public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: gdb-buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] [gdb/testsuite] Make pass message unique in gdb-index.exp for cc-with-dwz-m
Date: Mon, 30 Sep 2019 08:17:00 -0000	[thread overview]
Message-ID: <73d9a918c6188ce0f1ec32e42dda063ca16e0362@gdb-build> (raw)

*** TEST RESULTS FOR COMMIT 73d9a918c6188ce0f1ec32e42dda063ca16e0362 ***

commit 73d9a918c6188ce0f1ec32e42dda063ca16e0362
Author:     Tom de Vries <tdevries@suse.de>
AuthorDate: Sun Sep 29 23:51:50 2019 +0200
Commit:     Tom de Vries <tdevries@suse.de>
CommitDate: Sun Sep 29 23:51:50 2019 +0200

    [gdb/testsuite] Make pass message unique in gdb-index.exp for cc-with-dwz-m
    
    With cc-with-dwz-m, we get:
    ...
    PASS: gdb.dwarf2/gdb-index.exp: objcopy
    PASS: gdb.dwarf2/gdb-index.exp: objcopy
    ...
    
    Make the pass message unique by using with_test_prefix:
    ...
    PASS: gdb.dwarf2/gdb-index.exp: objcopy
    PASS: gdb.dwarf2/gdb-index.exp: modify dwz file: objcopy
    ...
    
    Tested on x86_64-linux.
    
    gdb/testsuite/ChangeLog:
    
    2019-09-29  Tom de Vries  <tdevries@suse.de>
    
            * gdb.dwarf2/gdb-index.exp: Use with_test_prefix for second objcopy.

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 87f34d6298..3dec824645 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2019-09-29  Tom de Vries  <tdevries@suse.de>
+
+	* gdb.dwarf2/gdb-index.exp: Use with_test_prefix for second objcopy.
+
 2019-09-27  Tom de Vries  <tdevries@suse.de>
 
 	* gdb.reverse/step-precsave.exp: Add missing $gdb_prompt in regexps.
diff --git a/gdb/testsuite/gdb.dwarf2/gdb-index.exp b/gdb/testsuite/gdb.dwarf2/gdb-index.exp
index 6fca3c6129..b14e07fa55 100644
--- a/gdb/testsuite/gdb.dwarf2/gdb-index.exp
+++ b/gdb/testsuite/gdb.dwarf2/gdb-index.exp
@@ -59,14 +59,16 @@ proc add_gdb_index { program } {
 	return ""
     }
 
-    if { [remote_file host exists ${dwz_index_file}] } {
-	# We're modifying $dwz in place, otherwise we'd have to update
-	# .gnu_debugaltlink in $program.
-	set args [join [list "--remove-section .gdb_index" \
-			    " --add-section .gdb_index=$dwz_index_file" \
-			    " --set-section-flags .gdb_index=readonly $dwz"]]
-	if {[run_on_host "objcopy" [gdb_find_objcopy] "$args"]} {
-	    return ""
+    with_test_prefix "modify dwz file" {
+	if { [remote_file host exists ${dwz_index_file}] } {
+	    # We're modifying $dwz in place, otherwise we'd have to update
+	    # .gnu_debugaltlink in $program.
+	    set args [join [list "--remove-section .gdb_index" \
+				" --add-section .gdb_index=$dwz_index_file" \
+				" --set-section-flags .gdb_index=readonly $dwz"]]
+	    if {[run_on_host "objcopy" [gdb_find_objcopy] "$args"]} {
+		return ""
+	    }
 	}
     }
 


             reply	other threads:[~2019-09-30  3:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-30  8:17 gdb-buildbot [this message]
2019-09-30  8:56 ` Failures on Ubuntu-Aarch64-m64, branch master gdb-buildbot
2019-09-30 16:26 ` Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, " gdb-buildbot
2019-10-04  4:34 ` *** COMPILATION FAILED *** Failures on Fedora-i686, branch master *** BREAKAGE *** gdb-buildbot
2019-10-04  4:38 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-m32, " gdb-buildbot
2019-10-04  5:01 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-m64, " gdb-buildbot
2019-10-04  5:07 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot
2019-10-04  5:33 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
2019-10-04  5:33 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot
2019-10-04  5:58 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-w64-mingw32, " gdb-buildbot
2019-10-04  9:29 ` Failures on Fedora-x86_64-native-gdbserver-m64, branch master gdb-buildbot
2019-10-04 10:32 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73d9a918c6188ce0f1ec32e42dda063ca16e0362@gdb-build \
    --to=gdb-buildbot@sergiodj.net \
    --cc=gdb-testers@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).