public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] exceptions.c:print_flush: Remove obsolete check
@ 2020-01-11  0:47 gdb-buildbot
  2020-01-11  0:47 ` Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, branch master gdb-buildbot
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: gdb-buildbot @ 2020-01-11  0:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 74375d182e992778ef8701278c02a742db6be77e ***

commit 74375d182e992778ef8701278c02a742db6be77e
Author:     Pedro Alves <palves@redhat.com>
AuthorDate: Fri Jan 10 20:05:43 2020 +0000
Commit:     Pedro Alves <palves@redhat.com>
CommitDate: Fri Jan 10 20:05:43 2020 +0000

    exceptions.c:print_flush: Remove obsolete check
    
    Commit 20f0d60db4fb ("Avoid crash when calling warning too early"),
    added a "current_top_target () != NULL" check to
    target_supports_terminal_ours, so this check in exceptions.c is now
    obsolete.
    
    gdb/ChangeLog:
    2020-01-10  Pedro Alves  <palves@redhat.com>
    
            * exceptions.c (print_flush): Remove current_top_target() check.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index af46e69fb3..1100e42141 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2020-01-10  Pedro Alves  <palves@redhat.com>
+
+	* exceptions.c (print_flush): Remove current_top_target() check.
+
 2020-01-10  Pedro Alves  <palves@redhat.com>
 
 	* remote.c (show_remote_exec_file): Show the current inferior's
diff --git a/gdb/exceptions.c b/gdb/exceptions.c
index 587988ac80..52cee4e2f6 100644
--- a/gdb/exceptions.c
+++ b/gdb/exceptions.c
@@ -39,11 +39,7 @@ print_flush (void)
     deprecated_error_begin_hook ();
 
   gdb::optional<target_terminal::scoped_restore_terminal_state> term_state;
-  /* While normally there's always something pushed on the target
-     stack, the NULL check is needed here because we can get here very
-     early during startup, before the target stack is first
-     initialized.  */
-  if (current_top_target () != NULL && target_supports_terminal_ours ())
+  if (target_supports_terminal_ours ())
     {
       term_state.emplace ();
       target_terminal::ours_for_output ();


^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-01-11 23:51 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-11  0:47 [binutils-gdb] exceptions.c:print_flush: Remove obsolete check gdb-buildbot
2020-01-11  0:47 ` Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, branch master gdb-buildbot
2020-01-11  1:03 ` Failures on Ubuntu-Aarch64-native-gdbserver-m64, " gdb-buildbot
2020-01-11 22:29 ` Failures on Fedora-i686, " gdb-buildbot
2020-01-11 22:51 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot
2020-01-11 23:11 ` Failures on Fedora-x86_64-m32, " gdb-buildbot
2020-01-11 23:29 ` Failures on Fedora-x86_64-m64, " gdb-buildbot
2020-01-11 23:51 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
2020-01-12  0:32 ` Failures on Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot
2020-01-12  0:47 ` Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).