public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: gdb-buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] [gdb/testsuite] Fix FAILs due to verbose in foll-fork.exp
Date: Fri, 20 Mar 2020 01:10:05 -0400	[thread overview]
Message-ID: <7462c383f9849aab40f156854a72f0a93305124a@gdb-build> (raw)

*** TEST RESULTS FOR COMMIT 7462c383f9849aab40f156854a72f0a93305124a ***

commit 7462c383f9849aab40f156854a72f0a93305124a
Author:     Tom de Vries <tdevries@suse.de>
AuthorDate: Wed Mar 11 14:58:59 2020 +0100
Commit:     Tom de Vries <tdevries@suse.de>
CommitDate: Wed Mar 11 14:58:59 2020 +0100

    [gdb/testsuite] Fix FAILs due to verbose in foll-fork.exp
    
    When running test-case gdb.base/foll-fork.exp, I see:
    ...
    (gdb) catch fork^M
    Catchpoint 2 (fork)^M
    Reading in symbols for ../sysdeps/x86/libc-start.c...^M
    (gdb) FAIL: gdb.base/foll-fork.exp: explicit child follow, set catch fork
    ...
    
    The problem is that the test regexp does not expect the "Reading in symbols"
    message:
    ...
        gdb_test "catch fork" "Catchpoint \[0-9\]* \\(fork\\)" \
            "explicit child follow, set catch fork"
    ...
    which is generated due to the verbose setting.
    
    Fix this by allowing the message in the regexp.
    
    Tested on x86_64-linux.
    
    gdb/testsuite/ChangeLog:
    
    2020-03-11  Tom de Vries  <tdevries@suse.de>
    
            * gdb.base/foll-fork.exp: Allow "Reading in symbols" messages.

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 8a7ca8ef3e..d7de4e7b78 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2020-03-11  Tom de Vries  <tdevries@suse.de>
+
+	* gdb.base/foll-fork.exp: Allow "Reading in symbols" messages.
+
 2020-03-11  Tom de Vries  <tdevries@suse.de>
 
 	* gdb.base/break-interp.exp: Limit verbose scope.
diff --git a/gdb/testsuite/gdb.base/foll-fork.exp b/gdb/testsuite/gdb.base/foll-fork.exp
index 27bbb44e53..788a6c950d 100644
--- a/gdb/testsuite/gdb.base/foll-fork.exp
+++ b/gdb/testsuite/gdb.base/foll-fork.exp
@@ -179,13 +179,17 @@ proc test_follow_fork { who detach cmd } {
     }
 }
 
+set reading_in_symbols_re {(?:\r\nReading in symbols for [^\r\n]*)?}
+
 proc catch_fork_child_follow {} {
     global gdb_prompt
     global srcfile
+    global reading_in_symbols_re
 
     set bp_after_fork [gdb_get_line_number "set breakpoint here"]
 
-    gdb_test "catch fork" "Catchpoint \[0-9\]* \\(fork\\)" \
+    gdb_test "catch fork" \
+	"Catchpoint \[0-9\]* \\(fork\\)$reading_in_symbols_re" \
 	"explicit child follow, set catch fork"
 
     # Verify that the catchpoint is mentioned in an "info breakpoints",
@@ -285,10 +289,12 @@ proc catch_fork_unpatch_child {} {
 proc tcatch_fork_parent_follow {} {
     global gdb_prompt
     global srcfile
+    global reading_in_symbols_re
 
     set bp_after_fork [gdb_get_line_number "set breakpoint here"]
 
-    gdb_test "catch fork" "Catchpoint \[0-9\]* \\(fork\\)" \
+    gdb_test "catch fork" \
+	"Catchpoint \[0-9\]* \\(fork\\)$reading_in_symbols_re" \
 	"explicit parent follow, set tcatch fork"
 
 # ??rehrauer: I don't yet know how to get the id of the tcatch


             reply	other threads:[~2020-03-20  5:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-20  5:10 gdb-buildbot [this message]
2020-03-20  5:10 ` Failures on Fedora-i686, branch master gdb-buildbot
2020-03-20  5:24 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot
2020-03-20  5:40 ` Failures on Fedora-x86_64-m32, " gdb-buildbot
2020-03-20  5:56 ` Failures on Fedora-x86_64-m64, " gdb-buildbot
2020-03-20  6:22 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
2020-03-20  6:53 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot
2020-03-22 13:24 ` Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot
2020-03-22 23:17 ` Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, " gdb-buildbot
2020-03-23  6:54 ` Failures on Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7462c383f9849aab40f156854a72f0a93305124a@gdb-build \
    --to=gdb-buildbot@sergiodj.net \
    --cc=gdb-testers@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).