[binutils-gdb] Use symbol_set_language to set a symbol's language

[gdb-buildbot@sergiodj.net]

*** TEST RESULTS FOR COMMIT 747cfc8c6bb23d40b3fa987f6c3df9d3a0d7b817 ***

commit 747cfc8c6bb23d40b3fa987f6c3df9d3a0d7b817
Author:     Christian Biesinger <cbiesinger@google.com>
AuthorDate: Sat Dec 14 15:47:22 2019 -0500
Commit:     Christian Biesinger <cbiesinger@google.com>
CommitDate: Mon Dec 16 00:39:50 2019 -0600

    Use symbol_set_language to set a symbol's language
    
    Instead of using SYMBOL_LANGUAGE (sym) = foo.
    
    Having only a single way to set a symbol's language is clearer and this
    is also a requirement for making set_language a member function.
    
    gdb/ChangeLog:
    
    2019-12-15  Christian Biesinger  <cbiesinger@google.com>
    
            * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
            set the language of sym.
            * language.c (language_alloc_type_symbol): Likewise.
    
    Change-Id: I85338ea2e4121155f2da222fe0aa6b7d3ffe26f7

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 1a452be175..8cc1c6b594 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2019-12-15  Christian Biesinger  <cbiesinger@google.com>
+
+	* ada-exp.y (write_ambiguous_var): Call symbol_set_language to
+	set the language of sym.
+	* language.c (language_alloc_type_symbol): Likewise.
+
 2019-12-14  Sergio Durigan Junior  <sergiodj@redhat.com>
 
 	https://bugzilla.redhat.com/show_bug.cgi?id=1728147
diff --git a/gdb/ada-exp.y b/gdb/ada-exp.y
index 00020cd067..6b1bdfa139 100644
--- a/gdb/ada-exp.y
+++ b/gdb/ada-exp.y
@@ -1106,7 +1106,7 @@ write_ambiguous_var (struct parser_state *par_state,
 
   SYMBOL_DOMAIN (sym) = UNDEF_DOMAIN;
   sym->set_linkage_name (obstack_strndup (&temp_parse_space, name, len));
-  SYMBOL_LANGUAGE (sym) = language_ada;
+  symbol_set_language (sym, language_ada, nullptr);
 
   write_exp_elt_opcode (par_state, OP_VAR_VALUE);
   write_exp_elt_block (par_state, block);
diff --git a/gdb/language.c b/gdb/language.c
index 6ab0ca323d..ed850350b1 100644
--- a/gdb/language.c
+++ b/gdb/language.c
@@ -1051,7 +1051,7 @@ language_alloc_type_symbol (enum language lang, struct type *type)
   symbol = new (gdbarch_obstack (gdbarch)) struct symbol ();
 
   symbol->name = TYPE_NAME (type);
-  symbol->language = lang;
+  symbol_set_language (symbol, lang, nullptr);
   symbol->owner.arch = gdbarch;
   SYMBOL_OBJFILE_OWNED (symbol) = 0;
   SYMBOL_TYPE (symbol) = type;