[binutils-gdb] Move declaration of overload_debug to header

[gdb-buildbot@sergiodj.net]

*** TEST RESULTS FOR COMMIT 79bb1944d63eb04f86cfacc62321c1062c292ac0 ***

commit 79bb1944d63eb04f86cfacc62321c1062c292ac0
Author:     Christian Biesinger <cbiesinger@google.com>
AuthorDate: Mon Oct 7 14:40:32 2019 -0500
Commit:     Christian Biesinger <cbiesinger@google.com>
CommitDate: Tue Oct 8 10:16:48 2019 -0500

    Move declaration of overload_debug to header
    
    gdb/ChangeLog:
    
    2019-10-08  Christian Biesinger  <cbiesinger@google.com>
    
            * gdbtypes.c (overload_debug): Move comment to header.
            * gdbtypes.h (overload_debug): Declare.
            * valops.c: Remove declaration of overload_debug, instead
            include gdbtypes.h.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 20a001e370..49b468d695 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2019-10-08  Christian Biesinger  <cbiesinger@google.com>
+
+	* gdbtypes.c (overload_debug): Move comment to header.
+	* gdbtypes.h (overload_debug): Declare.
+	* valops.c: Remove declaration of overload_debug, instead
+	include gdbtypes.h.
+
 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 
 	* language.c (show_language_command): Pass lang_frame_mismatch_warn
diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c
index afda89e43f..a2b81c8690 100644
--- a/gdb/gdbtypes.c
+++ b/gdb/gdbtypes.c
@@ -118,8 +118,7 @@ const struct floatformat *floatformats_ibm_long_double[BFD_ENDIAN_UNKNOWN] = {
 
 static bool opaque_type_resolution = true;
 
-/* A flag to enable printing of debugging information of C++
-   overloading.  */
+/* See gdbtypes.h.  */
 
 unsigned int overload_debug = 0;
 
diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h
index c62b8a31ba..d431cb6fdd 100644
--- a/gdb/gdbtypes.h
+++ b/gdb/gdbtypes.h
@@ -2146,4 +2146,9 @@ extern int type_not_allocated (const struct type *type);
 
 extern int type_not_associated (const struct type *type);
 
+/* A flag to enable printing of debugging information of C++
+   overloading.  */
+
+extern unsigned int overload_debug;
+
 #endif /* GDBTYPES_H */
diff --git a/gdb/valops.c b/gdb/valops.c
index fc7a4c5918..4c8efd90fb 100644
--- a/gdb/valops.c
+++ b/gdb/valops.c
@@ -39,9 +39,9 @@
 #include "observable.h"
 #include "objfiles.h"
 #include "extension.h"
+#include "gdbtypes.h"
 #include "gdbsupport/byte-vector.h"
 
-extern unsigned int overload_debug;
 /* Local functions.  */
 
 static int typecmp (int staticp, int varargs, int nargs,