public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: sergiodj@redhat.com
To: gdb-testers@sourceware.org
Subject: Test results for commit 7b582627bc42922de3b75792472f5223f1910277 on branch gdb-7.9-branch
Date: Fri, 20 Feb 2015 05:01:00 -0000	[thread overview]
Message-ID: <7b582627bc42922de3b75792472f5223f1910277@kwanyin> (raw)

*** TEST RESULTS FOR COMMIT 7b582627bc42922de3b75792472f5223f1910277 ***

Author: David Taylor <dtaylor@emc.com>
Branch: gdb-7.9-branch
Commit: 7b582627bc42922de3b75792472f5223f1910277

[gdb/ax] small "setv" fix and documentation's adjustment.
gdb/doc/agentexpr.texi documents the "setv" opcode as follow:

    @item @code{setv} (0x2d) @var{n}: @result{} @var{v}
    Set trace state variable number @var{n} to the value found on the top
    of the stack.  The stack is unchanged, so that the value is readily
    available if the assignment is part of a larger expression.  The
    handling of @var{n} is as described for @code{getv}.

The @item line is incorrect (and does not match with its
description), so this patch fixes it.

Additionally, in gdb/common/ax.def we find the line:

    DEFOP (setv, 2, 0, 0, 1, 0x2d)

>From the comment earlier in the file:

       Each line is of the form:

       DEFOP (name, size, data_size, consumed, produced, opcode)
[...]
       CONSUMED is the number of stack elements consumed.
       PRODUCED is the number of stack elements produced.

which is saying that nothing is consumed and one item is produced.
Both should be 0 or both should be 1.

This patch sets them both to 1, which seems better since if nothing
is on the stack an error will occur.

gdb/ChangeLog:

        * common/ax.def (setv): Fix consumed entry in setv DEFOP.

gdb/doc/ChangeLog:

        * agentexpr.texi (Bytecode Descriptions): Fix summary line for setv.

Tested on x86_64-linux.


             reply	other threads:[~2015-02-20  4:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-20  5:01 sergiodj [this message]
2015-02-20  5:21 ` Failures on Fedora-ppc64be-cc-with-index, " sergiodj
2015-02-20  5:43 ` Failures on Fedora-ppc64be-m64, " sergiodj
2015-02-20  6:09 ` Failures on Fedora-ppc64be-native-gdbserver-m64, " sergiodj
2015-02-20  6:45 ` Failures on Fedora-ppc64be-native-extended-gdbserver-m64, " sergiodj
2015-02-20  8:14 ` Failures on Fedora-ppc64le-native-extended-gdbserver-m64, " sergiodj
2015-02-20  8:22 ` Failures on Fedora-ppc64le-cc-with-index, " sergiodj
2015-02-20  9:25 ` Failures on Fedora-ppc64le-native-gdbserver-m64, " sergiodj
2015-02-20  9:28 ` Failures on Fedora-ppc64le-m64, " sergiodj
2015-02-20  9:32 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " sergiodj
2015-02-20  9:48 ` Failures on Fedora-x86_64-m64, " sergiodj
2015-02-20  9:50 ` Failures on Fedora-x86_64-native-gdbserver-m32, " sergiodj
2015-02-20 10:09 ` Failures on Debian-i686-native-extended-gdbserver, " sergiodj
2015-02-20 17:44 ` Failures on Debian-x86_64-native-gdbserver-m64, " sergiodj
2015-02-20 17:44 ` Failures on Debian-x86_64-m64, " sergiodj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b582627bc42922de3b75792472f5223f1910277@kwanyin \
    --to=sergiodj@redhat.com \
    --cc=gdb-testers@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).