Failures on Fedora-i686, branch master

Failures on Fedora-i686, branch master

[gdb-buildbot]

Buildername:
        Fedora-i686

Worker:
        fedora-x86-64-3

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/18/builds/3219

Author:
        Andrew Burgess <andrew.burgess@embecosm.com>

Commit tested:
        7c13f4e875fd5eeb0b7a1c301b4b513051822648

Subject of commit:
        gdb: Restore old annotations behaviour when printing frame info

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-i686/7c/7c13f4e875fd5eeb0b7a1c301b4b513051822648/

*** Diff to previous build ***
==============================================
PASS -> UNRESOLVED: gdb.base/shell.exp: -d spaces value missing
PASS -> UNRESOLVED: gdb.base/shell.exp: -d value missing
PASS -> UNRESOLVED: gdb.base/shell.exp: DELIM delimiter missing
PASS -> UNRESOLVED: gdb.base/shell.exp: SHELL_COMMAND missing
PASS -> UNRESOLVED: gdb.base/shell.exp: SHELL_COMMAND missing with delimiter
PASS -> UNRESOLVED: gdb.base/shell.exp: all missing
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "pipe "
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "pipe -"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "pipe -d "
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "pipe -d XXX maint set test-se"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "pipe -d XXX maint set"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "pipe -d main"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "pipe -d set maint set "
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "pipe -d set maint set"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "pipe maint set test-se"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "pipe print 1 | "
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "pipe"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "| "
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "| -"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "| -d "
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "| -d XXX maint set test-se"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "| -d XXX maint set"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "| -d main"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "| -d set maint set "
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "| -d set maint set"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "| maint set test-se"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "| print 1 | "
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "|"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "|-"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "|-d "
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "|-d XXX maint set test-se"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "|-d XXX maint set"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "|-d main"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "|-d set maint set "
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "|-d set maint set"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "|maint set test-se"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "|print 1 | "
PASS -> UNRESOLVED: gdb.base/shell.exp: delimiter missing due to missing space
PASS -> UNRESOLVED: gdb.base/shell.exp: pipe fail exitcode
PASS -> UNRESOLVED: gdb.base/shell.exp: pipe fail exitsignal
PASS -> UNRESOLVED: gdb.base/shell.exp: pipe interrupt exitcode
PASS -> UNRESOLVED: gdb.base/shell.exp: pipe interrupt exitsignal
PASS -> UNRESOLVED: gdb.base/shell.exp: pipe success exitcode
PASS -> UNRESOLVED: gdb.base/shell.exp: pipe success exitsignal
new UNRESOLVED: gdb.base/shell.exp: set max-completions 0
new UNRESOLVED: gdb.base/shell.exp: set max-completions 2
new UNRESOLVED: gdb.base/shell.exp: show editing
new UNRESOLVED: gdb.base/shell.exp: show max-completions
PASS -> UNRESOLVED: gdb.base/shell.exp: | delimiter missing
PASS -> UNRESOLVED: gdb.base/shell.exp: |p 123| exit 0
PASS -> UNRESOLVED: gdb.base/shell.exp: |p 123| exit 1
PASS -> UNRESOLVED: gdb.base/shell.exp: |p 123| kill -2 $$
PASS -> FAIL: gdb.gdb/selftest.exp: backtrace through signal handler
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/7c/7c13f4e875fd5eeb0b7a1c301b4b513051822648//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/7c/7c13f4e875fd5eeb0b7a1c301b4b513051822648//xfail.table.gz>

[binutils-gdb] gdb: Restore old annotations behaviour when printing frame info

[gdb-buildbot]

*** TEST RESULTS FOR COMMIT 7c13f4e875fd5eeb0b7a1c301b4b513051822648 ***

commit 7c13f4e875fd5eeb0b7a1c301b4b513051822648
Author:     Andrew Burgess <andrew.burgess@embecosm.com>
AuthorDate: Tue May 12 21:29:23 2020 +0100
Commit:     Andrew Burgess <andrew.burgess@embecosm.com>
CommitDate: Fri May 22 13:39:50 2020 +0100

    gdb: Restore old annotations behaviour when printing frame info
    
    This undoes most of the changes from these commits:
    
      commit ec8e2b6d3051f0b4b2a8eee9917898e95046c62f
      Date:   Fri Jun 14 23:43:00 2019 +0100
    
          gdb: Don't allow annotations to influence what else GDB prints
    
      commit 0d3abd8cc936360f8c46502135edd2e646473438
      Date:   Wed Jun 12 22:34:26 2019 +0100
    
          gdb: Remove an update of current_source_line and current_source_symtab
    
    as a result of the discussion here:
    
      https://sourceware.org/pipermail/gdb/2020-April/048468.html
    
    Having taken time to reflect on the discussion, and reading the
    documentation again I believe we should revert GDB's behaviour back to
    how it used to be.
    
    The original concern that triggered the initial patch was that when
    annotations were on the current source and line were updated (inside
    the annotation code), while when annotations are off this update would
    not occur.  This was incorrect, as printing the source with the call
    to print_source_lines does also update the current source and line.
    
    Further, the documentation here:
      https://sourceware.org/gdb/current/onlinedocs/gdb/Source-Annotations.html#Source-Annotations
    
    Clearly states:
    
      "The following annotation is used instead of displaying source code:
    
       ^Z^Zsource filename:line:character:middle:addr
    
       ..."
    
    So it is documented that the 'source' annotation is a replacement for,
    and not in addition to, actually printing the source lie.
    
    There are still a few issues that I can see, these are:
    
      1. In source.c:info_line_command, when annotations are on we call
      annotate_source_line, however, if annotations are off then there is
      no corresponding call to print the source line.  This means that a
      if a user uses 'info line ...' with annotations on, and then does a
      'list', they will get different results than if they had done this
      with annotations off.
    
      2. It bothers me that the call to annotate_source_line returns a
      boolean, and that this controls a call to print_source_line (in
      stack.c:print_frame_info).
    
      The reason for this is that the source line annotation will only
      print something if the file is found, and the line number is in
      range for the file.
    
      It seems to me like an annotation should always be printed, either
      one that identifies the file and line, or one that identifies the
      file and line GDB would like to access, but couldn't.
    
      I considered changing this, but in the end decided not too, if I
      extend the existing 'source' annotation to print something in all
      cases then I risk breaking existing UIs that rely on the file and
      line always being valid.  If I add a new annotation then this might
      also break existing UIs that rely on GDB itself printing the error
      from within print_source_line.
    
    Given that annotations is deprecated (as I understand it) mechanism
    for UIs to interact with GDB (in favour of MI) I figure we should just
    restore the old behaviour, and leave the mini-bugs in until someone
    actually complains.
    
    This isn't a straight revert of the two commits mentioned above.  I've
    left annotate_source_line instead of going back to the original
    identify_source_line, which lived in source.c, but was really
    annotation related.  The API for setting the current source and line
    has changed since the original patches, so I updated for that change
    too.  Finally I wrote the code in stack.c so that we avoided an extra
    level of indentation, which I felt made things easier to read.
    
    gdb/ChangeLog:
    
            * annotate.c (annotate_source_line): Update return type, add call
            to update current symtab and line.
            * annotate.h (annotate_source_line): Update return type, and
            extend header comment.
            * source.c (info_line_command): Check annotation_level before
            calling annotate_source_line.
            * stack.c (print_frame_info): If calling annotate_source_line
            returns true, then don't print any other source line information.
    
    gdb/testsuite/ChangeLog:
    
            * gdb.base/annota1.exp: Update expected results.
            * gdb.cp/annota2.exp: Update expected results, remove duplicate
            test name.
            * gdb.cp/annota3.exp: Update expected results.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 0b38daf3e3..31550d23b1 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,14 @@
+2020-05-22  Andrew Burgess  <andrew.burgess@embecosm.com>
+
+	* annotate.c (annotate_source_line): Update return type, add call
+	to update current symtab and line.
+	* annotate.h (annotate_source_line): Update return type, and
+	extend header comment.
+	* source.c (info_line_command): Check annotation_level before
+	calling annotate_source_line.
+	* stack.c (print_frame_info): If calling annotate_source_line
+	returns true, then don't print any other source line information.
+
 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
 
 	* lm32-tdep.c (lm32_register_reggroup_p): Fix condition.
diff --git a/gdb/annotate.c b/gdb/annotate.c
index 6daa0c5701..0a4e2f27ca 100644
--- a/gdb/annotate.c
+++ b/gdb/annotate.c
@@ -435,7 +435,7 @@ annotate_source (const char *filename, int line, int character, int mid,
 
 /* See annotate.h.  */
 
-void
+bool
 annotate_source_line (struct symtab *s, int line, int mid_statement,
 		      CORE_ADDR pc)
 {
@@ -443,16 +443,25 @@ annotate_source_line (struct symtab *s, int line, int mid_statement,
     {
       const std::vector<off_t> *offsets;
       if (!g_source_cache.get_line_charpos (s, &offsets))
-	return;
-
-      /* Don't index off the end of the line_charpos array.  */
+	return false;
       if (line > offsets->size ())
-	return;
+	return false;
 
       annotate_source (s->fullname, line, (int) (*offsets)[line - 1],
 		       mid_statement, SYMTAB_OBJFILE (s)->arch (),
 		       pc);
+
+      /* Update the current symtab and line.  */
+      symtab_and_line sal;
+      sal.pspace = SYMTAB_PSPACE (s);
+      sal.symtab = s;
+      sal.line = line;
+      set_current_source_symtab_and_line (sal);
+
+      return true;
     }
+
+  return false;
 }
 
 
diff --git a/gdb/annotate.h b/gdb/annotate.h
index b45d882dc0..70c2f28050 100644
--- a/gdb/annotate.h
+++ b/gdb/annotate.h
@@ -92,8 +92,20 @@ struct annotate_arg_emitter
    character position.
 
    MID_STATEMENT is nonzero if the PC is not at the beginning of that
-   line.  */
-extern void annotate_source_line (struct symtab *s, int line,
+   line.
+
+   The current symtab and line is updated to reflect S and LINE.
+
+   Return true if the annotation was printed and the current symtab and
+   line were updated, otherwise return false, which can happen if the
+   source file for S can't be found, or LINE is out of range.
+
+   This does leave GDB in the weird situation where, even when annotations
+   are on, we only sometimes print the annotation, and only sometimes
+   update the current symtab and line.  However, this particular annotation
+   has behaved this way for some time, and front ends that still use
+   annotations now depend on this behaviour.  */
+extern bool annotate_source_line (struct symtab *s, int line,
 				  int mid_statement, CORE_ADDR pc);
 
 extern void annotate_frame_begin (int, struct gdbarch *, CORE_ADDR);
diff --git a/gdb/source.c b/gdb/source.c
index b94c6af487..0c2b5a4f83 100644
--- a/gdb/source.c
+++ b/gdb/source.c
@@ -1532,7 +1532,7 @@ info_line_command (const char *arg, int from_tty)
 
 	  /* If this is the only line, show the source code.  If it could
 	     not find the file, don't do anything special.  */
-	  if (sals.size () == 1)
+	  if (annotation_level > 0 && sals.size () == 1)
 	    annotate_source_line (sal.symtab, sal.line, 0, start_pc);
 	}
       else
diff --git a/gdb/stack.c b/gdb/stack.c
index d7e2120541..265e764dc2 100644
--- a/gdb/stack.c
+++ b/gdb/stack.c
@@ -1126,10 +1126,25 @@ print_frame_info (const frame_print_options &fp_opts,
     {
       int mid_statement = ((print_what == SRC_LINE)
 			   && frame_show_address (frame, sal));
-      annotate_source_line (sal.symtab, sal.line, mid_statement,
-			    get_frame_pc (frame));
-
-      if (deprecated_print_frame_info_listing_hook)
+      if (annotation_level > 0
+	  && annotate_source_line (sal.symtab, sal.line, mid_statement,
+				   get_frame_pc (frame)))
+	{
+	  /* The call to ANNOTATE_SOURCE_LINE already printed the
+	     annotation for this source line, so we avoid the two cases
+	     below and do not print the actual source line.  The
+	     documentation for annotations makes it clear that the source
+	     line annotation is printed __instead__ of printing the source
+	     line, not as well as.
+
+	     However, if we fail to print the source line, which usually
+	     means either the source file is missing, or the requested
+	     line is out of range of the file, then we don't print the
+	     source annotation, and will pass through the "normal" print
+	     source line code below, the expectation is that this code
+	     will print an appropriate error.  */
+	}
+      else if (deprecated_print_frame_info_listing_hook)
 	deprecated_print_frame_info_listing_hook (sal.symtab, sal.line,
 						  sal.line + 1, 0);
       else
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 050a793ed0..2edec92f0d 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,10 @@
+2020-05-22  Andrew Burgess  <andrew.burgess@embecosm.com>
+
+	* gdb.base/annota1.exp: Update expected results.
+	* gdb.cp/annota2.exp: Update expected results, remove duplicate
+	test name.
+	* gdb.cp/annota3.exp: Update expected results.
+
 2020-05-20  Simon Marchi  <simon.marchi@efficios.com>
 
 	PR gdb/26016
diff --git a/gdb/testsuite/gdb.base/annota1.exp b/gdb/testsuite/gdb.base/annota1.exp
index 829d144cc2..2fdfd65ce8 100644
--- a/gdb/testsuite/gdb.base/annota1.exp
+++ b/gdb/testsuite/gdb.base/annota1.exp
@@ -268,10 +268,10 @@ if [target_info exists gdb,nosignals] {
     unsupported "backtrace @ signal handler"
 } else {
     gdb_test_multiple "signal SIGUSR1" "send SIGUSR1" {
-	-re "\r\n\032\032post-prompt\r\nContinuing with signal SIGUSR1.\r\n\r\n\032\032starting\(\(\r\n\r\n\032\032frames-invalid\)|\(\r\n\r\n\032\032breakpoints-invalid\)\)+\r\n\r\n\032\032breakpoint 2\r\n\r\nBreakpoint 2, \r\n\032\032frame-begin 0 $hex\r\n\r\n\032\032frame-function-name\r\nhandle_USR1\r\n\032\032frame-args\r\n \\(\r\n\032\032arg-begin\r\nsig\r\n\032\032arg-name-end\r\n=\r\n\032\032arg-value -\r\n$decimal\r\n\032\032arg-end\r\n\\)\r\n\032\032frame-source-begin\r\n at \r\n\032\032frame-source-file\r\n${escapedsrcfile}\r\n\032\032frame-source-file-end\r\n:\r\n\032\032frame-source-line\r\n.*\r\n\032\032frame-source-end\r\n\r\n\r\n\032\032source.*annota1.c:.*:.*:beg:$hex\r\n$decimal\[^\r\n\]+\r\n\r\n\032\032frame-end\r\n\r\n\032\032stopped\r\n$gdb_prompt$" {
+	-re "\r\n\032\032post-prompt\r\nContinuing with signal SIGUSR1.\r\n\r\n\032\032starting\(\(\r\n\r\n\032\032frames-invalid\)|\(\r\n\r\n\032\032breakpoints-invalid\)\)+\r\n\r\n\032\032breakpoint 2\r\n\r\nBreakpoint 2, \r\n\032\032frame-begin 0 $hex\r\n\r\n\032\032frame-function-name\r\nhandle_USR1\r\n\032\032frame-args\r\n \\(\r\n\032\032arg-begin\r\nsig\r\n\032\032arg-name-end\r\n=\r\n\032\032arg-value -\r\n$decimal\r\n\032\032arg-end\r\n\\)\r\n\032\032frame-source-begin\r\n at \r\n\032\032frame-source-file\r\n${escapedsrcfile}\r\n\032\032frame-source-file-end\r\n:\r\n\032\032frame-source-line\r\n.*\r\n\032\032frame-source-end\r\n\r\n\r\n\032\032source.*annota1.c:.*:.*:beg:$hex\r\n\r\n\032\032frame-end\r\n\r\n\032\032stopped\r\n$gdb_prompt$" {
 	    pass $gdb_test_name
 	}
-	-re "\r\n\032\032post-prompt\r\nContinuing with signal SIGUSR1.\r\n\r\n\032\032starting\(\(\r\n\r\n\032\032frames-invalid\)|\(\r\n\r\n\032\032breakpoints-invalid\)\)+\r\n\r\n\032\032breakpoint 2\r\n\r\nBreakpoint 2, \r\n\032\032frame-begin 0 $hex\r\n\r\n\032\032frame-function-name\r\nhandle_USR1\r\n\032\032frame-args\r\n \\(\r\n\032\032arg-begin\r\nsig\r\n\032\032arg-name-end\r\n=\r\n\032\032arg-value -\r\n$decimal\r\n\032\032arg-end\r\n\\)\r\n\032\032frame-source-begin\r\n at \r\n\032\032frame-source-file\r\n.*${srcfile}\r\n\032\032frame-source-file-end\r\n:\r\n\032\032frame-source-line\r\n.*\r\n\032\032frame-source-end\r\n\r\n\r\n\032\032source.*annota1.c:.*:.*:beg:$hex\r\n$decimal\[^\r\n\]+\r\n\r\n\032\032frame-end\r\n\r\n\032\032stopped\r\n$gdb_prompt$" {
+	-re "\r\n\032\032post-prompt\r\nContinuing with signal SIGUSR1.\r\n\r\n\032\032starting\(\(\r\n\r\n\032\032frames-invalid\)|\(\r\n\r\n\032\032breakpoints-invalid\)\)+\r\n\r\n\032\032breakpoint 2\r\n\r\nBreakpoint 2, \r\n\032\032frame-begin 0 $hex\r\n\r\n\032\032frame-function-name\r\nhandle_USR1\r\n\032\032frame-args\r\n \\(\r\n\032\032arg-begin\r\nsig\r\n\032\032arg-name-end\r\n=\r\n\032\032arg-value -\r\n$decimal\r\n\032\032arg-end\r\n\\)\r\n\032\032frame-source-begin\r\n at \r\n\032\032frame-source-file\r\n.*${srcfile}\r\n\032\032frame-source-file-end\r\n:\r\n\032\032frame-source-line\r\n.*\r\n\032\032frame-source-end\r\n\r\n\r\n\032\032source.*annota1.c:.*:.*:beg:$hex\r\n\r\n\032\032frame-end\r\n\r\n\032\032stopped\r\n$gdb_prompt$" {
 	    setup_xfail "*-*-*" 1270
 	    fail $gdb_test_name
 	}
diff --git a/gdb/testsuite/gdb.cp/annota2.exp b/gdb/testsuite/gdb.cp/annota2.exp
index 1b4f04bb44..2c36c5854e 100644
--- a/gdb/testsuite/gdb.cp/annota2.exp
+++ b/gdb/testsuite/gdb.cp/annota2.exp
@@ -73,9 +73,9 @@ gdb_expect {
     timeout	            { fail "annotation set at level 2 (timeout)" }
   }
 
-gdb_test_multiple "run" "run until main breakpoint" {
+gdb_test_multiple "run" "run until main breakpoint, first time" {
     -re "$main_line.*$gdb_prompt$" {
-	pass "run until main breakpoint"
+	pass $gdb_test_name
     }
 }
 
@@ -189,9 +189,9 @@ set main_line 22
 # run program up to breakpoint.
 #
 
-gdb_test_multiple "run" "run until main breakpoint" {
+gdb_test_multiple "run" "run until main breakpoint, second time" {
     -re "$main_line.*$gdb_prompt$"    {
-	pass "run until main breakpoint"
+	pass $gdb_test_name
     }
 }
 
@@ -243,7 +243,6 @@ set pat [multi_line "" \
 	     "" \
 	     "" \
 	     "\032\032source .*$srcfile.*beg:$hex" \
-	     "$decimal\[^\r\n\]+" \
 	     "" \
 	     "\032\032frame-end" \
 	     "" \
diff --git a/gdb/testsuite/gdb.cp/annota3.exp b/gdb/testsuite/gdb.cp/annota3.exp
index 6580f469e7..62d522083b 100644
--- a/gdb/testsuite/gdb.cp/annota3.exp
+++ b/gdb/testsuite/gdb.cp/annota3.exp
@@ -164,7 +164,7 @@ gdb_expect_list "set watch on a.x" "$gdb_prompt$" {
 # annotate-watchpoint
 #
 gdb_test_multiple "next" "watch triggered on a.x" {
-    -re "\r\n\032\032post-prompt\r\n\r\n\032\032starting\r\n\r\n\032\032watchpoint 3\r\n.*atchpoint 3: a.x\r\n\r\nOld value = 0\r\nNew value = 1\r\n\r\n(\032\032frame-begin 0 0x\[0-9a-z\]+\r\n|)main \\(\\) at .*$srcfile:$decimal\r\n\r\n\032\032source .*$srcfile.*beg:$hex\r\n$decimal\[^\r\n\]+\r\n\r\n\032\032stopped\r\n.*$gdb_prompt$" { 
+    -re "\r\n\032\032post-prompt\r\n\r\n\032\032starting\r\n\r\n\032\032watchpoint 3\r\n.*atchpoint 3: a.x\r\n\r\nOld value = 0\r\nNew value = 1\r\n\r\n(\032\032frame-begin 0 0x\[0-9a-z\]+\r\n|)main \\(\\) at .*$srcfile:$decimal\r\n\r\n\032\032source .*$srcfile.*beg:$hex\r\n\r\n\032\032stopped\r\n.*$gdb_prompt$" {
 	pass "watch triggered on a.x"
     }
 }

Failures on Fedora-x86_64-cc-with-index, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-cc-with-index

Worker:
        fedora-x86-64-4

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/20/builds/3168

Author:
        Andrew Burgess <andrew.burgess@embecosm.com>

Commit tested:
        7c13f4e875fd5eeb0b7a1c301b4b513051822648

Subject of commit:
        gdb: Restore old annotations behaviour when printing frame info

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/7c/7c13f4e875fd5eeb0b7a1c301b4b513051822648/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.multi/multi-arch-exec.exp: first_arch=1: selected_thread=1: follow_exec_mode=new: continue across exec that changes architecture
PASS -> FAIL: gdb.multi/multi-arch-exec.exp: first_arch=1: selected_thread=1: follow_exec_mode=same: continue across exec that changes architecture
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: first thread: print i02
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: first thread: print i12
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: first thread: print i22
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/7c/7c13f4e875fd5eeb0b7a1c301b4b513051822648//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/7c/7c13f4e875fd5eeb0b7a1c301b4b513051822648//xfail.table.gz>

Failures on Fedora-x86_64-m32, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-m32

Worker:
        fedora-x86-64-3

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/17/builds/3214

Author:
        Andrew Burgess <andrew.burgess@embecosm.com>

Commit tested:
        7c13f4e875fd5eeb0b7a1c301b4b513051822648

Subject of commit:
        gdb: Restore old annotations behaviour when printing frame info

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/7c/7c13f4e875fd5eeb0b7a1c301b4b513051822648/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/7c/7c13f4e875fd5eeb0b7a1c301b4b513051822648//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/7c/7c13f4e875fd5eeb0b7a1c301b4b513051822648//xfail.table.gz>

Failures on Fedora-x86_64-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-m64

Worker:
        fedora-x86-64-4

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/3/builds/3276

Author:
        Andrew Burgess <andrew.burgess@embecosm.com>

Commit tested:
        7c13f4e875fd5eeb0b7a1c301b4b513051822648

Subject of commit:
        gdb: Restore old annotations behaviour when printing frame info

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/7c/7c13f4e875fd5eeb0b7a1c301b4b513051822648/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.multi/multi-arch-exec.exp: first_arch=1: selected_thread=1: follow_exec_mode=new: continue across exec that changes architecture
PASS -> FAIL: gdb.threads/fork-plus-threads.exp: detach-on-fork=off: only inferior 1 left
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: outer_threads: outer stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: outer_threads: outer stop: print j
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: single_scope: first thread: print i3
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/7c/7c13f4e875fd5eeb0b7a1c301b4b513051822648//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/7c/7c13f4e875fd5eeb0b7a1c301b4b513051822648//xfail.table.gz>

Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-extended-gdbserver-m32

Worker:
        fedora-x86-64-3

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/4/builds/3110

Author:
        Andrew Burgess <andrew.burgess@embecosm.com>

Commit tested:
        7c13f4e875fd5eeb0b7a1c301b4b513051822648

Subject of commit:
        gdb: Restore old annotations behaviour when printing frame info

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/7c/7c13f4e875fd5eeb0b7a1c301b4b513051822648/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.fortran/vla-ptype.exp: ptype vla1
PASS -> FAIL: gdb.fortran/vla-value.exp: print member in non-allocated vla1
PASS -> FAIL: gdb.fortran/vla-value.exp: set member in non-allocated vla1
PASS -> FAIL: gdb.threads/interrupted-hand-call.exp: continue until exit
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/7c/7c13f4e875fd5eeb0b7a1c301b4b513051822648//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/7c/7c13f4e875fd5eeb0b7a1c301b4b513051822648//xfail.table.gz>

Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-extended-gdbserver-m64

Worker:
        fedora-x86-64-4

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/2/builds/3111

Author:
        Andrew Burgess <andrew.burgess@embecosm.com>

Commit tested:
        7c13f4e875fd5eeb0b7a1c301b4b513051822648

Subject of commit:
        gdb: Restore old annotations behaviour when printing frame info

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/7c/7c13f4e875fd5eeb0b7a1c301b4b513051822648/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=2: continue until exit
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=2: print re_run_var_2
PASS -> UNRESOLVED: gdb.threads/attach-into-signal.exp: threaded: attach
new FAIL: gdb.threads/attach-into-signal.exp: threaded: thread apply 2 print $_siginfo.si_signo
PASS -> FAIL: gdb.threads/interrupted-hand-call.exp: continue until exit
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 2nd thread: print k
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 2nd thread: print r
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 2nd thread: print z
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 4th stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 4th stop: print j
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: outer_threads: outer stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: outer_threads: outer stop: print j
PASS -> FAIL: gdb.threads/thread-unwindonsignal.exp: continue until exit
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/7c/7c13f4e875fd5eeb0b7a1c301b4b513051822648//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/7c/7c13f4e875fd5eeb0b7a1c301b4b513051822648//xfail.table.gz>

Failures on Fedora-x86_64-native-gdbserver-m32, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-gdbserver-m32

Worker:
        fedora-x86-64-3

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/24/builds/3123

Author:
        Andrew Burgess <andrew.burgess@embecosm.com>

Commit tested:
        7c13f4e875fd5eeb0b7a1c301b4b513051822648

Subject of commit:
        gdb: Restore old annotations behaviour when printing frame info

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/7c/7c13f4e875fd5eeb0b7a1c301b4b513051822648/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.threads/interrupted-hand-call.exp: continue until exit
PASS -> FAIL: gdb.trace/mi-tsv-changed.exp: create delete modify: tvariable $tvar3 modified
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/7c/7c13f4e875fd5eeb0b7a1c301b4b513051822648//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/7c/7c13f4e875fd5eeb0b7a1c301b4b513051822648//xfail.table.gz>

Failures on Fedora-x86_64-native-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-gdbserver-m64

Worker:
        fedora-x86-64-4

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/22/builds/3121

Author:
        Andrew Burgess <andrew.burgess@embecosm.com>

Commit tested:
        7c13f4e875fd5eeb0b7a1c301b4b513051822648

Subject of commit:
        gdb: Restore old annotations behaviour when printing frame info

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/7c/7c13f4e875fd5eeb0b7a1c301b4b513051822648/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: second thread: print i02
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: second thread: print i12
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: second thread: print i22
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
PASS -> FAIL: gdb.trace/mi-tsv-changed.exp: create delete modify: tvariable $tvar3 modified
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/7c/7c13f4e875fd5eeb0b7a1c301b4b513051822648//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/7c/7c13f4e875fd5eeb0b7a1c301b4b513051822648//xfail.table.gz>