public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Fix dwarf_expr_context method regressions
@ 2016-11-02 22:29 sergiodj+buildbot
  2016-11-02 22:46 ` *** COMPILATION FAILED *** Failures on Fedora-i686, branch master *** BREAKAGE *** sergiodj+buildbot
                   ` (10 more replies)
  0 siblings, 11 replies; 12+ messages in thread
From: sergiodj+buildbot @ 2016-11-02 22:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7d5697f9e27f79e1decc1215f33088cee9f7d863 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 7d5697f9e27f79e1decc1215f33088cee9f7d863

Fix dwarf_expr_context method regressions

This fixes some regressions found in the patch to convert
dwarf_expr_context to use methods.  Specifically:

* get_base_type could erroneously throw; this was rewritten to move
  the size checks into the only spot needing them.
* Previously the "symbol needs frame" implementation reused th
  "cfa" function for the get_frame_pc slot; this reimplements
  it under the correct name.
* Not enough members were saved and restored in one implementation
  of push_dwarf_reg_entry_value; this patch fixes this oversight
  and also takes the opportunity to remove an extraneous structure
  definition.

2016-11-02  Tom Tromey  <tom@tromey.com>

	* dwarf2loc.c (dwarf_evaluate_loc_desc::get_base_type): Rename
	from impl_get_base_type.  Rewrite.
	(struct dwarf_expr_baton): Remove.
	(dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value): Save and
	restore more fields.
	(symbol_needs_eval_context::get_frame_pc): New method.
	* dwarf2expr.h (dwarf_expr_context::get_base_type): Now public,
	virtual.
	(dwarf_expr_context::impl_get_base_type): Remove.
	* dwarf2expr.c (dwarf_expr_context::get_base_type): Remove.


^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2016-11-09 14:46 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-02 22:29 [binutils-gdb] Fix dwarf_expr_context method regressions sergiodj+buildbot
2016-11-02 22:46 ` *** COMPILATION FAILED *** Failures on Fedora-i686, branch master *** BREAKAGE *** sergiodj+buildbot
2016-11-02 22:47 ` *** COMPILATION FAILED *** Failures on Debian-i686-native-extended-gdbserver, " sergiodj+buildbot
2016-11-02 22:50 ` *** COMPILATION FAILED *** Failures on Debian-i686, " sergiodj+buildbot
2016-11-02 23:19 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2016-11-02 23:22 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, " sergiodj+buildbot
2016-11-03  2:36 ` Failures on Debian-s390x-native-extended-gdbserver-m64, " sergiodj+buildbot
2016-11-03 11:37 ` Failures on Fedora-s390x-m64, " sergiodj+buildbot
2016-11-03 11:37 ` Failures on Debian-s390x-native-gdbserver-m64, " sergiodj+buildbot
2016-11-08 21:58 ` Failures on Fedora-ppc64be-native-extended-gdbserver-m64, " sergiodj+buildbot
2016-11-09 13:19 ` Failures on Fedora-ppc64le-native-gdbserver-m64, " sergiodj+buildbot
2016-11-09 15:03 ` Failures on Fedora-ppc64le-native-extended-gdbserver-m64, " sergiodj+buildbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).