public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: gdb-buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] Remove stale references to Cell BE
Date: Fri, 03 Jan 2020 02:20:00 -0000	[thread overview]
Message-ID: <8133c7dce66f472a67705ad2779dc202a1a6311e@gdb-build> (raw)

*** TEST RESULTS FOR COMMIT 8133c7dce66f472a67705ad2779dc202a1a6311e ***

commit 8133c7dce66f472a67705ad2779dc202a1a6311e
Author:     Luis Machado <luis.machado@linaro.org>
AuthorDate: Mon Dec 30 15:47:10 2019 -0300
Commit:     Luis Machado <luis.machado@linaro.org>
CommitDate: Thu Jan 2 23:15:42 2020 -0300

    Remove stale references to Cell BE
    
    While reading some code i noticed we're still referencing Cell BE in a couple
    parts. This patch removes those.
    
    v2: Update comment in gdb/target.h.
    
    gdb/ChangeLog:
    
    2020-01-02  Luis Machado  <luis.machado@linaro.org>
    
            * proc-service.c (get_ps_regcache): Remove reference to obsolete
            Cell BE architecture.
            * target.h (struct target_ops) <thread_architecture>: Likewise.
    
    Change-Id: I7a9ccc603b00db22a6275bc5ab69e1417148cb72

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 5edb1c4dc3..c9999315d9 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2020-01-02  Luis Machado  <luis.machado@linaro.org>
+
+	* proc-service.c (get_ps_regcache): Remove reference to obsolete
+	Cell BE architecture.
+	* target.h (struct target_ops) <thread_architecture>: Likewise.
+
 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
 
 	* Makefile.in: Use INSTALL_PROGRAM_ENV.
diff --git a/gdb/proc-service.c b/gdb/proc-service.c
index 86b3f057db..7593ffe389 100644
--- a/gdb/proc-service.c
+++ b/gdb/proc-service.c
@@ -129,10 +129,7 @@ ps_pdwrite (struct ps_prochandle *ph, psaddr_t addr,
 /* Get a regcache for LWPID using its inferior's "main" architecture,
    which is the register set libthread_db expects to be using.  In
    multi-arch debugging scenarios, the thread's architecture may
-   differ from the inferior's "main" architecture.  E.g., in the Cell
-   combined debugger, if GDB happens to interrupt SPU code, the
-   thread's architecture is SPU, and the main architecture is
-   PowerPC.  */
+   differ from the inferior's "main" architecture.  */
 
 static struct regcache *
 get_ps_regcache (struct ps_prochandle *ph, lwpid_t lwpid)
diff --git a/gdb/target.h b/gdb/target.h
index 8e51516fea..a8e551ce69 100644
--- a/gdb/target.h
+++ b/gdb/target.h
@@ -878,11 +878,10 @@ struct target_ops
     /* Determine current architecture of thread PTID.
 
        The target is supposed to determine the architecture of the code where
-       the target is currently stopped at (on Cell, if a target is in spu_run,
-       to_thread_architecture would return SPU, otherwise PPC32 or PPC64).
-       This is architecture used to perform decr_pc_after_break adjustment,
-       and also determines the frame architecture of the innermost frame.
-       ptrace operations need to operate according to target_gdbarch ().  */
+       the target is currently stopped at.  The architecture information is
+       used to perform decr_pc_after_break adjustment, and also to determine
+       the frame architecture of the innermost frame.  ptrace operations need to
+       operate according to target_gdbarch ().  */
     virtual struct gdbarch *thread_architecture (ptid_t)
       TARGET_DEFAULT_RETURN (NULL);
 


             reply	other threads:[~2020-01-03  2:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-03  2:20 gdb-buildbot [this message]
2020-01-03  2:20 ` *** COMPILATION FAILED *** Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, branch master *** BREAKAGE *** gdb-buildbot
2020-01-03  2:23 ` *** COMPILATION FAILED *** Failures on Ubuntu-Aarch64-m64, " gdb-buildbot
2020-01-03  2:25 ` *** COMPILATION FAILED *** Failures on Ubuntu-Aarch64-native-gdbserver-m64, " gdb-buildbot
2020-01-03  2:46 ` Failures on Fedora-i686, branch master gdb-buildbot
2020-01-03  2:56 ` Failures on Fedora-x86_64-m64, " gdb-buildbot
2020-01-03  2:58 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
2020-01-03  3:06 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot
2020-01-03  3:19 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot
2020-01-03  3:30 ` Failures on Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot
2020-01-03  3:37 ` Failures on Fedora-x86_64-m32, " gdb-buildbot
2020-01-03  3:54 ` Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8133c7dce66f472a67705ad2779dc202a1a6311e@gdb-build \
    --to=gdb-buildbot@sergiodj.net \
    --cc=gdb-testers@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).