public inbox for gdb-testers@sourceware.org help / color / mirror / Atom feed
From: sergiodj+buildbot@sergiodj.net To: gdb-testers@sourceware.org Subject: [binutils-gdb] Fix scm-ports.exp regression Date: Mon, 15 Jan 2018 20:05:00 -0000 [thread overview] Message-ID: <86d6a90c58ee3fb924bcbca154f4e32347437e6c@gdb-build> (raw) *** TEST RESULTS FOR COMMIT 86d6a90c58ee3fb924bcbca154f4e32347437e6c *** Author: Tom Tromey <tom@tromey.com> Branch: master Commit: 86d6a90c58ee3fb924bcbca154f4e32347437e6c Fix scm-ports.exp regression In https://sourceware.org/ml/gdb-patches/2017-12/msg00215.html, Jan pointed out that the scalar printing patches caused a regression in scm-ports.exp on x86. What happens is that on x86, this: set sp_reg [get_integer_valueof "\$sp" 0] ... ends up setting sp_reg to a negative value, because get_integer_valueof uses "print/d": print /d $sp $1 = -11496 Then later the test suite does: gdb_test "guile (print (seek rw-mem-port (value->integer sp-reg) SEEK_SET))" \ "= $sp_reg" \ "seek to \$sp" ... expecting this value to be identical to the saved $sp_reg value. However it gets: guile (print (seek rw-mem-port (value->integer sp-reg) SEEK_SET)) = 4294955800 "print" is just a wrapper for guile's format: gdb_test_no_output "guile (define (print x) (format #t \"= ~A\" x) (newline))" The seek function returns a scm_t_off, the printing of which is handled by guile, not by gdb. Tested on x86-64 Fedora 26 using an ordinary build and also a -m32 build. 2018-01-15 Tom Tromey <tom@tromey.com> * gdb.guile/scm-ports.exp (test_mem_port_rw): Use get_valueof to compute sp_reg.
next reply other threads:[~2018-01-15 20:05 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-01-15 20:05 sergiodj+buildbot [this message] 2018-01-15 20:05 ` Failures on Fedora-x86_64-m64, branch master sergiodj+buildbot 2018-01-15 20:11 ` Failures on Fedora-x86_64-native-gdbserver-m32, " sergiodj+buildbot 2018-01-15 20:19 ` Failures on Fedora-x86_64-m32, " sergiodj+buildbot 2018-01-15 20:23 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " sergiodj+buildbot 2018-01-15 20:31 ` Failures on Fedora-x86_64-cc-with-index, " sergiodj+buildbot 2018-01-15 20:37 ` Failures on Fedora-x86_64-native-gdbserver-m64, " sergiodj+buildbot 2018-01-15 20:42 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " sergiodj+buildbot 2018-01-15 20:43 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, " sergiodj+buildbot 2018-01-15 20:44 ` Failures on Fedora-i686, " sergiodj+buildbot 2018-01-15 21:21 ` Failures on Ubuntu-AArch64-m64, " sergiodj+buildbot 2018-01-15 21:29 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, " sergiodj+buildbot 2018-01-15 22:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, " sergiodj+buildbot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=86d6a90c58ee3fb924bcbca154f4e32347437e6c@gdb-build \ --to=sergiodj+buildbot@sergiodj.net \ --cc=gdb-testers@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).