[binutils-gdb] Don't write to inferior_ptid in btrace_fetch

[binutils-gdb] Don't write to inferior_ptid in btrace_fetch

[gdb-buildbot]

*** TEST RESULTS FOR COMMIT 86e57d1b233e15f7d72b39dbd381a7e5a9d1b026 ***

commit 86e57d1b233e15f7d72b39dbd381a7e5a9d1b026
Author:     Pedro Alves <palves@redhat.com>
AuthorDate: Thu Jun 18 21:28:31 2020 +0100
Commit:     Pedro Alves <palves@redhat.com>
CommitDate: Thu Jun 18 23:14:15 2020 +0100

    Don't write to inferior_ptid in btrace_fetch
    
    gdb/ChangeLog:
    2020-06-18  Pedro Alves  <palves@redhat.com>
    
            * btrace.c (btrace_fetch): Use switch_to_thread instead of writing
            to inferior_ptid.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index c465a4d36d..2f3c1e5887 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2020-06-18  Pedro Alves  <palves@redhat.com>
+
+	* btrace.c (btrace_fetch): Use switch_to_thread instead of writing
+	to inferior_ptid.
+
 2020-06-18  Pedro Alves  <palves@redhat.com>
 
 	* bsd-kvm.c (bsd_kvm_target::close): Use switch_to_no_thread
diff --git a/gdb/btrace.c b/gdb/btrace.c
index d41e3c4f8f..2a0c61de76 100644
--- a/gdb/btrace.c
+++ b/gdb/btrace.c
@@ -1910,11 +1910,12 @@ btrace_fetch (struct thread_info *tp, const struct btrace_cpu *cpu)
   if (btinfo->replay != NULL)
     return;
 
-  /* With CLI usage, TP->PTID always equals INFERIOR_PTID here.  Now that we
-     can store a gdb.Record object in Python referring to a different thread
-     than the current one, temporarily set INFERIOR_PTID.  */
-  scoped_restore save_inferior_ptid = make_scoped_restore (&inferior_ptid);
-  inferior_ptid = tp->ptid;
+  /* With CLI usage, TP is always the current thread when we get here.
+     However, since we can also store a gdb.Record object in Python
+     referring to a different thread than the current one, we need to
+     temporarily set the current thread.  */
+  scoped_restore_current_thread restore_thread;
+  switch_to_thread (tp);
 
   /* We should not be called on running or exited threads.  */
   gdb_assert (can_access_registers_thread (tp));

Failures on Fedora-i686, branch master

[gdb-buildbot]

Buildername:
        Fedora-i686

Worker:
        fedora-x86-64-3

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/18/builds/3510

Author:
        Pedro Alves <palves@redhat.com>

Commit tested:
        86e57d1b233e15f7d72b39dbd381a7e5a9d1b026

Subject of commit:
        Don't write to inferior_ptid in btrace_fetch

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-i686/86/86e57d1b233e15f7d72b39dbd381a7e5a9d1b026/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.base/fork-running-state.exp: detach-on-fork=off: follow-fork=child: all-stop: schedule-multiple=on: continue &
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/86/86e57d1b233e15f7d72b39dbd381a7e5a9d1b026//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/86/86e57d1b233e15f7d72b39dbd381a7e5a9d1b026//xfail.table.gz>

Failures on Fedora-x86_64-cc-with-index, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-cc-with-index

Worker:
        fedora-x86-64-4

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/20/builds/3458

Author:
        Pedro Alves <palves@redhat.com>

Commit tested:
        86e57d1b233e15f7d72b39dbd381a7e5a9d1b026

Subject of commit:
        Don't write to inferior_ptid in btrace_fetch

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/86/86e57d1b233e15f7d72b39dbd381a7e5a9d1b026/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.cp/cpcompletion.exp: expression with namespace: cmd complete "p Test_NS"
PASS -> FAIL: gdb.cp/cpcompletion.exp: expression with namespace: tab complete "p Test_NS"
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: first thread: print i02
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: first thread: print i12
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: first thread: print i22
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: single_scope: first thread: print i3
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/86/86e57d1b233e15f7d72b39dbd381a7e5a9d1b026//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/86/86e57d1b233e15f7d72b39dbd381a7e5a9d1b026//xfail.table.gz>

Failures on Fedora-x86_64-m32, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-m32

Worker:
        fedora-x86-64-3

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/17/builds/3504

Author:
        Pedro Alves <palves@redhat.com>

Commit tested:
        86e57d1b233e15f7d72b39dbd381a7e5a9d1b026

Subject of commit:
        Don't write to inferior_ptid in btrace_fetch

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/86/86e57d1b233e15f7d72b39dbd381a7e5a9d1b026/

*** Diff to previous build ***
==============================================
UNRESOLVED -> FAIL: gdb.base/fork-running-state.exp: detach-on-fork=off: follow-fork=child: all-stop: schedule-multiple=off: only child marked running
UNRESOLVED -> FAIL: gdb.base/fork-running-state.exp: detach-on-fork=off: follow-fork=child: all-stop: schedule-multiple=on: info threads
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/86/86e57d1b233e15f7d72b39dbd381a7e5a9d1b026//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/86/86e57d1b233e15f7d72b39dbd381a7e5a9d1b026//xfail.table.gz>

Failures on Fedora-x86_64-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-m64

Worker:
        fedora-x86-64-4

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/3/builds/3567

Author:
        Pedro Alves <palves@redhat.com>

Commit tested:
        86e57d1b233e15f7d72b39dbd381a7e5a9d1b026

Subject of commit:
        Don't write to inferior_ptid in btrace_fetch

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/86/86e57d1b233e15f7d72b39dbd381a7e5a9d1b026/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 2nd stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 2nd stop: print j
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: single_scope: first thread: print i3
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/86/86e57d1b233e15f7d72b39dbd381a7e5a9d1b026//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/86/86e57d1b233e15f7d72b39dbd381a7e5a9d1b026//xfail.table.gz>

Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-extended-gdbserver-m32

Worker:
        fedora-x86-64-3

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/4/builds/3400

Author:
        Pedro Alves <palves@redhat.com>

Commit tested:
        86e57d1b233e15f7d72b39dbd381a7e5a9d1b026

Subject of commit:
        Don't write to inferior_ptid in btrace_fetch

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/86/86e57d1b233e15f7d72b39dbd381a7e5a9d1b026/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=2: continue until exit
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=2: print re_run_var_1
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/86/86e57d1b233e15f7d72b39dbd381a7e5a9d1b026//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/86/86e57d1b233e15f7d72b39dbd381a7e5a9d1b026//xfail.table.gz>

Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-extended-gdbserver-m64

Worker:
        fedora-x86-64-4

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/2/builds/3401

Author:
        Pedro Alves <palves@redhat.com>

Commit tested:
        86e57d1b233e15f7d72b39dbd381a7e5a9d1b026

Subject of commit:
        Don't write to inferior_ptid in btrace_fetch

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/86/86e57d1b233e15f7d72b39dbd381a7e5a9d1b026/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=1: continue until exit
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=1: print re_run_var_1
new UNRESOLVED: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=2: delete all breakpoints in delete_breakpoints
PASS -> UNRESOLVED: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=2: setting breakpoint at all_started
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=1: continue until exit
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=1: print re_run_var_2
new UNRESOLVED: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=2: delete all breakpoints in delete_breakpoints
PASS -> UNRESOLVED: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=2: setting breakpoint at all_started
PASS -> UNRESOLVED: gdb.threads/attach-into-signal.exp: threaded: attach
new FAIL: gdb.threads/attach-into-signal.exp: threaded: thread apply 2 print $_siginfo.si_signo
UNRESOLVED -> FAIL: gdb.threads/fork-plus-threads.exp: detach-on-fork=off: inferior 1 exited
new FAIL: gdb.threads/fork-plus-threads.exp: detach-on-fork=off: only inferior 1 left
PASS -> FAIL: gdb.threads/interrupted-hand-call.exp: continue until exit
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 1st stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 1st stop: print j
PASS -> FAIL: gdb.threads/thread-unwindonsignal.exp: continue until exit
PASS -> FAIL: gdb.trace/tspeed.exp: advance through tracing
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/86/86e57d1b233e15f7d72b39dbd381a7e5a9d1b026//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/86/86e57d1b233e15f7d72b39dbd381a7e5a9d1b026//xfail.table.gz>

Failures on Fedora-x86_64-native-gdbserver-m32, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-gdbserver-m32

Worker:
        fedora-x86-64-3

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/24/builds/3413

Author:
        Pedro Alves <palves@redhat.com>

Commit tested:
        86e57d1b233e15f7d72b39dbd381a7e5a9d1b026

Subject of commit:
        Don't write to inferior_ptid in btrace_fetch

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/86/86e57d1b233e15f7d72b39dbd381a7e5a9d1b026/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/86/86e57d1b233e15f7d72b39dbd381a7e5a9d1b026//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/86/86e57d1b233e15f7d72b39dbd381a7e5a9d1b026//xfail.table.gz>

Failures on Fedora-x86_64-native-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-gdbserver-m64

Worker:
        fedora-x86-64-4

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/22/builds/3412

Author:
        Pedro Alves <palves@redhat.com>

Commit tested:
        86e57d1b233e15f7d72b39dbd381a7e5a9d1b026

Subject of commit:
        Don't write to inferior_ptid in btrace_fetch

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/86/86e57d1b233e15f7d72b39dbd381a7e5a9d1b026/

*** Diff to previous build ***
==============================================
new FAIL: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=2: continue until exit
new FAIL: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=2: print re_run_var_1
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: first thread: print i02
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: first thread: print i12
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: first thread: print i22
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 2nd thread: print k
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 2nd thread: print r
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 2nd thread: print z
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 1st stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 1st stop: print j
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
PASS -> FAIL: gdb.trace/ftrace.exp: advance through tracing
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/86/86e57d1b233e15f7d72b39dbd381a7e5a9d1b026//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/86/86e57d1b233e15f7d72b39dbd381a7e5a9d1b026//xfail.table.gz>