[binutils-gdb] Add a string_view version of startswith

[binutils-gdb] Add a string_view version of startswith

[gdb-buildbot]

*** TEST RESULTS FOR COMMIT 87f34879e5339be458505ca85f70cff346295140 ***

commit 87f34879e5339be458505ca85f70cff346295140
Author:     Christian Biesinger <cbiesinger@google.com>
AuthorDate: Tue Oct 1 13:41:58 2019 -0500
Commit:     Christian Biesinger <cbiesinger@google.com>
CommitDate: Mon Oct 28 12:20:13 2019 -0500

    Add a string_view version of startswith
    
    Makes sure that the string is longer than prefix, so that strncmp will
    do the right thing even if the string is not null-terminated.
    
    For use in my string_view conversion patch:
    https://sourceware.org/ml/gdb-patches/2019-10/msg00030.html
    https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/125
    
    gdb/ChangeLog:
    
    2019-10-28  Christian Biesinger  <cbiesinger@google.com>
    
            * gdbsupport/common-utils.h (startswith): Add an overloaded version
            that takes gdb::string_view arguments.
    
    Change-Id: I5389855de2fd70e7065a789a79374b0693651b71

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index edf7c34f43..7059623788 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2019-10-28  Christian Biesinger  <cbiesinger@google.com>
+
+	* gdbsupport/common-utils.h (startswith): Add an overloaded version
+	that takes gdb::string_view arguments.
+
 2019-10-26  Tom de Vries  <tdevries@suse.de>
 
 	* aarch64-linux-tdep.c: Fix typos in comments.
diff --git a/gdb/gdbsupport/common-utils.h b/gdb/gdbsupport/common-utils.h
index e96fc21e3f..23bf354a8b 100644
--- a/gdb/gdbsupport/common-utils.h
+++ b/gdb/gdbsupport/common-utils.h
@@ -43,6 +43,8 @@
 #endif
 #endif
 
+#include "gdb_string_view.h"
+
 /* xmalloc(), xrealloc() and xcalloc() have already been declared in
    "libiberty.h". */
 
@@ -118,6 +120,16 @@ startswith (const char *string, const char *pattern)
   return strncmp (string, pattern, strlen (pattern)) == 0;
 }
 
+/* Version of startswith that takes string_view arguments.  See comment
+   above.  */
+
+static inline bool
+startswith (gdb::string_view string, gdb::string_view pattern)
+{
+  return (string.length () >= pattern.length ()
+	  && strncmp (string.data (), pattern.data (), pattern.length ()) == 0);
+}
+
 ULONGEST strtoulst (const char *num, const char **trailer, int base);
 
 /* Skip leading whitespace characters in INP, returning an updated

Failures on Ubuntu-Aarch64-native-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Ubuntu-Aarch64-native-gdbserver-m64

Worker:
        ubuntu-aarch64

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/19/builds/1045

Author:
        Christian Biesinger <cbiesinger@google.com>

Commit tested:
        87f34879e5339be458505ca85f70cff346295140

Subject of commit:
        Add a string_view version of startswith

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-gdbserver-m64/87/87f34879e5339be458505ca85f70cff346295140/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-gdbserver-m64/87/87f34879e5339be458505ca85f70cff346295140//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-gdbserver-m64/87/87f34879e5339be458505ca85f70cff346295140//xfail.table.gz>

Failures on Fedora-i686, branch master

[gdb-buildbot]

Buildername:
        Fedora-i686

Worker:
        fedora-x86-64-1

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/18/builds/1190

Author:
        Christian Biesinger <cbiesinger@google.com>

Commit tested:
        87f34879e5339be458505ca85f70cff346295140

Subject of commit:
        Add a string_view version of startswith

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-i686/87/87f34879e5339be458505ca85f70cff346295140/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/87/87f34879e5339be458505ca85f70cff346295140//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/87/87f34879e5339be458505ca85f70cff346295140//xfail.table.gz>

Failures on Fedora-x86_64-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-m64

Worker:
        fedora-x86-64-2

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/3/builds/1240

Author:
        Christian Biesinger <cbiesinger@google.com>

Commit tested:
        87f34879e5339be458505ca85f70cff346295140

Subject of commit:
        Add a string_view version of startswith

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/87/87f34879e5339be458505ca85f70cff346295140/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/87/87f34879e5339be458505ca85f70cff346295140//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/87/87f34879e5339be458505ca85f70cff346295140//xfail.table.gz>

Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-extended-gdbserver-m32

Worker:
        fedora-x86-64-1

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/4/builds/1184

Author:
        Christian Biesinger <cbiesinger@google.com>

Commit tested:
        87f34879e5339be458505ca85f70cff346295140

Subject of commit:
        Add a string_view version of startswith

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/87/87f34879e5339be458505ca85f70cff346295140/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.linespec/explicit.exp: complete non-unique label name: cmd complete "b -function myfunction -label "
PASS -> FAIL: gdb.linespec/explicit.exp: complete non-unique label name: tab complete "b -function myfunction -label "
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/87/87f34879e5339be458505ca85f70cff346295140//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/87/87f34879e5339be458505ca85f70cff346295140//xfail.table.gz>

Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-extended-gdbserver-m64

Worker:
        fedora-x86-64-2

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/2/builds/1186

Author:
        Christian Biesinger <cbiesinger@google.com>

Commit tested:
        87f34879e5339be458505ca85f70cff346295140

Subject of commit:
        Add a string_view version of startswith

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/87/87f34879e5339be458505ca85f70cff346295140/

*** Diff to previous build ***
==============================================
PASS -> UNRESOLVED: gdb.threads/attach-into-signal.exp: threaded: attach
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/87/87f34879e5339be458505ca85f70cff346295140//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/87/87f34879e5339be458505ca85f70cff346295140//xfail.table.gz>