public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: gdb-buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] Update comments about removed function
Date: Fri, 24 Jan 2020 12:18:00 -0000 [thread overview]
Message-ID: <89203d40625ea3c835a19c8a4aff8bdeff479748@gdb-build> (raw)
*** TEST RESULTS FOR COMMIT 89203d40625ea3c835a19c8a4aff8bdeff479748 ***
commit 89203d40625ea3c835a19c8a4aff8bdeff479748
Author: Christian Biesinger <cbiesinger@google.com>
AuthorDate: Thu Jan 23 15:52:05 2020 +0100
Commit: Christian Biesinger <cbiesinger@google.com>
CommitDate: Fri Jan 24 12:34:48 2020 +0100
Update comments about removed function
regset_from_core_section doesn't exist anymore; it has been replaced
by the iterate_over_regset_sections gdbarch method. Update comments
accordingly to not confuse readers.
gdb/ChangeLog:
2020-01-24 Christian Biesinger <cbiesinger@google.com>
* aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
Update comment.
* aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
Likewise.
* arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
* gdbcore.h (deprecated_add_core_fns): Update comment to point to
the correct replacement (iterate_over_regset_sections).
* riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
Update comment.
Change-Id: I5eea4d18e15edae5d6dfd5d0d6241e5b2ae40daa
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index ca2e49eb50..964a01d6f1 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,15 @@
+2020-01-24 Christian Biesinger <cbiesinger@google.com>
+
+ * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
+ Update comment.
+ * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
+ Likewise.
+ * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
+ * gdbcore.h (deprecated_add_core_fns): Update comment to point to
+ the correct replacement (iterate_over_regset_sections).
+ * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
+ Update comment.
+
2020-01-24 Graham Markall <graham.markall@embecosm.com>
PR gdb/23718
diff --git a/gdb/aarch64-fbsd-tdep.c b/gdb/aarch64-fbsd-tdep.c
index b923c5c474..0d41198ecd 100644
--- a/gdb/aarch64-fbsd-tdep.c
+++ b/gdb/aarch64-fbsd-tdep.c
@@ -134,7 +134,7 @@ const struct regset aarch64_fbsd_fpregset =
regcache_supply_regset, regcache_collect_regset
};
-/* Implement the "regset_from_core_section" gdbarch method. */
+/* Implement the "iterate_over_regset_sections" gdbarch method. */
static void
aarch64_fbsd_iterate_over_regset_sections (struct gdbarch *gdbarch,
diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
index 67046c4271..34ba0d87ba 100644
--- a/gdb/aarch64-linux-tdep.c
+++ b/gdb/aarch64-linux-tdep.c
@@ -582,7 +582,7 @@ aarch64_linux_collect_sve_regset (const struct regset *regset,
size - SVE_HEADER_SIZE);
}
-/* Implement the "regset_from_core_section" gdbarch method. */
+/* Implement the "iterate_over_regset_sections" gdbarch method. */
static void
aarch64_linux_iterate_over_regset_sections (struct gdbarch *gdbarch,
diff --git a/gdb/arm-fbsd-tdep.c b/gdb/arm-fbsd-tdep.c
index 417a805e67..de94d06c70 100644
--- a/gdb/arm-fbsd-tdep.c
+++ b/gdb/arm-fbsd-tdep.c
@@ -150,7 +150,7 @@ const struct regset arm_fbsd_vfpregset =
regcache_supply_regset, regcache_collect_regset
};
-/* Implement the "regset_from_core_section" gdbarch method. */
+/* Implement the "iterate_over_regset_sections" gdbarch method. */
static void
arm_fbsd_iterate_over_regset_sections (struct gdbarch *gdbarch,
diff --git a/gdb/gdbcore.h b/gdb/gdbcore.h
index 66e81dfe95..0a69d36ad7 100644
--- a/gdb/gdbcore.h
+++ b/gdb/gdbcore.h
@@ -269,8 +269,7 @@ private:
std::string m_storage;
};
-/* NOTE: cagney/2004-04-05: Replaced by "regset.h" and
- regset_from_core_section(). */
+/* Replaced by the "iterate_over_regset_sections" gdbarch method. */
extern void deprecated_add_core_fns (struct core_fns *cf);
extern int default_core_sniffer (struct core_fns *cf, bfd * abfd);
extern int default_check_format (bfd * abfd);
diff --git a/gdb/riscv-fbsd-tdep.c b/gdb/riscv-fbsd-tdep.c
index 8a9295904d..6e0eb2bb78 100644
--- a/gdb/riscv-fbsd-tdep.c
+++ b/gdb/riscv-fbsd-tdep.c
@@ -81,7 +81,7 @@ const struct regset riscv_fbsd_fpregset =
regcache_supply_regset, regcache_collect_regset
};
-/* Implement the "regset_from_core_section" gdbarch method. */
+/* Implement the "iterate_over_regset_sections" gdbarch method. */
static void
riscv_fbsd_iterate_over_regset_sections (struct gdbarch *gdbarch,
next reply other threads:[~2020-01-24 12:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 12:18 gdb-buildbot [this message]
2020-01-24 12:25 ` Failures on Fedora-x86_64-m64, branch master gdb-buildbot
2020-01-24 12:38 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
2020-01-24 12:47 ` Failures on Ubuntu-Aarch64-native-gdbserver-m64, " gdb-buildbot
2020-01-24 13:17 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot
2020-01-24 13:17 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot
2020-01-24 13:32 ` Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89203d40625ea3c835a19c8a4aff8bdeff479748@gdb-build \
--to=gdb-buildbot@sergiodj.net \
--cc=gdb-testers@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).