public inbox for gdb-testers@sourceware.org help / color / mirror / Atom feed
From: sergiodj+buildbot@sergiodj.net To: gdb-testers@sourceware.org Subject: [binutils-gdb] PR24355, segmentation fault in function called from ppc_finish_symbols Date: Mon, 18 Mar 2019 12:30:00 -0000 [thread overview] Message-ID: <8cd1fe1bf525b59f4d07e5790d11d49eee7e8494@gdb-build> (raw) *** TEST RESULTS FOR COMMIT 8cd1fe1bf525b59f4d07e5790d11d49eee7e8494 *** Author: Alan Modra <amodra@gmail.com> Branch: master Commit: 8cd1fe1bf525b59f4d07e5790d11d49eee7e8494 PR24355, segmentation fault in function called from ppc_finish_symbols This one looks to be a bug going back to 2009, git commit e054468f6c "STT_GNU_IFUNC support for PowerPC". That bug was carried over with git commit 49c09209d0 "Rearrange PLT reloc output on powerpc". If the refcount for an ifunc local sym plt entry was zero, ppc_elf_size_dynamic_sections would correctly set plt.offset to -1 but leave glink_offset uninitialized. That leads to occasional segfaults (which can be made solid with MALLOC_PERTURB_=1 when using glibc). So, guard the write_glink_stub call with plt.offset != -1. Also, remove the totally ineffective attempt at writing multiple-use glink stubs only once. PR 24355 * elf32-ppc.c (ppc_finish_symbols): Don't call write_glink_stub for local iplt syms with ent->plt.offset == -1. Remove ineffective attempt at writing glink stubs only once.
next reply other threads:[~2019-03-18 12:30 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-18 12:30 sergiodj+buildbot [this message] 2019-03-18 12:30 ` Failures on RHEL-s390x-m64, branch master sergiodj+buildbot 2019-03-18 12:55 ` Failures on Debian-s390x-native-extended-gdbserver-m64, " sergiodj+buildbot 2019-03-18 13:31 ` Failures on Debian-s390x-native-gdbserver-m64, " sergiodj+buildbot 2019-03-18 13:53 ` Failures on Debian-s390x-m64, " sergiodj+buildbot 2019-03-23 13:51 ` Failures on Fedora-i686, " sergiodj+buildbot 2019-03-23 14:04 ` Failures on Fedora-x86_64-cc-with-index, " sergiodj+buildbot 2019-03-23 15:14 ` Failures on Fedora-x86_64-native-gdbserver-m64, " sergiodj+buildbot 2019-03-23 15:33 ` Failures on Fedora-x86_64-m64, " sergiodj+buildbot 2019-03-23 15:40 ` Failures on Fedora-x86_64-m32, " sergiodj+buildbot 2019-03-24 23:50 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " sergiodj+buildbot 2019-03-25 6:49 ` Failures on Fedora-x86_64-native-gdbserver-m32, " sergiodj+buildbot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8cd1fe1bf525b59f4d07e5790d11d49eee7e8494@gdb-build \ --to=sergiodj+buildbot@sergiodj.net \ --cc=gdb-testers@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).