From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39638 invoked by alias); 1 Oct 2019 18:10:36 -0000 Mailing-List: contact gdb-testers-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-testers-owner@sourceware.org Received: (qmail 39629 invoked by uid 89); 1 Oct 2019 18:10:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: kwanyin.sergiodj.net Received: from kwanyin.sergiodj.net (HELO kwanyin.sergiodj.net) (158.69.185.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 Oct 2019 18:10:34 +0000 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [binutils-gdb] [PATCH v2 2/4] DWARF 5 support: Handle DW_FORM_strx From: gdb-buildbot@sergiodj.net To: gdb-testers@sourceware.org Message-Id: <8fe0f950f4c0438e684a532add46dc99ee32165c@gdb-build> Date: Tue, 01 Oct 2019 18:10:00 -0000 X-SW-Source: 2019-q4/txt/msg00014.txt.bz2 *** TEST RESULTS FOR COMMIT 8fe0f950f4c0438e684a532add46dc99ee32165c *** commit 8fe0f950f4c0438e684a532add46dc99ee32165c Author: Ali Tamur AuthorDate: Mon Aug 26 18:40:18 2019 -0700 Commit: Ali Tamur CommitDate: Mon Sep 30 18:00:41 2019 -0700 [PATCH v2 2/4] DWARF 5 support: Handle DW_FORM_strx * Handle DW_FORM_strx forms everywhere. Tested with CC=/usr/bin/gcc (version 8.3.0) against master branch (also with -gsplit-dwarf and -gdwarf-4 flags) and there was no increase in the set of tests that fails. This is part of an effort to support DWARF 5 in gdb. gdb/ChangeLog: * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms. (dwarf2_string_attr): Likewise. diff --git a/gdb/ChangeLog b/gdb/ChangeLog index a096cae2da..1be7f4b2f6 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2019-09-30 Ali Tamur + + * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms. + (dwarf2_string_attr): Likewise. + 2019-09-30 Ali Tamur * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL. diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index 0f4f36682c..53e7393a7c 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -9336,6 +9336,7 @@ skip_one_die (const struct die_reader_specs *reader, const gdb_byte *info_ptr, case DW_FORM_data1: case DW_FORM_ref1: case DW_FORM_flag: + case DW_FORM_strx1: info_ptr += 1; break; case DW_FORM_flag_present: @@ -9343,10 +9344,15 @@ skip_one_die (const struct die_reader_specs *reader, const gdb_byte *info_ptr, break; case DW_FORM_data2: case DW_FORM_ref2: + case DW_FORM_strx2: info_ptr += 2; break; + case DW_FORM_strx3: + info_ptr += 3; + break; case DW_FORM_data4: case DW_FORM_ref4: + case DW_FORM_strx4: info_ptr += 4; break; case DW_FORM_data8: @@ -20168,6 +20174,10 @@ dwarf2_string_attr (struct die_info *die, unsigned int name, struct dwarf2_cu *c if (attr->form == DW_FORM_strp || attr->form == DW_FORM_line_strp || attr->form == DW_FORM_string || attr->form == DW_FORM_strx + || attr->form == DW_FORM_strx1 + || attr->form == DW_FORM_strx2 + || attr->form == DW_FORM_strx3 + || attr->form == DW_FORM_strx4 || attr->form == DW_FORM_GNU_str_index || attr->form == DW_FORM_GNU_strp_alt) str = DW_STRING (attr);