public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb/gdb-7.11-branch] Fix PR gdb/19676: Internal error in linux-thread.db.c if /proc not mounted
@ 2016-03-15 17:34 sergiodj+buildbot
  2016-03-15 17:34 ` Failures on RHEL-s390x-m64, branch gdb-7.11-branch sergiodj+buildbot
                   ` (14 more replies)
  0 siblings, 15 replies; 16+ messages in thread
From: sergiodj+buildbot @ 2016-03-15 17:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9312893c8d63934f7855451c6a78503e69a47453 ***

Author: Pedro Alves <palves@redhat.com>
Branch: gdb-7.11-branch
Commit: 9312893c8d63934f7855451c6a78503e69a47453

Fix PR gdb/19676: Internal error in linux-thread.db.c if /proc not mounted

If /proc is not mounted, GDB fails an assertion in find_new_threads_once:

 Continuing.
 .../src/gdb/linux-thread-db.c:1249: internal-error: find_new_threads_once: Assertion `!target_has_execution' failed.
 A problem internal to GDB has been detected,
 further debugging may prove unreliable.
 Quit this debugging session? (y or n)

That was supposed to catch misuses of td_ta_thr_iter, which is unsafe
for live debugging.  However, if /proc is not mounted, we still
fallback to using it.

I didn't bother with a warning, because GDB already prints several
others related to failing to open /proc files.

gdb/ChangeLog:
2016-03-15  Pedro Alves  <palves@redhat.com>

	PR gdb/19676
	* linux-thread-db.c (try_thread_db_load_1): Leave
	info->td_ta_thr_iter_p NULL iff debugging a live process and we
	have /proc access.
	(find_new_threads_once): Assert that we have a non-NULL
	info->td_ta_thr_iter_p instead of checking whether the target has
	execution.


^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2016-03-15 22:28 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-15 17:34 [binutils-gdb/gdb-7.11-branch] Fix PR gdb/19676: Internal error in linux-thread.db.c if /proc not mounted sergiodj+buildbot
2016-03-15 17:34 ` Failures on RHEL-s390x-m64, branch gdb-7.11-branch sergiodj+buildbot
2016-03-15 18:56 ` Failures on AIX-POWER7-plain, " sergiodj+buildbot
2016-03-15 19:36 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " sergiodj+buildbot
2016-03-15 19:42 ` Failures on Debian-s390x-native-gdbserver-m64, " sergiodj+buildbot
2016-03-15 19:48 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " sergiodj+buildbot
2016-03-15 19:51 ` Failures on Fedora-x86_64-native-gdbserver-m64, " sergiodj+buildbot
2016-03-15 20:25 ` Failures on Debian-s390x-native-extended-gdbserver-m64, " sergiodj+buildbot
2016-03-15 20:38 ` Failures on Debian-i686, " sergiodj+buildbot
2016-03-15 21:05 ` Failures on Debian-i686-native-gdbserver, " sergiodj+buildbot
2016-03-15 21:30 ` Failures on Debian-i686-native-extended-gdbserver, " sergiodj+buildbot
2016-03-15 21:42 ` Failures on Fedora-ppc64be-native-gdbserver-m64, " sergiodj+buildbot
2016-03-15 21:43 ` Failures on Debian-x86_64-native-extended-gdbserver-m64, " sergiodj+buildbot
2016-03-15 21:57 ` Failures on Fedora-ppc64be-native-extended-gdbserver-m64, " sergiodj+buildbot
2016-03-15 22:27 ` Failures on Fedora-ppc64le-native-extended-gdbserver-m64, " sergiodj+buildbot
2016-03-16  5:28 ` Failures on Debian-x86_64-native-gdbserver-m64, " sergiodj+buildbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).