public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Fix PR gdb/18155
@ 2015-04-28  1:37 sergiodj+buildbot
  2015-04-28  1:38 ` Failures on Fedora-ppc64be-m64, branch master sergiodj+buildbot
                   ` (9 more replies)
  0 siblings, 10 replies; 11+ messages in thread
From: sergiodj+buildbot @ 2015-04-28  1:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9720679936fc4f710d718f13d903c7826e048a36 ***

Author: Patrick Palka <patrick@parcs.ath.cx>
Branch: master
Commit: 9720679936fc4f710d718f13d903c7826e048a36

Fix PR gdb/18155
For no good reason the function tui_free_window() is freeing the locator
window when we pass it an SRC_WIN or a DISASSEM_WIN.  This behavior
doesn't make much sense because the locator window is always visible and
its contents do not change when the main window changes.

This behavior triggers the above PR because when we switch from one TUI
window to another (in the PR, from the src window to the asm window) we
call tui_free_window() on the previously active window (in the PR, the
src window).  The function then frees the src window along with the
locator window and later we segfault when the now-active asm window
tries to query the locator window about the inferior's PC.

This patch fixes this apparently wrong behavior by changing
tui_free_window() to not free the locator window when we pass it an
SRC_WIN or a DISASSEM_WIN.

gdb/ChangeLog:

	PR gdb/18155
	* tui/tui-data.c (tui_free_window): Don't free the locator
	window when passed an SRC_WIN or a DISASSEM_WIN.


^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2015-04-28  7:54 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-28  1:37 [binutils-gdb] Fix PR gdb/18155 sergiodj+buildbot
2015-04-28  1:38 ` Failures on Fedora-ppc64be-m64, branch master sergiodj+buildbot
2015-04-28  1:41 ` Failures on Fedora-ppc64be-native-gdbserver-m64, " sergiodj+buildbot
2015-04-28  1:44 ` Failures on Fedora-ppc64be-native-extended-gdbserver-m64, " sergiodj+buildbot
2015-04-28  1:44 ` Failures on Fedora-ppc64le-native-extended-gdbserver-m64, " sergiodj+buildbot
2015-04-28  1:47 ` Failures on Fedora-ppc64le-cc-with-index, " sergiodj+buildbot
2015-04-28  1:54 ` Failures on Fedora-ppc64le-native-gdbserver-m64, " sergiodj+buildbot
2015-04-28  1:58 ` Failures on Fedora-ppc64le-m64, " sergiodj+buildbot
2015-04-28  2:04 ` Failures on Fedora-ppc64be-cc-with-index, " sergiodj+buildbot
2015-04-28  7:03 ` Failures on Debian-i686, " sergiodj+buildbot
2015-04-28  7:54 ` Failures on Debian-i686-native-extended-gdbserver, " sergiodj+buildbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).