public inbox for gdb-testers@sourceware.org help / color / mirror / Atom feed
From: sergiodj+buildbot@sergiodj.net To: gdb-testers@sourceware.org Subject: [binutils-gdb] Fix regression in "commands" Date: Thu, 07 Dec 2017 22:13:00 -0000 [thread overview] Message-ID: <99598d713f45d1b26015ec3562d160dc2b3792e4@gdb-build> (raw) *** TEST RESULTS FOR COMMIT 99598d713f45d1b26015ec3562d160dc2b3792e4 *** Author: Tom Tromey <tom@tromey.com> Branch: master Commit: 99598d713f45d1b26015ec3562d160dc2b3792e4 Fix regression in "commands" Pedro pointed out a regression in "commands", where trying to clear a breakpoint's command list would fail: (top-gdb) commands Type commands for breakpoint(s) 3, one per line. End with a line saying just "end". >end No breakpoints specified. (top-gdb) I believe the bug was introduced by my patch that changes counted_command_line to be a shared_ptr. This causes the problem because now the counted_command_line in commands_command_1 can be NULL, whereas previously it never could be. After some discussion, we agreed to simply remove the error case from commands_command_1. 2017-12-07 Tom Tromey <tom@tromey.com> PR breakpoints/22511: * breakpoint.c (commands_command_1): Don't throw an exception when no commands have been read. 2017-12-07 Tom Tromey <tom@tromey.com> * gdb.base/break.exp: Add test for empty "commands".
next reply other threads:[~2017-12-07 22:13 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-12-07 22:13 sergiodj+buildbot [this message] 2017-12-07 22:13 ` Failures on Fedora-x86_64-m64, branch master sergiodj+buildbot 2017-12-07 22:14 ` Failures on Fedora-x86_64-m32, " sergiodj+buildbot 2017-12-07 22:29 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " sergiodj+buildbot 2017-12-07 22:45 ` Failures on Fedora-i686, " sergiodj+buildbot 2017-12-07 22:45 ` Failures on Fedora-x86_64-native-gdbserver-m64, " sergiodj+buildbot 2017-12-07 23:08 ` Failures on Fedora-x86_64-cc-with-index, " sergiodj+buildbot 2017-12-08 1:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, " sergiodj+buildbot 2017-12-08 1:51 ` Failures on Ubuntu-AArch32-m32, " sergiodj+buildbot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=99598d713f45d1b26015ec3562d160dc2b3792e4@gdb-build \ --to=sergiodj+buildbot@sergiodj.net \ --cc=gdb-testers@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).