public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Fix PR gdb/19858: GDB doesn't register the JIT libraries on attach
@ 2016-03-31 19:01 sergiodj+buildbot
  2016-03-31 19:11 ` Failures on Debian-i686, branch master sergiodj+buildbot
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: sergiodj+buildbot @ 2016-03-31 19:01 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9bb84c9f97cb81df81f18f4e47d6b24fa37b597c ***

Author: Yichao Yu <yyc1992@gmail.com>
Branch: master
Commit: 9bb84c9f97cb81df81f18f4e47d6b24fa37b597c

Fix PR gdb/19858: GDB doesn't register the JIT libraries on attach

Ref: https://sourceware.org/ml/gdb/2016-03/msg00023.html

GDB currently fails to fetch the list of already-registered JIT
modules on attach.

Nothing is calling jit_inferior_init, which is what is responsible for
walking the JIT object list at init time.

Despite the misleading naming, jit_inferior_created_hook ->
jit_inferior_init is only called when the inferior execs.

This regressed with the fix for PR gdb/13431 (03bef283c2d3):
 https://sourceware.org/ml/gdb-patches/2012-02/msg00023.html which
removed the inferior_created (jit_inferior_created_observer)
observer.

Adding an inferior_created observer back fixes the issue.

In turn, this exposes a bug in jit_breakpoint_re_set_internal as well,
which is returning the wrong result when we already have the
breakpoint at the right address.

gdb/ChangeLog:
2016-03-31  Yichao Yu  <yyc1992@gmail.com>

	PR gdb/19858
	* jit.c (jit_breakpoint_re_set_internal): Return 0 if we already
	got the breakpoint at the right address.
	(jit_inferior_created): New function.
	(_initialize_jit): Install jit_inferior_created as
	inferior_created observer.

Signed-off-by: Pedro Alves <palves@redhat.com>


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2016-04-01  2:46 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-31 19:01 [binutils-gdb] Fix PR gdb/19858: GDB doesn't register the JIT libraries on attach sergiodj+buildbot
2016-03-31 19:11 ` Failures on Debian-i686, branch master sergiodj+buildbot
2016-03-31 19:12 ` Failures on AIX-POWER7-plain, " sergiodj+buildbot
2016-03-31 19:31 ` Failures on Debian-x86_64-m64, " sergiodj+buildbot
2016-03-31 19:31 ` Failures on Debian-i686-native-extended-gdbserver, " sergiodj+buildbot
2016-03-31 21:45 ` Failures on Fedora-x86_64-cc-with-index, " sergiodj+buildbot
2016-03-31 21:51 ` Failures on Fedora-x86_64-cxx-build-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2016-04-01  2:46 ` Failures on Fedora-ppc64be-native-extended-gdbserver-m64, branch master sergiodj+buildbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).