public inbox for gdb-testers@sourceware.org help / color / mirror / Atom feed
From: sergiodj+buildbot@sergiodj.net To: gdb-testers@sourceware.org Subject: [binutils-gdb] PR remote/21188: Fix remote serial timeout Date: Wed, 22 Mar 2017 13:24:00 -0000 [thread overview] Message-ID: <9bcbdca808b5f9fec6217d20bd4b48a56008c460@gdb-build> (raw) *** TEST RESULTS FOR COMMIT 9bcbdca808b5f9fec6217d20bd4b48a56008c460 *** Author: Pedro Alves <palves@redhat.com> Branch: master Commit: 9bcbdca808b5f9fec6217d20bd4b48a56008c460 PR remote/21188: Fix remote serial timeout As Gareth McMullin <gareth@blacksphere.co.nz> reports at <https://sourceware.org/ml/gdb-patches/2017-02/msg00560.html>, the timeout mechanism in ser-unix.c was broken by commit 048094acc ("target remote: Don't rely on immediate_quit (introduce quit handlers)"). Instead of applying a local fix, and since we now finally always use interrupt_select [1], let's get rid of hardwire_readchar entirely, and use ser_base_readchar instead, which has similar timeout handling, except for the bug. Smoke tested with: $ socat -d -d pty,raw,echo=0 pty,raw,echo=0 2017/03/14 14:08:13 socat[4994] N PTY is /dev/pts/14 2017/03/14 14:08:13 socat[4994] N PTY is /dev/pts/15 2017/03/14 14:08:13 socat[4994] N starting data transfer loop with FDs [3,3] and [5,5] $ gdbserver /dev/pts/14 PROG $ gdb PROG -ex "tar rem /dev/pts/15" and then a few continues/ctrl-c's, plus killing gdbserver and socat. [1] - See FIXME comments being removed. gdb/ChangeLog: 2017-03-17 Pedro Alves <palves@redhat.com> PR remote/21188 * ser-base.c (ser_base_wait_for): Add comment. (do_ser_base_readchar): Improve comment based on the ser-unix.c's version. * ser-unix.c (hardwire_raw): Remove reference to scb->current_timeout. (wait_for, do_hardwire_readchar, hardwire_readchar): Delete. (hardwire_ops): Install ser_base_readchar instead of hardwire_readchar. * serial.h (struct serial) <current_timeout, timeout_remaining>: Remove fields.
next reply other threads:[~2017-03-22 13:24 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-22 13:24 sergiodj+buildbot [this message] 2017-03-22 13:24 ` Failures on Fedora-s390x-m64, branch master sergiodj+buildbot 2017-03-23 11:52 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, " sergiodj+buildbot 2017-03-23 12:20 ` Failures on Ubuntu-AArch64-m64, " sergiodj+buildbot 2017-03-23 17:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, " sergiodj+buildbot 2017-03-23 17:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, " sergiodj+buildbot 2017-03-23 18:18 ` Failures on Ubuntu-AArch32-m32, " sergiodj+buildbot 2017-04-30 10:54 ` Failures on Fedora-ppc64le-native-gdbserver-m64, " sergiodj+buildbot 2017-04-30 20:45 ` Failures on Fedora-ppc64le-native-extended-gdbserver-m64, " sergiodj+buildbot 2017-05-05 4:29 ` Failures on Debian-s390x-native-extended-gdbserver-m64, " sergiodj+buildbot 2017-05-05 13:35 ` Failures on Debian-s390x-native-gdbserver-m64, " sergiodj+buildbot 2017-05-05 14:13 ` Failures on Debian-s390x-m64, " sergiodj+buildbot 2017-05-06 11:04 ` Failures on Fedora-ppc64be-native-gdbserver-m64, " sergiodj+buildbot 2017-05-06 20:15 ` Failures on Fedora-ppc64be-native-extended-gdbserver-m64, " sergiodj+buildbot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9bcbdca808b5f9fec6217d20bd4b48a56008c460@gdb-build \ --to=sergiodj+buildbot@sergiodj.net \ --cc=gdb-testers@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).