public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: sergiodj+buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] MIPS64/BFD: Fix a crash with invalid `r_sym' in relocation
Date: Mon, 09 Apr 2018 13:04:00 -0000	[thread overview]
Message-ID: <9ccfa98b4cbc86ac34734ecf9d35466461c7e34c@gdb-build> (raw)

*** TEST RESULTS FOR COMMIT 9ccfa98b4cbc86ac34734ecf9d35466461c7e34c ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 9ccfa98b4cbc86ac34734ecf9d35466461c7e34c

MIPS64/BFD: Fix a crash with invalid `r_sym' in relocation

Prevent an out-of-range access and a possible segmentation fault in
`mips_elf64_slurp_one_reloc_table':

Program received signal SIGSEGV, Segmentation fault.
mips_elf64_slurp_one_reloc_table (abfd=0x71bd90, asect=0x71cf70,
    rel_hdr=<value optimized out>, reloc_count=1,
    relents=<value optimized out>, symbols=0x7218c0, dynamic=0)
    at .../bfd/elf64-mips.c:3758
3757			      ps = symbols + rela.r_sym - 1;
3758			      s = *ps;

in the MIPS64 (n64 MIPS) ELF backend whenever an invalid symbol index is
retrieved from the `r_sym' field of a relocation seen in input while
running `objcopy' or `strip'.  Issue an error instead, like the generic
ELF backend does, taking code from `elf_slurp_reloc_table_from_section',
except for relocation types that do not refer to a symbol.

This complements commit 1f70368c21a8 ("Stop objdump crash on corrupt
reloc table"), <https://sourceware.org/ml/binutils/2002-09/msg00332.html>,
and commit 05a487dc8c39 ("make check fails on i686-linux-gnu"),
<https://sourceware.org/ml/binutils/2002-09/msg00340.html>, where the
generic ELF backend code comes from.

	bfd/
	* elf64-mips.c (mips_elf64_slurp_one_reloc_table): Issue an
	error for out-of-range `r_sym' values.


             reply	other threads:[~2018-04-09 13:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-09 13:04 sergiodj+buildbot [this message]
2018-04-09 13:04 ` Failures on Fedora-s390x-m64, branch master sergiodj+buildbot
2018-04-09 13:16 ` Failures on Fedora-x86_64-m64, " sergiodj+buildbot
2018-04-09 13:30 ` Failures on Fedora-x86_64-native-gdbserver-m32, " sergiodj+buildbot
2018-04-09 13:41 ` Failures on Fedora-x86_64-m32, " sergiodj+buildbot
2018-04-09 13:51 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " sergiodj+buildbot
2018-04-09 14:03 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-w64-mingw32, branch master *** BREAKAGE *** sergiodj+buildbot
2018-04-09 14:10 ` Failures on Fedora-x86_64-native-gdbserver-m64, branch master sergiodj+buildbot
2018-04-09 14:20 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " sergiodj+buildbot
2018-04-09 14:34 ` Failures on Fedora-x86_64-cc-with-index, " sergiodj+buildbot
2018-04-09 14:48 ` Failures on Debian-s390x-m64, " sergiodj+buildbot
2018-04-09 15:20 ` Failures on Debian-s390x-native-gdbserver-m64, " sergiodj+buildbot
2018-04-09 21:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, " sergiodj+buildbot
2018-04-09 21:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, " sergiodj+buildbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ccfa98b4cbc86ac34734ecf9d35466461c7e34c@gdb-build \
    --to=sergiodj+buildbot@sergiodj.net \
    --cc=gdb-testers@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).