[binutils-gdb] PR gdb/17210 - fix possible memory leak in read_memory_robust

[binutils-gdb] PR gdb/17210 - fix possible memory leak in read_memory_robust

[sergiodj+buildbot]

*** TEST RESULTS FOR COMMIT 9d78f827e0da9ab6fda2d6ef2d59cebb805b411f ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 9d78f827e0da9ab6fda2d6ef2d59cebb805b411f

PR gdb/17210 - fix possible memory leak in read_memory_robust

PR gdb/17210 concerns a possible memory leak in read_memory_robust.
The bug can happen because read_memory_robust allocates memory, does
not install any cleanups, and invokes QUIT.  Similarly, target_read
calls QUIT, so it too can potentially throw.

The fix is to install cleanups to guard the allocated memory.

Built and regtested on x86-64 Fedora 23.  I couldn't think of a way to
test this, so no new test; and of course this means it should have
more careful review.

2016-06-29  Tom Tromey  <tom@tromey.com>

	PR gdb/17210:
	* target.c (free_memory_read_result_vector): Take a pointer to the
	VEC as an argument.
	(read_memory_robust): Install a cleanup for "result".
	* mi/mi-main.c (mi_cmd_data_read_memory_bytes): Update.

Failures on Debian-i686, branch master

[sergiodj+buildbot]

Buildslave:
	wildebeest-debian-wheezy-i686

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Debian-i686/builds/3767>

Commit(s) tested:
	9d78f827e0da9ab6fda2d6ef2d59cebb805b411f

Author(s) (in the same order as the commits):
	Tom Tromey <tom@tromey.com>

Subject:
	PR gdb/17210 - fix possible memory leak in read_memory_robust

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/cgit/Debian-i686/.git/tree/?h=master&id=8494fc66257ed2a8775f9d9e629e945aef205d4b>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: continue: setup: continue to breakpoint: run to breakpoint in thread 2
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: continue: setup: unbreak loop in thread 2
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: continue: continue
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Debian-i686/xfails/master/xfail;hb=b49a91b>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Debian-i686/xfails/master/xfail.table;hb=b49a91b>

Failures on Fedora-x86_64-native-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-4

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-gdbserver-m64/builds/3866>

Commit(s) tested:
	9d78f827e0da9ab6fda2d6ef2d59cebb805b411f

Author(s) (in the same order as the commits):
	Tom Tromey <tom@tromey.com>

Subject:
	PR gdb/17210 - fix possible memory leak in read_memory_robust

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/cgit/Fedora-x86_64-native-gdbserver-m64/.git/tree/?h=master&id=51e714dbd4e358b4be7362622447f03828d1a522>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.ada/tagged_not_init.exp: print obj
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-gdbserver-m64/xfails/master/xfail;hb=e3dda73>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-gdbserver-m64/xfails/master/xfail.table;hb=e3dda73>

Failures on Fedora-x86_64-native-gdbserver-m32, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-3

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-gdbserver-m32/builds/3874>

Commit(s) tested:
	9d78f827e0da9ab6fda2d6ef2d59cebb805b411f

Author(s) (in the same order as the commits):
	Tom Tromey <tom@tromey.com>

Subject:
	PR gdb/17210 - fix possible memory leak in read_memory_robust

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/cgit/Fedora-x86_64-native-gdbserver-m32/.git/tree/?h=master&id=08772b8397a9f5a347ba9de77f76204729c6eac1>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.ada/win_fu_syms.exp: compilation foo.adb
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-gdbserver-m32/xfails/master/xfail;hb=afde56f>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-gdbserver-m32/xfails/master/xfail.table;hb=afde56f>

Failures on Fedora-i686, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-4

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-i686/builds/3887>

Commit(s) tested:
	9d78f827e0da9ab6fda2d6ef2d59cebb805b411f

Author(s) (in the same order as the commits):
	Tom Tromey <tom@tromey.com>

Subject:
	PR gdb/17210 - fix possible memory leak in read_memory_robust

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/cgit/Fedora-i686/.git/tree/?h=master&id=128d58effd3ebed78cac6d49ce735a7730e762af>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.ada/win_fu_syms.exp: compilation foo.adb
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-i686/xfails/master/xfail;hb=f8a3b71>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-i686/xfails/master/xfail.table;hb=f8a3b71>

Failures on Debian-i686-native-extended-gdbserver, branch master

[sergiodj+buildbot]

Buildslave:
	wildebeest-debian-wheezy-i686

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Debian-i686-native-extended-gdbserver/builds/3749>

Commit(s) tested:
	9d78f827e0da9ab6fda2d6ef2d59cebb805b411f

Author(s) (in the same order as the commits):
	Tom Tromey <tom@tromey.com>

Subject:
	PR gdb/17210 - fix possible memory leak in read_memory_robust

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/cgit/Debian-i686-native-extended-gdbserver/.git/tree/?h=master&id=46ccbb697f5980f10104f8e31092ff2861b639b3>

*** Diff to previous build ***
============================
new FAIL: gdb.threads/attach-into-signal.exp: threaded: process is still running on the attempt # 1 of 100
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: next: setup: continue to breakpoint: run to breakpoint in thread 3
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: next: setup: unbreak loop in thread 3
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: continue: setup: continue to breakpoint: run to breakpoint in thread 3
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: continue: setup: unbreak loop in thread 3
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: signal thr2: setup: continue to breakpoint: run to breakpoint in thread 3
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: signal thr2: setup: unbreak loop in thread 3
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: signal thr2: continue to sigusr1_handler
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Debian-i686-native-extended-gdbserver/xfails/master/xfail;hb=b49a91b>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Debian-i686-native-extended-gdbserver/xfails/master/xfail.table;hb=b49a91b>

Failures on Debian-x86_64-native-extended-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	wildebeest-debian-wheezy-x86_64

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Debian-x86_64-native-extended-gdbserver-m64/builds/3797>

Commit(s) tested:
	9d78f827e0da9ab6fda2d6ef2d59cebb805b411f

Author(s) (in the same order as the commits):
	Tom Tromey <tom@tromey.com>

Subject:
	PR gdb/17210 - fix possible memory leak in read_memory_robust

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/cgit/Debian-x86_64-native-extended-gdbserver-m64/.git/tree/?h=master&id=462b65dc86fe22cd0ca81314afb9ecc29538f316>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.base/multi-forks.exp: Run to exit 13
PASS -> FAIL: gdb.base/multi-forks.exp: info inferior 13
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Debian-x86_64-native-extended-gdbserver-m64/xfails/master/xfail;hb=b49a91b>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Debian-x86_64-native-extended-gdbserver-m64/xfails/master/xfail.table;hb=b49a91b>

Failures on Fedora-ppc64be-cc-with-index, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-ppc64be-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-ppc64be-cc-with-index/builds/3807>

Commit(s) tested:
	9d78f827e0da9ab6fda2d6ef2d59cebb805b411f

Author(s) (in the same order as the commits):
	Tom Tromey <tom@tromey.com>

Subject:
	PR gdb/17210 - fix possible memory leak in read_memory_robust

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/cgit/Fedora-ppc64be-cc-with-index/.git/tree/?h=master&id=7f31b9e5b8e16207b191809f143a8ebd66e57d19>

*** Diff to previous build ***
============================
new FAIL: gdb.gdb/observer.exp: run until breakpoint at captured_main
new FAIL: gdb.gdb/selftest.exp: run until breakpoint at captured_main
new FAIL: gdb.gdb/xfullpath.exp: run until breakpoint at captured_main
new FAIL: gdb.mi/mi-reverse.exp: Turn on process record
new FAIL: gdb.mi/mi-var-child.exp: listing of children, simple types: names, type and values, complex types: names and types
new FAIL: gdb.mi/mi-var-display.exp: set format variable weird.func_ptr_ptr in natural
new FAIL: gdb.mi/mi-watch.exp: mi-mode=main: wp-type=hw: watchpoint trigger
new FAIL: gdb.mi/mi-watch.exp: mi-mode=separate: wp-type=hw: watchpoint trigger
new FAIL: gdb.mi/mi-watch-nonstop.exp: delete watchpoint
new FAIL: gdb.mi/pr11022.exp: data-write-memory-bytes &x "01": watchpoint hit
new FAIL: gdb.mi/pr11022.exp: data-write-memory-bytes &x "01": watchpoint hit 2
new FAIL: gdb.mi/pr11022.exp: data-write-memory &x x 4 "01": watchpoint hit
new FAIL: gdb.mi/pr11022.exp: data-write-memory &x x 4 "01": watchpoint hit 2
new FAIL: gdb.modula2/unbounded-array.exp: print unbounded array contents
new FAIL: gdb.opt/inline-cmds.exp: mi: step to inline call
new FAIL: gdb.opt/inline-cmds.exp: mi: step into inline call
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-ppc64be-cc-with-index/xfails/master/xfail;hb=28b4051>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-ppc64be-cc-with-index/xfails/master/xfail.table;hb=28b4051>

Failures on Fedora-ppc64be-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-ppc64be-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-ppc64be-m64/builds/3810>

Commit(s) tested:
	9d78f827e0da9ab6fda2d6ef2d59cebb805b411f

Author(s) (in the same order as the commits):
	Tom Tromey <tom@tromey.com>

Subject:
	PR gdb/17210 - fix possible memory leak in read_memory_robust

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/cgit/Fedora-ppc64be-m64/.git/tree/?h=master&id=19c978d84387d575096fc08ba01aaa4d6918c404>

*** Internal error on buildslave (no space left on device). ***
*** Please report this to the buildslave owner (see <http://gdb-build.sergiodj.net//buildslaves/fedora-ppc64be-1>) ***

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.base/coredump-filter.exp: saving corefile for non-Shared-Anonymous: save corefile
PASS -> FAIL: gdb.base/coredump-filter.exp: saving corefile for DoNotDump: p set_coredump_filter
new FAIL: gdb.gdb/observer.exp: run until breakpoint at captured_main
new FAIL: gdb.gdb/selftest.exp: run until breakpoint at captured_main
new FAIL: gdb.gdb/xfullpath.exp: run until breakpoint at captured_main
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-ppc64be-m64/xfails/master/xfail;hb=cccfb8a>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-ppc64be-m64/xfails/master/xfail.table;hb=cccfb8a>

Failures on Fedora-ppc64le-native-extended-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-ppc64le-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-ppc64le-native-extended-gdbserver-m64/builds/3745>

Commit(s) tested:
	9d78f827e0da9ab6fda2d6ef2d59cebb805b411f

Author(s) (in the same order as the commits):
	Tom Tromey <tom@tromey.com>

Subject:
	PR gdb/17210 - fix possible memory leak in read_memory_robust

Testsuite log (gdb.sum and gdb.log) URL(s):
	<Error fetching commit ID for 9d78f827e0da9ab6fda2d6ef2d59cebb805b411f>

Failures on Fedora-ppc64le-cc-with-index, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-ppc64le-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-ppc64le-cc-with-index/builds/3723>

Commit(s) tested:
	9d78f827e0da9ab6fda2d6ef2d59cebb805b411f

Author(s) (in the same order as the commits):
	Tom Tromey <tom@tromey.com>

Subject:
	PR gdb/17210 - fix possible memory leak in read_memory_robust

Testsuite log (gdb.sum and gdb.log) URL(s):
	<Error fetching commit ID for 9d78f827e0da9ab6fda2d6ef2d59cebb805b411f>

Failures on Fedora-ppc64le-native-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-ppc64le-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-ppc64le-native-gdbserver-m64/builds/3733>

Commit(s) tested:
	9d78f827e0da9ab6fda2d6ef2d59cebb805b411f

Author(s) (in the same order as the commits):
	Tom Tromey <tom@tromey.com>

Subject:
	PR gdb/17210 - fix possible memory leak in read_memory_robust

Testsuite log (gdb.sum and gdb.log) URL(s):
	<Error fetching commit ID for 9d78f827e0da9ab6fda2d6ef2d59cebb805b411f>

Failures on Fedora-ppc64be-native-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-ppc64be-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-ppc64be-native-gdbserver-m64/builds/3804>

Commit(s) tested:
	9d78f827e0da9ab6fda2d6ef2d59cebb805b411f

Author(s) (in the same order as the commits):
	Tom Tromey <tom@tromey.com>

Subject:
	PR gdb/17210 - fix possible memory leak in read_memory_robust

Testsuite log (gdb.sum and gdb.log) URL(s):
	<Error fetching commit ID for 9d78f827e0da9ab6fda2d6ef2d59cebb805b411f>

*** Internal error on buildslave (no space left on device). ***
*** Please report this to the buildslave owner (see <http://gdb-build.sergiodj.net//buildslaves/fedora-ppc64be-1>) ***

Failures on Fedora-ppc64le-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-ppc64le-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-ppc64le-m64/builds/3724>

Commit(s) tested:
	9d78f827e0da9ab6fda2d6ef2d59cebb805b411f

Author(s) (in the same order as the commits):
	Tom Tromey <tom@tromey.com>

Subject:
	PR gdb/17210 - fix possible memory leak in read_memory_robust

Testsuite log (gdb.sum and gdb.log) URL(s):
	<Error fetching commit ID for 9d78f827e0da9ab6fda2d6ef2d59cebb805b411f>

Failures on Fedora-ppc64be-native-extended-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-ppc64be-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-ppc64be-native-extended-gdbserver-m64/builds/3812>

Commit(s) tested:
	9d78f827e0da9ab6fda2d6ef2d59cebb805b411f

Author(s) (in the same order as the commits):
	Tom Tromey <tom@tromey.com>

Subject:
	PR gdb/17210 - fix possible memory leak in read_memory_robust

Testsuite log (gdb.sum and gdb.log) URL(s):
	<Error fetching commit ID for 9d78f827e0da9ab6fda2d6ef2d59cebb805b411f>

*** Internal error on buildslave (no space left on device). ***
*** Please report this to the buildslave owner (see <http://gdb-build.sergiodj.net//buildslaves/fedora-ppc64be-1>) ***