public inbox for gdb-testers@sourceware.org help / color / mirror / Atom feed
From: sergiodj+buildbot@sergiodj.net To: gdb-testers@sourceware.org Subject: [binutils-gdb] Basic c++ification of varobj Date: Wed, 22 Nov 2017 21:06:00 -0000 [thread overview] Message-ID: <9e5b9d2b295d1771647a9e4bc942e398142ccf9b@gdb-build> (raw) *** TEST RESULTS FOR COMMIT 9e5b9d2b295d1771647a9e4bc942e398142ccf9b *** Author: Simon Marchi <simon.marchi@polymtl.ca> Branch: master Commit: 9e5b9d2b295d1771647a9e4bc942e398142ccf9b Basic c++ification of varobj This patch does a basic c++ification or the varobj data structure. - varobj: add constructor and destructor, initialize fields - varobj_root: initialize fields - varobj_dynamic: initialize fields This allows getting rid of new_variable, new_root_variable. free_variable essentially becomes varobj's destructor. This also allows getting rid of a cleanup, make_cleanup_free_variable, which was only used in varobj_create in case the varobj creation fails. It is replaced with a unique_ptr. gdb/ChangeLog: * varobj.h (struct varobj): Add constructor and destructor, initialize fields. * varobj.c (struct varobj_root): Initialize fields. (struct varobj_dynamic): Initialize fields. (varobj_create): Use unique_ptr instead of cleanup. Create varobj with new instead of new_root_variable. (delete_variable_1): Free variable with delete instead of free_variable. (create_child_with_value): Create variable with new instead of new_variable. (varobj::varobj): New. (varobj::~varobj): New (body mostly coming from free_variable). (new_variable): Remove. (free_variable): Remove. (do_free_variable_cleanup): Remove. (make_cleanup_free_variable): Remove.
next reply other threads:[~2017-11-22 21:06 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-11-22 21:06 sergiodj+buildbot [this message] 2017-11-22 21:06 ` Failures on Fedora-x86_64-native-gdbserver-m32, branch master sergiodj+buildbot 2017-11-22 21:15 ` Failures on Fedora-x86_64-m32, " sergiodj+buildbot 2017-11-22 21:27 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " sergiodj+buildbot 2017-11-22 21:30 ` Failures on Fedora-x86_64-cc-with-index, " sergiodj+buildbot 2017-11-22 21:31 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " sergiodj+buildbot 2017-11-22 21:40 ` Failures on Fedora-i686, " sergiodj+buildbot 2017-11-22 21:47 ` Failures on Fedora-x86_64-native-gdbserver-m64, " sergiodj+buildbot 2017-11-22 23:51 ` Failures on Ubuntu-AArch64-m64, " sergiodj+buildbot 2017-11-23 1:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, " sergiodj+buildbot 2017-11-23 2:10 ` Failures on Ubuntu-AArch32-m32, " sergiodj+buildbot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9e5b9d2b295d1771647a9e4bc942e398142ccf9b@gdb-build \ --to=sergiodj+buildbot@sergiodj.net \ --cc=gdb-testers@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).