public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: sergiodj+buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] btrace, gdbserver: use exceptions to convey btrace enable/disable errors
Date: Fri, 09 Feb 2018 16:32:00 -0000	[thread overview]
Message-ID: <9ee23a853c18da3c83530c7957464bc6b6e9fb16@gdb-build> (raw)

*** TEST RESULTS FOR COMMIT 9ee23a853c18da3c83530c7957464bc6b6e9fb16 ***

Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: 9ee23a853c18da3c83530c7957464bc6b6e9fb16

btrace, gdbserver: use exceptions to convey btrace enable/disable errors

Change error reporting to use exceptions and be prepared to catch them in
gdbserver.  We use the exception message in our error reply to GDB.

This may remove some detail from the error message in the native case since
errno is no longer printed.  Later patches will improve that.

We're still using error strings on the RSP level.  This patch does not affect
the interoperability of older/newer GDB/gdbserver.

gdbserver/
	* server.c (handle_btrace_enable_bts, handle_btrace_enable_pt)
	(handle_btrace_disable): Change return type to void.  Use exceptions
	to report errors.
	(handle_btrace_general_set): Catch exception and copy message to
	return message.

gdb/
	* nat/linux-btrace.c (linux_enable_btrace): Throw exception if enabling
	btrace failed.
	* x86-linux-nat.c (x86_linux_enable_btrace): Catch btrace enabling
	exception and use message in own exception.


             reply	other threads:[~2018-02-09 16:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-09 16:32 sergiodj+buildbot [this message]
2018-02-09 16:32 ` Failures on Fedora-s390x-m64, branch master sergiodj+buildbot
2018-02-09 18:03 ` Failures on Debian-s390x-m64, " sergiodj+buildbot
2018-02-09 18:19 ` Failures on Debian-s390x-native-extended-gdbserver-m64, " sergiodj+buildbot
2018-02-09 18:33 ` Failures on Debian-s390x-native-gdbserver-m64, " sergiodj+buildbot
2018-02-09 18:46 ` Failures on Fedora-i686, " sergiodj+buildbot
2018-02-09 18:48 ` Failures on Fedora-x86_64-m64, " sergiodj+buildbot
2018-02-09 18:51 ` Failures on Fedora-x86_64-native-gdbserver-m32, " sergiodj+buildbot
2018-02-09 19:02 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " sergiodj+buildbot
2018-02-09 19:17 ` Failures on Fedora-x86_64-native-gdbserver-m64, " sergiodj+buildbot
2018-02-09 19:20 ` Failures on Fedora-x86_64-m32, " sergiodj+buildbot
2018-02-10  0:30 ` Failures on Ubuntu-AArch64-m64, " sergiodj+buildbot
2018-02-10 12:38 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, " sergiodj+buildbot
2018-02-10 13:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, " sergiodj+buildbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ee23a853c18da3c83530c7957464bc6b6e9fb16@gdb-build \
    --to=sergiodj+buildbot@sergiodj.net \
    --cc=gdb-testers@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).