public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Constify arch_type and friends
@ 2016-06-10 16:24 sergiodj+buildbot
  2016-06-10 16:30 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
                   ` (10 more replies)
  0 siblings, 11 replies; 145+ messages in thread
From: sergiodj+buildbot @ 2016-06-10 16:24 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 695bfa52ccf22058e371828c3636a3d74424ec5b ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 695bfa52ccf22058e371828c3636a3d74424ec5b

Constify arch_type and friends

While working on the Rust support, I happened to notice that arch_type
and related functions take "char *" arguments, where "const char *"
would be more correct.  This patch fixes this oversight.  Tested by
rebuilding.

2016-06-10  Tom Tromey  <tom@tromey.com>

	* gdbtypes.c (arch_type, arch_integer_type, arch_character_type)
	(arch_boolean_type, arch_float_type, arch_complex_type)
	(arch_flags_type, append_flags_type_field)
	(append_flags_type_flag, arch_composite_type)
	(append_composite_type_field_raw)
	(append_composite_type_field_aligned)
	(append_composite_type_field): Make "name" parameter const.
	* gdbtypes.h (arch_type, arch_integer_type, arch_character_type)
	(arch_boolean_type, arch_float_type, arch_complex_type)
	(append_composite_type_field, append_composite_type_field_aligned)
	(append_composite_type_field_raw, arch_flags_type)
	(append_flags_type_field, append_flags_type_flag): Constify.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Add intro comment to length_cond.exp
@ 2019-06-19 15:59 sergiodj+buildbot
  2019-06-19 16:02 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2019-06-19 15:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 899277ae529c2b743d22093fcc1a9e46aff4422a ***

Author: Tom Tromey <tromey@adacore.com>
Branch: master
Commit: 899277ae529c2b743d22093fcc1a9e46aff4422a

Add intro comment to length_cond.exp

Pedro pointed out that the new length_cond.exp test did not have an
intro comment.  This adds one.

gdb/testsuite/ChangeLog
2019-06-19  Tom Tromey  <tromey@adacore.com>

	* gdb.ada/length_cond.exp: Add intro comment.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Fix crash when setting breakpoint condition
@ 2019-06-19 14:38 sergiodj+buildbot
  2019-06-19 14:43 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2019-06-19 14:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 680e1beed31da40080f61a35f6ccd626de818056 ***

Author: Tom Tromey <tromey@adacore.com>
Branch: master
Commit: 680e1beed31da40080f61a35f6ccd626de818056

Fix crash when setting breakpoint condition

gdb could crash when setting a breakpoint condition on a breakpoint
when using the Ada language.  The problem occurred because the
ada_evaluate_subexp would try to evaluate the array to compute its
attributes, but evaluating can't really be done at this time.

This patch fixes the problem by arranging not to try to evaluate in
EVAL_AVOID_SIDE_EFFECTS mode when computing an attribute.

Tested on x86-64 Fedora 29.  Because this is Ada-specific, and because
Joel approved it internally, I am checking it in.

gdb/ChangeLog
2019-06-19  Tom Tromey  <tromey@adacore.com>

	* ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
	EVAL_AVOID_SIDE_EFFECTS specially.

gdb/testsuite/ChangeLog
2019-06-19  Tom Tromey  <tromey@adacore.com>

	* gdb.ada/length_cond.exp: New file.
	* gdb.ada/length_cond/length_cond.adb: New file.
	* gdb.ada/length_cond/pck.adb: New file.
	* gdb.ada/length_cond/pck.ads: New file.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Instantiate a single source highlighter
@ 2019-06-19 12:58 sergiodj+buildbot
  2019-06-19 12:59 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2019-06-19 12:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT dcf3792354ddcd6e10e59e32060e34b27246e7da ***

Author: Tom Tromey <tromey@adacore.com>
Branch: master
Commit: dcf3792354ddcd6e10e59e32060e34b27246e7da

Instantiate a single source highlighter

It occurred to me that there's no reason to make a new source
highlighter each time gdb needs to highlight some source code.
Instead, a single one can be created and then simply reused each time.

This patch implements this idea.  Tested on x86-64 Fedora 29.

gdb/ChangeLog
2019-06-19  Tom Tromey  <tromey@adacore.com>

	* source-cache.c (highlighter): New global.
	(source_cache::get_source_lines): Create a highlighter on demand.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] PR24697, R_PPC_EMB_SDA21 relocation
@ 2019-06-19 11:38 sergiodj+buildbot
  2019-06-19 11:38 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2019-06-19 11:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6f5601c4d0ad43254244f1b624900cdd5afd02ba ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 6f5601c4d0ad43254244f1b624900cdd5afd02ba

PR24697, R_PPC_EMB_SDA21 relocation

	PR 24697
	* elf32-ppc.c (ppc_elf_relocate_section): Don't read insn for
	R_PPC_EMB_RELSDA.  Mask low bit of R_PPC_EMB_SDA21 r_offset.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] PowerPC64 notoc calls
@ 2019-06-19  8:47 sergiodj+buildbot
  2019-06-19  8:48 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2019-06-19  8:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4a4e7361d67cd9262be1413300795eede564f4cb ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 4a4e7361d67cd9262be1413300795eede564f4cb

PowerPC64 notoc calls

Calls from functions that don't have a valid toc pointer in r2 (these
calls are marked with _NOTOC relocs) to functions that require r2
valid must go via the callee global entry point.  This patch corrects
the condition the linker was using to detect functions that require r2
to be valid.  Values of both zero and one in st_other local entry bits
mean a function doesn't care about r2.

	* elf64-ppc.c (ppc64_elf_inline_plt): Correct st_other test for
	functions that require r2 valid to use local entry.
	(ppc64_elf_size_stubs, ppc64_elf_relocate_section): Likewise.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] gdb: Remove use of deprecated_interactive_hook
@ 2019-06-19  5:18 sergiodj+buildbot
  2019-06-19  6:16 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2019-06-19  5:18 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 494986d596a977e1d24f9f068696f5b3e993ebf7 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 494986d596a977e1d24f9f068696f5b3e993ebf7

gdb: Remove use of deprecated_interactive_hook

The deprecated_interactive_hook is not used within GDB.  It is used in
gdbtk, however this patch removes that use:

  https://sourceware.org/ml/insight/2019-q2/msg00001.html

So I think there is no longer a reason to keep this hook around.

This patch removes it.  There should be no user visible changes after
this commit.

gdb/ChangeLog:

	* defs.h (deprecated_interactive_hook): Delete declaration.
	* interps.c (clear_interpreter_hooks): Remove use of
	deprecated_interactive_hook.
	* top.c (deprecated_interactive_hook): Delete definition.
	* utils.c (maybe_quit): Remove use of deprecated_interactive_hook.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] [gdb/testsuite] Use -fuse-ld=gold in fission.exp
@ 2019-06-18 18:53 sergiodj+buildbot
  2019-06-18 18:56 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2019-06-18 18:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0ed4690a67e2c4703d9088312de652d0d5f1aaaf ***

Author: Tom de Vries <tdevries@suse.de>
Branch: master
Commit: 0ed4690a67e2c4703d9088312de652d0d5f1aaaf

[gdb/testsuite] Use -fuse-ld=gold in fission.exp

The target board fission.exp requires the gold linker (because it supports
--gdb-index).

When running the target board on a system where the default linker is not
gold, most tests will fail to compile.

Fix this by adding "-fuse-ld=gold" ( supported in gcc since version 4.8).

gdb/testsuite/ChangeLog:

2019-06-18  Tom de Vries  <tdevries@suse.de>

	* boards/fission.exp (debug_flags): Add "-fuse-ld=gold".


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] [gdb] Fix abstract_to_concrete type
@ 2019-06-18 18:43 sergiodj+buildbot
  2019-06-18 18:44 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2019-06-18 18:43 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3360b6e7963e3c579e50078e78d226ea63e2960f ***

Author: Tom de Vries <tdevries@suse.de>
Branch: master
Commit: 3360b6e7963e3c579e50078e78d226ea63e2960f

[gdb] Fix abstract_to_concrete type

The test-case varval.exp fails here:
...
FAIL: gdb.dwarf2/varval.exp: print varval2
...
with boards readnow/cc-with-gdb-index/cc-with-debug-names, as well as if gdb
is build with -fsanitize=address -lasan.

The problem is that the abstract_to_concrete map in which we track the
association of abstract to concrete DIEs (for DW_OP_GNU_variable_value
support) has type std::unordered_map<die_info_ptr, std::vector<die_info_ptr>>,
and the die_info_ptrs that we register in the map may be invalid by the time
that we start to lookup DIEs in the map.

Fix this by using the sect_offset instead to identify the DIEs in the map.

Build and tested on x86_64-linux.

gdb/ChangeLog:

2019-06-18  Tom de Vries  <tdevries@suse.de>

	PR gdb/24515
	* dwarf2read.h (abstract_to_concrete): Change type from
	std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
	std::unordered_map<sect_offset, std::vector<sect_offset>>.
	* dwarf2read.c (read_variable): Update.
	(dwarf2_fetch_die_loc_sect_off): Update.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] NEWS and manual changes for command options changes
@ 2019-06-13  4:35 sergiodj+buildbot
  2019-06-13  4:42 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2019-06-13  4:35 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3345721af145007661f4e7e7f4300470095ba622 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 3345721af145007661f4e7e7f4300470095ba622

NEWS and manual changes for command options changes

gdb/ChangeLog:
2019-06-13  Pedro Alves  <palves@redhat.com>

	* NEWS (New commands): Mention "maint test-options
	require-delimiter", "maint test-options unknown-is-error", "maint
	test-options unknown-is-operand" and "maint show
	test-options-completion-result".
	(New command options, command completion): New section.
	(Completion improvements): New section.
	Mention that you can abbreviate "unlimited".

gdb/doc/ChangeLog:
2019-06-13  Pedro Alves  <palves@redhat.com>

	* gdb.texinfo (Command Completion): Mention command options too.
	(Command Options): New node.
	(Threads): Add anchors.  Extend descriptions of the "taas" and
	"tfaas" commands.
	(Backtrace): Describe new options of the "backtrace" command.  Add
	anchors.
	(Frame Apply): Describe new options of the "frame apply" and
	"faas" commands.  Add anchors.
	(Data): Describe new options of the "print" command.  Add anchors.
	(Compiling and Injecting Code): Mention options of the "compile
	print" command.
	(Maintenance Commands): Mention "maint test-options" subcommands
	and the "maint show test-options-completion-result" command.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Delete parse_flags/parse_flags_qcs
@ 2019-06-13  4:29 sergiodj+buildbot
  2019-06-13  4:35 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2019-06-13  4:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6206060d9be8da3e701fe0307c6c01390e2b4ae2 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 6206060d9be8da3e701fe0307c6c01390e2b4ae2

Delete parse_flags/parse_flags_qcs

Now that "thread/frame apply" have been converted to the gdb::option
framework, these functions are no longer used.

For a while, I thought about keeping the unit tests, by making a local
version of parse_flags_qcs in the unit tests file.  But all that would
really test that is used by GDB itself, is the validate_flags_qcs
function.  So in the end, I went through all the unit tests, and
converted any that wasn't already covered to gdb.base/options.exp
tests.  And those have all already been added in previous patches.

gdb/ChangeLog:
2019-06-13  Pedro Alves  <palves@redhat.com>

	* cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
	* cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
	* unittests/cli-utils-selftests.c (test_parse_flags)
	(test_parse_flags_qcs): Delete.
	(test_cli_utils): Don't call deleted functions.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Make "thread apply" use the gdb::option framework
@ 2019-06-13  4:21 sergiodj+buildbot
  2019-06-13  4:21 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2019-06-13  4:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6665660a411ead049daa85cac5c629d637e22044 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 6665660a411ead049daa85cac5c629d637e22044

Make "thread apply" use the gdb::option framework

Similarly to the "frame apply" patch, this makes the "thread apply"
family of commands -- "thread apply TID", "thread apply all" and
"taas" use the gdb::option framework for '-'-style options.

No new options are added, but there are some user-visible changes:

- Can now abbreviate and complete "-ascending"

- We now have a completer for "thread apply" commands

  Can now complete options ("thread apply all -[TAB]"), and also,
  'thread apply all COMMAND[TAB]' now does what you'd expect, by
  making use of the new complete_command routine.

- "help" output tweaked with auto-generated option descriptions:

   ~~~
   Usage: thread apply all [OPTION]... COMMAND
   Prints per-inferior thread number and target system's thread id
   followed by COMMAND output.

   By default, an error raised during the execution of COMMAND
   aborts "thread apply".

   Options:
     -ascending
       Call COMMAND for all threads in ascending order.
       The default is descending order.

     -q
       Disables printing the thread information.

     -c
       Print any error raised by COMMAND and continue.

     -s
       Silently ignore any errors or empty output produced by COMMAND.
   ~~~

  The "By default ..." sentence is new as well.

gdb/ChangeLog:
2019-06-13  Pedro Alves  <palves@redhat.com>

	* thread.c: Include "cli/cli-option.h".
	(tp_array_compar_ascending): Global.
	(tp_array_compar): Delete function.
	(tp_array_compar_ascending, tp_array_compar_descending): New
	functions.
	(ascending_option_def, qcs_flag_option_def)
	(thr_qcs_flags_option_defs)
	(make_thread_apply_all_options_def_group)
	(make_thread_apply_options_def_group): New.
	(thread_apply_all_command): Use gdb::option::process_options.
	(thread_apply_command_completer)
	(thread_apply_all_command_completer): New.
	(thread_apply_command): Use gdb::option::process_options.
	(_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
	with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
	to generate help text of "thread apply".  Adjust "taas"'s help.
	* tid-parse.c (tid_range_parser::in_thread_range): New method.
	* tid-parse.h (tid_range_parser::in_thread_range): New method.

gdb/testsuite/ChangeLog:
2019-06-13  Pedro Alves  <palves@redhat.com>

	* gdb.base/options.exp (test-thread-apply): New.
	(top level): Call it.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] "thread apply 1 -- -" vs "frame apply level 0 -- -"
@ 2019-06-13  4:08 sergiodj+buildbot
  2019-06-13  4:15 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2019-06-13  4:08 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f7e13587eaf1e2d433e21ac0a9e413a98e53652d ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: f7e13587eaf1e2d433e21ac0a9e413a98e53652d

"thread apply 1 -- -" vs "frame apply level 0 -- -"

With the following patch, we'll be able to explicitly tell "thread
apply" where options end, using the "--" delimiter.  A test added by
that patch caught a pre-existing inconsistency:

 (gdb) thread apply 1 -- -
 Invalid thread ID: -

 (gdb) frame apply level 0 -- -
 #0  main () at threads.c:55
 Cannot enable the TUI when output is not a terminal

Above, "thread apply" did not try to run the command, while "frame
apply level" did.  ("-" is a valid TUI command.)

That "-" is past "--", so it should have not been confused with an
invalid TID, in the "thread apply" case.

That error actually doesn't come from the TID parser, but instead from
thread_apply_command directly.

So that error/check needs tweaking.  The next question is what to
tweak it to.

"-" is actually a valid TUI command:

 (gdb) help -
 Scroll window backward.
 Usage: - [WIN] [N]

(gdb) frame apply level 0 -- -
#0  main () at threads.c:55
Cannot enable the TUI when output is not a terminal

While I don't imagine it being useful to use that "-" command with
"thread apply" or "frame apply level", the fact is that you can use it
with "frame apply level", but not with "thread apply".  And since it's
an actual command, pedantically it seems right to allow it.

That's what this commit does.

Note: simply removing the "isalpha" check regresses
gdb.multi/tids.exp -- see related commit 3f5b7598805c.

gdb/ChangeLog:
2019-06-13  Pedro Alves  <palves@redhat.com>

	* thread.c (thread_apply_command): Check for invalid TID with
	isdigit instead of !isalpha.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Make "frame apply" support -OPT options
@ 2019-06-13  3:56 sergiodj+buildbot
  2019-06-13  4:06 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2019-06-13  3:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5d7071341dd3c01d38fc01398ef8b23b1bd3783c ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 5d7071341dd3c01d38fc01398ef8b23b1bd3783c

Make "frame apply" support -OPT options

This adds support for '-'-style options to the "frame apply" family of
commands -- "frame apply COUNT", "frame apply level", "frame apply
all", "faas" and "tfaas".

The -q/-c/-s flags were already supported, -past-main/-past-entry is
new:

~~~
(gdb) help frame apply all
Apply a command to all frames.

Usage: frame apply all [OPTION]... COMMAND
Prints the frame location information followed by COMMAND output.

By default, an error raised during the execution of COMMAND
aborts "frame apply".

Options:
  -q
    Disables printing the frame location information.

  -c
    Print any error raised by COMMAND and continue.

  -s
    Silently ignore any errors or empty output produced by COMMAND.

  -past-main [on|off]
    Set whether backtraces should continue past "main".
    Normally the caller of "main" is not of interest, so GDB will terminate
    the backtrace at "main".  Set this if you need to see the rest
    of the stack trace.

  -past-entry [on|off]
    Set whether backtraces should continue past the entry point of a program.
    Normally there are no callers beyond the entry point of a program, so GDB
    will terminate the backtrace there.  Set this if you need to see
    the rest of the stack trace.
~~~

TAB completion of options is now supported.  Also, TAB completion of
COMMAND in "frame apply all COMMAND" does the right thing now, making
use of complete_command, added by the previous patch.  E.g.:

 (gdb) thread apply all -ascending frame apply all -past-main print -[TAB]
 -address         -elements        -pretty          -symbol
 -array           -null-stop       -repeats         -union
 -array-indexes   -object          -static-members  -vtbl
 (gdb) thread apply all -ascending frame apply all -past-main print glo[TAB]
 global1         global2

The change to tfaas_command is necessary because otherwise you get
this:

 (gdb) tfaas --
 Unrecognized option at: frame apply all -s --

That's because the above is equivalent to:

 (gdb) thread apply all -s frame apply all -s --

and the "--" instructs "thread apply" to consider everything up to
"--" as its command options.  And from that view, "frame" is an
invalid option.

The change makes tfaas be equivalent to:

 (gdb) thread apply all -s -- frame apply all -s --

gdb/ChangeLog:
2019-06-13  Pedro Alves  <palves@redhat.com>

	* cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
	(validate_flags_qcs): New.
	* cli/cli-utils.h (struct qcs_flags): Change field types to int.
	(validate_flags_qcs): Declare.
	* stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
	(make_frame_apply_options_def_group): New.
	(frame_apply_command_count): Process options with
	gdb::option::process_options.
	(frame_apply_completer): New.
	(frame_apply_level_completer, frame_apply_all_completer)
	(frame_apply_completer): New.
	(_initialize_stack): Update help of "frame apply", "frame apply
	level", "frame apply all" and "faas" to mention supported options
	and install command completers.
	* stack.h (frame_apply_all_completer): Declare.
	* thread.c: Include "stack.h".
	(tfaas_command): Add "--".
	(_initialize_thread): Update help "tfaas" to mention supported
	options and install command completer.

gdb/testsuite/ChangeLog:
2019-06-13  Pedro Alves  <palves@redhat.com>

	* gdb.base/options.exp (test-frame-apply): New.
	(top level): Test print commands with different "frame apply"
	prefixes.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Introduce complete_nested_command_line
@ 2019-06-13  3:45 sergiodj+buildbot
  2019-06-13  3:46 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2019-06-13  3:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 272d4594343349a713f7d8967d90ae2413ecbc30 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 272d4594343349a713f7d8967d90ae2413ecbc30

Introduce complete_nested_command_line

This adds a completion helper routine that makes it possible for a
command that takes another command as argument, such as "frame apply
all COMMAND" as "thread apply all COMMAND", to complete on COMMAND,
and have the completion machinery recurse and complete COMMAND as if
you tried to complete "(gdb) COMMAND".  I.e., we'll be able to
complete like this, for example:

 (gdb) thread apply all -[TAB]
 -c           -ascending   -q           -s
 (gdb) thread apply all -ascending frame apply all -[TAB]
 -c           -limit       -past-entry  -past-main   -q           -s
 (gdb) thread apply all -ascending frame apply all -past-main print -[TAB]
 -address         -elements        -pretty          -symbol
 -array           -null-stop       -repeats         -union
 -array-indexes   -object          -static-members  -vtbl
 (gdb) thread apply all -ascending frame apply all -past-main print glo[TAB]
 global1         global2

Above, the completer function understands that "thread apply all" is a
command, and then parses "-ascending" successfully and understand that
the rest of the string is "thread apply all"'s operand.  And then, the
process repeats for the "frame apply" command, and on and on.

gdb/ChangeLog:
2019-06-13  Pedro Alves  <palves@redhat.com>

	* completer.c (complete_nested_command_line): New.
	(gdb_completion_word_break_characters_throw): Add assertion.
	* completer.h (complete_nested_command_line): Declare.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] lib/completion-support.exp: Add test_gdb_completion_offers_commands
@ 2019-06-13  3:40 sergiodj+buildbot
  2019-06-13  3:41 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2019-06-13  3:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e2a689da55d3feb7b79a141f69c4049112f59c91 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: e2a689da55d3feb7b79a141f69c4049112f59c91

lib/completion-support.exp: Add test_gdb_completion_offers_commands

This adds a procedure to the collection of completion-testing
routines, that allows checking whether completion offers all commands
as completion candidates.  This will be used for testing completing
"frame apply all [TAB]", "thread apply all [TAB]", etc.

gdb/testsuite/ChangeLog:
2019-06-13  Pedro Alves  <palves@redhat.com>

        * lib/completion-support.exp (test_gdb_complete_tab_multiple)
	(test_gdb_complete_cmd_multiple, test_gdb_complete_multiple): Add
	'max_completions' parameter and handle it.
	(test_gdb_completion_offers_commands): New.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] "backtrace full/no-filters/hide" completer
@ 2019-06-13  3:19 sergiodj+buildbot
  2019-06-13  3:24 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2019-06-13  3:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 90a1ef8762a57f3f57007db2186099c026152034 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 90a1ef8762a57f3f57007db2186099c026152034

"backtrace full/no-filters/hide" completer

"backtrace"'s completer now completes on command options:

 (gdb) bt -[TAB]
 -entry-values         -full                 -no-filters           -past-main
 -frame-arguments      -hide                 -past-entry           -raw-frame-arguments

But it doesn't know how to complete on qualifiers:

 (gdb) bt fu[TAB]
 funlockfile       futimens          futimes.c
 funlockfile.c     futimens.c        futimesat
 futex-internal.h  futimes           futimesat.c

This commit fixes that:

 (gdb) bt fu[TAB]ll
 (gdb) bt n[TAB]o-filters
 (gdb) bt h[TAB]ide

I considered teaching the gdb::option framework to handle non-'-'
options, but decided it wasn't worth it for this special case, and I'd
rather not make it easy to add new qualifier-like options.

gdb/ChangeLog:
2019-06-13  Pedro Alves  <palves@redhat.com>

	* stack.c (parse_backtrace_qualifiers): New.
	(backtrace_command): Use it.
	(backtrace_command_completer): Complete on qualifiers.

gdb/testsuite/ChangeLog:
2019-06-13  Pedro Alves  <palves@redhat.com>

	* gdb.base/options.exp (test-backtrace): Test completing qualifiers.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Make "backtrace" support -OPT options
@ 2019-06-13  3:03 sergiodj+buildbot
  2019-06-13  3:03 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2019-06-13  3:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d4c16835cad70bd8c04ff30d5d6f40ac65e7f7e1 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: d4c16835cad70bd8c04ff30d5d6f40ac65e7f7e1

Make "backtrace" support -OPT options

This adds support for comand options to the "backtrace" command.  We'll get:

  (gdb) bt -
  -entry-values         -hide                 -past-main
  -frame-arguments      -no-filters           -raw-frame-arguments
  -full                 -past-entry

~~~~
(gdb) help backtrace
Print backtrace of all stack frames, or innermost COUNT frames.
Usage: backtrace [OPTION]... [QUALIFIER]... [COUNT | -COUNT]

Options:
  -entry-values no|only|preferred|if-needed|both|compact|default
    Set printing of function arguments at function entry
    GDB can sometimes determine the values of function arguments at entry,
    in addition to their current values.  This option tells GDB whether
    to print the current value, the value at entry (marked as val@entry),
    or both.  Note that one or both of these values may be <optimized out>.

  -frame-arguments all|scalars|none
    Set printing of non-scalar frame arguments

  -raw-frame-arguments [on|off]
    Set whether to print frame arguments in raw form.
    If set, frame arguments are printed in raw form, bypassing any
    pretty-printers for that value.

  -past-main [on|off]
    Set whether backtraces should continue past "main".
    Normally the caller of "main" is not of interest, so GDB will terminate
    the backtrace at "main".  Set this if you need to see the rest
    of the stack trace.

  -past-entry [on|off]
    Set whether backtraces should continue past the entry point of a program.
    Normally there are no callers beyond the entry point of a program, so GDB
    will terminate the backtrace there.  Set this if you need to see
    the rest of the stack trace.

  -full
    Print values of local variables.

  -no-filters
    Prohibit frame filters from executing on a backtrace.

  -hide
    Causes Python frame filter elided frames to not be printed.

For backward compatibility, the following qualifiers are supported:

   full       - same as -full option.
   no-filters - same as -no-filters option.
   hide       - same as -hide.

With a negative COUNT, print outermost -COUNT frames.
~~~~

Implementation wise, this:

- Moves relevant options/settings globals to structures.
- Tweaks a number of functions to pass down references to such structures.
- Adds option_def structures describing the options/settings.
- Makes backtrace_command parse the options, with gdb::option::process_options.
- Tweaks "backtrace"'s help to describe the new options.
- Adds testcases.

Note that backtrace is a PROCESS_OPTIONS_UNKNOWN_IS_OPERAND command,
because of the "-COUNT" argument.

The COUNT/-COUNT argument is currently parsed as an expression.  I
considered whether it would be prudent here to require "--", but
concluded that the risk of causing a significant breakage here is much
lower compared to "print", since printing the expression is not the
whole point of the "backtrace" command.  Seems OK to me to require
typing "backtrace -past-main -- -p" if the user truly wants to refer
to the negative of a backtrace count stored in an inferior variable
called "p".

gdb/ChangeLog:
2019-06-13  Pedro Alves  <palves@redhat.com>

	* frame.c: Include "cli/cli-option.h.
	(user_set_backtrace_options): New.
	(backtrace_past_main, backtrace_past_entry, backtrace_limit):
	Delete.
	(get_prev_frame): Adjust.
	(boolean_option_def, uinteger_option_def)
	(set_backtrace_option_defs): New.
	(_initialize_frame): Adjust and use
	gdb::option::add_setshow_cmds_for_options to install "set
	backtrace past-main" and "set backtrace past-entry".
	* frame.h: Include "cli/cli-option.h".
	(struct frame_print_options): Forward declare.
	(print_frame_arguments_all, print_frame_arguments_scalars)
	(print_frame_arguments_none): Declare.
	(print_entry_values): Delete declaration.
	(struct frame_print_options, user_frame_print_options): New.
	(struct set_backtrace_options): New.
	(set_backtrace_option_defs, user_set_backtrace_options): Declare.
	* mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
	(mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
	(mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
	(list_args_or_locals): Add frame_print_options parameter.
	(mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
	* python/py-framefilter.c (enumerate_args): Pass down
	USER_FRAME_PRINT_OPTIONS.
	* stack.c: Include "cli/cli-option.h".
	(print_frame_arguments_all, print_frame_arguments_scalars)
	(print_frame_arguments_none): Declare.
	(print_raw_frame_arguments, print_entry_values): Delete.
	(user_frame_print_options): New.
	(boolean_option_def, enum_option_def, frame_print_option_defs):
	New.
	(struct backtrace_cmd_options): New.
	(bt_flag_option_def): New.
	(backtrace_command_option_defs): New.
	(print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
	(print_frame_arg, read_frame_arg, print_frame_args)
	(print_frame_info, print_frame): Add frame_print_options parameter
	and use it.
	(info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
	(backtrace_command_1): Add frame_print_options and
	backtrace_cmd_options parameters and use them.
	(make_backtrace_options_def_group): New.
	(backtrace_command): Process command options with
	gdb::option::process_options.
	(backtrace_command_completer): New.
	(_initialize_stack): Extend "backtrace"'s help to mention
	supported options.  Install completer for "backtrace".
	Install some settings commands with add_setshow_cmds_for_options.

gdb/testsuite/ChangeLog:
2019-06-13  Pedro Alves  <palves@redhat.com>

	* gdb.base/options.exp (test-backtrace): New.
	(top level): Call it.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] "set print raw frame-arguments" -> "set print raw-frame-arguments"
@ 2019-06-13  3:01 sergiodj+buildbot
  2019-06-13  3:01 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2019-06-13  3:01 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2daf894ed0baf72dd3f422b7a71630145568db30 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 2daf894ed0baf72dd3f422b7a71630145568db30

"set print raw frame-arguments" -> "set print raw-frame-arguments"

A following patch will introduce options for the "backtrace" command,
based on some "set print" and "set backtrace" settings.  There's one
setting in particular that is a bit annoying if we want to describe
the backtrace options and the settings commands using the same data
structures:

  "set print raw frame-arguments"

The problem is that space between "raw" and "frame-arguments".

Calling the option

  "bt -raw frame-arguments"

would be odd.  So I'm calling the option

  "bt -raw-frame-arguments"

instead.

And for consistency, this patch renames the set/show commands to:

 "set print raw-frame-arguments"
 "show print raw-frame-arguments"

I.e., dash instead of space.  The old commands are left in place, but
marked deprecated.

We need to adjust a couple testcases, because the relevant tests use
gdb_test_no_output and the old commands are no longer silent:

  (gdb) set print raw frame-arguments on
  Warning: command 'set print raw frame-arguments' is deprecated.
  Use 'set print raw-frame-arguments'.

gdb/ChangeLog:
2019-06-13  Pedro Alves  <palves@redhat.com>

	* NEWS (Changed commands): Mention set/show print raw-frame-arguments,
	and that "set/show print raw frame-arguments" are now deprecated.

	* cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
	command.
	* command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
	* stack.c (_initialize_stack): Install "set/show print
	raw-frame-arguments", and deprecate "set/show print raw
	frame-arguments".
	* valprint.c (_initialize_valprint): Deprecate "set/show print
	raw".

gdb/doc/ChangeLog:
2019-06-13  Pedro Alves  <palves@redhat.com>

	* gdb.texinfo (Print Settings): Document "set/show print
	raw-frame-arguments" instead of "set/show print raw
	frame-arguments".

gdb/testsuite/ChangeLog:
2019-06-13  Pedro Alves  <palves@redhat.com>

	* gdb.guile/scm-frame-args.exp: Use "set print
	raw-frame-arguments" instead of "set print raw frame-arguments".
	* gdb.python/py-frame-args.exp: Likewise.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Migrate rest of compile commands to new options framework
@ 2019-06-13  2:57 sergiodj+buildbot
  2019-06-13  2:59 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2019-06-13  2:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e6ed716cd5514c08b9d7c469d185b1aa177dbc22 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: e6ed716cd5514c08b9d7c469d185b1aa177dbc22

Migrate rest of compile commands to new options framework

As I was in the neighbourhood, I converted the other "compile"
subcommands to the new options framework too.  Specifically, "compile
code" and "compile file".

The user-visible changes are:

  - All abbreviations of "-raw" are accepted now, instead of just -r.
    Obviously that means "-ra" is now accepted.

  - Option completion now works.

  - "compile file" did not have a completer yet, and now it knows to
    complete on filenames.

  - You couldn't use "compile file" with a file named "-something".
    You can now, with "compile file -- -something".

gdb/ChangeLog:
2019-06-13  Pedro Alves  <palves@redhat.com>

	* compile/compile.c (struct compile_options): New.
	(compile_flag_option_def, compile_command_option_defs)
	(make_compile_options_def_group): New.
	(compile_file_command): Handle options with
	gdb::option::process_options.
	(compile_file_command_completer): New function.
	(compile_code_command): Handle options with
	gdb::option::process_options.
	(compile_code_command_completer): New function.
	(_initialize_compiler): Install completers for "compile code" and
	"compile file".  Mention available options in "compile code" and
	"compile code"'s help.
	* completer.c (advance_to_completion_word): New, factored out from
	...
	(advance_to_expression_complete_word_point): ... this.
	(advance_to_filename_complete_word_point): New.
	* completer.h (advance_to_filename_complete_word_point): New
	declaration.

gdb/testsuite/ChangeLog:
2019-06-13  Pedro Alves  <palves@redhat.com>

	* gdb.compile/compile.exp: Adjust expected output to option
	processing changes.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] [PATCH 44/57][Arm][OBJDUMP] Add support for MVE instructions: vcvt and vrint
@ 2019-05-16 16:12 sergiodj+buildbot
  2019-05-16 16:13 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2019-05-16 16:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bf0b396de71b76c02f6dd37e61e4044cdccb28d3 ***

Author: Andre Vieira <andre.simoesdiasvieira@arm.com>
Branch: master
Commit: bf0b396de71b76c02f6dd37e61e4044cdccb28d3

[PATCH 44/57][Arm][OBJDUMP] Add support for MVE instructions: vcvt and vrint

opcodes/ChangeLog:
2019-05-16  Andre Vieira  <andre.simoesdiasvieira@arm.com>
	    Michael Collison <michael.collison@arm.com>

	* arm-dis.c (enum mve_instructions): Add new instructions.
	(enum mve_unpredictable): Add new reasons.
	(enum mve_undefined): Likewise.
	(is_mve_encoding_conflict): Handle new instructions.
	(is_mve_undefined): Likewise.
	(is_mve_unpredictable): Likewise.
	(print_mve_undefined): Likewise.
	(print_mve_unpredictable): Likewise.
	(print_mve_rounding_mode): Likewise.
	(print_mve_vcvt_size): Likewise.
	(print_mve_size): Likewise.
	(print_insn_mve): Likewise.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] [PATCH 43/57][Arm][OBJDUMP] Add support for MVE instructions: scatter stores and gather loads
@ 2019-05-16 16:10 sergiodj+buildbot
  2019-05-16 16:10 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2019-05-16 16:10 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ef1576a1b5f14276b44ee4c0fc259832ca0dfd99 ***

Author: Andre Vieira <andre.simoesdiasvieira@arm.com>
Branch: master
Commit: ef1576a1b5f14276b44ee4c0fc259832ca0dfd99

[PATCH 43/57][Arm][OBJDUMP] Add support for MVE instructions: scatter stores and gather loads

opcodes/ChangeLog:
2019-05-16  Andre Vieira  <andre.simoesdiasvieira@arm.com>
	    Michael Collison <michael.collison@arm.com>

	* arm-dis.c (enum mve_instructions): Add new instructions.
	(enum mve_unpredictable): Add new reasons.
	(enum mve_undefined): Likewise.
	(is_mve_undefined): Handle new instructions.
	(is_mve_unpredictable): Likewise.
	(print_mve_undefined): Likewise.
	(print_mve_unpredictable): Likewise.
	(print_mve_size): Likewise.
	(print_insn_mve): Likewise.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] [PATCH 42/57][Arm][OBJDUMP] Add support for MVE instructions: vldr[bhw] and vstr[bhw]
@ 2019-05-16 16:08 sergiodj+buildbot
  2019-05-16 16:10 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2019-05-16 16:08 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT aef6d006581cab8a858e7abd36c57e73ea6e97a2 ***

Author: Andre Vieira <andre.simoesdiasvieira@arm.com>
Branch: master
Commit: aef6d006581cab8a858e7abd36c57e73ea6e97a2

[PATCH 42/57][Arm][OBJDUMP] Add support for MVE instructions: vldr[bhw] and vstr[bhw]

opcodes/ChangeLog:
2019-05-16  Andre Vieira  <andre.simoesdiasvieira@arm.com>
	    Michael Collison <michael.collison@arm.com>

	* arm-dis.c (enum mve_instructions): Add new instructions.
	(enum mve_undefined): Add new reasons.
	(insns): Add new instructions.
	(is_mve_encoding_conflict):
	(print_mve_vld_str_addr): New print function.
	(is_mve_undefined): Handle new instructions.
	(is_mve_unpredictable): Likewise.
	(print_mve_undefined): Likewise.
	(print_mve_size): Likewise.
	(print_insn_coprocessor_1): Handle MVE VLDR, VSTR instructions.
	(print_insn_mve):  Handle new operands.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] [PATCH 41/57][Arm][OBJDUMP] Add support for MVE instructions: vld[24] and vst[24]
@ 2019-05-16 16:06 sergiodj+buildbot
  2019-05-16 16:08 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2019-05-16 16:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 04d54ace12e77deb8b1d26541de0f2cbc11880f5 ***

Author: Andre Vieira <andre.simoesdiasvieira@arm.com>
Branch: master
Commit: 04d54ace12e77deb8b1d26541de0f2cbc11880f5

[PATCH 41/57][Arm][OBJDUMP] Add support for MVE instructions: vld[24] and vst[24]

opcodes/ChangeLog:
2019-05-16  Andre Vieira  <andre.simoesdiasvieira@arm.com>
	    Michael Collison <michael.collison@arm.com>

	* arm-dis.c (enum mve_instructions): Add new instructions.
	(enum mve_unpredictable): Add new reasons.
	(is_mve_encoding_conflict): Handle new instructions.
	(is_mve_unpredictable): Likewise.
	(mve_opcodes): Add new instructions.
	(print_mve_unpredictable): Handle new reasons.
	(print_mve_register_blocks): New print function.
	(print_mve_size): Handle new instructions.
	(print_insn_mve): Likewise.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] [PATCH 40/57][Arm][OBJDUMP] Add support for MVE instructions: vdup, veor, vfma, vfms, vhadd, vhsub and vrhadd
@ 2019-05-16 16:05 sergiodj+buildbot
  2019-05-16 16:06 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2019-05-16 16:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9743db035e9bc256b5accdcbdecd7d1e9b41d4be ***

Author: Andre Vieira <andre.simoesdiasvieira@arm.com>
Branch: master
Commit: 9743db035e9bc256b5accdcbdecd7d1e9b41d4be

[PATCH 40/57][Arm][OBJDUMP] Add support for MVE instructions: vdup, veor, vfma, vfms, vhadd, vhsub and vrhadd

opcodes/ChangeLog:
2019-05-16  Andre Vieira  <andre.simoesdiasvieira@arm.com>
	    Michael Collison <michael.collison@arm.com>

	* arm-dis.c (enum mve_instructions): Add new instructions.
	(enum mve_unpredictable): Add new reasons.
	(enum mve_undefined): Likewise.
	(is_mve_encoding_conflict): Handle new instructions.
	(is_mve_undefined): Likewise.
	(is_mve_unpredictable): Likewise.
	(coprocessor_opcodes): Move NEON VDUP from here...
	(neon_opcodes): ... to here.
	(mve_opcodes): Add new instructions.
	(print_mve_undefined):  Handle new reasons.
	(print_mve_unpredictable): Likewise.
	(print_mve_size): Handle new instructions.
	(print_insn_neon): Handle vdup.
	(print_insn_mve): Handle new operands.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] [PATCH 39/57][Arm][OBJDUMP] Add support for MVE instructions: vpt, vpst and vcmp
@ 2019-05-16 16:03 sergiodj+buildbot
  2019-05-16 16:05 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2019-05-16 16:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 143275ea7e56baf5ad7a736698b79a90b473183a ***

Author: Andre Vieira <andre.simoesdiasvieira@arm.com>
Branch: master
Commit: 143275ea7e56baf5ad7a736698b79a90b473183a

[PATCH 39/57][Arm][OBJDUMP] Add support for MVE instructions: vpt, vpst and vcmp

opcodes/ChangeLog:
2019-05-16  Andre Vieira  <andre.simoesdiasvieira@arm.com>
	    Michael Collison <michael.collison@arm.com>

	* arm-dis.c (enum mve_instructions): Add new instructions.
	(enum mve_unpredictable): Add new values.
	(mve_opcodes): Add new instructions.
	(vec_condnames): New array with vector conditions.
	(mve_predicatenames): New array with predicate suffixes.
	(mve_vec_sizename): New array with vector sizes.
	(enum vpt_pred_state): New enum with vector predication states.
	(struct vpt_block): New struct type for vpt blocks.
	(vpt_block_state): Global struct to keep track of state.
	(mve_extract_pred_mask): New helper function.
	(num_instructions_vpt_block): Likewise.
	(mark_outside_vpt_block): Likewise.
	(mark_inside_vpt_block): Likewise.
	(invert_next_predicate_state): Likewise.
	(update_next_predicate_state): Likewise.
	(update_vpt_block_state): Likewise.
	(is_vpt_instruction): Likewise.
	(is_mve_encoding_conflict): Add entries for new instructions.
	(is_mve_unpredictable): Likewise.
	(print_mve_unpredictable): Handle new cases.
	(print_instruction_predicate): Likewise.
	(print_mve_size): New function.
	(print_vec_condition): New function.
	(print_insn_mve): Handle vpt blocks and new print operands.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] [PATCH 38/57][Arm][OBJDUMP] Disable the use of MVE reserved coproc numbers in coprocessor instructions
@ 2019-05-16 16:01 sergiodj+buildbot
  2019-05-16 16:03 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2019-05-16 16:01 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f08d8ce3cd39f34f26dbc681d873e59a0d7e6780 ***

Author: Andre Vieira <andre.simoesdiasvieira@arm.com>
Branch: master
Commit: f08d8ce3cd39f34f26dbc681d873e59a0d7e6780

[PATCH 38/57][Arm][OBJDUMP] Disable the use of MVE reserved coproc numbers in coprocessor instructions

opcodes/ChangeLog:
2019-05-16  Andre Vieira  <andre.simoesdiasvieira@arm.com>

	* arm-dis.c (print_insn_coprocessor_1): Disable the use of coprocessors
	8, 14 and 15 for Armv8.1-M Mainline.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] [PATCH 37/57][Arm][OBJDUMP] Add framework for MVE instructions
@ 2019-05-16 15:59 sergiodj+buildbot
  2019-05-16 16:01 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2019-05-16 15:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 73cd51e51b294af9591ecc2e8a28a9bec4f466b3 ***

Author: Andre Vieira <andre.simoesdiasvieira@arm.com>
Branch: master
Commit: 73cd51e51b294af9591ecc2e8a28a9bec4f466b3

[PATCH 37/57][Arm][OBJDUMP] Add framework for MVE instructions

opcodes/ChangeLog:
2019-05-16  Andre Vieira  <andre.simoesdiasvieira@arm.com>
	    Michael Collison <michael.collison@arm.com>

	* arm-dis.c (enum mve_instructions): New enum.
	(enum mve_unpredictable): Likewise.
	(enum mve_undefined): Likewise.
	(struct mopcode32): New struct.
	(is_mve_okay_in_it): New function.
	(is_mve_architecture): Likewise.
	(arm_decode_field): Likewise.
	(arm_decode_field_multiple): Likewise.
	(is_mve_encoding_conflict): Likewise.
	(is_mve_undefined): Likewise.
	(is_mve_unpredictable): Likewise.
	(print_mve_undefined): Likewise.
	(print_mve_unpredictable): Likewise.
	(print_insn_coprocessor_1): Use arm_decode_field_multiple.
	(print_insn_mve): New function.
	(print_insn_thumb32): Handle MVE architecture.
	(select_arm_features): Force thumb for Armv8.1-m Mainline.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Fix style bug when paging
@ 2019-05-08 17:01 sergiodj+buildbot
  2019-05-08 17:59 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2019-05-08 17:01 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 99f20f08682ecc7be882774ff78409530802d000 ***

Author: Tom Tromey <tromey@adacore.com>
Branch: master
Commit: 99f20f08682ecc7be882774ff78409530802d000

Fix style bug when paging

Philippe pointed out a styling bug that would occur in some conditions
when paging:

    https://sourceware.org/ml/gdb-patches/2019-04/msg00101.html

I was finally able to reproduce this, and this patch fixes the bug.

The problem occurred when text overflowed the line, causing a
pagination prompt, but when no wrap column had been set.  In this
case, the current style was reset to show the prompt, but then not
reset back to the previously applied style before emitting the rest of
the line.

The fix is to record the applied style in this case, and re-apply it
afterward -- but only if the pager prompt was emitted, something that
the existing style.exp pointed out on the first, more naive, version
of the patch.

Tested on x86-64 Fedora 29.

gdb/ChangeLog
2019-05-08  Tom Tromey  <tromey@adacore.com>

	* utils.c (fputs_maybe_filtered): Reset style after paging, even
	when no wrap column is set.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Add linux_get_hwcap
@ 2019-03-25 16:55 sergiodj+buildbot
  2019-03-25 16:58 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2019-03-25 16:55 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0f83012ea0fb84d86d2a84a5feb51c0d63f0b7eb ***

Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: 0f83012ea0fb84d86d2a84a5feb51c0d63f0b7eb

Add linux_get_hwcap

Tidy up calls to read HWCAP (and HWCAP2) by adding common functions,
removing the PPC and AArch64 specific versions.

The only function difference is in aarch64_linux_core_read_description - if
the hwcap read fails it now return a valid description instead of nullptr.

gdb/ChangeLog:

2019-03-25  Alan Hayward  <alan.hayward@arm.com>

	* aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
	Call linux_get_hwcap.
	* aarch64-linux-tdep.c (aarch64_linux_core_read_description):
	Likewise.
	(aarch64_linux_get_hwcap): Remove function.
	* aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
	declaration.
	* arm-linux-nat.c (arm_linux_nat_target::read_description):Call
	linux_get_hwcap.
	* arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
	* linux-tdep.c (linux_get_hwcap): Add function.
	(linux_get_hwcap2): Likewise.
	* linux-tdep.h (linux_get_hwcap): Add declaration.
	(linux_get_hwcap2): Likewise.
	* ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
	(ppc_linux_get_hwcap2): Likewise.
	(ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
	linux_get_hwcap.
	(ppc_linux_nat_target::insert_watchpoint): Likewise.
	(ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
	(ppc_linux_nat_target::read_description): Likewise.
	* ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
	* s390-linux-nat.c: Likewise.
	* s390-linux-tdep.c (s390_core_read_description): Likewise.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] gdb: Improve scoped_switch_fork_info class
@ 2019-01-10 17:12 sergiodj+buildbot
  2019-01-10 17:12 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2019-01-10 17:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1ef8573cc77c91feeef3edab74d383d20809eb33 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 1ef8573cc77c91feeef3edab74d383d20809eb33

gdb: Improve scoped_switch_fork_info class

After committing this patch I got this feedback:

   https://sourceware.org/ml/gdb-patches/2019-01/msg00181.html

This patch makes the constructor of scoped_switch_fork_info explicit,
and wraps the core of the destructor in a TRY/CATCH block.

I've run this through the testsuite on X86-64/GNU Linux, however, this
code is not exercised, so this patch is untested.

gdb/ChangeLog:

	* linux-fork.c (scoped_switch_fork_info)
	<scoped_switch_fork_info>: Make explicit.
	<~scoped_switch_fork_info>: Wrap core in TRY/CATCH.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Sync libiberty sources with master version in gcc repository. Updated stabs demangling and cxxfilt tests to match.
@ 2019-01-07 13:26 sergiodj+buildbot
  2019-01-07 13:26 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2019-01-07 13:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 053af8c9034f92d6e36a1180655ba22a65c56437 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 053af8c9034f92d6e36a1180655ba22a65c56437

Sync libiberty sources with master version in gcc repository.  Updated stabs demangling and cxxfilt tests to match.

	PR 24044
	* stabs.c (parse_stab_argtypes): Remove call to
	cplus_mangle_opcode.
	* testsuite/binutils-all/cxxfilt.exp: Replace tests of v2 encoding
	with v3 encoding.  Add escape for known failures.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Fix a crash in jit.c
@ 2018-12-28 23:52 sergiodj+buildbot
  2018-12-29  0:20 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-12-28 23:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2cd8cc0b66ca297bce4d08e4f712f86d9f1a2fb6 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 2cd8cc0b66ca297bce4d08e4f712f86d9f1a2fb6

Fix a crash in jit.c

A user at Mozilla pointed out a crash in jit.c.  In his situation, an
inferior using the JIT API exec'd an executable that did not use it.
This caused an assertion failure when jit.c:free_objfile_data called
delete_breakpoint with NULL.

This patch fixes the problem in the obvious way.  New test case
included.

gdb/ChangeLog
2018-12-28  Tom Tromey  <tom@tromey.com>

	* jit.c (free_objfile_data): Only delete breakpoint if non-null.

gdb/testsuite/ChangeLog
2018-12-28  Tom Tromey  <tom@tromey.com>
	    Simon Marchi <simark@simark.ca>

	* gdb.base/jit-exec.exp: New file.
	* gdb.base/jit-exec.c: New file.
	* gdb.base/jit-execd.c: New file.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Document the "set style" commands
@ 2018-12-28 23:46 sergiodj+buildbot
  2018-12-29  0:13 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-12-28 23:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 140a4bc099820c909da0eac1df0f56ec468ad3dd ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 140a4bc099820c909da0eac1df0f56ec468ad3dd

Document the "set style" commands

This documents the new "set style" commands.

gdb/ChangeLog
2018-12-28  Tom Tromey  <tom@tromey.com>

	* NEWS: Mention terminal styling.

gdb/doc/ChangeLog
2018-12-28  Tom Tromey  <tom@tromey.com>

	* gdb.texinfo (Output Styling): New node.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Highlight source code using GNU Source Highlight
@ 2018-12-28 23:31 sergiodj+buildbot
  2018-12-29  0:02 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-12-28 23:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 62f29fda90cf1d5a1899f57ef78452471c707fd6 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 62f29fda90cf1d5a1899f57ef78452471c707fd6

Highlight source code using GNU Source Highlight

This changes gdb to highlight source using GNU Source Highlight, if it
is available.

This affects the output of the "list" command and also the TUI source
window.

No new test because I didn't see a way to make it work when Source
Highlight is not found.

gdb/ChangeLog
2018-12-28  Tom Tromey  <tom@tromey.com>

	* utils.h (can_emit_style_escape): Declare.
	* utils.c (can_emit_style_escape): No longer static.
	* cli/cli-style.c (set_style_enabled): New function.
	(_initialize_cli_style): Use it.
	* tui/tui-winsource.c (tui_show_source_line): Use tui_puts.
	(tui_alloc_source_buffer): Change how source lines are allocated.
	* tui/tui-source.c (copy_source_line): New function.
	(tui_set_source_content): Use source cache.
	* tui/tui-io.h (tui_puts): Update.
	* tui/tui-io.c (tui_puts_internal): Add window parameter.
	(tui_puts): Likewise.
	(tui_redisplay_readline): Update.
	* tui/tui-data.c (free_content_elements): Change how source window
	contents are freed.
	* source.c (forget_cached_source_info): Clear the source cache.
	(print_source_lines_base): Use the source cache.
	* source-cache.h: New file.
	* source-cache.c: New file.
	* configure.ac: Check for GNU Source Highlight library.
	* configure: Update.
	* config.in: Update.
	* Makefile.in (SRCHIGH_LIBS, SRCHIGH_CFLAGS): New variables.
	(INTERNAL_CFLAGS_BASE): Add SRCHIGH_CFLAGS.
	(CLIBS): Add SRCHIGH_LIBS.
	(COMMON_SFILES): Add source-cache.c.
	(HFILES_NO_SRCDIR): Add source-cache.h.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Avoid "Invalid parameter passed to C runtime function" warning
@ 2018-11-20 16:57 sergiodj+buildbot
  2018-11-20 16:57 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-11-20 16:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 970d89d8fdd84b31decaf3bd84e785aad057ea32 ***

Author: Eli Zaretskii <eliz@gnu.org>
Branch: master
Commit: 970d89d8fdd84b31decaf3bd84e785aad057ea32

Avoid "Invalid parameter passed to C runtime function" warning

This warning was displayed by OutputDebugString on MinGW when
GDB was being debugged natively.

gdb/ChangeLog:

	* common/filestuff.c (gdb_fopen_cloexec): Disable use of "e" mode
	with 'fopen' also if O_CLOEXEC is equal to O_NOINHERIT, to cater
	to MinGW fixed by Gnulib.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] [ARC] More fixes for TLS.
@ 2018-11-09 15:43 sergiodj+buildbot
  2018-11-09 15:44 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-11-09 15:43 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d07b621f4cc585607c7eee7cc58ce54a7dde52f5 ***

Author: Cupertino Miranda <cmiranda@synopsys.com>
Branch: master
Commit: d07b621f4cc585607c7eee7cc58ce54a7dde52f5

[ARC] More fixes for TLS.

Added warning for static TLS reloc.

Fixed issue related to TLS and partial static linking of libraries:
  This issue was detected when throwing exceptions in C++ while linking with
  -static-libstdc++.
  TLS relocation from the libstdc++ wasn't being patched as local now that it was
  static linked with the executable.

Fix for TLS with static and pie. Problem introduced by earlier patch:
  Fixes the following glibc tests:
   - elf/tst-tls1-static

bfd/
    xxxx-xx-xx  Cupertino Miranda  <cmiranda@synopsys.com>

	    * arc-got.h (arc_got_entry_type_for_reloc): Changed to
	      correct static TLS relocs.
            * elf32-arc.c (elf_arc_check_relocs): Introduced warning to
	      TLS relocs which require -fPIC.
	      (arc_create_forced_local_got_entries_for_tls): Created.
	      Traverses list of GOT entries to be resolved statically
	      when needed.
	      (elf_arc_finish_dynamic_sections): Changed. Calls
	      arc_create_forced_local_got_entries_for_tls for each known
	      possibly GOT symbol.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Remove unused variable in record-btrace.c
@ 2018-09-12 19:01 sergiodj+buildbot
  2018-09-12 19:01 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-12 19:01 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8ec235834d454a66a89fe16bc62e11497eb79078 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 8ec235834d454a66a89fe16bc62e11497eb79078

Remove unused variable in record-btrace.c

old_inferior_ptid is unused, this is caught by a gcc built from git
recently, not sure about previous versions:

/home/emaisin/src/binutils-gdb/gdb/record-btrace.c: In function frame_info* get_thread_current_frame(thread_info*):
/home/emaisin/src/binutils-gdb/gdb/record-btrace.c:1974:10: error: unused variable old_inferior_ptid [-Werror=unused-variable]
1974 |   ptid_t old_inferior_ptid;
     |          ^~~~~~~~~~~~~~~~~

gdb/ChangeLog:

	* record-btrace.c (get_thread_current_frame): Remove
	old_inferior_ptid.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] (Ada) Fix resolving of homonym components in tagged types
@ 2018-09-12 14:53 sergiodj+buildbot
  2018-09-12 14:53 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-12 14:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1f5d1570c0eaadbb72d450211f70b24c4c23ac8e ***

Author: Jerome Guitton <guitton@adacore.com>
Branch: master
Commit: 1f5d1570c0eaadbb72d450211f70b24c4c23ac8e

(Ada) Fix resolving of homonym components in tagged types

ada_value_struct_elt is used when displaying a component (say, 'N') of
a record object (say, 'Obj') of type, say, 't1'. Now if Obj is tagged
(Ada parlance: "tagged types" are what other object-oriented languages
call "classes"), then 'N' may not be visible in the current view and
we need to look for it in its actual type. We do that at the same time
as resolving variable-length fields. This would typically be done by
the following call to ada_value_struct_elt, with the last parameter
check_tag set to 1:

      t1 = ada_to_fixed_type (ada_get_base_type (t1), NULL,
                              address, NULL, 1);

This is the general logic, but recently we introduced a special case
to handle homonyms. Different components may have the same name in a
tagged type.  For instance:

       type Top_T is tagged record
          N : Integer := 1;
       end record;

       type Middle_T is new Top.Top_T with record
          N : Character := 'a';
       end record;

Middle_T extends Top_T and both define a (different) component with
the same name ('N'). In such a case, using the actual type of a
Middle_T object would create a confusion, since we would have two
component 'N' in this actual type.

So, to handle homonyms, we convert t1 to the actual type *if
and only if* N cannot be found in the current view. For example, if Obj
has been created as a Middle_T but is seen as a Top_T'Class at our
point of execution, then "print Obj.N" will display the integer field
defined in Top_T's declaration.

Now, even if we find N in the current view, we still have to get a
fixed type: for instance, the record can be unconstrained and we still
need a fixed type to get the proper offset to each field. That is
to say, in this case:

   type Dyn_Top_T (Disc : Natural) is tagged record
      S : Integer_Array (1 .. Disc) := (others => Disc);
      N : Integer := 1;
   end record;

   type Dyn_Middle_T is new Dyn_Top.Dyn_Top_T with record
      N : Character := 'a';
      U : Integer := 42;
   end record;

If we have an object Obj of type Dyn_Middle_T and we want to display
U, we don't need to build, from its tag, a real type with all its real
fields. In other words, we don't need to add the parent components:
Disc, S, and the integer N. We only need to access U and it is
directly visible in Dyn_Middle_T. So no tag handling. However, we do
need to build a fixed-size type to have the proper offset to U (since
this offset to U depends on the size of Obj.S, which itself is dynamic
and depends on the value of Obj.Disc).

We accidentally lost some of this treatment when we introduced the
resolution of homonyms. This patch re-install this part by uncoupling
the tag resolution from the "fixing" of variable-length components.

This change also slightly simplifies the non-tagged case: in the
non-tagged case, no need to set check_tag to 1, since we already know
that there is no tag.

gdb/ChangeLog:

	* ada-lang.c (ada_value_struct_elt): Call ada_to_fixed_type
	with check_tag to 1 if and only if the type is tagged and the
	component being searched cannot been found in the current
	view. Otherwise, always call ada_to_fixed_type with
	check_tag to 0.

gdb/testsuite/ChangeLog:

	* gdb.ada/same_component_name: Add test for case of tagged record
	with variable-length fields.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] (Ada) Cleanup code by using ada_is_access_to_unconstrained_array call.
@ 2018-09-12 12:16 sergiodj+buildbot
  2018-09-12 12:25 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-12 12:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d91e9ea81dce83259f2a7f32f43876373f3e7981 ***

Author: Xavier Roirand <roirand@adacore.com>
Branch: master
Commit: d91e9ea81dce83259f2a7f32f43876373f3e7981

(Ada) Cleanup code by using ada_is_access_to_unconstrained_array call.

This patch just avoids code duplication by using a function we
introduced recently (ada_is_access_to_unconstrained_array).

gdb/ChangeLog:

    * ada-lang.c (ada_is_access_to_unconstrained_array): Remove static
    declaration.
    * ada-lang.h: add ada_is_access_to_unconstrained_array prototype.
    * ada-varobj.c (ada_varobj_get_number_of_children,
    ada_varobj_describe_child, ada_value_is_changeable_p): Cleanup code.

Tested on x86_64-linux.
No new testcase provided, as this is just a refactoring.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] (Ada) Fix printing of access to unconstrained arrays
@ 2018-09-12 12:06 sergiodj+buildbot
  2018-09-12 12:10 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-12 12:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cc330e39bc938cefd4cfc581639177ef4c6bcbe3 ***

Author: Xavier Roirand <roirand@adacore.com>
Branch: master
Commit: cc330e39bc938cefd4cfc581639177ef4c6bcbe3

(Ada) Fix printing of access to unconstrained arrays

Using this Ada code:

    type String_Access is access String;
    type Array_Of_String is array (1 .. 2) of String_Access;
    Aos : Array_Of_String := (new String'("ab"), new String'("cd"));

When debugging with GDB, printing each Aos element displays:

    (gdb) print Aos(1)
    $2 = "ab"
    (gdb) print Aos(2)
    $3 = "cd"

Whereas it should display:

    (gdb) print Aos(1)
    $2 = (foo_r118_024.string_access) 0x635018
    (gdb) print Aos(2)
    $3 = (foo_r118_024.string_access) 0x635038

Notice that printing the entire array works:

(gdb) print Aos
$1 = (0x635018, 0x635038)

The problem was located in ada_value_print function and due to the fact
that the value_type used in this function was based on
value_enclosing_type rather than value_type itself.
In our example, the difference between the value_type and the
value_enclosing_type of the value is that the value_type contains an
additional typedef layer which is not present in the value_enclosing_type.
This typedef layer is GNAT's way to specify that the element is, at the
source level, an access to the unconstrained array, rather than the
unconstrained array.
Moreover, the value_enclosing_type is not really needed in that case and
the value_type can be used instead in this function, and this patch fixes
this.

gdb/ChangeLog:

    * ada-valprint.c (ada_value_print): Use type instead of
    enclosing type.

testsuite/ChangeLog:

    * gdb.ada/access_to_unbounded_array.exp: New testcase.
    * gdb.ada/access_to_unbounded_array/foo.adb: New file.
    * gdb.ada/access_to_unbounded_array/pack.adb: New file.
    * gdb.ada/access_to_unbounded_array/pack.ads: New file.

Tested: x86_64-linux


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] (Ada/MI) Fix -var-evaluate-expression for access to unconstrained arrays
@ 2018-09-12 11:37 sergiodj+buildbot
  2018-09-12 11:53 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-12 11:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b9c50e9a9ac48662b2132583c52d46976efb3512 ***

Author: Xavier Roirand <roirand@adacore.com>
Branch: master
Commit: b9c50e9a9ac48662b2132583c52d46976efb3512

(Ada/MI) Fix -var-evaluate-expression for access to unconstrained arrays

Using this Ada code:

   type String_Access is access String;
   type Array_Of_String is array (1 .. 2) of String_Access;
   Aos : Array_Of_String := (new String'("ab"), new String'("cd"));

In GDB/MI mode, create a variable which type is Aos, evaluate it:

(gdb) -var-create var1 * Aos
^done,name="var1",numchild="2",value="[2]",type="bar.array_of_string",thread-id="1",has_more="0"

Now print it:

(gdb) -var-list-children 1 var1
^done,numchild="2",children=[child={name="var1.1",exp="1",numchild="1",value="[2] \"ab\"", type="bar.string_access",thread-id="1"},child={name="var1.2",exp="2",numchild="1",value="[2] \"cd\"", type="bar.string_access",thread-id="1"}],has_more="0"

But printed fields "value" are wrong, since it should be:

^done,numchild="2",children=[child={name="var1.1",exp="1",numchild="1",value="0x634018",type="bar.string_access",thread-id="1"},child={name="var1.2",exp="2",numchild="1",value="0x634038",type="bar.string_access",thread-id="1"}],has_more="0"^M

Print each child of var1:

(gdb) -var-evaluate-expression var1.1
^done,value="[2] \"ab\""
(gdb) -var-evaluate-expression var1.2
^done,value="[2] \"cd\""

Whereas it should be

(gdb) -var-evaluate-expression var1.1
^done,value="0x635018"
(gdb) -var-evaluate-expression var1.2
^done,value="0x635038"

This patch fixes this.

gdb/ChangeLog:

        * ada-lang.c (ada_value_subscript): Handle case when parameter is
        an array of access to unconstrained array.

testsuite/ChangeLog

        * gdb.ada/mi_string_access.exp: New testcase.
        * gdb.ada/mi_string_access/bar.adb: New file.
        * gdb.ada/mi_string_access/pck.adb: New file.
        * gdb.ada/mi_string_access/pck.asd: New file.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] (Ada) New function ada_is_access_to_unconstrained_array
@ 2018-09-12 11:28 sergiodj+buildbot
  2018-09-12 11:28 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-12 11:28 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 736ade86ea3dd3df31120b6c617d64c88bcc86c1 ***

Author: Xavier Roirand <roirand@adacore.com>
Branch: master
Commit: 736ade86ea3dd3df31120b6c617d64c88bcc86c1

(Ada) New function ada_is_access_to_unconstrained_array

Add a new function to check if a given type is an access to an
unconstrained array. This function contains code that is present only
once in the current sources but will be used in a future patch.

gdb/ChangeLog:

        * ada-lang.c (ada_is_access_to_unconstrained_array): New function.
        (ada_check_typedef): Use it.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] (Ada) Fix -var-list-children MI command for union type
@ 2018-09-11 21:36 sergiodj+buildbot
  2018-09-12  4:31 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-11 21:36 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2963898f38dab323a9e381d7c41a26b9c3498882 ***

Author: Xavier Roirand <roirand@adacore.com>
Branch: master
Commit: 2963898f38dab323a9e381d7c41a26b9c3498882

(Ada) Fix -var-list-children MI command for union type

Using this Ada code:

   type Union_Type (A : Boolean := False) is record
      case A is
         when True  => B : Integer;
         when False => C : Float;
      end case;
   end record;
   pragma Unchecked_Union (Union_Type);
   Ut : Union_Type := (A => True, B => 3);

In GDB/MI mode, once creating a varobj from variable "Ut" as follow:

(gdb) -var-create var1 * ut
^done,name="var1",numchild="2",value="{...}",type="foo.union_type",thread-id="1",has_more="0"

Printing the list of its children displays:

(gdb) -var-list-children 1 var1
^error,msg="Duplicate variable object name"

Whereas it should be

(gdb) -var-list-children 1 var1
^done,numchild="2",children=[child={name="var1.b",exp="b",numchild="0",value="3",type="integer",thread-id="1"},child={name="var1.c",exp="c",numchild="0",value="4.20389539e-45",type="float",thread-id="1"}],has_more="0"

The problem occurs because ada_varobj_describe_struct_child wasn't
handling unions.  This patch fixes this.

gdb/ChangeLog:

        * ada-varobj.c (ada_varobj_describe_struct_child)
        (ada_varobj_describe_child): Handle union case like struct one.

testsuite/ChangeLog

        * gdb.ada/mi_var_union.exp: New testcase.
        * gdb.ada/mi_var_union/bar.adb: New file.
        * gdb.ada/mi_var_union/pck.adb: New file.
        * gdb.ada/mi_var_union/pck.asd: New file.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Fix help text for "python" command
@ 2018-09-11 15:00 sergiodj+buildbot
  2018-09-11 15:15 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-11 15:00 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a154931ef1ef1c588c0e7da5e5fd4658c5dd28f5 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: a154931ef1ef1c588c0e7da5e5fd4658c5dd28f5

Fix help text for "python" command

PR python/18380 points out that the example in the "help python" text
will only work in Python 2.  This changes the example to be valid
syntax for both Python 2 and Python 3.

gdb/ChangeLog
2018-09-10  Tom Tromey  <tom@tromey.com>

	PR python/18380:
	* python/python.c (_initialize_python): Make example in "python"
	help work in Python 3.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Fix "make install-strip" failure to install gdb-add-index.sh
@ 2018-09-11 12:01 sergiodj+buildbot
  2018-09-11 12:04 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-11 12:01 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 23c4651c060c123493de004ef61d8ed052d46113 ***

Author: Eli Zaretskii <eliz@gnu.org>
Branch: master
Commit: 23c4651c060c123493de004ef61d8ed052d46113

Fix "make install-strip" failure to install gdb-add-index.sh

gdb/ChangeLog:
2018-09-10  Eli Zaretskii  <eliz@gnu.org>

	* Makefile.in (transformed_name): Use INSTALL_SCRIPT instead of
	INSTALL_PROGRAM to install gdb-add-index.sh.  Don't append
	$(EXEEXT) to the script, as it is not a program.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Allow a pretty-printer without a to_string method
@ 2018-09-10 16:47 sergiodj+buildbot
  2018-09-10 16:59 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-10 16:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 332cf4c9251a31f0addc2ce2970c9a8bb0c16f96 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 332cf4c9251a31f0addc2ce2970c9a8bb0c16f96

Allow a pretty-printer without a to_string method

PR python/16047 points out that, while the documentation says that the
to_string method is optional for a pretty-printer, the code disagrees
and throws an exception.  This patch fixes the problem.  varobj is
already ok here.

Tested on x86-64 Fedora 26.

gdb/ChangeLog
2018-09-08  Tom Tromey  <tom@tromey.com>

	PR python/16047:
	* python/py-prettyprint.c (pretty_print_one_value): Check for
	to_string method.

gdb/testsuite/ChangeLog
2018-09-08  Tom Tromey  <tom@tromey.com>

	PR python/16047:
	* gdb.python/py-prettyprint.py (pp_int_typedef3): New class.
	(register_pretty_printers): Register new printer.
	* gdb.python/py-prettyprint.exp (run_lang_tests): Add int_type3
	test.
	* gdb.python/py-prettyprint.c (int_type3): New typedef.
	(an_int_type3): New global.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] (Ada) fix handling of expression with parameterless function call
@ 2018-09-10 10:42 sergiodj+buildbot
  2018-09-10 13:52 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-10 10:42 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 424da6cf3b30b889ff577b1babd09777148dc0e0 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 424da6cf3b30b889ff577b1babd09777148dc0e0

(Ada) fix handling of expression with parameterless function call

Consider the following function, which takes no parameter and returns
an integer:

    function Something return Integer;

For the purpose of this discussion, our function has been implemented
to always return 124:

    function Something return Integer is
    begin
       return 124;
    end Something;

In Ada, such function can been called without using the parentheses.
For instance, in the statement below, variable My_Value is assigned
the returned value from the call to Something:

    My_Value := Something;

The Ada expression interpeter in GDB supports this case, as we can
see below:

    (gdb) print something
    $1 = 124

However, we get fairly strange results when trying to use this feature
as part of a larger expression. For instance:

    (gdb) print something + 1
    $2 = 248

The problem occurs while doing the resolution pass of the expression.
After prefixying the expression, we obtain the following expression:

    0  BINOP_ADD
    1    OP_VAR_VALUE          Block @0x2021550, symbol @0x20213a0 (pck.something)
    5    OP_LONG               Type @0x1e3c170 (int), value 1 (0x1)

The resolution pass is then expected to remove the OP_VAR_VALUE
entry, and replace it with an OP_FUNCALL. This is what the call
to replace_operator_with_call in ada-lang.c::resolve_subexp is
expected to do:

      if (deprocedure_p
          && (TYPE_CODE (SYMBOL_TYPE (exp->elts[pc + 2].symbol))
              == TYPE_CODE_FUNC))
        {
          replace_operator_with_call (expp, pc, 0, 0,
                                      exp->elts[pc + 2].symbol,
                                      exp->elts[pc + 1].block);
          exp = expp->get ();
        }

The problem is that we're passing OPLEN (zero -- 4th parameter in
the call), and so replace_operator_with_call ends up removing zero
element from our expression, and inserting the corresponding OP_FUNCALL
instead. As a result, instead of having the OP_LONG (1) as the second
argument of the BINOP_ADD, it is now the OP_VAR_VALUE that we were
meant to replace. That OP_VAR_VALUE then itself gets transformed into
an OP_FUNCALL, with the same issue, and eventually, the resolved
expression now looks like this:

     0  BINOP_ADD
     1    OP_FUNCALL            Number of args: 0
     4      OP_VAR_VALUE          Block @0x2021550, symbol @0x20213a0 (pck.something)
     8    OP_FUNCALL            Number of args: 0
    11      OP_VAR_VALUE          Block @0x2021550, symbol @0x20213a0 (pck.something)
    15  OP_VAR_VALUE          Block @0x2021550, symbol @0x20213a0 (pck.something)
    19  OP_LONG               Type @0x1e3c170 (int), value 1 (0x1)

This explains why we get twice the result of the function call
instead of its value plus one. The extra entries in the expression
at the end are just ignored.

This patch fixes the issue by calling replace_operator_with_call
with the correct OPLEN equal to the size of an OP_VAR_VALUE (4).

gdb/ChangeLog:

        * ada-lang.c (resolve_subexp): Pass correct OPLEN in call to
        replace_operator_with_call.

gdb/testsuite/ChangeLog:

        * gdb.ada/expr_with_funcall: New testcase.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] ada-lang.c::ada_value_cast: remove unnecessary parentheses
@ 2018-09-10  9:19 sergiodj+buildbot
  2018-09-10  9:22 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-10  9:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 95f39a5b2755e5aaaceb6248e585f8a593542331 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 95f39a5b2755e5aaaceb6248e585f8a593542331

ada-lang.c::ada_value_cast: remove unnecessary parentheses

No other code change.

gdb/ChangeLog:

        * ada-lang.c (ada_value_cast): Remove unnecessary parentheses.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] (Ada) slightly incorrect bounds for type of array indexed by enum
@ 2018-09-10  9:00 sergiodj+buildbot
  2018-09-10  9:00 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-10  9:00 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 16b9eb7bfa56f060d183aa44165bf75cb3c414d8 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 16b9eb7bfa56f060d183aa44165bf75cb3c414d8

(Ada) slightly incorrect bounds for type of array indexed by enum

Consider the following code:

   type Enumerated is (Enum_A, Enum_B, Enum_C, Enum_Last);
   type Table is array (Enumerated) of Integer;
   --  Declare a variable of type Table to make sure the compiler
   --  does emit the debugging information for that type.
   V : Table := (others => 1);

Trying to print the type description of type Table, or of variable V
yields:

    (gdb) ptype v
    type = array (0 .. 3) of integer
    (gdb) ptype example.table
    type = array (0 .. 3) of integer

The compiler generates an XA type for the bounds...

 <1><cf6>: Abbrev Number: 13 (DW_TAG_structure_type)
    <cf7>   DW_AT_name        : example__table___XA

... whose member is described as being as:

 <2><cfe>: Abbrev Number: 14 (DW_TAG_member)
    <cff>   DW_AT_name        : example__enumerated
    <d05>   DW_AT_type        : <0xc69>

This leads us to DIE 0xc69, which is our enumeration type:

 <2><c69>: Abbrev Number: 4 (DW_TAG_enumeration_type)
    <c6a>   DW_AT_name        : example__enumerated

Normally, for arrays, we expect a range type, rather than an enumerated
type. However, for a situation like this, where the range of the array
index is the full enumeration type, it seems like a waste to require
an extra range layer.

Instead, looking at print_range, we see that we print the bounds
of our range using the target type:

       target_type = TYPE_TARGET_TYPE (type);
       if (target_type == NULL)
         target_type = type;
       [...]
       ada_print_scalar (target_type, lo, stream);
       fprintf_filtered (stream, " .. ");
       ada_print_scalar (target_type, hi, stream);

In this case, this causes us to use the enumerated type's subtype,
which is a plain integer type, hence the output we get. However,
there is no reason for using the target type, even in the TYPE_CODE_RANGE
situation. So this patch fixes the issue by simply printing the bounds
using the type being given, instead of its target type.

gdb/ChangeLog:

        * ada-typeprint.c (print_range): Print the bounds using TYPE
        rather than its TYPE_TARGET_TYPE.

A new test for this isn't necessary, as existing tests will demonstrate
this issue once a change in the compiler triggering the generation of
this type of debugging info gets pushed.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] minor reformatting in ada-lang.c::ada_to_fixed_value
@ 2018-09-10  7:38 sergiodj+buildbot
  2018-09-10  8:18 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-10  7:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d8ce91275e421dfe57aa4e79bb9a58824c155e96 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: d8ce91275e421dfe57aa4e79bb9a58824c155e96

minor reformatting in ada-lang.c::ada_to_fixed_value

The arguments in the call to ada_to_fixed_value_create where
improperly aligned. But I also noticed that all the arguments
do fit on a single-line (up to 79 characters). So this patch
just fixes the code by putting everything on that same line.

gdb/ChangeLog:

        * ada-lang.c (ada_to_fixed_value): Minor reformatting in
        call to ada_to_fixed_value_create.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Handle PPC64 function descriptor in Ada decoding
@ 2018-09-10  7:19 sergiodj+buildbot
  2018-09-10  7:21 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-10  7:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0d81f350ec01630ef7cd9ae4385a1dc504c54d73 ***

Author: Jerome Guitton <guitton@adacore.com>
Branch: master
Commit: 0d81f350ec01630ef7cd9ae4385a1dc504c54d73

Handle PPC64 function descriptor in Ada decoding

On PPC64, the entry point of the function "FN" is ".FN" when a function
descriptor is used. One of the consequences of this is that GDB then
presents the name of the function to the user (eg: in backtraces) with
the leading dot, which is a low-level internal detail that the user
should not be seeing.  The Ada decoding should strip it.

gdb/ChangeLog:

	* ada-lang.c (ada_decode): strip dot prefix in symbol name.

No testcase added, as a number of existing testcases should already
demonstrate that problem.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] (Ada) "catch assert" spurious internal error
@ 2018-09-10  5:17 sergiodj+buildbot
  2018-09-10  7:19 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-10  5:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 57aff202b4b17a05d73e71680a26fe12a817f110 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 57aff202b4b17a05d73e71680a26fe12a817f110

(Ada) "catch assert" spurious internal error

We noticed while debugging a program compiled without assertions
enabled and using an older compiler that inserting a catchpoint
on failed assertions would cause an internal error:

    (gdb) catch assert
    ../../src/gdb/ada-lang.c:13321: internal-error: ada_exception_sal:
    Assertion`sym != NULL' failed.
    A problem internal to GDB has been detected,

This is due to a combination of factors:

  1. With older versions of the compiler, the function used as a hook
     was provided by a unit that's different from the unit which
     provides the hooks for the other exception catchpoints.

  2. The program either does not use any assertion, or is compiled
     without the assertions enabled.

With newer versions of the compiler, all such functions are provided
by the same unit, so should normally always be available.  However,
there can still be reasons why this is not the case. Consider, for
instance, the case of a runtime compiled with -ffunction-sections,
in which case the hook might be eliminated unless assertions are
used and enabled.

So this patch transforms the internal error into a simple error.

gdb/ChangeLog:

        * ada-lang.c (ada_exception_sal): Replace gdb_assert calls
        by calls to error.

No testcase added, as the existing testcase gdb.ada/catch_ex.exp
should trigger it when using an older version of GNAT as the Ada
compiler.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] (Ada) infinite loop when hitting unhandled exception catchpoint
@ 2018-09-10  3:54 sergiodj+buildbot
  2018-09-10  3:02 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-10  3:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fb44b1a737ee7d53d5d88c4f2a3d449e8084d6c2 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: fb44b1a737ee7d53d5d88c4f2a3d449e8084d6c2

(Ada) infinite loop when hitting unhandled exception catchpoint

When debugging a program compiled with an older version of GNAT,
hitting a catchpoint on unhandled exceptions can caused GDB to
got into an infinite loop. This happens while trying to find
the name of the exception that was raised. For that, it searches
for a frame corresponding to a specific function we know gets
called during the exeption handling.

In our particular case, the compiler was too old, and so GDB never
found that frame, and eventually got past the "main" subprogram,
all the way to system frames, where no symbol was available.
As a result, the code addresses could not be resolved into
a function name, leading to the infinite loop because of
a misplaced update of our loop variable "fi":

    while (fi != NULL)
      {
        char *func_name;
        enum language func_lang;

        find_frame_funname (fi, &func_name, &func_lang, NULL);
        if (func_name != NULL)
          {
            make_cleanup (xfree, func_name);

            if (strcmp (func_name,
                        data->exception_info->catch_exception_sym) == 0)
              break; /* We found the frame we were looking for...  */
            fi = get_prev_frame (fi);
          }
      }

If FUNC_NAME is NULL, then FI never gets updated ever after!

gdb/ChangeLog:

        * ada-lang.c (ada_unhandled_exception_name_addr_from_raise):
        Move update of loop variable "fi".

No testcase added, as the existing testcase gdb.ada/catch_ex.exp
should trigger it when using an older version of GNAT as the Ada
compiler.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] (Ada) assigning packed array aggregate with variable as component
@ 2018-09-10  0:24 sergiodj+buildbot
  2018-09-10  1:27 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-10  0:24 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2a62dfa93f1980fd8d5b0651753c550942fa30b6 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 2a62dfa93f1980fd8d5b0651753c550942fa30b6

(Ada) assigning packed array aggregate with variable as component

Consider a variable "PRA" defined as a packed array of packed
records as follow:

   subtype Int is Integer range 0 .. 7;
   type Packed_Rec is record
      X, Y : Int;
      W    : Integer;
   end record;
   pragma Pack (Packed_Rec);
   type Packed_RecArr is array (Integer range <>) of Packed_Rec;
   pragma Pack (Packed_RecArr);

   PRA : Packed_RecArr (1 .. 3);

Consider also a variable "PR", which is a Packed_Rec record,
declared as follow:

   PR : Packed_Rec := (2, 2, 2);

Trying to assign a new value to PRA using an aggregate expression
where one of the components is our variable PR yields the wrong
result on big-endian machines (e.g. on ppc-linux):

    (gdb) p pra := (pr, (2,2,2), (2,2,2))
    $6 = ((x => 1, y => 0, w => 8), [...]

On the other hand, replacing "pr" by "(2,2,2)" does work.

I tracked the issue down to the bit offset we use to extract
the value of "PR" and copy it inside PRA. in value_assign_to_component,
we have:

  if (gdbarch_bits_big_endian (get_type_arch (value_type (container))))
    move_bits ([target buffer], [bit offset in target buffer],
               [source buffer where PR is stored],
               TYPE_LENGTH (value_type (component)) * TARGET_CHAR_BIT - bits,
               bits, 1);

The issue is with the third-to-last argument, which provides the bit
offset where the value of PR is stored relative to its start address,
and therefore the bit offset relative to the start of the source
buffer passed as the previous argument.

In our case, component is a 38bit packed record whose TYPE_LENGTH
is 5 bytes, so the bit-offset that gets calculated is 2 (bits).
However, that formula only really applies to scalars, whereas
in our case, we have a record (struct). The offset in the non-scalar
case should be zero.

gdb/ChangeLog:

        * ada-lang.c (value_assign_to_component): In the case of
        big-endian targets, extract the bits of the given VAL
        using an src_offset of zero if container is not a scalar.

gdb/testsuite/ChangeLog:

        * gdb.ada/packed_array_assign: New testcase.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] gdb: Add builtin types for 24 bit integers.
@ 2018-09-09 11:13 sergiodj+buildbot
  2018-09-09 13:16 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-09 11:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d1908f2d6b9f161b6a31449e83e1b671acb99620 ***

Author: John Darrington <john@darrington.wattle.id.au>
Branch: master
Commit: d1908f2d6b9f161b6a31449e83e1b671acb99620

gdb: Add builtin types for 24 bit integers.

Add int24 and uint24.  These are used by the upcoming S12Z target, but will be
needed for any arch which features 24 bit registers.

* gdb/gdbtypes.h (struct builtin_type): New members builtin_int24
  and builtin_uint24;
* gdb/gdbtypes.c: Initialize them.
* gdb/doc/gdb.texinfo (Predefined Target Types): Mention types int24 and uint24.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] S12Z: Make disassebler work for --enable-targets=all config.
@ 2018-09-09  7:50 sergiodj+buildbot
  2018-09-09  7:33 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-09  7:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9da4dfd6816fa2198bd80fd6a7b12fef4d6c8361 ***

Author: John Darrington <john@darrington.wattle.id.au>
Branch: master
Commit: 9da4dfd6816fa2198bd80fd6a7b12fef4d6c8361

S12Z: Make disassebler work for --enable-targets=all config.

    opcodes/
    * disassemble.c (ARCH_s12z): Define if ARCH_all.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] gdb/testsuite: Make test names unique in gdb.base/watchpoint.exp
@ 2018-09-09  4:35 sergiodj+buildbot
  2018-09-09  4:35 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-09  4:35 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 96b6697fd807428f3832bdab1527ad55156e88d7 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 96b6697fd807428f3832bdab1527ad55156e88d7

gdb/testsuite: Make test names unique in gdb.base/watchpoint.exp

Extend test names and add test name prefixes to make test names
unique.

gdb/testsuite/ChangeLog:

	* gdb.base/watchpoint.exp (test_complex_watchpoint): Extend test
	names, and add test prefixes to make test names unique.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Generate NT_PROCSTAT_{AUXV, VMMAP, PS_STRINGS} in FreeBSD coredumps
@ 2018-09-09  0:05 sergiodj+buildbot
  2018-09-09  0:05 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-09  0:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 739ab2e92e1840c9285f3cfce1f1236c0fa68730 ***

Author: Simon Ser <contact@emersion.fr>
Branch: master
Commit: 739ab2e92e1840c9285f3cfce1f1236c0fa68730

Generate NT_PROCSTAT_{AUXV,VMMAP,PS_STRINGS} in FreeBSD coredumps

gcore generates NT_AUXV and NT_FILE notes for Linux targets.  On
FreeBSD auxv is stored in a NT_PROCSTAT_AUXV section, virtual memory
mappings are stored in a NT_PROCSTAT_VMMAP, and both are prefixed with
the struct size.  In addition, store a NT_PROCSTAT_PS_STRINGS note
saving the initial location of the argv[] and environment[] arrays.

gdb/ChangeLog:

	PR gdb/23105
	* fbsd-nat.c (fbsd_nat_target::xfer_partial): Add support for
	TARGET_OBJECT_FREEBSD_VMMAP and TARGET_OBJECT_FREEBSD_PS_STRINGS.
	* fbsd-tdep.c (fbsd_make_note_desc): New.
	(fbsd_make_corefile_notes): Write NT_PROCSTAT_AUXV,
	NT_PROCSTAT_VMMAP and NT_PROCSTAT_PS_STRINGS notes.
	* target.h (enum target_object) Add FreeBSD-specific
	TARGET_OBJECT_FREEBSD_VMMAP and TARGET_OBJECT_FREEBSD_PS_STRINGS.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] compile: Remove non-const reference parameters
@ 2018-09-08 22:13 sergiodj+buildbot
  2018-09-08 22:14 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-08 22:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d82b3862f1218134f5301ed990c6db48fcb82b2f ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: d82b3862f1218134f5301ed990c6db48fcb82b2f

compile: Remove non-const reference parameters

As mentioned here:

  https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#Avoid_non-const_reference_parameters.2C_use_pointers_instead

we prefer to avoid non-const references.  This patch changes the
non-const references I could find in the compile/ directory, either by
making them rvalue-reference (&&) or changing them to pointers.

I'd say all the changes are pretty obvious, except the one in
compile_cplus_instance::enter_scope which might require more attention.

gdb/ChangeLog:

	* compile/compile-c.h (generate_c_for_variable_locations):
	Change reference to pointer.
	* compile/compile-c-support.c (compile_program) <compute>:
	Likewise.
	* compile/compile-c-symbols.c (generate_vla_size): Likewise.
	(generate_c_for_for_one_variable): Likewise
	(generate_c_for_variable_locations): Likewise
	* compile/compile-c-types.c (compile_c_instance::convert_type):
	Likewise
	* compile/compile-cplus-symbols.c (convert_one_symbol):
	std::move the scope passed to enter_scope.
	* compile/compile-cplus-types.c
	(compile_cplus_instance::enter_scope): Make parameter
	rvalue-reference.
	(compile_cplus_instance::new_scope): Change reference to
	pointer.
	(compile_cplus_instance::convert_type): Likewise
	(compile_cplus_convert_typedef): std::move the scope passed to
	enter_scope.
	(compile_cplus_convert_struct_or_union): Likewise.
	(compile_cplus_convert_enum): Likewise.
	(compile_cplus_convert_namespace): Likewise.
	* compile/compile-cplus.h (compile_cplus_instance)
	<enter_scope>: Make parameter rvalue-reference.
	* compile/compile-internal.h (compile_instance)
	<get_cached_type>: Likewise
	* compile/compile-loc2c.c (push): Likewise
	(pushf): Likewise
	(unary): Likewise
	(binary): Likewise
	(print_label): Likewise
	(pushf_register_address): Likewise
	(pushf_register): Likewise
	(do_compile_dwarf_expr_to_c): Likewise
	(compile_dwarf_expr_to_c): Likewise
	(compile_dwarf_bounds_to_c): Likewise
	* compile/compile.c (compile_instance::get_cached_type):
	Likewise
	* compile/compile.h (compile_dwarf_expr_to_c): Likewise.
	(compile_dwarf_bounds_to_c): Likewise
	* dwarf2loc.c (locexpr_generate_c_location): Likewise.
	(dwarf2_compile_property_to_c): Likewise
	* dwarf2loc.h (dwarf2_compile_property_to_c): Likewise
	* symtab.h (struct symbol_computed_ops) <generate_c_location>:
	Likewise


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Remove unused tui_win_element::highlight
@ 2018-09-08 22:11 sergiodj+buildbot
  2018-09-08 22:12 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-08 22:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cc5a5ae5b7ea576bb8bf4bbebeaa70366851eacd ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: cc5a5ae5b7ea576bb8bf4bbebeaa70366851eacd

Remove unused tui_win_element::highlight

gdb/ChangeLog:

	* tui/tui-data.h (struct tui_win_element) <highlight>: Remove.
	* tui/tui-data.c (init_content_element): Don't initialize it.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Remove unused tui_win_info::detail::opaque
@ 2018-09-08 17:19 sergiodj+buildbot
  2018-09-08 21:53 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-08 17:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 137be54029ed2d2fc95120bba2af88311e5a198a ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 137be54029ed2d2fc95120bba2af88311e5a198a

Remove unused tui_win_info::detail::opaque

gdb/ChangeLog:

	* tui/tui-data.h (struct tui_win_info)
	<detail::opaque>: Remove.
	* tui/tui-data.c (init_win_info): Remove assignment.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] PR23570, AVR .noinit section defaults to PROGBITS
@ 2018-09-08 11:43 sergiodj+buildbot
  2018-09-08 11:45 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-08 11:43 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT deee88e9810fe5a3e73b071713ff6fa03b5c016d ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: deee88e9810fe5a3e73b071713ff6fa03b5c016d

PR23570, AVR .noinit section defaults to PROGBITS

Revert commit 8744470deab and instead use the standard special_sections
support.

	PR 23570
bfd/
	* elf32-avr.c (elf_avr_special_sections): New.
	(elf_backend_special_sections): Define.
gas/
	* config/tc-avr.c: Revert 2018-09-03 change.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Make -Wformat-nonliteral work with gcc
@ 2018-09-08  8:49 sergiodj+buildbot
  2018-09-08  9:02 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-08  8:49 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f1628857d783fee0171f16f1bad0b7816460dec5 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: f1628857d783fee0171f16f1bad0b7816460dec5

Make -Wformat-nonliteral work with gcc

After looking into why the build failed for Simon but not for me, we
found that the underlying cause was due to how gcc treats
-Wformat-nonliteral.  gcc requires -Wformat to be given first; but
warning.m4 was not doing this, so -Wformat-nonliteral was not being
used.

This patch changes warning.m4 to account gcc's requirement.

This then showed that the target-float.c build change in the earlier
Makefile patch was also incorrect.  Simon didn't see this in his
build, but gcc now points it out.  So, this patch fixes this problem
as well.

2018-09-05  Tom Tromey  <tom@tromey.com>

	* warning.m4 (AM_GDB_WARNINGS): Add -Wformat when testing
	-Wformat-nonliteral.
	* target-float.c (host_float_ops<T>::to_string)
	(host_float_ops<T>::from_string): Use
	DIAGNOSTIC_IGNORE_FORMAT_NONLITERAL.
	* configure: Rebuild.

gdb/gdbserver/ChangeLog
2018-09-05  Tom Tromey  <tom@tromey.com>

	* configure: Rebuild.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Disable -Wformat-nonliteral in parts of printcmd.c
@ 2018-09-08  8:41 sergiodj+buildbot
  2018-09-08  8:42 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-08  8:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT af39b1c216ffb11e6ca8e8607b00749e0fc1ab41 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: af39b1c216ffb11e6ca8e8607b00749e0fc1ab41

Disable -Wformat-nonliteral in parts of printcmd.c

commit 3322c5d9a1 ("Remove unneeded explicit .o targets") broke the
build with clang, because -Wno-format-nonliteral was in fact needed.
This patch fixes the problem by introducing
DIAGNOSTIC_IGNORE_FORMAT_NONLITERAL and using it in printcmd.c.  This
seems preferable to reverting the patch because now the warning
suppression is more targeted.

gdb/ChangeLog
2018-09-05  Simon Marchi  <simon.marchi@ericsson.com>

	* printcmd.c (printf_c_string): Use
	DIAGNOSTIC_IGNORE_FORMAT_NONLITERAL.
	(printf_wide_c_string, printf_pointer, ui_printf): Likewise.

include/ChangeLog
2018-09-05  Simon Marchi  <simon.marchi@ericsson.com>

	* diagnostics.h (DIAGNOSTIC_IGNORE_FORMAT_NONLITERAL): New macro.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Remove unnecessary casts from cli-cmds.c
@ 2018-09-07 15:23 sergiodj+buildbot
  2018-09-07 17:04 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-07 15:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 081bca4d622143b229cf02a1dda4afb9b457eefa ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 081bca4d622143b229cf02a1dda4afb9b457eefa

Remove unnecessary casts from cli-cmds.c

I noticed a couple of unnecessary casts in cli-cmds.c.  This patch
removes them.

Tested by rebuilding.  I'm checking this in.

gdb/ChangeLog
2018-09-05  Tom Tromey  <tom@tromey.com>

	* cli/cli-cmds.c (shell_escape, edit_command): Remove cast.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] [gdb/exp] Handle DW_OP_GNU_variable_value refs to abstract dies
@ 2018-09-07  3:16 sergiodj+buildbot
  2018-09-07  4:12 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-07  3:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e4a62c65fa8fe6a48b6ff564f45c1ac535f10f14 ***

Author: Tom de Vries <tdevries@suse.de>
Branch: master
Commit: e4a62c65fa8fe6a48b6ff564f45c1ac535f10f14

[gdb/exp] Handle DW_OP_GNU_variable_value refs to abstract dies

Consider a vla variable 'a' in function f1:
...
 <2><1a7>: Abbrev Number: 11 (DW_TAG_variable)
    <1a8>   DW_AT_description : a
    <1aa>   DW_AT_abstract_origin: <0x311>
...
with abstract origin 'a':
...
 <2><311>: Abbrev Number: 3 (DW_TAG_variable)
    <312>   DW_AT_name        : a
    <317>   DW_AT_type        : <0x325>
...
and inherited abstract vla type:
...
 <1><325>: Abbrev Number: 9 (DW_TAG_array_type)
    <326>   DW_AT_type        : <0x33a>
 <2><32e>: Abbrev Number: 10 (DW_TAG_subrange_type)
    <32f>   DW_AT_type        : <0x2ea>
    <333>   DW_AT_upper_bound : 5 byte block: fd 1b 3 0 0
                                (DW_OP_GNU_variable_value: <0x31b>)
...
where the upper bound refers to this artificial variable D.1922 without location
attribute:
...
 <2><31b>: Abbrev Number: 8 (DW_TAG_variable)
    <31c>   DW_AT_description : (indirect string, offset: 0x39a): D.1922
    <320>   DW_AT_type        : <0x2ea>
    <324>   DW_AT_artificial  : 1
...

Currently, when we execute "p sizeof (a)" in f1, the upper bound is calculated
by evaluating the DW_OP_GNU_variable_value expression referring to D.1922, but
since that die doesn't have a location attribute, we get:
...
value has been optimized out
...

However, there's also artificial variable D.4283 that is sibling of vla
variable 'a', has artificial variable D.1922 as abstract origin, and has a
location attribute:
...
 <2><1ae>: Abbrev Number: 12 (DW_TAG_variable)
    <1af>   DW_AT_description : (indirect string, offset: 0x1f8): D.4283
    <1b3>   DW_AT_abstract_origin: <0x31b>
    <1b7>   DW_AT_location    : 11 byte block: 75 1 8 20 24 8 20 26 31 1c 9f
                                (DW_OP_breg5 (rdi):1; DW_OP_const1u: 32;
				 DW_OP_shl; DW_OP_const1u: 32; DW_OP_shra;
				 DW_OP_lit1; DW_OP_minus; DW_OP_stack_value)
...

The intended behaviour for DW_OP_GNU_variable_value is to find a die that
refers to D.1922 as abstract origin, has a location attribute and is
'in scope', so the expected behaviour is:
...
$1 = 6
...

The 'in scope' concept can be thought of as variable D.1922 having name
attribute "D.1922", and variable D.4283 inheriting that attribute, resulting
in D.4283 being declared with name "D.1922" alongside vla a in f1, and when we
lookup "DW_OP_GNU_variable_value D.1922", it should work as if we try to find
the value of a variable named "D.1922" on the gdb command line using
"p D.1922", and we should return the value of D.4283.

This patch fixes the case described above, by:
- adding a field abstract_to_concrete to struct dwarf2_per_objfile,
- using that field to keep track of which concrete dies are instances of an
  abstract die, and
- using that information when getting the value DW_OP_GNU_variable_value.

Build and reg-tested on x86_64-linux.

2018-09-05  Tom de Vries  <tdevries@suse.de>

	* dwarf2loc.c (sect_variable_value): Call indirect_synthetic_pointer
	with resolve_abstract_p == true.
	(indirect_synthetic_pointer): Add resolve_abstract_p parameter,
	defaulting to false. Propagate resolve_abstract_p to
	dwarf2_fetch_die_loc_sect_off.
	* dwarf2loc.h (dwarf2_fetch_die_loc_sect_off): Add resolve_abstract_p
	parameter, defaulting to false.
	* dwarf2read.c (read_variable): Add variable to abstract_to_concrete.
	(dwarf2_fetch_die_loc_sect_off): Add and handle resolve_abstract_p
	parameter.
	* dwarf2read.h (struct die_info): Forward-declare.
	(die_info_ptr): New typedef.
	(struct dwarf2_per_objfile): Add abstract_to_concrete field.

	* gdb.dwarf2/varval.exp: Add test.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] bfd, sparc: avoid duplicated error messages on invalid relocations.
@ 2018-09-06  3:54 sergiodj+buildbot
  2018-09-06  3:54 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-06  3:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e920c014ecd9fbb630c76576d2771aa4631d93f7 ***

Author: Jose E. Marchesi <jose.marchesi@oracle.com>
Branch: master
Commit: e920c014ecd9fbb630c76576d2771aa4631d93f7

bfd, sparc: avoid duplicated error messages on invalid relocations.

This patch avoids a duplicated error message when an invalid
relocation number is read from an object file in sparc-* ELF targets:

$ strip -g test.o
strip: test.o: unsupported relocation type 0xd7
strip: test.o: unsupported relocation type 0xd7
strip: test.o: bad value

Tested in x86_64-linux-gnu, sparc64-linux-gnu and sparc-linux-gnu
targets.

bfd/ChangeLog:

2018-09-04  Jose E. Marchesi  <jose.marchesi@oracle.com>

	* elfxx-sparc.c (_bfd_sparc_elf_info_to_howto): Do not issue an
	error when an invalid relocation is passed;  this is already done
	by `_bfd_sparc_elf_info_to_howto_ptr'.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] bfd, sparc: issue an error when reading relocations with invalid symbol references.
@ 2018-09-06  3:53 sergiodj+buildbot
  2018-09-06  3:53 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-06  3:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8410d65b77164d020a45cc9aa17a0147dc76862d ***

Author: Jose E. Marchesi <jose.marchesi@oracle.com>
Branch: master
Commit: 8410d65b77164d020a45cc9aa17a0147dc76862d

bfd, sparc: issue an error when reading relocations with invalid symbol references.

The function `elf64_sparc_slurp_one_reloc_table' in elf64-sparc.c
currently checks that the symbol indexes read in the r_sym fields of
relocations are in range.  This is done for both dynamic and
non-dynamic symbols.  This avoids subsequent invalid memory accesses.
However, no error is issued to the user.

This patch makes BFD to issue an error when the read symbol index is
out of range, following the same behavior implemented in both the
generic ELF routines and other ELF backends (such as mips64).

Tested in x86_64-linux-gnu, sparc64-linux-gnu, and
--enable-targets=all.

2018-09-04  Jose E. Marchesi  <jose.marchesi@oracle.com>

            * elf64-sparc.c (elf64_sparc_slurp_one_reloc_table): Issue an
            error when an invalid symbol index is retrieved in ELF64_R_SYM of
            a relocation seen in an input file.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Automatically update "aclocal_m4_deps" when updating gnulib
@ 2018-09-05 22:50 sergiodj+buildbot
  2018-09-05 23:25 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-05 22:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fcc9b044b7f563023633a9964810e76f4cde40d4 ***

Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: fcc9b044b7f563023633a9964810e76f4cde40d4

Automatically update "aclocal_m4_deps" when updating gnulib

When we update gnulib using our "update-gnulib.sh" tool, it doesn't
automatically update the list of M4 files present at
gnulib/Makefile.in:aclocal_m4_deps.  This patch extends the tool to do
that.  It also puts "aclocal_m4_deps" in its own file (a Makefile
fragment), so that it's easier to update it programatically.

Tested by generating the file and diff'ing the results against the
current version of "aclocal_m4_deps".

gdb/ChangeLog:
2018-09-04  Sergio Durigan Junior  <sergiodj@redhat.com>
	    Pedro Alves  <palves@redhat.com>

	* gnulib/Makefile.in (aclocal_m4_deps): Move to
	"aclocal-m4-deps.mk".  Include file here.
	$(srcdir)/aclocal.m4: Add "configure.ac".
	* gnulib/aclocal-m4-deps.mk: New file.
	* gnulib/update-gnulib.sh: Automatically update
	"aclocal-m4-deps.mk".


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Remove --enable-multi-ice
@ 2018-09-05 15:50 sergiodj+buildbot
  2018-09-05 15:54 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-05 15:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d53d543682d9add652a82d267681cf6426aded42 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: d53d543682d9add652a82d267681cf6426aded42

Remove --enable-multi-ice

gdb's configure script accepts --enable-multi-ice, but the code this
refers to is long gone.  This patch removes the option entirely.

gdb/ChangeLog
2018-09-04  Tom Tromey  <tom@tromey.com>

	* configure: Rebuild.
	* configure.ac: Remove multi-ice code.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Simplify ada-exp.o rule
@ 2018-09-05 15:32 sergiodj+buildbot
  2018-09-05 15:33 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-05 15:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8dc9fd87b0965f24e21922f295c4af9c3f624985 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 8dc9fd87b0965f24e21922f295c4af9c3f624985

Simplify ada-exp.o rule

The ada-exp.o rule no longer needs to pass -Wno-old-style-definition
to the compiler, as this option has no meaning in C++.  So, This patch
simplifies the explicit ada-exp.o rule in the Makefile.  The rule is
still needed because, according to the comment, ada-exp.c may appear
in the srcdir.

gdb/ChangeLog
2018-09-04  Tom Tromey  <tom@tromey.com>

	* Makefile.in (GDB_WARN_CFLAGS_NO_DEFS): Remove.
	(ada-exp.o): Update.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Remove unneeded explicit .o targets
@ 2018-09-05 15:02 sergiodj+buildbot
  2018-09-05 15:32 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-05 15:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3322c5d9a102f9af099bd87cc65a1e2a70f91c78 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 3322c5d9a102f9af099bd87cc65a1e2a70f91c78

Remove unneeded explicit .o targets

Makefile.in had special cases to compile printcmd.o and target-float.o
with a different set of warnings.  However, this is no longer
required, so this patch removes those rules.

gdb/ChangeLog
2018-09-04  Tom Tromey  <tom@tromey.com>

	* Makefile.in (printcmd.o, target-float.o): Remove.
	(GDB_WARN_CFLAGS_NO_FORMAT): Remove.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Remove obsolete comments from Makefiles
@ 2018-09-05 12:05 sergiodj+buildbot
  2018-09-05 13:06 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-05 12:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ba2bf2aaba97866f4c9c67239666916caa7bb150 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: ba2bf2aaba97866f4c9c67239666916caa7bb150

Remove obsolete comments from Makefiles

This removes an obsolete comment from Makefile.in.  This was copied
into gnulib/Makefile.in, so this removes that comment as well.

gdb/ChangeLog
2018-09-04  Tom Tromey  <tom@tromey.com>

	* gnulib/Makefile.in: Remove obsolete comment.
	* Makefile.in: Remove obsolete comment.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Fix batch exit status test failure on Fedora 28
@ 2018-09-05  9:57 sergiodj+buildbot
  2018-09-05  9:55 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-05  9:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT dd083ee23d23903e8bc595b64aa8ea62379491cd ***

Author: Gary Benson <gbenson@redhat.com>
Branch: master
Commit: dd083ee23d23903e8bc595b64aa8ea62379491cd

Fix batch exit status test failure on Fedora 28

This commit adds calls to remote_close and clear_gdb_spawn_id to
gdb.base/batch-exit-status.exp, fixing failures reported by buildbot
on Fedora 28 where gdb_spawn_id not being reset by the previous test
caused default_gdb_spawn to return without spawning.

This commit also changes the test to use detect GDB's exit using
gdb_test_multiple expecting 'eof', rather than using 'wait -i' alone.
This means the testcase won't hang forever on failure as fixed in
gdb.base/quit.exp by commit 15763a09d4ae ("Fix 'gdb.base/quit.exp
hangs forever' if the test fails").

gdb/testsuite/ChangeLog:

	* gdb.base/batch-exit-status.exp: Use gdb_test_multiple and expect
	'eof' before 'wait -i'.  Use remote_close and clear_gdb_spawn_id.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] gdb/riscv: Fix an ARI warning
@ 2018-09-05  9:07 sergiodj+buildbot
  2018-09-05  8:44 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-05  9:07 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6c9d681b07e32d07f7ca0774360be62bbf065b82 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 6c9d681b07e32d07f7ca0774360be62bbf065b82

gdb/riscv: Fix an ARI warning

This patch fixes an ARI violation in riscv-tdep.c (line ends with
'+').

gdb/ChangeLog:

	* riscv-tdep.c (riscv_frame_cache): Fix ARI warning, don't end a
	line with '+'.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] gdb/riscv: Provide non-DWARF stack unwinder
@ 2018-09-04 20:01 sergiodj+buildbot
  2018-09-04 20:01 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-04 20:01 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 78a3b0fab8200fdca2b1b934645c29e7bd502d36 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 78a3b0fab8200fdca2b1b934645c29e7bd502d36

gdb/riscv: Provide non-DWARF stack unwinder

Collects information during the prologue scan and uses this to unwind
registers when no DWARF information is available.

This patch has been tested by disabling the DWARF stack unwinders, and
running the complete GDB testsuite against a range of RISC-V targets.
The results are comparable to running with the DWARF unwinders in
place.

gdb/ChangeLog:

	* riscv-tdep.c: Add 'prologue-value.h' include.
	(struct riscv_unwind_cache): New struct.
	(riscv_debug_unwinder): New global.
	(riscv_scan_prologue): Update arguments, capture register details
	from prologue scan.
	(riscv_skip_prologue): Reformat arguments line, move end of
	prologue calculation into riscv_scan_prologue.
	(riscv_frame_cache): Update return type, create
	riscv_unwind_cache, scan the prologue, and fill in remaining cache
	details.
	(riscv_frame_this_id): Use frame id computed in riscv_frame_cache.
	(riscv_frame_prev_register): Use the trad_frame within the
	riscv_unwind_cache.
	(_initialize_riscv_tdep): Add 'set/show debug riscv unwinder'
	flag.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] gdb: Extend the trad-frame API
@ 2018-09-04 19:39 sergiodj+buildbot
  2018-09-04 19:55 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-04 19:39 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 23e60e7a4ea772eabb6ae4788913e228763755cf ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 23e60e7a4ea772eabb6ae4788913e228763755cf

gdb: Extend the trad-frame API

Adds two new functions to the trad-frame API and update the internals
of trad-frame to use the new functions.  These functions will be used
in later commits.

gdb/ChangeLog:

	* trad-frame.h (trad_frame_set_realreg): Declare.
	(trad_frame_set_addr): Declare.
	* trad-frame.c (trad_frame_set_realreg): Define new function.
	(trad_frame_set_addr): Define new function.
	(trad_frame_set_reg_realreg): Use new function.
	(trad_frame_set_reg_addr): Use new function.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] PR23595, simple objcopy of executable failure for msp430-elf
@ 2018-09-04 18:26 sergiodj+buildbot
  2018-09-04 18:34 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-04 18:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2542e49e21e6b7270f72c7be0fc4ff1a986371da ***

Author: Jozef Lawrynowicz <jozef.l@mittosystems.com>
Branch: master
Commit: 2542e49e21e6b7270f72c7be0fc4ff1a986371da

PR23595, simple objcopy of executable failure for msp430-elf

VMA of the first section in the segment containing the ELF file header
(and possibly section headers too) can't be used to reliably find the
size of the headers plus padding.  What's really needed is sh_offset
of the first section assuming it has contents (vma does have a
relationship to sh_offset, but is only guaranteed in demand paged
executables).

If the first section is SHT_NOBITS and it hasn't been converted to
have file contents by the existence of a following SHT_PROGBITS
section in the same segment, the sh_offset value also isn't reliable.

	PR 23595
	elf.c (copy_elf_program_header): When first segment contains
	only the headers and SHT_NOBITS sections, use segment p_filesz
	to calculate header and padding size.  Use filepos of the first
	section otherwise.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Fix ARI violations in c++compile
@ 2018-09-03 17:01 sergiodj+buildbot
  2018-09-03 17:24 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-03 17:01 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5c889512f325e0447a6182f70cfa7e1d9e407167 ***

Author: Keith Seitz <keiths@redhat.com>
Branch: master
Commit: 5c889512f325e0447a6182f70cfa7e1d9e407167

Fix ARI violations in c++compile

This patch fixes two violations of the ARI (use of ATTRIBUTE_UNUSED and
"%ll").

gdb/ChangeLog

	* compile/compile-cplus-types.c (compile_cplus_debug_output_1): Use
	pulongest instead of "%lld".
	* compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol): Remove
	ATTRIBUTE_UNUSED.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Allow an IR object with unknown architecture
@ 2018-09-02  6:57 sergiodj+buildbot
  2018-09-02  7:30 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-02  6:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b986869b6605e45044626c5b3111390ac4e70b82 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: b986869b6605e45044626c5b3111390ac4e70b82

Allow an IR object with unknown architecture

An IR object may have an unknown architecture.  But it is compatible
with other architecture.

	PR ld/23600
	* archures.c (bfd_arch_get_compatible): Allow an IR object with
	unknown architecture.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] RISC-V: Correct the requirement of compressed floating point instructions
@ 2018-09-01  4:41 sergiodj+buildbot
  2018-09-01  4:41 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-01  4:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT be192bc284b329fa0b38646bd3df9a02b880a704 ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: be192bc284b329fa0b38646bd3df9a02b880a704

RISC-V: Correct the requirement of compressed floating point instructions

2018-08-31  Kito Cheng  <kito@andestech.com>
gas/
	* testsuite/gas/riscv/c-fld-fsd-fail.d: New.
	* testsuite/gas/riscv/c-fld-fsd-fail.l: Likewise.
	* testsuite/gas/riscv/c-fld-fsd-fail.s: Likewise.
opcodes/
	* riscv-opc.c (riscv_opcodes): Fix incorrect subset info for
	compressed floating point instructions.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Set TYPE_LENGTH on a variant part
@ 2018-09-01  3:00 sergiodj+buildbot
  2018-09-01  2:54 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-01  3:00 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c8c81635739435a31860ff5f1e49743d80321f43 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: c8c81635739435a31860ff5f1e49743d80321f43

Set TYPE_LENGTH on a variant part

gdb represents a DW_TAG_variant_part as a union.  While normally DWARF
would not set the size of a DW_TAG_variant_part, gdb's representation
requires the TYPE_LENGTH to be set.

This patch arranges to set the TYPE_LENGTH of a variant part if it has
not already been set.

This fixes some Rust regressions when testing against a version of
rustc that emits DW_TAG_variant_part.

gdb/ChangeLog
2018-08-31  Tom Tromey  <tom@tromey.com>

	* dwarf2read.c (dwarf2_add_field): Set the TYPE_LENGTH of the
	variant part type.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Fix a small bug in gdb.rust/simple.rs
@ 2018-09-01  1:47 sergiodj+buildbot
  2018-09-01  1:47 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-09-01  1:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT aef9346c25b0a0c665bce793c00797f5ab82ed37 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: aef9346c25b0a0c665bce793c00797f5ab82ed37

Fix a small bug in gdb.rust/simple.rs

I noticed that gdb.rust/simple.rs had two local variables named "v".
This didn't previous cause problems, but with a newer rust compiler
this resulted in a test failure.  (It should have failed all along, so
I suppose earlier passes were due to a compiler bug.)

This patch renames the second variable.

gdb/testsuite/ChangeLog
2018-08-31  Tom Tromey  <tom@tromey.com>

	* gdb.rust/simple.rs: Rename second variable "v".


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Regenerate gdbarch.h
@ 2018-08-31 23:08 sergiodj+buildbot
  2018-08-31 23:20 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-08-31 23:08 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0c8885885ab1d62971bbae22d4b5e335c31b19c9 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 0c8885885ab1d62971bbae22d4b5e335c31b19c9

Regenerate gdbarch.h

The previous commit included a stale gdbarch.h from an earlier version
of that patch by mistake.

gdb/ChangeLog:
2018-08-31  Pedro Alves  <palves@redhat.com>

	* gdbarch.h: Regenerate.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Add comment describing continuable/steppable/non-steppable watchpoints
@ 2018-08-31 22:25 sergiodj+buildbot
  2018-08-31 22:25 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-08-31 22:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7ea65f08fa1b8279b65133a958de02fe84767eb9 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 7ea65f08fa1b8279b65133a958de02fe84767eb9

Add comment describing continuable/steppable/non-steppable watchpoints

These weren't described anywhere in the sources.

gdb/ChangeLog:
2018-08-31  Pedro Alves  <palves@redhat.com>

	* gdbarch.sh (have_nonsteppable_watchpoint): Add comment.
	* target.h (Hardware watchpoint interfaces): Describe
	continuable/steppable/non-steppable watchpoints.
	* gdbarch.h, gdbarch.c: Regenerate.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Eliminate target_have_continuable_watchpoint
@ 2018-08-31 22:04 sergiodj+buildbot
  2018-08-31 22:17 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-08-31 22:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7eb65fafed7b50511f52664e98e22b20eb697197 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 7eb65fafed7b50511f52664e98e22b20eb697197

Eliminate target_have_continuable_watchpoint

target_have_continuable_watchpoint isn't used anywhere so remove it.
The property isn't necessary because checking for "continuable" is the
same as checking for "!steppable && !non-steppable".

gdb/ChangeLog:
2018-08-31  Pedro Alves  <palves@redhat.com>

	* nto-procfs.c (nto_procfs_target::have_continuable_watchpoint):
	Delete.
	* s390-linux-nat.c
	(s390_linux_nat_target::have_continuable_watchpoint): Delete.
	* target.h (target_ops::have_continuable_watchpoint): Delete.
	(target_have_continuable_watchpoint): Delete.
	* x86-nat.h (x86_nat_target::have_continuable_watchpoint): Delete.
	* target-delegates.c: Regenerate.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Update gnulib/Makefile.in:aclocal_m4_deps
@ 2018-08-31 20:14 sergiodj+buildbot
  2018-08-31 20:15 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-08-31 20:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT dab999b116b507ad431c70fab0a28074dfea29df ***

Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: dab999b116b507ad431c70fab0a28074dfea29df

Update gnulib/Makefile.in:aclocal_m4_deps

It was pointed by Pedro that gnulib/Makefile.in should be updated
accordingly after our local gnulib is also updated.  The specific part
that needs to be refreshed is the "aclocal_m4_deps" variable, which
lists the .m4 files present under the "gnulib/import/m4/" directory.
This patch does that.

No regressions introduced.

gdb/ChangeLog:
2018-08-31  Sergio Durigan Junior  <sergiodj@redhat.com>

	* gnulib/Makefile.in (aclocal_m4_deps): Update according to
	the files present in "gnulib/import/m4/".


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] PowerPC64 --emit-relocs support for notoc stubs
@ 2018-08-31 19:43 sergiodj+buildbot
  2018-08-31 19:43 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-08-31 19:43 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3d58e1fcfbedad71be7e539dfa2045ab2768f013 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 3d58e1fcfbedad71be7e539dfa2045ab2768f013

PowerPC64 --emit-relocs support for notoc stubs

This patch uses the newly defined high-part REL16 relocs to emit
relocations on the notoc stubs as we already do for other stubs.

	* elf64-ppc.c (num_relocs_for_offset): New function.
	(emit_relocs_for_offset): New function.
	(use_global_in_relocs): New function, split out from..
	(ppc_build_one_stub): ..here.  Output relocations for notoc stubs.
	(ppc_size_one_stub): Calculate reloc count for notoc stubs.
	(ppc64_elf_size_stubs): Don't count undefined syms in stub_globals.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] PowerPC64 higher REL16 relocations
@ 2018-08-31 19:39 sergiodj+buildbot
  2018-08-31 19:41 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-08-31 19:39 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4a9699735b04d4629bd3dc418c265e7f0bc1f9ce ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 4a9699735b04d4629bd3dc418c265e7f0bc1f9ce

PowerPC64 higher REL16 relocations

There are occasions where someone might want to build a 64-bit
pc-relative offset from 16-bit pieces.  This adds the necessary REL16
relocs corresponding to existing ADDR16 relocs that can be used to
build 64-bit absolute values.

include/
	* elf/ppc64.h (R_PPC64_REL16_HIGH, R_PPC64_REL16_HIGHA),
	(R_PPC64_REL16_HIGHER, R_PPC64_REL16_HIGHERA),
	(R_PPC64_REL16_HIGHEST, R_PPC64_REL16_HIGHESTA): Define.
	(R_PPC64_LO_DS_OPT, R_PPC64_16DX_HA): Bump value.
bfd/
	* reloc.c (BFD_RELOC_PPC64_REL16_HIGH, BFD_RELOC_PPC64_REL16_HIGHA),
	(BFD_RELOC_PPC64_REL16_HIGHER, BFD_RELOC_PPC64_REL16_HIGHERA),
	(BFD_RELOC_PPC64_REL16_HIGHEST, BFD_RELOC_PPC64_REL16_HIGHESTA):
	Define.
	* elf64-ppc.c (ppc64_elf_howto_raw): Add new REL16 howtos.
	(ppc64_elf_reloc_type_lookup): Translate new REL16 relocs.
	(ppc64_elf_check_relocs, ppc64_elf_relocate_section): Handle them.
	* bfd-in2.h: Regenerate.
	* libbfd.h: Regenerate.
gas/
	* config/tc-ppc.h (TC_FORCE_RELOCATION_SUB_LOCAL): Allow ADDR16
	HIGH, HIGHA, HIGHER, HIGHERA, HIGHEST, and HIGHESTA relocs.
	Group 16-bit relocs.
	* config/tc-ppc.c (md_apply_fix): Translate those ADDR16 relocs
	to REL16 when pcrel.  Sort relocs.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Rearrange ppc_size_one_stub and correct _notoc stub examples
@ 2018-08-31 19:26 sergiodj+buildbot
  2018-08-31 19:28 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-08-31 19:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f891966ff66639673a5207b94bd68ec928fb68bc ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: f891966ff66639673a5207b94bd68ec928fb68bc

Rearrange ppc_size_one_stub and correct _notoc stub examples

This patch rearranges ppc_size_one_stub to make it a little easier to
compare against ppc_build_one_stub, and makes a few other random
changes that might help for future maintenance.  There should be no
functional changes here.

The patch also fixes code examples in comments.  A couple of "ori"
instructions lacked the source register operand, and "@high" is the
correct reloc modifier to use in a sequence building a 64-bit value.
(@hi reports overflow of a 32-bit signed value.)

	* elf64-ppc.c: Correct _notoc stub comments.
	(ppc_build_one_stub): Simplify output of branch for notoc
	long branch stub.  Don't include label offset of 8 bytes in
	"off" calculation for notoc plt stub.  Don't emit insns to get pc.
	(build_offset): Emit insns to get pc here instead.
	(size_offset): Add 4 extra insns.
	(plt_stub_size): Adjust for "off" and size_offset changes.
	(ppc_size_one_stub): Rearrange code into a switch, duplicating
	some to better match ppc_build_one_stub.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] RISC-V: Allow instruction require more than one extension
@ 2018-08-31 16:33 sergiodj+buildbot
  2018-08-31 16:32 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-08-31 16:33 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 43135d3b15ce10a786704f9bb4736d834d6581a8 ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 43135d3b15ce10a786704f9bb4736d834d6581a8

RISC-V: Allow instruction require more than one extension

2018-08-29  Kito Cheng  <kito@andestech.com>

gas/
	* config/tc-riscv.c (riscv_subset_supports): New argument:
	xlen_required.
	(riscv_multi_subset_supports): New function, able to check more
	than one extension.
	(riscv_ip): Use riscv_multi_subset_supports instead of
	riscv_subset_supports.
	(riscv_set_arch): Update call-site for riscv_subset_supports.
	(riscv_after_parse_args): Likewise.

include/
	*opcode/riscv.h (MAX_SUBSET_NUM): New.
	(riscv_opcode): Add xlen_requirement field and change type of
	subset.

opcodes/
	* riscv-dis.c (riscv_disassemble_insn): Check XLEN by
	riscv_opcode.xlen_requirement.
	* riscv-opc.c (riscv_opcodes): Update for struct change.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] gdb/riscv: Extend instruction decode to cover more instructions
@ 2018-08-30 22:32 sergiodj+buildbot
  2018-08-30 23:07 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-08-30 22:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ff3a05b3f87093e5ac2bcd5e510bca4bebf1bef2 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: ff3a05b3f87093e5ac2bcd5e510bca4bebf1bef2

gdb/riscv: Extend instruction decode to cover more instructions

Extends the instruction decoder used during prologue scan and software
single step to cover more instructions.  These instructions are
encountered when running the current GDB testsuite with the DWARF
stack unwinders turned off.

gdb/ChangeLog:

	* riscv-tdep.c (riscv_insn::decode): Decode c.addi4spn, c.sd,
	c.sw, c.swsp, and c.sdsp.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] gdb/riscv: remove extra caching of misa register
@ 2018-08-30 21:42 sergiodj+buildbot
  2018-08-30 21:50 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-08-30 21:42 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0b3f9efc044d2971aa0d9bb39a4c76678bc4ea6d ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 0b3f9efc044d2971aa0d9bb39a4c76678bc4ea6d

gdb/riscv: remove extra caching of misa register

The RISC-V had a mechanism in place to cache the contents of the misa
register per-inferior, the original intention behind this was to
reduce the number of times the misa register had to be read (as the
contents should be constant), but it was pointed out on the mailing
list[1] that the register cache will mean the register is only
accessed once each time GDB stops, and any additional caching is
probably just unneeded extra complexity.

As such, until it can be shown that there's a real need for additional
caching, this commit removes all of the additional caching of the misa
register, and just accesses the misa register like a normal register.

[1] https://sourceware.org/ml/gdb-patches/2018-03/msg00136.html

gdb/ChangeLog:

	* riscv-tdep.c (struct riscv_inferior_data): Delete.
	(riscv_read_misa_reg): Don't cache value read into inferior data.
	(riscv_new_inferior_data): Delete.
	(riscv_inferior_data_cleanup): Delete.
	(riscv_inferior_data): Delete.
	(riscv_invalidate_inferior_data): Delete.
	(_initialize_riscv_tdep): Remove initialisation of inferior data.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] gdb: Ensure compiler doesn't optimise variable out in test
@ 2018-08-30 21:26 sergiodj+buildbot
  2018-08-30 21:28 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-08-30 21:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c67f2e1518a829c4ae4f346c316701ef5d56a30f ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: c67f2e1518a829c4ae4f346c316701ef5d56a30f

gdb: Ensure compiler doesn't optimise variable out in test

In the test gdb.base/funcargs.exp, there's this function:

    void recurse (SVAL a, int depth)
    {
      a.s = a.i = a.l = --depth;
      if (depth == 0)
        hitbottom ();
      else
        recurse (a, depth);
    }

The test script places a breakpoint in hitbottom, and runs the
executable which calls recurse with an initial depth of 4.

When GDB hits the breakpoint in hitbottom the testscript performs a
backtrace, and examines 'a' at each level.

The problem is that 'a' is not live after either the call to
'hitbottom' or the call to 'recurse', and as a result the test fails.

In the particular case I was looking at GCC for RISC-V 32-bit, the
variable 'a' is on the stack and GCC selects the register $ra (the
return address register) to hold the pointer to 'a'.  This is fine,
because, by the time the $ra register is needed to hold a return
address (calling hitbottom or recurse) then 'a' is dead.

In this patch I propose that a use of 'a' is added after the calls to
hitbottom and recurse, this should cause the compiler to keep 'a'
around, which should ensure GDB can find it.

gdb/testsuite/ChangeLog:

	* gdb.base/funcargs.c (use_a): New function.
	(recurse): Call use_a.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Fix compile-cplus-types.c build errors
@ 2018-08-30 20:30 sergiodj+buildbot
  2018-08-30 20:31 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-08-30 20:30 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a0dc02a6df86011462293cc11b4e35c0f18effd0 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: a0dc02a6df86011462293cc11b4e35c0f18effd0

Fix compile-cplus-types.c build errors

I see these errors when building with clang:

  CXX    compile/compile-cplus-types.o
/home/emaisin/src/binutils-gdb/gdb/compile/compile-cplus-types.c:306:56: error: cannot pass non-trivial object of type 'compile_scope' to variadic function; expected type from format string was 'void *' [-Wnon-pod-varargs]
        fprintf_unfiltered (gdb_stdlog, "leaving scope %p\n", current);
                                                       ~~     ^~~~~~~
/home/emaisin/src/binutils-gdb/gdb/compile/compile-cplus-types.c:1058:13: error: comparison of two values with different enumeration types ('enum_flags<gcc_cp_qualifiers>::enum_type' (aka 'gcc_cp_qualifiers') and 'gcc_cp_ref_qualifiers') [-Werror,-Wenum-compare]
  if (quals != GCC_CP_REF_QUAL_NONE)
      ~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~

Fix the first one by using host_address_to_string.

Fix the second one by comparing to 0 instead.  I think the current
comparison simply uses the wrong enum type.  Comparing to 0 seems like
the right thing to do, because we want to check whether any flags are
specified.

gdb/ChangeLog:

	* compile/compile-cplus-types.c
	(compile_cplus_instance::leave_scope): Take the address of scope
	object.
	(compile_cplus_instance::convert_qualified_base): Compare quals
	to 0.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Use host_address_to_string in compile_cplus_instance::enter_scope
@ 2018-08-30 19:05 sergiodj+buildbot
  2018-08-30 19:21 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-08-30 19:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fdad7678b74a170ead1ef967007be087435715f7 ***

Author: Keith Seitz <keiths@redhat.com>
Branch: master
Commit: fdad7678b74a170ead1ef967007be087435715f7

Use host_address_to_string in compile_cplus_instance::enter_scope

This patch fixes a problem being reported by the buildbot with an
invalid argument to a "%p" printf format. Instead of "%p", the
debug output is changed to use "%s" and host_address_to_string.

gdb/ChangeLog

	* compile/compile-cplus-types.c (compile_cplus_instance::enter_scope):
	Use "%s" and host_address_to_string instead of "%p" in printf.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] C++ compile support
@ 2018-08-30  1:55 sergiodj+buildbot
  2018-08-30  1:57 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-08-30  1:55 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 078a020797210f4d8f9491bbfe16ec31e9efb652 ***

Author: Keith Seitz <keiths@redhat.com>
Branch: master
Commit: 078a020797210f4d8f9491bbfe16ec31e9efb652

C++ compile support

This patch adds *basic* support for C++ to the compile feature.  It does
most simple type conversions, including everything that C compile does and
your basic "with-classes" type of C++.

I've written a new compile-support.exp support file which adds a new test
facility for automating and simplifying "compile print" vs "compile code"
testing.  See testsuite/lib/compile-support.exp and CompileExpression
for more on that.  The tests use this facility extensively.

This initial support has several glaring omissions:
- No template support at all
  I have follow-on patches for this, but they add much complexity
  to this "basic" support.  Consequently, they will be submitted separately.
- Cannot print functions
  The code template needs tweaking, and I simply haven't gotten to it yet.
- So-called "special function" support is not included
  Using constructors, destructors, operators, etc will not work. I have
  follow-on patches for that, but they require some work because of the
  recent churn in symbol searching.
- There are several test suite references to "compile/1234" bugs.
  I will file bugs and update the test suite's bug references before pushing
  these patches.

The test suite started as a copy of the original C-language support, but
I have written tests to exercise the basic functionality of the plug-in.

I've added a new option for outputting debug messages for C++ type-conversion
("debug compile-cplus-types").

gdb/ChangeLog:

	* Makefile.in (SUBDIR_GCC_COMPILE_SRCS): Add compile-cplus-symbols.c
	and compile-cplus-types.c.
	(HFILES_NO_SRCDIR): Add gcc-cp-plugin.h.
	* c-lang.c (cplus_language_defn): Set C++ compile functions.
	* c-lang.h (cplus_get_compile_context, cplus_compute_program):
	Declare.
	* compile/compile-c-support.c: Include compile-cplus.h.
	(load_libcompile): Templatize.
	(get_compile_context): "New" function.
	(c_get_compile_context): Use get_compile_context.
	(cplus_get_compile_context): New function.
	(cplus_push_user_expression, cplus_pop_user_expression)
	(cplus_add_code_header, cplus_add_input, cplus_compile_program)
	(cplus_compute_program): Define new structs/functions.
	* compile/compile-cplus-symmbols.c: New file.
	* compile/compile-cplus-types.c: New file.
	* compile/compile-cplus.h: New file.
	* compile/compile-internal.h (debug_compile_oracle, GCC_TYPE_NONE):
	Declare.
	* compile/compile-object-load.c (get_out_value_type): Use
	strncmp_iw when comparing symbol names.
	(compile_object_load): Add mst_bss and mst_data.
	* compile/compile.c (_initialize_compile): Remove
	-Wno-implicit-function-declaration from `compile_args'.
	* compile/gcc-cp-plugin.h: New file.
	* NEWS: Mention C++ compile support and new debug options.

gdb/testsuite/ChangeLog:

	* gdb.compile/compile-cplus-anonymous.cc: New file.
	* gdb.compile/compile-cplus-anonymous.exp: New file.
	* gdb.compile/compile-cplus-array-decay.cc: New file.
	* gdb.compile/compile-cplus-array-decay.exp: New file.
	* gdb.compile/compile-cplus-inherit.cc: New file.
	* gdb.compile/compile-cplus-inherit.exp: New file.
	* gdb.compile/compile-cplus-member.cc: New file.
	* gdb.compile/compile-cplus-member.exp: New file.
	* gdb.compile/compile-cplus-method.cc: New file.
	* gdb.compile/compile-cplus-method.exp: New file.
	* gdb.compile/compile-cplus-mod.c: "New" file.
	* gdb.compile/compile-cplus-namespace.cc: New file.
	* gdb.compile/compile-cplus-namespace.exp: New file.
	* gdb.compile/compile-cplus-nested.cc: New file.
	* gdb.compile/compile-cplus-nested.exp: New file.
	* gdb.compile/compile-cplus-print.c: "New" file.
	* gdb.compile/compile-cplus-print.exp: "New" file.
	* gdb.compile/compile-cplus-virtual.cc: New file.
	* gdb.compile/compile-cplus-virtual.exp: New file.
	* gdb.compile/compile-cplus.c: "New" file.
	* gdb.compile/compile-cplus.exp: "New" file.
	* lib/compile-support.exp: New file.

doc/ChangeLog:

	* gdb.texinfo (Compiling and injecting code in GDB): Document
	set/show "compile-oracle" and "compile-cplus-types" commands.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Add new search_symbols_multiple API
@ 2018-08-30  1:51 sergiodj+buildbot
  2018-08-30  1:54 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-08-30  1:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fcaad03cc027ec2cdf7f2cff70d792867d43c57f ***

Author: Keith Seitz <keiths@redhat.com>
Branch: master
Commit: fcaad03cc027ec2cdf7f2cff70d792867d43c57f

Add new search_symbols_multiple API

This patch adds a new symbol searching API based on linespec.c's parser
implementation.  This allows users to find "all* matching symbols instead
of the first found match (a la lookup_symbol).

gdb/ChangeLog:

	* linespec.c (collect_info::add_symbol): Make virtual.
	(struct symbol_searcher_collect_info): New struct.
	(symbol_searcher::find_all_symbols): New method.
	* symtab.h (class symbol_searcher): New class.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Use block_symbol in linespec APIs
@ 2018-08-30  1:27 sergiodj+buildbot
  2018-08-30  1:36 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-08-30  1:27 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7e41c8db84bc6f74843dda40ae443d41977c0d20 ***

Author: Keith Seitz <keiths@redhat.com>
Branch: master
Commit: 7e41c8db84bc6f74843dda40ae443d41977c0d20

Use block_symbol in linespec APIs

This patch changes the linespec.c APIs to use block_symbol instead of just
a symbol.  lookup_symbol et al already return block_symbol's.

gdb/ChangeLog:

	* linespec.c (struct linespec) <function_symbols, label_symbols>:
	Change to vector of block_symbol.  Update all users.
	(struct collect_info) <symbols>: Likewise.
	(collect_info::add_symbol): Take block_symbol as argument.
	Update all callers.
	(decode_compound_collector) <m_symbols>: Change type to vector
	of block_symbol.  Update all users.
	(decode_compound_collector::operator ()): Change parameter type
	to block_symbol.
	(find_method, find_function_symbols, find_linespec_symbols)
	(find_label_symbols_in_block, find_label_symbols): Change symbol
	vectors to block_symbol vectors.
	* symtab.h (symbol_found_callback_ftype): Change parameter type to
	block_symbol.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Remove VEC definitions from linespec.c
@ 2018-08-30  1:10 sergiodj+buildbot
  2018-08-30  1:20 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-08-30  1:10 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 63e8c3daad1eae11cef5b6d1833507d9d4d6b0c0 ***

Author: Keith Seitz <keiths@redhat.com>
Branch: master
Commit: 63e8c3daad1eae11cef5b6d1833507d9d4d6b0c0

Remove VEC definitions from linespec.c

Since they are now no longer necessary, this patch removes the typedefs
and VEC definitions for bound_minimal_symbol_d and symbolp.

gdb/ChangeLog:

	* linespec.c (symbolp): Remove typedef and VEC definitions.
	(bound_minimal_symbol_d): Likewise.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Change decode_compound_collector to use std::vector
@ 2018-08-30  1:07 sergiodj+buildbot
  2018-08-30  1:10 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-08-30  1:07 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4dedf84da98ca7dcb9fc80895044d09b5787c1f0 ***

Author: Keith Seitz <keiths@redhat.com>
Branch: master
Commit: 4dedf84da98ca7dcb9fc80895044d09b5787c1f0

Change decode_compound_collector to use std::vector

This patch changes decode_compound_collector to use std::vector instead of
VEC, eliminating a cleanup in the process.

gdb/ChangeLog:

	* linespec.c (decode_compound_collector::decode_compound_collector):
	Remove initialization for `m_symtabs'.
	(decode_compound_collector::release_symbols): Change return type
	to std::vector.  Update all callers.
	(class decode_compound_collector) <m_symbols>: Change type to
	std::vector.
	(lookup_prefix_sym): Change return type to std::vector.  Update all
	callers.
	(compare_symbols): Remove.
	(std_compare_symbols): Rename to `compare_symbols'.
	(find_method): Change `sym_classes' parameter to std::vector.
	Update all callers.  Use std::sort to sort sym_classes.
	(find_linespec_symbols): Remove cleanup.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Change `minimal_symbols' to std::vector in linespec.c structures
@ 2018-08-30  0:47 sergiodj+buildbot
  2018-08-30  0:51 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-08-30  0:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c2a031c5822b4256f116254def47b9887c230e68 ***

Author: Keith Seitz <keiths@redhat.com>
Branch: master
Commit: c2a031c5822b4256f116254def47b9887c230e68

Change `minimal_symbols' to std::vector in linespec.c structures

This patch converts linespec.c's linespec.label_symbols member from a
VEC to a std::vector.

gdb/ChangeLog:

	* linespec.c (struct linespec) <minimal_symbols>: Change type to
	std::vector.  Update all users.
	(convert_linespec_to_sals): Use std::sort to sort minimal symbols.
	(struct collect_info) <minimal_symbols>: Likewise.
	(compare_msymbols): Return bool.  Change parameters to const
	bound_minimal_symbol references.
	(find_method, find_function_symbols, find_linespec_symbols): Change
	`minsyms' parameter to std::vector.  Update all callers.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Change `label_symbols' to std::vector in linespec.c structures
@ 2018-08-30  0:35 sergiodj+buildbot
  2018-08-30  0:35 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-08-30  0:35 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3553eadc8cb5f087ea0fb72ebdd1c52264304e0b ***

Author: Keith Seitz <keiths@redhat.com>
Branch: master
Commit: 3553eadc8cb5f087ea0fb72ebdd1c52264304e0b

Change `label_symbols' to std::vector in linespec.c structures

This patch converts linespec.c's linespec.label_symbols member from a
VEC to a std::vector.

gdb/ChangeLog:

	* linespec.c (struct linespec) <label_symbols>: Change type to
	std::vector.  Update all users.
	(find_label_symbols_in_block): Change `result' parameter to
	std::vector.  Update all callers.
	(find_label_symbols): Return std::vector.  Update all callers.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Change `function_symbols' to std::vector
@ 2018-08-30  0:11 sergiodj+buildbot
  2018-08-30  0:22 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-08-30  0:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7243d0118af6f72e3e72db1eb66941fec4530963 ***

Author: Keith Seitz <keiths@redhat.com>
Branch: master
Commit: 7243d0118af6f72e3e72db1eb66941fec4530963

Change `function_symbols' to std::vector

This patch changes the `function_symbols'  members in linespec.c structures
from a VEC to a std::vector.

gdb/ChangeLog:

	* linespec.c (struct linespec) <function_symbols>: Change type to
	std::vector.  Update all users.
	(struct collect_info) <function_symbols>: Likewise.
	(convert_linespec_to_sals): Use std::sort to sort function_symbols.
	(std_compare_symbols): New function.
	(find_method, find_function_symbols, find_linespec_symbols)
	(find_label_symbols_in_block): Change `symbols' parameter to
	std::vector.  Update all callers.
	(find_label_symbols): Likewise for `function_symbols' and
	`label_funcs_ret'.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Change `file_symtabs' to std::vector
@ 2018-08-30  0:06 sergiodj+buildbot
  2018-08-30  0:07 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-08-30  0:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2a90824133f9d46970c9c52b68ef2ccbeb6389ac ***

Author: Keith Seitz <keiths@redhat.com>
Branch: master
Commit: 2a90824133f9d46970c9c52b68ef2ccbeb6389ac

Change `file_symtabs' to std::vector

This patch changes the `file_symtabs' members in linespec.c structures
from a VEC to a std::vector (or unique_ptr thereof), eliminating a cleanup
in the process.

gdb/ChangeLog:

	* linespec.c (symtab_vector_up): Define.
	(struct linespec) <file_symtabs>: Change type to std::vector *.
	Update all uses.
	(struct collect_info) <file_symtabs>: Likewise.
	(collect_symtabs_from_filename): Return symtab_vector_up.
	Update all callers.
	(decode_objc): Remove cleanup.
	(symtab_collector::symtab_collector): Initialize `m_symtabs'.
	(symtab_collector::release_symtabs): Return symtab_vector_up.
	Update all callers.
	(class symtab_collector) <m_symtabs>: Change type to symtab_vector_up.
	Update all users.
	(collect_symtabs_from_filename, symtabs_from_filename): Return
	symtab_vector_up.  Update all callers.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Use core_addr_to_string_nz in csky_analyze_prologue
@ 2018-08-29 23:06 sergiodj+buildbot
  2018-08-29 23:12 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-08-29 23:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f6c4e3e8a3af94fbecce2a38d3fccc0980616c6d ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: f6c4e3e8a3af94fbecce2a38d3fccc0980616c6d

Use core_addr_to_string_nz in csky_analyze_prologue

One of the buildbot builders had a failure on a recent try run:

../../binutils-gdb/gdb/csky-tdep.c: In function CORE_ADDR csky_analyze_prologue(gdbarch*, CORE_ADDR, CORE_ADDR, CORE_ADDR, frame_info*, csky_unwind_cache*, lr_type_t):
../../binutils-gdb/gdb/csky-tdep.c:1107:23: error: format %lx expects argument of type long unsigned int, but argument 3 has type CORE_ADDR {aka long long unsigned int} [-Werror=format=]
        "0x%lx\n", addr);
                       ^
../../binutils-gdb/gdb/csky-tdep.c:1419:12: error: format %lx expects argument of type long unsigned int, but argument 3 has type CORE_ADDR {aka long long unsigned int} [-Werror=format=]
        addr);
            ^

The fix is to use core_addr_to_string_nz rather than %lx in
csky-tdep.c.

Tested by rebuilding.  I'm checking this in.

gdb/ChangeLog
2018-08-29  Tom Tromey  <tom@tromey.com>

	* csky-tdep.c (csky_analyze_prologue): Use
	core_addr_to_string_nz.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Fix windows-nat.c for -Wnarrowing
@ 2018-08-29 22:41 sergiodj+buildbot
  2018-08-29 22:41 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-08-29 22:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 73c13fe69a4275433544533a610275861346ef44 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 73c13fe69a4275433544533a610275861346ef44

Fix windows-nat.c for -Wnarrowing

Sergio pointed out that the Windows builder was failing due to the
-Wnarrowing patch, with:

../../binutils-gdb/gdb/windows-nat.c:301:27: error: narrowing conversion of '3221225477' from 'DWORD {aka long unsigned int}' to 'int' inside { } [-Wnarrowing]
   {-1, GDB_SIGNAL_UNKNOWN}};
                           ^
../../binutils-gdb/gdb/windows-nat.c:301:27: error: narrowing conversion of '3221225725' from 'DWORD {aka long unsigned int}' to 'int' inside { } [-Wnarrowing]
../../binutils-gdb/gdb/windows-nat.c:301:27: error: narrowing conversion of '2147483651' from 'DWORD {aka long unsigned int}' to 'int' inside { } [-Wnarrowing]
../../binutils-gdb/gdb/windows-nat.c:301:27: error: narrowing conversion of '2147483652' from 'DWORD {aka long unsigned int}' to 'int' inside { } [-Wnarrowing]
../../binutils-gdb/gdb/windows-nat.c:301:27: error: narrowing conversion of '3221225614' from 'DWORD {aka long unsigned int}' to 'int' inside { } [-Wnarrowing]

Looking into this, I found two things.

First, in struct xlate_exception, it is better to have "them" be of
type DWORD, as that's the type actually in use.

Second, struct xlate_exception and xlate are not used in this file,
because the code in windows_nat_target::resume is #if'd out.

This patch changes the type of "them", but also similarly #if's out
this object.

In order to avoid a narrowing warning from the -1 entry, at Pedro's
suggestion I have removed this and changed windows_nat_target::resume
to use ranged for.

Tested by rebuilding using the mingw toolchain on x86-64 Fedora 28.  I
also tested it by temporarily removing the "#if 0"s and rebuilding.

gdb/ChangeLog
2018-08-29  Tom Tromey  <tom@tromey.com>

	* windows-nat.c (struct xlate_exception) <them>: Change type to
	DWORD.
	(xlate): Fix formatting.  Remove last entry.
	(struct xlate_exception, xlate): Comment out.
	(windows_nat_target::resume): Use ranged for.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] sparc/leon: add support for partial write psr instruction
@ 2018-08-29 21:44 sergiodj+buildbot
  2018-08-29 21:54 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-08-29 21:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT df28970fcc741fa744a51aece29bb755c20eceab ***

Author: Martin Aberg <maberg@gaisler.com>
Branch: master
Commit: df28970fcc741fa744a51aece29bb755c20eceab

sparc/leon: add support for partial write psr instruction

Partial write %PSR (PWRPSR) is a SPARC V8e option that allows the WRPSR
instruction to only affect the %PSR.ET field. When available it is enabled
by setting the rd field of the WRPSR instruction to a value other than 0.
For Leon processors with support for partial write %PSR (currently GR740
and GR716) the rd value must be 1.

opcodes/ChangeLog:

2018-08-29  Martin Aberg  <maberg@gaisler.com>

        * sparc-opc.c (sparc_opcodes): Add Leon specific partial write
        psr (PWRPSR) instruction.

gas/ChangeLog:

2018-08-29  Daniel Cederman  <cederman@gaisler.com>

        * testsuite/gas/sparc/leon.d: New test.
        * testsuite/gas/sparc/leon.s: New test.
        * testsuite/gas/sparc/sparc.exp: Execute the pwrpsr test.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Fix riscv-linux native gdb build failure.
@ 2018-08-29 20:38 sergiodj+buildbot
  2018-08-29 20:52 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-08-29 20:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4d3928d7e0a141e0fb16405d33b375cbe2f13123 ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 4d3928d7e0a141e0fb16405d33b375cbe2f13123

Fix riscv-linux native gdb build failure.

The linux kernel uses NT_PRFPREG.  Glibc before BZ 14890 defines NT_FPREGSET.
After it defines both.  Avoid glibc version dependency by using the gdb header
file instead of the glibc header file, and the macro name that gdb defines
which is NT_FPREGSET.

	gdb/
	* riscv-linux-nat.c: Include elf/common.h instead of elf.h.
	(riscv_linux_nat_target::fetch_registers): Use NT_FPREGSET instead
	of NT_PRFPREG.
	(riscv_linux_nat_target::store_registers): Likewise.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Update gnulib to current upstream master
@ 2018-08-29 19:31 sergiodj+buildbot
  2018-08-29 19:29 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-08-29 19:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7a6dbc2fdb2323c35e981f93236f323e9d7c0b24 ***

Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: 7a6dbc2fdb2323c35e981f93236f323e9d7c0b24

Update gnulib to current upstream master

It has been a while since we don't update our gnulib copy against
their upstream master branch, so I thought I'd propose this patch.  It
also fixes (at least) one bug reported against GDB:

  https://sourceware.org/bugzilla/show_bug.cgi?id=23558

The problem reported there is about the replacement of 'getcwd' when
cross-compiling GDB.  With our current gnulib copy, the mechanism for
deciding whether to use the system's 'getcwd' or gnulib's version is
too simplistic and pessimistic, so when cross-compiling we always end
up using gnulib's version, which has a limitation: it cannot handle
the situation when the parent directory doesn't have read permissions.

This has been reported against upstream gnulib and the fix has been
pushed here:

  https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=a96d2e67052c879b1bcc5bc461722beac75fc372

I regtested this patch on Fedora 28 x86-64, and there were no
regressions.

OK?

gdb/ChangeLog:

2018-08-29  Sergio Durigan Junior  <sergiodj@redhat.com>

	PR gdb/23555
	PR gdb/23558
	* gnulib/aclocal.m4: Regenerate.
	* gnulib/config.in: Regenerate.
	* gnulib/configure: Regenerate.
	* gnulib/import/Makefile.am: Update.
	* gnulib/import/Makefile.in: Update.
	* gnulib/import/extra/snippet/_Noreturn.h: Rename to...
	* gnulib/import/_Noreturn.h: ... this.
	* gnulib/import/alloca.in.h: Update.
	* gnulib/import/extra/snippet/arg-nonnull.h: Rename to...
	* gnulib/import/arg-nonnull.h: ... this.
	* gnulib/import/assure.h: Update.
	* gnulib/import/at-func.c: Update.
	* gnulib/import/basename-lgpl.c: Update.
	* gnulib/import/extra/snippet/c++defs.h: Rename to...
	* gnulib/import/c++defs.h: ... this.
	* gnulib/import/canonicalize-lgpl.c: Update.
	* gnulib/import/cdefs.h: Update.
	* gnulib/import/chdir-long.c: Update.
	* gnulib/import/chdir-long.h: Update.
	* gnulib/import/cloexec.c: Update.
	* gnulib/import/cloexec.h: Update.
	* gnulib/import/close.c: Update.
	* gnulib/import/closedir.c: Update.
	* gnulib/import/config.charset: Update.
	* gnulib/import/dirent-private.h: Update.
	* gnulib/import/dirent.in.h: Update.
	* gnulib/import/dirfd.c: Update.
	* gnulib/import/dirname-lgpl.c: Update.
	* gnulib/import/dirname.h: Update.
	* gnulib/import/dosname.h: Update.
	* gnulib/import/dup-safer-flag.c: Update.
	* gnulib/import/dup-safer.c: Update.
	* gnulib/import/dup.c: Update.
	* gnulib/import/dup2.c: Update.
	* gnulib/import/errno.in.h: Update.
	* gnulib/import/error.c: Update.
	* gnulib/import/error.h: Update.
	* gnulib/import/exitfail.c: Update.
	* gnulib/import/exitfail.h: Update.
	* gnulib/import/extra/update-copyright: Update.
	* gnulib/import/fchdir.c: Update.
	* gnulib/import/fcntl.c: Update.
	* gnulib/import/fcntl.in.h: Update.
	* gnulib/import/fd-hook.c: Update.
	* gnulib/import/fd-hook.h: Update.
	* gnulib/import/fd-safer-flag.c: Update.
	* gnulib/import/fd-safer.c: Update.
	* gnulib/import/fdopendir.c: Update.
	* gnulib/import/filename.h: Update.
	* gnulib/import/filenamecat-lgpl.c: Update.
	* gnulib/import/filenamecat.h: Update.
	* gnulib/import/flexmember.h: Update.
	* gnulib/import/float+.h: Update.
	* gnulib/import/float.c: Update.
	* gnulib/import/float.in.h: Update.
	* gnulib/import/fnmatch.c: Update.
	* gnulib/import/fnmatch.in.h: Update.
	* gnulib/import/fnmatch_loop.c: Update.
	* gnulib/import/fpucw.h: Update.
	* gnulib/import/frexp.c: Update.
	* gnulib/import/frexpl.c: Update.
	* gnulib/import/fstat.c: Update.
	* gnulib/import/fstatat.c: Update.
	* gnulib/import/getcwd-lgpl.c: Update.
	* gnulib/import/getcwd.c: Update.
	* gnulib/import/getdtablesize.c: Update.
	* gnulib/import/getlogin_r.c: Update.
	* gnulib/import/getprogname.c: Update.
	* gnulib/import/getprogname.h: Update.
	* gnulib/import/gettext.h: Update.
	* gnulib/import/gettimeofday.c: Update.
	* gnulib/import/glob-libc.h: Update.
	* gnulib/import/glob.c: Update.
	* gnulib/import/glob.in.h: Update.
	* gnulib/import/glob_internal.h: Update.
	* gnulib/import/glob_pattern_p.c: Update.
	* gnulib/import/globfree.c: Update.
	* gnulib/import/hard-locale.c: Update.
	* gnulib/import/hard-locale.h: Update.
	* gnulib/import/intprops.h: Update.
	* gnulib/import/inttypes.in.h: Update.
	* gnulib/import/isnan.c: Update.
	* gnulib/import/isnand-nolibm.h: Update.
	* gnulib/import/isnand.c: Update.
	* gnulib/import/isnanl-nolibm.h: Update.
	* gnulib/import/isnanl.c: Update.
	* gnulib/import/itold.c: Update.
	* gnulib/import/libc-config.h: Update.
	* gnulib/import/limits.in.h: Update.
	* gnulib/import/localcharset.c: Update.
	* gnulib/import/localcharset.h: Update.
	* gnulib/import/localtime-buffer.c: Update.
	* gnulib/import/localtime-buffer.h: Update.
	* gnulib/import/lstat.c: Update.
	* gnulib/import/m4/00gnulib.m4: Update.
	* gnulib/import/m4/__inline.m4: Update.
	* gnulib/import/m4/absolute-header.m4: Update.
	* gnulib/import/m4/alloca.m4: Update.
	* gnulib/import/m4/builtin-expect.m4: Update.
	* gnulib/import/m4/canonicalize.m4: Update.
	* gnulib/import/m4/chdir-long.m4: Update.
	* gnulib/import/m4/close.m4: Update.
	* gnulib/import/m4/closedir.m4: Update.
	* gnulib/import/m4/configmake.m4: Update.
	* gnulib/import/m4/d-ino.m4: Update.
	* gnulib/import/m4/d-type.m4: Update.
	* gnulib/import/m4/dirent_h.m4: Update.
	* gnulib/import/m4/dirfd.m4: Update.
	* gnulib/import/m4/dirname.m4: Update.
	* gnulib/import/m4/double-slash-root.m4: Update.
	* gnulib/import/m4/dup.m4: Update.
	* gnulib/import/m4/dup2.m4: Update.
	* gnulib/import/m4/eealloc.m4: Update.
	* gnulib/import/m4/environ.m4: Update.
	* gnulib/import/m4/errno_h.m4: Update.
	* gnulib/import/m4/error.m4: Update.
	* gnulib/import/m4/exponentd.m4: Update.
	* gnulib/import/m4/exponentl.m4: Update.
	* gnulib/import/m4/extensions.m4: Update.
	* gnulib/import/m4/extern-inline.m4: Update.
	* gnulib/import/m4/fchdir.m4: Update.
	* gnulib/import/m4/fcntl-o.m4: Update.
	* gnulib/import/m4/fcntl.m4: Update.
	* gnulib/import/m4/fcntl_h.m4: Update.
	* gnulib/import/m4/fdopendir.m4: Update.
	* gnulib/import/m4/filenamecat.m4: Update.
	* gnulib/import/m4/flexmember.m4: Update.
	* gnulib/import/m4/float_h.m4: Update.
	* gnulib/import/m4/fnmatch.m4: Update.
	* gnulib/import/m4/fnmatch_h.m4: Update.
	* gnulib/import/m4/fpieee.m4: Update.
	* gnulib/import/m4/frexp.m4: Update.
	* gnulib/import/m4/frexpl.m4: Update.
	* gnulib/import/m4/fstat.m4: Update.
	* gnulib/import/m4/fstatat.m4: Update.
	* gnulib/import/m4/getcwd-abort-bug.m4: Update.
	* gnulib/import/m4/getcwd-path-max.m4: Update.
	* gnulib/import/m4/getcwd.m4: Update.
	* gnulib/import/m4/getdtablesize.m4: Update.
	* gnulib/import/m4/getlogin.m4: Update.
	* gnulib/import/m4/getlogin_r.m4: Update.
	* gnulib/import/m4/getpagesize.m4: Update.
	* gnulib/import/m4/getprogname.m4: Update.
	* gnulib/import/m4/gettimeofday.m4: Update.
	* gnulib/import/m4/glibc21.m4: Update.
	* gnulib/import/m4/glob.m4: Update.
	* gnulib/import/m4/glob_h.m4: Update.
	* gnulib/import/m4/gnulib-cache.m4: Update.
	* gnulib/import/m4/gnulib-common.m4: Update.
	* gnulib/import/m4/gnulib-comp.m4: Update.
	* gnulib/import/m4/gnulib-tool.m4: Update.
	* gnulib/import/m4/hard-locale.m4: Update.
	* gnulib/import/m4/include_next.m4: Update.
	* gnulib/import/m4/inttypes-pri.m4: Update.
	* gnulib/import/m4/inttypes.m4: Update.
	* gnulib/import/m4/isnand.m4: Update.
	* gnulib/import/m4/isnanl.m4: Update.
	* gnulib/import/m4/largefile.m4: Update.
	* gnulib/import/m4/limits-h.m4: Update.
	* gnulib/import/m4/localcharset.m4: Update.
	* gnulib/import/m4/locale-fr.m4: Update.
	* gnulib/import/m4/locale-ja.m4: Update.
	* gnulib/import/m4/locale-zh.m4: Update.
	* gnulib/import/m4/localtime-buffer.m4: Update.
	* gnulib/import/m4/longlong.m4: Update.
	* gnulib/import/m4/lstat.m4: Update.
	* gnulib/import/m4/malloc.m4: Update.
	* gnulib/import/m4/malloca.m4: Update.
	* gnulib/import/m4/math_h.m4: Update.
	* gnulib/import/m4/mbrtowc.m4: Update.
	* gnulib/import/m4/mbsinit.m4: Update.
	* gnulib/import/m4/mbsrtowcs.m4: Update.
	* gnulib/import/m4/mbstate_t.m4: Update.
	* gnulib/import/m4/memchr.m4: Update.
	* gnulib/import/m4/memmem.m4: Update.
	* gnulib/import/m4/mempcpy.m4: Update.
	* gnulib/import/m4/memrchr.m4: Update.
	* gnulib/import/m4/mkdir.m4: Update.
	* gnulib/import/m4/mkstemp.m4: Update.
	* gnulib/import/m4/mmap-anon.m4: Update.
	* gnulib/import/m4/mode_t.m4: Update.
	* gnulib/import/m4/msvc-inval.m4: Update.
	* gnulib/import/m4/msvc-nothrow.m4: Update.
	* gnulib/import/m4/multiarch.m4: Update.
	* gnulib/import/m4/nocrash.m4: Update.
	* gnulib/import/m4/off_t.m4: Update.
	* gnulib/import/m4/onceonly.m4: Update.
	* gnulib/import/m4/open-cloexec.m4: Update.
	* gnulib/import/m4/open.m4: Update.
	* gnulib/import/m4/openat.m4: Update.
	* gnulib/import/m4/opendir.m4: Update.
	* gnulib/import/m4/pathmax.m4: Update.
	* gnulib/import/m4/rawmemchr.m4: Update.
	* gnulib/import/m4/readdir.m4: Update.
	* gnulib/import/m4/readlink.m4: Update.
	* gnulib/import/m4/realloc.m4: Update.
	* gnulib/import/m4/rename.m4: Update.
	* gnulib/import/m4/rewinddir.m4: Update.
	* gnulib/import/m4/rmdir.m4: Update.
	* gnulib/import/m4/save-cwd.m4: Update.
	* gnulib/import/m4/secure_getenv.m4: Update.
	* gnulib/import/m4/setenv.m4: Update.
	* gnulib/import/m4/signal_h.m4: Update.
	* gnulib/import/m4/ssize_t.m4: Update.
	* gnulib/import/m4/stat-time.m4: Update.
	* gnulib/import/m4/stat.m4: Update.
	* gnulib/import/m4/std-gnu11.m4: Update.
	* gnulib/import/m4/stdbool.m4: Update.
	* gnulib/import/m4/stddef_h.m4: Update.
	* gnulib/import/m4/stdint.m4: Update.
	* gnulib/import/m4/stdio_h.m4: Update.
	* gnulib/import/m4/stdlib_h.m4: Update.
	* gnulib/import/m4/strchrnul.m4: Update.
	* gnulib/import/m4/strdup.m4: Update.
	* gnulib/import/m4/strerror.m4: Update.
	* gnulib/import/m4/string_h.m4: Update.
	* gnulib/import/m4/strstr.m4: Update.
	* gnulib/import/m4/strtok_r.m4: Update.
	* gnulib/import/m4/sys_socket_h.m4: Update.
	* gnulib/import/m4/sys_stat_h.m4: Update.
	* gnulib/import/m4/sys_time_h.m4: Update.
	* gnulib/import/m4/sys_types_h.m4: Update.
	* gnulib/import/m4/tempname.m4: Update.
	* gnulib/import/m4/time_h.m4: Update.
	* gnulib/import/m4/unistd-safer.m4: Update.
	* gnulib/import/m4/unistd_h.m4: Update.
	* gnulib/import/m4/warn-on-use.m4: Update.
	* gnulib/import/m4/wchar_h.m4: Update.
	* gnulib/import/m4/wchar_t.m4: Update.
	* gnulib/import/m4/wctype_h.m4: Update.
	* gnulib/import/m4/wint_t.m4: Update.
	* gnulib/import/malloc.c: Update.
	* gnulib/import/malloc/scratch_buffer.h: Update.
	* gnulib/import/malloc/scratch_buffer_grow.c: Update.
	* gnulib/import/malloc/scratch_buffer_grow_preserve.c: Update.
	* gnulib/import/malloc/scratch_buffer_set_array_size.c: Update.
	* gnulib/import/malloca.c: Update.
	* gnulib/import/malloca.h: Update.
	* gnulib/import/malloca.valgrind: Update.
	* gnulib/import/math.in.h: Update.
	* gnulib/import/mbrtowc.c: Update.
	* gnulib/import/mbsinit.c: Update.
	* gnulib/import/mbsrtowcs-impl.h: Update.
	* gnulib/import/mbsrtowcs-state.c: Update.
	* gnulib/import/mbsrtowcs.c: Update.
	* gnulib/import/memchr.c: Update.
	* gnulib/import/memmem.c: Update.
	* gnulib/import/mempcpy.c: Update.
	* gnulib/import/memrchr.c: Update.
	* gnulib/import/mkdir.c: Update.
	* gnulib/import/mkstemp.c: Update.
	* gnulib/import/msvc-inval.c: Update.
	* gnulib/import/msvc-inval.h: Update.
	* gnulib/import/msvc-nothrow.c: Update.
	* gnulib/import/msvc-nothrow.h: Update.
	* gnulib/import/open.c: Update.
	* gnulib/import/openat-die.c: Update.
	* gnulib/import/openat-priv.h: Update.
	* gnulib/import/openat-proc.c: Update.
	* gnulib/import/openat.c: Update.
	* gnulib/import/openat.h: Update.
	* gnulib/import/opendir.c: Update.
	* gnulib/import/pathmax.h: Update.
	* gnulib/import/pipe-safer.c: Update.
	* gnulib/import/rawmemchr.c: Update.
	* gnulib/import/readdir.c: Update.
	* gnulib/import/readlink.c: Update.
	* gnulib/import/realloc.c: Update.
	* gnulib/import/ref-add.sin: Update.
	* gnulib/import/ref-del.sin: Update.
	* gnulib/import/rename.c: Update.
	* gnulib/import/rewinddir.c: Update.
	* gnulib/import/rmdir.c: Update.
	* gnulib/import/same-inode.h: Update.
	* gnulib/import/save-cwd.c: Update.
	* gnulib/import/save-cwd.h: Update.
	* gnulib/import/scratch_buffer.h: Update.
	* gnulib/import/secure_getenv.c: Update.
	* gnulib/import/setenv.c: Update.
	* gnulib/import/signal.in.h: Update.
	* gnulib/import/stat-time.c: Update.
	* gnulib/import/stat-time.h: Update.
	* gnulib/import/stat-w32.c: Update.
	* gnulib/import/stat-w32.h: Update.
	* gnulib/import/stat.c: Update.
	* gnulib/import/stdbool.in.h: Update.
	* gnulib/import/stddef.in.h: Update.
	* gnulib/import/stdint.in.h: Update.
	* gnulib/import/stdio.in.h: Update.
	* gnulib/import/stdlib.in.h: Update.
	* gnulib/import/str-two-way.h: Update.
	* gnulib/import/strchrnul.c: Update.
	* gnulib/import/strdup.c: Update.
	* gnulib/import/streq.h: Update.
	* gnulib/import/strerror-override.c: Update.
	* gnulib/import/strerror-override.h: Update.
	* gnulib/import/strerror.c: Update.
	* gnulib/import/string.in.h: Update.
	* gnulib/import/stripslash.c: Update.
	* gnulib/import/strnlen1.c: Update.
	* gnulib/import/strnlen1.h: Update.
	* gnulib/import/strstr.c: Update.
	* gnulib/import/strtok_r.c: Update.
	* gnulib/import/sys_stat.in.h: Update.
	* gnulib/import/sys_time.in.h: Update.
	* gnulib/import/sys_types.in.h: Update.
	* gnulib/import/tempname.c: Update.
	* gnulib/import/tempname.h: Update.
	* gnulib/import/time.in.h: Update.
	* gnulib/import/unistd--.h: Update.
	* gnulib/import/unistd-safer.h: Update.
	* gnulib/import/unistd.in.h: Update.
	* gnulib/import/unsetenv.c: Update.
	* gnulib/import/verify.h: Update.
	* gnulib/import/extra/snippet/warn-on-use.h: Update.
	* gnulib/import/wchar.in.h: Update.
	* gnulib/import/wctype.in.h: Update.
	* gnulib/import/xalloc-oversized.h: Update.
	* gnulib/update-gnulib.sh (GNULIB_COMMIT_SHA1): Set to
	"53e2c179f26a890fa6685af4b6c1397ee370433b".


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] [ARC] Add Tag_ARC_ATR_version.
@ 2018-08-06 14:07 sergiodj+buildbot
  2018-08-06 14:07 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-08-06 14:07 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT db1e1b45b417dc3e7d37f401828afa18328d8508 ***

Author: claziss <claziss@synopsys.com>
Branch: master
Commit: db1e1b45b417dc3e7d37f401828afa18328d8508

[ARC] Add Tag_ARC_ATR_version.

Add a new tag (Tag_ARC_ATR_version) used to indicate if current
attributes are interpreted in GNU way. This attribute is used by
Synopsys custom compiler to correctly identify and interpret the
object attributes section as generated by GNU tools.

gas/
2017-08-02  Claudiu Zissulescu <claziss@synopsys.com>

	* config/tc-arc.c (arc_set_public_attributes): Add
	Tag_ARC_ATR_version.
	(arc_convert_symbolic_attribute): Likewise.
	* testsuite/gas/arc/attr-arc600.d: Update test.
	* testsuite/gas/arc/attr-arc600_mul32x16.d: Likewise.
	* testsuite/gas/arc/attr-arc600_norm.d: Likewise.
	* testsuite/gas/arc/attr-arc601.d: Likewise.
	* testsuite/gas/arc/attr-arc601_mul32x16.d: Likewise.
	* testsuite/gas/arc/attr-arc601_mul64.d: Likewise.
	* testsuite/gas/arc/attr-arc601_norm.d: Likewise.
	* testsuite/gas/arc/attr-arc700.d: Likewise.
	* testsuite/gas/arc/attr-arcem.d: Likewise.
	* testsuite/gas/arc/attr-archs.d: Likewise.
	* testsuite/gas/arc/attr-autodetect-1.d: Likewise.
	* testsuite/gas/arc/attr-cpu-a601.d: Likewise.
	* testsuite/gas/arc/attr-cpu-a700.d: Likewise.
	* testsuite/gas/arc/attr-cpu-em.d: Likewise.
	* testsuite/gas/arc/attr-cpu-hs.d: Likewise.
	* testsuite/gas/arc/attr-em.d: Likewise.
	* testsuite/gas/arc/attr-em4.d: Likewise.
	* testsuite/gas/arc/attr-em4_dmips.d: Likewise.
	* testsuite/gas/arc/attr-em4_fpuda.d: Likewise.
	* testsuite/gas/arc/attr-em4_fpus.d: Likewise.
	* testsuite/gas/arc/attr-hs.d: Likewise.
	* testsuite/gas/arc/attr-hs34.d: Likewise.
	* testsuite/gas/arc/attr-hs38.d: Likewise.
	* testsuite/gas/arc/attr-hs38_linux.d: Likewise.
	* testsuite/gas/arc/attr-mul64.d: Likewise.
	* testsuite/gas/arc/attr-name.d: Likewise.
	* testsuite/gas/arc/attr-nps400.d: Likewise.
	* testsuite/gas/arc/attr-override-mcpu.d: Likewise.
	* testsuite/gas/arc/attr-quarkse_em.d: Likewise.

bfd/
2017-08-02  Claudiu Zissulescu <claziss@synopsys.com>

	* elf32-arc.c (arc_elf_merge_attributes): Handle
	Tag_ARC_ATR_version.

binutils/
2017-08-02  Claudiu Zissulescu <claziss@synopsys.com>

	* readelf.c (display_arc_attribute): Print Tag_ARC_ATR_version.

include/
2017-08-02  Claudiu Zissulescu <claziss@synopsys.com>

	* elf/arc.h (Tag_ARC_ATR_version): New tag.

ld/
2017-08-02  Claudiu Zissulescu <claziss@synopsys.com>

	* testsuite/ld-arc/attr-merge-0.d: Update test.
	* testsuite/ld-arc/attr-merge-1.d: Likewise.
	* testsuite/ld-arc/attr-merge-2.d: Likewise.
	* testsuite/ld-arc/attr-merge-3.d: Likewise.
	* testsuite/ld-arc/attr-merge-5.d: Likewise.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] x86_64-windows GDB crash due to fs_base/gs_base registers
@ 2018-06-29 22:12 sergiodj+buildbot
  2018-06-29 22:12 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-06-29 22:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT de52b9607d2623f18b7a7dbee3e1123d8d63f5da ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: de52b9607d2623f18b7a7dbee3e1123d8d63f5da

x86_64-windows GDB crash due to fs_base/gs_base registers

GDB is currently crashing anytime we try to access the fs_base/gs_base
registers, either to read them, or to write them. This can be observed
under various scenarios:
  - Explicit reference to those registers (eg: print $fs_base) --
    probably relatively rare;
  - Calling a function in the inferior, with the crash happening
    because we are trying to read those registers in order to save
    their value ahead of making the function call;
  - Just a plain "info registers";

The crash was introduced by the following commit:

    | commit 48aeef91c248291dd03583798904612426b1f40a
    | Date:   Mon Jun 26 18:14:43 2017 -0700
    | Subject: Include the fs_base and gs_base registers in amd64 target descriptions.

The Windows-nat implementation was unfortunately not prepared to deal
with those new registers. In particular, the way it fetches registers
is done by using a table where the index is the register number, and
the value at that index is the offset in the area in the thread's CONTEXT
data where the corresponding register value is stored.

For instance, in amd64-windows-nat.c, we can find the mappings static
array containing the following 57 elements in it:

    #define context_offset(x) (offsetof (CONTEXT, x))
    static const int mappings[] =
    {
      context_offset (Rax),
      [...]
      context_offset (FloatSave.MxCsr)
    };

That array is then used by windows_fetch_one_register via:

    char *context_offset = ((char *) &th->context) + mappings[r];

The problem is that fs_base's register number is 172, which is
well past the end of the mappings array (57 elements in total).
We end up getting an undefined offset, which happens to be so large
that it then causes the address where we try to read the register
value (a little bit later) to be invalid, thus crashing GDB with
a SEGV.

This patch side-steps the issue entirely by removing support for
those registers in GDB on x86_64-windows, because a look at the
CONTEXT structure indicates no support for getting those registers.

A more comprehensive fix would patch the potential buffer overflow
of the mappings array, but this can be done as a separate commit.

gdb/ChangeLog:

        * gdb/amd64-tdep.h (amd64_create_target_description): Add
        "segments" parameter.
        * gdb/amd64-tdep.c (amd64_none_init_abi, amd64_x32_none_init_abi)
        (_initialize_amd64_tdep): Update call to
        amd64_create_target_description.
        (amd64_target_description): Add "segments" parameter.  Adjust
        the implementation to use it.
        * gdb/amd64-linux-tdep.c (amd64_linux_read_description): Update
        call to amd64_create_target_description.
        * gdb/amd64-windows-tdep.c (amd64_windows_init_abi): Likewise.
        * gdb/arch/amd64.h (amd64_create_target_description): Add
        "segments" register.
        * gdb/arch/amd64.c (amd64_create_target_description): Add
        "segments" parameter.  Call create_feature_i386_64bit_segments
        only if SEGMENTS is true.
        * gdb/gdbserver/win32-i386-low.c (i386_arch_setup): Update
        call to amd64_create_target_description.

Tested on x86_64-windows using AdaCore's testsuite (by Joel Brobecker
<brobecker at adacore dot com>).


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] target factories, target open and multiple instances of targets
@ 2018-05-03  2:31 sergiodj+buildbot
  2018-05-03  3:17 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-05-03  2:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d9f719f1adb653ab40a55e4c1b8c300215b400ff ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: d9f719f1adb653ab40a55e4c1b8c300215b400ff

target factories, target open and multiple instances of targets

Currently, to open a target, with "target TARGET_NAME", GDB finds the
target_ops instance with "TARGET_NAME" as short name, and then calls
its target_ops::open virtual method.  In reality, there's no actual
target/name lookup, a pointer to the target_ops object was associated
with the "target TARGET_NAME" command at add_target time (when GDB is
initialized), as the command's context.

This creates a chicken and egg situation.  Consider the case of
wanting to open multiple remote connections.  We want to be able to
have one remote target_ops instance per connection, but, if we're not
connected yet, so we don't yet have an instance to call target->open()
on...

This patch fixes this by separating out common info about a target_ops
to a separate structure (shortname, longname, doc), and changing the
add_target routine to take a reference to such an object instead of a
pointer to a target_ops, and a pointer to a factory function that is
responsible to open an instance of the corresponding target when the
user types "target TARGET_NAME".

 -extern void add_target (struct target_ops *);
 +extern void add_target (const target_info &info, target_open_ftype *func);

I.e. this factory function replaces the target_ops::open virtual
method.

For static/singleton targets, nothing changes, the target_open_ftype
function pushes the global target_ops instance on the target stack.
At target_close time, the connection is tor down, but the global
target_ops object remains live.

However, targets that support being open multiple times will make
their target_open_ftype routine allocate a new target_ops instance on
the heap [e.g., new remote_target()], and push that on the stack.  At
target_close time, the new object is destroyed (by the
target_ops::close virtual method).

Both the core target and the remote targets will support being open
multiple times (others could/should too, but those were my stopping
point), but not in this patch yet.  We need to get rid of more globals
first before that'd be useful.

Native targets are somewhat special, given find_default_run_target &
friends.  Those routines also expect to return a target_ops pointer,
even before we've open the target.  However, we'll never need more
than one instance of the native target, so we can assume/require that
native targets are global/simpletons, and have the backends register a
pointer to the native target_ops.  Since all native targets inherit
inf_child_target, we can centralize that registration.  See
add_inf_child_target, get_native_target/set_native_target and
find_default_run_target.

gdb/ChangeLog:
2018-05-02  Pedro Alves  <palves@redhat.com>

	* aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Use
	add_inf_child_target.
	* aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Use
	add_inf_child_target.
	* aix-thread.c (aix_thread_target_info): New.
	(aix_thread_target) <shortname, longname, doc>: Delete.
	<info>: New.
	* alpha-bsd-nat.c (_initialize_alphabsd_nat): Use
	add_inf_child_target.
	* alpha-linux-nat.c (_initialize_alpha_linux_nat): Use
	add_inf_child_target.
	* amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Use
	add_inf_child_target.
	* amd64-linux-nat.c (_initialize_amd64_linux_nat): Use
	add_inf_child_target.
	* amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Use
	add_inf_child_target.
	* amd64-obsd-nat.c (_initialize_amd64obsd_nat): Use
	add_inf_child_target.
	* arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Use
	add_inf_child_target.
	* arm-linux-nat.c (_initialize_arm_linux_nat): Use
	add_inf_child_target.
	* arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Use
	add_inf_child_target.
	* bfd-target.c (target_bfd_target_info): New.
	(target_bfd) <shortname, longname, doc>: Delete.
	<info>: New.
	* bsd-kvm.c (bsd_kvm_target_info): New.
	(bsd_kvm_target) <shortname, longname, doc>: Delete.
	<info>: New.
	(bsd_kvm_target::open): Rename to ...
	(bsd_kvm_target_open): ... this.  Adjust.
	* bsd-uthread.c (bsd_uthread_target_info): New.
	(bsd_uthread_target) <shortname, longname, doc>: Delete.
	<info>:	New.
	* corefile.c (core_file_command): Adjust.
	* corelow.c (core_target_info): New.
	(core_target) <shortname, longname, doc>: Delete.
	<info>: New.
	(core_target::open): Rename to ...
	(core_target_open): ... this.  Adjust.
	* ctf.c (ctf_target_info): New.
	(ctf_target) <shortname, longname, doc>: Delete.
	<info>:	New.
	(ctf_target::open): Rename to ...
	(ctf_target_open): ... this.
	(_initialize_ctf): Adjust.
	* exec.c (exec_target_info): New.
	(exec_target) <shortname, longname, doc>: Delete.
	<info>:	New.
	(exec_target::open): Rename to ...
	(exec_target_open): ... this.
	* gdbcore.h (core_target_open): Declare.
	* go32-nat.c (_initialize_go32_nat): Use add_inf_child_target.
	* hppa-linux-nat.c (_initialize_hppa_linux_nat): Use
	add_inf_child_target.
	* hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Use
	add_inf_child_target.
	* hppa-obsd-nat.c (_initialize_hppaobsd_nat): Use
	add_inf_child_target.
	* i386-darwin-nat.c (_initialize_i386_darwin_nat): Use
	add_inf_child_target.
	* i386-fbsd-nat.c (_initialize_i386fbsd_nat): Use
	add_inf_child_target.
	* i386-gnu-nat.c (_initialize_i386gnu_nat): Use
	add_inf_child_target.
	* i386-linux-nat.c (_initialize_i386_linux_nat): Use
	add_inf_child_target.
	* i386-nbsd-nat.c (_initialize_i386nbsd_nat): Use
	add_inf_child_target.
	* i386-obsd-nat.c (_initialize_i386obsd_nat): Use
	add_inf_child_target.
	* ia64-linux-nat.c (_initialize_ia64_linux_nat): Use
	add_inf_child_target.
	* inf-child.c (inf_child_target_info): New.
	(inf_child_target::info): New.
	(inf_child_open_target): Remove 'target' parameter.  Use
	get_native_target instead.
	(inf_child_target::open): Delete.
	(add_inf_child_target): New.
	* inf-child.h (inf_child_target) <shortname, longname, doc, open>:
	Delete.
	<info>:	New.
	(add_inf_child_target): Declare.
	(inf_child_open_target): Declare.
	* linux-thread-db.c (thread_db_target_info): New.
	(thread_db_target) <shortname, longname, doc>: Delete.
	<info>:	New.
	* m32r-linux-nat.c (_initialize_m32r_linux_nat): Use
	add_inf_child_target.
	* m68k-bsd-nat.c (_initialize_m68kbsd_nat): Use
	add_inf_child_target.
	* m68k-linux-nat.c (_initialize_m68k_linux_nat): Use
	add_inf_child_target.
	* m88k-bsd-nat.c (_initialize_m88kbsd_nat): Use
	add_inf_child_target.
	* make-target-delegates (print_class): Adjust.
	* mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Use
	add_inf_child_target.
	* mips-linux-nat.c (_initialize_mips_linux_nat): Use
	add_inf_child_target.
	* mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Use
	add_inf_child_target.
	* mips64-obsd-nat.c (_initialize_mips64obsd_nat): Use
	add_inf_child_target.
	* nto-procfs.c (nto_native_target_info): New.
	(nto_procfs_target_native) <shortname, longname, doc>:
	Delete.
	<info>:	New.
	(nto_procfs_target_info): New.
	(nto_procfs_target_procfs) <shortname, longname, doc>:
	Delete.
	<info>:	New.
	(init_procfs_targets): Adjust.
	* ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Use
	add_inf_child_target.
	* ppc-linux-nat.c (_initialize_ppc_linux_nat): Use
	add_inf_child_target.
	* ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Use
	add_inf_child_target.
	* ppc-obsd-nat.c (_initialize_ppcobsd_nat): Use
	add_inf_child_target.
	* ravenscar-thread.c (ravenscar_target_info): New.
	(ravenscar_thread_target) <shortname, longname, doc>:
	Delete.
	<info>:	New.
	* record-btrace.c (record_btrace_target_info):
	(record_btrace_target) <shortname, longname, doc>: Delete.
	<info>: New.
	(record_btrace_target::open): Rename to ...
	(record_btrace_target_open): ... this.  Adjust.
	* record-full.c (record_longname, record_doc): New.
	(record_full_base_target) <shortname, longname, doc>: Delete.
	<info>: New.
	(record_full_target_info): New.
	(record_full_target): <shortname>: Delete.
	<info>: New.
	(record_full_core_open_1, record_full_open_1): Update comments.
	(record_full_base_target::open): Rename to ...
	(record_full_open): ... this.
	(cmd_record_full_restore): Update.
	(_initialize_record_full): Update.
	* remote-sim.c (remote_sim_target_info): New.
	(gdbsim_target) <shortname, longname, doc>: Delete.
	<info>: New.
	(gdbsim_target::open): Rename to ...
	(gdbsim_target_open): ... this.
	(_initialize_remote_sim): Adjust.
	* remote.c (remote_doc): New.
	(remote_target_info): New.
	(remote_target) <shortname, longname, doc>: Delete.
	<info>: New.
	(extended_remote_target_info): New.
	(extended_remote_target) <shortname, longname, doc>: Delete.
	<info>: New.
	(remote_target::open_1): Make static.  Adjust.
	* rs6000-nat.c (_initialize_rs6000_nat): Use add_inf_child_target.
	* s390-linux-nat.c (_initialize_s390_nat): Use
	add_inf_child_target.
	* sh-nbsd-nat.c (_initialize_shnbsd_nat): Use
	add_inf_child_target.
	* sol-thread.c (thread_db_target_info): New.
	(sol_thread_target) <shortname, longname, doc>: Delete.
	<info>: New.
	* sparc-linux-nat.c (_initialize_sparc_linux_nat): Use
	add_inf_child_target.
	* sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Use
	add_inf_child_target.
	* sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Use
	add_inf_child_target.
	* sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Use
	add_inf_child_target.
	* sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Use
	add_inf_child_target.
	* sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Use
	add_inf_child_target.
	* spu-linux-nat.c (_initialize_spu_nat): Use
	add_inf_child_target.
	* spu-multiarch.c (spu_multiarch_target_info): New.
	(spu_multiarch_target) <shortname, longname, doc>: Delete.
	<info>: New.
	* target-delegates.c: Regenerate.
	* target.c: Include <unordered_map>.
	(target_ops_p): Delete.
	(DEF_VEC_P(target_ops_p)): Delete.
	(target_factories): New.
	(test_target_info): New.
	(test_target_ops::info): New.
	(open_target): Adjust to use target_factories.
	(add_target_with_completer): Rename to ...
	(add_target): ... this.  Change prototype.  Register target_info
	and open callback in target_factories.  Register target_info in
	command context instead of target_ops.
	(add_target): Delete old implementation.
	(add_deprecated_target_alias): Change prototype.  Adjust.
	(the_native_target): New.
	(set_native_target, get_native_target): New.
	(find_default_run_target): Use the_native_target.
	(find_attach_target, find_run_target): Simplify.
	(target_ops::open): Delete.
	(dummy_target_info): New.
	(dummy_target::shortname, dummy_target::longname)
	(dummy_target::doc): Delete.
	(dummy_target::info): New.
	(debug_target::shortname, debug_target::longname)
	(debug_target::doc): Delete.
	(debug_target::info): New.
	* target.h (struct target_info): New.
	(target_ops::~target_ops): Add comment.
	(target_ops::info): New.
	(target_ops::shortname, target_ops::longname, target_ops::doc): No
	longer virtual.  Implement in terms of target_info.
	(set_native_target, get_native_target): Declare.
	(target_open_ftype): New.
	(add_target, add_target_with_completer)
	(add_deprecated_target_alias): Change prototype.
	(test_target) <shortname, longname, doc>: Delete.
	<info>: New.
	* tilegx-linux-nat.c (_initialize_tile_linux_nat): Use
	add_inf_child_target.
	* tracefile-tfile.c (tfile_target_info): New.
	(tfile_target) <shortname, longname, doc>: Delete.
	<info>: New.
	(tfile_target::open): Rename to ...
	(tfile_target_open): ... this.
	(_initialize_tracefile_tfile): Adjust.
	* vax-bsd-nat.c (_initialize_vaxbsd_nat): Use
	add_inf_child_target.
	* windows-nat.c (_initialize_windows_nat): Use
	add_inf_child_target.
	* xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Use
	add_inf_child_target.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] linux_nat_target: More low methods
@ 2018-05-03  2:26 sergiodj+buildbot
  2018-05-03  2:58 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-05-03  2:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 135340afdf3b333cde11e4429fb16271d5170335 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 135340afdf3b333cde11e4429fb16271d5170335

linux_nat_target: More low methods

This converts the remaining linux-nat.c hooks low_ methods like had
been started in a previous patch.  The linux_nat_set_foo routines are
all gone with this.

gdb/ChangeLog:
2018-05-02  Pedro Alves  <palves@redhat.com>

	* linux-nat.h (linux_nat_target) <low_new_thread,
	low_delete_thread, low_new_fork, low_forget_process,
	low_prepare_to_resume, low_siginfo_fixup, low_status_is_event>:
	New virtual methods.
	(linux_nat_set_new_thread, linux_nat_set_delete_thread)
	(linux_nat_new_fork_ftype, linux_nat_set_new_fork)
	(linux_nat_forget_process_ftype, linux_nat_set_forget_process)
	(linux_nat_forget_process, linux_nat_set_siginfo_fixup)
	(linux_nat_set_prepare_to_resume, linux_nat_set_status_is_event):
	Delete.
	* linux-fork.c (delete_fork): Adjust to call low method.
	* linux-nat.c (linux_nat_new_thread, linux_nat_delete_thread)
	(linux_nat_new_fork, linux_nat_forget_process_hook)
	(linux_nat_prepare_to_resume, linux_nat_siginfo_fixup)
	(linux_nat_status_is_event):
	(linux_nat_target::follow_fork, lwp_free, add_lwp, detach_one_lwp)
	(linux_resume_one_lwp_throw, linux_handle_extended_wait): Adjust
	to call low method.
	(sigtrap_is_event): Rename to ...
	(linux_nat_target::low_status_is_event): ... this.
	(linux_nat_set_status_is_event): Delete.
	(save_stop_reason, linux_nat_wait_1)
	(linux_nat_target::mourn_inferior, siginfo_fixup): Adjust to call
	low methods.
	(linux_nat_set_new_thread, linux_nat_set_delete_thread)
	(linux_nat_set_new_fork, linux_nat_set_forget_process)
	(linux_nat_forget_process, linux_nat_set_siginfo_fixup)
	(linux_nat_set_prepare_to_resume): Delete.
	* aarch64-linux-nat.c: All linux_nat_set_* callbacks converted to
	low virtual methods.
	* amd64-linux-nat.c: Likewise.
	* arm-linux-nat.c: Likewise.
	* i386-linux-nat.c: Likewise.
	* ia64-linux-nat.c: Likewise.
	* mips-linux-nat.c: Likewise.
	* ppc-linux-nat.c: Likewise.
	* s390-linux-nat.c: Likewise.
	* sparc64-linux-nat.c: Likewise.
	* x86-linux-nat.c: Likewise.
	* x86-linux-nat.h: Include "nat/x86-linux.h".
	(x86_linux_nat_target) <low_new_fork, low_forget_process,
	low_prepare_to_resume, low_new_thread, low_delete_thread>:
	Override methods.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] target_ops: Use bool throughout
@ 2018-05-03  2:21 sergiodj+buildbot
  2018-05-03  2:52 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-05-03  2:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 57810aa7e8032c598897454daea14ed17df0f89d ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 57810aa7e8032c598897454daea14ed17df0f89d

target_ops: Use bool throughout

After the previous target_ops/C++ patches are all squashed and merged,
this one can go in separately.

This patch adjusts all the target methods to return bool instead of int
when they're returning a boolean.

gdb/ChangeLog:
2018-05-02  Pedro Alves  <palves@redhat.com>

	* target.h (target_ops)
	<stopped_by_sw_breakpoint, supports_stopped_by_sw_breakpoint,
	stopped_by_hw_breakpoint, supports_stopped_by_hw_breakpoint,
	stopped_by_watchpoint, have_continuable_watchpoint,
	stopped_data_address, watchpoint_addr_within_range,
	can_accel_watchpoint_condition, can_run, thread_alive,
	has_all_memory, has_memory, has_stack, has_registers,
	has_execution, can_async_p, is_async_p, supports_non_stop,
	always_non_stop_p, can_execute_reverse, supports_multi_process,
	supports_enable_disable_tracepoint,
	supports_disable_randomization, supports_string_tracing,
	supports_evaluation_of_breakpoint_conditions,
	can_run_breakpoint_commands, filesystem_is_local,
	can_download_tracepoint, get_trace_state_variable_value,
	set_trace_notes, get_tib_address, use_agent, can_use_agent,
	record_is_replaying, record_will_replay,
	augmented_libraries_svr4_read>: Adjust to return bool.
	* aarch64-linux-nat.c: All implementations adjusted.
	* aix-thread.c: All implementations adjusted.
	* arm-linux-nat.c: All implementations adjusted.
	* breakpoint.c: All implementations adjusted.
	* bsd-kvm.c: All implementations adjusted.
	* bsd-uthread.c: All implementations adjusted.
	* corelow.c: All implementations adjusted.
	* ctf.c: All implementations adjusted.
	* darwin-nat.c: All implementations adjusted.
	* darwin-nat.h: All implementations adjusted.
	* exec.c: All implementations adjusted.
	* fbsd-nat.c: All implementations adjusted.
	* fbsd-nat.h: All implementations adjusted.
	* gnu-nat.c: All implementations adjusted.
	* gnu-nat.h: All implementations adjusted.
	* go32-nat.c: All implementations adjusted.
	* ia64-linux-nat.c: All implementations adjusted.
	* inf-child.c: All implementations adjusted.
	* inf-child.h: All implementations adjusted.
	* inf-ptrace.c: All implementations adjusted.
	* inf-ptrace.h: All implementations adjusted.
	* linux-nat.c: All implementations adjusted.
	* linux-nat.h: All implementations adjusted.
	* mips-linux-nat.c: All implementations adjusted.
	* nto-procfs.c: All implementations adjusted.
	* ppc-linux-nat.c: All implementations adjusted.
	* procfs.c: All implementations adjusted.
	* ravenscar-thread.c: All implementations adjusted.
	* record-btrace.c: All implementations adjusted.
	* record-full.c: All implementations adjusted.
	* remote-sim.c: All implementations adjusted.
	* remote.c: All implementations adjusted.
	* s390-linux-nat.c: All implementations adjusted.
	* sol-thread.c: All implementations adjusted.
	* spu-multiarch.c: All implementations adjusted.
	* target-delegates.c: All implementations adjusted.
	* target.c: All implementations adjusted.
	* target.h: All implementations adjusted.
	* tracefile-tfile.c: All implementations adjusted.
	* tracefile.c: All implementations adjusted.
	* tracefile.h: All implementations adjusted.
	* windows-nat.c: All implementations adjusted.
	* x86-linux-nat.h: All implementations adjusted.
	* x86-nat.h: All implementations adjusted.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] make-target-delegates: line break between return type and function name
@ 2018-05-03  2:19 sergiodj+buildbot
  2018-05-03  2:51 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-05-03  2:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ad6a4e2dd69f9d343864181b638e166ff1458861 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: ad6a4e2dd69f9d343864181b638e166ff1458861

make-target-delegates: line break between return type and function name

Before the target_ops C++ification, this wasn't necessary simply
because the methods were wrapped in ()'s, like
  '(*to_my_long_method_name) (target_ops *)',
so
  std::vector<long_type_name>(*to_my_long_method_name) ()TARGET_DEFAULT_IGNORE ()

still parsed correctly.  With the (*) gone, we need this.

gdb/ChangeLog:
2018-05-02  Pedro Alves  <palves@redhat.com>

	* make-target-delegates (scan_target_h): Don't trim lines here.
	Replace sequences of tabs and/or whitespace with a single
	whitespace.
	(top level, parsing methods): Trim each line before processing it
	here.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Convert struct target_ops to C++
@ 2018-05-03  2:19 sergiodj+buildbot
  2018-05-03  2:48 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-05-03  2:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f6ac5f3d63e03a81c4ff3749aba234961cc9090e ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: f6ac5f3d63e03a81c4ff3749aba234961cc9090e

Convert struct target_ops to C++

I.e., use C++ virtual methods and inheritance instead of tables of
function pointers.

Unfortunately, there's no way to do a smooth transition.  ALL native
targets in the tree must be converted at the same time.  I've tested
all I could with cross compilers and with help from GCC compile farm,
but naturally I haven't been able to test many of the ports.  Still, I
made a best effort to port everything over, and while I expect some
build problems due to typos and such, which should be trivial to fix,
I don't expect any design problems.

* Implementation notes:

- The flattened current_target is gone.  References to current_target
  or current_target.beneath are replaced with references to
  target_stack (the top of the stack) directly.

- To keep "set debug target" working, this adds a new debug_stratum
  layer that sits on top of the stack, prints the debug, and delegates
  to the target beneath.

  In addition, this makes the shortname and longname properties of
  target_ops be virtual methods instead of data fields, and makes the
  debug target defer those to the target beneath.  This is so that
  debug code sprinkled around that does "if (debugtarget) ..."  can
  transparently print the name of the target beneath.

  A patch later in the series actually splits out the
  shortname/longname methods to a separate structure, but I preferred
  to keep that chance separate as it is associated with changing a bit
  the design of how targets are registered and open.

- Since you can't check whether a C++ virtual method is overridden,
  the old method of checking whether a target_ops implements a method
  by comparing the function pointer must be replaced with something
  else.

  Some cases are fixed by adding a parallel "can_do_foo" target_ops
  methods.  E.g.,:

    +  for (t = target_stack; t != NULL; t = t->beneath)
	 {
    -      if (t->to_create_inferior != NULL)
    +      if (t->can_create_inferior ())
	    break;
	 }

  Others are fixed by changing void return type to bool or int return
  type, and have the default implementation return false or -1, to
  indicate lack of support.

- make-target-delegates was adjusted to generate C++ classes and
  methods.

  It needed tweaks to grok "virtual" in front of the target method
  name, and for the fact that methods are no longer function pointers.
  (In particular, the current code parsing the return type was simple
  because it could simply parse up until the '(' in '(*to_foo)'.

  It now generates a couple C++ classes that inherit target_ops:
  dummy_target and debug_target.

  Since we need to generate the class declarations as well, i.e., we
  need to emit methods twice, we now generate the code in two passes.

- The core_target global is renamed to avoid conflict with the
  "core_target" class.

- ctf/tfile targets

  init_tracefile_ops is replaced by a base class that is inherited by
  both ctf and tfile.

- bsd-uthread

  The bsd_uthread_ops_hack hack is gone.  It's not needed because
  nothing was extending a target created by bsd_uthread_target.

- remote/extended-remote targets

  This is a first pass, just enough to C++ify target_ops.

  A later pass will convert more free functions to methods, and make
  remote_state be truly per remote instance, allowing multiple
  simultaneous instances of remote targets.

- inf-child/"native" is converted to an actual base class
  (inf_child_target), that is inherited by all native targets.

- GNU/Linux

  The old weird double-target linux_ops mechanism in linux-nat.c, is
  gone, replaced by adding a few virtual methods to linux-nat.h's
  target_ops, called low_XXX, that the concrete linux-nat
  implementations override.  Sort of like gdbserver's
  linux_target_ops, but simpler, for requiring only one
  target_ops-like hierarchy, which spares implementing the same method
  twice when we need to forward the method to a low implementation.
  The low target simply reimplements the target_ops method directly in
  that case.

  There are a few remaining linux-nat.c hooks that would be better
  converted to low_ methods like above too.  E.g.:

   linux_nat_set_new_thread (t, x86_linux_new_thread);
   linux_nat_set_new_fork (t, x86_linux_new_fork);
   linux_nat_set_forget_process

  That'll be done in a follow up patch.

- We can no longer use functions like x86_use_watchpoints to install
  custom methods on an arbitrary base target.

  The patch replaces instances of such a pattern with template mixins.
  For example memory_breakpoint_target defined in target.h, or
  x86_nat_target in x86-nat.h.

- linux_trad_target, MIPS and Alpha GNU/Linux

  The code in the new linux-nat-trad.h/c files which was split off of
  inf-ptrace.h/c recently, is converted to a C++ base class, and used
  by the MIPS and Alpha GNU/Linux ports.

- BSD targets

  The

    $architecture x NetBSD/OpenBSD/FreeBSD

  support matrix complicates things a bit.  There's common BSD target
  code, and there's common architecture-specific code shared between
  the different BSDs.  Currently, all that is stiched together to form
  a final target, via the i386bsd_target, x86bsd_target,
  fbsd_nat_add_target functions etc.

  This introduces new fbsd_nat_target, obsd_nat_target and
  nbsd_nat_target classes that serve as base/prototype target for the
  corresponding BSD variant.

  And introduces generic i386/AMD64 BSD targets, to be used as
  template mixin to build a final target.  Similarly, a generic SPARC
  target is added, used by both BSD and Linux ports.

- bsd_kvm_add_target, BSD libkvm target

  I considered making bsd_kvm_supply_pcb a virtual method, and then
  have each port inherit bsd_kvm_target and override that method, but
  that was resulting in lots of unjustified churn, so I left the
  function pointer mechanism alone.

gdb/ChangeLog:
2018-05-02  Pedro Alves  <palves@redhat.com>
	    John Baldwin  <jhb@freebsd.org>

	* target.h (enum strata) <debug_stratum>: New.
	(struct target_ops) <all delegation methods>: Replace by C++
	virtual methods, and drop "to_" prefix.  All references updated
	throughout.
	<to_shortname, to_longname, to_doc, to_data,
	to_have_steppable_watchpoint, to_have_continuable_watchpoint,
	to_has_thread_control, to_attach_no_wait>: Delete, replaced by
	virtual methods.  All references updated throughout.
	<can_attach, supports_terminal_ours, can_create_inferior,
	get_thread_control_capabilities, attach_no_wait>: New
	virtual methods.
	<insert_breakpoint, remove_breakpoint>: Now
	TARGET_DEFAULT_NORETURN methods.
	<info_proc>: Now returns bool.
	<to_magic>: Delete.
	(OPS_MAGIC): Delete.
	(current_target): Delete.  All references replaced by references
	to ...
	(target_stack): ... this.  New.
	(target_shortname, target_longname): Adjust.
	(target_can_run): Now a function declaration.
	(default_child_has_all_memory, default_child_has_memory)
	(default_child_has_stack, default_child_has_registers)
	(default_child_has_execution): Remove target_ops parameter.
	(complete_target_initialization): Delete.
	(memory_breakpoint_target): New template class.
	(test_target_ops): Refactor as a C++ class with virtual methods.
	* make-target-delegates (NAME_PART): Tighten.
	(POINTER_PART, CP_SYMBOL): New.
	(SIMPLE_RETURN_PART): Reimplement.
	(VEC_RETURN_PART): Expect less.
	(RETURN_PART, VIRTUAL_PART): New.
	(METHOD): Adjust to C++ virtual methods.
	(scan_target_h): Remove reference to C99.
	(dname): Output "target_ops::" prefix.
	(write_function_header): Adjust to output a C++ class method.
	(write_declaration): New.
	(write_delegator): Adjust to output a C++ class method.
	(tdname): Output "dummy_target::" prefix.
	(write_tdefault, write_debugmethod): Adjust to output a C++ class
	method.
	(tdefault_names, debug_names): Delete.
	(return_types, tdefaults, styles, argtypes_array): New.
	(top level): All methods are delegators.
	(print_class): New.
	(top level): Print dummy_target and debug_target classes.
	* target-delegates.c: Regenerate.
	* target-debug.h (target_debug_print_enum_info_proc_what)
	(target_debug_print_thread_control_capabilities)
	(target_debug_print_thread_info_p): New.
	* target.c (dummy_target): Delete.
	(the_dummy_target, the_debug_target): New.
	(target_stack): Now extern.
	(set_targetdebug): Push/unpush debug target.
	(default_child_has_all_memory, default_child_has_memory)
	(default_child_has_stack, default_child_has_registers)
	(default_child_has_execution): Remove target_ops parameter.
	(complete_target_initialization): Delete.
	(add_target_with_completer): No longer call
	complete_target_initialization.
	(target_supports_terminal_ours): Use regular delegation.
	(update_current_target): Delete.
	(push_target): No longer check magic number.  Don't call
	update_current_target.
	(unpush_target): Don't call update_current_target.
	(target_is_pushed): No longer check magic number.
	(target_require_runnable): Skip for all stratums over
	process_stratum.
	(target_ops::info_proc): New.
	(target_info_proc): Use find_target_at and
	find_default_run_target.
	(target_supports_disable_randomization): Use regular delegation.
	(target_get_osdata): Use find_target_at.
	(target_ops::open, target_ops::close, target_ops::can_attach)
	(target_ops::attach, target_ops::can_create_inferior)
	(target_ops::create_inferior, target_ops::can_run)
	(target_can_run): New.
	(default_fileio_target): Use regular delegation.
	(target_ops::fileio_open, target_ops::fileio_pwrite)
	(target_ops::fileio_pread, target_ops::fileio_fstat)
	(target_ops::fileio_close, target_ops::fileio_unlink)
	(target_ops::fileio_readlink): New.
	(target_fileio_open_1, target_fileio_unlink)
	(target_fileio_readlink): Always call the target method.  Handle
	FILEIO_ENOSYS.
	(return_zero, return_zero_has_execution): Delete.
	(init_dummy_target): Delete.
	(dummy_target::dummy_target, dummy_target::shortname)
	(dummy_target::longname, dummy_target::doc)
	(debug_target::debug_target, debug_target::shortname)
	(debug_target::longname, debug_target::doc): New.
	(target_supports_delete_record): Use regular delegation.
	(setup_target_debug): Delete.
	(maintenance_print_target_stack): Skip debug_stratum.
	(initialize_targets): Instantiate the_dummy_target and
	the_debug_target.
	* auxv.c (target_auxv_parse): Remove 'ops' parameter.  Adjust to
	use target_stack.
	(target_auxv_search, fprint_target_auxv): Adjust.
	(info_auxv_command): Adjust to use target_stack.
	* auxv.h (target_auxv_parse): Remove 'ops' parameter.
	* exceptions.c (print_flush): Handle a NULL target_stack.
	* regcache.c (target_ops_no_register): Refactor as class with
	virtual methods.

	* exec.c (exec_target): New class.
	(exec_ops): Now an exec_target.
	(exec_open, exec_close_1, exec_get_section_table)
	(exec_xfer_partial, exec_files_info, exec_has_memory)
	(exec_make_note_section): Refactor as exec_target methods.
	(exec_file_clear, ignore, exec_remove_breakpoint, init_exec_ops):
	Delete.
	(exec_target::find_memory_regions): New.
	(_initialize_exec): Don't call init_exec_ops.
	* gdbcore.h (exec_file_clear): Delete.

	* corefile.c (core_target): Delete.
	(core_file_command): Adjust.
	* corelow.c (core_target): New class.
	(the_core_target): New.
	(core_close): Remove target_ops parameter.
	(core_close_cleanup): Adjust.
	(core_target::close): New.
	(core_open, core_detach, get_core_registers, core_files_info)
	(core_xfer_partial, core_thread_alive, core_read_description)
	(core_pid_to_str, core_thread_name, core_has_memory)
	(core_has_stack, core_has_registers, core_info_proc): Rework as
	core_target methods.
	(ignore, core_remove_breakpoint, init_core_ops): Delete.
	(_initialize_corelow): Initialize the_core_target.
	* gdbcore.h (core_target): Delete.
	(the_core_target): New.

	* ctf.c: (ctf_target): New class.
	(ctf_ops): Now a ctf_target.
	(ctf_open, ctf_close, ctf_files_info, ctf_fetch_registers)
	(ctf_xfer_partial, ctf_get_trace_state_variable_value)
	(ctf_trace_find, ctf_traceframe_info): Refactor as ctf_target
	methods.
	(init_ctf_ops): Delete.
	(_initialize_ctf): Don't call it.
	* tracefile-tfile.c (tfile_target): New class.
	(tfile_ops): Now a tfile_target.
	(tfile_open, tfile_close, tfile_files_info)
	(tfile_get_tracepoint_status, tfile_trace_find)
	(tfile_fetch_registers, tfile_xfer_partial)
	(tfile_get_trace_state_variable_value, tfile_traceframe_info):
	Refactor as tfile_target methods.
	(tfile_xfer_partial_features): Remove target_ops parameter.
	(init_tfile_ops): Delete.
	(_initialize_tracefile_tfile): Don't call it.
	* tracefile.c (tracefile_has_all_memory, tracefile_has_memory)
	(tracefile_has_stack, tracefile_has_registers)
	(tracefile_thread_alive, tracefile_get_trace_status): Refactor as
	tracefile_target methods.
	(init_tracefile_ops): Delete.
	(tracefile_target::tracefile_target): New.
	* tracefile.h: Include "target.h".
	(tracefile_target): New class.
	(init_tracefile_ops): Delete.

	* spu-multiarch.c (spu_multiarch_target): New class.
	(spu_ops): Now a spu_multiarch_target.
	(spu_thread_architecture, spu_region_ok_for_hw_watchpoint)
	(spu_fetch_registers, spu_store_registers, spu_xfer_partial)
	(spu_search_memory, spu_mourn_inferior): Refactor as
	spu_multiarch_target methods.
	(init_spu_ops): Delete.
	(_initialize_spu_multiarch): Remove references to init_spu_ops,
	complete_target_initialization.

	* ravenscar-thread.c (ravenscar_thread_target): New class.
	(ravenscar_ops): Now a ravenscar_thread_target.
	(ravenscar_resume, ravenscar_wait, ravenscar_update_thread_list)
	(ravenscar_thread_alive, ravenscar_pid_to_str)
	(ravenscar_fetch_registers, ravenscar_store_registers)
	(ravenscar_prepare_to_store, ravenscar_stopped_by_sw_breakpoint)
	(ravenscar_stopped_by_hw_breakpoint)
	(ravenscar_stopped_by_watchpoint, ravenscar_stopped_data_address)
	(ravenscar_mourn_inferior, ravenscar_core_of_thread)
	(ravenscar_get_ada_task_ptid): Refactor as ravenscar_thread_target
	methods.
	(init_ravenscar_thread_ops): Delete.
	(_initialize_ravenscar): Remove references to
	init_ravenscar_thread_ops and complete_target_initialization.

	* bsd-uthread.c (bsd_uthread_ops_hack): Delete.
	(bsd_uthread_target): New class.
	(bsd_uthread_ops): Now a bsd_uthread_target.
	(bsd_uthread_activate): Adjust to refer to bsd_uthread_ops.
	(bsd_uthread_close, bsd_uthread_mourn_inferior)
	(bsd_uthread_fetch_registers, bsd_uthread_store_registers)
	(bsd_uthread_wait, bsd_uthread_resume, bsd_uthread_thread_alive)
	(bsd_uthread_update_thread_list, bsd_uthread_extra_thread_info)
	(bsd_uthread_pid_to_str): Refactor as bsd_uthread_target methods.
	(bsd_uthread_target): Delete function.
	(_initialize_bsd_uthread): Remove reference to
	complete_target_initialization.

	* bfd-target.c (target_bfd_data): Delete.  Fields folded into ...
	(target_bfd): ... this new class.
	(target_bfd_xfer_partial, target_bfd_get_section_table)
	(target_bfd_close): Refactor as target_bfd methods.
	(target_bfd::~target_bfd): New.
	(target_bfd_reopen): Adjust.
	(target_bfd::close): New.

	* record-btrace.c (record_btrace_target): New class.
	(record_btrace_ops): Now a record_btrace_target.
	(record_btrace_open, record_btrace_stop_recording)
	(record_btrace_disconnect, record_btrace_close)
	(record_btrace_async, record_btrace_info)
	(record_btrace_insn_history, record_btrace_insn_history_range)
	(record_btrace_insn_history_from, record_btrace_call_history)
	(record_btrace_call_history_range)
	(record_btrace_call_history_from, record_btrace_record_method)
	(record_btrace_is_replaying, record_btrace_will_replay)
	(record_btrace_xfer_partial, record_btrace_insert_breakpoint)
	(record_btrace_remove_breakpoint, record_btrace_fetch_registers)
	(record_btrace_store_registers, record_btrace_prepare_to_store)
	(record_btrace_to_get_unwinder)
	(record_btrace_to_get_tailcall_unwinder, record_btrace_resume)
	(record_btrace_commit_resume, record_btrace_wait)
	(record_btrace_stop, record_btrace_can_execute_reverse)
	(record_btrace_stopped_by_sw_breakpoint)
	(record_btrace_supports_stopped_by_sw_breakpoint)
	(record_btrace_stopped_by_hw_breakpoint)
	(record_btrace_supports_stopped_by_hw_breakpoint)
	(record_btrace_update_thread_list, record_btrace_thread_alive)
	(record_btrace_goto_begin, record_btrace_goto_end)
	(record_btrace_goto, record_btrace_stop_replaying_all)
	(record_btrace_execution_direction)
	(record_btrace_prepare_to_generate_core)
	(record_btrace_done_generating_core): Refactor as
	record_btrace_target methods.
	(init_record_btrace_ops): Delete.
	(_initialize_record_btrace): Remove reference to
	init_record_btrace_ops.
	* record-full.c (RECORD_FULL_IS_REPLAY): Adjust to always refer to
	the execution_direction global.
	(record_full_base_target, record_full_target)
	(record_full_core_target): New classes.
	(record_full_ops): Now a record_full_target.
	(record_full_core_ops): Now a record_full_core_target.
	(record_full_target::detach, record_full_target::disconnect)
	(record_full_core_target::disconnect)
	(record_full_target::mourn_inferior, record_full_target::kill):
	New.
	(record_full_open, record_full_close, record_full_async): Refactor
	as methods of the record_full_base_target class.
	(record_full_resume, record_full_commit_resume): Refactor
	as methods of the record_full_target class.
	(record_full_wait, record_full_stopped_by_watchpoint)
	(record_full_stopped_data_address)
	(record_full_stopped_by_sw_breakpoint)
	(record_full_supports_stopped_by_sw_breakpoint)
	(record_full_stopped_by_hw_breakpoint)
	(record_full_supports_stopped_by_hw_breakpoint): Refactor as
	methods of the record_full_base_target class.
	(record_full_store_registers, record_full_xfer_partial)
	(record_full_insert_breakpoint, record_full_remove_breakpoint):
	Refactor as methods of the record_full_target class.
	(record_full_can_execute_reverse, record_full_get_bookmark)
	(record_full_goto_bookmark, record_full_execution_direction)
	(record_full_record_method, record_full_info, record_full_delete)
	(record_full_is_replaying, record_full_will_replay)
	(record_full_goto_begin, record_full_goto_end, record_full_goto)
	(record_full_stop_replaying): Refactor as methods of the
	record_full_base_target class.
	(record_full_core_resume, record_full_core_kill)
	(record_full_core_fetch_registers)
	(record_full_core_prepare_to_store)
	(record_full_core_store_registers, record_full_core_xfer_partial)
	(record_full_core_insert_breakpoint)
	(record_full_core_remove_breakpoint)
	(record_full_core_has_execution): Refactor
	as methods of the record_full_core_target class.
	(record_full_base_target::supports_delete_record): New.
	(init_record_full_ops): Delete.
	(init_record_full_core_ops): Delete.
	(record_full_save): Refactor as method of the
	record_full_base_target class.
	(_initialize_record_full): Remove references to
	init_record_full_ops and init_record_full_core_ops.

	* remote.c (remote_target, extended_remote_target): New classes.
	(remote_ops): Now a remote_target.
	(extended_remote_ops): Now an extended_remote_target.
	(remote_insert_fork_catchpoint, remote_remove_fork_catchpoint)
	(remote_insert_vfork_catchpoint, remote_remove_vfork_catchpoint)
	(remote_insert_exec_catchpoint, remote_remove_exec_catchpoint)
	(remote_pass_signals, remote_set_syscall_catchpoint)
	(remote_program_signals, )
	(remote_thread_always_alive): Remove target_ops parameter.
	(remote_thread_alive, remote_thread_name)
	(remote_update_thread_list, remote_threads_extra_info)
	(remote_static_tracepoint_marker_at)
	(remote_static_tracepoint_markers_by_strid)
	(remote_get_ada_task_ptid, remote_close, remote_start_remote)
	(remote_open): Refactor as methods of remote_target.
	(extended_remote_open, extended_remote_detach)
	(extended_remote_attach, extended_remote_post_attach):
	(extended_remote_supports_disable_randomization)
	(extended_remote_create_inferior): : Refactor as method of
	extended_remote_target.
	(remote_set_permissions, remote_open_1, remote_detach)
	(remote_follow_fork, remote_follow_exec, remote_disconnect)
	(remote_resume, remote_commit_resume, remote_stop)
	(remote_interrupt, remote_pass_ctrlc, remote_terminal_inferior)
	(remote_terminal_ours, remote_wait, remote_fetch_registers)
	(remote_prepare_to_store, remote_store_registers)
	(remote_flash_erase, remote_flash_done, remote_files_info)
	(remote_kill, remote_mourn, remote_insert_breakpoint)
	(remote_remove_breakpoint, remote_insert_watchpoint)
	(remote_watchpoint_addr_within_range)
	(remote_remove_watchpoint, remote_region_ok_for_hw_watchpoint)
	(remote_check_watch_resources, remote_stopped_by_sw_breakpoint)
	(remote_supports_stopped_by_sw_breakpoint)
	(remote_stopped_by_hw_breakpoint)
	(remote_supports_stopped_by_hw_breakpoint)
	(remote_stopped_by_watchpoint, remote_stopped_data_address)
	(remote_insert_hw_breakpoint, remote_remove_hw_breakpoint)
	(remote_verify_memory): Refactor as methods of remote_target.
	(remote_write_qxfer, remote_read_qxfer): Remove target_ops
	parameter.
	(remote_xfer_partial, remote_get_memory_xfer_limit)
	(remote_search_memory, remote_rcmd, remote_memory_map)
	(remote_pid_to_str, remote_get_thread_local_address)
	(remote_get_tib_address, remote_read_description): Refactor as
	methods of remote_target.
	(remote_target::fileio_open, remote_target::fileio_pwrite)
	(remote_target::fileio_pread, remote_target::fileio_close): New.
	(remote_hostio_readlink, remote_hostio_fstat)
	(remote_filesystem_is_local, remote_can_execute_reverse)
	(remote_supports_non_stop, remote_supports_disable_randomization)
	(remote_supports_multi_process, remote_supports_cond_breakpoints)
	(remote_supports_enable_disable_tracepoint)
	(remote_supports_string_tracing)
	(remote_can_run_breakpoint_commands, remote_trace_init)
	(remote_download_tracepoint, remote_can_download_tracepoint)
	(remote_download_trace_state_variable, remote_enable_tracepoint)
	(remote_disable_tracepoint, remote_trace_set_readonly_regions)
	(remote_trace_start, remote_get_trace_status)
	(remote_get_tracepoint_status, remote_trace_stop)
	(remote_trace_find, remote_get_trace_state_variable_value)
	(remote_save_trace_data, remote_get_raw_trace_data)
	(remote_set_disconnected_tracing, remote_core_of_thread)
	(remote_set_circular_trace_buffer, remote_traceframe_info)
	(remote_get_min_fast_tracepoint_insn_len)
	(remote_set_trace_buffer_size, remote_set_trace_notes)
	(remote_use_agent, remote_can_use_agent, remote_enable_btrace)
	(remote_disable_btrace, remote_teardown_btrace)
	(remote_read_btrace, remote_btrace_conf)
	(remote_augmented_libraries_svr4_read, remote_load)
	(remote_pid_to_exec_file, remote_can_do_single_step)
	(remote_execution_direction, remote_thread_handle_to_thread_info):
	Refactor as methods of remote_target.
	(init_remote_ops, init_extended_remote_ops): Delete.
	(remote_can_async_p, remote_is_async_p, remote_async)
	(remote_thread_events, remote_upload_tracepoints)
	(remote_upload_trace_state_variables): Refactor as methods of
	remote_target.
	(_initialize_remote): Remove references to init_remote_ops and
	init_extended_remote_ops.

	* remote-sim.c (gdbsim_target): New class.
	(gdbsim_fetch_register, gdbsim_store_register, gdbsim_kill)
	(gdbsim_load, gdbsim_create_inferior, gdbsim_open, gdbsim_close)
	(gdbsim_detach, gdbsim_resume, gdbsim_interrupt)
	(gdbsim_wait, gdbsim_prepare_to_store, gdbsim_xfer_partial)
	(gdbsim_files_info, gdbsim_mourn_inferior, gdbsim_thread_alive)
	(gdbsim_pid_to_str, gdbsim_has_all_memory, gdbsim_has_memory):
	Refactor as methods of gdbsim_target.
	(gdbsim_ops): Now a gdbsim_target.
	(init_gdbsim_ops): Delete.
	(gdbsim_cntrl_c): Adjust.
	(_initialize_remote_sim): Remove reference to init_gdbsim_ops.

	* amd64-linux-nat.c (amd64_linux_nat_target): New class.
	(the_amd64_linux_nat_target): New.
	(amd64_linux_fetch_inferior_registers)
	(amd64_linux_store_inferior_registers): Refactor as methods of
	amd64_linux_nat_target.
	(_initialize_amd64_linux_nat): Adjust.  Set linux_target.
	* i386-linux-nat.c: Don't include "linux-nat.h".
	(i386_linux_nat_target): New class.
	(the_i386_linux_nat_target): New.
	(i386_linux_fetch_inferior_registers)
	(i386_linux_store_inferior_registers, i386_linux_resume): Refactor
	as methods of i386_linux_nat_target.
	(_initialize_i386_linux_nat): Adjust.  Set linux_target.
	* inf-child.c (inf_child_ops): Delete.
	(inf_child_fetch_inferior_registers)
	(inf_child_store_inferior_registers): Delete.
	(inf_child_post_attach, inf_child_prepare_to_store): Refactor as
	methods of inf_child_target.
	(inf_child_target::supports_terminal_ours)
	(inf_child_target::terminal_init)
	(inf_child_target::terminal_inferior)
	(inf_child_target::terminal_ours_for_output)
	(inf_child_target::terminal_ours, inf_child_target::interrupt)
	(inf_child_target::pass_ctrlc, inf_child_target::terminal_info):
	New.
	(inf_child_open, inf_child_disconnect, inf_child_close)
	(inf_child_mourn_inferior, inf_child_maybe_unpush_target)
	(inf_child_post_startup_inferior, inf_child_can_run)
	(inf_child_pid_to_exec_file): Refactor as methods of
	inf_child_target.
	(inf_child_follow_fork): Delete.
	(inf_child_target::can_create_inferior)
	(inf_child_target::can_attach): New.
	(inf_child_target::has_all_memory, inf_child_target::has_memory)
	(inf_child_target::has_stack, inf_child_target::has_registers)
	(inf_child_target::has_execution): New.
	(inf_child_fileio_open, inf_child_fileio_pwrite)
	(inf_child_fileio_pread, inf_child_fileio_fstat)
	(inf_child_fileio_close, inf_child_fileio_unlink)
	(inf_child_fileio_readlink, inf_child_use_agent)
	(inf_child_can_use_agent): Refactor as methods of
	inf_child_target.
	(return_zero, inf_child_target): Delete.
	(inf_child_target::inf_child_target): New.
	* inf-child.h: Include "target.h".
	(inf_child_target): Delete function prototype.
	(inf_child_target): New class.
	(inf_child_open_target, inf_child_mourn_inferior)
	(inf_child_maybe_unpush_target): Delete.
	* inf-ptrace.c (inf_ptrace_target::~inf_ptrace_target): New.
	(inf_ptrace_follow_fork, inf_ptrace_insert_fork_catchpoint)
	(inf_ptrace_remove_fork_catchpoint, inf_ptrace_create_inferior)
	(inf_ptrace_post_startup_inferior, inf_ptrace_mourn_inferior)
	(inf_ptrace_attach, inf_ptrace_post_attach, inf_ptrace_detach)
	(inf_ptrace_detach_success, inf_ptrace_kill, inf_ptrace_resume)
	(inf_ptrace_wait, inf_ptrace_xfer_partial)
	(inf_ptrace_thread_alive, inf_ptrace_files_info)
	(inf_ptrace_pid_to_str, inf_ptrace_auxv_parse): Refactor as
	methods of inf_ptrace_target.
	(inf_ptrace_target): Delete function.
	* inf-ptrace.h: Include "inf-child.h".
	(inf_ptrace_target): Delete function declaration.
	(inf_ptrace_target): New class.
	(inf_ptrace_trad_target, inf_ptrace_detach_success): Delete.
	* linux-nat.c (linux_target): New.
	(linux_ops, linux_ops_saved, super_xfer_partial): Delete.
	(linux_nat_target::~linux_nat_target): New.
	(linux_child_post_attach, linux_child_post_startup_inferior)
	(linux_child_follow_fork, linux_child_insert_fork_catchpoint)
	(linux_child_remove_fork_catchpoint)
	(linux_child_insert_vfork_catchpoint)
	(linux_child_remove_vfork_catchpoint)
	(linux_child_insert_exec_catchpoint)
	(linux_child_remove_exec_catchpoint)
	(linux_child_set_syscall_catchpoint, linux_nat_pass_signals)
	(linux_nat_create_inferior, linux_nat_attach, linux_nat_detach)
	(linux_nat_resume, linux_nat_stopped_by_watchpoint)
	(linux_nat_stopped_data_address)
	(linux_nat_stopped_by_sw_breakpoint)
	(linux_nat_supports_stopped_by_sw_breakpoint)
	(linux_nat_stopped_by_hw_breakpoint)
	(linux_nat_supports_stopped_by_hw_breakpoint, linux_nat_wait)
	(linux_nat_kill, linux_nat_mourn_inferior)
	(linux_nat_xfer_partial, linux_nat_thread_alive)
	(linux_nat_update_thread_list, linux_nat_pid_to_str)
	(linux_nat_thread_name, linux_child_pid_to_exec_file)
	(linux_child_static_tracepoint_markers_by_strid)
	(linux_nat_is_async_p, linux_nat_can_async_p)
	(linux_nat_supports_non_stop, linux_nat_always_non_stop_p)
	(linux_nat_supports_multi_process)
	(linux_nat_supports_disable_randomization, linux_nat_async)
	(linux_nat_stop, linux_nat_close, linux_nat_thread_address_space)
	(linux_nat_core_of_thread, linux_nat_filesystem_is_local)
	(linux_nat_fileio_open, linux_nat_fileio_readlink)
	(linux_nat_fileio_unlink, linux_nat_thread_events): Refactor as
	methods of linux_nat_target.
	(linux_nat_wait_1, linux_xfer_siginfo, linux_proc_xfer_partial)
	(linux_proc_xfer_spu, linux_nat_xfer_osdata): Remove target_ops
	parameter.
	(check_stopped_by_watchpoint): Adjust.
	(linux_xfer_partial): Delete.
	(linux_target_install_ops, linux_target, linux_nat_add_target):
	Delete.
	(linux_nat_target::linux_nat_target): New.
	* linux-nat.h: Include "inf-ptrace.h".
	(linux_nat_target): New.
	(linux_target, linux_target_install_ops, linux_nat_add_target):
	Delete function declarations.
	(linux_target): Declare global.
	* linux-thread-db.c (thread_db_target): New.
	(thread_db_target::thread_db_target): New.
	(thread_db_ops): Delete.
	(the_thread_db_target): New.
	(thread_db_detach, thread_db_wait, thread_db_mourn_inferior)
	(thread_db_update_thread_list, thread_db_pid_to_str)
	(thread_db_extra_thread_info)
	(thread_db_thread_handle_to_thread_info)
	(thread_db_get_thread_local_address, thread_db_get_ada_task_ptid)
	(thread_db_resume): Refactor as methods of thread_db_target.
	(init_thread_db_ops): Delete.
	(_initialize_thread_db): Remove reference to init_thread_db_ops.
	* x86-linux-nat.c: Don't include "linux-nat.h".
	(super_post_startup_inferior): Delete.
	(x86_linux_nat_target::~x86_linux_nat_target): New.
	(x86_linux_child_post_startup_inferior)
	(x86_linux_read_description, x86_linux_enable_btrace)
	(x86_linux_disable_btrace, x86_linux_teardown_btrace)
	(x86_linux_read_btrace, x86_linux_btrace_conf): Refactor as
	methods of x86_linux_nat_target.
	(x86_linux_create_target): Delete.  Bits folded ...
	(x86_linux_add_target): ... here.  Now takes a linux_nat_target
	pointer.
	* x86-linux-nat.h: Include "linux-nat.h" and "x86-nat.h".
	(x86_linux_nat_target): New class.
	(x86_linux_create_target): Delete.
	(x86_linux_add_target): Now takes a linux_nat_target pointer.
	* x86-nat.c (x86_insert_watchpoint, x86_remove_watchpoint)
	(x86_region_ok_for_watchpoint, x86_stopped_data_address)
	(x86_stopped_by_watchpoint, x86_insert_hw_breakpoint)
	(x86_remove_hw_breakpoint, x86_can_use_hw_breakpoint)
	(x86_stopped_by_hw_breakpoint): Remove target_ops parameter and
	make extern.
	(x86_use_watchpoints): Delete.
	* x86-nat.h: Include "breakpoint.h" and "target.h".
	(x86_use_watchpoints): Delete.
	(x86_can_use_hw_breakpoint, x86_region_ok_for_hw_watchpoint)
	(x86_stopped_by_watchpoint, x86_stopped_data_address)
	(x86_insert_watchpoint, x86_remove_watchpoint)
	(x86_insert_hw_breakpoint, x86_remove_hw_breakpoint)
	(x86_stopped_by_hw_breakpoint): New declarations.
	(x86_nat_target): New template class.

	* ppc-linux-nat.c (ppc_linux_nat_target): New class.
	(the_ppc_linux_nat_target): New.
	(ppc_linux_fetch_inferior_registers)
	(ppc_linux_can_use_hw_breakpoint)
	(ppc_linux_region_ok_for_hw_watchpoint)
	(ppc_linux_ranged_break_num_registers)
	(ppc_linux_insert_hw_breakpoint, ppc_linux_remove_hw_breakpoint)
	(ppc_linux_insert_mask_watchpoint)
	(ppc_linux_remove_mask_watchpoint)
	(ppc_linux_can_accel_watchpoint_condition)
	(ppc_linux_insert_watchpoint, ppc_linux_remove_watchpoint)
	(ppc_linux_stopped_data_address, ppc_linux_stopped_by_watchpoint)
	(ppc_linux_watchpoint_addr_within_range)
	(ppc_linux_masked_watch_num_registers)
	(ppc_linux_store_inferior_registers, ppc_linux_auxv_parse)
	(ppc_linux_read_description): Refactor as methods of
	ppc_linux_nat_target.
	(_initialize_ppc_linux_nat): Adjust.  Set linux_target.

	* procfs.c (procfs_xfer_partial): Delete forward declaration.
	(procfs_target): New class.
	(the_procfs_target): New.
	(procfs_target): Delete function.
	(procfs_auxv_parse, procfs_attach, procfs_detach)
	(procfs_fetch_registers, procfs_store_registers, procfs_wait)
	(procfs_xfer_partial, procfs_resume, procfs_pass_signals)
	(procfs_files_info, procfs_kill_inferior, procfs_mourn_inferior)
	(procfs_create_inferior, procfs_update_thread_list)
	(procfs_thread_alive, procfs_pid_to_str)
	(procfs_can_use_hw_breakpoint, procfs_stopped_by_watchpoint)
	(procfs_stopped_data_address, procfs_insert_watchpoint)
	(procfs_remove_watchpoint, procfs_region_ok_for_hw_watchpoint)
	(proc_find_memory_regions, procfs_info_proc)
	(procfs_make_note_section): Refactor as methods of procfs_target.
	(_initialize_procfs): Adjust.
	* sol-thread.c (sol_thread_target): New class.
	(sol_thread_ops): Now a sol_thread_target.
	(sol_thread_detach, sol_thread_resume, sol_thread_wait)
	(sol_thread_fetch_registers, sol_thread_store_registers)
	(sol_thread_xfer_partial, sol_thread_mourn_inferior)
	(sol_thread_alive, solaris_pid_to_str, sol_update_thread_list)
	(sol_get_ada_task_ptid): Refactor as methods of sol_thread_target.
	(init_sol_thread_ops): Delete.
	(_initialize_sol_thread): Adjust.  Remove references to
	init_sol_thread_ops and complete_target_initialization.

	* windows-nat.c (windows_nat_target): New class.
	(windows_fetch_inferior_registers)
	(windows_store_inferior_registers, windows_resume, windows_wait)
	(windows_attach, windows_detach, windows_pid_to_exec_file)
	(windows_files_info, windows_create_inferior)
	(windows_mourn_inferior, windows_interrupt, windows_kill_inferior)
	(windows_close, windows_pid_to_str, windows_xfer_partial)
	(windows_get_tib_address, windows_get_ada_task_ptid)
	(windows_thread_name, windows_thread_alive): Refactor as
	windows_nat_target methods.
	(do_initial_windows_stuff): Adjust.
	(windows_target): Delete function.
	(_initialize_windows_nat): Adjust.

	* darwin-nat.c (darwin_resume, darwin_wait_to, darwin_interrupt)
	(darwin_mourn_inferior, darwin_kill_inferior)
	(darwin_create_inferior, darwin_attach, darwin_detach)
	(darwin_pid_to_str, darwin_thread_alive, darwin_xfer_partial)
	(darwin_pid_to_exec_file, darwin_get_ada_task_ptid)
	(darwin_supports_multi_process): Refactor as darwin_nat_target
	methods.
	(darwin_resume_to, darwin_files_info): Delete.
	(_initialize_darwin_inferior): Rename to ...
	(_initialize_darwin_nat): ... this.  Adjust to C++ification.
	* darwin-nat.h: Include "inf-child.h".
	(darwin_nat_target): New class.
	(darwin_complete_target): Delete.
	* i386-darwin-nat.c (i386_darwin_nat_target): New class.
	(darwin_target): New.
	(i386_darwin_fetch_inferior_registers)
	(i386_darwin_store_inferior_registers): Refactor as methods of
	darwin_nat_target.
	(darwin_complete_target): Delete, with ...
	(_initialize_i386_darwin_nat): ... bits factored out here.

	* alpha-linux-nat.c (alpha_linux_nat_target): New class.
	(the_alpha_linux_nat_target): New.
	(alpha_linux_register_u_offset): Refactor as
	alpha_linux_nat_target method.
	(_initialize_alpha_linux_nat): Adjust.
	* linux-nat-trad.c (inf_ptrace_register_u_offset): Delete.
	(inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
	(inf_ptrace_store_register, inf_ptrace_store_registers): Refact as
	methods of linux_nat_trad_target.
	(linux_trad_target): Delete.
	* linux-nat-trad.h (linux_trad_target): Delete function.
	(linux_nat_trad_target): New class.
	* mips-linux-nat.c (mips_linux_nat_target): New class.
	(super_fetch_registers, super_store_registers, super_close):
	Delete.
	(the_mips_linux_nat_target): New.
	(mips64_linux_regsets_fetch_registers)
	(mips64_linux_regsets_store_registers)
	(mips64_linux_fetch_registers, mips64_linux_store_registers)
	(mips_linux_register_u_offset, mips_linux_read_description)
	(mips_linux_can_use_hw_breakpoint)
	(mips_linux_stopped_by_watchpoint)
	(mips_linux_stopped_data_address)
	(mips_linux_region_ok_for_hw_watchpoint)
	(mips_linux_insert_watchpoint, mips_linux_remove_watchpoint)
	(mips_linux_close): Refactor as methods of mips_linux_nat.
	(_initialize_mips_linux_nat): Adjust to C++ification.

	* aix-thread.c (aix_thread_target): New class.
	(aix_thread_ops): Now an aix_thread_target.
	(aix_thread_detach, aix_thread_resume, aix_thread_wait)
	(aix_thread_fetch_registers, aix_thread_store_registers)
	(aix_thread_xfer_partial, aix_thread_mourn_inferior)
	(aix_thread_thread_alive, aix_thread_pid_to_str)
	(aix_thread_extra_thread_info, aix_thread_get_ada_task_ptid):
	Refactor as methods of aix_thread_target.
	(init_aix_thread_ops): Delete.
	(_initialize_aix_thread): Remove references to init_aix_thread_ops
	and complete_target_initialization.
	* rs6000-nat.c (rs6000_xfer_shared_libraries): Delete.
	(rs6000_nat_target): New class.
	(the_rs6000_nat_target): New.
	(rs6000_fetch_inferior_registers, rs6000_store_inferior_registers)
	(rs6000_xfer_partial, rs6000_wait, rs6000_create_inferior)
	(rs6000_xfer_shared_libraries): Refactor as rs6000_nat_target methods.
	(super_create_inferior): Delete.
	(_initialize_rs6000_nat): Adjust to C++ification.

	* arm-linux-nat.c (arm_linux_nat_target): New class.
	(the_arm_linux_nat_target): New.
	(arm_linux_fetch_inferior_registers)
	(arm_linux_store_inferior_registers, arm_linux_read_description)
	(arm_linux_can_use_hw_breakpoint, arm_linux_insert_hw_breakpoint)
	(arm_linux_remove_hw_breakpoint)
	(arm_linux_region_ok_for_hw_watchpoint)
	(arm_linux_insert_watchpoint, arm_linux_remove_watchpoint)
	(arm_linux_stopped_data_address, arm_linux_stopped_by_watchpoint)
	(arm_linux_watchpoint_addr_within_range): Refactor as methods of
	arm_linux_nat_target.
	(_initialize_arm_linux_nat): Adjust to C++ification.

	* aarch64-linux-nat.c (aarch64_linux_nat_target): New class.
	(the_aarch64_linux_nat_target): New.
	(aarch64_linux_fetch_inferior_registers)
	(aarch64_linux_store_inferior_registers)
	(aarch64_linux_child_post_startup_inferior)
	(aarch64_linux_read_description)
	(aarch64_linux_can_use_hw_breakpoint)
	(aarch64_linux_insert_hw_breakpoint)
	(aarch64_linux_remove_hw_breakpoint)
	(aarch64_linux_insert_watchpoint, aarch64_linux_remove_watchpoint)
	(aarch64_linux_region_ok_for_hw_watchpoint)
	(aarch64_linux_stopped_data_address)
	(aarch64_linux_stopped_by_watchpoint)
	(aarch64_linux_watchpoint_addr_within_range)
	(aarch64_linux_can_do_single_step): Refactor as methods of
	aarch64_linux_nat_target.
	(super_post_startup_inferior): Delete.
	(_initialize_aarch64_linux_nat): Adjust to C++ification.

	* hppa-linux-nat.c (hppa_linux_nat_target): New class.
	(the_hppa_linux_nat_target): New.
	(hppa_linux_fetch_inferior_registers)
	(hppa_linux_store_inferior_registers): Refactor as methods of
	hppa_linux_nat_target.
	(_initialize_hppa_linux_nat): Adjust to C++ification.

	* ia64-linux-nat.c (ia64_linux_nat_target): New class.
	(the_ia64_linux_nat_target): New.
	(ia64_linux_insert_watchpoint, ia64_linux_remove_watchpoint)
	(ia64_linux_stopped_data_address)
	(ia64_linux_stopped_by_watchpoint, ia64_linux_fetch_registers)
	(ia64_linux_store_registers, ia64_linux_xfer_partial): Refactor as
	ia64_linux_nat_target methods.
	(super_xfer_partial): Delete.
	(_initialize_ia64_linux_nat): Adjust to C++ification.

	* m32r-linux-nat.c (m32r_linux_nat_target): New class.
	(the_m32r_linux_nat_target): New.
	(m32r_linux_fetch_inferior_registers)
	(m32r_linux_store_inferior_registers): Refactor as
	m32r_linux_nat_target methods.
	(_initialize_m32r_linux_nat): Adjust to C++ification.

	* m68k-linux-nat.c (m68k_linux_nat_target): New class.
	(the_m68k_linux_nat_target): New.
	(m68k_linux_fetch_inferior_registers)
	(m68k_linux_store_inferior_registers): Refactor as
	m68k_linux_nat_target methods.
	(_initialize_m68k_linux_nat): Adjust to C++ification.

	* s390-linux-nat.c (s390_linux_nat_target): New class.
	(the_s390_linux_nat_target): New.
	(s390_linux_fetch_inferior_registers)
	(s390_linux_store_inferior_registers, s390_stopped_by_watchpoint)
	(s390_insert_watchpoint, s390_remove_watchpoint)
	(s390_can_use_hw_breakpoint, s390_insert_hw_breakpoint)
	(s390_remove_hw_breakpoint, s390_region_ok_for_hw_watchpoint)
	(s390_auxv_parse, s390_read_description): Refactor as methods of
	s390_linux_nat_target.
	(_initialize_s390_nat): Adjust to C++ification.

	* sparc-linux-nat.c (sparc_linux_nat_target): New class.
	(the_sparc_linux_nat_target): New.
	(_initialize_sparc_linux_nat): Adjust to C++ification.
	* sparc-nat.c (sparc_fetch_inferior_registers)
	(sparc_store_inferior_registers): Remove target_ops parameter.
	* sparc-nat.h (sparc_fetch_inferior_registers)
	(sparc_store_inferior_registers): Remove target_ops parameter.
	* sparc64-linux-nat.c (sparc64_linux_nat_target): New class.
	(the_sparc64_linux_nat_target): New.
	(_initialize_sparc64_linux_nat): Adjust to C++ification.

	* spu-linux-nat.c (spu_linux_nat_target): New class.
	(the_spu_linux_nat_target): New.
	(spu_child_post_startup_inferior, spu_child_post_attach)
	(spu_child_wait, spu_fetch_inferior_registers)
	(spu_store_inferior_registers, spu_xfer_partial)
	(spu_can_use_hw_breakpoint): Refactor as spu_linux_nat_target
	methods.
	(_initialize_spu_nat): Adjust to C++ification.

	* tilegx-linux-nat.c (tilegx_linux_nat_target): New class.
	(the_tilegx_linux_nat_target): New.
	(fetch_inferior_registers, store_inferior_registers):
	Refactor as methods.
	(_initialize_tile_linux_nat): Adjust to C++ification.

	* xtensa-linux-nat.c (xtensa_linux_nat_target): New class.
	(the_xtensa_linux_nat_target): New.
	(xtensa_linux_fetch_inferior_registers)
	(xtensa_linux_store_inferior_registers): Refactor as
	xtensa_linux_nat_target methods.
	(_initialize_xtensa_linux_nat): Adjust to C++ification.

	* fbsd-nat.c (USE_SIGTRAP_SIGINFO): Delete.
	(fbsd_pid_to_exec_file, fbsd_find_memory_regions)
	(fbsd_find_memory_regions, fbsd_info_proc, fbsd_xfer_partial)
	(fbsd_thread_alive, fbsd_pid_to_str, fbsd_thread_name)
	(fbsd_update_thread_list, fbsd_resume, fbsd_wait)
	(fbsd_stopped_by_sw_breakpoint)
	(fbsd_supports_stopped_by_sw_breakpoint, fbsd_follow_fork)
	(fbsd_insert_fork_catchpoint, fbsd_remove_fork_catchpoint)
	(fbsd_insert_vfork_catchpoint, fbsd_remove_vfork_catchpoint)
	(fbsd_post_startup_inferior, fbsd_post_attach)
	(fbsd_insert_exec_catchpoint, fbsd_remove_exec_catchpoint)
	(fbsd_set_syscall_catchpoint)
	(super_xfer_partial, super_resume, super_wait)
	(fbsd_supports_stopped_by_hw_breakpoint): Delete.
	(fbsd_handle_debug_trap): Remove target_ops parameter.
	(fbsd_nat_add_target): Delete.
	* fbsd-nat.h: Include "inf-ptrace.h".
	(fbsd_nat_add_target): Delete.
	(USE_SIGTRAP_SIGINFO): Define.
	(fbsd_nat_target): New class.

	* amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers)
	(amd64bsd_store_inferior_registers): Remove target_ops parameter.
	(amd64bsd_target): Delete.
	* amd64-bsd-nat.h: New file.
	* amd64-fbsd-nat.c: Include "amd64-bsd-nat.h" instead of
	"x86-bsd-nat.h".
	(amd64_fbsd_nat_target): New class.
	(the_amd64_fbsd_nat_target): New.
	(amd64fbsd_read_description): Refactor as method of
	amd64_fbsd_nat_target.
	(amd64_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
	(_initialize_amd64fbsd_nat): Adjust to C++ification.
	* amd64-nat.h (amd64bsd_target): Delete function declaration.
	* i386-bsd-nat.c (i386bsd_fetch_inferior_registers)
	(i386bsd_store_inferior_registers): Remove target_ops parameter.
	(i386bsd_target): Delete.
	* i386-bsd-nat.h (i386bsd_target): Delete function declaration.
	(i386bsd_fetch_inferior_registers)
	(i386bsd_store_inferior_registers): Declare.
	(i386_bsd_nat_target): New class.
	* i386-fbsd-nat.c (i386_fbsd_nat_target): New class.
	(the_i386_fbsd_nat_target): New.
	(i386fbsd_resume, i386fbsd_read_description): Refactor as
	i386_fbsd_nat_target methods.
	(i386_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
	(_initialize_i386fbsd_nat): Adjust to C++ification.
	* x86-bsd-nat.c (super_mourn_inferior): Delete.
	(x86bsd_mourn_inferior, x86bsd_target): Delete.
	(_initialize_x86_bsd_nat): Adjust to C++ification.
	* x86-bsd-nat.h: Include "x86-nat.h".
	(x86bsd_target): Delete declaration.
	(x86bsd_nat_target): New class.

	* aarch64-fbsd-nat.c (aarch64_fbsd_nat_target): New class.
	(the_aarch64_fbsd_nat_target): New.
	(aarch64_fbsd_fetch_inferior_registers)
	(aarch64_fbsd_store_inferior_registers): Refactor as methods of
	aarch64_fbsd_nat_target.
	(_initialize_aarch64_fbsd_nat): Adjust to C++ification.
	* alpha-bsd-nat.c (alpha_bsd_nat_target): New class.
	(the_alpha_bsd_nat_target): New.
	(alphabsd_fetch_inferior_registers)
	(alphabsd_store_inferior_registers): Refactor as
	alpha_bsd_nat_target methods.
	(_initialize_alphabsd_nat): Refactor as methods of
	alpha_bsd_nat_target.
	* amd64-nbsd-nat.c: Include "amd64-bsd-nat.h".
	(the_amd64_nbsd_nat_target): New.
	(_initialize_amd64nbsd_nat): Adjust to C++ification.
	* amd64-obsd-nat.c: Include "amd64-bsd-nat.h".
	(the_amd64_obsd_nat_target): New.
	(_initialize_amd64obsd_nat): Adjust to C++ification.
	* arm-fbsd-nat.c (arm_fbsd_nat_target): New.
	(the_arm_fbsd_nat_target): New.
	(arm_fbsd_fetch_inferior_registers)
	(arm_fbsd_store_inferior_registers, arm_fbsd_read_description):
	(_initialize_arm_fbsd_nat): Refactor as methods of
	arm_fbsd_nat_target.
	(_initialize_arm_fbsd_nat): Adjust to C++ification.
	* arm-nbsd-nat.c (arm_netbsd_nat_target): New class.
	(the_arm_netbsd_nat_target): New.
	(armnbsd_fetch_registers, armnbsd_store_registers): Refactor as
	arm_netbsd_nat_target.
	(_initialize_arm_netbsd_nat): Adjust to C++ification.
	* hppa-nbsd-nat.c (hppa_nbsd_nat_target): New class.
	(the_hppa_nbsd_nat_target): New.
	(hppanbsd_fetch_registers, hppanbsd_store_registers): Refactor as
	hppa_nbsd_nat_target methods.
	(_initialize_hppanbsd_nat): Adjust to C++ification.
	* hppa-obsd-nat.c (hppa_obsd_nat_target): New class.
	(the_hppa_obsd_nat_target): New.
	(hppaobsd_fetch_registers, hppaobsd_store_registers): Refactor as
	methods of hppa_obsd_nat_target.
	(_initialize_hppaobsd_nat): Adjust to C++ification.  Use
	add_target.
	* i386-nbsd-nat.c (the_i386_nbsd_nat_target): New.
	(_initialize_i386nbsd_nat): Adjust to C++ification.  Use
	add_target.
	* i386-obsd-nat.c (the_i386_obsd_nat_target): New.
	(_initialize_i386obsd_nat): Use add_target.
	* m68k-bsd-nat.c (m68k_bsd_nat_target): New class.
	(the_m68k_bsd_nat_target): New.
	(m68kbsd_fetch_inferior_registers)
	(m68kbsd_store_inferior_registers): Refactor as methods of
	m68k_bsd_nat_target.
	(_initialize_m68kbsd_nat): Adjust to C++ification.
	* mips-fbsd-nat.c (mips_fbsd_nat_target): New class.
	(the_mips_fbsd_nat_target): New.
	(mips_fbsd_fetch_inferior_registers)
	(mips_fbsd_store_inferior_registers): Refactor as methods of
	mips_fbsd_nat_target.
	(_initialize_mips_fbsd_nat): Adjust to C++ification.  Use
	add_target.
	* mips-nbsd-nat.c (mips_nbsd_nat_target): New class.
	(the_mips_nbsd_nat_target): New.
	(mipsnbsd_fetch_inferior_registers)
	(mipsnbsd_store_inferior_registers): Refactor as methods of
	mips_nbsd_nat_target.
	(_initialize_mipsnbsd_nat): Adjust to C++ification.
	* mips64-obsd-nat.c (mips64_obsd_nat_target): New class.
	(the_mips64_obsd_nat_target): New.
	(mips64obsd_fetch_inferior_registers)
	(mips64obsd_store_inferior_registers): Refactor as methods of
	mips64_obsd_nat_target.
	(_initialize_mips64obsd_nat): Adjust to C++ification.  Use
	add_target.
	* nbsd-nat.c (nbsd_pid_to_exec_file): Refactor as method of
	nbsd_nat_target.
	* nbsd-nat.h: Include "inf-ptrace.h".
	(nbsd_nat_target): New class.
	* obsd-nat.c (obsd_pid_to_str, obsd_update_thread_list)
	(obsd_wait): Refactor as methods of obsd_nat_target.
	(obsd_add_target): Delete.
	* obsd-nat.h: Include "inf-ptrace.h".
	(obsd_nat_target): New class.
	* ppc-fbsd-nat.c (ppc_fbsd_nat_target): New class.
	(the_ppc_fbsd_nat_target): New.
	(ppcfbsd_fetch_inferior_registers)
	(ppcfbsd_store_inferior_registers): Refactor as methods of
	ppc_fbsd_nat_target.
	(_initialize_ppcfbsd_nat): Adjust to C++ification.  Use
	add_target.
	* ppc-nbsd-nat.c (ppc_nbsd_nat_target): New class.
	(the_ppc_nbsd_nat_target): New.
	(ppcnbsd_fetch_inferior_registers)
	(ppcnbsd_store_inferior_registers): Refactor as methods of
	ppc_nbsd_nat_target.
	(_initialize_ppcnbsd_nat): Adjust to C++ification.
	* ppc-obsd-nat.c (ppc_obsd_nat_target): New class.
	(the_ppc_obsd_nat_target): New.
	(ppcobsd_fetch_registers, ppcobsd_store_registers): Refactor as
	methods of ppc_obsd_nat_target.
	(_initialize_ppcobsd_nat): Adjust to C++ification.  Use
	add_target.
	* sh-nbsd-nat.c (sh_nbsd_nat_target): New class.
	(the_sh_nbsd_nat_target): New.
	(shnbsd_fetch_inferior_registers)
	(shnbsd_store_inferior_registers): Refactor as methods of
	sh_nbsd_nat_target.
	(_initialize_shnbsd_nat): Adjust to C++ification.
	* sparc-nat.c (sparc_xfer_wcookie): Make extern.
	(inf_ptrace_xfer_partial): Delete.
	(sparc_xfer_partial, sparc_target): Delete.
	* sparc-nat.h (sparc_fetch_inferior_registers)
	(sparc_store_inferior_registers, sparc_xfer_wcookie): Declare.
	(sparc_target): Delete function declaration.
	(sparc_target): New template class.
	* sparc-nbsd-nat.c (the_sparc_nbsd_nat_target): New.
	(_initialize_sparcnbsd_nat): Adjust to C++ification.
	* sparc64-fbsd-nat.c (the_sparc64_fbsd_nat_target): New.
	(_initialize_sparc64fbsd_nat): Adjust to C++ification.  Use
	add_target.
	* sparc64-nbsd-nat.c (the_sparc64_nbsd_nat_target): New.
	(_initialize_sparc64nbsd_nat): Adjust to C++ification.
	* sparc64-obsd-nat.c (the_sparc64_obsd_nat_target): New.
	(_initialize_sparc64obsd_nat): Adjust to C++ification.  Use
	add_target.
	* vax-bsd-nat.c (vax_bsd_nat_target): New class.
	(the_vax_bsd_nat_target): New.
	(vaxbsd_fetch_inferior_registers)
	(vaxbsd_store_inferior_registers): Refactor as vax_bsd_nat_target
	methods.
	(_initialize_vaxbsd_nat): Adjust to C++ification.

	* bsd-kvm.c (bsd_kvm_target): New class.
	(bsd_kvm_ops): Now a bsd_kvm_target.
	(bsd_kvm_open, bsd_kvm_close, bsd_kvm_xfer_partial)
	(bsd_kvm_files_info, bsd_kvm_fetch_registers)
	(bsd_kvm_thread_alive, bsd_kvm_pid_to_str): Refactor as methods of
	bsd_kvm_target.
	(bsd_kvm_return_one): Delete.
	(bsd_kvm_add_target): Adjust to C++ification.

	* nto-procfs.c (nto_procfs_target, nto_procfs_target_native)
	(nto_procfs_target_procfs): New classes.
	(procfs_open_1, procfs_thread_alive, procfs_update_thread_list)
	(procfs_files_info, procfs_pid_to_exec_file, procfs_attach)
	(procfs_post_attach, procfs_wait, procfs_fetch_registers)
	(procfs_xfer_partial, procfs_detach, procfs_insert_breakpoint)
	(procfs_remove_breakpoint, procfs_insert_hw_breakpoint)
	(procfs_remove_hw_breakpoint, procfs_resume)
	(procfs_mourn_inferior, procfs_create_inferior, procfs_interrupt)
	(procfs_kill_inferior, procfs_store_registers)
	(procfs_pass_signals, procfs_pid_to_str, procfs_can_run): Refactor
	as methods of nto_procfs_target.
	(nto_procfs_ops): Now an nto_procfs_target_procfs.
	(nto_native_ops): Delete.
	(procfs_open, procfs_native_open): Delete.
	(nto_native_ops): Now an nto_procfs_target_native.
	(init_procfs_targets): Adjust to C++ification.
	(procfs_can_use_hw_breakpoint, procfs_remove_hw_watchpoint)
	(procfs_insert_hw_watchpoint, procfs_stopped_by_watchpoint):
	Refactor as methods of nto_procfs_target.

	* go32-nat.c (go32_nat_target): New class.
	(the_go32_nat_target): New.
	(go32_attach, go32_resume, go32_wait, go32_fetch_registers)
	(go32_store_registers, go32_xfer_partial, go32_files_info)
	(go32_kill_inferior, go32_create_inferior, go32_mourn_inferior)
	(go32_terminal_init, go32_terminal_info, go32_terminal_inferior)
	(go32_terminal_ours, go32_pass_ctrlc, go32_thread_alive)
	(go32_pid_to_str): Refactor as methods of go32_nat_target.
	(go32_target): Delete.
	(_initialize_go32_nat): Adjust to C++ification.

	* gnu-nat.c (gnu_wait, gnu_resume, gnu_kill_inferior)
	(gnu_mourn_inferior, gnu_create_inferior, gnu_attach, gnu_detach)
	(gnu_stop, gnu_thread_alive, gnu_xfer_partial)
	(gnu_find_memory_regions, gnu_pid_to_str): Refactor as methods of
	gnu_nat_target.
	(gnu_target): Delete.
	* gnu-nat.h (gnu_target): Delete.
	(gnu_nat_target): New class.
	* i386-gnu-nat.c (gnu_base_target): New.
	(i386_gnu_nat_target): New class.
	(the_i386_gnu_nat_target): New.
	(_initialize_i386gnu_nat): Adjust to C++ification.

gdb/testsuite/ChangeLog:
2018-05-02  Pedro Alves  <palves@redhat.com>

	* gdb.base/breakpoint-in-ro-region.exp: Adjust to to_resume and
	to_log_command renames.
	* gdb.base/sss-bp-on-user-bp-2.exp: Likewise.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] gdb: Remove OpenBSD/m88k support
@ 2018-04-16 12:19 sergiodj+buildbot
  2018-04-16 12:20 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-04-16 12:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a2a79012fe7ad4bcc354c14410679ccb705d5326 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: a2a79012fe7ad4bcc354c14410679ccb705d5326

gdb: Remove OpenBSD/m88k support

Support for m88k was fully removed from bfd, which broke gdb
--enable-targets=all builds:

  > gdb/m88k-tdep.c: In function void _initialize_m88k_tdep():
  > gdb/m88k-tdep.c:867:21: error: bfd_arch_m88k was not declared in this scope
  >    gdbarch_register (bfd_arch_m88k, m88k_gdbarch_init, NULL);

There's no point in keeping GDB support for OpenBSD/m88k with no bfd
support, so this commit simply removes the port.

gdb/ChangeLog:
2018-04-16  Pedro Alves  <palves@redhat.com>

	* MAINTAINERS: Remove m88k.
	* Makefile.in (ALL_TARGET_OBS): Remove m88k-tdep.o.
	(HFILES_NO_SRCDIR): Remove m88k-tdep.h.
	(ALLDEPFILES): Remove m88k-bsd-nat.c and m88k-tdep.c.
	* NEWS: Mention that support for OpenBSD/m88k was removed.
	* configure.host (m88*-*-*): Remove support.
	* configure.nat (m88k-*-*): Remove support.
	* configure.tgt (m88*-*-openbsd*): Remove.
	* m88k-bsd-nat.c, m88k-tdep.c, m88k-tdep.h: Delete.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Prevent an illegal memory access via an out of range fixup pointer.
@ 2018-04-16 12:05 sergiodj+buildbot
  2018-04-16 12:05 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-04-16 12:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e9af4700bc7435e593dd74d4d2e099b3d7c01eb6 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: e9af4700bc7435e593dd74d4d2e099b3d7c01eb6

Prevent an illegal memory access via an out of range fixup pointer.

	PR 23061
	* coffgen.c (coff_pointerize_aux): Check for an out of range
	fixup.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Remove arm-epoc-pe support
@ 2018-04-16 11:32 sergiodj+buildbot
  2018-04-16 11:32 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-04-16 11:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ddb000396c9246649e02669e0bd6ad3949973e5a ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: ddb000396c9246649e02669e0bd6ad3949973e5a

Remove arm-epoc-pe support

bfd/
	* Makefile.am: Remove arm-epoc-pe support.
	* coff-arm.c: Likewise.
	* config.bfd: Likewise.
	* configure.ac: Likewise.
	* targets.c: Likewise.
	* epoc-pe-arm.c: Delete.
	* epoc-pei-arm.c: Delete.
	* Makefile.in: Regenerate.
	* configure: Regenerate.
	* po/SRC-POTFILES.in: Regenerate.
binutils/
	* configure.ac: Remove arm-epoc-pe support.
	* dlltool.c: Likewise.
	* configure: Regenerate.
gas/
	* Makefile.am: Remove arm-epoc-pe support.
	* config/tc-arm.h: Likewise.
	* configure.tgt: Likewise.
	* testsuite/gas/all/gas.exp: Likewise.
	* testsuite/gas/arm/local_label_coff.d: Likewise.
	* testsuite/gas/arm/undefined.d: Likewise.
	* testsuite/gas/arm/undefined_coff.d: Likewise.
	* config/te-epoc-pe.h: Delete.
	* Makefile.in: Regenerate.
	* po/POTFILES.in: Regenerate.
ld/
	* Makefile.am: Remove arm-epoc-pe support.
	* configure.tgt: Likewise.
	* emultempl/pe.em: Likewise.
	* pe-dll.c: Likewise.
	* testsuite/ld-scripts/fill.d: Likewise.
	* testsuite/ld-scripts/fill16.d: Likewise.
	* emulparams/arm_epoc_pe.sh: Delete.
	* scripttempl/epocpe.sc: Delete.
	* Makefile.in: Regenerate.
	* po/BLD-POTFILES.in: Regenerate.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] sparc-coff removal leftover
@ 2018-04-16 11:29 sergiodj+buildbot
  2018-04-16 11:29 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-04-16 11:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5452f388a51463394553b29469e32e7765d874e1 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 5452f388a51463394553b29469e32e7765d874e1

sparc-coff removal leftover

	* coff/sparc.h: Delete.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Remove sh-symbianelf support
@ 2018-04-16 11:06 sergiodj+buildbot
  2018-04-16 11:06 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-04-16 11:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4db9937a27496d2f62ac1dde76565809acd4ecde ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 4db9937a27496d2f62ac1dde76565809acd4ecde

Remove sh-symbianelf support

bfd/
	* Makefile.am: Remove sh-symbianelf support.
	* config.bfd: Likewise.
	* configure.ac: Likewise.
	* targets.c: Likewise.
	* elf32-sh-symbian.c: Delete.
	* Makefile.in: Regenerate.
	* configure: Regenerate.
	* po/SRC-POTFILES.in: Regenerate.
gas/
	* config/tc-sh.c: Remove sh-symbianelf support.
	* config/tc-sh.h: Likewise.
	* configure.ac: Likewise.
	* configure.tgt: Likewise.
	* testsuite/gas/sh/reg-prefix.d: Likewise.
	* testsuite/gas/sh/sh2a-pic.d: Likewise.
	* config.in: Regenerate.
	* configure: Regenerate.
ld/
	* Makefile.am: Remove sh-symbianelf support.
	* configure.tgt: Likewise.
	* emulparams/shlsymbian.sh: Delete.
	* scripttempl/elf32sh-symbian.sc: Delete.
	* Makefile.in: Regenerate.
	* po/BLD-POTFILES.in: Regenerate.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Remove vax-bsd and vax-ultrix support
@ 2018-04-16 11:04 sergiodj+buildbot
  2018-04-16 11:04 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-04-16 11:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9f5d15933be033c9d54e41d605d7824f57fbed4e ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 9f5d15933be033c9d54e41d605d7824f57fbed4e

Remove vax-bsd and vax-ultrix support

bfd/
	* Makefile.am: Remove vax-bsd and vax-ultrix support.
	* config.bfd: Likewise.
	* configure.ac: Likewise.
	* targets.c: Likewise.
	* vaxbsd.c: Delete.
	* Makefile.in: Regenerate.
	* configure: Regenerate.
	* po/SRC-POTFILES.in: Regenerate.
ld/
	* Makefile.am: Remove vax-bsd and vax-ultrix support.
	* configure.tgt: Likewise.
	* emulparams/vax.sh: Delete.
	* Makefile.in: Regenerate.
	* po/BLD-POTFILES.in: Regenerate.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Remove w65 support
@ 2018-04-16 11:02 sergiodj+buildbot
  2018-04-16 11:02 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-04-16 11:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a9a4b30244006a0087c5a7bf73cbb13927f1d9f1 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: a9a4b30244006a0087c5a7bf73cbb13927f1d9f1

Remove w65 support

include/
	* coff/internal.h: Remove w65 support.
	* coff/w65.h: Delete.
bfd/
	* Makefile.am: Remove w65 support.
	* archures.c: Likewise.
	* coffcode.h: Likewise.
	* config.bfd: Likewise.
	* configure.ac: Likewise.
	* targets.c: Likewise.
	* coff-w65.c: Delete.
	* cpu-w65.c: Delete.
	* Makefile.in: Regenerate.
	* bfd-in2.h: Regenerate.
	* configure: Regenerate.
	* po/SRC-POTFILES.in: Regenerate.
opcodes/
	* Makefile.am: Remove w65 support.
	* configure.ac: Likewise.
	* disassemble.c: Likewise.
	* disassemble.h: Likewise.
	* w65-dis.c: Delete.
	* w65-opc.h: Delete.
	* Makefile.in: Regenerate.
	* configure: Regenerate.
	* po/POTFILES.in: Regenerate.
binutils/
	* testsuite/binutils-all/objcopy.exp: Remove w65 support.
ld/
	* Makefile.am: Remove w65 support.
	* configure.tgt: Likewise.
	* emulparams/w65.sh: Delete.
	* scripttempl/w65.sc: Delete.
	* Makefile.in: Regenerate.
	* po/BLD-POTFILES.in: Regenerate.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Remove we32k support
@ 2018-04-16 11:00 sergiodj+buildbot
  2018-04-16 11:00 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-04-16 11:00 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 04cb01fd5a3bc167ae26486bbc2bf941e96ad805 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 04cb01fd5a3bc167ae26486bbc2bf941e96ad805

Remove we32k support

include/
	* coff/we32k.h: Delete.
bfd/
	* Makefile.am: Remove we32k support.
	* archures.c: Likewise.
	* coffcode.h: Likewise.
	* config.bfd: Likewise.
	* configure.ac: Likewise.
	* targets.c: Likewise.
	* coff-we32k.c: Delete.
	* cpu-we32k.c: Delete.
	* Makefile.in: Regenerate.
	* bfd-in2.h: Regenerate.
	* configure: Regenerate.
	* po/SRC-POTFILES.in: Regenerate.
opcodes/
	* configure.ac: Remove we32k support.
	* configure: Regenerate.
bintuils/
	* testsuite/binutils-all/objdump.exp: Remove we32k support.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Remove m88k support
@ 2018-04-16 10:58 sergiodj+buildbot
  2018-04-16 10:58 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-04-16 10:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c2bf1eecf99abc4d546bb52a008a25e64a29d85e ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: c2bf1eecf99abc4d546bb52a008a25e64a29d85e

Remove m88k support

include/
	* coff/internal.h: Remove m88k support.
	* coff/m88k.h: Delete.
	* opcode/m88k.h: Delete.
bfd/
	* Makefile.am: Remove m88k support.
	* aoutx.h: Likewise.
	* archures.c: Likewise.
	* coffcode.h: Likewise.
	* coffswap.h: Likewise.
	* config.bfd: Likewise.
	* configure.ac: Likewise.
	* cpu-ns32k.c: Likewise.
	* elf32-nds32.c: Likewise.
	* mach-o.c: Likewise.
	* netbsd-core.c: Likewise.
	* reloc.c: Likewise.
	* targets.c: Likewise.
	* coff-m88k.c: Delete.
	* cpu-m88k.c: Delete.
	* elf32-m88k.c: Delete.
	* hosts/m88kmach3.h: Delete.
	* m88kmach3.c: Delete.
	* m88kopenbsd.c: Delete.
	* Makefile.in: Regenerate.
	* bfd-in2.h: Regenerate.
	* configure: Regenerate.
	* po/SRC-POTFILES.in: Regenerate.
opcodes/
	* Makefile.am: Remove m88k support.
	* configure.ac: Likewise.
	* disassemble.c: Likewise.
	* disassemble.h: Likewise.
	* m88k-dis.c: Delete.
	* Makefile.in: Regenerate.
	* configure: Regenerate.
	* po/POTFILES.in: Regenerate.
binutils/
	* MAINTAINERS (Mark Kettenis): Move to past maintainers.
	* testsuite/binutils-all/objdump.exp: Remove m88k support.
gas/
	* configure.ac: Remove m88k support.
	* config.in: Regenerate.
	* configure: Regenerate.
ld/
	* Makefile.am: Remove m88k support.
	* configure.host: Likewise.
	* configure.tgt: Likewise.
	* testsuite/ld-elf/sec-to-seg.exp: Likewise.
	* emulparams/m88kbcs.sh: Delete.
	* scripttempl/m88kbcs.sc: Delete.
	* Makefile.in: Regenerate.
	* po/BLD-POTFILES.in: Regenerate.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Remove sparc-aout and sparc-coff support
@ 2018-04-16  9:35 sergiodj+buildbot
  2018-04-16 11:13 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-04-16  9:35 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c9098af41e3246586a30f4f0bdb0ee4367e9a5e7 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: c9098af41e3246586a30f4f0bdb0ee4367e9a5e7

Remove sparc-aout and sparc-coff support

bfd/
	* Makefile.am: Remove sparc-aout and sparc-coff support.
	* config.bfd: Likewise.
	* configure.ac: Likewise.
	* targets.c: Likewise.
	* aout-sparcle.c: Delete.
	* aoutf1.h: Delete.
	* cf-sparclynx.c: Delete.
	* coff-sparc.c: Delete.
	* demo64.c: Delete.
	* sparclinux.c: Delete.
	* sparclynx.c: Delete.
	* sparcnetbsd.c: Delete.
	* sunos.c: Delete.
	* Makefile.in: Regenerate.
	* configure: Regenerate.
	* po/SRC-POTFILES.in: Regenerate.
binutils/
	* testsuite/lib/binutils-common.exp: Remove sparc-aout and
	sparc-coff support.
gas/
	* Makefile.am: Remove sparc-aout and sparc-coff support.
	* config/obj-coff.h: Likewise.
	* config/tc-sparc.c: Likewise.
	* config/tc-sparc.h: Likewise.
	* configure.tgt: Likewise.
	* config/te-sparcaout.h: Delete.
	* testsuite/gas/sun4/addend.d: Delete.
	* testsuite/gas/sun4/addend.exp: Delete.
	* testsuite/gas/sun4/addend.s: Delete.
	* Makefile.in: Regenerate.
	* po/POTFILES.in: Regenerate.
ld/
	* Makefile.am: Remove sparc-aout and sparc-coff support.
	* configure.tgt: Likewise.
	* testsuite/ld-elfvers/vers.exp: Likewise.
	* testsuite/ld-elfvsb/elfvsb.exp: Likewise.
	* testsuite/ld-elfweak/elfweak.exp: Likewise.
	* testsuite/ld-shared/shared.exp: Likewise.
	* emulparams/coff_sparc.sh: Delete.
	* emulparams/sparcaout.sh: Delete.
	* emulparams/sparclinux.sh: Delete.
	* emulparams/sparcnbsd.sh: Delete.
	* emulparams/sun4.sh: Delete.
	* scripttempl/sparccoff.sc: Delete.
	* Makefile.in: Regenerate.
	* po/BLD-POTFILES.in: Regenerate.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Remove m68k-aout and m68k-coff support
@ 2018-04-16  9:21 sergiodj+buildbot
  2018-04-16 11:11 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-04-16  9:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT dc12032bca08554cf0a72d224e44f755f7789ff3 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: dc12032bca08554cf0a72d224e44f755f7789ff3

Remove m68k-aout and m68k-coff support

include/
	* aout/host.h: Remove m68k-aout and m68k-coff support.
	* aout/hp300hpux.h: Delete.
	* coff/apollo.h: Delete.
	* coff/aux-coff.h: Delete.
	* coff/m68k.h: Delete.
bfd/
	* Makefile.am: Remove m68k-aout and m68k-coff support.
	* aoutf1.h: Likewise.
	* aoutx.h: Likewise.
	* archive.c: Likewise.
	* bfd-in.h: Likewise.
	* bfd.c: Likewise.
	* coffcode.h: Likewise.
	* coffswap.h: Likewise.
	* config.bfd: Likewise.
	* configure.ac: Likewise.
	* configure.host: Likewise.
	* doc/bfd.texinfo: Likewise.
	* doc/bfdint.texi: Likewise.
	* freebsd.h: Likewise.
	* gen-aout.c: Likewise.
	* hpux-core.c: Likewise.
	* libaout.h: Likewise.
	* libbfd-in.h: Likewise.
	* pdp11.c: Likewise.
	* peicode.h: Likewise.
	* riscix.c: Likewise.
	* targets.c: Likewise.
	* aout0.c: Delete.
	* coff-apollo.c: Delete.
	* coff-aux.c: Delete.
	* coff-m68k.c: Delete.
	* coff-svm68k.c: Delete.
	* coff-u68k.c: Delete.
	* hosts/delta68.h: Delete.
	* hosts/hp300bsd.h: Delete.
	* hosts/m68kaux.h: Delete.
	* hosts/news.h: Delete.
	* hp300bsd.c: Delete.
	* hp300hpux.c: Delete.
	* liboasys.h: Delete.
	* m68k4knetbsd.c: Delete.
	* m68klinux.c: Delete.
	* m68knetbsd.c: Delete.
	* oasys.c: Delete.
	* versados.c: Delete.
	* Makefile.in: Regenerate.
	* bfd-in2.h: Regenerate.
	* configure: Regenerate.
	* libbfd.h: Regenerate.
	* po/SRC-POTFILES.in: Regenerate.
binutils/
	* testsuite/binutils-all/copy-2.d: Remove m68k-aout and m68k-coff
	support.
	* testsuite/binutils-all/copy-3.d: Likewise.
	* testsuite/binutils-all/objcopy.exp: Likewise.
	* testsuite/lib/binutils-common.exp: Likewise.
gas/
	* Makefile.am: Remove m68k-aout and m68k-coff support.
	* config/tc-m68k.c: Likewise.
	* config/tc-m68k.h: Likewise.
	* configure.ac: Likewise.
	* configure.tgt: Likewise.
	* testsuite/gas/all/weakref1u.d: Likewise.
	* testsuite/gas/m68k/all.exp: Likewise.
	* testsuite/gas/m68k/br-isaa.d: Likewise.
	* testsuite/gas/m68k/br-isab.d: Likewise.
	* testsuite/gas/m68k/br-isac.d: Likewise.
	* config/te-psos.h: Delete.
	* config/te-sun3.h: Delete.
	* testsuite/gas/m68k-coff/gas.exp: Delete.
	* testsuite/gas/m68k-coff/p2389.s: Delete.
	* testsuite/gas/m68k-coff/p2389a.s: Delete.
	* testsuite/gas/m68k-coff/p2430.s: Delete.
	* testsuite/gas/m68k-coff/p2430a.s: Delete.
	* testsuite/gas/m68k-coff/t1.s: Delete.
	* testsuite/gas/m68k/p3041.d: Delete.
	* testsuite/gas/m68k/p3041.s: Delete.
	* testsuite/gas/m68k/p3041data.d: Delete.
	* testsuite/gas/m68k/p3041data.s: Delete.
	* testsuite/gas/m68k/p3041pcrel.d: Delete.
	* testsuite/gas/m68k/p3041pcrel.s: Delete.
	* testsuite/gas/m68k/t2.d: Delete.
	* Makefile.in: Regenerate.
	* config.in: Regenerate.
	* configure: Regenerate.
	* po/POTFILES.in: Regenerate.
ld/
	* Makefile.am: Remove m68k-aout and m68k-coff support.
	* configure.tgt: Likewise.
	* emultempl/m68kelf.em: Likewise.
	* ld.texinfo: Likewise.
	* mri.c: Likewise.
	* emulparams/delta68.sh: Delete.
	* emulparams/hp300bsd.sh: Delete.
	* emulparams/hp3hpux.sh: Delete.
	* emulparams/m68k4knbsd.sh: Delete.
	* emulparams/m68kaout.sh: Delete.
	* emulparams/m68kaux.sh: Delete.
	* emulparams/m68kcoff.sh: Delete.
	* emulparams/m68klinux.sh: Delete.
	* emulparams/m68knbsd.sh: Delete.
	* emulparams/m68kpsos.sh: Delete.
	* emulparams/sun3.sh: Delete.
	* emultempl/m68kcoff.em: Delete.
	* scripttempl/delta68.sc: Delete.
	* scripttempl/m68kaux.sc: Delete.
	* scripttempl/m68kcoff.sc: Delete.
	* scripttempl/psos.sc: Delete.
	* testsuite/ld-versados/t1-1.ro: Delete.
	* testsuite/ld-versados/t1-2.ro: Delete.
	* testsuite/ld-versados/t1.ld: Delete.
	* testsuite/ld-versados/t1.ook: Delete.
	* testsuite/ld-versados/t2-1.ro: Delete.
	* testsuite/ld-versados/t2-2.ro: Delete.
	* testsuite/ld-versados/t2-3.ro: Delete.
	* testsuite/ld-versados/t2.ld: Delete.
	* testsuite/ld-versados/t2.ook: Delete.
	* testsuite/ld-versados/versados.exp: Delete.
	* Makefile.in: Regenerate.
	* po/BLD-POTFILES.in: Regenerate.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Remove sh5 and sh64 support
@ 2018-04-16  9:11 sergiodj+buildbot
  2018-04-16 11:08 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-04-16  9:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 211dc24b8744ed14ee5c293e7ac164d02e1fa1fe ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 211dc24b8744ed14ee5c293e7ac164d02e1fa1fe

Remove sh5 and sh64 support

include/
	* dis-asm.h: Remove sh5 and sh64 support.
bfd/
	* Makefile.am: Remove sh5 and sh64 support.
	* archures.c: Likewise.
	* config.bfd: Likewise.
	* configure.ac: Likewise.
	* cpu-sh.c: Likewise.
	* elf32-sh-relocs.h: Likewise.
	* elf32-sh.c: Likewise.
	* targets.c: Likewise.
	* elf32-sh64-com.c: Delete.
	* elf32-sh64.c: Delete.
	* elf32-sh64.h: Delete.
	* elf64-sh64.c: Delete.
	* Makefile.in: Regenerate.
	* bfd-in2.h: Regenerate.
	* configure: Regenerate.
	* po/SRC-POTFILES.in: Regenerate.
opcodes/
	* Makefile.am: Remove sh5 and sh64 support.
	* configure.ac: Likewise.
	* disassemble.c: Likewise.
	* disassemble.h: Likewise.
	* sh-dis.c: Likewise.
	* sh64-dis.c: Delete.
	* sh64-opc.c: Delete.
	* sh64-opc.h: Delete.
	* Makefile.in: Regenerate.
	* configure: Regenerate.
	* po/POTFILES.in: Regenerate.
bintuils/
	* testsuite/binutils-all/objcopy.exp: Remove sh5 and sh64 support.
gas/
	* Makefile.am: Remove sh5 and sh64 support.
	* config/tc-sh.c: Likewise.
	* configure.tgt: Likewise.
	* doc/Makefile.am: Likewise.
	* doc/as.texinfo: Likewise.
	* testsuite/gas/cfi/cfi.exp: Likewise.
	* testsuite/gas/sh/basic.exp: Likewise.
	* config/tc-sh64.c: Delete.
	* config/tc-sh64.h: Delete.
	* doc/c-sh64.texi: Delete.
	* testsuite/gas/sh/sh64/abi-32.d: Delete.
	* testsuite/gas/sh/sh64/abi-32.s: Delete.
	* testsuite/gas/sh/sh64/abi-64.d: Delete.
	* testsuite/gas/sh/sh64/abi-64.s: Delete.
	* testsuite/gas/sh/sh64/basic-1.d: Delete.
	* testsuite/gas/sh/sh64/basic-1.s: Delete.
	* testsuite/gas/sh/sh64/case-1.d: Delete.
	* testsuite/gas/sh/sh64/case-1.s: Delete.
	* testsuite/gas/sh/sh64/case-noexp-1.d: Delete.
	* testsuite/gas/sh/sh64/crange1-1.d: Delete.
	* testsuite/gas/sh/sh64/crange1-2.d: Delete.
	* testsuite/gas/sh/sh64/crange1.s: Delete.
	* testsuite/gas/sh/sh64/crange2-1.d: Delete.
	* testsuite/gas/sh/sh64/crange2-2.d: Delete.
	* testsuite/gas/sh/sh64/crange2-noexp-1.d: Delete.
	* testsuite/gas/sh/sh64/crange2.s: Delete.
	* testsuite/gas/sh/sh64/crange3-1.d: Delete.
	* testsuite/gas/sh/sh64/crange3.s: Delete.
	* testsuite/gas/sh/sh64/crange4-1.d: Delete.
	* testsuite/gas/sh/sh64/crange4.s: Delete.
	* testsuite/gas/sh/sh64/crange5-1.d: Delete.
	* testsuite/gas/sh/sh64/crange5.s: Delete.
	* testsuite/gas/sh/sh64/creg-1.d: Delete.
	* testsuite/gas/sh/sh64/creg-1.s: Delete.
	* testsuite/gas/sh/sh64/creg-2.d: Delete.
	* testsuite/gas/sh/sh64/creg-2.s: Delete.
	* testsuite/gas/sh/sh64/datal-1.s: Delete.
	* testsuite/gas/sh/sh64/datal-2.d: Delete.
	* testsuite/gas/sh/sh64/datal-2.s: Delete.
	* testsuite/gas/sh/sh64/datal-3.s: Delete.
	* testsuite/gas/sh/sh64/datal32-1.d: Delete.
	* testsuite/gas/sh/sh64/datal32-3.d: Delete.
	* testsuite/gas/sh/sh64/datal64-1.d: Delete.
	* testsuite/gas/sh/sh64/datal64-3.d: Delete.
	* testsuite/gas/sh/sh64/eh-1.d: Delete.
	* testsuite/gas/sh/sh64/eh-1.s: Delete.
	* testsuite/gas/sh/sh64/endian-1.d: Delete.
	* testsuite/gas/sh/sh64/endian-1.s: Delete.
	* testsuite/gas/sh/sh64/endian-2.d: Delete.
	* testsuite/gas/sh/sh64/endian-2.s: Delete.
	* testsuite/gas/sh/sh64/err-1.s: Delete.
	* testsuite/gas/sh/sh64/err-2.s: Delete.
	* testsuite/gas/sh/sh64/err-3.s: Delete.
	* testsuite/gas/sh/sh64/err-4.s: Delete.
	* testsuite/gas/sh/sh64/err-abi-32.s: Delete.
	* testsuite/gas/sh/sh64/err-abi-64.s: Delete.
	* testsuite/gas/sh/sh64/err-dsp.s: Delete.
	* testsuite/gas/sh/sh64/err-movi-noexp-1.s: Delete.
	* testsuite/gas/sh/sh64/err-noexp-cmd1.s: Delete.
	* testsuite/gas/sh/sh64/err-pt-1.s: Delete.
	* testsuite/gas/sh/sh64/err-pt32-cmd1.s: Delete.
	* testsuite/gas/sh/sh64/err-pt32-cmd2.s: Delete.
	* testsuite/gas/sh/sh64/err-pt32-cmd3.s: Delete.
	* testsuite/gas/sh/sh64/err-ptb-1.s: Delete.
	* testsuite/gas/sh/sh64/err-ptb-2.s: Delete.
	* testsuite/gas/sh/sh64/err.exp: Delete.
	* testsuite/gas/sh/sh64/immexpr1.s: Delete.
	* testsuite/gas/sh/sh64/immexpr2.s: Delete.
	* testsuite/gas/sh/sh64/immexpr32-1.d: Delete.
	* testsuite/gas/sh/sh64/immexpr32-2.d: Delete.
	* testsuite/gas/sh/sh64/immexpr64-1.d: Delete.
	* testsuite/gas/sh/sh64/immexpr64-2.d: Delete.
	* testsuite/gas/sh/sh64/lineno.d: Delete.
	* testsuite/gas/sh/sh64/lineno.s: Delete.
	* testsuite/gas/sh/sh64/localcom-1.d: Delete.
	* testsuite/gas/sh/sh64/localcom-1.s: Delete.
	* testsuite/gas/sh/sh64/mix-1.d: Delete.
	* testsuite/gas/sh/sh64/mix-1.s: Delete.
	* testsuite/gas/sh/sh64/mix-noexp-1.d: Delete.
	* testsuite/gas/sh/sh64/movi-1.s: Delete.
	* testsuite/gas/sh/sh64/movi-2.s: Delete.
	* testsuite/gas/sh/sh64/movi-3.d: Delete.
	* testsuite/gas/sh/sh64/movi-3.s: Delete.
	* testsuite/gas/sh/sh64/movi32-1.d: Delete.
	* testsuite/gas/sh/sh64/movi32-2.d: Delete.
	* testsuite/gas/sh/sh64/movi32-noexp-2.d: Delete.
	* testsuite/gas/sh/sh64/movi64-1.d: Delete.
	* testsuite/gas/sh/sh64/movi64-2.d: Delete.
	* testsuite/gas/sh/sh64/movi64-2.s: Delete.
	* testsuite/gas/sh/sh64/movi64-3.d: Delete.
	* testsuite/gas/sh/sh64/movi64-noexp-2.d: Delete.
	* testsuite/gas/sh/sh64/pt-1.d: Delete.
	* testsuite/gas/sh/sh64/pt-1.s: Delete.
	* testsuite/gas/sh/sh64/pt-2.s: Delete.
	* testsuite/gas/sh/sh64/pt-noexp-1.d: Delete.
	* testsuite/gas/sh/sh64/pt32-1.d: Delete.
	* testsuite/gas/sh/sh64/pt32-noexp-2.d: Delete.
	* testsuite/gas/sh/sh64/pt64-1.d: Delete.
	* testsuite/gas/sh/sh64/pt64-32-1.d: Delete.
	* testsuite/gas/sh/sh64/pt64-32-2.d: Delete.
	* testsuite/gas/sh/sh64/pt64-noexp-2.d: Delete.
	* testsuite/gas/sh/sh64/ptc-1.s: Delete.
	* testsuite/gas/sh/sh64/ptc32-1.d: Delete.
	* testsuite/gas/sh/sh64/ptc32-noexp-1.d: Delete.
	* testsuite/gas/sh/sh64/ptc64-1.d: Delete.
	* testsuite/gas/sh/sh64/ptc64-32-1.d: Delete.
	* testsuite/gas/sh/sh64/ptc64-noexp-1.d: Delete.
	* testsuite/gas/sh/sh64/ptext-1.s: Delete.
	* testsuite/gas/sh/sh64/ptext32-1.d: Delete.
	* testsuite/gas/sh/sh64/ptext32-noexp-1.d: Delete.
	* testsuite/gas/sh/sh64/ptext64-1.d: Delete.
	* testsuite/gas/sh/sh64/ptext64-32-1.d: Delete.
	* testsuite/gas/sh/sh64/ptext64-noexp-1.d: Delete.
	* testsuite/gas/sh/sh64/rel-1.s: Delete.
	* testsuite/gas/sh/sh64/rel-2.s: Delete.
	* testsuite/gas/sh/sh64/rel-3.s: Delete.
	* testsuite/gas/sh/sh64/rel-4.s: Delete.
	* testsuite/gas/sh/sh64/rel-5.s: Delete.
	* testsuite/gas/sh/sh64/rel32-1.d: Delete.
	* testsuite/gas/sh/sh64/rel32-2.d: Delete.
	* testsuite/gas/sh/sh64/rel32-3.d: Delete.
	* testsuite/gas/sh/sh64/rel32-4.d: Delete.
	* testsuite/gas/sh/sh64/rel32-5.d: Delete.
	* testsuite/gas/sh/sh64/rel64-1.d: Delete.
	* testsuite/gas/sh/sh64/rel64-2.d: Delete.
	* testsuite/gas/sh/sh64/rel64-3.d: Delete.
	* testsuite/gas/sh/sh64/rel64-4.d: Delete.
	* testsuite/gas/sh/sh64/rel64-5.d: Delete.
	* testsuite/gas/sh/sh64/relax-1.d: Delete.
	* testsuite/gas/sh/sh64/relax-1.s: Delete.
	* testsuite/gas/sh/sh64/relax-2.d: Delete.
	* testsuite/gas/sh/sh64/relax-2.s: Delete.
	* testsuite/gas/sh/sh64/relax-3.d: Delete.
	* testsuite/gas/sh/sh64/relax-3.s: Delete.
	* testsuite/gas/sh/sh64/sh64.exp: Delete.
	* testsuite/gas/sh/sh64/shift-1.s: Delete.
	* testsuite/gas/sh/sh64/shift-2.s: Delete.
	* testsuite/gas/sh/sh64/shift-3.s: Delete.
	* testsuite/gas/sh/sh64/shift32-1.d: Delete.
	* testsuite/gas/sh/sh64/shift32-3.d: Delete.
	* testsuite/gas/sh/sh64/shift32-noexp-3.d: Delete.
	* testsuite/gas/sh/sh64/shift64-1.d: Delete.
	* testsuite/gas/sh/sh64/shift64-2.d: Delete.
	* testsuite/gas/sh/sh64/shift64-3.d: Delete.
	* testsuite/gas/sh/sh64/shift64-noexp-3.d: Delete.
	* testsuite/gas/sh/sh64/syntax-1.d: Delete.
	* testsuite/gas/sh/sh64/syntax-1.s: Delete.
	* testsuite/gas/sh/sh64/syntax-2.d: Delete.
	* testsuite/gas/sh/sh64/syntax-2.s: Delete.
	* testsuite/gas/sh/sh64/ua-1.s: Delete.
	* testsuite/gas/sh/sh64/ua32-1.d: Delete.
	* testsuite/gas/sh/sh64/ua64-1.d: Delete.
	* Makefile.in: Regenerate.
	* doc/Makefile.in: Regenerate.
	* po/POTFILES.in: Regenerate.
ld/
	* Makefile.am: Remove sh5 and sh64 support.
	* configure.tgt: Likewise.
	* ldlang.c: Likewise.
	* testsuite/ld-elfcomm/elfcomm.exp: Likewise.
	* testsuite/ld-gc/gc.exp: Likewise.
	* testsuite/ld-gc/pr13683.d: Likewise.
	* testsuite/ld-scripts/crossref.exp: Likewise.
	* testsuite/ld-selective/selective.exp: Likewise.
	* testsuite/ld-sh/ld-r-1.d: Likewise.
	* testsuite/ld-sh/rd-sh.exp: Likewise.
	* testsuite/ld-sh/sh.exp: Likewise.
	* testsuite/ld-srec/srec.exp: Likewise.
	* testsuite/ld-undefined/undefined.exp: Likewise.
	* emulparams/shelf32.sh: Delete.
	* emulparams/shelf32_linux.sh: Delete.
	* emulparams/shelf32_nbsd.sh: Delete.
	* emulparams/shelf64.sh: Delete.
	* emulparams/shelf64_nbsd.sh: Delete.
	* emulparams/shlelf32.sh: Delete.
	* emulparams/shlelf32_linux.sh: Delete.
	* emulparams/shlelf32_nbsd.sh: Delete.
	* emulparams/shlelf64.sh: Delete.
	* emulparams/shlelf64_nbsd.sh: Delete.
	* emultempl/sh64elf.em: Delete.
	* testsuite/ld-sh/sh64/abi32.sd: Delete.
	* testsuite/ld-sh/sh64/abi32.xd: Delete.
	* testsuite/ld-sh/sh64/abi64.sd: Delete.
	* testsuite/ld-sh/sh64/abi64.xd: Delete.
	* testsuite/ld-sh/sh64/abixx-noexp.sd: Delete.
	* testsuite/ld-sh/sh64/cmpct1.sd: Delete.
	* testsuite/ld-sh/sh64/cmpct1.xd: Delete.
	* testsuite/ld-sh/sh64/crange-1.s: Delete.
	* testsuite/ld-sh/sh64/crange-2a.s: Delete.
	* testsuite/ld-sh/sh64/crange-2b.s: Delete.
	* testsuite/ld-sh/sh64/crange-2c.s: Delete.
	* testsuite/ld-sh/sh64/crange-2d.s: Delete.
	* testsuite/ld-sh/sh64/crange-2e.s: Delete.
	* testsuite/ld-sh/sh64/crange-2f.s: Delete.
	* testsuite/ld-sh/sh64/crange-2g.s: Delete.
	* testsuite/ld-sh/sh64/crange-2h.s: Delete.
	* testsuite/ld-sh/sh64/crange-2i.s: Delete.
	* testsuite/ld-sh/sh64/crange1.rd: Delete.
	* testsuite/ld-sh/sh64/crange2.rd: Delete.
	* testsuite/ld-sh/sh64/crange3-cmpct.rd: Delete.
	* testsuite/ld-sh/sh64/crange3-media.rd: Delete.
	* testsuite/ld-sh/sh64/crange3.dd: Delete.
	* testsuite/ld-sh/sh64/crange3.rd: Delete.
	* testsuite/ld-sh/sh64/crangerel1.rd: Delete.
	* testsuite/ld-sh/sh64/crangerel2.rd: Delete.
	* testsuite/ld-sh/sh64/dlsection-1.s: Delete.
	* testsuite/ld-sh/sh64/dlsection.sd: Delete.
	* testsuite/ld-sh/sh64/endian.dbd: Delete.
	* testsuite/ld-sh/sh64/endian.dld: Delete.
	* testsuite/ld-sh/sh64/endian.ld: Delete.
	* testsuite/ld-sh/sh64/endian.s: Delete.
	* testsuite/ld-sh/sh64/endian.sbd: Delete.
	* testsuite/ld-sh/sh64/endian.sld: Delete.
	* testsuite/ld-sh/sh64/gotplt.d: Delete.
	* testsuite/ld-sh/sh64/gotplt.map: Delete.
	* testsuite/ld-sh/sh64/gotplt.s: Delete.
	* testsuite/ld-sh/sh64/init-cmpct.d: Delete.
	* testsuite/ld-sh/sh64/init-media.d: Delete.
	* testsuite/ld-sh/sh64/init.s: Delete.
	* testsuite/ld-sh/sh64/init64.d: Delete.
	* testsuite/ld-sh/sh64/mix1-noexp.sd: Delete.
	* testsuite/ld-sh/sh64/mix1.sd: Delete.
	* testsuite/ld-sh/sh64/mix1.xd: Delete.
	* testsuite/ld-sh/sh64/mix2-noexp.sd: Delete.
	* testsuite/ld-sh/sh64/mix2.sd: Delete.
	* testsuite/ld-sh/sh64/mix2.xd: Delete.
	* testsuite/ld-sh/sh64/rd-sh64.exp: Delete.
	* testsuite/ld-sh/sh64/rel-1.s: Delete.
	* testsuite/ld-sh/sh64/rel-2.s: Delete.
	* testsuite/ld-sh/sh64/rel32.xd: Delete.
	* testsuite/ld-sh/sh64/rel64.xd: Delete.
	* testsuite/ld-sh/sh64/relax.exp: Delete.
	* testsuite/ld-sh/sh64/relax1.s: Delete.
	* testsuite/ld-sh/sh64/relax2.s: Delete.
	* testsuite/ld-sh/sh64/relax3.s: Delete.
	* testsuite/ld-sh/sh64/relax4.s: Delete.
	* testsuite/ld-sh/sh64/reldl-1.s: Delete.
	* testsuite/ld-sh/sh64/reldl-2.s: Delete.
	* testsuite/ld-sh/sh64/reldl32.rd: Delete.
	* testsuite/ld-sh/sh64/reldl64.rd: Delete.
	* testsuite/ld-sh/sh64/relfail.exp: Delete.
	* testsuite/ld-sh/sh64/relfail.s: Delete.
	* testsuite/ld-sh/sh64/sh64-1.s: Delete.
	* testsuite/ld-sh/sh64/sh64-2.s: Delete.
	* testsuite/ld-sh/sh64/sh64.exp: Delete.
	* testsuite/ld-sh/sh64/shcmp-1.s: Delete.
	* testsuite/ld-sh/sh64/shdl-1.s: Delete.
	* testsuite/ld-sh/sh64/shdl-2.s: Delete.
	* testsuite/ld-sh/sh64/shdl32.xd: Delete.
	* testsuite/ld-sh/sh64/shdl64.sd: Delete.
	* testsuite/ld-sh/sh64/shdl64.xd: Delete.
	* testsuite/ld-sh/sh64/shmix-1.s: Delete.
	* testsuite/ld-sh/sh64/shmix-2.s: Delete.
	* testsuite/ld-sh/sh64/shmix-3.s: Delete.
	* testsuite/ld-sh/sh64/stobin-0-dso.d: Delete.
	* testsuite/ld-sh/sh64/stobin-1.d: Delete.
	* testsuite/ld-sh/sh64/stobin.s: Delete.
	* testsuite/ld-sh/sh64/stolib.s: Delete.
	* Makefile.in: Regenerate.
	* po/BLD-POTFILES.in: Regenerate.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Move fixup_partial_die to partial_die_info::fixup
@ 2018-02-26 16:40 sergiodj+buildbot
  2018-02-26 16:40 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 16:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 52356b79d76fb299a67685510ae584f3b0179734 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 52356b79d76fb299a67685510ae584f3b0179734

Move fixup_partial_die to partial_die_info::fixup

fixup_partial_die can be a partial_die_info method fixup.

gdb:

2018-02-26  Yao Qi  <yao.qi@linaro.org>

	* dwarf2read.c (struct partial_die_info) <fixup>: New method.
	(fixup_partial_die): Remove declaration.
	(scan_partial_symbols): Update.
	(partial_die_parent_scope): Likewise.
	(partial_die_full_name): Likewise.
	(fixup_partial_die): Change it to partial_die_info::fixup.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Remove one argument abbrev_len in read_partial_die
@ 2018-02-26 16:36 sergiodj+buildbot
  2018-02-26 16:36 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 16:36 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 35cc7ed70ced98eedf9c065faa602abb1dfac537 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 35cc7ed70ced98eedf9c065faa602abb1dfac537

Remove one argument abbrev_len in read_partial_die

gdb:

2018-02-26  Yao Qi  <yao.qi@linaro.org>

	* dwarf2read.c (read_partial_die): Update the declaration.
	(load_partial_dies): Caller update.
	(read_partial_die): Remove one argument abbrev_len.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Fix PR rust/20110
@ 2016-06-10 16:15 sergiodj+buildbot
  2016-06-10 16:20 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2016-06-10 16:15 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 347dc1025db1c0acf616ab6520c3f36448f25e8b ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 347dc1025db1c0acf616ab6520c3f36448f25e8b

Fix PR rust/20110

PR rust/20110 concerns the type of an integer constant that is too
large for "i32", the default integer type.  This patch changes the
type of such a constant to i64.  This is important because such values
are often addresses, so truncating them by default is unfriendly.

Built and regtested on x86-64 Fedora 23.

2016-06-10  Tom Tromey  <tom@tromey.com>

	PR rust/20110:
	* rust-exp.y (lex_number): Don't truncate large numbers to i32.

2016-06-10  Tom Tromey  <tom@tromey.com>

	PR rust/20110:
	* gdb.rust/expr.exp: Add test for integer constant larger than
	i32.


^ permalink raw reply	[flat|nested] 145+ messages in thread
* [binutils-gdb] Fix rust-exp handling in makefile
@ 2016-06-10 16:12 sergiodj+buildbot
  2016-06-10 16:15 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
  0 siblings, 1 reply; 145+ messages in thread
From: sergiodj+buildbot @ 2016-06-10 16:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT edef7b8cf3d811ce8630591dbed1257ba16164ff ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: edef7b8cf3d811ce8630591dbed1257ba16164ff

Fix rust-exp handling in makefile

I noticed that the rust-exp handling in the Makefile differed from
that of other .y files.  I believe I noticed this by seeing a stray
"rm" in the build log.

This patch changes the Makefile to bring the rust-exp handling in line
with that of other .y files.

2016-06-10  Tom Tromey  <tom@tromey.com>

	* Makefile.in (COMMON_OBS): Remove rust-exp.o.
	(YYFILES): Add rust-exp.c.
	(YYOBJ): Add rust-exp.o.
	(local-maintainer-clean): Remove rust-exp.c.


^ permalink raw reply	[flat|nested] 145+ messages in thread
end of thread, other threads:[~2019-06-19 14:38 UTC | newest]

Thread overview: 145+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-10 16:24 [binutils-gdb] Constify arch_type and friends sergiodj+buildbot
2016-06-10 16:30 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2016-06-10 16:44 ` *** COMPILATION FAILED *** Failures on AIX-POWER7-plain, " sergiodj+buildbot
2016-06-10 17:50 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2016-06-10 17:52 ` Failures on Fedora-x86_64-m32, " sergiodj+buildbot
2016-06-10 18:23 ` Failures on Debian-i686, " sergiodj+buildbot
2016-06-10 18:52 ` Failures on Fedora-x86_64-m64, " sergiodj+buildbot
2016-06-10 19:16 ` Failures on Debian-i686-native-extended-gdbserver, " sergiodj+buildbot
2016-06-10 19:23 ` Failures on Debian-x86_64-native-extended-gdbserver-m64, " sergiodj+buildbot
2016-06-10 21:36 ` Failures on Fedora-ppc64le-native-extended-gdbserver-m64, " sergiodj+buildbot
2016-06-10 22:18 ` Failures on Fedora-ppc64be-native-gdbserver-m64, " sergiodj+buildbot
2016-06-11  8:19 ` Failures on Fedora-ppc64be-native-extended-gdbserver-m64, " sergiodj+buildbot
  -- strict thread matches above, loose matches on Subject: below --
2019-06-19 15:59 [binutils-gdb] Add intro comment to length_cond.exp sergiodj+buildbot
2019-06-19 16:02 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2019-06-19 14:38 [binutils-gdb] Fix crash when setting breakpoint condition sergiodj+buildbot
2019-06-19 14:43 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2019-06-19 12:58 [binutils-gdb] Instantiate a single source highlighter sergiodj+buildbot
2019-06-19 12:59 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2019-06-19 11:38 [binutils-gdb] PR24697, R_PPC_EMB_SDA21 relocation sergiodj+buildbot
2019-06-19 11:38 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2019-06-19  8:47 [binutils-gdb] PowerPC64 notoc calls sergiodj+buildbot
2019-06-19  8:48 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2019-06-19  5:18 [binutils-gdb] gdb: Remove use of deprecated_interactive_hook sergiodj+buildbot
2019-06-19  6:16 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2019-06-18 18:53 [binutils-gdb] [gdb/testsuite] Use -fuse-ld=gold in fission.exp sergiodj+buildbot
2019-06-18 18:56 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2019-06-18 18:43 [binutils-gdb] [gdb] Fix abstract_to_concrete type sergiodj+buildbot
2019-06-18 18:44 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2019-06-13  4:35 [binutils-gdb] NEWS and manual changes for command options changes sergiodj+buildbot
2019-06-13  4:42 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2019-06-13  4:29 [binutils-gdb] Delete parse_flags/parse_flags_qcs sergiodj+buildbot
2019-06-13  4:35 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2019-06-13  4:21 [binutils-gdb] Make "thread apply" use the gdb::option framework sergiodj+buildbot
2019-06-13  4:21 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2019-06-13  4:08 [binutils-gdb] "thread apply 1 -- -" vs "frame apply level 0 -- -" sergiodj+buildbot
2019-06-13  4:15 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2019-06-13  3:56 [binutils-gdb] Make "frame apply" support -OPT options sergiodj+buildbot
2019-06-13  4:06 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2019-06-13  3:45 [binutils-gdb] Introduce complete_nested_command_line sergiodj+buildbot
2019-06-13  3:46 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2019-06-13  3:40 [binutils-gdb] lib/completion-support.exp: Add test_gdb_completion_offers_commands sergiodj+buildbot
2019-06-13  3:41 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2019-06-13  3:19 [binutils-gdb] "backtrace full/no-filters/hide" completer sergiodj+buildbot
2019-06-13  3:24 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2019-06-13  3:03 [binutils-gdb] Make "backtrace" support -OPT options sergiodj+buildbot
2019-06-13  3:03 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2019-06-13  3:01 [binutils-gdb] "set print raw frame-arguments" -> "set print raw-frame-arguments" sergiodj+buildbot
2019-06-13  3:01 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2019-06-13  2:57 [binutils-gdb] Migrate rest of compile commands to new options framework sergiodj+buildbot
2019-06-13  2:59 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2019-05-16 16:12 [binutils-gdb] [PATCH 44/57][Arm][OBJDUMP] Add support for MVE instructions: vcvt and vrint sergiodj+buildbot
2019-05-16 16:13 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2019-05-16 16:10 [binutils-gdb] [PATCH 43/57][Arm][OBJDUMP] Add support for MVE instructions: scatter stores and gather loads sergiodj+buildbot
2019-05-16 16:10 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2019-05-16 16:08 [binutils-gdb] [PATCH 42/57][Arm][OBJDUMP] Add support for MVE instructions: vldr[bhw] and vstr[bhw] sergiodj+buildbot
2019-05-16 16:10 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2019-05-16 16:06 [binutils-gdb] [PATCH 41/57][Arm][OBJDUMP] Add support for MVE instructions: vld[24] and vst[24] sergiodj+buildbot
2019-05-16 16:08 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2019-05-16 16:05 [binutils-gdb] [PATCH 40/57][Arm][OBJDUMP] Add support for MVE instructions: vdup, veor, vfma, vfms, vhadd, vhsub and vrhadd sergiodj+buildbot
2019-05-16 16:06 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2019-05-16 16:03 [binutils-gdb] [PATCH 39/57][Arm][OBJDUMP] Add support for MVE instructions: vpt, vpst and vcmp sergiodj+buildbot
2019-05-16 16:05 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2019-05-16 16:01 [binutils-gdb] [PATCH 38/57][Arm][OBJDUMP] Disable the use of MVE reserved coproc numbers in coprocessor instructions sergiodj+buildbot
2019-05-16 16:03 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2019-05-16 15:59 [binutils-gdb] [PATCH 37/57][Arm][OBJDUMP] Add framework for MVE instructions sergiodj+buildbot
2019-05-16 16:01 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2019-05-08 17:01 [binutils-gdb] Fix style bug when paging sergiodj+buildbot
2019-05-08 17:59 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2019-03-25 16:55 [binutils-gdb] Add linux_get_hwcap sergiodj+buildbot
2019-03-25 16:58 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2019-01-10 17:12 [binutils-gdb] gdb: Improve scoped_switch_fork_info class sergiodj+buildbot
2019-01-10 17:12 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2019-01-07 13:26 [binutils-gdb] Sync libiberty sources with master version in gcc repository. Updated stabs demangling and cxxfilt tests to match sergiodj+buildbot
2019-01-07 13:26 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-12-28 23:52 [binutils-gdb] Fix a crash in jit.c sergiodj+buildbot
2018-12-29  0:20 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-12-28 23:46 [binutils-gdb] Document the "set style" commands sergiodj+buildbot
2018-12-29  0:13 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-12-28 23:31 [binutils-gdb] Highlight source code using GNU Source Highlight sergiodj+buildbot
2018-12-29  0:02 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-11-20 16:57 [binutils-gdb] Avoid "Invalid parameter passed to C runtime function" warning sergiodj+buildbot
2018-11-20 16:57 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-11-09 15:43 [binutils-gdb] [ARC] More fixes for TLS sergiodj+buildbot
2018-11-09 15:44 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-12 19:01 [binutils-gdb] Remove unused variable in record-btrace.c sergiodj+buildbot
2018-09-12 19:01 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-12 14:53 [binutils-gdb] (Ada) Fix resolving of homonym components in tagged types sergiodj+buildbot
2018-09-12 14:53 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-12 12:16 [binutils-gdb] (Ada) Cleanup code by using ada_is_access_to_unconstrained_array call sergiodj+buildbot
2018-09-12 12:25 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-12 12:06 [binutils-gdb] (Ada) Fix printing of access to unconstrained arrays sergiodj+buildbot
2018-09-12 12:10 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-12 11:37 [binutils-gdb] (Ada/MI) Fix -var-evaluate-expression for access to unconstrained arrays sergiodj+buildbot
2018-09-12 11:53 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-12 11:28 [binutils-gdb] (Ada) New function ada_is_access_to_unconstrained_array sergiodj+buildbot
2018-09-12 11:28 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-11 21:36 [binutils-gdb] (Ada) Fix -var-list-children MI command for union type sergiodj+buildbot
2018-09-12  4:31 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-11 15:00 [binutils-gdb] Fix help text for "python" command sergiodj+buildbot
2018-09-11 15:15 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-11 12:01 [binutils-gdb] Fix "make install-strip" failure to install gdb-add-index.sh sergiodj+buildbot
2018-09-11 12:04 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-10 16:47 [binutils-gdb] Allow a pretty-printer without a to_string method sergiodj+buildbot
2018-09-10 16:59 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-10 10:42 [binutils-gdb] (Ada) fix handling of expression with parameterless function call sergiodj+buildbot
2018-09-10 13:52 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-10  9:19 [binutils-gdb] ada-lang.c::ada_value_cast: remove unnecessary parentheses sergiodj+buildbot
2018-09-10  9:22 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-10  9:00 [binutils-gdb] (Ada) slightly incorrect bounds for type of array indexed by enum sergiodj+buildbot
2018-09-10  9:00 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-10  7:38 [binutils-gdb] minor reformatting in ada-lang.c::ada_to_fixed_value sergiodj+buildbot
2018-09-10  8:18 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-10  7:19 [binutils-gdb] Handle PPC64 function descriptor in Ada decoding sergiodj+buildbot
2018-09-10  7:21 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-10  5:17 [binutils-gdb] (Ada) "catch assert" spurious internal error sergiodj+buildbot
2018-09-10  7:19 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-10  3:54 [binutils-gdb] (Ada) infinite loop when hitting unhandled exception catchpoint sergiodj+buildbot
2018-09-10  3:02 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-10  0:24 [binutils-gdb] (Ada) assigning packed array aggregate with variable as component sergiodj+buildbot
2018-09-10  1:27 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-09 11:13 [binutils-gdb] gdb: Add builtin types for 24 bit integers sergiodj+buildbot
2018-09-09 13:16 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-09  7:50 [binutils-gdb] S12Z: Make disassebler work for --enable-targets=all config sergiodj+buildbot
2018-09-09  7:33 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-09  4:35 [binutils-gdb] gdb/testsuite: Make test names unique in gdb.base/watchpoint.exp sergiodj+buildbot
2018-09-09  4:35 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-09  0:05 [binutils-gdb] Generate NT_PROCSTAT_{AUXV, VMMAP, PS_STRINGS} in FreeBSD coredumps sergiodj+buildbot
2018-09-09  0:05 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-08 22:13 [binutils-gdb] compile: Remove non-const reference parameters sergiodj+buildbot
2018-09-08 22:14 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-08 22:11 [binutils-gdb] Remove unused tui_win_element::highlight sergiodj+buildbot
2018-09-08 22:12 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-08 17:19 [binutils-gdb] Remove unused tui_win_info::detail::opaque sergiodj+buildbot
2018-09-08 21:53 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-08 11:43 [binutils-gdb] PR23570, AVR .noinit section defaults to PROGBITS sergiodj+buildbot
2018-09-08 11:45 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-08  8:49 [binutils-gdb] Make -Wformat-nonliteral work with gcc sergiodj+buildbot
2018-09-08  9:02 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-08  8:41 [binutils-gdb] Disable -Wformat-nonliteral in parts of printcmd.c sergiodj+buildbot
2018-09-08  8:42 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-07 15:23 [binutils-gdb] Remove unnecessary casts from cli-cmds.c sergiodj+buildbot
2018-09-07 17:04 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-07  3:16 [binutils-gdb] [gdb/exp] Handle DW_OP_GNU_variable_value refs to abstract dies sergiodj+buildbot
2018-09-07  4:12 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-06  3:54 [binutils-gdb] bfd, sparc: avoid duplicated error messages on invalid relocations sergiodj+buildbot
2018-09-06  3:54 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-06  3:53 [binutils-gdb] bfd, sparc: issue an error when reading relocations with invalid symbol references sergiodj+buildbot
2018-09-06  3:53 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-05 22:50 [binutils-gdb] Automatically update "aclocal_m4_deps" when updating gnulib sergiodj+buildbot
2018-09-05 23:25 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-05 15:50 [binutils-gdb] Remove --enable-multi-ice sergiodj+buildbot
2018-09-05 15:54 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-05 15:32 [binutils-gdb] Simplify ada-exp.o rule sergiodj+buildbot
2018-09-05 15:33 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-05 15:02 [binutils-gdb] Remove unneeded explicit .o targets sergiodj+buildbot
2018-09-05 15:32 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-05 12:05 [binutils-gdb] Remove obsolete comments from Makefiles sergiodj+buildbot
2018-09-05 13:06 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-05  9:57 [binutils-gdb] Fix batch exit status test failure on Fedora 28 sergiodj+buildbot
2018-09-05  9:55 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-05  9:07 [binutils-gdb] gdb/riscv: Fix an ARI warning sergiodj+buildbot
2018-09-05  8:44 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-04 20:01 [binutils-gdb] gdb/riscv: Provide non-DWARF stack unwinder sergiodj+buildbot
2018-09-04 20:01 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-04 19:39 [binutils-gdb] gdb: Extend the trad-frame API sergiodj+buildbot
2018-09-04 19:55 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-04 18:26 [binutils-gdb] PR23595, simple objcopy of executable failure for msp430-elf sergiodj+buildbot
2018-09-04 18:34 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-03 17:01 [binutils-gdb] Fix ARI violations in c++compile sergiodj+buildbot
2018-09-03 17:24 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-02  6:57 [binutils-gdb] Allow an IR object with unknown architecture sergiodj+buildbot
2018-09-02  7:30 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-01  4:41 [binutils-gdb] RISC-V: Correct the requirement of compressed floating point instructions sergiodj+buildbot
2018-09-01  4:41 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-01  3:00 [binutils-gdb] Set TYPE_LENGTH on a variant part sergiodj+buildbot
2018-09-01  2:54 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-09-01  1:47 [binutils-gdb] Fix a small bug in gdb.rust/simple.rs sergiodj+buildbot
2018-09-01  1:47 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-08-31 23:08 [binutils-gdb] Regenerate gdbarch.h sergiodj+buildbot
2018-08-31 23:20 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-08-31 22:25 [binutils-gdb] Add comment describing continuable/steppable/non-steppable watchpoints sergiodj+buildbot
2018-08-31 22:25 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-08-31 22:04 [binutils-gdb] Eliminate target_have_continuable_watchpoint sergiodj+buildbot
2018-08-31 22:17 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-08-31 20:14 [binutils-gdb] Update gnulib/Makefile.in:aclocal_m4_deps sergiodj+buildbot
2018-08-31 20:15 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-08-31 19:43 [binutils-gdb] PowerPC64 --emit-relocs support for notoc stubs sergiodj+buildbot
2018-08-31 19:43 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-08-31 19:39 [binutils-gdb] PowerPC64 higher REL16 relocations sergiodj+buildbot
2018-08-31 19:41 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-08-31 19:26 [binutils-gdb] Rearrange ppc_size_one_stub and correct _notoc stub examples sergiodj+buildbot
2018-08-31 19:28 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-08-31 16:33 [binutils-gdb] RISC-V: Allow instruction require more than one extension sergiodj+buildbot
2018-08-31 16:32 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-08-30 22:32 [binutils-gdb] gdb/riscv: Extend instruction decode to cover more instructions sergiodj+buildbot
2018-08-30 23:07 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-08-30 21:42 [binutils-gdb] gdb/riscv: remove extra caching of misa register sergiodj+buildbot
2018-08-30 21:50 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-08-30 21:26 [binutils-gdb] gdb: Ensure compiler doesn't optimise variable out in test sergiodj+buildbot
2018-08-30 21:28 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-08-30 20:30 [binutils-gdb] Fix compile-cplus-types.c build errors sergiodj+buildbot
2018-08-30 20:31 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-08-30 19:05 [binutils-gdb] Use host_address_to_string in compile_cplus_instance::enter_scope sergiodj+buildbot
2018-08-30 19:21 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-08-30  1:55 [binutils-gdb] C++ compile support sergiodj+buildbot
2018-08-30  1:57 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-08-30  1:51 [binutils-gdb] Add new search_symbols_multiple API sergiodj+buildbot
2018-08-30  1:54 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-08-30  1:27 [binutils-gdb] Use block_symbol in linespec APIs sergiodj+buildbot
2018-08-30  1:36 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-08-30  1:10 [binutils-gdb] Remove VEC definitions from linespec.c sergiodj+buildbot
2018-08-30  1:20 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-08-30  1:07 [binutils-gdb] Change decode_compound_collector to use std::vector sergiodj+buildbot
2018-08-30  1:10 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-08-30  0:47 [binutils-gdb] Change `minimal_symbols' to std::vector in linespec.c structures sergiodj+buildbot
2018-08-30  0:51 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-08-30  0:35 [binutils-gdb] Change `label_symbols' to std::vector in linespec.c structures sergiodj+buildbot
2018-08-30  0:35 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-08-30  0:11 [binutils-gdb] Change `function_symbols' to std::vector sergiodj+buildbot
2018-08-30  0:22 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-08-30  0:06 [binutils-gdb] Change `file_symtabs' to std::vector sergiodj+buildbot
2018-08-30  0:07 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-08-29 23:06 [binutils-gdb] Use core_addr_to_string_nz in csky_analyze_prologue sergiodj+buildbot
2018-08-29 23:12 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-08-29 22:41 [binutils-gdb] Fix windows-nat.c for -Wnarrowing sergiodj+buildbot
2018-08-29 22:41 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-08-29 21:44 [binutils-gdb] sparc/leon: add support for partial write psr instruction sergiodj+buildbot
2018-08-29 21:54 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-08-29 20:38 [binutils-gdb] Fix riscv-linux native gdb build failure sergiodj+buildbot
2018-08-29 20:52 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-08-29 19:31 [binutils-gdb] Update gnulib to current upstream master sergiodj+buildbot
2018-08-29 19:29 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-08-06 14:07 [binutils-gdb] [ARC] Add Tag_ARC_ATR_version sergiodj+buildbot
2018-08-06 14:07 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-06-29 22:12 [binutils-gdb] x86_64-windows GDB crash due to fs_base/gs_base registers sergiodj+buildbot
2018-06-29 22:12 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-05-03  2:31 [binutils-gdb] target factories, target open and multiple instances of targets sergiodj+buildbot
2018-05-03  3:17 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-05-03  2:26 [binutils-gdb] linux_nat_target: More low methods sergiodj+buildbot
2018-05-03  2:58 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-05-03  2:21 [binutils-gdb] target_ops: Use bool throughout sergiodj+buildbot
2018-05-03  2:52 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-05-03  2:19 [binutils-gdb] make-target-delegates: line break between return type and function name sergiodj+buildbot
2018-05-03  2:51 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-05-03  2:19 [binutils-gdb] Convert struct target_ops to C++ sergiodj+buildbot
2018-05-03  2:48 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-04-16 12:19 [binutils-gdb] gdb: Remove OpenBSD/m88k support sergiodj+buildbot
2018-04-16 12:20 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-04-16 12:05 [binutils-gdb] Prevent an illegal memory access via an out of range fixup pointer sergiodj+buildbot
2018-04-16 12:05 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-04-16 11:32 [binutils-gdb] Remove arm-epoc-pe support sergiodj+buildbot
2018-04-16 11:32 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-04-16 11:29 [binutils-gdb] sparc-coff removal leftover sergiodj+buildbot
2018-04-16 11:29 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-04-16 11:06 [binutils-gdb] Remove sh-symbianelf support sergiodj+buildbot
2018-04-16 11:06 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-04-16 11:04 [binutils-gdb] Remove vax-bsd and vax-ultrix support sergiodj+buildbot
2018-04-16 11:04 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-04-16 11:02 [binutils-gdb] Remove w65 support sergiodj+buildbot
2018-04-16 11:02 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-04-16 11:00 [binutils-gdb] Remove we32k support sergiodj+buildbot
2018-04-16 11:00 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-04-16 10:58 [binutils-gdb] Remove m88k support sergiodj+buildbot
2018-04-16 10:58 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-04-16  9:35 [binutils-gdb] Remove sparc-aout and sparc-coff support sergiodj+buildbot
2018-04-16 11:13 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-04-16  9:21 [binutils-gdb] Remove m68k-aout and m68k-coff support sergiodj+buildbot
2018-04-16 11:11 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-04-16  9:11 [binutils-gdb] Remove sh5 and sh64 support sergiodj+buildbot
2018-04-16 11:08 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-02-26 16:40 [binutils-gdb] Move fixup_partial_die to partial_die_info::fixup sergiodj+buildbot
2018-02-26 16:40 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2018-02-26 16:36 [binutils-gdb] Remove one argument abbrev_len in read_partial_die sergiodj+buildbot
2018-02-26 16:36 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2016-06-10 16:15 [binutils-gdb] Fix PR rust/20110 sergiodj+buildbot
2016-06-10 16:20 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot
2016-06-10 16:12 [binutils-gdb] Fix rust-exp handling in makefile sergiodj+buildbot
2016-06-10 16:15 ` *** COMPILATION FAILED *** Failures on RHEL-s390x-m64, branch master *** BREAKAGE *** sergiodj+buildbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).