public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb/gdb-7.12-branch] ppc: Fix record support of Store String Word instructions
@ 2016-09-21 13:28 sergiodj+buildbot
  2016-09-21 13:18 ` Failures on Fedora-x86_64-native-gdbserver-m32, branch gdb-7.12-branch sergiodj+buildbot
                   ` (14 more replies)
  0 siblings, 15 replies; 36+ messages in thread
From: sergiodj+buildbot @ 2016-09-21 13:28 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4e2b3c62a39b99edcd20c25774c1eee01ea6fad5 ***

Author: Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
Branch: gdb-7.12-branch
Commit: 4e2b3c62a39b99edcd20c25774c1eee01ea6fad5

ppc: Fix record support of Store String Word instructions

gdb/ChangeLog
2016-09-20  Edjunior Barbosa Machado  <emachado@linux.vnet.ibm.com>

	* rs6000-tdep.c (ppc_process_record_op31): Fix record of Store String
	Word instructions.


^ permalink raw reply	[flat|nested] 36+ messages in thread
* [binutils-gdb/gdb-7.12-branch] Set GDB version number to 7.12.1.
@ 2017-01-21 14:06 sergiodj+buildbot
  2017-01-21 14:17 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
  0 siblings, 1 reply; 36+ messages in thread
From: sergiodj+buildbot @ 2017-01-21 14:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 59b102452f0bdab7a9b19d9fdbb8ce5253f0ce9f ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: gdb-7.12-branch
Commit: 59b102452f0bdab7a9b19d9fdbb8ce5253f0ce9f

Set GDB version number to 7.12.1.

gdb/ChangeLog:

	* version.in: Set GDB version number to 7.12.1.
	* PROBLEMS: Likewise.


^ permalink raw reply	[flat|nested] 36+ messages in thread
* [binutils-gdb/gdb-7.12-branch] Fix python-interactive with Python 3.6
@ 2017-01-21  2:29 sergiodj+buildbot
  2017-01-21  3:05 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
  0 siblings, 1 reply; 36+ messages in thread
From: sergiodj+buildbot @ 2017-01-21  2:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3fc6097b073698a50d0ab70c6c8205a83cd9383c ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: gdb-7.12-branch
Commit: 3fc6097b073698a50d0ab70c6c8205a83cd9383c

Fix python-interactive with Python 3.6

New in v2:

 - Define PyMem_RawMalloc as PyMem_Malloc for Python < 3.4 and use
   PyMem_RawMalloc in the code.

Since Python 3.4, the callback installed in PyOS_ReadlineFunctionPointer
should return a value allocated with PyMem_RawMalloc instead of
PyMem_Malloc.  The reason is that PyMem_Malloc must be called with the
Python Global Interpreter Lock (GIL) held, which is not the case in the
context where this function is called.  PyMem_RawMalloc was introduced
for cases like this.

In Python 3.6, it looks like they added an assert to verify that
PyMem_Malloc was not called without the GIL.  The consequence is that
typing anything in the python-interactive mode of gdb crashes the
process.  The same behavior was observed with the official package on
Arch Linux as well as with a manual Python build on Ubuntu 14.04.

This is what is shown with a debug build of Python 3.6 (the error with a
non-debug build is far less clear):

  (gdb) pi
  >>> print(1)
  Fatal Python error: Python memory allocator called without holding the GIL

  Current thread 0x00007f1459af8780 (most recent call first):
  [1]    21326 abort      ./gdb

and the backtrace:

  #0  0x00007ffff618bc37 in raise () from /lib/x86_64-linux-gnu/libc.so.6
  #1  0x00007ffff618f028 in abort () from /lib/x86_64-linux-gnu/libc.so.6
  #2  0x00007ffff6b104d6 in Py_FatalError (msg=msg@entry=0x7ffff6ba15b8 "Python memory allocator called without holding the GIL") at Python/pylifecycle.c:1457
  #3  0x00007ffff6a37a68 in _PyMem_DebugCheckGIL () at Objects/obmalloc.c:1972
  #4  0x00007ffff6a3804e in _PyMem_DebugFree (ctx=0x7ffff6e65290 <_PyMem_Debug+48>, ptr=0x24f8830) at Objects/obmalloc.c:1994
  #5  0x00007ffff6a38e1d in PyMem_Free (ptr=<optimized out>) at Objects/obmalloc.c:442
  #6  0x00007ffff6b866c6 in _PyFaulthandler_Fini () at ./Modules/faulthandler.c:1369
  #7  0x00007ffff6b104bd in Py_FatalError (msg=msg@entry=0x7ffff6ba15b8 "Python memory allocator called without holding the GIL") at Python/pylifecycle.c:1431
  #8  0x00007ffff6a37a68 in _PyMem_DebugCheckGIL () at Objects/obmalloc.c:1972
  #9  0x00007ffff6a37aa3 in _PyMem_DebugMalloc (ctx=0x7ffff6e65290 <_PyMem_Debug+48>, nbytes=5) at Objects/obmalloc.c:1980
  #10 0x00007ffff6a38d91 in PyMem_Malloc (size=<optimized out>) at Objects/obmalloc.c:418
  #11 0x000000000064dbe2 in gdbpy_readline_wrapper (sys_stdin=0x7ffff6514640 <_IO_2_1_stdin_>, sys_stdout=0x7ffff6514400 <_IO_2_1_stdout_>, prompt=0x7ffff4d4f7d0 ">>> ")
    at /home/emaisin/src/binutils-gdb/gdb/python/py-gdb-readline.c:75

The documentation is very clear about it [1] and it was also mentioned
in the "What's New In Python 3.4" page [2].

[1] https://docs.python.org/3/c-api/veryhigh.html#c.PyOS_ReadlineFunctionPointer
[2] https://docs.python.org/3/whatsnew/3.4.html#changes-in-the-c-api

gdb/ChangeLog:

	* python/python-internal.h (PyMem_RawMalloc): Define for
	Python < 3.4.
	* python/py-gdb-readline.c (gdbpy_readline_wrapper): Use
	PyMem_RawMalloc instead of PyMem_Malloc.


^ permalink raw reply	[flat|nested] 36+ messages in thread
* [binutils-gdb/gdb-7.12-branch] gdb: Fix C and C++03 builds
@ 2016-12-20 20:16 sergiodj+buildbot
  2016-12-20 20:30 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
  0 siblings, 1 reply; 36+ messages in thread
From: sergiodj+buildbot @ 2016-12-20 20:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9bfe0298332782a9c082fb475bdf8eeeef8cf45e ***

Author: Pedro Alves <palves@redhat.com>
Branch: gdb-7.12-branch
Commit: 9bfe0298332782a9c082fb475bdf8eeeef8cf45e

gdb: Fix C and C++03 builds

The readline/sjlj-exceptions fix added an unconditional use of
noexcept, but that's only valid C++11, and 7.12 must build with C and
C++03 too.  Fix this by adding a GDB_EXCEPT macro that compiles away
to nothing in C, and to throw() in C++03, which I've confirmed fixes
the original issue just the same as noexcept, with GCC 7 + -std=gnu+03
+ sjlj-exceptions.

gdb/ChangeLog:
2016-12-20  Pedro Alves  <palves@redhat.com>

	PR gdb/20977
	* event-top.c (GDB_NOEXCEPT): Define.
	(gdb_rl_callback_read_char_wrapper_noexcept): Use GDB_NOEXCEPT
	instead of noexcept and use (void) instead of ().
	(gdb_rl_callback_handler): Use GDB_NOEXCEPT instead of noexcept.


^ permalink raw reply	[flat|nested] 36+ messages in thread
* [binutils-gdb/gdb-7.12-branch] sim: mips: fix dv-tx3904cpu build error
@ 2016-11-11  7:48 sergiodj+buildbot
  2016-11-11  8:15 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
  0 siblings, 1 reply; 36+ messages in thread
From: sergiodj+buildbot @ 2016-11-11  7:48 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cd48ce152d6710af146ffc7897a82586513fc534 ***

Author: Mike Frysinger <vapier@gentoo.org>
Branch: gdb-7.12-branch
Commit: cd48ce152d6710af146ffc7897a82586513fc534

sim: mips: fix dv-tx3904cpu build error

When building for mipstx39-rtems4.12 targets, some funcs use SD and CPU
implicitly.  Restore the defines for these to the local sd and cpu vars.

This was broken by the clean up in commit d47f5b30d8481272e9480118bdcb.

Reported-by: Joel Sherrill <joel.sherrill@oarcorp.com>


^ permalink raw reply	[flat|nested] 36+ messages in thread
* [binutils-gdb/gdb-7.12-branch] Fix gdb C++ compilation on Solaris (PR build/20712)
@ 2016-10-27  2:04 sergiodj+buildbot
  2016-10-27  1:31 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
  0 siblings, 1 reply; 36+ messages in thread
From: sergiodj+buildbot @ 2016-10-27  2:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fd5c8f0002f6790d57b6479bc9f2e86ccd63a68b ***

Author: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Branch: gdb-7.12-branch
Commit: fd5c8f0002f6790d57b6479bc9f2e86ccd63a68b

Fix gdb C++ compilation on Solaris (PR build/20712)

gdb 7.12 doesn't compile as C++ (tried with g++ 4.9) on Solaris (tried
10 and 12, sparc and x86).  The following patch (relative to the 7.12
release, though I expect most if not all issues to be present on trunk,
too) fixes this.

Only a few of the changes bear explanation:

* Initially, compilation failed whereever defs.h. was included:

In file included from /vol/src/gnu/gdb/gdb-7.12/gdb/gdb.c:19:0:
/vol/src/gnu/gdb/gdb-7.12/gdb/defs.h:630:33: error: 'double atof(const char*)' conflicts with a previous declaration
 extern double atof (const char *); /* X3.159-1989  4.10.1.1 */
                                 ^
In file included from /usr/include/stdlib.h:17:0,
                 from build-gnulib/import/stdlib.h:36,
                 from /vol/src/gnu/gdb/gdb-7.12/gdb/common/common-defs.h:32,
                 from /vol/src/gnu/gdb/gdb-7.12/gdb/defs.h:28,
                 from /vol/src/gnu/gdb/gdb-7.12/gdb/gdb.c:19:
/vol/gcc-4.9/lib/gcc/i386-pc-solaris2.10/4.9.0/include-fixed/iso/stdlib_iso.h:119:15: note: previous declaration 'double std::atof(const char*)'
 extern double atof(const char *);
               ^

  This is due to this gem in gdb/defs.h which seems to have been present
  like forever:

#ifndef atof
extern double atof (const char *);	/* X3.159-1989  4.10.1.1 */
#endif

  In the Solaris headers, the appropriate functions are in namespace std,
  thus the conflict.  I've wrapped the defs.h declaration in !__cplusplus
  to avoid this; perhaps it can go completely instead.

* All the casts are necessary to appease g++ and should be pretty
  obvious.

* The sol-thread.c changes are here to handle

/vol/src/gnu/gdb/gdb-7.12/gdb/sol-thread.c: In function 'void _initialize_sol_thread()':
/vol/src/gnu/gdb/gdb-7.12/gdb/sol-thread.c:1252:36: error: invalid conversion from 'void*' to 'void (*)(int)' [-fpermissive]
   if (!(p_##X = dlsym (dlhandle, #X))) \
                                    ^
/vol/src/gnu/gdb/gdb-7.12/gdb/sol-thread.c:1255:3: note: in expansion of macro 'resolve'
   resolve (td_log);
   ^

  and are modeled after linux-thread-db.c (try_thread_db_load_1).

The patch allowed both 32 and 64-bit C++ builds on sparc-sun-solaris2.10
and i386-pc-solaris2.10 to complete.  The resulting binary hasn't seen
more than a smoke test (invoke it on itself, b main, run) yet.

When investigating the failure to detect -static-libstdc++
support (more below), I found two more issues which only show up with
-Werror:

/vol/src/gnu/gdb/gdb/local/gdb/procfs.c: In function 'ssd* proc_get_LDT_entry(procinfo*, int)':
/vol/src/gnu/gdb/gdb/local/gdb/procfs.c:2487:19: error: variable 'old_chain' set but not used [-Werror=unused-but-set-variable]
   struct cleanup *old_chain = NULL;
                   ^

Unless I'm mistaken, you need to run do_cleanups on every return from
the function.

Afterwards, I ran a 32-bit compilation, which (after adding
--disable-largefile to avoid

In file included from /usr/include/sys/procfs.h:28:0,
                 from /vol/src/gnu/gdb/gdb/local/gdb/i386-sol2-nat.c:23:
/usr/include/sys/old_procfs.h:39:2: error: #error "Cannot use procfs in the large file compilation environment"
 #error "Cannot use procfs in the large file compilation environment"
  ^

and two more instances) revealed

/vol/src/gnu/gdb/gdb/local/gdb/top.c: In function 'void gdb_safe_append_history()':
/vol/src/gnu/gdb/gdb/local/gdb/top.c:1170:59: error: format '%d' expects argument of type 'int', but argument 3 has type 'pid_t {aka long int}' [-Werror=format=]
     = xstrprintf ("%s-gdb%d~", history_filename, getpid ());
                                                           ^

Fixed by casting pid_t to long and printing it as such.


^ permalink raw reply	[flat|nested] 36+ messages in thread
* [binutils-gdb/gdb-7.12-branch] [AArch64] Track FP registers in prologue analyzer
@ 2016-10-12 12:26 sergiodj+buildbot
  2016-10-12 13:18 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
  0 siblings, 1 reply; 36+ messages in thread
From: sergiodj+buildbot @ 2016-10-12 12:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8268cfa384409770cd6988e54b386ae286c0f3d1 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: gdb-7.12-branch
Commit: 8268cfa384409770cd6988e54b386ae286c0f3d1

[AArch64] Track FP registers in prologue analyzer

We don't track FP registers in aarch64 prologue analyzer, so this causes
an internal error when FP registers are saved by "stp" instruction in
prologue (stp	d8, d9, [sp,#128]),

 tbreak _Unwind_RaiseException^M
 aarch64-tdep.c:335: internal-error: CORE_ADDR aarch64_analyze_prologue(gdbarch*, CORE_ADDR, CORE_ADDR, aarch64_prologue_cache*): Assertion `inst.operands[0].type == AARCH64_OPND_Rt' failed.^M
 A problem internal to GDB has been detected,

This patch teaches GDB to track FP registers (D registers) in prologue
analyzer.

gdb:

2016-10-12  Yao Qi  <yao.qi@linaro.org>

	PR tdep/20682
	* aarch64-tdep.c: Replace 32 with AARCH64_D_REGISTER_COUNT.
	(aarch64_analyze_prologue): Extend array 'regs' for D registers.
	Assert that operand 0 and 1 can be X or D registers.  Update
	register number for D registers.  Update registers in frame
	cache.
	* aarch64-tdep.h (AARCH64_D_REGISTER_COUNT): New macro.


^ permalink raw reply	[flat|nested] 36+ messages in thread
* [binutils-gdb/gdb-7.12-branch] Bump GDB version number to 7.12.0.DATE-git.
@ 2016-10-07 18:04 sergiodj+buildbot
  2016-10-07 18:55 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
  0 siblings, 1 reply; 36+ messages in thread
From: sergiodj+buildbot @ 2016-10-07 18:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 856c9a7506cb86bedeb1402f03266b5b6fb2c431 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: gdb-7.12-branch
Commit: 856c9a7506cb86bedeb1402f03266b5b6fb2c431

Bump GDB version number to 7.12.0.DATE-git.

gdb/ChangeLog:

	* version.in: Set GDB version number to 7.12.0.DATE-git.


^ permalink raw reply	[flat|nested] 36+ messages in thread
* [binutils-gdb/gdb-7.12-branch] testsuite: solib-disc: Use `standard_output_file'
@ 2016-10-06 19:21 sergiodj+buildbot
  2016-10-06 21:25 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
  0 siblings, 1 reply; 36+ messages in thread
From: sergiodj+buildbot @ 2016-10-06 19:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8ff5432c0c9912efc43f92837243aecfcf1c1098 ***

Author: Maciej W. Rozycki <macro@imgtec.com>
Branch: gdb-7.12-branch
Commit: 8ff5432c0c9912efc43f92837243aecfcf1c1098

testsuite: solib-disc: Use `standard_output_file'

Correct a commit 2151ccc56c74 ("Always organize test artifacts in a
directory hierarchy") regression causing:

Running .../gdb/testsuite/gdb.base/solib-disc.exp ...
gdb compile failed, Assembler messages:
Fatal error: can't create .../gdb/testsuite/gdb.base/so-disc-shr.c.o: No such file or directory

by using `standard_output_file' to construct output file names
throughout.

	gdb/testsuite/
	* gdb.base/solib-disc.exp: Use `standard_output_file'
	throughout.
(cherry picked from commit 7470adbb872d5363580eb5e0a8dbb231c286ee4c)


^ permalink raw reply	[flat|nested] 36+ messages in thread
* [binutils-gdb/gdb-7.12-branch] Introduce cleanup to restore current_uiout
@ 2016-10-03 23:07 sergiodj+buildbot
  2016-10-04  0:04 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
  0 siblings, 1 reply; 36+ messages in thread
From: sergiodj+buildbot @ 2016-10-03 23:07 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 33de0b1741b1939dd5384e54a858e71d2029a365 ***

Author: Simon Marchi <simark@simark.ca>
Branch: gdb-7.12-branch
Commit: 33de0b1741b1939dd5384e54a858e71d2029a365

Introduce cleanup to restore current_uiout

Make a globally available cleanup from a pre-existing one in infrun.c.
This is used in a following patch.

gdb/ChangeLog:

	* infrun.c (restore_current_uiout_cleanup): Move to ui-out.c.
	(print_stop_event): Use make_cleanup_restore_current_uiout.
	* python/python.c (execute_gdb_command): Likewise.
	* ui-out.c (restore_current_uiout_cleanup): Move from infrun.c.
	(make_cleanup_restore_current_uiout): New function definition.
	* ui-out.h (make_cleanup_restore_current_uiout): New function
	declaration.
	* utils.c (do_restore_ui_out): Remove.
	(make_cleanup_restore_ui_out): Remove.
	* utils.h (make_cleanup_restore_ui_out): Remove.


^ permalink raw reply	[flat|nested] 36+ messages in thread
* [binutils-gdb/gdb-7.12-branch] Detect the magic address of EXC_RETURN in ARM coretx-m profile
@ 2016-09-27 12:20 sergiodj+buildbot
  2016-09-27 15:34 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
  0 siblings, 1 reply; 36+ messages in thread
From: sergiodj+buildbot @ 2016-09-27 12:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4b48dc411a11fd38b7e5d0e8aeecf1bb1f7b90d8 ***

Author: Fredrik Hederstierna <fredrik.hederstierna@verisure.com>
Branch: gdb-7.12-branch
Commit: 4b48dc411a11fd38b7e5d0e8aeecf1bb1f7b90d8

Detect the magic address of EXC_RETURN in ARM coretx-m profile

On ARMv6-M and ARMv7-M, the exception return address is sort of magic
address defined by the manual.  This patch is to let GDB well handle
these magic addresses.

2016-09-27  Fredrik Hederstierna  <fredrik.hederstierna@verisure.com>

	* arm-tdep.c (arm_m_addr_is_magic): New function.
	(arm_addr_bits_remove): Call arm_m_addr_is_magic.
	(arm_m_exception_unwind_sniffer): Likewise.


^ permalink raw reply	[flat|nested] 36+ messages in thread
* [binutils-gdb/gdb-7.12-branch] Introduce make_cleanup_restore_current_ui
@ 2016-09-07  2:09 sergiodj+buildbot
  2016-09-07  8:57 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
  0 siblings, 1 reply; 36+ messages in thread
From: sergiodj+buildbot @ 2016-09-07  2:09 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 751b0f7dcfee83f60c1224790b9665c92be50fd8 ***

Author: Pedro Alves <palves@redhat.com>
Branch: gdb-7.12-branch
Commit: 751b0f7dcfee83f60c1224790b9665c92be50fd8

Introduce make_cleanup_restore_current_ui

Just a tidy, no functional changes.

gdb/ChangeLog:
2016-09-06  Pedro Alves  <palves@redhat.com>

	* event-top.c (restore_ui_cleanup): Now static.
	(make_cleanup_restore_current_ui): New function.
	(switch_thru_all_uis_init): Use it.
	* infcall.c (call_thread_fsm_should_stop): Use it.
	* infrun.c (fetch_inferior_event): Use it.
	* top.c (new_ui_command): Use it.
	* top.h (restore_ui_cleanup): Delete declaration.
	(make_cleanup_restore_current_ui): New declaration.


^ permalink raw reply	[flat|nested] 36+ messages in thread
* [binutils-gdb/gdb-7.12-branch] Fix lwp_suspend/unsuspend imbalance in linux_wait_1
@ 2016-09-01  8:54 sergiodj+buildbot
  2016-09-01 19:20 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
  0 siblings, 1 reply; 36+ messages in thread
From: sergiodj+buildbot @ 2016-09-01  8:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 305a161d11c4b5801a0e135fec5d77f3d64f121f ***

Author: Antoine Tremblay <antoine.tremblay@ericsson.com>
Branch: gdb-7.12-branch
Commit: 305a161d11c4b5801a0e135fec5d77f3d64f121f

Fix lwp_suspend/unsuspend imbalance in linux_wait_1

This patch fixes imbalanced lwp_suspend/unsuspend calls caused by the
premature choosing of another event for fairness.

select_event_lwp would switch the event before a call to
unsuspend_all_lwps, thus it would be called with the wrong event.

This caused an assertion failure: unsuspend LWP xx, suspended=-1 when
testing  gdb.threads/non-stop-fair-events.exp with ARM range stepping in
GDBServer.

This patch moves the switch of event after the unsuspend/unstop calls.

No regressions, tested on ubuntu 14.04 ARMv7 and x86.
With gdbserver-native.

gdb/gdbserver/ChangeLog:

	* linux-low.c (linux_wait_1): Move event switch after unsuspend_lwps.


^ permalink raw reply	[flat|nested] 36+ messages in thread
* [binutils-gdb/gdb-7.12-branch] gdb.base/default.exp regression
@ 2016-08-30 12:43 sergiodj+buildbot
  2016-08-30 16:11 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
  0 siblings, 1 reply; 36+ messages in thread
From: sergiodj+buildbot @ 2016-08-30 12:43 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b82dedc7696daab1b7a4a28530f3eb94c6b4e62d ***

Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Branch: gdb-7.12-branch
Commit: b82dedc7696daab1b7a4a28530f3eb94c6b4e62d

gdb.base/default.exp regression

tty^M
(gdb) FAIL: gdb.base/default.exp: tty

gdb/testsuite/ChangeLog
2016-08-29  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* gdb.base/default.exp (tty): Remove.


^ permalink raw reply	[flat|nested] 36+ messages in thread
* [binutils-gdb/gdb-7.12-branch] xtensa: Avoid designated inits, for C++ compliance
@ 2016-08-26 19:14 sergiodj+buildbot
  2016-08-27  1:37 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
  0 siblings, 1 reply; 36+ messages in thread
From: sergiodj+buildbot @ 2016-08-26 19:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e529eb722d213875230dbcd0c856390f840f1863 ***

Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: gdb-7.12-branch
Commit: e529eb722d213875230dbcd0c856390f840f1863

xtensa: Avoid designated inits, for C++ compliance

C++ does not officially support designators in initializer lists.  Thus
some compilers may issue errors when encountering them.  Modern versions
of GCC seem to allow them by default, as a GCC extension, even though
the GCC documentation explicitly states otherwise: "[...] This extension
is not implemented in GNU C++."  But some older GCC versions (like
4.4.7) did indeed emit an error instead, like this:

  .../gdb/xtensa-config.c:219: error: expected primary-expression before
			       . token

This patch removes the only such instance I've seen when building with
'--enable-targets=all'.

gdb/ChangeLog:

	* xtensa-tdep.h (XTENSA_GDBARCH_TDEP_INSTANTIATE): Replace
	designated initializer list by plain initializer list, for C++
	compliance.


^ permalink raw reply	[flat|nested] 36+ messages in thread
* [binutils-gdb/gdb-7.12-branch] Allow resetting an empty inferior-tty
@ 2016-08-24 22:31 sergiodj+buildbot
  2016-08-25  3:10 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
  0 siblings, 1 reply; 36+ messages in thread
From: sergiodj+buildbot @ 2016-08-24 22:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2b3eaab2c3eadd12bbd56499c00dca8cefb81552 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: gdb-7.12-branch
Commit: 2b3eaab2c3eadd12bbd56499c00dca8cefb81552

Allow resetting an empty inferior-tty

This patch allows the user to set the inferior-tty to "empty", in order
to come back to the default behaviour of using the same tty as gdb is
using.

This is already supported in MI (and tested in gdb.mi/mi-basics.exp).

I added a new test, set-inferior-tty.exp, where I test only the setting
and unsetting of the parameter.  It would be nice to actually test that
the inferior output properly goes to the separate tty, but that will be
for another day.

gdb/ChangeLog:

	* infcmd.c (set_inferior_io_terminal): Set inferior terminal to
	NULL if terminal_name is an empty string.
	(_initialize_infcmd): Make the argument of "set inferior-tty"
	optional, mention it in the help doc.

gdb/doc/ChangeLog:

	* gdb.texinfo (Input/Output): Mention possibility to unset
	inferior-tty.

gdb/testsuite/ChangeLog:

	* gdb.base/set-inferior-tty.exp: New file.
	* gdb.base/set-inferior-tty.c: New file.


^ permalink raw reply	[flat|nested] 36+ messages in thread
* [binutils-gdb/gdb-7.12-branch] Fix PR20494 - User input stops being echoed in CLI
@ 2016-08-23 19:14 sergiodj+buildbot
  2016-08-23 23:25 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
  0 siblings, 1 reply; 36+ messages in thread
From: sergiodj+buildbot @ 2016-08-23 19:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e24e88f9de8e4d34c052864c42aed10778f0174a ***

Author: Pedro Alves <palves@redhat.com>
Branch: gdb-7.12-branch
Commit: e24e88f9de8e4d34c052864c42aed10778f0174a

Fix PR20494 - User input stops being echoed in CLI

This patch fixes a problem that problem triggers if you start an
inferior, e.g., with the "start" command, in a UI created with the
new-ui command, and then run a foreground execution command in the
main UI.  Once the program stops for the latter command, typing in the
main UI no longer echoes back to the user.

The problem revolves around this:

- gdb_has_a_terminal computes its result lazily, on first call.

  that is what saves gdb's initial main UI terminal state (the UI
  associated with stdin):

          our_terminal_info.ttystate = serial_get_tty_state (stdin_serial);

  This is the state that target_terminal_ours() restores.

- In this scenario, the gdb_has_a_terminal function happens to be
  first ever called from within the target_terminal_init call in
  startup_inferior:

      (top-gdb) bt
      #0  gdb_has_a_terminal () at src/gdb/inflow.c:157
      #1  0x000000000079db22 in child_terminal_init_with_pgrp () at src/gdb/inflow.c:217
       [...]
      #4  0x000000000065bacb in target_terminal_init () at src/gdb/target.c:456
      #5  0x00000000004676d2 in startup_inferior () at src/gdb/fork-child.c:531
       [...]
      #7  0x000000000046b168 in linux_nat_create_inferior () at src/gdb/linux-nat.c:1112
       [...]
      #9  0x00000000005f20c9 in start_command (args=0x0, from_tty=1) at src/gdb/infcmd.c:657

If the command to start the inferior is issued on the main UI, then
readline will have deprepped the terminal when we reach the above, and
the problem doesn't appear.

If however the command is issued on a non-main UI, then when we reach
that gdb_has_a_terminal call, the main UI's terminal state is still
set to whatever readline has sets it to in rl_prep_terminal, which
happens to have echo disabled.  Later, when the following synchronous
execution command finishes, we'll call target_terminal_ours to restore
gdb's the main UI's terminal settings, and that restores the terminal
state with echo disabled...

Conceptually, the fix is to move the gdb_has_a_terminal call earlier,
to someplace during GDB initialization, before readline/ncurses have
had a chance to change terminal settings.  Turns out that
"set_initial_gdb_ttystate" is exactly such a place.

I say conceptually, because the fix actually inlines the
gdb_has_a_terminal part that saves the terminal state in
set_initial_gdb_ttystate and then simplifies gdb_has_a_terminal, since
there's no point in making gdb_has_a_terminal do lazy computation.

gdb/ChangeLog:
2016-08-23  Pedro Alves  <palves@redhat.com>

	PR gdb/20494
	* inflow.c (our_terminal_info, initial_gdb_ttystate): Update
	comments.
	(enum gdb_has_a_terminal_flag_enum, gdb_has_a_terminal_flag):
	Delete.
	(set_initial_gdb_ttystate): Record our_terminal_info here too,
	instead of ...
	(gdb_has_a_terminal): ... here.  Reimplement in terms of
	initial_gdb_ttystate.  Make static.
	* terminal.h (gdb_has_a_terminal): Delete declaration.
	(set_initial_gdb_ttystate): Add comment.
	* top.c (show_interactive_mode): Use input_interactive_p instead
	of gdb_has_a_terminal.

gdb/testsuite/ChangeLog:
2016-08-23  Pedro Alves  <palves@redhat.com>

	PR gdb/20494
	* gdb.base/new-ui-echo.c: New file.
	* gdb.base/new-ui-echo.exp: New file.


^ permalink raw reply	[flat|nested] 36+ messages in thread
* [binutils-gdb/gdb-7.12-branch] Fix signals-state-child.exp in remote testing
@ 2016-08-23 17:02 sergiodj+buildbot
  2016-08-23 18:18 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
  0 siblings, 1 reply; 36+ messages in thread
From: sergiodj+buildbot @ 2016-08-23 17:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 22dc25f77bdff5954af60abd7a098ea6e76ad1f9 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: gdb-7.12-branch
Commit: 22dc25f77bdff5954af60abd7a098ea6e76ad1f9

Fix signals-state-child.exp in remote testing

Remote testing isn't considered in signals-state-child.exp, so the it
fails like

shell diff -s /scratch/yao/gdb/build-git/aarch64-linux-gnu/gdb/testsuite/outputs/gdb.base/signals-state-child/standalone.txt /scratch/yao/gdb/build-git/aarch64-linux-gnu/gdb/testsuite/outputs/gdb.base/signals-state-child/gdb.txt^M
diff: /scratch/yao/gdb/build-git/aarch64-linux-gnu/gdb/testsuite/outputs/gdb.base/signals-state-child/standalone.txt: No such file or directory^M
(gdb) FAIL: gdb.base/signals-state-child.exp: signals states are identical

This patch is to fix it.

gdb/testsuite:

2016-08-23  Yao Qi  <yao.qi@linaro.org>

	* gdb.base/signals-state-child.exp: Set variables gdb_txt and
	standalone_txt.  Delete gdb_txt and standalone_txt on host
	and target.  Spawn the binary on target.  Copy files from
	target to host.


^ permalink raw reply	[flat|nested] 36+ messages in thread
* [binutils-gdb/gdb-7.12-branch] Regenerate some target description files
@ 2016-08-09 11:33 sergiodj+buildbot
  2016-08-11  8:52 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
  0 siblings, 1 reply; 36+ messages in thread
From: sergiodj+buildbot @ 2016-08-09 11:33 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d3437d69a3d3fcc28ddb1c17cf2938a422e26222 ***

Author: Pedro Alves <palves@redhat.com>
Branch: gdb-7.12-branch
Commit: d3437d69a3d3fcc28ddb1c17cf2938a422e26222

Regenerate some target description files

I regenerated all target description .c files from scratch, and got
this spurious diff.

It's a simple mid-air collision - these files were clearly generated
before commit 73b4f516a037 ("maint_print_c_tdesc_cmd: Use type for
TYPE_CODE_FLAGS instead of field_type."), which did the global
s/field_type/type/, and pushed to master afterwards.

gdb/features/ChangeLog:
2016-08-08  Pedro Alves  <palves@redhat.com>

	* features/i386/amd64-avx-mpx-linux.c: Regenerate.
	* features/i386/amd64-avx-mpx.c: Regenerate.
	* features/i386/i386-avx-mpx-linux.c: Regenerate.
	* features/i386/i386-avx-mpx.c: Regenerate.


^ permalink raw reply	[flat|nested] 36+ messages in thread
* [binutils-gdb/gdb-7.12-branch] Quiet ptrace error ESRCH in regsets_fetch_inferior_registers
@ 2016-08-04 11:11 sergiodj+buildbot
  2016-08-10 18:57 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
  0 siblings, 1 reply; 36+ messages in thread
From: sergiodj+buildbot @ 2016-08-04 11:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 367ed8910ee791720f99a28ad0320f430bd910d9 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: gdb-7.12-branch
Commit: 367ed8910ee791720f99a28ad0320f430bd910d9

Quiet ptrace error ESRCH in regsets_fetch_inferior_registers

When I run process-dies-while-detaching.exp with GDBserver, I see many
warnings printed by GDBserver,

ptrace(regsets_fetch_inferior_registers) PID=26183: No such process
ptrace(regsets_fetch_inferior_registers) PID=26183: No such process
ptrace(regsets_fetch_inferior_registers) PID=26184: No such process
ptrace(regsets_fetch_inferior_registers) PID=26184: No such process

regsets_fetch_inferior_registers is called when GDBserver resumes each
lwp.

 #2  0x0000000000428260 in regsets_fetch_inferior_registers (regsets_info=0x4690d0 <aarch64_regsets_info>, regcache=0x31832020)
    at /home/yao/SourceCode/gnu/gdb/git/gdb/gdbserver/linux-low.c:5412
 #3  0x00000000004070e8 in get_thread_regcache (thread=0x31832940, fetch=fetch@entry=1) at /home/yao/SourceCode/gnu/gdb/git/gdb/gdbserver/regcache.c:58
 #4  0x0000000000429c40 in linux_resume_one_lwp_throw (info=<optimized out>, signal=0, step=0, lwp=0x31832830)
    at /home/yao/SourceCode/gnu/gdb/git/gdb/gdbserver/linux-low.c:4463
 #5  linux_resume_one_lwp (lwp=0x31832830, step=<optimized out>, signal=<optimized out>, info=<optimized out>)
    at /home/yao/SourceCode/gnu/gdb/git/gdb/gdbserver/linux-low.c:4573

The is the case that threads are disappeared when GDB/GDBserver resumes
them.  We check errno for ESRCH, and don't print error messages, like
what we are doing in regsets_store_inferior_registers.

gdb/gdbserver:

2016-08-04  Yao Qi  <yao.qi@linaro.org>

	* linux-low.c (regsets_fetch_inferior_registers): Check
	errno is ESRCH or not.


^ permalink raw reply	[flat|nested] 36+ messages in thread
* [binutils-gdb/gdb-7.12-branch] Avoid potential memory leak in find_frame_funname
@ 2016-08-03 19:10 sergiodj+buildbot
  2016-08-10 18:52 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
  0 siblings, 1 reply; 36+ messages in thread
From: sergiodj+buildbot @ 2016-08-03 19:10 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d2ed2edaf76fc10505214290d04c3cf312acfbca ***

Author: Tom Tromey <tom@tromey.com>
Branch: gdb-7.12-branch
Commit: d2ed2edaf76fc10505214290d04c3cf312acfbca

Avoid potential memory leak in find_frame_funname

The PR 18565 thread pointed out that, if cp_remove_params can throw
(we aren't quite sure), then find_frame_funname could leak some
memory.  This patch avoids any potential issue by rearranging some
code in find_frame_funname.

Built and regtested on x86-64 Fedora 24.

2016-08-03  Tom Tromey  <tom@tromey.com>

	* stack.c (find_frame_funname): Avoid any possible leak in case
	cp_remove_params can throw.


^ permalink raw reply	[flat|nested] 36+ messages in thread
end of thread, other threads:[~2017-01-21 14:17 UTC | newest]

Thread overview: 36+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-21 13:28 [binutils-gdb/gdb-7.12-branch] ppc: Fix record support of Store String Word instructions sergiodj+buildbot
2016-09-21 13:18 ` Failures on Fedora-x86_64-native-gdbserver-m32, branch gdb-7.12-branch sergiodj+buildbot
2016-09-21 13:28 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " sergiodj+buildbot
2016-09-21 13:28 ` Failures on Debian-i686, " sergiodj+buildbot
2016-09-21 13:53 ` Failures on Fedora-i686, " sergiodj+buildbot
2016-09-21 14:13 ` Failures on Fedora-x86_64-m32, " sergiodj+buildbot
2016-09-21 14:18 ` Failures on Fedora-x86_64-cc-with-index, " sergiodj+buildbot
2016-09-21 14:19 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, " sergiodj+buildbot
2016-09-21 14:25 ` Failures on Debian-s390x-m64, " sergiodj+buildbot
2016-09-21 14:39 ` Failures on Fedora-ppc64be-native-gdbserver-m64, " sergiodj+buildbot
2016-09-21 14:45 ` Failures on Fedora-x86_64-m64, " sergiodj+buildbot
2016-09-21 15:00 ` Failures on Debian-i686-native-extended-gdbserver, " sergiodj+buildbot
2016-09-21 15:07 ` Failures on Fedora-s390x-m64, " sergiodj+buildbot
2016-09-21 15:13 ` Failures on Debian-x86_64-native-extended-gdbserver-m64, " sergiodj+buildbot
2016-09-21 15:25 ` Failures on Fedora-ppc64be-native-extended-gdbserver-m64, " sergiodj+buildbot
2016-09-21 15:44 ` Failures on Fedora-ppc64le-native-extended-gdbserver-m64, " sergiodj+buildbot
  -- strict thread matches above, loose matches on Subject: below --
2017-01-21 14:06 [binutils-gdb/gdb-7.12-branch] Set GDB version number to 7.12.1 sergiodj+buildbot
2017-01-21 14:17 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
2017-01-21  2:29 [binutils-gdb/gdb-7.12-branch] Fix python-interactive with Python 3.6 sergiodj+buildbot
2017-01-21  3:05 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
2016-12-20 20:16 [binutils-gdb/gdb-7.12-branch] gdb: Fix C and C++03 builds sergiodj+buildbot
2016-12-20 20:30 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
2016-11-11  7:48 [binutils-gdb/gdb-7.12-branch] sim: mips: fix dv-tx3904cpu build error sergiodj+buildbot
2016-11-11  8:15 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
2016-10-27  2:04 [binutils-gdb/gdb-7.12-branch] Fix gdb C++ compilation on Solaris (PR build/20712) sergiodj+buildbot
2016-10-27  1:31 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
2016-10-12 12:26 [binutils-gdb/gdb-7.12-branch] [AArch64] Track FP registers in prologue analyzer sergiodj+buildbot
2016-10-12 13:18 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
2016-10-07 18:04 [binutils-gdb/gdb-7.12-branch] Bump GDB version number to 7.12.0.DATE-git sergiodj+buildbot
2016-10-07 18:55 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
2016-10-06 19:21 [binutils-gdb/gdb-7.12-branch] testsuite: solib-disc: Use `standard_output_file' sergiodj+buildbot
2016-10-06 21:25 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
2016-10-03 23:07 [binutils-gdb/gdb-7.12-branch] Introduce cleanup to restore current_uiout sergiodj+buildbot
2016-10-04  0:04 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
2016-09-27 12:20 [binutils-gdb/gdb-7.12-branch] Detect the magic address of EXC_RETURN in ARM coretx-m profile sergiodj+buildbot
2016-09-27 15:34 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
2016-09-07  2:09 [binutils-gdb/gdb-7.12-branch] Introduce make_cleanup_restore_current_ui sergiodj+buildbot
2016-09-07  8:57 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
2016-09-01  8:54 [binutils-gdb/gdb-7.12-branch] Fix lwp_suspend/unsuspend imbalance in linux_wait_1 sergiodj+buildbot
2016-09-01 19:20 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
2016-08-30 12:43 [binutils-gdb/gdb-7.12-branch] gdb.base/default.exp regression sergiodj+buildbot
2016-08-30 16:11 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
2016-08-26 19:14 [binutils-gdb/gdb-7.12-branch] xtensa: Avoid designated inits, for C++ compliance sergiodj+buildbot
2016-08-27  1:37 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
2016-08-24 22:31 [binutils-gdb/gdb-7.12-branch] Allow resetting an empty inferior-tty sergiodj+buildbot
2016-08-25  3:10 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
2016-08-23 19:14 [binutils-gdb/gdb-7.12-branch] Fix PR20494 - User input stops being echoed in CLI sergiodj+buildbot
2016-08-23 23:25 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
2016-08-23 17:02 [binutils-gdb/gdb-7.12-branch] Fix signals-state-child.exp in remote testing sergiodj+buildbot
2016-08-23 18:18 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
2016-08-09 11:33 [binutils-gdb/gdb-7.12-branch] Regenerate some target description files sergiodj+buildbot
2016-08-11  8:52 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
2016-08-04 11:11 [binutils-gdb/gdb-7.12-branch] Quiet ptrace error ESRCH in regsets_fetch_inferior_registers sergiodj+buildbot
2016-08-10 18:57 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot
2016-08-03 19:10 [binutils-gdb/gdb-7.12-branch] Avoid potential memory leak in find_frame_funname sergiodj+buildbot
2016-08-10 18:52 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-7.12-branch sergiodj+buildbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).