public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Remove lwp -> pid conversion in linux_nat_xfer_partial
@ 2017-03-25 4:31 sergiodj+buildbot
2017-03-25 4:30 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch master sergiodj+buildbot
` (11 more replies)
0 siblings, 12 replies; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-03-25 4:31 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b67aeab02c05fdd654f132a550dd4f196cb1f6d3 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: b67aeab02c05fdd654f132a550dd4f196cb1f6d3
Remove lwp -> pid conversion in linux_nat_xfer_partial
The linux_nat_xfer_partial does a conversion of inferior_ptid: if it's
an LWP (ptid::lwp != 0), it builds a new ptid with the lwp as
the pid and assigns that temporarily to inferior_ptid. For example, if
inferior_ptid is:
{ .pid = 1234, .lwp = 1235 }
it will assign this to inferior_ptid for the duration of the call:
{ .pid = 1235, .lwp = 0 }
Instead of doing this, this patch teaches the inf-ptrace implementation
of xfer_partial to deal with ptids representing lwps by using
get_ptrace_pid.
Also, in linux_proc_xfer_spu and linux_proc_xfer_partial, we use ptid_get_lwp
instead of ptid_get_pid. While not strictly necessary, since the content of
/proc/<pid> and /proc/<lwp> should be the same, it's a bit safer, because:
- some files under /proc/<pid>/ may not work if the <pid> thread is
running, just like ptrace requires a stopped thread. The current
thread's lwp id is more likely to be in the necessary state (stopped).
- if the leader (<pid>) had exited and is thus now zombie, then several
files under "/proc/<pid>" won't work, while they will if you use
"/proc/<lwp>".
The testsuite found no regression on native amd64 linux.
gdb/ChangeLog:
* inf-ptrace.c (inf_ptrace_xfer_partial): Get pid from ptid
using get_ptrace_pid.
* linux-nat.c (linux_nat_xfer_partial): Don't set/restore
inferior_ptid.
(linux_proc_xfer_partial, linux_proc_xfer_spu): Use lwp of
inferior_ptid instead of pid.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* Failures on Ubuntu-AArch64-native-gdbserver-m64, branch master
2017-03-25 4:31 [binutils-gdb] Remove lwp -> pid conversion in linux_nat_xfer_partial sergiodj+buildbot
@ 2017-03-25 4:30 ` sergiodj+buildbot
2017-03-25 4:59 ` Failures on Ubuntu-AArch64-m64, " sergiodj+buildbot
` (10 subsequent siblings)
11 siblings, 0 replies; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-03-25 4:30 UTC (permalink / raw)
To: gdb-testers
Buildslave:
ubuntu-aarch64-1
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch64-native-gdbserver-m64/builds/1621>
Commit(s) tested:
b67aeab02c05fdd654f132a550dd4f196cb1f6d3
Author(s) (in the same order as the commits):
Simon Marchi <simon.marchi@polymtl.ca>
Subject:
Remove lwp -> pid conversion in linux_nat_xfer_partial
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Ubuntu-AArch64-native-gdbserver-m64/b6/b67aeab02c05fdd654f132a550dd4f196cb1f6d3/>
*** Diff to previous build ***
============================
PASS -> FAIL: gdb.server/ext-run.exp: get process list
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=17: wait for stops
============================
*** Complete list of XFAILs for this builder ***
To obtain the list of XFAIL tests for this builder, go to:
<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch64-native-gdbserver-m64/xfails/master/xfail;hb=84d1683>
You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:
<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch64-native-gdbserver-m64/xfails/master/xfail.table;hb=84d1683>
^ permalink raw reply [flat|nested] 2083+ messages in thread
* Failures on Ubuntu-AArch64-m64, branch master
2017-03-25 4:31 [binutils-gdb] Remove lwp -> pid conversion in linux_nat_xfer_partial sergiodj+buildbot
2017-03-25 4:30 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch master sergiodj+buildbot
@ 2017-03-25 4:59 ` sergiodj+buildbot
2017-03-25 18:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, " sergiodj+buildbot
` (9 subsequent siblings)
11 siblings, 0 replies; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-03-25 4:59 UTC (permalink / raw)
To: gdb-testers
Buildslave:
ubuntu-aarch64-1
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch64-m64/builds/1621>
Commit(s) tested:
b67aeab02c05fdd654f132a550dd4f196cb1f6d3
Author(s) (in the same order as the commits):
Simon Marchi <simon.marchi@polymtl.ca>
Subject:
Remove lwp -> pid conversion in linux_nat_xfer_partial
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Ubuntu-AArch64-m64/b6/b67aeab02c05fdd654f132a550dd4f196cb1f6d3/>
*** Diff to previous build ***
============================
PASS -> FAIL: gdb.threads/thread-specific-bp.exp: non-stop: continue to end
============================
*** Complete list of XFAILs for this builder ***
To obtain the list of XFAIL tests for this builder, go to:
<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch64-m64/xfails/master/xfail;hb=abee8a4>
You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:
<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch64-m64/xfails/master/xfail.table;hb=abee8a4>
^ permalink raw reply [flat|nested] 2083+ messages in thread
* Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master
2017-03-25 4:31 [binutils-gdb] Remove lwp -> pid conversion in linux_nat_xfer_partial sergiodj+buildbot
2017-03-25 4:30 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch master sergiodj+buildbot
2017-03-25 4:59 ` Failures on Ubuntu-AArch64-m64, " sergiodj+buildbot
@ 2017-03-25 18:26 ` sergiodj+buildbot
2017-03-25 18:49 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, " sergiodj+buildbot
` (8 subsequent siblings)
11 siblings, 0 replies; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-03-25 18:26 UTC (permalink / raw)
To: gdb-testers
Buildslave:
ubuntu-trusty-aarch32-1
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-native-gdbserver-m32/builds/246>
Commit(s) tested:
b67aeab02c05fdd654f132a550dd4f196cb1f6d3
Author(s) (in the same order as the commits):
Simon Marchi <simon.marchi@polymtl.ca>
Subject:
Remove lwp -> pid conversion in linux_nat_xfer_partial
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-native-gdbserver-m32/b6/b67aeab02c05fdd654f132a550dd4f196cb1f6d3/>
*** Diff to previous build ***
============================
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=5: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=7: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=8: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=9: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=12: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=16: wait for stops
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=0: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=0: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=0: next to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=0: next does not change thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=0: current thread advanced - unlocked
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: set scheduler-locking off
new FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: setting breakpoint at 80 if arg != 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: continue to breakpoint: return to loop
new FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: delete all breakpoints in delete_breakpoints
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: print call_function = 1
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: next to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: other threads ran - unlocked
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: set scheduler-locking off
new FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: setting breakpoint at 80 if arg != 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: continue to breakpoint: return to loop
new FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: delete all breakpoints in delete_breakpoints
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: set scheduler-locking step
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: print call_function = 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: step to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: set scheduler-locking off
new FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: setting breakpoint at 80 if arg != 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: continue to breakpoint: return to loop
new FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: delete all breakpoints in delete_breakpoints
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: set scheduler-locking step
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: print call_function = 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: next to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: set scheduler-locking off
new FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: setting breakpoint at 80 if arg != 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: continue to breakpoint: return to loop
new FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: delete all breakpoints in delete_breakpoints
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: set scheduler-locking step
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: print call_function = 1
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: next to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: set scheduler-locking off
new FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: setting breakpoint at 80 if arg != 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: continue to breakpoint: return to loop
new FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: delete all breakpoints in delete_breakpoints
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: set scheduler-locking on
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: print call_function = 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: step to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: set scheduler-locking off
new FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: setting breakpoint at 80 if arg != 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: continue to breakpoint: return to loop
new FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: delete all breakpoints in delete_breakpoints
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: set scheduler-locking on
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: print call_function = 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: next to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: set scheduler-locking off
new FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: setting breakpoint at 80 if arg != 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: continue to breakpoint: return to loop
new FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: delete all breakpoints in delete_breakpoints
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: set scheduler-locking on
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: print call_function = 1
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: next to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: find current thread
============================
*** Complete list of XFAILs for this builder ***
FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST. PLEASE CONTACT THE BUILDBOT ADMIN.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master
2017-03-25 4:31 [binutils-gdb] Remove lwp -> pid conversion in linux_nat_xfer_partial sergiodj+buildbot
` (2 preceding siblings ...)
2017-03-25 18:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, " sergiodj+buildbot
@ 2017-03-25 18:49 ` sergiodj+buildbot
2017-03-25 19:12 ` Failures on Ubuntu-AArch32-m32, " sergiodj+buildbot
` (7 subsequent siblings)
11 siblings, 0 replies; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-03-25 18:49 UTC (permalink / raw)
To: gdb-testers
Buildslave:
ubuntu-trusty-aarch32-1
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-native-extended-gdbserver-m32/builds/246>
Commit(s) tested:
b67aeab02c05fdd654f132a550dd4f196cb1f6d3
Author(s) (in the same order as the commits):
Simon Marchi <simon.marchi@polymtl.ca>
Subject:
Remove lwp -> pid conversion in linux_nat_xfer_partial
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-native-extended-gdbserver-m32/b6/b67aeab02c05fdd654f132a550dd4f196cb1f6d3/>
*** Diff to previous build ***
============================
PASS -> FAIL: gdb.base/step-over-syscall.exp: clone: displaced=off: single step over clone
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=5: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=6: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=10: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=18: wait for stops
============================
*** Complete list of XFAILs for this builder ***
FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST. PLEASE CONTACT THE BUILDBOT ADMIN.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* Failures on Ubuntu-AArch32-m32, branch master
2017-03-25 4:31 [binutils-gdb] Remove lwp -> pid conversion in linux_nat_xfer_partial sergiodj+buildbot
` (3 preceding siblings ...)
2017-03-25 18:49 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, " sergiodj+buildbot
@ 2017-03-25 19:12 ` sergiodj+buildbot
2017-06-04 23:27 ` Failures on Fedora-ppc64le-native-gdbserver-m64, " sergiodj+buildbot
` (6 subsequent siblings)
11 siblings, 0 replies; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-03-25 19:12 UTC (permalink / raw)
To: gdb-testers
Buildslave:
ubuntu-trusty-aarch32-1
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-m32/builds/246>
Commit(s) tested:
b67aeab02c05fdd654f132a550dd4f196cb1f6d3
Author(s) (in the same order as the commits):
Simon Marchi <simon.marchi@polymtl.ca>
Subject:
Remove lwp -> pid conversion in linux_nat_xfer_partial
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-m32/b6/b67aeab02c05fdd654f132a550dd4f196cb1f6d3/>
*** Diff to previous build ***
============================
PASS -> FAIL: gdb.mi/mi-var-rtti.exp: run to mi-var-rtti.cc:148
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=2: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=3: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=4: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=6: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=10: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=13: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=17: wait for stops
============================
*** Complete list of XFAILs for this builder ***
FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST. PLEASE CONTACT THE BUILDBOT ADMIN.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* Failures on Fedora-ppc64le-native-gdbserver-m64, branch master
2017-03-25 4:31 [binutils-gdb] Remove lwp -> pid conversion in linux_nat_xfer_partial sergiodj+buildbot
` (4 preceding siblings ...)
2017-03-25 19:12 ` Failures on Ubuntu-AArch32-m32, " sergiodj+buildbot
@ 2017-06-04 23:27 ` sergiodj+buildbot
2017-06-05 11:14 ` Failures on Fedora-ppc64le-native-extended-gdbserver-m64, " sergiodj+buildbot
` (5 subsequent siblings)
11 siblings, 0 replies; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-06-04 23:27 UTC (permalink / raw)
To: gdb-testers
Buildslave:
fedora-ppc64le-1
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Fedora-ppc64le-native-gdbserver-m64/builds/5195>
Commit(s) tested:
b67aeab02c05fdd654f132a550dd4f196cb1f6d3
Author(s) (in the same order as the commits):
Simon Marchi <simon.marchi@polymtl.ca>
Subject:
Remove lwp -> pid conversion in linux_nat_xfer_partial
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Fedora-ppc64le-native-gdbserver-m64/b6/b67aeab02c05fdd654f132a550dd4f196cb1f6d3/>
^ permalink raw reply [flat|nested] 2083+ messages in thread
* Failures on Fedora-ppc64le-native-extended-gdbserver-m64, branch master
2017-03-25 4:31 [binutils-gdb] Remove lwp -> pid conversion in linux_nat_xfer_partial sergiodj+buildbot
` (5 preceding siblings ...)
2017-06-04 23:27 ` Failures on Fedora-ppc64le-native-gdbserver-m64, " sergiodj+buildbot
@ 2017-06-05 11:14 ` sergiodj+buildbot
2017-06-24 9:04 ` Failures on Debian-s390x-native-gdbserver-m64, " sergiodj+buildbot
` (4 subsequent siblings)
11 siblings, 0 replies; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-06-05 11:14 UTC (permalink / raw)
To: gdb-testers
Buildslave:
fedora-ppc64le-1
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Fedora-ppc64le-native-extended-gdbserver-m64/builds/5205>
Commit(s) tested:
b67aeab02c05fdd654f132a550dd4f196cb1f6d3
Author(s) (in the same order as the commits):
Simon Marchi <simon.marchi@polymtl.ca>
Subject:
Remove lwp -> pid conversion in linux_nat_xfer_partial
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Fedora-ppc64le-native-extended-gdbserver-m64/b6/b67aeab02c05fdd654f132a550dd4f196cb1f6d3/>
^ permalink raw reply [flat|nested] 2083+ messages in thread
* Failures on Debian-s390x-native-gdbserver-m64, branch master
2017-03-25 4:31 [binutils-gdb] Remove lwp -> pid conversion in linux_nat_xfer_partial sergiodj+buildbot
` (6 preceding siblings ...)
2017-06-05 11:14 ` Failures on Fedora-ppc64le-native-extended-gdbserver-m64, " sergiodj+buildbot
@ 2017-06-24 9:04 ` sergiodj+buildbot
2017-06-24 9:10 ` Failures on Debian-s390x-native-extended-gdbserver-m64, " sergiodj+buildbot
` (3 subsequent siblings)
11 siblings, 0 replies; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-06-24 9:04 UTC (permalink / raw)
To: gdb-testers
Buildslave:
debian-jessie-s390x-1
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Debian-s390x-native-gdbserver-m64/builds/4119>
Commit(s) tested:
b67aeab02c05fdd654f132a550dd4f196cb1f6d3
Author(s) (in the same order as the commits):
Simon Marchi <simon.marchi@polymtl.ca>
Subject:
Remove lwp -> pid conversion in linux_nat_xfer_partial
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Debian-s390x-native-gdbserver-m64/b6/b67aeab02c05fdd654f132a550dd4f196cb1f6d3/>
^ permalink raw reply [flat|nested] 2083+ messages in thread
* Failures on Debian-s390x-native-extended-gdbserver-m64, branch master
2017-03-25 4:31 [binutils-gdb] Remove lwp -> pid conversion in linux_nat_xfer_partial sergiodj+buildbot
` (7 preceding siblings ...)
2017-06-24 9:04 ` Failures on Debian-s390x-native-gdbserver-m64, " sergiodj+buildbot
@ 2017-06-24 9:10 ` sergiodj+buildbot
2017-08-20 11:53 ` Failures on Fedora-ppc64be-native-extended-gdbserver-m64, " sergiodj+buildbot
` (2 subsequent siblings)
11 siblings, 0 replies; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-06-24 9:10 UTC (permalink / raw)
To: gdb-testers
Buildslave:
debian-jessie-s390x-1
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Debian-s390x-native-extended-gdbserver-m64/builds/4126>
Commit(s) tested:
b67aeab02c05fdd654f132a550dd4f196cb1f6d3
Author(s) (in the same order as the commits):
Simon Marchi <simon.marchi@polymtl.ca>
Subject:
Remove lwp -> pid conversion in linux_nat_xfer_partial
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Debian-s390x-native-extended-gdbserver-m64/b6/b67aeab02c05fdd654f132a550dd4f196cb1f6d3/>
^ permalink raw reply [flat|nested] 2083+ messages in thread
* Failures on Fedora-ppc64be-native-extended-gdbserver-m64, branch master
2017-03-25 4:31 [binutils-gdb] Remove lwp -> pid conversion in linux_nat_xfer_partial sergiodj+buildbot
` (8 preceding siblings ...)
2017-06-24 9:10 ` Failures on Debian-s390x-native-extended-gdbserver-m64, " sergiodj+buildbot
@ 2017-08-20 11:53 ` sergiodj+buildbot
2017-08-20 21:49 ` Failures on Fedora-ppc64be-m64, " sergiodj+buildbot
2017-08-20 22:06 ` Failures on Fedora-ppc64be-native-gdbserver-m64, " sergiodj+buildbot
11 siblings, 0 replies; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-08-20 11:53 UTC (permalink / raw)
To: gdb-testers
Buildslave:
fedora-ppc64be-1
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Fedora-ppc64be-native-extended-gdbserver-m64/builds/5303>
Commit(s) tested:
b67aeab02c05fdd654f132a550dd4f196cb1f6d3
Author(s) (in the same order as the commits):
Simon Marchi <simon.marchi@polymtl.ca>
Subject:
Remove lwp -> pid conversion in linux_nat_xfer_partial
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Fedora-ppc64be-native-extended-gdbserver-m64/b6/b67aeab02c05fdd654f132a550dd4f196cb1f6d3/>
^ permalink raw reply [flat|nested] 2083+ messages in thread
* Failures on Fedora-ppc64be-m64, branch master
2017-03-25 4:31 [binutils-gdb] Remove lwp -> pid conversion in linux_nat_xfer_partial sergiodj+buildbot
` (9 preceding siblings ...)
2017-08-20 11:53 ` Failures on Fedora-ppc64be-native-extended-gdbserver-m64, " sergiodj+buildbot
@ 2017-08-20 21:49 ` sergiodj+buildbot
2017-08-20 22:06 ` Failures on Fedora-ppc64be-native-gdbserver-m64, " sergiodj+buildbot
11 siblings, 0 replies; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-08-20 21:49 UTC (permalink / raw)
To: gdb-testers
Buildslave:
fedora-ppc64be-1
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Fedora-ppc64be-m64/builds/5399>
Commit(s) tested:
b67aeab02c05fdd654f132a550dd4f196cb1f6d3
Author(s) (in the same order as the commits):
Simon Marchi <simon.marchi@polymtl.ca>
Subject:
Remove lwp -> pid conversion in linux_nat_xfer_partial
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Fedora-ppc64be-m64/b6/b67aeab02c05fdd654f132a550dd4f196cb1f6d3/>
*** Diff to previous build ***
============================
PASS -> FAIL: gdb.base/paginate-bg-execution.exp: cancel with ctrl-c: set height unlimited
============================
*** Complete list of XFAILs for this builder ***
To obtain the list of XFAIL tests for this builder, go to:
<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-ppc64be-m64/xfails/master/xfail;hb=5899af4>
You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:
<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-ppc64be-m64/xfails/master/xfail.table;hb=5899af4>
^ permalink raw reply [flat|nested] 2083+ messages in thread
* Failures on Fedora-ppc64be-native-gdbserver-m64, branch master
2017-03-25 4:31 [binutils-gdb] Remove lwp -> pid conversion in linux_nat_xfer_partial sergiodj+buildbot
` (10 preceding siblings ...)
2017-08-20 21:49 ` Failures on Fedora-ppc64be-m64, " sergiodj+buildbot
@ 2017-08-20 22:06 ` sergiodj+buildbot
11 siblings, 0 replies; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-08-20 22:06 UTC (permalink / raw)
To: gdb-testers
Buildslave:
fedora-ppc64be-1
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Fedora-ppc64be-native-gdbserver-m64/builds/5268>
Commit(s) tested:
b67aeab02c05fdd654f132a550dd4f196cb1f6d3
Author(s) (in the same order as the commits):
Simon Marchi <simon.marchi@polymtl.ca>
Subject:
Remove lwp -> pid conversion in linux_nat_xfer_partial
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Fedora-ppc64be-native-gdbserver-m64/b6/b67aeab02c05fdd654f132a550dd4f196cb1f6d3/>
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] linux-low: Remove unused variables
@ 2017-09-15 15:50 sergiodj+buildbot
2017-09-15 17:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-15 15:50 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 0eb0a40713c6479e782e5a257793d28f647e38bd ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 0eb0a40713c6479e782e5a257793d28f647e38bd
linux-low: Remove unused variables
gdb/gdbserver/ChangeLog:
* linux-low.c (linux_set_resume_request): Remove unused
variables.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add -l option to src-release script.
@ 2017-09-15 16:41 sergiodj+buildbot
2017-09-15 18:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-15 16:41 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ef87240fd95c5f29a697eccf20b2f1f6dc3593a6 ***
Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: ef87240fd95c5f29a697eccf20b2f1f6dc3593a6
Add -l option to src-release script.
Since we are updating src-release.sh I thought I would check in this
small patch. It adds the option to create lzip compressed tarballs
via the -l command line option.
* src-release.sh (LZIPPROG): New define. Provides the name of the
lzip program.
(do_lz): New function. Compresses a tarball using the lzip
program.
(do_compress): Add support for lzip compression.
(usage): Mention -l option.
(build_release): Support -l option to invoke lzip compression.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdbserver: Move detach code to its own function
@ 2017-09-15 16:54 sergiodj+buildbot
2017-09-15 21:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-15 16:54 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e8ca139ed036e6da8adf42fc6fbd93973b724d3c ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: e8ca139ed036e6da8adf42fc6fbd93973b724d3c
gdbserver: Move detach code to its own function
The code required to handle the 'D' packet is non trivial, so move it
out to its own function.
The moved out code is identical, except for the call to strtol and some
breaks that became returns.
Tested manually, and by running gdb.base/*detach*.exp with
native-gdbserver and native-extended-gdbserver.
gdb/gdbserver/ChangeLog:
* server.c (handle_detach): New function.
(process_serial_event): Move code out, call handle_detach.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Deduplicate require_running macros and move them up
@ 2017-09-15 17:29 sergiodj+buildbot
2017-09-15 19:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-15 17:29 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f8a4e1192032044cdae544848865636f6e07a925 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: f8a4e1192032044cdae544848865636f6e07a925
Deduplicate require_running macros and move them up
I find it very confusing to define the require_running in the middle of
the file, and re-define it to something else later in the middle of the
same file. I think it would be better if those macros had different
names so that we know exactly what they do.
gdb/gdbserver/ChangeLog:
* server.c (require_running): Rename to ...
(require_running_or_return): ... this ...
(require_running_or_break): ... and this.
(handle_query, process_serial_event): Adjust.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Sync libiberty/ & include/ with GCC
@ 2017-09-15 19:36 sergiodj+buildbot
2017-09-16 4:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-15 19:36 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 26a67918a501370a8fe62db18a74761a0073016f ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 26a67918a501370a8fe62db18a74761a0073016f
Sync libiberty/ & include/ with GCC
Note this brings in the interface files for libcc1/G++ as well, which
we will be needing in GDB soon anyway. That commit renamed a method
in the C interface and that required a small update to GDB's compile/
code, which I've included that in this patch to keep the tree
building.
include/ChangeLog:
2017-09-15 Pedro Alves <palves@redhat.com>
* ansidecl.h (DISABLE_COPY_AND_ASSIGN): New macro.
2017-09-12 Jiong Wang <jiong.wang@arm.com>
* dwarf2.def (DW_CFA_AARCH64_negate_ra_state): New DW_CFA_DUP.
* dwarf2.h (DW_CFA_DUP): New define.
2017-08-21 Richard Biener <rguenther@suse.de>
* simple-object.h (simple_object_copy_lto_debug_sections): New
function.
2017-05-18 Martin Liska <mliska@suse.cz>
* ansidecl.h: Define CONSTEXPR macro.
2017-05-24 Nathan Sidwell <nathan@acm.org>
* libiberty.h (ASTRDUP): Adjust cast to avoid warning.
2017-01-30 Alexandre Oliva <aoliva@redhat.com>
Introduce C++ support in libcc1.
* gcc-c-fe.def (int_type_v0): Rename from...
(int_type): ... this. Introduce new version.
(float_type_v0): Rename from...
(float_type): ... this. Introduce new version.
(char_type): New.
* gcc-c-interface.h (gcc_c_api_version): Add GCC_C_FE_VERSION_1.
(gcc_type_array): Move...
* gcc-interface.h: ... here.
* gcc-cp-fe.def: New.
* gcc-cp-interface.h: New.
2016-04-29 Oleg Endo <olegendo@gcc.gnu.org>
* longlong.h (umul_ppmm): Remove SHMEDIA checks.
(__umulsidi3, count_leading_zeros): Remove SHMEDIA implementations.
2017-09-15 Yao Qi <yao.qi@linaro.org>
Pedro Alves <palves@redhat.com>
* ansidecl.h (DISABLE_COPY_AND_ASSIGN): New macro.
2017-09-12 Jiong Wang <jiong.wang@arm.com>
* dwarf2.def (DW_CFA_AARCH64_negate_ra_state): New DW_CFA_DUP.
* dwarf2.h (DW_CFA_DUP): New define.
2017-08-21 Richard Biener <rguenther@suse.de>
* simple-object.h (simple_object_copy_lto_debug_sections): New
function.
2017-05-18 Martin Liska <mliska@suse.cz>
* ansidecl.h: Define CONSTEXPR macro.
2017-05-24 Nathan Sidwell <nathan@acm.org>
* libiberty.h (ASTRDUP): Adjust cast to avoid warning.
2017-01-30 Alexandre Oliva <aoliva@redhat.com>
Introduce C++ support in libcc1.
* gcc-c-fe.def (int_type_v0): Rename from...
(int_type): ... this. Introduce new version.
(float_type_v0): Rename from...
(float_type): ... this. Introduce new version.
(char_type): New.
* gcc-c-interface.h (gcc_c_api_version): Add GCC_C_FE_VERSION_1.
(gcc_type_array): Move...
* gcc-interface.h: ... here.
* gcc-cp-fe.def: New.
* gcc-cp-interface.h: New.
2016-04-29 Oleg Endo <olegendo@gcc.gnu.org>
* longlong.h (umul_ppmm): Remove SHMEDIA checks.
(__umulsidi3, count_leading_zeros): Remove SHMEDIA implementations.
libiberty/ChangeLog:
2017-09-15 Nathan Sidwell <nathan@acm.org>
PR demangler/82195
* cp-demangle.c (d_name): Add 'toplevel' parm. Pass to ...
(d_local_name): ... here. Parse trailing function args on nested
local_name.
(d_encoding, d_special_name, d_class_enum_type): Adjust d_name calls.
* testsuite/demangle-expected: Add tests.
2017-09-15 Richard Biener <rguenther@suse.de>
PR lto/81968
* simple-object-elf.c (simple_object_elf_copy_lto_debug_sections):
Iterate marking dependent sections necessary.
2017-09-15 Nathan Sidwell <nathan@acm.org>
* cp-demangle.c (is_fnqual_component_type): Reimplement using
FNQUAL_COMPONENT_CASE.
(d_encoding): Hold bare_function_type in local var.
(d_local_name): Build name in both cases and build result once.
Collapse switch-if to single conditional.
(d_local_name):
* testsuite/demangle-expected: Realign blank lines with tests.
2017-09-12 Jiong Wang <jiong.wang@arm.com>
* dwarfnames.c (DW_CFA_DUP): New define.
gdb/ChangeLog:
2017-09-15 Pedro Alves <palves@redhat.com>
* compile/compile-c-types.c (convert_enum, convert_int)
(convert_float): Adjust to refer to int_type_v0 and float_type_v0.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Use std::vector on tdesc->reg_defs (gdbserver/tdesc.h)
@ 2017-09-16 4:36 sergiodj+buildbot
2017-09-16 12:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-16 4:36 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c4dfafabc575f4995a5aa18241adc275e63c846c ***
Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: c4dfafabc575f4995a5aa18241adc275e63c846c
Use std::vector on tdesc->reg_defs (gdbserver/tdesc.h)
This is a followup patch to the build breakage fix on AArch64. While
doing the fix, I found it better to convert tdesc->reg_defs (on
gdbserver/tdesc.h) from using VEC to using std::vector. This makes
the code easier to read and maintain, and also is one more step
towards the C++fication.
Regtested on BuildBot.
2017-09-16 Sergio Durigan Junior <sergiodj@redhat.com>
* regcache.c (get_thread_regcache): Update code to use "std::vector"
instead of "VEC" for "target_desc.reg_defs".
(regcache_cpy): Likewise.
(registers_to_string): Likewise.
(registers_from_string): Likewise.
(find_regno): Likewise.
(supply_regblock): Likewise.
(regcache_raw_read_unsigned): Likewise.
* tdesc.c (init_target_desc): Likewise.
(tdesc_create_reg): Likewise.
* tdesc.h: Remove declaration of "tdesc_reg_p". Include <vector>.
(struct target_desc) <reg_defs>: Convert to "std::vector".
(target_desc): Do not initialize "reg_defs".
(~target_desc): Update code to use "std::vector" instead of "VEC"
for "target_desc.reg_defs".
(operator==): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] mi_load_progress: Use unique_ptr to manage ui_out lifetime
@ 2017-09-16 12:13 sergiodj+buildbot
2017-09-16 13:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-16 12:13 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT bd77e8ff276864d6622f2433b8a499bf4332fa65 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: bd77e8ff276864d6622f2433b8a499bf4332fa65
mi_load_progress: Use unique_ptr to manage ui_out lifetime
In mi_load_progress, we xfree a ui_out object. Because ui_out is not
trivially destructible, it should be freed with delete. This patch
makes use of a unique_ptr to do it.
gdb/ChangeLog:
* mi/mi-main.c (mi_load_progress): Make uiout variable
a unique_ptr.
diff --git a/gdb/mi/mi-main.c b/gdb/mi/mi-main.c index 0ee2605..0359dc1
100644 --- a/gdb/mi/mi-main.c +++ b/gdb/mi/mi-main.c @@ -2325,7 +2325,6
@@ mi_load_progress (const char *section_name, static char
*previous_sect_name = NULL; int new_section; struct ui_out *saved_uiout;
- struct ui_out *uiout; struct mi_interp *mi = (struct mi_interp *)
current_interpreter ();
/* This function is called through deprecated_show_load_progress
@@ -2333,17 +2332,19 @@ mi_load_progress (const char *section_name,
of this function. */
saved_uiout = current_uiout;
+ std::unique_ptr<ui_out> uiout;
+
if (current_interp_named_p (INTERP_MI)
|| current_interp_named_p (INTERP_MI2))
- current_uiout = mi_out_new (2);
+ uiout.reset (mi_out_new (2));
else if (current_interp_named_p (INTERP_MI1))
- current_uiout = mi_out_new (1);
+ uiout.reset (mi_out_new (1));
else if (current_interp_named_p (INTERP_MI3))
- current_uiout = mi_out_new (3);
+ uiout.reset (mi_out_new (3));
else
return;
- uiout = current_uiout;
+ current_uiout = uiout.get ();
new_section = (previous_sect_name ?
strcmp (previous_sect_name, section_name) : 1);
@@ -2356,12 +2357,12 @@ mi_load_progress (const char *section_name,
fputs_unfiltered (current_token, mi->raw_stdout);
fputs_unfiltered ("+download", mi->raw_stdout);
{
- ui_out_emit_tuple tuple_emitter (uiout, NULL);
+ ui_out_emit_tuple tuple_emitter (uiout.get (), NULL);
uiout->field_string ("section", section_name);
uiout->field_int ("section-size", total_section);
uiout->field_int ("total-size", grand_total);
}
- mi_out_put (uiout, mi->raw_stdout);
+ mi_out_put (uiout.get (), mi->raw_stdout);
fputs_unfiltered ("\n", mi->raw_stdout);
gdb_flush (mi->raw_stdout);
}
@@ -2374,19 +2375,18 @@ mi_load_progress (const char *section_name,
fputs_unfiltered (current_token, mi->raw_stdout);
fputs_unfiltered ("+download", mi->raw_stdout);
{
- ui_out_emit_tuple tuple_emitter (uiout, NULL);
+ ui_out_emit_tuple tuple_emitter (uiout.get (), NULL);
uiout->field_string ("section", section_name);
uiout->field_int ("section-sent", sent_so_far);
uiout->field_int ("section-size", total_section);
uiout->field_int ("total-sent", total_sent);
uiout->field_int ("total-size", grand_total);
}
- mi_out_put (uiout, mi->raw_stdout);
+ mi_out_put (uiout.get (), mi->raw_stdout);
fputs_unfiltered ("\n", mi->raw_stdout);
gdb_flush (mi->raw_stdout);
}
- xfree (uiout);
current_uiout = saved_uiout;
}
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] mi_load_progress: Restore current_uiout using a scoped_restore
@ 2017-09-16 12:47 sergiodj+buildbot
2017-09-16 14:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-16 12:47 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 5846367a24e24f334077ceb7f7389acbd072b11a ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 5846367a24e24f334077ceb7f7389acbd072b11a
mi_load_progress: Restore current_uiout using a scoped_restore
Simply use a scoped_restore instead of manually saving and restoring
current_uiout.
gdb/ChangeLog:
* mi/mi-main.c (mi_load_progress): Restore current_uiout using a
scoped_restore.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add unit test for xml_escape_text
@ 2017-09-16 13:24 sergiodj+buildbot
2017-09-16 17:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-16 13:24 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c3d7b541fa920e6ecb0f06ffe1e0e3f070fa295d ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: c3d7b541fa920e6ecb0f06ffe1e0e3f070fa295d
Add unit test for xml_escape_text
The following patch modifies xml_escape_text, so I took the opportunity
to write a unit test for it.
gdb/ChangeLog:
* Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new source file.
(SUBDIR_UNITTESTS_OBS): Add new object file.
* unittests/xml-utils-selftests.c: New file.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Make xml_escape_text return an std::string
@ 2017-09-16 14:50 sergiodj+buildbot
2017-09-17 3:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-16 14:50 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 5e1875543df7413d3cbc3831390445e347064b75 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 5e1875543df7413d3cbc3831390445e347064b75
Make xml_escape_text return an std::string
This is a simple replacement, it allows removing some manual free'ing in
the callers.
gdb/ChangeLog:
* common/buffer.c (buffer_xml_printf): Adjust.
* common/xml-utils.c (xml_escape_text): Change return type to
std::string, update code accordingly.
* common/xml-utils.h (xml_escape_text): Change return type to
std::string.
* rs6000-aix-tdep.c (rs6000_aix_shared_library_to_xml): Adjust.
* windows-tdep.c (windows_xfer_shared_library): Adjust.
* unittests/xml-utils-selftests.c (test_xml_escape_text):
Adjust.
gdb/gdbserver/ChangeLog:
* linux-low.c (linux_qxfer_libraries_svr4): Adjust to change of
return type of xml_escape_text.
* server.c (emit_dll_description): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] dwarf2expr: Remove unused abort_expression label in execute_stack_op
@ 2017-09-18 11:43 sergiodj+buildbot
2017-09-18 20:28 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-18 11:43 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 0615127c587253a6386fe49468fd64abf827273e ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 0615127c587253a6386fe49468fd64abf827273e
dwarf2expr: Remove unused abort_expression label in execute_stack_op
The label abort_expression is unused, so remove it.
gdb/ChangeLog:
* dwarf2expr.c (dwarf_expr_context::execute_stack_op): Remove
label abort_expression.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Check error return from bfd_canonicalize_dynamic_reloc
@ 2017-09-18 20:44 sergiodj+buildbot
2017-09-19 5:29 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-18 20:44 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 94670f6cf11fc29cc6db6814b38c4305d9bcac96 ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 94670f6cf11fc29cc6db6814b38c4305d9bcac96
Check error return from bfd_canonicalize_dynamic_reloc
Since bfd_canonicalize_dynamic_reloc returns -1 on error, check it in
_bfd_x86_elf_get_synthetic_symtab.
PR ld/22148
* elfxx-x86.c (_bfd_x86_elf_get_synthetic_symtab): Check error
return from bfd_canonicalize_dynamic_reloc.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR22150, ld keeps a version reference for gc'd symbols
@ 2017-09-19 5:56 sergiodj+buildbot
2017-09-19 6:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-19 5:56 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 3d13f3e9bda5aada68915f5d958f731ae79ed41d ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 3d13f3e9bda5aada68915f5d958f731ae79ed41d
PR22150, ld keeps a version reference for gc'd symbols
elf_gc_sweep_symbol should run after verdefs are calculated, since
the verdef code creates symbols for the versions. However,
elf_gc_sweep_symbol needs to run before verrefs so as to not emit
useless verrefs for symbols that are gc'd.
I've also removed a _bfd_elf_link_renumber_dynsyms calls added by
Maciej after I fussed about it when reviewing. On further examination
the call appears to be unnecessary. Looking at renumber_dynsyms also
made me realize that the test to exclude .gnu.version has been wrong
since 2016-04-26 (git commit d5486c4372), so fix that too.
PR 22150
* elflink.c (bfd_elf_size_dynamic_sections): Garbage collect
symbols before calculating verrefs. Don't renumber dynsyms
after gc. Exclude .gnu.version when zero or one dynsym.
Localize some vars and reindent.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove one explicit rule for monitor.o
@ 2017-09-19 10:48 sergiodj+buildbot
2017-09-19 19:25 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-19 10:48 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT aa70c9f1950b25b48f8fd6770f5d38a8252c24a4 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: aa70c9f1950b25b48f8fd6770f5d38a8252c24a4
Remove one explicit rule for monitor.o
gdb/monitor.c was removed by 40e0b27 (Delete the remaining ROM monitor
targets).
gdb:
2017-09-19 Yao Qi <yao.qi@linaro.org>
* Makefile.in (monitor.o): Remove the rule.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add a 'starti' command.
@ 2017-09-19 19:46 sergiodj+buildbot
2017-09-20 3:27 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-19 19:46 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 4e5a4f5850487740eb7549f1d0b8625ce577faab ***
Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: 4e5a4f5850487740eb7549f1d0b8625ce577faab
Add a 'starti' command.
This works like 'start' but it stops at the first instruction rather
than the first line in main(). This is useful if one wants to single
step through runtime linker startup.
While here, introduce a RUN_ARGS_HELP macro for shared help text
between run, start, and starti. This includes expanding the help for
start and starti to include details from run's help text.
gdb/ChangeLog:
* NEWS (Changes since GDB 8.0): Add starti.
* infcmd.c (enum run_break): New.
(run_command_1): Queue pending event for RUN_STOP_AT_FIRST_INSN
case.
(run_command): Use enum run_how.
(start_command): Likewise.
(starti_command): New function.
(RUN_ARGS_HELP): New macro.
(_initialize_infcmd): Use RUN_ARGS_HELP for run and start
commands. Add starti command.
gdb/doc/ChangeLog:
* gdb.texinfo (Starting your Program): Add description of
starti command. Mention starti command as an alternative for
debugging the elaboration phase.
gdb/testsuite/ChangeLog:
* gdb.base/starti.c: New file.
* gdb.base/starti.exp: New file.
* lib/gdb.exp (gdb_starti_cmd): New procedure.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb - avx512: tests were failing due to missing memory aligment.
@ 2017-09-20 14:10 sergiodj+buildbot
2017-09-20 15:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-20 14:10 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 6470a84860b11ba6e7258604ae78f047a1af2f5d ***
Author: Walfred Tedeschi <walfred.tedeschi@intel.com>
Branch: master
Commit: 6470a84860b11ba6e7258604ae78f047a1af2f5d
gdb - avx512: tests were failing due to missing memory aligment.
Test was running on a fault during code execution. Analysis have shown
that the wrong instruction had been used. An instruction that takes
not alligned memory is more appropriated for the task.
ChangeLog:
2017-09-20 Walfred Tedeschi <walfred.tedeschi@intel.com>
gdb/testesuite/ChangeLog:
* gdb.arch/i386-avx512.c (move_zmm_data_to_reg): Use
vmovups instead vmovaps.
(move_zmm_data_to_memory): Use vmovups instead vmovaps.
Change-Id: I4a95560861ef1792ed6ce86578fdd726162863f1
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] [OBV] amd64-features-makefile: add missing backslash.
@ 2017-09-20 15:28 sergiodj+buildbot
2017-09-20 16:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-20 15:28 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 1b7fa39ed9678fded7264636c1e5cc14c6d6ebc6 ***
Author: Walfred Tedeschi <walfred.tedeschi@intel.com>
Branch: master
Commit: 1b7fa39ed9678fded7264636c1e5cc14c6d6ebc6
[OBV] amd64-features-makefile: add missing backslash.
In an old commit the backslash of was missing in the rule for creating the
i386-avx-mpx-avx512-pku.dat file. No need to regenerate the files, this
was done by another commit from Yao.
2017-09-20 Walfred Tedeschi <walfred.tedeschi@intel.com>
* features/Makefile (i386-avx-mpx-avx512-pku.dat): Add backslash.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Make "list ambiguous" show symbol names too
@ 2017-09-20 17:04 sergiodj+buildbot
2017-09-20 22:25 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-20 17:04 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 06871ae84096ed1672eb76f44cea4d5dbe79ae24 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 06871ae84096ed1672eb76f44cea4d5dbe79ae24
Make "list ambiguous" show symbol names too
Currently, with an ambiguous "list first,last", we get:
(gdb) list bar,main
Specified first line 'bar' is ambiguous:
file: "src/gdb/testsuite/gdb.cp/overload.cc", line number: 97
file: "src/gdb/testsuite/gdb.cp/overload.cc", line number: 98
This commit makes gdb's output above a bit clearer by printing the
symbol name as well:
(gdb) list bar,main
Specified first line 'bar' is ambiguous:
file: "src/gdb/testsuite/gdb.cp/overload.cc", line number: 97, symbol: "bar(A)"
file: "src/gdb/testsuite/gdb.cp/overload.cc", line number: 98, symbol: "bar(B)"
And while at it, makes gdb print the symbol name when actually listing
multiple locations too. I.e., before (with "set listsize 2"):
(gdb) list bar
file: "src/gdb/testsuite/gdb.cp/overload.cc", line number: 97
96
97 int bar (A) { return 11; }
file: "src/gdb/testsuite/gdb.cp/overload.cc", line number: 98
97 int bar (A) { return 11; }
98 int bar (B) { return 22; }
After:
(gdb) list bar
file: "src/gdb/testsuite/gdb.cp/overload.cc", line number: 97, symbol: "bar(A)"
96
97 int bar (A) { return 11; }
file: "src/gdb/testsuite/gdb.cp/overload.cc", line number: 98, symbol: "bar(B)"
97 int bar (A) { return 11; }
98 int bar (B) { return 22; }
Currently, the result of decoding a linespec loses information about
the original symbol that was found. All we end up with is an address.
This makes it difficult to find the original symbol again to get at
its print name. Fix that by storing a pointer to the symbol in the
sal. We already store the symtab and obj_section, so it feels like a
natural progression to me. This avoids having to do any extra symbol
lookup too.
gdb/ChangeLog:
2017-09-20 Pedro Alves <palves@redhat.com>
* cli/cli-cmds.c (list_command): Use print_sal_location.
(print_sal_location): New function.
(ambiguous_line_spec): Use print_sal_location.
* linespec.c (symbol_to_sal): Record the symbol in the sal.
* symtab.c (find_function_start_sal): Likewise.
* symtab.h (symtab_and_line::symbol): New field.
gdb/testsuite/ChangeLog:
2017-09-20 Pedro Alves <palves@redhat.com>
* gdb.base/list-ambiguous.exp (test_list_ambiguous_symbol): Expect
symbol names in gdb's output.
* gdb.cp/overload.exp ("list all overloads"): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Overload catch_command_errors
@ 2017-09-20 22:31 sergiodj+buildbot
2017-09-20 23:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-20 22:31 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 013af3fc8eba48d081f0e83303cd800097e5b7a8 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 013af3fc8eba48d081f0e83303cd800097e5b7a8
Overload catch_command_errors
This changes catch_command_errors_const to be an overload of
catch_command_errors, which may mildly help future constification
efforts.
Tested by rebuilding.
gdb/ChangeLog
2017-09-20 Tom Tromey <tom@tromey.com>
* main.c (catch_command_errors): Rename from
catch_command_errors_const.
(captured_main_1): Update.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] eval.c:evaluate_subexp_standard: Use RAII to avoid leaks
@ 2017-09-21 0:06 sergiodj+buildbot
2017-09-21 4:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-21 0:06 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c83833f49353e1fe7fa727291210be751161ade1 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: c83833f49353e1fe7fa727291210be751161ade1
eval.c:evaluate_subexp_standard: Use RAII to avoid leaks
While working on the no-debug-info debugging improvements series, I
noticed these bare xfree calls, which lead to leaks if
evaluate_subexp_standard throws.
Fix that by reworking make_params as a RAII class. Ends up
eliminating a couple heap allocations too.
gdb/ChangeLog:
2017-09-20 Pedro Alves <palves@redhat.com>
* eval.c (make_params): Delete, refactored as ...
(class fake_method): ... this new type's ctor.
(fake_method::~fake_method): New.
(evaluate_subexp_standard): Use 'fake_method'.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Change counted_command_line to a shared_ptr
@ 2017-09-21 6:48 sergiodj+buildbot
2017-09-21 8:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-21 6:48 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d1b0a7bfd3df05fd2009b62b19b7535bbc6555c0 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: d1b0a7bfd3df05fd2009b62b19b7535bbc6555c0
Change counted_command_line to a shared_ptr
This changes counted_command_line to be a typedef for std::shared_ptr
and removes the associated cleanups. In the long run I believe that
cmd_list_element should also be changed to use a shared_ptr.
gdb/ChangeLog
2017-09-20 Tom Tromey <tom@tromey.com>
* breakpoint.c (struct counted_command_line): Remove.
(breakpoint_commands): Update.
(alloc_counted_command_line, incref_counted_command_line)
(decref_counted_command_line, do_cleanup_counted_command_line)
(make_cleanup_decref_counted_command_line): Remove.
(breakpoint_set_commands, commands_command_1, ~bpstats, bpstats)
(bpstat_clear_actions, bpstat_do_actions_1, watchpoint_check)
(bpstat_stop_status, print_one_breakpoint_location, ~breakpoint)
(save_breakpoints): Update.
* breakpoint.h (counted_command_line): Now a typedef to
shared_ptr.
(struct breakpoint) <commands>: Now a counted_command_line.
(struct bpstats) <command>: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] [SIM, ARM] Fix build failure
@ 2017-09-21 8:31 sergiodj+buildbot
2017-09-21 9:41 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-21 8:31 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 88240b186d224d634633d9996832f1235364b6d4 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 88240b186d224d634633d9996832f1235364b6d4
[SIM, ARM] Fix build failure
This patch fixes the build failure by using disassembler to get
disassemble function pointer, and do the disassembly, because
print_insn_little_arm is no longer visible outside opcodes/
binutils-gdb/sim/arm/wrapper.c:98:10: error: implicit declaration of function 'print_insn_little_arm' [-Werror=implicit-function-declaration]
size = print_insn_little_arm (0, & info);
^
sim/arm:
2017-09-21 Yao Qi <yao.qi@linaro.org>
* wrapper.c (print_insn): Use disassembler instead of
print_insn_little_arm.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix aarch64-freebsd build failure
@ 2017-09-21 9:36 sergiodj+buildbot
2017-09-21 12:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-21 9:36 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 0a0bf5dc149ad79b325cdffb6b4e57be6c5ecbc2 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 0a0bf5dc149ad79b325cdffb6b4e57be6c5ecbc2
Fix aarch64-freebsd build failure
I happen to see that fbsd-tdep.o is missing for target aarch64-freebsd,
and it causes the build failure,
aarch64-fbsd-tdep.o: In function `aarch64_fbsd_init_abi(gdbarch_info, gdbarch*)':
binutils-gdb/gdb/aarch64-fbsd-tdep.c:186: undefined reference to `fbsd_init_abi(gdbarch_info, gdbarch*)'
binutils-gdb/gdb/aarch64-fbsd-tdep.c:189: undefined reference to `svr4_lp64_fetch_link_map_offsets()'
binutils-gdb/gdb/aarch64-fbsd-tdep.c:189: undefined reference to `set_solib_svr4_fetch_link_map_offsets(gdbarch*, link_map_offsets* (*)())'
This patch fixed it.
gdb:
2017-09-21 Yao Qi <yao.qi@linaro.org>
* configure.tgt (aarch64*-*-freebsd*): Add fbsd-tdep.o solib-svr4.o
to gdb_target_obs.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] microblaze-tdep: Add ATTRIBUTE_PRINTF to microblaze_debug
@ 2017-09-21 12:52 sergiodj+buildbot
2017-09-21 14:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-21 12:52 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ebe48ba0856dcccaa7a60d873c61e6f1f96f5887 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: ebe48ba0856dcccaa7a60d873c61e6f1f96f5887
microblaze-tdep: Add ATTRIBUTE_PRINTF to microblaze_debug
I am getting this warning with clang:
/home/emaisin/src/binutils-gdb/gdb/microblaze-tdep.c:94:28: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
vprintf_unfiltered (fmt, args);
^~~
Adding ATTRIBUTE_PRINTF to microblaze_debug gets rid of it. Strangely,
gcc doesn't warn about non-literal format strings when calling vprintf
(or a vprintf-style function, like vprintf_unfiltered). I filed this
gcc bug:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82206
gdb/ChangeLog:
* microblaze-tdep.c (microblaze_debug): Add ATTRIBUTE_PRINTF.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] linux-waitpid: Get rid of format string warning
@ 2017-09-21 13:51 sergiodj+buildbot
2017-09-21 16:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-21 13:51 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 1e5b66ed4285ecf063e7801a46178ebb0ce5be41 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 1e5b66ed4285ecf063e7801a46178ebb0ce5be41
linux-waitpid: Get rid of format string warning
Clang gives this warning:
/home/emaisin/src/binutils-gdb/gdb/gdbserver/../nat/linux-waitpid.c:45:25: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
vfprintf (stderr, format, args);
^~~~~~
Get rid of it by adding ATTRIBUTE_PRINTF.
gdb/ChangeLog:
* nat/linux-waitpid.c (linux_debug): Add ATTRIBUTE_PRINTF.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] S/390: Fix Elf note swap s390_gs_bc vs. s390_gs_cb
@ 2017-09-21 16:21 sergiodj+buildbot
2017-09-21 18:33 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-21 16:21 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 8fe09d7421db51bc13c9228547d63e6315bd6bd0 ***
Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: 8fe09d7421db51bc13c9228547d63e6315bd6bd0
S/390: Fix Elf note swap s390_gs_bc vs. s390_gs_cb
Fix two typos that resulted in swapping the BFD names for the core note
register sections NT_S390_GS_CB and NT_S390_GS_BC.
bfd/ChangeLog:
* elf.c (elfcore_grok_note): For the cases NT_S390_GS_CB and
NT_S390_GS_BC, correct the previously swapped invocations of
elfcore_grok_s390_gs_bc and elfcore_grok_s390_gs_cb.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdbserver: Remove traces of ancient Hc handling
@ 2017-09-21 16:58 sergiodj+buildbot
2017-09-21 19:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-21 16:58 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f557a88ab120b75ddcc507c03d565c28e5f88c16 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: f557a88ab120b75ddcc507c03d565c28e5f88c16
gdbserver: Remove traces of ancient Hc handling
Back in commit f0db101d9897 ("gdbserver: don't pick a random thread if
the current thread dies"), a couple years ago, the last references to
set_desired_thread(0) [select the Hc thread] were removed, and all the
remaining calls to set_desired_thread pass '1', meaning general
thread. This means we can simplify set_desired_thread.
gdb/gdbserver/ChangeLog:
2017-09-21 Pedro Alves <palves@redhat.com>
* server.c (gdb_read_memory, handle_status, process_serial_event)
(handle_serial_event, handle_target_event): Adjust to
set_desired_thread prototype change.
* target.c (set_desired_thread): Remove 'use_general' parameter
and adjust.
* target.h (set_desired_thread): Remove 'use_general' parameter.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add target method for converting thread handle to thread_info struct pointer
@ 2017-09-21 19:14 sergiodj+buildbot
2017-09-21 20:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-21 19:14 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e04ee09e24563f013c35cdebd7e9de3092b99b83 ***
Author: Kevin Buettner <kevinb@redhat.com>
Branch: master
Commit: e04ee09e24563f013c35cdebd7e9de3092b99b83
Add target method for converting thread handle to thread_info struct pointer
This patch adds a target method named `to_thread_handle_to_thread_info'.
It is intended to map a thread library specific thread handle (such as
pthread_t for the pthread library) to the corresponding GDB internal
thread_info struct (pointer).
An implementation is provided for Linux pthreads; see linux-thread-db.c.
gdb/ChangeLog:
* target.h (struct target_ops): Add to_thread_handle_to_thread_info.
(target_thread_handle_to_thread_info): Declare.
* target.c (target_thread_handle_to_thread_info): New function.
* target-delegates.c: Regenerate.
* gdbthread.h (find_thread_by_handle): Declare.
* thread.c (find_thread_by_handle): New function.
* linux-thread-db.c (thread_db_thread_handle_to_thread_info): New
function.
(init_thread_db_ops): Register thread_db_thread_handle_to_thread_info.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add `thread_from_thread_handle' method to (Python) gdb.Inferior
@ 2017-09-21 19:39 sergiodj+buildbot
2017-09-21 21:41 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-21 19:39 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT fbbe5337a6d839309c0415765803a19f3e38f6e4 ***
Author: Kevin Buettner <kevinb@redhat.com>
Branch: master
Commit: fbbe5337a6d839309c0415765803a19f3e38f6e4
Add `thread_from_thread_handle' method to (Python) gdb.Inferior
gdb/ChangeLog:
* python/py-inferior.c (gdbpy_thread_from_thread_handle): New
function.
(inferior_object_methods): Add gdbpy_thread_from_thread_handle.
* python/python-internal.h (thread_object_type): Declare.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add thread_db_notice_clone to gdbserver
@ 2017-09-21 20:08 sergiodj+buildbot
2017-09-21 22:51 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-21 20:08 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 8629910955a751a93f2f12389ff1f497556cc260 ***
Author: Kevin Buettner <kevinb@redhat.com>
Branch: master
Commit: 8629910955a751a93f2f12389ff1f497556cc260
Add thread_db_notice_clone to gdbserver
While working on a patch for fetching a thread handle in gdbserver, I
ran into a circumstance in which tests in gdb.mi/mi-nsmoribund.exp
would occasionally fail. Over a large enough number of runs, it would
fail roughly 2% of the time.
That thread handle patch caused find_one_thread() to be called on
every stop. find_one_thread() calls td_ta_map_lwp2thr() which, in
turn, can cause ps_get_thread_area() to be called.
ps_get_thread_area() makes a call to ptrace() for getting the thread
area address. If this should happen when the thread is not stopped,
the call to ptrace will return error which in turn propogates back to
find_one_thread(). find_one_thread() calls error() in this instance
which causes the program to die.
This patch causes find_one_thread() to be called upon reciept of a
clone event. Since the clone is stopped, the circumstances described
above cannot occur.
gdb/gdbserver/ChangeLog:
* linux-low.c (handle_extended_wait): Call thread_db_notice_clone().
* linux-low.h (thread_db_notice_clone): Declare.
* thread-db.c (thread_db_notice_clone): New function.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Test case for Inferior.thread_from_thread_handle
@ 2017-09-21 20:48 sergiodj+buildbot
2017-09-22 5:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-21 20:48 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 757bf54bb48a8417154cfdd7128c1775d43478d8 ***
Author: Kevin Buettner <kevinb@redhat.com>
Branch: master
Commit: 757bf54bb48a8417154cfdd7128c1775d43478d8
Test case for Inferior.thread_from_thread_handle
As the title says, this is a test case for
Inferior.thread_from_thread_handle, a python method which will,
given a thread library dependent thread handle, find the GDB thread
which corresponds to that thread handle (in the inferior under
consideration).
The C file for this test case causes the thread handles for the
main thread and two child threads to be placed into an array. The
test case runs to one of the functions (do_something()) at which point,
it retrieves the thread handles from the array and attempts to find the
corresponding thread in GDB's internal thread list.
I use barriers to make sure that both threads have actually started;
execution will stop when one of the threads breaks at do_something.
Thanks to Simon Marchi for suggestions for forcing the thread
numbering to be stable.
gdb/testsuite/ChangeLog:
* gdb.python/py-thrhandle.c, gdb.python/py-thrhandle.exp: New
files.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix gdb 8.1 Solaris compilation
@ 2017-09-22 9:29 sergiodj+buildbot
2017-09-22 14:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-22 9:29 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 4fa7574eecb9a92ef40f77de572541e402a2749e ***
Author: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Branch: master
Commit: 4fa7574eecb9a92ef40f77de572541e402a2749e
Fix gdb 8.1 Solaris compilation
I just tried to compile gdb trunk on Solaris 11.4 (formerly 12), and
failed for a couple of reasons:
*
In file included from /usr/include/python2.7/Python.h:128:0,
from /vol/src/gnu/gdb/gdb/dist/gdb/python/python-internal.h:94,
from /vol/src/gnu/gdb/gdb/dist/gdb/python/py-instruction.h:23,
from /vol/src/gnu/gdb/gdb/dist/gdb/python/py-instruction.c:21:
/usr/include/python2.7/ceval.h:67:0: error: ignoring #pragma no_inline [-Werror=unknown-pragmas]
#pragma no_inline(PyEval_EvalFrameEx)
^
New in Solaris 11.4: <python2.7/ceval.h> uses a Studio-only #pragma.
I've disabled the warning in warnings.m4.
*
/vol/src/gnu/gdb/gdb/dist/gdb/ser-pipe.c: In function int pipe_open(serial*, const char*):
/vol/src/gnu/gdb/gdb/dist/gdb/ser-pipe.c:77:9: error: pid_t vfork() is deprecated (declared at /usr/include/unistd.h:659) [-Werror=deprecated-declarations]
pid = vfork ();
^
/vol/src/gnu/gdb/gdb/dist/gdb/ser-pipe.c:77:16: error: pid_t vfork() is deprecated (declared at /usr/include/unistd.h:659) [-Werror=deprecated-declarations]
pid = vfork ();
^
Since Solaris 11, vfork () is marked deprecated in <unistd.h>.
cf. vfork(2):
The vfork() and vforkx() functions are deprecated. Their sole legiti-
mate use as a prelude to an immediate call to a function from the exec
family can be achieved safely by posix_spawn(3C) or posix_spawnp(3C).
Again, I've disabled the warning.
*
/vol/src/gnu/gdb/gdb/dist/gdb/cli/cli-cmds.c: In function void shell_escape(const char*, int):
/vol/src/gnu/gdb/gdb/dist/gdb/cli/cli-cmds.c:750:14: error: pid_t vfork() is deprecated (declared at /usr/include/unistd.h:659) [-Werror=deprecated-declarations]
if ((pid = vfork ()) == 0)
^
/vol/src/gnu/gdb/gdb/dist/gdb/cli/cli-cmds.c:750:21: error: pid_t vfork() is deprecated (declared at /usr/include/unistd.h:659) [-Werror=deprecated-declarations]
if ((pid = vfork ()) == 0)
^
Same problem.
*
/vol/src/gnu/gdb/gdb/dist/gdb/procfs.c: In function void procfs_init_inferior(target_ops*, int):
/vol/src/gnu/gdb/gdb/dist/gdb/procfs.c:4380:30: error: START_INFERIOR_TRAPS_EXPECTED was not declared in this scope
gdb_startup_inferior (pid, START_INFERIOR_TRAPS_EXPECTED);
^
defined in nat/fork-inferior.h, need to include that header
/vol/src/gnu/gdb/gdb/dist/gdb/procfs.c: In function void procfs_create_inferior(target_ops*, const char*, const string&, char**, int):
/vol/src/gnu/gdb/gdb/dist/gdb/procfs.c:4605:38: error: fork_inferior was not declared in this scope
NULL, NULL, shell_file, NULL);
^
likewise
/vol/src/gnu/gdb/gdb/dist/gdb/procfs.c: In function void procfs_info_proc(target_ops*, const char*, info_proc_what):
/vol/src/gnu/gdb/gdb/dist/gdb/procfs.c:5124:20: error: argv was not declared in this scope
for (char *arg : argv)
^
Typo, should be built_argv instead!
*
Undefined first referenced
symbol in file
fork_inferior(char const*, std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, char**, void (*)(), void (*)(int), void (*)(), char const*, void (*)(char const*, char* const*, char* const*)) procfs.o
startup_inferior(int, int, target_waitstatus*, ptid_t*) fork-child.o
ld: fatal: symbol referencing errors
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:2249: gdb] Error 1
Need to add fork-inferior.o to NATDEPFILES.
With the changes below, I can build gdb on sparcv9-sun-solaris2.11 and
amd64-pc-solaris2.11 and a simple smoke test (gdb/gdb gdb/gdb) works.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix sometimes-uninitialized warning in gdbscm_value_address
@ 2017-09-22 14:18 sergiodj+buildbot
2017-09-22 15:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-22 14:18 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 432ae719d35c81324e01ae6bd9970cc43e69fa5e ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 432ae719d35c81324e01ae6bd9970cc43e69fa5e
Fix sometimes-uninitialized warning in gdbscm_value_address
I am getting this warning with clang:
/home/emaisin/src/binutils-gdb/gdb/guile/scm-value.c:439:11: error: variable 'address' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
if (res_val != NULL)
^~~~~~~~~~~~~~~
/home/emaisin/src/binutils-gdb/gdb/guile/scm-value.c:444:32: note: uninitialized use occurs here
if (gdbscm_is_exception (address))
^~~~~~~
/home/emaisin/src/binutils-gdb/gdb/guile/scm-value.c:439:7: note: remove the 'if' if its condition is always true
if (res_val != NULL)
^~~~~~~~~~~~~~~~~~~~
/home/emaisin/src/binutils-gdb/gdb/guile/scm-value.c:427:18: note: initialize the variable 'address' to silence this warning
SCM address;
^
= nullptr
We can get rid of it with a small refactoring. I think it's a bit
cleaner/safer to initialize address with a pessimistic value and assign
it on success. Then there's no chance of using it uninitialized. If I
understand correctly, the NULL check on res_val was to check whether
value_addr threw, and that if value_addr returns without throwing, the
result will never be NULL. If that's true, we can skip the res_val
variable.
Tested by running gdb.guile/*.exp locally.
gdb/ChangeLog:
* guile/scm-value.c (gdbscm_value_address): Initialize address,
get rid of res_val.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] bfd/version.h: Add rationale for BFD_VERSION_DATE
@ 2017-09-22 14:55 sergiodj+buildbot
2017-09-22 16:44 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-22 14:55 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b877d21f34211915953487d68a07697f4cb4f771 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: b877d21f34211915953487d68a07697f4cb4f771
bfd/version.h: Add rationale for BFD_VERSION_DATE
bfd/ChangeLog:
2017-09-22 Pedro Alves <palves@redhat.com>
Alan Modra <amodra@gmail.com>
* version.h: Add comment.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: Return -1 if bfd_canonicalize_dynamic_reloc returns 0
@ 2017-09-22 15:29 sergiodj+buildbot
2017-09-22 17:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-22 15:29 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b69e9267d15a09ce3f3d4599eae2952dfc6df502 ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: b69e9267d15a09ce3f3d4599eae2952dfc6df502
x86: Return -1 if bfd_canonicalize_dynamic_reloc returns 0
Stop if bfd_canonicalize_dynamic_reloc returns 0.
PR ld/22163
* elfxx-x86.c (_bfd_x86_elf_get_synthetic_symtab): Also return
-1 if bfd_canonicalize_dynamic_reloc returns 0.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdbserver x86 on win32: call init_target_desc
@ 2017-09-22 15:58 sergiodj+buildbot
2017-09-22 19:00 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-22 15:58 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT cc4d742f4ce05bf933397a513b953c0feeae0663 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: cc4d742f4ce05bf933397a513b953c0feeae0663
gdbserver x86 on win32: call init_target_desc
When trying to run gdbserver compiled for x86 win32 under wine, I get:
$ wine ./gdbserver/gdbserver.exe --once :1234 ./test
/home/emaisin/src/binutils-gdb/gdb/gdbserver/regcache.c:177: A problem internal to GDBserver has been detected.
regcache* new_register_cache(const target_desc*): Assertion `tdesc->registers_size != 0' failed.
It seems like on that platform, init_target_desc is never called, so
registers_size is never computed.
My first thought was to call init_target_desc somewhere in win32-low.c,
but it turns out that when using win32 on arm, the target description is
already initialized by the generated code. My second thought was to
call it in {i386,amd64}_create_target_description, but those functions
are shared with GDB, and init_target_desc is gdbserver-specific. So I
ended up with the simplest fix, calling it in i386_arch_setup.
Now I hit some other problem:
$ wine ./gdbserver/gdbserver.exe --once :1234 ./test
Killing process(es): 39
No program to debug
Exiting
but still, I think fixing the tdesc issue this is a step forward.
gdb/gdbserver/ChangeLog:
* win32-i386-low.c (i386_arch_setup): Call init_target_desc.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Get rid of "gdb_dirbuf" and use "getcwd (NULL, 0)"
@ 2017-09-22 18:25 sergiodj+buildbot
2017-09-22 21:38 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-22 18:25 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 43573013c9836f2b91b74b9b29dac35fdb41e06b ***
Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: 43573013c9836f2b91b74b9b29dac35fdb41e06b
Get rid of "gdb_dirbuf" and use "getcwd (NULL, 0)"
Currently we have "current_directory" and "gdb_dirbuf" globals, which
means that we basically have two possible places to consult when we
want to know GDB's current working directory.
This is not ideal and can lead to confusion. Moreover, the way we're
using "gdb_difbuf" along with "getcwd" is problematic because we
declare the buffer with "1024" elements hardcoded, which does not take
into account longer pathnames that are possible in many filesystems.
Using "PATH_MAX" would also not be a solution because of portability
problems. Therefore, the best solution is to rely on the fact that
"getcwd (NULL, 0)" will "do the right thing" and return a
heap-allocated string containing the full path. With the new "getcwd"
module from gnulib, it is now possible to do that without worrying
about breaking some host.
With this patch "current_directory" is now the only place to check for
GDB's cwd.
Reviewed-by: Pedro Alves <palves@redhat.com>
gdb/ChangeLog:
2017-09-22 Sergio Durigan Junior <sergiodj@redhat.com>
* cli/cli-cmds.c (pwd_command): Use "getcwd (NULL, 0)".
(cd_command): Likewise. Free "current_directory" before
assigning to it.
* main.c (captured_main_1): Use "getcwd (NULL, 0)".
* mi/mi-cmd-env.c (mi_cmd_env_pwd): Likewise.
* top.c (gdb_dirbuf): Remove global declaration.
* top.h (gdb_dirbuf): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] LVU: dump loclists with locviews
@ 2017-09-22 20:52 sergiodj+buildbot
2017-09-22 22:23 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-22 20:52 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9f272209118972864b2c3799ddf2b39683c1a7b7 ***
Author: Alexandre Oliva <aoliva@redhat.com>
Branch: master
Commit: 9f272209118972864b2c3799ddf2b39683c1a7b7
LVU: dump loclists with locviews
When dumping location lists, also dump locview lists that may be
interspersed with them, and bring view pairs next to the corresponding
location list entries.
This patch supports DW_AT_GNU_locviews as a separate attribute for
DWARF4- loc_lists and split (dwo) loclists, as well as DWARF5
loclists.
It also supports, in DWARF5 loclists, the proposed
DW_LLE_GNU_view_pair loclist entry type proposed for DWARF6.
The tests use 32-bit DWARF, even on 64-bit targets, resolving offsets
to constants so as to reduce the risk that relocations be created for
them, or that the offsets be rejected as nonconstants.
The patch also adds an xfail to an unrelated test, namely dw5, so that
no unexpected fails remain on nds32*-elf, one of the tested targets.
Reviewed-by: Alan Modra <amodra@gmail.com>
for include/ChangeLog
* dwarf2.def (DW_AT_GNU_locviews): New.
* dwarf2.h (enum dwarf_location_list_entry_type): Add
DW_LLE_GNU_view_pair.
(DW_LLE_view_pair): Define.
for binutils/ChangeLog
* dwarf.h (debug_info): Add loc_views and num_loc_views.
* dwarf.c (vm1): New constant.
(print_dwarf_view): New function.
(read_and_display_attr_value): Support DW_AT_GNU_locviews.
(process_debug_info): Keep num_loc_offsets and num_loc_views
in sync.
(display_view_pair_list): New function.
(display_loc_list_dwo): Take vstart_ptr; update it. Dump
location view pairs before the range they apply to, when a
viewlist augments the loc list.
(display_loc_list): Likewise. Check view numbers in range
tests.
(display_loclists_list): Likewise. Handle view pair entries,
and warn on trailing ones.
(loc_views): New variable.
(loc_offsets_compar): Compare loc_views if loc_offsets are the
same.
(display_debug_loc): Check and sort loc_views too. Accept
loc_view as expected_start. Skip if lists and views are the
same. Dump locview list separately in order, and pass the
locview list base to each list dump function. Warn and skip
overlap and hole checking if we find loclists and locviews to
not be adjacent.
* testsuite/binutils-all/locview-1.s: New.
* testsuite/binutils-all/readelf.locview-1: New.
* testsuite/binutils-all/locview-2.s: New.
* testsuite/binutils-all/readelf.locview-2: New.
* testsuite/binutils-all/readelf.exp: Run new tests. Fix
option spelling in pr18374 fail message. XFAIL dw5 test on
nds32*-elf.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Change type of scoped_input_handler::m_quit_handler
@ 2017-09-22 22:17 sergiodj+buildbot
2017-09-23 7:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-22 22:17 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c2f97536b77f9d9531a1a2c37008b454eb67a82e ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: c2f97536b77f9d9531a1a2c37008b454eb67a82e
Change type of scoped_input_handler::m_quit_handler
Simon pointed out that scoped_input_handler::m_quit_handler must have
the correct scoped_restore_tmpl type, to avoid binding to a temporary.
This patch fixes the problem.
gdb/ChangeLog
2017-09-22 Tom Tromey <tom@tromey.com>
* utils.c (class scoped_input_handler) <m_quit_handler>: Change
type to scoped_restore_tmpl.
<scoped_input_handler>: Initialize m_quit_handler directly.
Reviewed-By: Pedro Alves <palves@redhat.com>
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Removed unused declaration
@ 2017-09-23 21:05 sergiodj+buildbot
2017-09-24 7:06 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-23 21:05 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b4a7c699688bd88313893cbb59ee0df5b8cd009b ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: b4a7c699688bd88313893cbb59ee0df5b8cd009b
Removed unused declaration
An earlier patch of mine removed make_cleanup_override_quit_handler,
but neglected to remove the declaration. This patch removes it.
Tested by rebuilding. I'm committing this as obvious.
ChangeLog
2017-09-23 Tom Tromey <tom@tromey.com>
* defs.h (make_cleanup_override_quit_handler): Don't declare.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR22167, NULL pointer dereference in scan_unit_for_symbols
@ 2017-09-24 7:39 sergiodj+buildbot
2017-09-24 9:41 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-24 7:39 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 0d76029f92182c3682d8be2c833d45bc9a2068fe ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 0d76029f92182c3682d8be2c833d45bc9a2068fe
PR22167, NULL pointer dereference in scan_unit_for_symbols
PR 22167
* dwarf2.c (scan_unit_for_symbols): Check u.blk->data is non-NULL.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR22169, heap-based buffer overflow in read_1_byte
@ 2017-09-24 8:08 sergiodj+buildbot
2017-09-24 10:54 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-24 8:08 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 515f23e63c0074ab531bc954f84ca40c6281a724 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 515f23e63c0074ab531bc954f84ca40c6281a724
PR22169, heap-based buffer overflow in read_1_byte
The .debug_line header length field doesn't include the length field
itself, ie. it's the size of the rest of .debug_line.
PR 22169
* dwarf2.c (decode_line_info): Correct .debug_line unit_length check.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR22186, divide-by-zero in decode_line_info
@ 2017-09-24 8:28 sergiodj+buildbot
2017-09-24 12:21 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-24 8:28 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d8010d3e75ec7194a4703774090b27486b742d48 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: d8010d3e75ec7194a4703774090b27486b742d48
PR22186, divide-by-zero in decode_line_info
PR 22186
* dwarf2.c (decode_line_info): Fail on lh.line_range of zero
rather than dividing by zero.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR22187, infinite loop in find_abstract_instance_name
@ 2017-09-24 8:40 sergiodj+buildbot
2017-09-24 13:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-24 8:40 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 52a93b95ec0771c97e26f0bb28630a271a667bd2 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 52a93b95ec0771c97e26f0bb28630a271a667bd2
PR22187, infinite loop in find_abstract_instance_name
This patch prevents the simple case of infinite recursion in
find_abstract_instance_name by ensuring that the attributes being
processed are not the same as the previous call.
The patch also does a little cleanup, and leaves in place some changes
to the nested_funcs array that I made when I wrongly thought looping
might occur in scan_unit_for_symbols.
PR 22187
* dwarf2.c (find_abstract_instance_name): Add orig_info_ptr and
pname param. Return status. Make name const. Don't abort,
return an error. Formatting. Exit if current info_ptr matches
orig_info_ptr. Update callers.
(scan_unit_for_symbols): Start at nesting_level of zero. Make
nested_funcs an array of structs for extensibility. Formatting.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR22191, memory leak in dwarf2.c
@ 2017-09-24 12:42 sergiodj+buildbot
2017-09-24 18:27 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-24 12:42 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a26a013f22a19e2c16729e64f40ef8a7dfcc086e ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: a26a013f22a19e2c16729e64f40ef8a7dfcc086e
PR22191, memory leak in dwarf2.c
table->sequences is a linked list before it is replaced by a bfd_alloc
array in sort_line_sequences.
PR 22191
* dwarf2.c (decode_line_info): Properly free line sequences on error.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR22197, buffer overflow in bfd_get_debug_link_info_1
@ 2017-09-24 12:59 sergiodj+buildbot
2017-09-25 5:25 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-24 12:59 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 52b36c51e5bf6d7600fdc6ba115b170b0e78e31d ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 52b36c51e5bf6d7600fdc6ba115b170b0e78e31d
PR22197, buffer overflow in bfd_get_debug_link_info_1
PR 22197
* opncls.c (bfd_get_debug_link_info_1): Properly check that crc is
within section bounds.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR22200, DWARF5 .debug_line sanity check
@ 2017-09-25 13:52 sergiodj+buildbot
2017-09-25 14:57 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-25 13:52 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c361faae8d964db951b7100cada4dcdc983df1bf ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: c361faae8d964db951b7100cada4dcdc983df1bf
PR22200, DWARF5 .debug_line sanity check
The format_count entry can't be zero unless the count is also zero.
PR 22200
* dwarf2.c (read_formatted_entries): Error on format_count zero.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR22201, DW_AT_name with out of bounds reference
@ 2017-09-25 14:14 sergiodj+buildbot
2017-09-25 16:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-25 14:14 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 11855d8a1f11b102a702ab76e95b22082cccf2f8 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 11855d8a1f11b102a702ab76e95b22082cccf2f8
PR22201, DW_AT_name with out of bounds reference
DW_AT_name ought to always have a string value.
PR 22201
* dwarf2.c (scan_unit_for_symbols): Ignore DW_AT_name unless it
has string form.
(parse_comp_unit): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR22202, buffer overflow in parse_die
@ 2017-09-25 15:04 sergiodj+buildbot
2017-09-25 18:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-25 15:04 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 1da5c9a485f3dcac4c45e96ef4b7dae5948314b5 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 1da5c9a485f3dcac4c45e96ef4b7dae5948314b5
PR22202, buffer overflow in parse_die
There was a complete lack of sanity checking in dwarf1.c
PR 22202
* dwarf1.c (parse_die): Sanity check pointer against section limit
before dereferencing.
(parse_line_table): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] S390: Add guarded-storage register support to GDB
@ 2017-09-25 16:24 sergiodj+buildbot
2017-09-25 22:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-25 16:24 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 1b63490c9173f8c9770b7885def720516aa9b9f8 ***
Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: 1b63490c9173f8c9770b7885def720516aa9b9f8
S390: Add guarded-storage register support to GDB
Recognize targets with the new guarded-storage feature and then present
the guarded-storage registers and the Linux-specific guarded-storage
broadcast control block appropriately.
gdb/ChangeLog:
* s390-linux-nat.c (have_regset_gs): New static variable.
(s390_linux_fetch_inferior_registers): Handle guarded-storage
control block and guarded-storage broadcast control regsets.
(s390_read_description): Detect whether the target has
guarded-storage support, return appropriate tdesc.
* s390-linux-tdep.c (features/s390-gs-linux64.c): New include.
(features/s390x-gs-linux64.c): Likewise.
(struct gdbarch_tdep) <have_gs>: New field.
(s390_regmap_gs, s390_regmap_gsbc, s390_gs_regset)
(s390_gsbc_regset): New variables.
(s390_iterate_over_regset_sections): Iterate over s390_gs_regset
and s390_gsbc_regset, if applicable.
(s390_core_read_description): Check whether core file was from a
target with guarded-storage support; include appropriate regsets.
(s390_gdbarch_init): Add registers for guarded-storage support.
(_initialize_s390_tdep): Initialize new target descriptions that
include registers for guarded-storage support.
* s390-linux-tdep.h (HWCAP_S390_GS, S390_GSD_REGNUM)
(S390_GSSM_REGNUM, S390_GSEPLA_REGNUM)
(S390_BC_GSD_REGNUM, S390_BC_GSSM_REGNUM): New defines.
(S390_NUM_REGS): Adjust macro definition.
(s390_gs_regset, s390_gsbc_regset, tdesc_s390_gs_linux64)
(tdesc_s390x_gs_linux64): New declarations.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] S390: Add guarded-storage register support to gdbserver
@ 2017-09-25 17:02 sergiodj+buildbot
2017-09-26 0:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-25 17:02 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ad3396348e0ebb61fdf71cff307bac08175ed366 ***
Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: ad3396348e0ebb61fdf71cff307bac08175ed366
S390: Add guarded-storage register support to gdbserver
Enable gdbserver to deal with the new guarded-storage register sets.
gdb/gdbserver/ChangeLog:
* configure.srv (s390*-*-linux*): Add s390-gs-linux64.o and
s390x-gs-linux64.o to srv_regobj. Add s390-gs-linux64.xml,
s390x-gs-linux64.xml, s390-gs.xml, and s390-gsbc.xml to
srv_xmlfiles. Add s390-gs-linux64-ipa.o and
s390x-gs-linux64-ipa.o to ipa_obj.
* linux-s390-low.c (HWCAP_S390_GS): New define.
(s390_fill_gs, s390_store_gs, s390_fill_gsbc, s390_store_gsbc):
New functions.
(s390_regsets): Add regsets for NT_S390_GS_CB and NT_S390_GS_BC.
(s390_arch_setup): Check for guarded-storage support and choose
appropriate tdesc.
(initialize_low_arch): Invoke init_registers_s390_gs_linux64 and
init_registers_s390x_gs_linux64.
* linux-s390-tdesc.h (enum s390_linux_tdesc) <S390_TDESC_GS>: New
enum value.
(init_registers_s390x_gs_linux64, tdesc_s390x_gs_linux64)
(init_registers_s390_gs_linux64, tdesc_s390_gs_linux64): Declare.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR22204, Lack of DW_LNE_end_sequence causes "infinite" loop
@ 2017-09-26 0:40 sergiodj+buildbot
2017-09-26 2:14 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-26 0:40 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e338894dc2e603683bed2172e8e9f25b29051005 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: e338894dc2e603683bed2172e8e9f25b29051005
PR22204, Lack of DW_LNE_end_sequence causes "infinite" loop
PR 22204
* dwarf2.c (decode_line_info): Ensure line_ptr stays within
bounds in inner loop.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR22205, .debug_line file table NULL filename
@ 2017-09-26 1:17 sergiodj+buildbot
2017-09-26 3:06 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-26 1:17 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a54018b72d75abf2e74bf36016702da06399c1d9 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: a54018b72d75abf2e74bf36016702da06399c1d9
PR22205, .debug_line file table NULL filename
The PR22200 fuzzer testcase found one way to put NULLs into .debug_line
file tables. PR22205 finds another. This patch gives up on trying to
prevent NULL files in the file table and instead just copes with them.
Arguably, this is better than giving up and showing no info from
.debug_line. I've also fixed a case where the fairly recent DWARF5
support in handling broken DWARG could result in uninitialized memory
reads, and made a small tidy.
PR 22205
* dwarf2.c (concat_filename): Return "<unknown>" on NULL filename.
(read_formatted_entries): Init "fe".
(decode_line_info <DW_LNE_define_file>): Use line_info_add_file_name.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove make_cleanup_regcache_xfree
@ 2017-09-26 2:45 sergiodj+buildbot
2017-09-26 7:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-26 2:45 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9ac86b52da268147b2565e4920357432bb7a34c3 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 9ac86b52da268147b2565e4920357432bb7a34c3
Remove make_cleanup_regcache_xfree
This removes make_cleanup_regcache_xfree in favor of using
std::unique_ptr as the return type of frame_save_as_regcache.
gdb/ChangeLog
2017-09-25 Tom Tromey <tom@tromey.com>
* spu-tdep.c (spu2ppu_sniffer): Update.
* regcache.h (make_cleanup_regcache_xfree): Don't declare.
* regcache.c (do_regcache_xfree, make_cleanup_regcache_xfree):
Remove.
* ppc-linux-tdep.c (ppu2spu_sniffer): Update.
* mi/mi-main.c (mi_cmd_data_list_changed_registers): Update.
* frame.h (frame_save_as_regcache): Return std::unique_ptr.
* frame.c (frame_save_as_regcache): Return std::unique_ptr.
(frame_pop): Update.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove make_cleanup_regcache_invalidate
@ 2017-09-26 3:25 sergiodj+buildbot
2017-09-26 9:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-26 3:25 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b292235f666ff2123e26794db73d5a27a685e7be ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: b292235f666ff2123e26794db73d5a27a685e7be
Remove make_cleanup_regcache_invalidate
This removes make_cleanup_regcache_invalidate in favor of a simple
RAII class that handles register invalidation.
gdb/ChangeLog
2017-09-25 Tom Tromey <tom@tromey.com>
* regcache.c (class regcache_invalidator): New.
(struct register_to_invalidate): Remove.
(make_cleanup_regcache_invalidate): Remove.
(regcache::raw_write): Use regcache_invalidator.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Allow the macw and macl instructions to be used on CPUs that have emacs support.
@ 2017-09-26 10:06 sergiodj+buildbot
2017-09-26 13:07 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-26 10:06 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 58a0b827444d0d6baad47f5fd010f33e541ed16e ***
Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 58a0b827444d0d6baad47f5fd010f33e541ed16e
Allow the macw and macl instructions to be used on CPUs that have emacs support.
>From PR 22123:
The common opcodes of emac and mac seem to be only implemented for mac.
To reproduce:
echo "macw %d3l,%a0l" > /tmp/dummy.S
m68k-unknown-elf-as -m5208 /tmp/dummy.S
Outputs something like:
/tmp/dummy.S: Assembler messages:
/tmp/dummy.S:1: Error: operands mismatch -- statement `macw %d3l,%a0l' ignored
This behavior occurs only if the CPU supports only emac but not explicitly mac (but emac is a superset of mac).
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove support for Solaris < 10 (PR gdb/22185)
@ 2017-09-26 14:35 sergiodj+buildbot
2017-09-26 17:55 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-26 14:35 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 281c4447738409888d9659924937da182a65b4e1 ***
Author: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Branch: master
Commit: 281c4447738409888d9659924937da182a65b4e1
Remove support for Solaris < 10 (PR gdb/22185)
Given that GCC has obsoleted/removed support for Solaris 9 in GCC 4.9/5 in 2013:
https://gcc.gnu.org/gcc-4.9/changes.html
https://gcc.gnu.org/ml/gcc-patches/2013-05/msg00728.html
and the last gdb version that can be compiled with gcc 4.9 is 7.12.1 only when
configured with --disable-build-with-cxx, it's time to obsolete/remove support
for Solaris < 10.
This patch does this, simplifying configure.nat along the way (only a single
sol2 configuration with variants for i386 and sparc).
Some configure checks for older Solaris versions can go, too, and the check
for libthread_db.so.1 removed:
* Since Solaris 10, dlopen has moved to libc and libdl.so is just a
filter on ld.so.1, so no need to check.
* $RDYNAMIC is already handled above (and is a no-op with Solaris ld
anyway).
Both proc-service.c and sol-thread.c lose support for (Solaris-only)
PROC_SERVICE_IS_OLD.
The attached revised patch has been tested on sparcv9-sun-solaris2.10,
sparcv9-sun-solaris2.11.4, amd64-pc-solaris2.10, amd64-pc-solaris2.11.4,
and x86_64-pc-linux-gnu.
I've also started an i386-pc-solaris2.9 build to check that it really
stops as expected.
PR gdb/22185
* configure.host <*-*-solaris2.[01], *-*-solaris2.[2-9]*>: Mark as
obsolete.
Use gdb_host sol2 for i[34567]86-*-solaris2*, x86_64-*-solaris2*.
Remove i386sol2 support.
* configure.nat <i386sol2>: Remove.
<sol2-64>: Fold into ...
<sol2>: ... this.
Move common settings to default section.
Add sol-thread.o.
* configure.tgt <i[34567]86-*-solaris2.1[0-9]*,
x86_64-*-solaris2.1[0-9]*>: Rename to ...
<i[34567]86-*-solaris2*, x86_64-*-solaris2*>: ... this.
<i[34567]86-*-solaris*>: Remove.
<sparc-*-solaris2.[0-6], sparc-*-solaris2.[0-6].*>: Remove.
* configure.ac: Remove wctype in libw check.
(_MSE_INT_H): Don't define on Solaris 7-9.
<solaris*>: Remove libthread_db.so.1 check.
* configure: Regenerate.
* config.in: Regenerate.
* proc-service.c: Remove PROC_SERVICE_IS_OLD handling.
(gdb_ps_prochandle_t, gdb_ps_read_buf_t, gdb_ps_write_buf_t)
(gdb_ps_size_t): Remove.
Use base types in users.
* sol-thread.c: Likewise, also for gdb_ps_addr_t.
* NEWS (Changes since GDB 8.0): Document Solaris 2.0-9 removal.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master
2017-09-26 14:35 [binutils-gdb] Remove support for Solaris < 10 (PR gdb/22185) sergiodj+buildbot
@ 2017-09-26 17:55 ` sergiodj+buildbot
0 siblings, 0 replies; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-26 17:55 UTC (permalink / raw)
To: gdb-testers
Buildslave:
ubuntu-trusty-aarch32-1
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-native-gdbserver-m32/builds/1513>
Commit(s) tested:
281c4447738409888d9659924937da182a65b4e1
Author(s) (in the same order as the commits):
Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Subject:
Remove support for Solaris < 10 (PR gdb/22185)
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-native-gdbserver-m32/28/281c4447738409888d9659924937da182a65b4e1/>
*** Diff to previous build ***
============================
new FAIL: gdb.threads/queue-signal.exp: determine thread functions
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=step: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=step: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=step: step to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=step: step does not change thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=step: current thread advanced - unlocked
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=0: set scheduler-locking off
new FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=0: setting breakpoint at 80 if arg != 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=0: continue to breakpoint: return to loop
new FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=0: delete all breakpoints in delete_breakpoints
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=0: print call_function = 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=0: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=0: next to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=0: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=0: other threads ran - unlocked
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: set scheduler-locking off
new FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: setting breakpoint at 80 if arg != 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: continue to breakpoint: return to loop
new FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: delete all breakpoints in delete_breakpoints
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: print call_function = 1
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: next to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: other threads ran - unlocked
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: set scheduler-locking off
new FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: setting breakpoint at 80 if arg != 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: continue to breakpoint: return to loop
new FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: delete all breakpoints in delete_breakpoints
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: set scheduler-locking step
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: print call_function = 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: step to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: set scheduler-locking off
new FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: setting breakpoint at 80 if arg != 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: continue to breakpoint: return to loop
new FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: delete all breakpoints in delete_breakpoints
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: set scheduler-locking step
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: print call_function = 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: next to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: set scheduler-locking off
new FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: setting breakpoint at 80 if arg != 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: continue to breakpoint: return to loop
new FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: delete all breakpoints in delete_breakpoints
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: set scheduler-locking step
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: print call_function = 1
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: next to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: set scheduler-locking off
new FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: setting breakpoint at 80 if arg != 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: continue to breakpoint: return to loop
new FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: delete all breakpoints in delete_breakpoints
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: set scheduler-locking on
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: print call_function = 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: step to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: set scheduler-locking off
new FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: setting breakpoint at 80 if arg != 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: continue to breakpoint: return to loop
new FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: delete all breakpoints in delete_breakpoints
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: set scheduler-locking on
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: print call_function = 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: next to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: set scheduler-locking off
new FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: setting breakpoint at 80 if arg != 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: continue to breakpoint: return to loop
new FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: delete all breakpoints in delete_breakpoints
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: set scheduler-locking on
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: print call_function = 1
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: next to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: find current thread
============================
*** Complete list of XFAILs for this builder ***
To obtain the list of XFAIL tests for this builder, go to:
<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch32-native-gdbserver-m32/xfails/master/xfail;hb=>
You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:
<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch32-native-gdbserver-m32/xfails/master/xfail.table;hb=>
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Avoid needless resource usage when processing a corrupt DWARF directory or file name table.
@ 2017-09-26 15:21 sergiodj+buildbot
2017-09-26 19:23 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-26 15:21 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 30d0157a2ad64e64e5ff9fcc0dbe78a3e682f573 ***
Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 30d0157a2ad64e64e5ff9fcc0dbe78a3e682f573
Avoid needless resource usage when processing a corrupt DWARF directory or file name table.
PR 22210
* dwarf2.c (read_formatted_entries): Fail early if we know that
the loop parsing data entries will overflow the end of the
section.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Tidy reading data in read_formatted_entries
@ 2017-09-26 16:00 sergiodj+buildbot
2017-09-26 21:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-26 16:00 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 33e0a9a056bd23e923b929a4f2ab049ade0b1c32 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 33e0a9a056bd23e923b929a4f2ab049ade0b1c32
Tidy reading data in read_formatted_entries
Using read_attribute_value accomplishes two things: It checks for
unexpected formats, and ensures the buffer pointer always increments.
PR 22210
* dwarf2.c (read_formatted_entries): Use read_attribute_value to
read data.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Allow linking GDB with ncursesw
@ 2017-09-26 17:12 sergiodj+buildbot
2017-09-26 23:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-26 17:12 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 5007d765ae09c10c7f3b18bb16841b9d2d59e181 ***
Author: Matthias Klose <doko@ubuntu.com>
Branch: master
Commit: 5007d765ae09c10c7f3b18bb16841b9d2d59e181
Allow linking GDB with ncursesw
Triggered by https://launchpad.net/bugs/1275210, to be able to cope
with UTF-8 characters in gdbtui.
Reference:
https://sourceware.org/ml/gdb-patches/2017-09/msg00356.html
gdb/ChangeLog:
2017-09-26 Matthias Klose <doko@ubuntu.com>
* configure.ac: Search ncursesw before ncurses.
Check ncursesw/ncurses.h before ncurses/ncurses.h.
* gdb_curses.h: Include <ncursesw/ncurses.h>
* config.in, configure: Regenerate.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Use "switch_to_thread" more thoroughly on gdbserver
@ 2017-09-26 17:59 sergiodj+buildbot
2017-09-27 1:38 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-26 17:59 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 75352e283fb2b265d14c750859156943f6eb2693 ***
Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: 75352e283fb2b265d14c750859156943f6eb2693
Use "switch_to_thread" more thoroughly on gdbserver
This is a technical debt that I left when I ported "switch_to_thread"
to gdbserver. It's a simple patch that converts occurences of:
current_thread = find_thread_ptid (ptid);
to:
switch_to_thread (ptid);
This patch also converts a simple "if" to a "gdb_assert" on
gdbserver's version of "switch_to_thread":
gdb_assert (ptid != minus_one_ptid);
This change makes the code more similar to what GDB already does.
Regtested on BuildBot.
gdb/gdbserver/ChangeLog:
2017-09-26 Sergio Durigan Junior <sergiodj@redhat.com>
* gdbthread.h: Include "common-gdbthread.h".
* inferiors.c (switch_to_thread): Use "gdb_assert" instead of
"if" when validating the ptid.
* remote-utils.c: Include "gdbthread.h".
(prepare_resume_reply): Use "switch_to_thread".
* target.c (done_accessing_memory): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] dwarf2read: Restrict ICC workaround to ICC<14
@ 2017-09-26 18:56 sergiodj+buildbot
2017-09-27 6:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-26 18:56 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 5230b05a94b964da335a0758686b92a8efcc823d ***
Author: Walfred Tedeschi <walfred.tedeschi@intel.com>
Branch: master
Commit: 5230b05a94b964da335a0758686b92a8efcc823d
dwarf2read: Restrict ICC workaround to ICC<14
GDB has a workaround for DWARF output by ICC, related to missing
DW_AT_declaration on incomplete types. The bug was fixed in ICC 14,
so this commit adjusts GDB accordingly.
For the version check, this adds a new parser function for the ICC
producer string. While at it, it also adds unit tests for the
producer parsing covering the new function and preexisting parsers.
gdb/ChangeLog:
2017-09-26 Walfred Tedeschi <walfred.tedeschi@intel.com>
Pedro Alves <palves@redhat.com>
* dwarf2read.c (dwarf2_cu): Remove field producer_is_icc and add
producer_is_icc_lt_14.
(producer_is_icc_lt_14): New function.
(check_producer): Add code for checking version of ICC.
(producer_is_icc): Move to producer.c.
(read_structure_type): Restrict ICC workaround to ICC<14.
* producer.c: Include selftest.h.
(producer_is_icc, producer_parsing_tests, _initialize_producer):
New functions.
* producer.h (producer_is_icc): New declaration.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master
2017-09-26 18:56 [binutils-gdb] dwarf2read: Restrict ICC workaround to ICC<14 sergiodj+buildbot
@ 2017-09-27 6:19 ` sergiodj+buildbot
0 siblings, 0 replies; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-27 6:19 UTC (permalink / raw)
To: gdb-testers
Buildslave:
ubuntu-trusty-aarch32-1
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-native-gdbserver-m32/builds/1520>
Commit(s) tested:
5230b05a94b964da335a0758686b92a8efcc823d
Author(s) (in the same order as the commits):
Walfred Tedeschi <walfred.tedeschi@intel.com>
Subject:
dwarf2read: Restrict ICC workaround to ICC<14
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-native-gdbserver-m32/52/5230b05a94b964da335a0758686b92a8efcc823d/>
*** Diff to previous build ***
============================
PASS -> FAIL: gdb.base/starti.exp: continue
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
new FAIL: gdb.threads/queue-signal.exp: determine thread functions
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=0: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=0: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=0: next to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=0: next does not change thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=0: current thread advanced - unlocked
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: set scheduler-locking off
new FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: setting breakpoint at 80 if arg != 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: continue to breakpoint: return to loop
new FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: delete all breakpoints in delete_breakpoints
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: print call_function = 1
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: next to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: other threads ran - unlocked
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: set scheduler-locking off
new FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: setting breakpoint at 80 if arg != 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: continue to breakpoint: return to loop
new FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: delete all breakpoints in delete_breakpoints
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: set scheduler-locking step
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: print call_function = 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: step to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: set scheduler-locking off
new FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: setting breakpoint at 80 if arg != 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: continue to breakpoint: return to loop
new FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: delete all breakpoints in delete_breakpoints
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: set scheduler-locking step
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: print call_function = 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: next to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: set scheduler-locking off
new FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: setting breakpoint at 80 if arg != 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: continue to breakpoint: return to loop
new FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: delete all breakpoints in delete_breakpoints
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: set scheduler-locking step
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: print call_function = 1
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: next to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: set scheduler-locking off
new FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: setting breakpoint at 80 if arg != 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: continue to breakpoint: return to loop
new FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: delete all breakpoints in delete_breakpoints
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: set scheduler-locking on
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: print call_function = 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: step to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: set scheduler-locking off
new FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: setting breakpoint at 80 if arg != 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: continue to breakpoint: return to loop
new FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: delete all breakpoints in delete_breakpoints
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: set scheduler-locking on
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: print call_function = 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: next to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: set scheduler-locking off
new FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: setting breakpoint at 80 if arg != 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: continue to breakpoint: return to loop
new FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: delete all breakpoints in delete_breakpoints
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: set scheduler-locking on
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: print call_function = 1
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: next to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: find current thread
============================
*** Complete list of XFAILs for this builder ***
To obtain the list of XFAIL tests for this builder, go to:
<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch32-native-gdbserver-m32/xfails/master/xfail;hb=>
You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:
<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch32-native-gdbserver-m32/xfails/master/xfail.table;hb=>
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86-64: Don't pass output_bfd to info->callbacks->minfo
@ 2017-09-26 22:02 sergiodj+buildbot
2017-09-27 6:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-26 22:02 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ac69a0d75bf472a140e5405c8a90420d5f63a998 ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: ac69a0d75bf472a140e5405c8a90420d5f63a998
x86-64: Don't pass output_bfd to info->callbacks->minfo
Don't pass output_bfd to info->callbacks->minfo when dumping local IFUNC
functions in the map file.
PR ld/22199
* elf64-x86-64.c (elf_x86_64_finish_dynamic_symbol): Don't pass
output_bfd to info->callbacks->minfo.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add support for __VA_OPT__
@ 2017-09-27 14:49 sergiodj+buildbot
2017-09-27 16:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-27 14:49 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a9bbfbd85fddfea2db30810c33c4bb130a2ef773 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: a9bbfbd85fddfea2db30810c33c4bb130a2ef773
Add support for __VA_OPT__
C++2a adds a "__VA_OPT__" feature that can be used to control the
pesky "," emission when the final (variable) argument of a variadic
macro is empty. This patch implements this feature for gdb. (A patch
to implement it for gcc is pending.)
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* macroexp.c (get_next_token_for_substitution): New function.
(substitute_args): Call it. Check for __VA_OPT__.
gdb/testsuite/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* gdb.base/macscp.exp: Add __VA_OPT__ tests.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add add_cmd function overloads
@ 2017-09-27 15:48 sergiodj+buildbot
2017-09-27 17:00 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-27 15:48 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 0450cc4ce8b4775c47e9aaa1c5a34e181b10ae98 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 0450cc4ce8b4775c47e9aaa1c5a34e181b10ae98
Add add_cmd function overloads
This adds two add_cmd overloads: one whose callback takes a const char *,
and one that doesn't accept a function at all. The no-function overload
was introduced to avoid ambiguity when NULL was passed as the function.
Long term the goal is for all commands to take const arguments, and
for the non-const variants to be removed entirely.
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* cli/cli-decode.c (add_cmd, set_cmd_cfunc): New function
overloads.
(do_add_cmd): Rename from add_cmd. Don't call set_cmd_cfunc.
(do_const_cfunc): New function.
(cmd_cfunc_eq): New overload.
(cli_user_command_p): Check do_const_cfunc.
* cli/cli-decode.h (struct cmd_list_element) <function>: New field
const_cfunc.
* command.h (add_cmd): Add const overload and no-function
overload.
(set_cmd_cfunc): Add const overload.
(cmd_const_cfunc_ftype): Declare.
(cmd_cfunc_eq): Add const overload.
* breakpoint.c, cli-cmds.c, cli-dump.c, guile/scm-cmd.c,
python/py-cmd.c, target.c, tracepoint.c: Use no-function add_cmd
overload.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Constify not_just_help_class_command
@ 2017-09-27 17:17 sergiodj+buildbot
2017-09-27 19:59 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-27 17:17 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT eb7c454d737322be2d810e1a5a2dc7b88fd636e6 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: eb7c454d737322be2d810e1a5a2dc7b88fd636e6
Constify not_just_help_class_command
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* command.h (not_just_help_class_command): Update.
* cli/cli-decode.h (not_just_help_class_command): Update.
* cli/cli-decode.c (not_just_help_class_command): Constify.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master
2017-09-27 17:17 [binutils-gdb] Constify not_just_help_class_command sergiodj+buildbot
@ 2017-09-27 19:59 ` sergiodj+buildbot
0 siblings, 0 replies; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-27 19:59 UTC (permalink / raw)
To: gdb-testers
Buildslave:
ubuntu-trusty-aarch32-1
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-native-gdbserver-m32/builds/1526>
Commit(s) tested:
eb7c454d737322be2d810e1a5a2dc7b88fd636e6
Author(s) (in the same order as the commits):
Tom Tromey <tom@tromey.com>
Subject:
Constify not_just_help_class_command
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-native-gdbserver-m32/eb/eb7c454d737322be2d810e1a5a2dc7b88fd636e6/>
*** Diff to previous build ***
============================
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=step: step does not change thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=step: current thread advanced - unlocked
new FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=0: setting breakpoint at 80 if arg != 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=0: other threads ran - unlocked
new FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: setting breakpoint at 80 if arg != 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: other threads ran - unlocked
new FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: setting breakpoint at 80 if arg != 0
new FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: setting breakpoint at 80 if arg != 0
new FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: setting breakpoint at 80 if arg != 0
new FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: setting breakpoint at 80 if arg != 0
new FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: setting breakpoint at 80 if arg != 0
new FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: delete all breakpoints in delete_breakpoints
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: set scheduler-locking on
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: print call_function = 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: next to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: set scheduler-locking off
new FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: setting breakpoint at 80 if arg != 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: continue to breakpoint: return to loop
new FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: delete all breakpoints in delete_breakpoints
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: set scheduler-locking on
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: print call_function = 1
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: next to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: find current thread
new FAIL: gdb.threads/sigstep-threads.exp: step 90
============================
*** Complete list of XFAILs for this builder ***
To obtain the list of XFAIL tests for this builder, go to:
<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch32-native-gdbserver-m32/xfails/master/xfail;hb=>
You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:
<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch32-native-gdbserver-m32/xfails/master/xfail.table;hb=>
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Constify info_probes_dtrace_command
@ 2017-09-27 17:48 sergiodj+buildbot
2017-09-27 21:41 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-27 17:48 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 8d97dc1cea4d1dafff2ce2f55e0b84cfe444e6cf ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 8d97dc1cea4d1dafff2ce2f55e0b84cfe444e6cf
Constify info_probes_dtrace_command
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* dtrace-probe.c (info_probes_dtrace_command): Constify.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Constify two functions in cp-abi.c
@ 2017-09-27 18:56 sergiodj+buildbot
2017-09-28 1:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-27 18:56 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 4ada038f6a8330b27769ad0227c7f716aa29b649 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 4ada038f6a8330b27769ad0227c7f716aa29b649
Constify two functions in cp-abi.c
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* cp-abi.c (set_cp_abi_cmd, show_cp_abi_cmd): Constify.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Constify two functions in linux-fork.c
@ 2017-09-27 19:06 sergiodj+buildbot
2017-09-28 2:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-27 19:06 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 5b64bf744c04f550a9d15b49a8cb0245904afb13 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 5b64bf744c04f550a9d15b49a8cb0245904afb13
Constify two functions in linux-fork.c
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* linux-fork.c (delete_checkpoint_command)
(detach_checkpoint_command): Constify.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Constify two functions in valprint.c
@ 2017-09-27 19:37 sergiodj+buildbot
2017-09-27 22:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-27 19:37 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b0a8e6c4431a2e762dac88f3d73efca4bc47c90a ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: b0a8e6c4431a2e762dac88f3d73efca4bc47c90a
Constify two functions in valprint.c
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* valprint.c (set_radix, show_radix): Constify.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Constify some functions in psymtab.c
@ 2017-09-27 19:46 sergiodj+buildbot
2017-09-28 5:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-27 19:46 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 990b9f9f5a301cef9c16035c341a7b0b7ccc983d ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 990b9f9f5a301cef9c16035c341a7b0b7ccc983d
Constify some functions in psymtab.c
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* psymtab.c (maintenance_print_psymbols)
(maintenance_info_psymtabs, maintenance_check_psymtabs):
Constify.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Constify first_component_command
@ 2017-09-27 20:01 sergiodj+buildbot
2017-09-28 6:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-27 20:01 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 4a47555179bfcfd3c9e4ad2752e38ae398fc7dcd ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 4a47555179bfcfd3c9e4ad2752e38ae398fc7dcd
Constify first_component_command
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* cp-support.c (first_component_command): Constify.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Constify maintenance_cplus_namespace
@ 2017-09-27 20:54 sergiodj+buildbot
2017-09-28 7:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-27 20:54 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 32a7bf17c94a81c08535ea045f43fe8c8271d3fd ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 32a7bf17c94a81c08535ea045f43fe8c8271d3fd
Constify maintenance_cplus_namespace
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* cp-namespace.c (maintenance_cplus_namespace): Constify.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Constify maintenance_print_user_registers
@ 2017-09-27 21:51 sergiodj+buildbot
2017-09-28 9:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-27 21:51 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 4d4589ef76b975eead8da6bfa65db4a9dc85089a ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 4d4589ef76b975eead8da6bfa65db4a9dc85089a
Constify maintenance_print_user_registers
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* user-regs.c (maintenance_print_user_registers): Constify.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Constify show_convenience
@ 2017-09-27 23:15 sergiodj+buildbot
2017-09-28 11:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-27 23:15 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ad25e4234a3f370a693b9c392c5b54216aab4592 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: ad25e4234a3f370a693b9c392c5b54216aab4592
Constify show_convenience
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* value.c (show_convenience): Constify.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Constify some functions in memattr.c
@ 2017-09-27 23:21 sergiodj+buildbot
2017-09-28 12:39 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-27 23:21 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 4465d9db2f8962640f3799a17851bef3b1be1a33 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 4465d9db2f8962640f3799a17851bef3b1be1a33
Constify some functions in memattr.c
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* memattr.c (enable_mem_command, disable_mem_command)
(delete_mem_command): Constify.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Constify cmd_record_full_restore
@ 2017-09-28 0:29 sergiodj+buildbot
2017-09-28 14:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-28 0:29 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 41243651350688a9a0f3a3542871d37e7f3c5f20 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 41243651350688a9a0f3a3542871d37e7f3c5f20
Constify cmd_record_full_restore
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* record-full.c (cmd_record_full_restore): Constify.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Constify interpreter_exec_cmd
@ 2017-09-28 0:41 sergiodj+buildbot
2017-09-28 15:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-28 0:41 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 1970a12f32f788f22b641737e846350e1ff9dd04 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 1970a12f32f788f22b641737e846350e1ff9dd04
Constify interpreter_exec_cmd
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* interps.c (interpreter_exec_cmd): Constify.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Constify commands in cli-dump.c
@ 2017-09-28 1:36 sergiodj+buildbot
2017-09-28 22:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-28 1:36 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2d0ac1068babfe8800607b17ddb2f31189bdb334 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 2d0ac1068babfe8800607b17ddb2f31189bdb334
Constify commands in cli-dump.c
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* cli/cli-dump.c (dump_memory_command, dump_value_command)
(dump_srec_memory, dump_srec_value, dump_ihex_memory)
(dump_ihex_value, dump_verilog_memory, dump_verilog_value)
(dump_tekhex_memory, dump_tekhex_value, dump_binary_memory)
(dump_binary_value, append_binary_memory, append_binary_value):
Constify.
(struct dump_context) <func>: Constify.
(add_dump_command): Update.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Constify core_file_command
@ 2017-09-28 2:14 sergiodj+buildbot
2017-09-28 10:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-28 2:14 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d64097b17c88ae18781ecce59d1b265b41e9551a ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: d64097b17c88ae18781ecce59d1b265b41e9551a
Constify core_file_command
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* gdbcore.h (core_file_command): Update.
* corefile.c (core_file_command): Constify.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove cleanup from complaints.c
@ 2017-09-30 7:29 sergiodj+buildbot
2017-10-02 7:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-30 7:29 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 55b064321eed6cccf511fd698c732890e3ba4c6b ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 55b064321eed6cccf511fd698c732890e3ba4c6b
Remove cleanup from complaints.c
This removes a cleanup from complaints.c by using std::string.
gdb/ChangeLog
2017-09-29 Tom Tromey <tom@tromey.com>
* complaints.c (vcomplaint): Use std::string.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove cleanup from xstormy16-tdep.c
@ 2017-09-30 7:51 sergiodj+buildbot
2017-10-02 8:32 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-30 7:51 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 726b2169b4cda6a0267cb2986ada758270cff093 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 726b2169b4cda6a0267cb2986ada758270cff093
Remove cleanup from xstormy16-tdep.c
This removes a cleanup from xstormy16-tdep.c, using gdb::byte_vector.
gdb/ChangeLog
2017-09-29 Tom Tromey <tom@tromey.com>
* xstormy16-tdep.c (xstormy16_push_dummy_call): Use
gdb::byte_vector.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove a cleanup from symtab.c
@ 2017-09-30 9:29 sergiodj+buildbot
2017-10-02 11:21 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-30 9:29 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 99ef965c6e812cc73691873c965cff0d2d5b89a0 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 99ef965c6e812cc73691873c965cff0d2d5b89a0
Remove a cleanup from symtab.c
This removes an unused outer cleanup from symtab.c, and an unused
cleanup declaration as well.
gdb/ChangeLog
2017-09-29 Tom Tromey <tom@tromey.com>
* symtab.c (search_symbols): Remove unused outer cleanup.
(make_source_files_completion_list): Remove unused declaration.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove make_cleanup_defer_target_commit_resume
@ 2017-09-30 10:20 sergiodj+buildbot
2017-10-02 14:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-30 10:20 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a9bc57b97840a874ad2802e29a44fbf557668808 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: a9bc57b97840a874ad2802e29a44fbf557668808
Remove make_cleanup_defer_target_commit_resume
This removes make_cleanup_defer_target_commit_resume in favor of using
scoped_restore.
gdb/ChangeLog
2017-09-29 Tom Tromey <tom@tromey.com>
* target.h (make_scoped_defer_target_commit_resume): Update.
* target.c (make_scoped_defer_target_commit_resume): Rename from
make_cleanup_defer_target_commit_resume. Return a
scoped_restore.
* infrun.c (proceed): Use make_scoped_defer_target_commit_resume.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove cleanups from mi_cmd_break_insert_1
@ 2017-09-30 11:26 sergiodj+buildbot
2017-10-02 15:02 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-30 11:26 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 784c453a4f1aeee237203dd6257a6ed24bee28c3 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 784c453a4f1aeee237203dd6257a6ed24bee28c3
Remove cleanups from mi_cmd_break_insert_1
This changes mi_argv_to_format to return a string, allowing the
removal of some cleanups.
gdb/ChangeLog
2017-09-29 Tom Tromey <tom@tromey.com>
* mi/mi-cmd-break.c (mi_argv_to_format): Return std::string.
(mi_cmd_break_insert_1): Update.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove cleanups from mi-cmd-var.c
@ 2017-09-30 11:49 sergiodj+buildbot
2017-10-02 16:13 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-30 11:49 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2d6960b4568869baaa3cb40f75caed4021938e1c ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 2d6960b4568869baaa3cb40f75caed4021938e1c
Remove cleanups from mi-cmd-var.c
This removes some cleanups from mi-cmd-var.c. varobj_gen_name now
returns a string, simplifying mi_cmd_var_create. In
mi_cmd_var_delete, a string copy is apparently unnecessary, so it's
simply removed.
gdb/ChangeLog
2017-09-29 Tom Tromey <tom@tromey.com>
* varobj.h (varobj_gen_name): Return std::string.
* varobj.c (varobj_gen_name): Return std::string.
* mi/mi-cmd-var.c (mi_cmd_var_create): Use std::string.
(mi_cmd_var_delete): Don't copy "name".
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Use std::string in mi-main.c
@ 2017-09-30 15:12 sergiodj+buildbot
2017-10-02 22:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-09-30 15:12 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT dcd5ddccd7d7917caf42b8d429a7535857c6e9b2 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: dcd5ddccd7d7917caf42b8d429a7535857c6e9b2
Use std::string in mi-main.c
Change a couple of spots in mi-main.c to use std::string, and change
one place to use field_fmt. This removes some cleanups.
gdb/ChangeLog
2017-09-29 Tom Tromey <tom@tromey.com>
* mi/mi-main.c (mi_execute_cli_command): Use std::string.
(mi_execute_async_cli_command): Likewise.
(mi_cmd_trace_frame_collected): Use field_fmt.
^ permalink raw reply [flat|nested] 2083+ messages in thread
[parent not found: <8abcee91738bf0be98e949049c559839ef811ae4@gdb-build>]
[parent not found: <9754d8c4c48209eaefb044d03dc25f14dca8a263@gdb-build>]
[parent not found: <6afe2f4a39badf0ea1ccf9fd34417e729577c6e6@gdb-build>]
* [binutils-gdb] Allow indexing of &str in Rust
@ 2017-10-02 20:33 sergiodj+buildbot
2017-10-03 11:57 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-02 20:33 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 01af5e0d09ac9c621e7b280f44a2c7ef55784493 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 01af5e0d09ac9c621e7b280f44a2c7ef55784493
Allow indexing of &str in Rust
rust_slice_type_p was not recognizing &str as a slice type, so indexing
into (or making a slice of) a slice was not working.
2017-10-02 Tom Tromey <tom@tromey.com>
* rust-lang.c (rust_slice_type_p): Recognize &str as a slice type.
2017-10-02 Tom Tromey <tom@tromey.com>
* gdb.rust/simple.exp: Test index of slice.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix ptype of Rust slices
@ 2017-10-02 21:04 sergiodj+buildbot
2017-10-03 13:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-02 21:04 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b3e3859bc577db5b79bb3d39048fd46c0a0420ef ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: b3e3859bc577db5b79bb3d39048fd46c0a0420ef
Fix ptype of Rust slices
Something like "ptype &x[..]" (where "x" was a slice) would crash gdb.
rust_subscript wasn't handling slicing in the EVAL_AVOID_SIDE_EFFECTS
case.
2017-10-02 Tom Tromey <tom@tromey.com>
* rust-lang.c (rust_subscript): Handle slices in
EVAL_AVOID_SIDE_EFFECTS case.
2017-10-02 Tom Tromey <tom@tromey.com>
* gdb.rust/simple.exp: Test ptype of a slice.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Change record_full_gdb_operation_disable_set not to return a cleanup
@ 2017-10-03 12:07 sergiodj+buildbot
2017-10-03 15:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-03 12:07 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 070365117b5727394e271399c5738a27bf9716d5 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 070365117b5727394e271399c5738a27bf9716d5
Change record_full_gdb_operation_disable_set not to return a cleanup
This changes record_full_gdb_operation_disable_set to return a
scoped_restore rather than a cleanup, and fixes all the users.
ChangeLog
2017-10-03 Tom Tromey <tom@tromey.com>
* record-full.h (record_full_gdb_operation_disable_set): Return
scoped_restore_tmpl<int>.
* infrun.c (adjust_pc_after_break): Update.
(handle_signal_stop): Update.
* record-full.c (record_full_gdb_operation_disable_set): Return
scoped_restore_tmpl<int>.
(record_full_wait_1, record_full_insert_breakpoint)
(record_full_remove_breakpoint, record_full_save)
(record_full_goto_insn): Update.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Update my email address.
@ 2017-10-03 21:48 sergiodj+buildbot
2017-10-03 22:30 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-03 21:48 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c0107b0f57bc958b640dabafd4c6c618ea023397 ***
Author: Jim Wilson <jim.wilson@linaro.org>
Branch: master
Commit: c0107b0f57bc958b640dabafd4c6c618ea023397
Update my email address.
sim/
* MAINTAINERS (aarch64): Update my email address.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Introduce gdb_tilde_expand
@ 2017-10-04 6:40 sergiodj+buildbot
2017-10-04 7:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-04 6:40 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 7da0a8867419fc4a2a64d49cc71a14bd145cebff ***
Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: 7da0a8867419fc4a2a64d49cc71a14bd145cebff
Introduce gdb_tilde_expand
Currently, whenever we want to handle paths provided by the user and
perform tilde expansion on GDB, we rely on "tilde_expand", which comes
from readline. This was enough for our use cases so far, but the
situation will change when we start dealing with paths on gdbserver as
well, which is what the next patches implement.
Unfortunately it is not possible to use "tilde_expand" in this case
because gdbserver doesn't use readline. For that reason I decided to
implement a new "gdb_tilde_expand" function, which is basically a
wrapper for "glob" and its GNU extension, GLOB_TILDE_CHECK. With the
import of the "glob" module from gnulib, we're sure that "glob" always
supports this extension.
gdb/ChangeLog:
2017-10-04 Sergio Durigan Junior <sergiodj@redhat.com>
* Makefile.in (SFILES): Add gdb_tilde_expand.c.
(HFILES_NO_SRCDIR): Add gdb_tilde_expand.h.
(COMMON_OBS): Add gdb_tilde_expand.o.
* common/gdb_tilde_expand.c: New file.
* common/gdb_tilde_expand.h: Likewise.
gdb/gdbserver/ChangeLog:
2017-10-04 Sergio Durigan Junior <sergiodj@redhat.com>
* Makefile.in (SFILES): Add $(srcdir)/common/gdb_tilde_expand.c.
(OBS): Add gdb_tilde_expand.o.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Implement "set cwd" command on GDB
@ 2017-10-04 6:49 sergiodj+buildbot
2017-10-04 8:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-04 6:49 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d092c5a2465ece3435131ae6fef1ccb6e70986cb ***
Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: d092c5a2465ece3435131ae6fef1ccb6e70986cb
Implement "set cwd" command on GDB
This commit adds new "set/show cwd" commands, which are used to
set/show the current working directory of the inferior that will be
started.
The idea here is that "set cwd" will become the de facto way of
setting the inferior's cwd. Currently, the user can use "cd" for
that, but there are side effects: with "cd", GDB also switches to
another directory, and that can impact the loading of scripts and
other files. With "set cwd", we separate the logic into a new
command.
To maintain backward compatibility, if the user issues a "cd" command
but doesn't use "set cwd", then the inferior's cwd will still be
changed according to what the user specified. However, "set cwd" has
precedence over "cd", so it can always be used to override it.
"set cwd" works in the following way:
- If the user sets the inferior's cwd by using "set cwd", then this
directory is saved into current_inferior ()->cwd and is used when
the inferior is started (see below).
- If the user doesn't set the inferior's cwd by using "set cwd", but
rather use the "cd" command as before, then this directory is
inherited by the inferior because GDB will have chdir'd into it.
On Unix-like hosts, the way the directory is changed before the
inferior execution is by expanding the user set directory before the
fork, and then "chdir" after the call to fork/vfork on
"fork_inferior", but before the actual execution. On Windows, the
inferior cwd set by the user is passed directly to the CreateProcess
call, which takes care of the actual chdir for us.
This way, we'll make sure that GDB's cwd is not affected by the user
set cwd.
gdb/ChangeLog:
2017-10-04 Sergio Durigan Junior <sergiodj@redhat.com>
* NEWS (New commands): Mention "set/show cwd".
* cli/cli-cmds.c (_initialize_cli_cmds): Mention "set cwd" on
"cd" command's help text.
* common/common-inferior.h (get_inferior_cwd): New prototype.
* infcmd.c (inferior_cwd_scratch): New global variable.
(set_inferior_cwd): New function.
(get_inferior_cwd): Likewise.
(set_cwd_command): Likewise.
(show_cwd_command): Likewise.
(_initialize_infcmd): Add "set/show cwd" commands.
* inferior.h (class inferior) <cwd>: New field.
* nat/fork-inferior.c: Include "gdb_tilde_expand.h".
(fork_inferior): Change inferior's cwd before its execution.
* windows-nat.c (windows_create_inferior): Pass inferior's cwd
to CreateProcess.
gdb/gdbserver/ChangeLog:
2017-10-04 Sergio Durigan Junior <sergiodj@redhat.com>
* inferiors.c (current_inferior_cwd): New global variable.
(get_inferior_cwd): New function.
* inferiors.h (struct process_info) <cwd>: New field.
gdb/doc/ChangeLog:
2017-10-04 Sergio Durigan Junior <sergiodj@redhat.com>
* gdb.texinfo (Starting your Program) <The working directory.>:
Mention new "set cwd" command.
(Working Directory) <Your Program's Working Directory>:
Rephrase to explain that "set cwd" exists and is the default
way to change the inferior's cwd.
gdb/testsuite/ChangeLog:
2017-10-04 Sergio Durigan Junior <sergiodj@redhat.com>
* gdb.base/set-cwd.c: New file.
* gdb.base/set-cwd.exp: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Extend "set cwd" to work on gdbserver
@ 2017-10-04 7:08 sergiodj+buildbot
2017-10-04 10:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-04 7:08 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT bc3b087de2401c65c02730d346e8bea4dc0504ae ***
Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: bc3b087de2401c65c02730d346e8bea4dc0504ae
Extend "set cwd" to work on gdbserver
This is the "natural" extension necessary for the "set cwd" command
(and the whole "set the inferior's cwd" logic) to work on gdbserver.
The idea here is to have a new remote packet, QSetWorkingDir (name
adopted from LLDB's extension to the RSP, as can be seen at
<https://raw.githubusercontent.com/llvm-mirror/lldb/master/docs/lldb-gdb-remote.txt>),
which sends an hex-encoded string representing the working directory
that the remote inferior will use. There is a slight difference from
the packet proposed by LLDB: GDB's version will accept empty
arguments, meaning that the user wants to clear the previously set
working directory for the inferior (i.e., "set cwd" without arguments
on GDB).
For UNIX-like targets this feature is already implemented on
nat/fork-inferior.c, and all gdbserver has to do is to basically
implement "set_inferior_cwd" and call it whenever such packet arrives.
For other targets, like Windows, it is possible to use the existing
"get_inferior_cwd" function and do the necessary steps to make sure
that the inferior will use the specified working directory.
Aside from that, the patch consists basically of updates to the
testcase (making it available on remote targets) and the
documentation.
No regressions found.
gdb/ChangeLog:
2017-10-04 Sergio Durigan Junior <sergiodj@redhat.com>
* NEWS (Changes since GDB 8.0): Add entry about new
'set-cwd-on-gdbserver' feature.
(New remote packets): Add entry for QSetWorkingDir.
* common/common-inferior.h (set_inferior_cwd): New prototype.
* infcmd.c (set_inferior_cwd): Remove "static".
(show_cwd_command): Expand text to include remote debugging.
* remote.c: Add PACKET_QSetWorkingDir.
(remote_protocol_features) <QSetWorkingDir>: New entry for
PACKET_QSetWorkingDir.
(extended_remote_set_inferior_cwd): New function.
(extended_remote_create_inferior): Call
"extended_remote_set_inferior_cwd".
(_initialize_remote): Call "add_packet_config_cmd" for
QSetWorkingDir.
gdb/gdbserver/ChangeLog:
2017-10-04 Sergio Durigan Junior <sergiodj@redhat.com>
* inferiors.c (set_inferior_cwd): New function.
* server.c (handle_general_set): Handle QSetWorkingDir packet.
(handle_query): Inform that QSetWorkingDir is supported.
* win32-low.c (create_process): Pass the inferior's cwd to
CreateProcess.
gdb/testsuite/ChangeLog:
2017-10-04 Sergio Durigan Junior <sergiodj@redhat.com>
* gdb.base/set-cwd.exp: Make it available on
native-extended-gdbserver.
gdb/doc/ChangeLog:
2017-10-04 Sergio Durigan Junior <sergiodj@redhat.com>
* gdb.texinfo (Starting your Program) <The working directory.>:
Mention remote debugging.
(Working Directory) <Your Program's Working Directory>:
Likewise.
(Connecting) <Remote Packet>: Add "set-working-dir"
and "QSetWorkingDir" to the table.
(Remote Protocol) <QSetWorkingDir>: New item, explaining the
packet.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Move code out of 'between TRY and CATCH'
@ 2017-10-04 12:21 sergiodj+buildbot
2017-10-04 13:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-04 12:21 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 73dcd72d4eeec176f769660ddcdefd1f25d0a2ec ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 73dcd72d4eeec176f769660ddcdefd1f25d0a2ec
Move code out of 'between TRY and CATCH'
I tried building GDB with TRY/CATCH mapped to raw C++ try/catch (by
defining GDB_XCPT to GDB_XCPT_RAW_TRY in
gdb/common/common-exceptions.h), and that caught a case of code
written between try and catch. This commit fixes it.
gdb/ChangeLog:
2017-10-04 Pedro Alves <palves@redhat.com>
* guile/scm-breakpoint.c (gdbscm_breakpoint_commands): Move code
out of 'between TRY and CATCH'.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix -list-thread-groups --available logic and add test
@ 2017-10-04 16:48 sergiodj+buildbot
2017-10-04 17:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-04 16:48 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 4c71c1059f876fcca9809f7b6372b721ddb83635 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 4c71c1059f876fcca9809f7b6372b721ddb83635
Fix -list-thread-groups --available logic and add test
New in v3:
- Replace use_gdb_stub with can_spawn_for_attach.
- Call kill_wait_spawned_process on spawn_ids.
Commit
Use std::set in mi-main.c
52f9abe4c739f42cc5f80b2629276493ac6306f9
changed the logic of the "-list-thread-groups --available" by mistake
when a pid is passed. It prints all the processes except the one
specified by the given pid. The correct behavior is to only print the
process corresponding to that pid. this patch fixes that and adds a test.
gdb/ChangeLog:
* mi/mi-main.c (list_available_thread_groups): Reverse filter logic.
gdb/testsuite/ChangeLog:
* gdb.mi/list-thread-groups-available.exp: New file.
* gdb.mi/list-thread-groups-available.c: New file.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix "Remote 'g' packet reply is too long" problems with multiple inferiors
@ 2017-10-04 17:39 sergiodj+buildbot
2017-10-04 21:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-04 17:39 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 5cd63fda035d4ba949e6478406162c4673b3c9ef ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 5cd63fda035d4ba949e6478406162c4673b3c9ef
Fix "Remote 'g' packet reply is too long" problems with multiple inferiors
When debugging two inferiors (or more) against gdbserver, and the
inferiors have different architectures, such as e.g., on x86_64
GNU/Linux and one inferior is 64-bit while the other is 32-bit, then
GDB can get confused with the different architectures in a couple
spots.
In both cases I ran into, GDB incorrectly ended up using the
architecture of whatever happens to be the selected inferior instead
of the architecture of some other given inferior:
#1 - When parsing the expedited registers in stop replies.
#2 - In the default implementation of the target_thread_architecture
target method.
These resulted in instances of the infamous "Remote 'g' packet reply
is too long" error. For example, with the test added in this commit,
we get:
~~~
Continuing.
Remote 'g' packet reply is too long (expected 440 bytes, got 816 bytes): ad064000000000000[snip]
(gdb) FAIL: gdb.multi/multi-arch.exp: inf1 event with inf2 selected: continue to hello_loop
c
Continuing.
Truncated register 50 in remote 'g' packet
(gdb) PASS: gdb.multi/multi-arch.exp: inf2 event with inf1 selected: c
~~~
This commit fixes that.
gdb/ChangeLog:
2017-10-04 Pedro Alves <palves@redhat.com>
* remote.c (get_remote_arch_state): New 'gdbarch' parameter. Use
it instead of target_gdbarch.
(get_remote_state, get_remote_packet_size): Adjust
get_remote_arch_state calls, passing down target_gdbarch
explicitly.
(packet_reg_from_regnum, packet_reg_from_pnum): New parameter
'gdbarch' and use it instead of target_gdbarch.
(get_memory_packet_size): Adjust get_remote_arch_state calls,
passing down target_gdbarch explicitly.
(struct stop_reply) <arch>: New field.
(remote_parse_stop_reply): Use the stopped thread's architecture,
not the current inferior's. Save the architecture in the
stop_reply.
(process_stop_reply): Use the stop reply's architecture.
(process_g_packet, remote_fetch_registers)
(remote_prepare_to_store, store_registers_using_G)
(remote_store_registers): Adjust get_remote_arch_state calls,
using the regcache's architecture.
(remote_get_trace_status): Adjust get_remote_arch_state calls,
passing down target_gdbarch explicitly.
* spu-multiarch.c (spu_thread_architecture): Defer to the target
beneath instead of calling target_gdbarch.
* target.c (default_thread_architecture): Use the specified
inferior's architecture, instead of the current inferior's
architecture (via target_gdbarch).
gdb/testsuite/ChangeLog:
2017-10-04 Pedro Alves <palves@redhat.com>
* gdb.multi/hangout.c: Include <unistd.h>.
(hangout_loop): New function.
(main): Call alarm. Call hangout_loop in a loop.
* gdb.multi/hello.c: Include <unistd.h>.
(hello_loop): New function.
(main): Call alarm. Call hangout_loop in a loop.
* gdb.multi/multi-arch.exp: Test running to a breakpoint one
inferior with the other selected.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master
2017-10-04 17:39 [binutils-gdb] Fix "Remote 'g' packet reply is too long" problems with multiple inferiors sergiodj+buildbot
@ 2017-10-04 21:11 ` sergiodj+buildbot
0 siblings, 0 replies; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-04 21:11 UTC (permalink / raw)
To: gdb-testers
Buildslave:
ubuntu-trusty-aarch32-1
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-native-gdbserver-m32/builds/1658>
Commit(s) tested:
5cd63fda035d4ba949e6478406162c4673b3c9ef
Author(s) (in the same order as the commits):
Pedro Alves <palves@redhat.com>
Subject:
Fix "Remote 'g' packet reply is too long" problems with multiple inferiors
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-native-gdbserver-m32/5c/5cd63fda035d4ba949e6478406162c4673b3c9ef/>
*** Diff to previous build ***
============================
PASS -> FAIL: gdb.base/catch-signal-fork.exp: got SIGHUP after fork
PASS -> FAIL: gdb.base/catch-syscall.exp: without args noxml: syscall vfork has returned
PASS -> FAIL: gdb.base/catch-syscall.exp: without args noxml: ENOSYS: program has called 985087
PASS -> FAIL: gdb.base/catch-syscall.exp: without args noxml: ENOSYS: syscall 985087 has returned
PASS -> FAIL: gdb.base/catch-syscall.exp: without args noxml: program has called 248
new FAIL: gdb.base/fileio.exp: System says shell is not available
PASS -> FAIL: gdb.base/fileio.exp: System says shell is available
PASS -> FAIL: gdb.base/fileio.exp: System
PASS -> FAIL: gdb.base/fileio.exp: System with invalid command returns 127
PASS -> FAIL: gdb.base/fileio.exp: Rename a file
PASS -> FAIL: gdb.base/fileio.exp: Renaming a file to existing directory returns EISDIR
PASS -> FAIL: gdb.base/fileio.exp: renaming a directory to a non-empty directory returns ENOTEMPTY or EEXIST
PASS -> FAIL: gdb.base/fileio.exp: Renaming a directory to a subdir of itself returns EINVAL
PASS -> FAIL: gdb.base/fileio.exp: Renaming a nonexistant file returns ENOENT
PASS -> FAIL: gdb.base/fileio.exp: Unlink a file
PASS -> FAIL: gdb.base/fileio.exp: Unlinking a file in a directory w/o write access returns EACCES
PASS -> FAIL: gdb.base/fileio.exp: Unlinking a nonexistant file returns ENOENT
PASS -> FAIL: gdb.base/fileio.exp: Time
PASS -> FAIL: gdb.base/foll-fork.exp: follow default, detach default, command "next 2": next 2 past fork
PASS -> FAIL: gdb.base/foll-fork.exp: follow default, detach default, command "continue": continue past fork
PASS -> FAIL: gdb.base/foll-fork.exp: follow parent, detach on, command "next 2": next 2 past fork
PASS -> FAIL: gdb.base/foll-fork.exp: follow parent, detach on, command "continue": continue past fork
PASS -> FAIL: gdb.base/foll-fork.exp: set follow-fork parent, hit tbreak
PASS -> FAIL: gdb.base/foll-vfork.exp: exec: vfork parent follow, through step: step
PASS -> FAIL: gdb.base/foll-vfork.exp: exec: vfork parent follow, to bp: continue to bp
PASS -> FAIL: gdb.base/foll-vfork.exp: exec: vfork parent follow, finish after tcatch vfork: finish
PASS -> FAIL: gdb.base/foll-vfork.exp: exit: vfork parent follow, through step: step
PASS -> FAIL: gdb.base/foll-vfork.exp: exit: vfork parent follow, to bp: continue to bp
PASS -> FAIL: gdb.base/foll-vfork.exp: exit: vfork parent follow, finish after tcatch vfork: finish
PASS -> FAIL: gdb.base/fork-running-state.exp: detach-on-fork=on: follow-fork=parent: non-stop: continue &
PASS -> FAIL: gdb.base/fork-running-state.exp: detach-on-fork=on: follow-fork=parent: non-stop: info threads
PASS -> FAIL: gdb.base/fork-running-state.exp: detach-on-fork=on: follow-fork=parent: all-stop: schedule-multiple=on: continue &
PASS -> FAIL: gdb.base/fork-running-state.exp: detach-on-fork=on: follow-fork=parent: all-stop: schedule-multiple=on: info threads
PASS -> FAIL: gdb.base/fork-running-state.exp: detach-on-fork=on: follow-fork=parent: all-stop: schedule-multiple=off: info threads
PASS -> FAIL: gdb.base/multi-forks.exp: follow parent, print pids
PASS -> FAIL: gdb.base/step-over-syscall.exp: fork: displaced=off: continue to fork
PASS -> FAIL: gdb.base/step-over-syscall.exp: fork: displaced=off: find syscall insn in fork
PASS -> FAIL: gdb.base/step-over-syscall.exp: fork: displaced=off: stepi fork insn
new FAIL: gdb.base/step-over-syscall.exp: fork: displaced=off: break on syscall insn
PASS -> FAIL: gdb.base/step-over-syscall.exp: fork: displaced=off: continue to syscall insn fork
PASS -> FAIL: gdb.base/step-over-syscall.exp: fork: displaced=off: single step over fork
PASS -> FAIL: gdb.base/step-over-syscall.exp: vfork: displaced=off: continue to vfork
PASS -> FAIL: gdb.base/step-over-syscall.exp: vfork: displaced=off: find syscall insn in vfork
PASS -> FAIL: gdb.base/step-over-syscall.exp: vfork: displaced=off: stepi vfork insn
new FAIL: gdb.base/step-over-syscall.exp: vfork: displaced=off: break on syscall insn
PASS -> FAIL: gdb.base/step-over-syscall.exp: vfork: displaced=off: continue to syscall insn vfork
PASS -> FAIL: gdb.base/step-over-syscall.exp: vfork: displaced=off: single step over vfork
PASS -> FAIL: gdb.base/watch-vfork.exp: Watchpoint triggers after vfork
PASS -> FAIL: gdb.reverse/waitpid-reverse.exp: continue to breakpoint: marker2
PASS -> FAIL: gdb.reverse/waitpid-reverse.exp: reverse to marker1
PASS -> FAIL: gdb.threads/forking-threads-plus-breakpoint.exp: cond_bp_target=0: detach_on_fork=on: displaced=on: inferior 1 exited
PASS -> FAIL: gdb.threads/forking-threads-plus-breakpoint.exp: cond_bp_target=0: detach_on_fork=on: displaced=off: inferior 1 exited
PASS -> FAIL: gdb.threads/fork-plus-threads.exp: detach-on-fork=on: continue &
PASS -> FAIL: gdb.threads/fork-plus-threads.exp: detach-on-fork=on: inferior 1 exited
PASS -> FAIL: gdb.threads/fork-plus-threads.exp: detach-on-fork=on: no threads left
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
PASS -> FAIL: gdb.threads/watchpoint-fork.exp: parent: singlethreaded: breakpoint after the first fork
PASS -> FAIL: gdb.threads/watchpoint-fork.exp: parent: singlethreaded: watchpoint after the first fork
PASS -> FAIL: gdb.threads/watchpoint-fork.exp: parent: singlethreaded: breakpoint after the second fork
PASS -> FAIL: gdb.threads/watchpoint-fork.exp: parent: singlethreaded: watchpoint after the second fork
PASS -> FAIL: gdb.threads/watchpoint-fork.exp: parent: singlethreaded: finish
PASS -> FAIL: gdb.threads/watchpoint-fork.exp: parent: multithreaded: breakpoint
PASS -> FAIL: gdb.threads/watchpoint-fork.exp: parent: multithreaded: watchpoint A after the first fork
PASS -> FAIL: gdb.threads/watchpoint-fork.exp: parent: multithreaded: watchpoint B after the first fork
PASS -> FAIL: gdb.threads/watchpoint-fork.exp: parent: multithreaded: watchpoint A after the second fork
PASS -> FAIL: gdb.threads/watchpoint-fork.exp: parent: multithreaded: watchpoint B after the second fork
PASS -> FAIL: gdb.threads/watchpoint-fork.exp: parent: multithreaded: finish
============================
*** Complete list of XFAILs for this builder ***
To obtain the list of XFAIL tests for this builder, go to:
<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch32-native-gdbserver-m32/xfails/master/xfail;hb=>
You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:
<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch32-native-gdbserver-m32/xfails/master/xfail.table;hb=>
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR21167, relocation sections not included in groups
@ 2017-10-04 23:08 sergiodj+buildbot
2017-10-04 23:57 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-04 23:08 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT db4677b8bd90b49f826807352c6c3c7eb0d57814 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: db4677b8bd90b49f826807352c6c3c7eb0d57814
PR21167, relocation sections not included in groups
This fixes a wart I've known about for years, but haven't done
anything about because BFD treats relocation sections as an adjunct to
the section they relocate. SHF_GROUP on the section thus implicitly
applies to its relocation section(s), but it is an error that the
reloc sections aren't part of the group.
Like many patches to gas, this wasn't as straightforward as it could
be due to a number of backends, i386, cr16 and others, removing relocs
in tc_get_reloc rather than marking them as "done" earlier in
md_apply_reloc. So it isn't possible for the group support to
reliably detect the presence of relocs by looking at fixups earlier
than write_relocs. However the group support needs to create
signature symbols, and that must be done before the symbol table is
frozen, before write_relocs. So split off the group sizing from
elf_adjust_symtab and put it in elf_frob_file_after_relocs.
bfd/
PR 21167
* elf.c (_bfd_elf_setup_sections): Don't trim reloc sections from
groups.
(_bfd_elf_init_reloc_shdr): Pass sec_hdr, use it to copy SHF_GROUP
flag from section.
(elf_fake_sections): Adjust calls. Exit immediately on failure.
(bfd_elf_set_group_contents): Add associated reloc section indices
to group contents
gas/
PR 21167
* config/obj-elf.c (struct group_list): Delete elt_count.
(groups): New static.
(build_group_lists): Don't count elements.
(elf_adjust_symtab): Use groups rather than auto list. Set up
pointer from group member to SHT_GROUP section. Don't size
SHT_GROUP section or clean up here..
(elf_frob_file_after_relocs): ..do so here instead.
* testsuite/gas/arc/jli-1.d,
* testsuite/gas/elf/groupautob.d,
* testsuite/gas/mips/compact-eh-eb-2.d,
* testsuite/gas/mips/compact-eh-eb-5.d,
* testsuite/gas/mips/compact-eh-el-2.d,
* testsuite/gas/mips/compact-eh-el-5.d: Adjust.
ld/
PR 21167
* testsuite/ld-elf/group9b.d: Adjust for relocs included in group.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] bfd_set_input_error
@ 2017-10-05 1:42 sergiodj+buildbot
2017-10-05 3:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-05 1:42 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2ca7de3746be7484aa5affceafa1ad2e1d789381 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 2ca7de3746be7484aa5affceafa1ad2e1d789381
bfd_set_input_error
A downside to the 2017-10-04 PR22245 fix is that bfd_set_error can now
silently accept invalid errors if/when someone passes the a value of
the wrong enumeration type, which previously would be caught by the
-Wenum-conversion warning.
PR 22245
* bfd.c (bfd_set_error): Revert 2017-10-04 change. Remove
ellipsis parameter. Split out bfd_error_on_input code to..
(bfd_set_input_error): .. New function.
* archive.c (_bfd_write_archive_contents): Use bfd_set_input_error.
* vms-lib.c (_bfd_vms_lib_write_archive_contents): Likewise.
* bfd-in2.h: Regenerate.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Update my email address.
@ 2017-10-05 4:45 sergiodj+buildbot
2017-10-05 5:33 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-05 4:45 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c91933e9e33654c7b8973cb449b93f5152afcbcb ***
Author: Tristan Gingold <tgingold@free.fr>
Branch: master
Commit: c91933e9e33654c7b8973cb449b93f5152afcbcb
Update my email address.
Also refer to global maintainers for branch release approval.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] tile: Dump dynamic relocation info to the map file
@ 2017-10-05 13:02 sergiodj+buildbot
2017-10-05 13:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-05 13:02 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 007873f54e41eaef2f7a89b8adbb63a563d98b65 ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 007873f54e41eaef2f7a89b8adbb63a563d98b65
tile: Dump dynamic relocation info to the map file
Dump dynamic relocation info to the map file when generating dynamic
relocation in read-only section relocations if -Map is used.
* elf32-tilepro.c (readonly_dynrelocs): Dump dynamic relocation
in read-only section with minfo.
(tilepro_elf_size_dynamic_sections): Likewise.
* elfxx-tilegx.c (readonly_dynrelocs): Likewise.
(tilegx_elf_size_dynamic_sections): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Handle the NT_ARM_VFP core dump note on FreeBSD.
@ 2017-10-05 17:00 sergiodj+buildbot
2017-10-05 18:59 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-05 17:00 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 6d5be5d6b8b4412e65bc037472aa2e727c25ccf5 ***
Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: 6d5be5d6b8b4412e65bc037472aa2e727c25ccf5
Handle the NT_ARM_VFP core dump note on FreeBSD.
bfd/ChangeLog:
* elf.c (elfcore_grok_freebsd_note): Handle NT_ARM_VFP.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Handle FreeBSD-specific AT_EHDRFLAGS and AT_HWCAP auxiliary vector types.
@ 2017-10-05 17:00 sergiodj+buildbot
2017-10-05 17:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-05 17:00 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 12c4bd7f53e9cefcf7c3a7f8cbf9e552526cb963 ***
Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: 12c4bd7f53e9cefcf7c3a7f8cbf9e552526cb963
Handle FreeBSD-specific AT_EHDRFLAGS and AT_HWCAP auxiliary vector types.
FreeBSD recently added two additional ELF auxiliary vectors. FreeBSD's
AT_HWCAP uses a different number compared to AT_HWCAP on Linux as the
numerical value was already in use for a different vector on FreeBSD.
include/ChangeLog:
* elf/common.h (AT_FREEBSD_EHDRFLAGS, AT_FREEBSD_HWCAP): Define.
gdb/ChangeLog:
* fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_EHDRFLAGS and
AT_HWCAP.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add a signal frame unwinder for FreeBSD/mipsn32.
@ 2017-10-05 17:00 sergiodj+buildbot
2017-10-05 20:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-05 17:00 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a80a647180bf92692e0f01efe7b323afe7d317c9 ***
Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: a80a647180bf92692e0f01efe7b323afe7d317c9
Add a signal frame unwinder for FreeBSD/mipsn32.
The N32 signal frame uses an identical layout to N64, so reuse the N64
handler. The N32 signal trampoline does use one different instruction
relative to N64, so a separate tramp_frame is required.
gdb/ChangeLog:
* mips-fbsd-tdep.c (MIPS_INST_ADDIU_A0_SP_N32): Define.
(mipsn32_fbsd_sigframe): Define.
(mips_fbsd_init_abi): Install mipsn32_fbsd_sigframe unwinder
for FreeBSD/mipsn32.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Clean up includes of doublest.h and floatformat.h
@ 2017-10-05 17:18 sergiodj+buildbot
2017-10-05 22:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-05 17:18 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 1841ee5d0300cf00022c8aadfe16725c5e86fe1d ***
Author: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Branch: master
Commit: 1841ee5d0300cf00022c8aadfe16725c5e86fe1d
Clean up includes of doublest.h and floatformat.h
As a first small step to getting rid of doublest.h, this patch removes the
include of "floatformat.h" in "doublest.h". This is actually not needed
for the file itself. A few source files now need to include "floatformat.h"
directly, since they got it indirectly via "doublest.h" and still need it.
In reviewing which files need it, I found a number of files that include
"floatformat.h" directly without actually needing it at all. Similarly,
a number of files include "doublest.h" without needing it. I've also
removed those unnecessary include statements.
gdb/ChangeLog:
2017-10-05 Ulrich Weigand <uweigand@de.ibm.com>
* doublest.h: Do not include "floatformat.h". Remove stale comments.
* gdbtypes.c: Include "floatformat.h".
* value.c: Likewise.
* m68k-tdep.c: Likewise.
* findvar.c: Do not include "floatformat.h".
* amd64-darwin-tdep.c: Likewise.
* arm-linux-tdep.c: Likewise.
* i386-darwin-tdep.c: Likewise.
* i387-tdep.c: Likewise.
* m68k-linux-tdep.c: Likewise.
* mep-tdep.c: Likewise.
* mips-tdep.c: Likewise.
* nios2-tdep.c: Likewise.
* s390-linux-tdep.c: Likewise.
* sparc-obsd-tdep.c: Likewise.
* sparc-tdep.c: Likewise.
* sparc64-tdep.c: Likewise.
* spu-tdep.c: Likewise.
* tic6x-tdep.c: Likewise.
* tilegx-tdep.c: Likewise.
* vax-tdep.c: Likewise.
* xstormy16-tdep.c: Likewise.
* xtensa-tdep.c: Likewise.
* top.c: Do not include "doublest.h".
* aarch64-tdep.c: Likewise.
* alpha-tdep.c: Likewise.
* arm-linux-tdep.c: Likewise.
* m68k-linux-tdep.c: Likewise.
* tilegx-tdep.c: Likewise.
* xstormy16-tdep.c: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove unused "union agent_val" from ax.h
@ 2017-10-05 17:18 sergiodj+buildbot
2017-10-06 0:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-05 17:18 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d13b8493cbd2891b5886e6176d468eb63c73606a ***
Author: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Branch: master
Commit: d13b8493cbd2891b5886e6176d468eb63c73606a
Remove unused "union agent_val" from ax.h
The ax.h header file contains a use of DOUBLEST in the type "union agent_val".
However, that type is never used anywhere, so it can be simply removed.
gdb/ChangeLog:
2017-10-05 Ulrich Weigand <uweigand@de.ibm.com>
* ax.h: Do not include "doublest.h".
(union agent_val): Remove.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix fork-related regressions on GNU/Linux
@ 2017-10-05 17:35 sergiodj+buildbot
2017-10-06 2:21 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-05 17:35 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2fd9d7ca17539ce983862b25e0abc27cfb706189 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 2fd9d7ca17539ce983862b25e0abc27cfb706189
Fix fork-related regressions on GNU/Linux
Commit 5cd63fda035d ("Fix "Remote 'g' packet reply is too long"
problems with multiple inferiors") caused a number of regressions on
native GNU/Linux, all related to follow-fork support. E.g.:
src/gdb/target.c:3141: internal-error: gdbarch* default_thread_architecture(target_ops*, ptid_t): Assertion `inf != NULL' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Quit this debugging session? (y or n)
Resyncing due to internal error.
FAIL: gdb.base/catch-signal-fork.exp: got SIGHUP after fork (GDB internal error)
This commit fixes it.
gdb/ChangeLog:
2017-10-05 Pedro Alves <palves@redhat.com>
* linux-nat.c (linux_child_follow_fork): When following the parent
and detaching the child, consult the parent thread's architecture
instead of the child's.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: Add TLS_TRANSITION_IE_TO_LE_P
@ 2017-10-06 7:18 sergiodj+buildbot
2017-10-06 8:33 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-06 7:18 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 51537393bd939e79f6e9291629fb65a17e6f19da ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 51537393bd939e79f6e9291629fb65a17e6f19da
x86: Add TLS_TRANSITION_IE_TO_LE_P
Add TLS_TRANSITION_IE_TO_LE_P which returns TRUE if TLS IE->LE transition
is OK.
* elfxx-x86.h (TLS_TRANSITION_IE_TO_LE_P): New.
* elf32-i386.c (elf_i386_tls_transition): Use it.
* elf64-x86-64.c (elf_x86_64_tls_transition): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: Add NEED_DYNAMIC_RELOCATION_P
@ 2017-10-06 7:26 sergiodj+buildbot
2017-10-06 10:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-06 7:26 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT daf1c414a48baf090f005ce4b319b6881d5d6872 ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: daf1c414a48baf090f005ce4b319b6881d5d6872
x86: Add NEED_DYNAMIC_RELOCATION_P
Add NEED_DYNAMIC_RELOCATION_P which returns TRUE if dynamic relocation
is needed.
* elf32-i386.c (X86_PCREL_TYPE_P): New.
(elf_i386_check_relocs): Use NEED_DYNAMIC_RELOCATION_P.
* elf64-x86-64.c (IS_X86_64_PCREL_TYPE): Renamed to ...
(X86_PCREL_TYPE_P): This.
(elf_x86_64_check_relocs): Use NEED_DYNAMIC_RELOCATION_P.
Replace IS_X86_64_PCREL_TYPE with X86_PCREL_TYPE_P.
(elf_x86_64_relocate_section): Replace IS_X86_64_PCREL_TYPE with
X86_PCREL_TYPE_P.
* elfxx-x86.h (NEED_DYNAMIC_RELOCATION_P): New.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add RESOLVED_LOCALLY_P
@ 2017-10-06 7:30 sergiodj+buildbot
2017-10-06 12:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-06 7:30 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2eba97c207399d8b541092a7b0a4428dc02f5cf1 ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 2eba97c207399d8b541092a7b0a4428dc02f5cf1
Add RESOLVED_LOCALLY_P
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: Add GENERATE_RELATIVE_RELOC_P
@ 2017-10-06 7:36 sergiodj+buildbot
2017-10-06 13:27 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-06 7:36 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f70656b2604eff12cea2e9bef27c1e00a3077f30 ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: f70656b2604eff12cea2e9bef27c1e00a3077f30
x86: Add GENERATE_RELATIVE_RELOC_P
Add GENERATE_RELATIVE_RELOC_P which returns TRUE if dynamic relative
relocation should be generated.
* elfxx-x86.h (GENERATE_RELATIVE_RELOC_P): New.
* elf32-i386.c (elf_i386_relocate_section): Use it.
* elf64-x86-64.c (elf_x86_64_relocate_section): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: Add GENERATE_DYNAMIC_RELOCATION_P
@ 2017-10-06 7:44 sergiodj+buildbot
2017-10-06 16:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-06 7:44 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT aebcc8ffd201adbee973b414818b01876dabe1a0 ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: aebcc8ffd201adbee973b414818b01876dabe1a0
x86: Add GENERATE_DYNAMIC_RELOCATION_P
Add GENERATE_DYNAMIC_RELOCATION_P which returns TRUE if dynamic
relocation should be generated.
* elf32-i386.c (X86_SIZE_TYPE_P): New.
(elf_i386_relocate_section): Use GENERATE_DYNAMIC_RELOCATION_P.
* elf64-x86-64.c (X86_SIZE_TYPE_P): New.
(elf_x86_64_relocate_section): Use GENERATE_DYNAMIC_RELOCATION_P.
* elfxx-x86.h (GENERATE_DYNAMIC_RELOCATION_P): New.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: Add VERIFY_PLT_ENTRY
@ 2017-10-06 7:51 sergiodj+buildbot
2017-10-06 18:27 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-06 7:51 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f3180fa9ee8917fa9547cd5f79c822761f5d87a0 ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: f3180fa9ee8917fa9547cd5f79c822761f5d87a0
x86: Add VERIFY_PLT_ENTRY
Add VERIFY_PLT_ENTRY to verify that symbol has an entry in the procedure
linkage table.
* elfxx-x86.h (VERIFY_PLT_ENTRY): New.
* elf32-i386.c (elf_i386_finish_dynamic_symbol): Use it.
* elf64-x86-64.c (elf_x86_64_finish_dynamic_symbol): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: Add VERIFY_COPY_RELOC
@ 2017-10-06 7:54 sergiodj+buildbot
2017-10-06 20:13 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-06 7:54 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ff38b4cc55dade4c9970cac2149a946d5dc0adc7 ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: ff38b4cc55dade4c9970cac2149a946d5dc0adc7
x86: Add VERIFY_COPY_RELOC
Add VERIFY_COPY_RELOC to verify that symbol supports copy relocation.
* elfxx-x86.h (VERIFY_COPY_RELOC): New.
* elf32-i386.c (elf_i386_finish_dynamic_symbol): Use it.
* elf64-x86-64.c (elf_x86_64_finish_dynamic_symbol): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Share code updating gdb_target_obs
@ 2017-10-06 10:23 sergiodj+buildbot
2017-10-07 0:30 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-06 10:23 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d97987e219b80c670e37eb0e25e31b36fa295509 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: d97987e219b80c670e37eb0e25e31b36fa295509
Share code updating gdb_target_obs
Nowadays, there are much duplications in configure.tgt to update
gdb_target_obs, some cpu specific object files are added to gdb_target_obs
to some different target triplets of the same cpu. The same problem
exists for os specific object files too. It is fragile to update them,
and build with all targets enabled doesn't find the problem.
This patch splits the gdb_target_obs update to three steps, cpu steps, os
steps, and the rest.
I tested this patch by build gdb for each different target triplets
respectively,
aarch64-elf aarch64-rtems aarch64-freebsd aarch64-linux alpha-elf
alpha-linux alpha-netbsd alpha-openbsd arm-elf arm-wince-pe arm-linux
arm-netbsd arm-symbianelf avr cris-elf frv-elf h8300-elf i386-elf
i386-darwin i386-dicos i386-freebsd i386-netbsdelf i386-openbsd
i386-nto i386-solaris i386-linux i386-gnu i386-cygwin i386-mingw32
i386-go32 ia64-linux-gnu ia64-vms lm32-elf m32c-elf m32r-elf m32r-linux
m68hc11-elf m68k-elf m68k-linux m68k-netbsd m68k-openbsd m88k-openbsd
mep-elf microblaze-xilinx-elf microblaze-linux-gnu mips-elf moxie-elf
ms1-elf nios2-elf nios2-linux-gnu hppa-elf hppa-linux hppa-netbsd
hppa-openbsd powerpc-eabi powerpc-freebsd powerpc-netbsd powerpc-openbsd
powerpc-linux powerpc-lynx178 rl78-elf rx-elf s390-linux-gnu score-elf
sh-elf sh-linux sh-openbsd sh64-elf sh64-linux sh64-openbsd sparc64-linux
sparc-linux sparc-freebsd sparc64-freebsd sparc-netbsd sparc64-netbsd
sparc-openbsd sparc64-openbsd spu-elf tic6x-elf tic6x-uclinux v850-elf
vax-netbsd vax-openbsd x86_64-linux-gnu x86_64-darwin x86_64-dicos
x86_64-elf x86_64-freebsd x86_64-mingw32 x86_64-netbsd x86_64-openbsd
x86_64-rtems xstormy16-elf xtensa-elf xtensa-linux
gdb:
2017-10-06 Yao Qi <yao.qi@linaro.org>
* configure.tgt (i386_tobjs): New variable.
(amd64_tobjs): New variable.
Set $cpu_obs and $os_obs.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix GDB build under msys+mingw gcc 32bit
@ 2017-10-06 10:53 sergiodj+buildbot
2017-10-07 2:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-06 10:53 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b79f7801a2c555ee4ff4bc3050141e83158f66d4 ***
Author: Yuanhui Zhang <asmwarrior@gmail.com>
Branch: master
Commit: b79f7801a2c555ee4ff4bc3050141e83158f66d4
Fix GDB build under msys+mingw gcc 32bit
I see a build error when building GDB under msys+mingw gcc 32bit:
g++ -x c++ -std=gnu++11 -g -O2 -I. -I../../../binutils-gdb/gdb/gdbserver -I../../../binutils-gdb/gdb/gdbserver/../common -I../../../binutils-gdb/gdb/gdbserver/../regformats -I../../../binutils-gdb/gdb/gdbserver/.. -I../../../binutils-gdb/gdb/gdbserver/../../include -I../../../binutils-gdb/gdb/gdbserver/../gnulib/import -Ibuild-gnulib-gdbserver/import -Wall -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable -Wno-sign-compare -Wno-narrowing -Wno-error=maybe-uninitialized -Wno-format -Werror -DGDBSERVER -c -o win32-low.o -MT win32-low.o -MMD -MP -MF .deps/win32-low.Tpo ../../../binutils-gdb/gdb/gdbserver/win32-low.c
../../../binutils-gdb/gdb/gdbserver/win32-low.c: In function 'BOOL create_process(const char*, char*, DWORD, PROCESS_INFORMATION*)':
../../../binutils-gdb/gdb/gdbserver/win32-low.c:566:48: error: 'get_inferior_cwd' was not declared in this scope
const char *inferior_cwd = get_inferior_cwd ();
^
make[4]: *** [win32-low.o] Error 1
It can be fixed by simply including the right header file.
gdb/gdbserver/ChangeLog:
2017-10-06 Yuanhui Zhang <asmwarrior@gmail.com>
* win32-low.c: Include "common-inferior.h".
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix more GDB build breakage on mingw32
@ 2017-10-06 11:06 sergiodj+buildbot
2017-10-07 3:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-06 11:06 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a1b85d282f408dfd18a27539874846197f7e4044 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: a1b85d282f408dfd18a27539874846197f7e4044
Fix more GDB build breakage on mingw32
With F23's mingw gcc 5.3.0, I'm seeing:
i686-w64-mingw32-g++ -x c++ -std=gnu++11 -g3 -O0 -I. -I../../src/gdb -I../../src/gdb/common -I../../src/gdb/config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode -I../../src/gdb/../opcodes/.. -I../../src/gdb/../readline/.. -I../../src/gdb/../zlib -I../bfd -I../../src/gdb/../bfd -I../../src/gdb/../include -I../libdecnumber -I../../src/gdb/../libdecnumber -I../../src/gdb/gnulib/import -Ibuild-gnulib/import -I/home/pedro/src/expat/install-win32//include -Wall -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable -Wno-sign-compare -Wno-narrowing -Wno-error=maybe-uninitialized -Wno-format -Werror -c -o windows-nat.o -MT windows-nat.o -MMD -MP -MF ./.deps/windows-nat.o.Tpo ../../src/gdb/windows-nat.c
../../src/gdb/windows-nat.c: In function 'void windows_create_inferior(target_ops*, const char*, const string&, char**, int)':
../../src/gdb/windows-nat.c:2476:7: error: 'replace' is not a member of 'std'
std::replace (expanded_infcwd.begin (), expanded_infcwd.end (),
^
gdb/Changelog:
2017-10-06 Pedro Alves <palves@redhat.com>
* windows-nat.c: Include <algorithm>.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add "do/while(0); " to COPY_INPUT_RELOC_P/VERIFY_COPY_RELOC
@ 2017-10-06 12:54 sergiodj+buildbot
2017-10-07 5:02 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-06 12:54 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e0d8f43169368abf354e596c7725dee1dd609cb8 ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: e0d8f43169368abf354e596c7725dee1dd609cb8
Add "do/while(0);" to COPY_INPUT_RELOC_P/VERIFY_COPY_RELOC
Add "do/while(0);" to COPY_INPUT_RELOC_P/VERIFY_COPY_RELOC to avoid
potential dangling else problems.
* elfxx-x86.h (COPY_INPUT_RELOC_P): Add "do/while(0);".
(VERIFY_COPY_RELOC): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Move aarch64-insn.o to arch/aarch64-insn.o and Remove a rule for arch/*.c
@ 2017-10-06 13:56 sergiodj+buildbot
2017-10-07 9:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-06 13:56 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 0d28b0a5caa6b04129e21a9aff371d4032c7ef17 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 0d28b0a5caa6b04129e21a9aff371d4032c7ef17
Move aarch64-insn.o to arch/aarch64-insn.o and Remove a rule for arch/*.c
This patch moves aarch64-insn.o to arch/aarch64-insn.o. Then, all
arch/*.c are built to arch/*.o, so we don't need a Makefile rule to build
*.o from arch/*.c. This patch removes it too.
gdb:
2017-10-06 Yao Qi <yao.qi@linaro.org>
* Makefile.in (ALL_64_TARGET_OBS): Replace aarch64-insn.o with
arch/aarch64-insn.o.
Remove one rule.
* configure.tgt: Replace aarch64-insn.o with arch/aarch64-insn.o.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Account for padding in FreeBSD/mipsn32 NT_PRSTATUS notes.
@ 2017-10-06 21:43 sergiodj+buildbot
2017-10-07 10:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-06 21:43 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 544c67cda1686c1b204cb96c0d7885b08d37b8d6 ***
Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: 544c67cda1686c1b204cb96c0d7885b08d37b8d6
Account for padding in FreeBSD/mipsn32 NT_PRSTATUS notes.
Add a new ELF backend method to grok FreeBSD NT_PRSTATUS core dump
notes. Define a method for MIPS N32 to override the default
elfcore_grok_freebsd_prstatus that accounts for additional padding
between pr_pid and pr_reg that is not present in other 32-bit FreeBSD
platforms.
* elf-bfd.h (struct elf_backend_data): Add
`elf_backend_grok_freebsd_prstatus'.
* elf.c (elfcore_grok_freebsd_note): Call
`elf_backend_grok_freebsd_prstatus' to handle NT_PRSTATUS if
present.
* elfn32-mips.c (elf_n32_mips_grok_freebsd_prstatus): New
function.
(elf_backend_grok_freebsd_prstatus): Define.
* elfxx-target.h (elf_backend_grok_freebsd_prstatus): Define.
(elfNN_bed): Initialize `elf_backend_grok_freebsd_prstatus'.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: Use zero_undefweak in elf_x86_link_hash_entry
@ 2017-10-07 1:04 sergiodj+buildbot
2017-10-07 13:02 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-07 1:04 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 98b273dc13b1e45db8c66821efc9e514884f3c25 ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 98b273dc13b1e45db8c66821efc9e514884f3c25
x86: Use zero_undefweak in elf_x86_link_hash_entry
Replace has_got_reloc and has_non_got_reloc in elf_x86_link_hash_entry
with zero_undefweak:
Bit 0: Symbol has no GOT nor PLT relocations.
Bit 1: Symbol has non-GOT/non-PLT relocations in text sections.
zero_undefweak is initialized to 1 and undefined weak symbol should be
resolved to 0 if zero_undefweak > 0.
* elf32-i386.c (elf_i386_check_relocs): Replace has_got_reloc
and has_non_got_reloc with zero_undefweak.
* elf64-x86-64.c (elf_x86_64_check_relocs): Likewise.
* elfxx-x86.c (_bfd_x86_elf_link_hash_newfunc): Initialize
zero_undefweak to 1.
(_bfd_x86_elf_copy_indirect_symbol): Replace has_got_reloc and
has_non_got_reloc with zero_undefweak.
* elfxx-x86.h (UNDEFINED_WEAK_RESOLVED_TO_ZERO): Replace
has_got_reloc and has_non_got_reloc with zero_undefweak.
(elf_x86_link_hash_entry): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] sparc: Dump dynamic relocation info to the map file
@ 2017-10-08 0:51 sergiodj+buildbot
2017-10-08 1:57 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-08 0:51 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f0f07ad1825e9b7f539e410562993b25f76e5627 ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: f0f07ad1825e9b7f539e410562993b25f76e5627
sparc: Dump dynamic relocation info to the map file
Dump dynamic relocation info to the map file when generating dynamic
relocation in read-only section relocations if -Map is used.
* elfxx-sparc.c (readonly_dynrelocs): Dump dynamic relocation
in read-only section with minfo.
(_bfd_sparc_elf_size_dynamic_sections): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] tilegx: Set this_hdr.sh_entsize only if section size > 0
@ 2017-10-08 21:53 sergiodj+buildbot
2017-10-08 22:23 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-08 21:53 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 4c7236d3cb7b971bbdc97b6aec348a4aa0594a9b ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 4c7236d3cb7b971bbdc97b6aec348a4aa0594a9b
tilegx: Set this_hdr.sh_entsize only if section size > 0
This fixes:
/export/build/gnu/binutils-cross/build-tilegx-linux/ld/ld-new -o tmpdir/comm-data -z norelro -L/export/gnu/import/git/sources/binutils-gdb/ld/testsuite/ld-elf -T comm-data2.ld -Ltmpdir -lcomm-data tmpdir/comm-data2.o
sh: line 1: 9208 Segmentation fault (core dumped) /export/build/gnu/binutils-cross/build-tilegx-linux/ld/ld-new -o tmpdir/comm-data -z norelro -L/export/gnu/import/git/sources/binutils-gdb/ld/testsuite/ld-elf -T comm-data2.ld -Ltmpdir -lcomm-data tmpdir/comm-data2.o 2>&1
FAIL: Common symbol override test
* elfxx-tilegx.c (tilegx_elf_finish_dynamic_sections): Set
this_hdr.sh_entsize only if section size > 0.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR22212, memory leak in nm
@ 2017-10-09 5:11 sergiodj+buildbot
2017-10-09 5:38 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-09 5:11 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b55ec8b676ed05d93ee49d6c79ae0403616c4fb0 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: b55ec8b676ed05d93ee49d6c79ae0403616c4fb0
PR22212, memory leak in nm
PR 22212
* dwarf2.c (_bfd_dwarf2_cleanup_debug_info): Free
funcinfo_hash_table and varinfo_hash_table.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Change search_symbols to return std::vector
@ 2017-10-09 5:31 sergiodj+buildbot
2017-10-09 6:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-09 5:31 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b9c04fb2681dd5706d2cafa5dcc6bdcd99016cf4 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: b9c04fb2681dd5706d2cafa5dcc6bdcd99016cf4
Change search_symbols to return std::vector
This changes search_symbols to return a std::vector, replacing the
previous linked list approach. This allows the removal of some
cleanups, as well as the use of std::sort and std::unique, saving some
code and extra allocations in sort_search_symbols_remove_dups.
Regression tested by the buildbot.
gdb/ChangeLog
2017-10-08 Tom Tromey <tom@tromey.com>
* symtab.c (free_search_symbols, do_free_search_symbols_cleanup)
(make_cleanup_free_search_symbols): Remove.
(search_symbols): Return std::vector.
(symbol_search::compare_search_syms): Now member of
symbol_search. Change arguments.
(sort_search_symbols_remove_dups): Change arguments. Rewrite.
(symtab_symbol_info, rbreak_command): Update.
* symtab.h (struct symbol_search) <next>: Remove.
Add constructors.
(symbol_search::operator<): New function.
(symbol_search::operator==): New function.
(search_symbols): Remove std::vector.
(free_search_symbols, make_cleanup_free_search_symbols): Remove.
(symbol_search::compare_search_syms): Declare.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove make_cleanup_value_free
@ 2017-10-09 5:51 sergiodj+buildbot
2017-10-09 8:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-09 5:51 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 757325a3f24e01bf8e7b7214f33c546bc52d1d12 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 757325a3f24e01bf8e7b7214f33c546bc52d1d12
Remove make_cleanup_value_free
This removes make_cleanup_value_free, in favor of a unique_ptr
specialization.
Regression tested by the buildbot.
gdb/ChangeLog
2017-10-08 Tom Tromey <tom@tromey.com>
* utils.h (make_cleanup_value_free): Remove.
* utils.c (do_value_free, struct cleanup): Remove.
* dwarf2loc.c (dwarf2_evaluate_loc_desc_full) <DWARF_VALUE_STACK>:
Use gdb_value_up.
* value.h (struct value_deleter): New.
(gdb_value_up): New typedef.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove some cleanups from dwarf2read.c
@ 2017-10-09 7:27 sergiodj+buildbot
2017-10-09 12:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-09 7:27 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 791afaa233ca9f4baa59aa16062296a00aa2c4da ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 791afaa233ca9f4baa59aa16062296a00aa2c4da
Remove some cleanups from dwarf2read.c
This removes a number of cleanups from dwarf2read.c in a
straightforward way.
Note that some places in dwarf2read create dangling cleanups. I don't
believe any of the changes in this patch interact with those spots.
Regression tested by the buildbot.
gdb/ChangeLog
2017-10-08 Tom Tromey <tom@tromey.com>
* dwarf2read.c (dwarf2_get_dwz_file): Use
gdb::unique_xmalloc_ptr.
(find_slot_in_mapped_hash): Likewise.
(dwarf2_physname): Likewise.
(create_dwo_unit_in_dwp_v1): Use std::string.
(create_dwo_unit_in_dwp_v2): Likewise.
(lookup_dwo_cutu): Likewise.
(inherit_abstract_dies): Use std::vector.
(read_array_type): Likewise.
(dwarf_decode_macros): Remove unused declaration.
(unsigned_int_compar): Remove.
(dwarf2_build_psymtabs_hard): Use scoped_restore.
(psymtabs_addrmap_cleanup): Remove.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove cleanup from frame_prepare_for_sniffer
@ 2017-10-09 8:52 sergiodj+buildbot
2017-10-09 10:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-09 8:52 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 30a9c02feff56bd58a276c2a7262f364baa558ac ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 30a9c02feff56bd58a276c2a7262f364baa558ac
Remove cleanup from frame_prepare_for_sniffer
Currently frame_prepare_for_sniffer returns a cleanup. This patch
changes it to return void, and exposes frame_cleanup_after_sniffer to
the caller.
Normally I would write an RAII class for this sort of thing; but
because there was just a single caller of frame_prepare_for_sniffer,
and because this caller is already using try/catch, I thought it
seemed ok to require explicit calls in this instance.
Regression tested by the buildbot.
gdb/ChangeLog
2017-10-08 Tom Tromey <tom@tromey.com>
* frame-unwind.c (frame_unwind_try_unwinder): Update.
* frame.h (frame_cleanup_after_sniffer): Declare.
(frame_prepare_for_sniffer): Return void.
* frame.c (frame_cleanup_after_sniffer): No longer static. Change
type of argument.
(frame_prepare_for_sniffer): Return void.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix gdb.base/print-file-var-main.c value check logic
@ 2017-10-09 12:16 sergiodj+buildbot
2017-10-09 13:39 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-09 12:16 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 5c9e4427a745e5e26fba320ecc62e4285b613e4f ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 5c9e4427a745e5e26fba320ecc62e4285b613e4f
Fix gdb.base/print-file-var-main.c value check logic
Fix a typo introduced in commit c56e7c4390ed ("Make ctxobj.exp and
print-file-var.exp work on all platforms.").
This doesn't really affect the outcome of the testcase. I only
noticed the typo because I stepped through the program manually.
To avoid such problems if the test is extended, this moves the STOP
marker until after the program self-validates the values. With the
typo in place, this alone would have resulted in a test FAIL. I.e.,
it'd have caught the typo.
gdb/testsuite/ChangeLog:
2017-10-09 Pedro Alves <palves@redhat.com>
* gdb.base/print-file-var-main.c: Fix get_version_2 value check
logic. Move STOP marker after the value checks.
* gdb.base/print-file-var.exp (continue to STOP marker): Tighten
regexp.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Make cp_remove_params return a gdb::unique_xmalloc_ptr
@ 2017-10-09 15:34 sergiodj+buildbot
2017-10-09 16:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-09 15:34 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 109483d9eec3f0d0c3eaafd5d829435059167c52 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 109483d9eec3f0d0c3eaafd5d829435059167c52
Make cp_remove_params return a gdb::unique_xmalloc_ptr
Use the type system instead of callers needing to know how the
returned string's memory is supposed to be managed.
gdb/ChangeLog:
2017-10-09 Pedro Alves <palves@redhat.com>
* cp-support.c (cp_remove_params): Return a gdb::unique_xmalloc_ptr.
Use bool.
(overload_list_add_symbol): Adjust to use gdb::unique_xmalloc_ptr.
* cp-support.h (cp_remove_params): Now returns a
gdb::unique_xmalloc_ptr.
* dwarf2read.c (find_slot_in_mapped_hash): Now returns bool.
Adjust to cp_remove_params returning a gdb::unique_xmalloc_ptr.
* psymtab.c (psymtab_search_name): Adjust to cp_remove_params
returning a gdb::unique_xmalloc_ptr.
(lookup_partial_symbol): Adjust to use gdb::unique_xmalloc_ptr.
* stack.c (find_frame_funname): Adjust to cp_remove_params
returning a gdb::unique_xmalloc_ptr.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix automatic dependency tracking
@ 2017-10-09 16:13 sergiodj+buildbot
2017-10-09 18:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-09 16:13 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 890e97902a21a3b88f9b6028852736b813303029 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 890e97902a21a3b88f9b6028852736b813303029
Fix automatic dependency tracking
Commit f38307f5 changed COMPILE.post and POSTCOMPILE to remove
$(basename) from the dependency file name computation. However, it
did not update the `-include' at the end of the Makefile.in; this in
effect disabled automatic dependency tracking.
This patch restores the $(basename) wrapper so that the dependency
files are named "file.Po" rather than "file.o.Po".
I also tested the non-gcc3 dependency mode, which pointed out that
this case hadn't been working since the switch to C++. This is also
fixed in this patch.
Tested by rebuilding.
ChangeLog
2017-10-09 Tom Tromey <tom@tromey.com>
* Makefile.in (COMPILE.post, POSTCOMPILE): Restore $(basename).
(COMPILE.pre): Use $(CXX).
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] S/390: Sync with latest POP - 3 new instructions
@ 2017-10-09 17:56 sergiodj+buildbot
2017-10-09 21:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-09 17:56 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 8e464506d2131fc931c4f81a22cc7125b7adf434 ***
Author: Andreas Krebbel <krebbel@linux.vnet.ibm.com>
Branch: master
Commit: 8e464506d2131fc931c4f81a22cc7125b7adf434
S/390: Sync with latest POP - 3 new instructions
prno, tpei, and irbm are missing in the optable.
gas/ChangeLog:
2017-10-09 Andreas Krebbel <krebbel@linux.vnet.ibm.com>
* testsuite/gas/s390/zarch-arch12.d (prno, tpei, irbm): New
instructions added.
* testsuite/gas/s390/zarch-arch12.s: Likewise.
* testsuite/gas/s390/zarch-z13.d: Rename ppno to prno.
opcodes/ChangeLog:
2017-10-09 Andreas Krebbel <krebbel@linux.vnet.ibm.com>
* s390-opc.txt (prno, tpei, irbm): New instructions added.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Use gdbarch_long_bit to determine layout of FreeBSD siginfo_t.
@ 2017-10-09 19:00 sergiodj+buildbot
2017-10-09 23:41 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-09 19:00 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a181c0bf7461c28cdb72a4074c6d7608119fb575 ***
Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: a181c0bf7461c28cdb72a4074c6d7608119fb575
Use gdbarch_long_bit to determine layout of FreeBSD siginfo_t.
FreeBSD architectures are either ILP32 or LP64 resulting in two
different layouts for siginfo_t. Previously, the 'bits_per_word'
member of bfd_arch_info was used to determine the layout to use for a
given FreeBSD architecture. However, mipsn32 architectures inherit
from a 64-bit mips architecture where bits_per_word is 64. As a
result, $_siginfo was not properly extracted from FreeBSD/mipsn32 core
dumps. Fix this by using gdbarch_long_bit instead of 'bits_per_word'
to determine if a FreeBSD architecture is ILP32 or LP64.
gdb/ChangeLog:
* fbsd-nat.c (fbsd_siginfo_size): Use gdbarch_long_bit.
(fbsd_convert_siginfo): Likewise.
* fbsd-tdep.c (fbsd_core_xfer_siginfo): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove "do_nothing"
@ 2017-10-10 0:03 sergiodj+buildbot
2017-10-10 6:22 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-10 0:03 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 0c478e2d060bebea341696806fed6f67122efab6 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 0c478e2d060bebea341696806fed6f67122efab6
Remove "do_nothing"
The do_nothing function in mi-main.c is used as a splay tree
key-deleting function; but NULL serves the same purpose and is used
elsewhere in gdb. This patch removes the unneeded function.
ChangeLog
2017-10-09 Tom Tromey <tom@tromey.com>
* mi/mi-main.c (do_nothing): Remove.
(list_available_thread_groups): Update.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] bfin: Don't create .interp section for info->nointerp
@ 2017-10-10 0:15 sergiodj+buildbot
2017-10-10 4:00 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-10 0:15 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9d45a7de8b80336b9965ee99353c34be85b1b98f ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 9d45a7de8b80336b9965ee99353c34be85b1b98f
bfin: Don't create .interp section for info->nointerp
Don't create the .interp section with "ld --no-dynamic-linker". This
fixed:
FAIL: PR ld/20828 forcibly exported symbol version without section GC
FAIL: PR ld/20828 forcibly exported symbol version with section GC
FAIL: readelf version information
* elf32-bfin.c (bfin_size_dynamic_sections): Don't create the
.interp section with "ld --no-dynamic-linker".
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove free_splay_tree cleanup
@ 2017-10-10 0:23 sergiodj+buildbot
2017-10-10 8:21 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-10 0:23 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 1a56bfa56ed967c5f6ed98f75834408417a062ff ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 1a56bfa56ed967c5f6ed98f75834408417a062ff
Remove free_splay_tree cleanup
One spot in gdb uses a cleanup to free a splay tree. This patch
introduces a unique_ptr specialization for this case.
ChangeLog
2017-10-09 Tom Tromey <tom@tromey.com>
* mi/mi-main.c (free_splay_tree): Remove.
(list_available_thread_groups): Use splay_tree_up.
* common/gdb_splay_tree.h: New file.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Prepare powerpc64 for late check_relocs
@ 2017-10-10 5:29 sergiodj+buildbot
2017-10-10 9:51 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-10 5:29 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b9399fcf4ec90d898a610e39bd9141e85c008fbb ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: b9399fcf4ec90d898a610e39bd9141e85c008fbb
Prepare powerpc64 for late check_relocs
check_relocs was setting up some data used by the --gc-sections
gc_mark_hook. If we change ld to run check_relocs after gc_sections
that data needs to be set up elsewhere. Done by this patch in the
backend check_directives function (ppc64_elf_before_check_relocs).
* elf64-ppc.c (ppc64_elf_before_check_relocs): Set sec_type for
.opd whenever .opd is present and non-zero size. Move code
setting abiversion to/from output file earlier. Only set
u.opd.func_sec when --gc-sections. Read relocs and set up
u.opd.func_sec values here..
(ppc64_elf_check_relocs): ..rather than here. Simplify opd
section tests.
(ppc64_elf_edit_opd): Don't set sec_type for .opd here.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] riscv: Cache the max alignment of output sections
@ 2017-10-10 5:49 sergiodj+buildbot
2017-10-10 11:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-10 5:49 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT fc3c534364ca6d6de4f0dbcaf347ec85f5e2f8ff ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: fc3c534364ca6d6de4f0dbcaf347ec85f5e2f8ff
riscv: Cache the max alignment of output sections
Cache the max alignment of output sections instead of scanning all
output sections for each input section, which can take a very long
time if there are millions of input/output sections.
PR ld/22274
* elfnn-riscv.c (riscv_elf_link_hash_table): Add max_alignment.
(riscv_elf_link_hash_table_create): Initialize max_alignment to
(bfd_vma) -1.
(_bfd_riscv_relax_section): Cache the max alignment of output
sections if possible.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Eliminate catch_exceptions/catch_exceptions_with_msg
@ 2017-10-10 17:00 sergiodj+buildbot
2017-10-10 19:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-10 17:00 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 65630365f7d073430e62b4fe65f34dcdc0a4b05e ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 65630365f7d073430e62b4fe65f34dcdc0a4b05e
Eliminate catch_exceptions/catch_exceptions_with_msg
This patch gets rid of catch_exceptions / catch_exceptions_with_msg.
The latter is done mostly by getting rid of the three remaining
vestigial libgdb wrapper functions, which are really pointless
nowadays. This results in a good number of simplifications.
(I checked that Insight doesn't use those functions.)
The gdb.mi/mi-pthreads.exp change is necessary because this actually
fixes a bug, IMO -- the patch stops MI's -thread-select causing output
on the CLI stream.
I.e., before:
-thread-select 123456789
&"Thread ID 123456789 not known.\n"
^error,msg="Thread ID 123456789 not known."
(gdb)
After:
-thread-select 123456789
^error,msg="Thread ID 123456789 not known."
(gdb)
gdb/ChangeLog
2017-10-10 Pedro Alves <palves@redhat.com>
Tom Tromey <tom@tromey.com>
* breakpoint.c (struct captured_breakpoint_query_args)
(do_captured_breakpoint_query, gdb_breakpoint_query): Delete.
(print_breakpoint): New.
* breakpoint.h (print_breakpoint): Declare.
* common/common-exceptions.h (enum return_reason): Remove
references to catch_exceptions.
* exceptions.c (catch_exceptions, catch_exceptions_with_msg):
Delete.
* exceptions.h (catch_exceptions_ftype, catch_exceptions)
(catch_exception_ftype, catch_exceptions_with_msg): Delete.
* gdb.h: Delete.
* gdbthread.h (thread_select): Declare.
* mi/mi-cmd-break.c: Don't include gdb.h.
(breakpoint_notify): Use print_breakpoint.
* mi/mi-cmd-catch.c: Don't include gdb.h.
* mi/mi-interp.c: Don't include gdb.h.
(mi_print_breakpoint_for_event): New.
(mi_breakpoint_created, mi_breakpoint_modified): Use
mi_print_breakpoint_for_event.
* mi/mi-main.c: Don't include gdb.h.
(mi_cmd_thread_select): Parse the global thread ID here. Use
thread_select instead of gdb_thread_select.
(mi_cmd_thread_list_ids): Output "thread-ids" tuple here instead
of using gdb_list_thread_ids.
* remote-fileio.c (do_remote_fileio_request): Change type. Reply
FILEIO_ENOSYS here.
(remote_fileio_request): Use TRY/CATCH instead of
catch_exceptions.
* symfile-mem.c (struct symbol_file_add_from_memory_args)
(symbol_file_add_from_memory_wrapper): Delete.
(add_vsyscall_page): Use TRY/CATCH instead of catch_exceptions.
* thread.c: Don't include gdb.h.
(do_captured_list_thread_ids, gdb_list_thread_ids): Delete.
(thread_alive): Use thread_select.
(do_captured_thread_select): Delete, parts salvaged as ...
(thread_select): ... this new function.
(gdb_thread_select): Delete.
gdb/testsuite/ChangeLog
2017-10-10 Pedro Alves <palves@redhat.com>
* gdb.mi/mi-pthreads.exp (check_mi_thread_command_set): Don't
expect CLI output.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Rename _doprnt -> _bfd_doprnt to fix DJGPP bfd build (and likely others)
@ 2017-10-11 12:08 sergiodj+buildbot
2017-10-11 13:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-11 12:08 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 8f314ad58ec824ce6c8467af29f11583f79a80ea ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 8f314ad58ec824ce6c8467af29f11583f79a80ea
Rename _doprnt -> _bfd_doprnt to fix DJGPP bfd build (and likely others)
Building bfd/ for DJGPP, I see:
../../src/bfd/bfd.c:642:1: error: conflicting types for '_doprnt'
_doprnt (FILE *stream, const char *format, va_list ap)
^~~~~~~
In file included from ../../src/bfd/sysdep.h:37:0,
from ../../src/bfd/bfd.c:367:
/usr/lib64/gcc/i586-pc-msdosdjgpp/6.1.0/include-fixed/stdio.h:171:5: note: previous declaration of '_doprnt' was here
int _doprnt(const char *_fmt, va_list _args, FILE *_f);
^~~~~~~
Possible fixes the build on other systems too -- _doprnt was/is an
exported symbol on old Unix/BSD systems too.
bfd/ChangeLog:
2017-10-11 Pedro Alves <palves@redhat.com>
* bfd.c (_doprnt): Rename to ...
(_bfd_doprnt): ... this.
(error_handler_internal): Adjust.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Use std::vector for symtab_fns
@ 2017-10-11 14:08 sergiodj+buildbot
2017-10-11 15:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-11 14:08 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 905014d7205d4f171c5cabf695fe1ec3da9b33d3 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 905014d7205d4f171c5cabf695fe1ec3da9b33d3
Use std::vector for symtab_fns
Simple replacement of VEC with std::vector.
gdb/ChangeLog:
* symfile.c (registered_sym_fns): Make struct, not typedef.
(DEF_VEC_O (registered_sym_fns)): Remove.
(symtab_fns): Change type to std::vector.
(add_symtab_fns): Adjust.
(find_sym_fns): Adjust.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Garbage collect reattach_breakpoints
@ 2017-10-11 14:30 sergiodj+buildbot
2017-10-11 16:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-11 14:30 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 458ca1d02e47db0af0e22d524df0e4b88fc54b6e ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 458ca1d02e47db0af0e22d524df0e4b88fc54b6e
Garbage collect reattach_breakpoints
Not used anywhere.
gdb/ChangeLog:
2017-10-11 Pedro Alves <palves@redhat.com>
* breakpoint.c (reattach_breakpoints): Delete.
* breakpoint.h (reattach_breakpoints): Delete.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] ELF/BFD: Fix padding in `elf_external_linux_prpsinfo64'
@ 2017-10-11 15:19 sergiodj+buildbot
2017-10-11 18:02 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-11 15:19 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 72bc1bb934ba99bc9182179a866c0d2c77d027c8 ***
Author: Maciej W. Rozycki <macro@imgtec.com>
Branch: master
Commit: 72bc1bb934ba99bc9182179a866c0d2c77d027c8
ELF/BFD: Fix padding in `elf_external_linux_prpsinfo64'
Fix commit 70a38d42c5b3 ("New entry points for writing Linux NT_PRPSINFO
notes."), <https://sourceware.org/ml/binutils/2013-02/msg00023.html>,
and move the padding of the `elf_external_linux_prpsinfo64' structure to
match the corresponding 64-bit Linux kernel `elf_prpsinfo' structure.
The 64-bit kernel structure is defined as follows:
(gdb) ptype struct elf_prpsinfo
type = struct elf_prpsinfo {
char pr_state;
char pr_sname;
char pr_zomb;
char pr_nice;
unsigned long pr_flag;
__kernel_uid_t pr_uid;
__kernel_gid_t pr_gid;
pid_t pr_pid;
pid_t pr_ppid;
pid_t pr_pgrp;
pid_t pr_sid;
char pr_fname[16];
char pr_psargs[80];
}
(gdb) print /x &((struct elf_prpsinfo *)0)->pr_nice
$1 = 0x3
(gdb) print /x &((struct elf_prpsinfo *)0)->pr_flag
$2 = 0x8
(gdb) print /x &((struct elf_prpsinfo *)0)->pr_uid
$3 = 0x10
(gdb) print sizeof(((struct elf_prpsinfo *)0)->pr_flag)
$4 = 8
(gdb)
with implicit padding present before the `pr_flag' member, to correctly
align it to a multiple of 8. Conversely `elf_external_linux_prpsinfo64'
has padding after its `pr_flag' member:
(top-gdb) ptype struct elf_external_linux_prpsinfo64
type = struct elf_external_linux_prpsinfo64 {
char pr_state;
char pr_sname;
char pr_zomb;
char pr_nice;
char pr_flag[8];
char gap[4];
char pr_uid[4];
char pr_gid[4];
char pr_pid[4];
char pr_ppid[4];
char pr_pgrp[4];
char pr_sid[4];
char pr_fname[16];
char pr_psargs[80];
}
(top-gdb) print /x &((struct elf_external_linux_prpsinfo64 *)0)->pr_nice
$1 = 0x3
(top-gdb) print /x &((struct elf_external_linux_prpsinfo64 *)0)->pr_flag
$2 = 0x4
(top-gdb) print /x &((struct elf_external_linux_prpsinfo64 *)0)->pr_uid
$3 = 0x10
(top-gdb)
and consequently `pr_flag' is misplaced. Move `gap' ahead of `pr_flag'
then.
bfd/
* elf-linux-core.h (elf_external_linux_prpsinfo64): Move the
`gap' member ahead of `pr_flag'.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] ELF/BFD: Handle both variants of the 64-bit Linux core PRPSINFO note
@ 2017-10-11 16:30 sergiodj+buildbot
2017-10-11 20:30 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-11 16:30 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 3c9a7b0d6d84425ea24d222a1a31e206e587374f ***
Author: Maciej W. Rozycki <macro@imgtec.com>
Branch: master
Commit: 3c9a7b0d6d84425ea24d222a1a31e206e587374f
ELF/BFD: Handle both variants of the 64-bit Linux core PRPSINFO note
Fix commit 70a38d42c5b3 ("New entry points for writing Linux NT_PRPSINFO
notes."), <https://sourceware.org/ml/binutils/2013-02/msg00023.html>,
and handle both variants of the 64-bit Linux core PRPSINFO note across
all targets.
The 64-bit Linux core PRPSINFO note matches the 64-bit kernel structure,
defined as follows:
(gdb) ptype struct elf_prpsinfo
type = struct elf_prpsinfo {
char pr_state;
char pr_sname;
char pr_zomb;
char pr_nice;
unsigned long pr_flag;
__kernel_uid_t pr_uid;
__kernel_gid_t pr_gid;
pid_t pr_pid;
pid_t pr_ppid;
pid_t pr_pgrp;
pid_t pr_sid;
char pr_fname[16];
char pr_psargs[80];
}
(gdb)
where the individual data types of most members are the same across all
64-bit Linux ports, with the exception of `__kernel_uid_t' and
`__kernel_gid_t'. These are defined in <asm-generic/posix_types.h> as
32-bit `unsigned int' by default, however overridden as 16-bit `unsigned
short' in port-specific <asm/posix_types.h> for the SuperH target.
The default is already handled, as from the commit referred. Add the
other variant then and provide a backend flag to switch between the two
cases possible, with the 32-bit one being the default and the 16-bit one
explicitly selected. Set the flag in the SuperH target backend. This
arrangement is analogous to how the 32-bit Linux core PRPSINFO note is
handled.
bfd/
* elf-bfd.h (elf_backend_data): Add `linux_prpsinfo64_ugid16'
member.
* elf-linux-core.h (elf_external_linux_prpsinfo64): Rename to...
(elf_external_linux_prpsinfo64_ugid32): ... this.
(swap_linux_prpsinfo32_out): Rename to...
(swap_linux_prpsinfo32_ugid32_out): ... this.
(elf_external_linux_prpsinfo64_ugid16): New structure.
(swap_linux_prpsinfo64_ugid16_out): New function.
* elfxx-target.h [!elf_backend_linux_prpsinfo64_ugid16]
(elf_backend_linux_prpsinfo64_ugid16): Define.
(elfNN_bed): Initialize `linux_prpsinfo64_ugid16' member.
* elf.c (elfcore_write_linux_prpsinfo64): Handle both variants
of the 64-bit Linux core PRPSINFO note.
* elf64-sh64.c (elf_backend_linux_prpsinfo64_ugid16): Define.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add native target for FreeBSD/arm.
@ 2017-10-11 20:32 sergiodj+buildbot
2017-10-12 0:13 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-11 20:32 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 4f9d99066edcefab0e5868d20cb9ddaa7b76da52 ***
Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: 4f9d99066edcefab0e5868d20cb9ddaa7b76da52
Add native target for FreeBSD/arm.
gdb/ChangeLog:
* Makefile.in (ALLDEPFILES): Add arm-fbsd-nat.c.
* NEWS: Mention new FreeBSD/arm native configuration.
* configure.host: Add arm*-*-freebsd*.
* configure.nat: Likewise.
* arm-fbsd-nat.c: New file.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove prepare_re_set_context
@ 2017-10-11 22:52 sergiodj+buildbot
2017-10-12 2:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-11 22:52 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT fdf44873ec6e37417bf8c8ce33bb9b1a6b4ddcef ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: fdf44873ec6e37417bf8c8ce33bb9b1a6b4ddcef
Remove prepare_re_set_context
prepare_re_set_context returns a null cleanup and doesn't seem
generally useful. This patch removes it plus a few more cleanups; and
changes breakpoint_re_set to use scoped_restore rather than its own
manual mechanism.
2017-10-11 Tom Tromey <tom@tromey.com>
* breakpoint.c (prepare_re_set_context): Remove.
(breakpoint_re_set_one): Update. Don't use cleanups.
(breakpoint_re_set): Use scoped_restore, std::string, and
scoped_restore_current_language.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Constify add_prefix_cmd
@ 2017-10-11 23:12 sergiodj+buildbot
2017-10-12 4:05 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-11 23:12 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 981a3fb3594dddae266b7a5014c3001727200d7b ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 981a3fb3594dddae266b7a5014c3001727200d7b
Constify add_prefix_cmd
This changes add_prefix_cmd to accept a const-taking function as an
argument; then fixes up all the callers.
In a couple of spots I had to add a non-const overload of a function,
because the function is passed to two different command-adding
"constructors". These overloads are temporary; once constification is
complete they can be removed.
This patch also fixes a typo I happened to notice while constifying.
Note that this touches a couple of files (gnu-nat.c and go32-nat.c)
that I can't build. So, while I made a best-effort there, I am not
certain they will still compile.
Tested by rebuilding.
gdb/ChangeLog
2017-10-11 Tom Tromey <tom@tromey.com>
* gdbthread.h (thread_command): Constify.
* inferior.h (detach_command): Constify.
* top.h (set_history, show_history): Constify.
* arm-tdep.c (set_arm_command, show_arm_command): Constify.
* serial.c (serial_set_cmd, serial_show_cmd): Constify.
* bsd-kvm.c (bsd_kvm_cmd): Constify.
* printcmd.c (set_command): Constify.
(non_const_set_command): New function.
* dcache.c (set_dcache_command, show_dcache_command): Constify.
* breakpoint.c (enable_command, disable_command, delete_command)
(catch_command, tcatch_command, set_breakpoint_cmd)
(show_breakpoint_cmd): Constify.
* macrocmd.c (macro_command): Constify.
* infcmd.c (unset_command, kill_command, detach_command)
(info_proc_cmd): Constify.
* i386-tdep.c (set_mpx_cmd, show_mpx_cmd): Constify.
* auto-load.c (show_auto_load_cmd, set_auto_load_cmd)
(info_auto_load_cmd): Constify.
* target-descriptions.c (set_tdesc_cmd, show_tdesc_cmd)
(unset_tdesc_cmd): Constify.
* ada-lang.c (set_ada_command, show_ada_command)
(maint_set_ada_cmd, maint_show_ada_cmd): Constify.
* guile/guile.c (set_guile_command, show_guile_command)
(info_guile_command): Constify.
* tui/tui-win.c (tui_command, set_tui_cmd, show_tui_cmd):
Constify.
* skip.c (skip_command): Constify.
* compile/compile.c (_initialize_compile): Constify.
* dwarf2read.c (set_dwarf_cmd, show_dwarf_cmd): Constify.
* btrace.c (maint_btrace_cmd, maint_btrace_set_cmd)
(maint_btrace_show_cmd, maint_btrace_pt_set_cmd)
(maint_btrace_pt_show_cmd): Constify.
* remote.c (set_remote_cmd, show_remote_cmd, remote_command):
Constify.
* python/python.c (user_show_python, user_set_python): Constify.
* mips-tdep.c (set_mips_command, show_mips_command)
(set_mipsfpu_command): Constify.
* record-btrace.c (cmd_record_btrace_start)
(cmd_set_record_btrace, cmd_show_record_btrace)
(cmd_set_record_btrace_bts, cmd_show_record_btrace_bts)
(cmd_set_record_btrace_pt, cmd_show_record_btrace_pt): Constify.
* rs6000-tdep.c (set_powerpc_command, show_powerpc_command):
Constify.
* symfile.c (overlay_command): Constify.
* spu-tdep.c (set_spu_command, show_spu_command): Constify.
* cli/cli-logging.c (set_logging_command, show_logging_command):
Constify.
* cli/cli-dump.c (dump_command, append_command)
(srec_dump_command, ihex_dump_command, verilog_dump_command)
(tekhex_dump_command, binary_dump_command)
(binary_append_command): Constify.
* cli/cli-decode.c (struct cmd_list_element): Change type of
"fun".
* cli/cli-cmds.c (info_command, show_command, set_debug)
(show_debug): Constify.
(show_command): Add non-const overload.
* top.c (set_history, show_history): Constify.
* sh-tdep.c (set_sh_command, show_sh_command): Constify.
* command.h (add_prefix_cmd): Accept a cmd_const_cfunc_ftype.
* target.c (target_command): Constify.
* sparc64-tdep.c (info_adi_command): Constify.
* record-full.c (cmd_record_full_start): Constify.
(set_record_full_command): Constify. Fix typo.
(show_record_full_command): Constify.
* thread.c (thread_command, thread_apply_command): Constify.
* memattr.c (dummy_cmd): Constify.
* value.c (function_command): Constify.
* frame.c (set_backtrace_cmd, show_backtrace_cmd): Constify.
* probe.c (info_probes_command): Constify.
* ser-tcp.c (set_tcp_cmd, show_tcp_cmd): Constify.
* gnu-nat.c (set_task_cmd, show_task_cmd, set_thread_cmd)
(show_thread_cmd, set_thread_default_cmd)
(show_thread_default_cmd): Constify.
(check_empty): Constify.
* tracepoint.c (tfind_command): Constify.
* cp-support.c (maint_cplus_command): Constify.
* windows-tdep.c (info_w32_command): Constify.
* record.c (cmd_record_start, set_record_command)
(show_record_command, info_record_command, cmd_record_goto):
Constify.
* ravenscar-thread.c (set_ravenscar_command)
(show_ravenscar_command): Constify.
* utils.c (set_internal_problem_cmd, show_internal_problem_cmd):
Constify.
(add_internal_problem_command): Remove casts.
* arc-tdep.c (maintenance_print_arc_command): Constify.
* valprint.c (set_print, show_print, set_print_raw)
(show_print_raw): Constify.
* maint.c (maintenance_command, maintenance_info_command)
(maintenance_print_command, maintenance_set_cmd)
(maintenance_show_cmd, set_per_command_cmd)
(show_per_command_cmd, maintenance_check_command): Constify.
* language.c (set_check, show_check): Constify.
* typeprint.c (show_print_type, set_print_type): Constify.
* go32-nat.c (go32_info_dos_command): Constify.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove cleanups from TUI
@ 2017-10-12 2:45 sergiodj+buildbot
2017-10-12 5:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-12 2:45 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f71c8822611a552e76843142a52b8197be0ea34a ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: f71c8822611a552e76843142a52b8197be0ea34a
Remove cleanups from TUI
This removes the last cleanups from the TUI, by using std::string
rather than manual memory management.
Regression tested against gdb.tui/*.exp on Fedora 26 x86-64.
gdb/ChangeLog
2017-10-09 Tom Tromey <tom@tromey.com>
* tui/tui-win.c (tui_set_win_height, parse_scrolling_args): Use
std::string.
* tui/tui-layout.c (enum tui_status): Use std::string.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix remaining targets using wrong .interp conditions
@ 2017-10-12 3:23 sergiodj+buildbot
2017-10-12 6:29 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-12 3:23 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f5233a1611d7d459a762b5fa93d7594a6965971f ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: f5233a1611d7d459a762b5fa93d7594a6965971f
Fix remaining targets using wrong .interp conditions
* elf32-nds32.c (nds32_elf_size_dynamic_sections): Set .interp
when executable rather than non-PIC.
* elf32-score.c (s3_bfd_score_elf_size_dynamic_sections): Likewise.
* elf32-score7.c (s7_bfd_score_elf_size_dynamic_sections): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] _bfd_elf_link_hash_hide_symbol calls in generic ELF code
@ 2017-10-12 3:43 sergiodj+buildbot
2017-10-12 8:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-12 3:43 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 559192d89d743834951fc386530c6bc7f89b358d ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 559192d89d743834951fc386530c6bc7f89b358d
_bfd_elf_link_hash_hide_symbol calls in generic ELF code
This function shouldn't be called directly, except from backend code.
bfd/
* elflink.c (_bfd_elf_adjust_dynamic_symbol): Call
elf_backend_hide_symbol, not _bfd_elf_link_hash_hide_symbol.
(bfd_elf_define_start_stop): Likewise.
ld/
* emultempl/elf32.em (before_allocation): Call
elf_backend_hide_symbol, not _bfd_elf_link_hash_hide_symbol.
Formatting.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: Add _bfd_x86_elf_hide_symbol
@ 2017-10-12 9:37 sergiodj+buildbot
2017-10-12 10:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-12 9:37 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9f8575350f980aa6da8c488c6aa30862620eaa1f ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 9f8575350f980aa6da8c488c6aa30862620eaa1f
x86: Add _bfd_x86_elf_hide_symbol
When there is no dynamic interpreter in PIE, make the undefined weak
symbol dynamic so that PC relative branch to the undefined weak symbol
will land to address 0.
* elf32-i386.c (elf_backend_hide_symbol): New.
* elf64-x86-64.c (elf_backend_hide_symbol): Likewise.
* elfxx-x86.c (_bfd_x86_elf_hide_symbol): Likewise.
* elfxx-x86.h (_bfd_x86_elf_hide_symbol): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Force the AArch64 linker backend to refuse to link when it encounters unresoleable relocations.
@ 2017-10-12 13:05 sergiodj+buildbot
2017-10-12 13:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-12 13:05 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 1d75a8e26e6def4f492c84a5f678e41ddebda799 ***
Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 1d75a8e26e6def4f492c84a5f678e41ddebda799
Force the AArch64 linker backend to refuse to link when it encounters unresoleable relocations.
* reloc.c (enum bfd_reloc_status): Start values at 2.
* bfd-in2.h: Regenerate.
* elfnn-aarch64.c (aarch64_relocate): Invert sense of function, so
that a TRUE return indicates success. Compare the result of
calling _bfd_aarch64_elf_put_addend against bfd_reloc_ok.
(build_one_stub): Change sense of tests against aarch64_relocate
return value.
(elfNN_aarch64_tls_relax): Return bfd_reloc_notsupported, rather
than FALSE, when an error is detected.
(elfNN_aarch64_final_link_relocate): Likewise.
* testsuite/ld-aarch64/pcrel_pic_defined.d: Expect errors not
warnings. Expect errors about unsupported relocations.
* testsuite/ld-aarch64/pcrel_pic_undefined.d: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Enable gdb.base/inferior-died.exp on is_remote target boards
@ 2017-10-12 18:10 sergiodj+buildbot
2017-10-12 19:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-12 18:10 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 4e04f0450f83d8d0ad08579b5e6c8b4e8a8e693f ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 4e04f0450f83d8d0ad08579b5e6c8b4e8a8e693f
Enable gdb.base/inferior-died.exp on is_remote target boards
We support follow-fork in the remote protocol nowadays.
Also, the right way to enable non-stop mode is to do it before
connecting, and for use_gdb_stub boards, that means we have to do it
at gdb_load time. The "modern" pattern for that is to pass non-stop
in GDBFLAGS.
This makes the test pass with --target_board=native-gdbserver.
gdb/testsuite/ChangeLog:
2017-10-12 Pedro Alves <palves@redhat.com>
Simon Marchi <simon.marchi@polymtl.ca>
* gdb.base/inferior-died.exp: Remove is_remote and isnative
checks. Use build_executable + clean_restart instead of
prepare_for_testing. Pass "set non-stop on" via GDBFLAGS instead
of enabling non-stop after starting gdb.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Tighten remote check in gdb.base/argv0-symlink.exp
@ 2017-10-12 18:52 sergiodj+buildbot
2017-10-12 21:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-12 18:52 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 30440677f3d0cdd2085bea40496774ffa24f6bb1 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 30440677f3d0cdd2085bea40496774ffa24f6bb1
Tighten remote check in gdb.base/argv0-symlink.exp
Check for gdbserver instead of dejagnu remote. Unlike what the
comment says, the test actually fails with target remote + gdbserver
(it does pass with extended-remote). The result is:
FAIL -> KFAIL with --target_board=native-gdbserver
KPASS -> PASS with --target_board=native-extended-gdbserver
gdb/testsuite/ChangeLog:
2017-10-12 Pedro Alves <palves@redhat.com>
Simon Marchi <simon.marchi@polymtl.ca>
* gdb.base/argv0-symlink.exp: kfail on remote gdbserver,
instead of on dejagnu remote boards.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] checkpoint.exp: Check for non-"target native" instead of isnative/is_remote
@ 2017-10-12 19:33 sergiodj+buildbot
2017-10-12 23:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-12 19:33 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e48ef82dd2fc85560d14a45a632c82eaaadca7ce ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: e48ef82dd2fc85560d14a45a632c82eaaadca7ce
checkpoint.exp: Check for non-"target native" instead of isnative/is_remote
This gets rid of a number of FAILs with
--target_board=native-extended-gdbserver.
The fact that checkpointing does not work has nothing to do with
dejagnu's native and remote concepts. It only works with native Linux
targets because the implementation is currently baked with
linux-nat.c.
gdb/testsuite/ChangeLog:
2017-10-12 Pedro Alves <palves@redhat.com>
Simon Marchi <simon.marchi@polymtl.ca>
* gdb.base/checkpoint.exp: Don't check is_remote or isnative.
Instead skip if there's any gdb_protocol set.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] lwp_info: Make the arch code free arch_lwp_info
@ 2017-10-12 21:52 sergiodj+buildbot
2017-10-13 2:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-12 21:52 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 466eeceef409597388dd2b4e8b907cf080bedcf1 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 466eeceef409597388dd2b4e8b907cf080bedcf1
lwp_info: Make the arch code free arch_lwp_info
I have the goal of "poisoning" the XNEW/xfree-family of functions, so
that we catch their usages with non-POD types. A few things need to be
fixed in the mean time, this is one.
The common lwp code in linux-nat.c and gdbserver/linux-low.c xfrees the
private lwp data of type arch_lwp_info. However, that type is opaque
from its point of view, as its defined differently in each arch-specific
implementation. This trips on the std::is_pod<T> check, since the
compiler can't tell whether the type is POD or not if it doesn't know
about it.
My initial patch [1] made a class hierarchy with a virtual destructor.
However, as Pedro pointed out, we only have one native architecture at
the time built in gdb and gdbserver, so that's overkill. Instead, we
can move the responsibility of free'ing arch_lwp_info to the arch code
(which is also the one that allocated it in the first place). This is
what this patch does.
Also, I had the concern that if we wanted to use C++ features in these
structures, we would have a problem with the one-definition rule.
However, since a build will only have one version of arch_lwp_info,
that's not a problem.
There are changes in arch-specific files, I was only able to built-test
this patch with the following cross-compilers:
aarch64-linux-gnu
alpha-linux-gnu
arm-linux-gnueabihf
hppa-linux-gnu
m68k-linux-gnu
mips64el-linux-gnuabi64
powerpc64-linux-gnu
s390x-linux-gnu
sh4-linux-gnu
sparc64-linux-gnu
x86_64-linux-gnu
x86_64-w64-mingw32
A buildbot run didn't find any regression.
[1] https://sourceware.org/ml/gdb-patches/2017-08/msg00255.html
gdb/ChangeLog:
* linux-nat.h (linux_nat_set_delete_thread): New declaration.
* linux-nat.c (linux_nat_delete_thread): New variable.
(lwp_free): Invoke linux_nat_delete_thread if set.
(linux_nat_set_delete_thread): New function.
* aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Assign
thread delete callback.
* arm-linux-nat.c (arm_linux_delete_thread): New function.
(_initialize_arm_linux_nat): Assign thread delete callback.
* s390-linux-nat.c (s390_delete_thread): New function.
(_initialize_s390_nat): Assign thread delete callback.
* x86-linux-nat.c (x86_linux_add_target): Likewise.
* nat/aarch64-linux.c (aarch64_linux_delete_thread): New
function.
* nat/aarch64-linux.h (aarch64_linux_delete_thread): New
declaration.
* nat/x86-linux.c (x86_linux_delete_thread): New function.
* nat/x86-linux.h (x86_linux_delete_thread): New declaration.
gdb/gdbserver/ChangeLog:
* linux-aarch64-low.c (the_low_target): Add thread delete
callback.
* linux-arm-low.c (arm_delete_thread): New function.
(the_low_target): Add thread delete callback.
* linux-bfin-low.c (the_low_target): Likewise.
* linux-crisv32-low.c (the_low_target): Likewise.
* linux-low.c (delete_lwp): Invoke delete_thread callback if
set.
* linux-low.h (struct linux_target_ops) <delete_thread>: New
field.
* linux-m32r-low.c (the_low_target): Add thread delete callback.
* linux-mips-low.c (mips_linux_delete_thread): New function.
(the_low_target): Add thread delete callback.
* linux-ppc-low.c (the_low_target): Likewise.
* linux-s390-low.c (the_low_target): Likewise.
* linux-sh-low.c (the_low_target): Likewise.
* linux-tic6x-low.c (the_low_target): Likewise.
* linux-tile-low.c (the_low_target): Likewise.
* linux-x86-low.c (the_low_target): Likewise.
* linux-xtensa-low.c (the_low_target): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] linux low: Make the arch code free arch_process_info
@ 2017-10-12 23:51 sergiodj+buildbot
2017-10-13 3:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-12 23:51 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 04ec7890fccfa5ddd9cc92961a4df58957ca181b ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 04ec7890fccfa5ddd9cc92961a4df58957ca181b
linux low: Make the arch code free arch_process_info
For the same reason as the previous patch, we need to make the
arch-specific code free the arch_process_info structure it allocates.
gdb/gdbserver/ChangeLog:
* linux-low.h (struct linux_target_ops) <delete_process>: New
field.
* linux-low.c (linux_mourn): Call the_low_target.delete_process.
* linux-aarch64-low.c (aarch64_linux_delete_process): New.
(struct linux_target_ops): Add delete_process callback.
* linux-arm-low.c (arm_delete_process): New.
(struct linux_target_ops): Add delete_process callback.
* linux-bfin-low.c (struct linux_target_ops): Likewise.
* linux-crisv32-low.c (struct linux_target_ops): Likewise.
* linux-m32r-low.c (struct linux_target_ops): Likewise.
* linux-mips-low.c (mips_linux_delete_process): New.
(struct linux_target_ops): Add delete_process callback.
* linux-ppc-low.c (struct linux_target_ops): Likewise.
* linux-s390-low.c (struct linux_target_ops): Likewise.
* linux-sh-low.c (struct linux_target_ops): Likewise.
* linux-tic6x-low.c (struct linux_target_ops): Likewise.
* linux-tile-low.c (struct linux_target_ops): Likewise.
* linux-x86-low.c (x86_linux_delete_process): New.
(struct linux_target_ops): Add delete_process callback.
* linux-xtensa-low.c (struct linux_target_ops): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Run gdb.base/catch-fork-static.exp on remote target boards
@ 2017-10-13 0:06 sergiodj+buildbot
2017-10-13 0:55 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-13 0:06 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 6bf0052db8bbeed41e512d1d3ce14ba2a446723d ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 6bf0052db8bbeed41e512d1d3ce14ba2a446723d
Run gdb.base/catch-fork-static.exp on remote target boards
Another case of a stale check. We support following forks in the
remote protocol nowadays.
gdb/testsuite/ChangeLog:
2017-10-12 Pedro Alves <palves@redhat.com>
Simon Marchi <simon.marchi@polymtl.ca>
* gdb.base/catch-fork-static.exp: No longer skip on is_remote
target boards.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] C++-ify prologue-value's pv_area
@ 2017-10-13 0:40 sergiodj+buildbot
2017-10-13 5:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-13 0:40 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f7b7ed97a23e2bf4a2ec27bef0fe0af55a080a94 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: f7b7ed97a23e2bf4a2ec27bef0fe0af55a080a94
C++-ify prologue-value's pv_area
This patch is an initial C++-ification of pv_area, from
prologue-value. It turns pv_area into a class with a constructor and
destructor; renames the data members; and changes various functions to
be member functions. This allows the removal of
make_cleanup_free_pv_area.
gdb/ChangeLog
2017-10-12 Tom Tromey <tom@tromey.com>
* s390-linux-tdep.c (s390_store, s390_load)
(s390_check_for_saved, s390_analyze_prologue): Update.
* rx-tdep.c (check_for_saved, rx_analyze_prologue): Update.
* rl78-tdep.c (rl78_analyze_prologue, check_for_saved): Update.
* prologue-value.h (class pv_area): Move from prologue-value.c.
Change names of members. Add constructor, destructor, member
functions.
(make_pv_area, free_pv_area, make_cleanup_free_pv_area)
(pv_area_store, pv_area_fetch, pv_area_store_would_trash)
(pv_area_fetch, pv_area_scan): Don't declare.
* prologue-value.c (struct pv_area::area_entry): Now member of
pv_area.
(struct pv_area): Move to prologue-value.h.
(pv_area::pv_area): Rename from make_pv_area.
(pv_area::~pv_area): Rename from free_pv_area.
(do_free_pv_area_cleanup, make_cleanup_free_pv_area): Remove.
(clear_entries, find_entry, overlaps, store_would_trash, store)
(fetch, find_reg, scan): Now member of pv_area.
Remove "area" argument. Update.
* msp430-tdep.c (check_for_saved, msp430_analyze_prologue):
Update.
* mn10300-tdep.c (push_reg, check_for_saved)
(mn10300_analyze_prologue): Update.
* mep-tdep.c (is_arg_spill, check_for_saved)
(mep_analyze_prologue): Update.
* m32c-tdep.c (m32c_pv_push, m32c_srcdest_fetch)
(m32c_srcdest_store, m32c_pv_enter, m32c_is_arg_spill)
(m32c_is_struct_return, m32c_analyze_prologue): Update.
* arm-tdep.c (thumb_analyze_prologue, arm_analyze_prologue):
Update.
* arc-tdep.c (arc_is_in_prologue, arc_analyze_prologue): Update.
* aarch64-tdep.c (aarch64_analyze_prologue): Update.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove is_remote check in labels.exp
@ 2017-10-13 3:01 sergiodj+buildbot
2017-10-13 8:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-13 3:01 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT cfa34c871c6644bd7b132b5ca7f2217880f5fa9b ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: cfa34c871c6644bd7b132b5ca7f2217880f5fa9b
Remove is_remote check in labels.exp
This works fine with remote target boards.
gdb/testsuite/ChangeLog:
2017-10-12 Simon Marchi <simon.marchi@polymtl.ca>
Pedro Alves <palves@redhat.com>
* gdb.base/label.exp: Remove is_remote target check.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove references to gdb64 in the testsuite
@ 2017-10-13 3:20 sergiodj+buildbot
2017-10-13 10:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-13 3:20 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 8aed1c0d04e6d0eb7d0790c4691665cffef573b7 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 8aed1c0d04e6d0eb7d0790c4691665cffef573b7
Remove references to gdb64 in the testsuite
I'm not sure whether this gdb64 was ever a thing in the upstream repo,
but it certainly doesn't exist nowadays.
AFAICT, this came in with the original big merge with the HP tree:
https://sourceware.org/ml/gdb-patches/1999-q2/msg00149.html
gdb/testsuite/ChangeLog:
2017-10-12 Pedro Alves <palves@redhat.com>
* gdb.base/attach.exp: Remove references to gdb64.
* gdb.base/dbx.exp: Remove references to gdb64.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] FT32: support for FT32B processor - part 1
@ 2017-10-13 4:53 sergiodj+buildbot
2017-10-13 15:05 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-13 4:53 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 3b4b0a629a972bf80fc0ac6202f89681fab1df37 ***
Author: James Bowman <jamesb@excamera.com>
Branch: master
Commit: 3b4b0a629a972bf80fc0ac6202f89681fab1df37
FT32: support for FT32B processor - part 1
FT32B is a new FT32 family member. It has a code
compression scheme, which requires the use of linker
relaxations. The change is quite large, so submission
is in several parts.
Part 1 adds a 15-bit instruction field, and CPU-specific functions for
the code compression that are used in binutils and GDB.
bfd/ChangeLog:
2017-10-12 James Bowman <james.bowman@ftdichip.com>
* bfd-in2.h: Regenerate.
* libbfd.h: Regenerate.
* elf32-ft32.c: Add HOWTO R_FT32_15.
* reloc.c: Add BFD_RELOC_FT32_15.
gas/ChangeLog:
2017-10-12 James Bowman <james.bowman@ftdichip.com>
* config/tc-ft32.c (md_assemble): Replace FT32_FLD_K8 with
K15.
(md_apply_fix, tc_gen_reloc): Add BFD_RELOC_FT32_15.
include/ChangeLog:
2017-10-12 James Bowman <james.bowman@ftdichip.com>
* elf/ft32.h: Add R_FT32_15.
* opcode/ft32.h: Replace FT32_FLD_K8 with K15.
(ft32_shortcode, sc_compar, ft32_split_shortcode,
ft32_merge_shortcode, ft32_merge_shortcode): New functions.
opcodes/ChangeLog:
2017-10-12 James Bowman <james.bowman@ftdichip.com>
* opcodes/ft32-dis.c (print_insn_ft32): Replace FT32_FLD_K8 with K15.
* opcodes/ft32-opc.c (ft32_opc_info): Replace FT32_FLD_K8 with
K15. Add jmpix pattern.
sim/ChangeLog:
2017-10-12 James Bowman <james.bowman@ftdichip.com>
* sim/ft32/interp.c (step_once): Replace FT32_FLD_K8 with K15.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Eliminate is_remote check in gdb.base/shlib-call.exp
@ 2017-10-13 9:47 sergiodj+buildbot
2017-10-13 18:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-13 9:47 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 5e830d9807b91f806524ff822d953443c8fb3d2f ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 5e830d9807b91f806524ff822d953443c8fb3d2f
Eliminate is_remote check in gdb.base/shlib-call.exp
gdb/testsuite/ChangeLog:
2017-10-13 Pedro Alves <palves@redhat.com>
* gdb.base/shlib-call.exp (top level): Use gdb_run_cmd and remove
is_remote target check.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix is_remote check in gdb.base/remote.exp
@ 2017-10-13 11:37 sergiodj+buildbot
2017-10-13 21:51 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-13 11:37 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 23fb630af09f2601e7cb75233837399d67cfd017 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 23fb630af09f2601e7cb75233837399d67cfd017
Fix is_remote check in gdb.base/remote.exp
1. Otherwise, when the native-gdbserver board stops setting is_remote,
this test would stop running there.
2. Makes the test run with --target_board=native-extended-gdbserver
too.
gdb/testsuite/ChangeLog:
2017-10-13 Pedro Alves <palves@redhat.com>
* gdb.base/remote.exp: Check gdb_protocol instead of is_remote.
(top level): Add comment.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Skip gdb.threads/thread_events.exp on RSP targets properly
@ 2017-10-13 12:26 sergiodj+buildbot
2017-10-14 0:22 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-13 12:26 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d7bcd5b8e55c54543389196fd18453db6961e314 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: d7bcd5b8e55c54543389196fd18453db6961e314
Skip gdb.threads/thread_events.exp on RSP targets properly
Fixes, with --target_board=native-extended-gdbserver:
Running ..../src/gdb/testsuite/gdb.threads/thread_events.exp ...
FAIL: gdb.threads/thread_events.exp: continue to after_join_func with messages enabled (saw 0, expected 1)
gdb/testsuite/ChangeLog:
2017-10-13 Pedro Alves <palves@redhat.com>
* gdb.threads/thread_events.exp: Check gdb_protocol instead of
is_remote.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] kfail gdb.python/py-evsignal.exp on RSP targets properly
@ 2017-10-13 12:51 sergiodj+buildbot
2017-10-14 1:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-13 12:51 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 8d6ef72b0470dfb1133525c8c4556d3578744ac4 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 8d6ef72b0470dfb1133525c8c4556d3578744ac4
kfail gdb.python/py-evsignal.exp on RSP targets properly
Fixes, with --target_board=native-extended-gdbserver:
Running ..../src/gdb/testsuite/gdb.python/py-evsignal.exp ...
FAIL: gdb.python/py-evsignal.exp: signal Thread 3
gdb/testsuite/ChangeLog:
2017-10-13 Pedro Alves <palves@redhat.com>
* gdb.python/py-evsignal.exp: Check gdb_protocol instead of
is_remote.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove is_remote kfail from gdb.python/py-evthreads.exp
@ 2017-10-13 14:31 sergiodj+buildbot
2017-10-14 4:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-13 14:31 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ebe3b40202042fc644df5ea3bd111425ba1aeeee ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: ebe3b40202042fc644df5ea3bd111425ba1aeeee
Remove is_remote kfail from gdb.python/py-evthreads.exp
This testcase works fine with gdbserver nowadays. So remove the
kfail.
gdb/testsuite/ChangeLog:
2017-10-13 Pedro Alves <palves@redhat.com>
Simon Marchi <simon.marchi@polymtl.ca>
PR python/12966
* gdb.python/py-evthreads.exp: Remove is_remote target kfail.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Change objfile to use new/delete
@ 2017-10-13 15:16 sergiodj+buildbot
2017-10-14 6:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-13 15:16 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9e86da0760aa1e52178cc5b90cd92a7cd4a338f9 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 9e86da0760aa1e52178cc5b90cd92a7cd4a338f9
Change objfile to use new/delete
This changes objfiles to use new and delete rather than xmalloc and
free. Simon noticed that it uses a non-POD and so shouldn't be
allocated with XCNEW; and I wanted to be able to use another non-POD as
a member; this patch is the result.
Regression tested by the buildbot.
2017-10-13 Tom Tromey <tom@tromey.com>
* compile/compile-object-run.c (do_module_cleanup): Use delete.
* solib.c (update_solib_list, reload_shared_libraries_1): Use
delete.
* symfile.c (symbol_file_add_with_addrs): Use new.
(symbol_file_add_separate): Update comment.
(syms_from_objfile_1, remove_symbol_file_command): Use delete.
* jit.c (jit_object_close_impl): Use new.
(jit_unregister_code): Use delete.
* objfiles.c (objfile::objfile): Rename from allocate_objfile.
(~objfile): Rename from free_objfile.
(free_objfile_separate_debug, do_free_objfile_cleanup)
(free_all_objfiles, objfile_purge_solibs): Use delete.
* objfiles.h (struct objfile): Add constructor and destructor.
Use DISABLE_COPY_AND_ASSIGN. Add initializers to data members.
(allocate_objfile, free_objfile): Don't declare.
(struct objstats): Add initializers.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Regenerate features/s390-gs-linux64.c and features/s390x-gs-linux64.c
@ 2017-10-13 15:42 sergiodj+buildbot
2017-10-14 8:13 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-13 15:42 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 4bf3f4a810813214213ad4f7d869eb24e79d77af ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 4bf3f4a810813214213ad4f7d869eb24e79d77af
Regenerate features/s390-gs-linux64.c and features/s390x-gs-linux64.c
gdb:
2017-10-13 Yao Qi <yao.qi@linaro.org>
* features/s390-gs-linux64.c: Regenerated.
* features/s390x-gs-linux64.c: Regenerated.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Make gdb.base/find-unmapped.exp pass on remote targets
@ 2017-10-13 16:57 sergiodj+buildbot
2017-10-14 11:14 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-13 16:57 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 8b0553c18f0dc63ab0ae930f2e8eed2bce4cd32c ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 8b0553c18f0dc63ab0ae930f2e8eed2bce4cd32c
Make gdb.base/find-unmapped.exp pass on remote targets
Currently, with --target_board=native-extended-gdbserver, we get:
Running .../src/gdb/testsuite/gdb.base/find-unmapped.exp ...
FAIL: gdb.base/find-unmapped.exp: find global_var_0, global_var_2, 0xff
FAIL: gdb.base/find-unmapped.exp: find global_var_1, global_var_2, 0xff
FAIL: gdb.base/find-unmapped.exp: find global_var_2, (global_var_2 + 16), 0xff
This commit makes the test pass there, and also enables in on
--target_board=native-gdbserver, and other remote targets.
I've filed PR gdb/22293 to track the missing-warning problem.
gdb/testsuite/ChangeLog:
2017-10-13 Pedro Alves <palves@redhat.com>
PR gdb/22293
* gdb.base/find-unmapped.exp: Don't skip if is_remote target.
(top level): Move some tests to ...
(test_not_found): ... this new procedure.
(top level): Call it.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix gdb.base/testenv.exp against --target_board=native-extended-gdbserver
@ 2017-10-13 18:20 sergiodj+buildbot
2017-10-14 13:38 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-13 18:20 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 50500caf810fcc6c05e3fd89bc37fe8f9e4adb07 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 50500caf810fcc6c05e3fd89bc37fe8f9e4adb07
Fix gdb.base/testenv.exp against --target_board=native-extended-gdbserver
Currently we get:
Running ..../src/gdb/testsuite/gdb.base/testenv.exp ...
FAIL: gdb.base/testenv.exp: test no TEST_GDB var
FAIL: gdb.base/testenv.exp: test with one TEST_GDB var
FAIL: gdb.base/testenv.exp: test with two TEST_GDB var
FAIL: gdb.base/testenv.exp: test with one TEST_GDB var, after unset
FAIL: gdb.base/testenv.exp: test with TEST_GDB_GLOBAL
FAIL: gdb.base/testenv.exp: test with TEST_GDB_GLOBAL unset
The problem is that the testcase relies on stdio. While we could fix
this for gdbserver by read output from inferior_spawn_id, a better fix
it to not rely on stdio at all. That's what this commit does.
Instead, it reads variables off of the inferior to extract the
necessary information.
Along the way, most of the .exp file is reimplemented/cleaned up using
more modern mechanisms. E.g., with_test_prefix, proc_with_prefix,
save_vars, etc. Also, a missing check for "is_remote host" is added.
gdb/testsuite/ChangeLog:
2017-10-13 Pedro Alves <palves@redhat.com>
* gdb.base/testenv.exp: Check use_gdb_stub instead of is_remote.
(test_num_test_vars, run_and_count_vars, find_env)
(test_set_unset_env, test_inherit_env_var): New procedures.
(top level): Use them.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Skip a few tests on targets that can't use the "run" commmand.
@ 2017-10-13 18:48 sergiodj+buildbot
2017-10-14 14:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-13 18:48 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 300b6685f17cae131166eaf2fcafe10dab06466b ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 300b6685f17cae131166eaf2fcafe10dab06466b
Skip a few tests on targets that can't use the "run" commmand.
These tests want to use raw "run", so skip them on targets that can't
do that.
Also adds a small utility procedure that clearly conveys intent instead of
explicitly checking use_gdb_stub in the testcases.
This makes sure these testcases continue to be skipped with
--target_board=native-gdbserver once that board stops setting
is_remote.
gdb/testsuite/ChangeLog:
2017-10-13 Pedro Alves <palves@redhat.com>
* lib/gdb.exp (target_can_use_run_cmd): New procedure.
* gdb.base/annota1.exp: Use it instead of is_remote.
* gdb.base/annota3.exp: Use it instead of is_remote.
* gdb.cp/annota2.exp: Use it instead of is_remote.
* gdb.cp/annota3.exp: Use it instead of is_remote.
* gdb.multi/bkpt-multi-exec.exp: Use it instead of is_remote.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Simplify tic6x and s390x expedite registers
@ 2017-10-14 2:59 sergiodj+buildbot
2017-10-14 9:27 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-14 2:59 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2399fe6ab0b6ee64c569992e4bc3bbae3b5b2193 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 2399fe6ab0b6ee64c569992e4bc3bbae3b5b2193
Simplify tic6x and s390x expedite registers
Nowadays, we have six tic6x expedite registers, which are duplicated.
tic6x-c64xp-expedite = A15,PC
tic6x-c64x-expedite = A15,PC
tic6x-c62x-expedite = A15,PC
tic6x-c64xp-linux-expedite = A15,PC
tic6x-c64x-linux-expedite = A15,PC
tic6x-c62x-linux-expedite = A15,PC
in features/Makefile, we have
echo "expedite:$(if $($*-expedite),$($*-expedite),$($(firstword $(subst -, ,$(notdir $*)))-expedite))" \
>> $(outdir)/$*.tmp
which means for a given bar/foo-baz.xml, we'll look for either
bar/foo-baz-expedite or foo-expedite. We can define only one generic
expedite register for all different ti6cx and s390x target descriptions.
Actually, we've done that for x86 target descriptions.
Re-run 'make GDB=/path/build/gdb all' to regenerate regformats/*.dat files,
and they are not changed.
gdb:
2017-10-13 Yao Qi <yao.qi@linaro.org>
* features/Makefile: Remove tic6x-*-expedite, add tic6x-expedite.
Remove s390x-*-expedite, add s390x-expedite.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Don't run gdb.gdb/ selftests if use_gdb_stub is true
@ 2017-10-14 5:29 sergiodj+buildbot
2017-10-14 12:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-14 5:29 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT dad0c6d2f7410d3b451800f856f3c6818303c316 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: dad0c6d2f7410d3b451800f856f3c6818303c316
Don't run gdb.gdb/ selftests if use_gdb_stub is true
If we make the native-gdbserver board be !is_remote, then the few
tests that use the selftest-support.exp routines to debug gdb itself
start running, and fail, with something like:
Running ..../src/gdb/testsuite/gdb.gdb/selftest.exp ...
ERROR: tcl error sourcing ..../src/gdb/testsuite/gdb.gdb/selftest.exp.
ERROR: gdbserver does not support run [....] without extended-remote
while executing
"error "gdbserver does not support $command without extended-remote""
(procedure "gdb_test_multiple" line 25)
invoked from within
"gdb_test_multiple "run $INTERNAL_GDBFLAGS" "$description" {
-re "Starting program.*Breakpoint \[0-9\]+,.*$function \\(\\).* at .*main.c:.*$gdb..."
(procedure "selftest_setup" line 45)
This commit makes sure those tests continue to be skipped.
gdb/testsuite/ChangeLog:
2017-10-13 Pedro Alves <palves@redhat.com>
* lib/selftest-support.exp (selftest_setup): Extend comments, and
also skip on stub-like targets.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Replace psymbol_allocation_list with std::vector
@ 2017-10-14 12:31 sergiodj+buildbot
2017-10-14 18:02 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-14 12:31 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT af5bf4ada48ff65b6658be1fab8f9c8f8ab5f319 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: af5bf4ada48ff65b6658be1fab8f9c8f8ab5f319
Replace psymbol_allocation_list with std::vector
psymbol_allocation_list is basically a vector implementation. We can
replace it with an std::vector, now that objfile has been C++-ified.
I sent this to the buildbot, there are a few suspicious failures, but
I don't think they are related to this patch. For example on powerpc:
new FAIL: gdb.base/catch-syscall.exp: execve: syscall execve has returned
new FAIL: gdb.base/catch-syscall.exp: execve: continue to main
new FAIL: gdb.base/catch-syscall.exp: execve: continue until exit
I get the same failures when testing manually on gcc112, without this
patch.
gdb/ChangeLog:
* objfiles.h: Don't include symfile.h.
(struct partial_symbol): Remove forward-declaration.
(struct objfile) <global_psymbols, static_psymbols>: Change type
to std::vector<partial_symbol *>.
* objfiles.c (objfile::objfile): Don't memset those fields.
(objfile::~objfile): Don't free those fields.
* psympriv.h (struct psymbol_allocation_list): Remove
forward-declaration.
(add_psymbol_to_list): Change psymbol_allocation_list parameter
to std::vector.
(start_psymtab_common): Change parameters to std::vector.
* psymtab.c: Include algorithm.
(require_partial_symbols): Call shrink_to_fit.
(find_pc_sect_psymbol): Adjust to vector change.
(match_partial_symbol): Likewise.
(lookup_partial_symbol): Likewise.
(psym_relocate): Likewise.
(dump_psymtab): Likewise.
(recursively_search_psymtabs): Likewise.
(compare_psymbols): Remove.
(sort_pst_symbols): Adjust to vector change.
(start_psymtab_common): Likewise.
(end_psymtab_common): Likewise.
(psymbol_bcache_full): De-constify return value.
(add_psymbol_to_bcache): Likewise.
(extend_psymbol_list): Remove.
(append_psymbol_to_list): Adjust to vector change.
(add_psymbol_to_list): Likewise.
(init_psymbol_list): Likewise.
(maintenance_info_psymtabs): Likewise.
(maintenance_check_psymtabs): Likewise.
* symfile.h (struct psymbol_allocation_list): Remove.
* symfile.c (reread_symbols): Adjust to vector change.
* dbxread.c (start_psymtab): Change type of parameters.
(dbx_symfile_read): Adjust to vector change.
(read_dbx_symtab): Likewise.
(start_psymtab): Change type of parameters.
* dwarf2read.c (dwarf2_build_psymtabs): Adjust to vector change.
(create_partial_symtab): Likewise.
(add_partial_symbol): Likewise.
(write_one_signatured_type): Likewise.
(recursively_write_psymbols): Likewise.
* mdebugread.c (parse_partial_symbols): Likewise.
* xcoffread.c (xcoff_start_psymtab): Change type of parameters.
(scan_xcoff_symtab): Adjust to vector change.
(xcoff_initial_scan): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Regenerate gdbserver/configure
@ 2017-10-16 10:50 sergiodj+buildbot
2017-10-16 15:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-16 10:50 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 5bfda25568c34410129c91042cdfdf10c143edac ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 5bfda25568c34410129c91042cdfdf10c143edac
Regenerate gdbserver/configure
4fa7574 (Fix gdb 8.1 Solaris compilation) changes warning.m4 and updates
configure, but gdbserver/configure is not updated.
gdb/gdbserver:
2017-10-16 Yao Qi <yao.qi@linaro.org>
* configure: Regenerated.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove regformats/tic6x-{c62x,c64x,c64xp}.dat
@ 2017-10-16 11:24 sergiodj+buildbot
2017-10-16 12:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-16 11:24 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT df27ae6a09c6e1d3e92e67b19e43c24d5f1842b2 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: df27ae6a09c6e1d3e92e67b19e43c24d5f1842b2
Remove regformats/tic6x-{c62x,c64x,c64xp}.dat
tic6x-uclinux GDBserver uses linux target descriptions, instead of these
non-linux target descriptions. So we can remove these *.dat files.
gdb:
2017-10-16 Yao Qi <yao.qi@linaro.org>
* features/Makefile (WHICH): Remove tic6x-c64xp, tic6x-c64x
tic6x-c62x.
* regformats/tic6x-c62x.dat: Remove.
* regformats/tic6x-c64x.dat: Remove.
* regformats/tic6x-c64xp.dat: Remove.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Make native gdbserver boards no longer be "remote" (in DejaGnu terms)
@ 2017-10-16 20:19 sergiodj+buildbot
2017-10-16 21:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-16 20:19 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 739b3f1d8ff7072dcc66240c25b026c6433bda1a ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 739b3f1d8ff7072dcc66240c25b026c6433bda1a
Make native gdbserver boards no longer be "remote" (in DejaGnu terms)
This commit finally clears the "isremote" flag in the native-gdbserver
and native-stdio-gdbserver boards. The goal is to make all "native"
boards be considered not remote in DejaGnu terms, like the
native-extended-gdbserver board is too.
DejaGnu automatically considers boards remote if their names don't
match the local hostname. That means that native-gdbserver and
native-extended-gdbserver are considered remote by default by DejaGnu,
even though they run locally. native-extended-gdbserver, however,
overrides its isremote flag to force it to be not remote. So we are
in that weird state where native-gdbserver is considered remote, and
native-extended-gdbserver is considered not remote.
A recent set of commits fixed all the problems (and some more) exposed
by testing with --target_board=native-gdbserver and
--target_board=native-stdio-gdbserver with isremote forced off on
x86-64 GNU/Linux. I believe we're good to go now.
The native-stdio-gdbserver.exp/remote-stdio-gdbserver.exp boards
required deep non-obvious modifications unfortunately... The problem
is that if a board is not remote, then DejaGnu doesn't call
${board}_spawn / ${board}_exec at all, and the
native-stdio-gdbserver.exp board relies on those procedures being
called. To fix that, this commit redesigns how the stdio boards hook
into the testing framework to spawn gdbserver. IMO, this is a good
change anyway, because the way its done currently is a bit of a hack,
and the result turns out to be simpler, even. With this commit, they
now no longer load the "gdbserver" generic config, and hook at the
mi_gdb_target_load/gdb_reload level instead, making them more like
traditional board files.
To share code between native-stdio-gdbserver.exp and
remote-stdio-gdbserver.exp, a new shared stdio-gdbserver-base.exp file
is created.
Instead of having each native board clear isremote manually, boards
source the new "local-board.exp" file.
This also adds a new section to testsuite/README file discussing
local/remote/native, so that we can easily refer to it.
gdb/testsuite/ChangeLog:
2017-10-16 Pedro Alves <palves@redhat.com>
Simon Marchi <simon.marchi@polymtl.ca>
* README (Local vs Remote vs Native): New section.
* boards/local-board.exp: New file, with bits factored out from
...
* boards/native-extended-gdbserver.exp: ... here. Load
"local-board".
* boards/native-gdbserver.exp: Load "local-board".
(${board}_spawn, ${board}_exec): Delete.
* boards/native-stdio-gdbserver.exp: Most contents factored out to
...
* boards/stdio-gdbserver-base.exp: ... this new file.
* boards/native-stdio-gdbserver.exp: Reimplement, by loading
"stdio-gdbserver-base" and defining a get_target_remote_pipe_cmd
procedure.
* boards/remote-stdio-gdbserver.exp: Load stdio-gdbserver-base
instead of native-stdio-gdbserver. Don't set gdb_server_prog nor
stdio_gdbserver_command.
(${board}_get_remote_address, ${board}_get_comm_port)
(${board}_download, ${board}_upload): Delete.
(get_target_remote_pipe_cmd): New.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Use std::vector in end_symtab_get_static_block
@ 2017-10-16 22:35 sergiodj+buildbot
2017-10-16 23:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-16 22:35 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b05628f0a878cdd64492bbc49d60003d699763ad ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: b05628f0a878cdd64492bbc49d60003d699763ad
Use std::vector in end_symtab_get_static_block
Change end_symtab_get_static_block to use std::vector. This removes a
cleanup.
ChangeLog
2017-10-16 Tom Tromey <tom@tromey.com>
* buildsym.c (block_compar): Remove.
(end_symtab_get_static_block): Use std::vector.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove some cleanups from probe.c
@ 2017-10-16 23:06 sergiodj+buildbot
2017-10-17 0:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-16 23:06 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2dc0e219715356c6acbc3bea85ddec288f752f1f ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 2dc0e219715356c6acbc3bea85ddec288f752f1f
Remove some cleanups from probe.c
This removes some cleanups from parse_probes by using std::string; and
removes some unnecessary cleanups from elsewhere in probe.c.
ChangeLog
2017-10-16 Tom Tromey <tom@tromey.com>
* probe.c (parse_probes): Use std::string.
(info_probes_for_ops, enable_probes_command)
(disable_probes_command): Remove cleanups.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Simple cleanup removals in remote.c
@ 2017-10-17 0:17 sergiodj+buildbot
2017-10-17 3:55 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-17 0:17 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b80406accc70791a1789e40f24d64161bc41de34 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: b80406accc70791a1789e40f24d64161bc41de34
Simple cleanup removals in remote.c
This removes a few cleanups in remote.c using the usual techniques:
std::vector, unique_xmalloc_ptr, and gdb::def_vector.
ChangeLog
2017-10-16 Tom Tromey <tom@tromey.com>
* remote.c (remote_register_number_and_offset): Use std::vector.
(remote_set_syscall_catchpoint): Use gdb::unique_xmalloc_ptr.
(putpkt_binary): Use gdb::def_vector.
(compare_sections_command): Use gdb::byte_vector.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Return unique_xmalloc_ptr from target_read_stralloc
@ 2017-10-17 1:24 sergiodj+buildbot
2017-10-17 5:07 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-17 1:24 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b7b030adc405017f01e996a90f85e40730ef8397 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: b7b030adc405017f01e996a90f85e40730ef8397
Return unique_xmalloc_ptr from target_read_stralloc
This changes target_read_stralloc to return a unique_xmalloc_ptr, and
then fixes all the callers. unique_xmalloc_ptr is used, rather than
std::string, because target_read_stralloc gives a special meaning to a
NULL return.
ChangeLog
2017-10-16 Tom Tromey <tom@tromey.com>
* xml-syscall.c (xml_init_syscalls_info): Update.
* xml-support.c (xinclude_start_include): Update.
(xml_fetch_content_from_file): Return unique_xmalloc_ptr.
* xml-support.h (xml_fetch_another): Return unique_xmalloc_ptr.
(xml_fetch_content_from_file): Likewise.
* osdata.c (get_osdata): Update.
* target.h (target_read_stralloc, target_get_osdata): Return
unique_xmalloc_ptr.
* solib-aix.c (solib_aix_get_library_list): Update.
* solib-target.c (solib_target_current_sos): Update.
* solib-svr4.c (svr4_current_sos_via_xfer_libraries): Update.
* xml-tdesc.c (fetch_available_features_from_target): Update.
(target_fetch_description_xml): Update.
(file_read_description_xml): Update.
* remote.c (remote_get_threads_with_qxfer, remote_memory_map)
(remote_traceframe_info, btrace_read_config, remote_read_btrace)
(remote_pid_to_exec_file): Update.
* target.c (target_read_stralloc): Return unique_xmalloc_ptr.
(target_get_osdata): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Record and output access specifiers for nested typedefs
@ 2017-10-17 2:05 sergiodj+buildbot
2017-10-17 7:33 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-17 2:05 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c191a6875b118fce30e7dc4d9e4bd20eff850270 ***
Author: Keith Seitz <keiths@redhat.com>
Branch: master
Commit: c191a6875b118fce30e7dc4d9e4bd20eff850270
Record and output access specifiers for nested typedefs
We currently do not record access information for typedefs defined inside
classes. Consider:
struct foo
{
typedef int PUBLIC;
private:
typedef int PRIVATE;
PRIVATE b;
};
(gdb) ptype foo
type = struct foo {
private:
PRIVATE b;
typedef int PRIVATE;
typedef int PUBLIC;
}
This patch fixes this:
(gdb) ptype foo
type = struct foo {
private:
PRIVATE b;
typedef int PRIVATE;
public:
typedef int PUBLIC;
}
gdb/ChangeLog:
* c-typeprint.c (enum access_specifier): Moved here from
c_type_print_base.
(output_access_specifier): New function.
(c_type_print_base): Consider typedefs when assessing
whether access labels are needed.
Use output_access_specifier as needed.
Output access specifier for typedefs, if needed.
* dwarf2read.c (dwarf2_add_typedef): Record DW_AT_accessibility.
* gdbtypes.h (struct typedef_field) <is_protected, is_private>: New
fields.
(TYPE_TYPEDEF_FIELD_PROTECTED, TYPE_TYPEDEF_FIELD_PRIVATE): New
accessor macros.
gdb/testsuite/ChangeLog:
* gdb.cp/classes.cc (class_with_typedefs, class_with_public_typedef)
(class_with_protected_typedef, class_with_private_typedef)
(struct_with_public_typedef, struct_with_protected_typedef)
(struct_with_private_typedef): New classes/structs.
* gdb.cp/classes.exp (test_ptype_class_objects): Add tests for
typedefs and access specifiers.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR22306, Invalid free() in slurp_symtab()
@ 2017-10-17 6:41 sergiodj+buildbot
2017-10-17 9:06 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-17 6:41 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 0301ce1486b1450f219202677f30d0fa97335419 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 0301ce1486b1450f219202677f30d0fa97335419
PR22306, Invalid free() in slurp_symtab()
PR 22306
* aoutx.h (aout_get_external_symbols): Handle stringsize of zero,
and error for any other size that doesn't cover the header word.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] [GDBserver] Move arm.o to arch/arm.o
@ 2017-10-17 12:52 sergiodj+buildbot
2017-10-17 13:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-17 12:52 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 7eb4e0f95641edebbc28a710f28111f0ecb9f0d1 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 7eb4e0f95641edebbc28a710f28111f0ecb9f0d1
[GDBserver] Move arm.o to arch/arm.o
gdb/gdbserver:
2017-10-17 Yao Qi <yao.qi@linaro.org>
* configure.srv: Rename arm.o with arch/arm.o.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] [GDBserver] Move arm-linux.o and arm-get-next-pcs.o to arch/
@ 2017-10-17 13:53 sergiodj+buildbot
2017-10-17 14:55 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-17 13:53 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e675d1703fbdec643ec42aa67b9720cb199f4375 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: e675d1703fbdec643ec42aa67b9720cb199f4375
[GDBserver] Move arm-linux.o and arm-get-next-pcs.o to arch/
gdb/gdbserver:
2017-10-17 Yao Qi <yao.qi@linaro.org>
* configure.srv: Rename arm-linux.o with arch/arm-linux.o.
Rename arm-get-next-pcs.o with arch/arm-get-next-pcs.o.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] [GDBserver] Move aarch64-insn.o to arch/ and remove one Makefile rule
@ 2017-10-17 14:23 sergiodj+buildbot
2017-10-17 16:13 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-17 14:23 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 7a7cdfa04b0225dfa6879384075e08d73eaee862 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 7a7cdfa04b0225dfa6879384075e08d73eaee862
[GDBserver] Move aarch64-insn.o to arch/ and remove one Makefile rule
gdb/gdbserver:
2017-10-17 Yao Qi <yao.qi@linaro.org>
* Makefile.in: Remove one rule.
* configure.srv: Rename aarch64-insn.o with arch/aarch64-insn.o.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Simplify regcache::xfer_part
@ 2017-10-17 14:34 sergiodj+buildbot
2017-10-17 17:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-17 14:34 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d3037ba6a398d37585b3d34ff9ed439848ba98a1 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: d3037ba6a398d37585b3d34ff9ed439848ba98a1
Simplify regcache::xfer_part
Since xfer_part is already a class method, and only
{raw,cooked}_{read,write} are passed to it. We can remove these two
arguments, but add a bool argument is_raw, indicating raw registers or
cooked registers are accessed.
gdb:
2017-10-17 Yao Qi <yao.qi@linaro.org>
* regcache.c (regcache::xfer_part): Remove parameters read and
write, add parameter is_raw. All callers are updated.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix double-free corruption
@ 2017-10-17 14:44 sergiodj+buildbot
2017-10-17 19:00 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-17 14:44 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 7b7009999ab8daac9db776c850b7df6e1f586334 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 7b7009999ab8daac9db776c850b7df6e1f586334
Fix double-free corruption
Fixes a double-free regression introduced by commit b7b030adc405
("Return unique_xmalloc_ptr from target_read_stralloc"):
gdb.sum:
Running src/gdb/testsuite/gdb.base/catch-syscall.exp ...
ERROR: Process no longer exists
Valgrind shows:
(gdb) catch syscall
==3687== Thread 1:
==3687== Invalid free() / delete / delete[] / realloc()
==3687== at 0x4C29CF0: free (vg_replace_malloc.c:530)
==3687== by 0x610862: xfree(void*) (common-utils.c:101)
==3687== by 0x440D5D: gdb::xfree_deleter<char>::operator()(char*) const (gdb_unique_ptr.h:34)
==3687== by 0x446CC6: std::unique_ptr<char, gdb::xfree_deleter<char> >::reset(char*) (unique_ptr.h:344)
==3687== by 0x81BE50: xml_fetch_content_from_file(char const*, void*) (xml-support.c:1042)
==3687== by 0x81DA86: xml_init_syscalls_info(char const*) (xml-syscall.c:366)
==3687== by 0x81DBDD: init_syscalls_info(gdbarch*) (xml-syscall.c:398)
==3687== by 0x81E131: get_syscall_by_number(gdbarch*, int, syscall*) (xml-syscall.c:599)
==3687== by 0x5BE86F: catch_syscall_command_1(char*, int, cmd_list_element*) (break-catch-syscall.c:481)
==3687== by 0x4B46B1: do_sfunc(cmd_list_element*, char*, int) (cli-decode.c:138)
==3687== by 0x4B76B8: cmd_func(cmd_list_element*, char*, int) (cli-decode.c:1952)
==3687== by 0x7E91C7: execute_command(char*, int) (top.c:615)
==3687== Address 0x14332ae0 is 0 bytes inside a block of size 4,096 free'd
==3687== at 0x4C2AB8B: realloc (vg_replace_malloc.c:785)
==3687== by 0x610792: xrealloc (common-utils.c:62)
==3687== by 0x81BE3E: xml_fetch_content_from_file(char const*, void*) (xml-support.c:1042)
==3687== by 0x81DA86: xml_init_syscalls_info(char const*) (xml-syscall.c:366)
==3687== by 0x81DBDD: init_syscalls_info(gdbarch*) (xml-syscall.c:398)
==3687== by 0x81E131: get_syscall_by_number(gdbarch*, int, syscall*) (xml-syscall.c:599)
==3687== by 0x5BE86F: catch_syscall_command_1(char*, int, cmd_list_element*) (break-catch-syscall.c:481)
==3687== by 0x4B46B1: do_sfunc(cmd_list_element*, char*, int) (cli-decode.c:138)
==3687== by 0x4B76B8: cmd_func(cmd_list_element*, char*, int) (cli-decode.c:1952)
==3687== by 0x7E91C7: execute_command(char*, int) (top.c:615)
==3687== by 0x6A422D: command_handler(char*) (event-top.c:583)
==3687== by 0x6A45F2: command_line_handler(char*) (event-top.c:773)
[...]
The problem is that if xrealloc decides it needs a new memory block,
it frees the previous block/pointer, and then text.reset() frees it
again.
gdb/ChangeLog:
2017-10-17 Pedro Alves <palves@redhat.com>
* xml-support.c (xml_fetch_content_from_file): Call
unique_ptr::release() instead unique_ptr::get() when passing
through xrealloc.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove obsolete assertion from regcache.c
@ 2017-10-17 15:53 sergiodj+buildbot
2017-10-17 21:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-17 15:53 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 57e12da97f8dbe2ad5b4f59bf89c709c4d66600d ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 57e12da97f8dbe2ad5b4f59bf89c709c4d66600d
Remove obsolete assertion from regcache.c
When building I got:
../../binutils-gdb/gdb/regcache.c:935:24: error: the address of ssize_t read(int, void*, size_t) will never be NULL [-Werror=address]
This happens because "read" used to be a parameter to this function,
which was then removed; but the assertion wasn't updated.
I don't think the assertion is relevant any more, to this removes it.
I'm checking it in as obvious.
2017-10-17 Tom Tromey <tom@tromey.com>
* regcache.c (regcache::xfer_part): Remove assertion.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add several "quit with live inferior" tests
@ 2017-10-17 17:30 sergiodj+buildbot
2017-10-18 0:02 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-17 17:30 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 8484c9554519c25c73a349d0581cc269f102c5d2 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 8484c9554519c25c73a349d0581cc269f102c5d2
Add several "quit with live inferior" tests
In my multi-target branch, I had managed to break GDB exiting
successfuly in response to "quit" or SIGHUP/SIGTERM when:
- you're debugging with "target extended-remote",
- have more than one inferior loaded in gdb, some running, and at
least one not running, and,
- quit gdb with the inferior that is not running yet selected.
The testsuite still passed cleanly anyway. I only noticed because I
was left with a bunch of core dumps in the gdb/testsuite/ directory --
the testsuite infrastructure closes GDB's pty after running each
testcase, which results in GDB getting a SIGHUP and should make GDB
exit gracefully. If GDB crashes at that point though, there's no
indication about it in gdb.sum/gdb.log.
This commit adds a multitude of tests exercising quitting GDB with
live inferiors, some of which would have caught the problem.
gdb/testsuite/ChangeLog:
2017-10-17 Pedro Alves <palves@redhat.com>
* gdb.base/quit-live.c: New file.
* gdb.base/quit-live.exp: New file.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove features/tic6x-c62x-linux.c
@ 2017-10-18 12:24 sergiodj+buildbot
2017-10-18 13:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-18 12:24 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 28c7c158766513a1c6f599c08f85851fcab855e6 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 28c7c158766513a1c6f599c08f85851fcab855e6
Remove features/tic6x-c62x-linux.c
c40c7bf (Remove features/tic6x-*.c files) doesn't remove
features/tic6x-c62x-linux.c. This patch removes it.
gdb:
2017-10-18 Yao Qi <yao.qi@linaro.org>
* features/tic6x-c62x-linux.c: Remove.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] [Visium] Disassemble the operands of the stop instruction.
@ 2017-10-18 14:57 sergiodj+buildbot
2017-10-18 15:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-18 14:57 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2a6969e1738859ea8c12837fb0cba3845bc87ceb ***
Author: Eric Botcazou <ebotcazou@gcc.gnu.org>
Branch: master
Commit: 2a6969e1738859ea8c12837fb0cba3845bc87ceb
[Visium] Disassemble the operands of the stop instruction.
binutils/
* MAINTAINERS: Add myself as Visium maintainer.
opcodes/
* visium-dis.c (disassem_class1) <case 0>: Print the operands.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Issue complaint instead of assert for invalid/unhandled DW_AT_accessibility
@ 2017-10-18 18:20 sergiodj+buildbot
2017-10-18 18:44 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-18 18:20 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 3753468682a9c7982b6eba0fca58fbfc1cd5b9fb ***
Author: Keith Seitz <keiths@redhat.com>
Branch: master
Commit: 3753468682a9c7982b6eba0fca58fbfc1cd5b9fb
Issue complaint instead of assert for invalid/unhandled DW_AT_accessibility
A previous patch called gdb_assert_not_reached whenever reading
the accessibility of a nested typedef definition. Wisely, Pedro has asked me
not do this.
This patch changes the previous one so that it issues a complaint instead.
gdb/ChangeLog:
* dwarf2read.c (dwarf2_add_typedef): Issue a complaint on unhandled
DW_AT_accessibility.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Canonicalize conversion operators
@ 2017-10-18 19:06 sergiodj+buildbot
2017-10-18 20:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-18 19:06 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c8ba13ad37c98262b94f99cc4f84ac0066c48cc2 ***
Author: Keith Seitz <keiths@redhat.com>
Branch: master
Commit: c8ba13ad37c98262b94f99cc4f84ac0066c48cc2
Canonicalize conversion operators
Consider a conversion operator such as:
operator foo const* const* ();
There are two small parser problems, highlighted by this test:
(gdb) p operator foo const* const*
There is no field named operatorfoo const* const *
GDB is looking up the symbol "operatorfoo const* const*" -- it is missing a
space between the keyword "operator" and the type name "foo const* const*".
Additionally, this input of the user-defined type needs to be canonicalized
so that different "spellings" of the type are recognized:
(gdb) p operator const foo* const *
There is no field named operator const foo* const *
gdb/ChangeLog:
* c-exp.y (oper): Canonicalize conversion operators of user-defined
types.
Add whitespace to front of type name.
gdb/testsuite/ChangeLog:
* gdb.cp/cpexprs.cc (base) <operator fluff const* const*>: New
method.
(main): Call it.
* gdb.cp/cpexprs.exp: Add new conversion operator to test matrix.
Add additional user-defined conversion operator tests.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] tile: Mark __tls_get_addr in gc_mark_hook
@ 2017-10-18 23:22 sergiodj+buildbot
2017-10-19 0:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-18 23:22 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 8e354058532d48dce19fdf0b2e0653609a69f19e ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 8e354058532d48dce19fdf0b2e0653609a69f19e
tile: Mark __tls_get_addr in gc_mark_hook
TLS_GD_CALL relocations implicitly reference __tls_get_addr. Since
elf_gc_mark_hook is called before check_relocs now, we need to call
_bfd_generic_link_add_one_symbol to mark __tls_get_addr for garbage
collection.
* elf32-tilepro.c (tilepro_elf_gc_mark_hook): Call
_bfd_generic_link_add_one_symbol to mark __tls_get_addr.
* elfxx-tilegx.c (tilegx_elf_gc_mark_hook): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] tilegx: Check bfd_link_executable for TLS check
@ 2017-10-19 13:54 sergiodj+buildbot
2017-10-19 16:00 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-19 13:54 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 280958942b74f3164708700f195188c4d3446f58 ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 280958942b74f3164708700f195188c4d3446f58
tilegx: Check bfd_link_executable for TLS check
Copied from x86, check bfd_link_executable, instead of bfd_link_pic,
for TLS transition check. Not sure if it works correctly. All usages
of bfd_link_pic should be audited.
PR ld/22263
* elfxx-tilegx.c (tilegx_elf_tls_transition): Replace
bfd_link_pic with !bfd_link_executable, !bfd_link_pic with
bfd_link_executable for TLS check.
(tilegx_elf_check_relocs): Likewise.
(allocate_dynrelocs): Likewise.
(tilegx_elf_relocate_section): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix build breakage in gdb/xml-support.c
@ 2017-10-19 18:15 sergiodj+buildbot
2017-10-19 20:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-19 18:15 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 63929e843d54d327676bed4d86dad280f4675547 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 63929e843d54d327676bed4d86dad280f4675547
Fix build breakage in gdb/xml-support.c
The buildbots are showing that the previous change to
xml_fetch_content_from_file causes __wur warnings/errors:
../../binutils-gdb/gdb/xml-support.c: In function gdb::unique_xmalloc_ptr<char> xml_fetch_content_from_file(const char*, void*):
../../binutils-gdb/gdb/xml-support.c:1028:43: error: ignoring return value of size_t fread(void*, size_t, size_t, FILE*), declared with attribute warn_unused_result [-Werror=unused-result]
fread (text.get (), 1, len, file.get ());
^
This commit fixes it.
gdb/ChangeLog:
2017-10-19 Pedro Alves <palves@redhat.com>
* xml-support.c (xml_fetch_content_from_file): Check fread's
return.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove cleanup from call_function_by_hand_dummy
@ 2017-10-20 0:10 sergiodj+buildbot
2017-10-20 0:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-20 0:10 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 395423c418da2cba1240e39ae944510fe9ffcccc ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 395423c418da2cba1240e39ae944510fe9ffcccc
Remove cleanup from call_function_by_hand_dummy
This changes call_function_by_hand_dummy to use std::string, removing
a cleanup.
ChangeLog
2017-10-19 Tom Tromey <tom@tromey.com>
* infcall.c (call_function_by_hand_dummy): Use std::string.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Get rid of VEC(interp_factory_p)
@ 2017-10-20 2:37 sergiodj+buildbot
2017-10-20 3:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-20 2:37 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 4c2287b0bdfbed95d37d09222fc253f4c5086ada ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 4c2287b0bdfbed95d37d09222fc253f4c5086ada
Get rid of VEC(interp_factory_p)
Replace it with an std::vector.
gdb/ChangeLog:
* interps.c (struct interp_factory): Add constructor.
(interp_factory_p): Remove typedef.
(DEF_VEC_P(interp_factory_p)): Remove.
(interpreter_factories): Change type to std::vector.
(interp_factory_register): Adjust.
(interp_lookup): Adjust.
(interpreter_completer): Adjust.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix 'gdb.base/quit.exp hangs forever' if the test fails
@ 2017-10-20 15:58 sergiodj+buildbot
2017-10-20 17:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-20 15:58 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 15763a09d4aea85fc3153d6746c040dd48565637 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 15763a09d4aea85fc3153d6746c040dd48565637
Fix 'gdb.base/quit.exp hangs forever' if the test fails
The [wait -i $gdb_spawn_id] in the test is dangerous in the sense that
it won't be subject to timeout logic. So if GDB fails quiting, this
testcase hangs forever, hanging the test run with it. See:
https://sourceware.org/ml/gdb-patches/2016-10/msg00728.html
Instead of 'wait'ing directly, use gdb_test_multiple and expect 'eof'.
Tested that the testcase no longer hangs by hacking the test to send
"info threads" instead of "quit".
Tested with
--target_board={unix, native-gdbserver,native-extended-gdbserver}
and tested with
--host_board=local-remote-host
as well.
gdb/testsuite/ChangeLog:
2017-10-20 Pedro Alves <palves@redhat.com>
* gdb.base/quit.exp: Use gdb_test_multiple and expect 'eof' before
'wait -i'. Use gdb_assert and remote_close.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Introduce new_bfd_ref
@ 2017-10-20 16:28 sergiodj+buildbot
2017-10-20 19:00 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-20 16:28 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2712ce2e659f82168154d4533f53d2963ae82571 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 2712ce2e659f82168154d4533f53d2963ae82571
Introduce new_bfd_ref
This introduces a helper function, new_bfd_ref, that calls gdb_bfd_ref
and returns a gdb_bfd_ref_ptr. Then it updates several places to use
this.
ChangeLog
2017-10-20 Tom Tromey <tom@tromey.com>
* exec.c (exec_file_attach): Use new_bfd_ref.
* symfile-mem.c (symbol_file_add_from_memory): Use new_bfd_ref.
* gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
(gdb_bfd_openw, gdb_bfd_openr_iovec, gdb_bfd_fdopenr): Use
new_bfd_ref.
* gdb_bfd.h (new_bfd_ref): New function.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Use "new" to allocate gdb_bfd_data
@ 2017-10-20 17:24 sergiodj+buildbot
2017-10-20 20:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-20 17:24 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 06d5bbc8e5f7541b13509c33b8b3eb8afac27b2f ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 06d5bbc8e5f7541b13509c33b8b3eb8afac27b2f
Use "new" to allocate gdb_bfd_data
This changes gdb_bfd_data to be allocated with new and destroyed with
delete.
ChangeLog
2017-10-20 Tom Tromey <tom@tromey.com>
* gdb_bfd.c (gdb_bfd_ref): Use new.
(struct gdb_bfd_data): Add constructor, destructor, and member
initializers.
(gdb_bfd_unref): Use delete.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Use std::vector in gdb_bfd_data
@ 2017-10-20 19:05 sergiodj+buildbot
2017-10-20 21:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-20 19:05 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d5833c62d93e8176b70e8509ab36cc38801c3ebd ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: d5833c62d93e8176b70e8509ab36cc38801c3ebd
Use std::vector in gdb_bfd_data
This changes gdb_bfd_data to use std::vector rather than VEC.
ChangeLog
2017-10-20 Tom Tromey <tom@tromey.com>
* gdb_bfd.c (struct gdb_bfd_data) <included_bfds>: Now a
std::vector.
(gdb_bfd_record_inclusion): Update.
(bfdp): Remove typedef.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Get rid of VEC (mem_region)
@ 2017-10-21 18:29 sergiodj+buildbot
2017-10-21 20:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-21 18:29 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a664f67e50eff30198097d51cec0ec4690abb2a1 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: a664f67e50eff30198097d51cec0ec4690abb2a1
Get rid of VEC (mem_region)
This patch removes VEC (mem_region). Doing so requires touching a lot
of little things here and there.
The fields in mem_attrib are now initialized during construction. The
values match those that were in default_mem_attrib (now removed).
unknown_mem_attrib is also removed, and replaced with a static method
(mem_attrib::unknown) that returns the equivalent.
mem_region is initialized in a way similar to mem_region_init (now
removed) did.
I found the organization of mem_region_list and target_mem_region_list a
bit confusing. Sometimes mem_region_list points to the same vector as
target_mem_region_list (and therefore does not own it), and sometimes
(when the user manually edits the mem regions) points to another vector,
and in this case owns it. To avoid this ambiguity, I think it is
simpler to have two vectors, one for target-defined regions and one for
user-defined regions, and have mem_region_list point to one or the
other. There are now no vector objects dynamically allocated, both are
static.
The make-target-delegates script does not generate valid code when a
target method returns a type with a parameter list. For this reason, I
created a typedef (mem_region_vector) that's only used in the target_ops
structure. If you speak perl, you are welcome to improve the script!
Regtested on the buildbot.
gdb/ChangeLog:
* memattr.h: Don't include vec.h.
(struct mem_attrib): Initialize fields.
<unknown>: New static method.
(struct mem_region): Add constructors, operator<, initialize
fields.
* memattr.c: Include algorithm.
(default_mem_attrib, unknown_mem_attrib): Remove.
(user_mem_region_list): New global.
(target_mem_region_list, mem_region_list): Change type to
std::vector<mem_region>.
(mem_use_target): Now a function.
(target_mem_regions_valid): Change type to bool.
(mem_region_lessthan, mem_region_cmp, mem_region_init): Remove.
(require_user_regions): Adjust.
(require_target_regions): Adjust.
(create_mem_region): Adjust.
(lookup_mem_region): Adjust.
(invalidate_target_mem_regions): Adjust.
(mem_clear): Rename to...
(user_mem_clear): ... this, and adjust.
(mem_command): Adjust.
(info_mem_command): Adjust.
(mem_enable, enable_mem_command, mem_disable,
disable_mem_command): Adjust.
(mem_delete): Adjust.
(delete_mem_command): Adjust.
* memory-map.h (parse_memory_map): Return an std::vector.
* memory-map.c (parse_memory_map): Likewise.
(struct memory_map_parsing_data): Add constructor.
<memory_map>: Point to std::vector.
(memory_map_start_memory): Adjust.
(memory_map_end_memory): Adjust.
(memory_map_end_property): Adjust.
(clear_result): Remove.
* remote.c (remote_memory_map): Return an std::vector.
* target-debug.h (target_debug_print_VEC_mem_region_s__p):
Remove.
(target_debug_print_mem_region_vector): New.
* target-delegates.c: Regenerate.
* target.h (mem_region_vector): New typedef.
(to_memory_map): Return mem_region_vector.
(target_memory_map): Return an std::vector.
* target.c (target_memory_map): Return an std::vector.
(flash_erase_command): Adjust.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Enable Intel VAES instructions.
@ 2017-10-26 7:22 sergiodj+buildbot
2017-10-26 11:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-26 7:22 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 8dcf1fadf2b0763962639fc5dcedc1892e502265 ***
Author: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
Branch: master
Commit: 8dcf1fadf2b0763962639fc5dcedc1892e502265
Enable Intel VAES instructions.
Intel has disclosed a set of new instructions. The spec is
https://software.intel.com/sites/default/files/managed/c5/15/architecture-instruction-set-extensions-programming-reference.pdf
gas/
* config/tc-i386.c (cpu_arch): Add VAES.
* doc/c-i386.texi: Document VAES.
* testsuite/gas/i386/i386.exp: Run VAES tests.
* testsuite/gas/i386/avx512f_vaes-intel.d: New test.
* testsuite/gas/i386/avx512f_vaes-wig.s: Ditto.
* testsuite/gas/i386/avx512f_vaes-wig1-intel.d: Ditto.
* testsuite/gas/i386/avx512f_vaes-wig1.d: Ditto.
* testsuite/gas/i386/avx512f_vaes.d: Ditto.
* testsuite/gas/i386/avx512f_vaes.s: Ditto.
* testsuite/gas/i386/avx512vl_vaes-intel.d: Ditto.
* testsuite/gas/i386/avx512vl_vaes-wig.s: Ditto.
* testsuite/gas/i386/avx512vl_vaes-wig1-intel.d: Ditto.
* testsuite/gas/i386/avx512vl_vaes-wig1.d: Ditto.
* testsuite/gas/i386/avx512vl_vaes.d: Ditto.
* testsuite/gas/i386/avx512vl_vaes.s: Ditto.
* testsuite/gas/i386/vaes-intel.d: Ditto.
* testsuite/gas/i386/vaes.d: Ditto.
* testsuite/gas/i386/vaes.s: Ditto.
* testsuite/gas/i386/x86-64-avx512f_vaes-intel.d: Ditto.
* testsuite/gas/i386/x86-64-avx512f_vaes-wig.s: Ditto.
* testsuite/gas/i386/x86-64-avx512f_vaes-wig1-intel.d: Ditto.
* testsuite/gas/i386/x86-64-avx512f_vaes-wig1.d: Ditto.
* testsuite/gas/i386/x86-64-avx512f_vaes.d: Ditto.
* testsuite/gas/i386/x86-64-avx512f_vaes.s: Ditto.
* testsuite/gas/i386/x86-64-avx512vl_vaes-intel.d: Ditto.
* testsuite/gas/i386/x86-64-avx512vl_vaes-wig.s: Ditto.
* testsuite/gas/i386/x86-64-avx512vl_vaes-wig1-intel.d: Ditto.
* testsuite/gas/i386/x86-64-avx512vl_vaes-wig1.d: Ditto.
* testsuite/gas/i386/x86-64-avx512vl_vaes.d: Ditto.
* testsuite/gas/i386/x86-64-avx512vl_vaes.s: Ditto.
* testsuite/gas/i386/x86-64-vaes-intel.d: Ditto.
* testsuite/gas/i386/x86-64-vaes.d: Ditto.
* testsuite/gas/i386/x86-64-vaes.s: Ditto.
opcodes/
* i386-dis.c (enum): Add PREFIX_EVEX_0F38DC, PREFIX_EVEX_0F38DD,
PREFIX_EVEX_0F38DE, PREFIX_EVEX_0F38DF.
(enum): Remove VEX_LEN_0F38DC_P_2, VEX_LEN_0F38DD_P_2,
VEX_LEN_0F38DE_P_2, VEX_LEN_0F38DF_P_2.
(vex_len_table): Ditto.
(enum): Remove VEX_W_0F38DC_P_2, VEX_W_0F38DD_P_2,
VEX_W_0F38DE_P_2, VEX_W_0F38DF_P_2.
(vew_w_table): Ditto.
(prefix_table): Adjust instructions (see prefixes above).
* i386-dis-evex.h (evex_table):
Add new instructions (see prefixes above).
* i386-gen.c (cpu_flag_init): Add VAES.
(bitfield_cpu_flags): Ditto.
* i386-opc.h (enum): Ditto.
(i386_cpu_flags): Ditto.
* i386-opc.tbl (vaes{enc,dec}{last,}): New instructions.
* i386-init.h: Regenerate.
* i386-tbl.h: Ditto.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix unstable test names in gdb.base/startup-with-shell.exp
@ 2017-10-26 9:40 sergiodj+buildbot
2017-10-26 18:55 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-26 9:40 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 10389c2c8b56b2519441e55bf16f77882fb897cb ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 10389c2c8b56b2519441e55bf16f77882fb897cb
Fix unstable test names in gdb.base/startup-with-shell.exp
Currently, if you diff testsuite/gdb.sum of two builds in different
directories you see these spurious hunks:
-PASS: gdb.base/startup-with-shell.exp: touch /home/pedro/gdb1/build/gdb/testsuite/outputs/gdb.base/startup-with-shell/unique-file.unique-extension
+PASS: gdb.base/startup-with-shell.exp: touch /home/pedro/gdb2/build/gdb/testsuite/outputs/gdb.base/startup-with-shell/unique-file.unique-extension
-PASS: gdb.base/startup-with-shell.exp: startup_with_shell = on; run_args = *.unique-extension: set args /home/pedro/gdb1/build/gdb/testsuite/outputs/gdb.base/startup-with-shell/*.unique-extension
+PASS: gdb.base/startup-with-shell.exp: startup_with_shell = on; run_args = *.unique-extension: set args /home/pedro/gdb2/build/gdb/testsuite/outputs/gdb.base/startup-with-shell/*.unique-extension
-PASS: gdb.base/startup-with-shell.exp: startup_with_shell = off; run_args = *.unique-extension: set args /home/pedro/gdb1/build/gdb/testsuite/outputs/gdb.base/startup-with-shell/*.unique-extension
+PASS: gdb.base/startup-with-shell.exp: startup_with_shell = off; run_args = *.unique-extension: set args /home/pedro/gdb2/build/gdb/testsuite/outputs/gdb.base/startup-with-shell/*.unique-extension
Since the run_args arguments are already shown in the test prefix, we
can change the "set args" test name to literally "set args $run_args".
I.e., after this commit we'll show:
PASS: gdb.base/startup-with-shell.exp: startup_with_shell = on; run_args = *.unique-extension: set args $run_args
PASS: gdb.base/startup-with-shell.exp: startup_with_shell = off; run_args = *.unique-extension: set args $run_args
PASS: gdb.base/startup-with-shell.exp: startup_with_shell = on; run_args = $TEST: set args $run_args
PASS: gdb.base/startup-with-shell.exp: startup_with_shell = off; run_args = $TEST: set args $run_args
gdb/testsuite/ChangeLog:
2017-10-24 Pedro Alves <palves@redhat.com>
* gdb.base/startup-with-shell.exp ('touch $unique_file'): Don't
include the unstable output directory name in the test's name.
(initial_setup_simple) <'set args'>: Use custom test name.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Drop /proc/PID/status polling from gdb.threads/attach-into-signal.exp
@ 2017-10-26 11:38 sergiodj+buildbot
2017-10-26 23:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-26 11:38 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 1f75a6516a4b480b5521dfb4e1a0721887ab5cdc ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 1f75a6516a4b480b5521dfb4e1a0721887ab5cdc
Drop /proc/PID/status polling from gdb.threads/attach-into-signal.exp
I noticed that the 'with_test_prefix "stoppedtry $stoppedtry"' prefix
in this testcase is unnecessary, because inside that block there are
no pass/fail calls. In fact the block includes a comment saying:
# No PASS message as we may be looping in multiple
# attempts.
but looking deeper at this I noticed a few odd things with this code
block:
1. This code is assuming that the second line in the /proc/PID/status
files is the "State:" line, which may have been true when this was
originally written, but is not true on my machine at least (Linux
4.8.13).
$ cat /proc/self/status
Name: cat
Umask: 0002
State: R (running)
So nowadays, that 'string match "*(stopped)*"' is running against
the "Umask:" line and thus always returns false, meaning the loop
always breaks on $stoppedtry == 0.
2. The loop seems to be waiting for the process to become "(stopped)",
but if so then that 'if {![string match]}' check is reversed, it
should be checking 'if {[string match]}' instead, because "string
match" returns true if the string matches, not 0.
3. But if we fixed all that, we'd still run into the simple fact that
nothing is actually stopping the test's inferior process before GDB
attaches... The top of the testcase says:
# This test was created by modifying attach-stopped.exp.
... and attach-stopped.exp does have:
# Stop the program
remote_exec build "kill -s STOP ${testpid}"
but then attach-stopped.exp doesn't have an equivalent
/proc/PID/status poll loop... (Maybe it could.)
So remove this whole loop as useless.
gdb/testsuite/ChangeLog:
2017-10-24 Pedro Alves <palves@redhat.com>
* gdb.threads/attach-into-signal.exp: Remove whole "stoppedtry"
loop.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Reindent gdb.threads/attach-into-signal.exp
@ 2017-10-26 12:26 sergiodj+buildbot
2017-10-27 0:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-26 12:26 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT eb2bfbadc159ff1463e58daf24c4ad5d1a23796d ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: eb2bfbadc159ff1463e58daf24c4ad5d1a23796d
Reindent gdb.threads/attach-into-signal.exp
A previous patch removed one nesting level.
gdb/testsuite/ChangeLog:
2017-10-24 Pedro Alves <palves@redhat.com>
* gdb.threads/attach-into-signal.exp (corefunc): Reindent.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix unstable test names in gdb.arch/arc-tdesc-cpu.exp
@ 2017-10-26 13:10 sergiodj+buildbot
2017-10-26 17:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-26 13:10 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a80e65a9d590f8817e4acd5a62363319b6a1f961 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: a80e65a9d590f8817e4acd5a62363319b6a1f961
Fix unstable test names in gdb.arch/arc-tdesc-cpu.exp
Currently if you diff testsuite/gdb.sum of two builds built from
different source trees you see this spurious hunk:
-PASS: gdb.arch/arc-tdesc-cpu.exp: set tdesc filename /home/pedro/gdb1/src/gdb/testsuite/gdb.arch/arc-tdesc-cpu.xml
+PASS: gdb.arch/arc-tdesc-cpu.exp: set tdesc filename /home/pedro/gdb2/src/gdb/testsuite/gdb.arch/arc-tdesc-cpu.xml
After this commit we'll show this instead in gdb.sum:
PASS: gdb.arch/arc-tdesc-cpu.exp: set tdesc filename $srcdir/gdb.arch/arc-tdesc-cpu.xml
gdb/testsuite/ChangeLog:
2017-10-24 Pedro Alves <palves@redhat.com>
* gdb.arch/arc-tdesc-cpu.exp ('set tdesc filename'): Use gdb_test
with explicit test name.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix gdb.opt/inline-cmds.exp regressions
@ 2017-10-26 13:38 sergiodj+buildbot
2017-10-27 3:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-26 13:38 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 5033013f17524964564dac5d422739ae5214729e ***
Author: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Branch: master
Commit: 5033013f17524964564dac5d422739ae5214729e
Fix gdb.opt/inline-cmds.exp regressions
When sorting pending blocks in end_symtab_get_static_block, blocks
with the same starting address must remain in the original order
to preserve inline function caller/callee relationships.
The original code seems to have implicitly relied on the fact that the
glibc qsort implemention actually (in the common case) provides a stable
sort, although this is not guaranteed by the standard. But the GNU
libstdc++ std::sort implementation is *not* stable.
gdb/ChangeLog:
2017-10-24 Ulrich Weigand <uweigand@de.ibm.com>
* buildsym.c (end_symtab_get_static_block): Use std::stable_sort.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] RISC-V: Only relax to C.LUI when imm != 0 and rd != 0/2
@ 2017-10-26 14:06 sergiodj+buildbot
2017-10-27 4:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-26 14:06 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 3342be5dabeeaf2218dfbf4d38f92214612436f4 ***
Author: Andrew Waterman <andrew@sifive.com>
Branch: master
Commit: 3342be5dabeeaf2218dfbf4d38f92214612436f4
RISC-V: Only relax to C.LUI when imm != 0 and rd != 0/2
This matches the ISA specification. This also adds two tests: one to
make sure the assembler rejects invalid 'c.lui's, and one to make sure
we only relax valid 'c.lui's.
bfd/ChangeLog
2017-10-24 Andrew Waterman <andrew@sifive.com>
* elfnn-riscv.c (_bfd_riscv_relax_lui): Don't relax to c.lui
when rd is x0.
include/ChangeLog
2017-10-24 Andrew Waterman <andrew@sifive.com>
* opcode/riscv.h (VALID_RVC_LUI_IMM): c.lui can't load the
immediate 0.
gas/ChangeLog
2017-10-24 Andrew Waterman <andrew@sifive.com>
* testsuite/gas/riscv/c-lui-fail.d: New testcase.
gas/testsuite/gas/riscv/c-lui-fail.l: Likewise.
gas/testsuite/gas/riscv/c-lui-fail.s: Likewise.
gas/testsuite/gas/riscv/riscv.exp: Likewise.
ld/ChangeLog
2017-10-24 Andrew Waterman <andrew@sifive.com>
* ld/testsuite/ld-riscv-elf/c-lui.d: New testcase.
ld/testsuite/ld-riscv-elf/c-lui.s: Likewise.
ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp: New test suite.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix unstable test names in gdb.gdb/unittest.exp
@ 2017-10-26 14:44 sergiodj+buildbot
2017-10-26 20:08 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-26 14:44 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT fee6da6e1d96796f8aa8308b3833a3e4cdb409ff ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: fee6da6e1d96796f8aa8308b3833a3e4cdb409ff
Fix unstable test names in gdb.gdb/unittest.exp
Currently, if you diff testsuite/gdb.sum of two builds built from different
source directories you see this spurious hunk:
-PASS: gdb.gdb/unittest.exp: maintenance check xml-descriptions /home/pedro/gdb1/src/gdb/testsuite/../features
+PASS: gdb.gdb/unittest.exp: maintenance check xml-descriptions /home/pedro/gdb2/src/gdb/testsuite/../features
After this commit we'll show instead:
PASS: gdb.gdb/unittest.exp: maintenance check xml-descriptions ${srcdir}/../features
gdb/testsuite/ChangeLog:
2017-10-24 Pedro Alves <palves@redhat.com>
* gdb.gdb/unittest.exp ('maintenance check xml-descriptions'): Use
custom test name.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix unstable test names in gdb.python/py-objfile.exp
@ 2017-10-26 16:13 sergiodj+buildbot
2017-10-26 21:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-26 16:13 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ad9b8f5d022f777f32cceab9856f47a5b6afcce1 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: ad9b8f5d022f777f32cceab9856f47a5b6afcce1
Fix unstable test names in gdb.python/py-objfile.exp
Currently, if you diff testsuite/gdb.sum of different builds you see
this spurious hunk:
-PASS: gdb.python/py-objfile.exp: get python valueof "sep_objfile.build_id" (6a0bfcab663f9810ccff33c756afdebb940037d4)
+PASS: gdb.python/py-objfile.exp: get python valueof "sep_objfile.build_id" (1f5531c657c57777b05fc95baa0025fd1d115c3b)
Fix this by syncing get_python_valueof with get_integer_valueof, which
stopped outputting the value in commit 2f20e312aad6
("get_integer_valueof: Don't output value in test name").
After this commit we'll show:
PASS: gdb.python/py-objfile.exp: get python valueof "sep_objfile.build_id"
As the comment explicitly says get_python_valueof is modeled on
get_integer_valueof, I went ahead and also added the optional 'test'
parameter while at it.
gdb/testsuite/ChangeLog:
2017-10-24 Pedro Alves <palves@redhat.com>
* lib/gdb-python.exp (get_python_valueof): Add 'test' optional
parameter and handle it. Don't output read value in test name.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Use const reference for decimal_from_string argument
@ 2017-10-26 16:36 sergiodj+buildbot
2017-10-27 10:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-26 16:36 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 09a7c6aa7a07f874f5357cde62b5753a10a5e107 ***
Author: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Branch: master
Commit: 09a7c6aa7a07f874f5357cde62b5753a10a5e107
Use const reference for decimal_from_string argument
No functional change.
gdb/ChangeLog:
2017-10-24 Ulrich Weigand <uweigand@de.ibm.com>
* dfp.h (decimal_from_string): Use const reference for argument.
* dfp.c (decimal_from_string): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR22348, conflicting global vars in crx and cr16
@ 2017-10-26 19:13 sergiodj+buildbot
2017-10-27 17:21 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-26 19:13 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e5d70d6b5a5c2832ad199ac1b91f68324b4a12c9 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: e5d70d6b5a5c2832ad199ac1b91f68324b4a12c9
PR22348, conflicting global vars in crx and cr16
include/
PR 22348
* opcode/cr16.h (instruction): Delete.
(cr16_words, cr16_allWords, cr16_currInsn): Delete.
* opcode/crx.h (crx_cst4_map): Rename from cst4_map.
(crx_cst4_maps): Rename from cst4_maps.
(crx_no_op_insn): Rename from no_op_insn.
(instruction): Delete.
opcodes/
PR 22348
* cr16-dis.c (cr16_cinvs, instruction, cr16_currInsn): Make static.
(cr16_words, cr16_allWords, processing_argument_number): Likewise.
(imm4flag, size_changed): Likewise.
* crx-dis.c (crx_cinvs, NUMCINVS, instruction, currInsn): Likewise.
(words, allWords, processing_argument_number): Likewise.
(cst4flag, size_changed): Likewise.
* crx-opc.c (crx_cst4_map): Rename from cst4_map.
(crx_cst4_maps): Rename from cst4_maps.
(crx_no_op_insn): Rename from no_op_insn.
gas/
PR 22348
* config/tc-crx.c (instruction, output_opcode): Make static.
(relocatable, ins_parse, cur_arg_num): Likewise.
(parse_insn): Adjust for renamed opcodes globals.
(check_range): Likewise
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Target FP: Use target format throughout expression parsing
@ 2017-10-26 19:34 sergiodj+buildbot
2017-10-27 18:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-26 19:34 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT edd079d9f6ca2f9ad21322b742269aec5de61190 ***
Author: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Branch: master
Commit: edd079d9f6ca2f9ad21322b742269aec5de61190
Target FP: Use target format throughout expression parsing
When parsing floating-point literals, the language parsers currently
use parse_float or some equivalent routine to parse the input string
into a DOUBLEST, which is then stored within a OP_DOUBLE expression
node. When evaluating the expression, the OP_DOUBLE is finally
converted into a value in target format.
On the other hand, *decimal* floating-point literals are parsed
directly into target format and stored that way in a OP_DECFLOAT
expression node. In order to eliminate the DOUBLEST, this patch
therefore unifies the handling of binary and decimal floating-
point literals and stores them both in target format within a
new OP_FLOAT expression node, replacing both OP_DOUBLE and
OP_DECFLOAT.
In order to store literals in target format, the parse_float
routine needs to know the type of the literal. All parsers
therefore need to be changed to determine the appropriate type
(e.g. by detecting suffixes) *before* calling parse_float,
instead of after it as today. However, this change is mostly
straightforward -- again, this is already done for decimal FP
today.
The core of the literal parsing is moved into a new routine
floatformat_from_string, mirroring floatformat_to_string.
The parse_float routine now calls either floatformat_from_string
or decimal_from_sting, allowing it to handle any type of FP
literal.
All language parsers need to be updated. Some notes on
specific changes to the various languages:
- C: Decimal FP is now handled in parse_float, and no longer
needs to be handled specially.
- D: Straightforward.
- Fortran: Still used a hard-coded "atof", also replaced by
parse_float now. Continues to always use builtin_real_s8
as the type of literal, even though this is probably wrong.
- Go: This used to handle "f" and "l" suffixes, even though
the Go language actually doesn't support those. I kept this
support for now -- maybe revisit later. Note the the GDB
test suite for some reason actually *verifies* that GDB supports
those unsupported suffixes ...
- Pascal: Likewise -- this handles suffixes that are not
supported in the language standard.
- Modula-2: Like Fortran, used to use "atof".
- Rust: Mostly straightforward, except for a unit-testing hitch.
The code use to set a special "unit_testing" flag which would
cause "rust_type" to always return NULL. This makes it not
possible to encode a literal into target format (which type?).
The reason for this flag appears to have been that during
unit testing, there is no "rust_parser" context set up, which
means no "gdbarch" is available to use its types. To fix this,
I removed the unit_testing flag, and instead simply just set up
a dummy rust_parser context during unit testing.
- Ada: This used to check sizeof (DOUBLEST) to determine which
type to use for floating-point literal. This seems questionable
to begin with (since DOUBLEST is quite unrelated to target formats),
and in any case we need to get rid of DOUBLEST. I'm now simply
always using the largest type (builtin_long_double).
gdb/ChangeLog:
2017-10-25 Ulrich Weigand <uweigand@de.ibm.com>
* doublest.c (floatformat_from_string): New function.
* doublest.h (floatformat_from_string): Add prototype.
* std-operator.def (OP_DOUBLE, OP_DECFLOAT): Remove, replace by ...
(OP_FLOAT): ... this.
* expression.h: Do not include "doublest.h".
(union exp_element): Replace doubleconst and decfloatconst by
new element floatconst.
* ada-lang.c (resolve_subexp): Handle OP_FLOAT instead of OP_DOUBLE.
(ada_evaluate_subexp): Likewise.
* eval.c (evaluate_subexp_standard): Handle OP_FLOAT instead of
OP_DOUBLE and OP_DECFLOAT.
* expprint.c (print_subexp_standard): Likewise.
(dump_subexp_body_standard): Likewise.
* breakpoint.c (watchpoint_exp_is_const): Likewise.
* parse.c: Include "dfp.h".
(write_exp_elt_dblcst, write_exp_elt_decfloatcst): Remove.
(write_exp_elt_floatcst): New function.
(operator_length_standard): Handle OP_FLOAT instead of OP_DOUBLE
and OP_DECFLOAT.
(operator_check_standard): Likewise.
(parse_float): Do not accept suffix. Take type as input. Return bool.
Return target format buffer instead of host DOUBLEST.
Use floatformat_from_string and decimal_from_string to parse
either binary or decimal floating-point types.
(parse_c_float): Remove.
* parser-defs.h: Do not include "doublest.h".
(write_exp_elt_dblcst, write_exp_elt_decfloatcst): Remove.
(write_exp_elt_floatcst): Add prototype.
(parse_float): Update prototype.
(parse_c_float): Remove.
* c-exp.y: Do not include "dfp.h".
(typed_val_float): Use byte buffer instead of DOUBLEST.
(typed_val_decfloat): Remove.
(DECFLOAT): Remove.
(FLOAT): Use OP_FLOAT and write_exp_elt_floatcst.
(parse_number): Update to new parse_float interface.
Parse suffixes and determine type before calling parse_float.
Handle decimal and binary FP types the same way.
* d-exp.y (typed_val_float): Use byte buffer instead of DOUBLEST.
(FLOAT_LITERAL): Use OP_FLOAT and write_exp_elt_floatcst.
(parse_number): Update to new parse_float interface.
Parse suffixes and determine type before calling parse_float.
* f-exp.y: Replace dval by typed_val_float.
(FLOAT): Use OP_FLOAT and write_exp_elt_floatcst.
(parse_number): Use parse_float instead of atof.
* go-exp.y (typed_val_float): Use byte buffer instead of DOUBLEST.
(parse_go_float): Remove.
(FLOAT): Use OP_FLOAT and write_exp_elt_floatcst.
(parse_number): Call parse_float instead of parse_go_float.
Parse suffixes and determine type before calling parse_float.
* p-exp.y (typed_val_float): Use byte buffer instead of DOUBLEST.
(FLOAT): Use OP_FLOAT and write_exp_elt_floatcst.
(parse_number): Update to new parse_float interface.
Parse suffixes and determine type before calling parse_float.
* m2-exp.y: Replace dval by byte buffer val.
(FLOAT): Use OP_FLOAT and write_exp_elt_floatcst.
(parse_number): Call parse_float instead of atof.
* rust-exp.y (typed_val_float): Use byte buffer instead of DOUBLEST.
(lex_number): Call parse_float instead of strtod.
(ast_dliteral): Use OP_FLOAT instead of OP_DOUBLE.
(convert_ast_to_expression): Handle OP_FLOAT instead of OP_DOUBLE.
Use write_exp_elt_floatcst.
(unit_testing): Remove static variable.
(rust_type): Do not check unit_testing.
(rust_lex_tests): Do not set uint_testing. Set up dummy rust_parser.
* ada-exp.y (type_float, type_double): Remove.
(typed_val_float): Use byte buffer instead of DOUBLEST.
(FLOAT): Use OP_FLOAT and write_exp_elt_floatcst.
* ada-lex.l (processReal): Use parse_float instead of sscanf.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] s/get_regcache_arch (regcache)/regcache->arch ()/g
@ 2017-10-26 20:23 sergiodj+buildbot
2017-10-27 19:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-26 20:23 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ac7936dfd0c85e5de2dfec45ca0dbf72baeffa51 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: ac7936dfd0c85e5de2dfec45ca0dbf72baeffa51
s/get_regcache_arch (regcache)/regcache->arch ()/g
This patches removes get_regcache_arch, and use regache->arch () instead.
The motivation of this change is that I am going to move some basic stuff
into a base class of regcache. I don't need to update "client" code
regcache->arch (). On the other hand, this patch shortens the code a
little bit.
gdb:
2017-10-25 Yao Qi <yao.qi@linaro.org>
* aarch32-linux-nat.c (aarch32_gp_regcache_supply): Use
regcache->arch () instead get_regcache_arch.
* aarch64-fbsd-nat.c (aarch64_fbsd_fetch_inferior_registers):
Likewise.
(aarch64_fbsd_store_inferior_registers): Likewise.
* aarch64-linux-nat.c (fetch_gregs_from_thread): Likewise.
(store_gregs_to_thread): Likewise.
(fetch_fpregs_from_thread): Likewise.
(store_fpregs_to_thread): Likewise.
* aarch64-tdep.c (aarch64_extract_return_value): Likewise.
(aarch64_store_return_value): Likewise.
(aarch64_software_single_step): Likewise.
* aix-thread.c (aix_thread_wait): Likewise.
(supply_reg32): Likewise.
(supply_sprs64): Likewise.
(supply_sprs32): Likewise.
(fill_gprs64): Likewise.
(fill_gprs32): Likewise.
(fill_sprs64): Likewise.
(fill_sprs32): Likewise.
(store_regs_user_thread): Likewise.
(store_regs_kernel_thread): Likewise.
* alpha-bsd-nat.c (alphabsd_fetch_inferior_registers): Likewise.
(alphabsd_store_inferior_registers): Likewise.
* alpha-tdep.c (alpha_extract_return_value): Likewise.
(alpha_store_return_value): Likewise.
(alpha_deal_with_atomic_sequence): Likewise.
(alpha_next_pc): Likewise.
(alpha_software_single_step): Likewise.
* amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Likewise.
(amd64bsd_store_inferior_registers): Likewise.
* amd64-linux-nat.c (amd64_linux_fetch_inferior_registers):
Likewise.
(amd64_linux_store_inferior_registers): Likewise.
* amd64-nat.c (amd64_supply_native_gregset): Likewise.
(amd64_collect_native_gregset): Likewise.
* amd64-obsd-tdep.c (amd64obsd_supply_uthread): Likewise.
(amd64obsd_collect_uthread): Likewise.
* amd64-tdep.c (amd64_supply_fpregset): Likewise.
(amd64_collect_fpregset): Likewise.
(amd64_supply_fxsave): Likewise.
(amd64_supply_xsave): Likewise.
(amd64_collect_fxsave): Likewise.
(amd64_collect_xsave): Likewise.
* arc-tdep.c (arc_write_pc): Likewise.
* arch-utils.c (default_skip_permanent_breakpoint): Likewise.
* arm-fbsd-nat.c (arm_fbsd_fetch_inferior_registers): Likewise.
(arm_fbsd_store_inferior_registers): Likewise.
* arm-linux-nat.c (fetch_vfp_regs): Likewise.
(store_vfp_regs): Likewise.
(arm_linux_fetch_inferior_registers): Likewise.
(arm_linux_store_inferior_registers): Likewise.
* arm-linux-tdep.c (arm_linux_supply_gregset): Likewise.
(arm_linux_sigreturn_next_pc): Likewise.
(arm_linux_get_next_pcs_syscall_next_pc): Likewise.
* arm-nbsd-nat.c (arm_supply_gregset): Likewise.
(fetch_register): Likewise.
(store_register): Likewise.
* arm-tdep.c (arm_is_thumb): Likewise.
(displaced_in_arm_mode): Likewise.
(bx_write_pc): Likewise.
(arm_get_next_pcs_addr_bits_remove): Likewise.
(arm_software_single_step): Likewise.
(arm_extract_return_value): Likewise.
(arm_store_return_value): Likewise.
(arm_write_pc): Likewise.
* bfin-tdep.c (bfin_extract_return_value): Likewise.
* bsd-uthread.c (bsd_uthread_fetch_registers): Likewise.
(bsd_uthread_store_registers): Likewise.
* core-regset.c (fetch_core_registers): Likewise.
* corelow.c (get_core_registers): Likewise.
* cris-tdep.c (cris_store_return_value): Likewise.
(cris_extract_return_value): Likewise.
(find_step_target): Likewise.
(find_step_target): Likewise.
(cris_software_single_step): Likewise.
* ctf.c (ctf_fetch_registers): Likewise.
* darwin-nat.c (cancel_breakpoint): Likewise.
* fbsd-tdep.c (fbsd_collect_thread_registers): Likewise.
* frv-tdep.c (frv_extract_return_value): Likewise.
* ft32-tdep.c (ft32_store_return_value): Likewise.
(ft32_extract_return_value): Likewise.
* go32-nat.c (fetch_register): Likewise.
(go32_fetch_registers): Likewise.
(go32_store_registers): Likewise.
(store_register): Likewise.
* h8300-tdep.c (h8300_extract_return_value): Likewise.
(h8300_store_return_value): Likewise.
* hppa-linux-nat.c (fetch_register): Likewise.
(store_register): Likewise.
(hppa_linux_fetch_inferior_registers): Likewise.
(hppa_linux_store_inferior_registers): Likewise.
* i386-darwin-nat.c (i386_darwin_fetch_inferior_registers): Likewise.
(i386_darwin_store_inferior_registers): Likewise.
* i386-gnu-nat.c (gnu_fetch_registers): Likewise.
(gnu_store_registers): Likewise.
* i386-linux-nat.c (fetch_register): Likewise.
(store_register): Likewise.
(supply_gregset): Likewise.
(fill_gregset): Likewise.
(i386_linux_fetch_inferior_registers): Likewise.
(i386_linux_store_inferior_registers): Likewise.
(i386_linux_resume): Likewise.
* i386-linux-tdep.c (i386_linux_get_syscall_number_from_regcache):
Likewise.
* i386-nto-tdep.c (i386nto_supply_gregset): Likewise.
* i386-obsd-nat.c (i386obsd_supply_pcb): Likewise.
* i386-obsd-tdep.c (i386obsd_supply_uthread): Likewise.
(i386obsd_collect_uthread): Likewise.
* i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
(i386_supply_gregset): Likewise.
(i386_collect_gregset): Likewise.
(i386_supply_fpregset): Likewise.
(i386_collect_fpregset): Likewise.
(i386_mpx_bd_base): Likewise.
* i386-v4-nat.c (supply_fpregset): Likewise.
(fill_fpregset): Likewise.
* i387-tdep.c (i387_supply_fsave): Likewise.
(i387_collect_fsave): Likewise.
(i387_supply_fxsave): Likewise.
(i387_collect_fxsave): Likewise.
(i387_supply_xsave): Likewise.
(i387_collect_xsave): Likewise.
* ia64-linux-nat.c (ia64_linux_fetch_registers): Likewise.
(ia64_linux_store_registers): Likewise.
* ia64-tdep.c (ia64_access_rse_reg): Likewise.
(ia64_extract_return_value): Likewise.
(ia64_store_return_value): Likewise.
(find_func_descr): Likewise.
* inf-child.c (inf_child_fetch_inferior_registers): Likewise.
* inf-ptrace.c (inf_ptrace_fetch_registers): Likewise.
(inf_ptrace_store_registers): Likewise.
* infrun.c (use_displaced_stepping): Likewise.
(displaced_step_prepare_throw): Likewise.
(resume): Likewise.
(proceed): Likewise.
(do_target_wait): Likewise.
(adjust_pc_after_break): Likewise.
(handle_inferior_event_1): Likewise.
(handle_signal_stop): Likewise.
(save_infcall_suspend_state): Likewise.
(restore_infcall_suspend_state): Likewise.
* iq2000-tdep.c (iq2000_extract_return_value): Likewise.
* jit.c (jit_frame_prev_register): Likewise.
* linux-nat.c (save_stop_reason): Likewise.
(linux_nat_wait_1): Likewise.
(resume_stopped_resumed_lwps): Likewise.
* linux-record.c (record_linux_sockaddr): Likewise.
(record_linux_msghdr): Likewise.
(record_linux_system_call): Likewise.
* linux-tdep.c (linux_collect_thread_registers): Likewise.
* lm32-tdep.c (lm32_extract_return_value): Likewise.
(lm32_store_return_value): Likewise.
* m32c-tdep.c (m32c_read_flg): Likewise.
(m32c_pseudo_register_read): Likewise.
(m32c_pseudo_register_write): Likewise.
* m32r-linux-tdep.c (m32r_linux_supply_gregset): Likewise.
(m32r_linux_collect_gregset): Likewise.
* m32r-tdep.c (m32r_store_return_value): Likewise.
(m32r_extract_return_value): Likewise.
* m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
(m68kbsd_collect_fpregset): Likewise.
* m68k-bsd-tdep.c (m68kbsd_supply_fpregset): Likewise.
* m68k-linux-nat.c (fetch_register): Likewise.
(old_fetch_inferior_registers): Likewise.
(old_store_inferior_registers): Likewise.
(store_regs): Likewise.
* m68k-tdep.c (m68k_svr4_extract_return_value): Likewise.
(m68k_svr4_store_return_value): Likewise.
* m88k-tdep.c (m88k_store_arguments): Likewise.
* mi/mi-main.c (mi_cmd_data_list_changed_registers): Likewise.
(mi_cmd_data_write_register_values): Likewise.
* mips-fbsd-nat.c (mips_fbsd_fetch_inferior_registers): Likewise.
(mips_fbsd_store_inferior_registers): Likewise.
* mips-fbsd-tdep.c (mips_fbsd_supply_fpregs): Likewise.
(mips_fbsd_supply_gregs): Likewise.
(mips_fbsd_collect_fpregs): Likewise.
(mips_fbsd_collect_gregs): Likewise.
(mips_fbsd_supply_fpregset): Likewise.
(mips_fbsd_collect_fpregset): Likewise.
(mips_fbsd_supply_gregset): Likewise.
(mips_fbsd_collect_gregset): Likewise.
* mips-linux-nat.c (supply_gregset): Likewise.
(fill_gregset): Likewise.
(supply_fpregset): Likewise.
(fill_fpregset): Likewise.
* mips-linux-tdep.c (mips_supply_gregset): Likewise.
(mips_fill_gregset): Likewise.
(mips_supply_fpregset): Likewise.
(mips_fill_fpregset): Likewise.
(mips64_supply_gregset): Likewise.
(micromips_linux_sigframe_validate): Likewise.
* mips-nbsd-nat.c (mipsnbsd_fetch_inferior_registers): Likewise.
(mipsnbsd_fetch_inferior_registers): Likewise.
(mipsnbsd_store_inferior_registers): Likewise.
* mips-nbsd-tdep.c (mipsnbsd_supply_fpregset): Likewise.
(mipsnbsd_supply_gregset): Likewise.
(mipsnbsd_iterate_over_regset_sections): Likewise.
(mipsnbsd_supply_reg): Likewise.
(mipsnbsd_supply_fpreg): Likewise.
* mips-tdep.c (mips_in_frame_stub): Likewise.
(mips_dummy_id): Likewise.
(is_octeon_bbit_op): Likewise.
(micromips_bc1_pc): Likewise.
(extended_mips16_next_pc): Likewise.
(mips16_next_pc): Likewise.
(deal_with_atomic_sequence): Likewise.
* moxie-tdep.c (moxie_process_readu): Likewise.
* nios2-tdep.c (nios2_get_next_pc): Likewise.
* nto-procfs.c (procfs_store_registers): Likewise.
* ppc-fbsd-nat.c (ppcfbsd_fetch_inferior_registers): Likewise.
(ppcfbsd_store_inferior_registers): Likewise.
* ppc-linux-nat.c (fetch_vsx_register): Likewise.
(fetch_altivec_register): Likewise.
(get_spe_registers): Likewise.
(fetch_spe_register): Likewise.
(fetch_altivec_registers): Likewise.
(fetch_all_gp_regs): Likewise.
(fetch_all_fp_regs): Likewise.
(store_vsx_register): Likewise.
(store_altivec_register): Likewise.
(set_spe_registers): Likewise.
(store_spe_register): Likewise.
(store_altivec_registers): Likewise.
(store_all_gp_regs): Likewise.
(store_all_fp_regs): Likewise.
* ppc-linux-tdep.c (ppc_linux_supply_gregset): Likewise.
(ppc_linux_collect_gregset): Likewise.
(ppc_canonicalize_syscall): Likewise.
(ppc_linux_record_signal): Likewise.
(ppu2spu_prev_register): Likewise.
* ppc-nbsd-nat.c (ppcnbsd_supply_pcb): Likewise.
* ppc-obsd-nat.c (ppcobsd_fetch_registers): Likewise.
(ppcobsd_store_registers): Likewise.
* ppc-ravenscar-thread.c (ppc_ravenscar_generic_fetch_registers):
Likewise.
(ppc_ravenscar_generic_store_registers): Likewise.
* procfs.c (procfs_fetch_registers): Likewise.
(procfs_store_registers): Likewise.
* ravenscar-thread.c (ravenscar_fetch_registers): Likewise.
(ravenscar_store_registers): Likewise.
(ravenscar_prepare_to_store): Likewise.
* record-btrace.c (record_btrace_fetch_registers): Likewise.
* record-full.c (record_full_wait_1): Likewise.
(record_full_registers_change): Likewise.
(record_full_store_registers): Likewise.
(record_full_core_fetch_registers): Likewise.
(record_full_save): Likewise.
(record_full_goto_insn): Likewise.
* regcache.c (regcache_register_size): Likewise.
(get_regcache_arch): Remove.
(regcache_read_pc): Likewise.
* regcache.h (get_regcache_arch): Remove.
* remote-sim.c (gdbsim_fetch_register): Likewise.
(gdbsim_store_register): Likewise.
* remote.c (fetch_register_using_p): Likewise.
(send_g_packet): Likewise.
(remote_prepare_to_store): Likewise.
(store_registers_using_G): Likewise.
* reverse.c (save_bookmark_command): Likewise.
(goto_bookmark_command): Likewise.
* rs6000-aix-tdep.c (branch_dest): Likewise.
* rs6000-nat.c (rs6000_ptrace64): Likewise.
(fetch_register): Likewise.
* rs6000-tdep.c (ppc_supply_reg): Likewise.
(ppc_collect_reg): Likewise.
(ppc_collect_gregset): Likewise.
(ppc_collect_fpregset): Likewise.
(ppc_collect_vsxregset): Likewise.
(ppc_collect_vrregset): Likewise.
(ppc_displaced_step_hw_singlestep): Likewise.
(rs6000_pseudo_register_read): Likewise.
(rs6000_pseudo_register_write): Likewise.
* s390-linux-nat.c (supply_gregset): Likewise.
(fill_gregset): Likewise.
(s390_linux_fetch_inferior_registers): Likewise.
* s390-linux-tdep.c (s390_write_pc): Likewise.
(s390_software_single_step): Likewise.
(s390_all_but_pc_registers_record): Likewise.
(s390_linux_syscall_record): Likewise.
* sentinel-frame.c (sentinel_frame_prev_arch): Likewise.
* sh-nbsd-nat.c (shnbsd_fetch_inferior_registers): Likewise.
(shnbsd_store_inferior_registers): Likewise.
* sh-tdep.c (sh_extract_return_value_nofpu): Likewise.
(sh_extract_return_value_fpu): Likewise.
(sh_store_return_value_nofpu): Likewise.
(sh_corefile_supply_regset): Likewise.
(sh_corefile_collect_regset): Likewise.
* sh64-tdep.c (sh64_extract_return_value): Likewise.
(sh64_store_return_value): Likewise.
* sparc-linux-tdep.c (sparc32_linux_collect_core_fpregset): Likewise.
* sparc-nat.c (sparc_fetch_inferior_registers): Likewise.
(sparc_store_inferior_registers): Likewise.
* sparc-ravenscar-thread.c (register_in_thread_descriptor_p): Likewise.
(sparc_ravenscar_prepare_to_store): Likewise.
* sparc-tdep.c (sparc32_store_arguments): Likewise.
(sparc_analyze_control_transfer): Likewise.
(sparc_step_trap): Likewise.
(sparc_software_single_step): Likewise.
(sparc32_gdbarch_init): Likewise.
(sparc_supply_rwindow): Likewise.
(sparc_collect_rwindow): Likewise.
* sparc64-linux-tdep.c (sparc64_linux_collect_core_fpregset): Likewise.
* sparc64-nbsd-nat.c (sparc64nbsd_supply_gregset): Likewise.
(sparc64nbsd_collect_gregset): Likewise.
(sparc64nbsd_supply_fpregset): Likewise.
(sparc64nbsd_collect_fpregset): Likewise.
* sparc64-tdep.c (sparc64_store_arguments): Likewise.
(sparc64_supply_gregset): Likewise.
(sparc64_collect_gregset): Likewise.
(sparc64_supply_fpregset): Likewise.
(sparc64_collect_fpregset): Likewise.
* spu-linux-nat.c (spu_fetch_inferior_registers): Likewise.
* spu-tdep.c (spu_unwind_sp): Likewise.
(spu2ppu_prev_register): Likewise.
(spu_memory_remove_breakpoint): Likewise.
* stack.c (return_command): Likewise.
* tic6x-tdep.c (tic6x_extract_signed_field): Likewise.
* tracefile-tfile.c (tfile_fetch_registers): Likewise.
* tracefile.c (trace_save_ctf): Likewise.
* windows-nat.c (do_windows_fetch_inferior_registers): Likewise.
(do_windows_store_inferior_registers): Likewise.
(windows_resume): Likewise.
* xtensa-linux-nat.c (fill_gregset): Likewise.
(supply_gregset_reg): Likewise.
* xtensa-tdep.c (xtensa_register_write_masked): Likewise.
(xtensa_register_read_masked): Likewise.
(xtensa_supply_gregset): Likewise.
(xtensa_extract_return_value): Likewise.
(xtensa_store_return_value): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] const-fy function parameter struct address_space *aspace
@ 2017-10-26 20:53 sergiodj+buildbot
2017-10-27 21:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-26 20:53 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT accd0bcdfe6914193bba8dec9e6311e608b5c498 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: accd0bcdfe6914193bba8dec9e6311e608b5c498
const-fy function parameter struct address_space *aspace
This patch changes the parameter "struct address_space *aspace" to "const
address_space *aspace" in many functions.
gdb:
2017-10-26 Yao Qi <yao.qi@linaro.org>
* breakpoint.c (breakpoint_location_address_match): Change
"struct address_space *" to "const address_space".
(breakpoint_location_address_range_overlap): Likewise.
(breakpoint_here_p): Likewise.
(breakpoint_in_range_p): Likewise.
(moribund_breakpoint_here_p): Likewise.
(bp_location_inserted_here_p): Likewise.
(software_breakpoint_inserted_here_p): Likewise.
(hardware_breakpoint_inserted_here_p): Likewise.
(hardware_watchpoint_inserted_in_range): Likewise.
(bpstat_check_location): Likewise.
(bpstat_stop_status): Likewise.
(breakpoint_address_match): Likewise.
(breakpoint_address_match_range): Likewise.
(breakpoint_location_address_match): Likewise.
(breakpoint_location_address_range_overlap): Likewise.
(insert_single_step_breakpoint): Likewise.
(breakpoint_has_location_inserted_here): Likewise.
(single_step_breakpoint_inserted_here_p): Likewise.
(pc_at_non_inline_function): Likewise.
* breakpoint.h (bpstat_stop_status): Update declaration.
(breakpoint_here_p): Likewise.
(breakpoint_in_range_p): Likewise.
(moribund_breakpoint_here_p): Likewise.
(breakpoint_inserted_here_p): Likewise.
(software_breakpoint_inserted_here_p): Likewise.
(hardware_breakpoint_inserted_here_p): Likewise.
(breakpoint_has_location_inserted_here): Likewise.
(single_step_breakpoint_inserted_here_p): Likewise.
(hardware_watchpoint_inserted_in_range): Likewise.
(breakpoint_address_match): Likewise.
(insert_single_step_breakpoint): Likewise.
(pc_at_non_inline_function): Likewise.
* gdbthread.h (thread_has_single_step_breakpoint_here): Likewise.
* record.c (record_check_stopped_by_breakpoint): Likewise.
* record.h (record_check_stopped_by_breakpoint): Likewise.
* thread.c (thread_has_single_step_breakpoint_here): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] const-fy breakpoint_ops->breakpoint_hit parameter aspace
@ 2017-10-26 21:14 sergiodj+buildbot
2017-10-27 22:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-26 21:14 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT bd5225139c83a80aad542e46efb66fabf51bff91 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: bd5225139c83a80aad542e46efb66fabf51bff91
const-fy breakpoint_ops->breakpoint_hit parameter aspace
gdb:
2017-10-26 Yao Qi <yao.qi@linaro.org>
* break-catch-sig.c (signal_catchpoint_breakpoint_hit): Make
aspace const.
* break-catch-syscall.c (breakpoint_hit_catch_syscall):
Likewise.
* breakpoint.c (bpstat_check_location): Remove cast.
(breakpoint_hit_catch_fork): Make aspce const.
(breakpoint_hit_catch_solib): Likewise.
(breakpoint_hit_catch_exec): Likewise.
(breakpoint_hit_ranged_breakpoint): Likewise.
(breakpoint_hit_watchpoint): Likewise.
(base_breakpoint_breakpoint_hit): Likewise.
(bkpt_breakpoint_hit): Likewise.
(dprintf_breakpoint_hit): Likewise.
(tracepoint_breakpoint_hit): Likewise.
* breakpoint.h (breakpoint_ops) <breakpoint_hit>: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] RISC-V: Fix disassembly of c.addi4spn, c.addi16sp, c.lui when imm=0
@ 2017-10-27 3:57 sergiodj+buildbot
2017-10-27 12:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-27 3:57 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 63a25ea0de6d2f6d45b26af8d9c808aa35962256 ***
Author: Andrew Waterman <andrew@sifive.com>
Branch: master
Commit: 63a25ea0de6d2f6d45b26af8d9c808aa35962256
RISC-V: Fix disassembly of c.addi4spn, c.addi16sp, c.lui when imm=0
These are all invalid instructions, so they should not disassemble.
opcodes/ChangeLog
2017-10-24 Andrew Waterman <andrew@sifive.com>
* riscv-opc.c (match_c_addi16sp) : New function.
(match_c_addi4spn): New function.
(match_c_lui): Don't allow 0-immediate encodings.
(riscv_opcodes) <addi>: Use the above functions.
<add>: Likewise.
<c.addi4spn>: Likewise.
<c.addi16sp>: Likewise.
gas/ChangeLog
2017-10-24 Andrew Waterman <andrew@sifive.com>
* testsuite/gas/riscv/c-addi16sp-fail.d: New test.
testsuite/gas/riscv/c-addi16sp-fail.l: Likewise.
testsuite/gas/riscv/c-addi16sp-fail.s: Likewise.
testsuite/gas/riscv/c-addi4spn-fail.d: Likewise.
testsuite/gas/riscv/c-addi4spn-fail.l: Likewise.
testsuite/gas/riscv/c-addi4spn-fail.s: Likewise.
testsuite/gas/riscv/riscv.exp: Add new tests.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix racy test in gdb.base/new-ui.exp
@ 2017-10-27 4:29 sergiodj+buildbot
2017-10-27 13:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-27 4:29 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 792ccf005f391f46e295e250f285d040ab105ab7 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 792ccf005f391f46e295e250f285d040ab105ab7
Fix racy test in gdb.base/new-ui.exp
I noticed gdb.base/new-ui.exp failing once here with:
FAIL: gdb.base/new-ui.exp: do_test: delete all breakpoints on extra console (got interactive prompt)
FAIL: gdb.base/new-ui.exp: do_test: main console: next causes no spurious output on other console
FAIL: gdb.base/new-ui.exp: do_test: main console: breakpoint hit reported on other console
The problem is 100% reproducible with check-read1:
$ make check-read1 TESTS="gdb.*/new-ui.exp"
testsuite/gdb.log shows:
delete
Delete all breakpoints? (y or n) [answered Y; input not from terminal]
(gdb) FAIL: gdb.base/new-ui.exp: do_test: delete all breakpoints on extra console (got interactive prompt)
This commit fixes the problem.
gdb/testsuite/ChangeLog:
2017-10-24 Pedro Alves <palves@redhat.com>
* gdb.base/new-ui.exp (do_test): Split "delete all breakpoints on
extra console" test in two stages.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove regular_breakpoint_inserted_here_p declaration
@ 2017-10-27 13:22 sergiodj+buildbot
2017-10-27 23:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-27 13:22 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 6abc18bbbf03dc4aee0b0f2cd851d9bc9a983e20 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 6abc18bbbf03dc4aee0b0f2cd851d9bc9a983e20
Remove regular_breakpoint_inserted_here_p declaration
There is no regular_breakpoint_inserted_here_p definition at all, so
this patch removes the declaration.
gdb:
2017-10-26 Yao Qi <yao.qi@linaro.org>
* breakpoint.h (regular_breakpoint_inserted_here_p): Remove.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add common AARCH64 REGNUM defines
@ 2017-10-27 15:45 sergiodj+buildbot
2017-10-27 16:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-27 15:45 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT cc628f3dbb12c720dbc9ab714feeb197dc739944 ***
Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: cc628f3dbb12c720dbc9ab714feeb197dc739944
Add common AARCH64 REGNUM defines
gdb/
* aarch64-tdep.h (enum aarch64_regnum): Remove.
* arch/aarch64.h: New file.
gdbserver/
* linux-aarch64-low.c (aarch64_fill_gregset): Replace defines
with REGNO.
(aarch64_store_gregset): Likewise.
(aarch64_fill_fpregset): Likewise.
(aarch64_store_fpregset): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Get rid of VEC(filename_language)
@ 2017-10-28 3:31 sergiodj+buildbot
2017-10-28 10:02 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-28 3:31 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 593e3209f3e4e525030bc8768850f3876fd0b850 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 593e3209f3e4e525030bc8768850f3876fd0b850
Get rid of VEC(filename_language)
This patch removes VEC(filename_language), replacing its usage with
std::vector. filename_language::ext is changed to an std::string at the
same time.
Regtested on the buildbot.
gdb/ChangeLog:
* symfile.c (filename_language): Make struct, not typedef. Add
constructor.
<ext>: Change type to std::string.
(DEF_VEC_O (filename_language)): Remove.
(filename_language_table): Change type to std::vector.
(add_filename_language): Adjust.
(set_ext_lang_command): Adjust.
(info_ext_lang_command): Adjust.
(deduce_language_from_filename): Adjust.
(class scoped_restore_filename_language_table): Remove.
(test_filename_language): Use scoped_restore.
(test_set_ext_lang_command): Use scoped_restore, adjust to
std::vector change.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Get rid of VEC(loaded_script_ptr)
@ 2017-10-28 5:03 sergiodj+buildbot
2017-10-28 12:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-28 5:03 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 6a1b9516d824a4d364040887455ba910f955f065 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 6a1b9516d824a4d364040887455ba910f955f065
Get rid of VEC(loaded_script_ptr)
Direct replacement with std::vector. This allows removing a cleanup as
well.
Regtested on the buildbot.
gdb/ChangeLog:
* auto-load.c: Don't include gdb_vecs.h, include algorithm.
(loaded_script_ptr): Remove typedef.
(DEF_VEC_P (loaded_script_ptr)): Remove.
(struct collect_matching_scripts_data): Add constructor.
<scripts_p>: Change type to (pointer to) std::vector.
(collect_matching_scripts_data): Adjust.
(sort_scripts_by_name): Make suitable for std::sort.
(print_scripts): Don't sort vector, adjust to std::vector.
(auto_load_info_scripts): Sort vectors, adjust to std::vector.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Allocate breakpoint_objfile_data with new
@ 2017-10-28 5:38 sergiodj+buildbot
2017-10-28 13:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-28 5:38 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 43dce4394513d15ba8122c3bf442ec1028d93feb ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 43dce4394513d15ba8122c3bf442ec1028d93feb
Allocate breakpoint_objfile_data with new
Allocate with new and free with delete. This allows using an
std::vector in the following patch.
I renamed free_breakpoint_probes to free_breakpoint_objfile_data,
because it now doesn't only free the probes vector, but also the
breakpoint_objfile_data structure itself.
gdb/ChangeLog:
* breakpoint.c (breakpoint_objfile_data): Initialize fields.
(get_breakpoint_objfile_data): Allocate breakpoint_objfile_data
with new.
(free_breakpoint_probes): Rename to ...
(free_breakpoint_objfile_data): ... this, and call delete on
bp_objfile_data..
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove find_inferior usage for thread_search
@ 2017-10-28 6:56 sergiodj+buildbot
2017-10-28 21:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-28 6:56 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT bac608e7e11fa83a648c0980883f810ebd1874b1 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: bac608e7e11fa83a648c0980883f810ebd1874b1
Remove find_inferior usage for thread_search
Replace it with for_each_thread. While at it, we can inline the
callback code. One little change is that I am using the
prev_general_thread variable instead of current_gen_ptid, since they
should have the same value.
gdb/gdbserver/ChangeLog:
* target.c (struct thread_search): Remove.
(thread_search_callback): Remove.
(prepare_to_access_memory): Use for_each_thread instead of
find_inferior. Inline code from thread_search_callback.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] C++ify xml-syscall.c
@ 2017-10-28 8:07 sergiodj+buildbot
2017-10-28 16:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-28 8:07 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 5a9dcda14c240eccee5c1de53cf4ae936230ed0c ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 5a9dcda14c240eccee5c1de53cf4ae936230ed0c
C++ify xml-syscall.c
This patch C++ifies the structures in xml-syscall.c, by using
std::vector instead of VEC, and std::string instead of char*.
Using a unique_ptr in syscall_parse_xml allows to remove a cleanup.
Something that seems strange with the existing code, if you look at
syscalls_info_free_syscalls_desc and
syscalls_info_free_syscall_group_desc, they free the structure elements
(the strings and vectors), but they don't free the syscall_desc and
syscall_group_desc structure themselves. I don't see anything freeing
those currently. Any idea why? According to the comment above
syscalls_info_free_syscall_group_desc, it kinda looks like it's on
purpose. With this patch, those structures are deleted when the vector
that contains them gets deleted.
The only time I'm aware a syscalls_info structure gets deleted is in the
case the data directory changes during runtime, in init_syscalls_info.
If tried that use case (including under valgrind):
(gdb) catch syscall
(gdb) set data-directory another-data-directory
(gdb) catch syscall
I confirmed that the syscalls_info structure got deleted and recreated,
and everything seemed fine.
Regtested on the buildbot.
gdb/ChangeLog:
* xml-syscall.c (struct syscall_desc): Add constructor.
<name>: Change type to std::string.
(syscall_desc_up): New typedef.
(syscall_desc_p): Remove typeder.
(DEF_VEC_P(syscall_desc_p)): Remove.
(struct syscall_group_desc): Add constructor.
<name>: Change type to std::string.
<syscalls>: Change type to std::vector.
(syscall_group_desc_up): New typedef.
(syscall_group_desc_p): Remove typedef.
(DEF_VEC_P(syscall_group_desc_p)): Remove.
(struct syscalls_info) <syscalls>: Change type to std::vector of
unique_ptr.
<groups>: Likewise.
<my_gdb_datadir>: Change type to std::string.
(syscalls_info_up): New typedef.
(allocate_syscalls_info): Remove.
(syscalls_info_free_syscalls_desc): Remove.
(syscalls_info_free_syscall_group_desc): Remove.
(free_syscalls_info): Remove.
(make_cleanup_free_syscalls_info): Remove.
(syscall_group_create_syscall_group_desc): Adjust.
(syscall_group_add_syscall): Adjust.
(syscall_create_syscall_desc): Adjust.
(syscall_parse_xml): Adjust, use unique_ptr instead of cleanup.
(init_syscalls_info): Adjust.
(syscall_group_get_group_by_name): Adjust.
(xml_get_syscall_number): Adjust.
(xml_get_syscall_name): Adjust.
(xml_list_of_syscalls): Adjust.
(xml_list_syscalls_by_group): Adjust.
(xml_list_of_groups): Adjust.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] common-utils-selftests.c: Add ATTRIBUTE_PRINTF
@ 2017-10-28 8:39 sergiodj+buildbot
2017-10-28 17:59 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-28 8:39 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b5540b5f2b9cd5fcbac6504359b856d3f43267b5 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: b5540b5f2b9cd5fcbac6504359b856d3f43267b5
common-utils-selftests.c: Add ATTRIBUTE_PRINTF
Fix this, when building with clang:
/home/emaisin/src/binutils-gdb/gdb/unittests/common-utils-selftests.c:50:40: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
std::string result = string_vprintf (fmt, vp);
^~~
gdb/ChangeLog:
* unittests/common-utils-selftests.c (format): Add
ATTRIBUTE_PRINTF.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR22300, Abort in elf32_hppa_relocate_section building polyml
@ 2017-10-28 12:08 sergiodj+buildbot
2017-10-28 22:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-28 12:08 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c0e331c794d6bd75d9be9bea6145513074c33f39 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: c0e331c794d6bd75d9be9bea6145513074c33f39
PR22300, Abort in elf32_hppa_relocate_section building polyml
polyml produces object files with the wrong OS/ABI for hppa-linux.
This, along with the fact that elf32-hppa.c is using the strictest
backend relocs_compatible, results in wrong merging of ELF symbols.
So, remove the relocs_compatible check in _bfd_elf_merge_symbol.
_bfd_elf_merge_symbol is only called nowadays from within blocks
protected by is_elf_hash_table, so "we are doing an ELF link" as the
removed comment says, is true.
Also relax relocs_compatible for hppa and powerpc. relocs_compatible
is used for more than just merging symbols, as the name suggests.
This allows objects that are in fact reasonably compatible to be
linked.
PR 22300
* elflink.c (_bfd_elf_merge_symbol): Remove relocs_compatible check.
* elf32-hppa.c (elf_backend_relocs_compatible): Define.
* elf32-ppc.c (elf_backend_relocs_compatible): Define.
* elf64-ppc.c (elf_backend_relocs_compatible): Define.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] xtensa-xtregs: Fix formatting issues
@ 2017-10-29 17:24 sergiodj+buildbot
2017-10-29 18:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-29 17:24 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 7ca51576b94fb59a41050957d5ee822d21711abc ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 7ca51576b94fb59a41050957d5ee822d21711abc
xtensa-xtregs: Fix formatting issues
Fix a few formatting issues in that file.
gdb/ChangeLog:
* xtensa-xtregs.c: Fix formatting issues.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] relocs_compatible test for gc-sections
@ 2017-10-30 2:05 sergiodj+buildbot
2017-10-30 3:42 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-30 2:05 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 81742b83e9f25895eaaf3a07ac1651a4e9a68251 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 81742b83e9f25895eaaf3a07ac1651a4e9a68251
relocs_compatible test for gc-sections
I noticed when looking at pr22300 that before calling check_relocs we
have an elf_object_id test (added for pr11933) as well as the
relocs_compatible test. I believe backend gc_mark_hook and
gc_sweep_hook ought to be protected similarly from being confused by
unexpected relocations (for example, both elf64-ppc.c and elf32-ppc.c
use _bfd_elf_relocs_compatible, so I think it would be possible for
the ppc64 gc_mark_hook to be presented with a ppc32 relocatable
object).
* elflink.c (elf_gc_sweep): Test elf_object_id in addition to
relocs_compatible.
(bfd_elf_gc_sections): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] frv-elf --gc-sections failures
@ 2017-10-30 2:25 sergiodj+buildbot
2017-10-30 4:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-30 2:25 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 7f9cb5d275e71a75e97230241ec7da6718a7a0f5 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 7f9cb5d275e71a75e97230241ec7da6718a7a0f5
frv-elf --gc-sections failures
git commit 81742b83e9 exposed an frv-elf bug, with the object id not
matching the hash table id.
* elf32-frv.c (ELF_TARGET_ID): Don't define for generic
elf target.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] darwin-nat: Remove gdb.h include
@ 2017-10-30 3:36 sergiodj+buildbot
2017-10-30 6:08 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-30 3:36 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 16c5c17e43b34c6cc5337b40e927bc2d05c38300 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 16c5c17e43b34c6cc5337b40e927bc2d05c38300
darwin-nat: Remove gdb.h include
gdb.h has been removed in
Eliminate catch_exceptions/catch_exceptions_with_msg
65630365f7d073430e62b4fe65f34dcdc0a4b05e
Remove the include in darwin-nat.c. Tested by rebuilding.
gdb/ChangeLog:
* darwin-nat.c: Remove include of gdb.h.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] remote.c, QCatchSyscalls: Build std::string instead of unique_xmalloc_ptr
@ 2017-10-30 13:20 sergiodj+buildbot
2017-10-30 15:38 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-30 13:20 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 1b81856f5b00e7ba860e4de2f3a426f342327165 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 1b81856f5b00e7ba860e4de2f3a426f342327165
remote.c, QCatchSyscalls: Build std::string instead of unique_xmalloc_ptr
Simplify the code a little bit using std::string + string_appendf.
gdb/ChangeLog:
2017-10-30 Pedro Alves <palves@redhat.com>
Simon Marchi <simon.marchi@ericsson.com>
* remote.c (remote_set_syscall_catchpoint): Build a std::string
instead of a gdb::unique_xmalloc_ptr, using string_appendf.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb/Makefile.in: fix 'make tags' failure
@ 2017-10-31 1:56 sergiodj+buildbot
2017-10-31 3:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-31 1:56 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f871c4853a9725682011c2314ea4308f3c34bd8d ***
Author: Mike Gulick <mike.gulick@mathworks.com>
Branch: master
Commit: f871c4853a9725682011c2314ea4308f3c34bd8d
gdb/Makefile.in: fix 'make tags' failure
'make tags' fails with the following error:
make[2]: Entering directory '/local-ssd/mgulick/gdb/git/binutils-gdb/gdb'
make[2]: *** No rule to make target 'gdb.h', needed by 'TAGS'. Stop.
make[2]: Leaving directory '/local-ssd/mgulick/gdb/git/binutils-gdb/gdb'
The file gdb/gdb.h was removed in commit
65630365f7d073430e62b4fe65f34dcdc0a4b05e.
gdb/ChangeLog:
2017-10-30 Mike Gulick <mgulick@mathworks.com>
* Makefile.in (HFILES_NO_SRCDIR): Remove reference to gdb.h.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix illegal memory access triggered when parsing a PE binary with a corrupt data dictionary.
@ 2017-10-31 14:53 sergiodj+buildbot
2017-10-31 15:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-31 14:53 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 0bb6961f18b8e832d88b490d421ca56cea16c45b ***
Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 0bb6961f18b8e832d88b490d421ca56cea16c45b
Fix illegal memory access triggered when parsing a PE binary with a corrupt data dictionary.
PR 22373
* peicode.h (pe_bfd_read_buildid): Check for invalid size and data
offset values.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] tracepoint: Remove unnecessary const_cast
@ 2017-10-31 19:14 sergiodj+buildbot
2017-10-31 19:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-10-31 19:14 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 09b847f3a85ca29ec20ada375fe67843755b6413 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 09b847f3a85ca29ec20ada375fe67843755b6413
tracepoint: Remove unnecessary const_cast
We are passing a const char * to a const char * parameter, the
const_cast is not necessary.
gdb/ChangeLog:
* tracepoint.c (tfind_command): Remove const_cast.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Use console uiout when executing breakpoint commands
@ 2017-11-01 1:59 sergiodj+buildbot
2017-11-01 2:59 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-01 1:59 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 3a87ae656c283e4f46ddf7d92c06ecb8992c2bf6 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 3a87ae656c283e4f46ddf7d92c06ecb8992c2bf6
Use console uiout when executing breakpoint commands
As reported here
https://sourceware.org/ml/gdb/2017-10/msg00020.html
the output of certain commands, like backtrace, doesn't appear anywhere
when it is run as a breakpoint command and when using MI.
The reason is that the current_uiout is set to the mi_ui_out while these
commands run, whereas we want the output as CLI output. Some commands
like "print" work, because they use printf_filtered (gdb_stdout, ...)
directly, bypassing the current ui_out.
The fix I did is to force setting the cli_uiout as the current_uiout
when calling execute_control_command. I am not sure if this is the
right way to fix the problem, comments about the approach would be
appreciated.
I enhanced gdb.mi/mi-break.exp to test the backtrace command.
Regtested on the buildbot.
gdb/ChangeLog:
* cli/cli-script.c (execute_control_command): Rename to ...
(execute_control_command_1): ... this.
(execute_control_command): New function.
gdb/testsuite/ChangeLog:
* gdb.mi/mi-break.exp (test_breakpoint_commands): Test backtrace
as a breakpoint command.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR22374, PowerPC unnecessary PLT entries
@ 2017-11-01 8:21 sergiodj+buildbot
2017-11-01 10:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-01 8:21 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 3988aed54acce3c682a877b51b0e09cce1079e81 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 3988aed54acce3c682a877b51b0e09cce1079e81
PR22374, PowerPC unnecessary PLT entries
We don't need a PLT entry when function pointer initialization in a
read/write section is the only reference to a given function symbol.
This patch prevents the unnecessary PLT entry, and ensures no dynamic
relocs are emitted when UNDEFWEAK_NO_DYNAMIC_RELOC says so.
bfd/
PR 22374
* elf32-ppc.c (ppc_elf_adjust_dynamic_symbol): Don't create a plt
entry when just a dynamic reloc can serve. Ensure no dynamic
relocations when UNDEFWEAK_NO_DYNAMIC_RELOC by setting non_got_ref.
Expand and move the non_got_ref comment.
* elf64-ppc.c (ppc64_elf_adjust_dynamic_symbol): Likewise.
ld/
* testsuite/ld-powerpc/ambiguousv2.d: Remove FIXME.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix an invalid free called when attempting to link a COFF object against an ELF archive with --no-keep-memory enabled.
@ 2017-11-01 11:58 sergiodj+buildbot
2017-11-01 12:51 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-01 11:58 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ee357486aa87b17782111295c5e7bd4ac9e6970f ***
Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: ee357486aa87b17782111295c5e7bd4ac9e6970f
Fix an invalid free called when attempting to link a COFF object against an ELF archive with --no-keep-memory enabled.
PR 22369
* coffgen.c (_bfd_coff_free_symbols): Fail if called on a non-COFF
file.
* cofflink.c (coff_link_check_archive_element): Skip non-COFF
members of an archive.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove code wrapped by "#if 0"
@ 2017-11-02 15:52 sergiodj+buildbot
2017-11-02 17:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-02 15:52 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2e1b49b32ab9aec1aca94f424cbe275e5f6f9ab4 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 2e1b49b32ab9aec1aca94f424cbe275e5f6f9ab4
Remove code wrapped by "#if 0"
These code wrapped by "#if 0" was added by af030b9a, which added the new
command to dump registers in 2002. The email didn't mention this either
https://sourceware.org/ml/gdb-patches/2002-08/msg00227.html It was there
for 15 years, and nobody needs it, so we can remove it.
gdb:
2017-11-02 Yao Qi <yao.qi@linaro.org>
* regcache.c (regcache::dump): Remove code.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] New method regcache::assert_regnum
@ 2017-11-02 16:13 sergiodj+buildbot
2017-11-02 18:59 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-02 16:13 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 4e888c281cd19f019248bd165d7055af88641c80 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 4e888c281cd19f019248bd165d7055af88641c80
New method regcache::assert_regnum
class regcache has some methods checking the range of register number,
this patch is to move it in a new method assert_regnum.
gdb:
2017-11-02 Yao Qi <yao.qi@linaro.org>
* regcache.c (regcache::assert_regnum): New method.
(regcache::invalidate): Call assert_regnum.
(regcache::raw_update): Likewise.
(regcache::raw_write): Likewise.
(regcache::raw_read_part): Likewise.
(regcache::raw_write_part): Likewise.
(regcache::raw_supply): Likewise.
(regcache::raw_supply_integer): Likewise.
(regcache::raw_supply_zeroed): Likewise.
(regcache::raw_collect): Likewise.
(regcache::raw_collect_integer): Likewise.
* regcache.h (regcache::assert_regnum): Declare.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] const-fy regcache::m_readonly_p
@ 2017-11-02 19:26 sergiodj+buildbot
2017-11-02 23:55 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-02 19:26 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 6c6e9412e930c96f48b8ee78a389437328f5283c ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 6c6e9412e930c96f48b8ee78a389437328f5283c
const-fy regcache::m_readonly_p
gdb:
2017-11-02 Yao Qi <yao.qi@linaro.org>
* regcache.h (regcache) <m_readonly_p>: Change it to const bool.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Skip gdb.python/py-thrhandle.exp if python is not enabled.
@ 2017-11-03 11:02 sergiodj+buildbot
2017-11-03 12:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-03 11:02 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 8e68731c8a4aecb3481803e91b9bcd2df182c135 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 8e68731c8a4aecb3481803e91b9bcd2df182c135
Skip gdb.python/py-thrhandle.exp if python is not enabled.
gdb/testsuite:
2017-11-03 Yao Qi <yao.qi@linaro.org>
* gdb.python/py-thrhandle.exp: Skip it if python is not
enabled.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] [ARC] Force the disassam to use the hexadecimal number for printing
@ 2017-11-03 15:03 sergiodj+buildbot
2017-11-03 16:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-03 15:03 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT fdddd2900f39584e7d6cee27127593fba2cb0cf2 ***
Author: claziss <claziss@synopsys.com>
Branch: master
Commit: fdddd2900f39584e7d6cee27127593fba2cb0cf2
[ARC] Force the disassam to use the hexadecimal number for printing
Force printing of the short/signed values using hexadecimal
representation via disassembler option.
opcode/
2017-11-03 Claudiu Zissulescu <claziss@synopsys.com>
* arc-dis.c (print_hex): New variable.
(parse_option): Check for hex option.
(print_insn_arc): Use hexadecimal representation for short
immediate values when requested.
(print_arc_disassembler_options): Add hex option to the list.
binutils/
2017-11-03 Claudiu Zissulescu <claziss@synopsys.com>
* doc/binutils.texi (ARC): Update disassembler options.
* testsuite/binutils-all/arc/hexprint.s: New file.
* testsuite/binutils-all/arc/objdump.exp: Test hex printing feature.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: Remove func_pointer_refcount
@ 2017-11-03 18:40 sergiodj+buildbot
2017-11-03 20:42 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-03 18:40 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 79b0c981b8f0c912208ec305d48e775bcb6d2624 ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 79b0c981b8f0c912208ec305d48e775bcb6d2624
x86: Remove func_pointer_refcount
Since check_reloc is running after gc_sections, there is no need for
reference count. If a function pointer relocation can be resolved at
run-time, there is no need for PLT and it doesn't count as non-GOT/PLT
relocation. func_pointer_refcount can be removed.
* elf32-i386.c (elf_i386_check_relocs): Set plt.refcount to 1.
Don't use func_pointer_refcount. Don't set plt.refcount nor
non_got_ref for function pointer reference.
* elf64-x86-64.c (elf_x86_64_check_relocs): Likewise.
* elfxx-x86.c (elf_x86_allocate_dynrelocs): Don't use
func_pointer_refcount.
(_bfd_x86_elf_copy_indirect_symbol): Don't copy
func_pointer_refcount.
(_bfd_x86_elf_hide_symbol): Don't use func_pointer_refcount.
* elfxx-x86.h (GENERATE_DYNAMIC_RELOCATION_P): Likewise.
(elf_x86_link_hash_entry): Remove func_pointer_refcount.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove cleanups from link_callbacks_einfo
@ 2017-11-04 17:45 sergiodj+buildbot
2017-11-04 19:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-04 17:45 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 20dcd8cae7d87910f6c3936bad72e78b647a8de6 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 20dcd8cae7d87910f6c3936bad72e78b647a8de6
Remove cleanups from link_callbacks_einfo
This removes a cleanup from link_callbacks_einfo by using std::string.
gdb/ChangeLog
2017-11-04 Tom Tromey <tom@tromey.com>
* compile/compile-object-load.c (link_callbacks_einfo): Use
std::string.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Use std::vector in compile-loc2c.c
@ 2017-11-04 18:06 sergiodj+buildbot
2017-11-04 20:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-04 18:06 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c6bcad5ffc9b4021253487e46a8754e5804135cf ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: c6bcad5ffc9b4021253487e46a8754e5804135cf
Use std::vector in compile-loc2c.c
This changes compile-loc2c.c to use std::vector, removing some
cleanups.
gdb/ChangeLog
2017-11-04 Tom Tromey <tom@tromey.com>
* compile/compile-loc2c.c (compute_stack_depth_worker): Change
type of "info".
(compute_stack_depth): Likewise.
(do_compile_dwarf_expr_to_c): Use std::vector.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Use unique_xmalloc_ptr in find_separate_debug_file_by_debuglink
@ 2017-11-04 18:59 sergiodj+buildbot
2017-11-04 22:00 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-04 18:59 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 5eae7aeaf754549d3645a0c590c5ef9f0134a32d ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 5eae7aeaf754549d3645a0c590c5ef9f0134a32d
Use unique_xmalloc_ptr in find_separate_debug_file_by_debuglink
This changes find_separate_debug_file_by_debuglink to use
unique_xmalloc_ptr, removing some cleanups.
gdb/ChangeLog
2017-11-04 Tom Tromey <tom@tromey.com>
* symfile.c (find_separate_debug_file_by_debuglink): Use
unique_xmalloc_ptr.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove directive-searched cleanups
@ 2017-11-04 19:51 sergiodj+buildbot
2017-11-04 23:32 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-04 19:51 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 167b0be1b5ef36a5605fcdfba0c84db2ed475e1e ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 167b0be1b5ef36a5605fcdfba0c84db2ed475e1e
Remove directive-searched cleanups
This removes a few cleanups related to the "searched" field in
struct using_direct, replacing these with scoped_restore.
gdb/ChangeLog
2017-11-04 Tom Tromey <tom@tromey.com>
* cp-namespace.c (reset_directive_searched): Remove.
(cp_lookup_symbol_via_imports): Use scoped_restore.
* cp-support.c (reset_directive_searched): Remove.
(make_symbol_overload_list_using): Use scoped_restore.
* d-namespace.c (d_lookup_symbol_imports): Use scoped_restore.
(reset_directive_searched): Remove.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Replace start_rbreak_breakpoints and end_rbreak_breakpoints
@ 2017-11-04 20:14 sergiodj+buildbot
2017-11-05 0:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-04 20:14 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c80049d3b615691dc902762d5d97551aa9664442 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: c80049d3b615691dc902762d5d97551aa9664442
Replace start_rbreak_breakpoints and end_rbreak_breakpoints
This replaces start_rbreak_breakpoints and end_rbreak_breakpoints with
a new scoped class. This allows the removal of a cleanup.
This also fixes an earlier memory leak regression, by changing
"string" to be a std::string.
gdb/ChangeLog
2017-11-04 Tom Tromey <tom@tromey.com>
* breakpoint.c
(scoped_rbreak_breakpoints::scoped_rbreak_breakpoints): Rename
from start_rbreak_breakpoints.
(scoped_rbreak_breakpoints): Rename from end_rbreak_breakpoints.
* breakpoint.h (class scoped_rbreak_breakpoints): New.
(start_rbreak_breakpoints, end_rbreak_breakpoints): Remove.
* symtab.c (do_end_rbreak_breakpoints): Remove.
(rbreak_command): Use scoped_rbreak_breakpoints, std::string.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove make_cleanup_free_objfile
@ 2017-11-04 20:56 sergiodj+buildbot
2017-11-05 3:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-04 20:56 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ed2b3126d1828d55d57880c6b6045a4e58c05cde ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: ed2b3126d1828d55d57880c6b6045a4e58c05cde
Remove make_cleanup_free_objfile
This replaces make_cleanup_free_objfile with std::unique_ptr.
gdb/ChangeLog
2017-11-04 Tom Tromey <tom@tromey.com>
* objfiles.c (do_free_objfile_cleanup): Remove.
* compile/compile-object-load.c (compile_object_load): Update.
* objfiles.h (make_cleanup_free_objfile): Remove.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove cleanups from linux-tdep.c
@ 2017-11-04 23:25 sergiodj+buildbot
2017-11-05 5:59 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-04 23:25 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9f584b37e36b67009fa23b6cffbec1bf691ef9ba ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 9f584b37e36b67009fa23b6cffbec1bf691ef9ba
Remove cleanups from linux-tdep.c
This removes some cleanups from linux-tdep.c, replacing them with
def_vector or byte_vector as appropriate.
gdb/ChangeLog
2017-11-04 Tom Tromey <tom@tromey.com>
* linux-tdep.c (linux_core_info_proc_mappings): Use
gdb::def_vector.
(linux_get_siginfo_data): Return gdb::byte_vector. Remove
"size" argument.
(linux_corefile_thread): Update.
(linux_make_corefile_notes): Remove unused variable.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Use unique_xmalloc_ptr in c_type_print_base
@ 2017-11-04 23:46 sergiodj+buildbot
2017-11-05 7:13 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-04 23:46 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 331b71e5ee226cb5455969899274f0e43e83aa1e ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 331b71e5ee226cb5455969899274f0e43e83aa1e
Use unique_xmalloc_ptr in c_type_print_base
This changes c_type_print_base to use unique_xmalloc_ptr, removing a
cleanup.
gdb/ChangeLog
2017-11-04 Tom Tromey <tom@tromey.com>
* c-typeprint.c (c_type_print_base): Use gdb::unique_xmalloc_ptr.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR22394, hppa-linux-ld fails to emit dynamic relocations
@ 2017-11-05 0:50 sergiodj+buildbot
2017-11-05 12:06 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-05 0:50 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 127e8e9f62ed0e7145dfa1172c6253275fc150dd ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 127e8e9f62ed0e7145dfa1172c6253275fc150dd
PR22394, hppa-linux-ld fails to emit dynamic relocations
gcc -mfast-indirect-calls emits a function pointer initialization
without a P% (plabel) modifier. ld does not create the necessary
dynamic relocations for this to work. It turns out that the problem
is caused by the non_got_ref symbol flag. This flag is set for
non-pic by check_relocs to indicate that the symbol might need copy
relocations or dynamic relocations. Later, the backend
adjust_dynamic_symbol clears the flag to indicate dynamic relocations
are needed, but leaves it set when copy relocations were created. The
inversion in meaning is insane, but it's that way because the backend
adjust_dynamic_symbol function doesn't get to look at all symbols..
Anyway, the insanity works for non-function symbols. However, the
flag is left set on any function symbol with a dynamic relocation.
This patch fixes the non_got_ref handling for function symbols, adds
-z nocopyreloc for hppa-elf, reports where textrel occurs, and expands
comments. The check_relocs change just stops creation of dyn_relocs
we always threw away later.
PR 22394
* elf32-hppa.c (elf32_hppa_check_relocs): Don't create dyn_relocs
for plabels when non-pic.
(maybe_set_textrel): New function.
(readonly_dynrelocs): Move and rewrite.
(elf32_hppa_adjust_dynamic_symbol): Use it. Don't create copy
relocs when def_regular or -z nocopyreloc. Handle non_got_ref
for functions. Expand non_got_ref comments.
(elf32_hppa_size_dynamic_sections): Use maybe_set_textrel.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Introduce gdb_breakpoint_up
@ 2017-11-05 3:51 sergiodj+buildbot
2017-11-05 9:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-05 3:51 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 454dafbdf2d1293a9b18a6fe9e9c9e0911eb740c ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 454dafbdf2d1293a9b18a6fe9e9c9e0911eb740c
Introduce gdb_breakpoint_up
This introduces gdb_breakpoint_up, a unique_ptr typedef that owns a
breakpoint. It then changes set_momentary_breakpoint to return a
gdb_breakpoint_up and fixes up the fallout. This then allows the
removal of make_cleanup_delete_breakpoint.
Once breakpoints are fully C++-ified, this typedef can be removed in
favor of a plain std::unique_ptr.
gdb/ChangeLog
2017-11-04 Tom Tromey <tom@tromey.com>
* breakpoint.c (set_momentary_breakpoint): Return
breakpoint_up.
(until_break_command): Update.
(new_until_break_fsm): Change argument types to
breakpoint_up.
(set_momentary_breakpoint_at_pc): Return breakpoint_up.
(do_delete_breakpoint_cleanup, make_cleanup_delete_breakpoint):
Remove.
* infcmd.c (finish_forward): Update.
* breakpoint.h (set_momentary_breakpoint)
(set_momentary_breakpoint_at_pc): Return breakpoint_up.
(make_cleanup_delete_breakpoint): Remove.
(struct breakpoint_deleter): New.
(breakpoint_up): New typedef.
* infrun.c (insert_step_resume_breakpoint_at_sal_1): Update.
(insert_exception_resume_breakpoint): Update.
(insert_exception_resume_from_probe): Update.
(insert_longjmp_resume_breakpoint): Update.
* arm-linux-tdep.c (arm_linux_copy_svc): Update.
* elfread.c (elf_gnu_ifunc_resolver_stop): Update.
* infcall.c (call_function_by_hand_dummy): Update
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] powerpc TLS in PIEs
@ 2017-11-05 7:46 sergiodj+buildbot
2017-11-05 15:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-05 7:46 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f15d0b545b9e9dada8d1398163693f67792e9e79 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: f15d0b545b9e9dada8d1398163693f67792e9e79
powerpc TLS in PIEs
This patch removes unnecessary GOT IE TLS relocations in PIEs. Useful
with --no-tls-optimize, or with an enormous TLS segment. With the
default --tls-optimize in effect IE code sequences will be edited to
LE under the same circumstances we can remove the GOT reloc.
* elf32-ppc.c (got_entries_needed, got_relocs_needed): New functions.
(allocate_dynrelocs, ppc_elf_size_dynamic_sections): Use them here.
(ppc_elf_relocate_section): Don't output a dynamic relocation
for IE GOT entries in an executable.
* elf64-ppc.c (allocate_got): Trim unnecessary TPREL relocs.
(ppc64_elf_size_dynamic_sections): Likewise.
(ppc64_elf_relocate_section): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Target FP: Add string routines to target-float.{c,h}
@ 2017-11-06 15:56 sergiodj+buildbot
2017-11-06 17:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-06 15:56 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f69fdf9bca80ac703890a51e124e408cbccbb743 ***
Author: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Branch: master
Commit: f69fdf9bca80ac703890a51e124e408cbccbb743
Target FP: Add string routines to target-float.{c,h}
This adds target_float_to_string and target_float_from_string,
which dispatch to the corresponding floatformat_ or decimal_ routines.
Existing users of those routines are changed to use the new
target-float routines instead (most of those places already handle
both binary and decimal FP).
In addition, two other places are changes to use target_float_from_string:
- define_symbol in stabsread.c, when parsing a floating-point literal
from stabs debug info
- gdbarch-selftest.c when initializing a target format values (to
eliminate use of DOUBLEST there).
gdb/ChangeLog:
2017-11-06 Ulrich Weigand <uweigand@de.ibm.com>
* target-float.c (target_float_to_string): New function.
(target_float_from_string): New function.
* target-float.h (target_float_to_string): Add prototype.
(target_float_from_string): Add prototype.
* valprint.c: Include "target-float.h". Do not include
"doublest.h" and "dfp.h".
(print_floating): Use target_float_to_string.
* printcmd.c: Include "target-float.h". Do not include "dfp.h".
(printf_floating): Use target_float_to_string.
* i387-tdep.c: Include "target-float.h". Do not include "doublest.h".
(print_i387_value): Use target_float_to_string.
* mips-tdep.c: Include "target-float.h".
(mips_print_fp_register): Use target_float_to_string.
* sh64-tdep.c: Include "target-float.h".
(sh64_do_fp_register): Use target_float_to_string.
* parse.c: Include "target-float.h". Do not include
"doublest.h" and "dfp.h".
(parse_float): Use target_float_from_string.
* stabsread.c: Include "target-float.h". Do not include "doublest.h".
(define_symbol): Use target_float_from_string.
* gdbarch-selftests.c: Include "target-float.h".
(register_to_value_test): Use target_float_from_string.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Target FP: Add conversion routines to target-float.{c, h}
@ 2017-11-06 16:44 sergiodj+buildbot
2017-11-06 18:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-06 16:44 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 50637b26f85dc3e59b616f1b01ca8885cf98f0b4 ***
Author: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Branch: master
Commit: 50637b26f85dc3e59b616f1b01ca8885cf98f0b4
Target FP: Add conversion routines to target-float.{c,h}
This patch adds the following conversion routines:
- target_float_to_longest
- target_float_from_longest
- target_float_from_ulongest
- target_float_convert
which call the equivalent decimal_ routines to handle decimal FP,
and call helper routines that currently still go via DOUBLEST to
handle binary FP.
The target_float_convert routine not only handles BFP<->BFP and
DFP<->DFP conversions, but also BFP<->DFP, which are implemented
by converting to a string and back.
These helpers are used in particular to implement conversion
from and to FP in value_cast, without going through DOUBLEST there.
In order to implement this for the FP<-integer case, the
pack_long / pack_unsigned_long routines are extended to support
floating-point values as output (thereby allowing use of
value_from_[u]longest with a floating-point target type).
This latter change also allows simplification of value_one.
gdb/ChangeLog:
2017-11-06 Ulrich Weigand <uweigand@de.ibm.com>
* target-float.c (floatformat_to_longest): New function.
(floatformat_from_longest, floatformat_from_ulongest): Likewise.
(floatformat_convert): Likewise.
(target_float_to_longest): Likewise.
(target_float_from_longest, target_float_from_ulongest): Likewise.
(target_float_convert): Likewise.
* target-float.h (target_float_to_longest): Add prototype.
(target_float_from_longest, target_float_from_ulongest): Likewise.
(target_float_convert): Likewise.
* value.c (unpack_long): Use target_float_to_longest.
(pack_long): Allow FP types. Use target_float_from_longest.
(pack_unsigned_long): Likewise using target_float_from_ulongest.
* valops.c: Include "target-float.h". Do not include "dfp.h".
(value_cast): Handle conversions to FP using target_float_convert,
value_from_ulongest, and value_from_longest.
(value_one): Use value_from_longest for FP types as well.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Target FP: Add binop and compare routines to target-float.{c, h}
@ 2017-11-06 17:27 sergiodj+buildbot
2017-11-06 20:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-06 17:27 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 66c02b9ed1eabf1d7981c0c27ec9fd3c17fc5d35 ***
Author: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Branch: master
Commit: 66c02b9ed1eabf1d7981c0c27ec9fd3c17fc5d35
Target FP: Add binop and compare routines to target-float.{c,h}
This patch adds the following target floating-point routines:
- target_float_binop
- target_float_compare
which call the equivalent decimal_ routines to handle decimal FP,
and call helper routines that currently still go via DOUBLEST to
handle binary FP (derived from current valarith.c code).
These routines are used to handle both binary and decimal FP types
in scalar_binop, value_equal, and value_less, mostly following the
method currently used for decimal FP. The existing value_args_as_decimal
helper is renamed to value_args_as_target_float and extended to handle
both binary and decimal types.
The unary operations value_pos and value_neg are also simplified,
the former by using a simple copy for all scalar types, the latter
by using value_binop (... BINOP_SUB) to implement negation as
subtraction from zero.
ChangeLog:
2017-11-06 Ulrich Weigand <uweigand@de.ibm.com>
* target-float.c: Include <math.h>.
(floatformat_binop): New function.
(floatformat_compare): Likewise.
(target_float_binop): Likewise.
(target_float_compare): Likewise.
* target-float.h: Include "expression.h".
(target_float_binop): Add prototype.
(target_float_compare): Likewise.
* valarith.c: Do not include "doublest.h" and "dfp.h".
Include "common/byte-vector.h".
(value_args_as_decimal): Remove, replace by ...
(value_args_as_target_float): ... this function. Handle both
binary and decimal target floating-point formats.
(scalar_binop): Handle both binary and decimal FP using
value_args_as_target_float and target_float_binop.
(value_equal): Handle both binary and decimal FP using
value_args_as_target_float and target_float_compare.
(value_less): Likewise.
(value_pos): Handle all scalar types as simple copy.
(value_neg): Handle all scalar types via BINOP_SUB from 0.
* dfp.c (decimal_binop): Throw error instead of internal_error
when called with an unsupported operation code.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Target FP: Remove unused floating-point routines
@ 2017-11-06 20:20 sergiodj+buildbot
2017-11-07 1:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-06 20:20 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b07e9c466ed24af614090ac42d6730a291608f69 ***
Author: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Branch: master
Commit: b07e9c466ed24af614090ac42d6730a291608f69
Target FP: Remove unused floating-point routines
This patch removes the following routines, which now have no remaining
users in GDB:
- extract_typed_floating
- store_typed_floating
- convert_typed_floating
- decimal_from_doublest
- decimal_to_doublest
- value_as_double
- unpack_double
- value_from_double
- value_from_decfloat
This completes removal of DOUBLEST from all files except doublest.{c,h}
and target-float.c.
gdb/ChangeLog:
2017-11-06 Ulrich Weigand <uweigand@de.ibm.com>
* doublest.c: Do not include "gdbtypes.h".
(extract_typed_floating): Remove.
(store_typed_floating): Remove.
(convert_typed_floating): Remove.
* doublest.h (struct type): Remove.
(DOUBLEST_PRINT_FORMAT): Remove.
(DOUBLEST_SCAN_FORMAT): Remove.
(extract_typed_floating): Remove.
(store_typed_floating): Remove.
(convert_typed_floating): Remove.
* dfp.c (decimal_from_doublest): Remove.
(decimal_to_doublest): Remove.
* dfp.h: Do not include "doublest.h".
(decimal_from_doublest): Remove.
(decimal_to_doublest): Remove.
* value.c: Do not include "doublest.h" and "dfp.h".
(value_as_double): Remove.
(unpack_double): Remove.
(value_from_double): Remove.
(value_from_decfloat): Remove.
* value.h: Do not include "doublest.h".
(value_as_double): Remove.
(unpack_double): Remove.
(value_from_double): Remove.
(value_from_decfloat): Remove.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Target FP: Merge doublest.c and dfp.c into target-float.c
@ 2017-11-06 21:12 sergiodj+buildbot
2017-11-07 3:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-06 21:12 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 1cfb73dbb7503d1cfb088c14d1125a5030a1f386 ***
Author: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Branch: master
Commit: 1cfb73dbb7503d1cfb088c14d1125a5030a1f386
Target FP: Merge doublest.c and dfp.c into target-float.c
Now that all target FP operations are performed via target-float.c,
this file remains the sole caller of functions in doublest.c and dfp.c.
Therefore, this patch merges the latter files into the former and
makes all their function static there.
gdb/ChangeLog:
2017-11-06 Ulrich Weigand <uweigand@de.ibm.com>
* Makefile.in (SFILES): Remove doublest.c and dfp.c.
(HFILES_NO_SRCDIR): Remove doublest.h and dfp.h.
(COMMON_OBS): Remove doublest.o and dfp.o.
Do not build target-float.c (instead of doublest.c)
with -Wformat-nonliteral.
* doublest.c: Remove file.
* doublest.h: Remove file.
* dfp.c: Remove file.
* dfp.h: Remove file.
* target-float.c: Do not include "doublest.h" and "dfp.h".
(DOUBLEST): Move here from doublest.h.
(enum float_kind): Likewise.
(FLOATFORMAT_CHAR_BIT): Likewise.
(FLOATFORMAT_LARGEST_BYTES): Likewise.
(floatformat_totalsize_bytes): Move here from doublest.c. Make static.
(floatformat_precision): Likewise.
(floatformat_normalize_byteorder, get_field, put_field): Likewise.
(floatformat_is_negative, floatformat_classify, floatformat_mantissa):
Likewise.
(host_float_format, host_double_format, host_long_double_format):
Likewise.
(floatformat_to_string, floatformat_from_string): Likewise.
(floatformat_to_doublest): Likewise. Also, inline the original
convert_floatformat_to_doublest.
(floatformat_from_doublest): Likewise. Also, inline the original
convert_floatformat_from_doublest.
Include "dpd/decimal128.h", "dpd/decimal64.h", and "dpd/decimal32.h".
(MAX_DECIMAL_STRING): Move here from dfp.c.
(match_endianness): Likewise.
(set_decnumber_context, decimal_check_errors): Likewise.
(decimal_from_number, decimal_to_number): Likewise.
(decimal_to_string, decimal_from_string): Likewise. Make static.
(decimal_from_longest, decimal_from_ulongest): Likewise.
(decimal_to_longest): Likewise.
(decimal_binop, decimal_is_zero, decimal_compare): Likewise.
(decimal_convert): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Don't set terminal flags twice in a row
@ 2017-11-06 22:47 sergiodj+buildbot
2017-11-07 6:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-06 22:47 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a94799ac1e430404fda5cbc181406cf5f3630108 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: a94799ac1e430404fda5cbc181406cf5f3630108
Don't set terminal flags twice in a row
I find this odd 'set flags twice' ancient code and comment annoyingly
distracting. It may well be that the reason for the double-set was
simply a copy/paste mistake, and that we've been doing this for
decades [1] for no good reason. Let's just get rid of it, and if we
find a real reason, add it back with a comment explaining why it's
necessary.
[1] This double-set was already in gdb 2.4 / 1988, the oldest release
we have sources for, and imported in git. From 'git show 7b4ac7e1ed2c
inflow.c':
+void
+terminal_inferior ()
+{
+ if (terminal_is_ours) /* && inferior_thisrun_terminal == 0) */
+ {
+ fcntl (0, F_SETFL, tflags_inferior);
+ fcntl (0, F_SETFL, tflags_inferior);
The "is there a reason" comment was added in 1993, by:
commit a88797b5eadf31e21804bc820429028bf708fbcd
Author: Fred Fish <fnf@specifix.com>
AuthorDate: Thu Aug 5 01:33:45 1993 +0000
gdb/ChangeLog:
2017-11-06 Pedro Alves <palves@redhat.com>
* inflow.c (child_terminal_inferior, child_terminal_ours_1): No
longer set flags twice in row.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Test attaching to a process that isn't a process group leader
@ 2017-11-07 1:06 sergiodj+buildbot
2017-11-07 10:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-07 1:06 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 46f67f80ddfeea11d4a8134b347c74581faff8f6 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 46f67f80ddfeea11d4a8134b347c74581faff8f6
Test attaching to a process that isn't a process group leader
The patch at
<https://sourceware.org/ml/gdb-patches/2017-11/msg00039.html> was
proposing to add an assertion to child_terminal_init that turns out
would fail if you tried to attach to a process that isn't a process
group leader.
Since the testsuite failed to catch the problem, this commit adds a
new testcase that would catch it, like:
(gdb) attach 12415
Attaching to program: build/gdb/testsuite/outputs/gdb.base/attach-non-pgrp-leader/attach-non-pgrp-leader, process 12415
src/gdb/inflow.c:180: internal-error: void child_terminal_init(target_ops*): Assertion `getpgid (inf->pid) == inf->pid' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Quit this debugging session? (y or n) FAIL: gdb.base/attach-non-pgrp-leader.exp: child: attach to child (GDB internal error)
gdb/testsuite/ChangeLog:
2017-11-06 Pedro Alves <palves@redhat.com>
* gdb.base/attach-non-pgrp-leader.c: New.
* gdb.base/attach-non-pgrp-leader.exp: New.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Update my e-mail address.
@ 2017-11-07 2:03 sergiodj+buildbot
2017-11-07 12:57 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-07 2:03 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 635dc5b2e5cda5b18d32c4b0f6c19cba3ef05c67 ***
Author: Luis Machado <luis.machado@linaro.org>
Branch: master
Commit: 635dc5b2e5cda5b18d32c4b0f6c19cba3ef05c67
Update my e-mail address.
gdb/ChangeLog:
2017-11-06 Luis Machado <luis.machado@linaro.org>
* MAINTAINERS (Write After Approval): Update my e-mail address.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Require ngettext in test of system gettext implementation
@ 2017-11-07 9:31 sergiodj+buildbot
2017-11-07 15:22 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-07 9:31 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f3ce9b3a00229e5c6087180a74bf533d0e5201f3 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: f3ce9b3a00229e5c6087180a74bf533d0e5201f3
Require ngettext in test of system gettext implementation
If binutils is going to use ngettext, then we'd better arrange for
intl/ to be compiled if the system gettext lacks ngettext.
* configure.ac: Invole AM_GNU_GETTEXT with need_ngettext.
* configure: Regenerate.
* aclocal.m4: Regenerate.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PowerPC64 statistics message
@ 2017-11-07 10:07 sergiodj+buildbot
2017-11-07 16:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-07 10:07 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT db84fff3f888bb3e6d51ad24b6bfa2c6e2c3a206 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: db84fff3f888bb3e6d51ad24b6bfa2c6e2c3a206
PowerPC64 statistics message
Fixes "linker stubs in 1 groups".
* elf64-ppc.c (ppc64_elf_build_stubs): Correct pluralization in
statistics message.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] This patch similarly to the AArch64 one enables Dot Product support by default for the Cortex-A55 and Cortex-A75 which have hardware support for these instructions.
@ 2017-11-07 10:42 sergiodj+buildbot
2017-11-07 17:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-07 10:42 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 0198d5e6fc331d50dc19b7f250ac4bc510a8dbb5 ***
Author: Tamar Christina <tamar.christina@arm.com>
Branch: master
Commit: 0198d5e6fc331d50dc19b7f250ac4bc510a8dbb5
This patch similarly to the AArch64 one enables Dot Product support by default for the Cortex-A55 and Cortex-A75 which have hardware support for these instructions.
gas * config/tc-arm.c (arm_cpus):
Change FPU_ARCH_CRYPTO_NEON_VFP_ARMV8
into FPU_ARCH_CRYPTO_NEON_VFP_ARMV8_DOTPROD.
include * opcode/arm.h (FPU_ARCH_CRYPTO_NEON_VFP_ARMV8_DOTPROD):
New macro.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Allow enabling/disabling breakpoint location ranges
@ 2017-11-07 11:32 sergiodj+buildbot
2017-11-07 19:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-07 11:32 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d0fe47010fc3289e081ba547a0bfcc6d07906cd2 ***
Author: Xavier Roirand <roirand@adacore.com>
Branch: master
Commit: d0fe47010fc3289e081ba547a0bfcc6d07906cd2
Allow enabling/disabling breakpoint location ranges
When a breakpoint has multiple locations, like e.g.:
Num Type Disp Enb Address What
1 breakpoint keep y <MULTIPLE>
1.1 y 0x080486a2 in void foo<int>()...
1.2 y 0x080486ca in void foo<double>()...
[....]
1.5 y 0x080487fa in void foo<long>()...
it's possible to enable/disable the individual locations using the
'<breakpoint_number>.<location_number>' syntax, like e.g.:
(gdb) disable 1.2 1.3 1.4 1.5
That's inconvenient when you have a long list of locations to disable,
however.
This patch adds shorthand for the above, by making it possible to
specify a range of locations with the following syntax (similar to
thread id ranges):
<breakpoint_number>.<first_location_number>-<last_location_number>
For example, the command above can now be simplified to:
(gdb) disable 1.2-5
gdb/ChangeLog:
2017-11-07 Xavier Roirand <roirand@adacore.com>
Pedro Alves <palves@redhat.com>
* breakpoint.c (map_breakpoint_number_range): New, factored out
from ...
(map_breakpoint_numbers): ... here.
(find_location_by_number): Change parameters from string to
breakpoint number and location.
(extract_bp_number_and_location): New function.
(enable_disable_bp_num_loc)
(enable_disable_breakpoint_location_range)
(enable_disable_command): New functions, factored out ...
(enable_command, disable_command): ... these functions, and
adjusted to support ranges.
* NEWS: Document enable/disable breakpoint location range feature.
gdb/doc/ChangeLog:
2017-11-07 Xavier Roirand <roirand@adacore.com>
Pedro Alves <palves@redhat.com>
* gdb.texinfo (Set Breaks): Document support for breakpoint
location ranges in the enable/disable commands.
gdb/testsuite/ChangeLog:
2017-11-07 Xavier Roirand <roirand@adacore.com>
Pedro Alves <palves@redhat.com>
* gdb.base/ena-dis-br.exp: Add reference to
gdb.cp/ena-dis-br-range.exp.
* gdb.cp/ena-dis-br-range.exp: New file.
* gdb.cp/ena-dis-br-range.cc: New file.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add base 'enable/disable invalid location range' tests
@ 2017-11-07 12:55 sergiodj+buildbot
2017-11-07 22:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-07 12:55 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT cee62dbd8771e22856d950c2615fb463305a9fcb ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: cee62dbd8771e22856d950c2615fb463305a9fcb
Add base 'enable/disable invalid location range' tests
This adds tests that exercise the "bad breakpoint number" paths.
Specifically:
- malformed ranges
- use of explicit 0 as bp/loc number.
- inverted ranges
I'm adding this as a baseline to improve. This shows that there's a
lot of inconsistency in GDB's output (e.g., "bad" vs "Bad").
Also, IMO, the "0-0" and inverted range cases should be loud errors.
That and more will all be addressed in the next patch.
gdb/testsuite/ChangeLog:
2017-11-07 Pedro Alves <palves@redhat.com>
* gdb.cp/ena-dis-br-range.exp: Add tests.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add some more breakpoint/location range tests
@ 2017-11-07 14:20 sergiodj+buildbot
2017-11-08 0:42 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-07 14:20 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a02b41a7e604471e584dc2151fbd36714842710e ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: a02b41a7e604471e584dc2151fbd36714842710e
Add some more breakpoint/location range tests
Some extra thoroughness tests that I had over here.
gdb/testsuite/ChangeLog:
2017-11-07 Pedro Alves <palves@redhat.com>
* gdb.cp/ena-dis-br-range.exp: Add more tests.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] opcodes/arc: Fix incorrect insn_class for some nps insns
@ 2017-11-07 20:49 sergiodj+buildbot
2017-11-08 3:42 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-07 20:49 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 52eab766df54915f8d3d71475235868285c4ca82 ***
Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 52eab766df54915f8d3d71475235868285c4ca82
opcodes/arc: Fix incorrect insn_class for some nps insns
A small number of NPS400 instruction incorrectly used NONE as an
insn_class_t, which would trigger a build warning. Fixed by changing to
MISC.
opcodes/ChangeLog:
* arc-nps400-tbl.h: Change incorrect use of NONE to MISC.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Constify add_abbrev_prefix_cmd
@ 2017-11-07 21:27 sergiodj+buildbot
2017-11-08 5:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-07 21:27 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ee7ddd713206fdf02512a9fb3fe928a210200c11 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: ee7ddd713206fdf02512a9fb3fe928a210200c11
Constify add_abbrev_prefix_cmd
This changes add_abbrev_prefix_cmd to take a const-taking callback
function and then fixes the one caller.
gdb/ChangeLog
2017-11-07 Tom Tromey <tom@tromey.com>
* breakpoint.c (stop_command): Constify.
* cli/cli-decode.c (struct cmd_list_element): Constify.
* command.h (add_abbrev_prefix_cmd): Constify.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Constify add_com_suppress_notification
@ 2017-11-07 21:57 sergiodj+buildbot
2017-11-08 6:07 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-07 21:57 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 1ee870c5249864d36717a08864c60d7166b6b292 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 1ee870c5249864d36717a08864c60d7166b6b292
Constify add_com_suppress_notification
This constifies add_com_suppress_notification and fixes the one
caller.
gdb/ChangeLog
2017-11-07 Tom Tromey <tom@tromey.com>
* stack.c (select_frame_command): Constify.
* cli/cli-decode.c (add_com_suppress_notification): Constify.
* command.h (add_com_suppress_notification): Constify.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Constify add_path and friends
@ 2017-11-07 23:28 sergiodj+buildbot
2017-11-08 10:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-07 23:28 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 5614fb77203f5ea01edfb2d739e9d4f3d570dc09 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 5614fb77203f5ea01edfb2d739e9d4f3d570dc09
Constify add_path and friends
This constifies add_path, mod_path, and directory_switch.
gdb/ChangeLog
2017-11-07 Tom Tromey <tom@tromey.com>
* source.c (directory_switch, mod_path, add_path): Constify.
* defs.h (add_path, mod_path, directory_switch): Constify.
* mi/mi-cmd-env.c (env_mod_path): Constify.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove cleanup from backtrace_command
@ 2017-11-07 23:48 sergiodj+buildbot
2017-11-08 11:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-07 23:48 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 022643b4456ee13752b0f3a8411238ab8c53bf6d ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 022643b4456ee13752b0f3a8411238ab8c53bf6d
Remove cleanup from backtrace_command
This removes a cleanup from backtrace_command, replacing it with
std::string. This patch temporarily changes backtrace_command so that
the parameter is named "args_in" and is immediately constified; this
is fixed again in the constification patch.
gdb/ChangeLog
2017-11-07 Tom Tromey <tom@tromey.com>
* stack.c (backtrace_command): Use std::string.
(backtrace_command_1): Make "count_exp" const.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Constify add_setshow_*
@ 2017-11-08 1:18 sergiodj+buildbot
2017-11-08 16:23 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-08 1:18 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT eb4c3f4aaae2ee1b27c210e951260a7e699133b4 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: eb4c3f4aaae2ee1b27c210e951260a7e699133b4
Constify add_setshow_*
This constifies the add_setshow_* family of functions, and then fixes
up the fallout. The bulk of this patch was written by script.
gdb/ChangeLog
2017-11-07 Tom Tromey <tom@tromey.com>
* ada-lang.c (catch_ada_exception_command): Constify.
(catch_assert_command): Constify.
* break-catch-throw.c (catch_catch_command, catch_throw_command)
(catch_rethrow_command): Constify.
(catch_exception_command_1): Constify.
* breakpoint.h (add_catch_command): Constify.
* break-catch-syscall.c (catch_syscall_command_1): Constify.
(catch_syscall_split_args): Constify.
* break-catch-sig.c (catch_signal_command): Constify.
(catch_signal_split_args): Constify.
* cli/cli-decode.h (struct cmd_list_element) <function>: Use
cmd_const_sfunc_ftype.
* cli/cli-decode.c (add_setshow_cmd_full): Constify.
(add_setshow_enum_cmd, add_setshow_auto_boolean_cmd)
(add_setshow_boolean_cmd, add_setshow_filename_cmd)
(add_setshow_string_cmd, struct cmd_list_element)
(add_setshow_optional_filename_cmd, add_setshow_integer_cmd)
(add_setshow_uinteger_cmd, add_setshow_zinteger_cmd)
(add_setshow_zuinteger_unlimited_cmd, add_setshow_zuinteger_cmd):
Constify.
(set_cmd_sfunc): Constify.
(empty_sfunc): Constify.
* command.h (add_setshow_enum_cmd, add_setshow_auto_boolean_cmd)
(add_setshow_boolean_cmd, add_setshow_filename_cmd)
(add_setshow_string_cmd, add_setshow_string_noescape_cmd)
(add_setshow_optional_filename_cmd, add_setshow_integer_cmd)
(add_setshow_uinteger_cmd, add_setshow_zinteger_cmd)
(add_setshow_zuinteger_cmd, add_setshow_zuinteger_unlimited_cmd):
Constify.
(set_cmd_sfunc): Constify.
(cmd_sfunc_ftype): Remove.
* compile/compile.c (set_compile_args): Constify.
* infrun.c (set_disable_randomization): Constify.
* infcmd.c (set_args_command, set_cwd_command): Constify.
* breakpoint.c (set_condition_evaluation_mode): Constify.
(add_catch_command): Constify.
(catch_fork_command_1, catch_exec_command_1)
(catch_load_command_1, catch_unload_command_1): Constify.
(catch_load_or_unload): Constify.
* guile/scm-param.c (pascm_set_func): Constify.
(add_setshow_generic): Constify.
* python/py-param.c (get_set_value): Constify.
* top.h (set_verbose): Constify.
* tui/tui-win.c (tui_set_var_cmd): Constify.
* mi/mi-main.c (set_mi_async_command): Constify.
* cli/cli-logging.c (set_logging_overwrite)
(set_logging_redirect): Constify.
* value.c (set_max_value_size): Constify.
* valprint.c (set_input_radix, set_output_radix): Constify.
* utils.c (set_width_command, set_height_command): Constify.
* typeprint.c (set_print_type_methods, set_print_type_typedefs): Constify.
* tracepoint.c (set_disconnected_tracing)
(set_circular_trace_buffer, set_trace_buffer_size)
(set_trace_user, set_trace_notes, set_trace_stop_notes): Constify.
* top.c (set_history_size_command, set_verbose, set_editing)
(set_gdb_datadir, set_history_filename): Constify.
* target.c (set_targetdebug, maint_set_target_async_command)
(maint_set_target_non_stop_command, set_target_permissions)
(set_write_memory_permission): Constify.
(open_target): Constify.
* target-descriptions.c (set_tdesc_filename_cmd): Constify.
* target-dcache.c (set_stack_cache, set_code_cache): Constify.
* symtab.c (set_symbol_cache_size_handler): Constify.
* symfile.c (set_ext_lang_command): Constify.
* symfile-debug.c (set_debug_symfile): Constify.
* source.c (set_directories_command): Constify.
* solib.c (reload_shared_libraries, gdb_sysroot_changed): Constify.
* serial.c (set_parity): Constify.
* rs6000-tdep.c (powerpc_set_soft_float, powerpc_set_vector_abi): Constify.
* remote.c (set_remote_exec_file, set_remotebreak)
(set_remote_protocol_Z_packet_cmd, set_range_stepping): Constify.
* record.c (set_record_insn_history_size)
(set_record_call_history_size): Constify.
* record-full.c (set_record_full_insn_max_num): Constify.
* proc-api.c (set_procfs_trace_cmd, set_procfs_file_cmd): Constify.
* osabi.c (set_osabi): Constify.
* mips-tdep.c (set_mips64_transfers_32bit_regs)
(reinit_frame_cache_sfunc, mips_abi_update): Constify.
* maint.c (maintenance_set_profile_cmd): Constify.
* linux-thread-db.c (set_libthread_db_search_path): Constify.
* language.c (set_language_command, set_range_command)
(set_case_command): Constify.
* infrun.c (set_non_stop, set_observer_mode)
(set_stop_on_solib_events, set_schedlock_func)
(set_exec_direction_func): Constify.
* infcmd.c (set_inferior_tty_command): Constify.
* disasm.c (set_disassembler_options_sfunc): Constify.
* demangle.c (set_demangling_command): Constify.
* dcache.c (set_dcache_size, set_dcache_line_size): Constify.
* cris-tdep.c (set_cris_version, set_cris_mode)
(set_cris_dwarf2_cfi): Constify.
* corefile.c (set_gnutarget_command): Constify.
* charset.c (set_host_charset_sfunc, set_target_charset_sfunc)
(set_target_wide_charset_sfunc): Constify.
* breakpoint.c (update_dprintf_commands): Constify.
* auto-load.c (set_auto_load_dir, set_auto_load_safe_path): Constify.
* arm-tdep.c (set_fp_model_sfunc, arm_set_abi)
(set_disassembly_style_sfunc): Constify.
* arch-utils.c (set_endian, set_architecture): Constify.
* alpha-tdep.c (reinit_frame_cache_sfunc): Constify.
* agent.c (set_can_use_agent): Constify.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Change the type of the aarch64_feature_set typedef to unsigned long long so that it will work on 32-bit hosts.
@ 2017-11-09 10:49 sergiodj+buildbot
2017-11-09 11:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-09 10:49 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 21b81e67c73368dbbc9f6356ac5a7eb274789a32 ***
Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 21b81e67c73368dbbc9f6356ac5a7eb274789a32
Change the type of the aarch64_feature_set typedef to unsigned long long so that it will work on 32-bit hosts.
* opcode/aarch64.h (aarch64_feature_set): Change type to unsigned
long long.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Simplify the psymbol hash function
@ 2017-11-09 16:31 sergiodj+buildbot
2017-11-09 18:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-09 16:31 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e793c052f9d9548442a46817998a46cbca4ccb70 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: e793c052f9d9548442a46817998a46cbca4ccb70
Simplify the psymbol hash function
This patch simplifies the psymbol_hash function, by changing it not to
examine the contents of the symbol's name. This change just mirrors
what psymbol_compare already does -- it is checking for name equality,
which is ok because symbol names are interned in symbol_set_names.
This change speeds up psymbol reading. "gdb -nx -batch gdb"
previously took ~1.8 seconds on my machine, and with this patch it now
takes ~1.7 seconds.
gdb/ChangeLog
2017-11-09 Tom Tromey <tom@tromey.com>
* psymtab.c (psymbol_hash): Do not hash string contents.
(psymbol_compare): Add comment.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Adds the new Fields and Operand types for the new instructions in Armv8.4-a.
@ 2017-11-09 17:04 sergiodj+buildbot
2017-11-09 20:07 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-09 17:04 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f42f1a1d6ca0cc84e43d7f2b85044a2565ca00f2 ***
Author: Tamar Christina <tamar.christina@arm.com>
Branch: master
Commit: f42f1a1d6ca0cc84e43d7f2b85044a2565ca00f2
Adds the new Fields and Operand types for the new instructions in Armv8.4-a.
gas/
* config/tc-aarch64.c (process_omitted_operand):
Add AARCH64_OPND_Va, AARCH64_OPND_SM3_IMM2
and AARCH64_OPND_IMM_2.
(parse_operands): Add AARCH64_OPND_Va, AARCH64_OPND_SM3_IMM2,
AARCH64_OPND_IMM_2, AARCH64_OPND_MASK
and AARCH64_OPND_ADDR_OFFSET.
include/
* opcode/aarch64.h:
(aarch64_opnd): Add AARCH64_OPND_Va, AARCH64_OPND_MASK,
AARCH64_OPND_IMM_2, AARCH64_OPND_ADDR_OFFSET
and AARCH64_OPND_SM3_IMM2.
(aarch64_insn_class): Add cryptosm3 and cryptosm4.
(arch64_feature_set): Make uint64_t.
opcodes/
* aarch64-asm.h (ins_addr_offset): New.
* aarch64-asm.c (aarch64_ins_reglane): Add cryptosm3.
(aarch64_ins_addr_offset): New.
* aarch64-asm-2.c: Regenerate.
* aarch64-dis.h (ext_addr_offset): New.
* aarch64-dis.c (aarch64_ext_reglane): Add cryptosm3.
(aarch64_ext_addr_offset): New.
* aarch64-dis-2.c: Regenerate.
* aarch64-opc.h (aarch64_field_kind): Add FLD_imm6_2,
FLD_imm4_2 and FLD_SM3_imm2.
* aarch64-opc.c (fields): Add FLD_imm6_2,
FLD_imm4_2 and FLD_SM3_imm2.
(operand_general_constraint_met_p): Add AARCH64_OPND_ADDR_OFFSET.
(aarch64_print_operand): Add AARCH64_OPND_Va, AARCH64_OPND_SM3_IMM2,
AARCH64_OPND_MASK, AARCH64_OPND_IMM_2 and AARCH64_OPND_ADDR_OFFSET.
* aarch64-opc-2.c (Va, MASK, IMM_2, ADDR_OFFSET, SM3_IMM2): New.
* aarch64-tbl.h
(aarch64_opcode_table): Add Va, MASK, IMM_2, ADDR_OFFSET, SM3_IMM2.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] fix typos in ada-lang.c comment
@ 2017-11-09 20:24 sergiodj+buildbot
2017-11-10 2:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-09 20:24 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 31432a672fd40058a714eb2791ea1c3168ccc4f1 ***
Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 31432a672fd40058a714eb2791ea1c3168ccc4f1
fix typos in ada-lang.c comment
gdb/ChangeLog:
* ada-lang.c: Fix some typos in the general command documenting
how Ada expressions are being evaluated and how their result
is printed.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix racy output matching in gdb.asm/asm-source.exp
@ 2017-11-09 23:12 sergiodj+buildbot
2017-11-10 3:38 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-09 23:12 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f29f4b6ba198674096fddf2aa38fa8d028d387b2 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: f29f4b6ba198674096fddf2aa38fa8d028d387b2
Fix racy output matching in gdb.asm/asm-source.exp
Testing with:
$ make check-read1 TESTS="gdb.asm/asm-source.exp"
Exposes a testcase bug that can result in racy fails:
(gdb) PASS: gdb.asm/asm-source.exp: next over foo3
return
Make selected stack frame return now? (y or n) y
n
#0 main () at /home/pedro/gdb/mygit/src/gdb/testsuite/gdb.asm/asmsrc1.s:53
53 gdbasm_exit0
(gdb) FAIL: gdb.asm/asm-source.exp: return from foo2 (got interactive prompt)
n
The problem is that the "return now\?.*" regex can match partial
output like this:
"Make selected stack frame return no"
and then we send the 'y' too early, and then the next time around we
hit gdb_test_multiple's internal "got interactive prompt" regex.
Also, note we match "return no" instead of "return now" because the
regex is missing one quote level.
gdb/testsuite/ChangeLog:
2017-11-09 Pedro Alves <palves@redhat.com>
* gdb.asm/asm-source.exp ("kill" test): Match the whole query
output. Fix '?' match.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix racy output matching in gdb.base/completion.exp
@ 2017-11-09 23:46 sergiodj+buildbot
2017-11-10 5:28 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-09 23:46 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c7a3851716f98540396b9e02be7d2fcd3bff2d29 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: c7a3851716f98540396b9e02be7d2fcd3bff2d29
Fix racy output matching in gdb.base/completion.exp
Testing with:
$ make check-read1 TESTS="gdb.base/completion.exp"
Exposes a testcase bug that can result in racy fails:
FAIL: gdb.base/completion.exp: command-name completion limiting using tab character
ERROR: Undefined command "".
FAIL: gdb.base/completion.exp: symbol-name completion limiting using tab character
FAIL: gdb.base/completion.exp: symbol-name completion limiting using complete command
testsuite/gdb.log shows:
(gdb) PASS: gdb.base/completion.exp: set max-completions 5
p^G
passcount path print print-object printf
*** List may be truncated, max-completions reached. ***
(gdb) FAIL: gdb.base/completion.exp: command-name completion limiting using tab character
pcomplete p
Undefined command: "pcomplete". Try "help".
(gdb) ERROR: Undefined command "".
The problem is that the expect buffer can get filled with partial
output that ends in the gdb prompt, and so the default FAIL inside
gdb_test_multiple matches.
Fix that by splitting the gdb_test_multiple in two stages. Since that
is done in more than one place in the testcase, move the otherwise
duplicate code to helper procedures.
gdb/testsuite/ChangeLog:
2017-11-09 Pedro Alves <palves@redhat.com>
* gdb.base/completion.exp (ignore_and_resync, test_tab_complete):
New procedures, factored out from ...
(top level): ... here, and adjusted to avoid expecting beyond the
prompt in one go.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix racy output matching in gdb.base/memattr.exp
@ 2017-11-10 0:28 sergiodj+buildbot
2017-11-10 6:41 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-10 0:28 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2c88253fc469fbf40be7f0d1f7060b81055f2eb1 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 2c88253fc469fbf40be7f0d1f7060b81055f2eb1
Fix racy output matching in gdb.base/memattr.exp
Testing with:
$ make check-read1 TESTS="gdb.base/memattr.exp"
Exposes a testcase bug that can result in racy fails:
info mem
Using user-defined memory regions.
Num Enb Low Addr High Addr Attrs
1 y 0x0000000000601060 0x0000000000601160 wo nocache
2 y 0x0000000000601180 0x0000000000601280 ro nocache
4 y 0x0000000000601280 0x0000000000601380 rw nocache
3 y 0x0000000000601380 0x0000000000601480 rw nocache
5 y 0x0000000000601480 0x0000000000601580 rw nocache
(gdb) FAIL: gdb.base/memattr.exp: info mem (1)
The problem is that:
"Attrs\[^\n\r]*.."
matches:
"Attrs \r"
when the output buffer is filled with partial output like this:
"info mem\r\nUsing user-defined memory regions.\r\nNum Enb Low Addr High Addr Attrs \r"
gdb/testsuite/ChangeLog:
2017-11-09 Pedro Alves <palves@redhat.com>
* gdb.base/memattr.exp: Tighten regexes to match the end line.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] non_got_ref after adjust_dynamic_relocs
@ 2017-11-12 10:14 sergiodj+buildbot
2017-11-12 12:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-12 10:14 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 529fe20eeb0030ea5d653d0ebec433f9e3145874 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 529fe20eeb0030ea5d653d0ebec433f9e3145874
non_got_ref after adjust_dynamic_relocs
This patch was aimed at a FIXME in elf32-hppa.c, the ludicrous and
confusing fact that non_got_ref after adjust_dynamic_relocs in that
backend means precisely the inverse of what it means before
adjust_dynamic_relocs. Before, when non_got_ref is set it means there
are dynamic relocs, after, if non_got_ref is clear it means "keep
dynamic relocs" and later, "has dynamic relocs". There is a reason
why it was done that way.. Some symbols that may have dynamic
relocations pre-allocated in check_relocs turn out to not be dynamic,
and then are not seen by the backend adjust_dynamic_symbols. We want
those symbols to lose their dynamic relocs when non-pic, so it's handy
that non_got_ref means the opposite after adjust_dynamic_relocs. But
it's really confusing.
Most other targets, like ppc32, don't always set non_got_ref on
non-GOT references that have dynamic relocations. This is because the
primary purpose of non_got_ref before adjust_dynamic_relocs is to flag
symbols that might need to be copied to .dynbss, and there are
relocation types that may require dyn_relocs but clearly cannot have
symbols copied into .dynbss, for example, TLS relocations.
Why do we need a flag after adjust_dynamic_relocs to say "keep
dynamic relocations"? Well, you can discard most unwanted dyn_relocs
in the backend adjust_dynamic_relocs, and for those symbols that
aren't seen by the backend adjust_dynamic_relocs, in
allocate_dynrelocs based on a flag set by adjust_dynamic relocs,
dynamic_adjusted. That doesn't solve all our difficulties though.
relocate_section needs to know whether a symbol has dyn_relocs, and
many targets transfer dyn_relocs to a weakdef if the symbol has one.
The transfer means relocate_section can't test dyn_relocs itself and
the weakdef field has been overwritten by that time. So non_got_ref
is used to flag "this symbol has dynamic relocations" for
relocate_section.
Confused still? Well, let's hope the comments I've added help clarify
things.. The patch also fixes a case where we might wrongly emit
dynamic relocations in an executable for common and undefined symbols.
* elf32-hppa.c (elf32_hppa_adjust_dynamic_symbol): Set non_got_ref
to keep dyn_relocs, clear to discard. Comment.
(allocate_dynrelocs): Always clear non_got_ref when clearing
dyn_relocs in non-pic case. Invert non_got_ref test. Also test
dynamic_adjusted and ELF_COMMON_DEF_P. Move code deleting
dyn_relocs on undefined syms to handle for non-pic too.
(elf32_hppa_relocate_section): Simplify test for non-pic dyn relocs.
* elf32-ppc.c (ppc_elf_adjust_dynamic_symbol): Set non_got_ref
to keep dyn_relocs, clear to discard. Comment.
(allocate_dynrelocs): Always clear non_got_ref when clearing
dyn_relocs in non-pic case. Invert non_got_ref test. Also test
dynamic_adjusted and ELF_COMMON_DEF_P. Move code deleting
dyn_relocs on undefined syms to handle for non-pic too.
(ppc_elf_relocate_section): Simplify test for non-pic dyn relocs.
* elf64-ppc.c (ppc64_elf_adjust_dynamic_symbol): Discard
dyn_relocs here. Don't bother setting non_got_ref. Comment.
(allocate_dynrelocs): Delete special handling of non-pic ELFv2
ifuncs. Move code deleting dyn_relocs on undefined symbols to
handle for non-pic too. Don't test non_got_ref. Do test
dynamic_adjusted and ELF_COMMON_DEF_P.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] weakdef list handling
@ 2017-11-12 10:49 sergiodj+buildbot
2017-11-12 13:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-12 10:49 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e3e53eed9c2f1ab82ae4a7683f474b4f6eb162c7 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: e3e53eed9c2f1ab82ae4a7683f474b4f6eb162c7
weakdef list handling
The existing code allowed common and indirect symbols to pass an
assert, but then read root.u.def which is not valid for anything
besides defined and weakdef symbols. The garbage root.u.def.section
pointer read can't possibly match pointers stored at the same location
for indirect and common symbols, so we would always have left
u.weakdef NULL.
* elflink.c (elf_link_add_object_symbols): Ignore anything but
defined and defweak symbols when setting up weakdefs.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] ld: Remove PF_X from PT_PHDR segment
@ 2017-11-13 1:32 sergiodj+buildbot
2017-11-13 2:28 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-13 1:32 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f882209d9aa5b68d68c45c5849e129ffc228749c ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: f882209d9aa5b68d68c45c5849e129ffc228749c
ld: Remove PF_X from PT_PHDR segment
It was reasonable to mark PT_PHDR segment with PF_X for compatibility
with UnixWare and Solaris linkers 20 years ago. But it is inappropriate
today when the primary OS of GNU ld is Linux. This patch removes PF_X
from PT_PHDR segment as gold does.
Tested natively on Linux/x86 as well as crosss-binutils for alpha-linux,
ia64-linux, powerpc64-linux, powerpc-linux, s390-linux, s390x-linux,
sparc64-linux and sparc-linux.
bfd/
PR ld/22423
* elf.c (_bfd_elf_map_sections_to_segments): Remove PF_X from
PT_PHDR segment.
ld/
PR ld/22423
* testsuite/ld-alpha/tlsbin.rd: Replace "R E " with "R +" for
PT_PHDR segment.
* testsuite/ld-alpha/tlsbinr.rd: Likewise.
* testsuite/ld-ia64/tlsbin.rd: Likewise.
* testsuite/ld-powerpc/tlsexe.r: Likewise.
* testsuite/ld-powerpc/tlsexe32.r: Likewise.
* testsuite/ld-powerpc/tlsexetoc.r: Likewise.
* testsuite/ld-s390/tlsbin.rd: Likewise.
* testsuite/ld-s390/tlsbin_64.rd: Likewise.
* testsuite/ld-sparc/tlssunbin32.rd: Likewise.
* testsuite/ld-sparc/tlssunbin64.rd: Likewise.
* testsuite/ld-elf/pr22423.d: New test.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: {f, }xsave64 / {f, }xrstor64 / xsaveopt64 should not allow q suffix
@ 2017-11-13 11:44 sergiodj+buildbot
2017-11-13 12:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-13 11:44 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 897e603cb98c50968ea21d1b3baac5bc020ccc06 ***
Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 897e603cb98c50968ea21d1b3baac5bc020ccc06
x86: {f,}xsave64 / {f,}xrstor64 / xsaveopt64 should not allow q suffix
Just like is the case for xsave{s,c}64 and xrstors64 already. I wonder
though why xsave{s,c} and xrstors don't allow for the q suffix, other
than the other insns without the "64" suffix do.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Enable hardware single step for m68k in GDBServer
@ 2017-11-13 15:31 sergiodj+buildbot
2017-11-13 16:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-13 15:31 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 5616b6c32f7454987ae167ba35589e095c0172fc ***
Author: Andreas Schwab <schwab@suse.de>
Branch: master
Commit: 5616b6c32f7454987ae167ba35589e095c0172fc
Enable hardware single step for m68k in GDBServer
* linux-m68k-low.c (m68k_supports_hardware_single_step): New
function.
(struct linux_target_ops) <supports_hardware_single_step>: Initialize.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Inconsistent .eh_frame_hdr on powerpc64
@ 2017-11-14 5:41 sergiodj+buildbot
2017-11-14 6:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-14 5:41 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2d0d44d514d9a2e2b0f7ae8129d52b02160c9897 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 2d0d44d514d9a2e2b0f7ae8129d52b02160c9897
Inconsistent .eh_frame_hdr on powerpc64
There is code in bfd/elf-eh-frame.c and ld/emultempl/elf32.em that
checks for the presence of eh_frame info by testing for a section
named .eh_frame sized more than 8 bytes. The size test is to exclude
a zero terminator. A similar check in elf64-ppc.c wrongly just tested
for non-zero size before creating the linker generated .eh_frame
describing plt call and other linkage stubs. The intention was to not
generate that info unless there was some user .eh_frame. (No user
.eh_frame implies the user doesn't care about exception handling.)
Because the test in elf64-ppc.c was wrong, ld generated the stub
.eh_frame just on finding a zero .eh_frame terminator in crtend.o, but
didn't generate the corresponding .eh_frame_hdr.
* elf64-ppc.c (ppc64_elf_size_stubs): Correct test for user
.eh_frame info.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: add disassembler support for XOP VPCOM* pseudo-ops
@ 2017-11-14 9:28 sergiodj+buildbot
2017-11-14 12:06 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-14 9:28 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT be92cb147d77d0ebc6a084a18627d800a9da9f95 ***
Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: be92cb147d77d0ebc6a084a18627d800a9da9f95
x86: add disassembler support for XOP VPCOM* pseudo-ops
Matching up with the assembler, which already supports them.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: drop VEXI4_Fixup()
@ 2017-11-15 8:44 sergiodj+buildbot
2017-11-15 10:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-15 8:44 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 3a2430e05b1503653ae09cb21feb2a0d4ea51ec7 ***
Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 3a2430e05b1503653ae09cb21feb2a0d4ea51ec7
x86: drop VEXI4_Fixup()
The low four bits of an immediate being set when the high bits specify a
fourth register operand is not a problem: CPUs ignore these bits rather
than raising #UD. Take care of incrementing codep in OP_EX_VexW()
instead.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: use correct register names
@ 2017-11-15 9:40 sergiodj+buildbot
2017-11-15 12:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-15 9:40 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 390a67891e4f1ed334e266cf084ba8948da5fcdf ***
Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 390a67891e4f1ed334e266cf084ba8948da5fcdf
x86: use correct register names
VEX.W may be legitimately set (and is then ignored by the CPU) for
non-64-bit code. Don't print 64-bit register names in such a case, by
utilizing that REX_W would never be set for non-64-bit code, and that
it is being set from VEX.W by generic decoding.
A test for this is going to be introduced in the next patch of this
series.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix M68HC11_NUM_REGS
@ 2017-11-15 10:29 sergiodj+buildbot
2017-11-15 13:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-15 10:29 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a714b0d6928ba195623ec2825b00c446939f6e59 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: a714b0d6928ba195623ec2825b00c446939f6e59
Fix M68HC11_NUM_REGS
M68HC11_LAST_HARD_REG is 8, but m68hc11 register number is started from 0,
so there are 9 raw registers, but M68HC11_NUM_REGS is 8 by mistake.
My following unit test can find this issue (GDB is built with asan)
=================================================================
==15555==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000113150 at pc 0x51393f bp 0x7fffcec36f60 sp 0x7fffcec36f58
WRITE of size 2 at 0x602000113150 thread T0
#0 0x51393e in m68hc11_pseudo_register_read gdb/m68hc11-tdep.c:320
#1 0xc4b620 in gdbarch_pseudo_register_read(gdbarch*, regcache*, int, unsigned char*) gdb/gdbarch.c:1974
#2 0xddad88 in regcache::cooked_read(int, unsigned char*) gdb/regcache.c:710
#3 0xddff2b in cooked_read_test gdb/regcache.c:1850
#4 0xdf8cfb in selftests::gdbarch_selftest::operator()() const gdb/selftest-arch.c:73
gdb:
2017-11-15 Yao Qi <yao.qi@linaro.org>
* m68hc11-tdep.c (M68HC11_NUM_REGS): Change it to
M68HC11_LAST_HARD_REG + 1.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Handle ' and I format flags
@ 2017-11-15 12:22 sergiodj+buildbot
2017-11-15 16:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-15 12:22 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a5065160868895e91cac8515263d9783f8120818 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: a5065160868895e91cac8515263d9783f8120818
Handle ' and I format flags
Also a little tidying and error checking.
* bfd.c (union _bfd_doprnt_args): Add "Bad".
(_bfd_doprnt): Handle more flags.
(_bfd_doprnt_scan): Likewise. Tidy setting of args array.
(error_handler_internal): Init args type to Bad.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Move self to Past Maintainers.
@ 2017-11-15 15:43 sergiodj+buildbot
2017-11-15 19:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-15 15:43 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 34a7ebaff9e522913afba4e9cac9d8d5064e5480 ***
Author: Andrew Cagney <cagney@gnu.org>
Branch: master
Commit: 34a7ebaff9e522913afba4e9cac9d8d5064e5480
Move self to Past Maintainers.
2017-11-15 Andrew Cagney <cagney@gnu.org>
* MAINTAINERS: Move self to Past Maintainers.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Separate the new FP16 instructions backported from Armv8.4-a to Armv8.2-a into a new flag order to distinguish them from the rest of the already existing optional FP16 instructions in Armv8.2-a.
@ 2017-11-15 17:36 sergiodj+buildbot
2017-11-15 22:05 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-15 17:36 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 01f48020363f1ca9b31df2ee0b2afedc38db1259 ***
Author: Tamar Christina <tamar.christina@arm.com>
Branch: master
Commit: 01f48020363f1ca9b31df2ee0b2afedc38db1259
Separate the new FP16 instructions backported from Armv8.4-a to Armv8.2-a into a new flag order to distinguish them from the rest of the already existing optional FP16 instructions in Armv8.2-a.
The new flag "+fp16fml" is available from Armv8.2-a and implies +fp16 and is mandatory
from Armv8.4-a.
gas/
* config/tc-arm.c (arm_ext_fp16_fml, fp16fml): New.
(do_neon_fmac_maybe_scalar_long): Use arm_ext_fp16_fml.
* doc/c-arm.texi (fp16, fp16fml): New.
* testsuite/gas/arm/armv8_2-a-fp16.d (fp16): Make fp16fml.
* testsuite/gas/arm/armv8_3-a-fp16.d (fp16): Make fp16fml.
* testsuite/gas/arm/armv8_2-a-fp16-illegal.d (fp16): Make fp16fml.
* testsuite/gas/arm/armv8_2-a-fp16-thumb2.d (fp16): Make fp16fml.
include/
* opcode/arm.h: (ARM_EXT2_FP16_FML): New.
(ARM_AEXT2_V8_4A): Add ARM_EXT2_FP16_FML.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Include <array> to declare std::array<>.
@ 2017-11-15 21:02 sergiodj+buildbot
2017-11-16 3:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-15 21:02 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a014b87a9ac665d2b92cfc66384d1af3ddd345dd ***
Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: a014b87a9ac665d2b92cfc66384d1af3ddd345dd
Include <array> to declare std::array<>.
gdb/ChangeLog:
* symtab.h: Include <array>.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix tic6x-uclinux GDBserver build failure
@ 2017-11-16 10:28 sergiodj+buildbot
2017-11-16 11:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-16 10:28 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 3491a34c4f7de10dbd19c719052642d8471c45a6 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 3491a34c4f7de10dbd19c719052642d8471c45a6
Fix tic6x-uclinux GDBserver build failure
I can't find a c6x-uclinux c++ compiler, so I use my host g++ to build
tic6x-uclinux GDBserver, and find the following build failures. They are
not target specific, so I believe they are real errors. This patch fixes
them.
../binutils-gdb/gdb/gdbserver/linux-tic6x-low.c:313:34: error: invalid
conversion from 'void*' to 'tic6x_register*' [-fpermissive]
union tic6x_register *regset = buf;
^
../binutils-gdb/gdb/gdbserver/linux-tic6x-low.c: In function 'void tic6x_store_gregset(regcache*, const void*)':
../binutils-gdb/gdb/gdbserver/linux-tic6x-low.c:324:40: error: invalid
conversion from 'const void*' to 'const tic6x_register*' [-fpermissive]
const union tic6x_register *regset = buf;
^
../binutils-gdb/gdb/gdbserver/linux-tic6x-low.c: At global scope:
../binutils-gdb/gdb/gdbserver/linux-tic6x-low.c:359:28: error: redefinition of 'usrregs_info tic6x_usrregs_info'
static struct usrregs_info tic6x_usrregs_info =
^
../binutils-gdb/gdb/gdbserver/linux-tic6x-low.c:186:28: note: 'usrregs_info tic6x_usrregs_info' previously declared here
static struct usrregs_info tic6x_usrregs_info;
^
gdb/gdbserver:
2017-11-16 Yao Qi <yao.qi@linaro.org>
* linux-tic6x-low.c (tic6x_fill_gregset): Cast buf.
(tic6x_store_gregset): Likewise.
(tic6x_usrregs_info): Move it up.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] GDBserver: Fix ignored Ctrl-C after reconnection
@ 2017-11-16 16:44 sergiodj+buildbot
2017-11-16 22:39 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-16 16:44 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e849ea896bcdc3da8caff02eb6dc91dc85dd8a7e ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: e849ea896bcdc3da8caff02eb6dc91dc85dd8a7e
GDBserver: Fix ignored Ctrl-C after reconnection
This fixes the issue reported by Dmitry Antipov <dantipov@nvidia.com>
here:
https://sourceware.org/ml/gdb/2017-10/msg00048.html
The problem is that GDBserver stops listening to Ctrl-C/interrupt
requests if you disconnect and reconnect back.
Dmitry wrote:
~~~
Currently gdbserver installs SIGIO handler just once, in
initialize_async_io() called from captured_main(), and this handler is
removed when remote_desc is closed in remote_close(). Next, when a
new instance of remote_desc is fetched from accept() and has '\003'
arrived, input_interrupt() is never called because it is not
registered as SIGIO handler.
~~~
The fix here is not remove the SIGIO handler in the first place, thus
going back to the original before-first-connection state.
(I haven't gone back to try it, but I think this was a regression
caused by commit 8b2073398477 ("[GDBserver] Block and unblock SIGIO"),
which was what made remote_close remove the signal handler.)
New test included.
gdb/gdbserver/ChangeLog:
2017-11-16 Pedro Alves <palves@redhat.com>
* remote-utils.c (remote_close): Block SIGIO signals instead of
uninstalling the SIGIO handler.
gdb/testsuite/ChangeLog:
2017-11-16 Pedro Alves <palves@redhat.com>
* gdb.server/reconnect-ctrl-c.c: New file.
* gdb.server/reconnect-ctrl-c.exp: New file.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add new AArch64 FP16 FM{A|S} instructions.
@ 2017-11-16 18:53 sergiodj+buildbot
2017-11-17 4:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-16 18:53 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d0f7791c6659081f3a62e220289417c010997baa ***
Author: Tamar Christina <tamar.christina@arm.com>
Branch: master
Commit: d0f7791c6659081f3a62e220289417c010997baa
Add new AArch64 FP16 FM{A|S} instructions.
This patch separates the new FP16 instructions backported from Armv8.4-a to Armv8.2-a
into a new flag order to distinguish them from the rest of the already existing optional
FP16 instructions in Armv8.2-a.
The new flag "+fp16fml" is available from Armv8.2-a and implies +fp16 and is mandatory on
Armv8.4-a.
gas/
* config/tc-aarch64.c (fp16fml): New.
* doc/c-aarch64.texi (fp16fml): New.
* testsuite/gas/aarch64/armv8_2-a-crypto-fp16.d (fp16): Make fp16fml.
* testsuite/gas/aarch64/armv8_3-a-crypto-fp16.d (fp16): Make fp16fml.
include/
* opcode/aarch64.h: (AARCH64_FEATURE_F16_FML): New.
(AARCH64_ARCH_V8_4): Enable AARCH64_FEATURE_F16_FML by default.
opcodes/
* aarch64-tbl.h (aarch64_feature_fp_16_v8_2): Require AARCH64_FEATURE_F16_FML
and AARCH64_FEATURE_F16.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix testing gdb.rust/modules.exp against gdbserver
@ 2017-11-16 20:25 sergiodj+buildbot
2017-11-17 9:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-16 20:25 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ea04e54ca8b935b01155c3d40381d879dd6ba683 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: ea04e54ca8b935b01155c3d40381d879dd6ba683
Fix testing gdb.rust/modules.exp against gdbserver
Currently several tests in gdb.rust/modules.exp fail with
--target_board=native-gdbserver:
Running src/gdb/testsuite/gdb.rust/modules.exp ...
FAIL: gdb.rust/modules.exp: call f3()
FAIL: gdb.rust/modules.exp: call self::f2()
FAIL: gdb.rust/modules.exp: call self::super::f2()
FAIL: gdb.rust/modules.exp: call super::f2()
FAIL: gdb.rust/modules.exp: call self::super::super::f2()
FAIL: gdb.rust/modules.exp: call super::super::f2()
FAIL: gdb.rust/modules.exp: call ::f2()
FAIL: gdb.rust/modules.exp: call extern modules::mod1::f2()
This is because these tests rely on matching inferior output.
However, when testing with gdbserver, inferior output goes to a
separate terminal instead of to gdb's terminal, and so gdb_test won't
cut it, as that is only reading from gdb's pty/gdb_spawn_id:
(gdb) call f3()
(gdb) FAIL: gdb.rust/modules.exp: call f3()
call self::f2()
(gdb) FAIL: gdb.rust/modules.exp: call self::f2()
Fix this by using gdb_test_stdio instead, which handles output coming
out of gdbserver's pty.
Also, skip the tests if the target/board doesn't support inferior I/O
at all.
gdb/ChangeLog:
2017-11-16 Pedro Alves <palves@redhat.com>
* gdb.rust/modules.exp: Skip tests that rely on inferior I/O if
gdb,noinferiorio is set, and use gdb_test_stdio otherwise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb/inflow.c: Move SIGTTOU temporary ignoring to a RAII class
@ 2017-11-16 21:11 sergiodj+buildbot
2017-11-17 10:51 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-16 21:11 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e2c33ac745108550dcc2dc61d23378fb2fa9e911 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: e2c33ac745108550dcc2dc61d23378fb2fa9e911
gdb/inflow.c: Move SIGTTOU temporary ignoring to a RAII class
I expect to use this in more places (in inflow.c) in follow up
patches, but I think this is still good on its own.
gdb/ChangeLog:
2017-11-16 Pedro Alves <palves@redhat.com>
* inflow.c (scoped_ignore_sigttou): New class.
(child_terminal_ours_1, new_tty): Use it.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Don't ever Quit out of resume
@ 2017-11-16 23:37 sergiodj+buildbot
2017-11-17 14:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-16 23:37 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d930703d68ae160ddfe8ebe5fdcf416fb6090e1e ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: d930703d68ae160ddfe8ebe5fdcf416fb6090e1e
Don't ever Quit out of resume
If you have a breakpoint command that re-resumes the target, like:
break foo
commands
> c
> end
and then let the inferior run, hitting the breakpoint, and then press
Ctrl-C at just the right time, between GDB processing the stop at
"foo", and re-resuming the target, you'll hit the QUIT call in
infrun.c:resume.
With this hack, we can reproduce the bad case consistently:
--- a/gdb/inf-loop.c
+++ b/gdb/inf-loop.c
@@ -31,6 +31,8 @@
#include "top.h"
#include "observer.h"
+bool continue_hack;
+
/* General function to handle events in the inferior. */
void
@@ -64,6 +66,8 @@ inferior_event_handler (enum inferior_event_type event_type,
{
check_frame_language_change ();
+ continue_hack = true;
+
/* Don't propagate breakpoint commands errors. Either we're
stopping or some command resumes the inferior. The user will
be informed. */
diff --git a/gdb/infrun.c b/gdb/infrun.c
index d425664..c74b14c 100644
--- a/gdb/infrun.c
+++ b/gdb/infrun.c
@@ -2403,6 +2403,10 @@ resume (enum gdb_signal sig)
gdb_assert (!tp->stop_requested);
gdb_assert (!thread_is_in_step_over_chain (tp));
+ extern bool continue_hack;
+
+ if (continue_hack)
+ set_quit_flag ();
QUIT;
The GDB backtrace looks like this:
(top-gdb) bt
...
#3 0x0000000000612e8b in throw_quit(char const*, ...) (fmt=0xaf84a1 "Quit") at src/gdb/common/common-exceptions.c:408
#4 0x00000000007fc104 in quit() () at src/gdb/utils.c:748
#5 0x00000000006a79d2 in default_quit_handler() () at src/gdb/event-top.c:954
#6 0x00000000007fc134 in maybe_quit() () at src/gdb/utils.c:762
#7 0x00000000006f66a3 in resume(gdb_signal) (sig=GDB_SIGNAL_0) at src/gdb/infrun.c:2406
#8 0x0000000000700c3d in keep_going_pass_signal(execution_control_state*) (ecs=0x7ffcf3744e60) at src/gdb/infrun.c:7793
#9 0x00000000006f5fcd in start_step_over() () at src/gdb/infrun.c:2145
#10 0x00000000006f7b1f in proceed(unsigned long, gdb_signal) (addr=18446744073709551615, siggnal=GDB_SIGNAL_DEFAULT)
at src/gdb/infrun.c:3135
#11 0x00000000006ebdd4 in continue_1(int) (all_threads=0) at src/gdb/infcmd.c:842
#12 0x00000000006ec097 in continue_command(char*, int) (args=0x0, from_tty=0) at src/gdb/infcmd.c:938
#13 0x00000000004b5140 in do_cfunc(cmd_list_element*, char*, int) (c=0x2d18570, args=0x0, from_tty=0)
at src/gdb/cli/cli-decode.c:106
#14 0x00000000004b8219 in cmd_func(cmd_list_element*, char*, int) (cmd=0x2d18570, args=0x0, from_tty=0)
at src/gdb/cli/cli-decode.c:1952
#15 0x00000000007f1532 in execute_command(char*, int) (p=0x7ffcf37452b1 "", from_tty=0) at src/gdb/top.c:608
#16 0x00000000004bd127 in execute_control_command(command_line*) (cmd=0x3a88ef0) at src/gdb/cli/cli-script.c:485
#17 0x00000000005cae0c in bpstat_do_actions_1(bpstat*) (bsp=0x37edcf0) at src/gdb/breakpoint.c:4513
#18 0x00000000005caf67 in bpstat_do_actions() () at src/gdb/breakpoint.c:4563
#19 0x00000000006e8798 in inferior_event_handler(inferior_event_type, void*) (event_type=INF_EXEC_COMPLETE, client_data=0x0)
at src/gdb/inf-loop.c:72
#20 0x00000000006f9447 in fetch_inferior_event(void*) (client_data=0x0) at src/gdb/infrun.c:3970
#21 0x00000000006e870e in inferior_event_handler(inferior_event_type, void*) (event_type=INF_REG_EVENT, client_data=0x0)
at src/gdb/inf-loop.c:43
#22 0x0000000000494d58 in remote_async_serial_handler(serial*, void*) (scb=0x3585ca0, context=0x2cd1b80)
at src/gdb/remote.c:13820
#23 0x000000000044d682 in run_async_handler_and_reschedule(serial*) (scb=0x3585ca0) at src/gdb/ser-base.c:137
#24 0x000000000044d767 in fd_event(int, void*) (error=0, context=0x3585ca0) at src/gdb/ser-base.c:188
#25 0x00000000006a5686 in handle_file_event(file_handler*, int) (file_ptr=0x45997d0, ready_mask=1)
at src/gdb/event-loop.c:733
#26 0x00000000006a5c29 in gdb_wait_for_event(int) (block=1) at src/gdb/event-loop.c:859
#27 0x00000000006a4aa6 in gdb_do_one_event() () at src/gdb/event-loop.c:347
#28 0x00000000006a4ade in start_event_loop() () at src/gdb/event-loop.c:371
and when that happens, you end up with GDB's run control in quite a
messed up state. Something like this:
thread_function1 (arg=0x1) at threads.c:107
107 usleep (SLEEP); /* Loop increment. */
Quit
(gdb) c
Continuing.
** nothing happens, time passes..., press ctrl-c again **
^CQuit
(gdb) info threads
Id Target Id Frame
1 Thread 1462.1462 "threads" (running)
* 2 Thread 1462.1466 "threads" (running)
3 Thread 1462.1465 "function0" (running)
(gdb) c
Cannot execute this command while the selected thread is running.
(gdb)
The first "Quit" above is thrown from within "resume", and cancels run
control while GDB is in the middle of stepping over a breakpoint.
with step_over_info_valid_p() true. The next "c" didn't actually
resume anything, because GDB throught that the step-over was still in
progress. It wasn't, because the thread that was supposed to be
stepping over the breakpoint wasn't actually resumed.
So at this point, we press Ctrl-C again, and this time, the default
quit handler is called directly from the event loop
(event-top.c:default_quit_handler -> quit()), because gdb was left
owning the terminal (because the previous resume was cancelled before
we reach target_resume -> target_terminal::inferior()).
Note that the exception called from within resume ends up calling
normal_stop via resume_cleanups. That's very borked though, because
normal_stop is going to re-handle whatever was the last reported
event, possibly even re-running a hook stop... I think that the only
sane way to safely cancel the run control state machinery is to push
an event via handle_inferior_event like all other events.
The fix here does two things, and either alone would fix the problem
at hand:
#1 - passes the terminal to the inferior earlier, so that any QUIT
call from the point we declare the target as running goes to the
inferior directly, protecting run control from unsafe QUIT calls.
#2 - gets rid of this QUIT call in resume and of its related unsafe
resume_cleanups.
Aboout #2, the comment describing resume says:
/* Resume the inferior, but allow a QUIT. This is useful if the user
wants to interrupt some lengthy single-stepping operation
(for child processes, the SIGINT goes to the inferior, and so
we get a SIGINT random_signal, but for remote debugging and perhaps
other targets, that's not true).
but that's a really old comment that predates a lot of fixes to Ctrl-C
handling throughout both GDB core and the remote target, that made
sure that a Ctrl-C isn't ever lost. In any case, if some target
depended on this, a much better fix would be to make the target return
a SIGINT stop out of target_wait the next time that is called.
This was exposed by the new gdb.base/bp-cmds-continue-ctrl-c.exp
testcase added later in the series.
gdb/ChangeLog:
2017-11-16 Pedro Alves <palves@redhat.com>
* infrun.c (resume_cleanups): Delete.
(resume): No longer install a resume_cleanups cleanup nor call
QUIT.
(proceed): Pass the terminal to the inferior.
(keep_going_pass_signal): No longer install a resume_cleanups
cleanup.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Test breakpoint commands w/ "continue" + Ctrl-C
@ 2017-11-16 23:48 sergiodj+buildbot
2017-11-17 17:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-16 23:48 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a0922d80dff15d4fbd5d469f56bcd1696846b90a ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: a0922d80dff15d4fbd5d469f56bcd1696846b90a
Test breakpoint commands w/ "continue" + Ctrl-C
This adds the testcase that exposed the multiple problems with Ctrl-C
handling fixed by the previous patches, when run against both native
and gdbserver GNU/Linux.
gdb/ChangeLog:
2017-11-16 Pedro Alves <palves@redhat.com>
* gdb.base/bp-cmds-continue-ctrl-c.c: New file.
* gdb.base/bp-cmds-continue-ctrl-c.exp: New file.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: Pass "%F%P:" to linker callback in case of error
@ 2017-11-17 12:33 sergiodj+buildbot
2017-11-17 19:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-17 12:33 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2c244f9b0935e577d7c20bb5706e27438e48227f ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 2c244f9b0935e577d7c20bb5706e27438e48227f
x86: Pass "%F%P:" to linker callback in case of error
We should pass "%F%P:" to linker callback in case of error. Otherwise,
linker will report:
: failed to create GNU property section
* elfxx-x86.c (_bfd_x86_elf_link_setup_gnu_properties): Pass
"%F%P:", instead of "%F:", to linker callback in case of error.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Make output_thread_groups take an std::vector<int>
@ 2017-11-17 18:49 sergiodj+buildbot
2017-11-17 22:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-17 18:49 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 5c632425957f0150a0d5d1e747f0425f74622132 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 5c632425957f0150a0d5d1e747f0425f74622132
Make output_thread_groups take an std::vector<int>
A simple replacement of VEC with std::vector.
gdb/ChangeLog:
* breakpoint.c (output_thread_groups): Take an std::vector.
(print_one_breakpoint_location): Adjust.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Handle dereferencing Rust trait objects
@ 2017-11-17 22:05 sergiodj+buildbot
2017-11-18 4:21 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-17 22:05 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 71a3c36949407eafea744bf00334c4e0c136f927 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 71a3c36949407eafea744bf00334c4e0c136f927
Handle dereferencing Rust trait objects
In Rust, virtual tables work a bit differently than they do in C++. In
C++, as you know, they are connected to a particular class hierarchy.
Rust, instead, can generate a virtual table for potentially any type --
in fact, one such virtual table for each trait (a trait is similar to an
abstract class or to a Java interface) that a type implements.
Objects that are referenced via a trait can't currently be inspected by
gdb. This patch implements the Rust equivalent of "set print object".
gdb relies heavily on the C++ ABI to decode virtual tables; primarily to
make "set print object" work; but also "info vtbl". However, Rust does
not currently have a specified ABI, so this approach seems unwise to
emulate.
Instead, I've changed the Rust compiler to emit some DWARF that
describes trait objects (previously their internal structure was
opaque), vtables (currently just a size -- but I hope to expand this in
the future), and the concrete type for which a vtable was emitted.
The concrete type is expressed as a DW_AT_containing_type on the
vtable's type. This is a small extension to DWARF.
This patch adds a new entry to quick_symbol_functions to return the
symtab that holds a data address. Previously there was no way in gdb to
look up a full (only minimal) non-text symbol by address. The psymbol
implementation of this method works by lazily filling in a map that is
added to the objfile. This avoids slowing down psymbol reading for a
feature that is likely to not be used too frequently.
I did not update .gdb_index. My thinking here is that the DWARF 5
indices will obsolete .gdb_index soon-ish, meaning that adding a new
feature to them is probably wasted work. If necessary I can update the
DWARF 5 index code when it lands in gdb.
Regression tested on x86-64 Fedora 25.
2017-11-17 Tom Tromey <tom@tromey.com>
* symtab.h (struct symbol) <is_rust_vtable>: New member.
(struct rust_vtable_symbol): New.
(find_symbol_at_address): Declare.
* symtab.c (find_symbol_at_address): New function.
* symfile.h (struct quick_symbol_functions)
<find_compunit_symtab_by_address>: New member.
* symfile-debug.c (debug_qf_find_compunit_symtab_by_address): New
function.
(debug_sym_quick_functions): Link to
debug_qf_find_compunit_symtab_by_address.
* rust-lang.c (rust_get_trait_object_pointer): New function.
(rust_evaluate_subexp) <case UNOP_IND>: New case. Call
rust_get_trait_object_pointer.
* psymtab.c (psym_relocate): Clear psymbol_map.
(psym_fill_psymbol_map, psym_find_compunit_symtab_by_address): New
functions.
(psym_functions): Link to psym_find_compunit_symtab_by_address.
* objfiles.h (struct objfile) <psymbol_map>: New member.
* dwarf2read.c (dwarf2_gdb_index_functions): Update.
(process_die) <DW_TAG_variable>: New case. Call read_variable.
(rust_containing_type, read_variable): New functions.
2017-11-17 Tom Tromey <tom@tromey.com>
* gdb.rust/traits.rs: New file.
* gdb.rust/traits.exp: New file.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix error message typo.
@ 2017-11-19 1:27 sergiodj+buildbot
2017-11-19 2:38 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-19 1:27 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 671275c35e71d3bcdde173d8817e34e89b984241 ***
Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 671275c35e71d3bcdde173d8817e34e89b984241
Fix error message typo.
bfd/
* elfnn-riscv.c (_bfd_riscv_relax_align): Add space between alignment
and to in error message.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove usage of find_inferior in win32-i386-low.c
@ 2017-11-20 3:48 sergiodj+buildbot
2017-11-20 4:42 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-20 3:48 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 0b360f1926cb15edc39c661dac2f1a433fb288c0 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 0b360f1926cb15edc39c661dac2f1a433fb288c0
Remove usage of find_inferior in win32-i386-low.c
Straightforward replacement of find_inferior with the overload of
for_each_thread that filters on pid. I am able to build-test this
patch, but not run it.
gdb/gdbserver/ChangeLog:
* win32-i386-low.c (update_debug_registers_callback): Rename
to ...
(update_debug_registers): ... this, return void, remove pid_p arg.
(x86_dr_low_set_addr, x86_dr_low_set_control): Use for_each_thread.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove usage of find_thread when calling resume_status_pending_p
@ 2017-11-20 8:34 sergiodj+buildbot
2017-11-20 19:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-20 8:34 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 25c28b4d153ced950cc8702aafb054d6f14f6a02 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 25c28b4d153ced950cc8702aafb054d6f14f6a02
Remove usage of find_thread when calling resume_status_pending_p
Replace with find_thread. Instead of setting the flag in the callback,
make the callback return true/false, and check the result against NULL
in the caller.
gdb/gdbserver/ChangeLog:
* linux-low.c (resume_status_pending_p): Return bool, remove
flag_p argument.
(linux_resume): Use find_thread.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove usage of find_inferior when calling kill_one_lwp_callback
@ 2017-11-20 10:03 sergiodj+buildbot
2017-11-20 21:27 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-20 10:03 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 578290ecafb83e93f0ac695df586b65dac5e8c5d ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 578290ecafb83e93f0ac695df586b65dac5e8c5d
Remove usage of find_inferior when calling kill_one_lwp_callback
Replace with for_each_thread.
gdb/gdbserver/ChangeLog:
* linux-low.c (kill_one_lwp_callback): Return void, take
argument directly, don't filter on pid.
(linux_kill): Use for_each_thread.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] 0xff chars in name components table; cp-name-parser lex UTF-8 identifiers
@ 2017-11-21 0:29 sergiodj+buildbot
2017-11-21 2:22 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-21 0:29 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e1ef7d7a5166f846b14bea5a77acb0dec76661a8 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: e1ef7d7a5166f846b14bea5a77acb0dec76661a8
0xff chars in name components table; cp-name-parser lex UTF-8 identifiers
The find-upper-bound-for-completion algorithm in the name components
accelerator table in dwarf2read.c increments a char in a string, and
asserts that it's not incrementing a 0xff char, but that's incorrect.
First, we shouldn't be calling gdb_assert on input.
Then, if "char" is signed, comparing a caracther with "0xff" will
never yield true, which is caught by Clang with:
error: comparison of constant 255 with expression of type '....' (aka 'char') is always true [-Werror,-Wtautological-constant-out-of-range-compare]
gdb_assert (after.back () != 0xff);
~~~~~~~~~~~~~ ^ ~~~~
And then, 0xff is a valid character on non-UTF-8/ASCII character sets.
E.g., it's '' in Latin1. While GCC nor Clang support !ASCII &&
!UTF-8 characters in identifiers (GCC supports UTF-8 characters only
via UCNs, see https://gcc.gnu.org/onlinedocs/cpp/Character-sets.html),
but other compilers might (Visual Studio?), so it doesn't hurt to
handle it correctly. Testing is covered by extending the
dw2_expand_symtabs_matching unit tests with relevant cases.
However, without further changes, the unit tests still fail... The
problem is that cp-name-parser.y assumes that identifiers are ASCII
(via ISALPHA/ISALNUM). This commit fixes that too, so that we can
unit test the dwarf2read.c changes. (The regular C/C++ lexer in
c-lang.y needs a similar treatment, but I'm leaving that for another
patch.)
While doing this, I noticed a thinko in the computation of the upper
bound for completion in dw2_expand_symtabs_matching_symbol. We're
using std::upper_bound but we should use std::lower_bound. I extended
the unit test with a case that I thought would expose it, this one:
+ /* These are used to check that the increment-last-char in the
+ matching algorithm for completion doesn't match "t1_fund" when
+ completing "t1_func". */
+ "t1_func",
+ "t1_func1",
+ "t1_fund",
+ "t1_fund1",
The algorithm actually returns "t1_fund1" as lower bound, so "t1_fund"
matches incorrectly. But turns out the problem is masked because
later here:
for (;lower != upper; ++lower)
{
const char *qualified = index.symbol_name_at (lower->idx);
if (!lookup_name_matcher.matches (qualified)
the lookup_name_matcher.matches check above filters out "t1_fund"
because that doesn't start with "t1_func".
I'll fix the latent bug in follow up patches, after factoring things
out a bit in a way that allows unit testing the relevant code more
directly.
gdb/ChangeLog:
2017-11-21 Pedro Alves <palves@redhat.com>
* cp-name-parser.y (cp_ident_is_alpha, cp_ident_is_alnum): New.
(symbol_end): Use cp_ident_is_alnum.
(yylex): Use cp_ident_is_alpha and cp_ident_is_alnum.
* dwarf2read.c (make_sort_after_prefix_name): New function.
(dw2_expand_symtabs_matching_symbol): Use it.
(test_symbols): Add more symbols.
(run_test): Add tests.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Unit test name-component bounds searching directly
@ 2017-11-21 1:02 sergiodj+buildbot
2017-11-21 3:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-21 1:02 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 5c58de74c9acb346513c974fcdede270be2a77c3 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 5c58de74c9acb346513c974fcdede270be2a77c3
Unit test name-component bounds searching directly
This commit factors out the name-components-vector building and bounds
searching out of dw2_expand_symtabs_matching_symbol into separate
functions, and adds unit tests that:
- expose both the latent bug mentioned in the previous commit, and
also,
- for completeness exercise the 0xff character handling fixed in the
previous commit more directly.
The actual fix for the now-exposed bug is left for the following
patch.
gdb/ChangeLog:
2017-11-21 Pedro Alves <palves@redhat.com>
* dwarf2read.c (mapped_index::name_components_casing): New field.
(mapped_index) <build_name_components,
find_name_components_bounds): Declare new methods.
(mapped_index::find_name_components_bounds)
(mapped_index::build_name_components): New methods, factored out
from dw2_expand_symtabs_matching_symbol.
(check_find_bounds_finds)
(test_mapped_index_find_name_component_bounds): New.
(run_test): Rename to ...
(test_dw2_expand_symtabs_matching_symbol): ... this.
(run_test): Reimplement.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix mapped_index::find_name_components_bounds upper bound computation
@ 2017-11-21 2:07 sergiodj+buildbot
2017-11-21 4:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-21 2:07 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e6b2f5efa97c7f3de8a3947c6782c40ec6172686 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: e6b2f5efa97c7f3de8a3947c6782c40ec6172686
Fix mapped_index::find_name_components_bounds upper bound computation
Here we want to find where we'd insert "after", so we want
std::lower_bound, not std::upper_bound.
gdb/ChangeLog:
2017-11-21 Pedro Alves <palves@redhat.com>
* dwarf2read.c (mapped_index::find_name_components_bounds)
<completion mode, upper bound>: Use std::lower_bound instead of
std::upper_bound.
(test_mapped_index_find_name_component_bounds): Remove incorrect
"t1_fund" from expected symbols.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix build failure in darwin-nat.c
@ 2017-11-21 4:54 sergiodj+buildbot
2017-11-21 7:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-21 4:54 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 0fc7642151cc5e62f05ac8ea91fe4d5b44bee11a ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 0fc7642151cc5e62f05ac8ea91fe4d5b44bee11a
Fix build failure in darwin-nat.c
Fix:
/Users/simark/src/binutils-gdb/gdb/darwin-nat.c:2404:3: error: no matching function for call to 'add_setshow_boolean_cmd'
add_setshow_boolean_cmd ("mach-exceptions", class_support,
^~~~~~~~~~~~~~~~~~~~~~~
gdb/ChangeLog:
* darwin-nat.c (set_enable_mach_exceptions): Constify parameter.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] [PowerPC] Detect different long double floating-point formats
@ 2017-11-21 18:08 sergiodj+buildbot
2017-11-21 19:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-21 18:08 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ed0f427344d0befead629d9267aecd01bfb72721 ***
Author: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Branch: master
Commit: ed0f427344d0befead629d9267aecd01bfb72721
[PowerPC] Detect different long double floating-point formats
Current versions of GCC support switching the format used for "long double"
to either IBM double double or IEEE-128. The resulting binary is marked
via different setting of the Tag_GNU_Power_ABI_FP GNU attribute.
This patch checks this attribute to detect the format of the default
"long double" type and sets GDB's notion of the format accordingly.
The patch also adds support for the "__ibm128" type, which always uses
IBM double double format independent of the format used for "long double".
A new test case verifies that all three types, "long double", "__float128",
and "__ibm128" are correctly detected in all three compiler settings,
the default setting, -mabi=ieeelongdouble, and -mabi=ibmlongdouble.
gdb/ChangeLog:
2017-11-21 Ulrich Weigand <uweigand@de.ibm.com>
* ppc-tdep.h (enum powerpc_long_double_abi): New data type.
(struct gdbarch_tdep): New member long_double_abi.
* rs6000-tdep.c (rs6000_gdbarch_init): Initialize long_double_abi
member of tdep struct based on Tag_GNU_Power_ABI_FP attribute.
* ppc-linux-tdep.c (ppc_linux_init_abi): Install long double data
format depending on long_double_abi tdep member.
(ppc_floatformat_for_type): Handle __ibm128 type.
gdb/testsuite/ChangeLog:
2017-11-21 Ulrich Weigand <uweigand@de.ibm.com>
* gdb.arch/ppc-longdouble.exp: New file.
* gdb.arch/ppc-longdouble.c: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add multiple-CPU support in ravenscar-thread.c
@ 2017-11-22 0:26 sergiodj+buildbot
2017-11-22 1:57 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-22 0:26 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9edcc12f9b714149f84bcf20dbdad91f030e62de ***
Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 9edcc12f9b714149f84bcf20dbdad91f030e62de
Add multiple-CPU support in ravenscar-thread.c
This patch reworks the ravenscar-thread layer to remove the
assumption that the target only has 1 CPU. In particular,
when connected to a QEMU target over the remote protocol,
QEMU reports each CPU as one thread. This patch adapts
the ravenscar-thread layer to this, and adds a large comment
explaining the general design of this unit.
gdb/ChangeLog:
* ada-lang.h (ada_get_task_info_from_ptid): Add declaration.
* ada-tasks.c (ada_get_task_info_from_ptid): New function.
* ravenscar-thread.c: Add into comment.
(base_magic_null_ptid): Delete.
(base_ptid): Change documentation.
(ravenscar_active_task): Renames ravenscar_running_thread.
All callers updated throughout.
(is_ravenscar_task, ravenscar_get_thread_base_cpu): New function.
(ravenscar_task_is_currently_active): Likewise.
(get_base_thread_from_ravenscar_task): Ditto.
(ravenscar_update_inferior_ptid): Adjust to handle multiple CPUs.
(ravenscar_runtime_initialized): Likewise.
(get_running_thread_id): Add new parameter "cpu". Adjust
implementation to handle this new parameter.
(ravenscar_fetch_registers): Small adjustment to use
is_ravenscar_task and ravenscar_task_is_currently_active in
order to decide whether to use the target beneath or this
module's arch_ops.
(ravenscar_store_registers, ravenscar_prepare_to_store): Likewise.
(ravenscar_stopped_by_sw_breakpoint): Use
get_base_thread_from_ravenscar_task to get the underlying
thread, rather than using base_ptid.
(ravenscar_stopped_by_hw_breakpoint, ravenscar_stopped_by_watchpoint)
(ravenscar_stopped_data_address, ravenscar_core_of_thread):
Likewise.
(ravenscar_inferior_created): Do not set base_magic_null_ptid.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] problem debugging ravenscar programs if runtime is stripped
@ 2017-11-22 1:10 sergiodj+buildbot
2017-11-22 3:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-22 1:10 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT cf3fbed4a00e668ffcad1b878eccec87334fdcff ***
Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: cf3fbed4a00e668ffcad1b878eccec87334fdcff
problem debugging ravenscar programs if runtime is stripped
Trying to debug a program using a stripped version of the ravenscar
runtime, we can get the following error:
(gdb) cont
Continuing.
Cannot find Ada_Task_Control_Block type. Aborting
This is because the ravenscar-thread layer makes the assumption that
the runtime is built the way we expect it, meaning that the Ada tasking
units we rely on for Ada tasking debugging, are built with debugging
information, and that this debug information has not been stripped from
the runtime.
When this assumption is not true, resuming such a program can trigger
the error above, which then leads GDB a little confused. For instance,
we can see things like:
(gdb) bt
Target is executing.
This patch fixes the issue by disabling the ravenscar thread layer
if we detect that the runtime is missing some of the debugging info
we need in order to support Ada task debugging. This is the best
we can do, as the ravenscar-thread layer actually depends on the
ada-tasks layer to implement thread debugging.
gdb/ChangeLog:
* ada-lang.h (ada_get_tcb_types_info): Add declaration.
* ada-tasks.c (ada_get_tcb_types_info): Renames get_tcb_types_info.
Make non-static. Change return type to char *. Adjust code
accordingly. Rewrite the function's documentation.
(read_atcb): Adjust call to get_tcb_types_info accordingly.
* ravenscar-thread.c (ravenscar_inferior_created): Check that
we have enough debugging information in the runtime to support
Ada task debugging before we enable the ravenscar-thread layer.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] (Ada) crash connecting to TSIM simulator
@ 2017-11-22 1:50 sergiodj+buildbot
2017-11-22 4:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-22 1:50 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 54aa6c67f5a0d52dabd428cc40ce02781032acd3 ***
Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 54aa6c67f5a0d52dabd428cc40ce02781032acd3
(Ada) crash connecting to TSIM simulator
Connecting to a TSIM simulator over the remote protocol causes GDB
to crash with the following failed assertion:
(gdb) tar remote :1234
Remote debugging using :1234
/[...]/gdb/ravenscar-thread.c:182: internal-error: ravenscar_update_inferior_ptid: Assertion `!is_ravenscar_task (inferior_ptid)' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Quit this debugging session? (y or n) y
What happens is the following. Upon connection to the target, GDB
sends a 'qfThreadInfo' query, which is the query asking the target
for the ID of the first thread, and TSIM replies 'm0':
Sending packet: $qfThreadInfo#bb...Ack
Packet received: m0
As a result of this, GDB takes the '0' as the TID, and because of it,
constructs a ptid whose value is {42000, 0, 0}. This trips our
!is_ravenscar_task check, because all it does to identify threads
corresponding to ravenscar tasks is that their lwp is null, because
that's how we construct their ptid.
But this is unfortunatly not sufficient when debugging with TSIM,
because the thread ID that TSIM returns causes the creation of
a ptid whose lwp is zero, which matches the current identification
scheme and yet is clearly not a ravenscar task.
The fix is to also make sure that the ptid's tid field is nonzero.
gdb/ChangeLog:
* ravenscar-thread.c (is_ravenscar_task): Also verify that
the ptid's TID is nonzero.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix build with GCC 8: strncpy -> memcpy
@ 2017-11-22 12:42 sergiodj+buildbot
2017-11-22 13:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-22 12:42 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 29f9a5673764c1b2711c0ceeba380a6ee764d1b2 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 29f9a5673764c1b2711c0ceeba380a6ee764d1b2
Fix build with GCC 8: strncpy -> memcpy
Recent gcc 8 trunk emits the warning below,
../../../binutils-gdb/gdb/gdbserver/remote-utils.c:1204:14: error: char* strncpy(char*, const char*, size_t) output truncated before terminating nul copying 6 bytes from a string of the same length [-Werror=stringop-truncation]
strncpy (buf, "watch:", 6);
~~~~~~~~^~~~~~~~~~~~~~~~~~
../../binutils-gdb/gdb/cli/cli-decode.c:1118:15: error: char* strncpy(char*, const char*, size_t) specified bound depends on the length of the source argument [-Werror=stringop-overflow=]
strncpy (cmdtype1 + 1, cmdtype, len - 1);
~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../binutils-gdb/gdb/cli/cli-decode.c:1110:16: note: length computed here
len = strlen (cmdtype);
~~~~~~~^~~~~~~~~
../../binutils-gdb/gdb/cli/cli-decode.c:1120:15: error: char* strncpy(char*, const char*, size_t) specified bound depends on the length of the source argument [-Werror=stringop-overflow=]
strncpy (cmdtype2, cmdtype, len - 1);
~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../binutils-gdb/gdb/cli/cli-decode.c:1110:16: note: length computed here
len = strlen (cmdtype);
~~~~~~~^~~~~~~~~
../../binutils-gdb/gdb/cp-namespace.c:1071:11: error: char* strncpy(char*, const char*, size_t) output truncated before terminating nul copying 2 bytes from a string of the same length [-Werror=stringop-truncation]
strncpy (full_name + scope_length, "::", 2);
~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This patch fixes it by using memcpy instead of strncpy.
gdb:
2017-11-22 Yao Qi <yao.qi@linaro.org>
* cli/cli-decode.c (help_list): Use memcpy instead of strncpy.
* cp-namespace.c (cp_lookup_transparent_type_loop): Likewise.
gdb/gdbserver:
2017-11-22 Yao Qi <yao.qi@linaro.org>
* remote-utils.c (prepare_resume_reply): Use memcpy.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Target FP: Make use of MPFR if available
@ 2017-11-22 15:10 sergiodj+buildbot
2017-11-22 17:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-22 15:10 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2400729ecfd2c7be8b18aeaa822fef5a4b503f8a ***
Author: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Branch: master
Commit: 2400729ecfd2c7be8b18aeaa822fef5a4b503f8a
Target FP: Make use of MPFR if available
This second patch introduces mfpr_float_ops, an new implementation
of target_float_ops. This implements precise emulation of target
floating-point formats using the MPFR library. This is then used
to perform operations on types that do not match any host type.
Note that use of MPFR is still not required. The patch adds
a configure option --with-mpfr similar to --with-expat. If use of
MPFR is disabled via the option or MPFR is not available, code will
fall back to current behavior. This means that operations on types
that do not match any host type will be implemented on the host
long double type instead.
A new test case verifies that we can correctly print the largest
__float128 value now.
gdb/ChangeLog:
2017-11-22 Ulrich Weigand <uweigand@de.ibm.com>
* NEWS: Document use of GNU MPFR.
* README: Likewise.
* Makefile.in (LIBMPFR): Add define.
(CLIBS): Add $(LIBMPFR).
* configure.ac: Add --with-mpfr configure option.
* configure: Regenerate.
* config.in: Regenerate.
* target-float.c [HAVE_LIBMPFR]: Include <mpfr.h>.
(class mpfr_float_ops): New type.
(mpfr_float_ops::from_target): Two new overloaded functions.
(mpfr_float_ops::to_target): Likewise.
(mpfr_float_ops::to_string): New function.
(mpfr_float_ops::from_string): Likewise.
(mpfr_float_ops::to_longest): Likewise.
(mpfr_float_ops::from_longest): Likewise.
(mpfr_float_ops::from_ulongest): Likewise.
(mpfr_float_ops::to_host_double): Likewise.
(mpfr_float_ops::from_host_double): Likewise.
(mpfr_float_ops::convert): Likewise.
(mpfr_float_ops::binop): Likewise.
(mpfr_float_ops::compare): Likewise.
(get_target_float_ops): Use mpfr_float_ops if available.
gdb/doc/ChangeLog:
2017-11-22 Ulrich Weigand <uweigand@de.ibm.com>
* gdb.texinfo (Requirements): Document use of GNU MPFR.
gdb/testsuite/ChangeLog:
2017-11-22 Ulrich Weigand <uweigand@de.ibm.com>
* gdb.base/float128.c (large128): New variable.
* gdb.base/float128.exp: Add test to print largest __float128 value.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] [testsuite] Pass -pie in ldflags
@ 2017-11-22 16:24 sergiodj+buildbot
2017-11-22 19:38 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-22 16:24 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT dc196b230b7366683799755b4461acef5cc95be7 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: dc196b230b7366683799755b4461acef5cc95be7
[testsuite] Pass -pie in ldflags
-pie is a linker flag, it should be passed via "ldflags", instead
of "additional_flags". Otherwise, clang complains,
clang: warning: argument unused during compilation: '-pie'
gdb/testsuite:
2017-11-22 Yao Qi <yao.qi@linaro.org>
* gdb.base/attach-pie-noexec.exp: Pass "-pie" in ldflags.
* gdb.base/break-interp.exp: Likewise.
* gdb.base/jit-attach-pie.exp: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] [testsuite] Don't skip gdb.dwarf2/pr10770.exp for non-gcc compiler
@ 2017-11-22 17:05 sergiodj+buildbot
2017-11-22 22:05 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-22 17:05 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 88465e872cb6649c42863e5c47011bae9e17bbdb ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 88465e872cb6649c42863e5c47011bae9e17bbdb
[testsuite] Don't skip gdb.dwarf2/pr10770.exp for non-gcc compiler
gdb.dwarf2/pr10770.exp can be used for non-gcc compiler, at least clang.
This patch removes the restriction to only use gcc. If other compilers,
like xlc or icc, can't compile the .c file, test result is not changed.
gdb/testsuite:
2017-11-22 Yao Qi <yao.qi@linaro.org>
* gdb.dwarf2/pr10770.exp: Remove code skipping non-gcc
compiler.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] [testsuite] Pass pthreads in prepare_for_testing
@ 2017-11-22 17:26 sergiodj+buildbot
2017-11-22 23:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-22 17:26 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 1daad298d699383bb4f35aa919a1acfa0ab8e16c ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 1daad298d699383bb4f35aa919a1acfa0ab8e16c
[testsuite] Pass pthreads in prepare_for_testing
"pthreads" in the right flag to pass in prepare_for_testing to linker,
instead of additional_flags. Without this patch, the test case can't be
complied by clang.
gdb compile failed, clang: warning: -lpthread: 'linker' input unused
gdb/testsuite:
2017-11-22 Yao Qi <yao.qi@linaro.org>
* gdb.base/info-os.exp: Pass pthreads.
* gdb.multi/multi-attach.exp: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove obsolete core-regset.c
@ 2017-11-22 20:23 sergiodj+buildbot
2017-11-23 0:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-22 20:23 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT fc35dab1a62541858cab1c82aebc6cd166e39f5b ***
Author: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Branch: master
Commit: fc35dab1a62541858cab1c82aebc6cd166e39f5b
Remove obsolete core-regset.c
The last target that used core-regset.c (FreeBSD/alpha) has been
removed with GDB 8.0, and since then this file is obsolete.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Show optimized out local variables in "info locals"
@ 2017-11-22 22:42 sergiodj+buildbot
2017-11-23 8:08 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-22 22:42 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 41bd68f52c05f5654bed49f312f6562c8d048897 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 41bd68f52c05f5654bed49f312f6562c8d048897
Show optimized out local variables in "info locals"
Currently, optimized out variables are not shown when doing "info
locals". Some users found that confusing, thinking GDB forgot to print
their variable. This patch adds them to the "info locals" output. I
added a test in gdb.dwarf2 to test for that behavior. I think doing a
synthetic DWARF test is the easiest way to have an optimized out local
variable for sure.
However, this change reveals what I think is a bug in GDB, see:
http://lists.dwarfstd.org/pipermail/dwarf-discuss-dwarfstd.org/2017-September/004394.html
This patch marks the tests in inline-locals.exp that start failing as
KFAIL. I'd like to tackle this bug eventually, but I don't have the
time right now. I think it's still better to show an extra erroneous
entry than to not show the optimized out variables at all. I haven't
created a bug in bugzilla yet, but if we agree it's indeed a bug, I'll
create one and update the setup_kfail lines with the actual bug number
before pushing.
gdb/ChangeLog:
* stack.c (iterate_over_block_locals): Add LOC_OPTIMIZED_OUT
case in switch.
gdb/testsuite/ChangeLog:
* gdb.opt/inline-locals.exp: Mark tests as KFAIL.
* gdb.dwarf2/info-locals-optimized-out.exp: New file.
* gdb.dwarf2/info-locals-optimized-out.c: New file.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] C++ify osdata
@ 2017-11-22 23:03 sergiodj+buildbot
2017-11-23 9:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-22 23:03 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 479f8de1b3b7e69ca8d557bbe9d843c7d1bc89c5 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 479f8de1b3b7e69ca8d557bbe9d843c7d1bc89c5
C++ify osdata
This patch c++ifies the osdata structure: osdata_column, osdata_item and
osdata. char* are replaced with std::string and VEC are replaced with
std::vector. This allows to get rid of a great deal of cleanup and
free'ing code.
I replaced the splay tree in list_available_thread_groups with an
std::map. Unless there's a good advantage to keep using a splay tree,
I think using the standard type should make things simpler to
understand.
gdb/ChangeLog:
* osdata.h: Include vector isntead of vec.h.
(osdata_column_s): Remove typedef.
(struct osdata_column): Add constructor.
<name, value>: Change type to std::string.
(DEF_VEC_O (osdata_column_s)): Remove.
(osdata_item_s): Remove typedef.
(struct osdata_item) <columns>: Change type to std::vector.
(DEF_VEC_O (osdata_item_s)): Remove.
(struct osdata): Add constructor.
<type>: Change type to std::string.
<items>: Change type to std::vector.
(osdata_p): Remove typedef.
(DEF_VEC_P (osdata_p)): Remove.
(osdata_parse): Return a unique_ptr.
(osdata_free): Remove.
(make_cleanup_osdata_free): Remove.
(get_osdata): Return a unique_ptr.
(get_osdata_column): Return pointer to std::string, take a
reference to osdata_item as parameter.
* osdata.c (struct osdata_parsing_data) <osdata>: Change type to
unique_ptr.
<property_name>: Change type to std::string.
(osdata_start_osdata): Allocate osdata with new and adjust.
(osdata_start_item): Adjust.
(osdata_start_column): Adjust.
(osdata_end_column): Adjust.
(clear_parsing_data): Remove.
(osdata_parse): Return a unique_ptr and adjust, remove cleanup.
(osdata_item_clear): Remove.
(get_osdata): return a unique_ptr and adjust.
(get_osdata_column): Return a pointer to std::string and adjust.
(info_osdata): Adjust.
* mi/mi-main.c: Include <map>.
(free_vector_of_osdata_items): Remove.
(list_available_thread_groups): Adjust, use std::map instead of
splay tree.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Rename u.weakdef and make it a circular list
@ 2017-11-23 13:28 sergiodj+buildbot
2017-11-23 17:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-23 13:28 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 60d67dc84bbc7d73672d297d714f8a4a0547618d ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 60d67dc84bbc7d73672d297d714f8a4a0547618d
Rename u.weakdef and make it a circular list
This makes the elf_link_hash_entry weakdef field, currently used to
point from a weak symbol to a strong alias, a circular list so that
all aliases can be found from any of them. A new flag, is_weakalias,
distinguishes the weak symbol from a strong alias, and is used in all
places where we currently test u.weakdef != NULL.
With the original u.weakdef handling it was possible to have two or
more weak symbols pointing via u.weakdef to a strong definition.
Obviously that situation can't map to a circular list; One or more of
the weak symbols must point at another weak alias rather than the
strong definition. To handle that, I've added an accessor function to
return the strong definition.
* elf-bfd.h (struct elf_link_hash_entry): Add is_weakalias.
Rename u.weakdef to u.alias and update comment.
(weakdef): New static inline function.
* elflink.c (bfd_elf_record_link_assignment) Test is_weakalias
rather than u.weakdef != NULL, and use weakdef function.
(_bfd_elf_adjust_dynamic_symbol): Likewise.
(_bfd_elf_fix_symbol_flags): Likewise. Clear is_weakalias on
all aliases if def has been overridden in a regular object, not
u.weakdef.
(elf_link_add_object_symbols): Delete new_weakdef flag. Test
is_weakalias and use weakdef. Set is_weakalias and circular
u.alias. Update comments.
(_bfd_elf_gc_mark_rsec): Test is_weakalias rather than
u.weakdef != NULL and use weakdef function.
* elf-m10300.c (_bfd_mn10300_elf_adjust_dynamic_symbol): Test
is_weakalias rather than u.weakdef != NULL and use weakdef
function. Assert that def is strong defined.
* elf32-arc.c (elf_arc_adjust_dynamic_symbol): Likewise.
* elf32-arm.c (elf32_arm_adjust_dynamic_symbol): Likewise.
* elf32-bfin.c (elf32_bfinfdpic_adjust_dynamic_symbol): Likewise.
(bfin_adjust_dynamic_symbol): Likewise.
* elf32-cr16.c (_bfd_cr16_elf_adjust_dynamic_symbol): Likewise.
* elf32-cris.c (elf_cris_adjust_dynamic_symbol): Likewise.
* elf32-frv.c (elf32_frvfdpic_adjust_dynamic_symbol): Likewise.
* elf32-hppa.c (elf32_hppa_adjust_dynamic_symbol): Likewise.
* elf32-i370.c (i370_elf_adjust_dynamic_symbol): Likewise.
* elf32-lm32.c (lm32_elf_adjust_dynamic_symbol): Likewise.
* elf32-m32r.c (m32r_elf_adjust_dynamic_symbol): Likewise.
* elf32-m68k.c (elf_m68k_adjust_dynamic_symbol): Likewise.
* elf32-metag.c (elf_metag_adjust_dynamic_symbol): Likewise.
* elf32-microblaze.c (microblaze_elf_adjust_dynamic_symbol): Likewise.
* elf32-nds32.c (nds32_elf_adjust_dynamic_symbol): Likewise.
* elf32-nios2.c (nios2_elf32_adjust_dynamic_symbol): Likewise.
* elf32-or1k.c (or1k_elf_adjust_dynamic_symbol): Likewise.
* elf32-ppc.c (ppc_elf_adjust_dynamic_symbol): Likewise.
* elf32-s390.c (elf_s390_adjust_dynamic_symbol): Likewise.
* elf32-score.c (s3_bfd_score_elf_adjust_dynamic_symbol): Likewise.
* elf32-score7.c (s7_bfd_score_elf_adjust_dynamic_symbol): Likewise.
* elf32-sh.c (sh_elf_adjust_dynamic_symbol): Likewise.
* elf32-tic6x.c (elf32_tic6x_adjust_dynamic_symbol): Likewise.
* elf32-tilepro.c (tilepro_elf_gc_mark_hook): Likewise.
(tilepro_elf_adjust_dynamic_symbol): Likewise.
* elf32-vax.c (elf_vax_adjust_dynamic_symbol): Likewise.
* elf32-xtensa.c (elf_xtensa_adjust_dynamic_symbol): Likewise.
* elf64-alpha.c (elf64_alpha_adjust_dynamic_symbol): Likewise.
* elf64-hppa.c (elf64_hppa_adjust_dynamic_symbol): Likewise.
* elf64-ia64-vms.c (elf64_ia64_adjust_dynamic_symbol): Likewise.
* elf64-ppc.c (ppc64_elf_gc_mark_hook): Likewise.
(ppc64_elf_adjust_dynamic_symbol): Likewise.
* elf64-s390.c (elf_s390_adjust_dynamic_symbol): Likewise.
* elf64-sh64.c (sh64_elf64_adjust_dynamic_symbol): Likewise.
* elfnn-aarch64.c (elfNN_aarch64_adjust_dynamic_symbol): Likewise.
* elfnn-ia64.c (elfNN_ia64_adjust_dynamic_symbol): Likewise.
* elfnn-riscv.c (riscv_elf_adjust_dynamic_symbol): Likewise.
* elfxx-mips.c (_bfd_mips_elf_adjust_dynamic_symbol): Likewise.
* elfxx-sparc.c (_bfd_sparc_elf_gc_mark_hook): Likewise.
(_bfd_sparc_elf_adjust_dynamic_symbol): Likewise.
* elfxx-tilegx.c (tilegx_elf_gc_mark_hook): Likewise.
(tilegx_elf_adjust_dynamic_symbol): Likewise.
* elfxx-x86.c (_bfd_x86_elf_adjust_dynamic_symbol): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Revert unexpected rename in previous patch
@ 2017-11-23 19:54 sergiodj+buildbot
2017-11-24 1:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-23 19:54 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT bd046f64a193405f2fef2d5120fab4be25feaa8b ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: bd046f64a193405f2fef2d5120fab4be25feaa8b
Revert unexpected rename in previous patch
While working on the previous patch, I renamed variables whose type I
changed to let the compiler help me find their usages, but I forgot to
rename one back to its original name. This patch fixes it.
gdb/ChangeLog:
* varobj.c (struct varobj_dynamic) <children_requested_>: Rename
back to...
<children_requested>: ... this.
(varobj_get_num_children, varobj_update): Adjust.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: don't omit disambiguating suffixes from "fi*"
@ 2017-11-24 8:04 sergiodj+buildbot
2017-11-24 8:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-24 8:04 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ac465521a50102d589a6a05a1e722dfa349d3181 ***
Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: ac465521a50102d589a6a05a1e722dfa349d3181
x86: don't omit disambiguating suffixes from "fi*"
"fi*" typically come in two (loads/stores: three) flavors, distinguished
by the suffix. Don't omit the 's' one when disassembling.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Change tic6x target descriptions
@ 2017-11-24 9:50 sergiodj+buildbot
2017-11-24 10:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-24 9:50 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 506fe5f4996738f25b7c26f126a84b231429ba95 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 506fe5f4996738f25b7c26f126a84b231429ba95
Change tic6x target descriptions
This patch changes tic6x target descriptions to be more flexible. Rebuild
tic6x-uclinux GDBserver with my x86 g++, and the unit test passes.
gdb:
2017-11-24 Yao Qi <yao.qi@linaro.org>
* arch/tic6x.c: New file.
* arch/tic6x.h: New file.
* features/Makefile (FEATURE_XMLFILES): Add tic6x-c6xp.xml,
tic6x-core.xml and tic6x-gp.xml.
* features/tic6x-c6xp.c: Generated.
* features/tic6x-core.c: Generated.
* features/tic6x-gp.c: Generated.
* target-descriptions.c (maint_print_c_tdesc_cmd): Match
"tic6x-".
gdb/gdbserver:
2017-11-24 Yao Qi <yao.qi@linaro.org>
* configure.srv: Set $srv_regobj for tic6x-linux.
* linux-tic6x-low.c: Include "arch/tic6x.h" and "tdesc.h".
(tic6x_read_description): Move some code to tic6x_arch_setup.
(tic6x_tdesc_test): New function.
(initialize_low_arch): Call selftests::register_test.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Change value_contents_eq return bool
@ 2017-11-24 11:34 sergiodj+buildbot
2017-11-24 12:54 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-24 11:34 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 98ead37e9735438986934f9f1f35f020a093fe07 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 98ead37e9735438986934f9f1f35f020a093fe07
Change value_contents_eq return bool
This patch changes value_contents_eq return type from int to bool.
gdb:
2017-11-24 Yao Qi <yao.qi@linaro.org>
* mi/mi-main.c (register_changed_p): Update.
* value.c (value_contents_bits_eq): Change return type.
(value_contents_eq): Likewise.
* value.h: Update comments.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add aarch64_create_target_description
@ 2017-11-24 12:40 sergiodj+buildbot
2017-11-24 14:08 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-24 12:40 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT da434ccbc3e0ed843700790cd16c1d4bb5882460 ***
Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: da434ccbc3e0ed843700790cd16c1d4bb5882460
Add aarch64_create_target_description
gdb/
* Makefile.in: Add new files.
* aarch64-linux-nat.c (aarch64_linux_read_description): Call
aarch64_read_description.
* aarch64-linux-tdep.c (aarch64_linux_core_read_description):
Call aarch64_read_description.
* aarch64-tdep.c (aarch64_read_description): New function.
(aarch64_gdbarch_init): Call aarch64_read_description.
* aarch64-tdep.h (aarch64_read_description): New function.
* arch/aarch64.c: New file.
* configure.tgt: Add new files.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Use flexible target descriptors for aarch64
@ 2017-11-24 13:09 sergiodj+buildbot
2017-11-24 16:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-24 13:09 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 49bdb7ee48a10581e9f7254782f2eb953c4a164b ***
Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: 49bdb7ee48a10581e9f7254782f2eb953c4a164b
Use flexible target descriptors for aarch64
gdb/
* aarch64-tdep.c (_initialize_aarch64_tdep): Remove init.
* arch/aarch64.c (aarch64_create_target_description): Create
new target description.
* features/Makefile: Add new files.
* features/aarch64.c: Remove file.
* features/aarch64-core.c: New autogenerated file.
* features/aarch64-fpu.c: New autogenerated file.
* target-descriptions.c (maint_print_c_tdesc_cmd): Check for aarch64.
gdbserver/
* linux-aarch64-ipa.c (initialize_low_tracepoint): Remove init.
* linux-aarch64-low.c (initialize_low_arch): Remove init.
* linux-aarch64-tdesc.c (aarch64_linux_read_description): Add init.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] regcache::cooked_read unit test
@ 2017-11-24 14:23 sergiodj+buildbot
2017-11-24 19:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-24 14:23 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 1b30aaa56607a563fa263b9d2ee9eba89d79c1b4 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 1b30aaa56607a563fa263b9d2ee9eba89d79c1b4
regcache::cooked_read unit test
This patch adds a unit test to regcache::cooked_read. This unit test is a
little different from normal unit test, it is more about conformance test
or interaction test. This test pass both raw register number and pseudo
register number to regcache::cooked_read, in order to inspect 1) return
value of cooked_read, 2) how are target_ops to_xfer_partial,
to_{fetch,store}_registers called (because regcache is updated by means of
these three target_ops methods). With this test here, we have a clear
picture about how each port of GDB get cooked registers.
This patch also shares some code on mock target.
gdb:
2017-11-24 Yao Qi <yao.qi@linaro.org>
* gdbarch-selftests.c (test_target_has_registers): Move it to
target.c.
(test_target_has_stack): Likewise.
(test_target_has_memory): Likewise.
(test_target_prepare_to_store): Likewise.
(test_target_store_registers): Likewise.
(test_target_ops): Likewise.
* regcache.c: Include selftest-arch.h and gdbthread.h.
(target_ops_no_register): New class.
(test_target_fetch_registers): New.
(test_target_store_registers): New.
(test_target_xfer_partial): New.
(readwrite_regcache): New.
(cooked_read_test): New.
(_initialize_regcache): Register the test.
* target.c: (test_target_has_registers): Moved from
gdbarch-selftests.c.
(test_target_has_stack): Likewise.
(test_target_has_memory): Likewise.
(test_target_prepare_to_store): Likewise.
(test_target_store_registers): Likewise.
* target.h (test_target_ops): New class.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add xml selftests for aarch64 target description.
@ 2017-11-24 14:52 sergiodj+buildbot
2017-11-24 17:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-24 14:52 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 6654d750c7c584dd83b93f062c5628f15c675480 ***
Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: 6654d750c7c584dd83b93f062c5628f15c675480
Add xml selftests for aarch64 target description.
gdb/
* aarch64-tdep.c (_initialize_aarch64_tdep): Add target desc
selftest.
gdbserver/
* configure.srv: Add linux-aarch64-tdesc-selftest.o.
* linux-aarch64-low.c (initialize_low_arch): Call init func.
* linux-aarch64-tdesc-selftest.c: New file.
* linux-aarch64-tdesc.h (initialize_low_tdesc): New declaration.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] elf: Properly compute offsets of note descriptor and next note
@ 2017-11-24 16:34 sergiodj+buildbot
2017-11-24 21:44 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-24 16:34 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 650444eb540f9fd85e821567a3f943b4bc41b8be ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 650444eb540f9fd85e821567a3f943b4bc41b8be
elf: Properly compute offsets of note descriptor and next note
According to gABI, in a note entry, the note name field, not note name
size, is padded for the note descriptor. And the note descriptor field,
not note descriptor size, is padded for the next note entry. Also notes
are aligned to 4 bytes in 32-bit objects and 8 bytes in 64-bit objects.
Since on Linux, .note.ABI-tag and .note.gnu.build-id notes are always
aligned to 4 bytes, we need to use alignment of note section or note
segment, instead of assuming alignment based on ELF file class.
Tested on i686 and x86-64.
bfd/
PR binutils/22444
* elf.c (elf_read_notes): Add an argument for note aligment.
(elf_parse_notes): Likewise.
(_bfd_elf_make_section_from_shdr): Pass section aligment to
elf_parse_notes.
(bfd_section_from_phdr): Pass segment aligment to elf_read_notes.
(elf_parse_notes): Add an argument for note aligment. Use
ELF_NOTE_DESC_OFFSET to get the offset of the note descriptor.
Use ELF_NOTE_NEXT_OFFSET to get the offset of the next note
entry.
(elf_read_notes): Add an argument for note aligment and pass it
to elf_parse_notes.
binutils/
PR binutils/22444
* readelf.c (process_notes_at): Use ELF_NOTE_DESC_OFFSET to get
the offset of the note descriptor. Use ELF_NOTE_NEXT_OFFSET to
get the offset of the next note entry.
include/
PR binutils/22444
* elf/external.h (ELF_ALIGN_UP): New.
(ELF_NOTE_DESC_OFFSET): Likewise.
(ELF_NOTE_NEXT_OFFSET): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master
2017-11-24 16:34 [binutils-gdb] elf: Properly compute offsets of note descriptor and next note sergiodj+buildbot
@ 2017-11-24 21:44 ` sergiodj+buildbot
0 siblings, 0 replies; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-24 21:44 UTC (permalink / raw)
To: gdb-testers
Buildslave:
ubuntu-trusty-aarch32-1
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-native-gdbserver-m32/builds/2184>
Commit(s) tested:
650444eb540f9fd85e821567a3f943b4bc41b8be
Author(s) (in the same order as the commits):
H.J. Lu <hjl.tools@gmail.com>
Subject:
elf: Properly compute offsets of note descriptor and next note
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-native-gdbserver-m32/65/650444eb540f9fd85e821567a3f943b4bc41b8be/>
*** Diff to previous build ***
============================
PASS -> FAIL: gdb.arch/i386-biarch-core.exp: load core file
PASS -> FAIL: gdb.arch/i386-biarch-core.exp: .text is readable
PASS -> FAIL: gdb.base/auxv.exp: load core file for info auxv on gcore-created dump
PASS -> FAIL: gdb.base/auxv.exp: info auxv on gcore-created dump
PASS -> FAIL: gdb.base/auxv.exp: matching auxv data from live and gcore
PASS -> FAIL: gdb.base/coredump-filter.exp: loading and testing corefile for non-Private-Anonymous: load core
new FAIL: gdb.base/coredump-filter.exp: loading and testing corefile for non-Private-Anonymous: loading /home/qiyao/buildbot/ubuntu-aarch32-native-gdbserver-m32/build/gdb/testsuite/outputs/gdb.base/coredump-filter/non-private-anon.gcore
PASS -> FAIL: gdb.base/coredump-filter.exp: disassembling function main for non-Private-Anonymous: no binary: load core
new FAIL: gdb.base/coredump-filter.exp: disassembling function main for non-Private-Anonymous: no binary: loading /home/qiyao/buildbot/ubuntu-aarch32-native-gdbserver-m32/build/gdb/testsuite/outputs/gdb.base/coredump-filter/non-private-anon.gcore
PASS -> FAIL: gdb.base/coredump-filter.exp: loading and testing corefile for non-Shared-Anonymous: load core
new FAIL: gdb.base/coredump-filter.exp: loading and testing corefile for non-Shared-Anonymous: loading /home/qiyao/buildbot/ubuntu-aarch32-native-gdbserver-m32/build/gdb/testsuite/outputs/gdb.base/coredump-filter/non-shared-anon.gcore
PASS -> FAIL: gdb.base/coredump-filter.exp: disassembling function main for non-Shared-Anonymous: no binary: load core
new FAIL: gdb.base/coredump-filter.exp: disassembling function main for non-Shared-Anonymous: no binary: loading /home/qiyao/buildbot/ubuntu-aarch32-native-gdbserver-m32/build/gdb/testsuite/outputs/gdb.base/coredump-filter/non-shared-anon.gcore
PASS -> FAIL: gdb.base/coredump-filter.exp: loading and testing corefile for DoNotDump: load core
new FAIL: gdb.base/coredump-filter.exp: loading and testing corefile for DoNotDump: loading /home/qiyao/buildbot/ubuntu-aarch32-native-gdbserver-m32/build/gdb/testsuite/outputs/gdb.base/coredump-filter/dont-dump.gcore
PASS -> FAIL: gdb.base/coredump-filter.exp: disassembling function main for DoNotDump: no binary: load core
new FAIL: gdb.base/coredump-filter.exp: disassembling function main for DoNotDump: no binary: loading /home/qiyao/buildbot/ubuntu-aarch32-native-gdbserver-m32/build/gdb/testsuite/outputs/gdb.base/coredump-filter/dont-dump.gcore
PASS -> FAIL: gdb.base/coredump-filter.exp: loading and testing corefile for non-Private-Shared-Anon-File: no binary: load core
new FAIL: gdb.base/coredump-filter.exp: loading and testing corefile for non-Private-Shared-Anon-File: no binary: loading /home/qiyao/buildbot/ubuntu-aarch32-native-gdbserver-m32/build/gdb/testsuite/outputs/gdb.base/coredump-filter/non-private-shared-anon-file.gcore
PASS -> FAIL: gdb.base/gcore.exp: re-load generated corefile
PASS -> FAIL: gdb.base/gcore-relro.exp: re-load generated corefile
PASS -> FAIL: gdb.base/gcore-relro.exp: library got loaded
PASS -> FAIL: gdb.base/gcore-relro-pie.exp: re-load generated corefile
PASS -> FAIL: gdb.base/gcore-relro-pie.exp: x/i $pc
PASS -> FAIL: gdb.base/gcore-relro-pie.exp: unstripped + core ok
PASS -> FAIL: gdb.base/info-proc.exp: core info-proc.gcore
PASS -> FAIL: gdb.base/info-proc.exp: info proc mapping with core file
PASS -> FAIL: gdb.base/print-symbol-loading.exp: core off: re-load generated corefile
PASS -> FAIL: gdb.base/print-symbol-loading.exp: core off: library got loaded
PASS -> FAIL: gdb.base/print-symbol-loading.exp: core brief: re-load generated corefile
PASS -> FAIL: gdb.base/print-symbol-loading.exp: core brief: library got loaded
PASS -> FAIL: gdb.base/print-symbol-loading.exp: core full: re-load generated corefile
PASS -> FAIL: gdb.base/print-symbol-loading.exp: core full: load shared-lib
PASS -> FAIL: gdb.base/print-symbol-loading.exp: core full: library got loaded
PASS -> FAIL: gdb.base/siginfo-obj.exp: core siginfo-obj.gcore
PASS -> FAIL: gdb.base/siginfo-obj.exp: p $_siginfo.si_signo from core file
PASS -> FAIL: gdb.base/siginfo-obj.exp: p $_siginfo.si_errno from core file
PASS -> FAIL: gdb.base/siginfo-obj.exp: p $_siginfo.si_code from core file
PASS -> FAIL: gdb.base/siginfo-obj.exp: p $_siginfo._sifields._sigfault.si_addr from core file
PASS -> FAIL: gdb.base/siginfo-thread.exp: core siginfo-thread.gcore
PASS -> FAIL: gdb.base/siginfo-thread.exp: p $_siginfo.si_signo from core file
PASS -> FAIL: gdb.base/siginfo-thread.exp: p $_siginfo.si_errno from core file
PASS -> FAIL: gdb.base/siginfo-thread.exp: p $_siginfo.si_code from core file
PASS -> FAIL: gdb.base/siginfo-thread.exp: p $_siginfo._sifields._sigfault.si_addr from core file
PASS -> FAIL: gdb.base/siginfo-thread.exp: update counter in thread 1
PASS -> FAIL: gdb.base/siginfo-thread.exp: update counter in thread 2
PASS -> FAIL: gdb.base/siginfo-thread.exp: print $count
PASS -> FAIL: gdb.base/solib-search.exp: re-load generated corefile
PASS -> FAIL: gdb.base/vdso-warning.exp: core: startup
PASS -> FAIL: gdb.reverse/break-precsave.exp: reload precord save file
PASS -> FAIL: gdb.reverse/break-precsave.exp: continue to breakpoint: foo
PASS -> FAIL: gdb.reverse/break-precsave.exp: continue to breakpoint: bar
PASS -> FAIL: gdb.reverse/break-precsave.exp: go to end of main forward
PASS -> FAIL: gdb.reverse/break-precsave.exp: set reverse
PASS -> FAIL: gdb.reverse/break-precsave.exp: continue to breakpoint: bar backward
PASS -> FAIL: gdb.reverse/break-precsave.exp: continue to breakpoint: foo backward
PASS -> FAIL: gdb.reverse/break-precsave.exp: main backward
PASS -> FAIL: gdb.reverse/break-precsave.exp: set forward
PASS -> FAIL: gdb.reverse/break-precsave.exp: end of record log
PASS -> FAIL: gdb.reverse/consecutive-precsave.exp: reload precord save file
PASS -> FAIL: gdb.reverse/consecutive-precsave.exp: continue to breakpoint in foo
PASS -> FAIL: gdb.reverse/consecutive-precsave.exp: get breakpoint address for foo
PASS -> FAIL: gdb.reverse/consecutive-precsave.exp: set bp, 2nd instr
PASS -> FAIL: gdb.reverse/consecutive-precsave.exp: stopped at bp, 2nd instr
PASS -> FAIL: gdb.reverse/consecutive-precsave.exp: set reverse execution
PASS -> FAIL: gdb.reverse/consecutive-precsave.exp: stopped at bp in reverse, 1st instr
PASS -> FAIL: gdb.reverse/finish-precsave.exp: reload precord save file
PASS -> FAIL: gdb.reverse/finish-precsave.exp: continue to breakpoint: void_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: finish from void_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: continue to breakpoint: char_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: finish from char_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: continue to breakpoint: short_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: finish from short_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: continue to breakpoint: int_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: finish from int_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: continue to breakpoint: long_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: finish from long_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: continue to breakpoint: long_long_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: finish from long_long_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: set reverse execution
PASS -> FAIL: gdb.reverse/finish-precsave.exp: reverse finish from long_long_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: reverse finish from long_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: reverse finish from int_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: reverse finish from short_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: reverse finish from char_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: reverse finish from void_func
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: reload prec save file
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: go to end of main forward
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: reverse to 85
new FAIL: gdb.reverse/machinestate-precsave.exp: step
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: module global forward past bp
new FAIL: gdb.reverse/machinestate-precsave.exp: reverse-step
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: reverse to 71
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: module static forward
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: reverse to 57
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: function static reverse-breakpoint
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: function static forward
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: function static reverse-step
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: reverse to 45
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: auto var reverse-breakpoint
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: auto var forward
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: auto var reverse-step
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: reverse to 33
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: register var reverse-breakpoint
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: register var step post-change
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: register var reverse step-to
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: reverse to main
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: forward to 33
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: register var forward-breakpoint
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: register var forward step-to
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: forward to 45
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: auto var forward-breakpoint
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: auto var forward step-to
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: auto var step post-change
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: forward to 57
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: function static forward-breakpoint
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: function static forward step-to
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: function static step post-change
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: forward to 71
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: module static step post-change
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: forward to 85
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: module global step post-change
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reload precord save file
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: get signal ABRT
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal ABRT
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to HUP
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: get signal HUP
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal HUP
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to QUIT
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: get signal QUIT
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal QUIT
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to ILL
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: get signal ILL
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal ILL
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to EMT
new FAIL: gdb.reverse/sigall-precsave.exp: get signal EMT
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal EMT
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to FPE
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: get signal FPE
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal FPE
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to BUS
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: get signal BUS
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal BUS
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to SEGV
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: get signal SEGV
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal SEGV
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to SYS
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: get signal SYS
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal SYS
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to PIPE
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: get signal PIPE
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal PIPE
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to ALRM
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: get signal ALRM
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal ALRM
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to URG
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: get signal URG
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal URG
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to TSTP
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: get signal TSTP
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal TSTP
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to CONT
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: get signal CONT
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal CONT
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to CHLD
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: get signal CHLD
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal CHLD
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to TTIN
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: get signal TTIN
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal TTIN
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to TTOU
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: get signal TTOU
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal TTOU
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to IO
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: get signal IO
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal IO
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to XCPU
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: get signal XCPU
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal XCPU
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to XFSZ
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: get signal XFSZ
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal XFSZ
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to VTALRM
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: get signal VTALRM
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal VTALRM
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to PROF
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: get signal PROF
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal PROF
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to WINCH
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: get signal WINCH
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal WINCH
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to LOST
new FAIL: gdb.reverse/sigall-precsave.exp: get signal LOST
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal LOST
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to USR1
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: get signal USR1
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal USR1
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to USR2
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: get signal USR2
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal USR2
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to PWR
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: get signal PWR
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal PWR
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to POLL
new FAIL: gdb.reverse/sigall-precsave.exp: get signal POLL
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal POLL
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to WIND
new FAIL: gdb.reverse/sigall-precsave.exp: get signal WIND
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal WIND
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to PHONE
new FAIL: gdb.reverse/sigall-precsave.exp: get signal PHONE
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal PHONE
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to WAITING
new FAIL: gdb.reverse/sigall-precsave.exp: get signal WAITING
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal WAITING
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to LWP
new FAIL: gdb.reverse/sigall-precsave.exp: get signal LWP
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal LWP
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to DANGER
new FAIL: gdb.reverse/sigall-precsave.exp: get signal DANGER
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal DANGER
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to GRANT
new FAIL: gdb.reverse/sigall-precsave.exp: get signal GRANT
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal GRANT
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to RETRACT
new FAIL: gdb.reverse/sigall-precsave.exp: get signal RETRACT
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal RETRACT
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to MSG
new FAIL: gdb.reverse/sigall-precsave.exp: get signal MSG
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal MSG
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to SOUND
new FAIL: gdb.reverse/sigall-precsave.exp: get signal SOUND
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal SOUND
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to SAK
new FAIL: gdb.reverse/sigall-precsave.exp: get signal SAK
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal SAK
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to PRIO
new FAIL: gdb.reverse/sigall-precsave.exp: get signal PRIO
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal PRIO
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to 33
new FAIL: gdb.reverse/sigall-precsave.exp: get signal 33
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal 33
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to 34
new FAIL: gdb.reverse/sigall-precsave.exp: get signal 34
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal 34
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to 35
new FAIL: gdb.reverse/sigall-precsave.exp: get signal 35
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal 35
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to 36
new FAIL: gdb.reverse/sigall-precsave.exp: get signal 36
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal 36
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to 37
new FAIL: gdb.reverse/sigall-precsave.exp: get signal 37
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal 37
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to 38
new FAIL: gdb.reverse/sigall-precsave.exp: get signal 38
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal 38
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to 39
new FAIL: gdb.reverse/sigall-precsave.exp: get signal 39
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal 39
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to 40
new FAIL: gdb.reverse/sigall-precsave.exp: get signal 40
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal 40
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to 41
new FAIL: gdb.reverse/sigall-precsave.exp: get signal 41
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal 41
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to 42
new FAIL: gdb.reverse/sigall-precsave.exp: get signal 42
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal 42
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to 43
new FAIL: gdb.reverse/sigall-precsave.exp: get signal 43
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal 43
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to 44
new FAIL: gdb.reverse/sigall-precsave.exp: get signal 44
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal 44
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to 45
new FAIL: gdb.reverse/sigall-precsave.exp: get signal 45
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal 45
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to 46
new FAIL: gdb.reverse/sigall-precsave.exp: get signal 46
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal 46
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to 47
new FAIL: gdb.reverse/sigall-precsave.exp: get signal 47
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal 47
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to 48
new FAIL: gdb.reverse/sigall-precsave.exp: get signal 48
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal 48
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to 49
new FAIL: gdb.reverse/sigall-precsave.exp: get signal 49
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal 49
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to 50
new FAIL: gdb.reverse/sigall-precsave.exp: get signal 50
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal 50
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to 51
new FAIL: gdb.reverse/sigall-precsave.exp: get signal 51
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal 51
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to 52
new FAIL: gdb.reverse/sigall-precsave.exp: get signal 52
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal 52
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to 53
new FAIL: gdb.reverse/sigall-precsave.exp: get signal 53
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal 53
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to 54
new FAIL: gdb.reverse/sigall-precsave.exp: get signal 54
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal 54
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to 55
new FAIL: gdb.reverse/sigall-precsave.exp: get signal 55
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal 55
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to 56
new FAIL: gdb.reverse/sigall-precsave.exp: get signal 56
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal 56
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to 57
new FAIL: gdb.reverse/sigall-precsave.exp: get signal 57
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal 57
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to 58
new FAIL: gdb.reverse/sigall-precsave.exp: get signal 58
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal 58
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to 59
new FAIL: gdb.reverse/sigall-precsave.exp: get signal 59
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal 59
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to 60
new FAIL: gdb.reverse/sigall-precsave.exp: get signal 60
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal 60
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to 61
new FAIL: gdb.reverse/sigall-precsave.exp: get signal 61
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal 61
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to 62
new FAIL: gdb.reverse/sigall-precsave.exp: get signal 62
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal 62
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to 63
new FAIL: gdb.reverse/sigall-precsave.exp: get signal 63
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal 63
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: advance to TERM
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: get signal TERM
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: send signal TERM
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: continue to sigall exit
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of TERM
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_TERM
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of 63
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_63
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of 62
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_62
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of 61
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_61
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of 60
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_60
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of 59
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_59
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of 58
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_58
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of 57
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_57
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of 56
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_56
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of 55
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_55
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of 54
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_54
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of 53
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_53
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of 52
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_52
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of 51
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_51
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of 50
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_50
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of 49
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_49
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of 48
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_48
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of 47
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_47
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of 46
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_46
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of 45
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_45
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of 44
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_44
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of 43
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_43
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of 42
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_42
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of 41
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_41
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of 40
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_40
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of 39
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_39
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of 38
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_38
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of 37
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_37
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of 36
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_36
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of 35
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_35
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of 34
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_34
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of 33
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_33
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of PRIO
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_PRIO
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of SAK
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_SAK
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of SOUND
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_SOUND
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of MSG
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_MSG
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of RETRACT
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_RETRACT
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of GRANT
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_GRANT
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of DANGER
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_DANGER
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of LWP
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_LWP
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of WAITING
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_WAITING
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of PHONE
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_PHONE
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of WIND
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_WIND
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of POLL
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_POLL
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of PWR
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_PWR
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of USR2
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_USR2
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of USR1
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_USR1
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of LOST
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_LOST
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of WINCH
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_WINCH
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of PROF
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_PROF
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of VTALRM
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_VTALRM
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of XFSZ
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_XFSZ
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of XCPU
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_XCPU
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of IO
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_IO
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of TTOU
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_TTOU
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of TTIN
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_TTIN
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of CHLD
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_CHLD
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of CONT
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_CONT
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of TSTP
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_TSTP
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of URG
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_URG
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of ALRM
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_ALRM
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of PIPE
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_PIPE
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of SYS
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_SYS
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of SEGV
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_SEGV
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of BUS
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_BUS
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of FPE
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_FPE
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of EMT
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_EMT
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of ILL
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_ILL
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of QUIT
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_QUIT
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of HUP
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_HUP
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to handler of ABRT
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: reverse to gen_ABRT
PASS -> FAIL: gdb.reverse/solib-precsave.exp: reload core file
PASS -> FAIL: gdb.reverse/solib-precsave.exp: run until end part one
PASS -> FAIL: gdb.reverse/solib-precsave.exp: reverse-step third shr1
PASS -> FAIL: gdb.reverse/solib-precsave.exp: reverse-step second shr1
PASS -> FAIL: gdb.reverse/solib-precsave.exp: reverse-step first shr1
PASS -> FAIL: gdb.reverse/solib-precsave.exp: reverse-step generic
PASS -> FAIL: gdb.reverse/solib-precsave.exp: forward to end part one
PASS -> FAIL: gdb.reverse/solib-precsave.exp: reverse-next third shr1
PASS -> FAIL: gdb.reverse/solib-precsave.exp: reverse-next second shr1
PASS -> FAIL: gdb.reverse/solib-precsave.exp: reverse-next first shr1
PASS -> FAIL: gdb.reverse/solib-precsave.exp: reverse-next generic
PASS -> FAIL: gdb.reverse/solib-precsave.exp: reverse-step into solib function one
PASS -> FAIL: gdb.reverse/solib-precsave.exp: reverse-step within solib function one
PASS -> FAIL: gdb.reverse/solib-precsave.exp: reverse-step back to main one
PASS -> FAIL: gdb.reverse/solib-precsave.exp: reverse-step into solib function two
PASS -> FAIL: gdb.reverse/solib-precsave.exp: reverse-step within solib function two
PASS -> FAIL: gdb.reverse/solib-precsave.exp: reverse-step back to main two
PASS -> FAIL: gdb.reverse/solib-precsave.exp: run until end part two
PASS -> FAIL: gdb.reverse/solib-precsave.exp: reverse-next over solib function one
PASS -> FAIL: gdb.reverse/solib-precsave.exp: reverse-next over solib function two
PASS -> FAIL: gdb.reverse/step-precsave.exp: reload core file
PASS -> FAIL: gdb.reverse/step-precsave.exp: next test 1
PASS -> FAIL: gdb.reverse/step-precsave.exp: step test 1
PASS -> FAIL: gdb.reverse/step-precsave.exp: next test 2
PASS -> FAIL: gdb.reverse/step-precsave.exp: step test 2
PASS -> FAIL: gdb.reverse/step-precsave.exp: step up to call
PASS -> FAIL: gdb.reverse/step-precsave.exp: next over call
PASS -> FAIL: gdb.reverse/step-precsave.exp: step into call
PASS -> FAIL: gdb.reverse/step-precsave.exp: finish out of fn call
PASS -> FAIL: gdb.reverse/step-precsave.exp: simple stepi
PASS -> FAIL: gdb.reverse/step-precsave.exp: stepi into function call
PASS -> FAIL: gdb.reverse/step-precsave.exp: stepi back from function call
PASS -> FAIL: gdb.reverse/step-precsave.exp: set reverse execution
PASS -> FAIL: gdb.reverse/step-precsave.exp: reverse stepi thru function return
PASS -> FAIL: gdb.reverse/step-precsave.exp: reverse stepi from a function call
PASS -> FAIL: gdb.reverse/step-precsave.exp: simple reverse stepi
PASS -> FAIL: gdb.reverse/step-precsave.exp: reverse step into fn call
PASS -> FAIL: gdb.reverse/step-precsave.exp: reverse step out of called fn
PASS -> FAIL: gdb.reverse/step-precsave.exp: reverse next over call
PASS -> FAIL: gdb.reverse/step-precsave.exp: reverse step test 1
PASS -> FAIL: gdb.reverse/step-precsave.exp: reverse next test 1
PASS -> FAIL: gdb.reverse/step-precsave.exp: reverse step test 2
PASS -> FAIL: gdb.reverse/step-precsave.exp: reverse next test 2
PASS -> FAIL: gdb.reverse/until-precsave.exp: reload core file
PASS -> FAIL: gdb.reverse/until-precsave.exp: until line number
PASS -> FAIL: gdb.reverse/until-precsave.exp: advance to factorial
PASS -> FAIL: gdb.reverse/until-precsave.exp: until factorial, recursive function
PASS -> FAIL: gdb.reverse/until-precsave.exp: finish to main
PASS -> FAIL: gdb.reverse/until-precsave.exp: advance to marker2
PASS -> FAIL: gdb.reverse/until-precsave.exp: until func, not called by current frame
PASS -> FAIL: gdb.reverse/until-precsave.exp: set reverse execution
PASS -> FAIL: gdb.reverse/until-precsave.exp: reverse-advance to marker2
PASS -> FAIL: gdb.reverse/until-precsave.exp: reverse-finish from marker2
PASS -> FAIL: gdb.reverse/until-precsave.exp: reverse-advance to final return of factorial
PASS -> FAIL: gdb.reverse/until-precsave.exp: reverse-until to entry of factorial
PASS -> FAIL: gdb.reverse/watch-precsave.exp: reload core file
PASS -> FAIL: gdb.reverse/watch-precsave.exp: continue to breakpoint: marker1
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit, first time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit, second time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit, third time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit, fourth time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit, fifth time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: continue to breakpoint: marker2
PASS -> FAIL: gdb.reverse/watch-precsave.exp: set reverse
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit in reverse, first time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit in reverse, second time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit in reverse, third time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit in reverse, fourth time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit in reverse, fifth time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: set forward
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit, forward replay, first time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit, forward replay, second time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit, forward replay, third time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit, forward replay, fourth time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit, forward replay, fifth time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: replay forward to marker2
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit in reverse, HW, first time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit in reverse, HW, second time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit in reverse, HW, third time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit in reverse, HW, fourth time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit in reverse, HW, fifth time
PASS -> FAIL: gdb.threads/gcore-thread.exp: corefile: re-load generated corefile
PASS -> FAIL: gdb.threads/gcore-thread.exp: core0file: re-load generated corefile
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
PASS -> FAIL: gdb.threads/tls-core.exp: load generated corefile
============================
*** Complete list of XFAILs for this builder ***
To obtain the list of XFAIL tests for this builder, go to:
<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch32-native-gdbserver-m32/xfails/master/xfail;hb=>
You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:
<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch32-native-gdbserver-m32/xfails/master/xfail.table;hb=>
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove dead code in regcache::dump
@ 2017-11-24 17:40 sergiodj+buildbot
2017-11-24 23:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-24 17:40 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e8d58cbaacb9ca54ad32eee1a38301202e09f878 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: e8d58cbaacb9ca54ad32eee1a38301202e09f878
Remove dead code in regcache::dump
footnote_register_size in regcache::dump is a constant zero, so the
condition check against footnote_register_size is dead code. The code
writing to footnote_register_size was removed by 01e1877.
This patche removes footnote_register_size and the dead code.
gdb:
2017-11-24 Yao Qi <yao.qi@linaro.org>
* regcache.c (regcache::dump): Remove footnote_register_size.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] remote: C++ify thread_item and threads_listing_context
@ 2017-11-24 20:00 sergiodj+buildbot
2017-11-25 3:55 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-24 20:00 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 21fe1c752e254167d953fa8c846280f63a3a5290 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 21fe1c752e254167d953fa8c846280f63a3a5290
remote: C++ify thread_item and threads_listing_context
This patch C++ifies the thread_item and threads_listing_context
structures in remote.c. thread_item::{extra,name} are changed to
std::string. As a result, there's a bit of awkwardness in
remote_update_thread_list, where we have to xstrdup those strings when
filling the private_thread_info structure. This is removed in the
following patch, where private_thread_info is also C++ified and its
corresponding fields made std::string too. The xstrdup then becomes an
std::move.
Other than that there's nothing really special, it's a usual day-to-day
VEC -> vector and char* -> std::string change. It allows removing a
cleanup in remote_update_thread_list.
Note that an overload of hex2bin that returns a gdb::byte_vector is
added, with corresponding selftests.
gdb/ChangeLog:
* remote.c (struct thread_item): Add constructor, disable copy
construction and copy assignment, define default move
construction and move assignment.
<extra, name>: Change type to std::string.
<core>: Initialize.
<thread_handle>: Make non-pointer.
(thread_item_t): Remove typedef.
(DEF_VEC_O(thread_item_t)): Remove.
(threads_listing_context) <contains_thread>: New method.
<remove_thread>: New method.
<items>: Change type to std::vector.
(clear_threads_listing_context): Remove.
(threads_listing_context_remove): Remove.
(remote_newthread_step): Use thread_item constructor, adjust to
change to std::vector.
(start_thread): Use thread_item constructor, adjust to change to
std::vector.
(end_thread): Adjust to change to std::vector and std::string.
(remote_get_threads_with_qthreadinfo): Use thread_item
constructor, adjust to std::vector.
(remote_update_thread_list): Adjust to change to std::vector and
std::string, use threads_listing_context methods.
(remove_child_of_pending_fork): Adjust.
(remove_new_fork_children): Adjust.
* Makefile.in (SUBDIR_UNITTESTS_SRCS): Add rsp-low-selftests.c.
(SUBDIR_UNITTESTS_OBS): Add rsp-low-selftests.o.
* unittests/rsp-low-selftests.c: New file.
* common/rsp-low.h: Include common/byte-vector.h.
(hex2bin): New overload.
* common/rsp-low.c (hex2bin): New overload.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Create private_thread_info hierarchy
@ 2017-11-24 20:32 sergiodj+buildbot
2017-11-25 5:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-24 20:32 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 7aabaf9d4ad52a1df1f551908fbd8cafc5e7597a ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 7aabaf9d4ad52a1df1f551908fbd8cafc5e7597a
Create private_thread_info hierarchy
There are multiple definitions of the private_thread_info structure
compiled in the same GDB build. Because of the one definition rule, we
need to change this if we want to be able to make them non-POD (e.g. use
std::vector fields). This patch creates a class hierarchy, with
private_thread_info being an abstract base class, and all the specific
implementations inheriting from it.
In order to poison XNEW/xfree for non-POD types, it is also needed to
get rid of the xfree in thread_info::~thread_info, which operates on an
opaque type. This is replaced by thread_info::priv now being a
unique_ptr, which calls the destructor of the private_thread_info
subclass when the thread is being destroyed.
Including gdbthread.h from darwin-nat.h gave these errors:
/Users/simark/src/binutils-gdb/gdb/gdbthread.h:609:3: error: must use 'class' tag to refer to type 'thread_info' in this scope
thread_info *m_thread;
^
class
/usr/include/mach/thread_act.h:240:15: note: class 'thread_info' is hidden by a non-type declaration of 'thread_info' here
kern_return_t thread_info
^
It turns out that there is a thread_info function in the Darwin/XNU/mach API:
http://web.mit.edu/darwin/src/modules/xnu/osfmk/man/thread_info.html
Therefore, I had to add the class keyword at a couple of places in gdbthread.h,
I don't really see a way around it.
gdb/ChangeLog:
* gdbthread.h (private_thread_info): Define structure type, add
virtual pure destructor.
(thread_info) <priv>: Change type to unique_ptr.
<private_dtor>: Remove.
* thread.c (add_thread_with_info): Adjust to use of unique_ptr.
(private_thread_info::~private_thread_info): Provide default
implementation.
(thread_info::~thread_info): Don't call private_dtor nor
manually free priv.
* aix-thread.c (private_thread_info): Rename to ...
(aix_thread_info): ... this.
(get_aix_thread_info): New.
(sync_threadlists): Adjust.
(iter_tid): Adjust.
(aix_thread_resume): Adjust.
(aix_thread_fetch_registers): Adjust.
(aix_thread_store_registers): Adjust.
(aix_thread_extra_thread_info): Adjust.
* darwin-nat.h (private_thread_info): Rename to ...
(darwin_thread_info): ... this.
(get_darwin_thread_info): New.
* darwin-nat.c (darwin_init_thread_list): Adjust.
(darwin_check_new_threads): Adjust.
(thread_info_from_private_thread_info): Adjust.
* linux-thread-db.c (private_thread_info): Rename to ...
(thread_db_thread_info): ... this, initialize fields.
(get_thread_db_thread_info): New.
<dying>: Change type to bool.
(update_thread_state): Adjust to type rename.
(record_thread): Adjust to type rename an use of unique_ptr.
(thread_db_pid_to_str): Likewise.
(thread_db_extra_thread_info): Likewise.
(thread_db_thread_handle_to_thread_info): Likewise.
(thread_db_get_thread_local_address): Likewise.
* nto-tdep.h (private_thread_info): Rename to ...
(nto_thread_info): ... this, initialize fields.
(get_nto_thread_info): New.
<name>: Change type to std::string.
* nto-tdep.c (nto_extra_thread_info): Adjust to type rename and
use of unique_ptr.
* nto-procfs.c (update_thread_private_data_name): Adjust to
std::string change, allocate nto_private_thread_info with new.
(update_thread_private_data): Adjust to unique_ptr.
* remote.c (private_thread_info): Rename to ...
(remote_thread_info): ... this, initialize data members with
default values.
<extra, name>: Change type to std::string.
<thread_handle>: Change type to non-pointer.
(free_private_thread_info): Remove.
(get_private_info_thread): Rename to...
(get_remote_thread_info): ... this, change return type, adjust to
use of unique_ptr, use remote_thread_info constructor.
(remote_add_thread): Adjust.
(get_private_info_ptid): Rename to...
(get_remote_thread_info): ...this, change return type.
(remote_thread_name): Use get_remote_thread_info, adjust to
change to std::string.
(struct thread_item) <~thread_item>: Remove.
<thread_handle>: Make non pointer.
(start_thread): Adjust to thread_item::thread_handle type
change.
(remote_update_thread_list): Adjust to type name change, move
strings from temporary to long-lived object instead of
duplicating.
(remote_threads_extra_info): Use get_remote_thread_info.
(process_initial_stop_replies): Likewise.
(resume_clear_thread_private_info): Likewise.
(remote_resume): Adjust to type name change.
(remote_commit_resume): Use get_remote_thread_info.
(process_stop_reply): Adjust to type name change.
(remote_stopped_by_sw_breakpoint): Use get_remote_thread_info.
(remote_stopped_by_hw_breakpoint): Likewise.
(remote_stopped_by_watchpoint): Likewise.
(remote_stopped_data_address): Likewise.
(remote_core_of_thread): Likewise.
(remote_thread_handle_to_thread_info): Use
get_private_info_thread, adjust to thread_handle field type
change.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Workaround build bug with GCC 6.2.1
@ 2017-11-24 23:37 sergiodj+buildbot
2017-11-25 10:29 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-24 23:37 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 30649c145114fe3aac089bf06e9457238d46341b ***
Author: Philipp Rudo <prudo@linux.vnet.ibm.com>
Branch: master
Commit: 30649c145114fe3aac089bf06e9457238d46341b
Workaround build bug with GCC 6.2.1
Building GDB with GCC 6.2.1 gives multiple errors like
gdb/dtrace-probe.c: In member function void dtrace_probe::build_arg_exprs(gdbarch*):
gdb/dtrace-probe.c:627:8: error: types may not be defined in a for-range-declaration [-Werror]
for (struct dtrace_probe_arg &arg : m_args
Fix it by removing the 'struct' keyword.
A similar Bug was already fixed for GCC 6.3.1
https://sourceware.org/ml/gdb-patches/2017-10/msg00442.html
gdb/ChangeLog:
* dtrace-probe.c (dtrace_probe::build_arg_exprs)
(dtrace_probe::is_enabled, dtrace_probe::enable)
(dtrace_probe::disable): Remove keyword 'struct' at for-range
variable
* probe.c (gen_ui_out_table_header_info)
(print_ui_out_not_applicables): Remove keyword 'struct' at
for-range variable
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Make strcmp_iw NOT ignore whitespace in the middle of tokens
@ 2017-11-25 2:17 sergiodj+buildbot
2017-11-25 17:54 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-25 2:17 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 0662b6a7c1b3b04a4ca31a09af703c91c7aa9646 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 0662b6a7c1b3b04a4ca31a09af703c91c7aa9646
Make strcmp_iw NOT ignore whitespace in the middle of tokens
currently "b func tion" manages to set a breakpoint at "function" !
All these years I had never noticed this, but now that the linespec
completer actually works, this easily happens by accident, with:
"b func t<tab>"
expecting to get "thread", but getting instead:
"b func tion"
...
Also, this:
"b rettypefunc<int>"
manages to set a breakpoint on "rettype func<int>()".
These things happen due to strcmp_iw "magic".
Fix it by teaching strcmp_iw about when can it skip whitespace. This
required handling user-defined operators, and scope operators,
complicating the code a bit, unfortunately. I added unit tests for
all the corner cases I stumbled on, as I was developing this, and then
in the end wrote a testsuite testcase covering many of the same things
and more (to be added later).
gdb/ChangeLog:
2017-11-24 Pedro Alves <palves@redhat.com>
* cp-support.c (cp_symbol_name_matches_1): New, factored out from
cp_fq_symbol_name_matches. Pass language_cplus to
strncmp_with_mode.
(cp_fq_symbol_name_matches): Call cp_symbol_name_matches_1.
(selftests::test_cp_symbol_name_cmp): New.
(_initialize_cp_support): Register "cp_symbol_name_matches"
selftests.
* language.c (default_symbol_name_matcher): Pass language_minimal
to strncmp_iw_with_mode.
* utils.c: Include "cp-support.h" and <algorithm>.
(valid_identifier_name_char, cp_skip_operator_token, skip_ws)
(cp_is_operator): New functions.
(strncmp_iw_with_mode): Use them. Add language parameter. Don't
skip whitespace in the symbol name when the lookup name doesn't
have spaces, and vice versa.
(strncmp_iw, strcmp_iw): Pass language to strncmp_iw_with_mode.
* utils.h (strncmp_iw_with_mode): Add language parameter.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Revert "elf: Properly compute offsets of note descriptor and next note"
@ 2017-11-25 3:37 sergiodj+buildbot
2017-11-25 11:44 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-25 3:37 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 4e25ac038efbe5293885cc75d8a3e08b23da7cc9 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 4e25ac038efbe5293885cc75d8a3e08b23da7cc9
Revert "elf: Properly compute offsets of note descriptor and next note"
This reverts commit 650444eb540f9fd85e821567a3f943b4bc41b8be.
With this patch, running the GDB test case gdb.base/auxv.exp is stuck in
an infinite loop, consuming memory to the point that it renders the
machine unusable. I am reverting it so we can take our time to
investigate while not killing all the developers' machines.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add comprehensive C++ operator linespec/location/completion tests
@ 2017-11-25 8:52 sergiodj+buildbot
2017-11-25 20:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-25 8:52 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 6a3c6ee41898743234d8fd9f9cab15f2ecdaba49 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 6a3c6ee41898743234d8fd9f9cab15f2ecdaba49
Add comprehensive C++ operator linespec/location/completion tests
This exercises the special handling C++ operators require in several
places in the linespec parser, both the linespec and explicit location
completers, symbol lookup, etc. Particularly, makes sure all that
works without quoting.
Note that despite the apparent smallish size, this adds thousands of
tests to the testsuite, due to combination explosion (linespecs,
explicit locations, tab completion, complete command, completion at
different points in each function, etc.)
Grows the gdb.linespec/ tests like this:
-# of expected passes 3464
+# of expected passes 7823
gdb/testsuite/ChangeLog:
2017-11-25 Pedro Alves <palves@redhat.com>
* gdb.linespec/cpls-ops.cc: New file.
* gdb.linespec/cpls-ops.exp: New file.
* lib/completion-support.exp (test_complete_prefix_range_re): New,
factored out from ...
(test_complete_prefix_range): ... this.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master
2017-11-25 8:52 [binutils-gdb] Add comprehensive C++ operator linespec/location/completion tests sergiodj+buildbot
@ 2017-11-25 20:49 ` sergiodj+buildbot
0 siblings, 0 replies; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-25 20:49 UTC (permalink / raw)
To: gdb-testers
Buildslave:
ubuntu-trusty-aarch32-1
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-native-gdbserver-m32/builds/2200>
Commit(s) tested:
6a3c6ee41898743234d8fd9f9cab15f2ecdaba49
Author(s) (in the same order as the commits):
Pedro Alves <palves@redhat.com>
Subject:
Add comprehensive C++ operator linespec/location/completion tests
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-native-gdbserver-m32/6a/6a3c6ee41898743234d8fd9f9cab15f2ecdaba49/>
*** Diff to previous build ***
============================
new FAIL: gdb.linespec/cpls-ops.exp: operator-new: tab complete "b test_op_new::operator"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new: cmd complete "b test_op_new::operator"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new: tab complete "b test_op_new::operator "
new FAIL: gdb.linespec/cpls-ops.exp: operator-new: cmd complete "b test_op_new::operator "
new FAIL: gdb.linespec/cpls-ops.exp: operator-new: tab complete "b test_op_new::operator n"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new: cmd complete "b test_op_new::operator n"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new: tab complete "b test_op_new::operator ne"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new: cmd complete "b test_op_new::operator ne"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new: tab complete "b test_op_new::operator new"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new: cmd complete "b test_op_new::operator new"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new: tab complete "b test_op_new::operator new
new FAIL: gdb.linespec/cpls-ops.exp: operator-new: cmd complete "b test_op_new::operator new
new FAIL: gdb.linespec/cpls-ops.exp: operator-new: compare "b test_op_new::operator new
new FAIL: gdb.linespec/cpls-ops.exp: operator-new: tab complete "b test_op_new::operator new "
new FAIL: gdb.linespec/cpls-ops.exp: operator-new: cmd complete "b test_op_new::operator new "
new FAIL: gdb.linespec/cpls-ops.exp: operator-new: compare "b test_op_new::operator new" completion list with bp location list: matches
new FAIL: gdb.linespec/cpls-ops.exp: operator-new: tab complete "b -function test_op_new::operator"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new: cmd complete "b -function test_op_new::operator"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new: tab complete "b -function test_op_new::operator "
new FAIL: gdb.linespec/cpls-ops.exp: operator-new: cmd complete "b -function test_op_new::operator "
new FAIL: gdb.linespec/cpls-ops.exp: operator-new: tab complete "b -function test_op_new::operator n"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new: cmd complete "b -function test_op_new::operator n"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new: tab complete "b -function test_op_new::operator ne"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new: cmd complete "b -function test_op_new::operator ne"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new: tab complete "b -function test_op_new::operator new"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new: cmd complete "b -function test_op_new::operator new"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new: compare "b -function test_op_new::operator new
new FAIL: gdb.linespec/cpls-ops.exp: operator-new: tab complete "b -function test_op_new::operator new "
new FAIL: gdb.linespec/cpls-ops.exp: operator-new: cmd complete "b -function test_op_new::operator new "
new FAIL: gdb.linespec/cpls-ops.exp: operator-new: compare "b -function test_op_new::operator new" completion list with bp location list: matches
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: tab complete "b test_op_new_array::operator"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: cmd complete "b test_op_new_array::operator"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: tab complete "b test_op_new_array::operator "
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: cmd complete "b test_op_new_array::operator "
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: tab complete "b test_op_new_array::operator n"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: cmd complete "b test_op_new_array::operator n"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: tab complete "b test_op_new_array::operator ne"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: cmd complete "b test_op_new_array::operator ne"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: tab complete "b test_op_new_array::operator new"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: cmd complete "b test_op_new_array::operator new"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: tab complete "b test_op_new_array::operator new["
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: cmd complete "b test_op_new_array::operator new["
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: tab complete "b test_op_new_array::operator new[]"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: cmd complete "b test_op_new_array::operator new[]"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: tab complete "b test_op_new_array::operator new[]
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: cmd complete "b test_op_new_array::operator new[]
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: compare "b test_op_new_array::operator new[]
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: tab complete "b test_op_new_array::operator new "
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: cmd complete "b test_op_new_array::operator new "
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: tab complete "b test_op_new_array::operator new []
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: cmd complete "b test_op_new_array::operator new []
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: compare "b test_op_new_array::operator new[]" completion list with bp location list: matches
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: compare "b test_op_new_array::operator new []
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: tab complete "b -function test_op_new_array::operator"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: cmd complete "b -function test_op_new_array::operator"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: tab complete "b -function test_op_new_array::operator "
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: cmd complete "b -function test_op_new_array::operator "
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: tab complete "b -function test_op_new_array::operator n"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: cmd complete "b -function test_op_new_array::operator n"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: tab complete "b -function test_op_new_array::operator ne"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: cmd complete "b -function test_op_new_array::operator ne"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: tab complete "b -function test_op_new_array::operator new"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: cmd complete "b -function test_op_new_array::operator new"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: tab complete "b -function test_op_new_array::operator new["
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: cmd complete "b -function test_op_new_array::operator new["
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: tab complete "b -function test_op_new_array::operator new[]"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: cmd complete "b -function test_op_new_array::operator new[]"
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: tab complete "b -function test_op_new_array::operator new[]
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: cmd complete "b -function test_op_new_array::operator new[]
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: compare "b -function test_op_new_array::operator new[]
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: tab complete "b -function test_op_new_array::operator new "
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: cmd complete "b -function test_op_new_array::operator new "
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: compare "b -function test_op_new_array::operator new[]" completion list with bp location list: matches
new FAIL: gdb.linespec/cpls-ops.exp: operator-new[]: compare "b -function test_op_new_array::operator new []
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
============================
*** Complete list of XFAILs for this builder ***
To obtain the list of XFAIL tests for this builder, go to:
<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch32-native-gdbserver-m32/xfails/master/xfail;hb=>
You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:
<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch32-native-gdbserver-m32/xfails/master/xfail.table;hb=>
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Removes a cleanup from gcore.c
@ 2017-11-26 18:30 sergiodj+buildbot
2017-11-26 21:32 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-26 18:30 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 44287fd89091a833451e74c79e46404c23fdaf9b ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 44287fd89091a833451e74c79e46404c23fdaf9b
Removes a cleanup from gcore.c
This removes a cleanup from gcore.c, replacing it with
unique_xmalloc_ptr.
Regression tested by the buildbot.
ChangeLog
2017-11-26 Tom Tromey <tom@tromey.com>
* gcore.c (write_gcore_file_1): Use gdb::unique_xmalloc_ptr.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] [PR ld/22269] aarch64: Handle local undefined weak symbols
@ 2017-11-27 12:30 sergiodj+buildbot
2017-11-27 16:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-27 12:30 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a377ae2ad683d3c16ae74dba440ee441120a7d8a ***
Author: Szabolcs Nagy <szabolcs.nagy@arm.com>
Branch: master
Commit: a377ae2ad683d3c16ae74dba440ee441120a7d8a
[PR ld/22269] aarch64: Handle local undefined weak symbols
With static pie linking undefined weak symbols are forced to resolve locally
to 0, so no GOT setup is needed in elfNN_aarch64_finish_dynamic_symbol,
which previously failed for these symbols.
The failure caused the unhelpful error message:
"ld: final link failed: Nonrepresentable section on output"
bfd/
PR ld/22269
* elfnn-aarch64.c (elfNN_aarch64_finish_dynamic_symbol): Use
UNDEFWEAK_NO_DYNAMIC_RELOC to avoid dynamic GOT relocs.
(elfNN_aarch64_allocate_dynrelocs): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] A simpler way to make the "arch" build directory
@ 2017-11-28 0:24 sergiodj+buildbot
2017-11-28 1:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-28 0:24 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b22c88c2ca013cc25d7a8fcbc748122bb1a349bb ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: b22c88c2ca013cc25d7a8fcbc748122bb1a349bb
A simpler way to make the "arch" build directory
This implements a simpler way to make the "arch" build directory --
namely, now it is done as an order-only dependency in the Makefile,
rather than being created when config.status is run. This simpler
because it means that the build directories can be changed without
re-running autoconf.
ChangeLog
2017-11-27 Tom Tromey <tom@tromey.com>
* configure.ac (CONFIG_SRC_SUBDIR): Don't subst.
* configure: Rebuild.
* Makefile.in (CONFIG_SRC_SUBDIR): Redefine.
(CONFIG_DEP_SUBDIR): New variable.
(%.o): Add order-only dependency.
($(CONFIG_DEP_SUBDIR)): New target.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Move mi objects to mi subdirectory
@ 2017-11-28 1:08 sergiodj+buildbot
2017-11-28 5:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-28 1:08 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 6f3cdf9a3bfa2c0a22fa9dc40b45578e2ea7957d ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 6f3cdf9a3bfa2c0a22fa9dc40b45578e2ea7957d
Move mi objects to mi subdirectory
Move object files corresponding to mi/*.c to a subdirectory in the
build tree.
ChangeLog
2017-11-27 Tom Tromey <tom@tromey.com>
* Makefile.in (SUBDIR_MI_OBS): Redefine.
(%.o): Remove mi rule.
(CONFIG_SRC_SUBDIR): Add mi.
(COMMON_OBS): Use mi/mi-common.o
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Move unittests object files to unittests subdirectory
@ 2017-11-28 2:28 sergiodj+buildbot
2017-11-28 11:38 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-28 2:28 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 75787ac19cdf7e8aa9b4c28f9421837ba479cf51 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 75787ac19cdf7e8aa9b4c28f9421837ba479cf51
Move unittests object files to unittests subdirectory
Move the object files corresponding to unittests/*.c to the unittests
subdirectory in the build tree.
ChangeLog
2017-11-27 Tom Tromey <tom@tromey.com>
* Makefile.in (SUBDIR_UNITTESTS_OBS): Redefine.
(%.o): Remove unittests rule.
(CONFIG_SRC_SUBDIR): Add unittests.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove REMOTE_OBS
@ 2017-11-28 11:31 sergiodj+buildbot
2017-11-29 1:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-28 11:31 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 18ca73470a0d7eb96a807c97559cbb9fddb4b461 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 18ca73470a0d7eb96a807c97559cbb9fddb4b461
Remove REMOTE_OBS
This removes REMOTE_OBS from the Makefile. It is no longer needed, as
remote support is always built into gdb. The relevant sources are now
added to COMMON_SFILES, where they are treated like other ordinary
sources.
ChangeLog
2017-11-27 Tom Tromey <tom@tromey.com>
* Makefile.in (REMOTE_OBS): Remove.
(SFILES): Remove remote sources.
(COMMON_SFILES): Add remote sources.
(ALLDEPFILES): Remove dcache.c.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] ld: Set non_ir_ref_regular on symbols referenced in regular objects
@ 2017-11-28 12:16 sergiodj+buildbot
2017-11-29 3:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-28 12:16 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a83ef4d139c377e0e87d105977d85c6ef9fbb162 ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: a83ef4d139c377e0e87d105977d85c6ef9fbb162
ld: Set non_ir_ref_regular on symbols referenced in regular objects
If linker plugin is enabled, set non_ir_ref_regular on symbols referenced
in regular objects so that linker plugin will get the correct symbol
resolution.
bfd/
PR ld/22502
* elflink.c (_bfd_elf_merge_symbol): Also skip definition from
an IR object.
(elf_link_add_object_symbols): If linker plugin is enabled, set
non_ir_ref_regular on symbols referenced in regular objects so
that linker plugin will get the correct symbol resolution.
ld/
PR ld/22502
* testsuite/ld-plugin/lto.exp: Run PR ld/22502 test.
* testsuite/ld-plugin/pr22502a.c: New file.
* testsuite/ld-plugin/pr22502b.c: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] ELF: Don't set non_ir_ref_regular in check_relocs
@ 2017-11-28 14:12 sergiodj+buildbot
2017-11-29 9:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-28 14:12 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 6c6bc899302deb7c9b14f71da79c0fffc992204e ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 6c6bc899302deb7c9b14f71da79c0fffc992204e
ELF: Don't set non_ir_ref_regular in check_relocs
Since elf_link_add_object_symbols sets non_ir_ref_regular now, there is
no need to set non_ir_ref_regular in check_relocs.
Tested on i686 and x86-64.
* elf-m10300.c (mn10300_elf_check_relocs): Don't set
non_ir_ref_regular.
* elf32-arm.c (elf32_arm_check_relocs): Likewise.
* elf32-bfin.c (bfin_check_relocs): Likewise.
* elf32-cr16.c (cr16_elf_check_relocs): Likewise.
* elf32-cris.c (cris_elf_check_relocs): Likewise.
* elf32-d10v.c (elf32_d10v_check_relocs): Likewise.
* elf32-dlx.c (elf32_dlx_check_relocs): Likewise.
* elf32-fr30.c (fr30_elf_check_relocs): Likewise.
* elf32-frv.c (elf32_frv_check_relocs): Likewise.
* elf32-hppa.c (elf32_hppa_check_relocs): Likewise.
* elf32-i370.c (i370_elf_check_relocs): Likewise.
* elf32-i386.c (elf_i386_check_relocs): Likewise.
* elf32-iq2000.c (iq2000_elf_check_relocs): Likewise.
* elf32-lm32.c (lm32_elf_check_relocs): Likewise.
* elf32-m32c.c (m32c_elf_check_relocs): Likewise.
* elf32-m32r.c (m32r_elf_check_relocs): Likewise.
* elf32-m68hc1x.c (elf32_m68hc11_check_relocs): Likewise.
* elf32-m68k.c (elf_m68k_check_relocs): Likewise.
* elf32-mcore.c (mcore_elf_check_relocs): Likewise.
* elf32-metag.c (elf_metag_check_relocs): Likewise.
* elf32-microblaze.c (microblaze_elf_check_relocs): Likewise.
* elf32-moxie.c (moxie_elf_check_relocs): Likewise.
* elf32-msp430.c (elf32_msp430_check_relocs): Likewise.
* elf32-mt.c (mt_elf_check_relocs): Likewise.
* elf32-nios2.c (nios2_elf32_check_relocs): Likewise.
* elf32-or1k.c (or1k_elf_check_relocs): Likewise.
* elf32-ppc.c (ppc_elf_check_relocs): Likewise.
* elf32-rl78.c (rl78_elf_check_relocs): Likewise.
* elf32-s390.c (elf_s390_check_relocs): Likewise.
* elf32-score.c (s3_bfd_score_elf_check_relocs): Likewise.
* elf32-score7.c (s7_bfd_score_elf_check_relocs): Likewise.
* elf32-sh.c (sh_elf_check_relocs): Likewise.
* elf32-tic6x.c (elf32_tic6x_check_relocs): Likewise.
* elf32-tilepro.c (tilepro_elf_check_relocs): Likewise.
* elf32-v850.c (v850_elf_check_relocs): Likewise.
* elf32-vax.c (elf_vax_check_relocs): Likewise.
* elf32-xstormy16.c (xstormy16_elf_check_relocs): Likewise.
* elf32-xtensa.c (elf_xtensa_check_relocs): Likewise.
* elf64-aarch64.c (elf64_aarch64_check_relocs): Likewise.
* elf64-alpha.c (elf64_alpha_check_relocs): Likewise.
* elf64-hppa.c (elf64_hppa_check_relocs): Likewise.
* elf64-ia64-vms.c (elf64_ia64_check_relocs): Likewise.
* elf64-mmix.c (mmix_elf_check_relocs): Likewise.
* elf64-ppc.c (ppc64_elf_check_relocs): Likewise.
* elf64-s390.c (elf_s390_check_relocs): Likewise.
* elf64-sh64.c (sh_elf64_check_relocs): Likewise.
* elf64-x86-64.c (elf_x86_64_check_relocs): Likewise.
* elfnn-aarch64.c (elfNN_aarch64_check_relocs): Likewise.
* elfnn-ia64.c (elfNN_ia64_check_relocs): Likewise.
* elfnn-riscv.c (riscv_elf_check_relocs): Likewise.
* elfxx-mips.c (_bfd_mips_elf_check_relocs): Likewise.
* elfxx-sparc.c (_bfd_sparc_elf_check_relocs): Likewise.
* elfxx-tilegx.c (tilegx_elf_check_relocs): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix a memory access violation when attempting to parse a corrupt COFF binary with a relocation that points beyond the end of the section to be relocated.
@ 2017-11-28 14:37 sergiodj+buildbot
2017-11-29 11:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-28 14:37 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b23dc97fe237a1d9e850d7cbeee066183a00630b ***
Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: b23dc97fe237a1d9e850d7cbeee066183a00630b
Fix a memory access violation when attempting to parse a corrupt COFF binary with a relocation that points beyond the end of the section to be relocated.
PR 22506
* reloc.c (reloc_offset_in_range): Rename to
bfd_reloc_offset_in_range and export.
(bfd_perform_relocation): Rename function invocation.
(bfd_install_relocation): Likewise.
(bfd_final_link_relocate): Likewise.
* bfd-in2.h: Regenerate.
* coff-arm.c (coff_arm_reloc): Use bfd_reloc_offset_in_range.
* coff-i386.c (coff_i386_reloc): Likewise.
* coff-i860.c (coff_i860_reloc): Likewise.
* coff-m68k.c (mk68kcoff_common_addend_special_fn): Likewise.
* coff-m88k.c (m88k_special_reloc): Likewise.
* coff-mips.c (mips_reflo_reloc): Likewise.
* coff-x86_64.c (coff_amd64_reloc): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Prevent a memory exhaustion problem when trying to read in strings from a COFF binary with a corrupt string table size.
@ 2017-11-28 20:11 sergiodj+buildbot
2017-11-29 13:23 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-28 20:11 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b0029dce6867de1a2828293177b0e030d2f0f03c ***
Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: b0029dce6867de1a2828293177b0e030d2f0f03c
Prevent a memory exhaustion problem when trying to read in strings from a COFF binary with a corrupt string table size.
PR 22507
* coffgen.c (_bfd_coff_read_string_table): Check for an excessive
size of the external string table.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] [gdb/testsuite] Fix wrong return type in tests
@ 2017-11-29 11:10 sergiodj+buildbot
2017-11-29 17:32 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-29 11:10 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f106e10e5e80265e1c43532bba4cb997a7dfa022 ***
Author: Thomas Preud'homme <thomas.preudhomme@arm.com>
Branch: master
Commit: f106e10e5e80265e1c43532bba4cb997a7dfa022
[gdb/testsuite] Fix wrong return type in tests
The following tests are marked untested with latest GCC due to a warning
being emitted for a mismatch between their return type and what the lack
of return statement:
* gdb.cp/breakpoint.exp
* gdb.cp/psymtab-parameter.exp
* gdb.cp/shadow.exp
This patch fix the return type to match the function definitions.
2017-11-29 Thomas Preud'homme <thomas.preudhomme@arm.com>
gdb/testsuite/
* gdb.cp/breakpoint.cc (bar): Set return type to void.
* gdb.cp/psymtab-parameter.cc (func): Likewise.
* gdb.cp/psymtab-parameter.exp: Update comment regarding prototype of
func ().
* gdb.cp/shadow.cc (B.func): Return 0.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix add-symbol-file usage and errors
@ 2017-11-29 16:44 sergiodj+buildbot
2017-11-29 21:25 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-29 16:44 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 02ca603a481d55e175765ab5bff30a04b86e905a ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 02ca603a481d55e175765ab5bff30a04b86e905a
Fix add-symbol-file usage and errors
This patch updates add-symbol-file help and error text.
It changes add-symbol-file to throw an exception if "-s" is seen but
not all of the arguments are given. Previously this was silently
ignored.
It changes the unrecognized argument message to more clearly state
what went wrong.
Finally, it updates the usage line in the help text to follow GNU
style regarding "metasyntactic variables"; a change I believe should
be made to all gdb help messages.
gdb/ChangeLog
2017-11-29 Tom Tromey <tom@tromey.com>
* symfile.c (add_symbol_file_command): Error if some arguments to
-s are missing. Change unrecognized-argument error message.
(_initialize_symfile): Fix usage text for add-symbol-file.
gdb/testsuite/ChangeLog
2017-11-29 Tom Tromey <tom@tromey.com>
* gdb.base/relocate.exp: Update invalid argument test.
Add new tests for invalid arguments.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Handle custom completion match prefix / LCD
@ 2017-11-29 20:48 sergiodj+buildbot
2017-11-30 9:33 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-29 20:48 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a207cff2da9f154e4f581b19dcde215593bfccf9 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: a207cff2da9f154e4f581b19dcde215593bfccf9
Handle custom completion match prefix / LCD
A following patch will add support for wild matching for C++ symbols,
making completing on "b push_ba" on a C++ program complete to
std::vector<...>::push_back, std::string::push_back etc., like:
(gdb) b push_ba[TAB]
std::vector<...>::push_back(....)
std::string<...>::push_back(....)
Currently, we compute the "lowest common denominator" between all
completion candidates (what the input line is adjusted to) as the
common prefix of all matches. That's problematic with wild matching
as above, as then we'd end up with TAB changing the input line to
"b std::", losing the original input, like:
(gdb) b push_ba[TAB]
std::vector<...>::push_back(....)
std::string<...>::push_back(....)
(gdb) b std::
while obviously we'd want it to adjust itself to "b push_back(" instead:
(gdb) b push_ba[TAB]
std::vector<...>::push_back(....)
std::string<...>::push_back(....)
(gdb) b push_back(
This patch adds the core code necessary to support this, though
nothing really makes use of it yet in this patch.
gdb/ChangeLog:
2017-11-29 Pedro Alves <palves@redhat.com>
* ada-lang.c (ada_lookup_name_info::matches): Change type of
parameter from completion_match to completion_match_result.
Adjust.
(do_wild_match, do_full_match, ada_symbol_name_matches): Likewise.
* completer.c (completion_tracker::maybe_add_completion): Add
match_for_lcd parameter and use it.
(completion_tracker::add_completion): Likewise.
* completer.h (class completion_match_for_lcd): New class.
(completion_match_result::match_for_lcd): New field.
(completion_match_result::set_match): New method.
(completion_tracker): Add comments.
(completion_tracker::add_completion): Add match_for_lcd parameter.
(completion_tracker::reset_completion_match_result): Reset
match_for_lcd too.
(completion_tracker::maybe_add_completion): Add match_for_lcd
parameter.
(completion_tracker::m_lowest_common_denominator_unique): Extend
comments.
* cp-support.c (cp_symbol_name_matches_1)
(cp_fq_symbol_name_matches): Change type of parameter from
completion_match to completion_match_result. Adjust.
* language.c (default_symbol_name_matcher): Change type of
parameter from completion_match to completion_match_result.
Adjust.
* language.h (completion_match_for_lcd): Forward declare.
(default_symbol_name_matcher): Change type of parameter from
completion_match to completion_match_result.
* symtab.c (compare_symbol_name): Adjust.
(completion_list_add_name): Pass the match_for_lcd to the tracker.
* symtab.h (ada_lookup_name_info::matches): Change type of
parameter from completion_match to completion_match_result.
(symbol_name_matcher_ftype): Likewise, and update comments.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Make "break foo" find "A::foo", A::B::foo", etc. [C++ and wild matching]
@ 2017-11-29 21:46 sergiodj+buildbot
2017-11-30 11:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-29 21:46 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a20714ff39f621961151d0c204e89062ab2107eb ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: a20714ff39f621961151d0c204e89062ab2107eb
Make "break foo" find "A::foo", A::B::foo", etc. [C++ and wild matching]
This patch teaches GDB about setting breakpoints in all scopes
(namespaces and classes) by default.
Here's a contrived example:
(gdb) b func<tab>
(anonymous namespace)::A::function() Bn::(anonymous namespace)::B::function() function(int, int)
(anonymous namespace)::B::function() Bn::(anonymous namespace)::function() gdb::(anonymous namespace)::A::function()
(anonymous namespace)::B::function() const Bn::(anonymous namespace)::function(int, int) gdb::(anonymous namespace)::function()
(anonymous namespace)::function() Bn::B::func() gdb::(anonymous namespace)::function(int, int)
(anonymous namespace)::function(int, int) Bn::B::function() gdb::A::func()
A::func() Bn::func() gdb::A::function()
A::function() Bn::function() gdb::func()
B::func() Bn::function(int, int) gdb::function()
B::function() Bn::function(long) gdb::function(int, int)
B::function() const func() gdb::function(long)
B::function_const() const function()
(gdb) b function
Breakpoint 1 at 0x4005ce: function. (26 locations)
(gdb) b B::function<tab>
(anonymous namespace)::B::function() B::function() const Bn::B::function()
(anonymous namespace)::B::function() const B::function_const() const
B::function() Bn::(anonymous namespace)::B::function()
(gdb) b B::function
Breakpoint 1 at 0x40072c: B::function. (6 locations)
To get back the original behavior of interpreting the function name as
a fully-qualified name, you can use the new "-qualified" (or "-q")
option/flag (added by this commit). For example:
(gdb) b B::function
(anonymous namespace)::B::function() B::function() const Bn::B::function()
(anonymous namespace)::B::function() const B::function_const() const
B::function() Bn::(anonymous namespace)::B::function()
vs:
(gdb) b -qualified B::function
B::function() B::function() const B::function_const() const
I've chosen "-qualified" / "-q" because "-f" (for "full" or
"fully-qualified") is already taken for "-function".
Note: the "-qualified" option works with both linespecs and explicit
locations. I.e., these are equivalent:
(gdb) b -q func
(gdb) b -q -f func
and so are these:
(gdb) b -q filename.cc:func
(gdb) b -q -s filename.cc -f func
(gdb) b -s filename.cc -q -f func
(gdb) b -s filename.cc -f func -q
To better understand why I consider wild matching the better default,
consider what happens when we get to the point when _all_ of GDB is
wrapped under "namespace gdb {}". I have a patch series that does
that, and when I started debugging that GDB, I immediately became
frustrated. You'd have to write "b gdb::internal_error", "b
gdb::foo", "b gdb::bar", etc. etc., which gets annoying pretty
quickly. OTOH, consider how this makes it very easy to set
breakpoints in classes wrapped in anonymous namespaces. You just
don't think of them, GDB finds the symbols for you automatically.
(At the Cauldron a couple months ago, several people told me that they
run into a similar issue when debugging other C++ projects. One
example was when debugging LLVM, which puts all its code under the
"llvm" namespace.)
Implementation-wise, what the patch does is:
- makes C++ symbol name hashing only consider the last component of
a symbol name. (so that we can look up symbol names by
last-component name only).
- adds a C++ symbol name matcher for symbol_name_match_type::WILD,
which ignores missing leading specifiers / components.
- adjusts a few preexisting testsuite tests to use "-qualified" when
they mean it.
- adds new testsuite tests.
- adds unit tests.
Grows the gdb.linespec/ tests like this:
-# of expected passes 7823
+# of expected passes 8977
gdb/ChangeLog:
2017-11-29 Pedro Alves <palves@redhat.com>
* NEWS: Mention that breakpoints on C++ functions are now set on
on all namespaces/classes by default, and mention "break
-qualified".
* ax-gdb.c (agent_command_1): Adjust to pass a
symbol_name_match_type to new_linespec_location.
* breakpoint.c (parse_breakpoint_sals): Adjust to
get_linespec_location's return type change.
(strace_marker_create_sals_from_location): Adjust to pass a
symbol_name_match_type to new_linespec_location.
(strace_marker_decode_location): Adjust to get_linespec_location's
return type change.
(strace_command): Adjust to pass a symbol_name_match_type to
new_linespec_location.
(LOCATION_HELP_STRING): Add paragraph about wildmatching, and
mention "-qualified".
* c-lang.c (cplus_language_defn): Install cp_search_name_hash.
* completer.c (explicit_location_match_type::MATCH_QUALIFIED): New
enumerator.
(complete_address_and_linespec_locations): New parameter
'match_type'. Pass it down.
(explicit_options): Add "-qualified".
(collect_explicit_location_matches): Pass the requested match type
to the linespec completers. Handle MATCH_QUALIFIED.
(location_completer): Handle "-qualified" combined with linespecs.
* cp-support.c (cp_search_name_hash): New.
(cp_symbol_name_matches_1): Implement wild matching for C++.
(cp_fq_symbol_name_matches): Reimplement.
(cp_get_symbol_name_matcher): Return different matchers depending
on the lookup name's match type.
(selftests::test_cp_symbol_name_matches): Add wild matching tests.
* cp-support.h (cp_search_name_hash): New declaration.
* dwarf2read.c
(selftests::dw2_expand_symtabs_matching::test_symbols): Add
symbols.
(test_dw2_expand_symtabs_matching_symbol): Add wild matching
tests.
* guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Adjust to
pass a symbol_name_match_type to new_linespec_location.
* linespec.c (linespec_parse_basic): Lookup function symbols using
the parser's symbol name match type.
(convert_explicit_location_to_linespec): New
symbol_name_match_type parameter. Pass it down to
find_linespec_symbols.
(convert_explicit_location_to_sals): Pass the location's name
match type to convert_explicit_location_to_linespec.
(parse_linespec): New match_type parameter. Save it in the
parser.
(linespec_parser_new): Default to symbol_name_match_type::WILD.
(linespec_complete_function): New symbol_name_match_type
parameter. Use it.
(complete_linespec_component): Pass down the parser's recorded
name match type.
(linespec_complete_label): New symbol_name_match_type parameter.
Use it.
(linespec_complete): New symbol_name_match_type parameter. Save
it in the parser and pass it down. Adjust to
get_linespec_location's prototype change.
(find_function_symbols, find_linespec_symbols): New
symbol_name_match_type parameter. Pass it down instead of
assuming symbol_name_match_type::WILD.
* linespec.h (linespec_complete, linespec_complete_function)
(linespec_complete_label): New symbol_name_match_type parameter.
* location.c (event_location::linespec_location): Now a struct
linespec_location.
(EL_LINESPEC): Adjust.
(initialize_explicit_location): Default to
symbol_name_match_type::WILD.
(new_linespec_location): New symbol_name_match_type parameter.
Record it in the location.
(get_linespec_location): Now returns a struct linespec_location.
(new_explicit_location): Also copy func_name_match_type.
(explicit_to_string_internal)
(string_to_explicit_location): Handle "-qualified".
(copy_event_location): Adjust to LINESPEC_LOCATION type change.
Copy symbol_name_match_type fields.
(event_location_deleter::operator()): Adjust to LINESPEC_LOCATION
type change.
(event_location_to_string): Adjust to LINESPEC_LOCATION type
change. Handle "-qualfied".
(string_to_explicit_location): Handle "-qualified".
(string_to_event_location_basic): New symbol_name_match_type
parameter. Pass it down.
(string_to_event_location): Handle "-qualified".
* location.h (struct linespec_location): New.
(explicit_location::func_name_match_type): New field.
(new_linespec_location): Now returns a const linespec_location *.
(string_to_event_location_basic): New symbol_name_match_type
parameter.
(explicit_completion_info::saw_explicit_location_option): New
field.
* mi/mi-cmd-break.c (mi_cmd_break_insert_1): Adjust to pass a
symbol_name_match_type to new_linespec_location.
* python/py-breakpoint.c (bppy_init): Likewise.
* python/python.c (gdbpy_decode_line): Likewise.
gdb/testsuite/ChangeLog:
2017-11-29 Pedro Alves <palves@redhat.com>
* gdb.base/langs.exp: Use -qualified.
* gdb.cp/meth-typedefs.exp: Use -qualified, and add tests without
it.
* gdb.cp/namespace.exp: Use -qualified.
* gdb.linespec/cpcompletion.exp (overload-2, fqn, fqn-2)
(overload-3, template-overload, template-ret-type, const-overload)
(const-overload-quoted, anon-ns, ambiguous-prefix): New
procedures.
(test_driver): Call them.
* gdb.cp/save-bp-qualified.cc: New.
* gdb.cp/save-bp-qualified.exp: New.
* gdb.linespec/explicit.exp: Test -qualified.
* lib/completion-support.exp (completion::explicit_opts_list): Add
"-qualified".
* lib/gdb.exp (gdb_breakpoint): Handle "qualified".
gdb/doc/ChangeLog:
2017-11-29 Pedro Alves <palves@redhat.com>
* gdb.texinfo (Linespec Locations): Document how "function" is
interpreted in C++ and Ada. Document "-qualified".
(Explicit Locations): Document how "-function" is interpreted in
C++ and Ada. Document "-qualified".
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Breakpoints in symbols with ABI tags (PR c++/19436)
@ 2017-11-29 22:06 sergiodj+buildbot
2017-11-30 13:25 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-29 22:06 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT bd69330db86b2367aac8aac5915f1686451c9d5d ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: bd69330db86b2367aac8aac5915f1686451c9d5d
Breakpoints in symbols with ABI tags (PR c++/19436)
Trying to set a breakpoint in a function with an ABI tag does not work
currently. E.g., debugging gdb itself, we see this with the
"string_printf" function:
(top-gdb) b string_print [TAB]
(top-gdb) b string_printf[abi:cxx11](char const*, ...) [RET]
No source file named string_printf[abi.
Make breakpoint pending on future shared library load? (y or [n])
Quoting doesn't help:
(top-gdb) b 'string_printf[abi:cxx11]'(char const*, ...)
malformed linespec error: unexpected string, "(char const*, ...)"
(top-gdb) b 'string_printf[abi:cxx11](char const*, ...)'
No source file named string_printf[abi.
Make breakpoint pending on future shared library load? (y or [n]) n
This patch fixes this, and takes it a bit further.
The actual symbol name as demangled by libiberty's demangler is really
string_printf[abi:cxx11](char const*, ...)
however, this patch makes it possible to set the breakpoint with
string_printf(char const*, ...)
too. I.e., ignoring the ABI tag.
And to match, it teaches the completer to complete the symbol name
without the ABI tag, i.e.,
"string_pri<TAB>" -> "string_printf(char const*, ...)"
If however, you really want to break on a symbol with the tag, then
you simply start writing the tag, and GDB will preserve it, like:
"string_printf[a<TAB>" -> "string_printf[abi:cxx11](char const*, ...)"
Grows the gdb.linespec/ tests like this:
-# of expected passes 8977
+# of expected passes 9176
gdb/ChangeLog:
2017-11-29 Pedro Alves <palves@redhat.com>
PR c++/19436
* NEWS: Mention setting breakpoints on functions with C++ ABI
tags.
* completer.h (completion_match_for_lcd) <match,
mark_ignored_range>: New methods.
<finish>: Consider ignored ranges.
<clear>: Clear ignored ranges.
<m_ignored_ranges, m_finished_storage>: New fields.
* cp-support.c (cp_search_name_hash): Ignore ABI tags.
(cp_symbol_name_matches_1, cp_fq_symbol_name_matches): Pass the
completion_match_for_lcd pointer to strncmp_iw_with_mode.
(test_cp_symbol_name_cmp): Add [abi:...] tags unit tests.
* language.c (default_symbol_name_matcher): Pass the
completion_match_for_lcd pointer to strncmp_iw_with_mode.
* linespec.c (linespec_lexer_lex_string): Don't tokenize ABI tags.
* utils.c (skip_abi_tag): New function.
(strncmp_iw_with_mode): Add completion_match_for_lcd parameter.
Handle ABI tags.
* utils.h (strncmp_iw_with_mode): Add completion_match_for_lcd
parameter.
gdb/testsuite/ChangeLog:
2017-11-29 Pedro Alves <palves@redhat.com>
PR c++/19436
* gdb.linespec/cpls-abi-tag.cc: New file.
* gdb.linespec/cpls-abi-tag.exp: New file.
gdb/doc/ChangeLog:
2017-11-29 Pedro Alves <palves@redhat.com>
PR c++/19436
* gdb.texinfo (Debugging C Plus Plus): Document setting
breakpoints in functions with ABI tags.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] preserve type length in ada-lang.c::to_fixed_range_type
@ 2017-11-30 0:53 sergiodj+buildbot
2017-11-30 15:22 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-30 0:53 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f5a91472120952bbc40f277561626b8ccdf7b194 ***
Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: f5a91472120952bbc40f277561626b8ccdf7b194
preserve type length in ada-lang.c::to_fixed_range_type
This patch fixes a potential issue which was noticed by code inspection:
ada-lang.c::to_fixed_range_type uses gdbtypes.c::create_static_range_type
to create most of the range type, which relies on create_range_type to
do most of the work. The latter has the following piece of code which
sets the length of the range type to match the length of the index_type:
if (TYPE_STUB (index_type))
TYPE_TARGET_STUB (result_type) = 1;
else
TYPE_LENGTH (result_type) = TYPE_LENGTH (check_typedef (index_type));
In Ada, it is actually possible to have a range type whose size
is smaller than its base type. For instance, with:
type Unsigned2_T is range 0 .. 2 ** 16 - 1;
for Unsigned2_T'SIZE use 16;
The compiler generates the following DWARF:
.uleb128 0x3 # (DIE (0x4e) DW_TAG_subrange_type)
.byte 0x2 # DW_AT_byte_size
.byte 0 # DW_AT_lower_bound
.value 0xffff # DW_AT_upper_bound
.long .LASF64 # DW_AT_name: "try__unsigned2_t___XDLU_0__65535"
.long 0x616 # DW_AT_type
... which points to the following base type...
.uleb128 0x1d # (DIE (0x616) DW_TAG_base_type)
.byte 0x4 # DW_AT_byte_size
.byte 0x5 # DW_AT_encoding
.long .LASF57 # DW_AT_name: "try__Tunsigned2_tB"
# DW_AT_artificial
... which has a size of 4 bytes.
With a type like this one, create_range_type returns a type whose
size is 4 bytes, instead of 2, which is not what we we would normally
expect.
Currently, this function is only used to handle array index types,
so the length of the type actually does not matter and there should
not be any user-visible consequences of the current behavior. But
it seems best to plug this latent bug now, rather than wait for it
to surface....
gdb/ChangeLog:
* ada-lang.c (to_fixed_range_type): Make sure that the size
of the range type being returned is the same as the size
of the range type being fixed.
Tested on x86_64-linux, no regression.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Define MPFR_USE_INTMAX_T so that mpfr.h assumes intmax_t is available.
@ 2017-11-30 1:14 sergiodj+buildbot
2017-11-30 17:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-30 1:14 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 7505954411a168f5c5b9adec23eac55b1532fbe6 ***
Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: 7505954411a168f5c5b9adec23eac55b1532fbe6
Define MPFR_USE_INTMAX_T so that mpfr.h assumes intmax_t is available.
mpfr.h uses a non-portable test to guess if intmax_t is available and
if API functions using intmax_t should be exposed. Define
MPFR_USE_INTMAX_T to override the non-portable test and always expose
these functions. This fixes the build on platforms where the test
guesses incorrectly.
gdb/ChangeLog:
* target-float.c [HAVE_LIBMPFR]: Define MPFR_USE_INTMAX_T.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: derive DispN from BaseIndex
@ 2017-11-30 12:28 sergiodj+buildbot
2017-11-30 23:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-30 12:28 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 7ac20022477c163983de77e5b16c016d518ca7bc ***
Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 7ac20022477c163983de77e5b16c016d518ca7bc
x86: derive DispN from BaseIndex
BaseIndex implies - with the exception of string instructions the
optional presence of a displacement. This is almost completely uniform
for all instructions (the sole exception being MPX ones, which don't
allow 16-bit addressing and hence Disp16), so there's no point in
explicitly stating this in the main opcode table. Drop those explict
specifications in favor of adding logic to i386-gen, shrinking the
table size quite a bit and hence making it more readable.
The opcodes/i386-tbl.h changes are due to a few cases where pointless
Disp* still hadn't been removed from their insns.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix gdb.linespec/cpls-ops.exp on 32-bit
@ 2017-11-30 16:51 sergiodj+buildbot
2017-12-01 3:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-30 16:51 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e3919f3e898aa5ab9a98dcaf9e242a9ebacc0757 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: e3919f3e898aa5ab9a98dcaf9e242a9ebacc0757
Fix gdb.linespec/cpls-ops.exp on 32-bit
gdb.linespec/cpls-ops.exp is currently failing on x86-64 -m32 and other
32-bit ports:
b test_op_new::operator new(unsigned int) FAIL: gdb.linespec/cpls-ops.exp: operator-new: tab complete "b test_op_new::operator" (timeout)
^CQuit
(gdb) complete b test_op_new::operator
b test_op_new::operator new(unsigned int)
(gdb) FAIL: gdb.linespec/cpls-ops.exp: operator-new: cmd complete "b test_op_new::operator"
The problem is simply that the testcase incorrectly assumes that
size_t is "unsigned long".
Fix this by extracting the right type with the "ptype" command.
gdb/testsuite/ChangeLog:
2017-11-30 Pedro Alves <palves@redhat.com>
* gdb.linespec/cpls-ops.exp
(check_explicit_skips_function_argument): Extract the underlying
type of size_t instead of hardcoding it.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Use boards/local-board.exp more
@ 2017-11-30 17:48 sergiodj+buildbot
2017-12-01 5:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-30 17:48 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f1af7b94c16029f2c6da9eae4076f64cd9383687 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: f1af7b94c16029f2c6da9eae4076f64cd9383687
Use boards/local-board.exp more
local-board.exp was introduced recently, containing the code required to
force the gdbserver boards to be non-remote (from the DejaGNU point of
view). Other board files use the same trick of forcing isremote to 0.
Instead of doing it by hand in each file, include local-board.exp.
gdb/testsuite/ChangeLog:
* boards/cc-with-tweaks.exp: Include local-board.exp instead of
setting isremote by hand.
* boards/dwarf4-gdb-index.exp: Likewise.
* boards/fission.exp: Likewise.
* boards/stabs.exp: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR22533, dynamic relocs generated for weak aliases
@ 2017-11-30 23:21 sergiodj+buildbot
2017-12-01 7:32 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-11-30 23:21 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 4a7e52349807017f9bc09ea25f07924f2ec971b3 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 4a7e52349807017f9bc09ea25f07924f2ec971b3
PR22533, dynamic relocs generated for weak aliases
This cleans up yet more craziness with non_got_ref.
PR 22533
* elf32-hppa.c (elf32_hppa_copy_indirect_symbol): Don't do anything
special with non_got_ref for weak aliases.
(elf32_hppa_check_relocs): Tweak setting of non_got_ref.
(elf32_hppa_adjust_dynamic_symbol): When initialising weak aliases,
don't uselessly copy non_got_ref. Clear dyn_relocs instead if
strong symbol is allocated in dynbss. Tidy comments.
(elf32_hppa_relocate_section): Comment fix.
* elf32-ppc.c (ppc_elf_copy_indirect_symbol): Don't do anything
special with non_got_ref for weak aliases.
(ppc_elf_adjust_dynamic_symbol): When initialising weak aliases,
don't uselessly copy non_got_ref. Clear dyn_relocs instead if
strong symbol is allocated in dynbss. Tidy comments.
* elf64-ppc.c (ppc64_elf_copy_indirect_symbol): Don't do anything
special with non_got_ref for weak aliases.
(ppc64_elf_adjust_dynamic_symbol): When initialising weak aliases,
don't uselessly copy non_got_ref. Clear dyn_relocs instead if
strong symbol is allocated in dynbss. Tidy comments.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] readonly_dynrelocs
@ 2017-12-01 7:34 sergiodj+buildbot
2017-12-01 10:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-01 7:34 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 63c1f59d665542359de4737e3e48033c588f44dc ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 63c1f59d665542359de4737e3e48033c588f44dc
readonly_dynrelocs
In early October, HJ Lu added support for a number of targets to "Dump
dynamic relocation in read-only section with minfo". This extends
that support to more targets, displays the symbol involved, and splits
the existing function that sets TEXTREL into a "readonly_dynrelocs"
and "maybe_set_textrel" function. I'll need "readonly_dynrelocs" if I
ever get around to fixing "pr22374 function pointer initialization"
fails.
am33_2.0, arc, bfin, hppa64, mn10300, and nios2 fail to mark a binary
needing text relocations with DT_TEXTREL. That's not good. xtensa also
fails to do so but complains about "dangerous relocation: dynamic
relocation in read-only section" so I reckon that is fine and have
marked the test as an xfail. The other targets need maintainer
attention.
Curiously, the map file dump wasn't added for x86, so the map test
currently fail on x86. It also fails on alpha, am33_2.0, arc, bfin,
hppa64, ia64, m68k, mips, mn10300, nios2, score and vax. cris
complains with "tmpdir/textrel.o, section .rodata: relocation
R_CRIS_32 should not be used in a shared object; recompile with -fPIC"
so I've marked it as an xfail.
bfd/
* elf32-hppa.c (maybe_set_textrel): Print symbol for map file output.
* elf32-ppc.c (maybe_set_textrel): Likewise.
* elf64-ppc.c (maybe_set_textrel): Likewise.
* elf32-arm.c (readonly_dynrelocs): New function.
(maybe_set_textrel): New function, replacing..
(elf32_arm_readonly_dynrelocs): ..this.
* elf32-lm32.c (readonly_dynrelocs): New function.
(maybe_set_textrel): New function, replacing old version of..
(readonly_dynrelocs): ..this.
* elf32-m32r.c (readonly_dynrelocs): New function.
(maybe_set_textrel): New function, replacing old version of..
(readonly_dynrelocs): ..this.
* elf32-metag.c (readonly_dynrelocs): New function.
(maybe_set_textrel): New function, replacing old version of..
(readonly_dynrelocs): ..this.
* elf32-nds32.c: Delete unnecessary forward declarations.
(readonly_dynrelocs): New function.
(maybe_set_textrel): New function, replacing old version of..
(readonly_dynrelocs): ..this.
* elf32-or1k.c (readonly_dynrelocs): New function.
(maybe_set_textrel): New function, replacing old version of..
(readonly_dynrelocs): ..this.
* elf32-s390.c (readonly_dynrelocs): New function.
(maybe_set_textrel): New function, replacing old version of..
(readonly_dynrelocs): ..this.
* elf32-sh.c (readonly_dynrelocs): New function.
(maybe_set_textrel): New function, replacing old version of..
(readonly_dynrelocs): ..this.
* elf32-tic6x.c (readonly_dynrelocs): New function.
(maybe_set_textrel): New function, replacing..
(elf32_tic6x_readonly_dynrelocs): ..this.
* elf32-tilepro.c (readonly_dynrelocs): New function.
(maybe_set_textrel): New function, replacing old version of..
(readonly_dynrelocs): ..this.
* elf64-s390.c (readonly_dynrelocs): New function.
(maybe_set_textrel): New function, replacing old version of..
(readonly_dynrelocs): ..this.
* elfnn-aarch64.c (readonly_dynrelocs): New function.
(maybe_set_textrel): New function, replacing..
(aarch64_readonly_readonly_dynrelocs): ..this.
* elfnn-riscv.c (readonly_dynrelocs): New function.
(maybe_set_textrel): New function, replacing old version of..
(readonly_dynrelocs): ..this.
* elfxx-sparc.c (readonly_dynrelocs): New function.
(maybe_set_textrel): New function, replacing old version of..
(readonly_dynrelocs): ..this.
* elfxx-tilegx.c (readonly_dynrelocs): New function.
(maybe_set_textrel): New function, replacing old version of..
(readonly_dynrelocs): ..this.
ld/
* testsuite/ld-elf/shared.exp: Run new textrel tests.
* testsuite/ld-elf/textrel.map: New file.
* testsuite/ld-elf/textrel.rd: New file.
* testsuite/ld-elf/textrel.s: New file.
* testsuite/ld-elf/textrel.warn: New file.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Replace mail address with the URL in copyright header
@ 2017-12-01 12:00 sergiodj+buildbot
2017-12-01 12:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-01 12:00 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 1cc75e929ff4e99b3bef4ca0e93250d5b1b126c9 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 1cc75e929ff4e99b3bef4ca0e93250d5b1b126c9
Replace mail address with the URL in copyright header
The copyright header in most of GDB files were changed from mail address
to the URL in the conversion to GPLv3 in Aug 2007. However, some files
still use mail address instead of the URL. This patch fixes them.
gdb/testsuite:
2017-12-01 Yao Qi <yao.qi@linaro.org>
* gdb.arch/aarch64-atomic-inst.exp: Replace mail address with
the URL in copyright header.
* gdb.arch/aarch64-fp.exp: Likewise.
* gdb.arch/ppc64-atomic-inst.exp: Likewise.
* gdb.arch/ppc64-isa207-atomic-inst.exp: Likewise.
* gdb.base/expand-psymtabs.exp: Likewise.
* gdb.cp/expand-psymtabs-cxx.exp: Likewise.
* gdb.fortran/common-block.exp: Likewise.
* gdb.fortran/common-block.f90: Likewise.
* gdb.fortran/logical.exp: Likewise.
* gdb.fortran/vla-datatypes.f90: Likewise.
* gdb.fortran/vla-sub.f90: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: Print dynreloc in readonly section for map file output
@ 2017-12-01 12:37 sergiodj+buildbot
2017-12-01 13:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-01 12:37 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 92f402a7e03f5d747bc9a09c8da2f61cc539ac33 ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 92f402a7e03f5d747bc9a09c8da2f61cc539ac33
x86: Print dynreloc in readonly section for map file output
This fixed:
FAIL: DT_TEXTREL map file warning
on Linux/x86.
* elfxx-x86.c (_bfd_x86_elf_readonly_dynrelocs): Print dynamic
relocation in readonly section for map file output.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Update GDB's list of maintainers to reflect today's reality
@ 2017-12-01 13:57 sergiodj+buildbot
2017-12-01 15:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-01 13:57 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2ee0c9b3eedca5d1071870334d2721be80a77ea1 ***
Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 2ee0c9b3eedca5d1071870334d2721be80a77ea1
Update GDB's list of maintainers to reflect today's reality
gdb/ChangeLog:
* MAINTAINERS: Update list of maintainers, moving those who
stepped down or became inactive to the "Past Maintainers"
section.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Use consistent types for holding instructions, instruction masks, etc.
@ 2017-12-01 17:42 sergiodj+buildbot
2017-12-01 18:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-01 17:42 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 0f873fd58b51a2906f31bb445ab685da04a1be23 ***
Author: Peter Bergner <bergner@vnet.ibm.com>
Branch: master
Commit: 0f873fd58b51a2906f31bb445ab685da04a1be23
Use consistent types for holding instructions, instruction masks, etc.
include/
* opcode/ppc.h (PPC_INT_FMT): Define.
(struct powerpc_opcode) <opcode>: Update type.
(struct powerpc_opcode) <mask>: Likewise.
(struct powerpc_opcode) <bitm>: Likewise.
(struct powerpc_opcode) <insert>: Likewise.
(struct powerpc_opcode) <extract>: Likewise.
(ppc_optional_operand_value): Likewise.
gas/
* config/tc-ppc.c (last_insn): Update type.
(insn_validate) <omask, mask>: Likewise.
(ppc_setup_opcodes) <mask, right_bit>: Likewise.
<PRINT_OPCODE_TABLE>: Update types and printf format specifiers.
(ppc_insert_operand): Update return and argument types and remove
unneeded type casts.
<min, max, right, tmp>: Update type.
(md_assemble): Remove unneeded type casts.
<insn, val, tmp_insn>: Update type.
opcodes/
* opcodes/ppc-dis.c (disassemble_init_powerpc): Fix white space.
(operand_value_powerpc): Update return and argument type.
<value, top>: Update type.
(skip_optional_operands): Update argument type.
(lookup_powerpc): Likewise.
(lookup_vle): Likewise.
<table_opcd, table_mask, insn2>: Update type.
(lookup_spe2): Update argument type.
<table_opcd, table_mask, insn2>: Update type.
(print_insn_powerpc) <insn, value>: Update type.
Use PPC_INT_FMT for printing instructions and operands.
* opcodes/ppc-opc.c (insert_arx, extract_arx, insert_ary, extract_ary,
insert_rx, extract_rx, insert_ry, extract_ry, insert_bat, extract_bat,
insert_bba, extract_bba, insert_bdm, extract_bdm, insert_bdp,
extract_bdp, valid_bo_pre_v2, valid_bo_post_v2, valid_bo, insert_bo,
extract_bo, insert_boe, extract_boe, insert_dcmxs, extract_dcmxs,
insert_dxd, extract_dxd, insert_dxdn, extract_dxdn, insert_fxm,
extract_fxm, insert_li20, extract_li20, insert_ls, extract_ls,
insert_esync, extract_esync, insert_mbe, extract_mbe, insert_mb6,
extract_mb6, extract_nb, insert_nbi, insert_nsi, extract_nsi,
insert_ral, extract_ral, insert_ram, extract_ram, insert_raq,
extract_raq, insert_ras, extract_ras, insert_rbs, extract_rbs,
insert_rbx, extract_rbx, insert_sci8, extract_sci8, insert_sci8n,
extract_sci8n, insert_sd4h, extract_sd4h, insert_sd4w, extract_sd4w,
insert_oimm, extract_oimm, insert_sh6, extract_sh6, insert_spr,
extract_spr, insert_sprg, extract_sprg, insert_tbr, extract_tbr,
insert_xt6, extract_xt6, insert_xtq6, extract_xtq6, insert_xa6,
extract_xa6, insert_xb6, extract_xb6, insert_xb6s, extract_xb6s,
insert_xc6, extract_xc6, insert_dm, extract_dm, insert_vlesi,
extract_vlesi, insert_vlensi, extract_vlensi, insert_vleui,
extract_vleui, insert_vleil, extract_vleil, insert_evuimm1_ex0,
extract_evuimm1_ex0, insert_evuimm2_ex0, extract_evuimm2_ex0,
insert_evuimm4_ex0, extract_evuimm4_ex0, insert_evuimm8_ex0,
extract_evuimm8_ex0, insert_evuimm_lt8, extract_evuimm_lt8,
insert_evuimm_lt16, extract_evuimm_lt16, insert_rD_rS_even,
extract_rD_rS_even, insert_off_lsp, extract_off_lsp, insert_off_spe2,
extract_off_spe2, insert_Ddd, extract_Ddd): Update types.
(OP, OPTO, OPL, OPVUP, OPVUPRT, A, AFRALFRC_MASK, B, BD8, BD8IO, BD15,
BD24, BBO, Y_MASK , AT1_MASK, AT2_MASK, BBOCB, C_LK, C, CTX, UCTX,
DX, EVSEL, IA16, I16A, I16L, IM7, LI20, MME, MD, MDS, SC, SC_MASK,
SCI8, SCI8BF, SD4, SE_IM5, SE_R, SE_RR, VX, VX_LSP, VX_RA_CONST,
VX_RB_CONST, VX_SPE_CRFD, VX_SPE2_CLR, VX_SPE2_SPLATB, VX_SPE2_OCTET,
VX_SPE2_DDHH, VX_SPE2_HH, VX_SPE2_EVMAR, VX_SPE2_EVMAR_MASK, VXA,
VXR, VXASH, X, EX, XX2, XX3, XX3RC, XX4, Z, XWRA_MASK, XLRT_MASK,
XRLARB_MASK, XLRAND_MASK, XRTLRA_MASK, XRTLRARB_MASK, XRTARARB_MASK,
XRTBFRARB_MASK, XOPL, XOPL2, XRCL, XRT, XRTRA, XCMP_MASK, XCMPL_MASK,
XTO, XTLB, XSYNC, XEH_MASK, XDSS, XFL, XISEL, XL, XLO, XLYLK, XLOCB,
XMBAR, XO, XOPS, XS, XFXM, XSPR, XUC, XW, APU): Update types in casts.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix typo in poison.h
@ 2017-12-03 1:53 sergiodj+buildbot
2017-12-03 2:23 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-03 1:53 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 6d83e819df0c71868d04db46c60ff0ecf8cf1914 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 6d83e819df0c71868d04db46c60ff0ecf8cf1914
Fix typo in poison.h
gdb/ChangeLog:
* common/poison.h (XDELETE): Fix typo.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove usage of find_inferior in regcache_invalidate_pid
@ 2017-12-03 2:14 sergiodj+buildbot
2017-12-03 3:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-03 2:14 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 634a3254c8fe1728c0202289afe594928094d860 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 634a3254c8fe1728c0202289afe594928094d860
Remove usage of find_inferior in regcache_invalidate_pid
Replace with for_each_thread with pid filtering.
regcache_invalidate_one is not longer needed, as it was only used to
filter the pid. We can call regcache_invalidate_thread directly.
gdb/gdbserver/ChangeLog:
* regcache.c (regcache_invalidate_one): Remove.
(regcache_invalidate_pid): use for_each_thread.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove usage of find_inferior in lynx_mourn
@ 2017-12-03 2:33 sergiodj+buildbot
2017-12-03 5:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-03 2:33 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c91bb56b06b52d45de7c8871a6d44ddae61ae977 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: c91bb56b06b52d45de7c8871a6d44ddae61ae977
Remove usage of find_inferior in lynx_mourn
Replace it with for_each_thread with pid filtering. We can remove
lynx_delete_thread_callback and pass remove_thread directly.
I can't build/test this change, but it should be obvious enough.
gdb/gdbserver/ChangeLog:
* lynx.low (lynx_delete_thread_callback): Remove.
(lynx_mourn): Use for_each_thread.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove usages of find_inferior in linux-mips-low.c
@ 2017-12-03 2:54 sergiodj+buildbot
2017-12-03 6:23 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-03 2:54 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT da25033cd92a60f4462e1468abfabfee02d0b8d9 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: da25033cd92a60f4462e1468abfabfee02d0b8d9
Remove usages of find_inferior in linux-mips-low.c
Replace with for_each_thread with pid filtering. This allows
simplifying the callback a little bit.
gdb/gdbserver/ChangeLog:
* linux-mips-low.c (update_watch_registers_callback): Return
void, remove pid_p parameter, don't check for pid.
(mips_insert_point, mips_remove_point): Use for_each_thread.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove find_inferior_in_random
@ 2017-12-03 6:09 sergiodj+buildbot
2017-12-03 10:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-03 6:09 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 83e1b6c13a285b4e1e852e1647667f09bb26892b ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 83e1b6c13a285b4e1e852e1647667f09bb26892b
Remove find_inferior_in_random
Replace with find_thread_in_random.
gdb/gdbserver/ChangeLog:
* inferiors.c (find_inferior_in_random): Remove.
* inferiors.h (find_inferior_in_random): Remove.
* linux-low.c (status_pending_p_callback): Return bool, accept
parameter ptid directly.
(linux_wait_for_event_filtered): Use find_thread_in_random.
(linux_wait_1): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove usages of find_inferior in select_event_lwp
@ 2017-12-03 6:32 sergiodj+buildbot
2017-12-03 18:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-03 6:32 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 39a64da5fc9ce6decd7e5ba0bacfeb2144d2bd63 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 39a64da5fc9ce6decd7e5ba0bacfeb2144d2bd63
Remove usages of find_inferior in select_event_lwp
Replace with find_thread/for_each_thread. I inlined the callbacks,
because they are relatively simple.
gdb/gdbserver/ChangeLog:
* linux-low.c (select_singlestep_lwp_callback): Remove.
(count_events_callback): Remove.
(select_event_lwp_callback): Remove.
(select_event_lwp): Use find_thread/for_each_thread.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove usages of find_inferior that call proceed_one_lwp
@ 2017-12-03 8:38 sergiodj+buildbot
2017-12-03 23:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-03 8:38 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e2b4407579df508f85de961dd693c9028e79d823 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: e2b4407579df508f85de961dd693c9028e79d823
Remove usages of find_inferior that call proceed_one_lwp
Replace with for_each_thread.
gdb/gdbserver/ChangeLog:
* linux-low.c (proceed_one_lwp): Return void, change parameter
type.
(unsuspend_and_proceed_one_lwp): Likewise.
(proceed_all_lwps): Use for_each_thread.
(unstop_all_lwps): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Update comments
@ 2017-12-03 8:58 sergiodj+buildbot
2017-12-04 0:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-03 8:58 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 8f86d7aa8504e9a557e807a3e37718055befcd84 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 8f86d7aa8504e9a557e807a3e37718055befcd84
Update comments
These functions were modified in the previous patch series, but I forgot
to update some comments.
gdb/gdbserver/ChangeLog:
* linux-low.c (resume_status_pending_p): Update comment.
(need_step_over_p): Update comment.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove for_each_inferior_with_data
@ 2017-12-03 10:05 sergiodj+buildbot
2017-12-04 4:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-03 10:05 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c0e15c9bfd6fb4bf36e5240838f6ebed1e1f4a7e ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: c0e15c9bfd6fb4bf36e5240838f6ebed1e1f4a7e
Remove for_each_inferior_with_data
Remove for_each_inferior_with_data, replacing its sole usage with
for_each_thread.
gdb/gdbserver/ChangeLog:
* inferiors.c (for_each_inferior_with_data): Remove.
* inferiors.h (for_each_inferior_with_data): Remove.
* server.c (handle_qxfer_threads_worker): Change parameter type.
(handle_qxfer_threads_proper): Use for_each_thread.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove usages of find_inferior calling not_stopped_callback
@ 2017-12-03 10:23 sergiodj+buildbot
2017-12-03 16:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-03 10:23 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a1385b7b881d2b129f8c26fac8ad20bc406a1a6d ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: a1385b7b881d2b129f8c26fac8ad20bc406a1a6d
Remove usages of find_inferior calling not_stopped_callback
Replace with find_thread. Writing a lambda inline in directly in the if
conditions would be a bit messy, so I chose to assign them to variables
instead.
gdb/gdbserver/ChangeLog:
* linux-low.c (not_stopped_callback): Return bool, take filter
argument directly.
(linux_wait_for_event_filtered): Use find_thread.
(linux_wait_1): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove usage of find_inferior in linux_stabilize_threads
@ 2017-12-03 12:00 sergiodj+buildbot
2017-12-03 19:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-03 12:00 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 5a6b0a41dfc9b860f285ddb3a1e518299f614cd3 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 5a6b0a41dfc9b860f285ddb3a1e518299f614cd3
Remove usage of find_inferior in linux_stabilize_threads
Replace with find_thread.
gdb/gdbserver/ChangeLog:
* linux-low.c (lwp_running): Return bool, remove unused
argument.
(linux_stabilize_threads): Use find_thread.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove find_inferior
@ 2017-12-03 15:50 sergiodj+buildbot
2017-12-04 1:39 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-03 15:50 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9521758bf967360fc1e18b2a2195d97ae19cb80d ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 9521758bf967360fc1e18b2a2195d97ae19cb80d
Remove find_inferior
All the usages of find_inferior were removed, so the function itself can
be removed.
gdb/gdbserver/ChangeLog:
* inferiors.h (find_inferior): Remove.
* inferiors.c (find_inferior): Remove.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Make make-target-delegates grok namespace scope op and template params
@ 2017-12-03 18:21 sergiodj+buildbot
2017-12-04 11:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-03 18:21 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 10f64178412d9c6e4f2faade0da271ab8be273c9 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 10f64178412d9c6e4f2faade0da271ab8be273c9
Make make-target-delegates grok namespace scope op and template params
The next patch will want to use gdb::array_view<int> as parameter type
of a target_ops method. However, that runs into a
make-target-delegates limitation: target_debug_foo calls in
target-delegates.c for parameters/return types with namespace scope
operators ("::") or template parameters, end up looking like:
@@ -1313,9 +1313,7 @@ debug_set_syscall_catchpoint (struct target_ops *self, int arg1, int arg2, int a
fputs_unfiltered (", ", gdb_stdlog);
target_debug_print_int (arg3);
fputs_unfiltered (", ", gdb_stdlog);
- target_debug_print_int (arg4);
- fputs_unfiltered (", ", gdb_stdlog);
- target_debug_print_int_p (arg5);
+ target_debug_print_gdb::array_view<const_int> (arg4);
which obviously isn't something that compiles. The problem is that
make-target-delegates wasn't ever taught that '::', '<', and '>' can
appear in parameter/return types. You could work around it by hidding
the unsupported characters behind a typedef in the target method
declaration, or by using an explicit TARGET_DEBUG_PRINTER, but it's
better to just remove the limitation.
While at it, also fix an "abuse" of reserved identifiers.
gdb/ChangeLog:
* make-target-delegates (munge_type): Also munge '<', '>', and
':'. Avoid double underscores in identifiers, and trailing
underscores.
* target-debug.h
(target_debug_print_VEC_static_tracepoint_marker_p__p): Rename to
...
(target_debug_print_VEC_static_tracepoint_marker_p_p): ... this.
* target-delegates.c: Regenerate.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove mem_region_vector typedef
@ 2017-12-03 18:49 sergiodj+buildbot
2017-12-04 13:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-03 18:49 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 1e97a22796cced8bba3359df46e8c2883653516f ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 1e97a22796cced8bba3359df46e8c2883653516f
Remove mem_region_vector typedef
Now that make-target-delegates understands namespaces and templates,
this typedef is no longer useful.
gdb/ChangeLog:
* target.h (mem_region_vector): Remove.
(struct target_ops) <to_memory_map>: Change return type to
std::vector<mem_region>.
* target-debug.h (target_debug_print_mem_region_vector): Rename
to ...
(target_debug_print_std_vector_mem_region): ... this.
* target-delegates.c: Re-generate.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix "FAIL: VLE relocations 3"
@ 2017-12-03 22:43 sergiodj+buildbot
2017-12-04 8:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-03 22:43 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f143cb5fc655e1ed0a6e15e6ba33af0d79ba1802 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: f143cb5fc655e1ed0a6e15e6ba33af0d79ba1802
Fix "FAIL: VLE relocations 3"
Correct sign extension.
* ppc-opc.c (extract_li20): Rewrite.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix displaced-stepping RIP-relative VEX-encoded instructions (AVX) (PR gdb/22499)
@ 2017-12-04 16:38 sergiodj+buildbot
2017-12-04 17:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-04 16:38 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 50a1fdd59c1777672a9be0e81fe2301c2a115fce ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 50a1fdd59c1777672a9be0e81fe2301c2a115fce
Fix displaced-stepping RIP-relative VEX-encoded instructions (AVX) (PR gdb/22499)
PR gdb/22499 is about a latent bug exposed by the switch to "maint set
target-non-stop on" by default on x86-64 GNU/Linux, a while ago. With
that on, GDB is also preferring to use displaced-stepping by default.
The testcase in the bug is failing because GDB ends up incorrectly
displaced-stepping over a RIP-relative VEX-encoded instruction, like
this:
0x00000000004007f5 <+15>: c5 fb 10 05 8b 01 00 00 vmovsd 0x18b(%rip),%xmm0 # 0x400988
While RIP-relative instructions need adjustment when relocated to the
scratch pad, GDB ends up just copying VEX-encoded instructions to the
scratch pad unmodified, with the end result that the inferior ends up
executing an instruction that fetches/writes memory from the wrong
address...
This patch teaches GDB about the VEX-encoding prefixes, fixing the
problem, and adds a testcase that fails without the GDB fix.
I think we may need a similar treatment for EVEX-encoded instructions,
but I didn't address that simply because I couldn't find any
EVEX-encoded RIP-relative instruction in the gas testsuite. In any
case, this commit is forward progress as-is already.
gdb/ChangeLog:
2017-12-04 Pedro Alves <palves@redhat.com>
PR gdb/22499
* amd64-tdep.c (amd64_insn::rex_offset): Rename to...
(amd64_insn::enc_prefix_offset): ... this, and tweak comment.
(vex2_prefix_p, vex3_prefix_p): New functions.
(amd64_get_insn_details): Adjust to rename. Also skip VEX2 and
VEX3 prefixes.
(fixup_riprel): Set VEX3.!B.
gdb/testsuite/ChangeLog:
2017-12-04 Pedro Alves <palves@redhat.com>
PR gdb/22499
* gdb.arch/amd64-disp-step-avx.S: New file.
* gdb.arch/amd64-disp-step-avx.exp: New file.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Implement 'set dump-excluded-mappings' command
@ 2017-12-04 18:06 sergiodj+buildbot
2017-12-04 19:41 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-04 18:06 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT afa840dcc021eaeb975dcde3bedbf46ea0511717 ***
Author: Sergio Lopez <slp@redhat.com>
Branch: master
Commit: afa840dcc021eaeb975dcde3bedbf46ea0511717
Implement 'set dump-excluded-mappings' command
Commit df8411da087dc05481926f4c4a82deabc5bc3859 implemented support for
checking /proc/PID/coredump_filter, and also changed gcore behavior to
unconditionally honor the VM_DONTDUMP flag, preventing sections marked
as such for being dumped into the core file.
This patch implements the 'set dump-excluded-mappings' command for
instructing gdb to ignore the VM_DONTDUMP flag. Combined with 'set
use-coredump-filter', this allows the user to restore the old behavior,
dumping all sections (except the ones marked as IO) unconditionally.
gdb/Changelog:
2017-11-29 Sergio Lopez <slp@redhat.com>
* linux-tdep.c (dump_excluded_mappings): New variable.
(dump_mapping_p): Use dump_excluded_mappings variable.
(_initialize_linux_tdep): New command 'set dump_excluded_mappings'.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove some unused variables
@ 2017-12-05 21:31 sergiodj+buildbot
2017-12-05 22:02 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-05 21:31 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 798a7429f980a00844c22dfdda9475c451c635d4 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 798a7429f980a00844c22dfdda9475c451c635d4
Remove some unused variables
This patch removes some unused variables, found with -Wunused. I have
not removed everything reported by -Wunused, because some expressions
such as
struct type *arg_type = check_typedef (value_type);
in bfin-tdep.c could have an unexpected but important side-effect. I
removed others that I considered more low-risk, such as:
struct gdbarch *gdbarch = get_objfile_arch (objfile);
I tested building with Python 2/Python 3/no Python, with/without expat,
with/without libipt and with/without babeltrace.
gdb/ChangeLog:
* ada-lang.c (ada_collect_symbol_completion_matches): Remove
unused variables.
(ada_is_redundant_range_encoding): Likewise.
* ada-varobj.c (ada_varobj_get_value_of_array_variable):
Likewise.
* alpha-tdep.c (alpha_software_single_step): Likewise.
* arm-tdep.c (_initialize_arm_tdep): Likewise.
* auto-load.c (info_auto_load_cmd): Likewise.
* break-catch-syscall.c (insert_catch_syscall): Likewise.
(remove_catch_syscall): Likewise.
* breakpoint.c (condition_completer): Likewise.
(clear_command): Likewise.
(update_breakpoint_locations): Likewise.
* btrace.c (btrace_disable): Likewise.
(btrace_teardown): Likewise.
(btrace_maint_update_pt_packets): Likewise.
(maint_btrace_clear_cmd): Likewise.
* cli/cli-decode.c (lookup_cmd_1): Likewise.
(lookup_cmd_composition): Likewise.
* cli/cli-dump.c (scan_filename): Likewise.
(restore_command): Likewise.
* compile/compile-loc2c.c (compute_stack_depth): Likewise.
* compile/compile-object-load.c (compile_object_load): Likewise.
* compile/compile-object-run.c (compile_object_run): Likewise.
* compile/compile.c (compile_to_object): Likewise.
* completer.c (filename_completer): Likewise.
(complete_files_symbols): Likewise.
(complete_expression): Likewise.
* corelow.c (core_open): Likewise.
* ctf.c (ctf_start): Likewise.
(ctf_write_status): Likewise.
(ctf_write_uploaded_tsv): Likewise.
(ctf_write_definition_end): Likewise.
(ctf_open_dir): Likewise.
(ctf_xfer_partial): Likewise.
(ctf_trace_find): Likewise.
* disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
Likewise.
* dwarf2loc.c (allocate_piece_closure): Likewise.
(indirect_pieced_value): Likewise.
(dwarf2_evaluate_loc_desc_full): Likewise.
* dwarf2read.c (dw2_expand_marked_cus): Likewise.
(dw2_expand_symtabs_matching): Likewise.
(dw2_map_symbol_filenames): Likewise.
(read_and_check_comp_unit_head): Likewise.
(read_cutu_die_from_dwo): Likewise.
(lookup_dwo_unit): Likewise.
(read_comp_units_from_section): Likewise.
(dwarf2_compute_name): Likewise.
(handle_DW_AT_stmt_list): Likewise.
(create_cus_hash_table): Likewise.
(create_dwp_v2_section): Likewise.
(dwarf2_rnglists_process): Likewise.
(dwarf2_ranges_process): Likewise.
(dwarf2_record_block_ranges): Likewise.
(is_vtable_name): Likewise.
(read_formatted_entries): Likewise.
(skip_form_bytes): Likewise.
* elfread.c (elf_symtab_read): Likewise.
* exec.c (exec_file_command): Likewise.
* f-valprint.c (f_val_print): Likewise.
(info_common_command_for_block): Likewise.
* guile/guile.c (initialize_scheme_side): Likewise.
* guile/scm-breakpoint.c (gdbscm_breakpoint_commands): Likewise.
* guile/scm-cmd.c (cmdscm_completer): Likewise.
(gdbscm_register_command_x): Likewise.
* guile/scm-frame.c (gdbscm_frame_read_var): Likewise.
* guile/scm-param.c (gdbscm_parameter_value): Likewise.
* guile/scm-ports.c (file_port_magic): Likewise.
* guile/scm-pretty-print.c (ppscm_search_pp_list): Likewise.
(ppscm_pretty_print_one_value): Likewise.
(ppscm_print_children): Likewise.
* guile/scm-string.c (gdbscm_string_to_argv): Likewise.
* guile/scm-symtab.c (gdbscm_sal_symtab): Likewise.
* guile/scm-type.c (gdbscm_type_next_field_x): Likewise.
* guile/scm-utils.c (gdbscm_parse_function_args): Likewise.
* i386-tdep.c (i386_register_reggroup_p): Likewise.
* infcmd.c (run_command_1): Likewise.
(until_next_fsm_clean_up): Likewise.
* linespec.c (linespec_complete): Likewise.
(find_label_symbols): Likewise.
* m2-valprint.c (m2_val_print): Likewise.
* memattr.c (require_user_regions): Likewise.
(lookup_mem_region): Likewise.
(disable_mem_command): Likewise.
(mem_delete): Likewise.
* mep-tdep.c (mep_register_name): Likewise.
(mep_analyze_prologue): Likewise.
* mi/mi-cmd-file.c (mi_cmd_file_list_shared_libraries): Likewise.
* mi/mi-interp.c (mi_on_sync_execution_done): Likewise.
* mi/mi-main.c (mi_cmd_trace_frame_collected): Likewise.
* microblaze-linux-tdep.c (microblaze_linux_init_abi): Likewise.
* minidebug.c (lzma_open): Likewise.
* minsyms.c (lookup_minimal_symbol): Likewise.
* mips-linux-tdep.c (mips64_fill_fpregset): Likewise.
* mips-tdep.c (mips_stub_frame_sniffer): Likewise.
(mips_o64_return_value): Likewise.
(mips_single_step_through_delay): Likewise.
(_initialize_mips_tdep): Likewise.
* nios2-tdep.c (nios2_push_dummy_call): Likewise.
(nios2_software_single_step): Likewise.
* parse.c (find_minsym_type_and_address): Likewise.
* psymtab.c (psym_relocate): Likewise.
* python/py-breakpoint.c (bppy_get_commands): Likewise.
(gdbpy_breakpoint_modified): Likewise.
* python/py-infevents.c (create_inferior_call_event_object):
Likewise.
* python/py-record-btrace.c (btpy_list_item): Likewise.
* python/py-type.c (typy_str): Likewise.
* python/py-value.c (valpy_call): Likewise.
* python/python.c (do_start_initialization): Likewise.
* record-btrace.c (record_btrace_insn_history_range): Likewise.
(record_btrace_call_history_range): Likewise.
(record_btrace_record_method): Likewise.
(record_btrace_xfer_partial): Likewise.
(btrace_get_frame_function): Likewise.
* record-full.c (record_full_open): Likewise.
* record.c (get_context_size): Likewise.
* registry.h (DEFINE_REGISTRY): Likewise.
* remote-fileio.c (remote_fileio_request): Likewise.
* remote.c (remote_update_thread_list): Likewise.
(remote_check_symbols): Likewise.
(remote_commit_resume): Likewise.
(remote_interrupt): Likewise.
(remote_insert_breakpoint): Likewise.
(compare_sections_command): Likewise.
* rust-exp.y (super_name): Likewise.
(lex_string): Likewise.
(convert_ast_to_type): Likewise.
(convert_ast_to_expression): Likewise.
* rust-lang.c (rust_print_struct_def): Likewise.
(rust_print_type): Likewise.
(rust_evaluate_subexp): Likewise.
* rx-tdep.c (rx_register_type): Likewise.
* ser-event.c (serial_event_clear): Likewise.
* serial.c (serial_open): Likewise.
* spu-tdep.c (spu_overlay_new_objfile): Likewise.
* symfile.c (section_is_overlay): Likewise.
(overlay_unmapped_address): Likewise.
(overlay_mapped_address): Likewise.
(simple_overlay_update_1): Likewise.
(simple_overlay_update): Likewise.
* symtab.c (symbol_find_demangled_name): Likewise.
(search_symbols): Likewise.
* target-descriptions.c (tdesc_predefined_type): Likewise.
* target.c (target_commit_resume): Likewise.
* thread.c (print_selected_thread_frame): Likewise.
* top.c (new_ui_command): Likewise.
(gdb_readline_no_editing): Likewise.
* tracefile-tfile.c (tfile_open): Likewise.
* tracepoint.c (create_tsv_from_upload): Likewise.
* utils.c (quit): Likewise.
(defaulted_query): Likewise.
* valarith.c (value_concat): Likewise.
* xml-syscall.c (xml_list_syscalls_by_group): Likewise.
* xml-tdesc.c (target_fetch_description_xml): Likewise.
* xtensa-tdep.c (xtensa_pseudo_register_read): Likewise.
(xtensa_pseudo_register_write): Likewise.
gdb/gdbserver/ChangeLog:
* regcache.c (registers_to_string): Remove unused variable.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Redefine gdb_static_assert as static_assert
@ 2017-12-05 22:06 sergiodj+buildbot
2017-12-05 23:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-05 22:06 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ed9376bd95c52ba00aa37b224b4407030a00d184 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: ed9376bd95c52ba00aa37b224b4407030a00d184
Redefine gdb_static_assert as static_assert
Since we use C++11, we can use static_assert instead doing the trick
that makes a negative-sized array if the expression is false.
static_assert is built in the language and gives clearer error messages.
To avoid modifying the usages of gdb_static_assert, redefine
gdb_static_assert in terms of static_assert, passing an empty message.
If we want to add an assert with a message, it's always possible to use
static_assert directly.
gdb/ChangeLog:
* common/gdb_assert.h (gdb_static_assert): Redefine using
static_assert.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Make target_desc::properties an std::vector
@ 2017-12-05 22:53 sergiodj+buildbot
2017-12-06 0:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-05 22:53 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 129c10bcb9b3bc2ed9682040aa9a0d144bb5e959 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 129c10bcb9b3bc2ed9682040aa9a0d144bb5e959
Make target_desc::properties an std::vector
This patch changes target_desc::properties to be a vector of property
objects. This way, we don't need to manually free the property members
as well as the property objects themselves.
gdb/ChangeLog:
* target-descriptions.c (property_s): Remove typedef.
(DEF_VEC_O (property_s)): Remove.
(struct target_desc) <properties>: Make an std::vector.
<~target_desc>: Don't manually free properties.
(tdesc_property): Adjust.
(set_tdesc_property): Adjust.
(class print_c_tdesc) <visit_pre>: Adjust.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Make tdesc_feature::name an std::string
@ 2017-12-06 0:02 sergiodj+buildbot
2017-12-06 5:25 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-06 0:02 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f65ff9f9a4add415e5ae332a094b2134c1625517 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: f65ff9f9a4add415e5ae332a094b2134c1625517
Make tdesc_feature::name an std::string
... so we don't have to manually free it in ~tdesc_feature.
gdb/ChangeLog:
* target-descriptions.c (tdesc_feature) <name>: Change type to
std::string.
<~tdesc_feature>: Don't manually free name.
<operator==>: Adjust.
(tdesc_find_feature): Adjust.
(tdesc_feature_name): Adjust.
(class print_c_tdesc) <visit_pre>: Adjust.
(class print_c_feature) <visit_pre>: Adjust.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Make tdesc_feature::registers an std::vector
@ 2017-12-06 0:22 sergiodj+buildbot
2017-12-06 6:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-06 0:22 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c9c895b9666e33a2b910faf9c1b667ea665f00f1 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: c9c895b9666e33a2b910faf9c1b667ea665f00f1
Make tdesc_feature::registers an std::vector
This patch makes tdesc_feature::registers an std::vector of unique_ptr
to tdesc_reg. This way, we don't have to manually free the tdesc_reg
objects and the vector in the tdesc_feature destructor.
gdb/ChangeLog:
* target-descriptions.c (tdesc_reg_p): Remove typedef.
(DEF_VEC_P (tdesc_reg_p)): Remove.
(struct tdesc_feature) <registers>: Change type to std::vector.
<~tdesc_feature>: Don't manually free registers.
<accept>: Adjust.
<operator==>: Adjust.
(tdesc_has_registers): Adjust.
(tdesc_find_register_early): Adjust.
(tdesc_use_registers): Adjust.
(tdesc_create_reg): Adjust.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Make target_desc::features an std::vector
@ 2017-12-06 0:22 sergiodj+buildbot
2017-12-06 4:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-06 0:22 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 3eea796c5daeb7b60531fc3d707470fa91a86e11 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 3eea796c5daeb7b60531fc3d707470fa91a86e11
Make target_desc::features an std::vector
This patch makes target_desc to be a vector of unique_ptr to
tdesc_feature objects. This way, we don't have to manually free the
features and the vector in the target_desc destructor.
gdb/ChangeLog:
* target-descriptions.c (tdesc_feature_p): Remove typedef.
(DEF_VEC_P (tdesc_feature_p)): Remove.
(struct target_desc) <features>: Change type to std::vector.
<~target_desc>: Replace with default implementation.
<accept>: Adjust.
<operator==>: Adjust.
(tdesc_has_registers): Adjust.
(tdesc_find_feature): Adjust.
(tdesc_use_registers): Adjust.
(tdesc_create_feature): Adjust.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Make tdesc_reg string fields std::string
@ 2017-12-06 0:44 sergiodj+buildbot
2017-12-06 7:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-06 0:44 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a8142ee195063e8c7202429e80ee58185c34b3fc ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: a8142ee195063e8c7202429e80ee58185c34b3fc
Make tdesc_reg string fields std::string
Make the name, group and type fields of tdesc_reg std::strings. This
way, we don't have to manually free them in ~tdesc_reg.
Doing so results in a small change in the generated tdesc. Instead of
passing an empty string for the group parameter of tdesc_create_reg, the
two modified tdesc now pass NULL. The end result should be the same.
gdb/ChangeLog:
* target-descriptions.c (struct tdesc_reg) <tdesc_reg>: Change
type of name_ parameter, adjust to std::string change.
<name, group, type>: Change type to std::string.
<~tdesc_reg>: Replace with default implementation.
<operator==>: Adjust.
(tdesc_find_register_early): Adjust.
(tdesc_register_name): Adjust.
(tdesc_register_type): Adjust.
(tdesc_register_in_reggroup_p): Adjust.
(class print_c_tdesc) <visit>: Adjust.
(class print_c_feature) <visit>: Adjust.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Make tdesc_feature::types an std::vector
@ 2017-12-06 1:05 sergiodj+buildbot
2017-12-06 9:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-06 1:05 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 53c934e9fed9a35542661690e4e71febcbebb539 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 53c934e9fed9a35542661690e4e71febcbebb539
Make tdesc_feature::types an std::vector
This patch makes tdesc_feature::types an std::vector of unique_ptr of
tdesc_type. This way, we don't need to manually free the objects and
the vector in ~tdesc_feature.
gdb/ChangeLog:
* target-descriptions.c (tdesc_type_p): Remove typedef.
(DEF_VEC_P (tdesc_type_p)): Remove.
(struct tdesc_feature) <types>: Change type to std::vector.
<~tdesc_feature>: Replace with default implementation.
<accept>: Adjust.
(tdesc_named_type): Adjust.
(tdesc_create_vector): Adjust.
(tdesc_create_struct): Adjust.
(tdesc_create_union): Adjust.
(tdesc_create_flags): Adjust.
(tdesc_create_enum): Adjust.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Make tdesc_type::name an std::string
@ 2017-12-06 1:26 sergiodj+buildbot
2017-12-06 11:06 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-06 1:26 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 082b9140d953b9e6a78271384ec48ff5d0ba8fad ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 082b9140d953b9e6a78271384ec48ff5d0ba8fad
Make tdesc_type::name an std::string
This patch makes tdesc_type::name an std::string. This way, we don't
need to free it manually in ~tdesc_type. I think the comment on top of
name is not correct, the string is always malloc'ed.
gdb/ChangeLog:
* target-descriptions.c (struct tdesc_type) <name>: Change type
to std::string.
<~tdesc_type>: Don't manually free name.
<operator==>: Adjust.
(tdesc_named_type): Adjust.
(tdesc_find_type): Adjust.
(tdesc_gdb_type): Adjust.
(class print_c_tdesc) <visit>: Adjust.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Split tdesc_type into multiple classes
@ 2017-12-06 2:59 sergiodj+buildbot
2017-12-06 14:54 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-06 2:59 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d4a0e8b57d6f85e4ee4a31e0e6929ff5b4fd9823 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: d4a0e8b57d6f85e4ee4a31e0e6929ff5b4fd9823
Split tdesc_type into multiple classes
This patch makes tdesc_type an abstract base class and creates three
subclasses:
- tdesc_type_builtin, for builtin types
- tdesc_type_vector, for vector types
- tdesc_type_with_fields, for struct, union, flag and enum types
This allows getting rid of the union in tdesc_type and to not allow the
std::vector separately. I tried to go further and create separate
classes for struct, union, flag and enum, but it proved too difficult.
One problem is that from the point of the of the target description
code, the types tdesc_type_* are opaque (only forward-declared).
Therefore, it doesn't know about inheritance relationship between those
classes. This makes it impossible to make functions that accept a
pointer to a base class and pass a pointer to a derived class, for
example. I think this patch here is a good compromise, and if somebody
wants to improve things further, the door is open.
A make_gdb_type virtual pure method is added to tdesc_type, which
replaces the current tdesc_gdb_type function. Calling this method on a
tdesc_type returns the corresponding built gdb type.
gdb/ChangeLog:
* target-descriptions.c (struct tdesc_type): Use default
destructor.
<u>: Remove.
<accept>: Remove.
(struct tdesc_type_builtin): New.
(struct tdesc_type_vector): New.
(struct tdesc_type_with_fields): New.
(tdesc_predefined_types): Change type to tdesc_type_builtin[].
(tdesc_gdb_type): Remove.
(tdesc_register_type): Adjust.
(tdesc_create_vector): Create tdesc_type_vector.
(tdesc_create_struct): Create tdesc_type_with_fields.
(tdesc_set_struct_size): Change parameter type.
(tdesc_create_union): Create tdesc_type_with_fields.
(tdesc_create_flags): Likewise.
(tdesc_create_enum): Likewise.
(tdesc_add_field): Change parameter type.
(tdesc_add_typed_bitfield): Likewise.
(tdesc_add_bitfield): Likewise.
(tdesc_add_flag): Likewise.
(tdesc_add_enum_value): Likewise.
(print_c_tdesc) <visit>: Remove overload with tdesc_type
parameter, add overloads for tdesc_type_builtin,
tdesc_type_with_fields and tdesc_type_vector.
<m_printed_type>: Remove.
<m_printed_element_type, m_printed_type_with_fields>: Add.
* target-descriptions.h (tdesc_create_enum): Change return type.
(tdesc_add_typed_bitfield): Change parameter type.
(tdesc_add_enum_value): Change parameter type.
* xml-tdesc.c (struct tdesc_parsing_data) <current_type>: Change
type to tdesc_type_with_fields.
(tdesc_start_struct): Adjust.
(tdesc_start_flags): Adjust.
(tdesc_start_enum): Adjust.
(tdesc_start_field): Adjust.
* arch/tdesc.h (struct tdesc_type_builtin): Forward-declare.
(struct tdesc_type_vector): Forward-declare.
(struct tdesc_type_with_fields): Forward-declare.
(tdesc_create_struct): Change return type.
(tdesc_create_union): Likewise.
(tdesc_create_flags): Likewise.
(tdesc_add_field): Change parameter type.
(tdesc_set_struct_size): Likewise.
(tdesc_add_bitfield): Likewise.
(tdesc_add_flag): Likewise.
* features: Re-generate C files.
gdb/gdbserver/ChangeLog:
* tdesc.c (struct tdesc_type): Change return type.
(tdesc_add_flag): Change parameter type.
(tdesc_add_bitfield): Likewise.
(tdesc_add_field): Likewise.
(tdesc_set_struct_size): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Make tdesc_type::u::u::fields an std::vector
@ 2017-12-06 5:26 sergiodj+buildbot
2017-12-06 12:23 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-06 5:26 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d05200d155f065b93e2dc353a7d33408c7574e9c ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: d05200d155f065b93e2dc353a7d33408c7574e9c
Make tdesc_type::u::u::fields an std::vector
This patch makes the tdesc_type::u::u::fields an std::vector of
tdesc_type_field. The difficulty here is that the vector is part of a
union. Because of this, I made fields a pointer to a vector, and
instantiate/destroy the vector if the type is one that uses this member
of the union
The field tdesc_type_field::name is changed to an std::string at the
same time.
gdb/ChangeLog:
* target-descriptions.c (tdesc_type_field): Remove typedef.
(DEF_VEC_O (tdesc_type_field)): Remove.
(struct tdesc_type_field): Add constructor.
<name>: Change type to std::string.
(struct tdesc_type) <tdesc_type>: Instantiate vector if the type
kind uses it.
<~tdesc_type>: Destroy vector if the type kind uses it.
<u::u::fields>: Change type to std::vector.
(tdesc_gdb_type): Adjust.
(tdesc_add_field): Adjust.
(tdesc_add_typed_bitfield): Adjust.
(tdesc_add_field): Adjust.
(tdesc_add_enum_value): Adjust.
(class print_c_tdesc) <visit>: Adjust.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Comment tidy
@ 2017-12-06 7:50 sergiodj+buildbot
2017-12-06 17:25 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-06 7:50 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT dce2246a6c934bf35157e8970d0da5a11aefb282 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: dce2246a6c934bf35157e8970d0da5a11aefb282
Comment tidy
Past tense is wrong for a comment before some action.
* elf32-ppc.c (ppc_elf_adjust_dynamic_symbol): Comment tidy.
* elf64-ppc.c (ppc64_elf_adjust_dynamic_symbol): Likewise.
* elfnn-aarch64.c (elfNN_aarch64_adjust_dynamic_symbol): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] dyn_relocs tidy
@ 2017-12-06 8:12 sergiodj+buildbot
2017-12-06 18:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-06 8:12 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 3bf083ed23b1337341129b810ed5da29ba8207f9 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 3bf083ed23b1337341129b810ed5da29ba8207f9
dyn_relocs tidy
Many targets define their own dyn_relocs struct when they could use
struct elf_dyn_relocs. This patch tidies that, and uses
readonly_dynrelocs in a few more places.
The SH adjust_dynamic_symbol had some really weird code dating back to
2002 that looked over dynamic relocations for any in SEC_HAS_CONTENTS
or SEC_READONLY sections, rather than just the usual SEC_READONLY
sections. So basically any dynamic relocation. What's more, the SH
relocate_section has no support for emitting dynamic relocations in
non-PIC. In other words, SH has no support for avoiding copy relocs
in non-PIC. I've made that more obvious by using "if (0 && ..)" in
asjust_dynamic_symbol.
Unfortunately, LM32, M32R, NDS32, and OR1K copied the bogus SH
adjust_dynamic_symbol code. So none of those targets would have
avoided copy relocs. LM32, M32R, NDS32 get the "if (0)" treatment
too. (LM32 is even more broken in that non_got_ref is never set.)
OR1K relocate_section looks like it might support dynamic relocs in
non-PIC, so I've enabled the copy reloc avoidance code for that
target.
* elf32-hppa.c (struct elf32_hppa_dyn_reloc_entry): Delete. Use
struct elf_dyn_relocs throughout file instead.
(elf32_hppa_adjust_dynamic_symbol): Comment tidy.
* elf32-lm32.c (struct elf_lm32_dyn_relocs): Delete. Use
struct elf_dyn_relocs throughout file instead.
(lm32_elf_adjust_dynamic_symbol): Use readonly_dynrelocs, but disable.
Disable -z no-copyreloc too.
* elf32-m32r.c (struct elf_m32r_dyn_relocs): Delete. Use
struct elf_dyn_relocs throughout file instead.
(m32r_elf_adjust_dynamic_symbol): Use readonly_dynrelocs, but disable.
Disable -z no-copyreloc too.
* elf32-metag.c (struct elf_metag_dyn_reloc_entry): Delete. Use
struct elf_dyn_relocs throughout file instead.
(elf_metag_adjust_dynamic_symbol): Use readonly_dynrelocs.
* elf32-microblaze.c (struct elf32_mb_dyn_relocs): Delete. Use
struct elf_dyn_relocs throughout file instead.
(readonly_dynrelocs): New function.
(microblaze_elf_adjust_dynamic_symbol): Use it.
* elf32-nds32.c (struct elf_nds32_dyn_relocs): Delete. Use
struct elf_dyn_relocs throughout file instead.
(nds32_elf_adjust_dynamic_symbol): Use readonly_dynrelocs, but disable.
Disable -z no-copyreloc too.
* elf32-nios2.c (struct elf32_nios2_dyn_relocs): Delete. Use
struct elf_dyn_relocs throughout file instead.
* elf32-or1k.c (struct elf_or1k_dyn_relocs): Delete. Use
struct elf_dyn_relocs throughout file instead.
(or1k_elf_adjust_dynamic_symbol): Use readonly_dynrelocs.
* elf32-sh.c (struct elf_sh_dyn_relocs): Delete. Use
struct elf_dyn_relocs throughout file instead.
(sh_elf_adjust_dynamic_symbol): Use readonly_dynrelocs, but disable.
Disable -z no-copyreloc too.
* elf32-tilepro.c (struct tilepro_elf_dyn_relocs): Delete. Use
struct elf_dyn_relocs throughout file instead.
(tilepro_elf_adjust_dynamic_symbol): Use readonly_dynrelocs.
* elfnn-riscv.c (struct riscv_elf_dyn_relocs): Delete. Use
struct elf_dyn_relocs throughout file instead.
(riscv_elf_adjust_dynamic_symbol): Use readonly_dynrelocs.
* elfxx-sparc.c (struct _bfd_sparc_elf_dyn_relocs): Delete. Use
struct elf_dyn_relocs throughout file instead.
(_bfd_sparc_elf_adjust_dynamic_symbol): Use readonly_dynrelocs.
* elfxx-tilegx.c (struct tilegx_elf_dyn_relocs): Delete. Use
struct elf_dyn_relocs throughout file instead.
(tilegx_elf_adjust_dynamic_symbol): Use readonly_dynrelocs.
* elf32-s390.c (elf_s390_adjust_dynamic_symbol): Use readonly_dynrelocs.
* elf64-s390.c (elf_s390_adjust_dynamic_symbol): Use readonly_dynrelocs.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix Common symbol override test fails
@ 2017-12-06 8:32 sergiodj+buildbot
2017-12-06 20:02 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-06 8:32 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 65281396861dfcfa993eb5af4769d6837104890d ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 65281396861dfcfa993eb5af4769d6837104890d
Fix Common symbol override test fails
Fixes fails on SH and NDS32 introduced by dyn_reloc tidy.
* elf32-lm32.c (lm32_elf_check_relocs): Skip non-ALLOC sections.
* elf32-m32r.c (m32r_elf_check_relocs): Likewise.
* elf32-nds32.c (nds32_elf_check_relocs): Likewise.
* elf32-or1k.c (or1k_elf_check_relocs): Likewise.
* elf32-sh.c (sh_elf_check_relocs): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] BFD whitespace fixes
@ 2017-12-06 8:55 sergiodj+buildbot
2017-12-06 21:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-06 8:55 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 07d6d2b8345ef3dc82eab49635acac9ee67dbb18 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 07d6d2b8345ef3dc82eab49635acac9ee67dbb18
BFD whitespace fixes
Binutils is supposed to use tabs. In my git config I have
whitespace = indent-with-non-tab,space-before-tab,trailing-space
and I got annoyed enough seeing red in "git diff" output to fix
the problems.
* doc/header.sed: Trim trailing space when splitting lines.
* aix386-core.c, * aout-adobe.c, * aout-arm.c, * aout-cris.c,
* aout-ns32k.c, * aout-target.h, * aout-tic30.c, * aoutf1.h, * aoutx.h,
* arc-got.h, * arc-plt.def, * arc-plt.h, * archive.c, * archive64.c,
* archures.c, * armnetbsd.c, * bfd-in.h, * bfd.c, * bfdio.c, * binary.c,
* bout.c, * cache.c, * cisco-core.c, * coff-alpha.c, * coff-apollo.c,
* coff-arm.c, * coff-h8300.c, * coff-i386.c, * coff-i860.c,
* coff-i960.c, * coff-m68k.c, * coff-m88k.c, * coff-mcore.c,
* coff-mips.c, * coff-ppc.c, * coff-rs6000.c, * coff-sh.c,
* coff-stgo32.c, * coff-tic4x.c, * coff-tic54x.c, * coff-tic80.c,
* coff-we32k.c, * coff-x86_64.c, * coff-z80.c, * coff-z8k.c,
* coff64-rs6000.c, * coffcode.h, * coffgen.c, * cofflink.c,
* coffswap.h, * compress.c, * corefile.c, * cpu-alpha.c, * cpu-arm.c,
* cpu-avr.c, * cpu-bfin.c, * cpu-cr16.c, * cpu-cr16c.c, * cpu-crx.c,
* cpu-d10v.c, * cpu-frv.c, * cpu-ft32.c, * cpu-i370.c, * cpu-i960.c,
* cpu-ia64-opc.c, * cpu-ip2k.c, * cpu-lm32.c, * cpu-m32r.c,
* cpu-mcore.c, * cpu-microblaze.c, * cpu-mips.c, * cpu-moxie.c,
* cpu-mt.c, * cpu-nios2.c, * cpu-ns32k.c, * cpu-or1k.c, * cpu-powerpc.c,
* cpu-pru.c, * cpu-sh.c, * cpu-spu.c, * cpu-v850.c, * cpu-v850_rh850.c,
* cpu-xgate.c, * cpu-z80.c, * dwarf1.c, * dwarf2.c, * ecoff.c,
* ecofflink.c, * ecoffswap.h, * elf-bfd.h, * elf-eh-frame.c,
* elf-hppa.h, * elf-m10200.c, * elf-m10300.c, * elf-s390-common.c,
* elf-strtab.c, * elf-vxworks.c, * elf.c, * elf32-am33lin.c,
* elf32-arc.c, * elf32-arm.c, * elf32-avr.c, * elf32-avr.h,
* elf32-bfin.c, * elf32-cr16.c, * elf32-cr16c.c, * elf32-cris.c,
* elf32-crx.c, * elf32-d10v.c, * elf32-d30v.c, * elf32-dlx.c,
* elf32-epiphany.c, * elf32-fr30.c, * elf32-frv.c, * elf32-ft32.c,
* elf32-h8300.c, * elf32-hppa.c, * elf32-i386.c, * elf32-i860.c,
* elf32-i960.c, * elf32-ip2k.c, * elf32-lm32.c, * elf32-m32c.c,
* elf32-m32r.c, * elf32-m68hc11.c, * elf32-m68hc12.c, * elf32-m68hc1x.c,
* elf32-m68hc1x.h, * elf32-m68k.c, * elf32-m88k.c, * elf32-mcore.c,
* elf32-mep.c, * elf32-metag.c, * elf32-microblaze.c, * elf32-mips.c,
* elf32-moxie.c, * elf32-msp430.c, * elf32-mt.c, * elf32-nds32.c,
* elf32-nds32.h, * elf32-nios2.c, * elf32-or1k.c, * elf32-pj.c,
* elf32-ppc.c, * elf32-ppc.h, * elf32-pru.c, * elf32-rl78.c,
* elf32-rx.c, * elf32-s390.c, * elf32-score.c, * elf32-score.h,
* elf32-score7.c, * elf32-sh-symbian.c, * elf32-sh.c, * elf32-sh64.c,
* elf32-sparc.c, * elf32-spu.c, * elf32-tic6x.c, * elf32-tilegx.c,
* elf32-tilegx.h, * elf32-tilepro.c, * elf32-tilepro.h, * elf32-v850.c,
* elf32-vax.c, * elf32-wasm32.c, * elf32-xc16x.c, * elf32-xgate.c,
* elf32-xgate.h, * elf32-xstormy16.c, * elf32-xtensa.c, * elf64-alpha.c,
* elf64-hppa.c, * elf64-ia64-vms.c, * elf64-mips.c, * elf64-mmix.c,
* elf64-ppc.c, * elf64-s390.c, * elf64-sh64.c, * elf64-sparc.c,
* elf64-tilegx.c, * elf64-tilegx.h, * elf64-x86-64.c, * elfcore.h,
* elflink.c, * elfn32-mips.c, * elfnn-aarch64.c, * elfnn-ia64.c,
* elfnn-riscv.c, * elfxx-aarch64.c, * elfxx-aarch64.h, * elfxx-ia64.c,
* elfxx-ia64.h, * elfxx-mips.c, * elfxx-riscv.c, * elfxx-sparc.c,
* elfxx-tilegx.c, * elfxx-x86.c, * elfxx-x86.h, * freebsd.h, * hash.c,
* host-aout.c, * hp300hpux.c, * hppabsd-core.c, * hpux-core.c,
* i386aout.c, * i386linux.c, * i386lynx.c, * i386mach3.c, * i386msdos.c,
* i386netbsd.c, * ieee.c, * ihex.c, * irix-core.c, * libaout.h,
* libbfd-in.h, * libbfd.c, * libcoff-in.h, * libnlm.h, * libpei.h,
* libxcoff.h, * linker.c, * lynx-core.c, * m68k4knetbsd.c,
* m68klinux.c, * m68knetbsd.c, * m88kmach3.c, * mach-o-aarch64.c,
* mach-o-arm.c, * mach-o-i386.c, * mach-o-target.c, * mach-o-x86-64.c,
* mach-o.c, * mach-o.h, * merge.c, * mipsbsd.c, * mmo.c, * netbsd.h,
* netbsd-core.c, * newsos3.c, * nlm-target.h, * nlm32-ppc.c,
* nlm32-sparc.c, * nlmcode.h, * ns32k.h, * ns32knetbsd.c, * oasys.c,
* opncls.c, * pc532-mach.c, * pdp11.c, * pe-arm.c, * pe-i386.c,
* pe-mcore.c, * pe-mips.c, * pe-x86_64.c, * peXXigen.c, * pef.c,
* pef.h, * pei-arm.c, * pei-i386.c, * pei-mcore.c, * pei-x86_64.c,
* peicode.h, * plugin.c, * ppcboot.c, * ptrace-core.c, * reloc.c,
* riscix.c, * rs6000-core.c, * section.c, * som.c, * som.h,
* sparclinux.c, * sparcnetbsd.c, * srec.c, * stabs.c, * sunos.c,
* syms.c, * targets.c, * tekhex.c, * trad-core.c, * vax1knetbsd.c,
* vaxnetbsd.c, * verilog.c, * versados.c, * vms-alpha.c, * vms-lib.c,
* vms-misc.c, * wasm-module.c, * wasm-module.h, * xcofflink.c,
* xsym.c, * xsym.h: Whitespace fixes.
* bfd-in2.h, * libbfd.h, * libcoff.h: Regenerate.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix syscall group completion
@ 2017-12-06 21:56 sergiodj+buildbot
2017-12-07 0:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-06 21:56 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9a93831ccc0ba3ba447552069f230e6d93dcbf3f ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 9a93831ccc0ba3ba447552069f230e6d93dcbf3f
Fix syscall group completion
The test gdb.base/catch-syscall.exp has been failing since commit
3d415c26bad3a15eed00d2ddf85c4268df77a4cc
Remove cleanups from break-catch-syscall.c
The reason is that we are putting into the group_ptr array a pointer to
the buffer of the local string object. If the string is small enough to
fit in the internal string buffer (used for small string optimizations),
the pointer will point to the local object directly. So even if we
std::move the string to the vector, the pointer in group_ptr will still
point to the local object. When we reuse that object (technically a new
instance, but most likely the same memory) for the next syscall, we'll
overwrite the previous string. The result is that we'll get less
results than expected, since there will be duplicates.
We'll also run into problems if we push the string to the vector, and
then record the c_str () pointer using the string object in the vector.
The vector might get reallocated, the string may move in memory, and our
pointer in group_ptr will point to stale memory.
Instead, we have to push all the strings first, then, when we know the
vector won't change anymore, build the group_ptr array. This is what
this patch does.
gdb/ChangeLog:
* break-catch-syscall.c (catch_syscall_completer): Get pointers
to syscall group strings after building the string vector.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] target_set_syscall_catchpoint, use gdb::array_view and bool
@ 2017-12-06 23:13 sergiodj+buildbot
2017-12-07 1:39 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-06 23:13 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 649a140ccf129ff79ea55ac0cc23ebddec0f02ef ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 649a140ccf129ff79ea55ac0cc23ebddec0f02ef
target_set_syscall_catchpoint, use gdb::array_view and bool
I noticed that we're passing down a data/size pair to
target_ops::to_set_syscall_catchpoint. This commit makes use of
gdb::array_view instead. While at it, use bool where appropriate as
well.
gdb/ChangeLog:
* break-catch-syscall.c (insert_catch_syscall)
(remove_catch_syscall): Adjust to pass reference to
inf_data->syscalls_counts directly via gdb::array_view.
* fbsd-nat.c (fbsd_set_syscall_catchpoint): Adjust to use bool
and gdb::array_view.
* linux-nat.c (linux_child_set_syscall_catchpoint): Likewise.
* remote.c (remote_set_syscall_catchpoint): Likewise.
* target-debug.h (target_debug_print_bool): New.
(define target_debug_print_gdb_array_view_const_int): New.
* target-delegates.c: Regenerate.
* target.h (target_ops) <to_set_syscall_catchpoint>: Use
gdb::array_view and bool.
(target_set_syscall_catchpoint): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb/MAINTAINERS: restore m68hc11, score and xstormy16 entries
@ 2017-12-07 13:37 sergiodj+buildbot
2017-12-07 14:07 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-07 13:37 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9c226a8689db8bced43b94f551e118551219ce54 ***
Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 9c226a8689db8bced43b94f551e118551219ce54
gdb/MAINTAINERS: restore m68hc11, score and xstormy16 entries
This patch restores some entries removed by a recent patch whose purpose
was to update the list of active maintainers. I thought that, the target
information was purely to document the scope of the given target, and
thus could be removed is maintainerless. But, in fact, those entries
are still useful, as a number of scripts (eg: gdb_buildall.sh) use
that information to build GDB with all targets enabled.
gdb/ChangeLog:
* MAINTAINERS: Restore target entries for m68hc11-elf,
score-elf and xstormy16-elf, incorrectly removed in a previous
patch meant to only update the list of active maintainers.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Implement explicit locations for Python breakpoints.
@ 2017-12-07 17:07 sergiodj+buildbot
2017-12-07 18:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-07 17:07 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 824cc835aa9a4d585d955db4ab2a5dd4c17cc22c ***
Author: Phil Muldoon <pmuldoon@redhat.com>
Branch: master
Commit: 824cc835aa9a4d585d955db4ab2a5dd4c17cc22c
Implement explicit locations for Python breakpoints.
This introduces several new keywords to the bppy_init constructor.
The spec parameter is now optional but mutually exclusive to the
explicit keywords source, label, function and line.
gdb/ChangeLog
2017-12-07 Phil Muldoon <pmuldoon@redhat.com>
* python/py-breakpoint.c (bppy_init): Use string_to_event_location
over basic location code. Implement explicit location keywords.
(bppy_init_validate_args): New function.
* NEWS: Document Python explicit breakpoint locations.
doc/ChangeLog
2017-12-07 Phil Muldoon <pmuldoon@redhat.com>
* python.texi (Breakpoints In Python): Add text relating
to allowed explicit locations and keywords in gdb.Breakpoints.
testsuite/ChangeLog
2017-12-07 Phil Muldoon <pmuldoon@redhat.com>
* gdb.python/py-breakpoint.exp (test_bkpt_explicit_loc): Add new
tests for explicit locations.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add virtual destructor to selftest
@ 2017-12-07 17:45 sergiodj+buildbot
2017-12-07 21:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-07 17:45 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 30970df7d56bd65657c97296f31fe9862bf27e1d ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 30970df7d56bd65657c97296f31fe9862bf27e1d
Add virtual destructor to selftest
Clang 6 shows this warning
In file included from /home/emaisin/src/binutils-gdb/gdb/common/selftest.c:19:
In file included from /home/emaisin/src/binutils-gdb/gdb/common/common-defs.h:92:
In file included from /home/emaisin/src/binutils-gdb/gdb/common/gdb_unique_ptr.h:23:
In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/memory:81:
/usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/unique_ptr.h:76:2: error: delete called on 'selftests::selftest' that is abstract but has non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
delete __ptr;
^
/usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/unique_ptr.h:236:4: note: in instantiation of member function 'std::default_delete<selftests::selftest>::operator()' requested here
get_deleter()(__ptr);
^
/home/emaisin/src/binutils-gdb/gdb/common/selftest.c:57:17: note: in instantiation of member function 'std::unique_ptr<selftests::selftest, std::default_delete<selftests::selftest> >::~unique_ptr' requested here
tests[name] = std::unique_ptr<selftest> (test);
^
The error is legitimate, we (the unique_ptr) are deleting selftest
objects through the base pointer, so technically the destructor should
be virtual, so that the destructor of the subclass is invoked.
gdb/ChangeLog:
* common/selftest.h (struct selftest): Add virtual destructor.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Initialize target description early in IPA
@ 2017-12-07 19:12 sergiodj+buildbot
2017-12-07 22:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-07 19:12 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a8806230241d201f808d856eaae4d44088117b0c ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: a8806230241d201f808d856eaae4d44088117b0c
Initialize target description early in IPA
Target descriptions are allocated lazily, that is fine in GDBserver,
but it is not safe to call malloc in gdb_collect in IPA, because we
can set a fast tracepoint in malloc, and when the tracepoint is hit,
gdb_collect/malloc is called, deadlock or memory corruption may be
triggered.
#0 0xf7cfc200 in malloc ()
#1 0xf7efdc07 in operator new(unsigned int) ()
#2 0xf7ef7636 in allocate_target_description() ()
#3 0xf7efcbe1 in i386_create_target_description(unsigned long long, bool) ()
#4 0xf7efb474 in i386_linux_read_description(unsigned long long) ()
#5 0xf7efb190 in get_ipa_tdesc(int) ()
#6 0xf7ef9baa in gdb_collect ()
The fix is to initialize all target descriptions earlier, when the
IPA is loaded. In order to guarantee malloc is not called in IPA
in gdb_collect, I change the test to set a breakpoint on malloc, if
IPA gdb_collect calls malloc, program will hit the breakpoint, and
test fail.
continue
Continuing.
Thread 1 "" hit Breakpoint 5, 0xf7cfc200 in malloc ()
(gdb) FAIL: gdb.trace/ftrace.exp: advance through tracing
gdb/gdbserver:
2017-12-07 Yao Qi <yao.qi@linaro.org>
* linux-aarch64-ipa.c (initialize_low_tracepoint): Call
aarch64_linux_read_description.
* linux-amd64-ipa.c (idx2mask): New array.
(get_ipa_tdesc): Move idx2mask out.
(initialize_low_tracepoint): Initialize target descriptions.
* linux-i386-ipa.c (idx2mask): New array.
(get_ipa_tdesc): Move idx2mask out.
(initialize_low_tracepoint): Initialize target descriptions.
gdb/testsuite:
2017-12-07 Yao Qi <yao.qi@linaro.org>
* gdb.trace/ftrace.exp (run_trace_experiment): Set breakpoint on
malloc and catch syscall.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix build with g++ 6.3.1
@ 2017-12-07 19:41 sergiodj+buildbot
2017-12-08 0:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-07 19:41 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 23a8d1862b7e5b95f0fe9d724c6be326e545e6d1 ***
Author: Adam Stylinski <adam.stylinski@etegent.com>
Branch: master
Commit: 23a8d1862b7e5b95f0fe9d724c6be326e545e6d1
Fix build with g++ 6.3.1
With g++ 6.3.1:
target-descriptions.c: In member function virtual void
print_c_tdesc::visit_pre(const target_desc*):
target-descriptions.c:1836:16: error: types may not be defined in a
for-range-declaration [-Werror]
for (const struct bfd_arch_info *compatible : e->compatible)
^~~~~~
I think at some point the forward declaration of this struct had been
removed and declared as a typedef. This fixes that.
gdb/ChangeLog:
2017-12-07 Adam Stylinski <adam.stylinski@etegent.com>
PR c++/21222
* target-descriptions.c (print_c_tdesc::visit_pre): Change type of
range-for variable.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Record nested types
@ 2017-12-07 23:49 sergiodj+buildbot
2017-12-08 4:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-07 23:49 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 883fd55ab1049333364479a7f5b0c7e61a310bac ***
Author: Keith Seitz <keiths@redhat.com>
Branch: master
Commit: 883fd55ab1049333364479a7f5b0c7e61a310bac
Record nested types
GDB currently does not track types defined in classes. Consider:
class A
{
public:
class B
{
public:
class C { };
};
};
(gdb) ptype A
type = class A {
<no data fields>
}
This patch changes this behavior so that GDB records these nested types
and displays them to the user when he has set the (new) "print type"
option "nested-type-limit."
Example:
(gdb) set print type nested-type-limit 1
(gdb) ptype A
type = class A {
<no data fields>
class A::B {
<no data fields>
};
}
(gdb) set print type nested-type-limit 2
type = class A {
<no data fields>
class A::B {
<no data fields>
class A::B::C {
<no data fields>
};
};
}
By default, the code maintains the status quo, that is, it will not print
any nested type definitions at all.
Testing is carried out via cp_ptype_class which required quite a bit of
modification to permit recursive calling (for the nested types). This
was most easily facilitated by turning the ptype command output into a
queue. Upshot: the test suite now has stack and queue data structures that
may be used by test writers.
gdb/ChangeLog
* NEWS (New commands): Mention set/show print type nested-type-limit.
* c-typeprint.c (c_type_print_base): Print out nested types.
* dwarf2read.c (struct typedef_field_list): Rename to ...
(struct decl_field_list): ... this. Change all uses.
(struct field_info) <nested_types_list, nested_types_list_count>:
New fields.
(add_partial_symbol): Look for nested type definitions in C++, too.
(dwarf2_add_typedef): Rename to ...
(dwarf2_add_type_defn): ... this.
(type_can_define_types): New function.
Update assertion to use type_can_define_types.
Permit NULL for a field's name.
(process_structure_scope): Handle child DIEs of types that can
define types.
Copy the list of nested types into the type struct.
* gdbtypes.h (struct typedef_field): Rename to ...
(struct decl_field): ... this. Change all uses.
[is_protected, is_private]: New fields.
(struct cplus_struct_type) <nested_types, nested_types_count>: New
fields.
(TYPE_NESTED_TYPES_ARRAY, TYPE_NESTED_TYPES_FIELD)
(TYPE_NESTED_TYPES_FIELD_NAME, TYPE_NESTED_TYPES_FIELD_TYPE)
(TYPE_NESTED_TYPES_COUNT, TYPE_NESTED_TYPES_FIELD_PROTECTED)
(TYPE_NESTED_TYPES_FIELD_PRIVATE): New macros.
* typeprint.c (type_print_raw_options, default_ptype_flags): Add
default value for print_nested_type_limit.
(print_nested_type_limit): New static variable.
(set_print_type_nested_types, show_print_type_nested_types): New
functions.
(_initialize_typeprint): Register new commands for set/show
`print-nested-type-limit'.
* typeprint.h (struct type_print_options) [print_nested_type_limit]:
New field.
gdb/testsuite/ChangeLog
* gdb.cp/nested-types.cc: New file.
* gdb.cp/nested-types.exp: New file.
* lib/cp-support.exp: Load data-structures.exp library.
(debug_cp_test_ptype_class): New global.
(cp_ptype_class_verbose, next_line): New procedures.
(cp_test_ptype_class): Add and document new parameter `recursive_qid'.
Add and document new return value.
Switch the list of lines to a queue.
Add support for new `type' key for nested type definitions.
Add debugging/troubleshooting messages.
* lib/data-structures.exp: New file.
gdb/doc/ChangeLog
* gdb.texinfo (Symbols): Document "set print type nested-type-limit"
and "show print type nested-type-limit".
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Validate explicit locations with early termination
@ 2017-12-08 0:32 sergiodj+buildbot
2017-12-08 5:25 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-08 0:32 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT fa6eb693cf43b427474b1d96ce093f6ea9e5da6a ***
Author: Keith Seitz <keiths@redhat.com>
Branch: master
Commit: fa6eb693cf43b427474b1d96ce093f6ea9e5da6a
Validate explicit locations with early termination
breakpoints/22569 involves an internal error generated by the rather
innocent looking command:
(gdb) break -source test.cpp main
.../linespec.c:3302: internal-error: void decode_line_full(...):
Assertion `result.size () == 1 || canonical->pre_expanded' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Quit this debugging session? (y or n)
The input string is tokenized into "-source", "test.cpp", and "main"
(input parsing breaks on whitespace). create_breakpoint is then called with
the explicit location (containing only the source file name) and "main" as
the extra_string argument.
No SaLs are created for this underspecified explicit location, and the
"result.size () == 1" evaluates false (as does the pre_expanded condition).
This triggers the assertion.
Normally string_to_explicit_location validates the input string. However,
the presence of the string "main" causes the parser to exit early:
802 else
803 {
804 /* End of the explicit location specification.
805 Stop parsing and return whatever explicit location was
806 parsed. */
807 *argp = start;
808 return location;
809 }
This bypasses the validation that is done a few lines down in this function
which would have emitted the expected error. This patch fixes that.
Additionally, this patch also fixes an inconsistency with error reporting
in this use case:
(gdb) b -source foo
Source filename requires function, label, or line offset.
(gdb) b -source foo main
No source file named foo.
These two commands should have elicited the same error message.
gdb/ChangeLog:
PR breakpoints/22569
* location.c (string_to_explicit_location): When terminating
parsing early, break out of enclosing loop instead of returning.
gdb/testsuite/ChangeLog:
PR breakpoints/22569
* gdb.linespec/ls-errs.exp: Change expected result of "break
-source this file has spaces.c -line 3".
Check that an explicit source file followed by whitespace is
identified as an invalid explicit location.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add aix 64-bit check to bfd_get_sign_extend_vma
@ 2017-12-08 6:55 sergiodj+buildbot
2017-12-08 7:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-08 6:55 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c8bed57010e8789212a6841db4b397b175a00f9e ***
Author: Sangamesh Mallayya <sangamesh.swamy@in.ibm.com>
Branch: master
Commit: c8bed57010e8789212a6841db4b397b175a00f9e
Add aix 64-bit check to bfd_get_sign_extend_vma
* bfd.c (bfd_get_sign_extend_vma): Handle aix5coff64-rs6000.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix stripping relocs in a file with mergeable notes.
@ 2017-12-08 10:27 sergiodj+buildbot
2017-12-08 11:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-08 10:27 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2d054e6bfdfb0f58fb9cc501c29327df34fec697 ***
Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 2d054e6bfdfb0f58fb9cc501c29327df34fec697
Fix stripping relocs in a file with mergeable notes.
A recent Fedora bug (1520805) exposed a problem with objcopy's reloc
copying code, when a binary also contains mergeable notes. The note
merging code would delete some relocs, but then the reloc copying code
would try to put them back again, which did not work.
So I am checking in the patch below to fix the problem. The patch
also tweaks one of the binutils note merging tests so that it is
skipped for the Sparc64 target, since this has funky relocs.
binutils * objcopy.c (copy_relocations_in_section): Use the orelocations
field of the input section, if it has been initialised.
* testsuite/binutils-all/note-2-64.d: Skip test on Sparc64.
bfd * elfcode.h (elf_write_relocs): Check for an empty howto field.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix PR 22567: set SAL .section in minsym_found
@ 2017-12-08 16:06 sergiodj+buildbot
2017-12-08 16:38 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-08 16:06 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 6b05c8bd437152d7a3ecfc19074ab243ee6c92f2 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 6b05c8bd437152d7a3ecfc19074ab243ee6c92f2
Fix PR 22567: set SAL .section in minsym_found
PR 22567 is that breakpoint location can't correct gdbarch from SAL,
because its fields .section and .symtab is NULL. We use to have code
setting .section, but was removed by 4024cf2
- if (msymbol_is_text (msymbol))
+ CORE_ADDR func_addr;
+ if (msymbol_is_function (objfile, msymbol, &func_addr))
{
- sal = find_pc_sect_line (MSYMBOL_VALUE_ADDRESS (objfile, msymbol),
- (struct obj_section *) 0, 0);
- sal.section = MSYMBOL_OBJ_SECTION (objfile, msymbol);
this patch adds this back by moving it to the common place at the bottom
of the function.
gdb:
2017-12-08 Yao Qi <yao.qi@linaro.org>
PR breakpionts/22567
* linespec.c (minsym_found): Set sal.section.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Adjust breakpoint address by clearing non-significant bits
@ 2017-12-08 19:17 sergiodj+buildbot
2017-12-08 21:39 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-08 19:17 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a0de8c21baf46c40ed8e62faef5f750b1e5453ea ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: a0de8c21baf46c40ed8e62faef5f750b1e5453ea
Adjust breakpoint address by clearing non-significant bits
Tag in tagged address on AArch64 is treated as a non-significant bits of
address, which can be got by gdbarch method significant_addr_bit, and gdb
can clear these bits.
With this patch, when user sets a breakpoint on tagged address on AArch64,
GDB will drop the top byte of address, and put breakpoint at the new place,
as shown below,
(gdb) hbreak *func_ptr
warning: Breakpoint address adjusted from 0xf000000000400690 to 0x00400690.
Hardware assisted breakpoint 2 at 0x400690
(gdb) break *func_ptr
warning: Breakpoint address adjusted from 0xf000000000400690 to 0x00400690.
Breakpoint 3 at 0x400690
When program hits a breakpoint, the stopped pc reported by Linux kernel is
the address *without* tag, so it is better the address recorded in
breakpoint location is the one without tag too, so we can still match
breakpoint location address and stopped pc reported by Linux kernel, by
simple compare.
gdb:
2017-12-08 Yao Qi <yao.qi@linaro.org>
* breakpoint.c (adjust_breakpoint_address): Call
address_significant.
gdb/testsuite:
2017-12-08 Yao Qi <yao.qi@linaro.org>
* gdb.arch/aarch64-tagged-pointer.c (main): Update.
* gdb.arch/aarch64-tagged-pointer.exp: Add test for breakpoint.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix thinko on dtrace-probe.c:dtrace_process_dof_probe
@ 2017-12-08 20:59 sergiodj+buildbot
2017-12-09 0:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-08 20:59 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 92469284a650232768523564f2c715c4ebb57906 ***
Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: 92469284a650232768523564f2c715c4ebb57906
Fix thinko on dtrace-probe.c:dtrace_process_dof_probe
While investigating PR gdb/22557 ("Regression:
gdb.base/dtrace-probe.exp"), I noticed that the code is wrongly
declaring a new "expression_up" variable inside the TRY block in
"dtrace_process_dof_probe". This causes the outter "expr" variable to
be empty, which may have an impact later when evaluating the
expression.
This commit fixes that. Unfortunately the script used to test DTrace
probes (gdb/testsuite/lib/pdtrace.in) is not very reliable so I cannot
say whether this commit fixes the PR mentioned above. Nonetheless,
it's an obvious fix and should go in.
gdb/ChangeLog:
2017-12-08 Sergio Durigan Junior <sergiodj@redhat.com>
* dtrace-probe.c (dtrace_process_dof_probe): Do not declare a new
"expression_up" inside the TRY block.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Work around sparc glibc bug
@ 2017-12-08 21:57 sergiodj+buildbot
2017-12-09 2:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-08 21:57 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a9d44aad42e127adadbad35f23931d8d83aa40c1 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: a9d44aad42e127adadbad35f23931d8d83aa40c1
Work around sparc glibc bug
* elfxx-sparc.c (_bfd_sparc_elf_relocate_section): When emitting
dynamic R_SPARC_RELATIVE for GOT entries, ensure the section
contents are zeroed.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] DWARF-5: .debug_names index producer
@ 2017-12-09 0:49 sergiodj+buildbot
2017-12-09 6:42 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-09 0:49 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 437afbb81e3a04cbd933fc534a50c686eaa63b19 ***
Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Branch: master
Commit: 437afbb81e3a04cbd933fc534a50c686eaa63b19
DWARF-5: .debug_names index producer
This adds a new "-dwarf-5" switch to "save gdb-index" that makes it
generate index files with DWARF-5 .debug_names/.debug_str sections
instead of GDB's own .gdb_index.
We should probably add a command line option to
contrib/gdb-add-index.sh (incl. cc-with-tweaks.sh) for the new
-dwarf-5 GDB option, and a new target board to make it more convenient
to exercise this. To be done later.
gdb/ChangeLog
2017-12-08 Jan Kratochvil <jan.kratochvil@redhat.com>
Pedro Alves <palves@redhat.com>
* contrib/gdb-add-index.sh (index): Rename to ...
(index4): ... here.
(index5, debugstr, debugstrmerge, debugstrerr): New variables.
Support also .debug_names and .debug_str.
* dwarf2read.c: Include cmath, set, list.
(INDEX_SUFFIX): Rename to ...
(INDEX4_SUFFIX): ... here.
(INDEX5_SUFFIX, DEBUG_STR_SUFFIX): New.
(file_write(FILE *, const void *, size_t)): New.
(file_write(FILE *, const std::vector<Elem, Alloc> &)): New.
(data_buf::append_unsigned_leb128, data_buf::empty): New.
(data_buf::file_write): Use ::file_write.
(data_buf::c_str, dwarf5_djb_hash, debug_names)
(check_dwarf64_offsets): New.
(psyms_seen_size, write_gdbindex): New from
write_psymtabs_to_index code.
(dwarf5_gdb_augmentation, write_debug_names, assert_file_size)
(enum dw_index_kind): New.
(write_psymtabs_to_index): New parameter index_kind. Support
filename_str and out_file_str. Move code to write_gdbindex,
possibly call write_debug_names.
(save_gdb_index_command): New parameter -dwarf-5.
(_initialize_dwarf2_read): Document the new parameter -dwarf-5.
gdb/doc/ChangeLog
2017-12-08 Jan Kratochvil <jan.kratochvil@redhat.com>
* gdb.texinfo (Index Files): Document .debug_names and -dwarf-5.
--
gdb/contrib/gdb-add-index.sh | 53 ++
gdb/doc/gdb.texinfo | 24 +
gdb/dwarf2read.c | 919 ++++++++++++++++++++++++++++++++++++++++--
3 files changed, 935 insertions(+), 61 deletions(-)
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Change dwarf2_initialize_objfile's return value
@ 2017-12-09 1:35 sergiodj+buildbot
2017-12-09 7:57 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-09 1:35 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT abccd1e7b7a37385159610ca4e0bc2632a547e9a ***
Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Branch: master
Commit: abccd1e7b7a37385159610ca4e0bc2632a547e9a
Change dwarf2_initialize_objfile's return value
dwarf2_initialize_objfile was returning boolean whether it is psymtabs
or .gdb_index while now it needs to return also whether it is
.debug_names.
gdb/ChangeLog
2017-12-08 Jan Kratochvil <jan.kratochvil@redhat.com>
* defs.h (elf_sym_fns_lazy_psyms, elf_sym_fns_gdb_index): Move here
declarations from elfread.c.
(dwarf2_initialize_objfile): Change return value.
* elfread.c (elf_sym_fns_lazy_psyms, elf_sym_fns_gdb_index): Move these
declarations to defs.h.
(elf_symfile_read): Adjust dwarf2_initialize_objfile caller.
* symfile.h (dwarf2_initialize_objfile): Change return type.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] DWARF-5: .debug_names index consumer
@ 2017-12-09 4:00 sergiodj+buildbot
2017-12-09 12:29 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-09 4:00 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 927aa2e778dce440f4de5de8fc37ead1683a804e ***
Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Branch: master
Commit: 927aa2e778dce440f4de5de8fc37ead1683a804e
DWARF-5: .debug_names index consumer
Some testcases needed to be updated as they were missing
.debug_aranges. While that does not matter for no-index (as GDB
builds the mapping internally during dwarf2_build_psymtabs_hard) and
neither for .gdb_index (as GDB uses that internally built mapping
which it stores into .gdb_index) it does matter for .debug_names as
that simply assumes existing .debug_aranges from GCC.
gdb/ChangeLog:
2017-12-08 Jan Kratochvil <jan.kratochvil@redhat.com>
Pedro Alves <palves@redhat.com>
* defs.h (elf_sym_fns_debug_names): New declaration.
* dwarf2read.c: Include "hash_enum.h".
(mapped_debug_names): New.
(struct dwarf2_per_objfile): Add debug_names, debug_aranges and
debug_names_table.
(dwarf2_elf_names): Add ".debug_names" and ".debug_aranges".
(struct dwz_file): Add debug_names.
(dwarf2_per_objfile::locate_sections): Handle debug_names and
debug_aranges.
(locate_dwz_sections): Handle debug_names.
(create_signatured_type_table_from_debug_names)
(create_addrmap_from_aranges): New.
(dwarf2_read_index): Update function comment.
(dwarf5_augmentation): Moved up.
(read_debug_names_from_section, create_cus_from_debug_names_list)
(create_cus_from_debug_names, dwarf2_read_debug_names): New.
(dwarf5_djb_hash): Moved up.
(dw2_debug_names_iterator): New.
(read_indirect_string_at_offset): New declaration.
(mapped_debug_names::namei_to_name)
(dw2_debug_names_iterator::find_vec_in_debug_names)
(dw2_debug_names_iterator::next, dw2_debug_names_lookup_symbol)
(dw2_debug_names_dump, dw2_debug_names_expand_symtabs_for_function)
(dw2_debug_names_expand_symtabs_matching, dwarf2_debug_names_functions):
New.
(dwarf2_initialize_objfile): Return also elf_sym_fns_debug_names.
(debug_names::djb_hash): Rename it to dwarf5_djb_hash.
(debug_names::build): Update djb_hash caller.
(write_debug_names): Move out and rename augmentation to
dwarf5_augmentation.
* elfread.c (elf_sym_fns_debug_names): New.
* psymtab.h (dwarf2_debug_names_functions): New declaration.
* symfile.h (struct dwarf2_debug_sections): Add debug_names and
debug_aranges.
* xcoffread.c (dwarf2_xcoff_names): Add debug_names and debug_aranges.
gdb/testsuite/ChangeLog:
2017-12-08 Jan Kratochvil <jan.kratochvil@redhat.com>
Pedro Alves <palves@redhat.com>
* gdb.base/maint.exp (check for .gdb_index): Check also for
.debug_names.
* gdb.dlang/watch-loc.c (.debug_aranges): New.
* gdb.dwarf2/dw2-case-insensitive-debug.S: Likewise.
* gdb.dwarf2/gdb-index.exp (check if index present, .gdb_index used)
(.gdb_index used after symbol reloading): Support also .debug_names.
* gdb.mi/dw2-ref-missing-frame-func.c (.debug_aranges): New.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] dwarf2read.c:mapped_index, use gdb::array_view, simplify symbol table
@ 2017-12-09 5:22 sergiodj+buildbot
2017-12-09 13:44 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-09 5:22 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f00a2de2a7556c59bce93f7ced44afa8e1bbf7c3 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: f00a2de2a7556c59bce93f7ced44afa8e1bbf7c3
dwarf2read.c:mapped_index, use gdb::array_view, simplify symbol table
This replaces a couple ptr+size pairs with gdb::array_view in the
.gdb_index code, and simplifies things by using an aggregate for the
type of the symbol table hash bucket instead of having to consider the
distinction between size of table vs number of slots and access name
vs vec by index.
gdb/ChangeLog:
2017-12-08 Pedro Alves <palves@redhat.com>
* dwarf2read.c (mapped_index::symbol_table_slot): New.
(mapped_index::address_table): Now a gdb::array_view of const
gdb_byte.
(mapped_index::symbol_table): Now a gdb::array_view of
symbol_table_slot.
(mapped_index::address_table_size)
(mapped_index::symbol_table_slots): Delete.
(create_addrmap_from_index): Adjust.
(find_slot_in_mapped_hash): Adjust.
(read_index_from_section): Adjust.
(dwarf2_read_index): Adjust.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Adapt gdb.ada/variant_record_packed_array.exp to accept reordered components
@ 2017-12-11 8:38 sergiodj+buildbot
2017-12-11 9:05 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-11 8:38 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c5f9cfc894373abd00ee56c6723ee0ba95a84f95 ***
Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: c5f9cfc894373abd00ee56c6723ee0ba95a84f95
Adapt gdb.ada/variant_record_packed_array.exp to accept reordered components
Recent versions of GNAT are capable of reordering record components
to make their access for efficient. This patch adapts this test to
accept both cases (reordered or not).
gdb/testsuite/ChangeLog:
* gdb.ada/variant_record_packed_array.exp: Adapt test to accept
output with components being reordered.
Tested on x86_64-linux.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] [MPFR] Fix regression on 32-bit host systems
@ 2017-12-11 14:55 sergiodj+buildbot
2017-12-11 15:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-11 14:55 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f2f9e7ecc1f02bfe5da83c38cf356ea96d428c6d ***
Author: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Branch: master
Commit: f2f9e7ecc1f02bfe5da83c38cf356ea96d428c6d
[MPFR] Fix regression on 32-bit host systems
When converting parts of the mantissa to MPFR, we need to make sure to do
an *unsigned* conversion. Since we convert at most 32 bits at a time,
stored in an unsigned long, this doesn't matter on systems where "long"
is larger than 32 bits. But on systems where it is 32 bits, we can get
conversion errors.
gdb/ChangeLog
2017-12-11 Ulrich Weigand <uweigand@de.ibm.com>
* target-float.c (mpfr_float_ops::from_target): Use mpfr_set_ui
instead of mpfr_set_si to convert mantissa bits.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] [Binutils][Objdump]Check symbol section information while search a mapping symbol backward.
@ 2017-12-11 16:19 sergiodj+buildbot
2017-12-11 17:54 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-11 16:19 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 4c5ae11b42433dbffc33fbde75c9e415594504d8 ***
Author: Renlin Li <renlin.li@arm.com>
Branch: master
Commit: 4c5ae11b42433dbffc33fbde75c9e415594504d8
[Binutils][Objdump]Check symbol section information while search a mapping symbol backward.
When checking mapping symbols backwardly, the section which defines the symbol
is not considerted. This patch fixes this by moving the section checking code
into get_sym_code_type () function which is shared by forward and backword
mapping symbol searching.
opcodes/
2017-12-11 Petr Pavlu <petr.pavlu@arm.com>
Renlin Li <renlin.li@arm.com>
* aarch64-dis.c (print_insn_aarch64): Move symbol section check ...
(get_sym_code_type): Here.
binutils/
2017-12-11 Renlin Li <renlin.li@arm.com>
* testsuite/binutils-all/aarch64/objdump.d: New.
* testsuite/binutils-all/aarch64/objdump.s: New.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR22576, ppc64_skip_trampoline_code uses wrong r2 for EXEC_REVERSE
@ 2017-12-12 13:33 sergiodj+buildbot
2017-12-12 14:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-12 13:33 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT db9077b7275e86637218a7a7d165cb85a4de116f ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: db9077b7275e86637218a7a7d165cb85a4de116f
PR22576, ppc64_skip_trampoline_code uses wrong r2 for EXEC_REVERSE
The TOC pointer register, r2, on powerpc64 is generally not mentioned
in debug info. It is saved and restored by call linkage code, and
set to the callee value either by call stub code (ELFv1) or in the
callee global entry point code (ELFv2). A call stub uses the caller
TOC pointer to access the PLT. So for gdb to read the correct PLT
entry in order to determine the destination of the trampoline, gdb
needs to know the caller r2. When skipping over trampolines in the
normal forward direction, the caller r2 is simply the current value of
r2 (at the start of the trampoline). However, when reversing over
trampolines the current value of r2 is that for the callee. Using
that value results in wild reads of memory rather than the correct PLT
entry.
This patch corrects the value of r2 by using the value saved on the
stack for reverse execution. Note that in reverse execution mode it
isn't really necessary for skip_trampoline_code to return the actual
destination, so we're doing a little more work than needed here. Any
non-zero return value would do (and it would be nicer if the interface
was changed to return the start of the stub).
PR tdep/22576
* ppc64-tdep.c (ppc64_plt_entry_point): Rewrite to take TOC-relative
PLT offset, and retrieve r2 from stack when executing in reverse.
(ppc64_standard_linkage1_target): Drop pc param. Calculate offset
rather than PLT address.
(ppc64_standard_linkage2_target): Likewise.
(ppc64_standard_linkage3_target): Likewise.
(ppc64_standard_linkage4_target): Likewise.
(ppc64_skip_trampoline_code_1): Adjust to suit.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb: testsuite: Add or1k l.nop instruction
@ 2017-12-12 16:06 sergiodj+buildbot
2017-12-12 17:55 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-12 16:06 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c3d186206bf04a40244e727fa381f78a1600f196 ***
Author: Stafford Horne <shorne@gmail.com>
Branch: master
Commit: c3d186206bf04a40244e727fa381f78a1600f196
gdb: testsuite: Add or1k l.nop instruction
The test case requires adding a nop instruction. For or1k the
instruction is `l.nop`. This change uses the correct operation.
gdb/testsuite/ChangeLog:
2017-12-12 Stafford Horne <shorne@gmail.com>
* gdb.base/bp-permanent.c: Define nop of or1k.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] sim: cgen: add remainder functions (needed for OR1K lf.rem.[sd])
@ 2017-12-12 18:13 sergiodj+buildbot
2017-12-12 22:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-12 18:13 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 07b95864f35f19636e2a95eaf3083a8b18ac7cda ***
Author: Peter Gavin <pgavin@gmail.com>
Branch: master
Commit: 07b95864f35f19636e2a95eaf3083a8b18ac7cda
sim: cgen: add remainder functions (needed for OR1K lf.rem.[sd])
* sim/common/ChangeLog:
2017-12-12 Peter Gavin <pgavin@gmail.com>
Stafford Horne <shorne@gmail.com>
* cgen-accfp.c (remsf, remdf): New function.
(cgen_init_accurate_fpu): Add remsf and remdf.
* cgen-fpu.h (cgen_fp_ops): Add remsf, remdf, remxf and remtf.
* sim-fpu.c (sim_fpu_rem): New function.
* sim-fpu.h (sim_fpu_status_invalid_irx): New enum.
(sim_fpu_rem): New function.
(sim_fpu_print_status): Add case for sim_fpu_status_invalid_irx.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] sim: or1k: add cgen generated files
@ 2017-12-12 20:43 sergiodj+buildbot
2017-12-13 2:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-12 20:43 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 6e51bfa75535439cc66039bcf4e8ebf16e8fe124 ***
Author: Stafford Horne <shorne@gmail.com>
Branch: master
Commit: 6e51bfa75535439cc66039bcf4e8ebf16e8fe124
sim: or1k: add cgen generated files
These are the simulator files generated by cgen. These are split out
from the main sim patch to make the patch easier to review and smaller.
sim/ChangeLog:
2017-12-12 Stafford Horne <shorne@gmail.com>
Peter Gavin <pgavin@gmail.com>
* or1k/arch.c: Generated.
* or1k/arch.h: Generated.
* or1k/cpu.c: Generated.
* or1k/cpu.h: Generated.
* or1k/cpuall.h: Generated.
* or1k/decode.c: Generated.
* or1k/decode.h: Generated.
* or1k/model.c: Generated.
* or1k/sem-switch.c: Generated.
* or1k/sem.c: Generated.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] sim: or1k: add autoconf generated files
@ 2017-12-12 21:23 sergiodj+buildbot
2017-12-13 4:13 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-12 21:23 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 0cd79707332aef140efa2275363c40aaaeba1c22 ***
Author: Stafford Horne <shorne@gmail.com>
Branch: master
Commit: 0cd79707332aef140efa2275363c40aaaeba1c22
sim: or1k: add autoconf generated files
These are separted out to make the patch easier to read and smaller.
sim/ChangeLog:
2017-12-12 Stafford Horne <shorne@gmail.com>
Peter Gavin <pgavin@gmail.com>
* configure: Regenerated.
* or1k/aclocal.m4: Generated.
* or1k/config.in: Generated.
* or1k/configure: Generated.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] sim: testsuite: add testsuite for or1k sim
@ 2017-12-12 22:06 sergiodj+buildbot
2017-12-13 5:29 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-12 22:06 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 702d582e2c5ab9fbd6e9a68f26d49575bfe7e062 ***
Author: Peter Gavin <pgavin@gmail.com>
Branch: master
Commit: 702d582e2c5ab9fbd6e9a68f26d49575bfe7e062
sim: testsuite: add testsuite for or1k sim
This is the testsuite for the or1k sim, it tests running many of the
basic architecture instructions on the openrisc sim.
sim/testsuite/sim/or1k/ChangeLog:
2017-12-12 Peter Gavin <pgavin@gmail.com>
Stafford Horne <shorne@gmail.com>
* add.S: New file.
* alltests.exp: New file.
* and.S: New file.
* basic.S: New file.
* div.S: New file.
* ext.S: New file.
* find.S: New file.
* flag.S: New file.
* fpu.S: New file.
* jump.S: New file.
* load.S: New file.
* mac.S: New file.
* mfspr.S: New file.
* mul.S: New file.
* or.S: New file.
* or1k-asm-test-env.h: New file.
* or1k-asm-test-helpers.h: New file.
* or1k-asm-test.h: New file.
* or1k-asm.h: New file.
* or1k-test.ld: New file.
* ror.S: New file.
* shift.S: New file.
* spr-defs.h: New file.
* sub.S: New file.
* xor.S: New file.
sim/testsuite/ChangeLog:
2017-12-12 Stafford Horne <shorne@gmail.com>
Peter Gavin <pgavin@gmail.com>
* configure: Regenerated.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] This patch enables disassembler_needs_relocs for PRU. It is needed to print correct symbols when disassembling arguments of "call" instructions with a relocation.
@ 2017-12-13 13:44 sergiodj+buildbot
2017-12-13 14:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-13 13:44 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 024d185c10a48339ae06634d0738dd796a159cd8 ***
Author: Dimitar Dimitrov <dimitar@dinux.eu>
Branch: master
Commit: 024d185c10a48339ae06634d0738dd796a159cd8
This patch enables disassembler_needs_relocs for PRU. It is needed to print correct symbols when disassembling arguments of "call" instructions with a relocation.
opcodes * disassemble.c: Enable disassembler_needs_relocs for PRU.
gas * testsuite/gas/pru/extern.s: New test for print of U16_PMEMM
relocation.
* testsuite/gas/pru/extern.d: New test driver.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb: Fix ARI warnings in or1k-tdep.c
@ 2017-12-13 15:34 sergiodj+buildbot
2017-12-13 18:08 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-13 15:34 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9664701462aec634d304923df8dc9c52c5a92caf ***
Author: Stafford Horne <shorne@gmail.com>
Branch: master
Commit: 9664701462aec634d304923df8dc9c52c5a92caf
gdb: Fix ARI warnings in or1k-tdep.c
Fix a few issues not using the gettext _() wrapper and issues where
we are using %p directly instead of the dedicated host/target functions.
gdb/ChangeLog:
yyyy-mm-dd Stafford Horne <shorne@gmail.com>
* or1k-tdep.c (or1k_analyse_inst): Use _() wrapper for message
strings.
(or1k_unwind_pc): Use paddress() instead of %p.
(or1k_unwind_sp): Likewise.
(or1k_frame_cache): Use host_address_to_string()/paddress()
instead of %p and use _() wrapper for message strings.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Factor out final completion match string building
@ 2017-12-13 17:00 sergiodj+buildbot
2017-12-13 20:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-13 17:00 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 60a20c190789fd75d1955576160cbbfe94c792fb ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 60a20c190789fd75d1955576160cbbfe94c792fb
Factor out final completion match string building
We have several places doing essentially the same thing; factor them
out to a central place. Some of the places overallocate for no good
reason, or use strcat unnecessarily. The centralized version is more
precise and to the point.
(I considered making the gdb::unique_xmalloc_ptr overload version of
make_completer_match_str try to realloc (not xrealloc) probably
avoiding an allocation in most cases, but that'd be probably overdoing
it, and also, now that I'm writing this I thought I'd try to see how
could we ever get to filename_completer with "text != word", but I
couldn't figure it out. Running the testsuite with 'gdb_assert (text
== word);' never tripped on the assertion either. So post gdb 8.1,
I'll probably propose a patch to simplify filename_completer a bit,
and the gdb::unique_xmalloc_str overload can be removed then.)
gdb/ChangeLog:
2017-12-13 Pedro Alves <palves@redhat.com>
* cli/cli-decode.c (complete_on_cmdlist, complete_on_enum): Use
make_completion_match_str.
* completer.c: Use gdb::unique_xmalloc_ptr and
make_completion_match_str.
(make_completion_match_str_1): New.
(make_completion_match_str(const char *, const char *,
const char *)): New.
(make_completion_match_str(gdb::unique_xmalloc_ptr<char> &&,
const char *, const char *)): New.
* completer.h (make_completion_match_str(const char *,
const char *, const char *)): New.
(make_completion_match_str(gdb::unique_xmalloc_ptr<char> &&,
const char *, const char *)): New.
* interps.c (interpreter_completer): Use make_completion_match_str.
* symtab.c (completion_list_add_name, add_filename_to_list): Use
make_completion_match_str.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Tighten regexp of lib/completion-support.exp:test_gdb_complete_tab_multiple
@ 2017-12-13 18:40 sergiodj+buildbot
2017-12-13 23:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-13 18:40 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 6892d2e4df57160f7103fef0340ae3f55ac8b2b3 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 6892d2e4df57160f7103fef0340ae3f55ac8b2b3
Tighten regexp of lib/completion-support.exp:test_gdb_complete_tab_multiple
While writing the tests included in the previous commit, I noticed
that test_gdb_complete_tab_multiple would not FAIL if GDB happens to
show more completions than expected before the expected list.
E.g., with something like this, expecting "p foo" to complete to
"foo2" and "foo3":
test_gdb_complete_tab_multiple "p foo" "" {
"foo2"
"foo3"
}
and then if foo actually completes to:
(gdb) p foo[TAB]
foo1 foo2 foo3
^^^^
we'd still PASS. (Note the spurious "foo1" above.)
This tightens the regexp with a beginning anchor thus making the
completions above cause a FAIL. Other similar functions in
completion-support.exp already do something like this; I had just
missed this one originally. Thankfully, this did not expose any
problems in the gdb.linespec/ tests. Phew.
gdb/testsuite/ChangeLog:
2017-12-13 Pedro Alves <palves@redhat.com>
* lib/completion-support.exp (test_gdb_complete_tab_multiple):
Tighten regexp by matching with an anchor.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] python: Add qualified parameter to gdb.Breakpoint
@ 2017-12-13 19:21 sergiodj+buildbot
2017-12-14 0:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-13 19:21 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b89641bab55496e52094282fabe146289c57b6d1 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: b89641bab55496e52094282fabe146289c57b6d1
python: Add qualified parameter to gdb.Breakpoint
This patch adds the possibility to pass a qualified=True|False parameter
when creating a breakpoint in Python. It is equivalent to using
-qualified in a linespec. The parameter actually accepts any Python
value, and converts it to boolean using Python's standard rules for
that (https://docs.python.org/3/library/stdtypes.html#truth).
Unlike the -source/-line/-function/-label parameters, it is possible to
use -qualified with a "normal" (non-explicit) linespec. Therefore, it
is possible (unlike these other parameters) to use this new parameter
along with the spec parameter.
I updated the py-breakpoint.exp test. To be able to test multiple
locations using a namespace, I had to switch the test case to compile as
C++. If we really wanted to, we could run it as both C and C++, but
omit the C++-specific parts when running it as C.
gdb/ChangeLog:
* location.h (string_to_event_location): Add match_type
parameter.
* location.c (string_to_event_location): Likewise.
* python/py-breakpoint.c (bppy_init): Handle qualified
parameter.
gdb/doc/ChangeLog:
* python.texi (Manipulating breakpoints using Python): Document
qualified parameter to gdb.Breakpoint.
gdb/testsuite/ChangeLog:
* gdb.python/py-breakpoint.c (foo_ns::multiply): New function.
* gdb.python/py-breakpoint.exp: Compile the test case as c++,
call test_bkpt_qualified.
(test_bkpt_qualified): New proc.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] (Ada) Add support for task switching when debugging core files
@ 2017-12-14 4:30 sergiodj+buildbot
2017-12-14 5:44 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-14 4:30 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e05fa6f9df82886043e1f1df30e0b9be3fee2d55 ***
Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: e05fa6f9df82886043e1f1df30e0b9be3fee2d55
(Ada) Add support for task switching when debugging core files
The reasons for not supporting task switching when debugging core files
appear to now mostly be OBE. In particular, on GNU/Linux, the thread
layer is now able to retrieve the same thread info as in the live
process. So, this patch is mostly about just removing the guard
that limited the use of task switching to live processes.
gdb/ChangeLog:
* ada-tasks.c (read_atcb): Properly set task_info->ptid
when !target_has_execution as well.
(task_command): Remove error when !target_has_execution.
gdb/testsuite/ChangeLog:
* gdb.ada/task_switch_in_core: New testcase.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Update the address of the FSF in the copyright notice of files which were using the old address.
@ 2017-12-14 13:12 sergiodj+buildbot
2017-12-14 13:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-14 13:12 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 863f7a5f4811c24d9a5863ffb541ff3da1511450 ***
Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 863f7a5f4811c24d9a5863ffb541ff3da1511450
Update the address of the FSF in the copyright notice of files which were using the old address.
top * COPYING.LIBGLOSS: Update address of FSF in copyright notice.
bfd * cpu-mt.c: Update address of FSF in copyright notice.
* elf32-m32c.c: Likewise.
* elf32-mt.c: Likewise.
* elf32-rl78.c: Likewise.
* elf32-rx.c: Likewise.
* elf32-rx.h: Likewise.
* elf32-spu.h: Likewise.
* hosts/x86-64linux.h: Likewise.
etc * add-log.el: Update address of FSF in copyright notice.
gas * config/tc-m32c.c: Update address of FSF in copyright notice.
* config/tc-m32c.h: Likewise.
* config/tc-mt.c: Likewise.
* config/tc-mt.h: Likewise.
* config/tc-visium.c: Likewise.
* config/tc-visium.h: Likewise.
* testsuite/gas/rx/explode: Likewise.
ld * testsuite/ld-mn10300/mn10300.exp: Update address of FSF in
copyright notice.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix disassembly for PowerPC
@ 2017-12-15 9:44 sergiodj+buildbot
2017-12-15 10:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-15 9:44 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT fbc2255575afc0d332b28fd4991235e020cda667 ***
Author: Dimitar Dimitrov <dimitar@dinux.eu>
Branch: master
Commit: fbc2255575afc0d332b28fd4991235e020cda667
Fix disassembly for PowerPC
* disassemble.c (disassemble_init_for_target): Don't put PRU
between powerpc and rs6000 cases.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Skip 'maintenance check xml-descriptions' if XML is disabled
@ 2017-12-15 11:47 sergiodj+buildbot
2017-12-15 14:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-15 11:47 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 1af17fd9cc3a453e55ce5b8f556c51859bf40363 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 1af17fd9cc3a453e55ce5b8f556c51859bf40363
Skip 'maintenance check xml-descriptions' if XML is disabled
I see the following test failure when gdb is configured without XML
support,
maintenance check xml-descriptions binutils-gdb/gdb/testsuite/../features
warning: Can not parse XML target description; XML support was disabled at compile time^M
Tested 29 XML files, 29 failed
(gdb) FAIL: gdb.gdb/unittest.exp: maintenance check xml-descriptions ${srcdir}/../features
gdb/testsuite:
2017-12-15 Yao Qi <yao.qi@linaro.org>
* gdb.gdb/unittest.exp: Skip 'maintenance check xml-descriptions'
if XML is disabled.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb: Add news entries for new or1k target.
@ 2017-12-16 22:41 sergiodj+buildbot
2017-12-16 23:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-16 22:41 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b282f0f2b56903c7b58f1eb94b88e468851928e8 ***
Author: Stafford Horne <shorne@gmail.com>
Branch: master
Commit: b282f0f2b56903c7b58f1eb94b88e468851928e8
gdb: Add news entries for new or1k target.
gdb/ChangeLog:
yyyy-mm-dd Stafford Horne <shorne@gmail.com>
* NEWS (Changes since GDB 8.0): Mention new or1k target and new
commands to set/show or1k debug.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] (Ada) crash assigning to record component which is an array
@ 2017-12-18 4:13 sergiodj+buildbot
2017-12-18 5:59 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-18 4:13 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 0e2da9f01334a01d1a6e224ecd592d6fbbb22515 ***
Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 0e2da9f01334a01d1a6e224ecd592d6fbbb22515
(Ada) crash assigning to record component which is an array
Consider the following code, which declares a variabled called "input"
of type "parameter", which is a record with one component called "u2",
where the type of that component is a simple 3-element array of
floating point values:
type Float_Array_3 is array (1 .. 3) of Float;
type parameters is record
u2 : Float_Array_3;
end record;
input : parameters;
Trying to assign a value to input.u2 causes GDB to crash:
(gdb) p input.u2 := (0.25,0.5,0.75)
[1] 20228 segmentation fault (core dumped) [...]/gdb
The crash occurs because input.u2 is described in the debugging
info as a typedef of an array. Indeed, input's type is:
<1><ae9>: Abbrev Number: 7 (DW_TAG_structure_type)
<aea> DW_AT_name : (indirect string, offset: 0x1045): target_wrapper__parameters
[...]
<2><af5>: Abbrev Number: 8 (DW_TAG_member)
<af6> DW_AT_name : u2
[...]
<afb> DW_AT_type : <0xaca>
and, looking at DIE 0xaca to get input.u2's type, we see:
<1><aca>: Abbrev Number: 4 (DW_TAG_typedef)
<acb> DW_AT_name : (indirect string, offset: 0x1060): target_wrapper__float_array_3
[...]
<ad1> DW_AT_type : <0xad5>
We can also confirm, following the DW_AT_type attribute (0xad5), that
it's a typedef of our array:
<1><ad5>: Abbrev Number: 5 (DW_TAG_array_type)
<ad6> DW_AT_name : (indirect string, offset: 0x1060): target_wrapper__float_array_3
[...]
In fact, this scenario uncovered 2 areas where typedef handling
is missing, thus causing a crash. The first happens inside
assign_aggregate:
if (ada_is_direct_array_type (lhs_type))
{
lhs = ada_coerce_to_simple_array (lhs);
lhs_type = value_type (lhs);
low_index = TYPE_ARRAY_LOWER_BOUND_VALUE (lhs_type);
high_index = TYPE_ARRAY_UPPER_BOUND_VALUE (lhs_type);
}
Here, lhs_type is a TYPE_CODE_TYPEDEF. ada_is_direct_array_type
knows how to handle it, but TYPE_ARRAY_LOWER_BOUND_VALUE assumes
that the given type is a TYPE_CODE_ARRAY. As such, it ends up
accessing some fields in lhs_type which it shouldn't, and kaboom.
We fixed this issue by making sure that the TYPE_CODE_TYPEDEF
layer gets stripped.
Once this is done, we hit a different kind of error, also leading to
a SEGV, this time in assign_component. The code looks like this:
if (TYPE_CODE (value_type (lhs)) == TYPE_CODE_ARRAY)
[...]
else
[...]
Because once again lhs is a TYPE_CODE_TYPEDEF, the check fail,
and we end up assuming that lhs is a struct, executing the "else"
block, which is:
else
{
elt = ada_index_struct_field (index, lhs, 0, value_type (lhs));
elt = ada_to_fixed_value (elt);
}
Since lhs is not a struct, ada_index_struct_field returns NULL,
which ada_to_fixed_value does not handle well, hence another crash.
This patch fixes this other issue the same way, by stripping
TYPE_CODE_TYPEDEF layers.
gdb/ChangeLog:
* ada-lang.c (assign_component): Strip any TYPE_CODE_TYPEDEF
layer from lhs' type.
(assign_aggregate): Likewise.
gdb/testsuite:
* gdb.ada/assign_arr: New testcase.
Tested on x86_64-linux.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] improved error message when getting an exception printing a variable
@ 2017-12-18 4:51 sergiodj+buildbot
2017-12-18 7:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-18 4:51 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT eccab96d54a9455557d3c4d5bff431f6e526d0b7 ***
Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: eccab96d54a9455557d3c4d5bff431f6e526d0b7
improved error message when getting an exception printing a variable
Consider the following Ada code defining a global variable whose
type is an array of static bounds (1 .. 2), but where its elements
are a variant record whose size is not statically known:
type Ints is array (Natural range <>) of Integer;
type Bounded_Ints (Max_Size : Natural) is record
Length : Natural := 0;
Objs : Ints (1 .. Max_Size);
end record;
type Ints_Doubled is array (1 .. 2) of Bounded_Ints (Idem (0));
Global : Ints_Doubled;
When compiling this program at -O2 using a GCC-6.4-based compiler
on x86_64-linux, trying to print the value of that global variable
yields:
(gdb) p global
$1 =
Let's look at the debugging info, which starts with the global
variable itself...
.uleb128 0x19 # (DIE (0x25e) DW_TAG_variable)
.long .LASF32 # DW_AT_name: "fd__global"
.long 0x273 # DW_AT_type
... its type is a reference to a typedef ...
.uleb128 0x14 # (DIE (0x273) DW_TAG_reference_type)
.byte 0x8 # DW_AT_byte_size
.long 0x202 # DW_AT_type
[...]
.uleb128 0x15 # (DIE (0x202) DW_TAG_typedef)
.long .LASF19 # DW_AT_name: "fd__ints_doubled"
.long 0x20d # DW_AT_type
... of an array (1..2) ...
.uleb128 0x2 # (DIE (0x20d) DW_TAG_array_type)
.long .LASF19 # DW_AT_name: "fd__ints_doubled"
.long 0x15b # DW_AT_type
.long 0x221 # DW_AT_sibling
.uleb128 0x16 # (DIE (0x21a) DW_TAG_subrange_type)
.long 0x40 # DW_AT_type
.sleb128 2 # DW_AT_upper_bound
.byte 0 # end of children of DIE 0x20d
... of a struct whose name is fd__Tints_doubledC:
.uleb128 0x10 # (DIE (0x15b) DW_TAG_structure_type)
.long .LASF11 # DW_AT_name: "fd__Tints_doubledC"
.long 0x1e4 # DW_AT_GNAT_descriptive_type
# DW_AT_artificial
.long 0x1e4 # DW_AT_sibling
.uleb128 0x7 # (DIE (0x16a) DW_TAG_member)
.long .LASF4 # DW_AT_name: "max_size"
[snip]
The error occurs while Ada evaluator is trying to "fix"
the element type inside the array, so as to determine its actual
size. For that, it searches for a parallel "XVZ" variable,
which, when found, contains the object's actual size.
Unfortunately in our case, the variable exists but has been
optimized out, as seen by the presence of a variable DIE in
the debugging info, but with no address attribute:
.uleb128 0x18 # (DIE (0x24e) DW_TAG_variable)
.long .LASF31 # DW_AT_name: "fd__Tints_doubledC___XVZ"
.long 0x257 # DW_AT_type
# DW_AT_artificial
Discussing this with some members of AdaCore's compiler team,
it is expected that the optimizer can get rid of this variable,
and we don't want to pessimize the code just to improve debuggability,
since -O2 is about performance. So, the idea of this patch is
not to make it work, but provide a bit more information to help
users understand what kind of error is preventing GDB from being
able to print the variable's value.
The first hurdle we had to clear was the fact that ada_val_print
traps all exceptions (including QUIT ones!), and does so completly
silently. So, the fix was to add a trace of the exception being
generated. While doing so, we fix an old XXX/FIXME by only catching
errors, letting QUIT exceptions go through.
Once this is done, we now get an error message, which gives a first
clue as to what was happening:
(gdb) p fd.global
$1 = <error reading variable: value has been optimized out>
However, it would be more useful to know which value it was
that was optimized out. For that purpose, we enhanced
ada-lang.c::ada_to_fixed_type_1 so as to re-throw the error
with a message which indicates which variable we failed to read.
With those changes, the new output is now:
(gdb) p fd.global
$1 = <error reading variable: unable to read value of fd__Tints_doubledC___XVZ (value has been optimized out)>
gdb/ChangeLog:
* ada-lang.c (ada_to_fixed_type_1): Rethrow errors with
a more detailed exception message when getting an exception
while trying to read the value of an XVZ variable.
* ada-valprint.c (ada_val_print): Only catch RETURN_MASK_ERROR
exceptions. Print an error message when an exception is caught.
gdb/testsuite/ChangeLog:
* gdb.dwarf2/ada-valprint-error.c: New file.
* gdb.dwarf2/ada-valprint-error.exp: New file.
Tested on x86_64-linux
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: replace Reg8, Reg16, Reg32, and Reg64
@ 2017-12-18 8:56 sergiodj+buildbot
2017-12-18 10:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-18 8:56 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT dc821c5f9ae5208ad1ec438718f75e224f856deb ***
Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: dc821c5f9ae5208ad1ec438718f75e224f856deb
x86: replace Reg8, Reg16, Reg32, and Reg64
Use a combination of a single new Reg bit and Byte, Word, Dword, or
Qword instead.
Besides shrinking the number of operand type bits this has the benefit
of making register handling more similar to accumulator handling (a
generic flag is being accompanied by a "size qualifier"). It requires,
however, to split a few insn templates, as it is no longer correct to
have combinations like Reg32|Reg64|Byte. This slight growth in size will
hopefully be outweighed by this change paving the road for folding a
presumably much larger number of templates later on.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master
2017-12-18 8:56 [binutils-gdb] x86: replace Reg8, Reg16, Reg32, and Reg64 sergiodj+buildbot
@ 2017-12-18 10:15 ` sergiodj+buildbot
0 siblings, 0 replies; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-18 10:15 UTC (permalink / raw)
To: gdb-testers
Buildslave:
ubuntu-trusty-aarch32-1
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-native-gdbserver-m32/builds/2410>
Commit(s) tested:
dc821c5f9ae5208ad1ec438718f75e224f856deb
Author(s) (in the same order as the commits):
Jan Beulich <jbeulich@novell.com>
Subject:
x86: replace Reg8, Reg16, Reg32, and Reg64
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-native-gdbserver-m32/dc/dc821c5f9ae5208ad1ec438718f75e224f856deb/>
*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
============================
*** Complete list of XFAILs for this builder ***
To obtain the list of XFAIL tests for this builder, go to:
<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch32-native-gdbserver-m32/xfails/master/xfail;hb=>
You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:
<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch32-native-gdbserver-m32/xfails/master/xfail.table;hb=>
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: drop FloatReg and FloatAcc
@ 2017-12-18 9:35 sergiodj+buildbot
2017-12-18 11:41 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-18 9:35 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ca0d63fe0703ed36af1a7bda6097958805895b3a ***
Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: ca0d63fe0703ed36af1a7bda6097958805895b3a
x86: drop FloatReg and FloatAcc
Express them as Reg|Tbyte and Acc|Tbyte respectively.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: fold certain AVX and AVX2 templates
@ 2017-12-18 11:26 sergiodj+buildbot
2017-12-18 14:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-18 11:26 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 10c17abdd052c5f8f9c2bcdf8b01dffe5d06baf0 ***
Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 10c17abdd052c5f8f9c2bcdf8b01dffe5d06baf0
x86: fold certain AVX and AVX2 templates
Just like for instructions in GPRs, there's no need to have separate
templates for otherwise identical insns acting on XMM or YMM registers
(or memory of the same size).
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add support for V_4B so we can properly reject it.
@ 2017-12-19 12:47 sergiodj+buildbot
2017-12-19 13:21 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-19 12:47 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a3b3345ae62503982698171bcfce0afe23bd8a31 ***
Author: Tamar Christina <tamar.christina@arm.com>
Branch: master
Commit: a3b3345ae62503982698171bcfce0afe23bd8a31
Add support for V_4B so we can properly reject it.
Previously parse_vector_type_for_operand was changed to allow the use of 4b
register size for indexed lane instructions. However this had the unintended
side effect of also allowing 4b for normal vector registers.
Because this support was only partial the rest of the tool silently treated
4b as 8b and continued. This patch adds full support for 4b so it can be
properly distinguished from 8b and the correct errors are generated.
With this patch you still can't encode any instruction which actually requires
v<num>.4b but such instructions don't exist so to prevent needing a workaround
in get_vreg_qualifier_from_value this was just omitted.
gas/
PR gas/22529
* config/tc-aarch64.c (vectype_to_qualifier): Support AARCH64_OPND_QLF_V_4B.
* gas/testsuite/gas/aarch64/pr22529.s: New.
* gas/testsuite/gas/aarch64/pr22529.d: New.
* gas/testsuite/gas/aarch64/pr22529.l: New.
include/
PR gas/22529
* opcode/aarch64.h (aarch64_opnd_qualifier): Add AARCH64_OPND_QLF_V_4B.
opcodes/
PR gas/22529
* aarch64-opc.c (aarch64_opnd_qualifiers): Add 4b variant.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] RISC-V: Add compressed instruction hints, and a few misc cleanups.
@ 2017-12-20 21:59 sergiodj+buildbot
2017-12-20 23:27 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-20 21:59 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 21a186f28061ea51e422ae47d062793ceac2180f ***
Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 21a186f28061ea51e422ae47d062793ceac2180f
RISC-V: Add compressed instruction hints, and a few misc cleanups.
gas/
* config/tc-riscv.c (risc_ip) <o>: Add comment.
* testsuite/gas/riscv/c-nonzero-imm.d,
* testsuite/gas/riscv/c-nonzero-imm.l,
* testsuite/gas/riscv/c-nonzero-imm.s,
* testsuite/gas/riscv/c-nonzero-reg.d,
* testsuite/gas/riscv/c-nonzero-reg.l,
* testsuite/gas/riscv/c-nonzero-reg.s,
* testsuite/gas/riscv/c-zero-imm-64.d,
* testsuite/gas/riscv/c-zero-imm-64.s,
* testsuite/gas/riscv/c-zero-imm.d, testsuite/gas/riscv/c-zero-imm.s,
* testsuite/gas/riscv/c-zero-reg.d,
* testsuite/gas/riscv/c-zero-reg.s: New.
opcodes/
* riscv-opc.c (match_c_add_with_hint, match_c_lui_with_hint): New.
(riscv_opcodes) <li>: Delete "d,0" line. Change Cj to Co.
<andi, and, add, addiw, addw, c.addi>: Change Cj to Co.
<add>: Add explanatory comment for 4-operand add instruction.
<c.nop>: Add support for immediate operand.
<c.mv, c.add>: Use match_c_add_with_hint instead of match_c_add.
<c.lui>: Use match_c_lui_with_hint instead of match_c_lui.
<c.li, c.slli>: Use match_opcode instead of match_rd_nonzero.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove write-only assignment in rs6000-tdep.c
@ 2017-12-21 2:01 sergiodj+buildbot
2017-12-21 2:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-21 2:01 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 27e9ff87a627614fda7ddd89ddef745de5e988bb ***
Author: Uros Bizjak <ubizjak@gmail.com>
Branch: master
Commit: 27e9ff87a627614fda7ddd89ddef745de5e988bb
Remove write-only assignment in rs6000-tdep.c
The result of this memory read is never used, so it can be removed.
gdb/ChangeLog:
* rs6000-tdep.c (ppc_deal_with_atomic_sequence): Remove
write-only assignment to "insn" variable.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add ATTRIBUTE_PRINTF to printf_field_type_assignment
@ 2017-12-23 21:51 sergiodj+buildbot
2017-12-23 22:32 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-23 21:51 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 6e8c24fe27098f407000812e61fa8210095a7970 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 6e8c24fe27098f407000812e61fa8210095a7970
Add ATTRIBUTE_PRINTF to printf_field_type_assignment
Get rid of:
/home/simark/src/binutils-gdb/gdb/target-descriptions.c:2026:25: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
vprintf_unfiltered (fmt, args);
when building with clang.
gdb/ChangeLog:
* target-descriptions.c (print_c_tdesc)
<printf_field_type_assignment>: Add ATTRIBUTE_PRINTF.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] reggroups: Add test and docs for `info reg $reggroup` feature
@ 2017-12-27 15:03 sergiodj+buildbot
2017-12-27 15:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-27 15:03 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b67d92b06e6155a392a0c2d413f87d050880dbf4 ***
Author: Stafford Horne <shorne@gmail.com>
Branch: master
Commit: b67d92b06e6155a392a0c2d413f87d050880dbf4
reggroups: Add test and docs for `info reg $reggroup` feature
Until now this feature has existed but was not documented. Adding docs
and tests.
gdb/ChangeLog:
yyyy-mm-dd Stafford Horne <shorne@gmail.com>
* infcmd.c (_initialize_infcmd): Add help for info reg $reggroup
and info all-registers $reggroup feature.
gdb/doc/ChangeLog:
yyyy-mm-dd Stafford Horne <shorne@gmail.com>
* gdb.texinfo (Registers): Document info reg $reggroup feature.
gdb/testsuite/ChangeLog:
yyyy-mm-dd Stafford Horne <shorne@gmail.com>
* gdb.base/reggroups.c: New file.
* gdb.base/reggroups.exp: New file.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] reggroups: Convert reggroups from post_init to pre_init
@ 2017-12-27 15:46 sergiodj+buildbot
2017-12-27 18:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-27 15:46 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c1166ca9f3543b28e8b0057ecaf2cd3251cd51c5 ***
Author: Stafford Horne <shorne@gmail.com>
Branch: master
Commit: c1166ca9f3543b28e8b0057ecaf2cd3251cd51c5
reggroups: Convert reggroups from post_init to pre_init
Currently the reggroups gdbarch_data cannot be manipulated until after
the gdbarch is completely initialized. This is usually done when the
object init depends on architecture specific fields. In the case of
reggroups it only depends on the obstack being available.
Coverting this to pre_init allows using reggroups during gdbarch
initialization. This is needed to allow registering arbitrary reggroups
during gdbarch initializations.
gdb/ChangeLog:
yyyy-mm-dd Stafford Horne <shorne@gmail.com>
* reggroups.c (reggroups_init): Change to depend only on
obstack rather than gdbarch.
(reggroup_add): Remove logic for forcing premature init.
(_initialize_reggroup): Set `reggroups_data` with
gdbarch_data_register_pre_init() rather than
gdbarch_data_register_post_init().
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] reggroups: Add reggroup_gdbarch_new, reggroup_find for dynamic reggroups
@ 2017-12-27 16:45 sergiodj+buildbot
2017-12-27 21:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-27 16:45 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f7efd549485db1fd84dbd2f2ee36d80c2739f224 ***
Author: Stafford Horne <shorne@gmail.com>
Branch: master
Commit: f7efd549485db1fd84dbd2f2ee36d80c2739f224
reggroups: Add reggroup_gdbarch_new, reggroup_find for dynamic reggroups
Traditionally reggroups have been created via reggroup_new() during
initialization code and never freed. Now, if we want to initialize
reggroups dynamically (i.e. in target description) we should be able to
free them. Create this function reggroup_gdbarch_new() which will
allocate the reggroup memory onto the passed gdbarch obstack.
Also creating reggroup_find() as a utility to find a gdbarch registered
reggroup object by name.
gdb/ChangeLog:
yyyy-mm-dd Stafford Horne <shorne@gmail.com>
* reggroups.c (reggroup_gdbarch_new): New function.
(reggroup_find): New function.
* reggroups.h (reggroup_gdbarch_new): New function.
(reggroup_find): New function.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p
@ 2017-12-27 17:51 sergiodj+buildbot
2017-12-27 23:51 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-27 17:51 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT cef0f8684e818f8b6c71c44dc9cc28a6d0ac3754 ***
Author: Stafford Horne <shorne@gmail.com>
Branch: master
Commit: cef0f8684e818f8b6c71c44dc9cc28a6d0ac3754
tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p
tdesc_register_in_reggroup_p in now able to handle arbitrary
groups. This is useful when groups are created while the
target descriptor file is received from the remote.
This can be the case of a soft core target processor where
registers/groups can change.
gdb/ChangeLog:
yyyy-mm-dd Franck Jullien <franck.jullien@gmail.com>
Stafford Horne <shorne@gmail.com>
* target-descriptions.c (tdesc_register_in_reggroup_p): Support
arbitrary strings.
(tdesc_use_registers): Add logic to register new reggroups.
(tdesc_reg::group): Update comment to indicate we allow
arbitrary strings.
* NEWS (Changes since GDB 8.0): Announce that GDB supports
arbitrary reggroups.
gdb/testsuite/ChangeLog:
yyyy-mm-dd Stafford Horne <shorne@gmail.com>
* gdb.xml/extra-regs.xml: Add example foo reggroup.
* gdb.xml/tdesc-regs.exp: Add test to check for foo reggroup.
gdb/doc/ChangeLog:
yyyy-mm-dd Stafford Horne <shorne@gmail.com>
* gdb.texinfo (Target Description Format): Explain that arbitrary
strings are now allowed for register groups.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove unused HP-UX TARGET_OBJECT_ enums
@ 2017-12-28 17:51 sergiodj+buildbot
2017-12-28 18:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-28 17:51 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 4ee2b642ddc70393d5b3ab04956fadad02954d4a ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 4ee2b642ddc70393d5b3ab04956fadad02954d4a
Remove unused HP-UX TARGET_OBJECT_ enums
These two enumerators are unused, remove them.
gdb/ChangeLog:
* target.h (enum target_object) <TARGET_OBJECT_HPUX_UREGS,
TARGET_OBJECT_HPUX_SOLIB_GOT>: Remove.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove unnecessary call to get_thread_db_info
@ 2017-12-30 3:17 sergiodj+buildbot
2017-12-30 4:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-30 3:17 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 502a625ab01da27e851333b598c893d6f2c20bd0 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 502a625ab01da27e851333b598c893d6f2c20bd0
Remove unnecessary call to get_thread_db_info
In thread_db_detach, we call get_thread_db_info to first check if there
exists a thread_db_info entry for the pid to detach. If there is, then
we call delete_thread_db_info. It's unnecessary to call
get_thread_db_info in the first place, since delete_thread_db_info
handles the case where no thread_db_info entry exist for the given pid.
gdb/ChangeLog:
* linux-thread-db.c (thread_db_detach): Remove call to
delete_thread_db_info.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Ignore warning about using different types of enums in switch
@ 2017-12-30 4:57 sergiodj+buildbot
2017-12-30 6:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-30 4:57 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 0436426c7f7798b8eb4b48be9867495da8ef28f0 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 0436426c7f7798b8eb4b48be9867495da8ef28f0
Ignore warning about using different types of enums in switch
When compiling with clang 6, I see a bunch of warnings like this:
/home/emaisin/src/binutils-gdb/gdb/amd64-linux-tdep.c:1427:8: error: comparison of two values with different enumeration types in switch statement ('enum amd64_syscall' and 'amd
64_x32_syscall') [-Werror,-Wenum-compare-switch]
case amd64_x32_sys_move_pages:
^~~~~~~~~~~~~~~~~~~~~~~~
In this switch, we indeed use enumerators of both types
amd64_x32_syscall and amd64_syscall. This is done on purpose, and the
enum values are chosen so that they are complementary.
I think it's still a useful warning, so I chose to ignore just that
particular case.
gdb/ChangeLog:
* common/diagnostics.h
(DIAGNOSTIC_IGNORE_SWITCH_DIFFERENT_ENUM_TYPES): New macro.
* amd64-linux-tdep.c (amd64_canonicalize_syscall): Use it.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Make mapped_debug_names and mapped_index final
@ 2017-12-30 7:02 sergiodj+buildbot
2017-12-30 7:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-30 7:02 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT fc898b42e355fef58e6a029799fdd71b9dda5dc6 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: fc898b42e355fef58e6a029799fdd71b9dda5dc6
Make mapped_debug_names and mapped_index final
When compiling with Clang 6, I see these warnings:
/home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:25421:5: error: destructor called on non-final 'mapped_index' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
data->index_table->~mapped_index ();
^
In file included from /home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:31:
In file included from /home/emaisin/src/binutils-gdb/gdb/defs.h:28:
In file included from /home/emaisin/src/binutils-gdb/gdb/common/common-defs.h:92:
In file included from /home/emaisin/src/binutils-gdb/gdb/common/gdb_unique_ptr.h:23:
In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/memory:81:
/usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/unique_ptr.h:76:2: error: delete called on non-final 'mapped_debug_names' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
delete __ptr;
^
/usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/unique_ptr.h:236:4: note: in instantiation of member function 'std::default_delete<mapped_debug_names>::operator()' requested here
get_deleter()(__ptr);
^
/home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:2374:21: note: in instantiation of member function 'std::unique_ptr<mapped_debug_names, std::default_delete<mapped_debug_names> >::~unique_ptr' requested here
dwarf2_per_objfile::dwarf2_per_objfile (struct objfile *objfile_,
^
This patch silences these warnings by making the classes final.
gdb/ChangeLog:
* dwarf2read.c (struct mapped_debug_names): Make final.
(struct mapped_index): Make final.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] dwarf2read: Silence -Wenum-compare-switch warning
@ 2017-12-31 2:43 sergiodj+buildbot
2017-12-31 4:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-31 2:43 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 132448f8359a268f34f074b0908b5255b568da06 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 132448f8359a268f34f074b0908b5255b568da06
dwarf2read: Silence -Wenum-compare-switch warning
Compiling with Clang 6 gives:
/home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:24385:14: error: comparison of two values with different enumeration types in switch statement ('enum dwarf_macro_record_type' and 'dwarf_macinfo_record_type') [-Werror,-Wenum-compare-switch]
case DW_MACINFO_vendor_ext:
^~~~~~~~~~~~~~~~~~~~~
/home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:24561:7: error: comparison of two values with different enumeration types in switch statement ('enum dwarf_macro_record_type' and 'dwarf_macinfo_record_type') [-Werror,-Wenum-compare-switch]
case DW_MACINFO_vendor_ext:
^~~~~~~~~~~~~~~~~~~~~
This code uses the two enum types on purpose, because it handles both
.debug_macro and .debug_macinfo sections. Add some pragmas to disable
the warning in these specific cases.
gdb/ChangeLog:
* dwarf2read.c (dwarf_decode_macro_bytes): Ignore
-Wenum-compare-switch warning.
(dwarf_decode_macros): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Only ignore -Wenum-compare-switch if it exists
@ 2017-12-31 4:57 sergiodj+buildbot
2017-12-31 6:02 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-31 4:57 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT cfa27c399ec9236a100ef794505d35f60da41a6d ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: cfa27c399ec9236a100ef794505d35f60da41a6d
Only ignore -Wenum-compare-switch if it exists
My patch
dwarf2read: Silence -Wenum-compare-switch warning
132448f8359a268f34f074b0908b5255b568da06
made some parts of dwarf2read.c ignore warnings about switch using enums
of different kinds. What I did not realize was that older Clang
versions (prior to 6) did not have that warning, and therefore give this
error:
/home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:24187:7: error: unknown warning group '-Wenum-compare-switch', ignored [-Werror,-Wunknown-pragmas]
DIAGNOSTIC_IGNORE_SWITCH_DIFFERENT_ENUM_TYPES
^
/home/emaisin/src/binutils-gdb/gdb/common/diagnostics.h:42:3: note: expanded from macro 'DIAGNOSTIC_IGNORE_SWITCH_DIFFERENT_ENUM_TYPES'
DIAGNOSTIC_IGNORE ("-Wenum-compare-switch")
^
/home/emaisin/src/binutils-gdb/gdb/common/diagnostics.h:27:3: note: expanded from macro 'DIAGNOSTIC_IGNORE'
_Pragma (STRINGIFY (GCC diagnostic ignored option))
^
<scratch space>:10:25: note: expanded from here
GCC diagnostic ignored "-Wenum-compare-switch"
^
Clang has a way to test if it knows about a particular warning. This
patch uses that feature to only define
DIAGNOSTIC_IGNORE_SWITCH_DIFFERENT_ENUM_TYPES to something if the
warning is recognized by the Clang version being used. I tested
building dwarf2read.c with clang 4, 5, 6, as well as gcc.
gdb/ChangeLog:
* common/diagnostics.h
(DIAGNOSTIC_IGNORE_SWITCH_DIFFERENT_ENUM_TYPES): Only
define if the compiler knows about -Wenum-compare-switch.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Avoid indexing std::vector past the end
@ 2017-12-31 11:04 sergiodj+buildbot
2017-12-31 15:32 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2017-12-31 11:04 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 47fea877452b84b94ac6ffb26f194f12845526fa ***
Author: Ruslan Kabatsayev <b7.10110111@gmail.com>
Branch: master
Commit: 47fea877452b84b94ac6ffb26f194f12845526fa
Avoid indexing std::vector past the end
The code here wants to find address of an element, and often this
element is one past the end of std::vector. Dereferencing that element
leads to undefined behavior, so it's better to simply use pointer
arithmetic instead of taking address of invalid dereference.
gdb/ChangeLog:
* psymtab.c (recursively_search_psymtabs): Use pointer arithmetic
instead of dereferencing std::vector past the end.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Yearly rotation of the gdb/ChangeLog file
@ 2018-01-02 3:57 sergiodj+buildbot
2018-01-02 4:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-02 3:57 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 053f54e57f64ca88596999f37bf3bd329b497d20 ***
Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 053f54e57f64ca88596999f37bf3bd329b497d20
Yearly rotation of the gdb/ChangeLog file
gdb/ChangeLog
* config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2017.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Update copyright year in version message of GDB, GDBserver and GDBreplay
@ 2018-01-02 4:44 sergiodj+buildbot
2018-01-02 6:32 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-02 4:44 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 82e1e79a420734bcb1fa255a1e7b3250e6acee65 ***
Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 82e1e79a420734bcb1fa255a1e7b3250e6acee65
Update copyright year in version message of GDB, GDBserver and GDBreplay
gdb/ChangeLog:
* top.c (print_gdb_version): Update Copyright year in version
message.
gdb/gdbserver/ChangeLog:
* gdbreplay.c (gdbreplay_version): Update copyright year in
version message.
* server.c (gdbserver_version): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb/copyright.py: Do not forget to remind about MULTIPLE_COPYRIGHT_HEADERS
@ 2018-01-02 5:29 sergiodj+buildbot
2018-01-02 8:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-02 5:29 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 0f0c98a8a1ca2fa2e73170849b1db4876c3ea954 ***
Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 0f0c98a8a1ca2fa2e73170849b1db4876c3ea954
gdb/copyright.py: Do not forget to remind about MULTIPLE_COPYRIGHT_HEADERS
There is a small logical error in the part of the script that
dumps the list of files in BY_HAND + MULTIPLE_COPYRIGHT_HEADERS
but only checkis the contents of BY_HAND. The issue becomes
apparent as soon as BY_HAND is empty. Prevent this from happening
by treating the two lists separately, as this allows us to provide
a more informative message in the case of MULTIPLE_COPYRIGHT_HEADERS.
gdb/ChangeLog:
* copyright.py (main): Dump the contents of
MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND,
even if BY_HAND is empty.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Update copyright year range in all GDB files
@ 2018-01-02 6:58 sergiodj+buildbot
2018-01-02 13:23 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-02 6:58 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e2882c85786571175a0b0bfc3bcd2f14620b1ea3 ***
Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: e2882c85786571175a0b0bfc3bcd2f14620b1ea3
Update copyright year range in all GDB files
gdb/ChangeLog:
Update copyright year range in all GDB files
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add support for dynamic DW_AT_byte_stride.
@ 2018-01-02 8:44 sergiodj+buildbot
2018-01-02 16:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-02 8:44 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a405673cc5b56c260de4e1202cead709d1a4f24c ***
Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: a405673cc5b56c260de4e1202cead709d1a4f24c
Add support for dynamic DW_AT_byte_stride.
This patch adds support for DW_AT_byte_stride, using Ada as one
example of where this would be useful. However, the implementation
is language-agnostic.
Consider the following Ada code:
procedure Nested (L, U : Integer) is
subtype Small_Type is Integer range L .. U;
type Record_Type (I : Small_Type := L) is record
S : String (1 .. I);
end record;
type Array_Type is array (Integer range <>) of Record_Type;
A1 : Array_Type :=
(1 => (I => 0, S => <>),
2 => (I => 1, S => "A"),
3 => (I => 2, S => "AB"));
procedure Discard (R : Record_Type) is
begin
null;
end Discard;
begin
Discard (A1 (1)); -- STOP
end;
It defines an array A1 of Record_Type, which is a variant record
type whose maximum size actually depends on the value of the
parameters passed when calling Nested. As a result, the stride
of the array A1 cannot be known statically, which leads the compiler
to generate a dynamic DW_AT_byte_stride attribute for our type.
Here is what the debugging info looks like with GNAT:
.uleb128 0x10 # (DIE (0x14e) DW_TAG_array_type)
.long .LASF17 # DW_AT_name: "foo__nested__T18b"
.long 0x141 # DW_AT_byte_stride
.long 0xdc # DW_AT_type
.uleb128 0x11 # (DIE (0x15f) DW_TAG_subrange_type)
.long 0x166 # DW_AT_type
.byte 0x3 # DW_AT_upper_bound
.byte 0 # end of children of DIE 0x14e
There DW_AT_byte_stride is a reference to a local (internal)
variable:
.uleb128 0x9 # (DIE (0x141) DW_TAG_variable)
.long .LASF6 # DW_AT_name: "foo__nested__T18b___PAD___XVZ"
This patch enhances GDB to handle this dynamic byte stride attribute
by first adding a new dynamic_prop_node_kind (DYN_PROP_BYTE_STRIDE)
to store the array dynamic stride info (when dynamic). It then enhances
the dynamic type resolver to handle this dynamic property.
Before applying this patch, trying to print the value of some of
A1's elements after having stopped at the "STOP" comment does not
work. For instance:
(gdb) p a1(2)
Cannot access memory at address 0x80000268dec0
With this patch applied, GDB now prints the value of all 3 elements
correctly:
(gdb) print A1(1)
$1 = (i => 0, s => "")
(gdb) print A1(2)
$2 = (i => 1, s => "A")
(gdb) print A1(3)
$3 = (i => 2, s => "AB")
gdb/ChangeLog:
* gdbtypes.h (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_STRIDE>:
New enum value.
(create_array_type_with_stride): Add byte_stride_prop parameter.
* gdbtypes.c (create_array_type_with_stride) <byte_stride_prop>:
New parameter. Update all callers in this file.
(array_type_has_dynamic_stride): New function.
(is_dynamic_type_internal, resolve_dynamic_array): Add handling
of arrays with dynamic byte strides.
* dwarf2read.c (read_array_type): Add support for dynamic
DW_AT_byte_stride attributes.
gdb/testsuite/ChangeLog:
* gdb.ada/dyn_stride: New testcase.
Tested on x86_64-linux.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: partial revert of 10c17abdd0
@ 2018-01-02 12:52 sergiodj+buildbot
2018-01-02 21:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-02 12:52 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 1508bbf535b03e3b9105d01a9e19f29f131b3d1a ***
Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 1508bbf535b03e3b9105d01a9e19f29f131b3d1a
x86: partial revert of 10c17abdd0
Other than the variables in tc-i386.c using them, OPERAND_TYPE_REGYMM
and OPERAND_TYPE_REGZMM they aren't entirely unused. No need to update
i386-init.h though, as it mistakenly wasn't updated by the original
commit.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix compile time warning (in the ARM simulator) about a print statement with insufficient arguments.
@ 2018-01-02 17:37 sergiodj+buildbot
2018-01-02 23:32 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-02 17:37 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 43724d16bebb38fe6794f6a3741352a7698038de ***
Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 43724d16bebb38fe6794f6a3741352a7698038de
Fix compile time warning (in the ARM simulator) about a print statement with insufficient arguments.
PR 22663
* maverick.c (DSPCDP4): Add missing parameter to debug print
statement.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Unbreak spurious fails in gdb.base/step-line.exp
@ 2018-01-03 4:17 sergiodj+buildbot
2018-01-03 5:44 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-03 4:17 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT bd570f80f6e47c93f4b1cc1e94688cdde33ca931 ***
Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: bd570f80f6e47c93f4b1cc1e94688cdde33ca931
Unbreak spurious fails in gdb.base/step-line.exp
My copyright year update in the copyright headers of the step-line
testcase caused it to start failing, due to shift in line numbers.
FAIL: gdb.base/step-line.exp: continue to f1
FAIL: gdb.base/step-line.exp: next to dummy 2
FAIL: gdb.base/step-line.exp: next over dummy 2
FAIL: gdb.base/step-line.exp: step into f2
FAIL: gdb.base/step-line.exp: next over dummy 4
FAIL: gdb.base/step-line.exp: next to dummy 5
FAIL: gdb.base/step-line.exp: next to dummy 6
FAIL: gdb.base/step-line.exp: next over dummy 6
FAIL: gdb.base/step-line.exp: next to dummy 7
FAIL: gdb.base/step-line.exp: next to dummy 8
FAIL: gdb.base/step-line.exp: next over dummy 8
FAIL: gdb.base/step-line.exp: next to dummy 9
FAIL: gdb.base/step-line.exp: next to dummy 10
FAIL: gdb.base/step-line.exp: next over dummy 10
This was caused by the copyright.py script after I changed it to
also update this testcase, which made the following transformation:
- Copyright (C) 2001-2017
- Free Software Foundation, Inc.
+ Copyright (C) 2001-2018 Free Software Foundation, Inc.
We can easily unbreak the testcase without having to go back to
manual edits each year by adding an extra line in the header.
gdb/testsuite/ChangeLog:
* gdb.base/step-line.c: Add extra empty line in copyright header.
* gdb.base/step-line.inp: Likewise.
Tested on x86_64-linux.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Update year range in copyright notice of binutils files
@ 2018-01-03 7:50 sergiodj+buildbot
2018-01-03 8:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-03 7:50 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 219d1afa89d0d53ca93a684cac341f16470f3ca0 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 219d1afa89d0d53ca93a684cac341f16470f3ca0
Update year range in copyright notice of binutils files
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Create pseudo sections for FreeBSD NT_PROCSTAT_(PROC|FILES|VMMAP) notes.
@ 2018-01-03 20:29 sergiodj+buildbot
2018-01-03 21:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-03 20:29 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ddb2bbcf0624ef5f75c0a007c6b192c09b6fa70b ***
Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: ddb2bbcf0624ef5f75c0a007c6b192c09b6fa70b
Create pseudo sections for FreeBSD NT_PROCSTAT_(PROC|FILES|VMMAP) notes.
bfd/ChangeLog:
* elf.c (elfcore_grok_freebsd_note): Handle
NT_FREEBSD_PROCSTAT_PROC, NT_FREEBSD_PROCSTAT_FILES, and
NT_FREEBSD_PROCSTAT_VMMAP.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add gdb.ada/info_addr_mixed_case new testcase
@ 2018-01-04 8:52 sergiodj+buildbot
2018-01-04 10:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-04 8:52 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 66fc87a0d50d2b91322cc24d17461c07925fa867 ***
Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 66fc87a0d50d2b91322cc24d17461c07925fa867
Add gdb.ada/info_addr_mixed_case new testcase
This patch adds a new testcase to demonstrate a regression introduced by:
commit b5ec771e60c1a0863e51eb491c85c674097e9e13
Date: Wed Nov 8 14:22:32 2017 +0000
Subject: Introduce lookup_name_info and generalize Ada's FULL/WILD name matching
The purpose of the testcase is to verify that a user can use any
casing for an Ada symbol name passed to the "info address" command.
After the patch above was applied, GDB was no longer able to find
the symbol:
(gdb) info address My_Table
No symbol "My_Table" in current context.
gdb/testsuite/ChangeLog:
PR gdb/22670
* gdb.ada/info_addr_mixed_case: New testcase.
Tested on x86_64-linux, both before and after the patch.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add "complete break ada" test to gdb.ada/complete.exp
@ 2018-01-04 9:35 sergiodj+buildbot
2018-01-04 12:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-04 9:35 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 344420da6beac1e0b2f7964e7101f8dcdb509b0d ***
Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 344420da6beac1e0b2f7964e7101f8dcdb509b0d
Add "complete break ada" test to gdb.ada/complete.exp
This patch adds a new test to demonstrate a regression introduced by:
commit b5ec771e60c1a0863e51eb491c85c674097e9e13
Date: Wed Nov 8 14:22:32 2017 +0000
Subject: Introduce lookup_name_info and generalize Ada's FULL/WILD name matching
The original purpose of the new test is to exercise the "complete"
command with an expression for which a large number of matches are
returned and to verify that each match returned is a plausible match.
In this particular case, the commit above causes GDB to generate
additional matches which should in fact not appear in the list
(internally generated symbols, or symbols that should be enclosed
between "<...>"). These extraneous entries are easy to spot, because
they have uppercase characters, such as:
break ada__stringsS
break ada__strings__R11s
[etc]
For now, the new test is KFAIL'ed, to avoid generating a new FAIL
while we work on fixing that regression.
gdb/testsuite/ChangeLog:
PR gdb/22670
* gdb.ada/complete.exp: Add "complete break ada" test.
Tested on x86_64-linux with GDB built before and after the patch
that caused the regression (b5ec771e60c1a0863e51eb491c85c674097e9e13).
The test passes before the regression, and generates a KFAIL after.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb.ada/maint_with_ada.exp: New testcase
@ 2018-01-04 11:13 sergiodj+buildbot
2018-01-04 17:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-04 11:13 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 7365ec2ff4a7028503f39655bd2628d54418106c ***
Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 7365ec2ff4a7028503f39655bd2628d54418106c
gdb.ada/maint_with_ada.exp: New testcase
This commit adds a new testcase testing the "check-psymtabs" and
"check-symtabs" maintenance commands.
The "maintenance check-psymtabs" commands is currently known to
produce some errors. While the situation was admetedly made worse
by the following patch...
commit b5ec771e60c1a0863e51eb491c85c674097e9e13
Date: Wed Nov 8 14:22:32 2017 +0000
Subject: Introduce lookup_name_info and generalize Ada's FULL/WILD name matching
... hence the reference to PR gdb/22670, the command was already
spotting one inconsistency prior to it:
(gdb) maintenance check-psymtabs
Global symbol `interfaces__cS' only found in /[...]/b~var_arr_typedef.adb psymtab
For now, the "check-psymtab" test is KFAIL-ed.
gdb/testsuite/ChangeLog:
PR gdb/22670
* gdb.ada/maint_with_ada: New testcase.
Tested on x86_64-linux.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] RISC-V: Add 2 missing privileged registers.
@ 2018-01-04 22:38 sergiodj+buildbot
2018-01-04 23:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-04 22:38 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 645a2c5b46e18013ac9cb16b66ba7b6b97cd01c5 ***
Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 645a2c5b46e18013ac9cb16b66ba7b6b97cd01c5
RISC-V: Add 2 missing privileged registers.
gas/
* testsuite/gas/riscv/priv-reg.s: Add missing stval and mtval.
* testsuite/gas/riscv/priv-reg.d: Likewise.
include/
* opcode/riscv-opc.h (CSR_SBADADDR): Rename to CSR_STVAL. Rename
DECLARE_CSR entry. Add alias to map sbadaddr to CSR_STVAL.
(CSR_MBADADDR): Rename to CSR_MTVAL. Rename DECLARE_CSR entry.
Add alias to map mbadaddr to CSR_MTVAL.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Bump version to 8.1.50.DATE-git.
@ 2018-01-05 5:59 sergiodj+buildbot
2018-01-05 9:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-05 5:59 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 09aca9495c4794e586680f359e612ece173148ec ***
Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 09aca9495c4794e586680f359e612ece173148ec
Bump version to 8.1.50.DATE-git.
Now that the GDB 8.1 branch has been created, we can
bump the version number.
gdb/ChangeLog:
GDB 8.1 branch created (5219ac6237c272b938c28517bf371429260c71e7):
* version.in: Bump version to 8.1.50.DATE-git.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Update NEWS post GDB 8.1 branch creation.
@ 2018-01-05 6:37 sergiodj+buildbot
2018-01-05 11:51 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-05 6:37 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT cd385f94a7888b619c84e9ab007bac5093c5e894 ***
Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: cd385f94a7888b619c84e9ab007bac5093c5e894
Update NEWS post GDB 8.1 branch creation.
gdb/ChangeLog:
* NEWS: Create a new section for the next release branch.
Rename the section of the current branch, now that it has
been cut.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] (Ada) Remove printing of array's first index when unneeded
@ 2018-01-05 7:31 sergiodj+buildbot
2018-01-05 13:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-05 7:31 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e3861a03138e24e7f2f0e8c4982bdad2a6e1dbaf ***
Author: Xavier Roirand <roirand@adacore.com>
Branch: master
Commit: e3861a03138e24e7f2f0e8c4982bdad2a6e1dbaf
(Ada) Remove printing of array's first index when unneeded
Consider the following code:
type Table is array (Character) of Natural;
My_Table : Table := (others => 4874);
Printing this table in gdb leads to:
(gdb) p my_table
$1 = ('["00"]' => 4874 <repeats 256 times>)
In this case, the index of the first element in this array is also
the first element of the index type (character type). Similar to what
we do we enumeration types, we do not need to print the index of the
first element when printing the array.
This patch fixes this issue and changes the output as follow:
(gdb) p my_table
$1 = (4874 <repeats 256 times>)
gdb/ChangeLog:
* ada-valprint.c (print_optional_low_bound): Handle
character-indexed array printing like boolean-indexed array
printing.
gdb/testuite/ChangeLog:
* testsuite/gdb.ada/array_char_idx/pck.ads (Table): New type.
(My_Table): New global variable.
* testsuite/gdb.ada/array_char_idx.exp: Add test.
Tested on x86_64-linux.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] memory error printing component of record from convenience variable
@ 2018-01-05 10:38 sergiodj+buildbot
2018-01-05 15:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-05 10:38 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT cc0e770c0d00acececc43826f4673896d09b3dff ***
Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: cc0e770c0d00acececc43826f4673896d09b3dff
memory error printing component of record from convenience variable
Consider the following situation Ada code:
type Kind_T is (One, Two, Three);
type Time_Set_T is array (Kind_T) of Integer;
type T is record
Started : Time_Set_T;
end record;
Null_T : constant T := (Started => (others => 0));
My_Item : Pck.T := Pck.Null_T;
Trying to print the value of My_Item.Started is no problem:
(gdb) p item.started
$1 = (0, 0, 0)
However, if you save My_Item into a convenience variable first,
and then try to print a component of that record, you get
an unexpected memory error, instead of getting the same result.
For instance:
(gdb) set variable $item := item
(gdb) p $item.started
Cannot access memory at address 0x0
The issue occurs when, after we extracted the component from
the convenience variable, we next try to "fix" it (which is
ada-lang speak for resolving the type into a static type).
This is done in ada_to_fixed_value, which delegates to
ada_to_fixed_value_create via:
val = ada_to_fixed_value_create (value_type (val),
value_address (val), val);
And looking at ada_to_fixed_value_create, we see that:
struct type *type = ada_to_fixed_type (type0, 0, address, NULL, 1);
if (type == type0 && val0 != NULL)
return val0;
else
return value_from_contents_and_address (type, 0, address);
The part that interests us, in this case, is the "else" branch,
where we obviously make the implicit assumption that our object
has an address, which is not true, in this case, because we are
actually dealing with a convenience variable.
This patch plugs that hole by adding special handing for situations
where val does not live in memory. In that case, we just create
a not_lval value using val's contents.
gdb/ChangeLog:
* ada-lang.c (ada_to_fixed_value_create): Add handling of
the case where VALUE_LVAL (val0) is not lval_memory.
gdb/testsuite/ChangeLog:
* gdb.ada/convvar_comp: New testcase.
Tested on x86_64-linux.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] (Ada) Fix Length attribute on array access
@ 2018-01-05 11:59 sergiodj+buildbot
2018-01-05 17:27 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-05 11:59 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 7150d33cda60fd543e9d9d68eb58d4e6155fb878 ***
Author: Jerome Guitton <guitton@adacore.com>
Branch: master
Commit: 7150d33cda60fd543e9d9d68eb58d4e6155fb878
(Ada) Fix Length attribute on array access
Consider the following variable "Indexed_By_Enum", declared as
an access to an array whose index type is an enumerated type
whose underlying values have "gaps":
type Enum_With_Gaps is (LIT0, LIT1, LIT2, LIT3, LIT4);
for Enum_With_Gaps use (LIT0 => 3,
LIT1 => 5,
LIT2 => 8,
LIT3 => 13,
LIT4 => 21);
for Enum_With_Gaps'size use 16;
type MyWord is range 0 .. 16#FFFF# ;
for MyWord'Size use 16;
type AR is array (Enum_With_Gaps range <>) of MyWord;
type AR_Access is access AR;
Indexed_By_Enum : AR_Access :=
new AR'(LIT1 => 1, LIT2 => 43, LIT3 => 42, LIT4 => 41);
Trying to print the length (number of elements) of this array using
the 'Length attribute does not work:
(gdb) print indexed_by_enum'length
'POS only defined on discrete types
The problem occurs while trying to get the array's index type.
It was using TYPE_INDEX_TYPE for that. It does not work for Ada arrays
in general; use ada_index_type instead.
gdb/ChangeLog:
* ada-lang.c (ada_array_length): Use ada_index_type instead of
TYPE_INDEX_TYPE.
gdb/testsuite/ChangeLog:
* gdb.ada/arr_acc_idx_w_gap: New testcase.
Tested on x86_64-linux.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix gdb.ada/info_addr_mixed_case.exp (PR gdb/22670)
@ 2018-01-05 17:13 sergiodj+buildbot
2018-01-05 23:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-05 17:13 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f98fc17b3ac4750842ec0fe28a18b51691ddfbda ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: f98fc17b3ac4750842ec0fe28a18b51691ddfbda
Fix gdb.ada/info_addr_mixed_case.exp (PR gdb/22670)
The comments about mixed case in the testcase are actually a red
herring. The problem here is that we'd get to
ada_lookup_encoded_symbol with "my_table", which wraps the looked up
name in "<>"s to force a verbatim match, and that in turn disables
wild matching.
Fix this by swapping around the internals of ada_lookup_encoded_symbol
and ada_lookup_symbol, thus avoiding the encoding and
verbatim-wrapping in the ada_lookup_symbol case, the case that starts
with a user-provided lookup name.
Ada encoding is still done of course, in the ada_lookup_name_info
ctor. This could be also seen as avoiding the double-encoding problem
in a different way.
gdb/ChangeLog:
2018-01-05 Pedro Alves <palves@redhat.com>
PR gdb/22670
* ada-lang.c (ada_lookup_encoded_symbol): Reimplement in terms of
ada_lookup_symbol.
(ada_lookup_symbol): Reimplement in terms of
ada_lookup_symbol_list, bits factored out from
ada_lookup_encoded_symbol.
gdb/testsuite/ChangeLog:
2018-01-05 Pedro Alves <palves@redhat.com>
PR gdb/22670
* gdb.ada/info_addr_mixed_case.exp: Remove kfail. Extend test to
exercise lower case too, and to exercise both full matching and
wild matching.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix gdb/spu-tdep.c build breakage
@ 2018-01-05 18:57 sergiodj+buildbot
2018-01-06 1:42 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-05 18:57 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a655456c134e5e02bab33941e1c738ca33905d23 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: a655456c134e5e02bab33941e1c738ca33905d23
Fix gdb/spu-tdep.c build breakage
Commit de63c46b549d ("Fix regresssion(internal-error) printing
subprogram argument (PR gdb/22670)") missed updating spu-tdep.c for
the block_lookup_symbol interface change, resulting in:
../../binutils-gdb/gdb/spu-tdep.c: In function void spu_catch_start(objfile*):
../../binutils-gdb/gdb/spu-tdep.c:1969:59: error: cannot convert domain_enum_tag to symbol_name_match_type for argument 3 to symbol* block_lookup_symbol(const block*, const char*, symbol_name_match_type, domain_enum)
sym = block_lookup_symbol (block, "main", VAR_DOMAIN);
^
gdb/ChangeLog:
2018-01-05 Pedro Alves <palves@redhat.com>
* spu-tdep.c (spu_catch_start): Pass
symbol_name_match_type::SEARCH_NAME to block_lookup_symbol.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix regression: cannot start with LD_PRELOAD=libSegFault.so (PR gdb/18653#c7)
@ 2018-01-05 19:58 sergiodj+buildbot
2018-01-06 5:33 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-05 19:58 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e379cee61f3890e535e995828e8846b020ef2a32 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: e379cee61f3890e535e995828e8846b020ef2a32
Fix regression: cannot start with LD_PRELOAD=libSegFault.so (PR gdb/18653#c7)
At https://sourceware.org/bugzilla/show_bug.cgi?id=18653#c7, Andrew
reports that the fix for PR gdb/18653 made GDB useless if you preload
libSegFault.so, because GDB internal-errors on startup:
$ LD_PRELOAD=libSegFault.so gdb
src/gdb/common/signals-state-save-restore.c:64: internal-error: unexpected signal handler
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Aborted (core dumped)
$
The internal error comes from the code saving the signal dispositions
inherited from gdb's parent:
(top-gdb) bt
#0 0x000000000056b001 in internal_error(char const*, int, char const*, ...) (file=0xaf5f38 "src/gdb/common/signals-state-save-restore.c", line=64, fmt=0xaf5f18 "unexpected signal handler") at src/gdb/common/errors.c:54
#1 0x00000000005752c9 in save_original_signals_state() () at src/gdb/common/signals-state-save-restore.c:64
#2 0x00000000007425de in captured_main_1(captured_main_args*) (context=0x7fffffffd860)
at src/gdb/main.c:509
#3 0x0000000000743622 in captured_main(void*) (data=0x7fffffffd860) at src/gdb/main.c:1145
During symbol reading, cannot get low and high bounds for subprogram DIE at 24065.
#4 0x00000000007436f9 in gdb_main(captured_main_args*) (args=0x7fffffffd860) at src/gdb/main.c:1171
#5 0x0000000000413acd in main(int, char**) (argc=1, argv=0x7fffffffd968) at src/gdb/gdb.c:32
This commit downgrades the internal error to a warning. You'll get
instead:
~~~
$ LD_PRELOAD=libSegFault.so gdb
warning: Found custom handler for signal 11 (Segmentation fault) preinstalled.
Some signal dispositions inherited from the environment (SIG_DFL/SIG_IGN)
won't be propagated to spawned programs.
GNU gdb (GDB) 8.0.50.20171213-git
Copyright (C) 2017 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law. Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-pc-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
(gdb)
~~~
This also moves the location where save_original_signals_state is
called a bit further below (to after option processing), so that "-q"
disables the warning:
~~~
$ LD_PRELOAD=libSegFault.so gdb -q
(gdb)
~~~
New testcase included.
gdb/ChangeLog:
2018-01-05 Pedro Alves <palves@redhat.com>
PR gdb/18653
* common/signals-state-save-restore.c
(save_original_signals_state): New parameter 'quiet'. Warn if we
find a custom handler preinstalled, instead of internal erroring.
But only warn if !quiet.
* common/signals-state-save-restore.h
(save_original_signals_state): New parameter 'quiet'.
* main.c (captured_main_1): Move save_original_signals_state call
after option handling, and pass QUIET.
gdb/gdbserver/ChangeLog:
2018-01-05 Pedro Alves <palves@redhat.com>
PR gdb/18653
* server.c (captured_main): Pass quiet=false to
save_original_signals_state.
gdb/testsuite/ChangeLog:
2018-01-05 Pedro Alves <palves@redhat.com>
PR gdb/18653
* gdb.base/libsegfault.exp: New.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] C++ify xmethod_worker, get rid of VEC(xmethod_worker_ptr)
@ 2018-01-07 14:48 sergiodj+buildbot
2018-01-07 16:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-07 14:48 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ba18742c3a1b62ff218db99bee47bb932af6dab9 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: ba18742c3a1b62ff218db99bee47bb932af6dab9
C++ify xmethod_worker, get rid of VEC(xmethod_worker_ptr)
The initial goal of this patch was to remove the usage of
VEC(xmethod_worker_ptr) and corresponding cleanups. I ended up having
to C++ify the xmethod_worker code, to be able to have xmethod_workers
free their data in destructors, and therefore be able to use vectors of
xmethod_worker unique_ptr.
The operations in extension_language_ops that act on one instance of
xmethod_worker (get result type, get args type, invoke) are transformed
to methods of xmethod_worker. xmethod_worker becomes an abstract base
class with virtual pure methods which python_xmethod_worker implements.
The only xmethod-related operation left in extension_language_ops is
get_matching_xmethod_workers, which returns a list of xmethod_workers.
The changes are relatively straightforward, but here are some notes on
things that may raise eyebrows:
- I was not really comfortable with the value_of_xmethod function. At
first it looks like a simple getter, so I considered making it a
method of xmethod_worker. But actually it creates a value and
transfers the ownership of the xmethod_worker to it. It would be a
bit weird and error-prone if calling a method on an object silently
removed the ownership of the object from the caller. To reflect the
behavior more accurately, I renamed it to value_from_xmethod and made
it accept an rvalue-reference (so the caller knows it gives away the
ownership). I noticed the backlink from xmethod_worker to its owning
value was not used, so I removed it.
- Some code, like get_matching_xmethod_workers, made each callee fill
a new vector, which was then merged in the result vector. I think
it's safe if we always pass the same vector around, and each
implementation just appends to it.
- The clone operation does not seem particularly useful, it is removed
in the following patch.
gdb/ChangeLog:
* extension-priv.h (enum ext_lang_rc): Remove, move to extension.h.
(struct extension_language_ops) <clone_xmethod_worker_data>: Remove.
<free_xmethod_worker_data>: Remove.
<get_matching_xmethod_workers>: Chance VEC to std::vector.
<get_xmethod_arg_types>: Remove.
<get_xmethod_result_type>: Remove.
<invoke_xmethod>: Remove.
* extension.c (new_xmethod_worker): Remove.
(clone_xmethod_worker): Remove.
(get_matching_xmethod_workers): Return void, pass std::vector by
pointer.
(get_xmethod_arg_types): Rename to...
(xmethod_worker::get_arg_types): ... this, and adjust.
(get_xmethod_result_type): Rename to...
(xmethod_worker::get_result_type): ... this, and adjust.
(invoke_xmethod): Remove.
(free_xmethod_worker): Remove.
(free_xmethod_worker_vec): Remove.
* extension.h (enum ext_lang_rc): Move here from
extension-priv.h.
(struct xmethod_worker): Add constructor and destructor.
<data>: Remove.
<value>: Remove.
<invoke, clone, do_get_result_type, do_get_arg_types>: New
virtual pure methods.
<get_arg_types, get_result_type>: New methods.
(xmethod_worker_ptr): Remove typedef.
(DEF_VEC_P (xmethod_worker_ptr)): Remove.
(xmethod_worker_vec): Remove typedef.
(xmethod_worker_up): New typedef.
(invoke_xmethod): Remove.
(clone_xmethod_worker): Remove.
(free_xmethod_worker): Remove.
(free_xmethod_worker_vec): Remove.
(get_xmethod_arg_types): Remove.
(get_xmethod_result_type): Remove.
* valops.c (find_method_list): Use std::vector, don't use
intermediate vector.
(value_find_oload_method_list): Use std::vector.
(find_overload_match): Use std::vector.
(find_oload_champ): Use std::vector.
* value.c (value_free): Use operator delete.
(value_of_xmethod): Rename to...
(value_from_xmethod): ... this. Don't assign
xmethod_worker::value, take rvalue-reference.
(result_type_of_xmethod): Adjust.
(call_xmethod): Adjust.
* value.h: Include extension.h.
(struct xmethod_worker): Don't forward-declare.
(value_of_xmethod): Rename to...
(value_from_xmethod): ... this, take rvalue-reference.
* python/py-xmethods.c (struct gdbpy_worker_data): Rename to...
(struct python_xmethod_worker): ... this, add constructor and
destructor.
<invoke, clone, do_get_arg_types, do_get_result_type>: Implement.
(gdbpy_free_xmethod_worker_data): Rename to...
(python_xmethod_worker::~python_xmethod_worker): ... this and
adjust.
(gdbpy_clone_xmethod_worker_data): Rename to...
(python_xmethod_worker::clone): ... this and adjust.
(gdbpy_get_matching_xmethod_workers): Use std::vector, don't use
temporary vector.
(gdbpy_get_xmethod_arg_types): Rename to...
(python_xmethod_worker::do_get_arg_types): ... this and adjust.
(gdbpy_get_xmethod_result_type): Rename to...
(python_xmethod_worker::do_get_result_type): ... this and
adjust.
(gdbpy_invoke_xmethod): Rename to...
(python_xmethod_worker::invoke): ... this and adjust.
(new_python_xmethod_worker): Rename to...
(python_xmethod_worker::python_xmethod_worker): ... this and
adjust.
* python/python-internal.h (gdbpy_clone_xmethod_worker_data):
Remove.
(gdbpy_free_xmethod_worker_data): Remove.
(gdbpy_get_matching_xmethod_workers): Use std::vector.
(gdbpy_get_xmethod_arg_types): Remove.
(gdbpy_get_xmethod_result_type): Remove.
(gdbpy_invoke_xmethod): Remove.
* python/python.c (python_extension_ops): Remove obsolete
callbacks.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove xmethod_worker::clone
@ 2018-01-07 15:59 sergiodj+buildbot
2018-01-07 17:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-07 15:59 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f979c73fd0be9a8a683f79af40c7b939c2a65d9f ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: f979c73fd0be9a8a683f79af40c7b939c2a65d9f
Remove xmethod_worker::clone
I think that the clone method of xmethod_worker can be removed. It is
only used in find_overload_match, to clone an xmethod we want to
keep. Instead, we can just std::move it out of the vector and into
value_from_xmethod. value_from_xmethod creates a value that will own
the xmethod_worker from that point. Other xmethod_workers left in the
vector will get destroyed when the vector gets destroyed, but the chosen
one will keep living inside the value struct.
gdb/ChangeLog:
* extension.h (struct xmethod_worker) <clone>: Remove.
* python/py-xmethods.c (struct python_xmethod_worker) <clone>:
Remove.
(python_xmethod_worker::clone): Remove.
* valops.c (find_overload_match): Use std::move instead of
clone.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Replace VEC(gdb_xml_value_s) with std::vector
@ 2018-01-07 16:23 sergiodj+buildbot
2018-01-07 20:05 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-07 16:23 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 4d0fdd9b357aff1fea3ef3def55d12464a41bf5b ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 4d0fdd9b357aff1fea3ef3def55d12464a41bf5b
Replace VEC(gdb_xml_value_s) with std::vector
This patch replaces VEC(gdb_xml_value_s), which is passed to XML
visitors, with an std::vector. In order to be able to remove the
cleanup in gdb_xml_parser::start_element, the gdb_xml_parser structure
is made to own the value with a gdb::unique_xmalloc_ptr.
This patch has been tested on the buildbot.
gdb/ChangeLog:
* xml-support.h (struct gdb_xml_value): Add constructor.
<value>: Change type to unique_xmalloc_ptr.
(gdb_xml_value_s): Remove typedef.
(DEF_VEC_O (gdb_xml_value_s)): Remove.
(gdb_xml_element_start_handler): Change parameter type to
std::vector.
(xml_find_attribute): Likewise.
* xml-support.c (xml_find_attribute): Change parameter type to
std::vector and adjust.
(gdb_xml_values_cleanup): Remove.
(gdb_xml_parser::start_element): Adjust to std::vector.
(xinclude_start_include): Change paraeter type to std::vector
and adjust.
* btrace.c (check_xml_btrace_version): Likewise.
(parse_xml_btrace_block): Likewise.
(parse_xml_btrace_pt_config_cpu): Likewise.
(parse_xml_btrace_pt): Likewise.
(parse_xml_btrace_conf_bts): Likewise.
(parse_xml_btrace_conf_pt): Likewise.
* memory-map.c (memory_map_start_memory): Likewise.
(memory_map_start_property): Likewise.
* osdata.c (osdata_start_osdata): Likewise.
(osdata_start_item): Likewise.
(osdata_start_column): Likewise.
* remote.c (start_thread): Likewise.
* solib-aix.c (library_list_start_library): Likewise.
(library_list_start_list): Likewise.
* solib-svr4.c (library_list_start_library): Likewise.
(svr4_library_list_start_list): Likewise.
* solib-target.c (library_list_start_segment): Likewise.
(library_list_start_section): Likewise.
(library_list_start_library): Likewise.
(library_list_start_list): Likewise.
* tracepoint.c (traceframe_info_start_memory): Likewise.
(traceframe_info_start_tvar): Likewise.
* xml-syscall.c (syscall_start_syscall): Likewise.
* xml-tdesc.c (tdesc_start_target): Likewise.
(tdesc_start_feature): Likewise.
(tdesc_start_reg): Likewise.
(tdesc_start_union): Likewise.
(tdesc_start_struct): Likewise.
(tdesc_start_flags): Likewise.
(tdesc_start_enum): Likewise.
(tdesc_start_field): Likewise.
(tdesc_start_enum_value): Likewise.
(tdesc_start_vector): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Replace VEC(converted_character_d) with std::vector
@ 2018-01-07 17:08 sergiodj+buildbot
2018-01-07 22:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-07 17:08 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b01ba14d4d5391e59fd0e1a3608fd47287edc008 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: b01ba14d4d5391e59fd0e1a3608fd47287edc008
Replace VEC(converted_character_d) with std::vector
This patch changes the usage of VEC(converted_character_d) to use an
std::vector instead. This allows getting rid of a cleanup.
gdb/ChangeLog:
* valprint.c (converted_character_d): Remove typedef.
(DEF_VEC_O (converted_character_d)): Remove.
(count_next_character): Use std::vector.
(print_converted_chars_to_obstack): Likewise.
(generic_printstr): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Make parse_debug_format_options return an std::string
@ 2018-01-07 18:03 sergiodj+buildbot
2018-01-08 0:00 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-07 18:03 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2cc050302cd365fd28fac65d49b6c817eed74faf ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 2cc050302cd365fd28fac65d49b6c817eed74faf
Make parse_debug_format_options return an std::string
This avoid having to manually free the return value.
gdb/gdbserver/ChangeLog:
* server.c (parse_debug_format_options): Return std::string.
(handle_monitor_command, captured_main): Adjust.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Replace objfile field in dwarf2_cu and dwarf2_per_cu_data with dwarf2_per_objfile
@ 2018-01-07 18:45 sergiodj+buildbot
2018-01-08 1:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-07 18:45 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e3b94546125849c6c513114cf20f78d2a7aa9db2 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: e3b94546125849c6c513114cf20f78d2a7aa9db2
Replace objfile field in dwarf2_cu and dwarf2_per_cu_data with dwarf2_per_objfile
The next patch aims to remove the dwarf2_per_objfile global. In many
functions, we need to find a way to get a reference to the current
dwarf2_per_objfile through the objects passed in parameters. Often, we have
access to a dwarf2_cu or a dwarf2_per_cu_data. These objects have a reference
to the objfile, through which we can get the dwarf2_per_objfile:
dwarf2_per_objfile = ((struct dwarf2_per_objfile *)
objfile_data (objfile, dwarf2_objfile_data_key));
However, this is a bit cumbersome to do all over the place. It would be
more logical if the dwarf2_cu and dwarf2_per_cu_data had a reference to
their dwarf2_per_objfile, which would then have a reference to the
objfile. It would be more in line with the object hierarchy, where
dwarf2_per_objfile owns the dwarf2_per_cu_data instances. We could
even remove the reference dwarf2_cu has to dwarf2_per_objfile, since we
can access dwarf2_per_objfile through dwarf2_cu::per_cu.
In a graphical way, references would look like this after the current
patch:
objfile <--- dwarf2_per_objfile <--- dwarf2_per_cu_data
| ^
| |
`- dwarf2_cu
This patch has been tested on the buildbot.
gdb/ChangeLog:
* dwarf2read.c (struct dwarf2_cu) <objfile>: Remove.
<dwarf2_per_objfile>: New field.
(struct dwarf2_per_cu_data) <objfile>: Remove.
<dwarf2_per_objfile>: New field.
(create_cu_from_index_list): Assign dwarf2_per_objfile instead
of objfile.
(create_signatured_type_table_from_index): Likewise.
(create_debug_type_hash_table): Likewise.
(fill_in_sig_entry_from_dwo_entry): Likewise.
(lookup_dwo_unit): Access objfile through dwarf2_per_objfile.
(create_type_unit_group): Assign dwarf2_per_objfile instead of
objfile.
(create_partial_symtab): Access objfile through
dwarf2_per_objfile.
(process_psymtab_comp_unit_reader): Likewise.
(read_comp_units_from_section): Likewise.
(scan_partial_symbols): Likewise.
(add_partial_symbol): Likewise.
(add_partial_subprogram): Likewise.
(peek_die_abbrev): Likewise.
(fixup_go_packaging): Likewise.
(process_full_comp_unit): Likewise.
(process_full_type_unit): Likewise.
(process_imported_unit_die): Likewise.
(dwarf2_compute_name): Likewise.
(dwarf2_physname): Likewise.
(read_import_statement): Likewise.
(create_cus_hash_table): Assign dwarf2_physname instead of
objfile.
(read_func_scope): Access objfile through dwarf2_per_objfile.
(read_lexical_block_scope): Likewise.
(read_call_site_scope): Likewise.
(read_variable): Likewise.
(dwarf2_rnglists_process): Likewise.
(dwarf2_ranges_process): Likewise.
(dwarf2_ranges_read): Likewise.
(dwarf2_record_block_ranges): Likewise.
(dwarf2_add_field): Likewise.
(dwarf2_add_member_fn): Likewise.
(read_structure_type): Likewise.
(process_structure_scope): Likewise.
(read_enumeration_type): Likewise.
(read_array_type): Likewise.
(read_common_block): Likewise.
(read_namespace_type): Likewise.
(read_namespace): Likewise.
(read_module_type): Likewise.
(read_tag_pointer_type): Likewise.
(read_tag_ptr_to_member_type): Likewise.
(read_tag_string_type): Likewise.
(read_subroutine_type): Likewise.
(read_typedef): Likewise.
(read_base_type): Likewise.
(attr_to_dynamic_prop): Likewise.
(read_subrange_type): Likewise.
(read_unspecified_type): Likewise.
(load_partial_dies): Likewise.
(read_partial_die): Likewise.
(find_partial_die): Likewise.
(guess_partial_die_structure_name): Likewise.
(fixup_partial_die): Likewise.
(read_attribute_value): Likewise.
(read_addr_index_from_leb128): Likewise.
(dwarf2_read_addr_index): Likewise.
(dwarf2_string_attr): Likewise.
(lnp_state_machine::check_line_address): Likewise.
(dwarf_decode_lines_1): Likewise.
(dwarf_decode_lines): Likewise.
(dwarf2_start_symtab): Likewise.
(var_decode_location): Likewise.
(new_symbol_full): Likewise.
(dwarf2_const_value_data): Likewise.
(dwarf2_const_value_attr): Likewise.
(dwarf2_const_value): Likewise.
(die_type): Likewise.
(die_containing_type): Likewise.
(lookup_die_type): Likewise.
(guess_full_die_structure_name): Likewise.
(anonymous_struct_prefix): Likewise.
(dwarf2_name): Likewise.
(follow_die_ref_or_sig): Likewise.
(follow_die_offset): Likewise.
(follow_die_ref): Likewise.
(dwarf2_fetch_die_loc_sect_off): Likewise.
(dwarf2_fetch_constant_bytes): Likewise.
(dwarf2_fetch_die_type_sect_off): Likewise.
(dwarf2_get_die_type): Likewise.
(follow_die_sig): Likewise.
(decode_locdesc): Likewise.
(dwarf2_per_cu_objfile): Likewise.
(dwarf2_per_cu_text_offset): Likewise.
(init_one_comp_unit): Assign dwarf2_per_objfile instead of
objfile.
(set_die_type): Access objfile through
dwarf2_per_objfile.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove dwarf2_per_objfile global
@ 2018-01-07 19:29 sergiodj+buildbot
2018-01-08 3:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-07 19:29 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ed2dc618b3d2b0be01ffdf74c4c75504b707bcf1 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: ed2dc618b3d2b0be01ffdf74c4c75504b707bcf1
Remove dwarf2_per_objfile global
This patch removes the global variable dwarf2_per_objfile. This global
variable is set at the various entry points of dwarf2read.c (using
dw2_setup), and is referred to throughout the file. Instead of passing
data between functions in global variables like this one, it would be
better if the functions that depend on it either received it as argument
or got it from the existing arguments they receive. For example, a
function receiving a reference to a dwarf2_per_cu_data can access it
from dwarf2_per_cu_data::dwarf2_per_objfile.
This patch has been tested on the buildbot.
gdb/ChangeLog:
* dwarf2read.c (struct mapped_debug_names): Add constructor.
<dwarf2_per_objfile>: New field.
(dwarf2_per_objfile): Remove global.
(get_dwarf2_per_objfile): New function.
(set_dwarf2_per_objfile): New function.
(dwarf2_build_psymtabs_hard): Change objfile parameter to
dwarf2_per_objfile.
(abbrev_table_read_table): Add dwarf2_per_objfile parameter.
(read_abbrev_offset): Likewise.
(read_indirect_string): Likewise.
(read_indirect_line_string): Likewise.
(read_indirect_string_at_offset): Likewise.
(read_indirect_string_from_dwz): Likewise.
(dwarf2_find_containing_comp_unit): Change objfile parameter to
dwarf2_per_objfile.
(age_cached_comp_units): Add dwarf2_per_objfile parameter.
(create_all_comp_units): Change objfile parameter to
dwarf2_per_objfile.
(create_all_type_units): Likewise.
(process_queue): Add dwarf2_per_objfile parameter.
(read_and_check_comp_unit_head): Likewise.
(lookup_dwo_unit_in_dwp): Likewise.
(get_dwp_file): Likewise.
(process_cu_includes): Likewise.
(struct free_dwo_file_cleanup_data): New struct.
(dwarf2_has_info): Use get_dwarf2_per_objfile and
set_dwarf2_per_objfile.
(dwarf2_get_dwz_file): Add dwarf2_per_objfile parameter.
(dw2_do_instantiate_symtab): Get dwarf2_per_objfile from
context, adjust calls.
(dw2_instantiate_symtab): Likewise.
(dw2_get_cutu): Add dwarf2_per_objfile parameter.
(dw2_get_cu): Likewise.
(create_cu_from_index_list): Change objfile parameter to
dwarf2_per_objfile.
(create_cus_from_index_list): Get dwarf2_per_objfile from
context, adjust calls.
(create_cus_from_index): Likewise.
(create_signatured_type_table_from_index): Change objfile
parameter to dwarf2_per_objfile.
(create_signatured_type_table_from_debug_names): Change objfile
parameter to dwarf2_per_objfile.
(create_addrmap_from_index): Likewise.
(create_addrmap_from_aranges): Likewise.
(dwarf2_read_index): Use get_dwarf2_per_objfile, adjust calls.
(dw2_setup): Remove.
(dw2_get_file_names_reader): Get dwarf2_per_objfile from
context.
(dw2_find_last_source_symtab): Get dwarf2_per_objfile using
get_dwarf2_per_objfile.
(dw2_forget_cached_source_info): Likewise.
(dw2_map_symtabs_matching_filename): Likewise.
(struct dw2_symtab_iterator) <index>: Remove.
<dwarf2_per_objfile>: New field.
(dw2_symtab_iter_init): Replace index parameter with
dwarf2_per_objfile.
(dw2_symtab_iter_next): Use dwarf2_per_objfile from iter.
(dw2_lookup_symbol): Use get_dwarf2_per_objfile and adjust.
(dw2_print_stats): Likewise.
(dw2_dump): Likewise.
(dw2_expand_symtabs_for_function): Likewise.
(dw2_expand_all_symtabs): Likewise.
(dw2_expand_symtabs_with_fullname): Likewise.
(dw2_expand_marked_cus): Replace index and objfile parameters
with dwarf2_per_objfile.
(dw_expand_symtabs_matching_file_matcher): Add
dwarf2_per_objfile parameter and adjust calls.
(dw2_expand_symtabs_matching): Use get_dwarf2_per_objfile and
adjust calls.
(dw2_find_pc_sect_compunit_symtab): Don't call dw2_setup.
(dw2_map_symbol_filenames): Use get_dwarf2_per_objfile and
adjust calls.
(create_cus_from_debug_names_list): Replace objfile parameter
with dwarf2_per_objfile and adjust calls.
(create_cus_from_debug_names): Likewise.
(dwarf2_read_debug_names): Likewise.
(mapped_debug_names::namei_to_name): Adjust call.
(dw2_debug_names_iterator::next): Likewise.
(dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
(dw2_debug_names_lookup_symbol): Use get_dwarf2_per_objfile.
(dw2_debug_names_dump): Likewise.
(dw2_debug_names_expand_symtabs_for_function): Likewise.
(dw2_debug_names_expand_symtabs_matching): Likewise.
(dwarf2_initialize_objfile): Likewise.
(dwarf2_build_psymtabs): Likewise.
(get_abbrev_section_for_cu): Get dwarf2_per_objfile from
this_cu.
(error_check_comp_unit_head): Add dwarf2_per_objfile parameter.
(read_and_check_comp_unit_head): Likewise.
(read_abbrev_offset): Likewise.
(create_debug_type_hash_table): Likewise.
(create_debug_types_hash_table): Likewise.
(create_all_type_units): Replace objfile parameter with
dwarf2_per_objfile.
(add_type_unit): Add dwarf2_per_objfile parameter.
(fill_in_sig_entry_from_dwo_entry): Replace objfile parameter
with dwarf2_per_objfile.
(lookup_dwo_signatured_type): Get dwarf2_per_objfile from cu.
(lookup_dwp_signatured_type): Likewise.
(lookup_signatured_type): Likewise.
(read_cutu_die_from_dwo): Likewise.
(init_tu_and_read_dwo_dies): Likewise.
(init_cutu_and_read_dies): Likewise.
(init_cutu_and_read_dies_no_follow): Likewise.
(allocate_type_unit_groups_table): Add objfile parameter.
(create_type_unit_group): Use dwarf2_per_objfile from cu.
(get_type_unit_group): Likewise.
(process_psymtab_comp_unit): Update call.
(build_type_psymtabs_reader): Use dwarf2_per_objfile from cu.
(build_type_psymtabs_1): Add dwarf2_per_objfile parameter.
(print_tu_stats): Likewise.
(build_type_psymtab_dependencies): Use dwarf2_per_objfile passed
in void* parameter.
(build_type_psymtabs): Change objfile parameter to
dwarf2_per_objfile.
(process_skeletonless_type_unit): Use dwarf2_per_objfile
passed in void* parameter.
(process_skeletonless_type_units): Change objfile parameter to
dwarf2_per_objfile.
(set_partial_user): Likewise.
(dwarf2_build_psymtabs_hard): Likewise.
(read_comp_units_from_section): Likewise.
(create_all_comp_units): Likewise.
(scan_partial_symbols): Update calls.
(add_partial_symbol): Likewise.
(dwarf2_read_symtab): Use get_dwarf2_per_objfile.
(maybe_queue_comp_unit): Use dwarf2_read_symtab from cu.
(process_queue): Add dwarf2_per_objfile parameter.
(get_compunit_symtab): Use dwarf2_per_objfile from cu.
(compute_compunit_symtab_includes): Likewise.
(process_cu_includes): Add dwarf2_per_objfile parameter.
(process_full_comp_unit): Use dwarf2_per_objfile from cu.
(process_full_type_unit): Likewise.
(process_imported_unit_die): Update call.
(handle_DW_AT_stmt_list): Use dwarf2_per_objfile from cu.
(read_file_scope): Likewise.
(allocate_dwo_file_hash_table): Add objfile parameter.
(lookup_dwo_file_slot): Add dwarf2_per_objfile parameter.
(create_cus_hash_table): Likewise.
(create_dwp_hash_table): Likewise.
(create_dwo_unit_in_dwp_v1): Likewise.
(create_dwp_v2_section): Likewise.
(create_dwo_unit_in_dwp_v2): Likewise.
(lookup_dwo_unit_in_dwp): Likewise.
(try_open_dwop_file): Likewise.
(open_dwo_file): Likewise. Use dwarf2_per_objfile from cu.
(open_and_init_dwo_file): Use dwarf2_per_objfile from cu, update
cleanup to include a reference to dwarf2_per_objfile.
(open_dwp_file): Add dwarf2_per_objfile parameter.
(open_and_init_dwp_file): Likewise.
(get_dwp_file): Likewise.
(lookup_dwo_cutu): Use dwarf2_per_objfile from cu.
(queue_and_load_all_dwo_tus): Update call.
(free_dwo_file_cleanup): Use dwarf2_per_objfile from cleanup
data.
(dwarf2_rnglists_process): Use dwarf2_per_objfile from cu.
(dwarf2_ranges_process): Likewise.
(dwarf2_get_pc_bounds): Likewise.
(mark_common_block_symbol_computed): Likewise.
(abbrev_table_read_table): Add dwarf2_per_objfile parameter.
(dwarf2_read_abbrevs): Update call.
(read_partial_die): Use dwarf2_per_objfile from cu.
(find_partial_die): Likewise.
(fixup_partial_die): Likewise.
(read_attribute_value): Likewise.
(read_indirect_string_at_offset_from): Add objfile parameter.
(read_indirect_string_at_offset): Add dwarf2_per_objfile
parameter.
(read_indirect_string_from_dwz): Add objfile parameter.
(read_indirect_string): Add objfile parameter.
(read_addr_index_1): Add dwarf2_per_objfile parameter.
(read_addr_index): Use dwarf2_per_objfile from cu.
(dwarf2_read_addr_index): Use dwarf2_per_objfile from cu, don't
call dw2_setup.
(read_str_index): Use dwarf2_per_objfile from cu.
(get_debug_line_section): Likewise.
(read_formatted_entries): Add dwarf2_per_objfile parameter.
(dwarf_decode_line_header): Use dwarf2_per_objfile from cu.
(new_symbol_full): Use dwarf2_per_objfile from cu.
(build_error_marker_type): Likewise.
(lookup_die_type): Likewise.
(determine_prefix): Likewise.
(follow_die_offset): Likewise.
(dwarf2_fetch_die_loc_sect_off): Use get_dwarf2_per_objfile.
(dwarf2_fetch_constant_bytes): Don't call dw2_setup.
(dwarf2_fetch_die_type_sect_off): Likewise.
(dwarf2_get_die_type): Likewise.
(follow_die_sig_1): Use dwarf2_per_objfile from cu.
(get_signatured_type): Likewise.
(get_DW_AT_signature_type): Likewise.
(dwarf_decode_macro_bytes): Add dwarf2_per_objfile parameter.
(dwarf_decode_macros): Use dwarf2_per_objfile from cu.
(cu_debug_loc_section): Likewise.
(fill_in_loclist_baton): Likewise.
(dwarf2_symbol_mark_computed): Likewise.
(dwarf2_find_containing_comp_unit): Change objfile parameter to
dwarf2_per_objfile.
(free_cached_comp_units): Use dwarf2_per_objfile passed in void*
parameter.
(age_cached_comp_units): Add dwarf2_per_objfile parameter.
(free_one_cached_comp_unit): Use dwarf2_per_objfile from cu.
(dwarf2_free_objfile): Use get_dwarf2_per_objfile.
(set_die_type): Use dwarf2_free_objfile from cu.
(get_die_type_at_offset): Likewise.
(dwarf2_per_objfile_free): Don't assign global variable.
(debug_names) <constructor>: Add dwarf2_per_objfile
parameter, update m_debugstrlookup construction.
(debug_names::debug_str_lookup): Add dwarf2_per_objfile
parameter.
<m_dwarf2_per_objfile>: New field.
<lookup>: Use m_dwarf2_per_objfile.
(check_dwarf64_offsets): Add dwarf2_per_objfile parameter.
(psyms_seen_size): Likewise.
(write_gdbindex): Replace objfile parameter with
dwarf2_per_objfile.
(write_debug_names): Likewise.
(write_psymtabs_to_index): Likewise.
(save_gdb_index_command): Use get_dwarf2_per_objfile, update
calls.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove dwarf2_cu::dwarf2_per_objfile
@ 2018-01-07 20:11 sergiodj+buildbot
2018-01-08 5:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-07 20:11 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 518817b361167ac91e7cdad8528b4d90cdc3fb26 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 518817b361167ac91e7cdad8528b4d90cdc3fb26
Remove dwarf2_cu::dwarf2_per_objfile
This patch removes the dwarf2_per_objfile field of dwarf2_cu. It is
redundant, since we can access dwarf2_per_objfile through
dwarf2_per_objfile, which is guaranteed to be set.
gdb/ChangeLog:
* dwarf2read.c (struct dwarf2_cu) <dwarf2_per_objfile>: Remove.
(dw2_get_file_names_reader): Adjust.
(lookup_dwo_signatured_type): Adjust.
(lookup_dwp_signatured_type): Adjust.
(lookup_signatured_type): Adjust.
(create_type_unit_group): Adjust.
(get_type_unit_group): Adjust.
(process_psymtab_comp_unit_reader): Adjust.
(build_type_psymtabs_reader): Adjust.
(scan_partial_symbols): Adjust.
(add_partial_symbol): Adjust.
(add_partial_subprogram): Adjust.
(peek_die_abbrev): Adjust.
(fixup_go_packaging): Adjust.
(process_imported_unit_die): Adjust.
(dwarf2_compute_name): Adjust.
(dwarf2_physname): Adjust.
(read_import_statement): Adjust.
(handle_DW_AT_stmt_list): Adjust.
(read_file_scope): Adjust.
(read_func_scope): Adjust.
(read_lexical_block_scope): Adjust.
(read_call_site_scope): Adjust.
(read_variable): Adjust.
(dwarf2_rnglists_process): Adjust.
(dwarf2_ranges_process): Adjust.
(dwarf2_ranges_read): Adjust.
(dwarf2_get_pc_bounds): Adjust.
(dwarf2_record_block_ranges): Adjust.
(dwarf2_add_field): Adjust.
(dwarf2_add_member_fn): Adjust.
(read_structure_type): Adjust.
(process_structure_scope): Adjust.
(read_enumeration_type): Adjust.
(read_array_type): Adjust.
(mark_common_block_symbol_computed): Adjust.
(read_common_block): Adjust.
(read_namespace_type): Adjust.
(read_namespace): Adjust.
(read_module_type): Adjust.
(read_tag_pointer_type): Adjust.
(read_tag_ptr_to_member_type): Adjust.
(read_tag_string_type): Adjust.
(read_subroutine_type): Adjust.
(read_typedef): Adjust.
(read_base_type): Adjust.
(attr_to_dynamic_prop): Adjust.
(read_subrange_type): Adjust.
(read_unspecified_type): Adjust.
(dwarf2_read_abbrevs): Adjust.
(load_partial_dies): Adjust.
(read_partial_die): Adjust.
(find_partial_die): Adjust.
(guess_partial_die_structure_name): Adjust.
(fixup_partial_die): Adjust.
(read_attribute_value): Adjust.
(read_addr_index): Adjust.
(read_addr_index_from_leb128): Adjust.
(read_str_index): Adjust.
(dwarf2_string_attr): Adjust.
(get_debug_line_section): Adjust.
(dwarf_decode_line_header): Adjust.
(lnp_state_machine::check_line_address): Adjust.
(dwarf_decode_lines_1): Adjust.
(dwarf_decode_lines): Adjust.
(dwarf2_start_symtab): Adjust.
(var_decode_location): Adjust.
(new_symbol_full): Adjust.
(dwarf2_const_value_data): Adjust.
(dwarf2_const_value_attr): Adjust.
(dwarf2_const_value): Adjust.
(die_type): Adjust.
(die_containing_type): Adjust.
(build_error_marker_type): Adjust.
(lookup_die_type): Adjust.
(guess_full_die_structure_name): Adjust.
(anonymous_struct_prefix): Adjust.
(determine_prefix): Adjust.
(dwarf2_name): Adjust.
(follow_die_ref_or_sig): Adjust.
(follow_die_offset): Adjust.
(follow_die_ref): Adjust.
(follow_die_sig_1): Adjust.
(follow_die_sig): Adjust.
(get_signatured_type): Adjust.
(get_DW_AT_signature_type): Adjust.
(decode_locdesc): Adjust.
(dwarf_decode_macros): Adjust.
(cu_debug_loc_section): Adjust.
(fill_in_loclist_baton): Adjust.
(dwarf2_symbol_mark_computed): Adjust.
(init_one_comp_unit): Don't assign
dwarf2_cu::dwarf2_per_objfile.
(set_die_type): Adjust.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] (Ada) Fix print of array using non-contiguous enumeration indexes
@ 2018-01-08 5:16 sergiodj+buildbot
2018-01-08 7:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-08 5:16 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 04bafb1ed002df1f25ca5a5773d87723a4baf46b ***
Author: Xavier Roirand <roirand@adacore.com>
Branch: master
Commit: 04bafb1ed002df1f25ca5a5773d87723a4baf46b
(Ada) Fix print of array using non-contiguous enumeration indexes
Consider the following code:
type Index is (Index1, Index2);
Size : constant Integer := 10;
for Index use (Index1 => 1, Index2 => Size);
type Array_Index_Enum is array (Index) of Integer;
my_table : Array_Index_Enum :=(others => 42);
When compiling the code above with a compiler where the GNAT encodings
are turned off (which can be temporarily emulated by using the compiler
switch -fgnat-encodings=minimal), printing this table in gdb leads to:
(gdb) p my_table
$1 = (42, 42, 4203344, 10, -8320, 32767, 4203465, 0, 0, 0)
The displayed content is wrong since the handling part believes
that the length of the array is max index value (10) minus the
first index value (1) i+ 1 = 10 which is wrong since index are not
contiguous in this case.
The right behavior is to detect that the array is using enumeration
index hence parse the enumeration values in order to get the number
of indexes in this array (2 indexes here).
This patch fixes this issue and changes the output as follow:
(gdb) p my_table
$1 = (42, 42)
gdb/ChangeLog:
* ada-valprint.c (val_print_packed_array_elements): Use
proper number of elements when printing an array indexed
by an enumeration type.
gdb/testsuite/ChangeLog (Joel Brobecker <brobecker@adacore.com>):
* gdb.ada/arr_enum_idx_w_gap.exp
* gdb.ada/arr_enum_idx_w_gap/foo_q418_043.adb
Tested on x86_64-linux.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix GDB build failure when $development is false
@ 2018-01-08 10:42 sergiodj+buildbot
2018-01-08 13:33 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-08 10:42 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 1e5ded6ce688ddee065fa852053dda07fcce959e ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 1e5ded6ce688ddee065fa852053dda07fcce959e
Fix GDB build failure when $development is false
We don't build GDB selftests bits when $development is false. However, if
we turn bfd/development.sh:$development to false, common/selftest.c is
compiled which is not expected. It causes the build failure,
selftest.o: In function `selftests::run_tests(char const*)':
binutils-gdb/gdb/common/selftest.c:97: undefined reference to `selftests::reset()'
collect2: error: ld returned 1 exit status
I fix this issue by putting selftest.o selftest-arch.o into CONFIG_OBS
only when $development is true. After this is fixed, there are other
build failures in maint.c, this patch fixes them as well.
In the release mode, the output of these commands are:
(gdb) maintenance selftest
Selftests are not available in a non-development build.
(gdb) maintenance selftest foo
Selftests are not available in a non-development build.
(gdb) maintenance info selftests
Selftests are not available in a non-development build.
gdb:
2018-01-08 Yao Qi <yao.qi@linaro.org>
Simon Marchi <simon.marchi@ericsson.com>
* Makefile.in (COMMON_SFILES): Remove selftest-arch.c and
common/selftest.c.
(COMMON_OBS): Remove selftest.o.
* configure.ac: Append selftest-arch.c and common/selftest.c to
CONFIG_SRCS. Append selftest-arch.o and selftest.o to COMMON_OBS.
* configure: Re-generated.
* maint.c (maintenance_selftest): Wrap selftests::run_tests with
GDB_SELF_TEST.
(maintenance_info_selftests): Likewise.
gdb/testsuite:
2018-01-08 Simon Marchi <simon.marchi@ericsson.com>
* gdb.gdb/unittest.exp: Match output in non-development mode.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: Properly encode vmovd with 64-bit memeory
@ 2018-01-08 13:11 sergiodj+buildbot
2018-01-08 20:28 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-08 13:11 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 704a705d7aaab8041df76e2981e2a1efc014aad0 ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 704a705d7aaab8041df76e2981e2a1efc014aad0
x86: Properly encode vmovd with 64-bit memeory
For historical reason, we allow movd/vmovd with 64-bit register and
memeory operands. But for vmovd, we failed to handle 64-bit memeory
operand. This has been gone unnoticed since AT&T syntax always treats
memory operand as 32-bit memory. This patch properly encodes vmovd
with 64-bit memeory operands. It also removes AVX512 vmovd with 64-bit
operands since GCC has
case TYPE_SSEMOV:
switch (get_attr_mode (insn))
{
case MODE_DI:
/* Handle broken assemblers that require movd instead of movq. */
if (!HAVE_AS_IX86_INTERUNIT_MOVQ
&& (GENERAL_REG_P (operands[0]) || GENERAL_REG_P (operands[1])))
return "%vmovd\t{%1, %0|%0, %1}";
return "%vmovq\t{%1, %0|%0, %1}";
and all AVX512 GNU assemblers set HAVE_AS_IX86_INTERUNIT_MOVQ, GCC won't
generate AVX512 vmovd with 64-bit operand.
gas/
PR gas/22681
* testsuite/gas/i386/i386.exp: Run x86-64-movd and
x86-64-movd-intel.
* testsuite/gas/i386/x86-64-movd-intel.d: New file.
* testsuite/gas/i386/x86-64-movd.d: Likewise.
* testsuite/gas/i386/x86-64-movd.s: Likewise.
opcodes/
PR gas/22681
* i386-opc.tbl: Properly encode vmovd with Qword memeory operand.
Remove AVX512 vmovd with 64-bit operands.
* i386-tbl.h: Regenerated.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR22662, nds32: Fix a typographical error.
@ 2018-01-09 9:16 sergiodj+buildbot
2018-01-09 11:13 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-09 9:16 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 6cef73f96f58ca3f0e0b2f594b324602c7590611 ***
Author: Kuan-Lin Chen <kuanlinchentw@gmail.com>
Branch: master
Commit: 6cef73f96f58ca3f0e0b2f594b324602c7590611
PR22662, nds32: Fix a typographical error.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add support for the AArch64's CSDB instruction.
@ 2018-01-09 11:49 sergiodj+buildbot
2018-01-09 16:00 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-09 11:49 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT be2e7d95414eb78f29312f30e62d4cabd55f9fda ***
Author: James Greenhalgh <james.greenhalgh@arm.com>
Branch: master
Commit: be2e7d95414eb78f29312f30e62d4cabd55f9fda
Add support for the AArch64's CSDB instruction.
CSDB is a new instruction which Arm has defined. It has the same encoding as
HINT #0x14 and is available at all architecture levels.
opcodes * aarch64-tbl.h (aarch64_opcode_table): Add "csdb".
* aarch64-asm-2.c: Regenerate.
* aarch64-dis-2.c: Regenerate.
* aarch64-opc-2.c: Regenerate.
gas * testsuite/gas/aarch64/system.d: Update expected results to expect
CSDB.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Support 'info proc' for FreeBSD process core dumps.
@ 2018-01-09 22:14 sergiodj+buildbot
2018-01-09 23:21 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-09 22:14 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d2176225dc982c22640215a0e611e997e8eeb030 ***
Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: d2176225dc982c22640215a0e611e997e8eeb030
Support 'info proc' for FreeBSD process core dumps.
- Command line arguments are obtained from the pr_psargs[] array
saved in the NT_PRPSINFO note.
- The 'cwd' and 'exe' values are obtained from the per-process file
descriptor table stored in the NT_PROCSTAT_FILES core note.
- 'mappings' is implemented by walking the array of VM map entries
stored in the NT_PROCSTAT_VMMAP core note.
- 'status' output is generated by outputting fields from
the first structure stored in the NT_PROCSTAT_PROC core note.
- 'stat' is aliased to 'status'.
gdb/ChangeLog:
* fbsd-tdep.c (KVE_STRUCTSIZE, KVE_START, KVE_END, KVE_OFFSET)
(KVE_FLAGS, KVE_PROTECTION, KVE_PATH, KINFO_VME_PROT_READ)
(KINFO_VME_PROT_WRITE, KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
(KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
(KINFO_VME_FLAG_SUPER, KINFO_VME_FLAG_GROWS_UP)
(KINFO_VME_FLAG_GROWS_DOWN, KF_STRUCTSIZE, KF_TYPE, KF_FD)
(KF_PATH, KINFO_FILE_TYPE_VNODE, KINFO_FILE_FD_TYPE_CWD)
(KINFO_FILE_FD_TYPE_TEXT, SIG_WORDS, struct kinfo_proc_layout)
(kinfo_proc_layout_32, kinfo_proc_layout_i386)
(kinfo_proc_layout_64, fbsd_vm_map_entry_flags)
(fbsd_core_info_proc_mappings, fbsd_core_vnode_path)
(fbsd_core_fetch_timeval, fbsd_print_sigset)
(fbsd_core_info_proc_status, fbsd_core_info_proc): New.
(fbsd_init_abi): Install gdbarch "core_info_proc" method.
* fbsd-tdep.h (fbsd_vm_map_entry_flags): New.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Use gdb::unique_xmalloc_ptr<> instead of a deleter that invokes free().
@ 2018-01-09 23:38 sergiodj+buildbot
2018-01-10 5:06 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-09 23:38 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 262f62f57d987269152412a55c458a03adc6ddd6 ***
Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: 262f62f57d987269152412a55c458a03adc6ddd6
Use gdb::unique_xmalloc_ptr<> instead of a deleter that invokes free().
Since xfree() always wraps free(), it is safe to use the xfree deleter
for buffers allocated by library routines such as kinfo_getvmmap() that
must be released via free().
gdb/ChangeLog:
* fbsd-nat.c (struct free_deleter): Remove.
(fbsd_find_memory_regions): Use gdb::unique_xmalloc_ptr<>.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Support 'info proc' for native FreeBSD processes.
@ 2018-01-10 0:28 sergiodj+buildbot
2018-01-10 7:23 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-10 0:28 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 92fce24de299a8b9a9a1c0c6b98e0e9c1656f99c ***
Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: 92fce24de299a8b9a9a1c0c6b98e0e9c1656f99c
Support 'info proc' for native FreeBSD processes.
- Command line arguments are fetched via the kern.proc.args.<pid>
sysctl.
- The 'cwd' and 'exe' values are obtained from the per-process
file descriptor table returned by kinfo_getfile() from libutil.
- 'mappings' is implemented by walking the array of VM map entries
returned by kinfo_getvmmap() from libutil.
- 'status' output is generated by outputting fields from the structure
returned by the kern.proc.pid.<pid> sysctl.
- 'stat' is aliased to 'status'.
gdb/ChangeLog:
* configure.ac: Check for kinfo_getfile in libutil.
* configure: Regenerate.
* config.in: Regenerate.
* fbsd-nat.c: Include "fbsd-tdep.h".
(fbsd_fetch_cmdline): New.
(fbsd_fetch_kinfo_proc): Move earlier and change to return a bool
rather than calling error.
(fbsd_info_proc): New.
(fbsd_thread_name): Report error if fbsd_fetch_kinfo_proc fails.
(fbsd_wait): Report warning if fbsd_fetch_kinfo_proc fails.
(fbsd_nat_add_target): Set "to_info_proc" to "fbsd_info_proc".
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Document support for 'info proc' on FreeBSD.
@ 2018-01-10 1:01 sergiodj+buildbot
2018-01-10 9:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-10 1:01 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2d97a5d9d33aea87c3bd02fd1fa417f5d4e1fa05 ***
Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: 2d97a5d9d33aea87c3bd02fd1fa417f5d4e1fa05
Document support for 'info proc' on FreeBSD.
Since the 'info proc' support on FreeBSD does not use /proc, reword
the documentation for 'info proc' to not assume /proc. This includes
renaming the node to 'Process Information' and suggesting that
additional process information can be queried via different
OS-specific interfaces. This is also cleans up the description of
'info proc' support for core files a bit as /proc is not used for core
file support on any current platform.
gdb/ChangeLog:
* NEWS: Document that 'info proc' now works on FreeBSD.
gdb/doc/ChangeLog:
* gdb.texinfo (pwd): Update cross-reference for Process Information
node and remove explicit /proc reference.
(Native): Rename subsection from SVR4 Process Information to
Process Information.
(Process Information): Reword introduction to be less /proc
centric. Document support for "info proc" on FreeBSD.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] RISC-V: Disassemble x0 based addresses as 0.
@ 2018-01-10 2:16 sergiodj+buildbot
2018-01-10 11:29 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-10 2:16 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 35fd2b2bcf370837a03f077acf1222f0a7e9c4d1 ***
Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 35fd2b2bcf370837a03f077acf1222f0a7e9c4d1
RISC-V: Disassemble x0 based addresses as 0.
gas/
* testsuite/gas/riscv/auipc-x0.d: New.
* testsuite/gas/riscv/auipc-x0.s: New.
opcodes/
* riscv-dis.c (maybe_print_address): If base_reg is zero,
then the hi_addr value is zero.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: fix Disp8 handling for scalar AVX512_4FMAPS insns
@ 2018-01-10 14:58 sergiodj+buildbot
2018-01-10 18:29 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-10 14:58 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT cbda583ada32e16bf8b6c6aff730cc9eab63b364 ***
Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: cbda583ada32e16bf8b6c6aff730cc9eab63b364
x86: fix Disp8 handling for scalar AVX512_4FMAPS insns
Just like their packed counterparts the memory operand is always 16
bytes wide, and the Disp8 scaling is the same for all of them. (As a
side note: I'm also surprised by there being AVX512VL variants of
these as well as the AVX512_4VNNIW ones - the SDM doesn't define any
such.)
Adjust the test cases also for the packed forms to actually live up to
their promise of testing correct Disp8 encoding.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Update the libiberty sources with the latest patches found in the master sources.
@ 2018-01-10 15:48 sergiodj+buildbot
2018-01-10 20:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-10 15:48 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2a8ae7146cacb006105e2e9c6f4635aca543e7ec ***
Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 2a8ae7146cacb006105e2e9c6f4635aca543e7ec
Update the libiberty sources with the latest patches found in the master sources.
2017-01-02 Richard Biener <rguenther@suse.de>
PR lto/83452
* simple-object-elf.c (simple_object_elf_copy_lto_debug_section):
Do not use UNDEF locals for removed symbols but instead just
define them in the first prevailing section and with no name.
Use the same gnu_lto_v1 name for all removed globals we promote to
WEAK UNDEFs so hpux can use a stub to provide this symbol. Clear
sh_info and sh_link in removed sections.
2017-10-30 Richard Biener <rguenther@suse.de>
PR lto/82757
* simple-object-elf.c (simple_object_elf_copy_lto_debug_sections):
Strip two leading _s from the __gnu_lto_* symbols.
2017-10-24 Alan Modra <amodra@gmail.com>
PR lto/82687
PR lto/82575
* simple-object-elf.c (simple_object_elf_copy_lto_debug_sections):
Only make __gnu_lto symbols hidden.
2017-10-20 Alan Modra <amodra@gmail.com>
PR lto/82575
* simple-object-elf.c (simple_object_elf_copy_lto_debug_sections):
Make discarded non-local symbols weak and hidden.
2017-10-18 Jakub Jelinek <jakub@redhat.com>
PR lto/82598
* simple-object.c (handle_lto_debug_sections): Copy over also
.note.GNU-stack section with unchanged name.
* simple-object-elf.c (SHF_EXECINSTR): Define.
(simple_object_elf_copy_lto_debug_section): Drop SHF_EXECINSTR bit
on .note.GNU-stack section.
2017-09-25 Nathan Sidwell <nathan@acm.org>
PR demangler/82195
* cp-demangle.c (d_encoding): Strip return type when name is a
LOCAL_NAME.
(d_local_name): Strip return type of enclosing TYPED_NAME.
* testsuite/demangle-expected: Add and adjust tests.
2017-09-21 Nathan Sidwell <nathan@acm.org>
PR demangler/82195
* cp-demangle.c (d_name): Revert addition of 'toplevel' parm.
(has_return_type): Recurse for DEMANGLE_COMPONENT_LOCAL_NAME.
(d_encoding): Revert d_name change. Use is_fnqual_component_type
to strip modifiers that do not belong.
(d_special_name, d_class_enum_type): Revert d_name call change.
(d_expresion_1): Commonize DEMANGLE_COMPONENT_UNARY building.
(d_local_name): Revert parsing of a function type.
(d_print_comp_inner): An inner LOCAL_NAME might contain a
TEMPLATE.
* testsuite/demangle-expected: Add & adjust tests
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix gdb.ada/complete.exp's "complete break ada" test (PR gdb/22670)
@ 2018-01-11 0:21 sergiodj+buildbot
2018-01-11 2:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-11 0:21 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d4c2a405cb7535d25b88e9b8dad0e557242950ca ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: d4c2a405cb7535d25b88e9b8dad0e557242950ca
Fix gdb.ada/complete.exp's "complete break ada" test (PR gdb/22670)
This patch fixes the regression covered by the test added by:
commit 344420da6beac1e0b2f7964e7101f8dcdb509b0d
Date: Thu Jan 4 03:30:37 2018 -0500
Subject: Add "complete break ada" test to gdb.ada/complete.exp
The regression had been introduced by:
commit b5ec771e60c1a0863e51eb491c85c674097e9e13
Date: Wed Nov 8 14:22:32 2017 +0000
Subject: Introduce lookup_name_info and generalize Ada's FULL/WILD name matching
The gist of it is that linespec completion in Ada mode is generating
additional matches that should not appear in the match list
(internally generated symbols, or symbols that should be enclosed
between "<...>"). These extraneous entries have uppercase characters, such as:
break ada__stringsS
break ada__strings__R11s
[etc]
These matches come from minimal symbols. The problem is that Ada
minsyms end up with no language set (language_auto), and thus we end
up using the generic symbol name matcher for those instead of Ada's.
We already had a special case for in compare_symbol_name to handle
this, but it was limited to expressions, while the case at hand is
completing a linespec. Fix this by applying the special case to
linespec completion as well. I.e., remove the EXPRESSION check from
compare_symbol_name. That alone turns out to not be sufficient still
-- GDB would still show a couple entries that shouldn't be there:
~~
break ada__exceptions__exception_data__append_info_exception_name__2Xn
break ada__exceptions__exception_data__exception_name_length__2Xn
~~
The reason is that these minimal symbols end up with their language
set to language_cplus / C++, because those encoded names manage to
demangle successfully as C++ symbols (using an old C++ mangling
scheme):
$ echo ada__exceptions__exception_data__append_info_exception_name__2Xn | c++filt
Xn::ada__exceptions__exception_data__append_info_exception_name(void)
It's unfortunate that Ada's encoding scheme doesn't start with some
unique prefix like "_Z" in the C++ Itanium ABI mangling scheme. For
now, paper over that by treating C++ minsyms as Ada minsyms.
gdb/ChangeLog:
2018-01-10 Pedro Alves <palves@redhat.com>
PR gdb/22670
* ada-lang.c (ada_collect_symbol_completion_matches): If the
minsym's language is language_auto or language_cplus, pass down
language_ada instead.
* symtab.c (compare_symbol_name): Don't frob symbol language here.
gdb/testsuite/ChangeLog:
2018-01-10 Pedro Alves <palves@redhat.com>
PR gdb/22670
* gdb.ada/complete.exp ("complete break ada"): Replace kfail with
a fail.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Ada: make verbatim matcher override other language matchers (PR gdb/22670)
@ 2018-01-11 1:05 sergiodj+buildbot
2018-01-11 5:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-11 1:05 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c63d3e8d12f0b08cda95f89aa13274defed215f0 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: c63d3e8d12f0b08cda95f89aa13274defed215f0
Ada: make verbatim matcher override other language matchers (PR gdb/22670)
A previous patch fixed verbatim matching in the lookup at the minimal
symbol level, but we should also be finding that same symbol through
the partial/full symtab search.
For example, this is what happens if we use "print" instead of
"break":
(gdb) p <MixedCaseFunc>
$1 = {<text variable, no debug info>} 0x4024dc <MixedCaseFunc>
Before the C++ wildmatching series, GDB knows that MixedCaseFunc is a
function without parameters, and the expression above means calling
it. If you try it before having started the inferior, you'd get the
following (expected) error:
(gdb) print <MixedCaseFunc>
You can't do that without a process to debug.
The main idea behind making the name matcher be determined by the
symbol's language is so that C++ (etc.) wildmatching in linespecs
works even if the current language is not C++, as e.g., when you step
through C or assembly code.
Ada's verbatim matching syntax however ("<...>") isn't quite the same.
It is more a property of the current language than of a particular
symbol's language. We want to support this syntax when debugging an
Ada program, but it's reason of existence is to find non-Ada symbols.
This suggests going back to enabling it depending on current language
instead of language of the symbol being matched.
I'm not entirely happy with the "current_language" reference (though I
think that it's harmless). I think we could try storing the current
language in the lookup_name_info object, and then convert a bunch of
functions more to pass around lookup_name_info objects instead of
"const char *" names. I.e., build the lookup_name_info higher up.
I'm not sure about that, I'll have to think more about it. Maybe
something different will be better. Meanwhile, this gets us going.
I've extended the testcase to also exercise a no-debug-info function,
for extra coverage of the minsyms-only paths.
gdb/ChangeLog:
2018-01-10 Pedro Alves <palves@redhat.com>
PR gdb/22670
* dwarf2read.c
(gdb_index_symbol_name_matcher::gdb_index_symbol_name_matcher):
Adjust to use language_get_symbol_name_matcher instead of
language_defn::la_get_symbol_name_matcher.
* language.c (language_get_symbol_name_matcher): If in Ada mode
and the lookup name is a verbatim match, return Ada's matcher.
* language.h (language_get_symbol_name_matcher): Adjust comment.
(ada_lookup_name_info::verbatim_p):: New method.
gdb/testsuite/ChangeLog:
2018-01-10 Pedro Alves <palves@redhat.com>
PR gdb/22670
* gdb.ada/bp_c_mixed_case.exp: Add intro comment. Test printing C
functions too. Test setting breakpoints and printing C functions
with no debug info too.
* gdb.ada/bp_c_mixed_case/qux.c: New file.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] language_get_symbol_name_matcher -> get_symbol_name_matcher
@ 2018-01-11 1:53 sergiodj+buildbot
2018-01-11 6:42 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-11 1:53 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 618daa933cdce21424d3759ea95a4e2f5c69a1c2 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 618daa933cdce21424d3759ea95a4e2f5c69a1c2
language_get_symbol_name_matcher -> get_symbol_name_matcher
Rename language_get_symbol_name_matcher -> get_symbol_name_matcher,
since the function is no longer a straight "language method".
gdb/ChangeLog:
2018-01-10 Pedro Alves <palves@redhat.com>
* language.h (language_get_symbol_name_matcher): Rename ...
(get_symbol_name_matcher): ... this.
* language.c (language_get_symbol_name_matcher): Ditto.
* dictionary.c, linespec.c, minsyms.c, psymtab.c, symtab.c: All
callers adjusted.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove VL variants for 4FMAPS and 4VNNIW insns.
@ 2018-01-11 5:36 sergiodj+buildbot
2018-01-11 15:25 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-11 5:36 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 888a89da7fa5d219695234c3a8dc7b8a57dfe8ee ***
Author: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
Branch: master
Commit: 888a89da7fa5d219695234c3a8dc7b8a57dfe8ee
Remove VL variants for 4FMAPS and 4VNNIW insns.
AVX512_4FMAPS and AVX512_4VNNIW insns are marked as having AVX512VL
variants. That is wrong as SDM doesn't define such instructions. The
patch removes these VL variants.
gas/
* testsuite/gas/i386/avx512_4fmaps-warn.l: Change xmm to zmm.
* testsuite/gas/i386/avx512_4fmaps-warn.s: Likewise.
* testsuite/gas/i386/avx512_4fmaps_vl-intel.d: Delete.
* testsuite/gas/i386/avx512_4fmaps_vl-warn.l: Likewise.
* testsuite/gas/i386/avx512_4fmaps_vl-warn.s: Likewise.
* testsuite/gas/i386/avx512_4fmaps_vl.d: Likewise.
* testsuite/gas/i386/avx512_4fmaps_vl.s: Likewise.
* testsuite/gas/i386/avx512_4vnniw_vl-intel.d: Likewise.
* testsuite/gas/i386/avx512_4vnniw_vl.d: Likewise.
* testsuite/gas/i386/avx512_4vnniw_vl.s: Likewise.
* testsuite/gas/i386/i386.exp: Delete _vl tests for 4fmaps an
4vnniw tests.
* testsuite/gas/i386/x86-64-avx512_4fmaps_vl-intel.d: Delete.
* testsuite/gas/i386/x86-64-avx512_4fmaps_vl-warn.l: Likewise.
* testsuite/gas/i386/x86-64-avx512_4fmaps_vl-warn.s: Likewise.
* testsuite/gas/i386/x86-64-avx512_4fmaps_vl.d: Likewise.
* testsuite/gas/i386/x86-64-avx512_4fmaps_vl.s: Likewise.
* testsuite/gas/i386/x86-64-avx512_4vnniw_vl-intel.d: Likewise.
* testsuite/gas/i386/x86-64-avx512_4vnniw_vl.d: Likewise.
* testsuite/gas/i386/x86-64-avx512_4vnniw_vl.s: Likewise.
opcodes/
* i386-opc.tbl: Remove VL variants for 4FMAPS and 4VNNIW
insns.
* i386-tbl.h: Regenerate.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix backwards compatibility with old GDBservers (PR remote/22597)
@ 2018-01-11 6:23 sergiodj+buildbot
2018-01-11 17:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-11 6:23 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 3cada74087687907311b52781354ff551e10a0ed ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 3cada74087687907311b52781354ff551e10a0ed
Fix backwards compatibility with old GDBservers (PR remote/22597)
At <https://sourceware.org/ml/gdb-patches/2017-12/msg00285.html>,
Maciej reported that commit:
commit 5cd63fda035d4ba949e6478406162c4673b3c9ef
Date: Wed Oct 4 18:21:10 2017 +0100
Subject: Fix "Remote 'g' packet reply is too long" problems with multiple inferiors
made GDB stop working with older stubs. Any attempt to continue
execution after the initial connection fails with:
[...]
Process .../gdb/testsuite/outputs/gdb.base/advance/advance created; pid = 2670
Listening on port 2346
target remote [...]:2346
Remote debugging using [...]:2346
Reading symbols from .../lib64/ld.so.1...done.
[Switching to Thread <main>]
(gdb) continue
Cannot execute this command without a live selected thread.
(gdb)
The problem is:
(gdb) c
Cannot execute this command without a live selected thread.
(gdb) info threads
Id Target Id Frame
1 Thread 14917 0x00007f341cd98ed0 in _start () from /lib64/ld-linux-x86-64.so.2
The current thread <Thread ID 2> has terminated. See `help thread'.
^^^^^^^^^^^
(gdb)
Note, thread _2_. There's really only one thread in the inferior
(it's still at the entry point), but still GDB added a bogus second
thread.
The reason GDB started adding a second thread after 5cd63fda035d is
this hunk:
+ if (event->ptid == null_ptid)
+ {
+ const char *thr = strstr (p1 + 1, ";thread:");
+ if (thr != NULL)
+ event->ptid = read_ptid (thr + strlen (";thread:"),
+ NULL);
+ else
+ event->ptid = magic_null_ptid;
+ }
Note the else branch that falls back to magic_null_ptid. We reach
that when we process the initial stop reply sent back in response to
the the "?" (status) packet early in the connection setup:
Sending packet: $?#3f...Ack
Packet received: T0506:0000000000000000;07:40a510f4fd7f0000;10:d0fe1201577f0000;
And note that that response does not include a ";thread:XXX" part.
This stop reply is processed after listing threads with qfThreadInfo /
qsThreadInfo :
Sending packet: $qfThreadInfo#bb...Ack
Packet received: m3915
Sending packet: $qsThreadInfo#c8...Ack
Packet received: l
meaning, when we process that stop reply, we treat the event as coming
from a thread with ptid == magic_null_ptid, which is not yet in the
thread list, so we add it then:
(top-gdb) p ptid
$1 = {m_pid = 42000, m_lwp = -1, m_tid = 1}
(top-gdb) bt
#0 0x0000000000840a8c in add_thread_silent(ptid_t) (ptid=...) at src/gdb/thread.c:269
#1 0x00000000007ad61d in remote_add_thread(ptid_t, int, int) (ptid=..., running=0, executing=0)
at src/gdb/remote.c:1838
#2 0x00000000007ad8de in remote_notice_new_inferior(ptid_t, int) (currthread=..., executing=0)
at src/gdb/remote.c:1921
#3 0x00000000007b758b in process_stop_reply(stop_reply*, target_waitstatus*) (stop_reply=0x1158860, status=0x7fffffffcc00)
at src/gdb/remote.c:7217
#4 0x00000000007b7a38 in remote_wait_as(ptid_t, target_waitstatus*, int) (ptid=..., status=0x7fffffffcc00, options=0)
at src/gdb/remote.c:7380
#5 0x00000000007b7cd1 in remote_wait(target_ops*, ptid_t, target_waitstatus*, int) (ops=0x102fac0 <remote_ops>, ptid=..., status=0x7fffffffcc00, options=0) at src/gdb/remote.c:7446
#6 0x000000000081587b in delegate_wait(target_ops*, ptid_t, target_waitstatus*, int) (self=0x102fac0 <remote_ops>, arg1=..., arg2=0x7fffffffcc00, arg3=0) at src/gdb/target-delegates.c:138
#7 0x0000000000827d77 in target_wait(ptid_t, target_waitstatus*, int) (ptid=..., status=0x7fffffffcc00, options=0)
at src/gdb/target.c:2179
#8 0x0000000000715fda in do_target_wait(ptid_t, target_waitstatus*, int) (ptid=..., status=0x7fffffffcc00, options=0)
at src/gdb/infrun.c:3589
#9 0x0000000000716351 in wait_for_inferior() () at src/gdb/infrun.c:3707
#10 0x0000000000715435 in start_remote(int) (from_tty=1) at src/gdb/infrun.c:3212
things go downhill from this.
We don't see the problem with current master gdbserver, because that
version always sends the ";thread:" part in the initial stop reply:
Sending packet: $?#3f...Packet received: T0506:0000000000000000;07:a0d4ffffff7f0000;10:d05eddf7ff7f0000;thread:p3cea.3cea;core:3;
Years ago I had added a "--disable-packet=" command line option to
gdbserver which comes in handy for testing this, since the existing
"--disable-packet=Tthread" precisely makes gdbserver not send that
";thread:" part in stop replies. The testcase added by this commit
emulates old gdbserver making use of that.
I've compared a testrun at 5cd63fda035d^ (before regression) with
'current master+patch', against old gdbserver at f8b73d13b7ca^. I
hacked out --once, and "monitor exit" to be able to test. The results
are a bit too unstable to tell accurately, but it looked like there
were no regressions. Maciej confirmed this worked for him as well.
No regressions on master (against master gdbserver).
gdb/ChangeLog:
2018-01-11 Pedro Alves <palves@redhat.com>
PR remote/22597
* remote.c (remote_parse_stop_reply): Default to the last-set
general thread instead of to 'magic_null_ptid'.
gdb/testsuite/ChangeLog:
2018-01-11 Pedro Alves <palves@redhat.com>
PR remote/22597
* gdb.server/stop-reply-no-thread.c: New file.
* gdb.server/stop-reply-no-thread.exp: New file.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] ld: Keep PREINIT_ARRAY/INIT_ARRAY/FINI_ARRAY sections for -r --gc-sections
@ 2018-01-11 18:02 sergiodj+buildbot
2018-01-11 22:07 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-11 18:02 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 8b6f4cd34fdde524ea035c65f7d48aaa3fb449b5 ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 8b6f4cd34fdde524ea035c65f7d48aaa3fb449b5
ld: Keep PREINIT_ARRAY/INIT_ARRAY/FINI_ARRAY sections for -r --gc-sections
We must keep all PREINIT_ARRAY, INIT_ARRAY as well as FINI_ARRAY sections
for ld -r --gc-sections.
bfd/
PR ld/22677
* elflink.c (bfd_elf_gc_sections): Keep all PREINIT_ARRAY,
INIT_ARRAY as well as FINI_ARRAY sections for ld -r --gc-sections.
ld/
PR ld/22677
* scripttempl/elf.sc (PREINIT_ARRAY): New.
Don't add .preinit_array for ld -r.
* testsuite/ld-elf/pr22677.d: New file.
* testsuite/ld-elf/pr22677.s: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb.base/breakpoint-in-ro-region.exp regression on sss targets (PR gdb/22583)
@ 2018-01-11 19:05 sergiodj+buildbot
2018-01-11 23:42 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-11 19:05 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 71d378ae60a4f072ce392046878d471255f6c8a1 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 71d378ae60a4f072ce392046878d471255f6c8a1
gdb.base/breakpoint-in-ro-region.exp regression on sss targets (PR gdb/22583)
As Maciej reported at
<https://sourceware.org/ml/gdb-patches/2017-12/msg00212.html>, this
commit:
commit d930703d68ae160ddfe8ebe5fdcf416fb6090e1e
Date: Thu Nov 16 18:44:43 2017 +0000
Subject: Don't ever Quit out of resume
caused regressions on software single-set targets, specifically:
FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: single-step breakpoint is not left behind
FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw on: single-step breakpoint is not left behind
FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted on: auto-hw off: step in ro region (cannot insert hw break)
FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted on: auto-hw off: single-step breakpoint is not left behind
FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted on: auto-hw on: single-step breakpoint is not left behind
and indeed detailed logs indicate a breakpoint is left lingering, e.g.:
(gdb) PASS: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: step in ro region (cannot insert sw break)
maint info breakpoints 0
Num Type Disp Enb Address What
0 sw single-step keep y 0x00400774 in main at [...]/gdb/testsuite/gdb.base/breakpoint-in-ro-region.c:24 inf 1 thread 1
stop only in thread 1
(gdb) FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: single-step breakpoint is not left behind
vs:
(gdb) PASS: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: step in ro region (cannot insert sw break)
maint info breakpoints 0
No breakpoint or watchpoint matching '0'.
(gdb) PASS: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: single-step breakpoint is not left behind
as at commit d930703d68ae^.
Before commit d930703d68ae, we had a cleanup installed in 'resume'
that would delete single-step breakpoints on error:
/* Resuming. */
/* Things to clean up if we QUIT out of resume (). */
static void
resume_cleanups (void *ignore)
{
if (!ptid_equal (inferior_ptid, null_ptid))
delete_single_step_breakpoints (inferior_thread ());
normal_stop ();
}
That whole function was removed by d930703d68ae mainly to eliminate
the normal_stop call:
~~~~
Note that the exception called from within resume ends up calling
normal_stop via resume_cleanups. That's very borked though, because
normal_stop is going to re-handle whatever was the last reported
event, possibly even re-running a hook stop...
~~~~
But as the regression shows, removing resume_cleanups completely went
a bit too far, as the delete_single_step_breakpoints call is still
necessary.
So fix the regression by reinstating the
delete_single_step_breakpoints call on error. However, since we're
trying to eliminate cleanups, restore it in a different form (using
TRY/CATCH).
Tested on x86-64 GNU/Linux both top of master and on top of a series
that implements software single-step on x86.
gdb/ChangeLog:
2018-01-11 Pedro Alves <palves@redhat.com>
PR gdb/22583
* infrun.c (resume): Rename to ...
(resume_1): ... this.
(resume): Reimplement as wrapper around resume_1.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Ignore dynamic references on forced local symbols
@ 2018-01-11 23:57 sergiodj+buildbot
2018-01-12 4:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-11 23:57 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d664fd41e15f058aab41b70c567ad09f2fab1115 ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: d664fd41e15f058aab41b70c567ad09f2fab1115
Ignore dynamic references on forced local symbols
We should ignore dynamic references on forced local symbols during
garbage collection since they can never be referenced dynamically.
bfd/
PR ld/22649
* elflink.c (bfd_elf_gc_mark_dynamic_ref_symbol): Ignore dynamic
references on forced local symbols.
ld/
PR ld/22649
* testsuite/ld-elf/pr22649-1.s: New file.
* testsuite/ld-elf/pr22649-2a.s: Likewise.
* testsuite/ld-elf/pr22649-2b.s: Likewise.
* testsuite/ld-elf/pr22649.msg: Likewise.
* testsuite/ld-elf/shared.exp: Run ld/22649 tests.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb_compile_shlib: Only consider shlib= options when building executables
@ 2018-01-12 2:29 sergiodj+buildbot
2018-01-12 6:44 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-12 2:29 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 6181e9c2c5ba252ac016f51903dc35d7bfbbca71 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 6181e9c2c5ba252ac016f51903dc35d7bfbbca71
gdb_compile_shlib: Only consider shlib= options when building executables
Trying to use gdb_compile_shlib with the shlib= option to build a shared
library that depends on another shared library does not work as of
today. See:
https://sourceware.org/ml/gdb-patches/2017-10/msg00733.html
The problem is that building the lib is done in two steps, compilation
(.c -> .o) and linking (.o -> .so) and the shlib= options are passed to
both steps. When compiling the object file (.o), it results in gcc
complaining:
gcc: warning: .../solib-vanish-lib2.so: linker input file unused because linking not done
The first solution I came up with was to filter the options inside
gdb_compile_shlib to remove the shlib= options from the options we pass
when compiling the .o file.
I then thought it would be simpler to ignore the shlib= options in
gdb_compile when not building an executable (the executable category
includes the shared libraries). For other compilation types (object
file, preprocess and generate assembly), it doesn't make sense to add
shared libraries to the source file list.
Regtested on the buildbot.
gdb/testsuite/ChangeLog:
* lib/gdb.exp (gdb_compile): Ignore shlib= and shlib_load
options when not creating an executable.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] ld: Create a new LOAD segment for separate code segment
@ 2018-01-12 4:24 sergiodj+buildbot
2018-01-12 11:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-12 4:24 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2888249fc9eb38b6d6e4bd969ce63c26e3753d5e ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 2888249fc9eb38b6d6e4bd969ce63c26e3753d5e
ld: Create a new LOAD segment for separate code segment
When generating separate code LOAD segment, create a new LOAD segment
if the previous section contains text and the current section doesn't
or vice versa:
Elf file type is DYN (Shared object file)
Entry point 0x200020
There are 7 program headers, starting at offset 52
Program Headers:
Type Offset VirtAddr PhysAddr FileSiz MemSiz Flg Align
LOAD 0x000000 0x00000000 0x00000000 0x00200 0x00200 R 0x200000
LOAD 0x200000 0x00200000 0x00200000 0x00036 0x00036 R E 0x200000
LOAD 0x400000 0x00400000 0x00400000 0x00064 0x00064 R 0x200000
LOAD 0x400f80 0x00600f80 0x00600f80 0x000a0 0x000a0 RW 0x200000
DYNAMIC 0x400f80 0x00600f80 0x00600f80 0x00080 0x00080 RW 0x4
GNU_STACK 0x000000 0x00000000 0x00000000 0x00000 0x00000 RW 0x10
GNU_RELRO 0x400f80 0x00600f80 0x00600f80 0x00080 0x00080 R 0x1
Section to Segment mapping:
Segment Sections...
00 .hash .gnu.hash .dynsym .dynstr .rela.plt
01 .plt .text
02 .rodata .eh_frame
03 .dynamic .got.plt
04 .dynamic
05
06 .dynamic
to prevent fetching or executing data in code pages as instructions.
Also don't put a writable section in a read-only segment if there is a
RELRO segment.
Since code segment is aligned and padded to the maximum page size on
disk, the minimum file size is bigger than the maximum page size which
is 2MB (0x200000):
-rwxr-xr-x 1 hjl hjl 4201932 Jan 10 10:41 libfoo.so
"-z max-page-size=0x1000" can be used to reduce the maximum page size to
4KB (0x1000):
-rwxr-xr-x 1 hjl hjl 15820 Jan 10 10:44 libfoo.so
PR ld/22393
* elf.c (_bfd_elf_map_sections_to_segments): When generating
separate code and read-only data LOAD segments, create a new
LOAD segment if the previous section contains text and the
current section doesn't or vice versa. Don't put a writable
section in a read-only segment if there is a RELRO segment.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fixes for "Ignore dynamic references on forced local symbols"
@ 2018-01-12 11:03 sergiodj+buildbot
2018-01-12 21:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-12 11:03 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 87e79a6515951fece72ee08871dd6e112b1042ba ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 87e79a6515951fece72ee08871dd6e112b1042ba
Fixes for "Ignore dynamic references on forced local symbols"
PowerPC64 has its own mark_dynamic_ref, which needs the same change as
made by d664fd41e1 to the generic ELF version. Some other targets
discard more than just .data, so allow for that too in expected ld
messages.
bfd/
PR ld/22649
* elf64-ppc.c (ppc64_elf_gc_mark_dynamic_ref): Ignore dynamic
references on forced local symbols.
ld/
PR ld/22649
* testsuite/ld-elf/pr22649.msg: Allow other messages.
* testsuite/ld-elf/shared.exp: Check that --gc-sections is
supported before running ld/22649 tests.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix override of common symbols for a.out
@ 2018-01-12 11:55 sergiodj+buildbot
2018-01-12 23:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-12 11:55 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a78eea1623aa6d05a395a73414bf01f6c8ae81c6 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: a78eea1623aa6d05a395a73414bf01f6c8ae81c6
Fix override of common symbols for a.out
The default should be bfd_link_common_skip_none, as in the original
patch at https://sourceware.org/ml/binutils/2002-07/msg00717.html
* aoutx.h (aout_link_check_ar_symbols): Remove default and handle
bfd_link_common_skip_none in switch.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Optimize the performance of the group_setup function.
@ 2018-01-12 13:37 sergiodj+buildbot
2018-01-13 0:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-12 13:37 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 564e11c9a9d9570b233b38cd995f1b4eb7c757e8 ***
Author: Jens Widell <jl@opera.com>
Branch: master
Commit: 564e11c9a9d9570b233b38cd995f1b4eb7c757e8
Optimize the performance of the group_setup function.
When processing a section that is a member of a group, the group
that contains it is looked up using a linear search. The resulting
O(n^2) complexity causes significant performance issues when
dealing with object files with very many groups.
By remembering the index of the last found group and restarting
the next search from that index, the search instead becomes O(n)
in common cases.
* elf.c (setup_group): Optimize search for group by remembering
last found group and restarting search at that index.
* elf-bfd.h (struct elf_obj_tdata): Add group_search_offset field.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix GDB hang with remote after error from resume
@ 2018-01-12 19:19 sergiodj+buildbot
2018-01-13 2:33 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-12 19:19 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT bdf2a94aa535016a1640d56e9b2b539c4376bf31 ***
Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: bdf2a94aa535016a1640d56e9b2b539c4376bf31
Fix GDB hang with remote after error from resume
Since this commit --
Fix PR18360 - internal error when using "interrupt -a"
(https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=c65d6b55)
-- the testsuite shows long delays on s390 with native-gdbserver when
executing certain tests, such as watchpoints.exp. These hangs have been
discussed before in the context of buildbot problems, see here:
https://sourceware.org/ml/gdb-patches/2017-12/msg00413.html
The problem can easily be triggered by stopping on a breakpoint, then
setting impossible watchpoints, and finally doing "continue". Then, after
having set the step-over state (in keep_going_pass_signal in infrun.c),
GDB tries to insert breakpoints and watchpoints into the inferior. This
fails, and the "continue" command is aborted. But the step-over state is
not cleared in this case, which causes future step-over attempts to be
skipped since GDB thinks that "we already have an in-line step-over
operation ongoing" (see start_step_over in infrun.c). Thus the next
"continue" just goes on to wait for events from the remote, which will
never occur.
The problem can also be reproduced on amd64 with native-gdbserver, using
the following change to watchpoints.exp:
-- >8 --
--- a/gdb/testsuite/gdb.base/watchpoints.exp
+++ b/gdb/testsuite/gdb.base/watchpoints.exp
@@ -61,2 +61,3 @@ with_test_prefix "before inferior start" {
gdb_test "watch ival3" ".*" ""
+ gdb_test "watch *(char \[256\] *) main"
-- >8 --
To fix the hang, this patch clears the step-over info when
insert_breakpoints has failed. Of course, with native-gdbserver the
watchpoints.exp test case still causes many FAILs on s390, because
gdbserver does not support watchpoints for that target. This is a
separate issue.
gdb/ChangeLog:
2018-01-12 Andreas Arnez <arnez@linux.vnet.ibm.com>
* infrun.c (keep_going_pass_signal): Clear step-over info when
insert_breakpoints fails.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add testcase for GDB hang fixed by previous commit
@ 2018-01-12 20:00 sergiodj+buildbot
2018-01-13 6:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-12 20:00 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT eea61984abfea2c0acdc7e46ec182a14698b3bf9 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: eea61984abfea2c0acdc7e46ec182a14698b3bf9
Add testcase for GDB hang fixed by previous commit
This adds a testcase for the previous commit. The regression was
related to in-line step overs. The reason we didn't see it on native
x86-64/s390 GNU/Linux testing is that native debugging uses displaced
stepping by default (because native debugging defaults to "maint set
target-non-stop on"), unlike remote debugging.
So in order to trigger the bug with native debugging as well, the
testcase disables displaced stepping explicitly.
Also, instead of using watchpoints to trigger the regression, the
testcase uses a breakpoint at address 0, which should be more
portable.
gdb/testsuite/ChangeLog:
2018-01-12 Pedro Alves <palves@redhat.com>
* gdb.base/continue-after-aborted-step-over.c: New.
* gdb.base/continue-after-aborted-step-over.exp: New.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Install and generate docs for gdb-add-index
@ 2018-01-12 23:43 sergiodj+buildbot
2018-01-13 15:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-12 23:43 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ba643918cf869fa0d064d733f69b453b6fe642ea ***
Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: ba643918cf869fa0d064d733f69b453b6fe642ea
Install and generate docs for gdb-add-index
The "gdb-add-index" script has been resurrected on:
commit caf26be91a584ef141ac5d3cb31007731af8b8e3
Author: Samuel Bronson <naesten@gmail.com>
Date: Fri Nov 15 16:09:33 2013 -0500
Resurrect gdb-add-index as a contrib script
However, for some reason (I couldn't find it in the archives), only
the script has been checked-in; the Makefile parts responsible for
installing it in the system were left out. This commit fixes that, by
also resurrecting the Makefile and documentation bits.
This commit is part of our effort to upstream the local Fedora GDB
changes. With this commit, we'll only carry a very small
Fedora-specific modification to the script.
gdb/ChangeLog:
2017-01-12 Tom Tromey <tom@tromey.com>
Sergio Durigan Junior <sergiodj@redhat.com>
* Makefile.in (install-only): Install gdb-add-index.
gdb/doc/ChangeLog:
2017-01-12 Tom Tromey <tom@tromey.com>
Sergio Durigan Junior <sergiodj@redhat.com>
* gdb.texinfo (Index Files): Mention gdb-add-index.
(gdb-add-index man): New section.
* Makefile.in (gdb-add-index.1): New rule to generate manpage
from gdb.texinfo.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb/testsuite: Don't attempt tests if they fail to compile
@ 2018-01-13 0:00 sergiodj+buildbot
2018-01-13 17:14 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-13 0:00 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT cbcdb1aaddb4dd1a388eadbea6b6ec342c7ab067 ***
Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: cbcdb1aaddb4dd1a388eadbea6b6ec342c7ab067
gdb/testsuite: Don't attempt tests if they fail to compile
In the gdb.base/whatis-ptype-typedefs.exp test, if the test program
fails to compile, don't run the tests.
gdb/testsuite/ChangeLog:
* gdb.base/whatis-ptype-typedefs.exp: Don't run tests if we failed
to prepare.
(prepare): Return 0 on error, 1 on success.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add note about 2.30 branch creation to changelogs
@ 2018-01-13 13:46 sergiodj+buildbot
2018-01-13 20:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-13 13:46 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT faf766e31794722b7e2c24e44e920d0476cede32 ***
Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: faf766e31794722b7e2c24e44e920d0476cede32
Add note about 2.30 branch creation to changelogs
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Bump version number to 2.30.51
@ 2018-01-13 14:31 sergiodj+buildbot
2018-01-13 23:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-13 14:31 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 769c7ea507209948135facd04bf8defc3f21a8a4 ***
Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 769c7ea507209948135facd04bf8defc3f21a8a4
Bump version number to 2.30.51
bfd/
* version.m4: Bump version to 2.30.51
* configure: Regenerate.
binutils/
* configure: Regenerate.
gas/
* configure: Regenerate.
gprof/
* configure: Regenerate.
ld/
* configure: Regenerate.
opcodes/
* configure: Regenerate.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Update notes on how to make a release
@ 2018-01-13 16:17 sergiodj+buildbot
2018-01-14 3:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-13 16:17 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 19e2900bd399d1ba272afe8b5b50b1b29a948bbe ***
Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 19e2900bd399d1ba272afe8b5b50b1b29a948bbe
Update notes on how to make a release
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix scm-ports.exp regression
@ 2018-01-15 20:05 sergiodj+buildbot
2018-01-15 22:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-15 20:05 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 86d6a90c58ee3fb924bcbca154f4e32347437e6c ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 86d6a90c58ee3fb924bcbca154f4e32347437e6c
Fix scm-ports.exp regression
In https://sourceware.org/ml/gdb-patches/2017-12/msg00215.html, Jan
pointed out that the scalar printing patches caused a regression in
scm-ports.exp on x86.
What happens is that on x86, this:
set sp_reg [get_integer_valueof "\$sp" 0]
... ends up setting sp_reg to a negative value, because
get_integer_valueof uses "print/d":
print /d $sp
$1 = -11496
Then later the test suite does:
gdb_test "guile (print (seek rw-mem-port (value->integer sp-reg) SEEK_SET))" \
"= $sp_reg" \
"seek to \$sp"
... expecting this value to be identical to the saved $sp_reg value.
However it gets:
guile (print (seek rw-mem-port (value->integer sp-reg) SEEK_SET))
= 4294955800
"print" is just a wrapper for guile's format:
gdb_test_no_output "guile (define (print x) (format #t \"= ~A\" x) (newline))"
The seek function returns a scm_t_off, the printing of which is
handled by guile, not by gdb.
Tested on x86-64 Fedora 26 using an ordinary build and also a -m32
build.
2018-01-15 Tom Tromey <tom@tromey.com>
* gdb.guile/scm-ports.exp (test_mem_port_rw): Use get_valueof to
compute sp_reg.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb/common/signals-state-save-restore.c: Fix typos
@ 2018-01-15 23:14 sergiodj+buildbot
2018-01-16 2:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-15 23:14 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT db422fb2120e311318657d9c7dd0e7b0b5a5eac9 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: db422fb2120e311318657d9c7dd0e7b0b5a5eac9
gdb/common/signals-state-save-restore.c: Fix typos
gdb/ChangeLog:
2018-01-15 Pedro Alves <palves@redhat.com>
* common/signals-state-save-restore.c
(save_original_signals_state): Fix typos.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] RISC-V: Add support for addi that compresses to c.nop.
@ 2018-01-16 0:18 sergiodj+buildbot
2018-01-16 4:33 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-16 0:18 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2721d702a055fe0f7621386123b103b5c4d84662 ***
Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 2721d702a055fe0f7621386123b103b5c4d84662
RISC-V: Add support for addi that compresses to c.nop.
gas/
* testsuite/gas/riscv/c-zero-imm.s: Test addi that compresses to c.nop.
* testsuite/gas/riscv/c-zero-imm.d: Likewise.
opcodes/
* riscv-opc.c (match_c_nop): New.
(riscv_opcodes) <addi>: Handle an addi that compresses to c.nop.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Update translations for various binutils components.
@ 2018-01-16 13:03 sergiodj+buildbot
2018-01-16 14:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-16 13:03 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f6efed019b4e49a4c27b518afbdf2d9bf0652843 ***
Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: f6efed019b4e49a4c27b518afbdf2d9bf0652843
Update translations for various binutils components.
ld * po/pt_BR.po: Updated Brazilian Portugese translation.
opcodes * po/pt_BR.po: Updated Brazilian Portugese translation.
* po/de.po: Updated German translation.
gas * po/fr.po: Updated French translation.
binutils* po/fr.po: Updated French translation.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Warning fix
@ 2018-01-17 11:10 sergiodj+buildbot
2018-01-17 12:23 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 11:10 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c75bc4f76fe456c57ef1e446db5378182692c429 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: c75bc4f76fe456c57ef1e446db5378182692c429
Warning fix
* elf64-ppc.c (ppc64_elf_build_stubs): Silence gcc warning.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Relax gdb.compile/compile.exp to match the address printed for frame
@ 2018-01-17 11:56 sergiodj+buildbot
2018-01-17 14:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 11:56 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d8447b6b9fd288ebd35620178ba720b1f0ce7ebf ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: d8447b6b9fd288ebd35620178ba720b1f0ce7ebf
Relax gdb.compile/compile.exp to match the address printed for frame
One test in gdb.compile/compile.exp passes on one fedora builder,
bt
#0 0x00007ffff7ff43f6 in _gdb_expr (__regs=0x7ffff7ff2000) at gdb
command line:1^M
#1 <function called from gdb>^M
#2 main () at /home/gdb-buildbot/fedora-x86-64-1/fedora-x86-64/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.compile/compile.c:106^M
(gdb) PASS: gdb.compile/compile.exp: bt
but fails on my machine with gcc trunk,
bt^M
#0 _gdb_expr (__regs=0x7ffff7ff3000) at gdb command line:1^M
#1 <function called from gdb>^M
#2 main () at gdb/testsuite/gdb.compile/compile.c:106^M
(gdb) FAIL: gdb.compile/compile.exp: bt
The test should be tweaked to match both cases (pc in the start of line
vs pc in the middle of line). Note that I am not clear that why libcc1
emits debug info this way so that the address is in the middle of line.
gdb/testsuite:
2018-01-17 Yao Qi <yao.qi@linaro.org>
* gdb.compile/compile.exp: Match the address printed for
frame in the output of command "bt".
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Replace CET bit with IBT and SHSTK bits.
@ 2018-01-17 17:04 sergiodj+buildbot
2018-01-18 4:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 17:04 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d777820bf5abea433c36e956b53b299502e0f708 ***
Author: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
Branch: master
Commit: d777820bf5abea433c36e956b53b299502e0f708
Replace CET bit with IBT and SHSTK bits.
The latest specification for Intel CET technology defined two
new bits instead of previously used CET bit. These are IBT and
SHSTK bits. The patch replaces CET bit with IBT and SHSTK bits.
gas/
* config/tc-i386.c (cpu_arch): Delete .cet. Add .ibt, .shstk.
(cpu_noarch): Add noibt, noshstk.
(parse_insn): Change cpucet to cpuibt.
* doc/c-i386.texi: Delete .cet. Add .ibt, .shstk.
* testsuite/gas/i386/cet-ibt-inval.l: New test.
* testsuite/gas/i386/cet-ibt-inval.s: Likewise.
* testsuite/gas/i386/cet-shstk-inval.l: Likewise.
* testsuite/gas/i386/cet-shstk-inval.s: Likewise.
* testsuite/gas/i386/x86-64-cet-ibt-inval.l: Likewise.
* testsuite/gas/i386/x86-64-cet-ibt-inval.s: Likewise.
* testsuite/gas/i386/x86-64-cet-shstk-inval.l: Likewise.
* testsuite/gas/i386/x86-64-cet-shstk-inval.s: Likewise.
opcodes/
* i386-gen.c (cpu_flag_init): Delete CPU_CET_FLAGS,
CpuCET. Add CPU_IBT_FLAGS, CPU_SHSTK_FLAGS, CPY_ANY_IBT_FLAGS,
CPU_ANY_SHSTK_FLAGS, CpuIBT, CpuSHSTK.
(cpu_flags): Add CpuIBT, CpuSHSTK.
* i386-opc.h (enum): Add CpuIBT, CpuSHSTK.
(i386_cpu_flags): Add cpuibt, cpushstk.
* i386-opc.tbl: Change CpuCET to CpuSHSTK and CpuIBT.
* i386-init.h: Regenerate.
* i386-tbl.h: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] linux-nat: Remove unnecessary xstrdup
@ 2018-01-17 17:53 sergiodj+buildbot
2018-01-18 6:41 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 17:53 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a7b2d0fbeb4ca22ffbf56d19d06b7d1cb774e383 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: a7b2d0fbeb4ca22ffbf56d19d06b7d1cb774e383
linux-nat: Remove unnecessary xstrdup
I think this xstrdup is not useful. We can pass ex.message directly to
throw_error instead.
gdb/ChangeLog:
* linux-nat.c (linux_nat_attach): Remove xstrdup.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Make linux_ptrace_attach_fail_reason return an std::string
@ 2018-01-17 17:59 sergiodj+buildbot
2018-01-18 8:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 17:59 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 4d9b86e17505063c96a01d40cdf5b4fc2080a798 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 4d9b86e17505063c96a01d40cdf5b4fc2080a798
Make linux_ptrace_attach_fail_reason return an std::string
This patch makes linux_ptrace_attach_fail_reason and
linux_ptrace_attach_fail_reason_string return std::string. It also
replaces usages of struct buffer with std::string. This allows getting
rid of a cleanup in in linux_ptrace_attach_fail_reason_string and
simplifies the code in general.
Something that looks odd to me is that in
linux_ptrace_attach_fail_reason, if the two messages are appended, there
is no separating space or \n, so the result won't be very nice. I left
it as-is for now though.
gdb/ChangeLog:
* nat/linux-ptrace.h (linux_ptrace_attach_fail_reason): Return
std::string.
(linux_ptrace_attach_fail_reason_string): Likewise.
* nat/linux-ptrace.c (linux_ptrace_attach_fail_reason):
Likewise.
(linux_ptrace_attach_fail_reason_string): Likewise.
* linux-nat.c (attach_proc_task_lwp_callback): Adjust.
gdb/gdbserver/ChangeLog:
* linux-low.c (attach_proc_task_lwp_callback): Adjust to
linux_ptrace_attach_fail_reason_string now returning an
std::string.
(linux_attach): Likewise.
* thread-db.c (attach_thread): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix gdb segv when objfile can't be opened
@ 2018-01-17 18:49 sergiodj+buildbot
2018-01-18 10:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 18:49 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 416675305692976aca45860e24b963982a2e682a ***
Author: Mike Gulick <mike.gulick@mathworks.com>
Branch: master
Commit: 416675305692976aca45860e24b963982a2e682a
Fix gdb segv when objfile can't be opened
This fixes PR 16577.
This patch changes gdb_bfd_map_section to issue a warning rather than an error
if it is unable to read the object file, and sets the size of the section/frame
that it attempted to read to 0 on error.
The description of gdb_bfd_map_section states that it will try to read or map
the contents of the section SECT, and if successful, the section data is
returned and *SIZE is set to the size of the section data. This function was
throwing an error and leaving *SIZE as-is. Setting the section size to 0
indicates to dwarf2_build_frame_info that there is no data to read, otherwise
it will try to read from an invalid frame pointer.
Changing the error to a warning allows this to be handled gracefully.
Additionally, the error was clobbering the breakpoint output indicating the
current frame (function name, arguments, source file, and line number). E.g.
Thread 3 "foo" hit Breakpoint 1, BFD: reopening /tmp/jna-1013829440/jna2973250704389291330.tmp: No such file or directory
BFD: reopening /tmp/jna-1013829440/jna2973250704389291330.tmp: No such file or directory
(gdb)
While the "BFD: reopening ..." messages will still appear interspersed in the
breakpoint output, the current frame info is now displayed:
Thread 3 "foo" hit Breakpoint 1, BFD: reopening /tmp/jna-1013829440/jna1875755897659885075.tmp: No such file or directory
BFD: reopening /tmp/jna-1013829440/jna1875755897659885075.tmp: No such file or directory
warning: Can't read data for section '.eh_frame' in file '/tmp/jna-1013829440/jna1875755897659885075.tmp'
do_something () at file.cpp:80
80 {
(gdb)
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Allocate dwarf2_cu with new
@ 2018-01-17 19:45 sergiodj+buildbot
2018-01-18 16:38 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 19:45 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT fcd3b13d80a2d0e5fc31ef6a245be62db6a11420 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: fcd3b13d80a2d0e5fc31ef6a245be62db6a11420
Allocate dwarf2_cu with new
This changes dwarf2_cu to be allocated with new, and fixes up the
users.
2018-01-17 Tom Tromey <tom@tromey.com>
Simon Marchi <simon.marchi@ericsson.com>
* dwarf2read.c (struct dwarf2_cu): Add constructor, destructor.
(dwarf2_per_objfile::free_cached_comp_units)
(init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
(init_cutu_and_read_dies_no_follow): Update.
(dwarf2_cu::dwarf2_cu): Rename from init_one_comp_unit.
(dwarf2_cu::~dwarf2_cu): New.
(free_heap_comp_unit, free_stack_comp_unit): Remove.
(age_cached_comp_units, free_one_cached_comp_unit): Update.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Change dwarf2_cu::method_info to be a std::vector
@ 2018-01-17 19:57 sergiodj+buildbot
2018-01-18 18:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 19:57 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c89b44cdc52b6a9c0848a795689895e292ad1f46 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: c89b44cdc52b6a9c0848a795689895e292ad1f46
Change dwarf2_cu::method_info to be a std::vector
This changes the type of dwarf2_cu::method_info and fixes up the uses.
In order to remove cleanups from process_full_comp_unit and
process_full_type_unit, psymtab_include_file_name also had to be
changed to avoid leaving dangling cleanups.
2018-01-17 Tom Tromey <tom@tromey.com>
* dwarf2read.c (delayed_method_info): Remove typedef.
(dwarf2_cu::method_info): Now a std::vector.
(add_to_method_list): Update.
(free_delayed_list): Remove.
(compute_delayed_physnames): Update.
(process_full_comp_unit, process_full_type_unit): Clear the method
list. Remove cleanups.
(psymtab_include_file_name): Add name_holder parameter. Use
unique_xmalloc_ptr.
(dwarf_decode_lines): Update.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove objfile argument from add_dyn_prop
@ 2018-01-17 20:09 sergiodj+buildbot
2018-01-18 20:59 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 20:09 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 50a820477b5d48d4c2d28ca1c22ba6d93c9fd7cb ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 50a820477b5d48d4c2d28ca1c22ba6d93c9fd7cb
Remove objfile argument from add_dyn_prop
The objfile argument to add_dyn_prop is redundant, so this patch
removes it.
2018-01-17 Tom Tromey <tom@tromey.com>
* gdbtypes.h (add_dyn_prop): Remove objfile parameter.
* gdbtypes.c (add_dyn_prop): Remove objfile parameter.
(create_array_type_with_stride): Update.
* dwarf2read.c (set_die_type): Update.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Allocate abbrev_table with new
@ 2018-01-17 20:16 sergiodj+buildbot
2018-01-18 15:00 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 20:16 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 685af9cd2283b07a222157723e239f09d6ea2682 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 685af9cd2283b07a222157723e239f09d6ea2682
Allocate abbrev_table with new
This changes dwarf2read.c to allocate abbrev tables using "new", and
then updates the users.
This version of the patch incorporates the changes that Simon
implemented. These changes simplify the ownership rules for abbrev
tables.
2018-01-17 Tom Tromey <tom@tromey.com>
Simon Marchi <simon.marchi@ericsson.com>
* dwarf2read.c (struct dwarf2_cu) <abbrev_table>: Remove.
(struct die_reader_specs) <abbrev_table>: New member.
(struct abbrev_table): Add constructor.
<alloc_abbrev, add_abbrev, lookup_abbrev>: Declare.
<abbrev_obstack>: Now an auto_obstack.
(abbrev_table_up): New typedef.
(init_cu_die_reader): Add abbrev_table parameter.
(read_cutu_die_from_dwo): Remove abbrev_table_provided parameter.
Add result_dwo_abbrev_table.
(init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
(init_cutu_and_read_dies_no_follow, build_type_psymtabs_1):
Update.
(peek_die_abbrev): Take die_reader_specs, not dwarf_cu as
parameter.
(skip_children): Update.
(abbrev_table::alloc_abbrev): Rename from
abbrev_table_alloc_abbrev.
(abbrev_table::add_abbrev): Rename from abbrev_table_add_abbrev.
(abbrev_table::lookup_abbrev): Rename from
abbrev_table_lookup_abbrev.
(abbrev_table_read_table): Return abbrev_table_up.
(abbrev_table_free, abbrev_table_free_cleanup)
(dwarf2_read_abbrevs, dwarf2_free_abbrev_table): Remove.
(load_partial_dies): Update.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove symbolp typedef
@ 2018-01-17 20:21 sergiodj+buildbot
2018-01-18 23:08 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 20:21 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9e14690d06ac55136b7f051a2d2b8e173fa3bbdf ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 9e14690d06ac55136b7f051a2d2b8e173fa3bbdf
Remove symbolp typedef
This removes the symbolp typedef from dwarf2read.c. It is no longer
used.
2018-01-17 Tom Tromey <tom@tromey.com>
* dwarf2read.c (symbolp): Remove typedef. Don't instantiate VEC.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] RISC-V: Fix bug in prior addi/c.nop patch.
@ 2018-01-17 22:21 sergiodj+buildbot
2018-01-19 1:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 22:21 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e925c834ecdb4a0ce595ad8d3da9c7d4f499ede0 ***
Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: e925c834ecdb4a0ce595ad8d3da9c7d4f499ede0
RISC-V: Fix bug in prior addi/c.nop patch.
gas/
* config/tc-riscv.c (validate_riscv_insn) <'z'>: New.
(riscv_ip) <'z'>: New.
opcodes/
* riscv-opc.c (riscv_opcodes) <addi>: Use z instead of 0.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix warning on gdb/compile/compile.c (C++-ify "triplet_rx")
@ 2018-01-17 23:20 sergiodj+buildbot
2018-01-19 4:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 23:20 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 7d937cad0acdccd0ff485435fbe16f005e994c66 ***
Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: 7d937cad0acdccd0ff485435fbe16f005e994c66
Fix warning on gdb/compile/compile.c (C++-ify "triplet_rx")
This fixes a GCC warning that happens when compiling
gdb/compile/compile.c on some GCC versions (e.g., "gcc (GCC) 7.2.1
20180104 (Red Hat 7.2.1-6)"):
../../gdb/compile/compile.c: In function 'void eval_compile_command(command_line*, const char*, compile_i_scope_types, void*)':
../../gdb/compile/compile.c:548:19: warning: 'triplet_rx' may be used uninitialized in this function [-Wmaybe-uninitialized]
error_message = compiler->fe->ops->set_arguments_v0 (compiler->fe, triplet_rx,
~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
argc, argv);
~~~~~~~~~~~
../../gdb/compile/compile.c:466:9: note: 'triplet_rx' was declared here
char *triplet_rx;
^~~~~~~~~~
It's a simple patch that converts "triplet_rx" from "char *" to
"std::string", thus guaranteeing that it will be always initialized.
I've regtested this patch and did not find any regressions. OK to
apply on both master and 8.1 (after creating a bug for it)?
gdb/ChangeLog:
2018-01-17 Sergio Durigan Junior <sergiodj@redhat.com>
* compile/compile.c (compile_to_object): Convert "triplet_rx"
to "std::string".
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PowerPC PLT stub alignment fixes
@ 2018-01-18 12:14 sergiodj+buildbot
2018-01-19 9:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-18 12:14 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 691d2e9af211ff8dd5fa8c96cb961b73a78394d7 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 691d2e9af211ff8dd5fa8c96cb961b73a78394d7
PowerPC PLT stub alignment fixes
Asking for ppc32 plt call stubs to be aligned at 32 byte boundaries
didn't quite work. For ld.bfd they were spaced 32 bytes apart, but
only started on a 16 byte boundary. ld.gold also didn't get it right.
Finding that bug made me check over the ppc64 plt stub alignment,
where I found that negative values for alignment (meaning align to
minimize boundary crossing) were not accepted. Since no one has
complained about that, I guess I could have removed the feature from
ld.bfd documentation, but I've opted instead to correct the code.
I've also added an optional alignment paramenter for ppc32
--plt-align, for some consistency with gold and ppc64 ld.bfd.
bfd/
* elf32-ppc.c (ppc_elf_create_glink): Correct alignment of .glink.
* elf64-ppc.c (ppc64_elf_size_stubs): Handle negative plt_stub_align.
(ppc64_elf_build_stubs): Likewise.
gold/
* powerpc.cc (param_plt_align): New function supplying default
--plt-align values. Use it..
(Stub_table::plt_call_align): ..here, and..
(Output_data_glink::global_entry_align): ..here.
(Stub_table::stub_align): Correct 32-bit minimum alignment.
ld/
* emultempl/ppc32elf.em: Support optional --plt-align arg.
* emultempl/ppc64elf.em: Support negative --plt-align arg.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Call cooked_read in ppu2spu_prev_register
@ 2018-01-18 12:35 sergiodj+buildbot
2018-01-19 12:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-18 12:35 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d679c21a43852305c5eeae957854f6e13d6f884c ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: d679c21a43852305c5eeae957854f6e13d6f884c
Call cooked_read in ppu2spu_prev_register
The code in ppu2spu_prev_register is in fact regcache_cooked_read,
because spu doesn't have gdbarch method pseudo_register_read_value.
gdb:
2018-01-18 Yao Qi <yao.qi@linaro.org>
* ppc-linux-tdep.c (ppu2spu_prev_register): Call cooked_read.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] S390: Use soft float in s390-tdbregs test case
@ 2018-01-18 18:56 sergiodj+buildbot
2018-01-19 16:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-18 18:56 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 25d4fd80936744adfa49f133524e3f342604a1cb ***
Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: 25d4fd80936744adfa49f133524e3f342604a1cb
S390: Use soft float in s390-tdbregs test case
The GDB test case s390-tdbregs.exp verifies GDB's handling of the
"transaction diagnostic block". For simplicity, the test case uses the
"transaction begin" (TBEGIN) instruction with the "allow floating-point
operation" flag set to zero. But some GCC versions may indeed emit
floating point or vector instructions for this test case. If this happens
in the transaction, it aborts, and an endless loop results.
This change tells the compiler to produce a soft-float binary, so no
floating-point or vector registers are touched.
gdb/testsuite/ChangeLog:
* gdb.arch/s390-tdbregs.exp: Add the compile option -msoft-float.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Make tests expect [ \t]+ pattern instead of \t for "info reg" command
@ 2018-01-19 6:21 sergiodj+buildbot
2018-01-19 20:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-19 6:21 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT adf8243ba9220966bbb8f67460b2d323e00cbfdb ***
Author: Ruslan Kabatsayev <b7.10110111@gmail.com>
Branch: master
Commit: adf8243ba9220966bbb8f67460b2d323e00cbfdb
Make tests expect [ \t]+ pattern instead of \t for "info reg" command
This will allow to format output of "info reg" command as we wish,
without breaking the tests. In particular, it'll let us correctly align
raw and natural values of the registers using spaces instead of current
badly-working approach with tabs.
This change is forwards- and backwards-compatible, so that the amended
tests will work in the same way before and after reformatting patches
(unless the tests check formatting, of course, but I've not come across
any such tests).
Some tests already used this expected pattern, so they didn't
even have to be modified. Others are changed by this patch.
I've checked this on a i386 system, with no noticeable differences in
test results, so at least on i386 nothing seems to be broken by this.
gdb/testsuite/ChangeLog:
* gdb.arch/powerpc-d128-regs.exp: Replace expected "\[\t\]*" from
"info reg" with "\[ \t\]*".
* gdb.arch/altivec-regs.exp: Replace expected "\t" from "info reg" with
"\[ \t\]+".
* gdb.arch/s390-multiarch.exp: Ditto.
* gdb.base/pc-fp.exp: Ditto.
* gdb.reverse/i386-precsave.exp: Ditto.
* gdb.reverse/i386-reverse.exp: Ditto.
* gdb.reverse/i387-env-reverse.exp: Ditto.
* gdb.reverse/i387-stack-reverse.exp: Ditto.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Find arm-linux-gnueabi(hf)?-gcc in compile
@ 2018-01-19 9:33 sergiodj+buildbot
2018-01-19 22:27 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-19 9:33 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT dea445b940545f9564972c5410ac8792b72cc9c3 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: dea445b940545f9564972c5410ac8792b72cc9c3
Find arm-linux-gnueabi(hf)?-gcc in compile
GCC for arm-linux has different names on different distros. It is
arm-linux-gnu-gcc on fedora. Debian/Ubuntu has arm-linux-gnueabihf-gcc
and arm-linux-gnueabi-gcc. So when I run gdb.compile/ tests on arm-linux,
I get,
(gdb) compile code -- ;
Could not find a compiler matching "^arm(-[^-]*)?-linux(-gnu)?-gcc$"
This patch extend the regexp to match both arm-linux-gnu-gcc and
arm-linux-gnueabihf-gcc.
gdb:
2018-01-19 Yao Qi <yao.qi@linaro.org>
* osabi.c (gdb_osabi_names): Extend the regexp for
arm-linux-gnueabihf and arm-linux-gnueabi.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Don't pass -m32 to libcc1 on arm-linux
@ 2018-01-19 10:00 sergiodj+buildbot
2018-01-20 0:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-19 10:00 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 88af8ea80b9732f951e61a4ed8868e722f337c8e ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 88af8ea80b9732f951e61a4ed8868e722f337c8e
Don't pass -m32 to libcc1 on arm-linux
When I run gdb.compile/ tests on arm-linux, I get the following fails,
(gdb) compile code -- ;^M
arm-none-linux-gnueabihf-gcc: error: unrecognized command line option '-m32'; did you mean '-mbe32'?^M
Compilation failed.^M
(gdb) compile code (void) param^M
arm-none-linux-gnueabihf-gcc: error: unrecognized command line option '-m32'; did you mean '-mbe32'?^M
Compilation failed.^M
(gdb) FAIL: gdb.compile/compile-ops.exp: compile code (void) param
This patch fixes it by implementing gcc_target_options gdbarch method
for arm-linux to override option "-m32".
gdb:
2018-01-19 Yao Qi <yao.qi@linaro.org>
* arm-linux-tdep.c (arm_linux_gcc_target_options): New function.
(arm_linux_init_abi): Install it.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] S390: Improve comments for s390-tdbregs test case
@ 2018-01-19 13:35 sergiodj+buildbot
2018-01-20 5:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-19 13:35 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d6ad07fdef94777bb512f072361706bcc743d51c ***
Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: d6ad07fdef94777bb512f072361706bcc743d51c
S390: Improve comments for s390-tdbregs test case
This adds more explanation as to why the test case must be compiled with
the -msoft-float option. It also documents the my_tbegin and my_tend
functions.
gdb/testsuite/ChangeLog:
* gdb.arch/s390-tdbregs.c (my_tbegin): Add comment documenting the
function.
(my_tend): Likewise.
* gdb.arch/s390-tdbregs.exp: Enhance comment; explain the
rationale of avoiding FP- and vector instructions.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Pass inferior down to target_detach and to_detach
@ 2018-01-19 17:34 sergiodj+buildbot
2018-01-20 10:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-19 17:34 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 6e1e1966bac965c5a26b5e5cae69cb0ed21be4cc ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 6e1e1966bac965c5a26b5e5cae69cb0ed21be4cc
Pass inferior down to target_detach and to_detach
The to_detach target_ops method implementations are currently expected
to work on current_inferior/inferior_ptid. In order to make things more
explicit, and remove some "shadow" parameter passing through globals,
this patch adds an "inferior" parameter to to_detach. Implementations
will be expected to use this instead of relying on the global. However,
to keep things simple, this patch only does the minimum that is
necessary to add the parameter. The following patch gives an example of
how one such implementation would be adapted. If the approach is deemed
good, we can then look into adapting more implementations. Until then,
they'll continue to work as they do currently.
gdb/ChangeLog:
* target.h (struct target_ops) <to_detach>: Add inferior
parameter.
(target_detach): Likewise.
* target.c (dispose_inferior): Pass inferior down.
(target_detach): Pass inferior down. Assert that it is equal to
the current inferior.
* aix-thread.c (aix_thread_detach): Pass inferior down.
* corefile.c (core_file_command): Pass current_inferior() down.
* corelow.c (core_detach): Add inferior parameter.
* darwin-nat.c (darwin_detach): Likewise.
* gnu-nat.c (gnu_detach): Likewise.
* inf-ptrace.c (inf_ptrace_detach): Likewise.
* infcmd.c (detach_command): Pass current_inferior() down to
target_detach.
* infrun.c (follow_fork_inferior): Pass parent_inf to
target_detach.
(handle_vfork_child_exec_or_exit): Pass inf->vfork_parent to
target_detach.
* linux-nat.c (linux_nat_detach): Add inferior parameter.
* linux-thread-db.c (thread_db_detach): Likewise.
* nto-procfs.c (procfs_detach): Likewise.
* procfs.c (procfs_detach): Likewise.
* record.c (record_detach): Likewise.
* record.h (struct inferior): Forward-declare.
(record_detach): Add inferior parameter.
* remote-sim.c (gdbsim_detach): Likewise.
* remote.c (remote_detach_1): Likewise.
(remote_detach): Likewise.
(extended_remote_detach): Likewise.
* sol-thread.c (sol_thread_detach): Likewise.
* target-debug.h (target_debug_print_inferior_p): New macro.
* target-delegates.c: Re-generate.
* top.c (kill_or_detach): Pass inferior down to target_detach.
* windows-nat.c (windows_detach): Add inferior parameter.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Make linux_nat_detach/thread_db_detach use the inferior parameter
@ 2018-01-19 17:48 sergiodj+buildbot
2018-01-20 12:41 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-19 17:48 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT bc09b0c14fb713a9aec25e09b78499f3bc2441b5 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: bc09b0c14fb713a9aec25e09b78499f3bc2441b5
Make linux_nat_detach/thread_db_detach use the inferior parameter
This patch makes these two functions actually use the inferior parameter
added by the previous patch, instead of reading inferior_ptid. I chose
these two, because they are the one actually used when I detach on my
GNU/Linux system, so they were easy to test.
I took the opportunity to pass the inferior being detached to
inf_ptrace_detach_success, so it could use it too. From there, it made
sense to add an overload of detach_inferior that takes the inferior
directly rather than the pid, to avoid having to pass inf->pid only for
the callee to look up the inferior structure by pid.
gdb/ChangeLog:
* inf-ptrace.c (inf_ptrace_detach): Adjust call to
inf_ptrace_detach_success.
(inf_ptrace_detach_success): Add inferior parameter, use it
instead of inferior_ptid, pass it to detach_inferior.
* inf-ptrace.h (inf_ptrace_detach_success): Add inferior
parameter.
* inferior.c (detach_inferior): Add overload that takes an
inferior object.
* inferior.h (detach_inferior): Likewise.
* linux-nat.c (linux_nat_detach): Use the inf parameter, don't
use inferior_ptid, adjust call to inf_ptrace_detach_success.
* linux-thread-db.c (thread_db_detach): Use inf parameter.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb: Fix ia64 defining TRAP_HWBKPT before including gdb_wait.h
@ 2018-01-19 19:04 sergiodj+buildbot
2018-01-20 15:23 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-19 19:04 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 5a6c3296a7a90694ad4042f6256f3da6d4fa4ee8 ***
Author: James Clarke <jrtc27@jrtc27.com>
Branch: master
Commit: 5a6c3296a7a90694ad4042f6256f3da6d4fa4ee8
gdb: Fix ia64 defining TRAP_HWBKPT before including gdb_wait.h
On ia64, gdb_wait.h eventually includes siginfo-consts-arch.h, which
contains an enum with TRAP_HWBKPT, along with a #define. Thus we cannot
define TRAP_HWBKPT to 4 beforehand, and so gdb_wait.h must be included
earlier; include it from linux-ptrace.h so it can never come afterwards.
gdb/ChangeLog:
* nat/linux-ptrace.c: Remove unnecessary reinclusion of
gdb_ptrace.h, and move including gdb_wait.h ...
* nat/linux-ptrace.h: ... to here.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb: Add missing #ifdef USE_THREAD_DB to gdbserver
@ 2018-01-19 19:06 sergiodj+buildbot
2018-01-20 17:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-19 19:06 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a0aad53764f45a634462288befe4c2eaecbf302d ***
Author: James Clarke <jrtc27@jrtc27.com>
Branch: master
Commit: a0aad53764f45a634462288befe4c2eaecbf302d
gdb: Add missing #ifdef USE_THREAD_DB to gdbserver
Otherwise, linking fails with:
[...]/linux-low.c:664: undefined reference to `thread_db_notice_clone(thread_info*, ptid_t)'
gdb/gdbserver/ChangeLog:
* linux-low.c (handle_extended_wait): Surround call to
thread_db_notice_clone with #ifdef USE_THREAD_DB.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] S390: Fix infcalls in s390-vregs test case
@ 2018-01-19 19:19 sergiodj+buildbot
2018-01-20 20:07 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-19 19:19 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 634c1c3109a2ffdf43ef9dab839c88108d9980f3 ***
Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: 634c1c3109a2ffdf43ef9dab839c88108d9980f3
S390: Fix infcalls in s390-vregs test case
GDB used to assume that functions without debug info return int. It
accepted an expression containing such a function call and silently
interpreted the function's return value as int. But nowadays GDB yields
an error message instead, see
https://sourceware.org/ml/gdb-patches/2017-07/msg00139.html
This affects the s390-vregs test case, because it contains calls to
setrlimit64 and chdir. When no glibc debug info is installed, these lead
to unnecessary FAILs. Fix this by adding appropriate casts to the
inferior function calls.
gdb/testsuite/ChangeLog:
* gdb.arch/s390-vregs.exp: Explicitly cast the return values of
setrlimit and chdir to int.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix qualified name lookup for Rust
@ 2018-01-19 22:47 sergiodj+buildbot
2018-01-20 21:57 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-19 22:47 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT fcfcc376969c4d7a6d20827c47b584db389a32b9 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: fcfcc376969c4d7a6d20827c47b584db389a32b9
Fix qualified name lookup for Rust
In https://github.com/rust-lang/rust/pull/46457, "m4b" pointed out
that the Rust support in gdb doesn't properly handle the lookup of
qualified names.
In particular, as shown in the test case in this patch, something like
"::NAME" should be found in the global scope, but is not.
This turns out to happen because rust_lookup_symbol_nonlocal does not
search the global scope unless the name in question is unqualified.
However, lookup_symbol_aux does not search the global scope, and
appears to search the static scope only as a fallback (I wonder if
this is needed?).
This patch fixes the problem by changing rust_lookup_symbol_nonlocal
to search the static and global blocks in more cases.
Regression tested against various versions of the rust compiler on
Fedora 26 x86-64. (Note that there are unrelated failures with newer
versions of rustc; I will be addressing those separately.)
2018-01-19 Tom Tromey <tom@tromey.com>
* rust-lang.c (rust_lookup_symbol_nonlocal): Look up qualified
symbols in the static and global blocks.
2018-01-19 Tom Tromey <tom@tromey.com>
* gdb.rust/modules.rs (TWENTY_THREE): New global.
* gdb.rust/modules.exp: Add ::-qualified lookup test.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: Check the versioned __tls_get_addr symbol
@ 2018-01-20 22:46 sergiodj+buildbot
2018-01-21 0:29 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-20 22:46 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 8a1b824af786989f879ab1421a4279f60bba141a ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 8a1b824af786989f879ab1421a4279f60bba141a
x86: Check the versioned __tls_get_addr symbol
We need to check the versioned __tls_get_addr symbol when looking up
"__tls_get_addr".
bfd/
PR ld/22721
* elfxx-x86.c (_bfd_x86_elf_link_check_relocs): Check the
versioned __tls_get_addr symbol.
ld/
PR ld/22721
* testsuite/ld-plugin/lto.exp: Run PR ld/22721 tests.
* testsuite/ld-plugin/pr22721.t: New file.
* testsuite/ld-plugin/pr22721a.s: Likewise.
* testsuite/ld-plugin/pr22721b.c: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb: Add test for some error cases of @entry usage
@ 2018-01-21 15:22 sergiodj+buildbot
2018-01-21 16:28 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-21 15:22 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b1b189e04cb5ea5da1cbb07bd6cceccd4d2ac969 ***
Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: b1b189e04cb5ea5da1cbb07bd6cceccd4d2ac969
gdb: Add test for some error cases of @entry usage
Adds a test that using @entry for a non-parameter, or for an unknown
symbol, both give the expected error. This error message was
previously untested.
gdb/testsuite/ChangeLog:
* gdb.arch/amd64-entry-value.exp: Test using @entry on a
non-parameter, and on an unknown symbol.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb: Remove duplicate declaration of global innermost_block
@ 2018-01-21 16:05 sergiodj+buildbot
2018-01-21 18:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-21 16:05 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 396af9a1527b396c251e70b5c79b5fc83fd1d7ff ***
Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 396af9a1527b396c251e70b5c79b5fc83fd1d7ff
gdb: Remove duplicate declaration of global innermost_block
The global 'innermost_block' is declared in two header files. Remove
one of the declarations, and add an include of the other header into
the one source file that could no longer see a declaration of
'innermost_block'.
gdb/ChangeLog:
* expression.h (innermost_block): Remove declaration.
* varobj.c: Add 'parser-defs.h' include.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb: Remove out of date comment
@ 2018-01-21 16:42 sergiodj+buildbot
2018-01-21 23:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-21 16:42 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 03d0bf7b78b142a5e03dfa1c80100893753d0022 ***
Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 03d0bf7b78b142a5e03dfa1c80100893753d0022
gdb: Remove out of date comment
Comment clean up.
gdb/ChangeLog:
* varobj.c (varobj_create): Remove out of date comment.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb: New API for tracking innermost block
@ 2018-01-21 16:50 sergiodj+buildbot
2018-01-21 19:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-21 16:50 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT aee1fcdf979d65c7623533ddd6d871767be9de13 ***
Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: aee1fcdf979d65c7623533ddd6d871767be9de13
gdb: New API for tracking innermost block
This commit is preparation for a later change, at this point there
should be no user visible change.
We currently maintain a global innermost_block which tracks the most
inner block encountered when parsing an expression.
This commit wraps the innermost_block into a new class, and switches all
direct accesses to the variable to use the class API.
gdb/ChangeLog:
* ada-exp.y (write_var_from_sym): Switch to innermost_block API.
* ada-lang.c (resolve_subexp): Likewise.
* breakpoint.c (set_breakpoint_condition) Likewise.
(watch_command_1) Likewise.
* c-exp.y (variable): Likewise.
* d-exp.y (PrimaryExpression): Likewise.
* f-exp.y (variable): Likewise.
* go-exp.y (variable): Likewise.
* m2-exp.y (variable): Likewise.
* objfiles.c (objfile::~objfile): Likewise.
* p-exp.y (variable): Likewise.
* parse.c (innermost_block): Change type.
* parser-defs.h (class innermost_block_tracker): New.
(innermost_block): Change to innermost_block_tracker.
* printcmd.c (display_command): Switch to innermost_block API.
(do_one_display): Likewise.
* rust-exp.y (do_one_display): Likewise.
* symfile.c (clear_symtab_users): Likewise.
* varobj.c (varobj_create): Switch to innermost_block API, replace
use of innermost_block with block stored on varobj object.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb: PR mi/20395: Fix -var-update for registers in frames 1 and up
@ 2018-01-21 17:01 sergiodj+buildbot
2018-01-21 21:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-21 17:01 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ae45162705fb76ee534336474a67b11373209c62 ***
Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: ae45162705fb76ee534336474a67b11373209c62
gdb: PR mi/20395: Fix -var-update for registers in frames 1 and up
This patch fixes a problem with using the MI -var-update command
to access the values of registers in frames other than the current
frame. The patch includes a test that demonstrates the problem:
* run so there are several frames on the stack
* create a fixed varobj for $pc in each frame, #'s 1 and above
* step one instruction, to modify the value of $pc
* call -var-update for each of the previously created varobjs
to verify that they are not reported as having changed.
Without the patch, the -var-update command reported that $pc for all
frames 1 and above had changed to the value of $pc in frame 0.
A varobj is created as either fixed, the expression is evaluated within
the context of a specific frame, or floating, the expression is
evaluated within the current frame, whatever that may be.
When a varobj is created by -var-create we set two fields of the varobj
to track the context in which the varobj was created, these two fields
are varobj->root->frame and var->root->valid_block.
If a varobj is of type fixed, then, when we subsequently try to
reevaluate the expression associated with the varobj we must determine
if the original frame (and block) is still available, if it is not then
the varobj can no longer be evaluated.
The problem is that for register expressions varobj->root->valid_block
is not set correctly. This block tracking is done using the global
'innermost_block' which is set in the various parser files (for example
c-exp.y). However, this is not set for register expressions.
The fix then seems like it should be to just update the innermost block
when parsing register expressions, however, that solution causes several
test regressions.
The problem is that in some cases we rely on the expression parsing
code not updating the innermost block for registers, one example is
when we parse the expression for a 'display' command. The display
commands treats registers like floating varobjs, but symbols are
treated like fixed varobjs. So 'display $reg_name' will always show
the value of '$reg_name' even as the user moves from frame to frame,
while 'display my_variable' will only show 'my_variable' while it is
in the current frame and/or block, when the user moves to a new frame
and/or block (even one with a different 'my_variable' in) then the
display of 'my_variable' stops. For the case of 'display', without
the option to force fixed or floating expressions, the current
behaviour is probably the best choice. For the varobj system though,
we can choose between floating and fixed, and we should try to make
this work for registers.
There's only one existing test case that needs to be updated, in that
test a fixed varobj is created using a register, the MI output now
include the thread-id in which the varobj should be evaluated, which I
believe is correct behaviour. I also added a new floating test case
into the same test script, however, right now this also includes the
thread-id in the expected output, which I believe is an existing gdb
bug, which I plan to fix next.
Tested on x86_64 Linux native and native-gdbserver, no regressions.
gdb/ChangeLog:
PR mi/20395
* ada-exp.y (write_var_from_sym): Pass extra parameter when
updating innermost block.
* parse.c (innermost_block_tracker::update): Take extra type
parameter, and check types match before updating innermost block.
(write_dollar_variable): Update innermost block for registers.
* parser-defs.h (enum innermost_block_tracker_type): New enum.
(innermost_block_tracker::innermost_block_tracker): Initialise
m_types member.
(innermost_block_tracker::reset): Take type parameter.
(innermost_block_tracker::update): Take type parameter, and pass
type through as needed.
(innermost_block_tracker::m_types): New member.
* varobj.c (varobj_create): Pass type when reseting innermost
block.
gdb/testsuite/ChangeLog:
* gdb.mi/basics.c: Add new global.
* gdb.mi/mi-frame-regs.exp: New file.
* gdb.mi/mi-var-create-rtti.exp: Update expected results, add new
case.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb: Don't store a thread-id for floating varobj
@ 2018-01-21 19:13 sergiodj+buildbot
2018-01-22 2:25 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-21 19:13 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e707fc445e68ccfa136a52cd4989b0cb778d1ca7 ***
Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: e707fc445e68ccfa136a52cd4989b0cb778d1ca7
gdb: Don't store a thread-id for floating varobj
When creating a varobj with -var-create a user can create either fixed
varobj, or floating varobj.
A fixed varobj will always be evaluated within the thread/frame/block in
which the varobj was created, if that thread/frame/block is no longer
available then the varobj is considered out of scope.
A floating varobj will always be evaluated within the current
thread/frame/block.
Despite never using them GDB was storing the thread/frame/block into a
floating varobj, and the thread-id would then be displayed when GDB
reported on the state of the varobj, this could confuse a user into
thinking that the thread-id was relevant.
This commit prevents GDB storing the thread/frame/block onto floating
varobj, and updates the few tests where this impacts the results.
gdb/ChangeLog:
* varobj.c (varobj_create): Don't set valid_block when creating a
floating varobj.
gdb/testsuite/ChangeLog:
* gdb.python/py-mi.exp: Don't expect a thread-id for floating
varobj.
* gdb.mi/mi-var-create-rtti.exp: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] wrong line number in breakpoint location
@ 2018-01-22 4:32 sergiodj+buildbot
2018-01-22 5:54 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-22 4:32 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a9e408182d2faaed5c2457b68ea3276c719a590f ***
Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: a9e408182d2faaed5c2457b68ea3276c719a590f
wrong line number in breakpoint location
Consider the following situation, where we have one file containing...
$ cat -n body.inc
1 i = i + 1;
... we include that file from some code, like so:
$ cat -n cat -n small.c
[...]
17 int
18 next (int i)
19 {
20 #include "body.inc"
21 return i;
22 }
When trying to insert a breakpoint on line 18, for instance:
(gdb) b small.c:18
Breakpoint 1 at 0x40049f: file body.inc, line 18.
^^
||
Here, the issue is that GDB reports the breakpoint to be in file
body.inc, which is true, but with the line number that corresponding
to the user-requested location, which is not correct.
Although the simple reproducer may look slightly artificial,
the above is simply one way to reproduce the same issue observed
when trying to insert a breakpoint on a function provided in
a .h files and then subsequently inlined in a C file.
What happens is the following:
1. We resolve the small.c:18 linespec into a symtab_and_line which
has "small.c" and 18 as the symtab and line number.
2. Next, we call skip_prologue_sal, which calculates the PC
past the prologue, and updates the symtab_and_line: PC,
but also symtab (now body.inc) and the new line (now 1).
3. However, right after that, we do:
/* Make sure the line matches the request, not what was
found. */
intermediate_results.sals[i].line = val.line;
We should either restore both symtab and line, or leave the actual
line to match the actual symtab. This patch chose the latter.
This introduces a few changes in a few tests, which required some
updates, but looking at those change, I believe them to be expected.
gdb/ChangeLog:
* linespec.c (create_sals_line_offset): Remove code that preserved
the symtab_and_line's line number.
gdb/testsuite/ChangeLog:
* gdb.base/break-include.c, gdb.base/break-include.inc,
gdb.base/break-include.exp: New files.
* gdb.base/ending-run.exp: Minor adaptations due to the breakpoint's
line number now being the actual line number where the breakpoint
was inserted.
* gdb.mi/mi-break.exp: Likewise.
* gdb.mi/mi-reverse.exp: Likewise.
* gdb.mi/mi-simplerun.exp: Ditto.
Tested on x86_64-linux.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Don't call gdbarch_pseudo_register_read_value in jit.c
@ 2018-01-22 11:23 sergiodj+buildbot
2018-01-22 13:06 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-22 11:23 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 3f5a868b2277a3678f7eeb8fdf88935913b5918b ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 3f5a868b2277a3678f7eeb8fdf88935913b5918b
Don't call gdbarch_pseudo_register_read_value in jit.c
gdbarch_pseudo_register_read_value is not implemented in every gdbarch, so
the predicate gdbarch_pseudo_register_read_value_p is needed before
calling it. However, there is no such guard in jit_frame_prev_register, I
am wondering how does jit work on the arch without having gdbarch method
pseudo_register_read_value.
The proper way to get register value is to call cooked_read, and then
create the value object from the buffer.
gdb:
2018-01-22 Yao Qi <yao.qi@linaro.org>
* jit.c (jit_frame_prev_register): Call regcache::cooked_read
instead of gdbarch_pseudo_register_read_value.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Replace regcache_raw_read with regcache->raw_read
@ 2018-01-22 11:47 sergiodj+buildbot
2018-01-22 17:54 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-22 11:47 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 03f50fc878f75fcdebf0e3273f201fb4b62b0bae ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 03f50fc878f75fcdebf0e3273f201fb4b62b0bae
Replace regcache_raw_read with regcache->raw_read
The patch later in this series will move regcache's raw_read and
cooked_read methods to a new class regcache_read, and regcache is
dervied from it. Also pass regcache_read instead of regcache to gdbarch
methods pseudo_register_read and pseudo_register_read_value. In order
to prepare for this change, this patch changes regcache_raw_read to
regcache->raw_read. On the other hand, since we are in C++, I prefer
using class method (regcache->raw_read).
gdb:
2018-01-22 Yao Qi <yao.qi@linaro.org>
* aarch64-tdep.c (aarch64_pseudo_read_value): Call regcache
method raw_read instead of regcache_raw_read.
* amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
* arm-tdep.c (arm_neon_quad_read): Likewise.
* avr-tdep.c (avr_pseudo_register_read): Likewise.
* bfin-tdep.c (bfin_pseudo_register_read): Likewise.
* frv-tdep.c (frv_pseudo_register_read): Likewise.
* h8300-tdep.c (h8300_pseudo_register_read): Likewise.
* i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
(i386_pseudo_register_read_into_value): Likewise.
* mep-tdep.c (mep_pseudo_cr32_read): Likewise.
* msp430-tdep.c (msp430_pseudo_register_read): Likewise.
* nds32-tdep.c (nds32_pseudo_register_read): Likewise.
* rl78-tdep.c (rl78_pseudo_register_read): Likewise.
* s390-linux-tdep.c (s390_pseudo_register_read): Likewise.
* sparc-tdep.c (sparc32_pseudo_register_read): Likewise.
* sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
* spu-tdep.c (spu_pseudo_register_read_spu): Likewise.
* xtensa-tdep.c (xtensa_pseudo_register_read): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove mt port
@ 2018-01-22 12:07 sergiodj+buildbot
2018-01-22 15:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-22 12:07 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT dc71152484248c0d8075618ec2146db4ea173b12 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: dc71152484248c0d8075618ec2146db4ea173b12
Remove mt port
This patch removes the MT port. The removal was annoucned
https://sourceware.org/ml/gdb-announce/2017/msg00006.html
I'll remove MT from the top-level configure later.
gdb:
2018-01-22 Yao Qi <yao.qi@linaro.org>
* Makefile.in (ALL_TARGET_OBS): Remove mt-tdep.o.
* configure.tgt: Remove target mt.
* mt-tdep.c: Remove.
* regcache.c (cooked_read_test): Remove the check for mt.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] regcache::cooked_write test
@ 2018-01-22 12:12 sergiodj+buildbot
2018-01-23 0:06 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-22 12:12 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ec7a5fcbfd90b2f67f1a0e3f9866b11c5968ae61 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: ec7a5fcbfd90b2f67f1a0e3f9866b11c5968ae61
regcache::cooked_write test
Since my following patches will change how each gdbarch read and write
pseudo registers, it's better to write a unit test to
regcache::cooked_write, to make sure my following changes don't cause
any regressions. See the comments on cooked_write_test.
gdb:
2018-01-22 Yao Qi <yao.qi@linaro.org>
* regcache.c (cooked_write_test): New function.
(_initialize_regcache): Register the test.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] s390: Allocate gdbarch & tdep at start of gdbarch_init
@ 2018-01-23 13:15 sergiodj+buildbot
2018-01-23 15:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 13:15 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 21f6f5ffc652e116e518fee29ebdc8fbfeeaa734 ***
Author: Philipp Rudo <prudo@linux.vnet.ibm.com>
Branch: master
Commit: 21f6f5ffc652e116e518fee29ebdc8fbfeeaa734
s390: Allocate gdbarch & tdep at start of gdbarch_init
Moving the allocation of gdbarch_tdep to the start of s390_gdbarch_init
allows us to use its fields for tracking the different features instead of
using separate variables. To make the code a little nicer move the actual
allocation and initialization to a separate function. Also move the
allocation of gdbarch to keep the two together.
gdb/ChangeLog:
* s390-linux-tdep (s390_abi_kind) <ABI_NONE>: New default field.
(gdbarch_tdep) <have_upper, have_vx>: New fields.
(s390_gdbarch_tdep_alloc): New function.
(s390_gdbarch_init): Allocate tdep at start and use its fields
instead of separate variables.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] s390: gdbarch_tdep add field tdesc
@ 2018-01-23 13:40 sergiodj+buildbot
2018-01-23 20:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 13:40 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 095085d8473689d86e00cd7d9a63680ca8faeda6 ***
Author: Philipp Rudo <prudo@linux.vnet.ibm.com>
Branch: master
Commit: 095085d8473689d86e00cd7d9a63680ca8faeda6
s390: gdbarch_tdep add field tdesc
Add a field for the target description to gdbarch_tdep. This will later be
needed to pass the 'correct' target description from osabi_init to
gdbarch_init. Unfortunately this cannot be done using gdbarch_info as it
is only passed by copy, not reference.
gdb/ChangeLog:
* s390-linux-tdep.c (gdbarch_tdep) <tdesc>: New field.
(s390_gdbarch_tdep_alloc): Adjust.
(s390_gdbarch_init): Adjust.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] s390: Hook s390 into OSABI mechanism
@ 2018-01-23 14:30 sergiodj+buildbot
2018-01-24 1:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 14:30 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 7042632bf7976d29889ba89fe4867654c5f38e2d ***
Author: Philipp Rudo <prudo@linux.vnet.ibm.com>
Branch: master
Commit: 7042632bf7976d29889ba89fe4867654c5f38e2d
s390: Hook s390 into OSABI mechanism
Do what the title says and distinguish between 31- and 64-bit systems.
The goal is to init the OSABI as late as possible in gdbarch_init so the
OSABI has the chance to overwrite the defaults.
There are two pitfalls to be aware of:
First, the dwarf2 unwinder must be appended before the OSABI is
initialized. Otherwise the OS could add a default unwinder which always
takes control before the dwarf unwinder even gets a chance.
Second, tdesc_use_registers has to be handled with extra care. It sets
several gdbarch hooks, especially gdbarch_register_name, which has to be
overwritten again after the call. Furthermore it deletes the tdesc_data
without checking. Therefore there must not be a call to
tdesc_data_cleanup afterwards or GDB will crash with a double free.
gdb/ChangeLog:
* s390-linux-tdep.c (osabi.h): New include.
(s390_linux_init_abi_31, s390_linux_init_abi_64)
(s390_linux_init_abi_any): New functions.
(s390_gdbarch_init, _initialize_s390_tdep): Adjust.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master
2018-01-23 14:30 [binutils-gdb] s390: Hook s390 into OSABI mechanism sergiodj+buildbot
@ 2018-01-24 1:03 ` sergiodj+buildbot
0 siblings, 0 replies; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-24 1:03 UTC (permalink / raw)
To: gdb-testers
Buildslave:
ubuntu-trusty-aarch32-1
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-native-gdbserver-m32/builds/2618>
Commit(s) tested:
7042632bf7976d29889ba89fe4867654c5f38e2d
Author(s) (in the same order as the commits):
Philipp Rudo <prudo@linux.vnet.ibm.com>
Subject:
s390: Hook s390 into OSABI mechanism
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-native-gdbserver-m32/70/7042632bf7976d29889ba89fe4867654c5f38e2d/>
*** Diff to previous build ***
============================
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=AIX: arch=s390:31-bit: endian=auto: set architecture s390:31-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=AIX: arch=s390:64-bit: endian=auto: set architecture s390:64-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=Cygwin: arch=s390:31-bit: endian=auto: set architecture s390:31-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=Cygwin: arch=s390:64-bit: endian=auto: set architecture s390:64-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=DICOS: arch=s390:31-bit: endian=auto: set architecture s390:31-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=DICOS: arch=s390:64-bit: endian=auto: set architecture s390:64-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=DJGPP: arch=s390:31-bit: endian=auto: set architecture s390:31-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=DJGPP: arch=s390:64-bit: endian=auto: set architecture s390:64-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=Darwin: arch=s390:31-bit: endian=auto: set architecture s390:31-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=Darwin: arch=s390:64-bit: endian=auto: set architecture s390:64-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=FreeBSD: arch=s390:31-bit: endian=auto: set architecture s390:31-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=FreeBSD: arch=s390:64-bit: endian=auto: set architecture s390:64-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=GNU/Hurd: arch=s390:31-bit: endian=auto: set architecture s390:31-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=GNU/Hurd: arch=s390:64-bit: endian=auto: set architecture s390:64-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=LynxOS178: arch=s390:31-bit: endian=auto: set architecture s390:31-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=LynxOS178: arch=s390:64-bit: endian=auto: set architecture s390:64-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=NetBSD: arch=s390:31-bit: endian=auto: set architecture s390:31-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=NetBSD: arch=s390:64-bit: endian=auto: set architecture s390:64-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=Newlib: arch=s390:31-bit: endian=auto: set architecture s390:31-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=Newlib: arch=s390:64-bit: endian=auto: set architecture s390:64-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=OpenBSD: arch=s390:31-bit: endian=auto: set architecture s390:31-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=OpenBSD: arch=s390:64-bit: endian=auto: set architecture s390:64-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=OpenVMS: arch=s390:31-bit: endian=auto: set architecture s390:31-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=OpenVMS: arch=s390:64-bit: endian=auto: set architecture s390:64-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=QNX-Neutrino: arch=s390:31-bit: endian=auto: set architecture s390:31-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=QNX-Neutrino: arch=s390:64-bit: endian=auto: set architecture s390:64-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=SDE: arch=s390:31-bit: endian=auto: set architecture s390:31-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=SDE: arch=s390:64-bit: endian=auto: set architecture s390:64-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=SVR4: arch=s390:31-bit: endian=auto: set architecture s390:31-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=SVR4: arch=s390:64-bit: endian=auto: set architecture s390:64-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=Solaris: arch=s390:31-bit: endian=auto: set architecture s390:31-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=Solaris: arch=s390:64-bit: endian=auto: set architecture s390:64-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=Symbian: arch=s390:31-bit: endian=auto: set architecture s390:31-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=Symbian: arch=s390:64-bit: endian=auto: set architecture s390:64-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=WindowsCE: arch=s390:31-bit: endian=auto: set architecture s390:31-bit
new FAIL: gdb.base/all-architectures-6.exp: tests: osabi=WindowsCE: arch=s390:64-bit: endian=auto: set architecture s390:64-bit
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
============================
*** Complete list of XFAILs for this builder ***
To obtain the list of XFAIL tests for this builder, go to:
<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch32-native-gdbserver-m32/xfails/master/xfail;hb=>
You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:
<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch32-native-gdbserver-m32/xfails/master/xfail.table;hb=>
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] s390: gdbarch_tdep add hook for syscall record
@ 2018-01-23 14:44 sergiodj+buildbot
2018-01-24 3:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 14:44 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9c0b896ee1d4edfe30c783b027ed5c081845a63d ***
Author: Philipp Rudo <prudo@linux.vnet.ibm.com>
Branch: master
Commit: 9c0b896ee1d4edfe30c783b027ed5c081845a63d
s390: gdbarch_tdep add hook for syscall record
Most parts of s390_process_record are common for the architecture. Only
the system call handling differs between the OSes. In order to be able to
move s390_process_record to a common code file add a hook to record
syscalls to gdbarch_tdep. So every OS can implement their own handling.
gdb/ChangeLog:
* s390-linux-tdep.c (gdbarch_tdep.s390_syscall_record): New hook.
(s390_process_record, s390_gdbarch_tdep_alloc)
(s390_linux_init_abi_any): Use/set new hook.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] s390: Move record-replay to s390-tdep.c
@ 2018-01-23 15:13 sergiodj+buildbot
2018-01-24 6:29 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 15:13 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ef8914a4d7d231fe3590f3e004316613e25f3617 ***
Author: Philipp Rudo <prudo@linux.vnet.ibm.com>
Branch: master
Commit: ef8914a4d7d231fe3590f3e004316613e25f3617
s390: Move record-replay to s390-tdep.c
Record-replay is independent of the OS. So it can be moved to the common
s390 code without problem.
gdb/ChangeLog:
* s390-linux-tdep.c (s390_record_address_mask)
(s390_record_calc_disp_common, s390_record_calc_disp)
(s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
(s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
(s390_process_record): Move to s390-tdep.c.
(s390_linux_init_abi_any): Adjust.
* s390-tdep.c (s390_record_address_mask)
(s390_record_calc_disp_common, s390_record_calc_disp)
(s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
(s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
(s390_process_record): Moved from s390-linux-tdep.c
(s390_gdbarch_init): Adjust.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] s390: Move tdesc validation to separate function
@ 2018-01-23 16:25 sergiodj+buildbot
2018-01-23 21:39 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 16:25 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 47c9317e71768ba9788c6dc055fb6932d0f0923a ***
Author: Philipp Rudo <prudo@linux.vnet.ibm.com>
Branch: master
Commit: 47c9317e71768ba9788c6dc055fb6932d0f0923a
s390: Move tdesc validation to separate function
Simplify s390_gdbarch_init by moving the target description validation to
a separate function.
gdb/ChangeLog:
* s390-linux-tdep.c (s390_tdesc_valid): New function.
(s390_validate_reg_range): New macro.
(s390_gdbarch_init): Adjust.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] s390: if -> gdb_assert for tdesc_has_registers check
@ 2018-01-23 17:23 sergiodj+buildbot
2018-01-23 23:29 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 17:23 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 650f5e137006fb7aea98e33d2ca9c6ac6712334c ***
Author: Philipp Rudo <prudo@linux.vnet.ibm.com>
Branch: master
Commit: 650f5e137006fb7aea98e33d2ca9c6ac6712334c
s390: if -> gdb_assert for tdesc_has_registers check
Before doing the tdesc validation there is a check whether the tdesc has
registers or not. This check is not only unnecessary but wrong.
First the check is done after a default tdesc is assigned if the original
tdesc has no registers. These default tdescs always have registers so the
check alway returns true.
Second if the default tdesc would not have registers the check only skips
the tdesc validation instead of returning an error. This would trigger a
gdb_assert later on in tdesc_use_registers.
gdb/ChangeLog:
* s390-linux-tdep.c (s390_gdbarch_init): Use gdb_assert for
tdesc_has_registers check
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Enable Intel WBNOINVD instruction.
@ 2018-01-23 17:26 sergiodj+buildbot
2018-01-24 11:21 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 17:26 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 3233d7d074e59b83f68a22071cff597f00d5ae81 ***
Author: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
Branch: master
Commit: 3233d7d074e59b83f68a22071cff597f00d5ae81
Enable Intel WBNOINVD instruction.
Intel has disclosed a set of new instructions for Icelake processor.
The spec is
https://software.intel.com/sites/default/files/managed/c5/15/architecture-instruction-set-extensions-programming-reference.pdf
This patch enables Intel WBNOINVD instruction.
gas/
* config/tc-i386.c (cpu_arch): Add .wbnoinvd.
* doc/c-i386.texi: Document .wbnoinvd.
* testsuite/gas/i386/i386.exp: Add WBNOINVD tests.
* testsuite/gas/i386/wbnoinvd-intel.d: New test.
* testsuite/gas/i386/wbnoinvd.d: Likewise.
* testsuite/gas/i386/wbnoinvd.s: Likewise.
* testsuite/gas/i386/x86-64-wbnoinvd-intel.d: Likewise.
* testsuite/gas/i386/x86-64-wbnoinvd.d: Likewise.
* testsuite/gas/i386/x86-64-wbnoinvd.s: Likewise.
opcodes/
* i386-dis.c (enum): Add PREFIX_0F09.
* i386-gen.c (cpu_flag_init): Add CPU_WBNOINVD_FLAGS.
(cpu_flags): Add CpuWBNOINVD.
* i386-opc.h (enum): Add CpuWBNOINVD.
(i386_cpu_flags): Add cpuwbnoinvd.
* i386-opc.tbl: Add WBNOINVD instruction.
* i386-init.h: Regenerate.
* i386-tbl.h: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Enable Intel PCONFIG instruction.
@ 2018-01-23 17:39 sergiodj+buildbot
2018-01-24 13:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 17:39 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT be3a8dca2d7241878302ca55f45129d532b6f746 ***
Author: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
Branch: master
Commit: be3a8dca2d7241878302ca55f45129d532b6f746
Enable Intel PCONFIG instruction.
Intel has disclosed a set of new instructions for Icelake processor.
The spec is
https://software.intel.com/sites/default/files/managed/c5/15/architecture-instruction-set-extensions-programming-reference.pdf
This patch enables Intel PCONFIG instruction.
gas/
* config/tc-i386.c (cpu_arch): Add .pconfig.
* doc/c-i386.texi: Document .pconfig.
* testsuite/gas/i386/i386.exp: Add PCONFIG tests.
* testsuite/gas/i386/pconfig-intel.d: New test.
* testsuite/gas/i386/pconfig.d: Likewise.
* testsuite/gas/i386/pconfig.s: Likewise.
* testsuite/gas/i386/x86-64-pconfig-intel.d: Likewise.
* testsuite/gas/i386/x86-64-pconfig.d: Likewise.
* testsuite/gas/i386/x86-64-pconfig.s: Likewise.
opcodes/
* i386-dis.c (enum): Add pconfig.
* i386-gen.c (cpu_flag_init): Add CPU_PCONFIG_FLAGS.
(cpu_flags): Add CpuPCONFIG.
* i386-opc.h (enum): Add CpuPCONFIG.
(i386_cpu_flags): Add cpupconfig.
* i386-opc.tbl: Add PCONFIG instruction.
* i386-init.h: Regenerate.
* i386-tbl.h: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] MIPS/BFD: Update a stale `mips_elf32_section_processing' reference
@ 2018-01-23 19:18 sergiodj+buildbot
2018-01-24 15:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 19:18 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 1c5e4ee9ab4c173aca017d488cc074ef66562a12 ***
Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 1c5e4ee9ab4c173aca017d488cc074ef66562a12
MIPS/BFD: Update a stale `mips_elf32_section_processing' reference
Update a stale reference to `mips_elf32_section_processing', following a
merge of the function into `_bfd_mips_elf_section_processing' made with
commit 103186c62b99 ("PATCH for MIPS 64-bit ABI suport"),
<https://sourceware.org/ml/binutils/1999-q3/msg00072.html>.
bfd/
* elfxx-mips.c (_bfd_mips_elf_final_link): Update a stale
`mips_elf32_section_processing' comment reference.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] [LD][AARCH64]Add group relocations to create PC-relative offset.
@ 2018-01-24 16:51 sergiodj+buildbot
2018-01-24 22:33 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-24 16:51 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 1daf502a16e052b55a28bd52b4fde185ccc3b27b ***
Author: Renlin Li <renlin.li@arm.com>
Branch: master
Commit: 1daf502a16e052b55a28bd52b4fde185ccc3b27b
[LD][AARCH64]Add group relocations to create PC-relative offset.
This is a patch to add linker support for group relocations to create a
16, 32, 48, or 64 bit PC-relative offset inline.
The following relocations are added along with the test cases:
BFD_RELOC_AARCH64_MOVW_PREL_G0, BFD_RELOC_AARCH64_MOVW_PREL_G0_NC,
BFD_RELOC_AARCH64_MOVW_PREL_G1, BFD_RELOC_AARCH64_MOVW_PREL_G1_NC,
BFD_RELOC_AARCH64_MOVW_PREL_G2, BFD_RELOC_AARCH64_MOVW_PREL_G2_NC,
BFD_RELOC_AARCH64_MOVW_PREL_G3.
bfd/
2018-01-24 Renlin Li <renlin.li@arm.com>
* elfnn-aarch64.c (elfNN_aarch64_final_link_relocate): Add support for
BFD_RELOC_AARCH64_MOVW_PREL_G0, BFD_RELOC_AARCH64_MOVW_PREL_G0_NC,
BFD_RELOC_AARCH64_MOVW_PREL_G1, BFD_RELOC_AARCH64_MOVW_PREL_G1_NC,
BFD_RELOC_AARCH64_MOVW_PREL_G2, BFD_RELOC_AARCH64_MOVW_PREL_G2_NC,
BFD_RELOC_AARCH64_MOVW_PREL_G3.
* elfxx-aarch64.c (_bfd_aarch64_elf_put_addend): Likewise.
(_bfd_aarch64_elf_resolve_relocation): Likewise.
ld/
2018-01-24 Renlin Li <renlin.li@arm.com>
* testsuite/ld-aarch64/aarch64-elf.exp: Run new testes.
* testsuite/ld-aarch64/emit-relocs-287.s: Fix test case.
* testsuite/ld-aarch64/emit-relocs-287.d: Fix expected output.
* testsuite/ld-aarch64/emit-relocs-287-overflow.s: New.
* testsuite/ld-aarch64/emit-relocs-287-overflow.d: New.
* testsuite/ld-aarch64/emit-relocs-288.d: New.
* testsuite/ld-aarch64/emit-relocs-288.s: New.
* testsuite/ld-aarch64/emit-relocs-289.d: New.
* testsuite/ld-aarch64/emit-relocs-289.s: New.
* testsuite/ld-aarch64/emit-relocs-289-overflow.s: New.
* testsuite/ld-aarch64/emit-relocs-289-overflow.d: New.
* testsuite/ld-aarch64/emit-relocs-290.d: New.
* testsuite/ld-aarch64/emit-relocs-290.s: New.
* testsuite/ld-aarch64/emit-relocs-291.d: New.
* testsuite/ld-aarch64/emit-relocs-291.s: New.
* testsuite/ld-aarch64/emit-relocs-291-overflow.s: New.
* testsuite/ld-aarch64/emit-relocs-291-overflow.d: New.
* testsuite/ld-aarch64/emit-relocs-292.d: New.
* testsuite/ld-aarch64/emit-relocs-292.s: New.
* testsuite/ld-aarch64/emit-relocs-293.d: New.
* testsuite/ld-aarch64/emit-relocs-293.s: New.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix GCC PR83906 - [8 Regression] Random FAIL: libstdc++-prettyprinters/80276.cc whatis p4
@ 2018-01-24 18:49 sergiodj+buildbot
2018-01-25 0:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-24 18:49 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 0f59d5fc1ce646348dfae3ca90b32f9228d1d514 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 0f59d5fc1ce646348dfae3ca90b32f9228d1d514
Fix GCC PR83906 - [8 Regression] Random FAIL: libstdc++-prettyprinters/80276.cc whatis p4
GCC PR83906 [1] is about a GCC/libstdc++ GDB/Python type printer
testcase failing randomly, as shown by running (in libstdc++'s
testsuite):
make check RUNTESTFLAGS=prettyprinters.exp=80276.cc
in a loop. Sometimes you get this:
FAIL: libstdc++-prettyprinters/80276.cc whatis p4
I.e., this:
type = std::unique_ptr<std::vector<std::unique_ptr<std::list<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >>[]>>[99]>
instead of this:
type = std::unique_ptr<std::vector<std::unique_ptr<std::list<std::string>[]>>[99]>
Jonathan Wakely tracked it on the printer side to this bit in
libstdc++'s type printer:
if self.type_obj == type_obj:
return strip_inline_namespaces(self.name)
This assumes the two types resolve to the same gdb.Type but some times
the comparison unexpectedly fails.
Running the testcase manually under Valgrind finds the problem in GDB:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~
==6118== Conditional jump or move depends on uninitialised value(s)
==6118== at 0x4C35CB0: bcmp (vg_replace_strmem.c:1100)
==6118== by 0x6F773A: check_types_equal(type*, type*, VEC_type_equality_entry_d**) (gdbtypes.c:3515)
==6118== by 0x6F7B00: check_types_worklist(VEC_type_equality_entry_d**, bcache*) (gdbtypes.c:3618)
==6118== by 0x6F7C03: types_deeply_equal(type*, type*) (gdbtypes.c:3655)
==6118== by 0x4D5B06: typy_richcompare(_object*, _object*, int) (py-type.c:1007)
==6118== by 0x63D7E6C: PyObject_RichCompare (object.c:961)
==6118== by 0x646EAEC: PyEval_EvalFrameEx (ceval.c:4960)
==6118== by 0x646DC08: PyEval_EvalFrameEx (ceval.c:4519)
==6118== by 0x646DC08: PyEval_EvalFrameEx (ceval.c:4519)
==6118== by 0x646DC08: PyEval_EvalFrameEx (ceval.c:4519)
==6118== by 0x646DC08: PyEval_EvalFrameEx (ceval.c:4519)
==6118== by 0x646DC08: PyEval_EvalFrameEx (ceval.c:4519)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~
That "bcmp" call is really a memcmp call in check_types_equal. The
problem is that gdb is memcmp'ing two objects that are equal in value:
(top-gdb) p *TYPE_RANGE_DATA (type1)
$1 = {low = {kind = PROP_CONST, data = {const_val = 0, baton = 0x0}}, high = {kind = PROP_CONST, data = {const_val = 15, baton = 0xf}}, flag_upper_bound_is_count = 0,
flag_bound_evaluated = 0}
(top-gdb) p *TYPE_RANGE_DATA (type2)
$2 = {low = {kind = PROP_CONST, data = {const_val = 0, baton = 0x0}}, high = {kind = PROP_CONST, data = {const_val = 15, baton = 0xf}}, flag_upper_bound_is_count = 0,
flag_bound_evaluated = 0}
but differ in padding. Notice the 4-byte hole:
(top-gdb) ptype /o range_bounds
/* offset | size */ type = struct range_bounds {
/* 0 | 16 */ struct dynamic_prop {
/* 0 | 4 */ dynamic_prop_kind kind;
/* XXX 4-byte hole */
/* 8 | 8 */ union dynamic_prop_data {
/* 8 */ LONGEST const_val;
/* 8 */ void *baton;
/* total size (bytes): 8 */
} data;
which is filled with garbage:
(top-gdb) x /40bx TYPE_RANGE_DATA (type1)
0x2fa7ea0: 0x01 0x00 0x00 0x00 0x43 0x01 0x00 0x00
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
0x2fa7ea8: 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
0x2fa7eb0: 0x01 0x00 0x00 0x00 0xfe 0x7f 0x00 0x00
0x2fa7eb8: 0x0f 0x00 0x00 0x00 0x00 0x00 0x00 0x00
0x2fa7ec0: 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
(top-gdb) x /40bx TYPE_RANGE_DATA (type2)
0x20379b0: 0x01 0x00 0x00 0x00 0xfe 0x7f 0x00 0x00
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
0x20379b8: 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
0x20379c0: 0x01 0x00 0x00 0x00 0xfe 0x7f 0x00 0x00
0x20379c8: 0x0f 0x00 0x00 0x00 0x00 0x00 0x00 0x00
0x20379d0: 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
(top-gdb) p memcmp (TYPE_RANGE_DATA (type1), TYPE_RANGE_DATA (type2), sizeof (*TYPE_RANGE_DATA (type1)))
$3 = -187
In some cases objects of type range_bounds are memset when allocated,
but then their dynamic_prop low/high fields are copied over from some
template dynamic_prop object that wasn't memset. E.g.,
create_static_range_type's low/high locals are left with garbage in
the padding, and then that padding is copied over to the range_bounds
object's low/high fields.
At first, I considered making sure to always memset range_bounds
objects, thinking that maybe type objects are being put in some bcache
instance somewhere. But then I hacked bcache/bcache_full to poison
non-pod types, and made dynamic_prop a non-pod, and GDB still
compiled.
So given that, it seems safest to not assume padding will always be
memset, and instead treat them as regular value types, implementing
(in)equality operators and using those instead of memcmp.
This fixes the random FAILs in GCC's testcase.
[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83906
gdb/ChangeLog:
2018-01-24 Pedro Alves <palves@redhat.com>
GCC PR libstdc++/83906
* gdbtypes.c (operator==(const dynamic_prop &,
const dynamic_prop &)): New.
(operator==(const range_bounds &, const range_bounds &)): New.
(check_types_equal): Use them instead of memcmp.
* gdbtypes.h (operator==(const dynamic_prop &,
const dynamic_prop &)): Declare.
(operator!=(const dynamic_prop &, const dynamic_prop &)): Declare.
(operator==(const range_bounds &, const range_bounds &)): Declare.
(operator!=(const range_bounds &, const range_bounds &)): Declare.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix PR ld/22727 (TLS breakage in PIC/PIE mode on SPARC).
@ 2018-01-25 11:35 sergiodj+buildbot
2018-01-25 12:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-25 11:35 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT bb363086e7743506d78bc6b1e56face0fb1fc93f ***
Author: Eric Botcazou <ebotcazou@gcc.gnu.org>
Branch: master
Commit: bb363086e7743506d78bc6b1e56face0fb1fc93f
Fix PR ld/22727 (TLS breakage in PIC/PIE mode on SPARC).
There are actually 2 different bugs:
1. TLS transition is broken in PIE mode.
2. TLS is broken in PIC/PIE mode when the __tls_get_addr symbol
is versioned (as is the case on Linux and Solaris at least).
The 1st bug is fixed by reverting the problematic change for now
(note that the associated test doesn't pass on SPARC because of another
issue so there is no formal regression in the testsuite). The 2nd bug
is fixed by changing the call to _bfd_generic_link_add_one_symbol
on __tls_get_addr into a mere lookup in _bfd_sparc_elf_check_relocs.
bfd/
* elfxx-sparc.c (_bfd_sparc_elf_check_relocs) <R_SPARC_TLS_GD_CALL>:
Do a mere lookup of the __tls_get_addr symbol instead of adding it.
Revert
2017-10-19 H.J. Lu <hongjiu.lu@intel.com>
PR ld/22263
* elfxx-sparc.c (sparc_elf_tls_transition): Replace
bfd_link_pic with !bfd_link_executable, !bfd_link_pic with
bfd_link_executable for TLS check.
(_bfd_sparc_elf_check_relocs): Likewise.
(allocate_dynrelocs): Likewise.
(_bfd_sparc_elf_relocate_section): Likewise.
ld/
* testsuite/ld-sparc/sparc.exp (32-bit: Helper shared library):
Link with a version script.
(32-bit: TLS -fpie): New test.
(64-bit: Helper shared library): Link with a version script.
(64-bit: TLS -fpie): New test.
(64-bit: GOTDATA relocations): Pass -Av9 to the assembler.
* testsuite/ld-sparc/tlslib.ver: New file.
* testsuite/ld-sparc/tlspie32.dd: Likewise.
* testsuite/ld-sparc/tlspie32.s: Likewise.
* testsuite/ld-sparc/tlspie64.dd: Likewise.
* testsuite/ld-sparc/tlspie64.s: Likewise.
* testsuite/ld-sparc/tlssunbin32.dd: Adjust for versioned symbol.
* testsuite/ld-sparc/tlssunbin32.rd: Likewise.
* testsuite/ld-sparc/tlssunbin32.sd: Likewise.
* testsuite/ld-sparc/tlssunbin64.dd: Likewise.
* testsuite/ld-sparc/tlssunbin64.rd: Likewise.
* testsuite/ld-sparc/tlssunbin64.sd: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR22746, crash when running 32-bit objdump on corrupted file
@ 2018-01-25 11:50 sergiodj+buildbot
2018-01-25 14:38 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-25 11:50 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 38e64b0ecc7f4ee64a02514b8d532782ac057fa2 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 38e64b0ecc7f4ee64a02514b8d532782ac057fa2
PR22746, crash when running 32-bit objdump on corrupted file
Avoid unsigned int overflow by performing bfd_size_type multiplication.
PR 22746
* elfcode.h (elf_object_p): Avoid integer overflow.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PowerPC PLT stub matching
@ 2018-01-26 5:59 sergiodj+buildbot
2018-01-26 11:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-26 5:59 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 7433498b7f1a79bf98ba272fd461f0ff9f1daa02 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 7433498b7f1a79bf98ba272fd461f0ff9f1daa02
PowerPC PLT stub matching
This patch fixes a number of bugs in ppc32 plt stub matching code.
1) The 4-insn stubs for shared libs and PIEs weren't matched.
2) The executable stub miscalculated PLT entry address (by oring a
sign-extended quantity rather than adding).
3) Comments were not accurate.
In addition, the insn arrays are made const.
* ppc-linux-tdep.c (powerpc32_plt_stub): Make const.
(powerpc32_plt_stub_so_1): Rename from powerpc32_plt_stub_so.
Remove nop. Make const. Comment.
(powerpc32_plt_stub_so_2): New.
(POWERPC32_PLT_CHECK_LEN): Rename from POWERPC32_PLT_STUB_LEN.
Correct count. Update uses.
(ppc_skip_trampoline_code): Match powerpc32_plt_stub_so_2 too.
Move common code reading PLT entry word. Correct
powerpc32_plt_stub PLT address calculation.
* ppc64-tdep.c (ppc64_standard_linkage1): Make const.
(ppc64_standard_linkage2, ppc64_standard_linkage3): Likewise.
(ppc64_standard_linkage4, ppc64_standard_linkage5): Likewise.
(ppc64_standard_linkage6, ppc64_standard_linkage7): Likewise.
(ppc64_standard_linkage8): Likewise.
* rs6000-tdep.c (ppc_insns_match_pattern): Make pattern const.
Correct insns description.
* ppc-tdep.h (ppc_insns_match_pattern): Update prototype.
Reviewed-By: Yao Qi <qiyaoltc@gmail.com>
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Define __start/__stop symbols when there is only a dynamic def
@ 2018-01-26 6:02 sergiodj+buildbot
2018-01-26 8:25 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-26 6:02 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 32253bb7963ac7caa166ec41e336372f2ffc03d4 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 32253bb7963ac7caa166ec41e336372f2ffc03d4
Define __start/__stop symbols when there is only a dynamic def
This patch fixes a case where a user had a C-representable named
section in both the executable and shared libraries, and of course
wanted the size of the local section in the executable, not the
dynamic section. It does mean that __start and __stop symbols don't
behave exactly like PROVIDEd symbols, but I think that's a reasonable
difference particularly since this is the way they used to behave.
* elflink.c (bfd_elf_define_start_stop): Override symbols when
they are defined dynamically.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add myself as a write-after-approval GDB maintainer.
@ 2018-01-26 15:05 sergiodj+buildbot
2018-01-26 15:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-26 15:05 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 56ae9dc397bdf08c4e8f1ef0b64f4320bf88ba3e ***
Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: 56ae9dc397bdf08c4e8f1ef0b64f4320bf88ba3e
Add myself as a write-after-approval GDB maintainer.
gdb/
* MAINTAINERS (Write After Approval): Add Alan Hayward.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Updated Russian translation for the bfd sub-directory
@ 2018-01-27 14:46 sergiodj+buildbot
2018-01-27 15:42 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-27 14:46 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 7d73b4c8dfc8ae59dc1334e67c7ae2ea493dd121 ***
Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 7d73b4c8dfc8ae59dc1334e67c7ae2ea493dd121
Updated Russian translation for the bfd sub-directory
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Avoid compilation warning in libiberty/simple-object-xcoff.c
@ 2018-01-27 16:43 sergiodj+buildbot
2018-01-27 17:33 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-27 16:43 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT de54ee813f35cdeee51729c6d50b82935dc88634 ***
Author: Eli Zaretskii <eliz@gnu.org>
Branch: master
Commit: de54ee813f35cdeee51729c6d50b82935dc88634
Avoid compilation warning in libiberty/simple-object-xcoff.c
gdb/ChangeLog:
2018-01-27 Eli Zaretskii <eliz@gnu.org>
* simple-object-xcoff.c (simple_object_xcoff_find_sections): Avoid
compilation warning in 32-bit builds not supported by
AC_SYS_LARGEFILE.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove dwarf2_per_objfile_free and use after free of dwarf2_per_objfile
@ 2018-01-28 17:24 sergiodj+buildbot
2018-01-28 18:00 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-28 17:24 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT fc8e7e75c2be02237a7961688b06869814f36a18 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: fc8e7e75c2be02237a7961688b06869814f36a18
Remove dwarf2_per_objfile_free and use after free of dwarf2_per_objfile
I got some crashes while doing some work with dwarf2_per_objfile. It
turns out that dwarf2_per_objfile_free is using the dwarf2_per_objfile
objects after their destructor has ran.
The easiest way to reproduce this is to run the inferior twice (do
"start" twice). Currently, it goes unnoticed, but when I tried to
change all_comp_units and all_type_units to std::vectors, things started
crashing.
The dwarf2_per_objfile objects get destroyed here:
#0 dwarf2_per_objfile::~dwarf2_per_objfile (this=0x35afe70, __in_chrg=<optimized out>) at /home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:2422
#1 0x0000000000833282 in dwarf2_free_objfile (objfile=0x356cff0) at /home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:25363
#2 0x0000000000699255 in elf_symfile_finish (objfile=0x356cff0) at /home/emaisin/src/binutils-gdb/gdb/elfread.c:1309
#3 0x0000000000911ed3 in objfile::~objfile (this=0x356cff0, __in_chrg=<optimized out>) at /home/emaisin/src/binutils-gdb/gdb/objfiles.c:674
and just after that the dwarf2read per-objfile registry cleanup function
gets called:
#0 dwarf2_per_objfile_free (objfile=0x356cff0, d=0x35afe70) at /home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:25667
... registry boilerplate ...
#4 0x00000000009103ea in objfile_free_data (container=0x356cff0) at /home/emaisin/src/binutils-gdb/gdb/objfiles.c:61
#5 0x0000000000911ee2 in objfile::~objfile (this=0x356cff0, __in_chrg=<optimized out>) at /home/emaisin/src/binutils-gdb/gdb/objfiles.c:678
In dwarf2_per_objfile_free, we access fields of the dwarf2_per_objfile
object, which is invalid since its destructor has been executed.
This patch moves the content of dwarf2_per_objfile_free to the
destructor of dwarf2_per_objfile. The call to
register_objfile_data_with_cleanup in _initialize_dwarf2_read can be
changed to the simpler register_objfile_data.
gdb/ChangeLog:
* dwarf2read.c (free_dwo_files): Add forward-declaration.
(dwarf2_per_objfile::~dwarf2_per_objfile): Move content from
dwarf2_per_objfile_free here.
(dwarf2_per_objfile_free): Remove.
(_initialize_dwarf2_read): Don't register
dwarf2_per_objfile_free as a registry cleanup.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR22741, objcopy segfault on fuzzed COFF object
@ 2018-01-29 5:45 sergiodj+buildbot
2018-01-29 6:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-29 5:45 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT eb77f6a4621795367a39cdd30957903af9dbb815 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: eb77f6a4621795367a39cdd30957903af9dbb815
PR22741, objcopy segfault on fuzzed COFF object
PR 22741
* coffgen.c (coff_pointerize_aux): Ensure auxent tagndx is in
range before converting to a symbol table pointer.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Don't call "detach_inferior" on "remote_follow_fork"
@ 2018-01-29 18:21 sergiodj+buildbot
2018-01-29 19:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-29 18:21 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 69ab5edb4d601611ba7b4d05e56689d4b60ca3b1 ***
Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: 69ab5edb4d601611ba7b4d05e56689d4b60ca3b1
Don't call "detach_inferior" on "remote_follow_fork"
This patch fixes a regression that has been introduced by:
commit bc09b0c14fb713a9aec25e09b78499f3bc2441b5
Date: Fri Jan 19 11:48:11 2018 -0500
Make linux_nat_detach/thread_db_detach use the inferior parameter
It is possible to trigger this failure with gdb.base/foll-fork.exp (in
which case a bunch of ERROR's will be printed), but one can also use
the test below.
Consider the following example program:
#include <unistd.h>
int
main (int argc, char *argv[])
{
fork ();
return 0;
}
When running it under gdbserver:
# ./gdb/gdbserver/gdbserver --multi --once :2345
And debugging it under GDB, we see a segmentation fault:
# ./gdb/gdb -q -batch -ex 'set remote exec-file ./a.out' -ex 'tar extended-remote :2345' -ex r ./a.out
Starting program:
...
[Detaching after fork from child process 16102.]
Segmentation fault (core dumped)
The problem happens on inferior.c:detach_inferior:
void
detach_inferior (inferior *inf)
{
/* Save the pid, since exit_inferior_1 will reset it. */
int pid = inf->pid;
^^^^^^^^^
exit_inferior_1 (inf, 0);
if (print_inferior_events)
printf_unfiltered (_("[Inferior %d detached]\n"), pid);
}
When this code is called from remote.c:remote_follow_fork, the PID is
valid but there is no 'inferior' associated with it, which means that
'inf == NULL'.
The proper fix here is to not call "detach_inferior" when doing remote
follow-fork, because we don't have an inferior to detach on the host
side.
Before bc09b0c1, that call was already a nop (exit_inferior_1 bails
out early if you pass it a NULL inferior), except that it printed
"Inferior PID detached" when "set print inferior-events" is on. Since
native debugging doesn't call detach_inferior in this case, removing
the call from remote aligns remote debugging output with native
debugging output further.
This has been regtested using BuildBot and no regressions were found.
gdb/ChangeLog:
2018-01-29 Sergio Durigan Junior <sergiodj@redhat.com>
* remote.c (remote_follow_fork): Don't call "detach_inferior".
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR22758, FAIL: Run pr22393-2
@ 2018-01-30 8:44 sergiodj+buildbot
2018-01-30 10:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-30 8:44 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 76cb3a89a6615cf3418fa1efe8268bf6673a5c8a ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 76cb3a89a6615cf3418fa1efe8268bf6673a5c8a
PR22758, FAIL: Run pr22393-2
We can't map different disk pages into the same memory page; The last
page mapped will simply overwrite any previous pages. The
executable/non-executable new_segment test ignored this fact, leading
to a ld.so segfault on hppa when .dynamic is overwritten with zeros.
This patch moves existing tests for demand paging with lma on the same
memory page, to a new test performed before any case where we want a
new segment due to protection or loadable conflicts.
PR 22758
* elf.c (_bfd_elf_map_sections_to_segments): Don't start a new
segment when demand paged with lma on the same page. Test this
before load/non-load, executable/non-executable,
writable/non-writable tests and simplify. Delete bogus relro
condition in writable/non-writable test. Delete outdated
comment. Formatting.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] linux-nat: Eliminate custom target_terminal_{inferior, ours}, stop using set_sigint_trap
@ 2018-01-30 15:53 sergiodj+buildbot
2018-01-30 17:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-30 15:53 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9c3a5d9319648db16b30a91253ad02d41d242cef ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 9c3a5d9319648db16b30a91253ad02d41d242cef
linux-nat: Eliminate custom target_terminal_{inferior,ours}, stop using set_sigint_trap
This patch gets rid of linux-nat.c's custom
target_terminal_inferior/target_terminal_ours implementations.
The only remaining reason those overrides exist is to install
clear_sigint_trap in order to pass Ctrl-C/SIGINT to the inferior
process in case the inferior is not sharing GDB's terminal (and
target_wait was called without TARGET_WNOHANG).
However, I think that's better handled by QUIT / target_pass_ctrlc
nowadays. Going that route avoids the issue with set_sigint_trap only
looking at the current inferior to know whether to override SIGINT or
not, which doesn't really work correctly with multi-inferior in the
picture. Also centralizing on a single SIGINT handler as much as
possible seems better considering a future multi-target world.
Tested on x86-64 GNU/Linux.
gdb/ChangeLog:
2018-01-30 Pedro Alves <palves@redhat.com>
* linux-nat.c (wait_for_signal): New function.
(wait_lwp, linux_nat_wait_1): Use it instead of calling sigsuspend
directly.
(async_terminal_is_ours)
(linux_nat_terminal_inferior, linux_nat_terminal_ours): Delete.
(linux_nat_add_target): Don't override
to_terminal_inferior/to_terminal_ours.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Per-inferior target_terminal state, fix PR gdb/13211, more
@ 2018-01-30 16:06 sergiodj+buildbot
2018-01-30 18:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-30 16:06 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e671cd59d74cec9f53e110ce887128d1eeadb7f2 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: e671cd59d74cec9f53e110ce887128d1eeadb7f2
Per-inferior target_terminal state, fix PR gdb/13211, more
In my multi-target branch I ran into problems with GDB's terminal
handling that exist in master as well, with multi-inferior debugging.
This patch adds a testcase for said problems
(gdb.multi/multi-term-settings.exp), fixes the problems, fixes PR
gdb/13211 as well (and adds a testcase for that too,
gdb.base/interrupt-daemon.exp).
The basis of the problem I ran into is the following. Consider a
scenario where you have:
- inferior 1 - started with "attach", process is running on some
other terminal.
- inferior 2 - started with "run", process is sharing gdb's terminal.
In this scenario, when you stop/resume both inferiors, you want GDB to
save/restore the terminal settings of inferior 2, the one that is
sharing GDB's terminal. I.e., you want inferior 2 to "own" the
terminal (in target_terminal::is_ours/target_terminal::is_inferior
sense).
Unfortunately, that's not what you get currently. Because GDB doesn't
know whether an attached inferior is actually sharing GDB's terminal,
it tries to save/restore its settings anyway, ignoring errors. In
this case, this is pointless, because inferior 1 is running on a
different terminal, but GDB doesn't know better.
And then, because it is only possible to have the terminal settings of
a single inferior be in effect at a time, or make one inferior/pgrp be
the terminal's foreground pgrp (aka, only one inferior can "own" the
terminal, ignoring fork children here), if GDB happens to try to
restore the terminal settings of inferior 1 first, then GDB never
restores the terminal settings of inferior 2.
This patch fixes that and a few things more along the way:
- Moves enum target_terminal::terminal_state out of the
target_terminal class (it's currently private) and makes it a
scoped enum so that it can be easily used elsewhere.
- Replaces the inflow.c:terminal_is_ours boolean with a
target_terminal_state variable. This allows distinguishing is_ours
and is_ours_for_output states. This allows finally making
child_terminal_ours_1 do something with its "output_only"
parameter.
- Makes each inferior have its own copy of the
is_ours/is_ours_for_output/is_inferior state.
- Adds a way for GDB to tell whether the inferior is sharing GDB's
terminal. Works best on Linux and Solaris; the fallback works just
as well as currently.
- With that, we can remove the inf->attach_flag tests from
child_terminal_inferior/child_terminal_ours.
- Currently target_ops.to_ours is responsible for both saving the
current inferior's terminal state, and restoring gdb's state.
Because each inferior has its own terminal state (possibly handled
by different targets in a multi-target world, even), we need to
split the inferior-saving part from the gdb-restoring part. The
patch adds a new target_ops.to_save_inferior target method for
that.
- Adds a new target_terminal::save_inferior() function, so that
sequences like:
scoped_restore_terminal_state save_state;
target_terminal::ours_for_output ();
... restore back inferiors that were
target_terminal_state::is_inferior before back to is_inferior, and
leaves inferiors that were is_ours alone.
- Along the way, this adds a default implementation of
target_pass_ctrlc to inflow.c (for inf-child.c), that handles
passing the Ctrl-C to a process running on GDB's terminal or to
some other process otherwise.
- Similarly, adds a new target default implementation of
target_interrupt, for the "interrupt" command. The current
implementation of this hook in inf-ptrace.c kills the whole process
group, but that's incorrect/undesirable because we may not be
attached to all processes in the process group. And also, it's
incorrect because inferior_process_group() doesn't really return
the inferior's real process group id if the inferior is not a
process group leader... This is the cause of PR gdb/13211 [1],
which this patch fixes. While at it, that target method's "ptid"
parameter is eliminated, because it's not really used.
- A new test is included that exercises and fixes PR gdb/13211, and
also fixes a GDB issue reported on stackoverflow that I ran into
while working on this [2]. The problem is similar to PR gdb/13211,
except that it also triggers with Ctrl-C. When debugging a daemon
(i.e., a process that disconnects from the controlling terminal and
is not a process group leader, then Ctrl-C doesn't work, you just
can't interrupt the inferior at all, resulting in a hung debug
session. The problem is that since the inferior is no longer
associated with gdb's session / controlling terminal, then trying
to put the inferior in the foreground fails. And so Ctrl-C never
reaches the inferior directly. pass_signal is only used when the
inferior is attached, but that is not the case here. This is fixed
by the new child_pass_ctrlc. Without the fix, the new
interrupt-daemon.exp testcase fails with timeout waiting for a
SIGINT that never arrives.
[1] PR gdb/13211 - Async / Process group and interrupt not working
https://sourceware.org/bugzilla/show_bug.cgi?id=13211
[2] GDB not reacting Ctrl-C when after fork() and setsid()
https://stackoverflow.com/questions/46101292/gdb-not-reacting-ctrl-c-when-after-fork-and-setsid
Note this patch does _not_ fix:
- PR gdb/14559 - The 'interrupt' command does not work if sigwait is in use
https://sourceware.org/bugzilla/show_bug.cgi?id=14559
- PR gdb/9425 - When using "sigwait" GDB doesn't trap SIGINT. Ctrl+C terminates program when should break gdb.
https://sourceware.org/bugzilla/show_bug.cgi?id=9425
The only way to fix that that I know of (without changing the kernel)
is to make GDB put inferiors in a separate session (create a
pseudo-tty master/slave pair, make the inferior run with the slave as
its terminal, and have gdb pump output/input on the master end).
gdb/ChangeLog:
2018-01-30 Pedro Alves <palves@redhat.com>
PR gdb/13211
* config.in, configure: Regenerate.
* configure.ac: Check for getpgid.
* go32-nat.c (go32_pass_ctrlc): New.
(go32_target): Install it.
* inf-child.c (inf_child_target): Install
child_terminal_save_inferior, child_pass_ctrlc and
child_interrupt.
* inf-ptrace.c (inf_ptrace_interrupt): Delete.
(inf_ptrace_target): No longer install it.
* infcmd.c (interrupt_target_1): Adjust.
* inferior.h (child_terminal_save_inferior, child_pass_ctrlc)
(child_interrupt): Declare.
(inferior::terminal_state): New.
* inflow.c (struct terminal_info): Update comments.
(inferior_process_group): Delete.
(terminal_is_ours): Delete.
(gdb_tty_state): New.
(child_terminal_init): Adjust.
(is_gdb_terminal, sharing_input_terminal_1)
(sharing_input_terminal): New functions.
(child_terminal_inferior): Adjust. Use sharing_input_terminal.
Set the process's actual process group in the foreground if
possible. Handle is_ours_for_output/is_ours distinction. Don't
mark terminal as the inferior's if not sharing GDB's terminal.
Don't check attach_flag.
(child_terminal_ours_for_output, child_terminal_ours): Adjust to
pass down a target_terminal_state.
(child_terminal_save_inferior): New, factored out from ...
(child_terminal_ours_1): ... this. Handle
target_terminal_state::is_ours_for_output.
(child_interrupt, child_pass_ctrlc): New.
(inflow_inferior_exit): Clear the inferior's terminal_state.
(copy_terminal_info): Copy the inferior's terminal state.
(_initialize_inflow): Remove reference to terminal_is_ours.
* inflow.h (inferior_process_group): Delete.
* nto-procfs.c (nto_handle_sigint, procfs_interrupt): Adjust.
* procfs.c (procfs_target): Don't install procfs_interrupt.
(procfs_interrupt): Delete.
* remote.c (remote_serial_quit_handler): Adjust.
(remote_interrupt): Remove ptid parameter. Adjust.
* target-delegates.c: Regenerate.
* target.c: Include "terminal.h".
(target_terminal::terminal_state): Rename to ...
(target_terminal::m_terminal_state): ... this.
(target_terminal::init): Adjust.
(target_terminal::inferior): Adjust to per-inferior
terminal_state.
(target_terminal::restore_inferior, target_terminal_is_ours_kind): New.
(target_terminal::ours, target_terminal::ours_for_output): Use
target_terminal_is_ours_kind.
(target_interrupt): Remove ptid parameter. Adjust.
(default_target_pass_ctrlc): Adjust.
* target.h (target_ops::to_terminal_save_inferior): New field.
(target_ops::to_interrupt): Remove ptid_t parameter.
(target_interrupt): Remove ptid_t parameter. Update comment.
(target_pass_ctrlc): Update comment.
* target/target.h (target_terminal_state): New scoped enum,
factored out of ...
(target_terminal::terminal_state): ... here.
(target_terminal::inferior): Update comments.
(target_terminal::restore_inferior): New.
(target_terminal::is_inferior, target_terminal::is_ours)
(target_terminal::is_ours_for_output): Adjust.
(target_terminal::scoped_restore_terminal_state): Adjust to
rename, and call restore_inferior() instead of inferior().
(target_terminal::scoped_restore_terminal_state::m_state): Change
type.
(target_terminal::terminal_state): Rename to ...
(target_terminal::m_terminal_state): ... this and change type.
gdb/gdbserver/ChangeLog:
2018-01-30 Pedro Alves <palves@redhat.com>
PR gdb/13211
* target.c (target_terminal::terminal_state): Rename to ...
(target_terminal::m_terminal_state): ... this.
gdb/testsuite/ChangeLog:
2018-01-30 Pedro Alves <palves@redhat.com>
PR gdb/13211
* gdb.base/interrupt-daemon.c: New.
* gdb.base/interrupt-daemon.exp: New.
* gdb.multi/multi-term-settings.c: New.
* gdb.multi/multi-term-settings.exp: New.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] s390: Fix gdb.base/all-architectures.exp with --enable-targets=all
@ 2018-01-30 16:50 sergiodj+buildbot
2018-01-30 20:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-30 16:50 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c81e88797907fc0698abec09767e49cee33b2bd5 ***
Author: Philipp Rudo <prudo@linux.vnet.ibm.com>
Branch: master
Commit: c81e88797907fc0698abec09767e49cee33b2bd5
s390: Fix gdb.base/all-architectures.exp with --enable-targets=all
With 7042632bf79 (s390: Hook s390 into OSABI mechanism) assigning a
default target description was moved from s390_gdbarch_init to
s390_linux_init_abi_*. This causes problems when GDB is built with
--enable-targets=all and the user sets an unsupported OSABI, e.g. "set
osabi AIX". In this case there is no valid tdesc, and GDB crashes with an
internal error. Fix this by reverting parts of 7042632bf79.
gdb/ChangeLog:
* s390-linux-tdep.c: Remove includes "features/s390-linux32.c" and
"features/s390x-linux64.c".
(_initialize_s390_linux_tdep): Remove initialization of tdescs
s390_linux32 and s390x_linux64.
(s390_linux_init_abi_31, s390_linux_init_abi_64): Don't set
default tdesc.
* s390-tdep.c: Include "features/s390-linux32.c" and
"features/s390x-linux64.c".
(s390_tdesc_valid): Add check for tdesc_has_registers.
(s390_gdbarch_init): Make sure there is always a valid tdesc.
(_initialize_s390_tdep): Initialize tdesc_s390_linux32 and
tdesc_s390x_linux64.
* s390-linux-tdep.h: Move export of tdesc_s390_linux32 and
tdesc_s390x_linux64 to...
* s390-tdep.h: ...here.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Improve junk file removal in source tarball creation script.
@ 2018-01-30 18:05 sergiodj+buildbot
2018-01-30 22:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-30 18:05 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 52b2f30022323367b2cd727f402c9876bdc53b0d ***
Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 52b2f30022323367b2cd727f402c9876bdc53b0d
Improve junk file removal in source tarball creation script.
* src-release.sh (do_proto_toplev): Add patterns for more junk files
to delete before creating the tarball.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] internal-error using '@' (repeat) operator on array of dynamic objects
@ 2018-01-31 7:35 sergiodj+buildbot
2018-01-31 9:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-31 7:35 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 929b5ad40f70fbd5bdf37d30281a761d56c87b59 ***
Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 929b5ad40f70fbd5bdf37d30281a761d56c87b59
internal-error using '@' (repeat) operator on array of dynamic objects
Using the following Ada declarations (the same as in
gdb.ada/dyn_stride.exp)...
subtype Small_Type is Integer range L .. U;
type Record_Type (I : Small_Type := L) is record
S : String (1 .. I);
end record;
type Array_Type is array (Integer range <>) of Record_Type;
A1 : Array_Type :=
(1 => (I => U, S => (others => ASCII.NUL)),
2 => (I => 1, S => "A"),
3 => (I => 2, S => "AB"));
... where "L" and "U" are variables, trying to apply the repeat
operator to "A1(1)" yields to an internal error:
| (gdb) print a1(1)@3
| $5 = /[...]/gdbtypes.c:4883: internal-error: type* copy_type(const type*):
| Assertion `TYPE_OBJFILE_OWNED (type)' failed.
What happens first is that the ada-lang module evaluated the "A1(1)"
sub-expression returning a structure where "I" (one of the fields
in that structure) has a type which is dynamic, because it is
a range type whose bounds are not statically known.
Next, we apply the repeat ('@') operator, which is done via
allocate_repeat_value, which creates an array type with the correct
bounds to associate to our value, by calling lookup_array_range_type:
| struct type *
| lookup_array_range_type (struct type *element_type,
| LONGEST low_bound, LONGEST high_bound)
| {
| struct gdbarch *gdbarch = get_type_arch (element_type);
| struct type *index_type = builtin_type (gdbarch)->builtin_int;
| struct type *range_type
| = create_static_range_type (NULL, index_type, low_bound, high_bound);
|
| return create_array_type (NULL, element_type, range_type);
| }
As we can see, this creates an array type whose index type is
always owned by the gdbarch. This is where the problem lies.
Next, we use that type to construct a struct value. That value
then gets passed to the valprint module, which then checks
whether our object is dynamic or not. And because field "I" above
had a dynamic range type, we end up determining by association
that the artificial repeat array itself is also dynamic. So
we attempt to resolve the type, which leads to trying to copying
that type. And because the artifical array created by
lookup_array_range_type has an index which is not objfile-owned,
we trip the assertion.
This patch fixes the issue by enhancing lookup_array_range_type
to create an index type which has the same owner as the element
type.
gdb/ChangeLog:
* gdbtypes.c (lookup_array_range_type): Make sure the array's
index type is objfile-owned if the element type is as well.
gdb/testsuite/ChangeLog:
* testsuite/gdb.ada/dyn_stride.exp: Add "print a1(1)@3" test.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] (Ada) Add gdb-mi support for stopping at start of exception handler.
@ 2018-01-31 13:41 sergiodj+buildbot
2018-01-31 21:06 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-31 13:41 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT bea298f9547372e6cb7854fabc2c0646e1d3d9be ***
Author: Xavier Roirand <roirand@adacore.com>
Branch: master
Commit: bea298f9547372e6cb7854fabc2c0646e1d3d9be
(Ada) Add gdb-mi support for stopping at start of exception handler.
Following my previous commit which add support for stopping at start of
exception handler, this commit adds required gdb-mi support for this
feature.
gdb/ChangeLog:
* mi/mi-cmd-catch.c (mi_cmd_catch_handlers): New function.
* mi/mi-cmds.c (mi_cmds): Add catch-handlers command.
* mi/mi-cmds.h (mi_cmd_catch_handlers): Add external declaration.
* NEWS: Document "-catch-handlers" command.
gdb/doc/ChangeLog:
* gdb.texinfo (Ada Exception gdb/mi Catchpoints): Add
documentation for new "-catch-handlers" command.
gdb/testsuite/ChangeLog:
* gdb.ada/mi_catch_ex_hand.exp: New testcase.
* gdb.ada/mi_catch_ex_hand/foo.adb: New file.
Tested on x86_64-linux.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] (Ada) C++fy conditional string when catching exception.
@ 2018-01-31 13:56 sergiodj+buildbot
2018-01-31 18:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-31 13:56 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 56ecd069f031d6bcdaa46664c68a16cb27b379c3 ***
Author: Xavier Roirand <roirand@adacore.com>
Branch: master
Commit: 56ecd069f031d6bcdaa46664c68a16cb27b379c3
(Ada) C++fy conditional string when catching exception.
This commit C++fy the conditional string used when catching Ada exception.
gdb/ChangeLog:
* ada-lang.c (catch_ada_exception_command_split)
(create_ada_exception_catchpoint) <cond_string>: Change parameter
type. Update code accordingly.
(catch_ada_exception_command, catch_ada_handlers_command): Use
C++ string instead of char* for conditional var.
(catch_ada_assert_command_split) <cond_string>: Change parameter
type. Update code accordingly.
(catch_assert_command): Use C++ string instead of char* for
conditional var.
* ada-lang.h (create_ada_exception_catchpoint) <cond_string>:
Update declaration.
* mi/mi-cmd-catch.c (mi_cmd_catch_assert, mi_cmd_catch_exception):
Use std::string instead of char* for condition string.
Tested on x86_64-linux.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] bfd_elf_define_start_stop: Fix check
@ 2018-01-31 15:00 sergiodj+buildbot
2018-02-01 1:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-31 15:00 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT bf3077a6c3c9ff21c072a6f42c91bffefd35bc15 ***
Author: Michael Matz <matz@suse.de>
Branch: master
Commit: bf3077a6c3c9ff21c072a6f42c91bffefd35bc15
bfd_elf_define_start_stop: Fix check
We really need to check for a dynamic def, not only a ref.
See added testcase.
bfd/
* elflink.c (bfd_elf_define_start_stop): Fix check of
def_dynamic.
ld/
* testsuite/ld-elf/pr21964-5.c: New test.
* testsuite/ld-elf/shared.exp: Run it.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb: Fix remote-sim/MinGW/Darwin builds
@ 2018-01-31 15:21 sergiodj+buildbot
2018-02-01 3:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-01-31 15:21 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f6cfb42730ed37bfb32cb27ef627df930f437f08 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: f6cfb42730ed37bfb32cb27ef627df930f437f08
gdb: Fix remote-sim/MinGW/Darwin builds
The recent commit e671cd59 ("Per-inferior target_terminal state, fix
PR gdb/13211, more") missed adjusting a few targets to the new
target_ops->to_interrupt interface, breaking the build for those
targets. This fixes it.
Note: remote-sim doesn't really support async execution, so I don't
think gdbsim_interrupt is ever reached via target_interrupt. (It is
reached via gdbsim_cntrl_c though).
The inflow.c changes are a bit ugly, but they're just doing what other
parts of the file already do to handle the same missing functions.
Targets that don't have 'kill', like mingw have their own
target_ops->to_interrupt implementation, so it's fine to make
child_interrupt be a nop.
gdb/ChangeLog:
2018-01-31 Pedro Alves <palves@redhat.com>
* darwin-nat.c (darwin_interrupt): Remove ptid_t parameter.
* inflow.c (child_terminal_save_inferior): Wrap reference to
tcgetpgrp in HAVE_TERMIOS_H.
(child_interrupt, child_pass_ctrlc): Wrap references to signal in
_WIN32.
* remote-sim.c (gdbsim_interrupt): Remove ptid_t parameter and
always iterate over all inferiors.
(gdbsim_cntrl_c): Adjust.
* windows-nat.c (windows_interrupt): Remove 'ptid_t' parameter.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix compile time warnings building the binutils with clang.
@ 2018-02-01 13:38 sergiodj+buildbot
2018-02-01 14:39 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-01 13:38 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e99955cd8eca9ac8eff828e8c7b676955fd46e04 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: e99955cd8eca9ac8eff828e8c7b676955fd46e04
Fix compile time warnings building the binutils with clang.
bfdI would like to fix instances of the following warning, when building
with clang with no special CFLAGS other than -g3 -O0.
/home/emaisin/src/binutils-gdb/bfd/elflink.c:5425:45: error: performing pointer arithmetic on a null pointer has undefined behavior [-Werror,-Wnull-pointer-arithmetic]
return (struct elf_link_hash_entry *) 0 - 1;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
Replacing those with "(struct elf_link_hash_entry *) -1" gets rid of the
warning. I wanted to check that it didn't change the resulting code, so
I tried to build this:
$ cat test.c
int *before()
{
return (int *) 0 - 1;
}
int *after()
{
return (int *) - 1;
}
$ gcc -c test.c -g
$ objdump -d test.o
test.o: file format elf64-x86-64
Disassembly of section .text:
0000000000000000 <before>:
0: 55 push %rbp
1: 48 89 e5 mov %rsp,%rbp
4: 48 c7 c0 fc ff ff ff mov $0xfffffffffffffffc,%rax
b: 5d pop %rbp
c: c3 retq
000000000000000d <after>:
d: 55 push %rbp
e: 48 89 e5 mov %rsp,%rbp
11: 48 c7 c0 ff ff ff ff mov $0xffffffffffffffff,%rax
18: 5d pop %rbp
19: c3 retq
This shows that the previous code doesn't actually return -1 as the
function documentation says, but the new one does, so it's kind of a
bugfix.
bfd * elf64-ppc.c (ppc64_elf_archive_symbol_lookup): Avoid pointer
arithmetic on NULL pointer.
* elflink.c (_bfd_elf_archive_symbol_lookup,
elf_link_add_archive_symbols): Likewise.
ld * ldexp.c (fold_name, exp_fold_tree_1): Avoid pointer arithmetic
on NULL pointer.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] set ret signed in arm_record_extension_space
@ 2018-02-01 15:47 sergiodj+buildbot
2018-02-01 19:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-01 15:47 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT df95a9cf09867c237ddf9b4eb65a990e86de1e17 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: df95a9cf09867c237ddf9b4eb65a990e86de1e17
set ret signed in arm_record_extension_space
Variable 'ret' should be int rather than unsigned, as it can be -1.
gdb:
2018-02-01 Yao Qi <yao.qi@linaro.org>
* arm-tdep.c (arm_record_extension_space): Change ret to signed.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Rewrite arm_record_coproc_data_proc and arm_record_data_proc_misc_ld_str
@ 2018-02-01 16:11 sergiodj+buildbot
2018-02-01 20:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-01 16:11 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2d9e6acbdbc528563a9df5445584a8a150a86527 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 2d9e6acbdbc528563a9df5445584a8a150a86527
Rewrite arm_record_coproc_data_proc and arm_record_data_proc_misc_ld_str
When I triage some reverse debugging test fails on arm-linux, I find
arm_record_coproc_data_proc and arm_record_data_proc_misc_ld_str is not
friendly to instruction encoding on ARM ARM. This patch rewrites them, in
a way match more closely to the manual.
gdb:
2018-02-01 Yao Qi <yao.qi@linaro.org>
* arm-tdep.c (arm_record_data_proc_misc_ld_str): Rewrite it.
(arm_record_coproc_data_proc): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Do not classify C struct members as a filename
@ 2018-02-02 3:50 sergiodj+buildbot
2018-02-02 4:41 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-02 3:50 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 59498c305e6f1db2a1ed8d44cb58f0d24ec092fe ***
Author: Leszek Swirski <leszeks@google.com>
Branch: master
Commit: 59498c305e6f1db2a1ed8d44cb58f0d24ec092fe
Do not classify C struct members as a filename
There is existing logic in C/C++ expression parsing to avoid classifying
names as a filename when they are a field on the this object. This
change extends this logic to also avoid classifying names after a
struct-op (-> or .) as a filename, which otherwise causes a syntax
error.
Thus, it is now possible in the file
#include <map>
struct D {
void map();
}
D d;
to call
(gdb) print d.map()
where previously this would have been a syntax error.
Tested on gdb.cp/*.exp
gdb/ChangeLog:
* c-exp.y (lex_one_token, classify_name, yylex): Don't classify
names after a structop as a filename
gdb/testsuite/ChangeLog:
* gdb.cp/filename.cc, gdb.cp/filename.exp: Test that member
functions with the same name as an include file are parsed
correctly.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PowerPC64, don't relocate nops
@ 2018-02-02 12:31 sergiodj+buildbot
2018-02-02 13:33 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-02 12:31 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d830549dba59f4e11412fd6dc18b7b1d4c6cf557 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: d830549dba59f4e11412fd6dc18b7b1d4c6cf557
PowerPC64, don't relocate nops
This fixes a "bug" in that nops emitted as part of code optimization
were being relocated. As it happens the relocation value was always
zero so the nop wasn't changed. Whew! I've also moved the use of
"howto" later since I was caught out in some recent code changes with
the howto not matching r_type.
* elf64-ppc.c (ppc64_elf_relocate_section): Don't relocate nops
emitted for toc sequence optimization. Set and use "howto" later.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] MI: Allow non-raw varobj evaluation
@ 2018-02-02 19:21 sergiodj+buildbot
2018-02-02 20:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-02 19:21 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 0625771b9e29116dc1fb0b597501f18e4bb0e18c ***
Author: Leszek Swirski via gdb-patches <gdb-patches@sourceware.org>
Branch: master
Commit: 0625771b9e29116dc1fb0b597501f18e4bb0e18c
MI: Allow non-raw varobj evaluation
Make the MI variable object expression evaluation, with the
-var-evaluate-expression command, recursively call pretty printers, to
match the output of normal expression printing.
Consider the following code:
struct Foo { int val; };
struct Wrapper { Foo foo; };
int main() {
Wrapper w;
w.foo.val = 23;
}
and this pretty printer file:
import gdb.printing
class FooPrinter:
def __init__(self, val):
self.val = val
def to_string(self):
return "Foo" + str(self.val["val"])
class WrapperPrinter:
def __init__(self, val):
self.val = val
def to_string(self):
return self.val["foo"]
test_printer = gdb.printing.RegexpCollectionPrettyPrinter("test")
test_printer.add_printer('Foo', '^Foo$', FooPrinter)
test_printer.add_printer('Wrapper', '^Wrapper$', WrapperPrinter)
gdb.printing.register_pretty_printer(None, test_printer)
Setting a breakpoint at the end of the function, we call the following commands:
-enable-pretty-printing
^done
-var-create var_w @ w
^done,name="var_w",numchild="0",value="{val = 23}",type="Wrapper",dynamic="1",has_more="0"
-var-create var_w_foo @ w.foo
^done,name="var_w_foo",numchild="0",value="Foo23",type="Foo",dynamic="1",has_more="0"
-var-evaluate-expression var_w
^done,value="{val = 23}"
-var-evaluate-expression var_w_foo
^done,value="Foo23"
-data-evaluate-expression w
^done,value="Foo23"
-data-evaluate-expression w.foo
^done,value="Foo23"
So, in the -var-evaluate-expression var_w case, we print the "raw" value
of w.foo, while in the -data-evaluate-expression w case, we print the
pretty printed w.foo value. After this patch, all of the above print
"Foo23".
gdb/ChangeLog:
* varobj.c (varobj_formatted_print_options): Allow recursive
pretty printing if pretty printing is enabled.
gdb/testsuite/ChangeLog:
* gdb.python/py-prettyprint.c
(struct to_string_returns_value_inner,
struct to_string_returns_value_wrapper): New.
(main): Add tsrvw variable.
* gdb.python/py-prettyprint.py (ToStringReturnsValueInner,
ToStringReturnsValueWrapper): New classes.
(register_pretty_printers): Register new pretty-printers.
* gdb.python/py-prettyprint.exp (run_lang_tests): Test printing
recursive pretty printer.
* gdb.python/py-mi.exp: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb/testsuite: Remove use of dejagnu cleanup proc
@ 2018-02-03 17:11 sergiodj+buildbot
2018-02-03 18:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-03 17:11 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f721678315fc6bbec25341bd616a906976d72693 ***
Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: f721678315fc6bbec25341bd616a906976d72693
gdb/testsuite: Remove use of dejagnu cleanup proc
The 'cleanup' proc has been removed from dejagnu (Feb 15 2016). The
proc has not done anything useful since at least 2001 so removing
these calls should be harmless.
gdb/testsuite/ChangeLog:
* config/sid.exp (gdb_target_sid): Remove use of cleanup.
* config/sim.exp (gdb_target_sim): Remove use of cleanup.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Move comment in gdb/dwarf2read.c::dwarf2_physname
@ 2018-02-05 5:03 sergiodj+buildbot
2018-02-05 5:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-05 5:03 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 0eb876f52f348ff08be24bca6cbca00e302839b2 ***
Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 0eb876f52f348ff08be24bca6cbca00e302839b2
Move comment in gdb/dwarf2read.c::dwarf2_physname
This commit just moves a comment right next to where it is actually
relevant. No actual code change.
gdb/ChangeLog:
* dwarf2read.c (dwarf2_physname): Move commment.
Tested by rebuilding GDB.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] ELF/BFD: Propagate the return status from backend section processing
@ 2018-02-05 14:17 sergiodj+buildbot
2018-02-05 17:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-05 14:17 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 7550610057c51d47e3815ef93893d4f4faa7e03d ***
Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 7550610057c51d47e3815ef93893d4f4faa7e03d
ELF/BFD: Propagate the return status from backend section processing
Fix the issue of any failure from `->elf_backend_section_processing'
not being propagated by `_bfd_elf_write_object_contents'. The MIPS
`_bfd_mips_elf_section_processing' handler can actually potentially
fail, however the caller currently ignores that.
bfd/
* elf.c (_bfd_elf_write_object_contents): Propagate a failure
status from `->elf_backend_section_processing'.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] MIPS/BFD: Correctly report unsupported `.reginfo' section size
@ 2018-02-05 14:29 sergiodj+buildbot
2018-02-05 21:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-05 14:29 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2d6dda71611ba6cc16fe2bd21ac816d5f7d1e74d ***
Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 2d6dda71611ba6cc16fe2bd21ac816d5f7d1e74d
MIPS/BFD: Correctly report unsupported `.reginfo' section size
Report an error when an unsupported `.reginfo' section size is found in
`_bfd_mips_elf_section_processing', removing an assertion that triggers
at elfxx-mips.c:7105 in GAS when assembling input like:
.section .reginfo
.word 0xdeadbeef
and in `objcopy --rename-section' when renaming an incorrectly sized
section to `.reginfo'.
bfd/
* elfxx-mips.c (_bfd_mips_elf_section_processing): For
SHT_MIPS_REGINFO sections don't assert the correct size and
report an error instead.
binutils/
* testsuite/binutils-all/mips/mips-reginfo.d: New test.
* testsuite/binutils-all/mips/mips-reginfo-n32.d: New test.
* testsuite/binutils-all/mips/mips-reginfo.s: New test source.
* testsuite/binutils-all/mips/mips.exp: Run the new tests.
gas/
* testsuite/gas/mips/reginfo-2.d: New test.
* testsuite/gas/mips/reginfo-2-n32.d: New test.
* testsuite/gas/mips/reginfo-2.l: New test stderr output.
* testsuite/gas/mips/reginfo-2.s: New test source.
* testsuite/gas/mips/mips.exp: Run the new tests.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] RISC-V/BFD: Correct a missing initializer error with pre-4.7 GCC
@ 2018-02-05 14:42 sergiodj+buildbot
2018-02-05 23:02 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-05 14:42 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e65b1a78686f840ab46fe97355d674919185adc8 ***
Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: e65b1a78686f840ab46fe97355d674919185adc8
RISC-V/BFD: Correct a missing initializer error with pre-4.7 GCC
Correct a commit 9d06997adb88 ("RISC-V: Relax RISCV_PCREL_* to
RISCV_GPREL_*") regression and remove a `-Wmissing-field-initializers'
compilation error:
cc1: warnings being treated as errors
.../bfd/elfnn-riscv.c: In function '_bfd_riscv_relax_pc':
.../bfd/elfnn-riscv.c:3117: error: missing initializer
.../bfd/elfnn-riscv.c:3117: error: (near initialization for 'hi_reloc.hi_addend')
make[4]: *** [elf64-riscv.lo] Error 1
which for versions of GCC before 4.7 prevents support for RISC-V targets
from being built. See also GCC PR c/36750.
bfd/
* elfnn-riscv.c (_bfd_riscv_relax_pc): Use `memset' to
initialize `hi_reloc'.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Use visitors for make_gdb_type
@ 2018-02-05 16:54 sergiodj+buildbot
2018-02-06 0:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-05 16:54 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b8df6ca79e69678a07d3216b9b2b552fce27cda8 ***
Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: b8df6ca79e69678a07d3216b9b2b552fce27cda8
Use visitors for make_gdb_type
Remove the make_gdb_type functions from the tdesc_type_ classes.
Replace with a static make_gdb_type function that uses a element
visitor called gdb_type_creator.
gdb/
* target-descriptions.c (tdesc_element_visitor) Add empty implementations.
(tdesc_type): Move make_gdb_type from here.
(tdesc_type_builtin): Likewise.
(tdesc_type_vector): Likewise.
(tdesc_type_with_fields): Move make_gdb_type_ functions from here.
(make_gdb_type_struct): Move from tdesc_type_with_fields.
(make_gdb_type_union): Likewise.
(make_gdb_type_flags): Likewise.
(make_gdb_type_enum): Likewise.
(make_gdb_type): New function.
(tdesc_register_type): Use static make_gdb_type.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: Remove the unused _GLOBAL_OFFSET_TABLE_
@ 2018-02-05 17:05 sergiodj+buildbot
2018-02-06 2:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-05 17:05 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT cd04836359da82ae1dc67e5a05565536f4427b51 ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: cd04836359da82ae1dc67e5a05565536f4427b51
x86: Remove the unused _GLOBAL_OFFSET_TABLE_
Since _GLOBAL_OFFSET_TABLE_ may be referenced implicitly on x86,
checking ref_regular_nonweak leaves the unused _GLOBAL_OFFSET_TABLE_
in output. This patch checks explicit GOT references instead.
ld-i386/discarded1.s and ld-x86-64/discarded1.s are updated to avoid
linker optimization which removes GOT references.
bfd/
PR ld/22782
* elf32-i386.c (elf_i386_check_relocs): Set got_referenced if
_GLOBAL_OFFSET_TABLE_ is referenced or GOT is needed to resolve
undefined weak symbol to 0.
* elf64-x86-64.c (elf_x86_64_check_relocs): Set got_referenced
if _GLOBAL_OFFSET_TABLE_ is referenced.
* elfxx-x86.c (_bfd_x86_elf_size_dynamic_sections): Check
got_referenced instead of ref_regular_nonweak. Remove the
unused _GLOBAL_OFFSET_TABLE_ from symbol table.
* elfxx-x86.h (elf_x86_link_hash_table): Add got_referenced.
ld/
PR ld/22782
* testsuite/ld-i386/discarded1.s: Replace mov with div.
* testsuite/ld-x86-64/discarded1.s: Likewise.
* testsuite/ld-i386/i386.exp: Run pr22782.
* testsuite/ld-i386/load1-nacl.d: Updated for removing
_GLOBAL_OFFSET_TABLE_ from output.
* testsuite/ld-i386/load1.d: Likewise.
* testsuite/ld-x86-64/load1a-nacl.d: Likewise.
* testsuite/ld-x86-64/load1a.d: Likewise.
* testsuite/ld-x86-64/load1b-nacl.d: Likewise.
* testsuite/ld-x86-64/load1b.d: Likewise.
* testsuite/ld-i386/pr22782.d: New file.
* testsuite/ld-i386/pr22782.s: Likewise.
* testsuite/ld-x86-64/pr22782.s: Likewise.
* testsuite/ld-x86-64/pr22782a.d: Likewise.
* testsuite/ld-x86-64/pr22782b.d: Likewise.
* testsuite/ld-x86-64/x86-64.exp: Run pr22782a and pr22782b.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove myself as a write-after-approval GDB maintainer.
@ 2018-02-05 18:11 sergiodj+buildbot
2018-02-06 4:30 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-05 18:11 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f3b91ed8f96a4d41eef1c64a7e77c406ec763612 ***
Author: Antoine Tremblay <antoine.tremblay@ericsson.com>
Branch: master
Commit: f3b91ed8f96a4d41eef1c64a7e77c406ec763612
Remove myself as a write-after-approval GDB maintainer.
Since I'll be leaving Ericsson.
gdb/
* MAINTAINERS (Write After Approval): Remove Antoine Tremblay.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] ppc64: Fix stwux encoding
@ 2018-02-05 19:45 sergiodj+buildbot
2018-02-06 8:14 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-05 19:45 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 72dd27306224497c8ba97f391d30b774d4d973fb ***
Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Branch: master
Commit: 72dd27306224497c8ba97f391d30b774d4d973fb
ppc64: Fix stwux encoding
With gcc-8.0.1-0.9.fc28.x86_64 I get:
../../gdb/rs6000-tdep.c: In function 'CORE_ADDR skip_prologue(gdbarch*, CORE_ADDR, CORE_ADDR, rs6000_framedata*)':
../../gdb/rs6000-tdep.c:1911:34: error: bitwise comparison always evaluates to false [-Werror=tautological-compare]
else if ((op & 0xfc1f016a) == 0x7c01016e)
~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
https://www.ibm.com/support/knowledgecenter/en/ssw_aix_72/com.ibm.aix.alangref/idalangref_stwux_stux_instrs.htm
says
bit 21 - 30 = 183
Those are bits 1..10 in normal bit order: 183<<1 = 0x16e
gdb/ChangeLog
2018-02-04 Jan Kratochvil <jan.kratochvil@redhat.com>
* rs6000-tdep.c (skip_prologue): Fix stwux encoding.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Allow the find_abstract_instance_name() function in the BFD library to also return file and line number information.
@ 2018-02-06 16:04 sergiodj+buildbot
2018-02-06 17:14 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-06 16:04 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 422f3d3d6d5713bf9235b7b7696818a70b3b578d ***
Author: Paul Carroll <pcarroll@codesourcery.com>
Branch: master
Commit: 422f3d3d6d5713bf9235b7b7696818a70b3b578d
Allow the find_abstract_instance_name() function in the BFD library to also return file and line number information.
The nm utility supports -l for using debug information to obtain file and line information for each symbol, if available.
We have a tool that consumes this information and displays it.
This identified a problem with the 'nm' utility.
When a source is compiled with -O2, functions can be inlined. The compiler also produces an uninlined copy of the function, normally for linking to other object files.
In the case of DWARF2 debug information, the compiler generates debug information to describe a function. If that function is inlined, the compiler then references that debug information from the inlined and uninlined copies of the routine through the use of the DW_AT_abstract_origin reference.
When nm is used on such a file, it is not able to find file and line information because that information is present in the common debug information and not at each actual implementation of the function.
The 'nm' utility only retrieves the name of the function from the abstract origin debug information and no more.
What I am proposing is to modify the find_abstract_instance_name() function (which I renamed to find_abstract_instance() ) to return the name of the function as well as any file and line information. The routine is already parsing all of the debug information in the abstract instance, so it is easy to pick up the file and line information at that time. If, for some reason, the file and line information is not present, the routine behaves as before.
For example, if I have a simple test case:
int foo(int j)
{
if (j < 15)
j += j << 2;
else
j += j << 6;
return j;
}
int main (int argc,char **argv)
{
int i = argc;
i += foo(i);
return i;
}
If that test case is compiled with -O2 and then 'nm -l' reads that executable, it currently produces this symbol output (ignoring a lot of library symbols):
8048400 T foo
080482e0 T main /scratch/pcarroll/its254/test/mytest.c:12
If I modify 'nm' to return file and line information for abstract instances, it produces the following output:
08048400 T foo /scratch/pcarroll/its254/test/mytest.c:1
080482e0 T main /scratch/pcarroll/its254/test/mytest.c:12
--------------------------------------------------------------------------
bfd * bfd/dwarf2.c (find_abstract_name): Modified to return file and
line information in addition to name, if they can be found.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Prevent attempts to call strncpy with a zero-length field by chacking the size of debuglink sections.
@ 2018-02-06 16:48 sergiodj+buildbot
2018-02-06 20:07 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-06 16:48 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 64e234d417d5685a4aec0edc618114d9991c031b ***
Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 64e234d417d5685a4aec0edc618114d9991c031b
Prevent attempts to call strncpy with a zero-length field by chacking the size of debuglink sections.
PR 22794
* opncls.c (bfd_get_debug_link_info_1): Check the size of the
section before attempting to read it in.
(bfd_get_alt_debug_link_info): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix GCC 8's -Wstringop-overflow on bfd/coff-rs6000.c
@ 2018-02-06 17:02 sergiodj+buildbot
2018-02-06 22:38 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-06 17:02 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 8278e7cec35536046caf596f4e55c7c037d06cf0 ***
Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: 8278e7cec35536046caf596f4e55c7c037d06cf0
Fix GCC 8's -Wstringop-overflow on bfd/coff-rs6000.c
GCC 8 will bring a new warning option which will detect possible
overflow and truncation on string manipulation functions. For more
details, see:
https://gcc.gnu.org/ml/gcc-patches/2017-08/msg00471.html
While compiling BFD with it, I can see one place on bfd/coff-rs6000.c
where the warning is triggered. This:
(void) strncpy (fhdr.magic, XCOFFARMAG, SXCOFFARMAG);
will not include the trailing NUL on fhdr.magic, but that's fine
because it's a magic number. The fix is trivial: just use memcpy
instead.
OK to push?
2018-02-06 Sergio Durigan Junior <sergiodj@redhat.com>
* coff-rs6000.c (xcoff_write_archive_contents_old): Use
'memcpy' instead of 'strncpy' when writing the magic number.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Improve the find_nearest_line function for the MIPS target so that it tries harder to find a function name.
@ 2018-02-06 17:17 sergiodj+buildbot
2018-02-07 0:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-06 17:17 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 46d09186d340407fdcf066fea25444682e989512 ***
Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 46d09186d340407fdcf066fea25444682e989512
Improve the find_nearest_line function for the MIPS target so that it tries harder to find a function name.
PR 22789
* elfxx-mips.c (_bfd_mips_elf_find_nearest_line): If the dwarf
functions failed to find the function name, try the generic elf
find function instead.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Treat OP_F77_UNDETERMINED_ARGLIST as OP_FUNCALL
@ 2018-02-06 17:29 sergiodj+buildbot
2018-02-07 2:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-06 17:29 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT bca65a2394ce11bb4a0b001b8a986961c2e84881 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: bca65a2394ce11bb4a0b001b8a986961c2e84881
Treat OP_F77_UNDETERMINED_ARGLIST as OP_FUNCALL
When I debug some fortran expression parsing, I got
(gdb) set debug expression 1
(gdb) p intvla(5,5,5)
Dump of expression @ 0x205fa80, before conversion to prefix form:
Language fortran, 19 elements, 16 bytes each.
Index Opcode Hex Value String Value
0 OP_VAR_VALUE 40 (...............
1 <unknown 31863232> 31863232 .1..............
....
14 BINOP_REM 5 ................
15 OP_LONG 38 &...............
16 OP_F77_UNDETERMINED_ARGLIST 48 0...............
17 BINOP_MUL 3 ................
18 OP_F77_UNDETERMINED_ARGLIST 48 0...............
Dump of expression @ 0x205fa80, after conversion to prefix form:
Expression: `Invalid expression
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This patch fixes this problem by handling OP_F77_UNDETERMINED_ARGLIST in
the same way as handling OP_FUNCALL. With this patch applied, the output
looks better,
(gdb) p intvla (5,5,5)
Dump of expression @ 0x2d75590, before conversion to prefix form:
Language fortran, 19 elements, 16 bytes each.
Index Opcode Hex Value String Value
0 OP_VAR_VALUE 40 (...............
....
16 OP_F77_UNDETERMINED_ARGLIST 48 0...............
17 BINOP_MUL 3 ................
18 OP_F77_UNDETERMINED_ARGLIST 48 0...............
Dump of expression @ 0x2d75590, after conversion to prefix form:
Expression: `vla_primitives::intvla (5, 5, 5)'
Language fortran, 19 elements, 16 bytes each.
0 OP_F77_UNDETERMINED_ARGLIST Number of args: 3
3 OP_VAR_VALUE Block @0x297e1c0, symbol @0x297cd50 (intvla)
7 OP_LONG Type @0x2976900 (int), value 5 (0x5)
11 OP_LONG Type @0x2976900 (int), value 5 (0x5)
15 OP_LONG Type @0x2976900 (int), value 5 (0x5)
gdb:
2018-02-06 Yao Qi <yao.qi@linaro.org>
* expprint.c (print_subexp_standard): Handle
OP_F77_UNDETERMINED_ARGLIST.
(dump_subexp_body_standard): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix PR ld/22263 on SPARC.
@ 2018-02-06 17:43 sergiodj+buildbot
2018-02-07 4:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-06 17:43 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c20c30f615756ddfccc4bb75c65ccfc1a399466e ***
Author: Eric Botcazou <ebotcazou@gcc.gnu.org>
Branch: master
Commit: c20c30f615756ddfccc4bb75c65ccfc1a399466e
Fix PR ld/22263 on SPARC.
This is -fpie -pie generating dynamic relocations in the text section,
simply because no TLS transitions are applied in PIE mode. The meat
of the patch is to turn calls to bfd_link_pic (info) in TLS-related code
into !bfd_link_executable (info) and there are quite a lot of them...
bfd/
* elfxx-sparc.c (sparc_elf_tls_transition): Turn call to bfd_link_pic
into call to !bfd_link_executable and tidy up.
(_bfd_sparc_elf_check_relocs): Fix formatting and tidy up.
<R_SPARC_TLS_LE_HIX22>: Turn call to bfd_link_pic into call to
!bfd_link_executable.
<R_SPARC_TLS_IE_HI22>: Likewise.
<GOT relocations>: Remove useless code, tidy and merge blocks.
<R_SPARC_TLS_GD_CALL>: Turn call to bfd_link_pic into call to
!bfd_link_executable.
<R_SPARC_WPLT30>: Tidy up.
(_bfd_sparc_elf_gc_mark_hook): Turn call to bfd_link_pic into call
to !bfd_link_executable.
(allocate_dynrelocs): Likewise.
(_bfd_sparc_elf_relocate_section): Fix formatting and tidy up.
<R_SPARC_TLS_GD_HI22>: Merge into...
<R_SPARC_TLS_GD_LO10>: ...this. Adjust 4th argument in call to
sparc_elf_tls_transition and remove redundant code.
<R_SPARC_TLS_LDM_HI22>: Turn call to bfd_link_pic into call to
!bfd_link_executable.
<R_SPARC_TLS_LDO_HIX22>: Likewise.
<R_SPARC_TLS_LE_HIX22>: Likewise. Tidy up.
<R_SPARC_TLS_LDM_CALL>: Likewise.
<R_SPARC_TLS_GD_CALL>: Likewise. Tidy up.
<R_SPARC_TLS_GD_ADD>: Likewise.
<R_SPARC_TLS_LDM_ADD>: Likewise.
<R_SPARC_TLS_LDO_ADD>: Likewise.
<R_SPARC_TLS_IE_LD>: Likewise.
ld/
* testsuite/ld-elf/tls.exp (AFLAGS_PIC): Define on SPARC.
(pr22263-1): Pass AFLAGS_PIC to the assembler.
* testsuite/ld-sparc/tlspie32.s: Add test for other 3 transitions.
* testsuite/ld-sparc/tlspie32.dd: Adjust to above.
* testsuite/ld-sparc/tlspie64.s: Add test for other 3 transitions.
* testsuite/ld-sparc/tlspie64.dd: Adjust to above.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove some $ARCH_read_pc and $ARCH_write_pc
@ 2018-02-06 20:29 sergiodj+buildbot
2018-02-07 7:08 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-06 20:29 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 3f8c94b478c8f2e5c82a1425fd49e977ed969a7f ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 3f8c94b478c8f2e5c82a1425fd49e977ed969a7f
Remove some $ARCH_read_pc and $ARCH_write_pc
Nowadays, gdbarch_read_pc is called in this way,
if (gdbarch_read_pc_p (gdbarch))
pc_val = gdbarch_read_pc (gdbarch, regcache);
/* Else use per-frame method on get_current_frame. */
else if (gdbarch_pc_regnum (gdbarch) >= 0)
{
ULONGEST raw_val;
if (regcache_cooked_read_unsigned (regcache,
gdbarch_pc_regnum (gdbarch),
&raw_val) == REG_UNAVAILABLE)
some ports don't have to define its own gdbarch read_pc method if the
pc value is simply a unsigned value from "pc" register. The same rule
applies to regcache_write_pc. This patch removes these $ARCH_read_pc
and $ARCH_write_pc functions.
gdb:
2018-02-06 Yao Qi <yao.qi@linaro.org>
* ft32-tdep.c (ft32_read_pc): Remove.
(ft32_write_pc): Remove.
(ft32_gdbarch_init): Update.
* m32r-tdep.c (m32r_read_pc): Remove.
(m32r_gdbarch_init): Update.
* mep-tdep.c (mep_read_pc): Remove.
(mep_gdbarch_init): Update.
* microblaze-tdep.c (microblaze_write_pc): Remove.
(microblaze_gdbarch_init): Update.
* mn10300-tdep.c (mn10300_read_pc): Remove.
(mn10300_write_pc): Remove.
(mn10300_gdbarch_init): Update.
* moxie-tdep.c (moxie_read_pc): Remove.
(moxie_write_pc): Remove.
(moxie_gdbarch_init): Update.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Revert "PowerPC PLT speculative execution barriers"
@ 2018-02-07 4:11 sergiodj+buildbot
2018-02-07 11:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-07 4:11 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 407aa07cee4d075c8e7996a5e994c02e76f19276 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 407aa07cee4d075c8e7996a5e994c02e76f19276
Revert "PowerPC PLT speculative execution barriers"
This reverts most of commit 1be5d8d3bb.
Left in place are addition of --no-plt-align to some ppc32 ld tests
and the ld.texinfo --no-plt-thread-safe fix.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix type of values representing optimized out static members
@ 2018-02-07 14:04 sergiodj+buildbot
2018-02-07 14:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-07 14:04 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c2e0e465f9488970c7e460a41e3fb7c366530619 ***
Author: Simon Marchi <simark@simark.ca>
Branch: master
Commit: c2e0e465f9488970c7e460a41e3fb7c366530619
Fix type of values representing optimized out static members
As reported here:
https://sourceware.org/ml/gdb/2018-02/msg00019.html
the type of values representing static members that are optimized out is
wrong. It currently assigns the type of the containing class rather
than the type of the field. This patch fixes that.
I found a place in m-static.exp already dealing with optimized out
static members, so I just added some gdb_test there.
gdb/ChangeLog:
* value.c (value_static_field): Assign field type instead of
containing type when returning an optimized out value.
gdb/testsuite/ChangeLog:
* gdb.cp/m-static.exp: Check type of optimized out static
member.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove a cleanup from gdbserver
@ 2018-02-08 19:05 sergiodj+buildbot
2018-02-08 19:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-08 19:05 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 45dd3607e24aaf515b5d75c666b351575410392b ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 45dd3607e24aaf515b5d75c666b351575410392b
Remove a cleanup from gdbserver
This removes a cleanup from gdbserver's set_raw_breakpoint_at,
replacing it with unique_xmalloc_ptr.
2018-02-08 Tom Tromey <tom@tromey.com>
* mem-break.c (set_raw_breakpoint_at): Use
gdb::unique_xmalloc_ptr.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove make_cleanup_restore_current_thread from gdbserver
@ 2018-02-08 19:18 sergiodj+buildbot
2018-02-08 22:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-08 19:18 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 8ce47547b34fddec16d1ccd801f025a56976af95 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 8ce47547b34fddec16d1ccd801f025a56976af95
Remove make_cleanup_restore_current_thread from gdbserver
This removes make_cleanup_restore_current_thread from gdbserver,
replacing it with a use of scoped_restore.
2018-02-08 Tom Tromey <tom@tromey.com>
* linux-low.c (install_software_single_step_breakpoints): Use
make_scoped_restore.
* inferiors.c (make_cleanup_restore_current_thread): Remove.
(do_restore_current_thread_cleanup): Remove.
* gdbthread.h (make_cleanup_restore_current_thread): Don't
declare.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Use gdb::def_vector in find_source_lines
@ 2018-02-08 20:25 sergiodj+buildbot
2018-02-09 8:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-08 20:25 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a9abc4345150a3f3e30da78f8d68c1f9e0198772 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: a9abc4345150a3f3e30da78f8d68c1f9e0198772
Use gdb::def_vector in find_source_lines
This replaces an explicit malloc and a cleanup with a gdb::def_vector.
2018-02-08 Tom Tromey <tom@tromey.com>
* source.c (find_source_lines): Use gdb::def_vector.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] RISC-V: Add comment for previous change.
@ 2018-02-08 21:32 sergiodj+buildbot
2018-02-09 14:05 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-08 21:32 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 3f48fe4a95ec0e67b81d5d606762c91ad9a6b799 ***
Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 3f48fe4a95ec0e67b81d5d606762c91ad9a6b799
RISC-V: Add comment for previous change.
bfd/
* elfnn-riscv.c (riscv_elf_relocate_section): Add comment for previous
change.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove cleanups from solib.c
@ 2018-02-08 23:17 sergiodj+buildbot
2018-02-09 12:21 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-08 23:17 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9a897d43f034544cd09292d0fb6fded7eb64ae8d ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 9a897d43f034544cd09292d0fb6fded7eb64ae8d
Remove cleanups from solib.c
This removes a couple of cleanups from solib.c, replacing one with
std::string and another with unique_xmalloc_ptr.
2018-02-08 Tom Tromey <tom@tromey.com>
* solib.c (solib_find_1): Use std::string.
(solib_bfd_fopen): Use unique_xmalloc_ptr.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Use unique_xmalloc_ptr in build_id_to_debug_bfd
@ 2018-02-09 0:11 sergiodj+buildbot
2018-02-09 10:02 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-09 0:11 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 58ef3771fbbdf7fd891fceefdd4bf2720c6c1ee7 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 58ef3771fbbdf7fd891fceefdd4bf2720c6c1ee7
Use unique_xmalloc_ptr in build_id_to_debug_bfd
This changes build_id_to_debug_bfd to use a unique_xmalloc_ptr,
removing a cleanup.
2018-02-08 Tom Tromey <tom@tromey.com>
* build-id.c (build_id_to_debug_bfd): Use unique_xmalloc_ptr.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: Keep the unused _GLOBAL_OFFSET_TABLE_ for Solaris
@ 2018-02-09 0:47 sergiodj+buildbot
2018-02-09 16:14 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-09 0:47 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT dc11dea21281758b71113c03a8d8be92d175a46c ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: dc11dea21281758b71113c03a8d8be92d175a46c
x86: Keep the unused _GLOBAL_OFFSET_TABLE_ for Solaris
Solaris requires to keep _GLOBAL_OFFSET_TABLE_ even if it isn't used.
This patch detects Solaris target and keeps _GLOBAL_OFFSET_TABLE_ for
Solaris.
* elf32-i386.c (elf32_i386_copy_solaris_special_section_fields):
New prototype.
(elf_i386_link_setup_gnu_properties): Set need_global_offset_table
for Solaris.
* elf64-x86-64.c (elf64_x86_64_copy_solaris_special_section_fields):
New prototype.
(elf_x86_64_link_setup_gnu_properties): Set
need_global_offset_table for Solaris.
* elfxx-x86.c (_bfd_x86_elf_size_dynamic_sections): Keep the
unused _GLOBAL_OFFSET_TABLE_ for Solaris.
(_bfd_x86_elf_link_setup_gnu_properties): Copy
need_global_offset_table.
* elfxx-x86.h (elf_x86_link_hash_table): Add
need_global_offset_table.
(elf_x86_init_table): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: Set need_global_offset_table with info->output_bfd->xvec
@ 2018-02-09 1:04 sergiodj+buildbot
2018-02-09 17:57 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-09 1:04 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 15b23f3612ffa19bd7fb20ce07485cdb3c06162f ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 15b23f3612ffa19bd7fb20ce07485cdb3c06162f
x86: Set need_global_offset_table with info->output_bfd->xvec
* elf32-i386.c (elf32_i386_copy_solaris_special_section_fields):
Remove prototype.
(i386_elf32_sol2_vec): Declared.
(elf_i386_link_setup_gnu_properties): Set
need_global_offset_table with info->output_bfd->xvec.
* elf64-x86-64.c (elf64_x86_64_copy_solaris_special_section_fields):
Remove prototype.
(x86_64_elf64_sol2_vec): Declared.
(elf_x86_64_link_setup_gnu_properties): Set
need_global_offset_table with info->output_bfd->xvec.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb/NEWS: Clarify the news entry for "rbreak" in GDB 8.1
@ 2018-02-09 12:24 sergiodj+buildbot
2018-02-09 20:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-09 12:24 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 4e7253479941cd6d59a0c8efbb1113d3734b7f56 ***
Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 4e7253479941cd6d59a0c8efbb1113d3734b7f56
gdb/NEWS: Clarify the news entry for "rbreak" in GDB 8.1
gdb/ChangeLog:
* NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
Python function, rather than a new command.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Use std::string in execute_script_contents
@ 2018-02-09 13:19 sergiodj+buildbot
2018-02-10 1:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-09 13:19 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a37a2ae7080898244de86d136961de81fe28a434 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: a37a2ae7080898244de86d136961de81fe28a434
Use std::string in execute_script_contents
This changes execute_script_contents to use a std::string, allowing
the removal of a cleanup.
2018-02-09 Tom Tromey <tom@tromey.com>
* auto-load.c (execute_script_contents): Use std::string.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Use gdb::unique_xmalloc_ptr in auto_load_section_scripts
@ 2018-02-09 13:31 sergiodj+buildbot
2018-02-10 4:32 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-09 13:31 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 869e8290ea62f594d2472476303bb74604e9326b ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 869e8290ea62f594d2472476303bb74604e9326b
Use gdb::unique_xmalloc_ptr in auto_load_section_scripts
This changes auto_load_section_scripts to use gdb::unique_xmalloc_ptr,
allowing the removal of a cleanup.
2018-02-09 Tom Tromey <tom@tromey.com>
* auto-load.c (auto_load_section_scripts): Use
gdb::unique_xmalloc_ptr.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] common: add scoped_fd
@ 2018-02-09 13:44 sergiodj+buildbot
2018-02-10 6:25 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-09 13:44 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ea4a0888120dec61348cae460ffa08de663e2852 ***
Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: ea4a0888120dec61348cae460ffa08de663e2852
common: add scoped_fd
Add a simple helper to automatically close a file descriptor.
gdb/
* common/scoped_fd.h: New.
* unittests/scoped_fd-selftest.c: New.
* Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
unittests/scoped_fd-selftest.c.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] btrace: prepare for throwing exceptions when enabling btrace
@ 2018-02-09 14:22 sergiodj+buildbot
2018-02-10 11:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-09 14:22 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 5c3284c1ec2edc28b0697532fd094d93d5ecf31b ***
Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: 5c3284c1ec2edc28b0697532fd094d93d5ecf31b
btrace: prepare for throwing exceptions when enabling btrace
We indicate success or failure for enabling branch tracing via the pointer
return value. Depending on the type of error, errno may provide additional
information.
Prepare for using exceptions with more descriptive error messages by using smart
pointers and objects with automatic destruction to hold intermediate results.
gdb/
* nat/linux-btrace.c: Include scoped_fd.h and scoped_mmap.h.
(perf_event_pt_event_type): Use gdb_file_up.
(linux_enable_bts, linux_enable_pt): Use gdb::unique_xmalloc_ptr,
scoped_fd, and scoped_mmap.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] btrace, gdbserver: remove the to_supports_btrace target method
@ 2018-02-09 14:47 sergiodj+buildbot
2018-02-10 15:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-09 14:47 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT de6242d3075700ec4b73bdee583dc216f3a0b046 ***
Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: de6242d3075700ec4b73bdee583dc216f3a0b046
btrace, gdbserver: remove the to_supports_btrace target method
Remove the to_supports_btrace target method and instead rely on detecting errors
when trying to enable recording. This will also provide a suitable error
message explaining why recording is not possible.
For remote debugging, gdbserver will now always advertise branch tracing related
packets. When talking to an older GDB, this will cause GDB to try to enable
branch tracing and gdbserver to report a suitable error message every time.
An older gdbserver will not advertise branch tracing related packets if the
one-time check failed, so a newer GDB with this patch will fail to enable branch
tracing at remote_enable_btrace() rather than at btrace_enable(). The error
message is the same in both cases so there should be no user-visible change.
gdb/
* btrace.c (btrace_enable): Remove target_supports_btrace call.
* nat/linux-btrace.c (perf_event_pt_event_type): Move.
(kernel_supports_bts, kernel_supports_pt, linux_supports_bts)
(linux_supports_pt, linux_supports_btrace): Remove.
(linux_enable_bts): Call cpu_supports_bts.
* nat/linux-btrace.h (linux_supports_btrace): Remove.
* remote.c (remote_supports_btrace): Remove.
(init_remote_ops): Remove remote_supports_btrace.
* target-delegates.c: Regenerated.
* target.c (target_supports_btrace): Remove.
* target.h (target_ops) <to_supports_btrace>: Remove
(target_supports_btrace): Remove.
* x86-linux-nat.c (x86_linux_create_target): Remove
linux_supports_btrace.
gdbserver/
* linux-low.c (linux_target_ops): Remove linux_supports_btrace.
* nto-low.c (nto_target_ops): Remove NULL for supports_btrace.
* spu-low.c (spu_target_ops): Likewise.
* win32-low.c (win32_target_ops): Likewise.
* server.c (supported_btrace_packets): Report packets unconditionally.
* target.h (target_ops) <supports_btrace>: Remove.
(target_supports_btrace): Remove.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] btrace: check perf_event_paranoid
@ 2018-02-09 15:12 sergiodj+buildbot
2018-02-10 21:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-09 15:12 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 88711fbfeadd6e4663d986962dfcd7ab660c61d1 ***
Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: 88711fbfeadd6e4663d986962dfcd7ab660c61d1
btrace: check perf_event_paranoid
One recurring error on Debian systems is that the default perf_event_paranoid
setting disables the perf_event interface for user-space.
Check the current level and point the user to the file.
gdb/
* nat/linux-btrace.c (diagnose_perf_event_open_fail): New.
(linux_enable_pt, linux_enable_bts): Call
diagnose_perf_event_open_fail.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] btrace: reword error messages
@ 2018-02-09 15:25 sergiodj+buildbot
2018-02-10 22:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-09 15:25 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c4e126313219ecde255a644a2c74008831edff5a ***
Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: c4e126313219ecde255a644a2c74008831edff5a
btrace: reword error messages
Reword some btrace error messages to align with the format discussed in
https://sourceware.org/ml/gdb-patches/2018-02/msg00135.html.
gdb/
* remote.c (remote_btrace_maybe_reopen): Change error message.
* btrace.c (btrace_enable): Likewise.
(parse_xml_btrace): Likewise.
(parse_xml_btrace_conf): Likewise.
testsuite/
* lib/gdb.exp (skip_btrace_pt_tests): Update expected error message.
Fix test name.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] btrace, gdbserver: use exceptions to convey btrace enable/disable errors
@ 2018-02-09 16:32 sergiodj+buildbot
2018-02-10 13:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-09 16:32 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9ee23a853c18da3c83530c7957464bc6b6e9fb16 ***
Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: 9ee23a853c18da3c83530c7957464bc6b6e9fb16
btrace, gdbserver: use exceptions to convey btrace enable/disable errors
Change error reporting to use exceptions and be prepared to catch them in
gdbserver. We use the exception message in our error reply to GDB.
This may remove some detail from the error message in the native case since
errno is no longer printed. Later patches will improve that.
We're still using error strings on the RSP level. This patch does not affect
the interoperability of older/newer GDB/gdbserver.
gdbserver/
* server.c (handle_btrace_enable_bts, handle_btrace_enable_pt)
(handle_btrace_disable): Change return type to void. Use exceptions
to report errors.
(handle_btrace_general_set): Catch exception and copy message to
return message.
gdb/
* nat/linux-btrace.c (linux_enable_btrace): Throw exception if enabling
btrace failed.
* x86-linux-nat.c (x86_linux_enable_btrace): Catch btrace enabling
exception and use message in own exception.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Don't reference past the end of the vector
@ 2018-02-09 19:26 sergiodj+buildbot
2018-02-11 1:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-09 19:26 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9c3630e983df43e68006b526a92c2a9a2b64dfd9 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 9c3630e983df43e68006b526a92c2a9a2b64dfd9
Don't reference past the end of the vector
An earlier change made find_source_lines read:
end = &data[size];
However, since 'size' is the size of the vector, this seems fishy.
More obviously ok is to compute the end of the data directly:
end = data.data () + size;
2018-02-09 Tom Tromey <tom@tromey.com>
* source.c (find_source_lines): Don't reference past the end of
the vector.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix GOT relocation overflow on SPARC.
@ 2018-02-10 2:13 sergiodj+buildbot
2018-02-11 5:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-10 2:13 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a8735c82b8519d8b18915765ca983fc07154a17d ***
Author: Eric Botcazou <ebotcazou@gcc.gnu.org>
Branch: master
Commit: a8735c82b8519d8b18915765ca983fc07154a17d
Fix GOT relocation overflow on SPARC.
There are 2 failures left in the linker testsuite on SPARC64/Linux and
they are caused by 2 different issues leading to the same end effect:
the overflow of the relocation section for the GOT, i.e. the linker
generates too many dynamic relocations for the GOT wrt the size of the
relocation section, leading to memory corruption and missing relocations
in the final binary.
The first issue was introduced by:
https://sourceware.org/ml/binutils/2017-06/msg00368.html
which makes the linker generate more R_SPARC_RELATIVE relocations for
the GOT without adjusting the size of the relocation section. This is
fixed by (1) preventively adjusting this size in allocate_dynrelocs and
(2) generating R_SPARC_NONE if needed when R_SPARC_GOTDATA_OP is relaxed.
The second issue is that we generate a GOT relocation for an undefined
weak symbol with non-default visibility in a PIC binary without accounting
for that in the size of the relocation section. Since the address of the
symbol should resolve to 0 at run time, it is fixed by not generating the
relocation at all, i.e. leaving the GOT entry zeroed.
bfd/
* elfxx-sparc.c (UNDEFINED_WEAK_RESOLVED_TO_ZERO): Reorder conditions.
(sparc_elf_append_rela): Assert that there is enough room in section.
(_bfd_sparc_elf_copy_indirect_symbol): Fix formatting.
(_bfd_sparc_elf_adjust_dynamic_symbol): Minor tweak.
(allocate_dynrelocs): Remove outdated comments and reorder conditions.
For a symbol subject to a GOT relocation, reserve a slot in the
relocation section if the symbol isn't dynamic and we are in PIC mode.
(_bfd_sparc_elf_relocate_section) <R_SPARC_GOTDATA_OP>: If relocation
is relaxed and a slot was reserved, generate a R_SPARC_NONE relocation.
<R_SPARC_GOTDATA_OP_HIX22>: Adjust comments.
<R_SPARC_PC10>: Reorder conditions. Remove always-false assertion.
(_bfd_sparc_elf_finish_dynamic_symbol): Rename local_undefweak into
resolved_to_zero. Do not generate a dynamic GOT relocation for an
undefined weak symbol with non-default visibility. Remove superfluous
'else' and fix formatting.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] oops - actually remove the assignment this time: bfd/elf32-nds32.c:9693]: (warning) Redundant assignment of 'irel->r_addend' to itself.
@ 2018-02-12 12:16 sergiodj+buildbot
2018-02-12 14:02 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-12 12:16 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 6444b19b244d7c84537fc796005ef756917135ae ***
Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 6444b19b244d7c84537fc796005ef756917135ae
oops - actually remove the assignment this time: bfd/elf32-nds32.c:9693]: (warning) Redundant assignment of 'irel->r_addend' to itself.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix compile time warning: bfd/elf32-arc.c:1537]: (warning) Redundant assignment of 'rel->r_offset' to itself.
@ 2018-02-12 12:31 sergiodj+buildbot
2018-02-12 16:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-12 12:31 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 0b8683b7eb25cc150c7738ddc0d237f255e0fa70 ***
Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 0b8683b7eb25cc150c7738ddc0d237f255e0fa70
Fix compile time warning: bfd/elf32-arc.c:1537]: (warning) Redundant assignment of 'rel->r_offset' to itself.
* elf32-arc.c (elf_arc_relocate_section): Remove redundant
assignment.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb: Remove cleanup from dw2_do_instantiate_symtab
@ 2018-02-13 0:11 sergiodj+buildbot
2018-02-13 1:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-13 0:11 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b303c6f688c6cd1ffd986ae65ac3f2dc11f27b93 ***
Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: b303c6f688c6cd1ffd986ae65ac3f2dc11f27b93
gdb: Remove cleanup from dw2_do_instantiate_symtab
When running the test gdb.dwarf2/dw2-bad-parameter-type.exp under
valgrind, I see the following issue reported (on x86-64 Fedora):
(gdb) ptype f
==5203== Invalid read of size 1
==5203== at 0x6931FE: process_die_scope::~process_die_scope() (dwarf2read.c:10642)
==5203== by 0x66818F: process_die(die_info*, dwarf2_cu*) (dwarf2read.c:10664)
==5203== by 0x66A01F: read_file_scope(die_info*, dwarf2_cu*) (dwarf2read.c:11650)
==5203== by 0x667F2D: process_die(die_info*, dwarf2_cu*) (dwarf2read.c:10672)
==5203== by 0x6677B6: process_full_comp_unit(dwarf2_per_cu_data*, language) (dwarf2read.c:10445)
==5203== by 0x66657A: process_queue(dwarf2_per_objfile*) (dwarf2read.c:9945)
==5203== by 0x6559B4: dw2_do_instantiate_symtab(dwarf2_per_cu_data*) (dwarf2read.c:3163)
==5203== by 0x66683D: psymtab_to_symtab_1(partial_symtab*) (dwarf2read.c:10034)
==5203== by 0x66622A: dwarf2_read_symtab(partial_symtab*, objfile*) (dwarf2read.c:9811)
==5203== by 0x787984: psymtab_to_symtab(objfile*, partial_symtab*) (psymtab.c:792)
==5203== by 0x786E3E: psym_lookup_symbol(objfile*, int, char const*, domain_enum_tag) (psymtab.c:522)
==5203== by 0x804BD0: lookup_symbol_via_quick_fns(objfile*, int, char const*, domain_enum_tag) (symtab.c:2383)
==5203== Address 0x147ed063 is 291 bytes inside a block of size 4,064 free'd
==5203== at 0x4C2CD5A: free (vg_replace_malloc.c:530)
==5203== by 0x444415: void xfree<void>(void*) (common-utils.h:60)
==5203== by 0x9DA8C2: call_freefun (obstack.c:103)
==5203== by 0x9DAD35: _obstack_free (obstack.c:280)
==5203== by 0x44464C: auto_obstack::~auto_obstack() (gdb_obstack.h:73)
==5203== by 0x68AFB0: dwarf2_cu::~dwarf2_cu() (dwarf2read.c:25080)
==5203== by 0x68B204: free_one_cached_comp_unit(dwarf2_per_cu_data*) (dwarf2read.c:25174)
==5203== by 0x66668C: dwarf2_release_queue(void*) (dwarf2read.c:9982)
==5203== by 0x563A4C: do_my_cleanups(cleanup**, cleanup*) (cleanups.c:154)
==5203== by 0x563AA7: do_cleanups(cleanup*) (cleanups.c:176)
==5203== by 0x5646CE: throw_exception_cxx(gdb_exception) (common-exceptions.c:289)
==5203== by 0x5647B7: throw_exception(gdb_exception) (common-exceptions.c:317)
==5203== Block was alloc'd at
==5203== at 0x4C2BBAD: malloc (vg_replace_malloc.c:299)
==5203== by 0x564BE8: xmalloc (common-utils.c:44)
==5203== by 0x9DA872: call_chunkfun (obstack.c:94)
==5203== by 0x9DA935: _obstack_begin_worker (obstack.c:141)
==5203== by 0x9DAA3C: _obstack_begin (obstack.c:164)
==5203== by 0x4445E0: auto_obstack::auto_obstack() (gdb_obstack.h:70)
==5203== by 0x68AE07: dwarf2_cu::dwarf2_cu(dwarf2_per_cu_data*) (dwarf2read.c:25073)
==5203== by 0x661A8A: init_cutu_and_read_dies(dwarf2_per_cu_data*, abbrev_table*, int, int, void (*)(die_reader_specs const*, unsigned char const*, die_info*, int, void*), void*) (dwarf2read.c:7869)
==5203== by 0x666A29: load_full_comp_unit(dwarf2_per_cu_data*, language) (dwarf2read.c:10108)
==5203== by 0x655847: load_cu(dwarf2_per_cu_data*) (dwarf2read.c:3120)
==5203== by 0x655928: dw2_do_instantiate_symtab(dwarf2_per_cu_data*) (dwarf2read.c:3148)
==5203== by 0x66683D: psymtab_to_symtab_1(partial_symtab*) (dwarf2read.c:10034)
There's actually a series of three issues reported, but it turns out
they're all related, so we can consider on the first one.
The invalid read is triggered from a destructor which is being invoked
as part of a stack unwind after throwing an error. At the time the
error is thrown, the stack looks like this:
#0 0x00000000009f4ecd in __cxa_throw ()
#1 0x0000000000564761 in throw_exception_cxx (exception=...) at ../../src/gdb/common/common-exceptions.c:303
#2 0x00000000005647b8 in throw_exception (exception=...) at ../../src/gdb/common/common-exceptions.c:317
#3 0x00000000005648ff in throw_it(return_reason, errors, const char *, typedef __va_list_tag __va_list_tag *) (reason=RETURN_ERROR,
error=GENERIC_ERROR, fmt=0xb33020 "Dwarf Error: Cannot find DIE at 0x%x referenced from DIE at 0x%x [in module %s]",
ap=0x7fff387f2d68) at ../../src/gdb/common/common-exceptions.c:373
#4 0x0000000000564929 in throw_verror (error=GENERIC_ERROR,
fmt=0xb33020 "Dwarf Error: Cannot find DIE at 0x%x referenced from DIE at 0x%x [in module %s]", ap=0x7fff387f2d68)
at ../../src/gdb/common/common-exceptions.c:379
#5 0x0000000000867be4 in verror (string=0xb33020 "Dwarf Error: Cannot find DIE at 0x%x referenced from DIE at 0x%x [in module %s]",
args=0x7fff387f2d68) at ../../src/gdb/utils.c:251
#6 0x000000000056879d in error (fmt=0xb33020 "Dwarf Error: Cannot find DIE at 0x%x referenced from DIE at 0x%x [in module %s]")
at ../../src/gdb/common/errors.c:43
#7 0x0000000000686875 in follow_die_ref (src_die=0x30bc8a0, attr=0x30bc8c8, ref_cu=0x7fff387f2ed0) at ../../src/gdb/dwarf2read.c:22969
#8 0x00000000006844cd in lookup_die_type (die=0x30bc8a0, attr=0x30bc8c8, cu=0x30bc5d0) at ../../src/gdb/dwarf2read.c:21976
#9 0x0000000000683f27 in die_type (die=0x30bc8a0, cu=0x30bc5d0) at ../../src/gdb/dwarf2read.c:21832
#10 0x0000000000679b39 in read_subroutine_type (die=0x30bc830, cu=0x30bc5d0) at ../../src/gdb/dwarf2read.c:17343
#11 0x00000000006845fb in read_type_die_1 (die=0x30bc830, cu=0x30bc5d0) at ../../src/gdb/dwarf2read.c:22035
#12 0x0000000000684576 in read_type_die (die=0x30bc830, cu=0x30bc5d0) at ../../src/gdb/dwarf2read.c:22010
#13 0x000000000067003f in read_func_scope (die=0x30bc830, cu=0x30bc5d0) at ../../src/gdb/dwarf2read.c:13822
#14 0x0000000000667f5e in process_die (die=0x30bc830, cu=0x30bc5d0) at ../../src/gdb/dwarf2read.c:10679
#15 0x000000000066a020 in read_file_scope (die=0x30bc720, cu=0x30bc5d0) at ../../src/gdb/dwarf2read.c:11650
#16 0x0000000000667f2e in process_die (die=0x30bc720, cu=0x30bc5d0) at ../../src/gdb/dwarf2read.c:10672
#17 0x00000000006677b7 in process_full_comp_unit (per_cu=0x3089b80, pretend_language=language_minimal)
at ../../src/gdb/dwarf2read.c:10445
#18 0x000000000066657b in process_queue (dwarf2_per_objfile=0x30897d0) at ../../src/gdb/dwarf2read.c:9945
#19 0x00000000006559b5 in dw2_do_instantiate_symtab (per_cu=0x3089b80) at ../../src/gdb/dwarf2read.c:3163
#20 0x000000000066683e in psymtab_to_symtab_1 (pst=0x3089bd0) at ../../src/gdb/dwarf2read.c:10034
#21 0x000000000066622b in dwarf2_read_symtab (self=0x3089bd0, objfile=0x3073f40) at ../../src/gdb/dwarf2read.c:9811
#22 0x0000000000787985 in psymtab_to_symtab (objfile=0x3073f40, pst=0x3089bd0) at ../../src/gdb/psymtab.c:792
#23 0x0000000000786e3f in psym_lookup_symbol (objfile=0x3073f40, block_index=1, name=0x30b2e30 "f", domain=VAR_DOMAIN)
at ../../src/gdb/psymtab.c:522
#24 0x0000000000804bd1 in lookup_symbol_via_quick_fns (objfile=0x3073f40, block_index=1, name=0x30b2e30 "f", domain=VAR_DOMAIN)
at ../../src/gdb/symtab.c:2383
#25 0x0000000000804fe4 in lookup_symbol_in_objfile (objfile=0x3073f40, block_index=1, name=0x30b2e30 "f", domain=VAR_DOMAIN)
at ../../src/gdb/symtab.c:2558
#26 0x0000000000805125 in lookup_static_symbol (name=0x30b2e30 "f", domain=VAR_DOMAIN) at ../../src/gdb/symtab.c:2595
#27 0x0000000000804357 in lookup_symbol_aux (name=0x30b2e30 "f", match_type=symbol_name_match_type::FULL, block=0x0,
domain=VAR_DOMAIN, language=language_c, is_a_field_of_this=0x0) at ../../src/gdb/symtab.c:2105
#28 0x0000000000803ad9 in lookup_symbol_in_language (name=0x30b2e30 "f", block=0x0, domain=VAR_DOMAIN, lang=language_c,
is_a_field_of_this=0x0) at ../../src/gdb/symtab.c:1887
#29 0x0000000000803b53 in lookup_symbol (name=0x30b2e30 "f", block=0x0, domain=VAR_DOMAIN, is_a_field_of_this=0x0)
at ../../src/gdb/symtab.c:1899
#30 0x000000000053b246 in classify_name (par_state=0x7fff387f6090, block=0x0, is_quoted_name=false, is_after_structop=false)
at ../../src/gdb/c-exp.y:2879
#31 0x000000000053b7e9 in c_yylex () at ../../src/gdb/c-exp.y:3083
#32 0x000000000053414a in c_yyparse () at c-exp.c:1903
#33 0x000000000053c2e7 in c_parse (par_state=0x7fff387f6090) at ../../src/gdb/c-exp.y:3255
#34 0x0000000000774a02 in parse_exp_in_context_1 (stringptr=0x7fff387f61c0, pc=0, block=0x0, comma=0, void_context_p=0, out_subexp=0x0)
at ../../src/gdb/parse.c:1213
#35 0x000000000077476a in parse_exp_in_context (stringptr=0x7fff387f61c0, pc=0, block=0x0, comma=0, void_context_p=0, out_subexp=0x0)
at ../../src/gdb/parse.c:1115
#36 0x0000000000774714 in parse_exp_1 (stringptr=0x7fff387f61c0, pc=0, block=0x0, comma=0) at ../../src/gdb/parse.c:1106
#37 0x0000000000774c53 in parse_expression (string=0x27ff996 "f") at ../../src/gdb/parse.c:1253
#38 0x0000000000861dc4 in whatis_exp (exp=0x27ff996 "f", show=1) at ../../src/gdb/typeprint.c:472
#39 0x00000000008620d8 in ptype_command (type_name=0x27ff996 "f", from_tty=1) at ../../src/gdb/typeprint.c:561
#40 0x000000000047430b in do_const_cfunc (c=0x3012010, args=0x27ff996 "f", from_tty=1) at ../../src/gdb/cli/cli-decode.c:106
#41 0x000000000047715e in cmd_func (cmd=0x3012010, args=0x27ff996 "f", from_tty=1) at ../../src/gdb/cli/cli-decode.c:1886
#42 0x00000000008431bb in execute_command (p=0x27ff996 "f", from_tty=1) at ../../src/gdb/top.c:630
#43 0x00000000006bf946 in command_handler (command=0x27ff990 "ptype f") at ../../src/gdb/event-top.c:583
#44 0x00000000006bfd12 in command_line_handler (rl=0x30bb3a0 "\240\305\v\003") at ../../src/gdb/event-top.c:774
The problem is that in `process_die` (frames 14 and 16) we create a
`process_die_scope` object, that takes a copy of the `struct
dwarf2_cu *` passed into the frame. The destructor of the
`process_die_scope` dereferences the stored pointer. This wouldn't be
an issue, except...
... in dw2_do_instantiate_symtab (frame 19) a clean up was registered that
clears the dwarf2_queue in case of an error. Part of this clean up
involves deleting the `struct dwarf2_cu`s referenced from the queue..
The problem then, is that cleanups are processed at the site of the
throw, while, class destructors are invoked as we unwind their frame.
The result is that we process the frame 19 cleanup (and delete the
struct dwarf2_cu) before we process the destructors in frames 14 and 16.
When we do get back to frames 14 and 16 the objects being references
have already been deleted.
The solution is to remove the cleanup from dw2_do_instantiate_symtab, and
instead use a destructor to release the dwarf2_queue instead. With this
patch in place, the valgrind errors are now resolved.
gdb/ChangeLog:
* dwarf2read.c (dwarf2_release_queue): Delete function, move body
into...
(class dwarf2_queue_guard): ...the destructor of this new class.
(dw2_do_instantiate_symtab): Create instance of the new class
dwarf2_queue_guard, remove cleanup.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix prefix of maint set/show per-command
@ 2018-02-13 6:47 sergiodj+buildbot
2018-02-13 7:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-13 6:47 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 387cd15b93fdca3a66bbda427c4e1d9340bfb532 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 387cd15b93fdca3a66bbda427c4e1d9340bfb532
Fix prefix of maint set/show per-command
I noticed this:
(gdb) apropos per-command
maintenance set per-command -- Per-command statistics settings
set per-command space -- Set whether to display per-command space usage
set per-command symtab -- Set whether to display per-command symtab statistics
set per-command time -- Set whether to display per-command execution time
maintenance show per-command -- Show per-command statistics settings
show per-command space -- Show whether to display per-command space usage
show per-command symtab -- Show whether to display per-command symtab statistics
show per-command time -- Show whether to display per-command execution time
The subcommands of "maintenance set per-command" are missing the
maintenance keyword. This is because that command is registered with
the wrong prefix. This patch fixes that.
gdb/ChangeLog:
* maint.c (_initialize_maint_cmds): Fix prefix of maint set/show
per-command.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR22829, objcopy/strip removes PT_GNU_RELRO from lld binaries
@ 2018-02-13 9:23 sergiodj+buildbot
2018-02-13 10:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-13 9:23 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f2731e0c374e5323ce4cdae2bcc7b7fe22da1a6f ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: f2731e0c374e5323ce4cdae2bcc7b7fe22da1a6f
PR22829, objcopy/strip removes PT_GNU_RELRO from lld binaries
lld lays out the relro segment differently to GNU ld, not bothering to
include the first few bytes of .got.plt and padding out to a page at
the end of the segment. This patch teaches binutils to recognize the
different (and somewhat inferior) layout as valid.
bfd/
PR 22829
* elf.c (assign_file_positions_for_non_load_sections): Rewrite
PT_GNU_RELRO setup.
ld/
* testsuite/ld-x86-64/pr14207.d: Adjust relro p_filesz.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR22836, "-r -s" doesn't work with -g3 using GCC 7
@ 2018-02-13 12:41 sergiodj+buildbot
2018-02-13 13:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-13 12:41 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 6e5e9d58c1eeef5677c90886578a895cb8c164c5 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 6e5e9d58c1eeef5677c90886578a895cb8c164c5
PR22836, "-r -s" doesn't work with -g3 using GCC 7
This fixes the case where all of a group is removed with ld -r, the
situation in the PR, and failures where part of a group is removed
that contain relocs.
bfd/
PR 22836
* elf.c (_bfd_elf_fixup_group_sections): Account for removed
relocation sections. If size reduces to just the flag word,
remove that too and mark with SEC_EXCLUDE.
* elflink.c (bfd_elf_final_link): Strip empty group sections.
binutils/
* testsuite/binutils-all/group-7.s,
* testsuite/binutils-all/group-7a.d,
* testsuite/binutils-all/group-7b.d,
* testsuite/binutils-all/group-7c.d: New tests.
* testsuite/binutils-all/objcopy.exp: Run them.
ld/
* testsuite/ld-elf/pr22836-2.d,
* testsuite/ld-elf/pr22836-2.s: New test.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] WebAssembly: Disable subdirectory configuration for unsupported LD
@ 2018-02-13 13:31 sergiodj+buildbot
2018-02-13 18:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-13 13:31 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b29d26411c62fef6b1401aff4f2c6a157053de4d ***
Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: b29d26411c62fef6b1401aff4f2c6a157053de4d
WebAssembly: Disable subdirectory configuration for unsupported LD
Remove an LD subdirectory configuration error:
*** ld does not support target wasm32-unknown-none
*** see ld/configure.tgt for supported targets
make[1]: *** [configure-ld] Error 1
which prevents binutils for the WebAssembly target from being built
unless an explicit `--disable-ld' configuration option has been given.
Users must not have to disable features selected by default to get a
working configuration.
/
* configure.ac <wasm32-*-*> (noconfigdirs): Add `ld'.
* configure: Regenerate.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix compile time warning messages from gcc version 8 about cast between incompatible function types.
@ 2018-02-13 13:43 sergiodj+buildbot
2018-02-13 20:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-13 13:43 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 68d206766637a041bbbeb89c8a1bfdd76317e192 ***
Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 68d206766637a041bbbeb89c8a1bfdd76317e192
Fix compile time warning messages from gcc version 8 about cast between incompatible function types.
PR 22823
bfd Fix compile time warnings generated by gcc version 8.
* libbfd-in.h: Remove extraneous text from prototypes.
Add prototypes for bfd_false_any, bfd_true_any,
bfd_nullvoidptr_any, bfd_0_any, bfd_0u_any, bfd_0l_any,
bfd_n1_any, bfd_void_any.
(_bfd_generic_bfd_copy_private_bfd_data): Use vararg based dummy
function.
(_bfd_generic_bfd_merge_private_bfd_data): Likewise.
(_bfd_generic_bfd_set_private_flags): Likewise.
(_bfd_generic_bfd_copy_private_section_data): Likewise.
(_bfd_generic_bfd_copy_private_symbol_data): Likewise.
(_bfd_generic_bfd_copy_private_header_data): Likewise.
(_bfd_generic_bfd_print_private_bfd_data): Likewise.
(_bfd_noarchive_construct_extended_name_table): Likewise.
(_bfd_noarchive_truncate_arname): Likewise.
(_bfd_noarchive_write_ar_hdr): Likewise.
(_bfd_noarchive_get_elt_at_index): Likewise.
(_bfd_nosymbols_canonicalize_symtab): Likewise.
(_bfd_nosymbols_print_symbol): Likewise.
(_bfd_nosymbols_get_symbol_info): Likewise.
(_bfd_nosymbols_get_symbol_version_string): Likewise.
(_bfd_nosymbols_bfd_is_local_label_name): Likewise.
(_bfd_nosymbols_bfd_is_target_special_symbol): Likewise.
(_bfd_nosymbols_get_lineno): Likewise.
(_bfd_nosymbols_find_nearest_line): Likewise.
(_bfd_nosymbols_find_line): Likewise.
(_bfd_nosymbols_find_inliner_info): Likewise.
(_bfd_nosymbols_bfd_make_debug_symbol): Likewise.
(_bfd_nosymbols_read_minisymbols): Likewise.
(_bfd_nosymbols_minisymbol_to_symbol): Likewise.
(_bfd_norelocs_bfd_reloc_type_lookup): Likewise.
(_bfd_norelocs_bfd_reloc_name_lookup): Likewise.
(_bfd_nowrite_set_arch_mach): Likewise.
(_bfd_nowrite_set_section_contents): Likewise.
(_bfd_nolink_sizeof_headers): Likewise.
(_bfd_nolink_bfd_get_relocated_section_contents): Likewise.
(_bfd_nolink_bfd_relax_section): Likewise.
(_bfd_nolink_bfd_gc_sections): Likewise.
(_bfd_nolink_bfd_lookup_section_flags): Likewise.
(_bfd_nolink_bfd_merge_sections): Likewise.
(_bfd_nolink_bfd_is_group_section): Likewise.
(_bfd_nolink_bfd_discard_group): Likewise.
(_bfd_nolink_bfd_link_hash_table_create): Likewise.
(_bfd_nolink_bfd_link_add_symbols): Likewise.
(_bfd_nolink_bfd_link_just_syms): Likewise.
(_bfd_nolink_bfd_copy_link_hash_symbol_type): Likewise.
(_bfd_nolink_bfd_final_link): Likewise.
(_bfd_nolink_bfd_link_split_section): Likewise.
(_bfd_nolink_section_already_linked): Likewise.
(_bfd_nolink_bfd_define_common_symbol): Likewise.
(_bfd_nolink_bfd_define_start_stop): Likewise.
(_bfd_nodynamic_canonicalize_dynamic_symtab): Likewise.
(_bfd_nodynamic_get_synthetic_symtab): Likewise.
(_bfd_nodynamic_get_dynamic_reloc_upper_bound _bfd_): Likewise.
(_bfd_nodynamic_canonicalize_dynamic_reloc): Likewise.
* libbfd.c (bfd_false_any): New function. Like bfd_false but
accepts one or more arguments.
(bfd_true_any): Likewise.
(bfd_nullvoidptr_any): Likewise.
(bfd_0_any): Likewise.
(bfd_0u_any): Likewise.
(bfd_0l_any): Likewise.
(_bfd_n1_any): Likewise.
(bfd_void_any): Likewise.
* libbfd.h (extern): Regenerate
* aout-target.h (MY_bfd_is_target_special_symbol): Use vararg
based dummy function.
* aout-tic30.c (tic30_aout_set_arch_mach): Likewise.
* binary.c (binary_get_symbol_info): Likewise.
* coff-alpha.c (alpha_ecoff_backend_data): Likewise.
* coff-mips.c (mips_ecoff_backend_data): Likewise.
* coffcode.h (coff_set_alignment_hook): Likewise.
(symname_in_debug_hook): Likewise.
(bfd_coff_backend_data bigobj_swap_table): Likewise.
* elf-m10300.c (elf_backend_omit_section_dynsym): Likewise.
* elf32-cr16.c (elf_backend_omit_section_dynsym): Likewise.
* elf32-lm32.c (elf_backend_omit_section_dynsym): Likewise.
* elf32-m32r.c (elf_backend_omit_section_dynsym): Likewise.
* elf32-metag.c (elf_backend_omit_section_dynsym): Likewise.
* elf32-score.c (elf_backend_omit_section_dynsym): Likewise.
* elf32-score7.c (elf_backend_omit_section_dynsym): Likewise.
* elf32-xstormy16.c (elf_backend_omit_section_dynsym): Likewise.
* elf32-xtensa.c (elf_backend_omit_section_dynsym): Likewise.
* elf64-alpha.c (elf_backend_omit_section_dynsym): Likewise.
* elf64-hppa.c (elf_backend_omit_section_dynsym): Likewise.
* elf64-ia64-vms.c (elf_backend_omit_section_dynsym): Likewise.
* elf64-mmix.c (elf_backend_omit_section_dynsym): Likewise.
* elf64-sh64.c (elf_backend_omit_section_dynsym): Likewise.
* elfnn-ia64.c (elf_backend_omit_section_dynsym): Likewise.
* elfxx-target.h (bfd_elfNN_bfd_debug_info_accumulate): Likewise.
(bfd_elfNN_bfd_make_debug_symbol): Likewise.
(bfd_elfNN_bfd_merge_private_bfd_data): Likewise.
(bfd_elfNN_bfd_set_private_flags): Likewise.
(bfd_elfNN_bfd_is_target_special_symbol): Likewise.
(elf_backend_init_index_section): Likewise.
(elf_backend_allow_non_load_phdr): Likewise.
* elfxx-x86.h (elf_backend_omit_section_dynsym): Likewise.
* i386msdos.c (msdos_bfd_is_target_special_symbol): Likewise.
* ieee.c (ieee_construct_extended_name_table): Likewise.
(ieee_write_armap): Likewise.
(ieee_write_ar_hdr): Likewise.
(ieee_bfd_is_target_special_symbol): Likewise.
* ihex.c (ihex_canonicalize_symtab): Likewise.
(ihex_bfd_is_target_special_symbol): Likewise.
* libaout.h (aout_32_bfd_is_target_special_symbol): Likewise.
* libecoff.h (_bfd_ecoff_bfd_is_target_special_symbol): Likewise.
(_bfd_ecoff_set_alignment_hook): Likewise.
* mach-o-target.c (bfd_mach_o_bfd_is_target_special_symbol): Likewise.
* mmo.c (mmo_bfd_is_target_special_symbol): Likewise.
* nlm-target.h (nlm_bfd_is_target_special_symbol): Likewise.
* oasys.c (oasys_construct_extended_name_table): Likewise.
(oasys_write_armap): Likewise.
(oasys_write_ar_hdr): Likewise.
(oasys_bfd_is_target_special_symbol): Likewise.
* pef.c (bfd_pef_bfd_is_target_special_symbol): Likewise.
* plugin.c (bfd_plugin_bfd_is_target_special_symbol): Likewise.
* ppcboot.c (ppcboot_bfd_is_target_special_symbol): Likewise.
* som.c (som_bfd_is_target_special_symbol): Likewise.
* srec.c (srec_bfd_is_target_special_symbol): Likewise.
* tekhex.c (tekhex_bfd_is_target_special_symbol): Likewise.
* verilog.c (verilog_bfd_is_target_special_symbol): Likewise.
* versados.c (versados_bfd_is_target_special_symbol): Likewise.
(versados_bfd_reloc_name_lookup): Likewise.
* vms-alpha.c (vms_bfd_is_target_special_symbol): Likewise.
(vms_bfd_define_start_stop): Likewise.
(alpha_vms_bfd_is_target_special_symbol): Likewise.
* wasm-module.c (wasm_bfd_is_target_special_symbol): Likewise.
* xsym.c (bfd_sym_bfd_is_target_special_symbol): Likewise.
* elf32-arc.c (get_replace_function): Assign replacement function
to func pointer.
* elf32-i370.c (i370_noop): Update prototype.
gas * config/obj-elf.c (elf_pseudo_table): Remove now redundant
casts.
(obj_elf_vtable_inherit): Rename to obj_elf_get_vtable_inherit.
(obj_elf_vtable_inherit): New stub function that calls
obj_elf_get_vtable_inherit.
(obj_elf_vtable_entry): Rename to obj_elf_get_vtable_entry.
(obj_elf_vtable_entry): New stub function that calls
obj_elf_get_vtable_entry.
* config/obj-elf.h (obj_elf_vtable_inherit): Update prototype.
(obj_elf_vtable_entry) Likewise.
(obj_elf_get_vtable_inherit) Likewise.
(obj_elf_get_vtable_entry) Likewise.
* config/tc-arm.c (md_pseudo_table): Remove now redundant cast.
* config/tc-i386c (md_pseudo_table): Likewise.
* config/tc-hppa.c (pa_vtable_entry): Call
obj_elf_get_vtable_entry.
(pa_vtable_inherit): Call obj_elf_get_vtable_inherit.
* config/tc-mips.c (s_mips_file): Replace call to dwarf2_get_file
with call to dwarf2_get_filename.
* dwarf2dbg.c (dwarf2_directive_file): Rename to
dwarf2_directive_filename.
(dwarf2_directive_file): New stub function that calls
dwarf2_directive_filename.
* dwarf2dbg.h: Prototype dwarf2_directive_filename.
opcodes * metag-dis.c (print_fmmov): Double buffer size to avoid warning
about truncation of printing.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix typo in Russian translation for the bfd/ sub-directory which could lead to a seg-fault in the linker.
@ 2018-02-13 15:41 sergiodj+buildbot
2018-02-13 22:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-13 15:41 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 80c96350467f23a54546580b3e2b67a65ec65b66 ***
Author: Sergei Trofimovich <slyfox@inbox.ru>
Branch: master
Commit: 80c96350467f23a54546580b3e2b67a65ec65b66
Fix typo in Russian translation for the bfd/ sub-directory which could lead to a seg-fault in the linker.
PR 22828
* po/ru.po: Fix typo in Russian translation.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86-64: Generate branch with PLT32 relocation
@ 2018-02-13 15:51 sergiodj+buildbot
2018-02-13 23:55 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-13 15:51 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT bd7ab16b4537788ad53521c45469a1bdae84ad4a ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: bd7ab16b4537788ad53521c45469a1bdae84ad4a
x86-64: Generate branch with PLT32 relocation
Since there is no need to prepare for PLT branch on x86-64, generate
R_X86_64_PLT32, instead of R_X86_64_PC32, if possible, which can be
used as a marker for 32-bit PC-relative branches.
To compile Linux kernel, this patch:
From: "H.J. Lu" <hjl.tools@gmail.com>
Subject: [PATCH] x86: Treat R_X86_64_PLT32 as R_X86_64_PC32
On i386, there are 2 types of PLTs, PIC and non-PIC. PIE and shared
objects must use PIC PLT. To use PIC PLT, you need to load
_GLOBAL_OFFSET_TABLE_ into EBX first. There is no need for that on
x86-64 since x86-64 uses PC-relative PLT.
On x86-64, for 32-bit PC-relative branches, we can generate PLT32
relocation, instead of PC32 relocation, which can also be used as
a marker for 32-bit PC-relative branches. Linker can always reduce
PLT32 relocation to PC32 if function is defined locally. Local
functions should use PC32 relocation. As far as Linux kernel is
concerned, R_X86_64_PLT32 can be treated the same as R_X86_64_PC32
since Linux kernel doesn't use PLT.
is needed. It is available on hjl/plt32/master branch at
https://github.com/hjl-tools/linux
bfd/
PR gas/22791
* elf64-x86-64.c (is_32bit_relative_branch): Removed.
(elf_x86_64_relocate_section): Check PIC relocations in PIE.
Remove is_32bit_relative_branch usage. Disallow PC32 reloc
against protected function in shared object.
gas/
PR gas/22791
* config/tc-i386.c (need_plt32_p): New function.
(output_jump): Generate BFD_RELOC_X86_64_PLT32 if possible.
(md_estimate_size_before_relax): Likewise.
* testsuite/gas/i386/reloc64.d: Updated.
* testsuite/gas/i386/x86-64-jump.d: Likewise.
* testsuite/gas/i386/x86-64-mpx-branch-1.d: Likewise.
* testsuite/gas/i386/x86-64-mpx-branch-2.d: Likewise.
* testsuite/gas/i386/x86-64-relax-2.d: Likewise.
* testsuite/gas/i386/x86-64-relax-3.d: Likewise.
* testsuite/gas/i386/ilp32/reloc64.d: Likewise.
* testsuite/gas/i386/ilp32/x86-64-branch.d: Likewise.
ld/
PR gas/22791
* testsuite/ld-x86-64/mpx1c.rd: Updated.
* testsuite/ld-x86-64/pr22791-1.err: New file.
* testsuite/ld-x86-64/pr22791-1a.c: Likewise.
* testsuite/ld-x86-64/pr22791-1b.s: Likewise.
* testsuite/ld-x86-64/pr22791-2.rd: Likewise.
* testsuite/ld-x86-64/pr22791-2a.s: Likewise.
* testsuite/ld-x86-64/pr22791-2b.c: Likewise.
* testsuite/ld-x86-64/pr22791-2c.s: Likewise.
* testsuite/ld-x86-64/x86-64.exp: Run PR ld/22791 tests.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Use enum flags for flags passed to openp
@ 2018-02-13 17:36 sergiodj+buildbot
2018-02-14 1:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-13 17:36 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 24b9144d4ba83d37751786b08b48ad62fb7aef26 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 24b9144d4ba83d37751786b08b48ad62fb7aef26
Use enum flags for flags passed to openp
gdb/ChangeLog:
* defs.h (enum openp_flags): New enum.
(OPF_TRY_CWD_FIRST, OPF_SEARCH_IN_PATH, OPF_RETURN_REALPATH):
Move to enum openp_flags.
(openp_flags): New enum flags.
(openp): Change parameter type to openp_flags.
* source.c (openp): Change parameter type to openp_flags.
* cli/cli-cmds.c (find_and_open_script): Use openp_flags.
* dwarf2read.c (try_open_dwop_file): Use openp_flags.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: Properly check building shared library
@ 2018-02-13 22:52 sergiodj+buildbot
2018-02-14 3:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-13 22:52 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 1031c264fd23641111df1e12a35d0a8f7e82fb80 ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 1031c264fd23641111df1e12a35d0a8f7e82fb80
x86: Properly check building shared library
If a symbol is not defined in a regular file, and we are not generating
a shared library, then set the symbol to its location in the .plt. This
is required to make function pointers compare as equal between the normal
executable and the shared library.
* elfxx-x86.c (elf_x86_allocate_dynrelocs): Check bfd_link_dll,
instead of bfd_link_pic, for building shared library.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove references to ada_name_for_lookup (deleted)
@ 2018-02-14 11:04 sergiodj+buildbot
2018-02-14 13:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-14 11:04 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f98b2e334fcca666afaee3c6546b9fc91a4963d4 ***
Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: f98b2e334fcca666afaee3c6546b9fc91a4963d4
Remove references to ada_name_for_lookup (deleted)
This function was deleted on 2017-11-08, but its declaration and
a reference to it in a comment was left behind. This patch just
removes those.
gdb/ChangeLog:
* ada-lang.c (name_match_type_from_name): Remove reference to
ada_name_for_lookup in function's documentation.
* ada-lang.h (ada_name_for_lookup): Delete declaration.
Tested by rebuilding GDB.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86-64: Use PLT address for PC-relative reloc
@ 2018-02-14 12:04 sergiodj+buildbot
2018-02-14 14:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-14 12:04 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 451875b4f976a527395e9303224c7881b65e12ed ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 451875b4f976a527395e9303224c7881b65e12ed
x86-64: Use PLT address for PC-relative reloc
Since PLT in PDE and PC-relative PLT in PIE can be used as function
address, there is no need for dynamic PC-relative relocation against
a dynamic function definition in PIE. Linker should resolve PC-relative
reference to its PLT address.
NB: i386 has non-PIC PLT and PIC PLT. Only non-PIC PLT in PDE can
be used as function address. PIC PLT in PIE can't be used as
function address.
bfd/
PR ld/22842
* elf32-i386.c (elf_i386_check_relocs): Pass FALSE for non
PC-relative PLT to NEED_DYNAMIC_RELOCATION_P.
* elf64-x86-64.c (elf_x86_64_check_relocs): Create PLT for
R_X86_64_PC32 reloc against dynamic function in data section.
Pass TRUE for PC-relative PLT to NEED_DYNAMIC_RELOCATION_P.
(elf_x86_64_relocate_section): Use PLT for R_X86_64_PC32 reloc
against dynamic function in data section.
* elfxx-x86.c (elf_x86_allocate_dynrelocs): Use PLT in PIE as
function address only if pcrel_plt is true.
(_bfd_x86_elf_link_hash_table_create): Set pcrel_plt.
* elfxx-x86.h (NEED_DYNAMIC_RELOCATION_P): Add PCREL_PLT for
PC-relative PLT. If PLT is PC-relative, don't generate dynamic
PC-relative relocation against a function definition in data
secton in PIE. Remove the obsolete comments.
(elf_x86_link_hash_table): Add pcrel_plt.
ld/
PR ld/22842
* testsuite/ld-i386/i386.exp: Run PR ld/22842 tests.
* testsuite/ld-x86-64/x86-64.exp: Likewise.
* testsuite/ld-i386/pr22842a.c: New file.
* testsuite/ld-i386/pr22842b.S: Likewise.
* testsuite/ld-x86-64/pr22842a.c: Likewise.
* testsuite/ld-x86-64/pr22842a.rd: Likewise.
* testsuite/ld-x86-64/pr22842b.S: Likewise.
* testsuite/ld-x86-64/pr22842b.rd: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix compilation of the BFD sub-directory with a gcc v8 compiler by adding extra casts.
@ 2018-02-14 15:16 sergiodj+buildbot
2018-02-14 17:13 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-14 15:16 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 12ef3f5a7c5a6b89964842fd3da047b8d07dec91 ***
Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 12ef3f5a7c5a6b89964842fd3da047b8d07dec91
Fix compilation of the BFD sub-directory with a gcc v8 compiler by adding extra casts.
GCC v8 issues warnings about mis-matching casts of function pointers.
A previous patch tried to fix this problem by adding new dummy functions
which accepted a variable number of arguments. But this introduces serious
problems when compiled with other versions of gcc, (notably gcc 4.4). This
patch reverts that previous solution and instead adds extra casts (to
function types without a parameter list).
For more details see: https://sourceware.org/ml/binutils/2018-02/msg00198.html
PR 22823
Revert previous delta. Add extra casts to avoid compile time
warnings instead.
* libbfd-in.h (_bfd_generic_bfd_copy_private_bfd_data): Add extra
cast to avoid warning from gcc v8 compiler.
(_bfd_generic_bfd_merge_private_bfd_data): Likewise.
(_bfd_generic_bfd_set_private_flags): Likewise.
(_bfd_generic_bfd_copy_private_section_data): Likewise.
(_bfd_generic_bfd_copy_private_symbol_data): Likewise.
(_bfd_generic_bfd_copy_private_header_data): Likewise.
(_bfd_generic_bfd_print_private_bfd_data): Likewise.
(_bfd_noarchive_construct_extended_name_table): Likewise.
(_bfd_noarchive_truncate_arname): Likewise.
(_bfd_noarchive_write_ar_hdr): Likewise.
(_bfd_noarchive_get_elt_at_index): Likewise.
(_bfd_nosymbols_canonicalize_symtab): Likewise.
(_bfd_nosymbols_print_symbol): Likewise.
(_bfd_nosymbols_get_symbol_info): Likewise.
(_bfd_nosymbols_get_symbol_version_string): Likewise.
(_bfd_nosymbols_bfd_is_local_label_name): Likewise.
(_bfd_nosymbols_bfd_is_target_special_symbol): Likewise.
(_bfd_nosymbols_get_lineno): Likewise.
(_bfd_nosymbols_find_nearest_line): Likewise.
(_bfd_nosymbols_find_line): Likewise.
(_bfd_nosymbols_find_inliner_info): Likewise.
(_bfd_nosymbols_bfd_make_debug_symbol): Likewise.
(_bfd_nosymbols_read_minisymbols): Likewise.
(_bfd_nosymbols_minisymbol_to_symbol): Likewise.
(_bfd_norelocs_bfd_reloc_type_lookup): Likewise.
(_bfd_norelocs_bfd_reloc_name_lookup): Likewise.
(_bfd_nowrite_set_arch_mach): Likewise.
(_bfd_nowrite_set_section_contents): Likewise.
(_bfd_nolink_sizeof_headers): Likewise.
(_bfd_nolink_bfd_get_relocated_section_contents): Likewise.
(_bfd_nolink_bfd_relax_section): Likewise.
(_bfd_nolink_bfd_gc_sections): Likewise.
(_bfd_nolink_bfd_lookup_section_flags): Likewise.
(_bfd_nolink_bfd_merge_sections): Likewise.
(_bfd_nolink_bfd_is_group_section): Likewise.
(_bfd_nolink_bfd_discard_group): Likewise.
(_bfd_nolink_bfd_link_hash_table_create): Likewise.
(_bfd_nolink_bfd_link_add_symbols): Likewise.
(_bfd_nolink_bfd_link_just_syms): Likewise.
(_bfd_nolink_bfd_copy_link_hash_symbol_type): Likewise.
(_bfd_nolink_bfd_final_link): Likewise.
(_bfd_nolink_bfd_link_split_section): Likewise.
(_bfd_nolink_section_already_linked): Likewise.
(_bfd_nolink_bfd_define_common_symbol): Likewise.
(_bfd_nolink_bfd_define_start_stop): Likewise.
(_bfd_nodynamic_canonicalize_dynamic_symtab): Likewise.
(_bfd_nodynamic_get_synthetic_symtab): Likewise.
(_bfd_nodynamic_get_dynamic_reloc_upper_bound _bfd_): Likewise.
(_bfd_nodynamic_canonicalize_dynamic_reloc): Likewise.
* libbfd.c (bfd_false_any): Delete.
(bfd_true_any, bfd_nullvoidptr_any, bfd_0_any): Delete.
(bfd_0u_any, bfd_0l_any, _bfd_n1_any, bfd_void_any): Delete.
* libbfd.h (extern): Regenerate
* aout-target.h (MY_bfd_is_target_special_symbol): Add extra
cast to avoid warning from gcc v8 compiler.
* aout-tic30.c (tic30_aout_set_arch_mach): Likewise.
* binary.c (binary_get_symbol_info): Likewise.
* coff-alpha.c (alpha_ecoff_backend_data): Likewise.
* coff-mips.c (mips_ecoff_backend_data): Likewise.
* coffcode.h (coff_set_alignment_hook): Likewise.
(symname_in_debug_hook): Likewise.
(bfd_coff_backend_data bigobj_swap_table): Likewise.
* elf-m10300.c (elf_backend_omit_section_dynsym): Likewise.
* elf32-cr16.c (elf_backend_omit_section_dynsym): Likewise.
* elf32-lm32.c (elf_backend_omit_section_dynsym): Likewise.
* elf32-m32r.c (elf_backend_omit_section_dynsym): Likewise.
* elf32-metag.c (elf_backend_omit_section_dynsym): Likewise.
* elf32-score.c (elf_backend_omit_section_dynsym): Likewise.
* elf32-score7.c (elf_backend_omit_section_dynsym): Likewise.
* elf32-xstormy16.c (elf_backend_omit_section_dynsym): Likewise.
* elf32-xtensa.c (elf_backend_omit_section_dynsym): Likewise.
* elf64-alpha.c (elf_backend_omit_section_dynsym): Likewise.
* elf64-hppa.c (elf_backend_omit_section_dynsym): Likewise.
* elf64-ia64-vms.c (elf_backend_omit_section_dynsym): Likewise.
* elf64-mmix.c (elf_backend_omit_section_dynsym): Likewise.
* elf64-sh64.c (elf_backend_omit_section_dynsym): Likewise.
* elfnn-ia64.c (elf_backend_omit_section_dynsym): Likewise.
* elfxx-target.h (bfd_elfNN_bfd_debug_info_accumulate): Likewise.
(bfd_elfNN_bfd_make_debug_symbol): Likewise.
(bfd_elfNN_bfd_merge_private_bfd_data): Likewise.
(bfd_elfNN_bfd_set_private_flags): Likewise.
(bfd_elfNN_bfd_is_target_special_symbol): Likewise.
(elf_backend_init_index_section): Likewise.
(elf_backend_allow_non_load_phdr): Likewise.
* elfxx-x86.h (elf_backend_omit_section_dynsym): Likewise.
* i386msdos.c (msdos_bfd_is_target_special_symbol): Likewise.
* ieee.c (ieee_construct_extended_name_table): Likewise.
(ieee_write_armap): Likewise.
(ieee_write_ar_hdr): Likewise.
(ieee_bfd_is_target_special_symbol): Likewise.
* ihex.c (ihex_canonicalize_symtab): Likewise.
(ihex_bfd_is_target_special_symbol): Likewise.
* libaout.h (aout_32_bfd_is_target_special_symbol): Likewise.
* libecoff.h (_bfd_ecoff_bfd_is_target_special_symbol): Likewise.
(_bfd_ecoff_set_alignment_hook): Likewise.
* mach-o-target.c (bfd_mach_o_bfd_is_target_special_symbol): Likewise.
* mmo.c (mmo_bfd_is_target_special_symbol): Likewise.
* nlm-target.h (nlm_bfd_is_target_special_symbol): Likewise.
* oasys.c (oasys_construct_extended_name_table): Likewise.
(oasys_write_armap): Likewise.
(oasys_write_ar_hdr): Likewise.
(oasys_bfd_is_target_special_symbol): Likewise.
* pef.c (bfd_pef_bfd_is_target_special_symbol): Likewise.
* plugin.c (bfd_plugin_bfd_is_target_special_symbol): Likewise.
* ppcboot.c (ppcboot_bfd_is_target_special_symbol): Likewise.
* som.c (som_bfd_is_target_special_symbol): Likewise.
* srec.c (srec_bfd_is_target_special_symbol): Likewise.
* tekhex.c (tekhex_bfd_is_target_special_symbol): Likewise.
* verilog.c (verilog_bfd_is_target_special_symbol): Likewise.
* versados.c (versados_bfd_is_target_special_symbol): Likewise.
(versados_bfd_reloc_name_lookup): Likewise.
* vms-alpha.c (vms_bfd_is_target_special_symbol): Likewise.
(vms_bfd_define_start_stop): Likewise.
(alpha_vms_bfd_is_target_special_symbol): Likewise.
* wasm-module.c (wasm_bfd_is_target_special_symbol): Likewise.
* xsym.c (bfd_sym_bfd_is_target_special_symbol): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Move some declarations to source.h
@ 2018-02-14 15:50 sergiodj+buildbot
2018-02-14 21:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-14 15:50 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b46a8d7c1d50c06e641af99b58301db0499111b9 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: b46a8d7c1d50c06e641af99b58301db0499111b9
Move some declarations to source.h
I noticed a few declarations in defs.h that really could be put into
source.h. I think it's generally preferable to something out of
defs.h unless it is needed by most of the files in gdb.
gdb/ChangeLog
2018-02-14 Tom Tromey <tom@tromey.com>
* solib.c: Include source.h.
* nto-tdep.c: Include source.h.
* mi/mi-cmd-env.c: Include source.h.
* infcmd.c: Include source.h.
* exec.c: Include source.h.
* defs.h (enum openp_flag, openp, source_full_path_of, mod_path)
(add_path, directory_switch, source_path, init_source_path): Move
declarations...
* source.h (enum openp_flag, openp, source_full_path_of, mod_path)
(add_path, directory_switch, source_path, init_source_path):
...here.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Constify target_so_ops::bfd_open
@ 2018-02-14 16:14 sergiodj+buildbot
2018-02-15 1:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-14 16:14 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 692d6f9760bc67b68a5c96baac47067fd7dfa711 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 692d6f9760bc67b68a5c96baac47067fd7dfa711
Constify target_so_ops::bfd_open
This constifies the bfd_open method of struct target_so_ops.
gdb/ChangeLog
2018-02-14 Tom Tromey <tom@tromey.com>
* solist.h (struct target_so_ops) <bfd_open>: Make pathname
const.
(solib_bfd_open): Make pathname const.
* solib.c (solib_bfd_open): Make pathname const.
* solib-spu.c (spu_bfd_fopen): Make name const.
(spu_bfd_open): Make pathname const.
* solib-darwin.c (darwin_bfd_open): Make pathname const.
* solib-aix.c (solib_aix_bfd_open): Make pathname const.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] delete ada-lang.c::ada_to_fixed_value_create advance declaration
@ 2018-02-15 4:34 sergiodj+buildbot
2018-02-15 5:07 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-15 4:34 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 355c559b74518b67eb113e635363cc890058746c ***
Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 355c559b74518b67eb113e635363cc890058746c
delete ada-lang.c::ada_to_fixed_value_create advance declaration
This advance declaration really isn't necesary, since the implementation
of this function comes before the first reference to it.
gdb/ChangeLog:
* ada-lang.c (ada_to_fixed_value_create): Delete advance
declaration.
Tested by rebuilding GDB.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR ld/22832 on SPARC.
@ 2018-02-15 15:29 sergiodj+buildbot
2018-02-15 19:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-15 15:29 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e513bd38a6b91401947d90ba5f301f01d3991b8e ***
Author: Eric Botcazou <ebotcazou@gcc.gnu.org>
Branch: master
Commit: e513bd38a6b91401947d90ba5f301f01d3991b8e
PR ld/22832 on SPARC.
The fix for PR ld/22727 on SPARC passed TRUE as the 'create' argument
in the call to bfd_link_hash_lookup. It turns out this was a bad idea
because, if the symbol is created at this point, the link will abort
later in elf_link_output_extsym. This changes the TRUE into a FALSE
and puts an assertion on the result of the call, making it easier to
debug the issue; that's exactly in keeping with what Gold does.
bfd/
* elfxx-sparc.c (_bfd_sparc_elf_check_relocs) <R_SPARC_TLS_GD_CALL>:
Pass FALSE instead of TRUE as 'create' argument to bfd_link_hash_lookup
and assert that the result of the call is not NULL.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] RISC-V: Give error for ignored pcrel_lo addend.
@ 2018-02-15 19:14 sergiodj+buildbot
2018-02-15 21:27 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-15 19:14 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2a0d98534964649bc6884b7833c6c4089159a6df ***
Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 2a0d98534964649bc6884b7833c6c4089159a6df
RISC-V: Give error for ignored pcrel_lo addend.
bfd/
* elfnn-riscv.c (riscv_elf_relocate_section): Use bfd_reloc_dangerous
when pcrel_lo reloc has an addend. Use reloc_dangerous callback for
bfd_reloc_dangerous. Use einfo instead of warning callback for errors.
Add %X%P to error messages.
ld/
* testsuite/ld-riscv-elf/ld-riscv-elf.exp: Run pcrel-lo-addend test.
* testsuite/ld-riscv-elf/pcrel-lo-addend.d: New.
* testsuite/ld-riscv-elf/pcrel-lo-addend.s: New.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] RISC-V: Fix relocation failure with zero address sections.
@ 2018-02-15 22:04 sergiodj+buildbot
2018-02-16 0:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-15 22:04 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 09ca4b9d9bd61ecb779386a6cc7796cb05dde1af ***
Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 09ca4b9d9bd61ecb779386a6cc7796cb05dde1af
RISC-V: Fix relocation failure with zero address sections.
bfd/
* elfnn-riscv.c (_bfd_riscv_relax_section): Ifdef out check to ignore
symbols whose section address is zero.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove bfd stub function casts.
@ 2018-02-16 8:56 sergiodj+buildbot
2018-02-16 10:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-16 8:56 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d00dd7dc5e415503de88614bf2ea4aafa2bca819 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: d00dd7dc5e415503de88614bf2ea4aafa2bca819
Remove bfd stub function casts.
This patch defines a bunch of new functions to use in the BFD target
structs rather than casting bfd_false or bfd_true and similar stub
functions. I've also renamed the stub functions to reflect their
parameters and put "error" in the name if they set bfd_error. The
latter change is important since there were quite a few uses of
bfd_false where setting bfd_error was inappropriate, for example in
elf_backend_allow_non_load_phdr and is_target_special_symbol.
* libbfd.c (_bfd_bool_bfd_false_error): Rename from bfd_false.
(_bfd_bool_bfd_true): Rename from bfd_true.
(_bfd_ptr_bfd_null_error): Rename from bfd_nullvoidptr.
(_bfd_int_bfd_0): Rename from bfd_0.
(_bfd_uint_bfd_0): Rename from bfd_0u.
(_bfd_long_bfd_0): Rename from bfd_0l.
(_bfd_long_bfd_n1_error): Rename from _bfd_n1.
(_bfd_void_bfd): Rename from bfd_void.
(_bfd_bool_bfd_false, _bfd_bool_bfd_asymbol_false),
(_bfd_bool_bfd_link_false_error),
(_bfd_bool_bfd_link_true, _bfd_bool_bfd_bfd_true),
(_bfd_bool_bfd_uint_true, _bfd_bool_bfd_ptr_true),
(_bfd_bool_bfd_asection_bfd_asection_true),
(_bfd_bool_bfd_asymbol_bfd_asymbol_true),
(_bfd_void_bfd_link, _bfd_void_bfd_asection): New functions.
* archive.c (_bfd_noarchive_get_elt_at_index),
(_bfd_noarchive_openr_next_archived_file),
(_bfd_noarchive_construct_extended_name_table),
(_bfd_noarchive_write_ar_hdr, _bfd_noarchive_truncate_arname),
(_bfd_noarchive_write_armap): New functions.
* archures.c (_bfd_nowrite_set_arch_mach): New function.
* coff-alpha.c (alpha_ecoff_swap_coff_aux_in),
(alpha_ecoff_swap_coff_sym_in, alpha_ecoff_swap_coff_lineno_in),
(alpha_ecoff_swap_coff_aux_out, alpha_ecoff_swap_coff_sym_out),
(alpha_ecoff_swap_coff_lineno_out),
(alpha_ecoff_swap_coff_reloc_out): New functions.
* coff-mips.c (mips_ecoff_swap_coff_aux_in),
(mips_ecoff_swap_coff_sym_in, mips_ecoff_swap_coff_lineno_in),
(mips_ecoff_swap_coff_aux_out, mips_ecoff_swap_coff_sym_out),
(mips_ecoff_swap_coff_lineno_out),
(mips_ecoff_swap_coff_reloc_out): New functions.
* coffcode.h (coff_set_alignment_hook): Replace define with
new function.
(symname_in_debug_hook): Likewise.
* ecoff.c (_bfd_ecoff_set_alignment_hook): New function.
* elfxx-target.h (elf_backend_allow_non_load_phdr): Default to 0.
* elf.c (assign_file_positions_except_relocs): Test
elf_backend_allow_non_load_phdr for NULL.
* elflink.c (_bfd_elf_omit_section_dynsym_default): Rename from
_bfd_elf_link_omit_section_dynsym. Update uses.
(_bfd_elf_omit_section_dynsym_all): New function.
* elf-bfd.h (_bfd_elf_link_omit_section_dynsym): Delete.
(_bfd_elf_omit_section_dynsym_default): Declare.
(_bfd_elf_omit_section_dynsym_all): Declare.
* linker.c (_bfd_nolink_sizeof_headers, _bfd_nolink_bfd_relax_section),
(_bfd_nolink_bfd_get_relocated_section_contents),
(_bfd_nolink_bfd_lookup_section_flags),
(_bfd_nolink_bfd_is_group_section, _bfd_nolink_bfd_discard_group),
(_bfd_nolink_bfd_link_hash_table_create),
(_bfd_nolink_bfd_link_just_syms),
(_bfd_nolink_bfd_copy_link_hash_symbol_type),
(_bfd_nolink_bfd_link_split_section),
(_bfd_nolink_section_already_linked),
(_bfd_nolink_bfd_define_common_symbol),
(_bfd_nolink_bfd_define_start_stop): New functions.
* reloc.c (_bfd_norelocs_bfd_reloc_type_lookup),
(_bfd_norelocs_bfd_reloc_name_lookup),
(_bfd_nodynamic_canonicalize_dynamic_reloc): New functions.
* section.c (_bfd_nowrite_set_section_contents): New function.
* syms.c (_bfd_nosymbols_canonicalize_symtab),
(_bfd_nosymbols_print_symbol, _bfd_nosymbols_get_symbol_info),
(_bfd_nosymbols_get_symbol_version_string),
(_bfd_nosymbols_bfd_is_local_label_name),
(_bfd_nosymbols_get_lineno, _bfd_nosymbols_find_nearest_line),
(_bfd_nosymbols_find_line, _bfd_nosymbols_find_inliner_info),
(_bfd_nosymbols_bfd_make_debug_symbol),
( _bfd_nosymbols_read_minisymbols),
( _bfd_nosymbols_minisymbol_to_symbol),
(_bfd_nodynamic_get_synthetic_symtab): New functions.
* libbfd-in.h: Declare new functions. Update existing defines,
removing casts.
* aix386-core.c: Update to use new hooks. Formatting.
* aout-adobe.c: Likewise.
* aout-arm.c: Likewise.
* aout-target.h: Likewise.
* aout-tic30.c: Likewise.
* aoutf1.h: Likewise.
* binary.c: Likewise.
* bout.c: Likewise.
* cisco-core.c: Likewise.
* coff-alpha.c: Likewise.
* coff-i386.c: Likewise.
* coff-i860.c: Likewise.
* coff-i960.c: Likewise.
* coff-ia64.c: Likewise.
* coff-mips.c: Likewise.
* coff-ppc.c: Likewise.
* coff-rs6000.c: Likewise.
* coff-sh.c: Likewise.
* coff-tic30.c: Likewise.
* coff-tic54x.c: Likewise.
* coff-x86_64.c: Likewise.
* coff64-rs6000.c: Likewise.
* coffcode.h: Likewise.
* elf-m10300.c: Likewise.
* elf32-cr16.c: Likewise.
* elf32-lm32.c: Likewise.
* elf32-m32r.c: Likewise.
* elf32-metag.c: Likewise.
* elf32-score.c: Likewise.
* elf32-score7.c: Likewise.
* elf32-tilepro.c: Likewise.
* elf32-xstormy16.c: Likewise.
* elf32-xtensa.c: Likewise.
* elf64-alpha.c: Likewise.
* elf64-hppa.c: Likewise.
* elf64-ia64-vms.c: Likewise.
* elf64-mmix.c: Likewise.
* elf64-sh64.c: Likewise.
* elfnn-ia64.c: Likewise.
* elfxx-sparc.c: Likewise.
* elfxx-target.h: Likewise.
* elfxx-tilegx.c: Likewise.
* elfxx-x86.h: Likewise.
* hp300hpux.c: Likewise.
* hppabsd-core.c: Likewise.
* hpux-core.c: Likewise.
* i386msdos.c: Likewise.
* i386os9k.c: Likewise.
* ieee.c: Likewise.
* ihex.c: Likewise.
* irix-core.c: Likewise.
* libaout.h: Likewise.
* libecoff.h: Likewise.
* mach-o-target.c: Likewise.
* mach-o.c: Likewise.
* mipsbsd.c: Likewise.
* mmo.c: Likewise.
* netbsd-core.c: Likewise.
* nlm-target.h: Likewise.
* oasys.c: Likewise.
* osf-core.c: Likewise.
* pdp11.c: Likewise.
* pe-mips.c: Likewise.
* pe-x86_64.c: Likewise.
* pef.c: Likewise.
* plugin.c: Likewise.
* ppcboot.c: Likewise.
* ptrace-core.c: Likewise.
* sco5-core.c: Likewise.
* som.c: Likewise.
* sparclynx.c: Likewise.
* srec.c: Likewise.
* tekhex.c: Likewise.
* trad-core.c: Likewise.
* verilog.c: Likewise.
* versados.c: Likewise.
* vms-alpha.c: Likewise.
* vms-lib.c: Likewise.
* wasm-module.c: Likewise.
* xsym.c: Likewise.
* libbfd.h: Regenerate.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] New class allocate_on_obstack
@ 2018-02-16 16:34 sergiodj+buildbot
2018-02-16 17:59 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-16 16:34 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT fd90ace4c1e77c94e90d2942cebe84e9a2019c0f ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: fd90ace4c1e77c94e90d2942cebe84e9a2019c0f
New class allocate_on_obstack
This patch adds a new class allocate_on_obstack, and let dwarf2_per_objfile
inherit it, so that dwarf2_per_objfile is automatically allocated on
obstack, and "delete dwarf2_per_objfile" doesn't de-allocate any space.
gdb:
2018-02-16 Yao Qi <yao.qi@linaro.org>
* block.c (block_namespace_info): Inherit allocate_on_obstack.
(block_initialize_namespace): Use new.
* dwarf2read.c (dwarf2_per_objfile): Inherit allocate_on_obstack.
(dwarf2_free_objfile): Use delete.
* gdbtypes.c (type_pair): Inherit allocate_on_obstack.
(copy_type_recursive): Use new.
* gdb_obstack.h (allocate_on_obstack): New.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Ignore degenerate PT_LOAD segments
@ 2018-02-17 0:02 sergiodj+buildbot
2018-02-17 0:54 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-17 0:02 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 325ba6fb34be799c885fad9287d883e86b835c84 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 325ba6fb34be799c885fad9287d883e86b835c84
Ignore degenerate PT_LOAD segments
Fixes a failure triggered by -z separate-code. p_memsz is tested
rather than p_filesz for objcopy --only-keep-debug where p_filesz is
set to zero.
PR 22845
* elf.c (assign_file_positions_for_non_load_sections): Ignore
degenerate zero size PT_LOAD segments when finding one overlapping
the PT_GNU_RELRO segment.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix make 3.81 build errors
@ 2018-02-20 11:13 sergiodj+buildbot
2018-02-20 12:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-20 11:13 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a543c5ca7c1285548726e6d92ca6044dc1963340 ***
Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: a543c5ca7c1285548726e6d92ca6044dc1963340
Fix make 3.81 build errors
gdbserver/
* Makefile.in: Switch order of make rules.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] btrace, testsuite: do not force BTS
@ 2018-02-20 13:30 sergiodj+buildbot
2018-02-20 14:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-20 13:30 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT de65820cd69a4d9aaa87079a809c70364571efab ***
Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: de65820cd69a4d9aaa87079a809c70364571efab
btrace, testsuite: do not force BTS
In gdb.btrace/buffer-size.exp we explicitly ask for the BTS recording format.
This may lead to spurious fails on systems where PT is being used by some other
process at the same time.
Set both PT and BTS buffer sizes to 1 and check that whatever recording format
is used will use a 4KB buffer.
testsuite/
* gdb.btrace/buffer-size.exp: Do not force BTS.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gnulib: import mkstemp
@ 2018-02-20 13:39 sergiodj+buildbot
2018-02-20 16:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-20 13:39 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2d8adcbd07fc12a3212a9f045605ef712f5fb3ab ***
Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: 2d8adcbd07fc12a3212a9f045605ef712f5fb3ab
gnulib: import mkstemp
Older versions of MinGW do not support mkstemp causing:
gdb/unittests/scoped_fd-selftests.c:37:29: error: \
'mkstemp' was not declared in this scope
int fd = mkstemp (filename);
^
gdb/unittests/scoped_fd-selftests.c: In function 'void
selftests::scoped_fd::test_release()':
gdb/unittests/scoped_fd-selftests.c:56:29: error: \
'mkstemp' was not declared in this scope
int fd = mkstemp (filename);
^
Import mkstemp from gnulib.
gdb/
* gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkstemp.
* gnulib/aclocal.m4: Regenerated.
* gnulib/config.in: Regenerated.
* gnulib/configure: Regenerated.
* gnulib/import/Makefile.am: Regenerated.
* gnulib/import/Makefile.in: Regenerated.
* gnulib/import/m4/gnulib-cache.m4: Regenerated.
* gnulib/import/m4/gnulib-comp.m4: Regenerated.
* gnulib/import/m4/mkstemp.m4: Imported.
* gnulib/import/m4/secure_getenv.m4: Imported.
* gnulib/import/m4/tempname.m4: Imported.
* gnulib/import/mkstemp.c: Imported.
* gnulib/import/secure_getenv.c: Imported.
* gnulib/import/tempname.c: Imported.
* gnulib/import/tempname.h: Imported.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] remote-sim: Add missing ATTRIBUTE_PRINTF
@ 2018-02-20 16:58 sergiodj+buildbot
2018-02-20 20:06 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-20 16:58 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 7104e59bece90e387d70f617eb7ed4c34087283d ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 7104e59bece90e387d70f617eb7ed4c34087283d
remote-sim: Add missing ATTRIBUTE_PRINTF
Fixes:
/home/emaisin/src/binutils-gdb/gdb/remote-sim.c:385:34: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
vfprintf_filtered (gdb_stdout, format, args);
^~~~~~
/home/emaisin/src/binutils-gdb/gdb/remote-sim.c:394:34: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
vfprintf_filtered (gdb_stdout, format, ap);
^~~~~~
/home/emaisin/src/binutils-gdb/gdb/remote-sim.c:402:34: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
vfprintf_filtered (gdb_stderr, format, ap);
^~~~~~
/home/emaisin/src/binutils-gdb/gdb/remote-sim.c:413:11: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
verror (format, args);
^~~~~~
4 errors generated.
gdb/ChangeLog:
* remote-sim.c (gdb_os_printf_filtered, gdb_os_vprintf_filtered,
gdb_os_evprintf_filtered, gdb_os_error): Add ATTRIBUTE_PRINTF.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Class reg_buffer
@ 2018-02-21 11:39 sergiodj+buildbot
2018-02-21 13:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 11:39 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 31716595b5bda8524fc841378468fd1c47510dd3 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 31716595b5bda8524fc841378468fd1c47510dd3
Class reg_buffer
This patch adds a new class reg_buffer, and regcache inherits it. Class
reg_buffer is a very simple class, which has the buffer for register
contents and status only. It doesn't have any methods to set contents and
status, and it is expected that its children classes can inherit it and
add different access methods.
Another reason I keep class reg_buffer so simple is that I think
reg_buffer can be even reused in other classes which need to record the
registers contents and status, like frame cache for example.
gdb:
2018-02-21 Yao Qi <yao.qi@linaro.org>
* regcache.c (regcache::regcache): Call reg_buffer ctor.
(regcache::arch): Move it to reg_buffer::arch.
(regcache::register_buffer): Likewise.
(regcache::assert_regnum): Likewise.
(regcache::num_raw_registers): Likewise.
* regcache.h (reg_buffer): New class.
(regcache): Inherit reg_buffer.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] class readable_regcache and pass readable_regcache to gdbarch pseudo_register_read and pseudo_register_read_value
@ 2018-02-21 11:47 sergiodj+buildbot
2018-02-21 15:54 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 11:47 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 849d0ba802323fe05e3039ed5b22957db2c85a67 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 849d0ba802323fe05e3039ed5b22957db2c85a67
class readable_regcache and pass readable_regcache to gdbarch pseudo_register_read and pseudo_register_read_value
pseudo registers are either from raw registers or memory, so
gdbarch methods pseudo_register_read and pseudo_register_read_value
should have regcache object which only have read methods. In other
words, we should disallow writing to regcache in these two gdbarch
methods. In order to apply this restriction, this patch adds a new
class readable_regcache, derived from reg_buffer, and it only has
raw_read and cooked_read methods. regcache is derived from
readable_regcache. This patch also passes readable_regcache instead of
regcache to gdbarch methods pseudo_register_read and
pseudo_register_read_value.
This patch moves raw_read* and cooked_read* methods to readable_regcache,
which is straightforward. One thing not straightforward is that I split
regcache::xfer_part to readable_regcache::read_part and regcache::write_part,
because readable_regcache can only have methods to read.
readable_regcache is an abstract base class, and it has a pure virtual
function raw_update, because I don't want readable_regcache know where
these raw registers are from. They can be from either the target
(readwrite regcache) or the regcache itself (readonly regcache).
gdb:
2018-02-21 Yao Qi <yao.qi@linaro.org>
* aarch64-tdep.c (aarch64_pseudo_register_read_value): Change
parameter type to 'readable_regcache *'.
* amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
* arm-tdep.c (arm_neon_quad_read): Likewise.
(arm_pseudo_read): Likewise.
* avr-tdep.c (avr_pseudo_register_read): Likewise.
* bfin-tdep.c (bfin_pseudo_register_read): Likewise.
* frv-tdep.c (frv_pseudo_register_read): Likewise.
* gdbarch.c: Re-generated.
* gdbarch.h: Re-generated.
* gdbarch.sh (pseudo_register_read): Change parameter type to
'readable_regcache *'.
(pseudo_register_read_value): Likewise.
* h8300-tdep.c (pseudo_from_raw_register): Likewise.
(h8300_pseudo_register_read): Likewise.
* hppa-tdep.c (hppa_pseudo_register_read): Likewise.
* i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
(i386_pseudo_register_read_into_value): Likewise.
(i386_pseudo_register_read_value): Likewise.
* i386-tdep.h (i386_pseudo_register_read_into_value): Update
declaration.
* ia64-tdep.c (ia64_pseudo_register_read): Likewise.
* m32c-tdep.c (m32c_raw_read): Likewise.
(m32c_read_flg): Likewise.
(m32c_banked_register): Likewise.
(m32c_banked_read): Likewise.
(m32c_sb_read): Likewise.
(m32c_part_read): Likewise.
(m32c_cat_read): Likewise.
(m32c_r3r2r1r0_read): Likewise.
(m32c_pseudo_register_read): Likewise.
* m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
* mep-tdep.c (mep_pseudo_cr32_read): Likewise.
(mep_pseudo_cr64_read): Likewise.
(mep_pseudo_register_read): Likewise.
* mips-tdep.c (mips_pseudo_register_read): Likewise.
* msp430-tdep.c (msp430_pseudo_register_read): Likewise.
* nds32-tdep.c (nds32_pseudo_register_read): Likewise.
* regcache.c (regcache::raw_read): Move it to readable_regcache.
(regcache::cooked_read): Likewise.
(regcache::cooked_read_value): Likewise.
(regcache_cooked_read_signed):
(regcache::cooked_read): Likewise.
* regcache.h (readable_regcache): New class.
(regcache): Inherit readable_regcache. Move some methods to
readable_regcache.
* rl78-tdep.c (rl78_pseudo_register_read): Change
parameter type to 'readable_regcache *'.
* rs6000-tdep.c (do_regcache_raw_read): Remove.
(e500_pseudo_register_read): Change parameter type to
'readable_regcache *'.
(dfp_pseudo_register_read): Likewise.
(vsx_pseudo_register_read): Likewise.
(efpr_pseudo_register_read): Likewise.
* s390-tdep.c (s390_pseudo_register_read): Likewise.
* sh-tdep.c (sh_pseudo_register_read): Likewise.
* sh64-tdep.c (pseudo_register_read_portions): Likewise.
(sh64_pseudo_register_read): Likewise.
* sparc-tdep.c (sparc32_pseudo_register_read): Likewise.
* sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
* spu-tdep.c (spu_pseudo_register_read_spu): Likewise.
(spu_pseudo_register_read): Likewise.
* xtensa-tdep.c (xtensa_register_read_masked): Likewise.
(xtensa_pseudo_register_read): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove regcache_save and regcache_cpy
@ 2018-02-21 12:00 sergiodj+buildbot
2018-02-21 18:22 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 12:00 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT fc5b87361580d915e28ae5f3cc4794b75b671b5a ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: fc5b87361580d915e28ae5f3cc4794b75b671b5a
Remove regcache_save and regcache_cpy
... instead we start to use regcache methods save and restore. It is
quite straightforward to replace regcache_save with regcache->save.
regcache_cpy has some asserts, some of them not necessary, like
gdb_assert (src != dst);
because we already assert !m_readonly_p and src->m_readonly_p, so
src isn't dst. Some of the asserts are moved to ::restore.
gdb:
2018-02-21 Yao Qi <yao.qi@linaro.org>
* frame.c (frame_save_as_regcache): Use regcache method save.
(frame_pop): Use regcache method restore.
* infrun.c (restore_infcall_suspend_state): Likewise.
* linux-fork.c (fork_load_infrun_state): Likewise.
* ppc-linux-tdep.c (ppu2spu_sniffer): User regcache method
save.
* regcache.c (regcache_save): Remove.
(regcache::restore): More asserts.
(regcache_cpy): Remove.
* regcache.h (regcache_save): Remove the declaration.
(regcache::restore): Move from private to public.
Remove the friend declaration of regcache_cpy.
(regcache_cpy): Remove declaration.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Class readonly_detached_regcache
@ 2018-02-21 12:12 sergiodj+buildbot
2018-02-21 21:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 12:12 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT daf6667d1f94c7e74df4076daf021cd28a2797b6 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: daf6667d1f94c7e74df4076daf021cd28a2797b6
Class readonly_detached_regcache
This patch adds a new class (type) for readonly regcache, which is
created via regcache::save. readonly_detached_regcache inherits
readable_regcache.
gdb:
2018-02-21 Yao Qi <yao.qi@linaro.org>
* dummy-frame.c (dummy_frame_cache) <prev_regcache>: Use
readonly_detached_regcache.
(dummy_frame_prev_register): Use regcache->cooked_read.
* frame.c (frame_save_as_regcache): Change return type.
(frame_pop): Update.
* frame.h (frame_save_as_regcache): Update declaration.
* inferior.h (get_infcall_suspend_state_regcache): Update
declaration.
* infrun.c (infcall_suspend_state) <registers>: use
readonly_detached_regcache.
(save_infcall_suspend_state): Don't use regcache_dup.
(get_infcall_suspend_state_regcache): Change return type.
* linux-fork.c (struct fork_info) <savedregs>: Change to
readonly_detached_regcache.
<pc>: New field.
(fork_save_infrun_state): Don't use regcache_dup.
(info_checkpoints_command): Adjust.
* mi/mi-main.c (register_changed_p): Update declaration.
(mi_cmd_data_list_changed_registers): Use
readonly_detached_regcache.
(register_changed_p): Change parameter type to
readonly_detached_regcache.
* ppc-linux-tdep.c (ppu2spu_cache) <regcache>: Use
readonly_detached_regcache.
(ppu2spu_sniffer): Construct a new readonly_detached_regcache.
* regcache.c (readonly_detached_regcache::readonly_detached_regcache):
New.
(regcache::save): Move it to reg_buffer.
(regcache::restore): Change parameter type.
(regcache_dup): Remove.
* regcache.h (reg_buffer) <save>: New method.
(readonly_detached_regcache): New class.
* spu-tdep.c (spu2ppu_cache) <regcache>: Use
readonly_detached_regcache.
(spu2ppu_sniffer): Construct a new readonly_detached_regcache.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Class detached_regcache
@ 2018-02-21 12:25 sergiodj+buildbot
2018-02-21 23:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 12:25 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c8ec2f334c3751c28d5f952d07dea9c0558ca0a0 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: c8ec2f334c3751c28d5f952d07dea9c0558ca0a0
Class detached_regcache
jit.c uses the regcache in a slightly different way, the regcache dosen't
write through to target, but it has read and write methods. If I apply
regcache in record-full.c, it has the similar use pattern. This patch
adds a new class detached_regcache, a register buffer, but can be
read and written.
Since jit.c doesn't want to write registers through to target, it uses
regcache as a readonly regcache (because only readonly regcache
disconnects from the target), but it adds a hole in regcache
(raw_set_cached_value) in order to modify a readonly regcache. This patch
fixes this hole completely.
regcache inherits detached_regcache, and detached_regcache inherits
readable_regcache. The ideal design is that both detached_regcache and
readable_regcache inherit reg_buffer, and regcache inherit
detached_regcache and regcache_read (virtual inheritance). I concern
about the performance overhead of virtual inheritance, so I don't do it in
the patch.
gdb:
2018-02-21 Yao Qi <yao.qi@linaro.org>
* jit.c (struct jit_unwind_private) <regcache>: Change its type to
reg_buffer_rw *.
(jit_unwind_reg_set_impl): Call raw_supply.
(jit_frame_sniffer): Use reg_buffer_rw.
* record-full.c (record_full_core_regbuf): Change its type.
(record_full_core_open_1): Use reg_buffer_rw.
(record_full_close): Likewise.
(record_full_core_fetch_registers): Use regcache->raw_supply.
(record_full_core_store_registers): Likewise.
* regcache.c (regcache::get_register_status): Move it to
reg_buffer.
(regcache_raw_set_cached_value): Remove.
(regcache::raw_set_cached_value): Remove.
(regcache::raw_write): Call raw_supply.
(regcache::raw_supply): Move it to reg_buffer_rw.
* regcache.h (regcache_raw_set_cached_value): Remove.
(reg_buffer_rw): New class.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Replace regcache::dump with class register_dump
@ 2018-02-21 12:37 sergiodj+buildbot
2018-02-22 2:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 12:37 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f3384e664de76c4bb9f8fd9920afcec86557f1f0 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: f3384e664de76c4bb9f8fd9920afcec86557f1f0
Replace regcache::dump with class register_dump
Nowadays, we need to dump registers contents from "readwrite" regcache and
"readonly" regcache,
if (target_has_registers)
get_current_regcache ()->dump (out, what_to_dump);
else
{
/* For the benefit of "maint print registers" & co when
debugging an executable, allow dumping a regcache even when
there is no thread selected / no registers. */
regcache dummy_regs (target_gdbarch ());
dummy_regs.dump (out, what_to_dump);
}
since we'll have two different types/classes for "readwrite" regcache and
"readonly" regcache, we have to move dump method to their parent class,
reg_buffer. However, the functionality of "dump" looks unnecessary to
reg_buffer (because some dump modes like regcache_dump_none,
regcache_dump_remote and regcache_dump_groups don't need reg_buffer at
all, they need gdbarch to do the dump), so I decide to move "dump" into a
separate classes, and each sub-class is about each mode of dump.
gdb:
2018-02-21 Yao Qi <yao.qi@linaro.org>
* regcache.c (class register_dump): New class.
(register_dump_regcache, register_dump_none): New class.
(register_dump_remote, register_dump_groups): New class.
(regcache_print): Update.
* regcache.h (regcache_dump_what): Move it to regcache.c.
(regcache) <dump>: Remove.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] No longer create readonly regcache
@ 2018-02-21 12:50 sergiodj+buildbot
2018-02-22 4:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 12:50 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 215c69dc9a7d8f868198b5523abcf41458fb6e4a ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 215c69dc9a7d8f868198b5523abcf41458fb6e4a
No longer create readonly regcache
Nowadays, we create a readonly regcache in get_return_value, and pass it
to gdbarch_return_value to get the return value. In theory, we can pass a
readable_regcache instance and get the return value, because we don't need
to modify the regcache. Unfortunately, gdbarch_return_value is designed
to multiplex regcache, according to READBUF and WRITEBUF.
# If READBUF is not NULL, extract the return value and save it in this
# buffer.
#
# If WRITEBUF is not NULL, it contains a return value which will be
# stored into the appropriate register.
In fact, gdbarch_return_value should be split to three functions, 1) only
return return_value_convention, 2) pass regcache_readonly and readbuf, 3)
pass regcache and writebuf. These changes are out of the scope of this
patch series, so I pass regcache to gdbarch_return_value even for read,
and trust each gdbarch backend doesn't modify regcache.
gdb:
2018-02-21 Yao Qi <yao.qi@linaro.org>
* infcmd.c (get_return_value): Let stop_regs point to
get_current_regcache.
* regcache.c (regcache::regcache): Remove.
(register_dump_reg_buffer): New class.
(regcache_print): Adjust.
* regcache.h (regcache): Remove constructors.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove regcache::m_readonly_p
@ 2018-02-21 13:02 sergiodj+buildbot
2018-02-22 6:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 13:02 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 796bb0264184e8d9343f041c2f11cb898c0d18ac ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 796bb0264184e8d9343f041c2f11cb898c0d18ac
Remove regcache::m_readonly_p
Now, m_readonly_p is always false, so we can remove it, and regcache no
longer includes pseudo registers. Some regcache methods are lift up to
its parent class, like reg_buffer or detached_regcache.
gdb:
2018-02-21 Yao Qi <yao.qi@linaro.org>
* regcache.c (regcache::regcache): Update.
(regcache::invalidate): Move it to detached_regcache::invalidate.
(get_thread_arch_aspace_regcache): Update.
(regcache::raw_update): Update.
(regcache::cooked_read): Remove some code.
(regcache::cooked_read_value): Likewise.
(regcache::raw_write): Remove assert on m_readonly_p.
(regcache::raw_supply_integer): Move it to
detached_regcache::raw_supply_integer.
(regcache::raw_supply_zeroed): Likewise.
* regcache.h (detached_regcache) <raw_supply_integer>: New
declaration.
<raw_supply_zeroed, invalidate>: Likewise.
(regcache) <raw_supply_integer, raw_supply_zeroed>: Removed.
<invalidate>: Likewise.
<m_readonly_p>: Removed.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove a cleanup from parse_expression_for_completion
@ 2018-02-21 16:31 sergiodj+buildbot
2018-02-22 15:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 16:31 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 3eac2b654808f9e233885f910045eea9d2ca0aa0 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 3eac2b654808f9e233885f910045eea9d2ca0aa0
Remove a cleanup from parse_expression_for_completion
This removes a cleanup from parse_expression_for_completion, by
changing various expression-completion functions to use
gdb::unique_xmalloc_ptry rather than explicit malloc+free.
Regression tested by the buildbot.
gdb/ChangeLog
2018-02-21 Tom Tromey <tom@tromey.com>
* value.h: (extract_field_op): Update.
* eval.c (extract_field_op): Return a const char *.
* expression.h (parse_expression_for_completion): Update.
* completer.c (complete_expression): Update.
(add_struct_fields): Make fieldname const.
* parse.c (expout_completion_name): Now a unique_xmalloc_ptr.
(mark_completion_tag, parse_exp_in_context_1): Update.
(parse_expression_for_completion): Change "name" to
unique_xmalloc_ptr*.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove a cleanup from call_function_by_hand_dummy
@ 2018-02-21 17:11 sergiodj+buildbot
2018-02-22 12:32 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 17:11 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 6ccb583f751e020a6db768d517c2dd3ba6d93cc4 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 6ccb583f751e020a6db768d517c2dd3ba6d93cc4
Remove a cleanup from call_function_by_hand_dummy
This removes a cleanup from call_function_by_hand_dummy, replacing
manual allocation with std::vector.
Regression tested by the buildbot.
gdb/ChangeLog
2018-02-21 Tom Tromey <tom@tromey.com>
* infcall.c (call_function_by_hand_dummy): Use std::vector.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add "common-defs.h" include to files in arch/ subdir not yet including it.
@ 2018-02-21 19:23 sergiodj+buildbot
2018-02-22 17:30 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 19:23 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 8ec57239e91f22f427f8065eb742e6c8bfa223f1 ***
Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: 8ec57239e91f22f427f8065eb742e6c8bfa223f1
Add "common-defs.h" include to files in arch/ subdir not yet including it.
This fixes a build breakage on FreeBSD hosts.
gdb/ChangeLog:
* arch/aarch64.c: Include "common-defs.h".
* arch/amd64.c: Likewise.
* arch/i386.c: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix a typo.
@ 2018-02-21 20:49 sergiodj+buildbot
2018-02-22 20:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 20:49 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 54a27fe598e6d44eb59bc94882f7f56585bfd5cd ***
Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: 54a27fe598e6d44eb59bc94882f7f56585bfd5cd
Fix a typo.
gdb/testsuite/ChangeLog:
* gdb.arch/amd64-i386-address.exp: Fix a typo.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] RISC-V: Make disassebler work for --enable-targets=all config.
@ 2018-02-22 19:44 sergiodj+buildbot
2018-02-23 0:27 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-22 19:44 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 0bccfb2994d307601ceba5c3a6223b7ca7cf5338 ***
Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 0bccfb2994d307601ceba5c3a6223b7ca7cf5338
RISC-V: Make disassebler work for --enable-targets=all config.
opcodes/
* disassemble.c (ARCH_riscv): Define if ARCH_all.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] New plugin interface to get list of symbols wrapped with --wrap option.
@ 2018-02-22 22:16 sergiodj+buildbot
2018-02-23 2:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-22 22:16 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 0b65c07b97c43e8891c2e14061270878a85222c8 ***
Author: Sriraman Tallam <tmsriram@google.com>
Branch: master
Commit: 0b65c07b97c43e8891c2e14061270878a85222c8
New plugin interface to get list of symbols wrapped with --wrap option.
2018-02-22 Sriraman Tallam <tmsriram@google.com>
* plugin.cc (get_wrap_symbols): New plugin interface.
(load): Add get_wrap_symbols to transfer vector.
* plugin-api.h (ld_plugin_get_wrap_symbols): New plugin interface.
* testsuite/plugin_test.c (onload): Call and check get_wrap_symbols
interface.
* testsuite/plugin_test_wrap_symbols.sh: New test script.
* testsuite/plugin_test_wrap_symbols_1.cc: New file.
* testsuite/plugin_test_wrap_symbols_2.cc: New file.
* testsuite/Makefile.am (plugin_test_wrap_symbols): New test.
* testsuite/Makefile.in: Regenerate.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR22881, null pointer dereference in assign_file_positions_for_non_load_sections
@ 2018-02-23 11:31 sergiodj+buildbot
2018-02-23 13:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-23 11:31 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 01f7e10cf2dcf403462b2feed06c43135651556d ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 01f7e10cf2dcf403462b2feed06c43135651556d
PR22881, null pointer dereference in assign_file_positions_for_non_load_sections
PR 22881
* elf.c (assign_file_positions_for_non_load_sections): Remove RELRO
segment if no matching LOAD segment.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] dwarf: Make sect_offset 64-bits
@ 2018-02-23 18:26 sergiodj+buildbot
2018-02-23 19:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-23 18:26 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9d8780f0d0f53d9d326a9d64b7919fe1a628b767 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 9d8780f0d0f53d9d326a9d64b7919fe1a628b767
dwarf: Make sect_offset 64-bits
Does anybody have an opinion about this? It would be nice to unbreak
the "default" build with clang (i.e. without passing special -Wno-error=
flags).
Here's a version rebased on today's master.
>From 47d28075117fa2ddb93584ec50881e33777a85e5 Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@ericsson.com>
Date: Sat, 30 Dec 2017 22:48:18 -0500
Subject: [PATCH] dwarf: Make sect_offset 64-bits
Compiling with Clang 6 shows these errors:
/home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:26610:43: error: result of comparison of constant 4294967296 with expression of type 'typename std::underlying_type<sect_offset>::type' (a
ka 'unsigned int') is always false [-Werror,-Wtautological-constant-out-of-range-compare]
if (to_underlying (per_cu.sect_off) >= (static_cast<uint64_t> (1) << 32))
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:26618:43: error: result of comparison of constant 4294967296 with expression of type 'typename std::underlying_type<sect_offset>::type' (a
ka 'unsigned int') is always false [-Werror,-Wtautological-constant-out-of-range-compare]
if (to_underlying (per_cu.sect_off) >= (static_cast<uint64_t> (1) << 32))
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
The code in question checks if there is any offset exceeding 32 bits,
and therefore if we need to use the 64-bit DWARF format when writing the
.debug_names section. The type we use currently to represent section
offsets is an unsigned int (32-bits), which means a value of this type
will never exceed 32 bits, hence the errors above.
There are many signs that we want to support 64-bits DWARF (although I
haven't tested), such as:
- We correctly read initial length fields (read_initial_length)
- We take that into account when reading offsets (read_offset_1)
- The check_dwarf64_offsets function
However, I don't see how it can work if sect_offset is a 32-bits type.
Every time we record a section offset, we risk truncating the value.
And if a file uses the 64-bit DWARF format, it's most likely because
there are such offset values that overflow 32 bits.
Because of this, I think the way forward is to change sect_offset to be
a uint64_t. It will be able to represent any offset, regardless of the
bitness of the DWARF info.
This patch was regtested on the buildbot.
gdb/ChangeLog:
* gdbtypes.h (sect_offset): Change type to uint64_t.
(sect_offset_str): New function.
* dwarf2read.c (create_addrmap_from_aranges): Use
sect_offset_str.
(error_check_comp_unit_head): Likewise.
(create_debug_type_hash_table): Likewise.
(read_cutu_die_from_dwo): Likewise.
(init_cutu_and_read_dies): Likewise.
(init_cutu_and_read_dies_no_follow): Likewise.
(process_psymtab_comp_unit_reader): Likewise.
(partial_die_parent_scope): Likewise.
(peek_die_abbrev): Likewise.
(process_queue): Likewise.
(dwarf2_physname): Likewise.
(read_namespace_alias): Likewise.
(read_import_statement): Likewise.
(create_dwo_cu_reader): Likewise.
(create_cus_hash_table): Likewise.
(lookup_dwo_cutu): Likewise.
(inherit_abstract_dies): Likewise.
(read_func_scope): Likewise.
(read_call_site_scope): Likewise.
(dwarf2_add_member_fn): Likewise.
(read_common_block): Likewise.
(read_module_type): Likewise.
(read_typedef): Likewise.
(read_subrange_type): Likewise.
(load_partial_dies): Likewise.
(read_partial_die): Likewise.
(find_partial_die): Likewise.
(read_str_index): Likewise.
(dwarf2_string_attr): Likewise.
(build_error_marker_type): Likewise.
(lookup_die_type): Likewise.
(dump_die_shallow): Likewise.
(follow_die_ref): Likewise.
(dwarf2_fetch_die_loc_sect_off): Likewise.
(dwarf2_fetch_constant_bytes): Likewise.
(follow_die_sig): Likewise.
(get_signatured_type): Likewise.
(get_DW_AT_signature_type): Likewise.
(dwarf2_find_containing_comp_unit): Likewise.
(set_die_type): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] GDB/testsuite: Fix a typo in $actual_line
@ 2018-02-23 20:31 sergiodj+buildbot
2018-02-23 22:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-23 20:31 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 11b031457e89d5739922ddd0bc65c9d781b6db35 ***
Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 11b031457e89d5739922ddd0bc65c9d781b6db35
GDB/testsuite: Fix a typo in $actual_line
Fix a commit 883fd55ab104 ("Record nested types") issue:
ERROR: tcl error sourcing .../gdb/testsuite/gdb.cp/nested-types.exp.
ERROR: can't read "actual_linejj": no such variable
while executing
"append txt " definition: $actual_linejj""
(procedure "cp_test_ptype_class" line 324)
invoked from within
"cp_test_ptype_class $name "ptype $name (limit = $limit)" $key $name $children" (procedure "test_nested_limit" line 28)
invoked from within
"test_nested_limit -1 false"
(file ".../gdb/testsuite/gdb.cp/nested-types.exp" line 310)
invoked from within
"source .../gdb/testsuite/gdb.cp/nested-types.exp"
("uplevel" body line 1)
invoked from within
"uplevel #0 source .../gdb/testsuite/gdb.cp/nested-types.exp"
invoked from within
"catch "uplevel #0 source $test_file_name""
testcase .../gdb/testsuite/gdb.cp/nested-types.exp completed in 9 seconds
caused by $actual_line having been accidentally referred to as
$actual_linejj in one place.
gdb/testsuite/
* lib/cp-support.exp (cp_test_ptype_class): Fix a typo in the
name of a variable: $actual_linejj -> $actual_line.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove most cleanups from linux-thread-db.c
@ 2018-02-24 17:31 sergiodj+buildbot
2018-02-24 20:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-24 17:31 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9b292f68805700c7ae46fc149231fdb79554bd17 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 9b292f68805700c7ae46fc149231fdb79554bd17
Remove most cleanups from linux-thread-db.c
This removes most (but not all) cleanups from linux-thread-db.c.
std::string and std::vector are used in place of manual memory
management.
The remaining cleanup in linux-thread-db.c uses
make_cleanup_free_char_ptr_vec, which requires a somewhat bigger
change.
Regression tested by the buildbot.
ChangeLog
2018-02-24 Tom Tromey <tom@tromey.com>
* linux-thread-db.c (try_thread_db_load_from_pdir_1)
(try_thread_db_load_from_dir, thread_db_load_search): Use
std::string.
(info_auto_load_libthread_db_compare): Return bool. Change
argument types.
(info_auto_load_libthread_db): Use std::vector, std::string.
Remove cleanups.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix double space expected in cp_test_ptype_class
@ 2018-02-25 20:37 sergiodj+buildbot
2018-02-25 22:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-25 20:37 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 6f6d0c269ecdc11aca9166940534ec61b6dbc39d ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 6f6d0c269ecdc11aca9166940534ec61b6dbc39d
Fix double space expected in cp_test_ptype_class
I noticed some failures of some buildbot slaves, e.g.:
FAIL: gdb.cp/nested-types.exp: ptype S10 (limit = 1) // wrong nested type enum definition: enum S10::E10 {S10::A10, S10::B10, S10::C10};
The issue is that they have an older gcc (not c++11 by default?) that
doesn't emit the enum underlying type information. When the
enum type is printed by ptype, it looks like this:
enum S10::E10 {S10::A10, S10::B10, S10::C10};
instead of this on older gccs:
enum S10::E10 : unsigned int {S10::A10, S10::B10, S10::C10};
The regex that matches this is in cp_test_ptype_class, and is
enum $nested_name (: (unsigned )?int)? \{
If the "unsigned int" portion is not present, then it requires the
string to have two spaces between the enum name and opening bracket.
The fix is simply to move the trailing space inside the ? group.
gdb/testsuite/ChangeLog:
* lib/cp-support.exp (cp_test_ptype_class): Move space inside
parentheses.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] unrecognized/unsupported reloc message
@ 2018-02-26 0:13 sergiodj+buildbot
2018-02-26 2:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 0:13 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 0aa13feeeb78fc9323bee329c4d91c30f25de121 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 0aa13feeeb78fc9323bee329c4d91c30f25de121
unrecognized/unsupported reloc message
It must get boring translating all the variants we have of
unrecognized/unsupported/invalid/unexpected reloc number. This patch
cuts down on the number of variations.
* aoutx.h, * coff-alpha.c, * coff-i860.c, * coff-m68k.c,
* coff-mcore.c, * coff-ppc.c, * coff-rs6000.c, * coff-sh.c,
* coff-tic4x.c, * coff-tic54x.c, * coff-tic80.c, * coff-w65.c,
* elf-bfd.h, * elf-m10300.c, * elf.c, * elf32-avr.c, * elf32-bfin.c,
* elf32-cr16.c, * elf32-cr16c.c, * elf32-cris.c, * elf32-crx.c,
* elf32-d10v.c, * elf32-d30v.c, * elf32-dlx.c, * elf32-epiphany.c,
* elf32-fr30.c, * elf32-frv.c, * elf32-i370.c, * elf32-i386.c,
* elf32-i960.c, * elf32-ip2k.c, * elf32-iq2000.c, * elf32-lm32.c,
* elf32-m32c.c, * elf32-m32r.c, * elf32-m68hc11.c, * elf32-m68hc12.c,
* elf32-m68k.c, * elf32-mcore.c, * elf32-mep.c, * elf32-metag.c,
* elf32-microblaze.c, * elf32-mips.c, * elf32-moxie.c,
* elf32-msp430.c, * elf32-mt.c, * elf32-nds32.c, * elf32-or1k.c,
* elf32-pj.c, * elf32-ppc.c, * elf32-rl78.c, * elf32-rx.c,
* elf32-s390.c, * elf32-sh.c, * elf32-spu.c, * elf32-tic6x.c,
* elf32-v850.c, * elf32-vax.c, * elf32-visium.c, * elf32-wasm32.c,
* elf32-xgate.c, * elf32-xtensa.c, * elf64-alpha.c,
* elf64-ia64-vms.c, * elf64-mips.c, * elf64-mmix.c,
* elf64-ppc.c, * elf64-s390.c, * elf64-sparc.c, * elf64-x86-64.c,
* elfn32-mips.c, * elfnn-aarch64.c, * elfnn-ia64.c,
* elfnn-riscv.c, * elfxx-mips.c, * elfxx-riscv.c, * elfxx-riscv.h,
* elfxx-sparc.c, * elfxx-sparc.h, * reloc.c: Standardize
unrecognized/unsupported reloc message.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] ELF linker messages
@ 2018-02-26 0:14 sergiodj+buildbot
2018-02-26 5:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 0:14 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9793eb77929a4ab2c0192d9bf5d3f8d20dd17394 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 9793eb77929a4ab2c0192d9bf5d3f8d20dd17394
ELF linker messages
This fixes a number of cases where we capitalized error messages or
printed a full-stop, and corrects "Dwarf" to "DWARF".
bfd/
* dwarf2.c, * elf-attrs.c, * elf-eh-frame.c, * elf.c, * elf32-gen.c,
* elflink.c: Standardize error/warning messages. Replace use of
linker callback einfo with _bfd_error_handler when possible.
ld/
* testsuite/ld-elf/indirect.exp,
* testsuite/ld-elf/pr22649-2ab-mips.msg,
* testsuite/ld-elf/pr22649-2cd-mips.msg,
* testsuite/ld-elf/pr22649.msg,
* testsuite/ld-elf/tls_common.exp,
* testsuite/ld-elfcomm/elfcomm.exp,
* testsuite/ld-arm/attr-merge-incompatible.d,
* testsuite/ld-tic6x/attr-compatibility-gnu-other.d,
* testsuite/ld-tic6x/attr-compatibility-other-gnu.d,
* testsuite/ld-tic6x/attr-compatibility-other-other.d,
* testsuite/ld-i386/warn1.d: Update expected error/warning messages.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] ARM and AArch64 messages
@ 2018-02-26 0:53 sergiodj+buildbot
2018-02-26 9:07 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 0:53 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 90b6238f06197c2abff953ab5920ae5b6d39f97f ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 90b6238f06197c2abff953ab5920ae5b6d39f97f
ARM and AArch64 messages
More standarization of error/warning messages. The ARM backend has
some multi-line error messages, which don't fit particularly well with
the GNU coding standard insistence that error messages shouldn't be
capitalized or have a full-stop. I've replaced the line breaks with
semicolons.
So for instance the following
system/path/to/ld: myobject.o: invalid special symbol `foo'.
system/path/to/ld: It must be a global or weak function symbol.
becomes
system/path/to/ld: myobject.o: invalid special symbol `foo'; it must be a global or weak function symbol
bfd/
* elf32-arm.c, * elfnn-aarch64.c: Standardize error/warning messages.
ld/
* testsuite/ld-aarch64/reloc-overflow-bad.d,
* testsuite/ld-arm/attr-merge-9.out,
* testsuite/ld-arm/attr-merge-arch-2.d,
* testsuite/ld-arm/attr-merge-unknown-1.d,
* testsuite/ld-arm/attr-merge-unknown-2.d,
* testsuite/ld-arm/attr-merge-unknown-2r.d,
* testsuite/ld-arm/attr-merge-unknown-3.d,
* testsuite/ld-arm/cmse-implib-errors.out,
* testsuite/ld-arm/cmse-new-earlier-later-implib.out,
* testsuite/ld-arm/cmse-new-implib-no-output.out,
* testsuite/ld-arm/cmse-new-implib-not-sg-in-implib.out,
* testsuite/ld-arm/cmse-new-implib.out,
* testsuite/ld-arm/cmse-new-wrong-implib.out,
* testsuite/ld-arm/cmse-veneers-no-gnu_sgstubs.out,
* testsuite/ld-arm/cmse-veneers-wrong-entryfct.out,
* testsuite/ld-arm/group-relocs-alu-bad-2.d,
* testsuite/ld-arm/group-relocs-alu-bad.d,
* testsuite/ld-arm/group-relocs-ldc-bad-2.d,
* testsuite/ld-arm/group-relocs-ldc-bad.d,
* testsuite/ld-arm/group-relocs-ldr-bad-2.d,
* testsuite/ld-arm/group-relocs-ldr-bad.d,
* testsuite/ld-arm/group-relocs-ldrs-bad-2.d,
* testsuite/ld-arm/group-relocs-ldrs-bad.d,
* testsuite/ld-arm/stm32l4xx-cannot-fix-far-ldm.d: Update.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] AOUT/COFF/PE messages
@ 2018-02-26 1:03 sergiodj+buildbot
2018-02-26 11:28 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 1:03 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 59d08d6ce8cb6c41691266e133304c961c270e85 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 59d08d6ce8cb6c41691266e133304c961c270e85
AOUT/COFF/PE messages
Capitalization, full-stops and unnecessary trailing \n fixes.
* aout-adobe.c, * aout-cris.c, * i386linux.c, * m68klinux.c,
* sparclinux.c, * coff-alpha.c, * coff-arm.c, * coff-mcore.c,
* coffcode.h, * coffgen.c, * cofflink.c, * ecoff.c, * pe-mips.c,
* peXXigen.c, * peicode.h: Standardize error/warning messages.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] BFD messages
@ 2018-02-26 1:16 sergiodj+buildbot
2018-02-26 13:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 1:16 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 6e05870c978aaa057b5ae0f525a2e9b803047ac8 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 6e05870c978aaa057b5ae0f525a2e9b803047ac8
BFD messages
bfd/
* archive.c, * bfd.c, * linker.c, * reloc.c, * stabs.c,
* syms.c: Standardize error/warning messages.
binutils/
* testsuite/binutils-all/mips/mips-reginfo-n32.d,
* testsuite/binutils-all/mips/mips-reginfo.d: Update.
gas/
* testsuite/gas/mips/reginfo-2.l: Update.
ld/
* testsuite/ld-arm/cmse-implib-errors.out,
* testsuite/ld-arm/cmse-new-earlier-later-implib.out,
* testsuite/ld-arm/cmse-new-implib-not-sg-in-implib.out,
* testsuite/ld-arm/cmse-new-wrong-implib.out,
* testsuite/ld-arm/cmse-veneers-no-gnu_sgstubs.out,
* testsuite/ld-arm/cmse-veneers-wrong-entryfct.out,
* testsuite/ld-cris/badgotr1.d,
* testsuite/ld-cris/tls-err-24.d,
* testsuite/ld-cris/tls-err-25.d,
* testsuite/ld-cris/tls-err-26.d,
* testsuite/ld-cris/tls-err-27.d,
* testsuite/ld-cris/tls-err-28.d,
* testsuite/ld-cris/tls-err-40.d,
* testsuite/ld-cris/tls-err-44.d,
* testsuite/ld-cris/tls-err-48.d,
* testsuite/ld-cris/tls-err-52.d,
* testsuite/ld-cris/tls-err-53.d,
* testsuite/ld-cris/tls-err-55.d,
* testsuite/ld-cris/tls-err-56.d,
* testsuite/ld-cris/tls-err-62.d,
* testsuite/ld-cris/tls-err-65.d,
* testsuite/ld-cris/tls-err-77.d,
* testsuite/ld-elf/empty-implib.out,
* testsuite/ld-elf/indirect.exp: Update.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] assorted target messages
@ 2018-02-26 1:28 sergiodj+buildbot
2018-02-26 15:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 1:28 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 38f14ab8fcfa4eab8bab417a5a165b7403ef9b0e ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 38f14ab8fcfa4eab8bab417a5a165b7403ef9b0e
assorted target messages
bfd/
* elf-m10300.c, * elf-s390-common.c, * elf32-arc.c, * elf32-cris.c,
* elf32-dlx.c, * elf32-frv.c, * elf32-i370.c, * elf32-lm32.c,
* elf32-m32r.c, * elf32-m68hc1x.c, * elf32-m68k.c,
* elf32-microblaze.c, * elf32-msp430.c, * elf32-nds32.c,
* elf32-nios2.c, * elf32-or1k.c, * elf32-rl78.c, * elf32-rx.c,
* elf32-score.c, * elf32-score7.c, * elf32-sh-symbian.c,
* elf32-sh.c, * elf32-spu.c, * elf32-v850.c, * elf32-xtensa.c,
* elf64-alpha.c, * elf64-ia64-vms.c, * elf64-mmix.c,
* elf64-sh64.c, * elf64-sparc.c, * elfnn-ia64.c, * elfxx-tilegx.c,
* mmo.c, * osf-core.c, * srec.c, * vms-alpha.c: Standardize
error/warning messages.
ld/
* testsuite/ld-cris/pcrelcp-1.d,
* testsuite/ld-mmix/start-2.d: Update.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] crx string overflow warning
@ 2018-02-26 1:40 sergiodj+buildbot
2018-02-26 18:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 1:40 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e95b887f85a192eb1597cd5d358673520029ad14 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: e95b887f85a192eb1597cd5d358673520029ad14
crx string overflow warning
gcc8 complains wrongly about the buffer not being large enough, at
least at -Og optimization.
* crx-dis.c (getregliststring): Allocate a large enough buffer
to silence false positive gcc8 warning.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Segfault on phdrs allocated but not created
@ 2018-02-26 1:53 sergiodj+buildbot
2018-02-26 20:59 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 1:53 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 6838f2bed6459514c1b0c549e6aa3fc7dbb1d7ec ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 6838f2bed6459514c1b0c549e6aa3fc7dbb1d7ec
Segfault on phdrs allocated but not created
A number of ARM tests show results like:
ld-new: no address assigned to the veneers output section .gnu.sgstubs
ld-new: can not size stub section: invalid operation
ld-new: warning: cannot find entry symbol _start; defaulting to 0000000000010074
ld-new: tmpdir/cmse-veneers-no-gnu_sgstubs: warning: allocated section `.text' not in segment
Segmentation fault
PASS: Secure gateway veneers: no .gnu.sgstubs section
The PASS despite the segv shows the danger of using "#..." to match
error output. This patch doesn't try to fix the testuite, but does
prevent the segfault.
* elf.c (assign_file_positions_except_relocs): Don't segfault
when actual number of phdrs is less than allocated. Delete
outdated comment. Formatting.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Move arch/tdesc.h to common/tdesc.h
@ 2018-02-26 12:02 sergiodj+buildbot
2018-02-26 22:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 12:02 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f46cd62a69b8050c7c30a53b29a781a9b5e9f062 ***
Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: f46cd62a69b8050c7c30a53b29a781a9b5e9f062
Move arch/tdesc.h to common/tdesc.h
gdb/
* arch/amd64.h: Use common/tdesc.h.
* arch/i386.c: Likewise.
* arch/i386.h: Likewise.
* arch/tic6x.c: Likewise.
* arch/tdesc.h: Move file from here...
* common/tdesc.h: ...to here.
* features/aarch64-core.c: Regenerate.
* features/aarch64-fpu.c: Regenerate.
* features/i386/32bit-avx.c: Regenerate.
* features/i386/32bit-avx512.c: Regenerate.
* features/i386/32bit-core.c: Regenerate.
* features/i386/32bit-linux.c: Regenerate.
* features/i386/32bit-mpx.c: Regenerate.
* features/i386/32bit-pkeys.c: Regenerate.
* features/i386/32bit-sse.c: Regenerate.
* features/i386/64bit-avx.c: Regenerate.
* features/i386/64bit-avx512.c: Regenerate.
* features/i386/64bit-core.c: Regenerate.
* features/i386/64bit-linux.c: Regenerate.
* features/i386/64bit-mpx.c: Regenerate.
* features/i386/64bit-pkeys.c: Regenerate.
* features/i386/64bit-segments.c: Regenerate.
* features/i386/64bit-sse.c: Regenerate.
* features/i386/x32-core.c: Regenerate.
* features/tic6x-c6xp.c: Regenerate.
* features/tic6x-core.c: Regenerate.
* features/tic6x-gp.c: Regenerate.
* target-descriptions.c: Use common/tdesc.h.
* target-descriptions.h: Likewise.
gdbserver/
* tdesc.c: Use common/tdesc.h.
* tdesc.h: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Re-write partial_die_info allocation in load_partial_dies
@ 2018-02-26 15:54 sergiodj+buildbot
2018-02-27 1:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 15:54 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT cd9983dd5f16803aa60e9fe1692b7e6716ac3927 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: cd9983dd5f16803aa60e9fe1692b7e6716ac3927
Re-write partial_die_info allocation in load_partial_dies
load_partial_dies has a "while (1)" loop to visit each die, and create
partial_die_info if needed in each iteration, like this,
part_die = XOBNEW (&cu->comp_unit_obstack, struct partial_die_info);
while (1)
{
if (foo1) continue;
if (foo2) continue;
read_partial_die (, , part_die, ,);
....
part_die = XOBNEW (&cu->comp_unit_obstack, struct partial_die_info);
};
the code was written in a way that spaces are allocated on necessary on
cu->comp_unit_obstack. I want to class-fy partial_die_info, but
partial_die_info ctor can't follow XOBNEW immediately, so this patch
rewrite this loop to:
while (1)
{
if (foo1) continue;
if (foo2) continue;
struct partial_die_info pdi;
read_partial_die (, , &pdi, ,);
part_die = XOBNEW (&cu->comp_unit_obstack, struct partial_die_info);
memcpy (part_die, &pdi, sizeof (pdi));
};
we create a local variable pdi, if we need it, call XOBNEW, and copy.
This also reduce one XOBNEW call. I measured the number of XOBNEW call in
load_partial_dies when gdb reads dwarf2read.o, without this patch, it is
18827, and with this patch, it is 18826.
gdb:
2018-026-26 Yao Qi <yao.qi@linaro.org>
* dwarf2read.c (load_partial_dies): Move the location of XOBNEW.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Initial support for variant parts
@ 2018-02-26 17:16 sergiodj+buildbot
2018-02-27 14:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 17:16 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 7c22600aabfd10e190e98fff0b7c2d69cd191325 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 7c22600aabfd10e190e98fff0b7c2d69cd191325
Initial support for variant parts
This adds some initial support for variant parts to gdbtypes.h. A
variant part is represented as a union. The union has a flag
indicating that it has a discriminant, and information about the
discriminant is attached using the dynamic property system.
2018-02-26 Tom Tromey <tom@tromey.com>
* value.h (value_union_variant): Declare.
* valops.c (value_union_variant): New function.
* gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): New macro.
(struct discriminant_info): New.
(enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: New
enumerator.
(struct main_type) <flag_discriminated_union>: New field.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Change find_partial_die_in_comp_unit to dwarf2_cu::find_partial_die
@ 2018-02-26 17:35 sergiodj+buildbot
2018-02-27 4:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 17:35 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d590ff257c81d5aac51928148ce74b0131bbf81c ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: d590ff257c81d5aac51928148ce74b0131bbf81c
Change find_partial_die_in_comp_unit to dwarf2_cu::find_partial_die
This patch changes find_partial_die_in_comp_unit to a dwarf2_cu method
find_partial_die.
gdb:
2018-02-26 Yao Qi <yao.qi@linaro.org>
* dwarf2read.c (struct dwarf2_cu) <find_partial_die>: New method.
(find_partial_die_in_comp_unit): Change it to
dwarf2_cu::find_partial_die.
(find_partial_die): Update.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Change frame_filter_flags to use DEF_ENUM_FLAGS_TYPE
@ 2018-02-26 18:06 sergiodj+buildbot
2018-02-27 23:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 18:06 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d4dd32824a1194718c81773804017ab546cb3aab ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: d4dd32824a1194718c81773804017ab546cb3aab
Change frame_filter_flags to use DEF_ENUM_FLAGS_TYPE
This changes frame_filter_flags to use DEF_ENUM_FLAGS_TYPE, and
updates all the uses. It also changes the enum constants to use <<,
as suggested by Sergio.
ChangeLog
2018-02-26 Tom Tromey <tom@tromey.com>
* stack.c (backtrace_command_1): Update.
* python/python-internal.h (gdbpy_apply_frame_filter): Change type
of "flags".
* python/py-framefilter.c (py_print_frame)
(gdbpy_apply_frame_filter): Change type of "flags".
* mi/mi-cmd-stack.c (mi_apply_ext_lang_frame_filter): Change type
of "flags".
(mi_cmd_stack_list_frames, mi_cmd_stack_list_locals)
(mi_cmd_stack_list_args, mi_cmd_stack_list_variables): Update.
* extension.h (enum frame_filter_flag): Rename from
frame_filter_flags.
(frame_filter_flags): Define using DEF_ENUM_FLAGS_TYPE.
(apply_ext_lang_frame_filter): Change type of "flags".
* extension.c (apply_ext_lang_frame_filter): Change type of
"flags".
* extension-priv.h (struct extension_language_ops)
<apply_frame_filter>: Change type of "flags".
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Move read_partial_die to partial_die_info::read
@ 2018-02-26 18:41 sergiodj+buildbot
2018-02-27 10:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 18:41 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 48fbe735fb8f0e65976d2b9dd345bf2f947ad258 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 48fbe735fb8f0e65976d2b9dd345bf2f947ad258
Move read_partial_die to partial_die_info::read
gdb:
2018-02-26 Yao Qi <yao.qi@linaro.org>
* dwarf2read.c (struct partial_die_info) <read>: New method.
(read_partial_die): Remove the declaration.
(load_partial_dies): Update.
(partial_die_info::partial_die_info):
(read_partial_die): Change it to partial_die_info::read.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] MIPS: Reorder ABI determination ahead of target description loading
@ 2018-02-26 19:59 sergiodj+buildbot
2018-02-28 1:21 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 19:59 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 37c33887bda54afb8fbf4786d400ce549c0e3de8 ***
Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 37c33887bda54afb8fbf4786d400ce549c0e3de8
MIPS: Reorder ABI determination ahead of target description loading
Move ABI determination code ahead of target description loading so that
architecture information can be adjusted according to the ABI selected,
and then used in OS dependent register information initialization needed
for target description processing. No functional change.
gdb/
* gdb/mips-tdep.c (mips_gdbarch_init): Reorder ABI determination
ahead of target description loading.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Handle DW_TAG_variant_part and DW_TAG_variant
@ 2018-02-27 0:14 sergiodj+buildbot
2018-02-27 18:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-27 0:14 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2ddeaf8a7d64094f4caf6cdc412d8162f49f73a1 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 2ddeaf8a7d64094f4caf6cdc412d8162f49f73a1
Handle DW_TAG_variant_part and DW_TAG_variant
This changes dwarf2read to understand DW_TAG_variant_part and
DW_TAG_variant.
Note that DW_AT_discr_list is not handled. I did not need this for
Rust. I imagine this should not be too hard to add later, should
someone need it. Meanwhile I have gdb emit a complaint if it is seen.
There is a lurking issue concerning the placement of the discriminant
in the DWARF. For Rust, I ended up following the letter of the
standard and having the discriminant be a child of the
DW_TAG_variant_part. However, GCC's Ada support does not do this.
Pierre-Marie filed this with the DWARF committee:
http://dwarfstd.org/ShowIssue.php?issue=180123.1
However as that is read-only, if you have comments you might consider
adding them to the GCC bug:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83935
Finally, there is a DWARF extension lurking in here. In Rust, a
univariant enum will not have a discriminant. However, in order to
unify the representation of all data-carrying enums, I've made LLVM
(and my forthcoming rustc patch) emit a univariant enum using a
DW_TAG_variant with a single variant part and without DW_AT_discr.
The lack of this DW_AT_discr is the extension. I will submit an issue
on dwarfstd.org about this.
2018-02-26 Tom Tromey <tom@tromey.com>
* dwarf2read.c (struct variant_field): New.
(struct nextfield) <variant>: New field.
(dwarf2_add_field): Handle DW_TAG_variant_part.
(dwarf2_attach_fields_to_type): Attach a discriminant_info to a
discriminated union.
(read_structure_type): Handle DW_TAG_variant_part.
(handle_struct_member_die): New function, extracted from
process_structure_scope. Handle DW_TAG_variant.
(process_structure_scope): Handle discriminated unions. Call
handle_struct_member_die.
2018-02-26 Tom Tromey <tom@tromey.com>
* gdb.dwarf2/variant.c: New file.
* gdb.dwarf2/variant.exp: New file.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Explicitly specify common tdesc.h for use with aarch64.h
@ 2018-02-27 16:46 sergiodj+buildbot
2018-02-28 12:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-27 16:46 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 0c305b6176408347afd8452abb8fe974a7e3f999 ***
Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: 0c305b6176408347afd8452abb8fe974a7e3f999
Explicitly specify common tdesc.h for use with aarch64.h
gdb/
* arch/aarch64.h: Use common/tdesc.h.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Change target_write_memory_blocks to use std::vector
@ 2018-02-27 19:20 sergiodj+buildbot
2018-02-28 15:29 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-27 19:20 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 55089490f79ce1ddb9610fd6abeeaf896825fb71 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 55089490f79ce1ddb9610fd6abeeaf896825fb71
Change target_write_memory_blocks to use std::vector
This changes target_write_memory_blocks to use std::vector, rather
than VEC. This allows the removal of some cleanups.
This version incorporates the additions that Simon made.
Regression tested by the buildbot.
ChangeLog
2018-02-27 Simon Marchi <simon.marchi@polymtl.ca>
Tom Tromey <tom@tromey.com>
* target.h (memory_write_request_s): Remove typedef. Don't define
VEC.
(target_write_memory_blocks): Change argument to std::vector.
(struct memory_write_request): Add constructor.
* target-memory.c (compare_block_starting_address): Return bool.
Change argument types.
(claim_memory): Change arguments to use std::vector.
(split_regular_and_flash_blocks, blocks_to_erase)
(compute_garbled_blocks): Likewise.
(cleanup_request_data, cleanup_write_requests_vector): Remove.
(target_write_memory_blocks): Change argument to std::vector.
* symfile.c (struct load_section_data): Add constructor and
destructor. Use std::vector for "requests".
(struct load_progress_data): Add initializers.
(load_section_callback): Update. Use "new".
(clear_memory_write_data): Remove.
(generic_load): Update.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Update get_args documentation
@ 2018-02-27 21:14 sergiodj+buildbot
2018-02-28 18:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-27 21:14 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e05cac70d855cd404eae9aeea5fcfb83ce8aabcf ***
Author: Phil Muldoon <pmuldoon@redhat.com>
Branch: master
Commit: e05cac70d855cd404eae9aeea5fcfb83ce8aabcf
Update get_args documentation
This patch adds argument compilation documentation, expanding on the
already existing comments, giving a more thorough explanation of
the source of the arguments used in the final argument string.
gdb/ChangeLog:
* compile/compile.c (get_args): Add additional comments
explaining function.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Workaround a FreeBSD ptrace() bug with clearing thread events.
@ 2018-02-28 1:47 sergiodj+buildbot
2018-02-28 19:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-28 1:47 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f169cfdc08761a3d9fcd587ad8661102672403ec ***
Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: f169cfdc08761a3d9fcd587ad8661102672403ec
Workaround a FreeBSD ptrace() bug with clearing thread events.
When multiple threads within a process wish to report STOPPED events
from wait(), the kernel picks one thread event as the thread event to
report. The chosen thread event is retrieved via PT_LWPINFO by
passing the process ID as the request pid. If multiple events are
pending, then the subsequent wait() after resuming a process will
report another STOPPED event after resuming the process to handle the
next thread event and so on.
A single thread event is cleared as a side effect of resuming the
process with PT_CONTINUE, PT_STEP, etc. In older kernels, however,
the request pid was used to select which thread's event was cleared
rather than always clearing the event that was just reported. To
avoid clearing the event of the wrong LWP, always pass the process ID
instead of an LWP ID to PT_CONTINUE or PT_SYSCALL.
In the case of stepping, the process ID cannot be used with PT_STEP
since it would step the thread that reported an event which may not be
the thread indicated by PTID. For stepping, use PT_SETSTEP to enable
stepping on the desired thread before resuming the process via
PT_CONTINUE instead of using PT_STEP.
This manifested as a failure in the
gdb.threads/continue-pending-status.exp test. Specifically, if thread
2 reported a breakpoint and the test thus switched to thread 3 before
continuing, thread 3's event (if any) was discarded and thread 2's
breakpoint remained pending and was reported a second time as a
duplicate event. As a result, the PC was decremented twice for the
same breakpoint resulting in an illegal instruction fault on x86.
gdb/ChangeLog:
* fbsd-nat.c (fbsd_resume): Use PT_SETSTEP for stepping and a
wildcard process pid for super_resume for kernels with a
specific bug.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix potential integer overflow when reading corrupt dwarf1 debug information.
@ 2018-02-28 10:29 sergiodj+buildbot
2018-02-28 21:54 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-28 10:29 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT eef104664efb52965d85a28bc3fc7c77e52e48e2 ***
Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: eef104664efb52965d85a28bc3fc7c77e52e48e2
Fix potential integer overflow when reading corrupt dwarf1 debug information.
PR 22894
* dwarf1.c (parse_die): Check the length of form blocks before
advancing the data pointer.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] testsuite: Restore gdb_is_target_remote_prompt
@ 2018-02-28 14:13 sergiodj+buildbot
2018-03-01 1:44 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-28 14:13 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 3083294d65393a31522586e058500f6abda29b83 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 3083294d65393a31522586e058500f6abda29b83
testsuite: Restore gdb_is_target_remote_prompt
In patch
Add test for load command
3275ef477498e0500d7ea440f1bc51787acf4610
I removed gdb_is_target_remote_prompt, but did not realize it was used
in mi_is_target_remote. This makes the gdb.mi/mi-nonstop.exp crash, for
example:
ERROR: (DejaGnu) proc "gdb_is_target_remote_prompt {[(]gdb[)]
}" does not exist.
The error code is TCL LOOKUP COMMAND gdb_is_target_remote_prompt
The info on the error is:
invalid command name "gdb_is_target_remote_prompt"
while executing
"::tcl_unknown gdb_is_target_remote_prompt {[(]gdb[)]
}"
("uplevel" body line 1)
invoked from within
"uplevel 1 ::tcl_unknown $args"
This patch restores it.
gdb/testsuite/ChangeLog:
* lib/gdb.exp (gdb_is_target_1): Add prompt_regexp parameter and
use it.
(gdb_is_target_remote_prompt): New proc.
(gdb_is_target_remote): Use gdb_is_target_remote_prompt.
(gdb_is_target_native): Pass prompt parameter to
gdb_is_target_1.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Create new common/pathstuff.[ch]
@ 2018-02-28 17:02 sergiodj+buildbot
2018-03-01 3:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-28 17:02 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b4987c956dfa44ca9fd8552f63e15f5fa094b2a4 ***
Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: b4987c956dfa44ca9fd8552f63e15f5fa094b2a4
Create new common/pathstuff.[ch]
This commit moves the path manipulation routines found on utils.c to a
new common/pathstuff.c, and updates the Makefile.in's accordingly.
The routines moved are "gdb_realpath", "gdb_realpath_keepfile" and
"gdb_abspath".
This will be needed because gdbserver will have to call "gdb_abspath"
on my next patch, which implements a way to expand the path of the
inferior provided by the user in order to allow specifying just the
binary name when starting gdbserver, like:
$ gdbserver :1234 a.out
With the recent addition of the startup-with-shell feature on
gdbserver, this scenario doesn't work anymore if the user doesn't have
the current directory listed in the PATH variable.
I had to do a minor adjustment on "gdb_abspath" because we don't have
access to "tilde_expand" on gdbserver, so now the function is using
"gdb_tilde_expand" instead. Otherwise, the code is the same.
Regression tested on the BuildBot, without regressions.
gdb/ChangeLog:
2018-02-28 Sergio Durigan Junior <sergiodj@redhat.com>
* Makefile.in (COMMON_SFILES): Add "common/pathstuff.c".
(HFILES_NO_SRCDIR): Add "common/pathstuff.h".
* auto-load.c: Include "common/pathstuff.h".
* common/common-def.h (current_directory): Move here.
* common/gdb_tilde_expand.c (gdb_tilde_expand_up): New
function.
* common/gdb_tilde_expand.h (gdb_tilde_expand_up): New
prototype.
* common/pathstuff.c: New file.
* common/pathstuff.h: New file.
* compile/compile.c: Include "common/pathstuff.h".
* defs.h (current_directory): Move to "common/common-defs.h".
* dwarf2read.c: Include "common/pathstuff.h".
* exec.c: Likewise.
* guile/scm-safe-call.c: Likewise.
* linux-thread-db.c: Likewise.
* main.c: Likewise.
* nto-tdep.c: Likewise.
* objfiles.c: Likewise.
* source.c: Likewise.
* symtab.c: Likewise.
* utils.c: Include "common/pathstuff.h".
(gdb_realpath): Move to "common/pathstuff.c".
(gdb_realpath_keepfile): Likewise.
(gdb_abspath): Likewise.
* utils.h (gdb_realpath): Move to "common/pathstuff.h".
(gdb_realpath_keepfile): Likewise.
(gdb_abspath): Likewise.
gdb/gdbserver/ChangeLog:
2018-02-28 Sergio Durigan Junior <sergiodj@redhat.com>
* Makefile.in (SFILES): Add "$(srcdir)/common/pathstuff.c".
(OBJS): Add "pathstuff.o".
* server.c (current_directory): New global variable.
(captured_main): Initialize "current_directory".
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add missing translations to ALL_LINGUAS
@ 2018-02-28 23:57 sergiodj+buildbot
2018-03-01 8:08 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-02-28 23:57 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e184813fdb0578fe7c5a3f3fc39b56d0ee4d1505 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: e184813fdb0578fe7c5a3f3fc39b56d0ee4d1505
Add missing translations to ALL_LINGUAS
binutils/
* configure.ac (ALL_LINGUAS): Add sr. Sort.
* configure: Regenerate.
gas/
* configure.ac (ALL_LINGUAS): Add uk. Sort.
* configure: Regenerate.
gprof/
* configure.ac (ALL_LINGUAS): Add it, ro, ru, uk. Sort.
* configure: Regenerate.
ld/
* configure.ac (ALL_LINGUAS): Add ja. Sort.
* configure: Regenerate.
opcodes/
* configure.ac (ALL_LINGUAS): Sort.
* configure: Regenerate.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] btrace, gdbserver: check btrace target pointers
@ 2018-03-01 11:41 sergiodj+buildbot
2018-03-01 13:21 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-01 11:41 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b1223e789040e9e8cdc6869a8a1fd1fd7acc109d ***
Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: b1223e789040e9e8cdc6869a8a1fd1fd7acc109d
btrace, gdbserver: check btrace target pointers
By removing the supports_btrace gdbserver target method we relied on GDB
trying to enable branch tracing and failing on the attempt.
For targets that do not provide the btrace methods, however, an initial
request from GDB for the branch trace configuration to detect whether
gdbserver is already recording resulted in a protocol error.
Have the btrace target methods throw a "Target does not suppor branch
tracing" error and be prepared to handle exceptions in all functions that
call btrace target methods. We therefore turn the target_* macros into
static inline functions.
Also remove the additional btrace target method checks that resulted in
the above protocol error.
Thanks to Maciej W. Rozycki <macro@mips.com> for reporting this.
gdbserver/
* target.h (target_enable_btrace, target_disable_btrace)
(target_read_btrace, target_read_btrace_conf): Turn macro into
inline function. Throw error if target method is not defined.
* server.c (handle_qxfer_btrace, handle_qxfer_btrace_conf): Remove
check for btrace target method. Be prepared to handle exceptions
from btrace target methods.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: Encode AVX256/AVX512 vpsub[bwdq] with VEX128/EVEX128
@ 2018-03-01 14:29 sergiodj+buildbot
2018-03-01 15:02 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-01 14:29 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 8305403a1ffa8e551fd1c7bd88af1a65c0ba747c ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 8305403a1ffa8e551fd1c7bd88af1a65c0ba747c
x86: Encode AVX256/AVX512 vpsub[bwdq] with VEX128/EVEX128
When 2 source registers are identical, AVX256 and AVX512 vpsub[bwdq]
instructions can be encoded with VEX128 or EVEX128 encodings.
gas/
* config/tc-i386.c (optimize_encoding): Optimize AVX256 and
AVX512 vpsub[bwdq] instructions.
* testsuite/gas/i386/optimize-1.s: Add tests for AVX256 and
AVX512 vpsub[bwdq] instructions.
* testsuite/gas/i386/x86-64-optimize-2.s: Likewise.
* testsuite/gas/i386/optimize-1.d: Updated.
* testsuite/gas/i386/x86-64-optimize-2.d: Likewise.
opcodes/
* * i386-opc.tbl: Add "Optimize" to AVX256 and AVX512
vpsub[bwdq] instructions.
* i386-tbl.h: Regenerated.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] RISC-V: Fix symbol size bug when relaxation deletes bytes.
@ 2018-03-01 22:37 sergiodj+buildbot
2018-03-01 23:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-01 22:37 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 788af978df01c3667be99a1607b774f5fa844113 ***
Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 788af978df01c3667be99a1607b774f5fa844113
RISC-V: Fix symbol size bug when relaxation deletes bytes.
bfd/
PR 22756
* elfnn-riscv.c (riscv_relax_delete_bytes): When adjust st_size, use
else if instead of if.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Improve gcore shell quoting and portability
@ 2018-03-01 22:44 sergiodj+buildbot
2018-03-02 1:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-01 22:44 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e1e6f073a9f5d7c3183cb8096fb24a42c28ba36b ***
Author: Georg Sauthoff <mail@georg.so>
Branch: master
Commit: e1e6f073a9f5d7c3183cb8096fb24a42c28ba36b
Improve gcore shell quoting and portability
The gcore shell script (gdb/gcore.in) doesn't quote its variables
enough.
For example, trying to write a core file with - say - a space
ungraciously fails like this:
$ gcore -o 'foo bar' 6270
/usr/bin/gcore: line 92: [: foo: binary operator expected
gcore: failed to create foo bar.6270
Similarly, one can inject meta characters like * (by accident)
that may yield unexpected results, e.g. as in:
$ gcore -o foobar '*'
This change fixes these issues in several places.
Aso, since the script uses array syntax, the patch changes the
the shell in the first line from `/bin/sh` to /bin/bash`.
POSIX doesn't specify the array syntax for shell, thus, the
script doesn't work on systems where /bin/sh is linked to - say -
dash.
Since the source gcore.in already is processed by a pre-processor
one could even auto-detect the path to bash and thus dynamically
generate the first line. For systems where bash isn't available
via /bin/bash. But I think this would be overkill and /bin/bash
is good enough as most systems probably have it.
gdb/ChangeLog:
PR gdb/22888
* gcore.in: Quote variables and switch interpreter to bash.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] [GDB/testsuite] Use %progbits in watch-loc.c
@ 2018-03-02 12:07 sergiodj+buildbot
2018-03-02 13:00 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-02 12:07 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ecc054c097e7ced281d02ef9632eb0261a410b96 ***
Author: Thomas Preud'homme <thomas.preudhomme@arm.com>
Branch: master
Commit: ecc054c097e7ced281d02ef9632eb0261a410b96
[GDB/testsuite] Use %progbits in watch-loc.c
While using @progbits in .pushsection work on some targets, it does not
work on arm target where this introduces a comment. This patch replaces
its use in gdb.dlang/watch-loc.c and gdb.mi/dw2-ref-missing-frame-func.c
by %progbits which should work on all targets since it is used in
target-independent elf/section7.s GAS test.
2018-03-02 Thomas Preud'homme <thomas.preudhomme@arm.com>
gdb/testsuite/
* gdb.dlang/watch-loc.c: Use %progbits instead of @progbits.
* gdb.mi/dw2-ref-missing-frame-func.c: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] opcodes error messages
@ 2018-03-03 1:20 sergiodj+buildbot
2018-03-03 1:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-03 1:20 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a6743a5420aa02a0550b0f7be004f6c06e90ce21 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: a6743a5420aa02a0550b0f7be004f6c06e90ce21
opcodes error messages
Another patch aimed at making binutils comply with the GNU coding
standard. The generated files require
https://sourceware.org/ml/cgen/2018-q1/msg00004.html
cpu/
* frv.opc: Include opintl.h.
(add_next_to_vliw): Use opcodes_error_handler to print error.
Standardize error message.
(fr500_check_insn_major_constraints, frv_vliw_add_insn): Likewise.
opcodes/
* sysdep.h (opcodes_error_handler): Define.
(_bfd_error_handler): Declare.
* Makefile.am: Remove stray #.
* opc2c.c (main): Remove bogus -l arg handling. Print "DO NOT
EDIT" comment.
* aarch64-dis.c, * arc-dis.c, * arm-dis.c, * avr-dis.c,
* d30v-dis.c, * h8300-dis.c, * mmix-dis.c, * ppc-dis.c,
* riscv-dis.c, * s390-dis.c, * sparc-dis.c, * v850-dis.c: Use
opcodes_error_handler to print errors. Standardize error messages.
* msp430-decode.opc, * nios2-dis.c, * rl78-decode.opc: Likewise,
and include opintl.h.
* nds32-asm.c: Likewise, and include sysdep.h and opintl.h.
* i386-gen.c: Standardize error messages.
* msp430-decode.c, * rl78-decode.c, rx-decode.c: Regenerate.
* Makefile.in: Regenerate.
* epiphany-asm.c, * epiphany-desc.c, * epiphany-dis.c,
* epiphany-ibld.c, * fr30-asm.c, * fr30-desc.c, * fr30-dis.c,
* fr30-ibld.c, * frv-asm.c, * frv-desc.c, * frv-dis.c, * frv-ibld.c,
* frv-opc.c, * ip2k-asm.c, * ip2k-desc.c, * ip2k-dis.c, * ip2k-ibld.c,
* iq2000-asm.c, * iq2000-desc.c, * iq2000-dis.c, * iq2000-ibld.c,
* lm32-asm.c, * lm32-desc.c, * lm32-dis.c, * lm32-ibld.c,
* m32c-asm.c, * m32c-desc.c, * m32c-dis.c, * m32c-ibld.c,
* m32r-asm.c, * m32r-desc.c, * m32r-dis.c, * m32r-ibld.c,
* mep-asm.c, * mep-desc.c, * mep-dis.c, * mep-ibld.c, * mt-asm.c,
* mt-desc.c, * mt-dis.c, * mt-ibld.c, * or1k-asm.c, * or1k-desc.c,
* or1k-dis.c, * or1k-ibld.c, * xc16x-asm.c, * xc16x-desc.c,
* xc16x-dis.c, * xc16x-ibld.c, * xstormy16-asm.c, * xstormy16-desc.c,
* xstormy16-dis.c, * xstormy16-ibld.c: Regenerate.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Make delim_string_to_char_ptr_vec return an std::vector
@ 2018-03-03 4:46 sergiodj+buildbot
2018-03-03 5:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-03 4:46 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e80aaf6183c6692ecc167bf26cbdc53f8f1a55f0 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: e80aaf6183c6692ecc167bf26cbdc53f8f1a55f0
Make delim_string_to_char_ptr_vec return an std::vector
This patch makes delim_string_to_char_ptr_vec and all related functions
use std::vector of gdb::unique_xmalloc_ptr. This allows getting rid of
make_cleanup_free_char_ptr_vec. Returning a vector of
unique_xmalloc_ptr instead of std::string allows to minimize the impacts
on the calling code. We can evaluate later whether we could/should
return a vector of std::strings instead.
gdb/ChangeLog:
* common/gdb_vecs.h (make_cleanup_free_char_ptr_vec): Remove.
(delim_string_to_char_ptr_vec): Return std::vector of
gdb::unique_xmalloc_ptr.
(dirnames_to_char_ptr_vec_append): Take std::vector of
gdb::unique_xmalloc_ptr.
(dirnames_to_char_ptr_vec): Return std::vector of
gdb::unique_xmalloc_ptr.
* common/gdb_vecs.c (delim_string_to_char_ptr_vec_append):
Take std::vector of gdb::unique_xmalloc_ptr, adjust the code.
(delim_string_to_char_ptr_vec): Return an std::vector of
gdb::unique_xmalloc_ptr, adjust the code.
(dirnames_to_char_ptr_vec_append): Take an std::vector of
gdb::unique_xmalloc_ptr, adjust the code.
(dirnames_to_char_ptr_vec): Return an std::vector of
gdb::unique_xmalloc_ptr, adjust the code.
* auto-load.c (auto_load_safe_path_vec): Change type to
std::vector of gdb::unique_xmalloc_ptr.
(auto_load_expand_dir_vars): Return an std::vector of
gdb::unique_xmalloc_ptr, adjust the code.
(auto_load_safe_path_vec_update): Adjust.
(filename_is_in_auto_load_safe_path_vec): Adjust.
(auto_load_objfile_script_1): Adjust.
* build-id.c (build_id_to_debug_bfd): Adjust.
* linux-thread-db.c (thread_db_load_search): Adjust.
* source.c (add_path): Adjust.
(openp): Adjust.
* symfile.c (find_separate_debug_file): Adjust.
* utils.c (do_free_char_ptr_vec): Remove.
(make_cleanup_free_char_ptr_vec): Remove.
gdb/gdbserver/ChangeLog:
* server.c (parse_debug_format_options): Adjust to
delim_string_to_char_ptr_vec changes.
* thread-db.c (thread_db_load_search): Adjust to
dirnames_to_char_ptr_vec changes.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Make program_space::deleted_solibs a vector of std::string
@ 2018-03-03 5:05 sergiodj+buildbot
2018-03-03 7:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-03 5:05 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 6fb16ce6eaba92b86a22eac58eb0eb61b3fd8804 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 6fb16ce6eaba92b86a22eac58eb0eb61b3fd8804
Make program_space::deleted_solibs a vector of std::string
This allows removing a usage of free_char_ptr_vec.
gdb/ChangeLog:
* progspace.h (struct program_space) <deleted_solibs>: Change
type to std::vector<std::string>.
* progspace.c (clear_program_space_solib_cache): Adjust.
* breakpoint.c (print_solib_event): Adjust.
(check_status_catch_solib): Adjust.
* solib.c (update_solib_list): Adjust.
* ui-out.h (class ui_out) <field_string>: New overload.
* ui-out.c (ui_out::field_string): New overload.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove free_char_ptr_vec
@ 2018-03-03 8:16 sergiodj+buildbot
2018-03-03 11:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-03 8:16 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 54693cf5f11bf292ae308604caf6e866dbb03e6f ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 54693cf5f11bf292ae308604caf6e866dbb03e6f
Remove free_char_ptr_vec
Nothing is using it anymore.
gdb/ChangeLog:
* common/gdb_vecs.c (free_char_ptr_vec): Remove.
* common/gdb_vecs.h (free_char_ptr_vec): Remove.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Implement "to_stopped_by_hw_breakpoint" for x86 debug registers.
@ 2018-03-04 5:54 sergiodj+buildbot
2018-03-04 6:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-04 5:54 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 12279366d71627bfbdd74d1a6675dca825d8feca ***
Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: 12279366d71627bfbdd74d1a6675dca825d8feca
Implement "to_stopped_by_hw_breakpoint" for x86 debug registers.
Report that a thread is stopped by a hardware breakpoint if a non-data
watchpoint is set in DR6. This change should be a no-op since a target
still needs to implement the "to_supports_stopped_by_hw_breakpoint"
method before this function is used.
gdb/ChangeLog:
* nat/x86-dregs.c (x86_dr_stopped_by_hw_breakpoint): New function.
* nat/x86-dregs.h (x86_dr_stopped_by_hw_breakpoint): New
prototype.
* x86-nat.c (x86_stopped_by_hw_breakpoint): New function.
(x86_use_watchpoints): Set "stopped_by_hw_breakpoint" target
method.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Propagate gdb_disassembly_flags to btrace_print_lines
@ 2018-03-05 1:19 sergiodj+buildbot
2018-03-05 1:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-05 1:19 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 3dea1ef72c646d808e5b287e98253f3b8670c450 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 3dea1ef72c646d808e5b287e98253f3b8670c450
Propagate gdb_disassembly_flags to btrace_print_lines
This function can take the flags as the gdb_disassembly_flags type
instead of int.
gdb/ChangeLog:
* record-btrace.c (btrace_print_lines): Change type of flags to
gdb_disassembly_flags.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb/amd64: Ignore zero sized fields when calling functions
@ 2018-03-06 10:29 sergiodj+buildbot
2018-03-06 11:08 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-06 10:29 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 5dc4391345f6e86906a57af1434025cfb47b4100 ***
Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 5dc4391345f6e86906a57af1434025cfb47b4100
gdb/amd64: Ignore zero sized fields when calling functions
In some cases passing an argument to a function on amd64, or attempting
to fetch the return value, can trigger an assertion failure within GDB.
An example of a type that would trigger such an error is:
struct foo_t
{
long double a;
struct {
struct {
/* Empty. */
} es1;
} s1;
};
GCC does permit empty structures, so we should probably support this.
The test that exposes this bug is in the next commit along with the
RiscV support.
gdb/ChangeLog:
* amd64-tdep.c (amd64_classify_aggregate): Ignore zero sized
fields within aggregates.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] btrace: Remove VEC cleanups
@ 2018-03-06 15:24 sergiodj+buildbot
2018-03-06 19:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-06 15:24 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 531270084129e069772e68ead40c97404d1c0dd7 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 531270084129e069772e68ead40c97404d1c0dd7
btrace: Remove VEC cleanups
This patch replaces two VEC(tp_t) with std::vector<thread_info *>, which
allows to remove two cleanups. To make it easier to map the old code to
the new code, I added the ordered_remove and unordered_remove functions,
which operate on std::vector and do the same as VEC's
ordered_remove/unordered_remove.
gdb/ChangeLog:
* record-btrace.c (record_btrace_maybe_mark_async_event): Change
parameter types to std::vector. Use bool.
(record_btrace_wait): Replace VEC(tp_t) with
std::vector<thread_info *>.
* common/gdb_vecs.h (unordered_remove, ordered_remove): New.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] btrace: Remove ui_out cleanups
@ 2018-03-06 17:58 sergiodj+buildbot
2018-03-06 20:44 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-06 17:58 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 7ea78b5973525193eda8e379cc351c7804653216 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 7ea78b5973525193eda8e379cc351c7804653216
btrace: Remove ui_out cleanups
This patch replaces the cleanups that close the list and tuple of the
btrace instruction history output with ui_out_emit_tuple and
ui_out_emit_list.
This allows removing make_cleanup_ui_out_tuple_begin_end and
make_cleanup_ui_out_list_begin_end.
This patch (along with the previous ones in the series) was regtested on
the buildbot.
gdb/ChangeLog:
* record-btrace.c (btrace_print_lines): Replace cleanup
parameter with RAII equivalents.
(btrace_insn_history): Replace cleanup with RAII equivalents.
* ui-out.h (make_cleanup_ui_out_list_begin_end,
make_cleanup_ui_out_tuple_begin_end): Remove.
* ui-out.c (struct ui_out_end_cleanup_data, do_cleanup_end,
make_cleanup_ui_out_end, make_cleanup_ui_out_tuple_begin_end,
make_cleanup_ui_out_list_begin_end): Remove.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb/riscv: Remove partial target description support
@ 2018-03-06 20:09 sergiodj+buildbot
2018-03-07 0:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-06 20:09 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9add17f218409f357d5ed8b831c777ac93f41ec4 ***
Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 9add17f218409f357d5ed8b831c777ac93f41ec4
gdb/riscv: Remove partial target description support
Some parts of the target description support were committed with the
initial riscv patch. As target descriptions are not currently supported
on riscv this commit removes the two pieces for code that relate to
target description support.
It is expected that target description support will be added in the
future, at which point this, or similar code will be added back.
gdb/ChangeLog:
* riscv-tdep.c (riscv_register_name): Remove target description
support.
(riscv_gdbarch_init): Remove target description check.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb/riscv: Remove 'Contributed by....' comments
@ 2018-03-06 20:30 sergiodj+buildbot
2018-03-06 23:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-06 20:30 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c9486dfe2753a3a9683dbb131ecfb4f5808a27c1 ***
Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: c9486dfe2753a3a9683dbb131ecfb4f5808a27c1
gdb/riscv: Remove 'Contributed by....' comments
The GDB coding standard states these lines should never have been
added.
gdb/ChangeLog:
* riscv-tdep.c: Remove 'Contributed by ...' lines from header
comment.
* riscv-tdep.h: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] mips64 rtype_to_howto error status
@ 2018-03-07 7:01 sergiodj+buildbot
2018-03-07 7:39 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-07 7:01 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 0118219e1850a05ceb181a4f47a6906c01c17c83 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 0118219e1850a05ceb181a4f47a6906c01c17c83
mips64 rtype_to_howto error status
* elf64-mips.c (mips_elf64_rtype_to_howto): Return NULL on error.
(mips_elf64_slurp_one_reloc_table): Pass on error.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb: Add riscv to list of architectures with a save_reggroup
@ 2018-03-07 17:55 sergiodj+buildbot
2018-03-07 19:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-07 17:55 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ea005f31ca7a823680c70a75ae073bee52487859 ***
Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: ea005f31ca7a823680c70a75ae073bee52487859
gdb: Add riscv to list of architectures with a save_reggroup
The regcache cooked_read test needs to know which architectures have a
save_reggroup, riscv does and needs adding to the list.
gdb/ChangeLog:
* regcache.c (cooked_read_test): Add riscv to the list of
architectures that have a save_reggroup.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86/Intel: correct disassembly of fsub*/fdiv*
@ 2018-03-08 8:06 sergiodj+buildbot
2018-03-08 11:06 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-08 8:06 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d53e6b98a2599ba4ce6ad14f711b76e44a32eea5 ***
Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: d53e6b98a2599ba4ce6ad14f711b76e44a32eea5
x86/Intel: correct disassembly of fsub*/fdiv*
fsub/fsubr/fsubp/fsubrp as well as fdiv/fdivr/fdivp/fdivrp disassembly
should match (a) the Intel SDM and (b) respective input fed to gas (both
of course with the exception of when we intentionally convert bogus
insns, accompanied by a warning).
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: bogus VMOVD with 64-bit operands should only allow for registers
@ 2018-03-08 8:27 sergiodj+buildbot
2018-03-08 9:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-08 8:27 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2907c2f55555de6b1df9a0262629003f4856807d ***
Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 2907c2f55555de6b1df9a0262629003f4856807d
x86: bogus VMOVD with 64-bit operands should only allow for registers
These templates exist solely to satisfy gcc's needs, and gcc only
produces these with register operands.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: drop {X,Y,Z}MMWORD_MNEM_SUFFIX
@ 2018-03-08 8:54 sergiodj+buildbot
2018-03-08 16:25 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-08 8:54 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d2224064f1a70969a77a8a82b117489793d6653e ***
Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: d2224064f1a70969a77a8a82b117489793d6653e
x86: drop {X,Y,Z}MMWORD_MNEM_SUFFIX
They aren't really useful (anymore?): The conflicting operand size check
isn't applicable to any insn validly using respective memory operand
sizes (and if they're used wrongly, another error would result), and the
logic in process_suffix() can be easily changed to work without them.
While re-structuring conditionals in process_suffix() also drop the
CMPXCHG8B special case in favor of a NoRex64 attribute in the opcode
table.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: fold FMA and FMA4 templates
@ 2018-03-08 9:07 sergiodj+buildbot
2018-03-08 18:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-08 9:07 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 25a4277fec9efb37b107f6bb6c9246f05cd3c348 ***
Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 25a4277fec9efb37b107f6bb6c9246f05cd3c348
x86: fold FMA and FMA4 templates
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: fold VEX-encoded GFNI templates
@ 2018-03-08 9:44 sergiodj+buildbot
2018-03-09 1:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-08 9:44 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 454172a99e4aebafa2cd42d389cd63a8733a046a ***
Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 454172a99e4aebafa2cd42d389cd63a8733a046a
x86: fold VEX-encoded GFNI templates
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove MAX_REGISTER_SIZE define
@ 2018-03-08 10:21 sergiodj+buildbot
2018-03-09 6:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-08 10:21 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 4ef0bef68cfc777e59156fce1563583c0ffb76d9 ***
Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: 4ef0bef68cfc777e59156fce1563583c0ffb76d9
Remove MAX_REGISTER_SIZE define
gdb/
* defs.h: Remove MAX_REGISTER_SIZE.
* regcache.c (init_regcache_descr): Remove MAX_REGISTER_SIZE
asserts.
* python/py-unwind.c (pyuw_sniffer): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: avoid SSE check for LDMXCSR/STMXCSR
@ 2018-03-08 10:37 sergiodj+buildbot
2018-03-08 13:44 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-08 10:37 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f2f6a710f46e3e7b357128d907002945751afcfd ***
Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: f2f6a710f46e3e7b357128d907002945751afcfd
x86: avoid SSE check for LDMXCSR/STMXCSR
Neither touches any XMM register, so the check is pointless. It is imo
even questionable whether in SSE2AVX mode the two should be converted to
their AVX counterparts.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86-64: Also optimize "clr reg64"
@ 2018-03-08 20:05 sergiodj+buildbot
2018-03-09 11:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-08 20:05 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d3d50934a9101416c3106497d6ea9ce548760253 ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: d3d50934a9101416c3106497d6ea9ce548760253
x86-64: Also optimize "clr reg64"
"clr reg" is an alias of "xor reg, reg". We can encode "clr reg64" as
"xor reg32, reg32".
gas/
* config/tc-i386.c (optimize_encoding): Also encode "clr reg64"
as "xor reg32, reg32".
* testsuite/gas/i386/x86-64-optimize-1.s: Add "clr reg64" tests.
* testsuite/gas/i386/x86-64-optimize-1.d: Updated.
opcodes/
* i386-opc.tbl: Add Optimize to clr.
* i386-tbl.h: Regenerated.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Don't redefine upload/download/file in gdbserver-base
@ 2018-03-08 23:13 sergiodj+buildbot
2018-03-09 13:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-08 23:13 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e4fe3756763773940b003159649f224a5ac42ee0 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: e4fe3756763773940b003159649f224a5ac42ee0
Don't redefine upload/download/file in gdbserver-base
Before patch
Make native gdbserver boards no longer be "remote" (in DejaGnu terms)
739b3f1d8ff7072dcc66240c25b026c6433bda1a
the local gdbserver boards (except native-extended-gdbserver...) were
considered as remote by DejaGNU. To avoid DejaGNU trying to use ssh/scp
to download the files to the target (which is actually local), the
gdbserver-base.exp file defined some _download, _upload and _file board
operations to override the default behavior, and instead just use local
operations.
The same patch also changed remote-stdio-gdbserver.exp to make it
inherit from gdbserver-base.exp. Since then, this board (which is
actually remote) uses the overrides with local file operations. As a
result, files are never actually copied to the target.
I think we can simply remove the overrides from gdbserver-base.exp.
Because all boards should be properly considered local or remote by
DejaGNU, it should by default use the right method for transferring
files.
gdb/testsuite/ChangeLog:
PR gdb/22841
* boards/gdbserver-base.exp (${board}_file, ${board}_download,
${board}_upload): Remove.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] linux_qxfer_libraries_svr4: Use std::string
@ 2018-03-08 23:36 sergiodj+buildbot
2018-03-09 15:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-08 23:36 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f6e8a41e6724e641d3b831983e4d158ff069b8ed ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: f6e8a41e6724e641d3b831983e4d158ff069b8ed
linux_qxfer_libraries_svr4: Use std::string
Use std::string, removing some manual memory management.
gdb/gdbserver/ChangeLog:
* linux-low.c (linux_qxfer_libraries_svr4): Use std::string.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Use std::string to simplify build_id_to_debug_bfd
@ 2018-03-09 0:25 sergiodj+buildbot
2018-03-09 19:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-09 0:25 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 00b400574aa75c1c5fe469233ab16930e2d8a4c8 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 00b400574aa75c1c5fe469233ab16930e2d8a4c8
Use std::string to simplify build_id_to_debug_bfd
Using std::string here makes the string building simpler thank playing
with char*. A stack allocation is replaced with heap allocation, but
I don't think this is really performance-critical code.
gdb/ChangeLog:
* build-id.c (build_id_to_debug_bfd): Use std::string.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Change enable_thread_stack_temporaries to an RAII class
@ 2018-03-09 5:14 sergiodj+buildbot
2018-03-09 22:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-09 5:14 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT fdf07f3aeba5906fec462fba33801c173862f241 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: fdf07f3aeba5906fec462fba33801c173862f241
Change enable_thread_stack_temporaries to an RAII class
This started as a patch to change enable_thread_stack_temporaries to
be an RAII class, but then I noticed that this code used a VEC, so I
went ahead and did a bit more C++-ification, changing
stack_temporaries_enabled to a bool and changing stack_temporaries to
a std::vector.
Regression tested by the buildbot.
gdb/ChangeLog
2018-03-08 Tom Tromey <tom@tromey.com>
* infcall.c (struct call_return_meta_info)
<stack_temporaries_enabled>: Remove.
(get_call_return_value, call_function_by_hand_dummy): Update.
* thread.c (disable_thread_stack_temporaries): Remove.
(enable_thread_stack_temporaries): Remove.
(thread_stack_temporaries_enabled_p): Return bool.
(push_thread_stack_temporary, value_in_thread_stack_temporaries)
(get_last_thread_stack_temporary): Update.
* eval.c (evaluate_subexp): Update.
* gdbthread.h (class enable_thread_stack_temporaries): Now a
class, not a function.
(value_ptr, value_vec): Remove typedefs.
(class thread_info) <stack_temporaries_enabled>: Now bool.
<stack_temporaries>: Now a std::vector.
(thread_stack_temporaries_enabled_p)
(value_in_thread_stack_temporaries): Return bool.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Use scoped_fd in more places
@ 2018-03-09 5:23 sergiodj+buildbot
2018-03-09 23:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-09 5:23 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 5dc1a7047a77f86de7518a99805af64891d4e22a ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 5dc1a7047a77f86de7518a99805af64891d4e22a
Use scoped_fd in more places
This changes a few more places to use scoped_fd. This allows the
removal of some cleanups.
Regression tested by the buildbot, though note that I'm not sure
whether the buildbot actually builds anything using all of these
files.
gdb/ChangeLog
2018-03-08 Tom Tromey <tom@tromey.com>
* source.c (get_filename_and_charpos): Use scoped_fd.
* nto-procfs.c (procfs_open_1): Use scoped_fd.
(procfs_pidlist): Likewise.
* procfs.c (proc_get_LDT_entry): Use scoped_fd.
(iterate_over_mappings): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Use std::vector for field lists in dwarf2read.c
@ 2018-03-12 3:49 sergiodj+buildbot
2018-03-12 5:22 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-12 3:49 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT be2daae6b8df45f3f6de5d94a1938cef54336a72 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: be2daae6b8df45f3f6de5d94a1938cef54336a72
Use std::vector for field lists in dwarf2read.c
This changes dwarf2read.c to use std::vector rather than a linked list
when managing the fields and base classes to be added to a type. This
removes some bookkeeping types and also allows the removal of some
cleanups.
gdb/ChangeLog
2018-03-11 Tom Tromey <tom@tromey.com>
* dwarf2read.c (struct nextfield): Add initializers.
(struct nextfnfield): Remove.
(struct fnfieldlist): Add initializers. Remove "length" and
"head", use std::vector.
(struct decl_field_list): Remove.
(struct field_info): Add initializers.
<fields, baseclasses>: Now std::vector.
<nbaseclasses, nfnfields, typedef_field_list_count,
nested_types_list_count>: Remove.
(dwarf2_add_field, dwarf2_add_type_defn)
(dwarf2_attach_fields_to_type, dwarf2_add_member_fn)
(dwarf2_attach_fn_fields_to_type, handle_struct_member_die)
(process_structure_scope): Update.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb/riscv: Fix some ARI issues
@ 2018-03-12 22:14 sergiodj+buildbot
2018-03-12 22:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-12 22:14 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 89a3b63e52be3e9bcf4b3d15e210652a5cb839c5 ***
Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 89a3b63e52be3e9bcf4b3d15e210652a5cb839c5
gdb/riscv: Fix some ARI issues
Fix some ARI issues in recently added riscv code, the ARI email is:
https://sourceware.org/ml/gdb-patches/2018-03/msg00156.html
gdb/ChangeLog:
* riscv-tdep.c (riscv_sw_breakpoint_from_kind): Add localization
to error message string.
(riscv_register_name): Use xsnprintf instead of sprintf.
(riscv_insn::fetch_instruction): Use gdb_assert instead of
internal_error.
(riscv_print_arg_location): Use gdb_assert_not_reached instead of
error.
(riscv_push_dummy_call): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Prevent memory access violations when attempting to parse an x86_64 PE binary containing corrupt unwind information.
@ 2018-03-13 14:19 sergiodj+buildbot
2018-03-13 15:42 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-13 14:19 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 3e33b239450771394fa6c83b67b9de80169f35e8 ***
Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 3e33b239450771394fa6c83b67b9de80169f35e8
Prevent memory access violations when attempting to parse an x86_64 PE binary containing corrupt unwind information.
PR 22113
incldue * coff/pe.h (struct pex64_unwind_info): Add a rawUnwindCodesEnd
field.
bfd * pei-x86_64.c (pex64_get_unwind_info): Change to a boolean
function. Add an end address parameter. Check access of the data
pointer to make sure that they do not extend beyond the end
address. Return FALSE if any check fails. Add the end address
pointer to the ui structure.
(pex64_xdata_print_uwd_codes): Check accesses of the raw unwind
codes to make sure that they do not extend beyond the end address
pointer. Print an error message and return immediately if any
check fails.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] GC: Also check the local debug definition section
@ 2018-03-14 11:43 sergiodj+buildbot
2018-03-14 12:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-14 11:43 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9e223787a474c672c5f1cfd4574857241ae4eafa ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 9e223787a474c672c5f1cfd4574857241ae4eafa
GC: Also check the local debug definition section
Extend
commit b7c871edcd83ccdc5fcd8148a7f433efd6b52255
Author: H.J. Lu <hjl.tools@gmail.com>
Date: Wed May 17 07:57:15 2017 -0700
Mark debug sections referenced by kept debug sections
to handle the local debug definition section.
bfd/
PR ld/20882
* elflink.c (elf_gc_mark_debug_section): Also check the local
debug definition section.
ld/
PR ld/20882
* testsuite/ld-gc/pr20882.d: Also dump and check .debug_abbrev
section.
* testsuite/ld-gc/pr20882b.s: Add .debug_abbrev section.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PowerPC64 debian bug 886264, out-of-line save/restore functions
@ 2018-03-14 12:19 sergiodj+buildbot
2018-03-14 13:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-14 12:19 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 7dda8d3cf3b089bb7e03c4cdbec827fc6a188c88 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 7dda8d3cf3b089bb7e03c4cdbec827fc6a188c88
PowerPC64 debian bug 886264, out-of-line save/restore functions
This calculation in relocate_section
if (stub_entry->stub_type == ppc_stub_save_res)
relocation += (stub_sec->output_offset
+ stub_sec->output_section->vma
+ stub_sec->size - htab->sfpr->size
- htab->sfpr->output_offset
- htab->sfpr->output_section->vma);
to adjust from the original out-of-line save/restore function address
in sfpr to a copy at the end of stub_sec goes wrong when stub_sec is
padded, because the copy is no longer at the end of stub_sec. The
solution is to pad before copying sfpr, so the copy is always at the
end of stub_sec.
* elf64-ppc.c (sfpr_define): Adjust for stub_sec size having
sfpr size added before defining alias symbols.
(ppc64_elf_build_stubs): Add stub section padding before
copying sfpr contents and defining save/restore alias symbols.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Update my email address
@ 2018-03-14 13:59 sergiodj+buildbot
2018-03-14 14:54 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-14 13:59 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 0d671d99a6125e8406e4d06efb58542d3f0aa955 ***
Author: Yao Qi <qiyao@sourceware.org>
Branch: master
Commit: 0d671d99a6125e8406e4d06efb58542d3f0aa955
Update my email address
gdb:
2018-03-14 Yao Qi <qiyao@sourceware.org>
* MAINTAINERS: Update my email address.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add usage to printf command
@ 2018-03-14 16:04 sergiodj+buildbot
2018-03-14 16:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-14 16:04 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 80ae639d3cc4f1e83f1ad48686f87417c06ca6dc ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 80ae639d3cc4f1e83f1ad48686f87417c06ca6dc
Add usage to printf command
This patch adds the "Usage:" text to the printf command's help text,
and tries to improve the text a tiny bit.
gdb/ChangeLog
2018-03-14 Tom Tromey <tom@tromey.com>
* printcmd.c (_initialize_printcmd): Add usage to printf.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] RISC-V: Add .insn support.
@ 2018-03-14 23:20 sergiodj+buildbot
2018-03-15 0:29 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-14 23:20 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 0e35537d754f1c687850d1caccb2d78d2e418391 ***
Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 0e35537d754f1c687850d1caccb2d78d2e418391
RISC-V: Add .insn support.
gas/ChangeLog
2018-03-07 Kito Cheng <kito.cheng@gmail.com>
* config/tc-riscv.c (opcode_name_list): New.
(opcode_names_hash): Likewise.
(init_opcode_names_hash): Likewise.
(opcode_name_lookup): Likewise.
(validate_riscv_insn): New argument length, and add new format
which used in .insn directive.
(md_begin): Refine hash table initialization logic into
init_opcode_hash.
(init_opcode_hash): New.
(my_getOpcodeExpression): Parse opcode name for .insn.
(riscv_ip): New argument hash, able to handle .insn directive.
(s_riscv_insn): Handler for .insn directive.
(riscv_pseudo_table): New entry for .insn.
* doc/c-riscv.texi: Add documentation for .insn directive.
* testsuite/gas/riscv/insn.d: Add testcase for .insn directive.
* testsuite/gas/riscv/insn.s: Likewise.
include/ChangeLog
2018-03-07 Kito Cheng <kito.cheng@gmail.com>
* opcode/riscv.h (OP_MASK_FUNCT3): New.
(OP_SH_FUNCT3): Likewise.
(OP_MASK_FUNCT7): Likewise.
(OP_SH_FUNCT7): Likewise.
(OP_MASK_OP2): Likewise.
(OP_SH_OP2): Likewise.
(OP_MASK_CFUNCT4): Likewise.
(OP_SH_CFUNCT4): Likewise.
(OP_MASK_CFUNCT3): Likewise.
(OP_SH_CFUNCT3): Likewise.
(riscv_insn_types): Likewise.
opcodes/ChangeLog
2018-03-07 Kito Cheng <kito.cheng@gmail.com>
* riscv-opc.c (riscv_insn_types): New.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix tspeed test case: copy libinproctrace to target
@ 2018-03-16 19:56 sergiodj+buildbot
2018-03-16 20:33 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-16 19:56 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 8b067d2cf5bf801eb143b4b04da5c22607673471 ***
Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: 8b067d2cf5bf801eb143b4b04da5c22607673471
Fix tspeed test case: copy libinproctrace to target
The tspeed test case does not execute correctly because libinproctrace.so
is not copied to the target. This is fixed.
gdb/testsuite/ChangeLog:
* gdb.trace/tspeed.exp: Add invocation of gdb_load_shlib to ensure
that libinproctrace is copied to the target.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove make_cleanup_free_section_addr_info
@ 2018-03-16 20:41 sergiodj+buildbot
2018-03-16 21:51 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-16 20:41 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 37e136b1684929df204ddd09c38978c705fa7228 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 37e136b1684929df204ddd09c38978c705fa7228
Remove make_cleanup_free_section_addr_info
This removes make_cleanup_free_section_addr_info. Instead -- per
Simon's suggestion -- this changes section_addr_info to be a
std::vector.
Regression tested by the buildbot.
gdb/ChangeLog
2018-03-16 Tom Tromey <tom@tromey.com>
* xcoffread.c (xcoff_symfile_offsets): Change type of "addrs".
* utils.h (make_cleanup_free_section_addr_info): Don't declare.
* utils.c (do_free_section_addr_info)
(make_cleanup_free_section_addr_info): Remove.
* symfile.h (struct other_sections): Add constructor.
(struct section_addr_info): Remove.
(section_addr_info): New typedef.
(struct sym_fns) <sym_offsets>: Change type of parameter.
(build_section_addr_info_from_objfile)
(relative_addr_info_to_section_offsets, addr_info_make_relative)
(default_symfile_offsets, symbol_file_add)
(symbol_file_add_from_bfd)
(build_section_addr_info_from_section_table): Update.
(alloc_section_addr_info, free_section_addr_info): Don't declare.
* symfile.c (alloc_section_addr_info): Remove.
(build_section_addr_info_from_section_table): Change return type.
Update.
(build_section_addr_info_from_bfd)
(build_section_addr_info_from_objfile): Likewise.
(free_section_addr_info): Remove.
(relative_addr_info_to_section_offsets): Change type of "addrs".
(addrs_section_compar): Now a std::sort comparator.
(addrs_section_sort): Change return type.
(addr_info_make_relative): Change type of "addrs". Update.
(default_symfile_offsets, syms_from_objfile_1)
(syms_from_objfile, symbol_file_add_with_addrs): Likewise.
(symbol_file_add_separate): Update.
(symbol_file_add): Change type of "addrs". Update.
(add_symbol_file_command): Update. Remove cleanups.
* symfile-mem.c (symbol_file_add_from_memory): Update. Remove
cleanups.
* symfile-debug.c (debug_sym_offsets): Change type of "info".
* solib.c (solib_read_symbols): Update.
* objfiles.c (objfile_relocate): Update. Remove cleanups.
* machoread.c (macho_symfile_offsets): Update.
* jit.c (jit_bfd_try_read_symtab): Update.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add silent Makefile rules
@ 2018-03-16 21:30 sergiodj+buildbot
2018-03-16 23:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-16 21:30 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 39be3c7e98728df57cfddd37fb7747f1339a319b ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 39be3c7e98728df57cfddd37fb7747f1339a319b
Add silent Makefile rules
Many projects (e.g. the Linux kernel) and build systems use "silent"
rules, which means that they'll only print a summary of what's being
done instead of printing all the detailed command lines. While chatting
on the #gdb IRC channel, I realized a few people (including me) thought
it would be nice to have it in GDB too.
The idea is that too much text is not useful, the important information
gets lost. If there's only the essential information, it's more likely
to be useful. Most of the time, when I look at the build output, it's
to see how it's progressing. By just printing a brief summary of each
operation, I can easily spot what's currently being compiled and
therefore how the build progresses (with time you know the order in
which files are compiled almost by heart).
As with other projects (Linux, automake-based things, probably others),
it's possible to print the complete command lines by passing V=1 to make
(or any other non-zero value).
I had one hesitation about this: when people report build failures, we
are more likely to miss the full compile command line. We'll probably
sometimes need to ask people to include the build log with "make V=1".
I don't think it's a big downside, if other projects the size of the
Linux kernel can live with it, I'm sure we can too.
gdb/ChangeLog:
* silent-rules.mk: New.
* Makefile.in: Include silent-rules.mk
(srcdir, VPATH, top_srcdir): Move up.
(COMPILE): Add ECHO_CXX.
(test-cp-name-parser$(EXEEXT)): Add ECHO_CXXLD.
(init.c): Add ECHO_INIT_C.
(gdb$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
(version.c): Add ECHO_GEN.
(printcmd.o): Add ECHO_CXX.
(target-float.o): Add ECHO_CXX.
(ada-exp.o): Add ECHO_CXX.
(stamp-xml): Add SILENCE and ECHO_GEN_XML_BUILTIN.
(insight$(EXEEXT)): Add ECHO_CXXLD.
* gnulib/configure.ac: Add AM_SILENT_RULES.
* gnulib/aclocal.m4: Re-generate.
* gnulib/configure: Re-generate.
* gnulib/import/Makefile.in: Re-generate.
gdb/gdbserver/ChangeLog:
* Makefile.in: Include silent-rules.mk.
(srcdir, abs_top_srcdir, abs_srcdir, VPATH): Move up.
(COMPILE): Add ECHO_CXX.
(gdbserver$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
(gdbreplay$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
($(IPA_LIB)): Add SILENCE and ECHO_CXXLD.
(version-generated.c): Add ECHO_GEN.
(stamp-xml): Add SILENCE and ECHO_GEN_XML_BUILTIN_GENERATED.
(IPAGENT_COMPILE): Add ECHO_CXX.
(%-generated.c): Add ECHO_REGDAT.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Change auto_load_objfile_script_1 to use std::string
@ 2018-03-17 19:46 sergiodj+buildbot
2018-03-17 20:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-17 19:46 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a06ab151cbab6f3da8735d2e5e06ede9454ca4c1 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: a06ab151cbab6f3da8735d2e5e06ede9454ca4c1
Change auto_load_objfile_script_1 to use std::string
This replaces some manual string manipulation in
auto_load_objfile_script_1 with std::string, simplifying the code and
allowing the removal of some cleanups.
Tested by the buildbot.
2018-03-17 Tom Tromey <tom@tromey.com>
* auto-load.c (auto_load_objfile_script_1): Use std::string.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove some cleanups from solib.c
@ 2018-03-19 4:11 sergiodj+buildbot
2018-03-19 4:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-19 4:11 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 1cb1f3dae747fef1a576fe38078891e545fa92e5 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 1cb1f3dae747fef1a576fe38078891e545fa92e5
Remove some cleanups from solib.c
This removes some cleanups from solib.c, replacing them with
gdb::def_vector.
Regression tested by the buildbot.
gdb/ChangeLog
2018-03-18 Tom Tromey <tom@tromey.com>
* solib.c (gdb_bfd_lookup_symbol_from_symtab): Use
gdb::def_vector.
(bfd_lookup_symbol_from_dyn_symtab): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Updated Spanish translation for the bfd/ sub-directory, and updated Ukranian translation for the gas/ sub-directory.
@ 2018-03-19 11:10 sergiodj+buildbot
2018-03-19 11:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-19 11:10 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 315aa1cf834a3d78a567263fa3fbda9b2027457e ***
Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 315aa1cf834a3d78a567263fa3fbda9b2027457e
Updated Spanish translation for the bfd/ sub-directory, and updated Ukranian translation for the gas/ sub-directory.
bfd * po/es.po: Updated Spanish translation.
gas * po/uk.po: Updated Ukranian translation.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Testsuite: Fix ambiguous "break" due to libinproctrace
@ 2018-03-19 12:29 sergiodj+buildbot
2018-03-19 13:07 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-19 12:29 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 194ed4130dadb7dd1668f6af87405bdcd8041199 ***
Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: 194ed4130dadb7dd1668f6af87405bdcd8041199
Testsuite: Fix ambiguous "break" due to libinproctrace
Some of GDB's trace test cases define a function end() and place a
breakpoint there with "break end". However, when libinproctrace is linked
to the binary, there are multiple methods named "end", such as
std::string::end() from the C++ library or format_pieces::end() from
common/format.h. GDB then creates multiple breakpoints instead of just a
single one, and some FAILs result, such as these:
FAIL: gdb.trace/trace-mt.exp: ftrace on: break end
FAIL: gdb.trace/trace-mt.exp: ftrace off: break end
Fix this by adding the "-qualified" option to the break commands. For
consistency, change all occurrences of "break end" (and similar) in all
trace test cases, even if the current behavior does not cause problems.
Also, consequently use the gdb_breakpoint convenience proc.
gdb/testsuite/ChangeLog:
* gdb.trace/actions-changed.exp: Call gdb_breakpoint with the
"qualified" option when setting breakpoints.
* gdb.trace/backtrace.exp: Likewise.
* gdb.trace/circ.exp: Likewise.
* gdb.trace/collection.exp: Likewise.
* gdb.trace/disconnected-tracing.exp: Likewise.
* gdb.trace/ftrace-lock.exp: Likewise.
* gdb.trace/ftrace.exp: Likewise.
* gdb.trace/infotrace.exp: Likewise.
* gdb.trace/packetlen.exp: Likewise.
* gdb.trace/passc-dyn.exp: Likewise.
* gdb.trace/qtro.exp: Likewise.
* gdb.trace/read-memory.exp: Likewise.
* gdb.trace/report.exp: Likewise.
* gdb.trace/signal.exp: Likewise.
* gdb.trace/status-stop.exp: Likewise.
* gdb.trace/strace.exp: Likewise.
* gdb.trace/tfind.exp: Likewise.
* gdb.trace/trace-break.exp: Likewise.
* gdb.trace/trace-condition.exp: Likewise.
* gdb.trace/trace-mt.exp: Likewise.
* gdb.trace/tstatus.exp: Likewise.
* gdb.trace/tsv.exp: Likewise.
* gdb.trace/unavailable-dwarf-piece.exp: Likewise.
* gdb.trace/unavailable.exp: Likewise.
* gdb.trace/while-dyn.exp: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Convert observers to C++
@ 2018-03-19 15:59 sergiodj+buildbot
2018-03-19 16:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-19 15:59 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 76727919ceb590f03ff0f6db08b7ceab5b7aeaff ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 76727919ceb590f03ff0f6db08b7ceab5b7aeaff
Convert observers to C++
This converts observers from using a special source-generating script
to be plain C++. This version of the patch takes advantage of C++11
by using std::function and variadic templates; incorporates Pedro's
patches; and renames the header file to "observable.h" (this change
eliminates the need for a clean rebuild).
Note that Pedro's patches used a template lambda in tui-hooks.c, but
this failed to compile on some buildbot instances (presumably due to
differing C++ versions); I replaced this with an ordinary template
function.
Regression tested on the buildbot.
gdb/ChangeLog
2018-03-19 Pedro Alves <palves@redhat.com>
Tom Tromey <tom@tromey.com>
* unittests/observable-selftests.c: New file.
* common/observable.h: New file.
* observable.h: New file.
* ada-lang.c, ada-tasks.c, agent.c, aix-thread.c, annotate.c,
arm-tdep.c, auto-load.c, auxv.c, break-catch-syscall.c,
breakpoint.c, bsd-uthread.c, cli/cli-interp.c, cli/cli-setshow.c,
corefile.c, dummy-frame.c, event-loop.c, event-top.c, exec.c,
extension.c, frame.c, gdbarch.c, guile/scm-breakpoint.c,
infcall.c, infcmd.c, inferior.c, inflow.c, infrun.c, jit.c,
linux-tdep.c, linux-thread-db.c, m68klinux-tdep.c,
mi/mi-cmd-break.c, mi/mi-interp.c, mi/mi-main.c, objfiles.c,
ppc-linux-nat.c, ppc-linux-tdep.c, printcmd.c, procfs.c,
python/py-breakpoint.c, python/py-finishbreakpoint.c,
python/py-inferior.c, python/py-unwind.c, ravenscar-thread.c,
record-btrace.c, record-full.c, record.c, regcache.c, remote.c,
riscv-tdep.c, sol-thread.c, solib-aix.c, solib-spu.c, solib.c,
spu-multiarch.c, spu-tdep.c, stack.c, symfile-mem.c, symfile.c,
symtab.c, thread.c, top.c, tracepoint.c, tui/tui-hooks.c,
tui/tui-interp.c, valops.c: Update all users.
* tui/tui-hooks.c (tui_bp_created_observer)
(tui_bp_deleted_observer, tui_bp_modified_observer)
(tui_inferior_exit_observer, tui_before_prompt_observer)
(tui_normal_stop_observer, tui_register_changed_observer):
Remove.
(tui_observers_token): New global.
(attach_or_detach, tui_attach_detach_observers): New functions.
(tui_install_hooks, tui_remove_hooks): Use
tui_attach_detach_observers.
* record-btrace.c (record_btrace_thread_observer): Remove.
(record_btrace_thread_observer_token): New global.
* observer.sh: Remove.
* observer.c: Rename to observable.c.
* observable.c (namespace gdb_observers): Define new objects.
(observer_debug): Move into gdb_observers namespace.
(struct observer, struct observer_list, xalloc_observer_list_node)
(xfree_observer_list_node, generic_observer_attach)
(generic_observer_detach, generic_observer_notify): Remove.
(_initialize_observer): Update.
Don't include observer.inc.
* Makefile.in (generated_files): Remove observer.h, observer.inc.
(clean mostlyclean): Likewise.
(observer.h, observer.inc): Remove targets.
(SUBDIR_UNITTESTS_SRCS): Add observable-selftests.c.
(COMMON_SFILES): Use observable.c, not observer.c.
* .gitignore: Remove observer.h.
gdb/doc/ChangeLog
2018-03-19 Tom Tromey <tom@tromey.com>
* observer.texi: Remove.
gdb/testsuite/ChangeLog
2018-03-19 Tom Tromey <tom@tromey.com>
* gdb.gdb/observer.exp: Remove.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Set non_ir_ref_dynamic if a symbol is made dynamic
@ 2018-03-20 11:08 sergiodj+buildbot
2018-03-20 11:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-20 11:08 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 416c34d683f2a17aefe19afb466af4316c7c603b ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 416c34d683f2a17aefe19afb466af4316c7c603b
Set non_ir_ref_dynamic if a symbol is made dynamic
If a symbol is made dynamic by --dynamic-list, it has non-IR reference.
bfd/
PR ld/22983
* elflink.c (bfd_elf_link_mark_dynamic_symbol): Set
non_ir_ref_dynamic if a symbol is made dynamic by --dynamic-list.
ld/
PR ld/22983
* testsuite/ld-plugin/lto.exp: Run PR ld/22983 test.
* testsuite/ld-plugin/pr22983.d: New file.
* testsuite/ld-plugin/pr22983.t: Likewise.
* testsuite/ld-plugin/pr22983a.c: Likewise.
* testsuite/ld-plugin/pr22983b.c: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Don't exceed reloc array bounds
@ 2018-03-21 11:32 sergiodj+buildbot
2018-03-21 12:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-21 11:32 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 675e28092f9d92c56c38d40d13ad5b766bdede05 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 675e28092f9d92c56c38d40d13ad5b766bdede05
Don't exceed reloc array bounds
* elf64-ppc.c (ppc64_elf_relocate_section): Don't access rel[1]
without first checking array bounds.
* elf32-ppc.c (ppc_elf_relocate_section): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Make tls_mask unsigned in elf32-ppc.c
@ 2018-03-21 11:59 sergiodj+buildbot
2018-03-21 14:54 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-21 11:59 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT bac3c8c5e7fb88ddb3615b895ad57847b9842171 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: bac3c8c5e7fb88ddb3615b895ad57847b9842171
Make tls_mask unsigned in elf32-ppc.c
* elf32-ppc.c (struct ppc_elf_link_hash_entry): Make tls_mask
field unsigned.
(update_local_sym_info): Likewise for local_got_tls_masks.
(ppc_elf_tls_optimize): Likewise for lgot_masks.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] S390: Enable re-attaching with native-extended-gdbserver
@ 2018-03-21 16:59 sergiodj+buildbot
2018-03-21 19:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-21 16:59 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 7edb9bd32ba23247a509cbe9d44ccb02da97b66e ***
Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: 7edb9bd32ba23247a509cbe9d44ccb02da97b66e
S390: Enable re-attaching with native-extended-gdbserver
On s390x, when running attach.exp with native-extended-gdbserver,
gdbserver crashes in find_regno like this:
.../regcache.c:252: A problem internal to GDBserver has been detected.
Unknown register tdb0 requested
On the GDB side it looks like this:
(gdb) attach 31568
Attaching to process 31568
Remote connection closed
The test case attempts to attach to a new process via the already running
gdbserver. Thus s390_arch_setup is called a second time, and that's where
the problem occurs. In order to determine the word width (32 or 64 bits),
s390_arch_setup reads the pswm register through the regcache. For that it
uses a temporary tdesc which is supposed to work for all s390 targets,
since the actual tdesc has not been determined yet. But in this second
round this doesn't work, because s390_regsets has been updated already and
now contains regsets not described by the temporary tdesc, such as the one
containing tdb0.
This is fixed by rearranging the logic in s390_arch_setup.
gdb/gdbserver/ChangeLog:
* linux-s390-low.c (s390_get_hwcap): Replace tdesc parameter by
the word size. Add comment.
(s390_get_wordsize): New function.
(s390_arch_setup): No longer select a temporary tdesc to fetch the
pswm with it. Instead, use s390_get_wordsize to determine the
word size first and derive the correct tdesc from that directly.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] S390: Make IPA recognize tdescs with guarded storage
@ 2018-03-21 18:30 sergiodj+buildbot
2018-03-21 21:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-21 18:30 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ce29f8439f94adfa56655940e657afbe07a0c99e ***
Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: ce29f8439f94adfa56655940e657afbe07a0c99e
S390: Make IPA recognize tdescs with guarded storage
The in-process agent does not handle tdescs with guarded storage yet.
This is fixed.
gdb/gdbserver/ChangeLog:
* linux-s390-ipa.c (get_ipa_tdesc): Add handling for
S390_TDESC_GS.
* linux-s390-low.c (s390_get_ipa_tdesc_idx): Likewise.
(initialize_low_tracepoint): Call init_registers_s390x_gs_linux64
and init_registers_s390_gs_linux64.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Make parse_static_tracepoint_marker_definition work with multiple static tracepoint definitions
@ 2018-03-22 4:50 sergiodj+buildbot
2018-03-22 5:28 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-22 4:50 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 62c222b6d9fcce8adf65f48fca2e528f777afeeb ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 62c222b6d9fcce8adf65f48fca2e528f777afeeb
Make parse_static_tracepoint_marker_definition work with multiple static tracepoint definitions
Since I modify the parse_static_tracepoint_marker_definition function in
the next patch, I wanted to write a unit test for it. Doing so showed
that it doesn't handle multiple consecutive static tracepoint
definitions separated by commas. However, the RSP documentation [1]
states that servers may return multiple definitions, like:
1234:6d61726b657231:6578747261207374756666,abba:6d61726b657232:
The problem is that the function uses strlen to compute the length of
the last field (the extra field). If there are additional definitions
in addition to the one we are currently parsing, the returned length
will include those definitions, and we'll try to hex-decode past the
extra field.
This patch changes parse_static_tracepoint_marker_definition to consider
the case where the current definition is followed by a comma and more
definitions. It also adds the unit test that found the issue in the
first place.
I don't think this causes any backwards compatibility issues, because
the previous code only handled single static tracepoint definitions, and
the new code handles that correctly.
gdb/ChangeLog:
* tracepoint.c (parse_static_tracepoint_marker_definition):
Consider case where the definition is followed by more
definitions.
* Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
tracepoint-selftests.c.
* unittests/tracepoint-selftests.c: New.
[1] https://sourceware.org/gdb/onlinedocs/gdb/Tracepoint-Packets.html#qTfSTM
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: fold a few XOP templates
@ 2018-03-22 7:50 sergiodj+buildbot
2018-03-22 8:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-22 7:50 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f776822506b417ce25170c67c33cc05870b37adf ***
Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: f776822506b417ce25170c67c33cc05870b37adf
x86: fold a few XOP templates
Also add a new test case verifying that mixed operands of SIMD insns
with a size-less memory operand in the middle are properly rejected.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86/Intel: fix fallout from earlier template folding
@ 2018-03-22 8:02 sergiodj+buildbot
2018-03-22 10:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-22 8:02 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d6793fa1acf384a93c83db6eb916e3b9eedd9ef4 ***
Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: d6793fa1acf384a93c83db6eb916e3b9eedd9ef4
x86/Intel: fix fallout from earlier template folding
While many templates allowing multiple suitably matching XMM/YMM/ZMM
operand sizes can be folded, a few need to be split in order to not
wrongly accept "xmmword ptr" operands when only XMM registers are
permitted (and memory operands are more narrow). Add a test case
validating this.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: fix swapped operand handling for BNDMOV
@ 2018-03-22 8:17 sergiodj+buildbot
2018-03-22 12:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-22 8:17 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9f79e88693dae859f838bcf684158e6e6f8f3b6b ***
Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 9f79e88693dae859f838bcf684158e6e6f8f3b6b
x86: fix swapped operand handling for BNDMOV
The wrong placement of the Load attribute in the templates prevented
this from working. The disassembler also didn't handle this consistently
with other similar dual-encoding insns.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: drop remaining redundant DispN
@ 2018-03-22 8:31 sergiodj+buildbot
2018-03-22 13:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-22 8:31 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 96bc132a736fe44cc021d5d4e8ed6780b9520f22 ***
Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 96bc132a736fe44cc021d5d4e8ed6780b9520f22
x86: drop remaining redundant DispN
A few of them were missed in commit 7ac2002247 ("x86: derive DispN
from BaseIndex") and also couldn't be removed by subsequent commits
touching certain templates anyway.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] S390: Correct brace style in s390_get_wordsize
@ 2018-03-22 9:20 sergiodj+buildbot
2018-03-22 15:59 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-22 9:20 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f69c5afb18871a773af88484a24d7da12c3a104c ***
Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: f69c5afb18871a773af88484a24d7da12c3a104c
S390: Correct brace style in s390_get_wordsize
This corrects bad formatting in the newly introduced function
s390_get_wordsize.
gdb/gdbserver/ChangeLog:
* linux-s390-low.c (s390_get_wordsize): Correct brace style.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Make "info proc cmdline" show args on GNU/Linux
@ 2018-03-22 9:34 sergiodj+buildbot
2018-03-22 17:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-22 9:34 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 26d6cec4a9291f154e549fb6f4318ace6cfaa2a5 ***
Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: 26d6cec4a9291f154e549fb6f4318ace6cfaa2a5
Make "info proc cmdline" show args on GNU/Linux
Currently "info proc cmdline" on GNU/Linux does not show the full command
line, but only argument 0. And even a warning is shown if there are more.
This was discussed in 2014 already:
https://sourceware.org/ml/gdb-patches/2014-04/msg00212.html
Follow the advice there and avoid target_fileio_read_stralloc. Instead,
use target_fileio_read_alloc to read the whole command line and then
replace NUL characters by spaces. Also add an appropriate test case.
Note that gdbserver already handles this correctly.
gdb/ChangeLog:
* linux-tdep.c (linux_info_proc): For "info proc cmdline", print
command line args instead of emitting a warning.
gdb/testsuite/ChangeLog:
* gdb.base/info-proc.exp: Add test for "info proc cmdline".
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: drop pointless VecESize
@ 2018-03-22 11:31 sergiodj+buildbot
2018-03-22 14:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-22 11:31 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b8c169f359dd99900994baff60c57417f13351b3 ***
Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: b8c169f359dd99900994baff60c57417f13351b3
x86: drop pointless VecESize
The attribute is meaningful only in templates allowing embedded
broadcast. Drop them everywhere else.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove some cleanups from record-full.c
@ 2018-03-23 3:37 sergiodj+buildbot
2018-03-23 4:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-23 3:37 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a2b2bc12af45f48617729c1413a1a01c0ee957ca ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: a2b2bc12af45f48617729c1413a1a01c0ee957ca
Remove some cleanups from record-full.c
This removes some cleanups from record-full.c in a straightforward
way.
Tested by the buildbot.
gdb/ChangeLog
2018-03-22 Tom Tromey <tom@tromey.com>
* record-full.c (record_full_exec_insn): Use gdb::byte_vector.
(record_full_goto_bookmark): Use std::string.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Move gdbserver tdesc header funcs to c file
@ 2018-03-23 11:26 sergiodj+buildbot
2018-03-23 12:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-23 11:26 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d80e524238a17878eee0c620d56e2fad072556bc ***
Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: d80e524238a17878eee0c620d56e2fad072556bc
Move gdbserver tdesc header funcs to c file
gdbserver/
* tdesc.c (target_desc::~target_desc): Move to here.
(target_desc::operator==): Likewise.
* tdesc.h (target_desc::~target_desc): Move from here.
(target_desc::operator==): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb: Minor cleanup in some gdb.arch/* tests
@ 2018-03-23 12:14 sergiodj+buildbot
2018-03-23 13:39 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-23 12:14 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 066cfa988ddf88ad32b7a114f2e984a13a3848c8 ***
Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 066cfa988ddf88ad32b7a114f2e984a13a3848c8
gdb: Minor cleanup in some gdb.arch/* tests
A small number of tests incorrectly tried to pass -Wa,-g through to
GCC as an extra compile time flag, either to gdb_compile or
prepare_for_testing.
The problem is that the syntax used for passing the flags was
incorrect, and as a result these extra flags were being ignored.
Luckily, the 'debug' flag was being passed in each case anyway, which
means that the '-g' flag would already be added.
Given that all these tests pass 'debug', and the invalid flag has been
ignored for some time, I'm just removing the flags in this commit.
I've also changed the tests from using gdb_compile to
prepare_for_testing, which allows some extra code to be removed from a
couple of tests scripts.
There should be no change in the test results after this commit.
gdb/testsuite/ChangeLog:
* gdb.arch/amd64-disp-step-avx.exp: Remove unneeded assembler flag
option, syntax was wrong anyway.
* gdb.arch/arm-disp-step.exp: Likewise.
* gdb.arch/sparc64-regs.exp: Likewise.
* gdb.arch/amd64-disp-step.exp: Remove unneeded assembler flag
option, syntax was wrong anyway, switch to use
prepare_for_testing.
* gdb.arch/i386-disp-step.exp: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Make gdbserver find_register_by_number static
@ 2018-03-23 15:04 sergiodj+buildbot
2018-03-23 16:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-23 15:04 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT dff7492c9b221aacd4efa6675bb288dfb5d50f80 ***
Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: dff7492c9b221aacd4efa6675bb288dfb5d50f80
Make gdbserver find_register_by_number static
gdbserver/
* regcache.c (find_register_by_number): Make static.
(find_regno): Use find_register_by_number
* regcache.h (struct reg): Remove declaration.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add psymbols for nested types
@ 2018-03-23 19:13 sergiodj+buildbot
2018-03-23 19:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-23 19:13 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b7fee5a3268c340975a1dddb131733abfd153d5e ***
Author: Keith Seitz <keiths@redhat.com>
Branch: master
Commit: b7fee5a3268c340975a1dddb131733abfd153d5e
Add psymbols for nested types
c++/22968 involves the inability of ptype to find a type definition for
a type defined inside another type. I recently added some additional
support for nested type definitions, but I apparently overlooked psymbols.
The user reports that using -readnow fixes the problem:
$ gdb 22968 -ex "ptype Outer::Inner"
There is no field named Inner
$ gdb -readnow 22968 -ex "ptype Outer::Inner"
type = struct Outer::Inner {
<no data field>
}
We clearly did not find a psymbol for Outer::Inner because it was located
in another CU. This patch addresses this problem by scanning structs
for additional psymbols. Rust is already doing this.
With this patch, the identical result to "-readnow" is given (without
using `-readnow', of course).
gdb/ChangeLog:
PR c++/22968
* dwarf2read.c (scan_partial_symbols): Scan structs/classes for
nested type definitions for C++, too.
gdb/testsuite/ChangeLog:
PR c++/22968
* gdb.cp/subtypes.exp: New file.
* gdb.cp/subtypes.h: New file.
* gdb.cp/subtypes.cc: New file.
* gdb.cp/subtypes-2.cc: New file.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] eval.c: reverse minsym and sym
@ 2018-03-25 18:14 sergiodj+buildbot
2018-03-25 18:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-25 18:14 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 3e5ef9a4de7919971130f7f2ca3052898a069e76 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 3e5ef9a4de7919971130f7f2ca3052898a069e76
eval.c: reverse minsym and sym
I noticed that in evaluate_funcall, where we handle
OP_VAR_MSYM_VALUE/OP_VAR_VALUE to figure out the symbol's name gets
the minimal_symbol/symbol backwards. Happens to be harmless in
practice because the symbol name is recorded in the common initial
sequence (in the general_symbol_info field).
gdb/ChangeLog:
2018-03-25 Pedro Alves <palves@redhat.com>
* eval.c (evaluate_funcall): Swap OP_VAR_MSYM_VALUE/OP_VAR_VALUE
if then/else bodies in var_func_name extraction.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Make gdbserver reg_defs a vector of objects
@ 2018-03-26 11:05 sergiodj+buildbot
2018-03-26 11:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-26 11:05 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 5cd3e386e0ac84b0ba1e0737853f4504ba24f677 ***
Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: 5cd3e386e0ac84b0ba1e0737853f4504ba24f677
Make gdbserver reg_defs a vector of objects
gdb/
* regformats/regdef.h (reg): Add constructors.
gdb/gdbserver/
* regcache.c (find_register_by_number): Return a ref.
(find_regno): Use references.
(register_size): Likewise.
(register_data): Likewise.
* tdesc.c (target_desc::~target_desc): Remove free calls.
(target_desc::operator==): Use std::vector compare.
(init_target_desc): Use reference.
(tdesc_create_reg): Use reg constructors.
* tdesc.h (struct target_desc): Replace pointer with object.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove struct keyword from section_addr_info
@ 2018-03-26 17:54 sergiodj+buildbot
2018-03-26 19:13 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-26 17:54 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 4f7ae6f5059924a5acc4490880449d6410dc5c93 ***
Author: Keith Seitz <keiths@redhat.com>
Branch: master
Commit: 4f7ae6f5059924a5acc4490880449d6410dc5c93
Remove struct keyword from section_addr_info
Buildbot pointed out a failiure in windows-nat.c:
../../binutils-gdb/gdb/windows-nat.c:582:10: error: using typedef-name 'section_addr_info' after 'struct'
struct section_addr_info *addrs;
^~~~~~~~~~~~~~~~~
In file included from ../../binutils-gdb/gdb/windows-nat.c:49:0:
../../binutils-gdb/gdb/symfile.h:75:37: note: 'section_addr_info' has a previous declaration here
typedef std::vector<other_sections> section_addr_info;
^~~~~~~~~~~~~~~~~
A recursive grep of the sources for "struct section_addr_info" reveals one
additional reference in a comment. In both cases, this patch simply removes
the struct keyword.
gdb/ChangeLog:
* symfile.c (place_section): Remove "struct" from section_addr_info
in comment.
* windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Remove
"struct" keyword from section_addr_info.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove DEF_VEC_I(offset_type)
@ 2018-03-26 20:03 sergiodj+buildbot
2018-03-26 21:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-26 20:03 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9f034d7573ec4fb4bd3879ce66fef0a20167a2ba ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 9f034d7573ec4fb4bd3879ce66fef0a20167a2ba
Remove DEF_VEC_I(offset_type)
It is unused.
gdb/ChangeLog:
* dwarf2read.c (DEF_VEC_I(offset_type)): Remove.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Change backtrace_command_1 calling to use flags
@ 2018-03-27 4:34 sergiodj+buildbot
2018-03-27 6:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-27 4:34 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 1cf7e64086d1490649dc56e1c0505be91c600218 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 1cf7e64086d1490649dc56e1c0505be91c600218
Change backtrace_command_1 calling to use flags
The next patch will add more flags to backtrace_command_1; and rather
than add another boolean argument, this patch changes it to accept a
flags value.
gdb/ChangeLog
2018-03-26 Tom Tromey <tom@tromey.com>
* stack.c (backtrace_command_1): Remove "show_locals" parameter,
add "flags".
(backtrace_command): Remove "fulltrace", add "flags".
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Allow hiding of some filtered frames
@ 2018-03-27 4:49 sergiodj+buildbot
2018-03-27 7:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-27 4:49 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 978d6c756fcb0332ddf12e19305dd0e53b98a93d ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 978d6c756fcb0332ddf12e19305dd0e53b98a93d
Allow hiding of some filtered frames
When a frame filter elides some frames, they are still printed by
"bt", indented a few spaces. PR backtrace/15582 notes that it would
be nice for users if elided frames could simply be dropped. This
patch adds this capability.
gdb/ChangeLog
2018-03-26 Tom Tromey <tom@tromey.com>
PR backtrace/15582:
* stack.c (backtrace_command): Parse "hide" argument.
* python/py-framefilter.c (py_print_frame): Handle PRINT_HIDE.
* extension.h (enum frame_filter_flags) <PRINT_HIDE>: New
constant.
gdb/doc/ChangeLog
2018-03-26 Tom Tromey <tom@tromey.com>
PR backtrace/15582:
* gdb.texinfo (Backtrace): Mention "hide" argument.
gdb/testsuite/ChangeLog
2018-03-26 Tom Tromey <tom@tromey.com>
PR backtrace/15582:
* gdb.python/py-framefilter.exp: Add "bt hide" test.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove EXT_LANG_BT_COMPLETED
@ 2018-03-27 5:03 sergiodj+buildbot
2018-03-27 9:27 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-27 5:03 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 63283d4a2983eaefd5d0860ddffcf946f0fe92db ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 63283d4a2983eaefd5d0860ddffcf946f0fe92db
Remove EXT_LANG_BT_COMPLETED
While looking at the frame filter code, I noticed that
EXT_LANG_BT_COMPLETED is not really needed. Semantically there is no
difference between the "completed" and "ok" results. So, this patch
removes this constant.
gdb/ChangeLog
2018-03-26 Tom Tromey <tom@tromey.com>
* python/py-framefilter.c (py_print_frame): Return
EXT_LANG_BT_OK.
(gdbpy_apply_frame_filter): Update comment.
* extension.h (enum ext_lang_bt_status) <EXT_LANG_BT_COMPLETED>:
Remove.
<EXT_LANG_BT_NO_FILTERS>: Change value.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Allow C-c to work in backtrace in more cases
@ 2018-03-27 5:31 sergiodj+buildbot
2018-03-27 12:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-27 5:31 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 92256134f3e5557dcc321c63c48e8175ea90ca27 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 92256134f3e5557dcc321c63c48e8175ea90ca27
Allow C-c to work in backtrace in more cases
PR cli/17716 notes that it is difficult to C-c (or "q" at a pagination
prompt) while backtracing using a frame filter. One reason for this
is that many places in py-framefilter.c use RETURN_MASK_ALL in a
try/catch.
This patch changes these spots to use RETURN_MASK_ERROR instead. This
is safe to do because this entire file is exception safe now.
gdb/ChangeLog
2018-03-26 Tom Tromey <tom@tromey.com>
PR cli/17716:
* python/py-framefilter.c (py_print_type, py_print_value)
(enumerate_args, py_print_args, gdbpy_apply_frame_filter): Use
RETURN_MASK_ERROR.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Move some code later in backtrace_command_1
@ 2018-03-27 6:17 sergiodj+buildbot
2018-03-27 15:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-27 6:17 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT fb7eb8b5826f059e2b7a18e42ff9c20972e626bc ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: fb7eb8b5826f059e2b7a18e42ff9c20972e626bc
Move some code later in backtrace_command_1
PR backtrace/15584 notes that some code in backtrace_command_1 is not
useful when frame filters are in use. This patch moves this code into
the no-frame-filters "if". This also removes the unused local
"trailing_level", which I noticed while moving the code around.
gdb/ChangeLog
2018-03-26 Tom Tromey <tom@tromey.com>
PR backtrace/15584:
* stack.c (backtrace_command_1): Move some code into no-filters
"if".
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Improve "backtrace" help text
@ 2018-03-27 6:58 sergiodj+buildbot
2018-03-27 20:30 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-27 6:58 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9507b29c0a00fb62f015fe69f82aaf8f5377ab35 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 9507b29c0a00fb62f015fe69f82aaf8f5377ab35
Improve "backtrace" help text
This improves help text in stack.c in two ways. First, it removes
trailing newlines from various help strings. I think these are never
needed. Second, it adds a "Usage" line to the "backtrace" text, as
suggested by Pedro.
gdb/ChangeLog
2018-03-26 Tom Tromey <tom@tromey.com>
* stack.c (_initialize_stack): Remove trailing newlines from help
text. Add "Usage" line to "backtrace" help.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Simplify exception handling in py-framefilter.c
@ 2018-03-27 7:12 sergiodj+buildbot
2018-03-27 21:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-27 7:12 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 76c939acfd21928957b45816bf78935363438b0a ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 76c939acfd21928957b45816bf78935363438b0a
Simplify exception handling in py-framefilter.c
This patch changes py-framefilter.c as suggested by Pedro in:
https://sourceware.org/ml/gdb-patches/2017-06/msg00748.html
In particular, gdb exceptions are now caught at the outermost layer,
rather than in each particular function. This simplifies much of the
code.
gdb/ChangeLog
2018-03-26 Tom Tromey <tom@tromey.com>
* python/py-framefilter.c (py_print_type): Don't catch
exceptions. Return void.
(py_print_value): Likewise.
(py_print_single_arg): Likewise.
(enumerate_args): Don't catch exceptions.
(py_print_args): Likewise.
(py_print_frame): Likewise.
(gdbpy_apply_frame_filter): Catch exceptions here.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Return EXT_LANG_BT_ERROR in one more spot in py-framefilter.c
@ 2018-03-27 7:57 sergiodj+buildbot
2018-03-27 17:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-27 7:57 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 1f111921a0f8e3f62a19808349ff9bcbd4e54043 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 1f111921a0f8e3f62a19808349ff9bcbd4e54043
Return EXT_LANG_BT_ERROR in one more spot in py-framefilter.c
While reading py-framefilter.c, I found one spot where an exception
could be caught but then not be turned into EXT_LANG_BT_ERROR. This
patch fixes this spot.
gdb/ChangeLog
2018-03-26 Tom Tromey <tom@tromey.com>
* python/py-framefilter.c (py_print_single_arg): Return
EXT_LANG_BT_ERROR from catch.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] problem looking up some symbols when they have a linkage name
@ 2018-03-27 14:13 sergiodj+buildbot
2018-03-28 0:28 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-27 14:13 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 59cc4834e53565da1de4a7b615ed8890ed55c7da ***
Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 59cc4834e53565da1de4a7b615ed8890ed55c7da
problem looking up some symbols when they have a linkage name
This patch fixes a known failure in gdb.ada/maint_with_ada.exp
(maintenance check-psymtabs). Another way to witness the same
issue is by considering the following Ada declarations...
type Wrapper is record
A : Integer;
end record;
u00045 : constant Wrapper := (A => 16#060287af#);
pragma Export (C, u00045, "symada__cS");
... which declares a variable name "u00045" but with a linkage
name which is "symada__cS". This variable is a record with one
component, the Ada equivalent of a struct with one field in C.
Trying to print that variable's value currently yields:
(gdb) p /x <symada__cS>
'symada(char, signed)' has unknown type; cast it to its declared type
This indicates that GDB was only able to find the minimal symbol,
but not the full symbol. The expected output is:
(gdb) print /x <symada__cS>
$1 = (a => 0x60287af)
The error message gives a hint about what's happening: We processed
the symbol through gdb_demangle, which in the case of this particular
symbol name, ends up matching the C++ naming scheme. As a result,
the demangler transforms our symbol name into 'symada(char, signed)',
thus breaking Ada lookups.
This patch fixes the issue by first introducing a new language_defn
attribute called la_store_sym_names_in_linkage_form_p, which is a boolean
to be set to true for the few languages that do not want their symbols
to have their names stored in demangled form, and false otherwise.
We then use this language attribute to skip the call to gdb_demangle
for all languages whose la_store_sym_names_in_linkage_form_p is true.
In terms of the selection of languages for which the new attribute
is set to true, the selection errs on the side of preserving the
existing behavior, and only changes the behavior for the languages
where we are certain storing symbol names in demangling form is not
needed. It is conceivable that other languages might be in the same
situation, but I not knowing in detail the symbol name enconding
strategy, I decided to play it safe and let other language maintainers
potentially adjust their language if it makes sense to do so.
gdb/ChangeLog:
PR gdb/22670
* dwarf2read.c (dwarf2_physname): Do not return the demangled
symbol name if the CU's language stores symbol names in linkage
format.
* language.h (struct language_defn)
<la_store_sym_names_in_linkage_form_p>: New field. Adjust
all instances of this struct.
gdb/testsuite/ChangeLog:
* gdb.ada/maint_with_ada.exp: Remove PR gdb/22670 setup_kfail.
* gdb.ada/notcplusplus: New testcase.
* gdb.base/c-linkage-name.c: New file.
* gdb.base/c-linkage-name.exp: New testcase.
Tested on x86_64-linux.
This also passes AdaCore's internal GDB testsuite.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Move DWARF index-related things to a separate file
@ 2018-03-27 14:24 sergiodj+buildbot
2018-03-28 1:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-27 14:24 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT cd4fb1b2ffc88911e4109444ff729e31920d01ec ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: cd4fb1b2ffc88911e4109444ff729e31920d01ec
Move DWARF index-related things to a separate file
I want to add a DWARF index-related feature (automatically produce index
files when loading objfiles in GDB), but I don't want to add many
hundred lines to the already too big dwarf2read.c. I thought it would
be a logical split to move everything related to the DWARF index to its
own file.
I first tried to move everything that reads and writes DWARF indices to
a separate file, but found that the "read" part is a little bit
entangled with the rest of dwarf2read.c, so the line is hard to draw
about where to split. The write part is quite isolated though, so I
moved this part to a new file, dwarf-index-write.c. Some things are
necessary to both reading and writing indices, so I placed them in
dwarf-index-common.{c,h}. The idea would be to have a
dwarf-index-read.c eventually that would use it too (for now that code
is still in dwarf2read.c).
This required moving some things to a new dwarf2read.h header, so they
can be read by the code that writes the index.
The patch is big in number of lines, but it's all existing code being
moved around. The only changes are that some functions are not static
anymore, a declaration is added in a .h file, and therefore the comment
is moved there.
I built-tested it with a little and big endian target.
This patch is also available on the users/simark/split-dwarf2read
branch.
gdb/ChangeLog:
* Makefile.in (COMMON_SFILES): Add dwarf-index-common.c and
dwarf-index-write.c
(HFILES_NO_SRCDIR): Add dwarf-index-common.h and dwarf2read.h.
* dwarf-index-common.c: New file.
* dwarf-index-common.h: New file.
* dwarf-index-write.c: New file.
* dwarf2read.c: Include dwarf2read.h and dwarf-index-common.h.
(struct dwarf2_section_info): Move from here.
(dwarf2_section_info_def): Likewise.
(DEF_VEC_O (dwarf2_section_info_def)): Likewise.
(offset_type): Likewise.
(DW2_GDB_INDEX_SYMBOL_STATIC_SET_VALUE): Likewise.
(DW2_GDB_INDEX_SYMBOL_KIND_SET_VALUE): Likewise.
(DW2_GDB_INDEX_CU_SET_VALUE): Likewise.
(byte_swap): Likewise.
(MAYBE_SWAP): Likewise.
(dwarf2_per_cu_ptr): Likewise.
(DEF_VEC_P (dwarf2_per_cu_ptr)): Likewise.
(struct tu_stats): Likewise.
(struct dwarf2_per_objfile): Likewise.
(struct dwarf2_per_cu_data): Likewise.
(struct signatured_type): Likewise.
(sig_type_ptr): Likewise.
(DEF_VEC_P (sig_type_ptr)): Likewise.
(INDEX4_SUFFIX): Likewise.
(INDEX5_SUFFIX): Likewise.
(DEBUG_STR_SUFFIX): Likewise.
(dwarf2_read_section): Make non-static.
(mapped_index_string_hash): Move from here.
(dwarf5_djb_hash): Likewise.
(file_write): Likewise.
(class data_buf): Likewise.
(struct symtab_index_entry): Likewise.
(struct mapped_symtab): Likewise.
(find_slot): Likewise.
(hash_expand): Likewise.
(add_index_entry): Likewise.
(uniquify_cu_indices): Likewise.
(class c_str_view): Likewise.
(class c_str_view_hasher): Likewise.
(class vector_hasher): Likewise.
(write_hash_table): Likewise.
(psym_index_map): Likewise.
(struct addrmap_index_data): Likewise.
(add_address_entry): Likewise.
(add_address_entry_worker): Likewise.
(write_address_map): Likewise.
(symbol_kind): Likewise.
(write_psymbols): Likewise.
(struct signatured_type_index_data): Likewise.
(write_one_signatured_type): Likewise.
(recursively_count_psymbols): Likewise.
(recursively_write_psymbols): Likewise.
(class debug_names): Likewise.
(check_dwarf64_offsets): Likewise.
(psyms_seen_size): Likewise.
(write_gdbindex): Likewise.
(write_debug_names): Likewise.
(assert_file_size): Likewise.
(write_psymtabs_to_index): Likewise.
(save_gdb_index_command): Likewise.
(_initialize_dwarf2_read): Don't register the "save gdb-index"
command.
* dwarf2read.h: New file.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Include <cmath> in dwarf-index-write.c
@ 2018-03-27 15:13 sergiodj+buildbot
2018-03-28 4:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-27 15:13 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 608219fb2917d407058952adf164eb616880662b ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 608219fb2917d407058952adf164eb616880662b
Include <cmath> in dwarf-index-write.c
On x86-64 Fedora 26, when building with the system gcc, I get:
../../binutils-gdb/gdb/dwarf-index-write.c: In member function void debug_names::build():
../../binutils-gdb/gdb/dwarf-index-write.c:705:13: error: pow is not a member of std
There are actually more messages, but this is sufficient to show the
problem.
The fix is to include <cmath>.
I'm checking this in as obvious. Tested by building.
gdb/ChangeLog
2018-03-27 Tom Tromey <tom@tromey.com>
* dwarf-index-write.c: Include <cmath>.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] C++-ify typedef hash
@ 2018-03-27 16:58 sergiodj+buildbot
2018-03-28 5:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-27 16:58 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c819b2c0b216c69a4ae5bfba0eac71ffdf1b3596 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: c819b2c0b216c69a4ae5bfba0eac71ffdf1b3596
C++-ify typedef hash
This changes the typedef_hash_table structure to be a C++ class. It
adds constructors and destructors and changes some functions to be
methods of the class. Then it changes the various users of this class
to adapt. This allows for the removal of some cleanups.
Regression tested by the buildbot.
gdb/ChangeLog
2018-03-27 Tom Tromey <tom@tromey.com>
* typeprint.h (struct type_print_options) <local_typedefs,
global_typedefs>: Remove "struct" keyword.
(class typedef_hash_table): New class.
(recursively_update_typedef_hash, add_template_parameters)
(create_typedef_hash, free_typedef_hash, copy_typedef_hash)
(find_typedef_in_hash): Don't declare.
* typeprint.c (struct typedef_hash_table): Move to typeprint.h.
(typedef_hash_table::recursively_update): Rename from
recursively_update_typedef_hash. Now a member.
(typedef_hash_table::add_template_parameters): Rename from
add_template_parameters. Now a member.
(typedef_hash_table::typedef_hash_table): Now a constructor;
rename from create_typedef_hash.
(typedef_hash_table::~typedef_hash_table): Now a destructor;
rename from free_typedef_hash.
(do_free_typedef_hash, make_cleanup_free_typedef_hash)
(do_free_global_table): Remove.
(typedef_hash_table::typedef_hash_table): New constructor; renamed
from copy_type_recursive.
(create_global_typedef_table): Remove.
(typedef_hash_table::find_global_typedef): Now a member of
typedef_hash_table.
(typedef_hash_table::find_typedef): Rename from
find_typedef_in_hash; now a member.
(whatis_exp): Update.
* extension.h (struct ext_lang_type_printers): Add constructor and
destructor.
(start_ext_lang_type_printers, free_ext_lang_type_printers): Don't
declare.
* extension.c (ext_lang_type_printers::ext_lang_type_printers):
Now a constructor; rename from start_ext_lang_type_printers.
(ext_lang_type_printers): Now a destructor; rename from
free_ext_lang_type_printers.
* c-typeprint.c (find_typedef_for_canonicalize, c_print_type_1):
Update.
(c_type_print_base_struct_union): Update. Remove cleanups.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove cleanups from gdb_readline_wrapper
@ 2018-03-27 17:14 sergiodj+buildbot
2018-03-28 7:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-27 17:14 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 1dbeed45b6a81ddcb725b68ff12236e7c8386a47 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 1dbeed45b6a81ddcb725b68ff12236e7c8386a47
Remove cleanups from gdb_readline_wrapper
This removes some cleanups from gdb_readline_wrapper by changing the
existing gdb_readline_wrapper_cleanup struct to have a constructor and
destructor, and then changing gdb_readline_wrapper to simply
instantiate it on the stack.
gdb/ChangeLog
2018-03-27 Pedro Alves <palves@redhat.com>
Tom Tromey <tom@tromey.com>
* top.c (class gdb_readline_wrapper_cleanup): Add constructor,
destructor. Now a class.
(gdb_readline_wrapper_cleanup): Remove function.
(gdb_readline_wrapper): Remove cleanups.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove cleanups from prompt_for_continue
@ 2018-03-27 17:29 sergiodj+buildbot
2018-03-28 8:30 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-27 17:29 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 5aa892761c6a9f76c5b5ec2a9509e994b4f4de07 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 5aa892761c6a9f76c5b5ec2a9509e994b4f4de07
Remove cleanups from prompt_for_continue
This removes the cleanups from prompt_for_continue by the use of
unique_xmalloc_ptr.
gdb/ChangeLog
2018-03-27 Tom Tromey <tom@tromey.com>
* utils.c (prompt_for_continue): Use unique_xmalloc_ptr.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Enhance the AARCH64 assembler to support LDFF1xx instructions which use REG+REG addressing with an assumed offset register.
@ 2018-03-28 9:04 sergiodj+buildbot
2018-03-28 10:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-28 9:04 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c8d59609b1cf66eaff3c486e483f5e3d647c66ff ***
Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: c8d59609b1cf66eaff3c486e483f5e3d647c66ff
Enhance the AARCH64 assembler to support LDFF1xx instructions which use REG+REG addressing with an assumed offset register.
PR 22988
opcode * opcode/aarch64.h (enum aarch64_opnd): Add
AARCH64_OPND_SVE_ADDR_R.
opcodes * aarch64-tbl.h (aarch64_opcode_table): Add entries for LDFF1xx
instructions with only a base address register.
* aarch64-opc.c (operand_general_constraint_met_p): Add code to
handle AARHC64_OPND_SVE_ADDR_R.
(aarch64_print_operand): Likewise.
* aarch64-asm-2.c: Regenerate.
* aarch64_dis-2.c: Regenerate.
* aarch64-opc-2.c: Regenerate.
gas * config/tc-aarch64.c (parse_operands): Add code to handle
AARCH64_OPN_SVE_ADDR_R.
* testsuite/gas/aarch64/sve.s: Add tests for LDFF1xx instructions
with an assumed XZR offset address register.
* testsuite/gas/aarch64/sve.d: Update expected disassembly.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: don't show suffixes for to-scalar-int conversion insns
@ 2018-03-28 12:42 sergiodj+buildbot
2018-03-28 14:08 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-28 12:42 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9646c87b5a6c0462e8a9b6305d9e449bd099f19d ***
Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 9646c87b5a6c0462e8a9b6305d9e449bd099f19d
x86: don't show suffixes for to-scalar-int conversion insns
In the course of folding their patterns (possible now that the pointless
and partly even bogus VecESize are no longer in the way) I've noticed
that vcvt*2usi, other than their vcvt*2si counterparts, don't allow for
any suffixes. As that is supposedly intentional, make the disassembler
consistently omit suffixes for all to-scalar-int conversion insns.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: fold to-scalar-int conversion insns
@ 2018-03-28 12:56 sergiodj+buildbot
2018-03-28 15:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-28 12:56 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9f123b911ec8c460304c3e1a3f18f1c2a311d97a ***
Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 9f123b911ec8c460304c3e1a3f18f1c2a311d97a
x86: fold to-scalar-int conversion insns
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: convert broadcast insn attribute to boolean
@ 2018-03-28 13:10 sergiodj+buildbot
2018-03-28 17:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-28 13:10 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 8e6e0792d17be5d4321def520d12c1764dc0ba2a ***
Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 8e6e0792d17be5d4321def520d12c1764dc0ba2a
x86: convert broadcast insn attribute to boolean
The (only) valid broadcast type for an insn can be inferred from other
information.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] [1/2][GAS][AARCH64]Add BFD_RELOC_AARCH64_TLSLE_LDST8/16/32/64_TPREL_LO12 support in GAS.
@ 2018-03-28 17:35 sergiodj+buildbot
2018-03-28 21:28 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-28 17:35 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 84f1b9fb081372a726fd70dfd8258a707833caef ***
Author: Renlin Li <renlin.li@arm.com>
Branch: master
Commit: 84f1b9fb081372a726fd70dfd8258a707833caef
[1/2][GAS][AARCH64]Add BFD_RELOC_AARCH64_TLSLE_LDST8/16/32/64_TPREL_LO12 support in GAS.
This patch adds the following relocation support into binutils gas.
BFD_RELOC_AARCH64_TLSLE_LDST16_TPREL_LO12,
BFD_RELOC_AARCH64_TLSLE_LDST16_TPREL_LO12_NC,
BFD_RELOC_AARCH64_TLSLE_LDST32_TPREL_LO12,
BFD_RELOC_AARCH64_TLSLE_LDST32_TPREL_LO12_NC,
BFD_RELOC_AARCH64_TLSLE_LDST64_TPREL_LO12,
BFD_RELOC_AARCH64_TLSLE_LDST64_TPREL_LO12_NC,
BFD_RELOC_AARCH64_TLSLE_LDST8_TPREL_LO12,
BFD_RELOC_AARCH64_TLSLE_LDST8_TPREL_LO12_NC.
Those relocations includes both ip64 and ilp32 variant.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] BFD/PA: Remove ATTRIBUTE_UNUSED from `elf_hppa_info_to_howto_rel'
@ 2018-03-28 22:32 sergiodj+buildbot
2018-03-29 2:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-28 22:32 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 8b6a949ae55d3adbade84af4e11415d764647fc9 ***
Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 8b6a949ae55d3adbade84af4e11415d764647fc9
BFD/PA: Remove ATTRIBUTE_UNUSED from `elf_hppa_info_to_howto_rel'
Remove ATTRIBUTE_UNUSED annotation from the `abfd' parameter in
`elf_hppa_info_to_howto' now that commit f3185997ac09 ("PR 22875: Stop
strip corrupting unknown relocs"),
<https://sourceware.org/ml/binutils/2018-02/msg00445.html>, made it
used.
bfd/
* elf-hppa.h (elf_hppa_info_to_howto_rel): Remove
ATTRIBUTE_UNUSED from `abfd'.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove make_cleanup_unpush_target
@ 2018-03-30 19:31 sergiodj+buildbot
2018-03-30 20:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-30 19:31 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9ae79dac31c2bcbd2f5418da2e12af94060e139a ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 9ae79dac31c2bcbd2f5418da2e12af94060e139a
Remove make_cleanup_unpush_target
This removes make_cleanup_unpush_target, replacing it with a
unique_ptr. This may seem odd, because the object in question is not
actually freed, but unique_ptr provided the necessary functionality.
Tested by the buildbot.
gdb/ChangeLog
2018-03-30 Tom Tromey <tom@tromey.com>
* utils.h (make_cleanup_unpush_target): Remove.
* inf-ptrace.c (struct target_unpusher): New.
(target_unpush_up) New typedef.
(inf_ptrace_create_inferior, inf_ptrace_attach): Use
target_unpush_up.
* utils.c (do_unpush_target, make_cleanup_unpush_target): Remove.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove parameter from free_dwo_file
@ 2018-03-30 19:55 sergiodj+buildbot
2018-03-31 0:08 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-30 19:55 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 5dafb3d176ab8d9b9f0a46111d7040bb51ad8f8e ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 5dafb3d176ab8d9b9f0a46111d7040bb51ad8f8e
Remove parameter from free_dwo_file
The objfile parameter to free_dwo_file is unused, so remove it.
gdb/ChangeLog
2018-03-30 Tom Tromey <tom@tromey.com>
* dwarf2read.c (free_dwo_file): Remove "objfile" parameter.
(free_dwo_file_cleanup, free_dwo_file_from_slot): Update.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Change target_read_string to use unique_xmalloc_ptr
@ 2018-03-30 20:21 sergiodj+buildbot
2018-03-31 2:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-30 20:21 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e83e4e24021acb4b095b1e8a45a51c2ea088a1ed ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: e83e4e24021acb4b095b1e8a45a51c2ea088a1ed
Change target_read_string to use unique_xmalloc_ptr
This changes the out parameter of target_read_string to be a
unique_xmalloc_ptr. This avoids a cleanup and sets the stage for more
cleanup removals.
This patch also removes a seemingly needless alloca from
print_subexp_standard.
gdb/ChangeLog
2018-03-30 Tom Tromey <tom@tromey.com>
* windows-nat.c (handle_output_debug_string, handle_exception):
Update.
* target.h (target_read_string): Update.
* target.c (target_read_string): Change "string" to
unique_xmalloc_ptr.
* solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
Update.
* solib-frv.c (frv_current_sos): Update.
* solib-dsbt.c (dsbt_current_sos): Update.
* solib-darwin.c (darwin_current_sos): Update.
* linux-thread-db.c (inferior_has_bug): Update.
* expprint.c (print_subexp_standard) <case OP_OBJC_MSGCALL>:
Update. Remove alloca.
* ada-lang.c (ada_main_name): Update.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Use std::vector and std::string instead of VEC(char_ptr) in gdbserver tdesc
@ 2018-03-31 1:27 sergiodj+buildbot
2018-03-31 6:44 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-03-31 1:27 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 17d08cd4137063dbc43d9989b9a5cb315171174f ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 17d08cd4137063dbc43d9989b9a5cb315171174f
Use std::vector and std::string instead of VEC(char_ptr) in gdbserver tdesc
This is a straightforward replacement, no change in behavior are
intended/expected.
gdb/gdbserver/ChangeLog:
* tdesc.h (struct target_desc) <features>: Change type to
std::vector<std::string>.
* tdesc.c (target_desc::~target_desc): Adjust to std::vector
changes.
(tdesc_get_features_xml): Likewise.
(tdesc_create_feature): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove char_ptr typedef
@ 2018-04-01 18:40 sergiodj+buildbot
2018-04-01 19:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-01 18:40 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ec1f2d91e07522a77cbef7a438e132ff4a2a7839 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: ec1f2d91e07522a77cbef7a438e132ff4a2a7839
Remove char_ptr typedef
Now that all instances of VEC(char_ptr) are gone, we can remove the
typedef. There is just one usage left, that is trivial to replace.
Tested by rebuilding on an enable-targets=all build.
gdb/ChangeLog:
* common/gdb_vecs.h (char_ptr): Remove.
* tracepoint.c (encode_actions_1): Remove usage of char_ptr.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add myself as a write-after-approval GDB maintainer.
@ 2018-04-02 22:13 sergiodj+buildbot
2018-04-02 22:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-02 22:13 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b39efc483ac8caefa8b6480b7a01231230bc2298 ***
Author: Weimin Pan <weimin.pan@oracle.com>
Branch: master
Commit: b39efc483ac8caefa8b6480b7a01231230bc2298
Add myself as a write-after-approval GDB maintainer.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Change read_alphacoff_dynamic_symtab to use gdb::byte_vector
@ 2018-04-03 18:20 sergiodj+buildbot
2018-04-03 18:59 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-03 18:20 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c5edbf3d1c58d59135788f084a3bf681a49e0f9a ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: c5edbf3d1c58d59135788f084a3bf681a49e0f9a
Change read_alphacoff_dynamic_symtab to use gdb::byte_vector
This changes read_alphacoff_dynamic_symtab to use gdb::byte_vector.
This allows for the removal of some cleanups.
Tested by the buildbot; though I don't know whether this code path is
ever actually run.
gdb/ChangeLog
2018-04-03 Tom Tromey <tom@tromey.com>
* mipsread.c (read_alphacoff_dynamic_symtab): Use
gdb::byte_vector.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR binutils/22875: MIPS/ELF: Also fail with relocation placeholders
@ 2018-04-04 1:17 sergiodj+buildbot
2018-04-04 1:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-04 1:17 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 7ed6f92aaffdcc0995b0247379fb8ea621854dce ***
Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 7ed6f92aaffdcc0995b0247379fb8ea621854dce
PR binutils/22875: MIPS/ELF: Also fail with relocation placeholders
Do not consider placeholder EMPTY_HOWTO relocation entries valid in
`rtype_to_howto' MIPS handlers. Instead issue an unsupported relocation
type error and return a NULL howto as with relocations outside the three
ISA-specific min-max ranges.
bfd/
* elf32-mips.c (mips_elf32_rtype_to_howto): Also return
unsuccessfully for placeholder howtos.
* elf64-mips.c (mips_elf64_rtype_to_howto): Likewise.
* elfn32-mips.c (mips_elf_n32_rtype_to_howto): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR binutils/22875: FRV/ELF: Prevent an out-of-bounds howto table access
@ 2018-04-04 2:02 sergiodj+buildbot
2018-04-04 3:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-04 2:02 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f428698edfd845a21639f5145cba3772eb92abc2 ***
Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: f428698edfd845a21639f5145cba3772eb92abc2
PR binutils/22875: FRV/ELF: Prevent an out-of-bounds howto table access
Prevent an out-of-bounds `elf32_frv_howto_table' table access in
`frv_info_to_howto_rela' by using the size of the table rather than
R_FRV_max to determine the number of entries in the contiguous regular
FRV relocation range defined and described in the table.
bfd/
* elf32-frv.c (frv_info_to_howto_rela): Correct the range check
for `elf32_frv_howto_table' table access.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR binutils/22875: Visium/ELF: Prevent an out-of-bounds howto table access
@ 2018-04-04 2:16 sergiodj+buildbot
2018-04-04 6:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-04 2:16 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 707bad1b21c18cf8e570fb8df8f7c5961fb0f3a5 ***
Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 707bad1b21c18cf8e570fb8df8f7c5961fb0f3a5
PR binutils/22875: Visium/ELF: Prevent an out-of-bounds howto table access
Prevent an out-of-bounds `visium_elf_howto_table' table access in
`visium_info_to_howto_rela' by using the size of the table rather than
R_VISIUM_max to determine the number of entries in the contiguous
regular Visium relocation range defined and described in the table.
bfd/
* elf32-visium.c (visium_info_to_howto_rela): Correct the range
check for `visium_elf_howto_table' table access.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR binutils/22875: HPPA/ELF: Also fail with relocation placeholders
@ 2018-04-04 2:44 sergiodj+buildbot
2018-04-04 10:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-04 2:44 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 8ee55178c22326c3624ad5872dc5382341ddcd2c ***
Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 8ee55178c22326c3624ad5872dc5382341ddcd2c
PR binutils/22875: HPPA/ELF: Also fail with relocation placeholders
Do not consider R_PARISC_UNIMPLEMENTED placeholder relocation entries of
the `elf_hppa_howto_table' table valid in `info_to_howto' HPPA handlers.
Instead issue an unsupported relocation type error and return a NULL
howto as with relocations whose number is R_PARISC_UNIMPLEMENTED or
beyond.
bfd/
* elf-hppa.h (elf_hppa_info_to_howto): Also return
unsuccessfully for unimplemented relocations.
(elf_hppa_info_to_howto_rel): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] i386: Clear vex instead of vex.evex
@ 2018-04-04 11:58 sergiodj+buildbot
2018-04-04 13:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-04 11:58 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT caf0678c84b5b55fbc4bcc853954745a4ad8b658 ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: caf0678c84b5b55fbc4bcc853954745a4ad8b658
i386: Clear vex instead of vex.evex
"vex" has many fields to control how to decode an instruction. Clear
all fields in "vex" before decoding an instruction to avoid using values
left from the previous instruction.
gas/
PR binutils/23025
* testsuite/gas/i386/prefix.s: Add tests for vcvtpd2dq with
VEX and EVEX prefixes.
* testsuite/gas/i386/prefix.d: Updated.
opcodes/
PR binutils/23025
* i386-dis.c (get_valid_dis386): Don't set vex.prefix nor vex.w
to 0.
(print_insn): Clear vex instead of vex.evex.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] elf-hppa.h warning fix
@ 2018-04-05 0:02 sergiodj+buildbot
2018-04-05 1:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-05 0:02 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 0e8452bb2297b5eb98a447f357ac82bece4e7024 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 0e8452bb2297b5eb98a447f357ac82bece4e7024
elf-hppa.h warning fix
* elf-hppa.h (elf_hppa_info_to_howto): Init howto to NULL.
(elf_hppa_info_to_howto_rel): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove some cleanups from search_minsyms_for_name
@ 2018-04-05 13:56 sergiodj+buildbot
2018-04-05 14:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-05 13:56 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 41c1efc614472cdc74397e734f5a66018362a80a ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 41c1efc614472cdc74397e734f5a66018362a80a
Remove some cleanups from search_minsyms_for_name
This changes struct collect_minsyms to use a std::vector, which
enables the removal of a cleanup from search_minsyms_for_name. This
also changes iterate_over_minimal_symbols to take a
gdb::function_view, which makes a function in linespec.c more
type-safe.
ChangeLog
2018-04-05 Tom Tromey <tom@tromey.com>
* minsyms.h (iterate_over_minimal_symbols): Update.
* minsyms.c (iterate_over_minimal_symbols): Take a
gdb::function_view.
* linespec.c (struct collect_minsyms): Remove.
(compare_msyms): Now a std::sort comparator.
(add_minsym): Add parameters.
(search_minsyms_for_name): Update. Use std::vector.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Return std::string from canonical_to_fullform
@ 2018-04-05 14:37 sergiodj+buildbot
2018-04-05 19:05 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-05 14:37 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 53a0f8a250199af97ff8708e3899835086c7a24d ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 53a0f8a250199af97ff8708e3899835086c7a24d
Return std::string from canonical_to_fullform
This changes canonical_to_fullform to return a std::string, and
changes decode_line_2 to use std::vector. This allows for the removal
of some cleanups.
ChangeLog
2018-04-05 Tom Tromey <tom@tromey.com>
* linespec.c (canonical_to_fullform): Return std::string.
(filter_results): Update.
(struct decode_line_2_item): Add constructor.
<fullform, displayform>: Now std::string.
(decode_line_2_compare_items): Now a std::sort comparator.
(decode_line_2): Update.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Have filter_results take a std::vector
@ 2018-04-05 14:52 sergiodj+buildbot
2018-04-05 21:06 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-05 14:52 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f73c6ece7888af880d3b03b2d57ee7782f2a539b ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: f73c6ece7888af880d3b03b2d57ee7782f2a539b
Have filter_results take a std::vector
This chagnes filter_results to take a std::vector, allowing the
removal of some cleanups in its callers.
ChangeLog
2018-04-05 Tom Tromey <tom@tromey.com>
* linespec.c (filter_results): Use std::vector.
(decode_line_2, decode_line_full): Update.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove a string copy from event_location_to_sals
@ 2018-04-05 15:05 sergiodj+buildbot
2018-04-06 1:23 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-05 15:05 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9be2c17a900178df75a2208fd112ceb4325a70c1 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 9be2c17a900178df75a2208fd112ceb4325a70c1
Remove a string copy from event_location_to_sals
The use of "const" showed that a string copy in event_location_to_sals
was unnecessary. This patch removes it.
ChangeLog
2018-04-05 Tom Tromey <tom@tromey.com>
* linespec.c (event_location_to_sals) <case ADDRESS_LOCATION>:
Remove a string copy.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove unnecessary include from linespec.h
@ 2018-04-05 16:01 sergiodj+buildbot
2018-04-06 6:44 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-05 16:01 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 8a76bd3ba43205b76226f41fe73e2840c2444742 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 8a76bd3ba43205b76226f41fe73e2840c2444742
Remove unnecessary include from linespec.h
linespec.h was inculding vec.h, but doesn't expose any VECs.
So, this include can be removed.
ChangeLog
2018-04-05 Tom Tromey <tom@tromey.com>
* linespec.h: Remove include of "vec.h".
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Change streq to return bool
@ 2018-04-05 18:17 sergiodj+buildbot
2018-04-06 2:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-05 18:17 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 459a2e4ccf9aadfba9819facba1c9be5297c1625 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 459a2e4ccf9aadfba9819facba1c9be5297c1625
Change streq to return bool
I wanted to use streq with std::unique in another (upcoming) patch in
this seres, so I changed it to return bool. To my surprise, this lead
to regressions. The cause turned out to be that streq was used as an
htab callback -- by casting it to the correct function type. This
sort of cast is invalid, so this patch adds a variant which is
directly suitable for use by htab. (Note that I did not add an
overload, as I could not get that to work with template deduction in
the other patch.)
ChangeLog
2018-04-05 Tom Tromey <tom@tromey.com>
* completer.c (completion_tracker::completion_tracker): Remove
cast.
(completion_tracker::discard_completions): Likewise.
* breakpoint.c (ambiguous_names_p): Remove cast.
* ada-lang.c (_initialize_ada_language): Remove cast.
* utils.h (streq): Update.
(streq_hash): Add new declaration.
* utils.c (streq): Return bool.
(streq_hash): New function.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Use dlsym to check if libdl is needed for plugin
@ 2018-04-05 22:53 sergiodj+buildbot
2018-04-06 10:57 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-05 22:53 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 3cba8b6c93ab8c573ba4678255df11486de61c54 ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 3cba8b6c93ab8c573ba4678255df11486de61c54
Use dlsym to check if libdl is needed for plugin
config/plugins.m4 has
if test "$plugins" = "yes"; then
AC_SEARCH_LIBS([dlopen], [dl])
fi
Plugin uses dlsym, but libasan.so only intercepts dlopen, not dlsym:
[hjl@gnu-tools-1 binutils-text]$ nm -D /lib64/libasan.so.4| grep " dl"
0000000000038580 W dlclose
U dl_iterate_phdr
000000000004dc50 W dlopen
U dlsym
U dlvsym
[hjl@gnu-tools-1 binutils-text]$
Testing dlopen for libdl leads to false negative when -fsanitize=address
is used. It results in link failure:
../bfd/.libs/libbfd.a(plugin.o): undefined reference to symbol 'dlsym@@GLIBC_2.16'
dlsym should be used to check if libdl is needed for plugin.
bfd/
PR gas/22318
* configure: Regenerated.
binutils/
PR gas/22318
* configure: Regenerated.
gas/
PR gas/22318
* configure: Regenerated.
gprof/
PR gas/22318
* configure: Regenerated.
ld/
PR gas/22318
* configure: Regenerated.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86-64: Don't mask out R_X86_64_converted_reloc_bit
@ 2018-04-06 12:23 sergiodj+buildbot
2018-04-06 13:02 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-06 12:23 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a6fd92b0578c5d2172799d7f38ddbda1bd87ea03 ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: a6fd92b0578c5d2172799d7f38ddbda1bd87ea03
x86-64: Don't mask out R_X86_64_converted_reloc_bit
R_X86_64_converted_reloc_bit is set in elf_x86_64_convert_load_reloc
which is called from elf_x86_64_check_relocs. Since it is used only
internally by linker, there is no need to mask it out in
elf_x86_64_info_to_howto.
* elf64-x86-64.c (elf_x86_64_info_to_howto): Don't mask out
R_X86_64_converted_reloc_bit.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Introduce a gdb_ref_ptr specialization for struct value
@ 2018-04-06 22:03 sergiodj+buildbot
2018-04-06 22:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-06 22:03 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 22bc8444e6d377fd016253926c2a2597ff944842 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 22bc8444e6d377fd016253926c2a2597ff944842
Introduce a gdb_ref_ptr specialization for struct value
struct value is internally reference counted and so, while it also has
some ownership rules unique to it, it makes sense to use a gdb_ref_ptr
when managing it automatically.
This patch removes the existing unique_ptr specialization in favor of
a reference-counted pointer. It also introduces two other
clarifications:
1. Rename value_free to value_decref, which I think is more in line
with what the function actually does; and
2. Change release_value to return a gdb_ref_ptr. This change allows
us to remove the confusing release_value_or_incref function,
primarily by making it much simpler to reason about the result of
release_value.
gdb/ChangeLog
2018-04-06 Tom Tromey <tom@tromey.com>
* varobj.c (varobj_clear_saved_item)
(update_dynamic_varobj_children, install_new_value, ~varobj):
Update.
* value.h (value_incref): Move declaration earlier.
(value_decref): Rename from value_free.
(struct value_ref_policy): New.
(value_ref_ptr): New typedef.
(struct value_deleter): Remove.
(gdb_value_up): Remove typedef.
(release_value): Change return type.
(release_value_or_incref): Remove.
* value.c (set_value_parent): Update.
(value_incref): Change return type.
(value_decref): Rename from value_free.
(value_free_to_mark, free_all_values, free_value_chain): Update.
(release_value): Return value_ref_ptr.
(release_value_or_incref): Remove.
(record_latest_value, set_internalvar, clear_internalvar):
Update.
* stack.c (info_frame_command): Don't call value_free.
* python/py-value.c (valpy_dealloc, valpy_new)
(value_to_value_object): Update.
* printcmd.c (do_examine): Update.
* opencl-lang.c (lval_func_free_closure): Update.
* mi/mi-main.c (register_changed_p): Don't call value_free.
* mep-tdep.c (mep_frame_prev_register): Don't call value_free.
* m88k-tdep.c (m88k_frame_prev_register): Don't call value_free.
* m68hc11-tdep.c (m68hc11_frame_prev_register): Don't call
value_free.
* guile/scm-value.c (vlscm_free_value_smob)
(vlscm_scm_from_value): Update.
* frame.c (frame_register_unwind, frame_unwind_register_signed)
(frame_unwind_register_unsigned, get_frame_register_bytes)
(put_frame_register_bytes): Don't call value_free.
* findvar.c (address_from_register): Don't call value_free.
* dwarf2read.c (dwarf2_compute_name): Don't call value_free.
* dwarf2loc.c (entry_data_value_free_closure)
(value_of_dwarf_reg_entry, free_pieced_value_closure)
(dwarf2_evaluate_loc_desc_full): Update.
* breakpoint.c (update_watchpoint, breakpoint_init_inferior)
(~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
(~watchpoint, watch_command_1)
(invalidate_bp_value_on_memory_change): Update.
* alpha-tdep.c (alpha_register_to_value): Don't call value_free.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Change last_examine_value to value_ref_ptr
@ 2018-04-06 22:31 sergiodj+buildbot
2018-04-07 1:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-06 22:31 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9b5587295bbc57e5e0453b659e24d7c2b504b894 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 9b5587295bbc57e5e0453b659e24d7c2b504b894
Change last_examine_value to value_ref_ptr
This patch removes some manual reference count manipulation by
changing last_examine_value to be a value_ref_ptr and then updating
the users.
gdb/ChangeLog
2018-04-06 Tom Tromey <tom@tromey.com>
* printcmd.c (last_examine_address): Change type to
value_ref_ptr.
(do_examine, x_command): Update.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Change value history to use value_ref_ptr
@ 2018-04-06 23:00 sergiodj+buildbot
2018-04-07 4:05 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-06 23:00 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 4d0266a0e0d9e9b615b04ff209a73d3725495835 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 4d0266a0e0d9e9b615b04ff209a73d3725495835
Change value history to use value_ref_ptr
This simplifies the value history implementation by replacing the
current data structure with a std::vector, and by making the value
history simply hold a reference to each value.
gdb/ChangeLog
2018-04-06 Tom Tromey <tom@tromey.com>
* value.c (VALUE_HISTORY_CHUNK, struct value_history_chunk)
(value_history_chain, value_history_count): Remove.
(value_history): New global.
(record_latest_value, access_value_history, show_values)
(preserve_values): Update.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove free_value_chain
@ 2018-04-06 23:29 sergiodj+buildbot
2018-04-07 6:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-06 23:29 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a6535de1903d9caad8c10c1d81c51a29612456a6 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: a6535de1903d9caad8c10c1d81c51a29612456a6
Remove free_value_chain
This patch changes value_release_to_mark and fetch_subexp_value to
return a std::vector of value references, rather than relying on the
"next" field that is contained in a struct value. This makes it
simpler to reason about the returned values, and also allows for the
removal of free_value_chain.
gdb/ChangeLog
2018-04-06 Tom Tromey <tom@tromey.com>
* value.h (fetch_subexp_value, value_release_to_mark): Update.
(free_value_chain): Remove.
* value.c (free_value_chain): Remove.
(value_release_to_mark): Return a std::vector.
* ppc-linux-nat.c (num_memory_accesses): Change "chain" to a
std::vector.
(check_condition): Update.
* eval.c (fetch_subexp_value): Change "val_chain" to a
std::vector.
* breakpoint.c (update_watchpoint): Update.
(can_use_hardware_watchpoint): Change "vals" to a std::vector.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Change value::parent to a value_ref_ptr
@ 2018-04-07 0:11 sergiodj+buildbot
2018-04-07 11:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 0:11 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2c8331b987f41fa53ed371d0bbeaa3cea50bd514 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 2c8331b987f41fa53ed371d0bbeaa3cea50bd514
Change value::parent to a value_ref_ptr
This changes value::parent to a value_ref_ptr. This removes a bit of
manual reference count management.
gdb/ChangeLog
2018-04-06 Tom Tromey <tom@tromey.com>
* value.c (~value): Update.
(struct value) <parent>: Now a value_ref_ptr.
(value_parent, set_value_parent, value_address, value_copy):
Update.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Change varobj to use value_ref_ptr
@ 2018-04-07 0:41 sergiodj+buildbot
2018-04-07 2:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 0:41 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b4d61099ba840824fd0aac9800403f6278476347 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: b4d61099ba840824fd0aac9800403f6278476347
Change varobj to use value_ref_ptr
This changes varobj to use value_ref_ptr, allowing the removal of some
manual reference count management.
gdb/ChangeLog
2018-04-06 Tom Tromey <tom@tromey.com>
* varobj.h (struct varobj) <value>: Now a value_ref_ptr.
* varobj.c (varobj_set_display_format, varobj_set_value)
(install_default_visualizer, construct_visualizer)
(install_new_value, ~varobj, varobj_get_value_type)
(my_value_of_variable, varobj_editable_p): Update.
* c-varobj.c (c_describe_child, c_value_of_variable)
(cplus_number_of_children, cplus_describe_child): Update.
* ada-varobj.c (ada_number_of_children, ada_name_of_child)
(ada_path_expr_of_child, ada_value_of_child, ada_type_of_child)
(ada_value_of_variable, ada_value_is_changeable_p): Update.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove value::next and value::released
@ 2018-04-07 4:04 sergiodj+buildbot
2018-04-07 8:05 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 4:04 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 062d818d2535d4bc9ccd5dbf3c6702b9f3e763cc ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 062d818d2535d4bc9ccd5dbf3c6702b9f3e763cc
Remove value::next and value::released
This patch converts all_values to simply hold a list of references to
values. Now, there's no need to have a value record whether or not it
is released -- there is only a single reference-counting mechanism for
values. So, this also removes value::next, value::released, and
value_next.
gdb/ChangeLog
2018-04-06 Tom Tromey <tom@tromey.com>
* value.c (struct value) <released, next>: Remove.
(all_values): Now a std::vector.
(allocate_value_lazy): Update.
(value_next): Remove.
(value_mark, value_free_to_mark, release_value)
(value_release_to_mark): Update.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Make target_read_alloc & al return vectors
@ 2018-04-07 17:38 sergiodj+buildbot
2018-04-07 18:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 17:38 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9018be22e022e6db2ba07c4e407c7244022bc69a ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 9018be22e022e6db2ba07c4e407c7244022bc69a
Make target_read_alloc & al return vectors
This patch started by changing target_read_alloc_1 to return a
byte_vector, to avoid manual memory management (in target_read_alloc_1
and in the callers). To communicate failures to the callers, it
actually returns a gdb::optional<gdb::byte_vector>.
Adjusting target_read_stralloc was a bit more tricky, since it wants to
return a buffer of char, and not gdb_byte. Since you can't just cast a
gdb::byte_vector into a gdb::def_vector<char>, I made
target_read_alloc_1 templated, so both versions (that return vectors of
gdb_byte and char) are generated. Since target_read_stralloc now
returns a gdb::char_vector instead of a gdb::unique_xmalloc_ptr<char>, a
few callers need to be adjusted.
gdb/ChangeLog:
* common/byte-vector.h (char_vector): New type.
* target.h (target_read_alloc): Return
gdb::optional<byte_vector>.
(target_read_stralloc): Return gdb::optional<char_vector>.
(target_get_osdata): Return gdb::optional<char_vector>.
* target.c (target_read_alloc_1): Templatize. Replacement
manual memory management with vector.
(target_read_alloc): Change return type, adjust.
(target_read_stralloc): Change return type, adjust.
(target_get_osdata): Change return type, adjust.
* auxv.c (struct auxv_info) <length>: Remove.
<data>: Change type to gdb::optional<byte_vector>.
(auxv_inferior_data_cleanup): Free auxv_info with delete.
(get_auxv_inferior_data): Allocate auxv_info with new, adjust.
(target_auxv_search): Adjust.
(fprint_target_auxv): Adjust.
* avr-tdep.c (avr_io_reg_read_command): Adjust.
* linux-tdep.c (linux_spu_make_corefile_notes): Adjust.
(linux_make_corefile_notes): Adjust.
* osdata.c (get_osdata): Adjust.
* remote.c (remote_get_threads_with_qxfer): Adjust.
(remote_memory_map): Adjust.
(remote_traceframe_info): Adjust.
(btrace_read_config): Adjust.
(remote_read_btrace): Adjust.
(remote_pid_to_exec_file): Adjust.
* solib-aix.c (solib_aix_get_library_list): Adjust.
* solib-dsbt.c (decode_loadmap): Don't free buf.
(dsbt_get_initial_loadmaps): Adjust.
* solib-svr4.c (svr4_current_sos_via_xfer_libraries): Adjust.
* solib-target.c (solib_target_current_sos): Adjust.
* tracepoint.c (sdata_make_value): Adjust.
* xml-support.c (xinclude_start_include): Adjust.
(xml_fetch_content_from_file): Adjust.
* xml-support.h (xml_fetch_another): Change return type.
(xml_fetch_content_from_file): Change return type.
* xml-syscall.c (xml_init_syscalls_info): Adjust.
* xml-tdesc.c (file_read_description_xml): Adjust.
(fetch_available_features_from_target): Change return type.
(target_fetch_description_xml): Adjust.
(target_read_description_xml): Adjust.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix generation of x86-64 gdbarch with osabi none (PR 22979)
@ 2018-04-07 18:05 sergiodj+buildbot
2018-04-07 20:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 18:05 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c912f608be7bc2598b919da2b11721b3c262d154 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: c912f608be7bc2598b919da2b11721b3c262d154
Fix generation of x86-64 gdbarch with osabi none (PR 22979)
When a 64-bits (x86-64) gdbarch is created, it is first born as a
32-bits gdbarch in i386_gdbarch_init. The call gdbarch_init_osabi will
call the handler register for the selected (arch, osabi) pair, such as
amd64_linux_init_abi. The various amd64 handlers call amd64_init_abi,
which turns the gdbarch into a 64-bits one.
When selecting the i386:x86-64 architecture with no osabi, no such
handler is ever called, so the gdbarch stays (wrongfully) a 32-bits one.
My first idea was to manually call amd64_init_abi & al in
i386_gdbarch_init when the osabi is GDB_OSABI_NONE. However, this
doesn't work in a build of GDB where i386 is included as a target but
not amd64. My next option (implemented in this patch), is to allow
registering handlers for GDB_OSABI_NONE. I added two such handlers in
amd64-tdep.c, so now it works the same as for the "normal" osabis. It
required re-ordering things in gdbarch_init_osabi to allow running
handlers for GDB_OSABI_NONE.
Without this patch applied (but with the previous one*) :
(gdb) set osabi none
(gdb) set architecture i386:x86-64
The target architecture is assumed to be i386:x86-64
(gdb) p sizeof(void*)
$1 = 4
and now:
(gdb) set osabi none
(gdb) set architecture i386:x86-64
The target architecture is assumed to be i386:x86-64
(gdb) p sizeof(void*)
$1 = 8
* Before the previous patch, which fixed "set osabi none", this bug was
hidden because we didn't actually try to generate a gdbarch for no
osabi, it would always fall back on Linux. Generating the gdbarch for
amd64/linux did work.
gdb/ChangeLog:
PR gdb/22979
* amd64-tdep.c (amd64_none_init_abi): New function.
(amd64_x32_none_init_abi): New function.
(_initialize_amd64_tdep): Register handlers for x86-64 and
x64_32 with GDB_OSABI_NONE.
* osabi.c (gdbarch_init_osabi): Allow running handlers for the
GDB_OSABI_NONE osabi.
gdb/testsuite/ChangeLog:
PR gdb/22979
* gdb.arch/amd64-osabi.exp: New file.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Implement write_async_safe for mi_console_file (PR 22299)
@ 2018-04-07 18:34 sergiodj+buildbot
2018-04-07 23:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 18:34 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 7c4e78cf63f6436ae43e8289badba78d81e2eb2c ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 7c4e78cf63f6436ae43e8289badba78d81e2eb2c
Implement write_async_safe for mi_console_file (PR 22299)
Enabling "set debug lin-lwp 1" with the MI interpreter doesn't work.
When the sigchld_handler function wants to print a debug output
("sigchld\n"), it uses ui_file_write_async_safe. This ends up in the
default implementation of ui_file::write_async_safe, which aborts GDB.
This patch implements the write_async_safe method for mi_console_file.
The "normal" MI output is line buffered, which means the output
accumulates in m_buffer until a \n is written, at which point it's
flushed in m_raw. The implementation of write_async_safe provided by
this patch bypasses this buffer and writes directly to m_raw. There are
two reasons for this:
(1) Appending to m_buffer (therefore to an std::string) is probably not
async-safe, as it may allocate memory.
(2) We may have a partial output already in m_buffer, so that would lead
to some nested MI output, not so great.
There is probably still a chance to have bad MI output, if
sigchld_handler is invoked in the middle of mi_console_file's flush, and
the line being flushed is only partially sent to m_raw. The solution
would probably be to block signals during flushing. Since this is only
used for debug output, I don't know if it's worth the effort to do that.
To implement write_async_safe, I needed to use the fputstrn_unfiltered,
which does the necessary escaping (e.g. replace \n with \\n). I started
by adding printchar's callback parameters to fputstrn_unfiltered, to be
able to pass async-safe versions of them. It's not easy to provide an
async-safe version of do_fprintf, but it turns out that we can easily
replace printchar's callbacks with a single do_fputc quite easily. The
async-safe version of do_fputc simply calls the underlying ui_file's
write_async_safe method.
gdb/ChangeLog:
PR mi/22299
* mi/mi-console.c (do_fputc_async_safe): New.
(mi_console_file::write_async_safe): New.
(mi_console_file::flush): Adjust calls to fputstrn_unfiltered.
* mi/mi-console.h (class mi_console_file) <write_async_safe>:
New.
* ui-file.c (ui_file::putstrn): Adjust call to
fputstrn_unfiltered.
* utils.c (printchar): Replace do_fputs and do_fprintf
parameters by do_fputc.
(fputstr_filtered): Adjust call to printchar.
(fputstr_unfiltered): Likewise.
(fputstrn_filtered): Likewise.
(fputstrn_unfiltered): Add do_fputc parameter, pass to
printchar.
* utils.h (do_fputc_ftype): New typedef.
(fputstrn_unfiltered): Add do_fputc parameter.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Defer breakpoint reset when cloning progspace for fork child
@ 2018-04-07 18:47 sergiodj+buildbot
2018-04-08 0:55 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 18:47 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b2e586e850dbf1dafc10beea3250d22e70add4b5 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: b2e586e850dbf1dafc10beea3250d22e70add4b5
Defer breakpoint reset when cloning progspace for fork child
Using this simple test:
static void
break_here ()
{
}
int
main (int argc, char *argv[])
{
fork ();
break_here();
return 0;
}
compiled as a PIE:
$ gcc test.c -g3 -O0 -o test -pie
and running this:
$ ./gdb -nx -q --data-directory=data-directory ./test -ex "b break_here" -ex "set detach-on-fork off" -ex r
gives:
Warning:
Cannot insert breakpoint 1.
Cannot access memory at address 0x64a
Note that GDB might get stopped by SIGTTOU because of this issue:
https://sourceware.org/bugzilla/show_bug.cgi?id=23020
In that case, just use "fg" to continue.
This issue happens only with position-independent executables. Adding
the main objfile for the new inferior (the fork child) causes GDB to try
to reset the breakpoints. However, that new objfile has not been
relocated yet. So the breakpoint on "break_here" resolves to an
unrelocated address, from which we are trying to read/write to set a
breakpoint. Passing SYMFILE_DEFER_BP_RESET avoids that problem. The
executable is relocated just after, in the follow_fork_inferior
function.
The buildbot seems happy with this patch. I don't think it's necessary
to add a new test. Just changing this made many tests go from FAIL to
PASS on my machine, where gcc produces PIE executables by default. If
anything, I think we would need to add a board file that produces
position-independent executables, so that we can run all the tests with
PIE, even on machines where that is not the default.
gdb/ChangeLog:
* progspace.c (clone_program_space): Pass SYMFILE_DEFER_BP_RESET
to symbol_file_add_main.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove some usages of get_dwarf2_per_objfile
@ 2018-04-07 19:29 sergiodj+buildbot
2018-04-08 4:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 19:29 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 12359b5e8f2a4034e1e4cd7f0b454fb03151df4c ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 12359b5e8f2a4034e1e4cd7f0b454fb03151df4c
Remove some usages of get_dwarf2_per_objfile
This patch removes some usages of get_dwarf2_per_objfile, where we can
get hold of the dwarf2_per_objfile object in a simpler way. For
example, it's simpler (and slightly less work) to pass
dwarf2_per_objfile and get the objfile from it than to pass the objfile
and call get_dwarf2_per_objfile.
Ideally, get_dwarf2_per_objfile should only be used in the entry points
of the dwarf2 code, where we receive an objfile.
gdb/ChangeLog:
* dwarf2read.c (create_cus_from_index_list): Replace objfile arg
with dwarf2_per_objfile.
(create_cus_from_index): Likewise.
(create_signatured_type_table_from_index): Likewise.
(dwarf2_read_index): Likewise.
(dwarf2_initialize_objfile): Likewise.
(dwarf2_fetch_die_loc_sect_off): Get dwarf2_per_objfile from
per_cu rather than get_dwarf2_per_objfile.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Make dwarf2_per_objfile::all_type_units an std::vector
@ 2018-04-07 19:57 sergiodj+buildbot
2018-04-08 7:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 19:57 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b2bdb8cf395f491319264cda42e41538f55a86d9 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: b2bdb8cf395f491319264cda42e41538f55a86d9
Make dwarf2_per_objfile::all_type_units an std::vector
Make all_type_units an std::vector, remove
n_type_units/n_allocated_type_units and some manual memory management.
gdb/ChangeLog:
* dwarf2read.h (struct dwarf2_per_objfile) <n_type_units>:
Remove.
<n_allocated_type_units>: Remove.
<all_type_units>: Change to std::vector.
* dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
to std::vector change.
(dwarf2_per_objfile::get_cutu): Likewise.
(dwarf2_per_objfile::get_tu): Likewise.
(create_signatured_type_table_from_index): Likewise.
(create_signatured_type_table_from_debug_names): Likewise.
(dw2_symtab_iter_next): Likewise.
(dw2_print_stats): Likewise.
(dw2_expand_all_symtabs): Likewise.
(dw2_expand_marked_cus): Likewise.
(dw2_debug_names_iterator::next): Likewise.
(dwarf2_initialize_objfile): Likewise.
(add_signatured_type_cu_to_table): Likewise.
(create_all_type_units): Likewise.
(add_type_unit): Likewise.
(struct tu_abbrev_offset): Add constructor.
(build_type_psymtabs_1): Adjust to std::vector change.
(print_tu_stats): Likewise.
* dwarf-index-write.c (check_dwarf64_offsets): Likewise.
(write_debug_names): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove stale file i386-avx.dat
@ 2018-04-07 20:17 sergiodj+buildbot
2018-04-07 22:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 20:17 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 5dc026d3f04ac657378308202ff7d43a1613f14c ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 5dc026d3f04ac657378308202ff7d43a1613f14c
Remove stale file i386-avx.dat
I noticed that regformats/i386/i386-avx.dat did not get re-generated
when doing "make" in the features directory. I think it's a leftover
from commit
f5a29eb0a663 ("Clean up x86 non-linux GDBserver target descriptions")
I build-tested gdbserver with amd64 and i386.
gdb/ChangeLog:
* regformats/i386/i386-avx.dat: Remove.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix indentation in gdb.mi/mi-stack.exp
@ 2018-04-07 20:26 sergiodj+buildbot
2018-04-08 11:27 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 20:26 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9b73db36739a72d216eb14d35edac2acfca7faa3 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 9b73db36739a72d216eb14d35edac2acfca7faa3
Fix indentation in gdb.mi/mi-stack.exp
This patch fixes the indentation in gdb.mi/mi-stack.exp, which is a bit
inconsistent.
gdb/testsuite/ChangeLog:
* gdb.mi/mi-stack.exp: Fix indentation.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix gdb.mi/mi-stack.exp when gcc generates a stack protector
@ 2018-04-07 20:40 sergiodj+buildbot
2018-04-08 13:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 20:40 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a0be7a3671e6252c0f3353d128f84c641005fa06 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: a0be7a3671e6252c0f3353d128f84c641005fa06
Fix gdb.mi/mi-stack.exp when gcc generates a stack protector
I see some failures in the gdb.mi/mi-stack.exp test. The test runs to
the callee4 function:
int callee4 (void)
{
int A=1;
int B=2;
int C;
int D[3] = {0, 1, 2};
C = A + B;
return 0;
}
and expects to be stopped at the A=1 line. However, when gcc generates
some stack protection code, it will stop at the { instead, as shown by
this disassembly (after I did "break callee4" and "run"):
(gdb) disassemble /s
Dump of assembler code for function callee4:
/home/simark/src/binutils-gdb/gdb/testsuite/gdb.mi/mi-stack.c:
26 {
0x00005555555546ca <+0>: push %rbp
0x00005555555546cb <+1>: mov %rsp,%rbp
0x00005555555546ce <+4>: sub $0x20,%rsp
=> 0x00005555555546d2 <+8>: mov %fs:0x28,%rax
0x00005555555546db <+17>: mov %rax,-0x8(%rbp)
0x00005555555546df <+21>: xor %eax,%eax
27 int A=1; /* callee4 begin */
0x00005555555546e1 <+23>: movl $0x1,-0x20(%rbp)
28 int B=2;
0x00005555555546e8 <+30>: movl $0x2,-0x1c(%rbp)
The rest of the test relies on execution stopping on the A=1, so many things
fail after that. This patch uses mi_continue_to_line instead, to stop at the
A=1 line precisely.
gdb/testsuite/ChangeLog:
* gdb.mi/mi-stack.exp (test_stack_frame_listing): Use
mi_continue_to_line.
* gdb.mi/mi-stack.c (callee4): Add comment.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Rearrange PLT reloc output on powerpc
@ 2018-04-09 9:03 sergiodj+buildbot
2018-04-09 14:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-09 9:03 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 49c09209d06885dc8350042ce77e442bfbb5bf27 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 49c09209d06885dc8350042ce77e442bfbb5bf27
Rearrange PLT reloc output on powerpc
The current scheme where we output PLT relocs for global symbols in
finish_dynamic_symbol, and PLT relocs for local symbols when
outputting stubs does not work if PLT entries are to be used for
inline PLT sequences against non-dynamic globals or local symbols.
bfd/
* elf64-ppc.c (ppc_build_one_stub): Move output of PLT relocs
for local symbols to..
(write_plt_relocs_for_local_syms): ..here. New function.
(ppc64_elf_finish_dynamic_symbol): Move output of PLT relocs for
global symbols to..
(build_global_entry_stubs_and_plt): ..here. Rename from
build_global_entry_stubs.
(ppc64_elf_build_stubs): Always call build_global_entry_stubs_and_plt.
Call write_plt_relocs_for_local_syms.
* elf32-ppc.c (get_sym_h): New function.
(ppc_elf_relax_section): Use get_sym_h.
(ppc_elf_relocate_section): Move output of PLT relocs and glink
stubs for local symbols to..
(ppc_finish_symbols): ..here. New function.
(ppc_elf_finish_dynamic_symbol): Move output of PLT relocs for
global syms to..
(write_global_sym_plt): ..here. New function.
* elf32-ppc.h (ppc_elf_modify_segment_map): Delete attribute.
(ppc_finish_symbols): Declare.
ld/
* ppc32elf.em (ppc_finish): Call ppc_finish_symbols.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Support PLT16 relocs against local symbols
@ 2018-04-09 9:17 sergiodj+buildbot
2018-04-09 16:30 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-09 9:17 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2d7ad24e8726ba4c45c9e67be08223a146a837ce ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 2d7ad24e8726ba4c45c9e67be08223a146a837ce
Support PLT16 relocs against local symbols
Necessary if gcc is to use PLT16 relocs to implement -mlongcall, and
there isn't a good technical reason why local symbols should be
excluded from PLT16 support. Non-ifunc local symbol PLT entries go in
a separate section to other PLT entries. In a fixed position
executable they won't need to be relocated, and in a PIE or shared
library I chose to not implement lazy relocation.
bfd/
* elf64-ppc.c (LOCAL_PLT_ENTRY_SIZE): Define.
(struct ppc_stub_hash_entry): Add symtype field.
(PLT_KEEP): Define.
(struct ppc_link_hash_table): Add pltlocal and relpltlocal.
(create_linkage_sections): Create pltlocal and relpltlocal.
(ppc64_elf_check_relocs): Allow PLT relocs on local symbols.
Set PLT_KEEP.
(ppc64_elf_adjust_dynamic_symbol): Keep PLT entries for inline calls.
(allocate_dynrelocs): Allocate pltlocal and relpltlocal.
(ppc64_elf_size_dynamic_sections): Size pltlocal and relpltlocal.
Keep PLT entries for inline calls against locals.
(ppc_build_one_stub): Use pltlocal as appropriate.
(ppc_size_one_stub): Likewise.
(ppc64_elf_size_stubs): Set symtype.
(build_global_entry_stubs_and_plt): Init pltlocal and write
relpltlocal for globals.
(write_plt_relocs_for_local_syms): Likewise for local syms.
(ppc64_elf_relocate_section): Support PLT for local syms.
* elf32-ppc.c (PLT_KEEP): Define.
(struct ppc_elf_link_hash_table): Add pltlocal and relpltlocal.
(ppc_elf_create_glink): Create pltlocal and relpltlocal.
(ppc_elf_check_relocs): Allow PLT relocs on local symbols.
Set PLT_KEEP. Adjust update_local_sym_info call.
(ppc_elf_adjust_dynamic_symbol): Keep PLT entries for inline calls.
(allocate_dynrelocs): Allocate pltlocal and relpltlocal.
(ppc_elf_size_dynamic_sections): Size pltlocal and relpltlocal.
(ppc_elf_relocate_section): Support PLT16 relocs for local syms.
(write_global_sym_plt): Init pltlocal and write relpltlocal.
(ppc_finish_symbols): Likewise for locals.
ld/
* emulparams/elf32ppc.sh (OTHER_RELRO_SECTIONS_2): Add .branch_lt.
(OTHER_GOT_RELOC_SECTIONS): Add .rela.branch_lt.
* testsuite/ld-powerpc/elfv2so.d: Update for symbol/stub reordering.
* testsuite/ld-powerpc/relbrlt.d: Likewise.
* testsuite/ld-powerpc/relbrlt.s: Likewise.
* testsuite/ld-powerpc/tlsso.r: Likewise.
* testsuite/ld-powerpc/tlstocso.r: Likewise.
gold/
* powerpc.cc (Target_powerpc::lplt_): New variable.
(Target_powerpc::lplt_section): Associated accessor.
(Target_powerpc::plt_off): Handle local non-ifunc symbols.
(Target_powerpc::make_lplt_section): New function.
(Target_powerpc::make_local_plt_entry): New function.
(Powerpc_relobj::do_relocate_sections): Write out lplt.
(Output_data_plt_powerpc::first_plt_entry_offset): Zero for lplt.
(Output_data_plt_powerpc::add_local_entry): New function.
(Output_data_plt_powerpc::do_write): Ignore lplt.
(Target_powerpc::make_iplt_section): Make lplt first.
(Target_powerpc::make_brlt_section): Make .branch_lt relro.
(Target_powerpc::Scan::local): Handle PLT16 relocs.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Inline PLT call optimization
@ 2018-04-09 9:47 sergiodj+buildbot
2018-04-09 20:33 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-09 9:47 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 3e04d7655bf63f4e5a0d0354c21aa3fa2ece3681 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 3e04d7655bf63f4e5a0d0354c21aa3fa2ece3681
Inline PLT call optimization
This patch adds the analysis part of PLT call optimization, enabling
the code added with the previous patch that actually performs the
optimization.
Gold support is not available yet.
bfd/
* elf64-ppc.c (struct _ppc64_elf_section_data): Add has_pltcall field.
(struct ppc_link_hash_table): Add can_convert_all_inline_plt.
(ppc64_elf_check_relocs): Set has_pltcall.
(ppc64_elf_adjust_dynamic_symbol): Discard some PLT entries.
(ppc64_elf_inline_plt): New function.
(ppc64_elf_size_dynamic_sections): Discard some PLT entries for locals.
* elf64-ppc.h (ppc64_elf_inline_plt): Declare.
* elf32-ppc.c (has_pltcall): Define.
(struct ppc_elf_link_hash_table): Add can_convert_all_inline_plt.
(ppc_elf_check_relocs): Set has_pltcall.
(ppc_elf_inline_plt): New function.
(ppc_elf_adjust_dynamic_symbol): Discard some PLT entries.
(ppc_elf_size_dynamic_sections): Likewise.
* elf32-ppc.h (ppc_elf_inline_plt): Declare.
ld/
* emultempl/ppc64elf.em (no_inline_plt): New var.
(ppc_before_allocation): Call ppc64_elf_inline_plt.
(enum ppc64_opt): Add OPTION_NO_INLINE_OPT.
(PARSE_AND_LIST_LONGOPTS, PARSE_AND_LIST_OPTIONS,
PARSE_AND_LIST_ARGS_CASES): Handle --no-inline-optimize.
* emultemps/ppc32elf.em (no_inline_opt): New var.
(prelim_size_sections): New function, extracted from..
(ppc_before_allocation): ..here. Call ppc_elf_inline_plt.
(enum ppc32_opt): Add OPTION_NO_INLINE_OPT.
(PARSE_AND_LIST_LONGOPTS, PARSE_AND_LIST_OPTIONS,
PARSE_AND_LIST_ARGS_CASES): Handle --no-inline-optimize.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PowerPC inline PLT call support
@ 2018-04-09 11:16 sergiodj+buildbot
2018-04-09 18:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-09 11:16 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 23cedd1dc90d05c4b80d4a4b000ed5f37b9c3268 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 23cedd1dc90d05c4b80d4a4b000ed5f37b9c3268
PowerPC inline PLT call support
In addition to the existing relocs we need two more to mark all
instructions in the call sequence, PLTCALL on the call itself (plus
the toc restore insn for ppc64), and PLTSEQ on others. All
relocations in a particular sequence have the same symbol.
Example ppc64 ELFv2 assembly:
.reloc .,R_PPC64_PLTSEQ,puts
std 2,24(1)
addis 12,2,puts@plt@ha # .reloc .,R_PPC64_PLT16_HA,puts
ld 12,puts@plt@l(12) # .reloc .,R_PPC64_PLT16_LO_DS,puts
.reloc .,R_PPC64_PLTSEQ,puts
mtctr 12
.reloc .,R_PPC64_PLTCALL,puts
bctrl
ld 2,24(1)
Example ppc32 -fPIC assembly:
addis 12,30,puts+32768@plt@ha # .reloc .,R_PPC_PLT16_HA,puts+0x8000
lwz 12,12,puts+32768@plt@l # .reloc .,R_PPC_PLT16_LO,puts+0x8000
.reloc .,R_PPC_PLTSEQ,puts+32768
mtctr 12
.reloc .,R_PPC_PLTCALL,puts+32768
bctrl
Marking sequences like this allows the linker to convert them to nops
and a direct call if the target symbol turns out to be local.
When the call is __tls_get_addr, each relocation shown above is paired
with an R_PPC*_TLSLD or R_PPC*_TLSGD reloc to additionally mark the
sequence for possible TLS optimization. The TLSLD or TLSGD relocs are
emitted first.
include/
* elf/ppc.h (R_PPC_PLTSEQ, R_PPC_PLTCALL): Define.
* elf/ppc64.h (R_PPC64_PLTSEQ, R_PPC64_PLTCALL): Define.
bfd/
* elf32-ppc.c (ppc_elf_howto_raw): Add PLTSEQ and PLTCALL howtos.
(is_plt_seq_reloc): New function.
(ppc_elf_check_relocs): Handle PLTSEQ and PLTCALL relocs.
(ppc_elf_tls_optimize): Handle inline plt call sequence.
(ppc_elf_relax_section): Handle PLTCALL reloc.
(ppc_elf_relocate_section): Nop out inline plt call sequence when
resolving locally.
* elf64-ppc.c (ppc64_elf_howto_raw): Add R_PPC64_PLTSEQ and
R_PPC64_PLTCALL entries. Comment R_PPC64_TOCSAVE.
(has_tls_get_addr_call): Correct comment.
(is_branch_reloc): Add PLTCALL.
(is_plt_seq_reloc): New function.
(ppc64_elf_check_relocs): Handle PLT16_LO_DS reloc. Set
has_tls_reloc for R_PPC64_TLSGD and R_PPC64_TLSLD. Create plt
entry for R_PPC64_PLTCALL.
(ppc64_elf_tls_optimize): Handle inline plt call sequence.
(ppc_type_of_stub): Handle PLTCALL reloc.
(toc_adjusting_stub_needed): Likewise.
(ppc64_elf_relocate_section): Set "can_plt_call" for PLTCALL
reloc insn. Nop out inline plt call sequence when resolving
locally. Handle __tls_get_addr inline plt call optimization.
elfcpp/
* powerpc.h (R_POWERPC_PLTSEQ, R_POWERPC_PLTCALL): Define.
gold/
* powerpc.cc (Target_powerpc::Track_tls::maybe_skip_tls_get_addr_call):
Handle inline plt sequence relocs.
(Stub_table::Plt_stub_key::Plt_stub_key): Likewise.
(Target_powerpc::Scan::reloc_needs_plt_for_ifunc): Likewise.
(Target_powerpc::Relocate::relocate): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] MIPS64/BFD: Fix a crash with invalid `r_sym' in relocation
@ 2018-04-09 13:04 sergiodj+buildbot
2018-04-09 21:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-09 13:04 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9ccfa98b4cbc86ac34734ecf9d35466461c7e34c ***
Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 9ccfa98b4cbc86ac34734ecf9d35466461c7e34c
MIPS64/BFD: Fix a crash with invalid `r_sym' in relocation
Prevent an out-of-range access and a possible segmentation fault in
`mips_elf64_slurp_one_reloc_table':
Program received signal SIGSEGV, Segmentation fault.
mips_elf64_slurp_one_reloc_table (abfd=0x71bd90, asect=0x71cf70,
rel_hdr=<value optimized out>, reloc_count=1,
relents=<value optimized out>, symbols=0x7218c0, dynamic=0)
at .../bfd/elf64-mips.c:3758
3757 ps = symbols + rela.r_sym - 1;
3758 s = *ps;
in the MIPS64 (n64 MIPS) ELF backend whenever an invalid symbol index is
retrieved from the `r_sym' field of a relocation seen in input while
running `objcopy' or `strip'. Issue an error instead, like the generic
ELF backend does, taking code from `elf_slurp_reloc_table_from_section',
except for relocation types that do not refer to a symbol.
This complements commit 1f70368c21a8 ("Stop objdump crash on corrupt
reloc table"), <https://sourceware.org/ml/binutils/2002-09/msg00332.html>,
and commit 05a487dc8c39 ("make check fails on i686-linux-gnu"),
<https://sourceware.org/ml/binutils/2002-09/msg00340.html>, where the
generic ELF backend code comes from.
bfd/
* elf64-mips.c (mips_elf64_slurp_one_reloc_table): Issue an
error for out-of-range `r_sym' values.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] MIPS64/BFD: Fix a crash with STN_UNDEF in relocation
@ 2018-04-09 13:12 sergiodj+buildbot
2018-04-09 23:23 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-09 13:12 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT aec2e0d252342aa7575aff608e999a36f27a9147 ***
Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: aec2e0d252342aa7575aff608e999a36f27a9147
MIPS64/BFD: Fix a crash with STN_UNDEF in relocation
Prevent a null BFD pointer dereference and a resulting segmentation
fault in `mips_elf64_write_rel' or `mips_elf64_write_rela':
Program received signal SIGSEGV, Segmentation fault.
0x0000000000437690 in mips_elf64_write_rela (abfd=0x71e130, sec=0x720700,
rela_hdr=0x721ff8, count=0x7fffffffb82c, data=0x7fffffffb88c)
at .../bfd/elf64-mips.c:4123
4123 if ((*ptr->sym_ptr_ptr)->the_bfd->xvec != abfd->xvec
4124 && ! _bfd_elf_validate_reloc (abfd, ptr))
in the MIPS64 (n64 MIPS) ELF backend whenever the STN_UNDEF symbol index
is retrieved from the `r_sym' field of a relocation seen in input while
running `objcopy' or `strip'. The reason for the null BFD pointer is
that internally in BFD an STN_UNDEF symbol reference resolves to an
absolute zero symbol that does not have a BFD associated. Check the
pointer then before using it, like the generic ELF backend does in
`elf_write_relocs'.
This complements the same change made for generic ELF bundled with:
commit e35765a9a2eaff0df62757f3e6480c8ba5ab8ee8
Author: Ian Lance Taylor <ian@airs.com>
Date: Sun Dec 15 19:59:18 1996 +0000
which (obviously due to a CVS -> GIT repository conversion inaccuracy)
seems to be one corresponding to this ChangeLog entry:
* elfcode.h (write_relocs): Handle absolute symbol.
from:
commit c86158e591edd8450f49f8cd75f82e4313d4b6d8
Author: Ian Lance Taylor <ian@airs.com>
Date: Fri Aug 30 22:09:51 1996 +0000
("Add SH ELF support."), which also updated RELA only and not REL (which
has been since fixed with: commit 947216bf8f34 ("ELF reloc code tidy"),
<https://sourceware.org/ml/binutils/2002-11/msg00727.html>).
bfd/
* elf64-mips.c (mips_elf64_write_rel): Handle a NULL BFD pointer
in the BFD symbol referred by the relocation.
(mips_elf64_write_rela): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Apply "Convert observers to C++" edit to gdbarch.sh
@ 2018-04-09 15:13 sergiodj+buildbot
2018-04-10 0:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-09 15:13 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 0bee6dd4aa42b928c2a7a496596490b694e5722b ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 0bee6dd4aa42b928c2a7a496596490b694e5722b
Apply "Convert observers to C++" edit to gdbarch.sh
Regenerating gdbarch.c results in:
--- gdbarch.c 2018-03-26 23:18:52.905548891 +0100
+++ new-gdbarch.c 2018-04-09 15:32:30.006712207 +0100
@@ -44,7 +44,7 @@
#include "reggroups.h"
#include "osabi.h"
#include "gdb_obstack.h"
-#include "observable.h"
+#include "observer.h"
#include "regcache.h"
#include "objfiles.h"
#include "auxv.h"
@@ -5457,7 +5457,7 @@
gdb_assert (new_gdbarch != NULL);
gdb_assert (new_gdbarch->initialized_p);
current_inferior ()->gdbarch = new_gdbarch;
- gdb::observers::architecture_changed.notify (new_gdbarch);
+ observer_notify_architecture_changed (new_gdbarch);
registers_changed ();
}
Clearly commit 76727919ceb5 ("Convert observers to C++") edited
gdbarch.c directly instead of gdbarch.sh. This fixes it.
gdb/ChangeLog:
2018-04-09 Pedro Alves <palves@redhat.com>
* gdbarch.sh: Include "observable.h" instead of "observer.h".
(set_target_gdbarch): Call
gdb::observers::architecture_changed.notify instead of
observer_notify_architecture_changed.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Copy string_view files from libstdc++
@ 2018-04-09 18:55 sergiodj+buildbot
2018-04-10 3:38 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-09 18:55 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 7adcdf08e792dc30e09af4eecbf1e479a2f56612 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 7adcdf08e792dc30e09af4eecbf1e479a2f56612
Copy string_view files from libstdc++
This patch copies the following files from libstdc++ (commit
02a4441f002c):
${gcc}/libstdc++-v3/include/experimental/string_view
-> ${binutils-gdb}/gdb/common/gdb_string_view.h
${gcc}/libstdc++-v3/include/experimental/bits/string_view.tcc
-> ${binutils-gdb}/gdb/common/gdb_string_view.tcc
The local modifications are done in the following patch in order to make
it easier to review them.
gdb/ChangeLog:
* common/gdb_string_view.h: New file.
* common/gdb_string_view.tcc: New file.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add gdb::string_view
@ 2018-04-09 19:11 sergiodj+buildbot
2018-04-10 4:57 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-09 19:11 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 8345c4a2670711eafd41c8b6a8726cf8b0771d6e ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 8345c4a2670711eafd41c8b6a8726cf8b0771d6e
Add gdb::string_view
We had a few times the need for a data structure that does essentially
what C++17's std::string_view does, which is to give an std::string-like
interface (only the read-only operations) to an arbitrary character
buffer.
This patch adapts the files copied from libstdc++ by the previous patch
to integrate them with GDB. Here's a summary of the changes:
* Remove things related to wstring_view, u16string_view and
u32string_view (I don't think we need them, but we can always add them
later).
* Remove usages of _GLIBCXX_BEGIN_NAMESPACE_VERSION and
_GLIBCXX_END_NAMESPACE_VERSION.
* Put the code in the gdb namespace. I had to add a few "std::" in
front of std type usages.
* Change __throw_out_of_range_fmt() for error().
* Make gdb::string_view an alias of std::string_view when building
with >= c++17.
* Remove a bunch of constexpr, because they are not valid in c++11
(e.g. they are not a single return line).
* Use std::common_type<_Tp>::type instead of std::common_type_t<_Tp>,
because c++11 doesn't have the later.
* Remove the #pragma GCC system_header, since that silences some
warnings that we might want to have if we're doing something not
correctly.
* Remove operator ""sv. It would need a lot of work to make all
supported compilers happy, and we can easily live without it.
* Remove operator<<. It is implemented using __ostream_insert (a
libstdc++ internal). Bringing it in might be possible, but I don't
think that would be worth the effort, since we don't really use
streams at the moment.
* Replace internal libstdc++ asserts ( __glibcxx_assert and
__glibcxx_requires_string_len) with gdb_assert.
* Remove hash helpers, because they use libstdc++ internal functions.
If we need them we always import them later.
The string_view class in cli/cli-script.c is removed and its usage
replaced with the new gdb::string_view.
gdb/ChangeLog:
* common/gdb_string_view.h: Remove libstdc++ implementation
details, adjust to gdb reality.
* common/gdb_string_view.tcc: Likewise.
* cli/cli-script.c (struct string_view): Remove.
(user_args) <m_args>: Change element type to gdb::string_view.
(user_args::insert_args): Adjust.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Copy string_view tests from libstdc++
@ 2018-04-09 19:25 sergiodj+buildbot
2018-04-10 6:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-09 19:25 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT fdc116781b03f5d30e93f5013159f39c4c0f3471 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: fdc116781b03f5d30e93f5013159f39c4c0f3471
Copy string_view tests from libstdc++
This patch copies the string_view tests from the gcc repository (commit
02a4441f002c).
${gcc}/libstdc++-v3/testsuite/21_strings/basic_string_view ->
${binutils-gdb}/gdb/unittests/basic_string_view
The local modifications are done in the following patch, so that it's
easier to review them.
gdb/ChangeLog:
* unittests/basic_string_view/capacity/1.cc: New file.
* unittests/basic_string_view/capacity/empty_neg.cc: New file.
* unittests/basic_string_view/cons/char/1.cc: New file.
* unittests/basic_string_view/cons/char/2.cc: New file.
* unittests/basic_string_view/cons/char/3.cc: New file.
* unittests/basic_string_view/cons/wchar_t/1.cc: New file.
* unittests/basic_string_view/cons/wchar_t/2.cc: New file.
* unittests/basic_string_view/cons/wchar_t/3.cc: New file.
* unittests/basic_string_view/element_access/char/1.cc: New file.
* unittests/basic_string_view/element_access/char/2.cc: New file.
* unittests/basic_string_view/element_access/char/empty.cc: New file.
* unittests/basic_string_view/element_access/char/front_back.cc: New file.
* unittests/basic_string_view/element_access/wchar_t/1.cc: New file.
* unittests/basic_string_view/element_access/wchar_t/2.cc: New file.
* unittests/basic_string_view/element_access/wchar_t/empty.cc: New file.
* unittests/basic_string_view/element_access/wchar_t/front_back.cc: New file.
* unittests/basic_string_view/include.cc: New file.
* unittests/basic_string_view/inserters/char/1.cc: New file.
* unittests/basic_string_view/inserters/char/2.cc: New file.
* unittests/basic_string_view/inserters/char/3.cc: New file.
* unittests/basic_string_view/inserters/pod/10081-out.cc: New file.
* unittests/basic_string_view/inserters/wchar_t/1.cc: New file.
* unittests/basic_string_view/inserters/wchar_t/2.cc: New file.
* unittests/basic_string_view/inserters/wchar_t/3.cc: New file.
* unittests/basic_string_view/literals/types.cc: New file.
* unittests/basic_string_view/literals/values.cc: New file.
* unittests/basic_string_view/modifiers/remove_prefix/char/1.cc: New file.
* unittests/basic_string_view/modifiers/remove_prefix/wchar_t/1.cc: New file.
* unittests/basic_string_view/modifiers/remove_suffix/char/1.cc: New file.
* unittests/basic_string_view/modifiers/remove_suffix/wchar_t/1.cc: New file.
* unittests/basic_string_view/modifiers/swap/char/1.cc: New file.
* unittests/basic_string_view/modifiers/swap/wchar_t/1.cc: New file.
* unittests/basic_string_view/operations/compare/char/1.cc: New file.
* unittests/basic_string_view/operations/compare/char/13650.cc: New file.
* unittests/basic_string_view/operations/compare/char/2.cc: New file.
* unittests/basic_string_view/operations/compare/char/70483.cc: New file.
* unittests/basic_string_view/operations/compare/wchar_t/1.cc: New file.
* unittests/basic_string_view/operations/compare/wchar_t/13650.cc: New file.
* unittests/basic_string_view/operations/compare/wchar_t/2.cc: New file.
* unittests/basic_string_view/operations/copy/char/1.cc: New file.
* unittests/basic_string_view/operations/copy/wchar_t/1.cc: New file.
* unittests/basic_string_view/operations/data/char/1.cc: New file.
* unittests/basic_string_view/operations/data/wchar_t/1.cc: New file.
* unittests/basic_string_view/operations/find/char/1.cc: New file.
* unittests/basic_string_view/operations/find/char/2.cc: New file.
* unittests/basic_string_view/operations/find/char/3.cc: New file.
* unittests/basic_string_view/operations/find/char/4.cc: New file.
* unittests/basic_string_view/operations/find/wchar_t/1.cc: New file.
* unittests/basic_string_view/operations/find/wchar_t/2.cc: New file.
* unittests/basic_string_view/operations/find/wchar_t/3.cc: New file.
* unittests/basic_string_view/operations/find/wchar_t/4.cc: New file.
* unittests/basic_string_view/operations/rfind/char/1.cc: New file.
* unittests/basic_string_view/operations/rfind/char/2.cc: New file.
* unittests/basic_string_view/operations/rfind/char/3.cc: New file.
* unittests/basic_string_view/operations/rfind/wchar_t/1.cc: New file.
* unittests/basic_string_view/operations/rfind/wchar_t/2.cc: New file.
* unittests/basic_string_view/operations/rfind/wchar_t/3.cc: New file.
* unittests/basic_string_view/operations/string_conversion/1.cc: New file.
* unittests/basic_string_view/operations/substr/char/1.cc: New file.
* unittests/basic_string_view/operations/substr/wchar_t/1.cc: New file.
* unittests/basic_string_view/operators/char/2.cc: New file.
* unittests/basic_string_view/operators/wchar_t/2.cc: New file.
* unittests/basic_string_view/range_access/char/1.cc: New file.
* unittests/basic_string_view/range_access/wchar_t/1.cc: New file.
* unittests/basic_string_view/requirements/explicit_instantiation/1.cc: New file.
* unittests/basic_string_view/requirements/explicit_instantiation/char/1.cc: New file.
* unittests/basic_string_view/requirements/explicit_instantiation/char16_t/1.cc: New file.
* unittests/basic_string_view/requirements/explicit_instantiation/char32_t/1.cc: New file.
* unittests/basic_string_view/requirements/explicit_instantiation/wchar_t/1.cc: New file.
* unittests/basic_string_view/requirements/typedefs.cc: New file.
* unittests/basic_string_view/typedefs.cc: New file.
* unittests/basic_string_view/types/1.cc: New file.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Use an std::vector for inline_states
@ 2018-04-09 20:08 sergiodj+buildbot
2018-04-10 11:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-09 20:08 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b24531ed171b5751a3a64c461728c9ad62092c8a ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: b24531ed171b5751a3a64c461728c9ad62092c8a
Use an std::vector for inline_states
This patch replaces VEC(inline_state) with std::vector<inline_state> and
adjusts the code that uses it.
gdb/ChangeLog:
* common/gdb_vecs.h (unordered_remove): Add overload that takes
an iterator.
* inline-frame.c: Include <algorithm>.
(struct inline_state): Add constructor.
(inline_state_s): Remove.
(DEF_VEC_O(inline_state_s)): Remove.
(inline_states): Change type to std::vector.
(find_inline_frame_state): Adjust to std::vector.
(allocate_inline_frame_state): Remove.
(clear_inline_frame_state): Adjust to std::vector.
(skip_inline_frames): Adjust to std::vector.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add selftests for range_contains and insert_into_bit_range_vector
@ 2018-04-09 20:22 sergiodj+buildbot
2018-04-10 13:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-09 20:22 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d5f4488f09b811b0ca44e687da2acbc286d84d4a ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: d5f4488f09b811b0ca44e687da2acbc286d84d4a
Add selftests for range_contains and insert_into_bit_range_vector
Add some selftests for these two functions. To to make it easier to
compare sequences of ranges, add operator== and operator!= to compare
two gdb::array_view, and add operator== in struct range.
gdb/ChangeLog:
* value.c: Include "selftest.h" and "common/array-view.h".
(struct range) <operator ==>: New.
(test_ranges_contain): New.
(check_ranges_vector): New.
(test_insert_into_bit_range_vector): New.
(_initialize_values): Register selftests.
* common/array-view.h (operator==, operator!=): New.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Replace finish_thread_state_cleanup with a RAII class
@ 2018-04-10 14:11 sergiodj+buildbot
2018-04-10 14:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-10 14:11 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 731f534f918cfaa35c20b5eb6220a8eba4819f04 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 731f534f918cfaa35c20b5eb6220a8eba4819f04
Replace finish_thread_state_cleanup with a RAII class
gdb/ChangeLog:
2018-04-10 Pedro Alves <palves@redhat.com>
* gdbthread.h (finish_thread_state_cleanup): Delete declaration.
(scoped_finish_thread_state): New class.
* infcmd.c (run_command_1): Use it instead of finish_thread_state
cleanup.
* infrun.c (proceed, prepare_for_detach, wait_for_inferior)
(fetch_inferior_event, normal_stop): Likewise.
* thread.c (finish_thread_state_cleanup): Delete.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] File I/O file handles after target closes
@ 2018-04-11 11:23 sergiodj+buildbot
2018-04-11 14:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-11 11:23 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 20db9c52a2073246a5c46a0274569e10b317866f ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 20db9c52a2073246a5c46a0274569e10b317866f
File I/O file handles after target closes
A future patch will propose making the remote target's target_ops be
heap-allocated (to make it possible to have multiple instances of
remote targets, for multiple simultaneous connections), and will
delete/destroy the remote target at target_close time.
That change trips on a latent problem, though. File I/O handles
remain open even after the target is gone, with a dangling pointer to
a target that no longer exists. This results in GDB crashing when it
calls the target_ops backend associated with the file handle:
(gdb) Disconnect
Ending remote debugging.
* GDB crashes deferencing a dangling pointer
Backtrace:
#0 0x00007f79338570a0 in main_arena () at /lib64/libc.so.6
#1 0x0000000000858bfe in target_fileio_close(int, int*) (fd=1, target_errno=0x7ffe0499a4c8)
at src/gdb/target.c:2980
#2 0x00000000007088bd in gdb_bfd_iovec_fileio_close(bfd*, void*) (abfd=0x1a631b0, stream=0x223c9d0)
at src/gdb/gdb_bfd.c:353
#3 0x0000000000930906 in opncls_bclose (abfd=0x1a631b0) at src/bfd/opncls.c:528
#4 0x0000000000930cf9 in bfd_close_all_done (abfd=0x1a631b0) at src/bfd/opncls.c:768
#5 0x0000000000930cb3 in bfd_close (abfd=0x1a631b0) at src/bfd/opncls.c:735
#6 0x0000000000708dc5 in gdb_bfd_close_or_warn(bfd*) (abfd=0x1a631b0) at src/gdb/gdb_bfd.c:511
#7 0x00000000007091a2 in gdb_bfd_unref(bfd*) (abfd=0x1a631b0) at src/gdb/gdb_bfd.c:615
#8 0x000000000079ed8e in objfile::~objfile() (this=0x2154730, __in_chrg=<optimized out>)
at src/gdb/objfiles.c:682
#9 0x000000000079fd1a in objfile_purge_solibs() () at src/gdb/objfiles.c:1065
#10 0x00000000008162ca in no_shared_libraries(char const*, int) (ignored=0x0, from_tty=1)
at src/gdb/solib.c:1251
#11 0x000000000073b89b in disconnect_command(char const*, int) (args=0x0, from_tty=1)
at src/gdb/infcmd.c:3035
This goes unnoticed in current master, because the current remote
target's target_ops is never destroyed nowadays, so we end up calling:
remote_hostio_close -> remote_hostio_send_command
which gracefully fails with FILEIO_ENOSYS if remote_desc is NULL
(because the target is closed).
Fix this by invalidating a target's file I/O handles when the target
is closed.
With this change, remote_hostio_send_command no longer needs to handle the
case of being called with a closed remote target, originally added here:
<https://sourceware.org/ml/gdb-patches/2008-08/msg00359.html>.
gdb/ChangeLog:
2018-04-11 Pedro Alves <palves@redhat.com>
* target.c (fileio_fh_t::t): Add comment.
(target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
(target_fileio_close): Handle a NULL target.
(invalidate_fileio_fh): New.
(target_close): Call it.
* remote.c (remote_hostio_send_command): No longer check whether
remote_desc is open.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add Rust test case for ".." struct initializer
@ 2018-04-11 14:46 sergiodj+buildbot
2018-04-11 19:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-11 14:46 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 50146e7022cedafe615bfc9884358d291a00689f ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 50146e7022cedafe615bfc9884358d291a00689f
Add Rust test case for ".." struct initializer
Building with --coverage pointed out that there was no Rust test for
initializing a structure using the ".." initializer. This patch adds
such a test.
Regression tested on x86-64 Fedora 26.
2018-04-11 Tom Tromey <tom@tromey.com>
* gdb.rust/simple.exp: Add test for ".." struct initializer.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Enable Intel WAITPKG instructions.
@ 2018-04-11 20:14 sergiodj+buildbot
2018-04-12 0:32 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-11 20:14 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT de89d0a34d52a2d2d28a4ce569e926dd9c7a7d13 ***
Author: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
Branch: master
Commit: de89d0a34d52a2d2d28a4ce569e926dd9c7a7d13
Enable Intel WAITPKG instructions.
Intel has disclosed a set of new instructions for Tremont processor.
The spec is
https://software.intel.com/en-us/intel-architecture-instruction-set-extensions-programming-reference
This patch enables Intel WAITPKG instructions.
gas/
* config/tc-i386.c (cpu_arch): Add WAITPKG.
(cpu_noarch): Likewise.
* doc/c-i386.texi: Document WAITPKG.
* i386/i386.exp: Run WAITPKG tests.
* testsuite/gas/i386/waitpkg-intel.d: New test.
* testsuite/gas/i386/waitpkg.d: Likewise.
* testsuite/gas/i386/waitpkg.s: Likewise.
* testsuite/gas/i386/x86-64-waitpkg-intel.d: Likewise.
* testsuite/gas/i386/x86-64-waitpkg.d: Likewise.
* testsuite/gas/i386/x86-64-waitpkg.s: Likewise.
opcodes/
* i386-dis.c (enum): Add PREFIX_MOD_0_0FAE_REG_6,
PREFIX_MOD_1_0FAE_REG_6.
(va_mode): New.
(OP_E_register): Use va_mode.
* i386-dis-evex.h (prefix_table):
New instructions (see prefixes above).
* i386-gen.c (cpu_flag_init): Add WAITPKG.
(cpu_flags): Likewise.
* i386-opc.h (enum): Likewise.
(i386_cpu_flags): Likewise.
* i386-opc.tbl: Add umonitor, umwait, tpause.
* i386-init.h: Regenerate.
* i386-tbl.h: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Eliminate target_has_exited
@ 2018-04-12 16:59 sergiodj+buildbot
2018-04-12 18:14 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-12 16:59 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 436411b1c6cb93541fd502321cf5470fe0392b91 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 436411b1c6cb93541fd502321cf5470fe0392b91
Eliminate target_has_exited
Nothing uses this.
gdb/ChangeLog:
2018-04-12 Pedro Alves <palves@redhat.com>
* target.h (target_ops::to_has_exited): Delete.
(target_has_exited): Delete.
* target-delegates.c: Regenerate.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix Solaris build
@ 2018-04-12 17:40 sergiodj+buildbot
2018-04-12 22:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-12 17:40 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 70b33f195b0d76e140921db40c0bea5a7c9abc42 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 70b33f195b0d76e140921db40c0bea5a7c9abc42
Fix Solaris build
This commit fixes a bit of rot in procfs.c caused by recent changes.
Specifically, the target_ops::to_detach change to pass down 'inferior
*' missed updating a forward declation, and the change to use
scoped_fd in more places missed removing one do_cleanups call.
src/gdb/procfs.c: In function target_ops* procfs_target():
src/gdb/procfs.c:167:16: error: invalid conversion from void (*)(target_ops*, const char*, int) to void (*)(target_ops*, inferior*, int) [-fpermissive]
t->to_detach = procfs_detach;
^
src/gdb/procfs.c: In function ssd* proc_get_LDT_entry(procinfo*, int):
src/gdb/procfs.c:1624:17: error: old_chain was not declared in this scope
do_cleanups (old_chain);
^
src/gdb/procfs.c: At global scope:
src/gdb/procfs.c:90:13: error: void procfs_detach(target_ops*, const char*, int) declared static but never defined [-Werror=unused-function]
static void procfs_detach (struct target_ops *, const char *, int);
^
src/gdb/procfs.c:1923:1: error: void procfs_detach(target_ops*, inferior*, int) defined but not used [-Werror=unused-function]
procfs_detach (struct target_ops *ops, inferior *inf, int from_tty)
^
gdb/ChangeLog:
2018-04-12 Pedro Alves <palves@redhat.com>
* procfs.c (procfs_detach): Make forward declaration's prototype
match definition's protototype.
(proc_get_LDT_entry): Remove stale do_cleanups call.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] infrun: step through indirect branch thunks
@ 2018-04-13 8:59 sergiodj+buildbot
2018-04-13 11:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-13 8:59 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 1d509aa625f891e20b37b8cee4659771e87b1ba4 ***
Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: 1d509aa625f891e20b37b8cee4659771e87b1ba4
infrun: step through indirect branch thunks
With version 7.3 GCC supports new options
-mindirect-branch=<choice>
-mfunction-return=<choice>
The choices are:
keep behaves as before
thunk jumps through a thunk
thunk-external jumps through an external thunk
thunk-inline jumps through an inlined thunk
For thunk and thunk-external, GDB would, on a call to the thunk, step into
the thunk and then resume to its caller assuming that this is an
undebuggable function. On a return thunk, GDB would stop inside the
thunk.
Make GDB step through such thunks instead.
Before:
Temporary breakpoint 1, main ()
at gdb.base/step-indirect-call-thunk.c:37
37 x = apply (inc, 41);
(gdb) s
apply (op=0x80483e6 <inc>, x=41)
at gdb.base/step-indirect-call-thunk.c:29
29 return op (x);
(gdb)
30 }
After:
Temporary breakpoint 1, main ()
at gdb.base/step-indirect-call-thunk.c:37
37 x = apply (inc, 41);
(gdb) s
apply (op=0x80483e6 <inc>, x=41)
at gdb.base/step-indirect-call-thunk.c:29
29 return op (x);
(gdb)
inc (x=41) at gdb.base/step-indirect-call-thunk.c:23
23 return x + 1;
This is independent of the step-mode. In order to step into the thunk,
you would need to use stepi.
When stepping over an indirect call thunk, GDB would first step through
the thunk, then recognize that it stepped into a sub-routine and resume to
the caller (of the thunk). Not sure whether this is worth optimizing.
Thunk detection is implemented via gdbarch. I implemented the methods for
IA. Other architectures may run into unexpected fails.
The tests assume a fixed number of instruction steps to reach a thunk.
This depends on the compiler as well as the architecture. They may need
adjustments when we add support for more architectures. Or we can simply
drop those tests that cover being able to step into thunks using
instruction stepping.
When using an older GCC, the tests will fail to build and will be reported
as untested:
Running .../gdb.base/step-indirect-call-thunk.exp ...
gdb compile failed, \
gcc: error: unrecognized command line option '-mindirect-branch=thunk'
gcc: error: unrecognized command line option '-mfunction-return=thunk'
=== gdb Summary ===
# of untested testcases 1
gdb/
* infrun.c (process_event_stop_test): Call
gdbarch_in_indirect_branch_thunk.
* gdbarch.sh (in_indirect_branch_thunk): New.
* gdbarch.c: Regenerated.
* gdbarch.h: Regenerated.
* x86-tdep.h: New.
* x86-tdep.c: New.
* Makefile.in (ALL_TARGET_OBS): Add x86-tdep.o.
(HFILES_NO_SRCDIR): Add x86-tdep.h.
(ALLDEPFILES): Add x86-tdep.c.
* arch-utils.h (default_in_indirect_branch_thunk): New.
* arch-utils.c (default_in_indirect_branch_thunk): New.
* i386-tdep: Include x86-tdep.h.
(i386_in_indirect_branch_thunk): New.
(i386_elf_init_abi): Set in_indirect_branch_thunk gdbarch
function.
* amd64-tdep: Include x86-tdep.h.
(amd64_in_indirect_branch_thunk): New.
(amd64_init_abi): Set in_indirect_branch_thunk gdbarch function.
testsuite/
* gdb.base/step-indirect-call-thunk.exp: New.
* gdb.base/step-indirect-call-thunk.c: New.
* gdb.reverse/step-indirect-call-thunk.exp: New.
* gdb.reverse/step-indirect-call-thunk.c: New.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] btrace: fix output of "set record btrace"
@ 2018-04-13 9:59 sergiodj+buildbot
2018-04-13 13:30 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-13 9:59 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b85310e1ec0419c4e1ca091cdd48f7597ebbefd3 ***
Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: b85310e1ec0419c4e1ca091cdd48f7597ebbefd3
btrace: fix output of "set record btrace"
Instead of giving a message that "set record btrace" needs a sub-command,
GDB crashed. Fix it. A regression test comes with the next patch.
gdb/
* record-btrace.c (cmd_set_record_btrace): Print sub-commands.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] btrace: set/show record btrace cpu
@ 2018-04-13 10:21 sergiodj+buildbot
2018-04-13 18:29 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-13 10:21 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 4a4495d62d185bdae17ed6aae6ea8249ad07c799 ***
Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: 4a4495d62d185bdae17ed6aae6ea8249ad07c799
btrace: set/show record btrace cpu
Add new set/show commands to set the processor that is used for enabling
errata workarounds when decoding branch trace.
The general format is "<vendor>:<identifier>" but we also allow two
special values "auto" and "none".
The default is "auto", which is the current behaviour of having GDB
determine the processor on which the trace was recorded.
If that cpu is not known to the trace decoder, e.g. when using an old
decoder on a new system, decode may fail with "unknown cpu". In most
cases it should suffice to 'downgrade' decode to assume an older cpu.
Unfortunately, we can't do this automatically.
The other special value, "none", disables errata workarounds.
gdb/
* NEWS (New options): announce set/show record btrace cpu.
* btrace.c: Include record-btrace.h.
(btrace_compute_ftrace_pt): Skip enabling errata workarounds if
the vendor is unknown.
(btrace_compute_ftrace_1): Add cpu parameter. Update callers.
Maybe overwrite the btrace configuration's cpu.
(btrace_compute_ftrace): Add cpu parameter. Update callers.
(btrace_fetch): Add cpu parameter. Update callers.
(btrace_maint_update_pt_packets): Call record_btrace_get_cpu.
Maybe overwrite the btrace configuration's cpu. Skip enabling
errata workarounds if the vendor is unknown.
* python/py-record-btrace.c: Include record-btrace.h.
(recpy_bt_begin, recpy_bt_end, recpy_bt_instruction_history)
(recpy_bt_function_call_history): Call record_btrace_get_cpu.
* record-btrace.c (record_btrace_cpu_state_kind): New.
(record_btrace_cpu): New.
(set_record_btrace_cpu_cmdlist): New.
(record_btrace_get_cpu): New.
(require_btrace_thread, record_btrace_info)
(record_btrace_resume_thread): Call record_btrace_get_cpu.
(cmd_set_record_btrace_cpu_none): New.
(cmd_set_record_btrace_cpu_auto): New.
(cmd_set_record_btrace_cpu): New.
(cmd_show_record_btrace_cpu): New.
(_initialize_record_btrace): Initialize set/show record btrace cpu
commands.
* record-btrace.h (record_btrace_get_cpu): New.
testsuite/
* gdb.btrace/cpu.exp: New.
doc/
* gdb.texinfo: Document set/show record btrace cpu.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Show line numbers in output for "info var/func/type"
@ 2018-04-13 17:44 sergiodj+buildbot
2018-04-13 20:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-13 17:44 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b744723f571815e6cee43df371c8e733e34e1edf ***
Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: b744723f571815e6cee43df371c8e733e34e1edf
Show line numbers in output for "info var/func/type"
The GDB commands "info variables", "info functions", and "info types" show
the appropriate list of definitions matching the given pattern. They also
group them by source files. But no line numbers within these source files
are shown.
The line number information is particularly useful to the user when a
simple "grep" doesn't readily point to a definition. This is often the
case when the definition involves a macro, occurs within a namespace, or
when the identifier appears very frequently in the source file.
This patch enriches the printout of these commands by the line numbers and
adjusts affected test cases to the changed output where necessary. The
new output looks like this:
(gdb) i variables
All defined variables:
File foo.c:
3: const char * const foo;
1: int x;
The line number is followed by a colon and a tab character, which is then
followed by the symbol definition. If no line number is available, the
tab is printed out anyhow, so definitions line up.
gdb/ChangeLog:
* symtab.c (print_symbol_info): Precede the symbol definition by
the line number when available.
* NEWS: Advertise this enhancement.
gdb/doc/ChangeLog:
* gdb.texinfo (Symbols): Mention the fact that "info
variables/functions/types" show source files and line numbers.
gdb/testsuite/ChangeLog:
* gdb.ada/info_types.exp: Adjust expected output to the line
numbers now printed by "info var/func/type".
* gdb.base/completion.exp: Likewise.
* gdb.base/included.exp: Likewise.
* gdb.cp/cp-relocate.exp: Likewise.
* gdb.cp/cplusfuncs.exp: Likewise.
* gdb.cp/namespace.exp: Likewise.
* gdb.dwarf2/dw2-case-insensitive.exp: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] powerpc max-page-size vs __QNXTARGET__
@ 2018-04-14 9:08 sergiodj+buildbot
2018-04-14 13:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-14 9:08 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 03aa968462e0345b2d846ca240b8c723d713761a ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 03aa968462e0345b2d846ca240b8c723d713761a
powerpc max-page-size vs __QNXTARGET__
The default max-page-size on ppc32 has been 64k since 1995-02-15 (git
commit bcbe2c71). There was a change committed 2003-07-12 to chose a
4k page if __QNXTARGET__ is defined, but that particular commit was
from an earlier posted patch
https://sourceware.org/ml/binutils/2003-07/msg00211.html that only
made the change effective for arm, rather than the later one
https://sourceware.org/ml/binutils/2003-07/msg00220.html that also
changed powerpc and sh..
Since the __QNXTARGET__ #ifdef in elf32-ppc.c is ineffective unless
the user defines it in his or her CFLAGS, I'm removing that code.
* elf32-ppc.c (ELF_MAXPAGESIZE, ELF_COMMONPAGESIZE): Don't depend
on __QNXTARGET__ define.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add x86-tdep.o to i386/amd64 target build
@ 2018-04-15 20:05 sergiodj+buildbot
2018-04-15 21:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-15 20:05 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT eda4efb12763893b8a49c10c6f2823a465c1c6ba ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: eda4efb12763893b8a49c10c6f2823a465c1c6ba
Add x86-tdep.o to i386/amd64 target build
We get this error when doing a build with a single amd64 target (the
default when doing just ./configure on x86-64 GNU/Linux):
/home/simark/src/binutils-gdb/gdb/i386-tdep.c:4431: error: undefined reference to 'x86_in_indirect_branch_thunk(unsigned long, char const**, int, int)'
/home/simark/src/binutils-gdb/gdb/amd64-tdep.c:3045: error: undefined reference to 'x86_in_indirect_branch_thunk(unsigned long, char const**, int, int)'
The problem is that commit
1d509aa625f8 ("infrun: step through indirect branch thunks")
missed adding x86-tdep.o to the list of object file included in an amd64
or i386 build. The problem is not seen with --enable-targets=all
because that file is included in ALL_TARGET_OBS.
Built-tested using:
* --host=x86_64-pc-linux-gnu --target=x86_64-pc-linux-gnu
* --host=armv7-rpi2-linux-gnueabihf --target=x86_64-pc-linux-gnu
gdb/ChangeLog:
* configure.tgt (x86_tobjs): New variable.
(amd64_tobjs, i386_tobjs): Use it.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove tandem support
@ 2018-04-16 8:43 sergiodj+buildbot
2018-04-16 15:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-16 8:43 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT de96689e03235bfd65a33704a9d398cb666140f4 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: de96689e03235bfd65a33704a9d398cb666140f4
Remove tandem support
bfd/
* config.bfd: Remove tandem support.
ld/
* Makefile.am: Remove tandem support.
* configure.tgt: Likewise.
* emulparams/st2000.sh: Delete.
* scripttempl/st2000.sc: Delete.
* Makefile.in: Regenerate.
* po/BLD-POTFILES.in: Regenerate.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove IEEE 695 object support
@ 2018-04-16 9:17 sergiodj+buildbot
2018-04-16 17:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-16 9:17 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT fdef3943443987525aea4f3ebe1f569f7070fcc8 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: fdef3943443987525aea4f3ebe1f569f7070fcc8
Remove IEEE 695 object support
include/
* ieee.h: Delete.
bfd/
* Makefile.am: Remove IEEE 695 support.
* archures.c: Likewise.
* bfd.c: Likewise.
* config.bfd: Likewise.
* configure.ac: Likewise.
* doc/bfd.texinfo: Likewise.
* doc/bfdint.texi: Likewise.
* doc/bfdsumm.texi: Likewise.
* section.c: Likewise.
* targets.c: Likewise.
* ieee.c: Delete.
* libieee.h: Delete.
* Makefile.in: Regenerate.
* bfd-in2.h: Regenerate.
* configure: Regenerate.
* po/SRC-POTFILES.in: Regenerate.
binutils/
* Makefile.am: Remove IEEE 695 support.
* budbg.h: Likewise.
* doc/binutils.texi: Likewise.
* makefile.vms: Likewise.
* objcopy.c: Likewise.
* objdump.c: Likewise.
* rddbg.c: Likewise.
* ieee.c: Delete.
* Makefile.in: Regenerate.
* po/POTFILES.in: Regenerate.
gas/
* app.c: Remove IEEE 695 support.
* symbols.c: Likewise.
ld/
* ld.texinfo: Remove IEEE 695 support.
* mri.c: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove h8300-coff support
@ 2018-04-16 9:50 sergiodj+buildbot
2018-04-16 19:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-16 9:50 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT fe0bf0fd57ea3ef8458d2e8661b428110fc026e2 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: fe0bf0fd57ea3ef8458d2e8661b428110fc026e2
Remove h8300-coff support
include/
* coff/h8300.h: Delete.
bfd/
* Makefile.am: Remove h8300-coff support.
* coffcode.h: Likewise.
* config.bfd: Likewise.
* configure.ac: Likewise.
* reloc16.c: Likewise.
* targets.c: Likewise.
* coff-h8300.c: Delete.
* Makefile.in: Regenerate.
* configure: Regenerate.
* po/SRC-POTFILES.in: Regenerate.
binutils/
* testsuite/binutils-all/objcopy.exp: Remove h8300-coff support.
gas/
* config/obj-coff.h: Remove h8300-coff support.
* config/tc-h8300.c: Likewise.
* config/tc-h8300.h: Likewise.
* testsuite/gas/h8300/h8300.exp: Likewise.
* testsuite/gas/h8300/branch-coff.s: Delete.
* testsuite/gas/h8300/branchh-coff.s: Delete.
* testsuite/gas/h8300/branchs-coff.s: Delete.
* testsuite/gas/h8300/ffxx1-coff.d: Delete.
* testsuite/gas/h8300/ffxx1-coff.s: Delete.
* testsuite/gas/h8300/h8300-coff.exp: Delete.
ld/
* Makefile.am: Remove h8300-coff support.
* configure.tgt: Likewise.
* testsuite/ld-h8300/h8300.exp: Likewise.
* emulparams/h8300.sh: Delete.
* emulparams/h8300h.sh: Delete.
* emulparams/h8300hn.sh: Delete.
* emulparams/h8300s.sh: Delete.
* emulparams/h8300sn.sh: Delete.
* emulparams/h8300sx.sh: Delete.
* emulparams/h8300sxn.sh: Delete.
* scripttempl/h8300.sc: Delete.
* scripttempl/h8300h.sc: Delete.
* scripttempl/h8300hn.sc: Delete.
* scripttempl/h8300s.sc: Delete.
* scripttempl/h8300sn.sc: Delete.
* scripttempl/h8300sx.sc: Delete.
* scripttempl/h8300sxn.sc: Delete.
* testsuite/ld-h8300/relax-3-coff.d: Delete.
* testsuite/ld-h8300/relax-4-coff.d: Delete.
* testsuite/ld-h8300/relax-5-coff.d: Delete.
* testsuite/ld-h8300/relax-6-coff.d: Delete.
* Makefile.in: Regenerate.
* po/BLD-POTFILES.in: Regenerate.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove h8500 support
@ 2018-04-16 10:44 sergiodj+buildbot
2018-04-16 21:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-16 10:44 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e82aa7944d2b00c54e9d3c1a47c5ed4a0e39393a ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: e82aa7944d2b00c54e9d3c1a47c5ed4a0e39393a
Remove h8500 support
include/
* coff/h8500.h: Delete.
* coff/internal.h: Remove h8500 support.
bfd/
* Makefile.am: Remove h8500 support.
* archures.c: Likewise.
* coffcode.h: Likewise.
* config.bfd: Likewise.
* configure.ac: Likewise.
* targets.c: Likewise.
* coff-h8500.c: Delete.
* cpu-h8500.c: Delete.
* Makefile.in: Regenerate.
* bfd-in2.h: Regenerate.
* configure: Regenerate.
* po/SRC-POTFILES.in: Regenerate.
opcodes/
* Makefile.am: Remove h8500 support.
* configure.ac: Likewise.
* disassemble.c: Likewise.
* disassemble.h: Likewise.
* h8500-dis.c: Delete.
* h8500-opc.h: Delete.
* Makefile.in: Regenerate.
* configure: Regenerate.
* po/POTFILES.in: Regenerate.
binutils/
* testsuite/binutils-all/objcopy.exp: Remove h8500 support.
* testsuite/lib/binutils-common.exp: Likewise.
gas/
* config/obj-coff.h: Remove h8500 support.
ld/
* Makefile.am: Remove h8500 support.
* configure.tgt: Likewise.
* emulparams/h8500.sh: Delete.
* emulparams/h8500b.sh: Delete.
* emulparams/h8500c.sh: Delete.
* emulparams/h8500m.sh: Delete.
* emulparams/h8500s.sh: Delete.
* scripttempl/h8500.sc: Delete.
* scripttempl/h8500b.sc: Delete.
* scripttempl/h8500c.sc: Delete.
* scripttempl/h8500m.sc: Delete.
* scripttempl/h8500s.sc: Delete.
* Makefile.in: Regenerate.
* po/BLD-POTFILES.in: Regenerate.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb: Remove support for SH-5/SH64
@ 2018-04-16 14:17 sergiodj+buildbot
2018-04-17 5:08 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-16 14:17 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 8a3de5e1a3fb7bdf89195388f127ecf429294f6f ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 8a3de5e1a3fb7bdf89195388f127ecf429294f6f
gdb: Remove support for SH-5/SH64
Since bfd dropped support for SH-5, there's no point in keeping it in
GDB either.
This restores --enable-targets=all builds.
gdb/ChangeLog:
2018-04-16 Pedro Alves <palves@redhat.com>
* MAINTAINERS (sh): Remove.
* Makefile.in (ALL_TARGET_OBS): Remove sh64-tdep.o.
(HFILES_NO_SRCDIR): Remove sh64-tdep.h.
(ALLDEPFILES): Remove sh64-tdep.c.
* NEWS: Mentions that support for SH-5/SH64 is removed.
* configure.tgt (sh*-*-linux*): Remove reference to sh64-tdep.o.
(sh*-*-openbsd*): Ditto.
(sh64-*-elf*): Remove.
(sh*): Remove.
* regcache.c (cooked_write_test): Remove bfd_mach_sh5 case.
* sh-linux-tdep.c: Remove reference to bfd_mach_sh5.
* sh-tdep.c: No longer include "sh64-tdep.h".
(sh_gdbarch_init): Remove reference to bfd_mach_sh5.
* sh64-tdep.c, sh64-tdep.h: Remove files.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Enable Intel CLDEMOTE instruction.
@ 2018-04-17 10:18 sergiodj+buildbot
2018-04-17 14:38 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-17 10:18 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c48935d75f720ecb006c81b37f4058e751f1dc31 ***
Author: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
Branch: master
Commit: c48935d75f720ecb006c81b37f4058e751f1dc31
Enable Intel CLDEMOTE instruction.
gas/
* config/tc-i386.c (cpu_arch): Add .cldemote.
* doc/c-i386.texi: Document cldemote/.cldemote.
* testsuite/gas/i386/cldemote-intel.d: New.
* testsuite/gas/i386/cldemote.d: Likewise.
* testsuite/gas/i386/cldemote.s: Likewise.
* testsuite/gas/i386/i386.exp: Run new tests.
* testsuite/gas/i386/x86-64-cldemote-intel.d: New.
* testsuite/gas/i386/x86-64-cldemote.d: Likewise.
* testsuite/gas/i386/x86-64-cldemote.s: Likewise.
* testsuite/gas/i386/ilp32/x86-64-nops.d: Remove 0x0f1c
NOP encoding that maps to cldemote.
* testsuite/gas/i386/nops.d: Likewise.
* testsuite/gas/i386/nops.s: Likewise.
* testsuite/gas/i386/x86-64-nops.d: Likewise.
* testsuite/gas/i386/x86-64-nops.s: Likewise.
opcode/
* i386-dis.c: Add REG_0F1C_MOD_0, MOD_0F1C_PREFIX_0,
PREFIX_0F1C.
* i386-gen.c (cpu_flag_init): Add CPU_CLDEMOTE_FLAGS,
(cpu_flags): Add CpuCLDEMOTE.
* i386-init.h: Regenerate.
* i386-opc.h (enum): Add CpuCLDEMOTE,
(i386_cpu_flags): Add cpucldemote.
* i386-opc.tbl: Add cldemote.
* i386-tbl.h: Regenerate.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Resync libiberty sources with master version in GCC repository.
@ 2018-04-17 13:19 sergiodj+buildbot
2018-04-17 16:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-17 13:19 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e9301e762ab6d533f7110d6c9c1dbe8e68e875d7 ***
Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: e9301e762ab6d533f7110d6c9c1dbe8e68e875d7
Resync libiberty sources with master version in GCC repository.
2018-04-13 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
PR lto/81968
* simple-object.c (handle_lto_debug_sections): Keep .comment
section.
2018-03-02 David Malcolm <dmalcolm@redhat.com>
* cp-demangle.c: Update URL for g++ V3 ABI.
2018-01-20 Eli Zaretskii <eliz@gnu.org>
* simple-object-xcoff.c (simple_object_xcoff_find_sections): Use
ulong_type to avoid warning about 32-bit shift.
2018-01-11 Richard Biener <rguenther@suse.de>
Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
PR lto/81968
* simple-object-common.h (struct simple_object_functions):
Change copy_lto_debug_sections callback signature.
* simple-object-elf.c (SHN_HIRESERVE, SHT_SYMTAB_SHNDX,
SHF_INFO_LINK): Add defines.
(simple_object_elf_copy_lto_debug_sections): Instead of
leaving not to be copied sections empty unnamed SHT_NULL
remove them from the target section headers and adjust section
reference everywhere. Handle SHN_XINDEX in the symbol table
processing properly.
* simple-object.c (handle_lto_debug_sections): Change
interface to return a modified string and handle renaming
of relocation sections.
2018-01-10 Daniel van Gerpen <daniel@vangerpen.de>
* argv.c (expandargv): Correct check for dynamically
allocated argv.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add a check for a NULL table pointer before attempting to compute a DWARF filename.
@ 2018-04-17 14:06 sergiodj+buildbot
2018-04-17 18:57 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-17 14:06 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 6327533b1fd29fa86f6bf34e61c332c010e3c689 ***
Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 6327533b1fd29fa86f6bf34e61c332c010e3c689
Add a check for a NULL table pointer before attempting to compute a DWARF filename.
PR 23065
* dwarf2.c (concat_filename): Check for a NULL table pointer.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Don't print symbol declaration's line number in rbreak output
@ 2018-04-17 17:52 sergiodj+buildbot
2018-04-17 23:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-17 17:52 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c7dcbf88c6557f35d9e75ae6223a3e61e1f70578 ***
Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: c7dcbf88c6557f35d9e75ae6223a3e61e1f70578
Don't print symbol declaration's line number in rbreak output
This commit:
b744723f57 -- Show line numbers in output for "info var/func/type"
adds the symbol declaration's line number to the output of certain GDB
commands. It also (inadvertently) changes the `rbreak' command's output,
like this:
(gdb) rbreak foo
Breakpoint 1 at 0x40049b: file rbreak.c, line 6.
4: static int foo1(void);
Breakpoint 2 at 0x4004b1: file rbreak.c, line 12.
10: static int foo2(void);
(gdb)
where the function declaration is now prefixed by its source line number,
followed by a colon. But without showing the declaration's file name, the
line number is useless and can possibly cause severe confusion.
No declaration line number was shown before. Instead, the function
declaration started at the first column:
(gdb) rbreak foo
Breakpoint 1 at 0x40049b: file rbreak.c, line 6.
static int foo1(void);
Breakpoint 2 at 0x4004b1: file rbreak.c, line 12.
static int foo2(void);
(gdb)
This old behavior is restored, fixing some FAILs in fullpath-expand.exp,
realname-expand.exp, and pr10179.exp.
In order to distinguish when to print location information, the meaning of
print_symbol_info()'s parameter `last' is changed. Now NULL means to skip
any filename or line number information. Previously NULL meant to always
print the filename.
gdb/ChangeLog:
* symtab.c (print_symbol_info): Skip printing filename and line
number when `last' is NULL.
(symtab_symbol_info): Use empty string instead of NULL for first
invocation of print_symbol_info.
(rbreak_command): Pass NULL to `last' parameter of
print_symbol_info.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] [MicroBlaze] PIC data text relative
@ 2018-04-17 22:07 sergiodj+buildbot
2018-04-18 5:42 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-17 22:07 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 3f0a5f17d7fe1f3d0911ad67a5993be59983fb00 ***
Author: Michael Eager <eager@eagercon.com>
Branch: master
Commit: 3f0a5f17d7fe1f3d0911ad67a5993be59983fb00
[MicroBlaze] PIC data text relative
Andrew Sadek <andrew.sadek.se@gmail.com>
A new implemented feature in GCC Microblaze that allows Position
Independent Code to run using Data Text Relative addressing instead
of using Global Offset Table.
Its aim was to make 'PIC' more efficient and flexible as elf size
excess performance overhead were noticed when using GOT due to the
indirect addressing.
include/ChangeLog:
* bfdlink.h (Add flag): Add new flag @ 'bfd_link_info' struct.
* elf/microblaze.h (Add 3 new relocations):
R_MICROBLAZE_TEXTPCREL_64, R_MICROBLAZE_TEXTREL_64
and R_MICROBLAZE_TEXTREL_32_LO for relax function.
bfd/ChangeLog:
* bfd/reloc.c (2 new BFD relocations):
BFD_RELOC_MICROBLAZE_64_TEXTPCREL &
BFD_RELOC_MICROBLAZE_64_TEXTPCREL
* bfd/bfd-in2.h: Regenerate
* bfd/libbfd.h: Regenerate
* bfd/elf32-microblaze.c (Handle new relocs): define 'HOWTO' of 3
new relocs and handle them in both relocate and relax functions.
(microblaze_elf_reloc_type_lookup): add mapping between for new
bfd relocs.
(microblaze_elf_relocate_section): Handle new relocs in case of
elf relocation.
(microblaze_elf_relax_section): Handle new relocs for elf relaxation.
gas/ChangeLog:
* gas/config/tc-microblaze.c (Handle new relocs directives in
assembler): Handle new relocs from compiler output.
(imm_types): add new imm types for data text relative addressing
TEXT_OFFSET, TEXT_PC_OFFSET
(md_convert_frag): conversion for BFD_RELOC_MICROBLAZE_64_TEXTPCREL,
BFD_RELOC_MICROBLAZE_64_TEXTPCREL
(md_apply_fix): apply fix for BFD_RELOC_MICROBLAZE_64_TEXTPCREL,
BFD_RELOC_MICROBLAZE_64_TEXTPCREL
(md_estimate_size_before_relax): estimate size for
BFD_RELOC_MICROBLAZE_64_TEXTPCREL,
BFD_RELOC_MICROBLAZE_64_TEXTPCREL
(tc_gen_reloc): generate relocations for
BFD_RELOC_MICROBLAZE_64_TEXTPCREL,
BFD_RELOC_MICROBLAZE_64_TEXTPCREL
ld/ChangeLog:
* ld/lexsup.c (Add 2 ld options):
(ld_options): add disable-multiple-abs-defs @ 'ld_options' array
(parse_args): parse new option and pass flag to 'link_info' struct.
* ld/ldlex.h (Add enum): add new enum @ 'option_values' enum.
* ld/ld.texinfo (Add new option): Add description for
'disable-multiple-abs-defs'
* ld/main.c: Initialize flags with false @ 'main'. Handle
disable-multiple-abs-defs @ 'mutiple_definition'.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: Use a normal input file with compatible relocation
@ 2018-04-18 1:33 sergiodj+buildbot
2018-04-18 10:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-18 1:33 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e4e6a73d26ef82622d3bd190749aad508534abe6 ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: e4e6a73d26ef82622d3bd190749aad508534abe6
x86: Use a normal input file with compatible relocation
Use a normal input file with compatible relocation to hold linker
created sections,
PR ld/23055
* elfxx-x86.c (_bfd_x86_elf_link_setup_gnu_properties): Use a
normal input file with compatible relocation.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] elf32_bed/elf64_bed
@ 2018-04-18 2:13 sergiodj+buildbot
2018-04-18 12:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-18 2:13 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 8f56f7a23911b6a48b372c8f0893343bfe7ed2e9 ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 8f56f7a23911b6a48b372c8f0893343bfe7ed2e9
elf32_bed/elf64_bed
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove mips aout, coff, and pe support
@ 2018-04-18 8:44 sergiodj+buildbot
2018-04-18 15:00 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-18 8:44 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 3596d8ceb2cdc35b4fd702ee9daace5a2d880174 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 3596d8ceb2cdc35b4fd702ee9daace5a2d880174
Remove mips aout, coff, and pe support
include/coff/mips.h needs to stay for ecoff debug support.
include/
* coff/mipspe.h: Delete.
bfd/
* Makefile.am: Remove mips aout, coff, and pe support.
* config.bfd: Likewise.
* configure.ac: Likewise.
* targets.c: Likewise.
* coff-mips.c: Delete
* mipsbsd.c: Delete
* pe-mips.c: Delete
* pei-mips.c: Delete
* Makefile.in: Regenerate.
* configure: Regenerate.
* po/SRC-POTFILES.in: Regenerate.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Commonise tdesc types and makes use of them in gdbserver tdesc
@ 2018-04-18 14:34 sergiodj+buildbot
2018-04-18 21:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-18 14:34 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT eee8a18dd2d4b62ed5e03324b099508717886193 ***
Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: eee8a18dd2d4b62ed5e03324b099508717886193
Commonise tdesc types and makes use of them in gdbserver tdesc
gdb/
* common/tdesc.c (tdesc_predefined_type): Move to here.
(tdesc_named_type): Likewise.
(tdesc_create_vector): Likewise.
(tdesc_create_struct): Likewise.
(tdesc_set_struct_size): Likewise.
(tdesc_create_union): Likewise.
(tdesc_create_flags): Likewise.
(tdesc_create_enum): Likewise.
(tdesc_add_field): Likewise.
(tdesc_add_typed_bitfield): Likewise.
(tdesc_add_bitfield): Likewise.
(tdesc_add_flag): Likewise.
(tdesc_add_enum_value): Likewise.
* common/tdesc.h (struct tdesc_type_builtin): Likewise.
(struct tdesc_type_vector): Likewise.
(struct tdesc_type_field): Likewise.
(struct tdesc_type_with_fields): Likewise.
(tdesc_create_enum): Add declaration.
(tdesc_add_typed_bitfield): Likewise.
(tdesc_add_enum_value): Likewise.
* target-descriptions.c (tdesc_type_field): Move from here.
(tdesc_type_builtin): Likewise.
(tdesc_type_vector): Likewise.
(tdesc_type_with_fields): Likewise.
(tdesc_predefined_types): Likewise.
(tdesc_named_type): Likewise.
(tdesc_create_vector): Likewise.
(tdesc_create_struct): Likewise.
(tdesc_set_struct_size): Likewise.
(tdesc_create_union): Likewise.
(tdesc_create_flags): Likewise.
(tdesc_create_enum): Likewise.
(tdesc_add_field): Likewise.
(tdesc_add_typed_bitfield): Likewise.
(tdesc_add_bitfield): Likewise.
(tdesc_add_flag): Likewise.
(tdesc_add_enum_value): Likewise.
* gdb/target-descriptions.h (tdesc_create_enum): Likewise.
(tdesc_add_typed_bitfield): Likewise.
(tdesc_add_enum_value): Likewise.
gdbserver/
* tdesc.c (tdesc_create_flags): Remove.
(tdesc_add_flag): Likewise.
(tdesc_named_type): Likewise.
(tdesc_create_union): Likewise.
(tdesc_create_struct): Likewise.
(tdesc_create_vector): Likewise.
(tdesc_add_bitfield): Likewise.
(tdesc_add_field): Likewise.
(tdesc_set_struct_size): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add tdesc osabi and architecture functions
@ 2018-04-18 15:15 sergiodj+buildbot
2018-04-19 2:28 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-18 15:15 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d278f585afe8e096e9232b8fd80404ab5fae5719 ***
Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: d278f585afe8e096e9232b8fd80404ab5fae5719
Add tdesc osabi and architecture functions
gdb/
* common/tdesc.h (tdesc_architecture_name): Add new declaration.
(tdesc_osabi_name): Likewise.
* target-descriptions.c (tdesc_architecture_name): Add new function.
(tdesc_osabi_name): Likewise.
gdbserver/
* tdesc.c (tdesc_architecture_name): Add new function.
(tdesc_osabi_name): Likewise.
(tdesc_get_features_xml): Use new functions.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add feature reference in .dat files
@ 2018-04-18 20:22 sergiodj+buildbot
2018-04-19 6:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-18 20:22 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ad7fc756d12a841d4b8dd707568426d875e26755 ***
Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: ad7fc756d12a841d4b8dd707568426d875e26755
Add feature reference in .dat files
For all targets which use the newer style target descriptions, add a
"feature" marker in the dat files.
Update regdat.sh to parse feature, but do not use it (yet).
gdb/
* features/Makefile: Add feature marker to targets with new style
target descriptions.
* regformats/aarch64.dat: Regenerate.
* regformats/i386/amd64-avx-avx512-linux.dat: Likewise.
* regformats/i386/amd64-avx-linux.dat: Likewise.
* regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Likewise.
* regformats/i386/amd64-avx-mpx-linux.dat: Likewise.
* regformats/i386/amd64-linux.dat: Likewise.
* regformats/i386/amd64-mpx-linux.dat: Likewise.
* regformats/i386/amd64.dat: Likewise.
* regformats/i386/i386-avx-avx512-linux.dat: Likewise.
* regformats/i386/i386-avx-linux.dat: Likewise.
* regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Likewise.
* regformats/i386/i386-avx-mpx-linux.dat: Likewise.
* regformats/i386/i386-linux.dat: Likewise.
* regformats/i386/i386-mmx-linux.dat: Likewise.
* regformats/i386/i386-mpx-linux.dat: Likewise.
* regformats/i386/i386.dat: Likewise.
* regformats/i386/x32-avx-avx512-linux.dat: Likewise.
* regformats/i386/x32-avx-linux.dat: Likewise.
* regformats/i386/x32-linux.dat: Likewise.
* regformats/tic6x-c62x-linux.dat: Likewise.
* regformats/tic6x-c64x-linux.dat: Likewise.
* regformats/tic6x-c64xp-linux.dat: Likewise.
* regformats/regdat.sh: Parse feature marker.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Create xml from target descriptions
@ 2018-04-18 20:43 sergiodj+buildbot
2018-04-19 8:14 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-18 20:43 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e98577a9dc4da048ded601920dc6471dcab375aa ***
Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: e98577a9dc4da048ded601920dc6471dcab375aa
Create xml from target descriptions
Add a print_xml_feature visitor class which turns a
target description into xml. Both gdb and gdbserver can do this.
gdb/
* common/tdesc.c (print_xml_feature::visit_pre): Add xml parsing.
(print_xml_feature::visit_post): Likewise.
(print_xml_feature::visit): Likewise.
* common/tdesc.h (tdesc_get_features_xml): Use const tdesc.
(print_xml_feature): Add new class.
* regformats/regdat.sh: Null xmltarget on feature targets.
* target-descriptions.c (struct target_desc): Add xmltarget.
(maintenance_check_tdesc_xml_convert): Add unittest function.
(tdesc_get_features_xml): Add function to get xml.
(maintenance_check_xml_descriptions): Test xml generation.
* xml-tdesc.c (string_read_description_xml): Add function.
* xml-tdesc.h (string_read_description_xml): Add declaration.
gdbserver/
* gdb/gdbserver/server.c (get_features_xml): Remove cast.
* tdesc.c (void target_desc::accept): Fill in function.
(tdesc_get_features_xml): Remove old xml creation.
(print_xml_feature::visit_pre): Add xml vistor.
* tdesc.h (struct target_desc): Make xmltarget mutable.
(tdesc_get_features_xml): Remove declaration.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove xml files from gdbserver
@ 2018-04-18 21:46 sergiodj+buildbot
2018-04-19 14:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-18 21:46 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b319b0984b505e9a5e653c3da8ae7d5af76c8f28 ***
Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: b319b0984b505e9a5e653c3da8ae7d5af76c8f28
Remove xml files from gdbserver
For ports which use new target descriptions, remove
the xml files from being built into gdbserver.
gdbserver/
* configure.srv (aarch64*-*-linux*): Don't include xml.
(i[34567]86-*-cygwin*): Likewise.
(i[34567]86-*-linux*): Likewise.
(i[34567]86-*-lynxos*): Likewise.
(i[34567]86-*-mingw32ce*): Likewise.
(i[34567]86-*-mingw*): Likewise.
(i[34567]86-*-nto*): Likewise.
(tic6x-*-uclinux): Likewise.
(x86_64-*-linux*): Likewise.
(x86_64-*-mingw*): Likewise.
(x86_64-*-cygwin*): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Reinstate mips ecoff support
@ 2018-04-19 0:40 sergiodj+buildbot
2018-04-19 17:07 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-19 0:40 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 8e415ce8fee234cd86f29d8f4ebbbdf0f9c0b031 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 8e415ce8fee234cd86f29d8f4ebbbdf0f9c0b031
Reinstate mips ecoff support
* Makefile.am: Revert 2018-04-18 coff-mips changes.
* config.bfd: Add back mips_ecoff_le_vec and mips_ecoff_be_vec
to selvecs for mips targets change 2018-04-18.
* configure.ac: Reinstate mips_ecoff_le_vec, mips_ecoff_be_vec
and mips_ecoff_bele_vec.
* targets.c: Likewise.
* coff-mips.c: Resurrect.
* Makefile.in: Regenerate.
* configure: Regenerate.
* po/SRC-POTFILES.in: Regenerate.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] [OB PATCH] Fix some comments in thread.c
@ 2018-04-19 22:02 sergiodj+buildbot
2018-04-19 23:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-19 22:02 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 224608c3ca1575bcbea82562f05d3fdd0390abcf ***
Author: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Branch: master
Commit: 224608c3ca1575bcbea82562f05d3fdd0390abcf
[OB PATCH] Fix some comments in thread.c
Fix some typos.
Remove obsolete comment about dispatch to thread_apply_command,
rather tell that thread_command either switches to a thread,
or prints the current thread.
2018-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
* thread.c (thread_apply_all_command): Fix comment.
(thread_command): Fix comment.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Improve on-line help for thread_apply_command and thread_apply_all_command.
@ 2018-04-20 21:47 sergiodj+buildbot
2018-04-20 23:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-20 21:47 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 5c8f23cdab2a7cde2dae6fcd5f9b18d089efecaf ***
Author: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Branch: master
Commit: 5c8f23cdab2a7cde2dae6fcd5f9b18d089efecaf
Improve on-line help for thread_apply_command and thread_apply_all_command.
Add a Usage: line for thread_apply_command, in particular to mention
the thread ID list.
In thread_apply_command and thread_apply_all_command help, use
uppercase for arg names, as this style seems to be more standard.
2018-04-20 Philippe Waroquiers <philippe.waroquiers@skynet.be>
* thread.c (_initialize_thread): improve on-line help for
thread_apply_command and thread_apply_all_command.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] FreeBSD: Fix 'Couldn't get registers: Device busy' error (PR gdb/23077)
@ 2018-04-21 18:17 sergiodj+buildbot
2018-04-22 9:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-21 18:17 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 00aecdcf6224e44fedf31a07340e9da11500fcfb ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 00aecdcf6224e44fedf31a07340e9da11500fcfb
FreeBSD: Fix 'Couldn't get registers: Device busy' error (PR gdb/23077)
As Rajendra SY reported at
<https://sourceware.org/ml/gdb-patches/2018-04/msg00399.html>, several
attach-related tests are failing on FreeBSD. The "attach" command
errors with "Couldn't get registers: Device busy".
When the "attach" command is executed, it calls target_attach ->
inf_ptrace_attach, which just does the ptrace(PT_ATTACH), it does not
wait for the child to stop with SIGSTOP. Afterwards, the command is
complete and we go back to the event loop. The event loop wakes up
and we end up in target_wait -> fbsd_wait, and handle the SIGSTOP
stop.
At the end of execute_command, though, before going back to the event
loop, we check if the frame language changed via
check_frame_language_change(). That reads the current PC, which is
what leads to the registers read that fails.
The problem is that we fail to mark the attached-to thread as
executing between the initial attach, and the subsequent target_wait.
Until we see the thread stop with SIGSTOP, we shouldn't try to read
registers off of it. I guess there may a timing issue here - if
you're "lucky", the thread may stop before gdb reads its registers,
masking the problem.
With that fixed, check_frame_language_change() becomes a nop until the
thread is marked not-executing again, after target_wait is called and
we go through handle_inferior_event -> normal_stop.
We haven't seen the problem on Linux because there, the target_attach
implementation waits for the thread to stop before returning. Still,
that's supposedly hidden from the core, since the Linux target, like
most targets, is a '!to_attach_no_wait' target.
This fixes:
FAIL: gdb.base/attach.exp: attach1, after setting file
FAIL: gdb.base/attach.exp: attach2, with no file
FAIL: gdb.base/attach.exp: load file manually, after attach2 (re-read) (got interactive prompt)
FAIL: gdb.base/attach.exp: attach when process' a.out not in cwd
FAIL: gdb.base/dprintf-detach.exp: bai=on ds=gdb dd=on: re-attach to inferior
FAIL: gdb.base/dprintf-detach.exp: bai=on ds=gdb dd=off: re-attach to inferior
FAIL: gdb.base/dprintf-detach.exp: bai=on ds=call dd=on: re-attach to inferior
FAIL: gdb.base/dprintf-detach.exp: bai=on ds=call dd=off: re-attach to inferior
FAIL: gdb.base/dprintf-detach.exp: bai=on ds=agent dd=on: re-attach to inferior
FAIL: gdb.base/dprintf-detach.exp: bai=on ds=agent dd=off: re-attach to inferior
FAIL: gdb.base/dprintf-detach.exp: bai=off ds=gdb dd=on: re-attach to inferior
FAIL: gdb.base/dprintf-detach.exp: bai=off ds=gdb dd=off: re-attach to inferior
FAIL: gdb.base/dprintf-detach.exp: bai=off ds=call dd=on: re-attach to inferior
FAIL: gdb.base/dprintf-detach.exp: bai=off ds=call dd=off: re-attach to inferior
FAIL: gdb.base/dprintf-detach.exp: bai=off ds=agent dd=on: re-attach to inferior
FAIL: gdb.base/dprintf-detach.exp: bai=off ds=agent dd=off: re-attach to inferior
gdb/ChangeLog:
2018-04-21 Pedro Alves <palves@redhat.com>
Rajendra SY <rajendra.sy@gmail.com>
* inf-ptrace.c (inf_ptrace_attach): Mark the thread as executing.
* remote.c (extended_remote_attach): In all-stop mode, mark the
thread as executing.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Prevent an illegal memory access in gprof by ensuring that string tables for aout format files are always zero-terminated.
@ 2018-04-23 12:15 sergiodj+buildbot
2018-04-23 13:27 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-23 12:15 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT bf82069dce1b1a88560e5d7320342c78372b627e ***
Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: bf82069dce1b1a88560e5d7320342c78372b627e
Prevent an illegal memory access in gprof by ensuring that string tables for aout format files are always zero-terminated.
PR 23056
* aoutx.h (aout_get_external_symbols): Allocate an extra byte at
the end of the string table, and zero it.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Revert bfd part of "Silence gcc-8 warnings"
@ 2018-04-23 14:42 sergiodj+buildbot
2018-04-23 15:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-23 14:42 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b9f26d2e29bb56a0404216c5612d6d7fee54a769 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: b9f26d2e29bb56a0404216c5612d6d7fee54a769
Revert bfd part of "Silence gcc-8 warnings"
The gcc warning has been fixed, and the patch regressed builds with
some older versions of gcc.
* elf-linux-core.h: Revert last change.
* elf.c: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Reindent cli-out.h
@ 2018-04-24 14:45 sergiodj+buildbot
2018-04-24 17:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-24 14:45 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e427af1889e6d169c3390f6960f1efdd08dca883 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: e427af1889e6d169c3390f6960f1efdd08dca883
Reindent cli-out.h
I noticed that cli-out.h had incorrect indentation in some spots.
This fixes it.
ChangeLog
2018-04-24 Tom Tromey <tom@tromey.com>
* cli-out.h: Reindent.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix an illegal memory access when copying a PE format file with corrupt debug information.
@ 2018-04-24 16:07 sergiodj+buildbot
2018-04-24 22:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-24 16:07 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT aa4a8c2a2a67545e90c877162c53cc9de42dc8b4 ***
Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: aa4a8c2a2a67545e90c877162c53cc9de42dc8b4
Fix an illegal memory access when copying a PE format file with corrupt debug information.
PR 23110
* peXXigen.c (_bfd_XX_bfd_copy_private_bfd_data_common): Check for
a negative PE_DEBUG_DATA size before iterating over the debug data.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove arm-aout and arm-coff support
@ 2018-04-25 0:47 sergiodj+buildbot
2018-04-25 5:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-25 0:47 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2ac93be706418f3b2aebeb22159a328023faed52 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 2ac93be706418f3b2aebeb22159a328023faed52
Remove arm-aout and arm-coff support
This also removes arm-netbsd (not arm-netbsdelf!), arm-openbsd, and
arm-riscix. Those targets weren't on the obsolete list but they are
all aout, and it doesn't make all that much sense to remove arm-aout
without removing them too.
bfd/
* Makefile.am: Remove arm-aout and arm-coff support.
* config.bfd: Likewise.
* configure.ac: Likewise.
* targets.c: Likewise.
* aout-arm.c: Delete.
* armnetbsd.c: Delete.
* riscix.c: Delete.
* Makefile.in: Regenerate.
* configure: Regenerate.
* po/SRC-POTFILES.in: Regenerate.
binutils/
* testsuite/binutils-all/arm/objdump.exp: Remove arm-aout and
arm-coff support.
* testsuite/binutils-all/objcopy.exp: Likewise.
* testsuite/lib/binutils-common.exp: Likewise.
gas/
* Makefile.am: Remove arm-aout and arm-coff support.
* config/tc-arm.c: Likewise.
* config/tc-arm.h: Likewise.
* configure.tgt: Likewise.
* testsuite/gas/aarch64/codealign.d: Likewise.
* testsuite/gas/aarch64/mapping.d: Likewise.
* testsuite/gas/aarch64/mapping2.d: Likewise.
* testsuite/gas/arm/adds-thumb1-reloc-local-armv7-m.d: Likewise.
* testsuite/gas/arm/adds-thumb1-reloc-local.d: Likewise.
* testsuite/gas/arm/addsw-bad.d: Likewise.
* testsuite/gas/arm/align.d: Likewise.
* testsuite/gas/arm/align64.d: Likewise.
* testsuite/gas/arm/arch7.d: Likewise.
* testsuite/gas/arm/arch7a-mp.d: Likewise.
* testsuite/gas/arm/arch7em.d: Likewise.
* testsuite/gas/arm/archv8m-main-dsp-5.d: Likewise.
* testsuite/gas/arm/arm-it-auto-2.d: Likewise.
* testsuite/gas/arm/arm-it-auto-3.d: Likewise.
* testsuite/gas/arm/arm-it-auto.d: Likewise.
* testsuite/gas/arm/arm-it-bad-2.d: Likewise.
* testsuite/gas/arm/arm-it.d: Likewise.
* testsuite/gas/arm/armv7e-m+fpv5-d16.d: Likewise.
* testsuite/gas/arm/armv7e-m+fpv5-sp-d16.d: Likewise.
* testsuite/gas/arm/armv8-2-fp16-scalar-thumb.d: Likewise.
* testsuite/gas/arm/armv8-2-fp16-scalar.d: Likewise.
* testsuite/gas/arm/armv8-2-fp16-simd-thumb.d: Likewise.
* testsuite/gas/arm/armv8-2-fp16-simd.d: Likewise.
* testsuite/gas/arm/armv8-a+crypto.d: Likewise.
* testsuite/gas/arm/armv8-a+fp.d: Likewise.
* testsuite/gas/arm/armv8-a+ras.d: Likewise.
* testsuite/gas/arm/armv8-a+rdma-warning.d: Likewise.
* testsuite/gas/arm/armv8-a+rdma.d: Likewise.
* testsuite/gas/arm/armv8-a+simd.d: Likewise.
* testsuite/gas/arm/armv8-a-barrier-thumb.d: Likewise.
* testsuite/gas/arm/armv8-r+fp.d: Likewise.
* testsuite/gas/arm/armv8-r+simd.d: Likewise.
* testsuite/gas/arm/armv8-r-barrier-thumb.d: Likewise.
* testsuite/gas/arm/armv8_1-a+simd.d: Likewise.
* testsuite/gas/arm/armv8_2+rdma.d: Likewise.
* testsuite/gas/arm/armv8_2-a.d: Likewise.
* testsuite/gas/arm/armv8_3-a-fp.d: Likewise.
* testsuite/gas/arm/armv8_3-a-simd.d: Likewise.
* testsuite/gas/arm/armv8a-automatic-hlt.d: Likewise.
* testsuite/gas/arm/armv8a-automatic-lda.d: Likewise.
* testsuite/gas/arm/attr-syntax.d: Likewise.
* testsuite/gas/arm/automatic-bw.d: Likewise.
* testsuite/gas/arm/automatic-cbz.d: Likewise.
* testsuite/gas/arm/automatic-clrex.d: Likewise.
* testsuite/gas/arm/automatic-lda.d: Likewise.
* testsuite/gas/arm/automatic-ldaex.d: Likewise.
* testsuite/gas/arm/automatic-ldaexb.d: Likewise.
* testsuite/gas/arm/automatic-ldrex.d: Likewise.
* testsuite/gas/arm/automatic-ldrexd.d: Likewise.
* testsuite/gas/arm/automatic-movw.d: Likewise.
* testsuite/gas/arm/automatic-sdiv.d: Likewise.
* testsuite/gas/arm/automatic-strexb.d: Likewise.
* testsuite/gas/arm/barrier-bad-thumb.d: Likewise.
* testsuite/gas/arm/barrier-bad.d: Likewise.
* testsuite/gas/arm/barrier-thumb.d: Likewise.
* testsuite/gas/arm/barrier.d: Likewise.
* testsuite/gas/arm/bignum1.d: Likewise.
* testsuite/gas/arm/blx-bad.d: Likewise.
* testsuite/gas/arm/blx-bl-convert.d: Likewise.
* testsuite/gas/arm/blx-local.s: Likewise.
* testsuite/gas/arm/crc32-armv8-a-bad.d: Likewise.
* testsuite/gas/arm/crc32-armv8-a.d: Likewise.
* testsuite/gas/arm/crc32-armv8-r-bad.d: Likewise.
* testsuite/gas/arm/crc32-armv8-r.d: Likewise.
* testsuite/gas/arm/dis-data.d: Likewise.
* testsuite/gas/arm/dis-data2.d: Likewise.
* testsuite/gas/arm/dis-data3.d: Likewise.
* testsuite/gas/arm/eabi_attr_1.d: Likewise.
* testsuite/gas/arm/fp-save.d: Likewise.
* testsuite/gas/arm/group-reloc-alu-encoding-bad.d: Likewise.
* testsuite/gas/arm/group-reloc-alu-parsing-bad.d: Likewise.
* testsuite/gas/arm/group-reloc-alu.d: Likewise.
* testsuite/gas/arm/group-reloc-ldc-encoding-bad.d: Likewise.
* testsuite/gas/arm/group-reloc-ldc-parsing-bad.d: Likewise.
* testsuite/gas/arm/group-reloc-ldc.d: Likewise.
* testsuite/gas/arm/group-reloc-ldr-encoding-bad.d: Likewise.
* testsuite/gas/arm/group-reloc-ldr-parsing-bad.d: Likewise.
* testsuite/gas/arm/group-reloc-ldr.d: Likewise.
* testsuite/gas/arm/group-reloc-ldrs-encoding-bad.d: Likewise.
* testsuite/gas/arm/group-reloc-ldrs-parsing-bad.d: Likewise.
* testsuite/gas/arm/group-reloc-ldrs.d: Likewise.
* testsuite/gas/arm/insn-error-a.d: Likewise.
* testsuite/gas/arm/insn-error-t.d: Likewise.
* testsuite/gas/arm/inst-po-2.d: Likewise.
* testsuite/gas/arm/inst-po-3.d: Likewise.
* testsuite/gas/arm/inst-po-be.d: Likewise.
* testsuite/gas/arm/inst-po.d: Likewise.
* testsuite/gas/arm/ldconst.d: Likewise.
* testsuite/gas/arm/ldgesb-bad.d: Likewise.
* testsuite/gas/arm/ldgesh-bad.d: Likewise.
* testsuite/gas/arm/ldst-offset0.d: Likewise.
* testsuite/gas/arm/local_function.d: Likewise.
* testsuite/gas/arm/local_label_coff.d: Likewise.
* testsuite/gas/arm/local_label_elf.d: Likewise.
* testsuite/gas/arm/mapping.d: Likewise.
* testsuite/gas/arm/mapping2.d: Likewise.
* testsuite/gas/arm/mapping3.d: Likewise.
* testsuite/gas/arm/mapping4.d: Likewise.
* testsuite/gas/arm/mapshort-elf.d: Likewise.
* testsuite/gas/arm/mask_1-armv8-a.d: Likewise.
* testsuite/gas/arm/mask_1-armv8-r.d: Likewise.
* testsuite/gas/arm/movs-thumb1-reloc-local-armv7-m.d: Likewise.
* testsuite/gas/arm/movs-thumb1-reloc-local.d: Likewise.
* testsuite/gas/arm/movw-local.d: Likewise.
* testsuite/gas/arm/mrs-msr-thumb-v6t2.d: Likewise.
* testsuite/gas/arm/mrs-msr-thumb-v7-m.d: Likewise.
* testsuite/gas/arm/mrs-msr-thumb-v7e-m.d: Likewise.
* testsuite/gas/arm/msr-imm-bad.d: Likewise.
* testsuite/gas/arm/msr-reg-bad.d: Likewise.
* testsuite/gas/arm/msr-reg-thumb.d: Likewise.
* testsuite/gas/arm/nomapping.d: Likewise.
* testsuite/gas/arm/nops.d: Likewise.
* testsuite/gas/arm/pic.d: Likewise.
* testsuite/gas/arm/pinsn.d: Likewise.
* testsuite/gas/arm/plt-1.d: Likewise.
* testsuite/gas/arm/pr21458.d: Likewise.
* testsuite/gas/arm/pr9722.d: Likewise.
* testsuite/gas/arm/strex-t.d: Likewise.
* testsuite/gas/arm/t2-branch-global.d: Likewise.
* testsuite/gas/arm/target-reloc-1.d: Likewise.
* testsuite/gas/arm/thumb-b-bad.d: Likewise.
* testsuite/gas/arm/thumb-w-bad.d: Likewise.
* testsuite/gas/arm/thumb-w-good.d: Likewise.
* testsuite/gas/arm/thumb.d: Likewise.
* testsuite/gas/arm/thumb2_it.d: Likewise.
* testsuite/gas/arm/thumb2_it_auto.d: Likewise.
* testsuite/gas/arm/thumb2_it_search.d: Likewise.
* testsuite/gas/arm/thumb2_ldmstm.d: Likewise.
* testsuite/gas/arm/thumb2_ldr_immediate_armv6.d: Likewise.
* testsuite/gas/arm/thumb2_ldr_immediate_armv6t2.d: Likewise.
* testsuite/gas/arm/thumb2_ldr_immediate_highregs_armv6t2.d: Likewise.
* testsuite/gas/arm/thumb2_pool.d: Likewise.
* testsuite/gas/arm/thumb2_vpool.d: Likewise.
* testsuite/gas/arm/thumb2_vpool_be.d: Likewise.
* testsuite/gas/arm/thumb32.d: Likewise.
* testsuite/gas/arm/thumbver.d: Likewise.
* testsuite/gas/arm/tls.d: Likewise.
* testsuite/gas/arm/tls_vxworks.d: Likewise.
* testsuite/gas/arm/undefined.d: Likewise.
* testsuite/gas/arm/undefined_coff.d: Likewise.
* testsuite/gas/arm/unwind.d: Likewise.
* testsuite/gas/arm/v4bx.d: Likewise.
* testsuite/gas/arm/vcmp-noprefix-imm.d: Likewise.
* testsuite/gas/arm/vcvt-bad.d: Likewise.
* testsuite/gas/arm/vfma1.d: Likewise.
* testsuite/gas/arm/vldconst.d: Likewise.
* testsuite/gas/arm/vldconst_be.d: Likewise.
* testsuite/gas/arm/vldm-arm.d: Likewise.
* testsuite/gas/arm/vldr.d: Likewise.
* testsuite/gas/arm/weakdef-1.d: Likewise.
* testsuite/gas/arm/weakdef-2.d: Likewise.
* config/te-riscix.h: Delete.
* Makefile.in: Regenerate.
* po/POTFILES.in: Regenerate.
ld/
* Makefile.am: Remove arm-aout and arm-coff support.
* configure.tgt: Likewise.
* testsuite/ld-arm/attr-merge-div-00.d: Likewise.
* testsuite/ld-arm/attr-merge-div-01-m3.d: Likewise.
* testsuite/ld-arm/attr-merge-div-01.d: Likewise.
* testsuite/ld-arm/attr-merge-div-02.d: Likewise.
* testsuite/ld-arm/attr-merge-div-10-m3.d: Likewise.
* testsuite/ld-arm/attr-merge-div-10.d: Likewise.
* testsuite/ld-arm/attr-merge-div-11.d: Likewise.
* testsuite/ld-arm/attr-merge-div-12.d: Likewise.
* testsuite/ld-arm/attr-merge-div-120.d: Likewise.
* testsuite/ld-arm/attr-merge-div-20.d: Likewise.
* testsuite/ld-arm/attr-merge-div-21.d: Likewise.
* testsuite/ld-arm/attr-merge-div-22.d: Likewise.
* testsuite/ld-arm/attr-merge-hardfp-use-1.d: Likewise.
* testsuite/ld-arm/attr-merge-hardfp-use-2.d: Likewise.
* testsuite/ld-arm/attr-merge-nosection-1.d: Likewise.
* testsuite/ld-arm/attr-merge-unknown-2.d: Likewise.
* testsuite/ld-arm/attr-merge-unknown-2r.d: Likewise.
* testsuite/ld-arm/attr-merge-unknown-3.d: Likewise.
* testsuite/ld-arm/attr-merge-vfp-1.d: Likewise.
* testsuite/ld-arm/attr-merge-vfp-10.d: Likewise.
* testsuite/ld-arm/attr-merge-vfp-10r.d: Likewise.
* testsuite/ld-arm/attr-merge-vfp-11.d: Likewise.
* testsuite/ld-arm/attr-merge-vfp-11r.d: Likewise.
* testsuite/ld-arm/attr-merge-vfp-12.d: Likewise.
* testsuite/ld-arm/attr-merge-vfp-12r.d: Likewise.
* testsuite/ld-arm/attr-merge-vfp-13.d: Likewise.
* testsuite/ld-arm/attr-merge-vfp-13r.d: Likewise.
* testsuite/ld-arm/attr-merge-vfp-14.d: Likewise.
* testsuite/ld-arm/attr-merge-vfp-14r.d: Likewise.
* testsuite/ld-arm/attr-merge-vfp-1r.d: Likewise.
* testsuite/ld-arm/attr-merge-vfp-2.d: Likewise.
* testsuite/ld-arm/attr-merge-vfp-2r.d: Likewise.
* testsuite/ld-arm/attr-merge-vfp-3.d: Likewise.
* testsuite/ld-arm/attr-merge-vfp-3r.d: Likewise.
* testsuite/ld-arm/attr-merge-vfp-4.d: Likewise.
* testsuite/ld-arm/attr-merge-vfp-4r.d: Likewise.
* testsuite/ld-arm/attr-merge-vfp-5.d: Likewise.
* testsuite/ld-arm/attr-merge-vfp-5r.d: Likewise.
* testsuite/ld-arm/attr-merge-vfp-6.d: Likewise.
* testsuite/ld-arm/attr-merge-vfp-6r.d: Likewise.
* testsuite/ld-arm/attr-merge-vfp-7.d: Likewise.
* testsuite/ld-arm/attr-merge-vfp-7r.d: Likewise.
* testsuite/ld-arm/attr-merge-vfp-8.d: Likewise.
* testsuite/ld-arm/attr-merge-vfp-8r.d: Likewise.
* testsuite/ld-arm/attr-merge-vfp-9.d: Likewise.
* testsuite/ld-arm/attr-merge-vfp-9r.d: Likewise.
* testsuite/ld-arm/attr-merge-wchar-00-nowarn.d: Likewise.
* testsuite/ld-arm/attr-merge-wchar-00.d: Likewise.
* testsuite/ld-arm/attr-merge-wchar-02-nowarn.d: Likewise.
* testsuite/ld-arm/attr-merge-wchar-02.d: Likewise.
* testsuite/ld-arm/attr-merge-wchar-04-nowarn.d: Likewise.
* testsuite/ld-arm/attr-merge-wchar-04.d: Likewise.
* testsuite/ld-arm/attr-merge-wchar-20-nowarn.d: Likewise.
* testsuite/ld-arm/attr-merge-wchar-20.d: Likewise.
* testsuite/ld-arm/attr-merge-wchar-22-nowarn.d: Likewise.
* testsuite/ld-arm/attr-merge-wchar-22.d: Likewise.
* testsuite/ld-arm/attr-merge-wchar-24-nowarn.d: Likewise.
* testsuite/ld-arm/attr-merge-wchar-40-nowarn.d: Likewise.
* testsuite/ld-arm/attr-merge-wchar-40.d: Likewise.
* testsuite/ld-arm/attr-merge-wchar-42-nowarn.d: Likewise.
* testsuite/ld-arm/attr-merge-wchar-44-nowarn.d: Likewise.
* testsuite/ld-arm/attr-merge-wchar-44.d: Likewise.
* testsuite/ld-arm/eabi-hard-float.d: Likewise.
* testsuite/ld-arm/eabi-soft-float-ABI4.d: Likewise.
* testsuite/ld-arm/eabi-soft-float-r.d: Likewise.
* testsuite/ld-arm/eabi-soft-float.d: Likewise.
* testsuite/ld-arm/gc-hidden-1.d: Likewise.
* emulparams/armaoutb.sh: Delete.
* emulparams/armaoutl.sh: Delete.
* emulparams/armcoff.sh: Delete.
* emulparams/armnbsd.sh: Delete.
* emulparams/riscix.sh: Delete.
* scripttempl/armaout.sc: Delete.
* scripttempl/armcoff.sc: Delete.
* scripttempl/riscix.sc: Delete.
* Makefile.in: Regenerate.
* po/BLD-POTFILES.in: Regenerate.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Silence gcc-8 warnings
@ 2018-04-25 8:21 sergiodj+buildbot
2018-04-25 10:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-25 8:21 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d99b4b92c8ed0f7ef98f370bbf65a360ed66ad7b ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: d99b4b92c8ed0f7ef98f370bbf65a360ed66ad7b
Silence gcc-8 warnings
This seems to work with gcc-8 and a bunch of prior gcc versions I tested.
* elf-linux-core.h: Disable gcc-8 string truncation warning.
* elf.c (elfcore_write_prpsinfo): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix the mask for the sqrdml(a|s)h instructions.
@ 2018-04-25 12:59 sergiodj+buildbot
2018-04-25 14:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-25 12:59 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 10bba94bd44045559cfd048cd34376090dd8107a ***
Author: Tamar Christina <tamar.christina@arm.com>
Branch: master
Commit: 10bba94bd44045559cfd048cd34376090dd8107a
Fix the mask for the sqrdml(a|s)h instructions.
Rn is supposed to have a 5 bit range but instead was given 4 bits
causing these instructions to disassemble as unknown instructions.
opcodes/
* aarch64-tbl.h (sqrdmlah, sqrdmlsh): Fix masks.
gas/
* testsuite/gas/aarch64/rdma.s: Test for larger register numbers.
* testsuite/gas/aarch64/rdma.d: Update results.
* testsuite/gas/aarch64/rdma-directive.d: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix new inferior events output
@ 2018-04-25 18:28 sergiodj+buildbot
2018-04-25 19:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-25 18:28 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 249b57335279b1051456884f1a908cdec907f43a ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 249b57335279b1051456884f1a908cdec907f43a
Fix new inferior events output
Since f67c0c917150 ("Enable 'set print inferior-events' and improve
detach/fork/kill/exit messages"), when detaching a remote process, we
get, for detach against a remote target:
(gdb) detach
Detaching from program: ...., process 5388
Ending remote debugging.
[Inferior 1 (Thread 5388.5388) detached]
^^^^^^^^^^^^^^^^
That is incorrect, for it is printing a thread id as string while we
should be printing the process id instead. I.e., either one of:
[Inferior 1 (process 5388) detached]
[Inferior 1 (Remote target) detached]
depending on remote stub support for the multi-process extensions.
Similarly, after killing a process, we're printing thread ids while we
should be printing process ids. E.g., on native GNU/Linux:
(gdb) k
Kill the program being debugged? (y or n) y
[Inferior 1 (Thread 0x7ffff7faa8c0 (LWP 30721)) has been killed]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
while it should have been:
Kill the program being debugged? (y or n) y
[Inferior 1 (process 30721) has been killed]
^^^^^^^^^^^^^
There's a wording inconsistency between detach and kill:
[Inferior 1 (process 30721) has been killed]
[Inferior 1 (process 30721) detached]
Given we were already saying "detached" instead of "has been
detached", and we used to say just "exited", and given that the "has
been" doesn't really add any information, this commit changes the
message to just "killed":
[Inferior 1 (process 30721) killed]
gdb/ChangeLog:
2018-04-25 Pedro Alves <palves@redhat.com>
* infcmd.c (kill_command): Print the pid as string, not the whole
thread's ptid. Add comment. s/has been killed/killed/ in output
message.
* remote.c (remote_detach_1): Print the pid as string, not the
whole thread's ptid.
gdb/testsuite/ChangeLog:
2018-04-25 Pedro Alves <palves@redhat.com>
* gdb.base/hook-stop.exp: Expect "killed" instead of "has been
killed".
* gdb.base/kill-after-signal.exp: Likewise.
* gdb.threads/kill.exp: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] [ARM] Add armelf_linux_fdpiceabi and armelfb_linux_fdpiceabi BFD backends
@ 2018-04-25 21:40 sergiodj+buildbot
2018-04-25 22:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-25 21:40 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 617a5ada88c7d4b6aae201ad5b295f3d2ef07c10 ***
Author: Christophe Lyon <christophe.lyon@st.com>
Branch: master
Commit: 617a5ada88c7d4b6aae201ad5b295f3d2ef07c10
[ARM] Add armelf_linux_fdpiceabi and armelfb_linux_fdpiceabi BFD backends
Initial definition of these new backends.
2018-04-25 Christophe Lyon <christophe.lyon@st.com>
Mickal Gun <mickael.guene@st.com>
bfd/
* config.bfd (arm*-*-linux-*): Add arm_elf32_fdpic_be_vec and
arm_elf32_fdpic_le_vec to targ_selvecs. Accept
arm*-*-uclinuxfdpiceabi.
* configure.ac: Add support for arm_elf32_fdpic_be_vec and
arm_elf32_fdpic_le_vec.
* configure: Regenerate.
* elf32-arm.c (struct elf32_arm_link_hash_table): Add fdpic_p.
(elf32_arm_link_hash_table_create): Initialize fdpic_p.
(TARGET_LITTLE_SYM, TARGET_LITTLE_NAME, TARGET_BIG_SYM)
(TARGET_BIG_NAME, elf_match_priority): Define for FDPIC targets.
(elf32_arm_fdpic_link_hash_table_create): New.
* targets.c (_bfd_target_vector): Add arm_elf32_fdpic_be_vec and
arm_elf32_fdpic_le_vec.
ld/
* Makefile.am (ALL_EMULATION_SOURCES): Add
earmelf_linux_fdpiceabi.c and earmelfb_linux_fdpiceabi.c.
(earmelf_linux_fdpiceabi.c, earmelfb_linux_fdpiceabi.c): New rules.
* Makefile.in: Regenerate.
* configure.tgt (arm*-*-uclinuxfdpiceabi): Handle new target.
* emulparams/armelf_linux_fdpiceabi.sh: New.
* emulparams/armelfb_linux_fdpiceabi.sh: New.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] [ARM] Add FDPIC OSABI flag support.
@ 2018-04-25 22:20 sergiodj+buildbot
2018-04-26 1:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-25 22:20 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 18a203380502fb3ee75633fd464faa3c83cec710 ***
Author: Christophe Lyon <christophe.lyon@st.com>
Branch: master
Commit: 18a203380502fb3ee75633fd464faa3c83cec710
[ARM] Add FDPIC OSABI flag support.
ELF files targetting ARM FDPIC use the ELFOSABI_ARM_FDPIC flag.
Set it appropriately in file generators (eg. gas), and handle it in
readers (eg. readelf).
2018-04-25 Christophe Lyon <christophe.lyon@st.com>
Mickal Gun <mickael.guene@st.com>
bfd/
* elf32-arm.c (elf32_arm_print_private_bfd_data): Support
EF_ARM_PIC and ELFOSABI_ARM_FDPIC.
(elf32_arm_post_process_headers): Support ELFOSABI_ARM_FDPIC.
(ELF_OSABI): Define to ELFOSABI_ARM_FDPIC.
binutils/
* readelf.c (decode_ARM_machine_flags): Support EF_ARM_PIC.
(get_osabi_name): Support ELFOSABI_ARM_FDPIC.
gas/
* config/tc-arm.c (arm_fdpic): New.
(elf32_arm_target_format): Support FDPIC.
(OPTION_FDPIC): New.
(md_longopts): Support FDPIC.
(md_parse_option): Likewise.
(md_show_usage): Likewise.
include/
* elf/arm.h (EF_ARM_FDPIC): New.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] [ARM] Implement FDPIC relocations.
@ 2018-04-25 23:36 sergiodj+buildbot
2018-04-26 6:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-25 23:36 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e8b09b87102504a110f839e67a712094d63dcbab ***
Author: Christophe Lyon <christophe.lyon@st.com>
Branch: master
Commit: e8b09b87102504a110f839e67a712094d63dcbab
[ARM] Implement FDPIC relocations.
This is the main BFD patch, that enables the linker to actually handle
the FDPIC relocations.
2018-04-25 Christophe Lyon <christophe.lyon@st.com>
Mickal Gun <mickael.guene@st.com>
bfd/
* elf32-arm.c (struct fdpic_local): New.
(elf_arm_obj_tdata): Add local_fdpic_cnts field.
(elf32_arm_local_fdpic_cnts): New.
(struct fdpic_global): New.
(elf32_arm_link_hash_entry): Add fdpic_cnts field.
(elf32_arm_link_hash_table): Add srofixup field.
(arm_elf_add_rofixup): New.
(arm_elf_fill_funcdesc): New.
(elf32_arm_link_hash_newfunc): Handle fdpic_cnts.
(elf32_arm_allocate_local_sym_info): Likewise.
(create_got_section): Create .rofixup section.
(elf32_arm_copy_indirect_symbol): Handle fdpic_cnts.
(bfd_elf32_arm_set_target_params): Handle FDPIC.
(elf32_arm_final_link_relocate): Likewise.
(elf32_arm_check_relocs): Likewise.
(allocate_dynrelocs_for_symbol): Likewise.
(elf32_arm_size_dynamic_sections): Likewise.
(elf32_arm_finish_dynamic_sections): Likewise.
(elf32_arm_output_arch_local_syms): Likewise.
(elf32_arm_fdpic_omit_section_dynsym): New.
ld/
* emulparams/armelf_linux_fdpiceabi.sh: Add .rofixup section.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] [ARM] Add TLS relocations for FDPIC.
@ 2018-04-26 0:55 sergiodj+buildbot
2018-04-26 11:23 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 0:55 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 5c5a4843ec385a60954fbbc4bcf5b64763639bd3 ***
Author: Christophe Lyon <christophe.lyon@st.com>
Branch: master
Commit: 5c5a4843ec385a60954fbbc4bcf5b64763639bd3
[ARM] Add TLS relocations for FDPIC.
Define and handle TLS relocations for FDPIC in BFD and gas.
In gas, the new relocations are rejected if the --fdpic option was not
specified.
We also define the __tdata_start symbol to mark the start of the
.tdata section. This allows FDPIC static binaries to find the start of
.tdata section, since phdr->p_vaddr of TLS segment is not a valid
value for FDPIC.
2018-04-25 Christophe Lyon <christophe.lyon@st.com>
Mickal Gun <mickael.guene@st.com>
bfd/:
* bfd-in2.h (BFD_RELOC_ARM_TLS_GD32_FDPIC)
(BFD_RELOC_ARM_TLS_LDM32_FDPIC, BFD_RELOC_ARM_TLS_IE32_FDPIC): New
relocations.
* elf32-arm.c (elf32_arm_howto_table_2): Add R_ARM_TLS_GD32_FDPIC,
R_ARM_TLS_LDM32_FDPIC, R_ARM_TLS_IE32_FDPIC relocations.
(elf32_arm_reloc_map): Add R_ARM_TLS_GD32_FDPIC,
R_ARM_TLS_LDM32_FDPIC, R_ARM_TLS_IE32_FDPIC.
(struct elf32_arm_link_hash_table): Update comment.
(elf32_arm_final_link_relocate): Handle TLS FDPIC relocations.
(IS_ARM_TLS_RELOC): Likewise.
(elf32_arm_check_relocs): Likewise.
(allocate_dynrelocs_for_symbol): Likewise.
(elf32_arm_size_dynamic_sections): Update comment.
* reloc.c: Add BFD_RELOC_ARM_TLS_GD32_FDPIC,
BFD_RELOC_ARM_TLS_LDM32_FDPIC, BFD_RELOC_ARM_TLS_IE32_FDPIC.
gas/
* config/tc-arm.c (reloc_names): Add TLSGD_FDPIC, TLSLDM_FDPIC,
GOTTPOFF_FDIC relocations.
(md_apply_fix): Handle the new TLS FDPIC relocations.
(tc_gen_reloc): Likewise.
(arm_fix_adjustable): Likewise.
include/
* elf/arm.h: Add R_ARM_TLS_GD32_FDPIC, R_ARM_TLS_LDM32_FDPIC,
R_ARM_TLS_IE32_FDPIC.
ld/
* scripttempl/elf.sc: Define __tdata_start for .tdata section.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] [ARM] FDPIC: Add stack segment
@ 2018-04-26 1:29 sergiodj+buildbot
2018-04-26 13:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 1:29 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT cb10292c2a6c26349c02ec275e4087147fd1cdf0 ***
Author: Christophe Lyon <christophe.lyon@st.com>
Branch: master
Commit: cb10292c2a6c26349c02ec275e4087147fd1cdf0
[ARM] FDPIC: Add stack segment
The size of the stack segment defaults to 32KB, and can be overridden
by defining the __stacksize symbol.
2018-04-25 Christophe Lyon <christophe.lyon@st.com>
Mickal Gun <mickael.guene@st.com>
bfd/
* elf32-arm.c (DEFAULT_STACK_SIZE): New.
(elf32_arm_always_size_sections): Create stack segment.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] [ARM] FDPIC: Make _GLOBAL_OFFSET_TABLE_ a relative symbol
@ 2018-04-26 2:23 sergiodj+buildbot
2018-04-26 18:39 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 2:23 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT fac7bd6475c4058e7c1e0df29dac50579e427b34 ***
Author: Christophe Lyon <christophe.lyon@st.com>
Branch: master
Commit: fac7bd6475c4058e7c1e0df29dac50579e427b34
[ARM] FDPIC: Make _GLOBAL_OFFSET_TABLE_ a relative symbol
2018-04-25 Christophe Lyon <christophe.lyon@st.com>
Mickal Gun <mickael.guene@st.com>
bfd/
* elf32-arm.c (elf32_arm_finish_dynamic_symbol): Handle
_GLOBAL_OFFSET_TABLE_ in FDPIC mode.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: CpuXSAVE is a prereq for various other features
@ 2018-04-26 8:36 sergiodj+buildbot
2018-04-27 6:07 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 8:36 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 59ef5df41e8a2addac4c74bb838fe8295cc79ebf ***
Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 59ef5df41e8a2addac4c74bb838fe8295cc79ebf
x86: CpuXSAVE is a prereq for various other features
All of AVX, LWP, MPX, and PKU require XSAVE, and hence it as well as
XRSTOR should be enabled when enabling these ISA extensions. Leverage
these implications to shorten some of the cpu_flag_init[] entries.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: fold various non-memory operand AVX512VL templates
@ 2018-04-26 9:03 sergiodj+buildbot
2018-04-27 8:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 9:03 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e2195274d4a0752459ea89ffbf50b2704fb0c0b4 ***
Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: e2195274d4a0752459ea89ffbf50b2704fb0c0b4
x86: fold various non-memory operand AVX512VL templates
There's little point carrying up to three templates per insn flavor
when the sole difference is operand size and the dependency on AVX512VL
being enabled. Instead the need for AVX512VL can be derived from an
operand allowing for ZMMword as well as one or both or XMMword and
YMMword (irrespective of whether this is a register or memory operand).
Without further abstraction to deal with the different Disp8MemShift
values between the templates, only a limited set (mostly ones only
allowing for non-memory operands) can be folded, which is being done
here.
Also drop IgnoreSize wherever possible from anything that's being
touched anyway.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: x87-related adjustments
@ 2018-04-26 10:29 sergiodj+buildbot
2018-04-27 1:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 10:29 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 0e0eea782025d92f894f6d132aae2507c6a90a7b ***
Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 0e0eea782025d92f894f6d132aae2507c6a90a7b
x86: x87-related adjustments
Neither 287 wrt 8087 nor 387 wrt 287 are proper supersets - in each case
some insns get removed from the ISA (they become NOPs, but code intended
for newer co-processors should not use them).
Furthermore with .no87, ST should not be recognized as a register name.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix breakpoints in ifunc after inferior resolved it (@got.plt symbol creation)
@ 2018-04-26 12:47 sergiodj+buildbot
2018-04-27 11:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 12:47 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 02e169e2dac9b0354162eb0e7ee3fc95134b232d ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 02e169e2dac9b0354162eb0e7ee3fc95134b232d
Fix breakpoints in ifunc after inferior resolved it (@got.plt symbol creation)
Setting a breakpoint on an ifunc symbol after the ifunc has already
been resolved by the inferior should result in creating a breakpoint
location at the ifunc target. However, that's not what happens on
current Fedora:
(gdb) n
53 i = gnu_ifunc (1); /* break-at-call */
(gdb)
54 assert (i == 2);
(gdb) b gnu_ifunc
Breakpoint 2 at gnu-indirect-function resolver at 0x7ffff7bd36ee
(gdb) info breakpoints
Num Type Disp Enb Address What
2 STT_GNU_IFUNC resolver keep y 0x00007ffff7bd36ee <gnu_ifunc+4>
The problem is that elf_gnu_ifunc_resolve_by_got never manages to
resolve an ifunc target. The reason is that GDB never actually
creates the internal got.plt symbols:
(gdb) p 'gnu_ifunc@got.plt'
No symbol "gnu_ifunc@got.plt" in current context.
and this is because GDB expects that rela.plt has relocations for
.plt, while it actually has relocations for .got.plt:
Relocation section [10] '.rela.plt' for section [22] '.got.plt' at offset 0x570 contains 2 entries:
Offset Type Value Addend Name
0x0000000000601018 X86_64_JUMP_SLOT 000000000000000000 +0 __assert_fail
0x0000000000601020 X86_64_JUMP_SLOT 000000000000000000 +0 gnu_ifunc
Using an older system on the GCC compile farm (machine gcc15, an
x86-64 running Debian 6.0.8, with GNU ld 2.20.1), we see that it used
to be that we'd get a .rela.plt section for .plt:
Relocation section [ 9] '.rela.plt' for section [11] '.plt' at offset 0x578 contains 3 entries:
Offset Type Value Addend Name
0x0000000000600cc0 X86_64_JUMP_SLOT 000000000000000000 +0 __assert_fail
0x0000000000600cc8 X86_64_JUMP_SLOT 000000000000000000 +0 __libc_start_main
0x0000000000600cd0 X86_64_JUMP_SLOT 000000000000000000 +0 gnu_ifunc
Those offsets did point into .got.plt, as seen with objdump -h:
20 .got.plt 00000030 0000000000600ca8 0000000000600ca8 00000ca8 2**3
CONTENTS, ALLOC, LOAD, DATA
I also tested on gcc110 on the compile farm (PPC64 running CentOS
7.4.1708, with GNU ld 2.25.1), and there we see instead:
Relocation section [ 9] '.rela.plt' for section [23] '.plt' at offset 0x5d0 contains 4 entries:
Offset Type Value Addend Name
0x0000000010020148 PPC64_JMP_SLOT 000000000000000000 +0 __libc_start_main
0x0000000010020160 PPC64_JMP_SLOT 000000000000000000 +0 __gmon_start__
0x0000000010020178 PPC64_JMP_SLOT 000000000000000000 +0 __assert_fail
0x0000000010020190 PPC64_JMP_SLOT 000000000000000000 +0 gnu_ifunc
But note that those offsets point into .plt, not .got.plt, as seen
with objdump -h:
22 .plt 00000078 0000000010020130 0000000010020130 00010130 2**3
ALLOC
This commit makes us support all the different combinations above.
With that addressed, we now get:
(gdb) p 'gnu_ifunc@got.plt'
$1 = (<text from jump slot in .got.plt, no debug info>) 0x400753 <final>
And setting a breakpoint on the ifunc finds the ifunc target:
(gdb) b gnu_ifunc
Breakpoint 2 at 0x400753
(gdb) info breakpoints
Num Type Disp Enb Address What
2 breakpoint keep y 0x0000000000400753 <final>
gdb/ChangeLog:
2018-04-26 Pedro Alves <palves@redhat.com>
* elfread.c (elf_rel_plt_read): Look for relocations for .got.plt too.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Calling ifunc functions when target has no debug info but resolver has
@ 2018-04-26 13:28 sergiodj+buildbot
2018-04-27 16:54 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 13:28 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 8388016d7ff8b88d29f2427963f26a6b8bbb03b1 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 8388016d7ff8b88d29f2427963f26a6b8bbb03b1
Calling ifunc functions when target has no debug info but resolver has
After the previous patch, on Fedora 27 (glibc 2.26), if you try
calling strlen in the inferior, you now get:
(top-gdb) p strlen ("hello")
'__strlen_avx2' has unknown return type; cast the call to its declared return type
This is correct, because __strlen_avx2 is written in assembly.
We can improve on this though -- if the final ifunc resolved/target
function has no debug info, but the ifunc _resolver_ does have debug
info, we can try extracting the final function's type from the type
that the resolver returns. E.g.,:
typedef size_t (*strlen_t) (const char*);
size_t my_strlen (const char *) { /* some implementation */ }
strlen_t strlen_resolver (unsigned long hwcap) { return my_strlen; }
extern size_t strlen (const char *s);
__typeof (strlen) strlen __attribute__ ((ifunc ("strlen_resolver")));
In the strlen example above, the resolver returns strlen_t, which is a
typedef for pointer to a function that returns size_t. "strlen_t" is
the type of both the user-visible "strlen", and of the the target
function that implements it.
This patch teaches GDB to extract that type.
This is done for actual inferior function calls (in infcall.c), and
for ptype (in eval_call). By the time we get to either of these
places, we've already lost the original symbol/minsym, and only have
values and types to work with. Hence the changes to c-exp.y and
evaluate_var_msym_value, to ensure that we propagate the ifunc
minsymbol's info.
The change to make ifunc symbols have no/unknown return type exposes a
latent problem -- gdb.compile/compile-ifunc.exp calls a no-debug-info
function, but we did not warn about it. The test is fixed by this
commit too.
gdb/ChangeLog:
2018-04-26 Pedro Alves <palves@redhat.com>
* blockframe.c (find_gnu_ifunc_target_type): New function.
(find_function_type): New.
* eval.c (evaluate_var_msym_value): For GNU ifunc types, always
return a value with a memory address.
(eval_call): For calls to GNU ifunc functions, try to find the
type of the target function from the type that the resolver
returns.
* gdbtypes.c (objfile_type): Don't install a return type for ifunc
symbols.
* infcall.c (find_function_return_type): Delete.
(find_function_addr): Add 'function_type' parameter. For calls to
GNU ifunc functions, try to find the type of the target function
from the type that the resolver returns, and return it via
FUNCTION_TYPE.
(call_function_by_hand_dummy): Adjust to use the function type
returned by find_function_addr.
(find_function_addr): Add 'function_type' parameter and move
description here.
* symtab.h (find_function_type, find_gnu_ifunc_target_type): New
declarations.
gdb/testsuite/ChangeLog:
2018-04-26 Pedro Alves <palves@redhat.com>
* gdb.compile/compile-ifunc.exp: Also expect "function has unknown
return type" warnings.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix calling ifunc functions when resolver has debug info and different name
@ 2018-04-26 14:27 sergiodj+buildbot
2018-04-27 13:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 14:27 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a376e11d84ba7ea8cc7333c77043e20c7b0cfc91 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: a376e11d84ba7ea8cc7333c77043e20c7b0cfc91
Fix calling ifunc functions when resolver has debug info and different name
Currently, on Fedora 27 (glibc 2.26), if you try to call strlen in the
inferior you get:
(gdb) p strlen ("hello")
$1 = (size_t (*)(const char *)) 0x7ffff554aac0 <__strlen_avx2>
strlen is an ifunc function, and what we see above is the result of
calling the ifunc resolver in the inferior. That returns a pointer to
the actual target function that implements strlen on my machine. GDB
should have turned around and called the resolver automatically
without the user noticing.
This is was caused by commit:
commit bf223d3e808e6fec9ee165d3d48beb74837796de
Date: Mon Aug 21 11:34:32 2017 +0100
Handle function aliases better (PR gdb/19487, errno printing)
which added the find_function_alias_target call to c-exp.y, to try to
find an alias with debug info for a minsym. For ifunc symbols, that
finds the ifunc's resolver if it has debug info (in the example it's
called "strlen_ifunc"), with the result that GDB calls that as a
regular function.
After this commit, we get now get:
(top-gdb) p strlen ("hello")
'__strlen_avx2' has unknown return type; cast the call to its declared return type
Which is correct, because __strlen_avx2 is written in assembly.
That'll be improved in a following patch, though.
gdb/ChangeLog:
2018-04-26 Pedro Alves <palves@redhat.com>
* c-exp.y (variable production): Skip finding an alias for ifunc
symbols.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Calling ifunc functions when resolver has debug info, user symbol same name
@ 2018-04-26 14:33 sergiodj+buildbot
2018-04-27 19:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 14:33 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ca31ab1d675c1e20cee5f8cb213c52e3d7352496 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: ca31ab1d675c1e20cee5f8cb213c52e3d7352496
Calling ifunc functions when resolver has debug info, user symbol same name
If the GNU ifunc resolver has the same name as the user visible
symbol, and the resolver has debug info, then the DWARF info for the
resolver masks the ifunc minsym. In that scenario, if you try calling
the ifunc from GDB, you call the resolver instead. With the
gnu-ifunc.exp testcase added in a following patch, you'd see:
(gdb) p gnu_ifunc (3)
$1 = (int (*)(int)) 0x400753 <final>
(gdb) FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=1: resolved_debug=0: p gnu_ifunc (3)
^^^^^^^^^^^^^^^^
That is, we called the ifunc resolver manually, which returned a
pointer to the ifunc target function ("final"). The "final" symbol is
the function that GDB should have called automatically,
~~~~~~~~~~~~
int
final (int arg)
{
return arg + 1;
}
~~~~~~~~~
which is what happens if you don't have debug info for the resolver:
(gdb) p gnu_ifunc (3)
$1 = 4
(gdb) PASS: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=0: resolved_debug=1: p gnu_ifunc (3)
^^^^^^^^^^^^^^^^
or if the resolver's symbol has a different name from the ifunc (as is
the case with modern uses of ifunc via __attribute__ ifunc, such as
glibc uses):
(gdb) p gnu_ifunc (3)
$1 = 4
(gdb) PASS: gdb.base/gnu-ifunc.exp: resolver_attr=1: resolver_debug=1: resolved_debug=0: p gnu_ifunc (3)
^^^^^^^^^^^^^^^
in which case after this patch, you can still call the resolver
directly if you want:
(gdb) p gnu_ifunc_resolver (3)
$1 = (int (*)(int)) 0x400753 <final>
gdb/ChangeLog:
2018-04-26 Pedro Alves <palves@redhat.com>
* c-exp.y (variable production): Prefer ifunc minsyms over
regular function symbols.
* symtab.c (find_gnu_ifunc): New function.
* minsyms.h (lookup_msym_prefer): New enum.
(lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
parameter by a lookup_msym_prefer parameter.
* symtab.h (find_gnu_ifunc): New declaration.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix setting breakpoints on ifunc functions after they're already resolved
@ 2018-04-26 14:53 sergiodj+buildbot
2018-04-27 23:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 14:53 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 3467ec66bc1f30cf3ed7f9fe75234c96fc9c92d5 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 3467ec66bc1f30cf3ed7f9fe75234c96fc9c92d5
Fix setting breakpoints on ifunc functions after they're already resolved
This fixes setting breakpoints on ifunc functions by name after the
ifunc has already been resolved.
In that case, if you have debug info for the ifunc resolver, without
the fix, then gdb puts a breakpoint past the prologue of the resolver,
instead of setting a breakpoint at the ifunc target:
break gnu_ifunc
Breakpoint 4 at 0x7ffff7bd36f2: file src/gdb/testsuite/gdb.base/gnu-ifunc-lib.c, line 34.
(gdb) continue
Continuing.
[Inferior 1 (process 13300) exited normally]
(gdb)
above we should have stopped at "final", but didn't because we never
resolved the ifunc to the final location.
If you don't have debug info for the resolver, GDB manages to resolve
the ifunc target, but, it should be setting a breakpoint after the
prologue of the final function, and instead what you get is that GDB
sets a breakpoint on the first address of the target function. With
the gnu-ifunc.exp tests added by a later patch, we get, without the
fix:
(gdb) break gnu_ifunc
Breakpoint 4 at 0x400753
(gdb) continue
Continuing.
Breakpoint 4, final (arg=1) at src/gdb/testsuite/gdb.base/gnu-ifunc-final.c:20
20 {
vs, fixed:
(gdb) break gnu_ifunc
Breakpoint 4 at 0x40075a: file src/gdb/testsuite/gdb.base/gnu-ifunc-final.c, line 21.
(gdb) continue
Continuing.
Breakpoint 4, final (arg=2) at src/gdb/testsuite/gdb.base/gnu-ifunc-final.c:21
21 return arg + 1;
(gdb)
Fix the problems above by moving the ifunc target resolving to
linespec.c, before we skip a function's prologue. We need to save
something in the sal, so that set_breakpoint_location_function knows
that it needs to create a bp_gnu_ifunc_resolver bp_location. Might as
well just save a pointer to the minsym.
gdb/ChangeLog:
2018-04-26 Pedro Alves <palves@redhat.com>
* breakpoint.c (set_breakpoint_location_function): Don't resolve
ifunc targets here. Instead, if we have an ifunc minsym, use its
address/name.
(add_location_to_breakpoint): Store the minsym and the objfile in
the breakpoint location.
* breakpoint.h (bp_location) <msymbol, objfile>: New fields.
* linespec.c (minsym_found): Resolve GNU ifunc targets here.
Record the minsym in the sal.
* symtab.h (symtab_and_line) <msymbol>: New field.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Breakpoints, don't skip prologue of ifunc resolvers with debug info
@ 2018-04-26 15:18 sergiodj+buildbot
2018-04-28 1:42 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 15:18 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 76af0f26356580771a18c37de4ebccdfbc449356 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 76af0f26356580771a18c37de4ebccdfbc449356
Breakpoints, don't skip prologue of ifunc resolvers with debug info
Without this patch, some of the tests added to gdb.base/gnu-ifunc.exp
by a following patch fail like so:
FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=1: resolved_debug=0: set-break: before resolving: break gnu_ifunc
FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=1: resolved_debug=0: set-break: before resolving: info breakpoints
FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=1: resolved_debug=0: set-break: after resolving: break gnu_ifunc
FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=1: resolved_debug=0: set-break: after resolving: info breakpoints
FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=1: resolved_debug=1: set-break: before resolving: break gnu_ifunc
FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=1: resolved_debug=1: set-break: before resolving: info breakpoints
FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=1: resolved_debug=1: set-break: after resolving: break gnu_ifunc
FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=1: resolved_debug=1: set-break: after resolving: info breakpoints
All of them trigger iff:
- you have debug info for the ifunc resolver.
- the resolver and the user-visible symbol have the same name.
If you have an ifunc that has a resolver with the same name as the
user visible symbol, debug info for the resolver masks out the ifunc
minsym. When you set a breakpoint by name on the user visible symbol,
GDB finds the DWARF symbol for the resolver, and thinking that it's a
regular function, sets a breakpoint location past its prologue.
Like so, location 1.2, before the ifunc is resolved by the inferior:
(gdb) break gnu_ifunc
Breakpoint 2 at 0x7ffff7bd36ea (2 locations)
(gdb) info breakpoints
Num Type Disp Enb Address What
1 breakpoint keep y <MULTIPLE>
1.1 y 0x00007ffff7bd36ea <gnu_ifunc>
1.2 y 0x00007ffff7bd36f2 in gnu_ifunc at src/gdb/testsuite/gdb.base/gnu-ifunc-lib.c:34
(gdb)
And like so, location 2.2, if you set the breakpoint after the ifunc
is resolved by the inferior (to "final"):
(gdb) break gnu_ifunc
Breakpoint 5 at 0x400757 (2 locations)
(gdb) info breakpoints
Num Type Disp Enb Address What
2 breakpoint keep y <MULTIPLE>
2.1 y 0x000000000040075a in final at src/gdb/testsuite/gdb.base/gnu-ifunc-resd.c:21
2.2 y 0x00007ffff7bd36f2 in gnu_ifunc at src/gdb/testsuite/gdb.base/gnu-ifunc-lib.c:34
(gdb)
I don't think this is right because when users set a breakpoint at an
ifunc, they don't care about debugging the resolver. Instead what you
should is a single location for the ifunc in the first case, and a
single location of the ifunc target in the second case.
gdb/ChangeLog:
2018-04-26 Pedro Alves <palves@redhat.com>
* linespec.c (struct bound_minimal_symbol_search_key): New.
(convert_linespec_to_sals): Sort minimal symbols earlier. Don't
skip first line if we found a GNU ifunc minimal symbol by name.
(compare_msymbols): Change parameters to work with a destructured
lhs minsym.
(compare_msymbols_for_qsort, compare_msymbols_for_bsearch): New
functions.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Factor out minsym_found/find_function_start_sal overload
@ 2018-04-26 16:07 sergiodj+buildbot
2018-04-28 7:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 16:07 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 42ddae103c9eb20fb87378548ee95b4bd23648a5 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 42ddae103c9eb20fb87378548ee95b4bd23648a5
Factor out minsym_found/find_function_start_sal overload
I need to make the ifunc resolving code in elfread.c skip the target
function's prologue like minsym_found does. I thought of factoring
that out to a separate function, but turns out there's already a
comment in find_function_start_sal that says that should agree with
minsym_found...
Instead of making sure the code agrees with a comment, factor out the
common code to a separate function and use it from both places.
Note that the current find_function_start_sal does a bit more than
minsym_found's equivalent (the "We always should ..." bit), though
that's probably a latent bug.
gdb/ChangeLog:
2018-04-26 Pedro Alves <palves@redhat.com>
* linespec.c (minsym_found): Use find_function_start_sal CORE_ADDR
overload.
* symtab.c (find_function_start_sal(CORE_ADDR, obj_section *,bool)):
New, factored out from ...
(find_function_start_sal(symbol *, int)): ... this. Reimplement
and use bool.
* symtab.h (find_function_start_sal(CORE_ADDR, obj_section *,bool)):
New.
(find_function_start_sal(symbol *, int)): Change boolean parameter
type to bool.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] For PPC64: elf_gnu_ifunc_record_cache: handle plt symbols in .text section
@ 2018-04-26 16:34 sergiodj+buildbot
2018-04-28 9:44 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 16:34 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 1adeb822668d3bd7182ca9b8cf42a7261deb3c7f ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 1adeb822668d3bd7182ca9b8cf42a7261deb3c7f
For PPC64: elf_gnu_ifunc_record_cache: handle plt symbols in .text section
elf_gnu_ifunc_record_cache doesn't ever record anything on PPC64
(tested on gcc110 on the compile farm, CentOS 7.4, ELFv1), because
that expects to find PLT symbols in the .plt section, while there we
get:
(gdb) info symbol 'gnu_ifunc@plt'
gnu_ifunc@plt in section .text
^^^^^
I guess that may be related to the comment in ppc-linux-tdep.c that
says "For secure PLT, stub is in .text".
In any case, this commit fixes the issue by making the function look
at the symbol name instead of at the section.
gdb/ChangeLog:
2018-04-26 Pedro Alves <palves@redhat.com>
* elfread.c (elf_gnu_ifunc_record_cache): Check if the symbol name
ends in "@plt" instead of looking at the symbol's section.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix stepping past GNU ifunc resolvers (introduce lookup_msym_prefer)
@ 2018-04-26 17:15 sergiodj+buildbot
2018-04-28 12:25 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 17:15 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 20944a6e20324cd897bf6c4c5fd20ef7224dacaa ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 20944a6e20324cd897bf6c4c5fd20ef7224dacaa
Fix stepping past GNU ifunc resolvers (introduce lookup_msym_prefer)
When we're stepping (with "step"), we want to skip trampoline-like
functions automatically, including GNU ifunc resolvers. That is done
by infrun.c calling into:
in_solib_dynsym_resolve_code
-> svr4_in_dynsym_resolve_code
-> in_gnu_ifunc_stub
A problem here is that if there's a regular text symbol at the same
address as the ifunc symbol, the minimal symbol lookup in
in_gnu_ifunc_stub may miss the GNU ifunc symbol:
(...)
41: 000000000000071a 53 FUNC GLOBAL DEFAULT 11 gnu_ifunc_resolver
(...)
50: 000000000000071a 53 IFUNC GLOBAL DEFAULT 11 gnu_ifunc
(...)
This causes this FAIL in the tests added later in the series:
(gdb) PASS: gdb.base/gnu-ifunc.exp: resolver_attr=1: resolver_debug=0: final_debug=0: resolver received HWCAP
set step-mode on
(gdb) PASS: gdb.base/gnu-ifunc.exp: resolver_attr=1: resolver_debug=0: final_debug=0: set step-mode on
step
0x00007ffff7bd371a in gnu_ifunc_resolver () from build/gdb/testsuite/outputs/gdb.base/gnu-ifunc/gnu-ifunc-lib-1-0-0.so
(gdb) FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=1: resolver_debug=0: final_debug=0: step
Above, GDB simply thought that it stepped into a regular function, so
it stopped stepping, while it should have continued stepping past the
resolver.
The fix is to teach minimal symbol lookup to prefer GNU ifunc symbols
if desired.
gdb/ChangeLog:
2018-04-26 Pedro Alves <palves@redhat.com>
* minsyms.c (lookup_minimal_symbol_by_pc_section_1): Rename to ...
(lookup_minimal_symbol_by_pc_section): ... this. Replace
'want_trampoline' parameter by a lookup_msym_prefer parameter.
Handle it.
(lookup_minimal_symbol_by_pc_section): Delete old implementation.
(lookup_minimal_symbol_by_pc): Adjust.
(in_gnu_ifunc_stub): Prefer GNU ifunc symbols.
(lookup_solib_trampoline_symbol_by_pc): Adjust.
* minsyms.h (lookup_msym_prefer): New enum.
(lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
parameter by a lookup_msym_prefer parameter.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PPC64: always make synthetic .text symbols for GNU ifunc symbols
@ 2018-04-26 18:05 sergiodj+buildbot
2018-04-28 18:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 18:05 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT bfa5bd2ab31a8abb23cb442d51fe6c3836028880 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: bfa5bd2ab31a8abb23cb442d51fe6c3836028880
PPC64: always make synthetic .text symbols for GNU ifunc symbols
If you create an ifunc using GCC's __attribute__ ifunc, like:
extern int gnu_ifunc (int arg);
static int gnu_ifunc_target (int arg) { return 0; }
__typeof (gnu_ifunc) *gnu_ifunc_resolver (unsigned long hwcap) { return gnu_ifunc_target; }
__typeof (gnu_ifunc) gnu_ifunc __attribute__ ((ifunc ("gnu_ifunc_resolver")));
then you end up with two (function descriptor) symbols, one for the
ifunc itself, and another for the resolver:
(...)
12: 0000000000020060 104 FUNC GLOBAL DEFAULT 18 gnu_ifunc_resolver
(...)
16: 0000000000020060 104 GNU_IFUNC GLOBAL DEFAULT 18 gnu_ifunc
(...)
Both ifunc and resolver symbols have the same address/value, so
ppc64_elf_get_synthetic_symtab only creates a synthetic text symbol
for one of them. In the case above, it ends up being created for the
resolver, only:
(gdb) maint print msymbols
(...)
[ 7] t 0x980 .frame_dummy section .text
[ 8] T 0x9e4 .gnu_ifunc_resolver section .text
[ 9] T 0xa58 __glink_PLTresolve section .text
(...)
GDB needs to know when a program stepped into an ifunc resolver, so
that it can know whether to step past the resolver into the target
function without the user noticing. The way GDB does it is my
checking whether the current PC points to an ifunc symbol (since
resolver and ifunc have the same address by design).
The problem is then that ppc64_elf_get_synthetic_symtab never creates
the synchetic symbol for the ifunc, so GDB stops stepping at the
resolver (in a test added by the following patch):
(gdb) step
gnu_ifunc_resolver (hwcap=21) at gdb/testsuite/gdb.base/gnu-ifunc-lib.c:33
33 {
(gdb) FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=1: resolver_debug=1: final_debug=0: step
After this commit, we get:
[ 8] i 0x9e4 .gnu_ifunc section .text
[ 9] T 0x9e4 .gnu_ifunc_resolver section .text
And stepping an ifunc call takes to the final function:
(gdb) step
0x00000000100009e8 in .final ()
(gdb) PASS: gdb.base/gnu-ifunc.exp: resolver_attr=1: resolver_debug=1: final_debug=0: step
An alternative to touching bfd I considered was for GDB to check
whether there's an ifunc data symbol / function descriptor that points
to the current PC, whenever the program stops, but discarded it
because we'd have to do a linear scan over .opd over an over to find a
matching function descriptor for the current PC. At that point I
considered caching that info, but quickly dismissed it as then that
has no advantage (memory or performance) over just creating the
synthetic ifunc text symbol in the first place.
I ran the binutils and ld testsuites on PPC64 ELFv1 (machine gcc110 on
the GCC compile farm), and saw no regressions. This commit is part of
a GDB patch series that includes GDB tests that fail without this fix.
bfd/ChangeLog:
2018-04-26 Pedro Alves <palves@redhat.com>
* elf64-ppc.c (ppc64_elf_get_synthetic_symtab): Don't consider
ifunc and non-ifunc symbols duplicates.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Extend GNU ifunc testcases
@ 2018-04-26 18:42 sergiodj+buildbot
2018-04-28 21:21 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 18:42 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT c7075ad5030c4c2e79a04f3517689b751ff41860 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: c7075ad5030c4c2e79a04f3517689b751ff41860
Extend GNU ifunc testcases
This patch extends/rewrites the gdb.base/gnu-ifunc.exp testcase to
cover the many different fixes in earlier patches. (This was actually
what encovered most of the problems.)
The current testcase uses an ifunc symbol with the same name as the
ifunc resolver symbol and makes sure to compile the ifunc resolver
without debug info. That does not model how ifuncs are implemented in
gcc/ifunc nowadays. Instead, what we have is that the glibc ifunc
resolvers nowadays are written in C and end up with debug info.
Also, in some cases the ifunc target is written in assembly, but in
other cases it's written in C. In the case of target function written
in C, if the target function has debug info, when we set a break on
the ifunc, we want to set it past the prologue of the target function.
Currently GDB gets that wrong.
To make sure we cover all the different scenarios, the testcase is
tweaked to cover all the different combinations of
- An ifunc resolver with the same name as the user-visible symbol vs
an ifunc resolver with a different name as the user-visible symbol.
- ifunc resolver compiled with and without debug info.
- ifunc target function compiled with and without debug info.
The testcase currently sets breakpoints on ifuncs, calls ifunc
functions, steps into ifunc functions, etc. After this series, this
all works and the testcase passes cleanly.
While working on this, I noticed that "b gnu_ifunc" before and after
the inferior resolved the ifunc would end up with a breakpoint with
different locations. That's now covered by new tests inside the new
"set-break" procedure.
It also tests other things like making sure we can't call an ifunc
without a return-type case if we don't know the type of the target.
And making sure that we pass enough arguments when we do know the
type.
gdb/testsuite/ChangeLog:
2018-04-26 Pedro Alves <palves@redhat.com>
* gdb.base/gnu-ifunc-final.c: New file.
* gdb.base/gnu-ifunc.c (final): Delete, moved to gnu-ifunc-final.c.
* gdb.base/gnu-ifunc.exp (executable): Delete.
(staticexecutable): Adjust.
(lib_opts, exec_opts): Delete.
(make_binsuffix, build, set-break): New procedures.
(misc_tests): New, with tests factored out from the top level.
(top level): Test different combinations of ifunc resolver name,
resolver with and with debug info, and ifunc target with and
without debug info. Wrap static tests with with_target_prefix.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix resolving GNU ifunc bp locations when inferior runs resolver
@ 2018-04-26 19:45 sergiodj+buildbot
2018-04-28 23:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 19:45 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 79188d8d27a8885aee2ca4ff55238219a6aa7228 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 79188d8d27a8885aee2ca4ff55238219a6aa7228
Fix resolving GNU ifunc bp locations when inferior runs resolver
I noticed that if you set a breakpoint on an ifunc before the ifunc is
resolved, and then let the program call the ifunc, thus resolving it,
GDB end up with a location for that original breakpoint that is
pointing to the ifunc target, but it is left pointing to the first
address of the function, instead of after its prologue. After
prologue is what you get if you create a new breakpoint at that point.
1) With no debug info for the target function:
1.a) Set before resolving, and then program continued passed resolving:
Num Type Disp Enb Address What
1 breakpoint keep y 0x0000000000400753 <final>
1.b) Breakpoint set after inferior resolved ifunc:
Num Type Disp Enb Address What
2 breakpoint keep y 0x0000000000400757 <final+4>
2) With debug info for the target function:
1.a) Set before resolving, and then program continued passed resolving:
Num Type Disp Enb Address What
1 breakpoint keep y 0x0000000000400753 in final at gdb/testsuite/gdb.base/gnu-ifunc-final.c:20
1.b) Breakpoint set after inferior resolved ifunc:
Num Type Disp Enb Address What
2 breakpoint keep y 0x000000000040075a in final at gdb/testsuite/gdb.base/gnu-ifunc-final.c:21
The problem is that elf_gnu_ifunc_resolver_return_stop (called by the
internal breakpoint that traps the resolver returning) does not agree
with linespec.c:minsym_found. It does not skip to the function's
start line (i.e., past the prologue). We can now use the
find_function_start_sal overload added by the previous commmit to fix
this.
New tests included, which fail before the patch, and pass afterwards.
gdb/ChangeLog:
2018-04-26 Pedro Alves <palves@redhat.com>
* elfread.c (elf_gnu_ifunc_resolver_return_stop): Use
find_function_start_sal instead of find_pc_line.
gdb/testsuite/ChangeLog:
2018-04-26 Pedro Alves <palves@redhat.com>
* gdb.base/gnu-ifunc.exp (set-break): Test that GDB resolves
ifunc breakpoint locations correctly of ifunc breakpoints set
while the program resolves the ifunc.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Enable Intel MOVDIRI, MOVDIR64B instructions.
@ 2018-04-26 22:02 sergiodj+buildbot
2018-04-29 1:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 22:02 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a914a7c95895161c99533d5919b8504b37ea54a0 ***
Author: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
Branch: master
Commit: a914a7c95895161c99533d5919b8504b37ea54a0
Enable Intel MOVDIRI, MOVDIR64B instructions.
gas/
* config/tc-i386.c (cpu_arch): Add .movdir, .movdir64b.
(cpu_noarch): Likewise.
(process_suffix): Add check for register size.
* doc/c-i386.texi: Document movdiri, movdir64b.
* testsuite/gas/i386/i386.exp: Run MOVDIR{I,64B} tests.
* testsuite/gas/i386/movdir-intel.d: New test.
* testsuite/gas/i386/movdir.d: Likewise.
* testsuite/gas/i386/movdir.s: Likewise.
* testsuite/gas/i386/movdir64b-reg.s: Likewise.
* testsuite/gas/i386/movdir64b-reg.l: Likewise.
* testsuite/gas/i386/x86-64-movdir-intel.d: Likewise.
* testsuite/gas/i386/x86-64-movdir.d: Likewise.
* testsuite/gas/i386/x86-64-movdir.s: Likewise.
* testsuite/gas/i386/x86-64-movdir64b-reg.s: Likewise.
* testsuite/gas/i386/x86-64-movdir64b-reg.l: Likewise.
opcodes/
* i386-dis.c (enum): Add PREFIX_0F38F8, PREFIX_0F38F9.
(prefix_table): New instructions (see prefix above).
Add Gva macro and handling in OP_G.
* i386-gen.c (cpu_flag_init): Add CPU_MOVDIRI_FLAGS,
CPU_MOVDIR64B_FLAGS.
(cpu_flags): Likewise.
(opcode_modifiers): Add AddrPrefixOpReg.
(i386_opcode_modifier): Likewise.
* i386-opc.h (enum): Add CpuMOVDIRI, CpuMOVDIR64B.
(i386_cpu_flags): Likewise.
* i386-opc.tbl: Add movidir{i,64b}.
* i386-init.h: Regenerate.
* i386-tbl.h: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix remote 'g' command error handling (PR remote/9665)
@ 2018-04-26 23:25 sergiodj+buildbot
2018-04-29 4:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 23:25 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b75abf5bb636869fd893ecf98414b8b2fe0d4a12 ***
Author: Andrzej Kaczmarek <andrzej.kaczmarek@codecoup.pl>
Branch: master
Commit: b75abf5bb636869fd893ecf98414b8b2fe0d4a12
Fix remote 'g' command error handling (PR remote/9665)
'g' command returns hex-string as response so simply checking for 'E'
to determine if it failed is not enough and can trigger spurious error
messages. For example, invalid behaviour can be easily triggered on
Cortex-M as follows:
(gdb) set $r0 = 0xe0
Sending packet: $P0=e0000000#72...Packet received: OK
Packet P (set-register) is supported
Sending packet: $g#67...Packet received: E0000000849A0020...
Remote failure reply: E0000000849A0020...
This patch fixes the problem by calling putpkt()/getpkt() directly and
checking result with packet_check_result(). This works fine since Enn
response has odd number of bytes while proper response has even number
of bytes.
Also, remote_send() is now not used anywhere so it can be removed.
gdb/Changelog:
2018-04-26 Andrzej Kaczmarek <andrzej.kaczmarek@codecoup.pl>
PR remote/9665
* remote.c (send_g_packet): Use putpkt/getpkt/packet_check_result
instead of remote_send.
(remote_send): Remove.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR23123, PowerPC32 ifunc regression
@ 2018-04-27 9:52 sergiodj+buildbot
2018-04-29 7:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-27 9:52 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 04383fd15b3b82d824df9c72e3ade88c43bfb5ac ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 04383fd15b3b82d824df9c72e3ade88c43bfb5ac
PR23123, PowerPC32 ifunc regression
Two of the gcc ifunc tests fail for ppc32, due to my pr22374 fix being
a little too enthusiastic in trimming PLT entries. ppc64 doesn't have
the same failures because ppc64_elf_check_relocs happens to set
needs_plt for any ifunc reloc.
PR 23123
PR 22374
* elf32-ppc.c (ppc_elf_adjust_dynamic_symbol): Don't drop plt
relocs for ifuncs.
* elf64-ppc.c (ppc64_elf_adjust_dynamic_symbol): Comment fixes.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Regenerate some files for recent ARM patches
@ 2018-04-27 11:12 sergiodj+buildbot
2018-04-29 10:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-27 11:12 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ffa389a39655f4b35d583783e49fa5b31c288e8f ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: ffa389a39655f4b35d583783e49fa5b31c288e8f
Regenerate some files for recent ARM patches
bfd/
* bfd-in2.h: Regenerate.
* libbfd.h: Regenerate.
ld/
* po/BLD-POTFILES.in: Regenerate.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Enable -Wsuggest-override
@ 2018-04-27 19:21 sergiodj+buildbot
2018-04-29 15:33 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-27 19:21 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 632e107b32c0fe8aede62e070b00756e9fdd2c01 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 632e107b32c0fe8aede62e070b00756e9fdd2c01
Enable -Wsuggest-override
I noticed the existence of -Wsuggest-override and so this patch
enables it for gdb. It found a few spots that could use "override".
Also I went ahead and removed all uses of the "OVERRIDE" macro.
Using override is beneficial because it makes it harder to change a
base class and then forget to change a derived class.
Tested by the buildbot.
ChangeLog
2018-04-27 Tom Tromey <tom@tromey.com>
* configure: Rebuild.
* warning.m4 (AM_GDB_WARNINGS): Add -Wsuggest-override.
* dwarf2loc.c (class dwarf_evaluate_loc_desc): Use "override", not
"OVERRIDE".
(class symbol_needs_eval_context): Likewise.
* dwarf2read.c (mock_mapped_index::symbol_name_count)
(mock_mapped_index::symbol_name_at): Use "override". Remove
"virtual".
* dwarf2-frame.c (dwarf_expr_executor::get_addr_index): Use
"override".
(class dwarf_expr_executor): Use "override", not "OVERRIDE".
* aarch64-tdep.c (instruction_reader::read): Use "override".
(instruction_reader_test::read): Likewise.
* arm-tdep.c (instruction_reader::read): Use "override".
(instruction_reader_thumb::read): Likewise.
gdbserver/ChangeLog
2018-04-27 Tom Tromey <tom@tromey.com>
* configure: Rebuild.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add inclusive range support for Rust
@ 2018-04-27 20:09 sergiodj+buildbot
2018-04-29 17:41 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-27 20:09 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 6873858b7e464e114f9a877e216949ad8350b4cf ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 6873858b7e464e114f9a877e216949ad8350b4cf
Add inclusive range support for Rust
This is version 2 of the patch to add inclusive range support for
Rust. I believe it addresses all review comments.
Rust recently stabilized the inclusive range feature:
https://github.com/rust-lang/rust/issues/28237
An inclusive range is an expression like "..= EXPR" or "EXPR ..=
EXPR". It is like an ordinary range, except the upper bound is
inclusive, not exclusive.
This patch adds support for this feature to gdb.
Regression tested on x86-64 Fedora 27.
2018-04-27 Tom Tromey <tom@tromey.com>
PR rust/22545:
* rust-lang.c (rust_inclusive_range_type_p): New function.
(rust_range): Handle inclusive ranges.
(rust_compute_range): Likewise.
* rust-exp.y (struct rust_op) <inclusive>: New field.
(DOTDOTEQ): New constant.
(range_expr): Add "..=" productions.
(operator_tokens): Add "..=" token.
(ast_range): Add "inclusive" parameter.
(convert_ast_to_expression) <case OP_RANGE>: Handle inclusive
ranges.
* parse.c (operator_length_standard) <case OP_RANGE>: Handle new
bounds values.
* expression.h (enum range_type) <NONE_BOUND_DEFAULT_EXCLUSIVE,
LOW_BOUND_DEFAULT_EXCLUSIVE>: New constants.
Update comments.
* expprint.c (print_subexp_standard): Handle new bounds values.
(dump_subexp_body_standard): Likewise.
2018-04-27 Tom Tromey <tom@tromey.com>
PR rust/22545:
* gdb.rust/simple.exp: Add inclusive range tests.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix race when building ada-lex.c
@ 2018-04-29 16:18 sergiodj+buildbot
2018-04-30 5:06 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-29 16:18 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT cd8c76e410a5f16a170cc680be1ae2ecb5528821 ***
Author: John Reiser <jreiser@BitWagon.com>
Branch: master
Commit: cd8c76e410a5f16a170cc680be1ae2ecb5528821
Fix race when building ada-lex.c
Prevent a race when building ada-lex.c, and any target of rules .c:.l or
.c:.y. The target should be written only at the last step, else SIGINT
(^C) can leave an inconsistent state. Being .PRECIOUS makes it even
worse.
gdb/ChangeLog:
PR build/22873
* gdb/Makefile.in: (.c:.l, .c:.y): Write the target only in the
last step, and do it atomically.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] proc-events.c: fix compilation on Solaris
@ 2018-04-29 16:52 sergiodj+buildbot
2018-04-30 7:55 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-29 16:52 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e28b63a989caffa4a6fba1aaf0d8992b37d13da8 ***
Author: Fabian Groffen <grobian@gentoo.org>
Branch: master
Commit: e28b63a989caffa4a6fba1aaf0d8992b37d13da8
proc-events.c: fix compilation on Solaris
This patch adds a guard around the usage of SYS_uuidsys, which is
not available on (at least) Solaris 10 and OpenIndiana.
gdb/ChangeLog:
PR gdb/22950
* proc-events.c (init_syscall_table): Guard usage os SYS_uuidsys
with #ifdef.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Use bool in read_index_from_section
@ 2018-04-30 15:27 sergiodj+buildbot
2018-04-30 17:32 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-30 15:27 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d33bc52e51fdb6c464c1c8e8fdf9b2007b522b57 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: d33bc52e51fdb6c464c1c8e8fdf9b2007b522b57
Use bool in read_index_from_section
gdb/ChangeLog:
* dwarf2read.c (read_index_from_section): Use bool.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add initial type alignment support
@ 2018-04-30 17:32 sergiodj+buildbot
2018-04-30 21:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-30 17:32 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2b4424c35b9ebabaab8588b2ba6c38935a48efec ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 2b4424c35b9ebabaab8588b2ba6c38935a48efec
Add initial type alignment support
This adds some basic type alignment support to gdb. It changes struct
type to store the alignment, and updates dwarf2read.c to handle
DW_AT_alignment. It also adds a new gdbarch method and updates
i386-tdep.c.
None of this new functionality is used anywhere yet, so tests will
wait until the next patch.
2018-04-30 Tom Tromey <tom@tromey.com>
* i386-tdep.c (i386_type_align): New function.
(i386_gdbarch_init): Update.
* gdbarch.sh (type_align): New method.
* gdbarch.c, gdbarch.h: Rebuild.
* arch-utils.h (default_type_align): Declare.
* arch-utils.c (default_type_align): New function.
* gdbtypes.h (TYPE_ALIGN_BITS): New define.
(struct type) <align_log2>: New field.
<instance_flags>: Now a bitfield.
(TYPE_RAW_ALIGN): New macro.
(type_align, type_raw_align, set_type_align): Declare.
* gdbtypes.c (type_align, type_raw_align, set_type_align): New
functions.
* dwarf2read.c (quirk_rust_enum): Set type alignment.
(get_alignment, maybe_set_alignment): New functions.
(read_structure_type, read_enumeration_type, read_array_type)
(read_set_type, read_tag_pointer_type, read_tag_reference_type)
(read_subrange_type, read_base_type): Set type alignment.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Handle alignof and _Alignof
@ 2018-04-30 18:19 sergiodj+buildbot
2018-05-01 0:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-30 18:19 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 007e1530347330d4dbba387c4e35aae05bc06498 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 007e1530347330d4dbba387c4e35aae05bc06498
Handle alignof and _Alignof
This adds alignof and _Alignof to the C/C++ expression parser, and
adds new tests to test the features. The tests are written to try to
ensure that gdb's knowledge of alignment rules stays in sync with the
compiler's.
2018-04-30 Tom Tromey <tom@tromey.com>
PR exp/17095:
* NEWS: Update.
* std-operator.def (UNOP_ALIGNOF): New operator.
* expprint.c (dump_subexp_body_standard) <case UNOP_ALIGNOF>:
New.
* eval.c (evaluate_subexp_standard) <case UNOP_ALIGNOF>: New.
* c-lang.c (c_op_print_tab): Add alignof.
* c-exp.y (ALIGNOF): New token.
(exp): Add "ALIGNOF" production.
(ident_tokens): Add _Alignof and alignof.
2018-04-30 Tom Tromey <tom@tromey.com>
PR exp/17095:
* gdb.dwarf2/dw2-align.exp: New file.
* gdb.cp/align.exp: New file.
* gdb.base/align.exp: New file.
* lib/gdb.exp (gdb_int128_helper): New proc.
(has_int128_c, has_int128_cxx): New caching procs.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Expose type alignment on gdb.Type
@ 2018-04-30 19:20 sergiodj+buildbot
2018-05-01 3:06 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-30 19:20 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 6d7bb8246b3beaf60ea9c2abe183705e876519cd ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 6d7bb8246b3beaf60ea9c2abe183705e876519cd
Expose type alignment on gdb.Type
This adds an "alignof" attribute to gdb.Type in the Python API.
2018-04-30 Tom Tromey <tom@tromey.com>
* NEWS: Mention Type.align.
* python/py-type.c (typy_get_alignof): New function.
(type_object_getset): Add "alignof".
2018-04-30 Tom Tromey <tom@tromey.com>
* python.texi (Types In Python): Document Type.align.
2018-04-30 Tom Tromey <tom@tromey.com>
* gdb.python/py-type.exp: Check align attribute.
* gdb.python/py-type.c: New "aligncheck" global.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove rust_type_alignment
@ 2018-04-30 20:28 sergiodj+buildbot
2018-05-01 7:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-30 20:28 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2fff16dd8c25831fb5fbf198ca86d5befff629be ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 2fff16dd8c25831fb5fbf198ca86d5befff629be
Remove rust_type_alignment
rust_type_alignment is not needed now that gdb has type alignment
code. So, this removes it.
2018-04-30 Tom Tromey <tom@tromey.com>
* rust-lang.c (rust_type_alignment): Remove.
(rust_composite_type): Use type_align.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove long_long_align_bit gdbarch attribute
@ 2018-04-30 20:51 sergiodj+buildbot
2018-05-01 11:08 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-30 20:51 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e11fb955fbab035748fa53ffc30c103157a284b6 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: e11fb955fbab035748fa53ffc30c103157a284b6
Remove long_long_align_bit gdbarch attribute
This removes the long_long_align_bit gdbarch attribute in favor of
type_align. This uncovered two possible issues.
First, arc-tdep.c claimed that long long alignment was 32 bits, but as
discussed on the list, ARC has a maximum alignment of 32 bits, so I've
added an arc_type_align function to account for this.
Second, jit.c, the sole user of long_long_align_bit, was confusing
"long long" with uint64_t. The relevant structure is defined in the
JIT API part of the manual as:
struct jit_code_entry
{
struct jit_code_entry *next_entry;
struct jit_code_entry *prev_entry;
const char *symfile_addr;
uint64_t symfile_size;
};
I've changed this code to use uint64_t.
2018-04-30 Tom Tromey <tom@tromey.com>
* jit.c (jit_read_code_entry): Use type_align.
* i386-tdep.c (i386_gdbarch_init): Don't call
set_gdbarch_long_long_align_bit.
* gdbarch.sh: Remove long_long_align_bit.
* gdbarch.c, gdbarch.h: Rebuild.
* arc-tdep.c (arc_type_align): New function.
(arc_gdbarch_init): Use arc_type_align. Don't call
set_gdbarch_long_long_align_bit.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove new_bfd_ref
@ 2018-04-30 21:37 sergiodj+buildbot
2018-05-01 15:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-30 21:37 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 1831a9f9d3346dbf61202d2aba6935f0093487dd ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 1831a9f9d3346dbf61202d2aba6935f0093487dd
Remove new_bfd_ref
For gdb_bfd_ref_ptr, gdb already had a convenience function like the
new gdb_ref_ptr::new_reference -- called new_bfd_ref. This patch
removes it in favor of the new common function.
While doing this I also noticed that the comment for gdb_bfd_open was
incorrect (in a way related to reference counting), so this patch
updates the comment as well.
ChangeLog
2018-04-30 Tom Tromey <tom@tromey.com>
* symfile-mem.c (symbol_file_add_from_memory): Use new_reference.
* gdb_bfd.h (new_bfd_ref): Remove.
(gdb_bfd_open): Update comment.
* gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
(gdb_bfd_openw, gdb_bfd_openr_iovec, gdb_bfd_record_inclusion)
(gdb_bfd_fdopenr): Use new_reference.
* exec.c (exec_file_attach): Use new_reference.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Introduce ref_ptr::new_reference
@ 2018-04-30 21:46 sergiodj+buildbot
2018-05-01 13:22 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-30 21:46 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 7c1b5f3db73d7ecab03dc4e866e291582935fb04 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 7c1b5f3db73d7ecab03dc4e866e291582935fb04
Introduce ref_ptr::new_reference
I noticed a common pattern with gdb::ref_ptr, where callers would
"incref" and then create a new wrapper object, like:
Py_INCREF (obj);
gdbpy_ref<> ref (obj);
The ref_ptr constructor intentionally does not acquire a new
reference, but it seemed to me that it would be reasonable to add a
static member function that does so.
In this patch I chose to call the function "new_reference". I
considered "acquire_reference" as well, but "new" seemed less
ambiguous than "acquire" to me.
ChangeLog
2018-04-30 Tom Tromey <tom@tromey.com>
* common/gdb_ref_ptr.h (ref_ptr::new_reference): New static
method.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove some uses of is_mi_like_p from py-framefilter.c
@ 2018-04-30 23:38 sergiodj+buildbot
2018-05-02 2:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-04-30 23:38 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2038b7fdf30c39bc4d528cc2e5fbf5403e0ba79e ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 2038b7fdf30c39bc4d528cc2e5fbf5403e0ba79e
Remove some uses of is_mi_like_p from py-framefilter.c
Some uses of is_mi_like_p in py-framefilter.c were not needed. In
general a call to ui_out::text, ui_out::message, or ui_out::spaces
does not need to be guarded -- these are already ignored by MI.
ChangeLog
2018-04-30 Tom Tromey <tom@tromey.com>
* python/py-framefilter.c (py_print_single_arg)
(enumerate_locals, py_print_args, py_print_frame): Remove some
uses of is_mi_like_p.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove a use of is_mi_like_p from tracepoint.c
@ 2018-05-01 0:19 sergiodj+buildbot
2018-05-02 7:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-01 0:19 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f3c6ababac34f3a291997f8d5ea6a63949b58b87 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: f3c6ababac34f3a291997f8d5ea6a63949b58b87
Remove a use of is_mi_like_p from tracepoint.c
This removes a use of is_mi_like_p and changes a printf_filtered into
a call to ui_out::text.
ChangeLog
2018-04-30 Tom Tromey <tom@tromey.com>
* tracepoint.c (tvariables_info_1): Remove use of is_mi_like_p.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove a use of is_mi_like_p from darwin-nat-info.c
@ 2018-05-01 1:23 sergiodj+buildbot
2018-05-02 11:32 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-01 1:23 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 767619365467fd825c6f3906a49d97a7a6afafd6 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 767619365467fd825c6f3906a49d97a7a6afafd6
Remove a use of is_mi_like_p from darwin-nat-info.c
This removes a use of is_mi_like_p from darwin-nat-info.c.
This is not needed because MI already ignores ui_out::text.
ChangeLog
2018-04-30 Tom Tromey <tom@tromey.com>
* darwin-nat-info.c (darwin_debug_regions_recurse): Remove use of
is_mi_like_p.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add the Netronome Flow Processor as a build target to the top-level configure.ac file.
@ 2018-05-01 15:30 sergiodj+buildbot
2018-05-02 17:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-01 15:30 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 1063beb58c9a2f69913682b6923b08e6a7d192aa ***
Author: Francois H. Theron <francois.theron@netronome.com>
Branch: master
Commit: 1063beb58c9a2f69913682b6923b08e6a7d192aa
Add the Netronome Flow Processor as a build target to the top-level configure.ac file.
* configure.ac: Added "nfp" target.
* configure: Regenerate.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix unintialized memory in aarch64 opcodes.
@ 2018-05-01 16:57 sergiodj+buildbot
2018-05-02 22:57 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-01 16:57 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b3ac5c6c286c5b5c1909628e85754edfb403cf1a ***
Author: Tamar Christina <tamar.christina@arm.com>
Branch: master
Commit: b3ac5c6c286c5b5c1909628e85754edfb403cf1a
Fix unintialized memory in aarch64 opcodes.
This patch fixes an issue where the memory for the opcode structure is not zero'd before
the first exit branch. So there is one failure mode for which uninitialized memory
is returned.
This causes weird failures when the return code is not checked before inst is used.
opcodes/
* aarch64-dis.c (aarch64_opcode_decode): Moved memory clear code.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Eliminate procfs.c:procfs_use_watchpoints
@ 2018-05-02 23:59 sergiodj+buildbot
2018-05-03 4:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-02 23:59 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b5c8fcb1b40a61be5015b02e8cf456a56c258b5d ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: b5c8fcb1b40a61be5015b02e8cf456a56c258b5d
Eliminate procfs.c:procfs_use_watchpoints
Now that procfs.c is only ever used by Solaris, and, both x86 and
SPARC Solaris support watchpoints (*), we don't need the separate
procfs_use_watchpoints function. Getting rid of it simplifies
C++ification of target_ops.
(*) and I assume that any other Solaris port would use the same kernel
debug API interfaces for watchpoints. Otherwise, we can worry about
it if it ever happens.
gdb/ChangeLog:
2018-05-02 Pedro Alves <palves@redhat.com>
* procfs.c (procfs_stopped_by_watchpoint)
(procfs_insert_watchpoint, procfs_remove_watchpoint)
(procfs_region_ok_for_hw_watchpoint, procfs_stopped_data_address):
Forward declare.
(procfs_use_watchpoints): Delete, move contents...
(procfs_target): ... here.
* procfs.h (procfs_use_watchpoints): Delete declaration.
* i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
procfs_use_watchpoints.
* sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Don't call
procfs_use_watchpoints.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Convert struct target_ops to C++
@ 2018-05-03 2:19 sergiodj+buildbot
2018-05-03 14:05 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-03 2:19 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f6ac5f3d63e03a81c4ff3749aba234961cc9090e ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: f6ac5f3d63e03a81c4ff3749aba234961cc9090e
Convert struct target_ops to C++
I.e., use C++ virtual methods and inheritance instead of tables of
function pointers.
Unfortunately, there's no way to do a smooth transition. ALL native
targets in the tree must be converted at the same time. I've tested
all I could with cross compilers and with help from GCC compile farm,
but naturally I haven't been able to test many of the ports. Still, I
made a best effort to port everything over, and while I expect some
build problems due to typos and such, which should be trivial to fix,
I don't expect any design problems.
* Implementation notes:
- The flattened current_target is gone. References to current_target
or current_target.beneath are replaced with references to
target_stack (the top of the stack) directly.
- To keep "set debug target" working, this adds a new debug_stratum
layer that sits on top of the stack, prints the debug, and delegates
to the target beneath.
In addition, this makes the shortname and longname properties of
target_ops be virtual methods instead of data fields, and makes the
debug target defer those to the target beneath. This is so that
debug code sprinkled around that does "if (debugtarget) ..." can
transparently print the name of the target beneath.
A patch later in the series actually splits out the
shortname/longname methods to a separate structure, but I preferred
to keep that chance separate as it is associated with changing a bit
the design of how targets are registered and open.
- Since you can't check whether a C++ virtual method is overridden,
the old method of checking whether a target_ops implements a method
by comparing the function pointer must be replaced with something
else.
Some cases are fixed by adding a parallel "can_do_foo" target_ops
methods. E.g.,:
+ for (t = target_stack; t != NULL; t = t->beneath)
{
- if (t->to_create_inferior != NULL)
+ if (t->can_create_inferior ())
break;
}
Others are fixed by changing void return type to bool or int return
type, and have the default implementation return false or -1, to
indicate lack of support.
- make-target-delegates was adjusted to generate C++ classes and
methods.
It needed tweaks to grok "virtual" in front of the target method
name, and for the fact that methods are no longer function pointers.
(In particular, the current code parsing the return type was simple
because it could simply parse up until the '(' in '(*to_foo)'.
It now generates a couple C++ classes that inherit target_ops:
dummy_target and debug_target.
Since we need to generate the class declarations as well, i.e., we
need to emit methods twice, we now generate the code in two passes.
- The core_target global is renamed to avoid conflict with the
"core_target" class.
- ctf/tfile targets
init_tracefile_ops is replaced by a base class that is inherited by
both ctf and tfile.
- bsd-uthread
The bsd_uthread_ops_hack hack is gone. It's not needed because
nothing was extending a target created by bsd_uthread_target.
- remote/extended-remote targets
This is a first pass, just enough to C++ify target_ops.
A later pass will convert more free functions to methods, and make
remote_state be truly per remote instance, allowing multiple
simultaneous instances of remote targets.
- inf-child/"native" is converted to an actual base class
(inf_child_target), that is inherited by all native targets.
- GNU/Linux
The old weird double-target linux_ops mechanism in linux-nat.c, is
gone, replaced by adding a few virtual methods to linux-nat.h's
target_ops, called low_XXX, that the concrete linux-nat
implementations override. Sort of like gdbserver's
linux_target_ops, but simpler, for requiring only one
target_ops-like hierarchy, which spares implementing the same method
twice when we need to forward the method to a low implementation.
The low target simply reimplements the target_ops method directly in
that case.
There are a few remaining linux-nat.c hooks that would be better
converted to low_ methods like above too. E.g.:
linux_nat_set_new_thread (t, x86_linux_new_thread);
linux_nat_set_new_fork (t, x86_linux_new_fork);
linux_nat_set_forget_process
That'll be done in a follow up patch.
- We can no longer use functions like x86_use_watchpoints to install
custom methods on an arbitrary base target.
The patch replaces instances of such a pattern with template mixins.
For example memory_breakpoint_target defined in target.h, or
x86_nat_target in x86-nat.h.
- linux_trad_target, MIPS and Alpha GNU/Linux
The code in the new linux-nat-trad.h/c files which was split off of
inf-ptrace.h/c recently, is converted to a C++ base class, and used
by the MIPS and Alpha GNU/Linux ports.
- BSD targets
The
$architecture x NetBSD/OpenBSD/FreeBSD
support matrix complicates things a bit. There's common BSD target
code, and there's common architecture-specific code shared between
the different BSDs. Currently, all that is stiched together to form
a final target, via the i386bsd_target, x86bsd_target,
fbsd_nat_add_target functions etc.
This introduces new fbsd_nat_target, obsd_nat_target and
nbsd_nat_target classes that serve as base/prototype target for the
corresponding BSD variant.
And introduces generic i386/AMD64 BSD targets, to be used as
template mixin to build a final target. Similarly, a generic SPARC
target is added, used by both BSD and Linux ports.
- bsd_kvm_add_target, BSD libkvm target
I considered making bsd_kvm_supply_pcb a virtual method, and then
have each port inherit bsd_kvm_target and override that method, but
that was resulting in lots of unjustified churn, so I left the
function pointer mechanism alone.
gdb/ChangeLog:
2018-05-02 Pedro Alves <palves@redhat.com>
John Baldwin <jhb@freebsd.org>
* target.h (enum strata) <debug_stratum>: New.
(struct target_ops) <all delegation methods>: Replace by C++
virtual methods, and drop "to_" prefix. All references updated
throughout.
<to_shortname, to_longname, to_doc, to_data,
to_have_steppable_watchpoint, to_have_continuable_watchpoint,
to_has_thread_control, to_attach_no_wait>: Delete, replaced by
virtual methods. All references updated throughout.
<can_attach, supports_terminal_ours, can_create_inferior,
get_thread_control_capabilities, attach_no_wait>: New
virtual methods.
<insert_breakpoint, remove_breakpoint>: Now
TARGET_DEFAULT_NORETURN methods.
<info_proc>: Now returns bool.
<to_magic>: Delete.
(OPS_MAGIC): Delete.
(current_target): Delete. All references replaced by references
to ...
(target_stack): ... this. New.
(target_shortname, target_longname): Adjust.
(target_can_run): Now a function declaration.
(default_child_has_all_memory, default_child_has_memory)
(default_child_has_stack, default_child_has_registers)
(default_child_has_execution): Remove target_ops parameter.
(complete_target_initialization): Delete.
(memory_breakpoint_target): New template class.
(test_target_ops): Refactor as a C++ class with virtual methods.
* make-target-delegates (NAME_PART): Tighten.
(POINTER_PART, CP_SYMBOL): New.
(SIMPLE_RETURN_PART): Reimplement.
(VEC_RETURN_PART): Expect less.
(RETURN_PART, VIRTUAL_PART): New.
(METHOD): Adjust to C++ virtual methods.
(scan_target_h): Remove reference to C99.
(dname): Output "target_ops::" prefix.
(write_function_header): Adjust to output a C++ class method.
(write_declaration): New.
(write_delegator): Adjust to output a C++ class method.
(tdname): Output "dummy_target::" prefix.
(write_tdefault, write_debugmethod): Adjust to output a C++ class
method.
(tdefault_names, debug_names): Delete.
(return_types, tdefaults, styles, argtypes_array): New.
(top level): All methods are delegators.
(print_class): New.
(top level): Print dummy_target and debug_target classes.
* target-delegates.c: Regenerate.
* target-debug.h (target_debug_print_enum_info_proc_what)
(target_debug_print_thread_control_capabilities)
(target_debug_print_thread_info_p): New.
* target.c (dummy_target): Delete.
(the_dummy_target, the_debug_target): New.
(target_stack): Now extern.
(set_targetdebug): Push/unpush debug target.
(default_child_has_all_memory, default_child_has_memory)
(default_child_has_stack, default_child_has_registers)
(default_child_has_execution): Remove target_ops parameter.
(complete_target_initialization): Delete.
(add_target_with_completer): No longer call
complete_target_initialization.
(target_supports_terminal_ours): Use regular delegation.
(update_current_target): Delete.
(push_target): No longer check magic number. Don't call
update_current_target.
(unpush_target): Don't call update_current_target.
(target_is_pushed): No longer check magic number.
(target_require_runnable): Skip for all stratums over
process_stratum.
(target_ops::info_proc): New.
(target_info_proc): Use find_target_at and
find_default_run_target.
(target_supports_disable_randomization): Use regular delegation.
(target_get_osdata): Use find_target_at.
(target_ops::open, target_ops::close, target_ops::can_attach)
(target_ops::attach, target_ops::can_create_inferior)
(target_ops::create_inferior, target_ops::can_run)
(target_can_run): New.
(default_fileio_target): Use regular delegation.
(target_ops::fileio_open, target_ops::fileio_pwrite)
(target_ops::fileio_pread, target_ops::fileio_fstat)
(target_ops::fileio_close, target_ops::fileio_unlink)
(target_ops::fileio_readlink): New.
(target_fileio_open_1, target_fileio_unlink)
(target_fileio_readlink): Always call the target method. Handle
FILEIO_ENOSYS.
(return_zero, return_zero_has_execution): Delete.
(init_dummy_target): Delete.
(dummy_target::dummy_target, dummy_target::shortname)
(dummy_target::longname, dummy_target::doc)
(debug_target::debug_target, debug_target::shortname)
(debug_target::longname, debug_target::doc): New.
(target_supports_delete_record): Use regular delegation.
(setup_target_debug): Delete.
(maintenance_print_target_stack): Skip debug_stratum.
(initialize_targets): Instantiate the_dummy_target and
the_debug_target.
* auxv.c (target_auxv_parse): Remove 'ops' parameter. Adjust to
use target_stack.
(target_auxv_search, fprint_target_auxv): Adjust.
(info_auxv_command): Adjust to use target_stack.
* auxv.h (target_auxv_parse): Remove 'ops' parameter.
* exceptions.c (print_flush): Handle a NULL target_stack.
* regcache.c (target_ops_no_register): Refactor as class with
virtual methods.
* exec.c (exec_target): New class.
(exec_ops): Now an exec_target.
(exec_open, exec_close_1, exec_get_section_table)
(exec_xfer_partial, exec_files_info, exec_has_memory)
(exec_make_note_section): Refactor as exec_target methods.
(exec_file_clear, ignore, exec_remove_breakpoint, init_exec_ops):
Delete.
(exec_target::find_memory_regions): New.
(_initialize_exec): Don't call init_exec_ops.
* gdbcore.h (exec_file_clear): Delete.
* corefile.c (core_target): Delete.
(core_file_command): Adjust.
* corelow.c (core_target): New class.
(the_core_target): New.
(core_close): Remove target_ops parameter.
(core_close_cleanup): Adjust.
(core_target::close): New.
(core_open, core_detach, get_core_registers, core_files_info)
(core_xfer_partial, core_thread_alive, core_read_description)
(core_pid_to_str, core_thread_name, core_has_memory)
(core_has_stack, core_has_registers, core_info_proc): Rework as
core_target methods.
(ignore, core_remove_breakpoint, init_core_ops): Delete.
(_initialize_corelow): Initialize the_core_target.
* gdbcore.h (core_target): Delete.
(the_core_target): New.
* ctf.c: (ctf_target): New class.
(ctf_ops): Now a ctf_target.
(ctf_open, ctf_close, ctf_files_info, ctf_fetch_registers)
(ctf_xfer_partial, ctf_get_trace_state_variable_value)
(ctf_trace_find, ctf_traceframe_info): Refactor as ctf_target
methods.
(init_ctf_ops): Delete.
(_initialize_ctf): Don't call it.
* tracefile-tfile.c (tfile_target): New class.
(tfile_ops): Now a tfile_target.
(tfile_open, tfile_close, tfile_files_info)
(tfile_get_tracepoint_status, tfile_trace_find)
(tfile_fetch_registers, tfile_xfer_partial)
(tfile_get_trace_state_variable_value, tfile_traceframe_info):
Refactor as tfile_target methods.
(tfile_xfer_partial_features): Remove target_ops parameter.
(init_tfile_ops): Delete.
(_initialize_tracefile_tfile): Don't call it.
* tracefile.c (tracefile_has_all_memory, tracefile_has_memory)
(tracefile_has_stack, tracefile_has_registers)
(tracefile_thread_alive, tracefile_get_trace_status): Refactor as
tracefile_target methods.
(init_tracefile_ops): Delete.
(tracefile_target::tracefile_target): New.
* tracefile.h: Include "target.h".
(tracefile_target): New class.
(init_tracefile_ops): Delete.
* spu-multiarch.c (spu_multiarch_target): New class.
(spu_ops): Now a spu_multiarch_target.
(spu_thread_architecture, spu_region_ok_for_hw_watchpoint)
(spu_fetch_registers, spu_store_registers, spu_xfer_partial)
(spu_search_memory, spu_mourn_inferior): Refactor as
spu_multiarch_target methods.
(init_spu_ops): Delete.
(_initialize_spu_multiarch): Remove references to init_spu_ops,
complete_target_initialization.
* ravenscar-thread.c (ravenscar_thread_target): New class.
(ravenscar_ops): Now a ravenscar_thread_target.
(ravenscar_resume, ravenscar_wait, ravenscar_update_thread_list)
(ravenscar_thread_alive, ravenscar_pid_to_str)
(ravenscar_fetch_registers, ravenscar_store_registers)
(ravenscar_prepare_to_store, ravenscar_stopped_by_sw_breakpoint)
(ravenscar_stopped_by_hw_breakpoint)
(ravenscar_stopped_by_watchpoint, ravenscar_stopped_data_address)
(ravenscar_mourn_inferior, ravenscar_core_of_thread)
(ravenscar_get_ada_task_ptid): Refactor as ravenscar_thread_target
methods.
(init_ravenscar_thread_ops): Delete.
(_initialize_ravenscar): Remove references to
init_ravenscar_thread_ops and complete_target_initialization.
* bsd-uthread.c (bsd_uthread_ops_hack): Delete.
(bsd_uthread_target): New class.
(bsd_uthread_ops): Now a bsd_uthread_target.
(bsd_uthread_activate): Adjust to refer to bsd_uthread_ops.
(bsd_uthread_close, bsd_uthread_mourn_inferior)
(bsd_uthread_fetch_registers, bsd_uthread_store_registers)
(bsd_uthread_wait, bsd_uthread_resume, bsd_uthread_thread_alive)
(bsd_uthread_update_thread_list, bsd_uthread_extra_thread_info)
(bsd_uthread_pid_to_str): Refactor as bsd_uthread_target methods.
(bsd_uthread_target): Delete function.
(_initialize_bsd_uthread): Remove reference to
complete_target_initialization.
* bfd-target.c (target_bfd_data): Delete. Fields folded into ...
(target_bfd): ... this new class.
(target_bfd_xfer_partial, target_bfd_get_section_table)
(target_bfd_close): Refactor as target_bfd methods.
(target_bfd::~target_bfd): New.
(target_bfd_reopen): Adjust.
(target_bfd::close): New.
* record-btrace.c (record_btrace_target): New class.
(record_btrace_ops): Now a record_btrace_target.
(record_btrace_open, record_btrace_stop_recording)
(record_btrace_disconnect, record_btrace_close)
(record_btrace_async, record_btrace_info)
(record_btrace_insn_history, record_btrace_insn_history_range)
(record_btrace_insn_history_from, record_btrace_call_history)
(record_btrace_call_history_range)
(record_btrace_call_history_from, record_btrace_record_method)
(record_btrace_is_replaying, record_btrace_will_replay)
(record_btrace_xfer_partial, record_btrace_insert_breakpoint)
(record_btrace_remove_breakpoint, record_btrace_fetch_registers)
(record_btrace_store_registers, record_btrace_prepare_to_store)
(record_btrace_to_get_unwinder)
(record_btrace_to_get_tailcall_unwinder, record_btrace_resume)
(record_btrace_commit_resume, record_btrace_wait)
(record_btrace_stop, record_btrace_can_execute_reverse)
(record_btrace_stopped_by_sw_breakpoint)
(record_btrace_supports_stopped_by_sw_breakpoint)
(record_btrace_stopped_by_hw_breakpoint)
(record_btrace_supports_stopped_by_hw_breakpoint)
(record_btrace_update_thread_list, record_btrace_thread_alive)
(record_btrace_goto_begin, record_btrace_goto_end)
(record_btrace_goto, record_btrace_stop_replaying_all)
(record_btrace_execution_direction)
(record_btrace_prepare_to_generate_core)
(record_btrace_done_generating_core): Refactor as
record_btrace_target methods.
(init_record_btrace_ops): Delete.
(_initialize_record_btrace): Remove reference to
init_record_btrace_ops.
* record-full.c (RECORD_FULL_IS_REPLAY): Adjust to always refer to
the execution_direction global.
(record_full_base_target, record_full_target)
(record_full_core_target): New classes.
(record_full_ops): Now a record_full_target.
(record_full_core_ops): Now a record_full_core_target.
(record_full_target::detach, record_full_target::disconnect)
(record_full_core_target::disconnect)
(record_full_target::mourn_inferior, record_full_target::kill):
New.
(record_full_open, record_full_close, record_full_async): Refactor
as methods of the record_full_base_target class.
(record_full_resume, record_full_commit_resume): Refactor
as methods of the record_full_target class.
(record_full_wait, record_full_stopped_by_watchpoint)
(record_full_stopped_data_address)
(record_full_stopped_by_sw_breakpoint)
(record_full_supports_stopped_by_sw_breakpoint)
(record_full_stopped_by_hw_breakpoint)
(record_full_supports_stopped_by_hw_breakpoint): Refactor as
methods of the record_full_base_target class.
(record_full_store_registers, record_full_xfer_partial)
(record_full_insert_breakpoint, record_full_remove_breakpoint):
Refactor as methods of the record_full_target class.
(record_full_can_execute_reverse, record_full_get_bookmark)
(record_full_goto_bookmark, record_full_execution_direction)
(record_full_record_method, record_full_info, record_full_delete)
(record_full_is_replaying, record_full_will_replay)
(record_full_goto_begin, record_full_goto_end, record_full_goto)
(record_full_stop_replaying): Refactor as methods of the
record_full_base_target class.
(record_full_core_resume, record_full_core_kill)
(record_full_core_fetch_registers)
(record_full_core_prepare_to_store)
(record_full_core_store_registers, record_full_core_xfer_partial)
(record_full_core_insert_breakpoint)
(record_full_core_remove_breakpoint)
(record_full_core_has_execution): Refactor
as methods of the record_full_core_target class.
(record_full_base_target::supports_delete_record): New.
(init_record_full_ops): Delete.
(init_record_full_core_ops): Delete.
(record_full_save): Refactor as method of the
record_full_base_target class.
(_initialize_record_full): Remove references to
init_record_full_ops and init_record_full_core_ops.
* remote.c (remote_target, extended_remote_target): New classes.
(remote_ops): Now a remote_target.
(extended_remote_ops): Now an extended_remote_target.
(remote_insert_fork_catchpoint, remote_remove_fork_catchpoint)
(remote_insert_vfork_catchpoint, remote_remove_vfork_catchpoint)
(remote_insert_exec_catchpoint, remote_remove_exec_catchpoint)
(remote_pass_signals, remote_set_syscall_catchpoint)
(remote_program_signals, )
(remote_thread_always_alive): Remove target_ops parameter.
(remote_thread_alive, remote_thread_name)
(remote_update_thread_list, remote_threads_extra_info)
(remote_static_tracepoint_marker_at)
(remote_static_tracepoint_markers_by_strid)
(remote_get_ada_task_ptid, remote_close, remote_start_remote)
(remote_open): Refactor as methods of remote_target.
(extended_remote_open, extended_remote_detach)
(extended_remote_attach, extended_remote_post_attach):
(extended_remote_supports_disable_randomization)
(extended_remote_create_inferior): : Refactor as method of
extended_remote_target.
(remote_set_permissions, remote_open_1, remote_detach)
(remote_follow_fork, remote_follow_exec, remote_disconnect)
(remote_resume, remote_commit_resume, remote_stop)
(remote_interrupt, remote_pass_ctrlc, remote_terminal_inferior)
(remote_terminal_ours, remote_wait, remote_fetch_registers)
(remote_prepare_to_store, remote_store_registers)
(remote_flash_erase, remote_flash_done, remote_files_info)
(remote_kill, remote_mourn, remote_insert_breakpoint)
(remote_remove_breakpoint, remote_insert_watchpoint)
(remote_watchpoint_addr_within_range)
(remote_remove_watchpoint, remote_region_ok_for_hw_watchpoint)
(remote_check_watch_resources, remote_stopped_by_sw_breakpoint)
(remote_supports_stopped_by_sw_breakpoint)
(remote_stopped_by_hw_breakpoint)
(remote_supports_stopped_by_hw_breakpoint)
(remote_stopped_by_watchpoint, remote_stopped_data_address)
(remote_insert_hw_breakpoint, remote_remove_hw_breakpoint)
(remote_verify_memory): Refactor as methods of remote_target.
(remote_write_qxfer, remote_read_qxfer): Remove target_ops
parameter.
(remote_xfer_partial, remote_get_memory_xfer_limit)
(remote_search_memory, remote_rcmd, remote_memory_map)
(remote_pid_to_str, remote_get_thread_local_address)
(remote_get_tib_address, remote_read_description): Refactor as
methods of remote_target.
(remote_target::fileio_open, remote_target::fileio_pwrite)
(remote_target::fileio_pread, remote_target::fileio_close): New.
(remote_hostio_readlink, remote_hostio_fstat)
(remote_filesystem_is_local, remote_can_execute_reverse)
(remote_supports_non_stop, remote_supports_disable_randomization)
(remote_supports_multi_process, remote_supports_cond_breakpoints)
(remote_supports_enable_disable_tracepoint)
(remote_supports_string_tracing)
(remote_can_run_breakpoint_commands, remote_trace_init)
(remote_download_tracepoint, remote_can_download_tracepoint)
(remote_download_trace_state_variable, remote_enable_tracepoint)
(remote_disable_tracepoint, remote_trace_set_readonly_regions)
(remote_trace_start, remote_get_trace_status)
(remote_get_tracepoint_status, remote_trace_stop)
(remote_trace_find, remote_get_trace_state_variable_value)
(remote_save_trace_data, remote_get_raw_trace_data)
(remote_set_disconnected_tracing, remote_core_of_thread)
(remote_set_circular_trace_buffer, remote_traceframe_info)
(remote_get_min_fast_tracepoint_insn_len)
(remote_set_trace_buffer_size, remote_set_trace_notes)
(remote_use_agent, remote_can_use_agent, remote_enable_btrace)
(remote_disable_btrace, remote_teardown_btrace)
(remote_read_btrace, remote_btrace_conf)
(remote_augmented_libraries_svr4_read, remote_load)
(remote_pid_to_exec_file, remote_can_do_single_step)
(remote_execution_direction, remote_thread_handle_to_thread_info):
Refactor as methods of remote_target.
(init_remote_ops, init_extended_remote_ops): Delete.
(remote_can_async_p, remote_is_async_p, remote_async)
(remote_thread_events, remote_upload_tracepoints)
(remote_upload_trace_state_variables): Refactor as methods of
remote_target.
(_initialize_remote): Remove references to init_remote_ops and
init_extended_remote_ops.
* remote-sim.c (gdbsim_target): New class.
(gdbsim_fetch_register, gdbsim_store_register, gdbsim_kill)
(gdbsim_load, gdbsim_create_inferior, gdbsim_open, gdbsim_close)
(gdbsim_detach, gdbsim_resume, gdbsim_interrupt)
(gdbsim_wait, gdbsim_prepare_to_store, gdbsim_xfer_partial)
(gdbsim_files_info, gdbsim_mourn_inferior, gdbsim_thread_alive)
(gdbsim_pid_to_str, gdbsim_has_all_memory, gdbsim_has_memory):
Refactor as methods of gdbsim_target.
(gdbsim_ops): Now a gdbsim_target.
(init_gdbsim_ops): Delete.
(gdbsim_cntrl_c): Adjust.
(_initialize_remote_sim): Remove reference to init_gdbsim_ops.
* amd64-linux-nat.c (amd64_linux_nat_target): New class.
(the_amd64_linux_nat_target): New.
(amd64_linux_fetch_inferior_registers)
(amd64_linux_store_inferior_registers): Refactor as methods of
amd64_linux_nat_target.
(_initialize_amd64_linux_nat): Adjust. Set linux_target.
* i386-linux-nat.c: Don't include "linux-nat.h".
(i386_linux_nat_target): New class.
(the_i386_linux_nat_target): New.
(i386_linux_fetch_inferior_registers)
(i386_linux_store_inferior_registers, i386_linux_resume): Refactor
as methods of i386_linux_nat_target.
(_initialize_i386_linux_nat): Adjust. Set linux_target.
* inf-child.c (inf_child_ops): Delete.
(inf_child_fetch_inferior_registers)
(inf_child_store_inferior_registers): Delete.
(inf_child_post_attach, inf_child_prepare_to_store): Refactor as
methods of inf_child_target.
(inf_child_target::supports_terminal_ours)
(inf_child_target::terminal_init)
(inf_child_target::terminal_inferior)
(inf_child_target::terminal_ours_for_output)
(inf_child_target::terminal_ours, inf_child_target::interrupt)
(inf_child_target::pass_ctrlc, inf_child_target::terminal_info):
New.
(inf_child_open, inf_child_disconnect, inf_child_close)
(inf_child_mourn_inferior, inf_child_maybe_unpush_target)
(inf_child_post_startup_inferior, inf_child_can_run)
(inf_child_pid_to_exec_file): Refactor as methods of
inf_child_target.
(inf_child_follow_fork): Delete.
(inf_child_target::can_create_inferior)
(inf_child_target::can_attach): New.
(inf_child_target::has_all_memory, inf_child_target::has_memory)
(inf_child_target::has_stack, inf_child_target::has_registers)
(inf_child_target::has_execution): New.
(inf_child_fileio_open, inf_child_fileio_pwrite)
(inf_child_fileio_pread, inf_child_fileio_fstat)
(inf_child_fileio_close, inf_child_fileio_unlink)
(inf_child_fileio_readlink, inf_child_use_agent)
(inf_child_can_use_agent): Refactor as methods of
inf_child_target.
(return_zero, inf_child_target): Delete.
(inf_child_target::inf_child_target): New.
* inf-child.h: Include "target.h".
(inf_child_target): Delete function prototype.
(inf_child_target): New class.
(inf_child_open_target, inf_child_mourn_inferior)
(inf_child_maybe_unpush_target): Delete.
* inf-ptrace.c (inf_ptrace_target::~inf_ptrace_target): New.
(inf_ptrace_follow_fork, inf_ptrace_insert_fork_catchpoint)
(inf_ptrace_remove_fork_catchpoint, inf_ptrace_create_inferior)
(inf_ptrace_post_startup_inferior, inf_ptrace_mourn_inferior)
(inf_ptrace_attach, inf_ptrace_post_attach, inf_ptrace_detach)
(inf_ptrace_detach_success, inf_ptrace_kill, inf_ptrace_resume)
(inf_ptrace_wait, inf_ptrace_xfer_partial)
(inf_ptrace_thread_alive, inf_ptrace_files_info)
(inf_ptrace_pid_to_str, inf_ptrace_auxv_parse): Refactor as
methods of inf_ptrace_target.
(inf_ptrace_target): Delete function.
* inf-ptrace.h: Include "inf-child.h".
(inf_ptrace_target): Delete function declaration.
(inf_ptrace_target): New class.
(inf_ptrace_trad_target, inf_ptrace_detach_success): Delete.
* linux-nat.c (linux_target): New.
(linux_ops, linux_ops_saved, super_xfer_partial): Delete.
(linux_nat_target::~linux_nat_target): New.
(linux_child_post_attach, linux_child_post_startup_inferior)
(linux_child_follow_fork, linux_child_insert_fork_catchpoint)
(linux_child_remove_fork_catchpoint)
(linux_child_insert_vfork_catchpoint)
(linux_child_remove_vfork_catchpoint)
(linux_child_insert_exec_catchpoint)
(linux_child_remove_exec_catchpoint)
(linux_child_set_syscall_catchpoint, linux_nat_pass_signals)
(linux_nat_create_inferior, linux_nat_attach, linux_nat_detach)
(linux_nat_resume, linux_nat_stopped_by_watchpoint)
(linux_nat_stopped_data_address)
(linux_nat_stopped_by_sw_breakpoint)
(linux_nat_supports_stopped_by_sw_breakpoint)
(linux_nat_stopped_by_hw_breakpoint)
(linux_nat_supports_stopped_by_hw_breakpoint, linux_nat_wait)
(linux_nat_kill, linux_nat_mourn_inferior)
(linux_nat_xfer_partial, linux_nat_thread_alive)
(linux_nat_update_thread_list, linux_nat_pid_to_str)
(linux_nat_thread_name, linux_child_pid_to_exec_file)
(linux_child_static_tracepoint_markers_by_strid)
(linux_nat_is_async_p, linux_nat_can_async_p)
(linux_nat_supports_non_stop, linux_nat_always_non_stop_p)
(linux_nat_supports_multi_process)
(linux_nat_supports_disable_randomization, linux_nat_async)
(linux_nat_stop, linux_nat_close, linux_nat_thread_address_space)
(linux_nat_core_of_thread, linux_nat_filesystem_is_local)
(linux_nat_fileio_open, linux_nat_fileio_readlink)
(linux_nat_fileio_unlink, linux_nat_thread_events): Refactor as
methods of linux_nat_target.
(linux_nat_wait_1, linux_xfer_siginfo, linux_proc_xfer_partial)
(linux_proc_xfer_spu, linux_nat_xfer_osdata): Remove target_ops
parameter.
(check_stopped_by_watchpoint): Adjust.
(linux_xfer_partial): Delete.
(linux_target_install_ops, linux_target, linux_nat_add_target):
Delete.
(linux_nat_target::linux_nat_target): New.
* linux-nat.h: Include "inf-ptrace.h".
(linux_nat_target): New.
(linux_target, linux_target_install_ops, linux_nat_add_target):
Delete function declarations.
(linux_target): Declare global.
* linux-thread-db.c (thread_db_target): New.
(thread_db_target::thread_db_target): New.
(thread_db_ops): Delete.
(the_thread_db_target): New.
(thread_db_detach, thread_db_wait, thread_db_mourn_inferior)
(thread_db_update_thread_list, thread_db_pid_to_str)
(thread_db_extra_thread_info)
(thread_db_thread_handle_to_thread_info)
(thread_db_get_thread_local_address, thread_db_get_ada_task_ptid)
(thread_db_resume): Refactor as methods of thread_db_target.
(init_thread_db_ops): Delete.
(_initialize_thread_db): Remove reference to init_thread_db_ops.
* x86-linux-nat.c: Don't include "linux-nat.h".
(super_post_startup_inferior): Delete.
(x86_linux_nat_target::~x86_linux_nat_target): New.
(x86_linux_child_post_startup_inferior)
(x86_linux_read_description, x86_linux_enable_btrace)
(x86_linux_disable_btrace, x86_linux_teardown_btrace)
(x86_linux_read_btrace, x86_linux_btrace_conf): Refactor as
methods of x86_linux_nat_target.
(x86_linux_create_target): Delete. Bits folded ...
(x86_linux_add_target): ... here. Now takes a linux_nat_target
pointer.
* x86-linux-nat.h: Include "linux-nat.h" and "x86-nat.h".
(x86_linux_nat_target): New class.
(x86_linux_create_target): Delete.
(x86_linux_add_target): Now takes a linux_nat_target pointer.
* x86-nat.c (x86_insert_watchpoint, x86_remove_watchpoint)
(x86_region_ok_for_watchpoint, x86_stopped_data_address)
(x86_stopped_by_watchpoint, x86_insert_hw_breakpoint)
(x86_remove_hw_breakpoint, x86_can_use_hw_breakpoint)
(x86_stopped_by_hw_breakpoint): Remove target_ops parameter and
make extern.
(x86_use_watchpoints): Delete.
* x86-nat.h: Include "breakpoint.h" and "target.h".
(x86_use_watchpoints): Delete.
(x86_can_use_hw_breakpoint, x86_region_ok_for_hw_watchpoint)
(x86_stopped_by_watchpoint, x86_stopped_data_address)
(x86_insert_watchpoint, x86_remove_watchpoint)
(x86_insert_hw_breakpoint, x86_remove_hw_breakpoint)
(x86_stopped_by_hw_breakpoint): New declarations.
(x86_nat_target): New template class.
* ppc-linux-nat.c (ppc_linux_nat_target): New class.
(the_ppc_linux_nat_target): New.
(ppc_linux_fetch_inferior_registers)
(ppc_linux_can_use_hw_breakpoint)
(ppc_linux_region_ok_for_hw_watchpoint)
(ppc_linux_ranged_break_num_registers)
(ppc_linux_insert_hw_breakpoint, ppc_linux_remove_hw_breakpoint)
(ppc_linux_insert_mask_watchpoint)
(ppc_linux_remove_mask_watchpoint)
(ppc_linux_can_accel_watchpoint_condition)
(ppc_linux_insert_watchpoint, ppc_linux_remove_watchpoint)
(ppc_linux_stopped_data_address, ppc_linux_stopped_by_watchpoint)
(ppc_linux_watchpoint_addr_within_range)
(ppc_linux_masked_watch_num_registers)
(ppc_linux_store_inferior_registers, ppc_linux_auxv_parse)
(ppc_linux_read_description): Refactor as methods of
ppc_linux_nat_target.
(_initialize_ppc_linux_nat): Adjust. Set linux_target.
* procfs.c (procfs_xfer_partial): Delete forward declaration.
(procfs_target): New class.
(the_procfs_target): New.
(procfs_target): Delete function.
(procfs_auxv_parse, procfs_attach, procfs_detach)
(procfs_fetch_registers, procfs_store_registers, procfs_wait)
(procfs_xfer_partial, procfs_resume, procfs_pass_signals)
(procfs_files_info, procfs_kill_inferior, procfs_mourn_inferior)
(procfs_create_inferior, procfs_update_thread_list)
(procfs_thread_alive, procfs_pid_to_str)
(procfs_can_use_hw_breakpoint, procfs_stopped_by_watchpoint)
(procfs_stopped_data_address, procfs_insert_watchpoint)
(procfs_remove_watchpoint, procfs_region_ok_for_hw_watchpoint)
(proc_find_memory_regions, procfs_info_proc)
(procfs_make_note_section): Refactor as methods of procfs_target.
(_initialize_procfs): Adjust.
* sol-thread.c (sol_thread_target): New class.
(sol_thread_ops): Now a sol_thread_target.
(sol_thread_detach, sol_thread_resume, sol_thread_wait)
(sol_thread_fetch_registers, sol_thread_store_registers)
(sol_thread_xfer_partial, sol_thread_mourn_inferior)
(sol_thread_alive, solaris_pid_to_str, sol_update_thread_list)
(sol_get_ada_task_ptid): Refactor as methods of sol_thread_target.
(init_sol_thread_ops): Delete.
(_initialize_sol_thread): Adjust. Remove references to
init_sol_thread_ops and complete_target_initialization.
* windows-nat.c (windows_nat_target): New class.
(windows_fetch_inferior_registers)
(windows_store_inferior_registers, windows_resume, windows_wait)
(windows_attach, windows_detach, windows_pid_to_exec_file)
(windows_files_info, windows_create_inferior)
(windows_mourn_inferior, windows_interrupt, windows_kill_inferior)
(windows_close, windows_pid_to_str, windows_xfer_partial)
(windows_get_tib_address, windows_get_ada_task_ptid)
(windows_thread_name, windows_thread_alive): Refactor as
windows_nat_target methods.
(do_initial_windows_stuff): Adjust.
(windows_target): Delete function.
(_initialize_windows_nat): Adjust.
* darwin-nat.c (darwin_resume, darwin_wait_to, darwin_interrupt)
(darwin_mourn_inferior, darwin_kill_inferior)
(darwin_create_inferior, darwin_attach, darwin_detach)
(darwin_pid_to_str, darwin_thread_alive, darwin_xfer_partial)
(darwin_pid_to_exec_file, darwin_get_ada_task_ptid)
(darwin_supports_multi_process): Refactor as darwin_nat_target
methods.
(darwin_resume_to, darwin_files_info): Delete.
(_initialize_darwin_inferior): Rename to ...
(_initialize_darwin_nat): ... this. Adjust to C++ification.
* darwin-nat.h: Include "inf-child.h".
(darwin_nat_target): New class.
(darwin_complete_target): Delete.
* i386-darwin-nat.c (i386_darwin_nat_target): New class.
(darwin_target): New.
(i386_darwin_fetch_inferior_registers)
(i386_darwin_store_inferior_registers): Refactor as methods of
darwin_nat_target.
(darwin_complete_target): Delete, with ...
(_initialize_i386_darwin_nat): ... bits factored out here.
* alpha-linux-nat.c (alpha_linux_nat_target): New class.
(the_alpha_linux_nat_target): New.
(alpha_linux_register_u_offset): Refactor as
alpha_linux_nat_target method.
(_initialize_alpha_linux_nat): Adjust.
* linux-nat-trad.c (inf_ptrace_register_u_offset): Delete.
(inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
(inf_ptrace_store_register, inf_ptrace_store_registers): Refact as
methods of linux_nat_trad_target.
(linux_trad_target): Delete.
* linux-nat-trad.h (linux_trad_target): Delete function.
(linux_nat_trad_target): New class.
* mips-linux-nat.c (mips_linux_nat_target): New class.
(super_fetch_registers, super_store_registers, super_close):
Delete.
(the_mips_linux_nat_target): New.
(mips64_linux_regsets_fetch_registers)
(mips64_linux_regsets_store_registers)
(mips64_linux_fetch_registers, mips64_linux_store_registers)
(mips_linux_register_u_offset, mips_linux_read_description)
(mips_linux_can_use_hw_breakpoint)
(mips_linux_stopped_by_watchpoint)
(mips_linux_stopped_data_address)
(mips_linux_region_ok_for_hw_watchpoint)
(mips_linux_insert_watchpoint, mips_linux_remove_watchpoint)
(mips_linux_close): Refactor as methods of mips_linux_nat.
(_initialize_mips_linux_nat): Adjust to C++ification.
* aix-thread.c (aix_thread_target): New class.
(aix_thread_ops): Now an aix_thread_target.
(aix_thread_detach, aix_thread_resume, aix_thread_wait)
(aix_thread_fetch_registers, aix_thread_store_registers)
(aix_thread_xfer_partial, aix_thread_mourn_inferior)
(aix_thread_thread_alive, aix_thread_pid_to_str)
(aix_thread_extra_thread_info, aix_thread_get_ada_task_ptid):
Refactor as methods of aix_thread_target.
(init_aix_thread_ops): Delete.
(_initialize_aix_thread): Remove references to init_aix_thread_ops
and complete_target_initialization.
* rs6000-nat.c (rs6000_xfer_shared_libraries): Delete.
(rs6000_nat_target): New class.
(the_rs6000_nat_target): New.
(rs6000_fetch_inferior_registers, rs6000_store_inferior_registers)
(rs6000_xfer_partial, rs6000_wait, rs6000_create_inferior)
(rs6000_xfer_shared_libraries): Refactor as rs6000_nat_target methods.
(super_create_inferior): Delete.
(_initialize_rs6000_nat): Adjust to C++ification.
* arm-linux-nat.c (arm_linux_nat_target): New class.
(the_arm_linux_nat_target): New.
(arm_linux_fetch_inferior_registers)
(arm_linux_store_inferior_registers, arm_linux_read_description)
(arm_linux_can_use_hw_breakpoint, arm_linux_insert_hw_breakpoint)
(arm_linux_remove_hw_breakpoint)
(arm_linux_region_ok_for_hw_watchpoint)
(arm_linux_insert_watchpoint, arm_linux_remove_watchpoint)
(arm_linux_stopped_data_address, arm_linux_stopped_by_watchpoint)
(arm_linux_watchpoint_addr_within_range): Refactor as methods of
arm_linux_nat_target.
(_initialize_arm_linux_nat): Adjust to C++ification.
* aarch64-linux-nat.c (aarch64_linux_nat_target): New class.
(the_aarch64_linux_nat_target): New.
(aarch64_linux_fetch_inferior_registers)
(aarch64_linux_store_inferior_registers)
(aarch64_linux_child_post_startup_inferior)
(aarch64_linux_read_description)
(aarch64_linux_can_use_hw_breakpoint)
(aarch64_linux_insert_hw_breakpoint)
(aarch64_linux_remove_hw_breakpoint)
(aarch64_linux_insert_watchpoint, aarch64_linux_remove_watchpoint)
(aarch64_linux_region_ok_for_hw_watchpoint)
(aarch64_linux_stopped_data_address)
(aarch64_linux_stopped_by_watchpoint)
(aarch64_linux_watchpoint_addr_within_range)
(aarch64_linux_can_do_single_step): Refactor as methods of
aarch64_linux_nat_target.
(super_post_startup_inferior): Delete.
(_initialize_aarch64_linux_nat): Adjust to C++ification.
* hppa-linux-nat.c (hppa_linux_nat_target): New class.
(the_hppa_linux_nat_target): New.
(hppa_linux_fetch_inferior_registers)
(hppa_linux_store_inferior_registers): Refactor as methods of
hppa_linux_nat_target.
(_initialize_hppa_linux_nat): Adjust to C++ification.
* ia64-linux-nat.c (ia64_linux_nat_target): New class.
(the_ia64_linux_nat_target): New.
(ia64_linux_insert_watchpoint, ia64_linux_remove_watchpoint)
(ia64_linux_stopped_data_address)
(ia64_linux_stopped_by_watchpoint, ia64_linux_fetch_registers)
(ia64_linux_store_registers, ia64_linux_xfer_partial): Refactor as
ia64_linux_nat_target methods.
(super_xfer_partial): Delete.
(_initialize_ia64_linux_nat): Adjust to C++ification.
* m32r-linux-nat.c (m32r_linux_nat_target): New class.
(the_m32r_linux_nat_target): New.
(m32r_linux_fetch_inferior_registers)
(m32r_linux_store_inferior_registers): Refactor as
m32r_linux_nat_target methods.
(_initialize_m32r_linux_nat): Adjust to C++ification.
* m68k-linux-nat.c (m68k_linux_nat_target): New class.
(the_m68k_linux_nat_target): New.
(m68k_linux_fetch_inferior_registers)
(m68k_linux_store_inferior_registers): Refactor as
m68k_linux_nat_target methods.
(_initialize_m68k_linux_nat): Adjust to C++ification.
* s390-linux-nat.c (s390_linux_nat_target): New class.
(the_s390_linux_nat_target): New.
(s390_linux_fetch_inferior_registers)
(s390_linux_store_inferior_registers, s390_stopped_by_watchpoint)
(s390_insert_watchpoint, s390_remove_watchpoint)
(s390_can_use_hw_breakpoint, s390_insert_hw_breakpoint)
(s390_remove_hw_breakpoint, s390_region_ok_for_hw_watchpoint)
(s390_auxv_parse, s390_read_description): Refactor as methods of
s390_linux_nat_target.
(_initialize_s390_nat): Adjust to C++ification.
* sparc-linux-nat.c (sparc_linux_nat_target): New class.
(the_sparc_linux_nat_target): New.
(_initialize_sparc_linux_nat): Adjust to C++ification.
* sparc-nat.c (sparc_fetch_inferior_registers)
(sparc_store_inferior_registers): Remove target_ops parameter.
* sparc-nat.h (sparc_fetch_inferior_registers)
(sparc_store_inferior_registers): Remove target_ops parameter.
* sparc64-linux-nat.c (sparc64_linux_nat_target): New class.
(the_sparc64_linux_nat_target): New.
(_initialize_sparc64_linux_nat): Adjust to C++ification.
* spu-linux-nat.c (spu_linux_nat_target): New class.
(the_spu_linux_nat_target): New.
(spu_child_post_startup_inferior, spu_child_post_attach)
(spu_child_wait, spu_fetch_inferior_registers)
(spu_store_inferior_registers, spu_xfer_partial)
(spu_can_use_hw_breakpoint): Refactor as spu_linux_nat_target
methods.
(_initialize_spu_nat): Adjust to C++ification.
* tilegx-linux-nat.c (tilegx_linux_nat_target): New class.
(the_tilegx_linux_nat_target): New.
(fetch_inferior_registers, store_inferior_registers):
Refactor as methods.
(_initialize_tile_linux_nat): Adjust to C++ification.
* xtensa-linux-nat.c (xtensa_linux_nat_target): New class.
(the_xtensa_linux_nat_target): New.
(xtensa_linux_fetch_inferior_registers)
(xtensa_linux_store_inferior_registers): Refactor as
xtensa_linux_nat_target methods.
(_initialize_xtensa_linux_nat): Adjust to C++ification.
* fbsd-nat.c (USE_SIGTRAP_SIGINFO): Delete.
(fbsd_pid_to_exec_file, fbsd_find_memory_regions)
(fbsd_find_memory_regions, fbsd_info_proc, fbsd_xfer_partial)
(fbsd_thread_alive, fbsd_pid_to_str, fbsd_thread_name)
(fbsd_update_thread_list, fbsd_resume, fbsd_wait)
(fbsd_stopped_by_sw_breakpoint)
(fbsd_supports_stopped_by_sw_breakpoint, fbsd_follow_fork)
(fbsd_insert_fork_catchpoint, fbsd_remove_fork_catchpoint)
(fbsd_insert_vfork_catchpoint, fbsd_remove_vfork_catchpoint)
(fbsd_post_startup_inferior, fbsd_post_attach)
(fbsd_insert_exec_catchpoint, fbsd_remove_exec_catchpoint)
(fbsd_set_syscall_catchpoint)
(super_xfer_partial, super_resume, super_wait)
(fbsd_supports_stopped_by_hw_breakpoint): Delete.
(fbsd_handle_debug_trap): Remove target_ops parameter.
(fbsd_nat_add_target): Delete.
* fbsd-nat.h: Include "inf-ptrace.h".
(fbsd_nat_add_target): Delete.
(USE_SIGTRAP_SIGINFO): Define.
(fbsd_nat_target): New class.
* amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers)
(amd64bsd_store_inferior_registers): Remove target_ops parameter.
(amd64bsd_target): Delete.
* amd64-bsd-nat.h: New file.
* amd64-fbsd-nat.c: Include "amd64-bsd-nat.h" instead of
"x86-bsd-nat.h".
(amd64_fbsd_nat_target): New class.
(the_amd64_fbsd_nat_target): New.
(amd64fbsd_read_description): Refactor as method of
amd64_fbsd_nat_target.
(amd64_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
(_initialize_amd64fbsd_nat): Adjust to C++ification.
* amd64-nat.h (amd64bsd_target): Delete function declaration.
* i386-bsd-nat.c (i386bsd_fetch_inferior_registers)
(i386bsd_store_inferior_registers): Remove target_ops parameter.
(i386bsd_target): Delete.
* i386-bsd-nat.h (i386bsd_target): Delete function declaration.
(i386bsd_fetch_inferior_registers)
(i386bsd_store_inferior_registers): Declare.
(i386_bsd_nat_target): New class.
* i386-fbsd-nat.c (i386_fbsd_nat_target): New class.
(the_i386_fbsd_nat_target): New.
(i386fbsd_resume, i386fbsd_read_description): Refactor as
i386_fbsd_nat_target methods.
(i386_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
(_initialize_i386fbsd_nat): Adjust to C++ification.
* x86-bsd-nat.c (super_mourn_inferior): Delete.
(x86bsd_mourn_inferior, x86bsd_target): Delete.
(_initialize_x86_bsd_nat): Adjust to C++ification.
* x86-bsd-nat.h: Include "x86-nat.h".
(x86bsd_target): Delete declaration.
(x86bsd_nat_target): New class.
* aarch64-fbsd-nat.c (aarch64_fbsd_nat_target): New class.
(the_aarch64_fbsd_nat_target): New.
(aarch64_fbsd_fetch_inferior_registers)
(aarch64_fbsd_store_inferior_registers): Refactor as methods of
aarch64_fbsd_nat_target.
(_initialize_aarch64_fbsd_nat): Adjust to C++ification.
* alpha-bsd-nat.c (alpha_bsd_nat_target): New class.
(the_alpha_bsd_nat_target): New.
(alphabsd_fetch_inferior_registers)
(alphabsd_store_inferior_registers): Refactor as
alpha_bsd_nat_target methods.
(_initialize_alphabsd_nat): Refactor as methods of
alpha_bsd_nat_target.
* amd64-nbsd-nat.c: Include "amd64-bsd-nat.h".
(the_amd64_nbsd_nat_target): New.
(_initialize_amd64nbsd_nat): Adjust to C++ification.
* amd64-obsd-nat.c: Include "amd64-bsd-nat.h".
(the_amd64_obsd_nat_target): New.
(_initialize_amd64obsd_nat): Adjust to C++ification.
* arm-fbsd-nat.c (arm_fbsd_nat_target): New.
(the_arm_fbsd_nat_target): New.
(arm_fbsd_fetch_inferior_registers)
(arm_fbsd_store_inferior_registers, arm_fbsd_read_description):
(_initialize_arm_fbsd_nat): Refactor as methods of
arm_fbsd_nat_target.
(_initialize_arm_fbsd_nat): Adjust to C++ification.
* arm-nbsd-nat.c (arm_netbsd_nat_target): New class.
(the_arm_netbsd_nat_target): New.
(armnbsd_fetch_registers, armnbsd_store_registers): Refactor as
arm_netbsd_nat_target.
(_initialize_arm_netbsd_nat): Adjust to C++ification.
* hppa-nbsd-nat.c (hppa_nbsd_nat_target): New class.
(the_hppa_nbsd_nat_target): New.
(hppanbsd_fetch_registers, hppanbsd_store_registers): Refactor as
hppa_nbsd_nat_target methods.
(_initialize_hppanbsd_nat): Adjust to C++ification.
* hppa-obsd-nat.c (hppa_obsd_nat_target): New class.
(the_hppa_obsd_nat_target): New.
(hppaobsd_fetch_registers, hppaobsd_store_registers): Refactor as
methods of hppa_obsd_nat_target.
(_initialize_hppaobsd_nat): Adjust to C++ification. Use
add_target.
* i386-nbsd-nat.c (the_i386_nbsd_nat_target): New.
(_initialize_i386nbsd_nat): Adjust to C++ification. Use
add_target.
* i386-obsd-nat.c (the_i386_obsd_nat_target): New.
(_initialize_i386obsd_nat): Use add_target.
* m68k-bsd-nat.c (m68k_bsd_nat_target): New class.
(the_m68k_bsd_nat_target): New.
(m68kbsd_fetch_inferior_registers)
(m68kbsd_store_inferior_registers): Refactor as methods of
m68k_bsd_nat_target.
(_initialize_m68kbsd_nat): Adjust to C++ification.
* mips-fbsd-nat.c (mips_fbsd_nat_target): New class.
(the_mips_fbsd_nat_target): New.
(mips_fbsd_fetch_inferior_registers)
(mips_fbsd_store_inferior_registers): Refactor as methods of
mips_fbsd_nat_target.
(_initialize_mips_fbsd_nat): Adjust to C++ification. Use
add_target.
* mips-nbsd-nat.c (mips_nbsd_nat_target): New class.
(the_mips_nbsd_nat_target): New.
(mipsnbsd_fetch_inferior_registers)
(mipsnbsd_store_inferior_registers): Refactor as methods of
mips_nbsd_nat_target.
(_initialize_mipsnbsd_nat): Adjust to C++ification.
* mips64-obsd-nat.c (mips64_obsd_nat_target): New class.
(the_mips64_obsd_nat_target): New.
(mips64obsd_fetch_inferior_registers)
(mips64obsd_store_inferior_registers): Refactor as methods of
mips64_obsd_nat_target.
(_initialize_mips64obsd_nat): Adjust to C++ification. Use
add_target.
* nbsd-nat.c (nbsd_pid_to_exec_file): Refactor as method of
nbsd_nat_target.
* nbsd-nat.h: Include "inf-ptrace.h".
(nbsd_nat_target): New class.
* obsd-nat.c (obsd_pid_to_str, obsd_update_thread_list)
(obsd_wait): Refactor as methods of obsd_nat_target.
(obsd_add_target): Delete.
* obsd-nat.h: Include "inf-ptrace.h".
(obsd_nat_target): New class.
* ppc-fbsd-nat.c (ppc_fbsd_nat_target): New class.
(the_ppc_fbsd_nat_target): New.
(ppcfbsd_fetch_inferior_registers)
(ppcfbsd_store_inferior_registers): Refactor as methods of
ppc_fbsd_nat_target.
(_initialize_ppcfbsd_nat): Adjust to C++ification. Use
add_target.
* ppc-nbsd-nat.c (ppc_nbsd_nat_target): New class.
(the_ppc_nbsd_nat_target): New.
(ppcnbsd_fetch_inferior_registers)
(ppcnbsd_store_inferior_registers): Refactor as methods of
ppc_nbsd_nat_target.
(_initialize_ppcnbsd_nat): Adjust to C++ification.
* ppc-obsd-nat.c (ppc_obsd_nat_target): New class.
(the_ppc_obsd_nat_target): New.
(ppcobsd_fetch_registers, ppcobsd_store_registers): Refactor as
methods of ppc_obsd_nat_target.
(_initialize_ppcobsd_nat): Adjust to C++ification. Use
add_target.
* sh-nbsd-nat.c (sh_nbsd_nat_target): New class.
(the_sh_nbsd_nat_target): New.
(shnbsd_fetch_inferior_registers)
(shnbsd_store_inferior_registers): Refactor as methods of
sh_nbsd_nat_target.
(_initialize_shnbsd_nat): Adjust to C++ification.
* sparc-nat.c (sparc_xfer_wcookie): Make extern.
(inf_ptrace_xfer_partial): Delete.
(sparc_xfer_partial, sparc_target): Delete.
* sparc-nat.h (sparc_fetch_inferior_registers)
(sparc_store_inferior_registers, sparc_xfer_wcookie): Declare.
(sparc_target): Delete function declaration.
(sparc_target): New template class.
* sparc-nbsd-nat.c (the_sparc_nbsd_nat_target): New.
(_initialize_sparcnbsd_nat): Adjust to C++ification.
* sparc64-fbsd-nat.c (the_sparc64_fbsd_nat_target): New.
(_initialize_sparc64fbsd_nat): Adjust to C++ification. Use
add_target.
* sparc64-nbsd-nat.c (the_sparc64_nbsd_nat_target): New.
(_initialize_sparc64nbsd_nat): Adjust to C++ification.
* sparc64-obsd-nat.c (the_sparc64_obsd_nat_target): New.
(_initialize_sparc64obsd_nat): Adjust to C++ification. Use
add_target.
* vax-bsd-nat.c (vax_bsd_nat_target): New class.
(the_vax_bsd_nat_target): New.
(vaxbsd_fetch_inferior_registers)
(vaxbsd_store_inferior_registers): Refactor as vax_bsd_nat_target
methods.
(_initialize_vaxbsd_nat): Adjust to C++ification.
* bsd-kvm.c (bsd_kvm_target): New class.
(bsd_kvm_ops): Now a bsd_kvm_target.
(bsd_kvm_open, bsd_kvm_close, bsd_kvm_xfer_partial)
(bsd_kvm_files_info, bsd_kvm_fetch_registers)
(bsd_kvm_thread_alive, bsd_kvm_pid_to_str): Refactor as methods of
bsd_kvm_target.
(bsd_kvm_return_one): Delete.
(bsd_kvm_add_target): Adjust to C++ification.
* nto-procfs.c (nto_procfs_target, nto_procfs_target_native)
(nto_procfs_target_procfs): New classes.
(procfs_open_1, procfs_thread_alive, procfs_update_thread_list)
(procfs_files_info, procfs_pid_to_exec_file, procfs_attach)
(procfs_post_attach, procfs_wait, procfs_fetch_registers)
(procfs_xfer_partial, procfs_detach, procfs_insert_breakpoint)
(procfs_remove_breakpoint, procfs_insert_hw_breakpoint)
(procfs_remove_hw_breakpoint, procfs_resume)
(procfs_mourn_inferior, procfs_create_inferior, procfs_interrupt)
(procfs_kill_inferior, procfs_store_registers)
(procfs_pass_signals, procfs_pid_to_str, procfs_can_run): Refactor
as methods of nto_procfs_target.
(nto_procfs_ops): Now an nto_procfs_target_procfs.
(nto_native_ops): Delete.
(procfs_open, procfs_native_open): Delete.
(nto_native_ops): Now an nto_procfs_target_native.
(init_procfs_targets): Adjust to C++ification.
(procfs_can_use_hw_breakpoint, procfs_remove_hw_watchpoint)
(procfs_insert_hw_watchpoint, procfs_stopped_by_watchpoint):
Refactor as methods of nto_procfs_target.
* go32-nat.c (go32_nat_target): New class.
(the_go32_nat_target): New.
(go32_attach, go32_resume, go32_wait, go32_fetch_registers)
(go32_store_registers, go32_xfer_partial, go32_files_info)
(go32_kill_inferior, go32_create_inferior, go32_mourn_inferior)
(go32_terminal_init, go32_terminal_info, go32_terminal_inferior)
(go32_terminal_ours, go32_pass_ctrlc, go32_thread_alive)
(go32_pid_to_str): Refactor as methods of go32_nat_target.
(go32_target): Delete.
(_initialize_go32_nat): Adjust to C++ification.
* gnu-nat.c (gnu_wait, gnu_resume, gnu_kill_inferior)
(gnu_mourn_inferior, gnu_create_inferior, gnu_attach, gnu_detach)
(gnu_stop, gnu_thread_alive, gnu_xfer_partial)
(gnu_find_memory_regions, gnu_pid_to_str): Refactor as methods of
gnu_nat_target.
(gnu_target): Delete.
* gnu-nat.h (gnu_target): Delete.
(gnu_nat_target): New class.
* i386-gnu-nat.c (gnu_base_target): New.
(i386_gnu_nat_target): New class.
(the_i386_gnu_nat_target): New.
(_initialize_i386gnu_nat): Adjust to C++ification.
gdb/testsuite/ChangeLog:
2018-05-02 Pedro Alves <palves@redhat.com>
* gdb.base/breakpoint-in-ro-region.exp: Adjust to to_resume and
to_log_command renames.
* gdb.base/sss-bp-on-user-bp-2.exp: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] BFD: Prevent writing the MIPS _gp_disp symbol into symbol tables
@ 2018-05-03 17:01 sergiodj+buildbot
2018-05-04 3:00 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-03 17:01 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 3be08ea4728b56d35e136af4e6fd3086ade17764 ***
Author: Simon Atanasyan <simon@atanasyan.com>
Branch: master
Commit: 3be08ea4728b56d35e136af4e6fd3086ade17764
BFD: Prevent writing the MIPS _gp_disp symbol into symbol tables
The _gp_disp is a magic symbol, always implicitly defined by the linker.
It does not make a sense to write it into symbol tables for output files.
Moreover, now if the linker gets a version script, the _gp_disp symbol
gets zero version definition index. The zero index means[1]:
"The symbol is local, not available outside the object."
But the _gp_disp symbol has GLOBAL binding. That confuses some tools
like for example the LLD linker when they get such files as inputs.
This patch fixes the problem - it prevents writing the _gp_disp symbol
in regular and dynamic symbol tables.
This was tested by running LD test suite on a mipsel-linux board.
References:
[1] "Linux Standard Base Specification", Section "10.7.2 Symbol
Version Table", p. 32
2018-05-03 Simon Atanasyan <simon@atanasyan.com>
bfd/
* elf32-mips.c: (elf32_mips_fixup_symbol): New function.
(elf_backend_fixup_symbol): New macro.
* elfxx-mips.c: (mips_elf_output_extsym): Discard _gp_disp
handling.
(_bfd_mips_elf_finish_dynamic_symbol): Likewise.
ld/
* testsuite/ld-mips-elf/gp-disp-sym.d: New test.
* testsuite/ld-mips-elf/gp-disp-sym.s: New test source.
* testsuite/ld-mips-elf/mips-elf.exp: Run the new test.
* testsuite/ld-mips-elf/mips16-pic-2.ad: Update for _gp_disp
symbol removal.
* testsuite/ld-mips-elf/mips16-pic-2.nd: Likewise.
* testsuite/ld-mips-elf/pic-and-nonpic-3a.dd: Likewise.
* testsuite/ld-mips-elf/tlslib-o32-hidden.got: Likewise.
* testsuite/ld-mips-elf/tlslib-o32-ver.got: Likewise.
* testsuite/ld-mips-elf/tlslib-o32.got: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Use flex's -t option instead of --stdout
@ 2018-05-03 22:18 sergiodj+buildbot
2018-05-04 6:39 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-03 22:18 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 4ea17de8f1985273215b515d48fbd59b2ced3cd1 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 4ea17de8f1985273215b515d48fbd59b2ced3cd1
Use flex's -t option instead of --stdout
As reported in
https://sourceware.org/ml/gdb-patches/2018-05/msg00042.html
some old versions of flex (2.5.4) don't support the --stdout switch.
Use -t, which is an alias.
gdb/ChangeLog:
* Makefile.in (%.c: %.l): Use -t instead of --stdout.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] -Wstringop-truncation warnings
@ 2018-05-04 10:22 sergiodj+buildbot
2018-05-04 14:14 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-04 10:22 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 602f16570454a1597c2af28af66852133432d1f2 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 602f16570454a1597c2af28af66852133432d1f2
-Wstringop-truncation warnings
This patch is aimed at silencing gcc8 -Wstringop-truncation warnings.
Unfortunately adding __attribute__ ((__nonstring)) doesn't work in a
number of the places patched here, (see
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85643) so if you have
recent glibc headers installed you'll need to configure binutils with
--disable-werror to compile using gcc8 or gcc9.
include/
* ansidecl.h: Import from gcc.
* coff/internal.h (struct internal_scnhdr): Add ATTRIBUTE_NONSTRING
to s_name.
(struct internal_syment): Add ATTRIBUTE_NONSTRING to _n_name.
bfd/
* elf-linux-core.h (struct elf_external_linux_prpsinfo32_ugid32),
(struct elf_external_linux_prpsinfo32_ugid16),
(struct elf_external_linux_prpsinfo64_ugid32),
(struct elf_external_linux_prpsinfo64_ugid16): Add ATTRIBUTE_NONSTRING
to pr_fname and pr_psargs fields. Remove GCC diagnostic pragmas.
Move comment to..
* elf.c (elfcore_write_prpsinfo): ..here. Indent nested preprocessor
directives.
* elf32-arm.c (elf32_arm_nabi_write_core_note): Add ATTRIBUTE_NONSTRING
to data.
* elf32-ppc.c (ppc_elf_write_core_note): Likewise.
* elf32-s390.c (elf_s390_write_core_note): Likewise.
* elf64-s390.c (elf_s390_write_core_note): Likewise.
* elfxx-aarch64.c (_bfd_aarch64_elf_write_core_note): Likewise.
* elf64-x86-64.c (elf_x86_64_write_core_note): Add GCC diagnostic
pragmas.
* peXXigen.c (_bfd_XXi_swap_scnhdr_out): Use strnlen to avoid
false positive gcc-8 warning.
gas/
* config/obj-evax.c (shorten_identifier): Use memcpy in place
of strncpy.
* config/obj-macho.c (obj_mach_o_make_or_get_sect): Ensure
segname and sectname fields are NUL terminated.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb/testsuite: Fix broken regexp in gdbstub case
@ 2018-05-04 11:04 sergiodj+buildbot
2018-05-04 15:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-04 11:04 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 089a949083dcd5c679376033e975d54093007408 ***
Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 089a949083dcd5c679376033e975d54093007408
gdb/testsuite: Fix broken regexp in gdbstub case
When $use_gdb_stub is true then, when we start an MI target there's a
regexp to match GDB's startup pattern. Unfortunately the pattern is
broken, and we're also missing a timeout case in the match list (which
would have helped point out that the regexp was broken).
The changes to the regexp are:
1. Remove '${run_match}' prefix, the issued command doesn't include
'${run_prefix}' so expecting '${run_match}' is wrong.
2. Replaced '\\n' with '\\\\n' in order to match literal '\n' in
GDBs output (that is, match a backslash followed by 'n', not a
newline character).
3. Replaced a '.' (matching any character) with '\.' to match a '.'
and moved the '\.' into the correct place in the regexp.
4. Replaced '\r\n' with '[\r\n]+' to match the end of a line. This
change isn't esential, but matches the other end of line patterns
within this regexp.
Here's an example of the output that the regexp should match taken
from a testfile log, the first line is the command sent to GDB, and
the remaining lines are the response from GDB:
jump *_start
&"jump *_start\n"
~"Continuing at 0x10074.\n"
^running
*running,thread-id="all"
(gdb)
gdb/testsuite/ChangeLog:
* lib/mi-support.exp (mi_run_cmd_full): Fix regexp and add a
timeout.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Return std::string from ada_exception_catchpoint_cond_string
@ 2018-05-04 19:36 sergiodj+buildbot
2018-05-05 6:30 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-04 19:36 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT cb7de75eb33b2ceda391c903cac5e5ed63933b99 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: cb7de75eb33b2ceda391c903cac5e5ed63933b99
Return std::string from ada_exception_catchpoint_cond_string
This changes ada_exception_catchpoint_cond_string to return a
std::string, allowing for the removal of a cleanup in
create_excep_cond_exprs.
ChangeLog
2018-05-04 Tom Tromey <tom@tromey.com>
* ada-lang.c (create_excep_cond_exprs): Update.
(ada_exception_catchpoint_cond_string): Use std::string.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Use previous count when 'x' command is repeated
@ 2018-05-04 20:33 sergiodj+buildbot
2018-05-05 13:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-04 20:33 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9be2ae8fc6b908746d9d7ebaf77aec8abba5dd2c ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 9be2ae8fc6b908746d9d7ebaf77aec8abba5dd2c
Use previous count when 'x' command is repeated
About the 'x' command, the manual says:
If you use <RET> to repeat the 'x' command, the repeat count N is
used again; the other arguments default as for successive uses of
'x'.
However, PR gdb/22619 points out that this does not work.
This patch fixes the problem.
ChangeLog
2018-05-04 Tom Tromey <tom@tromey.com>
PR gdb/22619:
* printcmd.c (last_count): New global.
(x_command): Use saved count when repeating.
testsuite/ChangeLog
2018-05-04 Tom Tromey <tom@tromey.com>
PR gdb/22619:
* gdb.base/long_long.exp (gdb_test_long_long): Add test for repeat
behavior.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] (SPARC/LEON) fix incorrect array return value printed by "finish"
@ 2018-05-04 21:12 sergiodj+buildbot
2018-05-05 18:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-04 21:12 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 05bc7456b872b81044d3b0e7c4d74c1de57217fd ***
Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 05bc7456b872b81044d3b0e7c4d74c1de57217fd
(SPARC/LEON) fix incorrect array return value printed by "finish"
Consider the code in the gdb.ada/array_return.exp testcase, which
defines a function returning an array of 2 integers:
type Data_Small is array (1 .. 2) of Integer;
function Create_Small return Data_Small;
When doing a "finish" from inside function Create_Small, we expect
GDB to tell us that the return value was "(1, 1)". However, it currently
prints the wrong value:
(gdb) finish
Run till exit from #0 pck.create_small () at /[...]/pck.adb:5
p () at /[...]/p.adb:10
10 Large := Create_Large;
Value returned is $1 = (0, 0)
This is a regression which I traced back to the following commit...
| commit 1933fd8ee01ad2e74a9c6341bc40f54962a8f889
| Date: Fri May 19 03:06:19 2017 -0700
| Subject: gdb: fix TYPE_CODE_ARRAY handling in sparc targets
... which, despite what the subject says, is not really about
TYPE_CODE_ARRAY handling, which is a bit of an implementation detail,
but about the GNU vectors extension.
The author of the patch equated TYPE_CODE_ARRAY with vectors, which
is not correct. Vectors are TYPE_CODE_ARRAY types with the TYPE_VECTOR
flag set. So at the very minimum, the patch should have been checking
for both TYPE_CODE_ARRAY and TYPE_VECTOR.
But, that's not the only thing that did not seem right to me. When
looking at the ABI, and at the summary of the implementation in GCC
of the calling conventions for that architecture:
size argument return value
small integer <4 int. reg. int. reg.
word 4 int. reg. int. reg.
double word 8 int. reg. int. reg.
_Complex small integer <8 int. reg. int. reg.
_Complex word 8 int. reg. int. reg.
_Complex double word 16 memory int. reg.
vector integer <=8 int. reg. FP reg.
vector integer >8 memory memory
float 4 int. reg. FP reg.
double 8 int. reg. FP reg.
long double 16 memory memory
_Complex float 8 memory FP reg.
_Complex double 16 memory FP reg.
_Complex long double 32 memory FP reg.
vector float any memory memory
aggregate any memory memory
The nice thing about the patch above is that it nicely factorized
the code that determines how arguments are passed/returns. The bad
news is that the implementation, particularly for the handling of
arrays and vectors, doesn't seem to match the summary above. Hence,
the regression we observed.
So what I did was review and re-implement some of the predicate functions
according to the summary above. Because dejagnu crashes all our Solaris
machines real bad, I can't run the dejagnu testsuite there. So what I did
was test the patch with AdaCore's testsuite against leon3-elf, no
regression. I verified that this fixes the regression above while
at the same time still passing gdb.base/gnu_vector.exp (I transposed
that testcase to our testsuite), which is the testcase that was cited
in the commit above as seeing some FAIL->PASS improvements.
This patch also removes one assertion...
gdb_assert (sparc_integral_or_pointer_p (type)
|| (TYPE_CODE (type) == TYPE_CODE_ARRAY && len <= 8));
... because that assertion is really the "negative" of the other conditions
written in the same "if, else if, else [assert]" block in this function.
To me, this assertion forces us to maintain two versions of the same code,
and is an unnecessary burden. In particular, the above is not the
correct condition, and the ABI summary table above shows that we need
a more complex condition to describe the situations where we expect
arguments to be passed by register.
gdb/ChangeLog:
* sparc-tdep.c (sparc_structure_return_p): Re-implement to
match the ABI as summarized in GCC's gcc/config/sparc/sparc.c.
(sparc_arg_by_memory_p): Renamed from sparc_arg_on_registers_p.
Re-implement to match the ABI as summarized in GCC's
gcc/config/sparc/sparc.c. All callers updated.
(sparc32_store_arguments): Remove assertion.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] aarch64: PR 19806: watchpoints: false negatives + PR 20207 contiguous ones
@ 2018-05-04 22:30 sergiodj+buildbot
2018-05-06 5:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-04 22:30 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT a3b60e4588606354b93508a0008a5ca04b68fad8 ***
Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Branch: master
Commit: a3b60e4588606354b93508a0008a5ca04b68fad8
aarch64: PR 19806: watchpoints: false negatives + PR 20207 contiguous ones
Some unaligned watchpoints were currently missed.
On old kernels as specified in
kernel RFE: aarch64: ptrace: BAS: Support any contiguous range (edit)
https://sourceware.org/bugzilla/show_bug.cgi?id=20207
after this patch some other unaligned watchpoints will get reported as false
positives.
With new kernels all the watchpoints should work exactly.
There may be a regresion that it now less merges watchpoints so that with
multiple overlapping watchpoints it may run out of the 4 hardware watchpoint
registers. But as discussed in the original thread GDB needs some generic
watchpoints merging framework to be used by all the target specific code.
Even current FSF GDB code does not merge it perfectly. Also with the more
precise watchpoints one can technically merge them less. And I do not think
it matters too much to improve mergeability only for old kernels.
Still even on new kernels some better merging logic would make sense.
There remains one issue:
kernel-4.15.14-300.fc27.armv7hl
FAIL: gdb.base/watchpoint-unaligned.exp: continue
FAIL: gdb.base/watchpoint-unaligned.exp: continue
(gdb) continue
Continuing.
Unexpected error setting watchpoint: Invalid argument.
(gdb) FAIL: gdb.base/watchpoint-unaligned.exp: continue
But that looks as a kernel bug to me.
(1) It is not a regression by this patch.
(2) It is unrelated to this patch.
gdb/ChangeLog
2018-05-04 Jan Kratochvil <jan.kratochvil@redhat.com>
Pedro Alves <palves@redhat.com>
PR breakpoints/19806 and support for PR external/20207.
* NEWS: Mention Aarch64 watchpoint improvements.
* aarch64-linux-nat.c (aarch64_linux_stopped_data_address): Fix missed
watchpoints and PR external/20207 watchpoints.
* nat/aarch64-linux-hw-point.c
(kernel_supports_any_contiguous_range): New.
(aarch64_watchpoint_offset): New.
(aarch64_watchpoint_length): Support PR external/20207 watchpoints.
(aarch64_point_encode_ctrl_reg): New parameter offset, new asserts.
(aarch64_point_is_aligned): Support PR external/20207 watchpoints.
(aarch64_align_watchpoint): New parameters aligned_offset_p and
next_addr_orig_p. Support PR external/20207 watchpoints.
(aarch64_downgrade_regs): New.
(aarch64_dr_state_insert_one_point): New parameters offset and
addr_orig.
(aarch64_dr_state_remove_one_point): Likewise.
(aarch64_handle_breakpoint): Update caller.
(aarch64_handle_aligned_watchpoint): Likewise.
(aarch64_handle_unaligned_watchpoint): Support addr_orig and
aligned_offset.
(aarch64_linux_set_debug_regs): Remove const from state. Call
aarch64_downgrade_regs.
(aarch64_show_debug_reg_state): Print also dr_addr_orig_wp.
* nat/aarch64-linux-hw-point.h (DR_CONTROL_LENGTH): Rename to ...
(DR_CONTROL_MASK): ... this.
(struct aarch64_debug_reg_state): New field dr_addr_orig_wp.
(unsigned int aarch64_watchpoint_offset): New prototype.
(aarch64_linux_set_debug_regs): Remove const from state.
* utils.c (align_up, align_down): Move to ...
* common/common-utils.c (align_up, align_down): ... here.
* utils.h (align_up, align_down): Move to ...
* common/common-utils.h (align_up, align_down): ... here.
gdb/gdbserver/ChangeLog
2018-05-04 Jan Kratochvil <jan.kratochvil@redhat.com>
Pedro Alves <palves@redhat.com>
* linux-aarch64-low.c (aarch64_stopped_data_address):
Likewise.
gdb/testsuite/ChangeLog
2018-05-04 Jan Kratochvil <jan.kratochvil@redhat.com>
Pedro Alves <palves@redhat.com>
PR breakpoints/19806 and support for PR external/20207.
* gdb.base/watchpoint-unaligned.c: New file.
* gdb.base/watchpoint-unaligned.exp: New file.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master
2018-05-04 22:30 [binutils-gdb] aarch64: PR 19806: watchpoints: false negatives + PR 20207 contiguous ones sergiodj+buildbot
@ 2018-05-06 5:46 ` sergiodj+buildbot
0 siblings, 0 replies; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-06 5:46 UTC (permalink / raw)
To: gdb-testers
Buildslave:
ubuntu-trusty-aarch32-1
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-native-gdbserver-m32/builds/3310>
Commit(s) tested:
a3b60e4588606354b93508a0008a5ca04b68fad8
Author(s) (in the same order as the commits):
Jan Kratochvil <jan.kratochvil@redhat.com>
Subject:
aarch64: PR 19806: watchpoints: false negatives + PR 20207 contiguous ones
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-native-gdbserver-m32/a3/a3b60e4588606354b93508a0008a5ca04b68fad8/>
*** Diff to previous build ***
============================
new FAIL: gdb.base/watchpoint-unaligned.exp: wp
new FAIL: gdb.base/watchpoint-unaligned.exp: continue
new FAIL: gdb.base/watchpoint-unaligned.exp: delete 26
new FAIL: gdb.base/watchpoint-unaligned.exp: rwatch data.u.size1[1]
new FAIL: gdb.base/watchpoint-unaligned.exp: set variable size = 2
new FAIL: gdb.base/watchpoint-unaligned.exp: set variable offset = 1
new FAIL: gdb.base/watchpoint-unaligned.exp: delete
new FAIL: gdb.base/watchpoint-unaligned.exp: set variable offset = 2
new FAIL: gdb.base/watchpoint-unaligned.exp: set variable offset = 3
new FAIL: gdb.base/watchpoint-unaligned.exp: set variable size = 4
new FAIL: gdb.base/watchpoint-unaligned.exp: set variable offset = 0
new FAIL: gdb.base/watchpoint-unaligned.exp: set variable size = 8
new FAIL: gdb.base/watchpoint-unaligned.exp: rwatch data.u.size1[2]
new FAIL: gdb.base/watchpoint-unaligned.exp: set variable size = 1
new FAIL: gdb.base/watchpoint-unaligned.exp: set variable offset = 4
new FAIL: gdb.base/watchpoint-unaligned.exp: set variable offset = 5
new FAIL: gdb.base/watchpoint-unaligned.exp: set variable offset = 6
new FAIL: gdb.base/watchpoint-unaligned.exp: set variable offset = 7
new FAIL: gdb.base/watchpoint-unaligned.exp: rwatch data.u.size1[3]
new FAIL: gdb.base/watchpoint-unaligned.exp: rwatch data.u.size1[4]
new FAIL: gdb.base/watchpoint-unaligned.exp: rwatch data.u.size1[5]
new FAIL: gdb.base/watchpoint-unaligned.exp: rwatch data.u.size1[6]
new FAIL: gdb.base/watchpoint-unaligned.exp: rwatch data.u.size1[7]
new FAIL: gdb.base/watchpoint-unaligned.exp: rwatch data.u.size2[0]
new FAIL: gdb.base/watchpoint-unaligned.exp: rwatch data.u.size2[1]
new FAIL: gdb.base/watchpoint-unaligned.exp: rwatch data.u.size2[2]
new FAIL: gdb.base/watchpoint-unaligned.exp: rwatch data.u.size2[3]
new FAIL: gdb.base/watchpoint-unaligned.exp: rwatch data.u.size4[0]
new FAIL: gdb.base/watchpoint-unaligned.exp: rwatch data.u.size4[1]
new FAIL: gdb.base/watchpoint-unaligned.exp: rwatch data.u.size8[0]
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
============================
*** Complete list of XFAILs for this builder ***
To obtain the list of XFAIL tests for this builder, go to:
<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Ubuntu-AArch32-native-gdbserver-m32/xfails/master/xfail?id=>
You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:
<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Ubuntu-AArch32-native-gdbserver-m32/xfails/master/xfail.table?id=>
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Let gdb.execute handle multi-line commands
@ 2018-05-05 1:57 sergiodj+buildbot
2018-05-09 16:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-05 1:57 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 56bcdbea2bed27ea83bf0e4fe472ab744b4beaa1 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 56bcdbea2bed27ea83bf0e4fe472ab744b4beaa1
Let gdb.execute handle multi-line commands
This changes the Python API so that gdb.execute can now handle
multi-line commands, like "commands" or "define".
ChangeLog
2018-05-04 Tom Tromey <tom@tromey.com>
PR python/22730:
* NEWS: Mention gdb.execute change.
* gdbcmd.h (execute_control_command): Don't declare.
* python/python.c (execute_gdb_command): Use read_command_lines_1,
execute_control_commands, execute_control_commands_to_string.
* cli/cli-script.h (execute_control_commands)
(execute_control_commands_to_string): Declare.
(execute_control_command): Add from_tty parameter.
* cli/cli-script.c (execute_control_commands)
(execute_control_commands_to_string): New functions.
(execute_user_command): Use execute_control_commands.
(execute_control_command_1): Add "from_tty" parameter. Update.
(execute_control_command): Likewise.
testsuite/ChangeLog
2018-05-04 Tom Tromey <tom@tromey.com>
PR python/22730:
* gdb.python/python.exp: Test multi-line execute.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Add two fall-through comments in rs6000-tdep.c
@ 2018-05-05 7:23 sergiodj+buildbot
2018-05-12 19:30 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-05 7:23 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e3829d13f6d0615f663d2a85ef4281a4365a947c ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: e3829d13f6d0615f663d2a85ef4281a4365a947c
Add two fall-through comments in rs6000-tdep.c
This adds two fall-through comments in rs6000-tdep.c. I looked at the
PPC instruction manual and convinced myself that this was correct.
And, this isn't a semantic change. However, close review would still
be good.
2018-05-04 Tom Tromey <tom@tromey.com>
* rs6000-tdep.c (ppc_process_record_op4)
(ppc_process_record_op63): Add fall-through comment.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Cleanup ppc code dealing with opcode dumps.
@ 2018-05-07 15:05 sergiodj+buildbot
2018-05-17 9:13 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-07 15:05 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2ceb7719f763b9e541a379d8ac7d53a72794fdd4 ***
Author: Peter Bergner <bergner@vnet.ibm.com>
Branch: master
Commit: 2ceb7719f763b9e541a379d8ac7d53a72794fdd4
Cleanup ppc code dealing with opcode dumps.
include/
* opcode/ppc.h (powerpc_num_opcodes): Change type to unsigned.
(vle_num_opcodes): Likewise.
(spe2_num_opcodes): Likewise.
opcodes/
* ppc-opc.c (powerpc_num_opcodes): Likewise.
(vle_num_opcodes): Likewise.
(spe2_num_opcodes): Likewise.
* ppc-dis.c (disassemble_init_powerpc) <powerpc_opcd_indices>: Rewrite
initialization loop.
(disassemble_init_powerpc) <vle_opcd_indices>: Likewise.
(disassemble_init_powerpc) <spe2_opcd_indices>: Likewise. Initialize
only once.
gas/
* config/tc-ppc.c (ppc_setup_opcodes) <powerpc_opcodes>: Rewrite code
to dump the entire opcode table.
(ppc_setup_opcodes) <spe2_opcodes>: Likewise.
(ppc_setup_opcodes) <vle_opcodes>: Likewise. Fix calculation of
opcode index.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Correct powerpc spe opcode lookup
@ 2018-05-08 14:08 sergiodj+buildbot
2018-06-09 4:32 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-08 14:08 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT f413a91378902aadbe4e338a6dc8f33f5f7148a0 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: f413a91378902aadbe4e338a6dc8f33f5f7148a0
Correct powerpc spe opcode lookup
Defining SPE2_OPCD_SEGS as 13 discounts the possibility that we'd
ever look up spe2_opcd_indices[14..16], which I think is possible.
Extend that array to size 16+1, using the macros we use to index the
array. Similarly use the index macros for PPC_OPCD_SEGS and
VLE_OPCD_SEGS.
* ppc-dis.c (PPC_OPCD_SEGS): Define using PPC_OP.
(VLE_OPCD_SEGS, SPE2_OPCD_SEGS): Similarly, using macros used to
partition opcode space for index lookup.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] PR23147, Heap buffer overflow in pe_print_idata
@ 2018-05-09 5:28 sergiodj+buildbot
2018-06-12 17:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-09 5:28 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 53db9cf9fc363fd8ab3a9d97cdcb2ea1f639a243 ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 53db9cf9fc363fd8ab3a9d97cdcb2ea1f639a243
PR23147, Heap buffer overflow in pe_print_idata
PR 23147
* peXXigen.c (pe_print_idata): Bound check hint_addr.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix tagged pointer support
@ 2018-05-10 10:11 sergiodj+buildbot
2018-06-16 14:59 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-10 10:11 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 8727de56b0dbe25b7b4a3bd04f72ac41992463ed ***
Author: Omair Javaid <omair.javaid@linaro.org>
Branch: master
Commit: 8727de56b0dbe25b7b4a3bd04f72ac41992463ed
Fix tagged pointer support
This patch fixes tagged pointer support for AArch64 GDB. Linux kernel
debugging failure was reported after tagged pointer support was committed.
After a discussion around best path forward to manage tagged pointers
on GDB side we are going to disable tagged pointers support for
aarch64-none-elf-gdb because for non-linux applications we cant be
sure if tagged pointers will be used by MMU or not.
Also for aarch64-linux-gdb we are going to sign extend user-space
address after clearing tag bits. This will help debug both kernel
and user-space addresses based on information from linux kernel
documentation given below:
According to AArch64 memory map:
https://www.kernel.org/doc/Documentation/arm64/memory.txt
"User addresses have bits 63:48 set to 0 while the kernel addresses have
the same bits set to 1."
According to AArch64 tagged pointers document:
https://www.kernel.org/doc/Documentation/arm64/tagged-pointers.txt
The kernel configures the translation tables so that translations made
via TTBR0 (i.e. userspace mappings) have the top byte (bits 63:56) of
the virtual address ignored by the translation hardware. This frees up
this byte for application use.
Running gdb testsuite after applying this patch introduces no regressions
and tagged pointer test cases still pass.
gdb/ChangeLog:
2018-05-10 Omair Javaid <omair.javaid@linaro.org>
PR gdb/23127
* aarch64-linux-tdep.c (aarch64_linux_init_abi): Add call to
set_gdbarch_significant_addr_bit.
* aarch64-tdep.c (aarch64_gdbarch_init): Remove call to
set_gdbarch_significant_addr_bit.
* utils.c (address_significant): Update to sign extend addr.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master
2018-05-10 10:11 [binutils-gdb] Fix tagged pointer support sergiodj+buildbot
@ 2018-06-16 14:59 ` sergiodj+buildbot
0 siblings, 0 replies; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-06-16 14:59 UTC (permalink / raw)
To: gdb-testers
Buildslave:
ubuntu-trusty-aarch32-1
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-native-gdbserver-m32/builds/3419>
Commit(s) tested:
8727de56b0dbe25b7b4a3bd04f72ac41992463ed
Author(s) (in the same order as the commits):
Omair Javaid <omair.javaid@linaro.org>
Subject:
Fix tagged pointer support
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-native-gdbserver-m32/87/8727de56b0dbe25b7b4a3bd04f72ac41992463ed/>
*** Diff to previous build ***
============================
PASS -> FAIL: gdb.base/auxv.exp: matching auxv data from live and gcore
PASS -> FAIL: gdb.base/gcore.exp: where in corefile
new FAIL: gdb.base/gcore.exp: capture_command_output for print array_func::local_array
PASS -> FAIL: gdb.base/gcore.exp: corefile restored stack array
PASS -> FAIL: gdb.base/gcore.exp: corefile restored backtrace
new FAIL: gdb.base/gcore-relro-pie.exp: can't run to break_here
new FAIL: gdb.base/pie-fork.exp: test_detach_on_fork_follow_parent: can't run to main
PASS -> FAIL: gdb.base/pie-fork.exp: test_detach_on_fork_follow_parent: continue
new FAIL: gdb.base/pie-fork.exp: test_detach_on_fork_follow_child: can't run to main
PASS -> FAIL: gdb.base/pie-fork.exp: test_detach_on_fork_follow_child: continue
new FAIL: gdb.base/pie-fork.exp: test_no_detach_on_fork: can't run to main
PASS -> FAIL: gdb.base/pie-fork.exp: test_no_detach_on_fork: continue
PASS -> FAIL: gdb.base/pie-fork.exp: test_no_detach_on_fork: thread 2.1
PASS -> FAIL: gdb.base/recurse.exp: continue to first instance watchpoint, first time
PASS -> FAIL: gdb.base/recurse.exp: continue to recurse
PASS -> FAIL: gdb.base/recurse.exp: continue to second instance watchpoint, first time
PASS -> FAIL: gdb.base/recurse.exp: continue to second instance watchpoint, second time
PASS -> FAIL: gdb.base/recurse.exp: second instance watchpoint deleted when leaving scope
PASS -> FAIL: gdb.base/recurse.exp: continue to first instance watchpoint, second time
PASS -> FAIL: gdb.base/recurse.exp: first instance watchpoint deleted when leaving scope
PASS -> FAIL: gdb.base/reread.exp: opts= "-fPIE" "ldflags=-pie" : run to foo
new FAIL: gdb.base/reread.exp: opts= "-fPIE" "ldflags=-pie" : shell sleep 1
PASS -> FAIL: gdb.base/reread.exp: opts= "-fPIE" "ldflags=-pie" : second pass: run to foo
PASS -> FAIL: gdb.base/reread.exp: opts= "-fPIE" "ldflags=-pie" : continue until exit at second pass
PASS -> FAIL: gdb.base/solib-search.exp: backtrace
PASS -> FAIL: gdb.base/watch-cond.exp: watchpoint with local expression, local condition evaluates in correct frame
PASS -> FAIL: gdb.base/watchpoint.exp: trigger local watch
PASS -> FAIL: gdb.base/watchpoint.exp: self-delete local watch
PASS -> FAIL: gdb.base/watchpoint.exp: trigger2 partially local watch
PASS -> FAIL: gdb.base/watchpoint.exp: self-delete partially local watch
PASS -> FAIL: gdb.base/watchpoint.exp: set static local watch
PASS -> FAIL: gdb.base/watchpoint.exp: trigger static local watch
PASS -> FAIL: gdb.base/watchpoint.exp: continue after trigger static local watch
PASS -> FAIL: gdb.base/watchpoint.exp: static local watch did not self-delete
PASS -> FAIL: gdb.base/watchpoint.exp: cont
PASS -> FAIL: gdb.base/watchpoint.exp: next past local_x initialization
PASS -> FAIL: gdb.base/watchpoint.exp: set local watch in recursive call
PASS -> FAIL: gdb.base/watchpoint.exp: trigger local watch in recursive call
PASS -> FAIL: gdb.base/watchpoint.exp: self-delete local watch in recursive call
PASS -> FAIL: gdb.base/watchpoint.exp: set local watch in recursive call with explicit scope
PASS -> FAIL: gdb.base/watchpoint.exp: trigger local watch with explicit scope in recursive call
PASS -> FAIL: gdb.base/watchpoint.exp: self-delete local watch with explicit scope in recursive call
PASS -> FAIL: gdb.base/watchpoint.exp: continue until exit at continue to exit in test_complex_watchpoint
PASS -> FAIL: gdb.base/watchpoint.exp: next after watch x
PASS -> FAIL: gdb.base/watchpoint.exp: continue with watch -location
PASS -> FAIL: gdb.base/watchpoint.exp: continue to breakpoint: func6 breakpoint here
PASS -> FAIL: gdb.base/watchpoint.exp: continue with watch foo2
PASS -> FAIL: gdb.base/watchpoint.exp: continue to breakpoint: func7 breakpoint here
PASS -> FAIL: gdb.base/watchpoint.exp: continue with watch foo4
PASS -> FAIL: gdb.base/watchpoint.exp: rwatch disallowed for register based expression
PASS -> FAIL: gdb.base/watchpoint.exp: awatch disallowed for register based expression
PASS -> FAIL: gdb.cp/annota2.exp: watch triggered on a.x
PASS -> FAIL: gdb.cp/annota2.exp: annotate-quit
PASS -> FAIL: gdb.cp/annota3.exp: watch triggered on a.x
PASS -> FAIL: gdb.cp/annota3.exp: annotate-quit
PASS -> FAIL: gdb.mi/mi-watch.exp: mi-mode=main: wp-type=hw: watchpoint trigger
PASS -> FAIL: gdb.mi/mi-watch.exp: mi-mode=separate: wp-type=hw: watchpoint trigger
PASS -> FAIL: gdb.reverse/finish-precsave.exp: continue to breakpoint: void_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: finish from void_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: continue to breakpoint: char_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: finish from char_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: continue to breakpoint: short_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: finish from short_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: continue to breakpoint: int_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: finish from int_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: continue to breakpoint: long_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: finish from long_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: continue to breakpoint: long_long_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: finish from long_long_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: reverse finish from long_long_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: reverse finish from long_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: reverse finish from int_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: reverse finish from short_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: reverse finish from char_func
PASS -> FAIL: gdb.reverse/finish-precsave.exp: reverse finish from void_func
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: auto var reverse-breakpoint
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: auto var forward
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: auto var reverse-step
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: auto var forward-breakpoint
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: auto var forward step-to
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: auto var step post-change
PASS -> FAIL: gdb.reverse/solib-precsave.exp: reverse-step third shr1
PASS -> FAIL: gdb.reverse/solib-precsave.exp: reverse-step second shr1
PASS -> FAIL: gdb.reverse/solib-precsave.exp: reverse-step first shr1
PASS -> FAIL: gdb.reverse/solib-precsave.exp: reverse-step generic
PASS -> FAIL: gdb.reverse/solib-precsave.exp: reverse-next third shr1
PASS -> FAIL: gdb.reverse/solib-precsave.exp: reverse-next second shr1
PASS -> FAIL: gdb.reverse/solib-precsave.exp: reverse-next first shr1
PASS -> FAIL: gdb.reverse/solib-precsave.exp: reverse-next generic
PASS -> FAIL: gdb.reverse/solib-precsave.exp: reverse-step into solib function one
PASS -> FAIL: gdb.reverse/solib-precsave.exp: reverse-step within solib function one
PASS -> FAIL: gdb.reverse/solib-precsave.exp: reverse-step back to main one
PASS -> FAIL: gdb.reverse/solib-precsave.exp: reverse-step into solib function two
PASS -> FAIL: gdb.reverse/solib-precsave.exp: reverse-step within solib function two
PASS -> FAIL: gdb.reverse/solib-precsave.exp: reverse-step back to main two
PASS -> FAIL: gdb.reverse/solib-precsave.exp: run until end part two
PASS -> FAIL: gdb.reverse/solib-precsave.exp: reverse-next over solib function one
PASS -> FAIL: gdb.reverse/solib-precsave.exp: reverse-next over solib function two
PASS -> FAIL: gdb.reverse/step-precsave.exp: finish out of fn call
PASS -> FAIL: gdb.reverse/step-precsave.exp: simple stepi
PASS -> FAIL: gdb.reverse/step-precsave.exp: stepi back from function call
PASS -> FAIL: gdb.reverse/step-precsave.exp: reverse stepi from a function call
PASS -> FAIL: gdb.reverse/step-precsave.exp: simple reverse stepi
PASS -> FAIL: gdb.reverse/step-precsave.exp: reverse step out of called fn
PASS -> FAIL: gdb.reverse/step-precsave.exp: reverse next over call
PASS -> FAIL: gdb.reverse/step-precsave.exp: reverse step test 1
PASS -> FAIL: gdb.reverse/step-precsave.exp: reverse next test 1
PASS -> FAIL: gdb.reverse/step-precsave.exp: reverse step test 2
PASS -> FAIL: gdb.reverse/step-precsave.exp: reverse next test 2
PASS -> FAIL: gdb.reverse/until-precsave.exp: advance to factorial
PASS -> FAIL: gdb.reverse/until-precsave.exp: until factorial, recursive function
PASS -> FAIL: gdb.reverse/until-precsave.exp: finish to main
PASS -> FAIL: gdb.reverse/until-precsave.exp: advance to marker2
PASS -> FAIL: gdb.reverse/until-precsave.exp: until func, not called by current frame
PASS -> FAIL: gdb.reverse/until-precsave.exp: reverse-advance to marker2
PASS -> FAIL: gdb.reverse/until-precsave.exp: reverse-finish from marker2
PASS -> FAIL: gdb.reverse/until-precsave.exp: reverse-advance to final return of factorial
PASS -> FAIL: gdb.reverse/until-precsave.exp: reverse-until to entry of factorial
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit, first time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit, second time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit, third time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit, fourth time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit, fifth time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: continue to breakpoint: marker2
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit in reverse, first time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit in reverse, second time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit in reverse, third time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit in reverse, fourth time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit in reverse, fifth time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit, forward replay, first time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit, forward replay, second time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit, forward replay, third time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit, forward replay, fourth time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit, forward replay, fifth time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: replay forward to marker2
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit in reverse, HW, first time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit in reverse, HW, second time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit in reverse, HW, third time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit in reverse, HW, fourth time
PASS -> FAIL: gdb.reverse/watch-precsave.exp: watchpoint hit in reverse, HW, fifth time
============================
*** Complete list of XFAILs for this builder ***
To obtain the list of XFAIL tests for this builder, go to:
<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Ubuntu-AArch32-native-gdbserver-m32/xfails/master/xfail?id=>
You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:
<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Ubuntu-AArch32-native-gdbserver-m32/xfails/master/xfail.table?id=>
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb: xtensa: drop gdb_target definition
@ 2018-05-12 1:03 sergiodj+buildbot
2018-06-23 10:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-12 1:03 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 67e6f569eb32332b8a70a919b0b14012247d320a ***
Author: Max Filippov <jcmvbkbc@gmail.com>
Branch: master
Commit: 67e6f569eb32332b8a70a919b0b14012247d320a
gdb: xtensa: drop gdb_target definition
gdb_target definitions were removed from configure.tgt in 2007, before
xtensa port was merged. Remove it from the xtensa target as well.
gdb/
2018-05-11 Max Filippov <jcmvbkbc@gmail.com>
* configure.tgt (xtensa*-*-linux*): Drop gdb_target definition.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Fix error messages in the NFP sources when building for 32-bit targets.
@ 2018-05-15 13:56 sergiodj+buildbot
2018-06-28 0:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-15 13:56 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 1678bd35a35a3bace2d4aee39b64d96c638651f0 ***
Author: Francois H. Theron <francois.theron@netronome.com>
Branch: master
Commit: 1678bd35a35a3bace2d4aee39b64d96c638651f0
Fix error messages in the NFP sources when building for 32-bit targets.
bfd * targets.c: Wrap nfp_elf64_vec in BFD64 ifdef.
include * opcode/nfp.h: Use uint64_t instead of bfd_vma.
opcodes * nfp-dis.c: Use uint64_t for instruction variables, not bfd_vma.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] testsuite: Fix a `server_pid' access crash in gdb.server/server-kill.exp
@ 2018-05-15 15:48 sergiodj+buildbot
2018-06-28 21:39 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-15 15:48 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 0726fcc61a8b7c943de513ec598b2189c5f67715 ***
Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 0726fcc61a8b7c943de513ec598b2189c5f67715
testsuite: Fix a `server_pid' access crash in gdb.server/server-kill.exp
Fix a commit f90183d7e31b ("Get GDBserver pid on remote target") bug and
correctly handle the case where the PID of `gdbserver' could not have
been retrieved. If that happens, $server_pid is unset causing:
FAIL: gdb.server/server-kill.exp: p server_pid
ERROR: tcl error sourcing .../gdb/testsuite/gdb.server/server-kill.exp.
ERROR: can't read "server_pid": no such variable
while executing
"if {$server_pid == "" } {
return -1
}"
(file ".../gdb/testsuite/gdb.server/server-kill.exp" line 49)
invoked from within
"source .../gdb/testsuite/gdb.server/server-kill.exp"
("uplevel" body line 1)
invoked from within
"uplevel #0 source .../gdb/testsuite/gdb.server/server-kill.exp"
invoked from within
"catch "uplevel #0 source $test_file_name""
Verify that the variable exists then rather than trying to access it.
gdb/testsuite/
* gdb.server/server-kill.exp: Verify whether `server_pid' exists
rather then trying to access it in determining whether the PID
of `gdbserver' could have been retrieved.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] MIPS: Make `mask_address_var' static
@ 2018-05-15 17:55 sergiodj+buildbot
2018-06-29 15:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-15 17:55 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ea33cd9290063d977fb2c31ea6a8567da585ab88 ***
Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: ea33cd9290063d977fb2c31ea6a8567da585ab88
MIPS: Make `mask_address_var' static
Make the `mask_address_var' variable static, it is not used outside
mips-tdep.c and having no target name embedded within it causes a risk
of a namespace clash.
gdb/
* mips-tdep.c (mask_address_var): Make variable static.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] value.c: Remove unused variables
@ 2018-05-17 15:50 sergiodj+buildbot
2018-07-07 6:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-17 15:50 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 3e6188349fbf16e9da69837e5e1211537805e422 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 3e6188349fbf16e9da69837e5e1211537805e422
value.c: Remove unused variables
Obvious patch to remove unused local variables (found by adding
-Wunused). I didn't touch this one in value_fetch_lazy, because
check_typedef could have a desired side-effect.
3743 struct type *type = check_typedef (value_type (val));
gdb/ChangeLog:
* value.c (release_value): Remove unused variable.
(record_latest_value): Likewise.
(access_value_history): Likewise.
(preserve_values): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Don't elide all inlined frames
@ 2018-05-18 0:01 sergiodj+buildbot
2018-07-09 2:51 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-18 0:01 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ddfe970e6bec29f779a60b071f12590e53cfe6eb ***
Author: Keith Seitz <keiths@redhat.com>
Branch: master
Commit: ddfe970e6bec29f779a60b071f12590e53cfe6eb
Don't elide all inlined frames
This patch essentially causes GDB to treat inlined frames like "normal"
frames from the user's perspective. This means, for example, that when a
user sets a breakpoint in an inlined function, GDB will now actually stop
"in" that function.
Using the test case from breakpoints/17534,
3 static inline void NVIC_EnableIRQ(int IRQn)
4 {
5 volatile int y;
6 y = IRQn;
7 }
8
9 __attribute__( ( always_inline ) ) static inline void __WFI(void)
10 {
11 __asm volatile ("nop");
12 }
13
14 int main(void) {
15
16 x= 42;
17
18 if (x)
19 NVIC_EnableIRQ(16);
20 else
21 NVIC_EnableIRQ(18);
(gdb) b NVIC_EnableIRQ
Breakpoint 1 at 0x4003e4: NVIC_EnableIRQ. (2 locations)
(gdb) r
Starting program: 17534
Breakpoint 1, main () at 17534.c:19
19 NVIC_EnableIRQ(16);
Because skip_inline_frames currently skips every inlined frame, GDB "stops"
in the caller. This patch adds a new parameter to skip_inline_frames
that allows us to pass in a bpstat stop chain. The breakpoint locations
on the stop chain can be used to determine if we've stopped inside an inline
function (due to a user breakpoint). If we have, we do not elide the frame.
With this patch, GDB now reports that the inferior has stopped inside the
inlined function:
(gdb) r
Starting program: 17534
Breakpoint 1, NVIC_EnableIRQ (IRQn=16) at 17534.c:6
6 y = IRQn;
Many thanks to Jan and Pedro for guidance on this.
gdb/ChangeLog:
* breakpoint.c (build_bpstat_chain): New function, moved from
bpstat_stop_status.
(bpstat_stop_status): Add optional parameter, `stop_chain'.
If no stop chain is passed, call build_bpstat_chain to build it.
* breakpoint.h (build_bpstat_chain): Declare.
(bpstat_stop_status): Move documentation here from breakpoint.c.
* infrun.c (handle_signal_stop): Before eliding inlined frames,
build the stop chain and pass it to skip_inline_frames.
Pass this stop chain to bpstat_stop_status.
* inline-frame.c: Include breakpoint.h.
(stopped_by_user_bp_inline_frame): New function.
(skip_inline_frames): Add parameter `stop_chain'.
Move documention to inline-frame.h.
If non-NULL, use stopped_by_user_bp_inline_frame to determine
whether the frame should be elided.
* inline-frame.h (skip_inline_frames): Add parameter `stop_chain'.
Add moved documentation and update for new parameter.
gdb/testsuite/ChangeLog:
* gdb.ada/bp_inlined_func.exp: Update inlined frame locations
in expected breakpoint stop locations.
* gdb.dwarf2/implptr.exp (implptr_test_baz): Use up/down to
move to proper scope to test variable values.
* gdb.opt/inline-break.c (inline_func1, not_inline_func1)
(inline_func2, not_inline_func2, inline_func3, not_inline_func3):
New functions.
(main): Call not_inline_func3.
* gdb.opt/inline-break.exp: Start inferior and set breakpoints at
inline_func1, inline_func2, and inline_func3. Test that when each
breakpoint is hit, GDB properly reports both the stop location
and the backtrace. Repeat tests for temporary breakpoints.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] format_pieces-selftests.c: Silence ARI warnings
@ 2018-05-18 22:33 sergiodj+buildbot
2018-07-16 2:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-18 22:33 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 1d143c36eedc0f0b124e6aa6fb3b98b1e6ff74b0 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 1d143c36eedc0f0b124e6aa6fb3b98b1e6ff74b0
format_pieces-selftests.c: Silence ARI warnings
Silence this:
unittests/format_pieces-selftests.c:51: warning: code: Do not use printf("%ll"), instead use printf("%s",phex()) to dump a `long long' value
unittests/format_pieces-selftests.c:56: warning: code: Do not use printf("%ll"), instead use printf("%s",phex()) to dump a `long long' value
gdb/ChangeLog:
* unittests/format_pieces-selftests.c (test_format_specifier):
Add ARI comments.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86: Don't set eh->local_ref to 1 for versioned symbol
@ 2018-05-19 3:50 sergiodj+buildbot
2018-07-26 1:08 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-19 3:50 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 97373b2eba6077d5059370a95931b93a8b118813 ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 97373b2eba6077d5059370a95931b93a8b118813
x86: Don't set eh->local_ref to 1 for versioned symbol
bfd_hide_sym_by_version can't be used to check if a versioned symbol is
hidden. It has to be synced with _bfd_elf_link_assign_sym_version to
get the correct answer.
bfd/
PR ld/23194
* elfxx-x86.c (_bfd_x86_elf_link_symbol_references_local): Don't
set eh->local_ref to 1 if a symbol is versioned and there is a
version script.
ld/
PR ld/23194
* testsuite/ld-i386/i386.exp: Run pr23194.
* testsuite/ld-x86-64/x86-64.exp: Likewise.
* testsuite/ld-i386/pr23194.d: New file.
* testsuite/ld-i386/pr23194.map: Likewise.
* testsuite/ld-i386/pr23194.s: Likewise.
* testsuite/ld-x86-64/pr23194.d: Likewise.
* testsuite/ld-x86-64/pr23194.map: Likewise.
* testsuite/ld-x86-64/pr23194.s: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove useless variable int i in backtrace_command_1
@ 2018-05-20 0:37 sergiodj+buildbot
2018-07-26 21:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-20 0:37 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 59f66be3aca7ef310c1d4464e93b251fe87135e0 ***
Author: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Branch: master
Commit: 59f66be3aca7ef310c1d4464e93b251fe87135e0
Remove useless variable int i in backtrace_command_1
value of int i was not used in the loop or after the loop.
Pushed as obvious.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove cleanup from ada-lang.c
@ 2018-05-21 18:22 sergiodj+buildbot
2018-07-29 23:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-21 18:22 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 6f46ac8531ead61003c96b8e2fa6a383ea8d8c58 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 6f46ac8531ead61003c96b8e2fa6a383ea8d8c58
Remove cleanup from ada-lang.c
This removes a cleanup from ada-lang.c by having
ada_exception_message_1 return a unique_xmalloc_ptr.
ChangeLog
2018-05-21 Tom Tromey <tom@tromey.com>
* ada-lang.c (ada_exception_message_1, ada_exception_message):
Return unique_xmalloc_ptr.
(print_it_exception): Update.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] MIPS/Linux: Disable n32 USR `ptrace' accesses to 64-bit registers
@ 2018-05-22 1:57 sergiodj+buildbot
2018-08-03 9:57 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-22 1:57 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 75d74ccace05f6166a45dbaa352abf753891d3be ***
Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 75d74ccace05f6166a45dbaa352abf753891d3be
MIPS/Linux: Disable n32 USR `ptrace' accesses to 64-bit registers
On the MIPS target DSP ASE registers can only be accessed with the
PTRACE_PEEKUSR and PTRACE_POKEUSR `ptrace' requests. With the n32 ABI
these requests only pass 32-bit data quantities, which are narrower than
the width of DSP accumulator registers, which are 64-bit.
Generic code is prepared to transfer registers wider than the `ptrace'
data type by offsetting into the USR address space, by the data width
transferred. That however does not work with the MIPS target, because
of how the API has been defined, where USR register addresses are
actually indices rather than offsets. Consequently given address `a'
using `a + 4' accesses the fourth next register rather than the upper
half of the original register.
With native debugging this causes clobbered register contents, as well
as access failures as locations beyond the available USR space are
addressed:
(gdb) info registers
zero at v0 v1
R0 0000000000000000 0000000000000001 0000000000000001 0000000000000000
a0 a1 a2 a3
R4 0000000010019158 0000000000000000 0000000000000011 0000000010019160
a4 a5 a6 a7
R8 0000000010019160 fffffffffff00000 fffffffffffffff8 0000000000000000
t0 t1 t2 t3
R12 0000000010019150 0000000000000001 0000000000000001 000000000000000f
s0 s1 s2 s3
R16 0000000077ee6f20 0000000010007bb0 0000000000000000 0000000000000000
s4 s5 s6 s7
R20 000000000052e668 000000000052f008 0000000000000000 0000000000000000
t8 t9 k0 k1
R24 0000000000000001 0000000010019010 0000000000000000 0000000000000000
gp sp s8 ra
R28 0000000010020280 000000007fff4c10 000000007fff4c10 0000000010004f48
status lo hi badvaddr
0000000000109cf3 0000000000943efe 000000000000000e 000000001001900c
cause pc
0000000000800024 0000000010004f48
fcsr fir hi1 lo1
0e800000 00f30000 0000000004040404 0101010105050505
hi2 lo2 hi3 lo3
0202020255aa33cc Couldn't read register (#75): Input/output error.
(gdb)
With `gdbserver' this makes debugging impossible due to a fatal failure:
(gdb) target remote :2346
Remote debugging using :2346
Reading symbols from .../sysroot/mips-r2-hard/lib32/ld.so.1...done.
0x77fc3d50 in __start () from .../sysroot/mips-r2-hard/lib32/ld.so.1
(gdb) continue
Continuing.
warning: Remote failure reply: E01
Remote communication error. Target disconnected.: Connection reset by peer.
(gdb)
Correct the problem by marking any register in the MIPS backend whose
width exceeds the width of the `ptrace' data type unavailable for the
purpose of PTRACE_PEEKUSR and PTRACE_POKEUSR requests:
(gdb) info registers
zero at v0 v1
R0 0000000000000000 0000000000000001 0000000000000001 0000000000000000
a0 a1 a2 a3
R4 0000000010019158 0000000000000000 0000000000000011 0000000010019160
a4 a5 a6 a7
R8 0000000010019160 fffffffffff00000 fffffffffffffff8 0000000000000000
t0 t1 t2 t3
R12 0000000010019150 0000000000000001 0000000000000001 000000000000000f
s0 s1 s2 s3
R16 0000000077ee6f20 0000000010007bb0 0000000000000000 0000000000000000
s4 s5 s6 s7
R20 000000000052e5c8 000000000052f008 0000000000000000 0000000000000000
t8 t9 k0 k1
R24 0000000000000001 0000000010019010 0000000000000000 0000000000000000
gp sp s8 ra
R28 0000000010020280 000000007fff4be0 000000007fff4be0 0000000010004f48
status lo hi badvaddr
0000000000109cf3 0000000000943efe 000000000000000e 000000001001900c
cause pc
0000000000800024 0000000010004f48
fcsr fir hi1 lo1
0e800000 00f30000 <unavailable> <unavailable>
hi2 lo2 hi3 lo3
<unavailable> <unavailable> <unavailable> <unavailable>
dspctl restart
55aa33cc 0000000000000000
(gdb)
as there is no way to access full contents of these registers with the
limited API available anyway.
This obviously does not affect general-purpose registers (which use the
PTRACE_GETREGS and PTRACE_SETREGS requests for access) or floating-point
general registers (which use PTRACE_GETFPREGS and PTRACE_SETFPREGS).
And $dspctl, being 32-bit, remains accessible too, which is important
for BPOSGE32 branch decoding in single-stepping.
For DSP accumulator access with the n32 ABI a new `ptrace' API is required
on the kernel side.
gdb/
* mips-linux-nat.c (mips64_linux_register_addr): Return -1 if
the width of the requested register exceeds the width of the
`ptrace' data type.
gdb/gdbserver/
* linux-mips-low.c (mips_cannot_fetch_register): Return 1 if the
width of the requested register exceeds the width of the
`ptrace' data type.
(mips_cannot_store_register): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] ld: Hide symbols defined by HIDDEN/PROVIDE_HIDDEN
@ 2018-05-22 4:46 sergiodj+buildbot
2018-08-04 9:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-22 4:46 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 34a87bb07a4a3b2202fc25167a6b0f12575edc87 ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 34a87bb07a4a3b2202fc25167a6b0f12575edc87
ld: Hide symbols defined by HIDDEN/PROVIDE_HIDDEN
There should be no difference in output for symbols defined by HIDDEN
or PROVIDE_HIDDEN assignments whether they are explicitly marked as
hidden or not. This patch adds a new BFD function, bfd_link_hide_symbol,
to hide symbols defined by HIDDEN and PROVIDE_HIDDEN assignments.
bfd
PR ld/23201
* aout-target.h (MY_bfd_link_hide_symbol): New.
* aout-tic30.c (MY_bfd_link_hide_symbol): Likewise.
* binary.c (binary_bfd_link_hide_symbol): Likewise.
* coff-alpha.c (_bfd_ecoff_bfd_link_hide_symbol): Likewise.
* coff-mips.c (_bfd_ecoff_bfd_link_hide_symbol): Likewise.
* coff-rs6000.c (_bfd_xcoff_bfd_link_hide_symbol): Likewise.
* coffcode.h (coff_bfd_link_hide_symbol): Likewise.
* elf-bfd.h (_bfd_elf_link_hide_symbol): Likewise.
* elfxx-target.h (bfd_elfNN_bfd_link_hide_symbol): Likewise.
* i386msdos.c (msdos_bfd_link_hide_symbol): Likewise.
* ihex.c (ihex_bfd_link_hide_symbol): Likewise.
* libbfd-in.h (_bfd_nolink_bfd_link_hide_symbol): Likewise.
* linker.c (_bfd_generic_link_hide_symbol): Likewise.
(bfd_link_hide_symbol): Likewise.
* mach-o-target.c (bfd_mach_o_bfd_link_hide_symbol): Likewise.
* mmo.c (mmo_bfd_link_hide_symbol): Likewise.
* pef.c (bfd_pef_bfd_link_hide_symbol): Likewise.
* plugin.c (bfd_plugin_bfd_link_hide_symbol): Likewise.
* ppcboot.c (ppcboot_bfd_link_hide_symbol): Likewise.
* som.c (som_bfd_link_hide_symbol): Likewise.
* srec.c (srec_bfd_link_hide_symbol): Likewise.
* tekhex.c (tekhex_bfd_link_hide_symbol): Likewise.
* vms-alpha.c (vms_bfd_link_hide_symbol): Likewise.
(alpha_vms_bfd_link_hide_symbol): Likewise.
* xsym.c (bfd_sym_bfd_link_hide_symbol): Likewise.
* coff64-rs6000.c (rs6000_xcoff64_vec): Add
_bfd_generic_link_hide_symbol.
(rs6000_xcoff64_aix_vec): Likewise.
* elflink.c (bfd_elf_record_link_assignment): Don't make forced
local symbol dynamic.
(_bfd_elf_link_hide_symbol): New function.
* elfxx-x86.c (_bfd_x86_elf_link_symbol_references_local): Don't
check root.ldscript_def.
* targets.c (bfd_target): Add _bfd_link_hide_symbol.
(BFD_JUMP_TABLE_LINK): Add NAME##_bfd_link_hide_symbol.
* bfd-in2.h: Regenerated.
* libbfd.h: Likewise.
ld/
PR ld/23201
* ldexp.c (exp_fold_tree_1): Call bfd_link_hide_symbol to hide
a symbol.
* testsuite/ld-elf/provide-hidden-dynabs.nd: Removed.
* testsuite/ld-elf/provide-hidden-dynsec.nd: Likewise.
* testsuite/ld-elf/provide-hidden.exp: Replace
provide-hidden-dynsec.nd with provide-hidden-sec.nd and
provide-hidden-dyn.nd. Replace provide-hidden-dynabs.nd with
provide-hidden-abs.nd and provide-hidden-dyn.nd.
* testsuite/ld-i386/pr23189.d: Expect no dynamic relocation.
* testsuite/ld-x86-64/pr23189.d: Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] [PowerPC] Consolidate wordsize getter between native and gdbserver
@ 2018-05-22 17:26 sergiodj+buildbot
2018-08-06 23:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-22 17:26 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 2e077f5e67aeff78e096a250bd225cd4658a35dc ***
Author: Pedro Franco de Carvalho <pedromfc@linux.vnet.ibm.com>
Branch: master
Commit: 2e077f5e67aeff78e096a250bd225cd4658a35dc
[PowerPC] Consolidate wordsize getter between native and gdbserver
This patch moves the native target wordsize getter for ppc linux to
nat/ so that it can be used to simplify ppc_arch_setup in
gdbserver. The ptrace call used to get MSR for this is ultimately the
same as before, but it is no longer necessary to create a temporary
regcache to call fetch_inferior_registers.
gdb/ChangeLog:
2018-05-22 Pedro Franco de Carvalho <pedromfc@linux.vnet.ibm.com>
* configure.nat <linux powerpc>: Add ppc-linux.o to NATDEPFILES.
* ppc-linux-nat.c (ppc_linux_target_wordsize): Move to
nat/ppc-linux.c.
(ppc_linux_nat_target::auxv_parse): Get thread id tid. Call
ppc_linux_target_wordsize with tid.
(ppc_linux_nat_target::read_description): Call ppc_linux_target
wordsize with tid.
* nat/ppc-linux.c: Include nat/gdb_ptrace.h.
(ppc64_64bit_inferior_p): Add static and inline specifiers.
(ppc_linux_target_wordsize): Move here from ppc-linux-nat.c. Add
tid parameter. Remove static specifier.
* nat/ppc-linux.h (ppc64_64bit_inferior_p): Remove declaration.
(ppc_linux_target_wordsize): New declaration.
gdb/gdbserver/ChangeLog:
2018-05-22 Pedro Franco de Carvalho <pedromfc@linux.vnet.ibm.com>
* linux-ppc-low.c (ppc_arch_setup): Remove code for getting the
wordsize of the inferior. Call ppc_linux_target_wordsize.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Support UTF-8 identifiers in C/C++ expressions (PR gdb/22973)
@ 2018-05-22 20:16 sergiodj+buildbot
2018-08-12 17:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-22 20:16 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b1b60145aedb8adcb0b9dcf43a5ae735c2f03b51 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: b1b60145aedb8adcb0b9dcf43a5ae735c2f03b51
Support UTF-8 identifiers in C/C++ expressions (PR gdb/22973)
Factor out cp_ident_is_alpha/cp_ident_is_alnum out of
gdb/cp-name-parser.y and use it in the C/C++ expression parser too.
New test included.
gdb/ChangeLog:
2018-05-22 Pedro Alves <palves@redhat.com>
<zjz@zjz.name>
PR gdb/22973
* c-exp.y: Include "c-support.h".
(parse_number, c_parse_escape, lex_one_token): Use TOLOWER instead
of tolower. Use c_ident_is_alpha to scan names.
* c-lang.c: Include "c-support.h".
(convert_ucn, convert_octal, convert_hex, convert_escape): Use
ISXDIGIT instead of isxdigit and ISDIGIT instead of isdigit.
* c-support.h: New file, with bits factored out from ...
* cp-name-parser.y: ... this file.
Include "c-support.h".
(cp_ident_is_alpha, cp_ident_is_alnum): Deleted, moved to
c-support.h and renamed.
(symbol_end, yylex): Adjust.
gdb/testsuite/ChangeLog:
2018-05-22 Pedro Alves <palves@redhat.com>
PR gdb/22973
* gdb.base/utf8-identifiers.c: New file.
* gdb.base/utf8-identifiers.exp: New file.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] remote: Make readahead_cache a C++ class
@ 2018-05-22 22:50 sergiodj+buildbot
2018-08-14 0:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-22 22:50 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT dd194f6b36727987dc7f0d707512bd886982099c ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: dd194f6b36727987dc7f0d707512bd886982099c
remote: Make readahead_cache a C++ class
The idea here is eliminate the get_remote_state calls from within
readahead_cache_invalidate, readahead_cache_invalidate_fd,
remote_hostio_pread_from_cache by making those functions be class
methods instead. Later on we'll have one readahead_cache instance per
remote connection, and this change makes that easier.
gdb/ChangeLog:
2018-05-22 Pedro Alves <palves@redhat.com>
* remote.c (struct readahead_cache) <invalidate, invalidate_fd,
pread>: New method declarations.
(remote_target::open_1): Adjust.
(readahead_cache_invalidate): Rename to ...
(readahead_cache::invalidate): ... this, and adjust to be a class
method.
(readahead_cache_invalidate_fd): Rename to ...
(readahead_cache::invalidate_fd): ... this, and adjust to be a
class method.
(remote_hostio_pwrite): Adjust.
(remote_hostio_pread_from_cache): Rename to ...
(readahead_cache::pread): ... this, and adjust to be a class
method.
(remote_hostio_close): Adjust.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] remote: multiple remote_arch_state instances per arch
@ 2018-05-22 22:55 sergiodj+buildbot
2018-08-14 11:02 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-22 22:55 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 9d6eea31325e4027b5f035e941864fa6d780a8ca ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 9d6eea31325e4027b5f035e941864fa6d780a8ca
remote: multiple remote_arch_state instances per arch
Currently, we associate gdbarch-related remote protocol state on a
per-gdbarch data object. Things like the size of the g/G packet, and
the max remote packet size. If we'll support being connected to
different remote servers at the same time, then we need to cope with
each having their own packet sizes, even if they are each debugging
programs of the same architecture. I.e., a single instance of
remote_arch_state per arch is not sufficient.
This patch moves the remote_arch_state object to a map of
gdbarch-to-remote_arch_state saved in the remote_state structure.
Usually there will only be one entry in the map, though we may see
more with stubs that support multi-process and/or archs with multiple
ABIs (e.g, one remote_arch_state for 64-bit inferiors and another for
32-bit inferiors).
gdb/ChangeLog:
2018-05-22 Pedro Alves <palves@redhat.com>
* remote.c: Include <unordered_map>.
(remote_state): Now a class.
(remote_state) <get_remote_arch_state>: Declare method.
<get_remote_arch_state>: New field.
(remote_arch_state) <remote_arch_state>: Declare ctor.
<regs>: Now a unique_ptr.
(remote_gdbarch_data_handle): Delete.
(get_remote_arch_state): Delete.
(remote_state::get_remote_arch_state): New.
(get_remote_state): Adjust to call remote_state's
get_remote_arch_state method.
(init_remote_state): Delete, bits factored out to ...
(remote_arch_state::remote_arch_state): ... this new method.
(get_remote_packet_size, get_memory_packet_size)
(process_g_packet, remote_target::fetch_registers)
(remote_target::prepare_to_store, store_registers_using_G)
(remote_target::store_registers, remote_target::get_trace_status):
Adjust to call remote_state's method.
(_initialize_remote): Remove reference to
remote_gdbarch_data_handle.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Handle "show remote memory-write-packet-size" when not connected
@ 2018-05-23 0:48 sergiodj+buildbot
2018-08-16 5:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-23 0:48 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT cc0be08f80d4348e8f81471c80409710c4d4cd1a ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: cc0be08f80d4348e8f81471c80409710c4d4cd1a
Handle "show remote memory-write-packet-size" when not connected
Currently "show remote memory-write-packet-size" says that the packet
size is limited to whatever is stored in the remote_state global, even
if not connected to a target.
When we get to support multiple instances of remote targets, there
won't be a remote_state global anymore, so that must be replaced by
something else.
Since it doesn't make sense to print the limit of the packet size of a
non-existing connection, this patch makes us say that the limit will
be further reduced when we connect.
The text is taken from the command's online help, which says:
"The actual limit is further reduced dependent on the target."
Note that a value of "0" is special, as per "help set remote
memory-write-packet-size":
~~~
Specify the number of bytes in a packet or 0 (zero) for the
default packet size.
~~~
I've tweaked "show remote memory-write-packet-size" to include
"(default)" in the output in that case, like this:
(gdb) show remote memory-write-packet-size
The memory-write-packet-size is 0 (default). The actual limit will be further reduced dependent on the target.
While working on this, I noticed that an explicit "set remote
write-packet-size 0" does not makes GDB go back to the exact same
state as the default state when GDB starts up:
(gdb) show remote memory-write-packet-size
The memory-write-packet-size is 0. [...]
^^
(gdb) set remote memory-write-packet-size 0
(gdb) show remote memory-write-packet-size
The memory-write-packet-size is 16384. [...]
^^^^^
The "16384" number comes from DEFAULT_MAX_MEMORY_PACKET_SIZE.
This happens because git commit a5c0808e221c ("gdb: remove packet size
limit") at
<https://sourceware.org/ml/gdb-patches/2015-08/msg00743.html>, added
this:
/* So that the query shows the correct value. */
if (size <= 0)
size = DEFAULT_MAX_MEMORY_PACKET_SIZE;
to set_memory_packet_size, but despite what the comment suggests, that
also has the side-effect of recording DEFAULT_MAX_MEMORY_PACKET_SIZE
in config->size.
Finally, DEFAULT_MAX_MEMORY_PACKET_SIZE only makes sense for "set
remote memory-write-packet-size fixed", so I've renamed it
accordingly, to make it a little bit clearer.
gdb/ChangeLog:
2018-05-22 Pedro Alves <palves@redhat.com>
* remote.c (DEFAULT_MAX_MEMORY_PACKET_SIZE): Rename to ...
(DEFAULT_MAX_MEMORY_PACKET_SIZE_FIXED): ... this.
(get_fixed_memory_packet_size): New.
(get_memory_packet_size): Use it.
(set_memory_packet_size): Don't override the config size with
DEFAULT_MAX_MEMORY_PACKET_SIZE.
(show_memory_packet_size): Use get_fixed_memory_packet_size.
Don't refer to get_memory_packet_size if not connected to a remote
target. Show "(default)" if configured size is 0.
gdb/testsuite/ChangeLog:
2018-05-22 Pedro Alves <palves@redhat.com>
* gdb.base/remote.exp: Adjust expected output of "show remote
memory-write-packet-size". Add tests for "set remote
memory-write-packet-size 0" and "set remote
memory-write-packet-size fixed/limit".
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb/x86: Fix `-Wstrict-overflow' build error in `i387_collect_xsave'
@ 2018-05-23 2:03 sergiodj+buildbot
2018-08-17 22:51 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-23 2:03 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 35f1fea3fcd44546a6cf074029c284c64ad25b3c ***
Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 35f1fea3fcd44546a6cf074029c284c64ad25b3c
gdb/x86: Fix `-Wstrict-overflow' build error in `i387_collect_xsave'
Make `i' defined within `i387_collect_xsave' unsigned, removing a
`-Werror=strict-overflow' compilation error:
.../gdb/i387-tdep.c: In function 'void i387_collect_xsave(const regcache*, int, void*, int)':
.../gdb/i387-tdep.c:1348:1: error: assuming signed overflow does not occur when assuming that (X + c) < X is always false [-Werror=strict-overflow]
i387_collect_xsave (const struct regcache *regcache, int regnum,
^
cc1plus: all warnings being treated as errors
Makefile:1610: recipe for target 'i387-tdep.o' failed
make: *** [i387-tdep.o] Error 1
seen with GCC 5.4.0, a commit 8ee22052f690 ("gdb/x86: Handle kernels
using compact xsave format") regression. While `regnum' can be -1 on
entry to the function, to mean all registers, `i' is only used with
non-negative register numbers.
gdb/
* i387-tdep.c (i387_collect_xsave): Make `i' unsigned.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove elements from complaint_series
@ 2018-05-23 16:40 sergiodj+buildbot
2018-08-21 11:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-23 16:40 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 43ba33c7689a9eeb20a3c36ecb9867574963ee0e ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 43ba33c7689a9eeb20a3c36ecb9867574963ee0e
Remove elements from complaint_series
I couldn't find a way to get complaints to use a couple of cases, and
the difference between the actual printed output for these cases was
minimal anyway. So, this patch removes a couple of constants from
complaint_series, plus the associated code.
gdb/ChangeLog
2018-05-23 Tom Tromey <tom@tromey.com>
* complaints.c (enum complaint_series): Remove FIRST_MESSAGE,
SUBSEQUENT_MESSAGE.
(vcomplaint, clear_complaints): Update.
(symfile_explanations): Remove some messages.
gdb/testsuite/ChangeLog
2018-05-23 Tom Tromey <tom@tromey.com>
* gdb.gdb/complaints.exp (test_serial_complaints): Remove.
(test_short_complaints): Update.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove "noisy" parameter from clear_complaints
@ 2018-05-23 17:01 sergiodj+buildbot
2018-08-22 9:44 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-23 17:01 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 4e9668d0d1ddad73af7c20a92a00704fbea2a8d9 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 4e9668d0d1ddad73af7c20a92a00704fbea2a8d9
Remove "noisy" parameter from clear_complaints
After the previous patch, the "noisy" parameter to clear_complaints is
no longer used, so this patch removes it.
gdb/ChangeLog
2018-05-23 Tom Tromey <tom@tromey.com>
* complaints.c (clear_complaints): Remove "noisy" parameter.
* complaints.h (clear_complaints): Update.
* symfile.c (syms_from_objfile_1, finish_new_objfile)
(reread_symbols): Update.
gdb/testsuite/ChangeLog
2018-05-23 Tom Tromey <tom@tromey.com>
* gdb.gdb/complaints.exp (test_empty_complaints): Update.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove vcomplaint
@ 2018-05-23 18:49 sergiodj+buildbot
2018-08-23 22:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-23 18:49 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT de54e1a5d231c5857e870acc788f9b843ff5f050 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: de54e1a5d231c5857e870acc788f9b843ff5f050
Remove vcomplaint
vcomplaint now has a single caller, so merge it with that caller.
gdb/ChangeLog
2018-05-23 Tom Tromey <tom@tromey.com>
* complaints.c (vcomplaint): Remove.
(complaint_internal) Merge in contents of vcomplaint.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] testsuite: Extend TLS core file testing with an OS-generated dump
@ 2018-05-24 15:23 sergiodj+buildbot
2018-08-31 19:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-24 15:23 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT d9f6d7f8b636a2b32004273143d72a77d82b40de ***
Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: d9f6d7f8b636a2b32004273143d72a77d82b40de
testsuite: Extend TLS core file testing with an OS-generated dump
Complementing commit 280ca31f4d60 ("Add test for fetching TLS from
core file") extend gdb.threads/tls-core.exp with an OS-generated dump
where supported.
This verifies not only that our core dump interpreter is consistent
with our producer, but that it matches the OS verified as well,
avoiding a possible case where our interpreter would be bug-compatible
with our producer but not the OS and it would go unnoticed in testing.
This results in:
PASS: gdb.threads/tls-core.exp: native: load core file
PASS: gdb.threads/tls-core.exp: native: print thread-local storage variable
PASS: gdb.threads/tls-core.exp: gcore: load core file
PASS: gdb.threads/tls-core.exp: gcore: print thread-local storage variable
with local testing and:
UNSUPPORTED: gdb.threads/tls-core.exp: native: load core file
UNSUPPORTED: gdb.threads/tls-core.exp: native: print thread-local storage variable
PASS: gdb.threads/tls-core.exp: gcore: load core file
PASS: gdb.threads/tls-core.exp: gcore: print thread-local storage variable
with remote testing, or for testing on ports that don't supports
cores.
gdb/testsuite/ChangeLog:
2018-05-24 Maciej W. Rozycki <macro@mips.com>
Pedro Alves <palves@redhat.com>
* gdb.threads/tls-core.c: Include <stdlib.h>
(thread_proc): Call `abort'.
* gdb.threads/tls-core.exp: Generate a core with core_find too.
(tls_core_test): New procedure, bits factored out from ...
(top level): ... here. Test both native cores and gcore cores.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb: Restore selected frame in print_frame_local_vars
@ 2018-05-24 18:01 sergiodj+buildbot
2018-09-02 0:55 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-24 18:01 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 45f25d6c83c31a48a01ef8293bb3978f5e58e653 ***
Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 45f25d6c83c31a48a01ef8293bb3978f5e58e653
gdb: Restore selected frame in print_frame_local_vars
PR gdb/23203 reports 'bt full' causing the currently selected frame to
change, this issue is fixed in this commit.
Add a new class scoped_restore_selected_frame that saves and restores
the selected frame. Make use of this in print_frame_local_vars to
restore the selected frame on exit.
gdb/ChangeLog:
PR gdb/23203
* frame.c
(scoped_restore_selected_frame::scoped_restore_selected_frame):
Define.
(scoped_restore_selected_frame::~scoped_restore_selected_frame):
Define.
* frame.h (class scoped_restore_selected_frame): New class.
* stack.c (print_frame_local_vars): Remove catching and rethrowing
of any exception, use scoped_restore_selected_frame to restore the
frame instead.
gdb/testsuite/ChangeLog:
PR gdb/23203
* gdb.base/bt-selected-frame.c: New file.
* gdb.base/bt-selected-frame.exp: New file.
* lib/gdb.exp (get_current_frame_number): New function.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Update help strings in skip.c
@ 2018-05-24 20:09 sergiodj+buildbot
2018-09-04 4:39 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-24 20:09 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 784e4b3e80c1093203ae1a0da33be7a670942713 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 784e4b3e80c1093203ae1a0da33be7a670942713
Update help strings in skip.c
This changes help strings in skip.c to follow the GNU style.
2018-04-27 Tom Tromey <tom@tromey.com>
* skip.c (_initialize_step_skip): Update help strings.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] gdb: Split func_command into two parts.
@ 2018-05-25 3:02 sergiodj+buildbot
2018-09-09 2:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-25 3:02 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 39f0c2040f13ae0eb3405b8cf2ff6491c6f354a5 ***
Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 39f0c2040f13ae0eb3405b8cf2ff6491c6f354a5
gdb: Split func_command into two parts.
The func_command function is used to emulate the dbx 'func' command.
However, finding a stack frame based on function name might be a useful
feature, and so the core of func_command is now split out into a
separate function.
gdb/ChangeLog:
* stack.c (select_and_print_frame): Delete.
(struct function_bounds): Move struct within function.
(func_command): Most content moved into new function
find_frame_for_function, use new function, print result, add
function comment.
(find_frame_for_function): New function, now returns a result.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] s12z regen
@ 2018-05-25 7:27 sergiodj+buildbot
2018-09-09 6:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-25 7:27 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 277eb7f64ae0c949715751a382350368ef14e95e ***
Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 277eb7f64ae0c949715751a382350368ef14e95e
s12z regen
This patch regenerates a number of files that either were edited by
hand or not regenerated when s12z support was added to binutils.
bfd/
* Makefile.in: Regenerate.
* po/SRC-POTFILES.in: Regenerate.
gas/
* po/POTFILES.in: Regenerate.
ld/
* po/BLD-POTFILES.in: Regenerate.
opcodes/
* Makefile.in: Regenerate.
* po/POTFILES.in: Regenerate.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Change the as_*_interp functions to use dynamic_cast
@ 2018-05-25 20:32 sergiodj+buildbot
2018-09-13 11:32 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-25 20:32 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 716b8bc52eef6044f1ff361e3e2eeb9307849034 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 716b8bc52eef6044f1ff361e3e2eeb9307849034
Change the as_*_interp functions to use dynamic_cast
This changes the various as_*_interp functions to be implemented using
dynamic_cast. I believe this is a small improvement, because it is
more typesafe -- the C++ runtime does the type-checking for us.
ChangeLog
2018-05-25 Tom Tromey <tom@tromey.com>
* tui/tui-interp.c (as_tui_interp): Use dynamic_cast.
* mi/mi-interp.c (as_mi_interp): Use dynamic_cast.
* cli/cli-interp.c (as_cli_interp): Use dynamic_cast.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove interp_name
@ 2018-05-25 20:59 sergiodj+buildbot
2018-09-13 14:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-25 20:59 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT da505cff6e29b18244dc9f6886bcb4d436263dee ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: da505cff6e29b18244dc9f6886bcb4d436263dee
Remove interp_name
This removes the interp_name function. It is only used a few spots --
one of which was only calling it on "this". It's simpler to remove
it; and should class interp become opaque in the future, it will be
just as easy to update the two remaining spots to use an accessor.
ChangeLog
2018-05-25 Tom Tromey <tom@tromey.com>
* interps.c (interp_name): Remove.
* mi/mi-interp.c (mi_interp::init): Update.
* interps.h (interp_name): Remove.
(~scoped_restore_interp): Update.
* tui/tui.c (tui_enable): Update.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove cleanups from dbxread.c
@ 2018-05-26 21:47 sergiodj+buildbot
2018-09-13 17:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-26 21:47 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT bf259e253f0d27323756fb434ba6e94d50846021 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: bf259e253f0d27323756fb434ba6e94d50846021
Remove cleanups from dbxread.c
This removes the remaining cleanups from dbxread.c, via std::vector,
scoped_restore, and unique_xmalloc_ptr.
Tested by the buildbot.
ChangeLog
2018-05-25 Tom Tromey <tom@tromey.com>
* dbxread.c (init_bincl_list): Remove.
(bincl_list): Now a std::vector.
(bincls_allocated, next_bincl): Remove.
(free_bincl_list, do_free_bincl_list_cleanup)
(make_cleanup_free_bincl_list): Remove.
(dbx_read_symtab, elfstab_build_psymtabs): Use scoped_restore,
unique_xmalloc_ptr.
(find_corresponding_bincl_psymtab, read_dbx_symtab): Update.
(struct header_file_location): Add constructor.
(add_bincl_to_list): Remove.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove last reference to REMOTE_OBS
@ 2018-05-27 22:16 sergiodj+buildbot
2018-09-14 17:14 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-27 22:16 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT b8283aea9e599f17dbae7f52223994e3a9168143 ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: b8283aea9e599f17dbae7f52223994e3a9168143
Remove last reference to REMOTE_OBS
REMOTE_OBS was removed from Makefile.in in
18ca73470a0d7eb96a807c97559cbb9fddb4b461, but one reference remains.
This patch removes the lingerer.
ChangeLog
2018-05-27 Tom Tromey <tom@tromey.com>
* Makefile.in (DEPFILES): Don't reference REMOTE_OBS.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] ld: Unify STT_GNU_IFUNC handling
@ 2018-05-28 16:20 sergiodj+buildbot
2018-09-15 4:21 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-28 16:20 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT ac98f9e2275ffcca560eaa0bddd282a1ff94fc28 ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: ac98f9e2275ffcca560eaa0bddd282a1ff94fc28
ld: Unify STT_GNU_IFUNC handling
Take STT_GNU_IFUNC handling scattered across targets and gather it in
the generic ELF linker.
bfd/
PR ld/23238
* elf-s390-common.c (elf_s390_add_symbol_hook): Removed.
* elf32-arc.c (elf_arc_add_symbol_hook): Likewise.
(elf_backend_add_symbol_hook): Likewise.
* elf32-m68k.c (elf_m68k_add_symbol_hook): Likewise.
(elf_backend_add_symbol_hook): Likewise.
* elf32-s390.c (elf_backend_add_symbol_hook): Likewise.
* elf32-sparc.c (elf32_sparc_add_symbol_hook): Likewise.
(elf_backend_add_symbol_hook): Likewise.
* elf64-s390.c (elf_backend_add_symbol_hook): Likewise.
* elfxx-aarch64.c (_bfd_aarch64_elf_add_symbol_hook): Likewise.
* elfxx-aarch64.h (_bfd_aarch64_elf_add_symbol_hook): Likewise.
(elf_backend_add_symbol_hook): Likewise.
* elf32-arm.c (elf32_arm_add_symbol_hook): Remove STT_GNU_IFUNC
handling.
* elf32-ppc.c (ppc_elf_add_symbol_hook): Likewise.
* elf64-ppc.c (ppc64_elf_add_symbol_hook): Likewise.
* elf64-sparc.c (elf64_sparc_add_symbol_hook): Likewise.
* elflink.c (elf_link_add_object_symbols): Set
elf_gnu_symbol_ifunc for STT_GNU_IFUNC symbols.
ld/
PR ld/23238
* testsuite/ld-ifunc/ifunc-26.d: New file.
* testsuite/ld-ifunc/ifunc-26.s: Likewise.
* testsuite/ld-ifunc/ifunc.exp: Run *.d tests without a
working compiler.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] x86-64: Add TLSDESC fields to elf_x86_lazy_plt_layout
@ 2018-05-28 19:57 sergiodj+buildbot
2018-09-15 22:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-28 19:57 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 92e68c1d65f844c0027f471a0c9e1722d781ef7d ***
Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 92e68c1d65f844c0027f471a0c9e1722d781ef7d
x86-64: Add TLSDESC fields to elf_x86_lazy_plt_layout
ENDBR64 is added to the special TLSDESC entry, which is similar to the
PLT0 entry, in the x86-64 lazy procedure linkage table to support Intel
CET. The NaCl PLT is different from the normal PLT. This patch adds
plt_tlsdesc_entry, plt_tlsdesc_entry_size, plt_tlsdesc_got1_offset,
plt_tlsdesc_got2_offset, plt_tlsdesc_got1_insn_end and
plt_tlsdesc_got2_insn_end to elf_x86_lazy_plt_layout to support both
normal and NaCl TLSDESC entries. This fixed
FAIL: TLS descriptor -fpic -shared transitions
for x86_64-nacl.
* elf32-i386.c (elf_i386_lazy_plt): Add plt_tlsdesc_entry,
plt_tlsdesc_entry_size, plt_tlsdesc_got1_offset,
plt_tlsdesc_got2_offset, plt_tlsdesc_got1_insn_end and
plt_tlsdesc_got2_insn_end for TLSDESC entry.
(elf_i386_lazy_ibt_plt): Likewise.
(elf_i386_nacl_plt): Likewise.
* elf64-x86-64.c (tlsdesc_plt_entry): Moved and renamed to ...
(elf_x86_64_tlsdesc_plt_entry): This.
(elf_x86_64_lazy_plt): Add plt_tlsdesc_entry,
plt_tlsdesc_entry_size, plt_tlsdesc_got1_offset,
plt_tlsdesc_got2_offset, plt_tlsdesc_got1_insn_end and
plt_tlsdesc_got2_insn_end for TLSDESC entry.
(elf_x86_64_lazy_bnd_plt): Likewise.
(elf_x86_64_lazy_ibt_plt): Likewise.
(elf_x32_lazy_ibt_plt): Likewise.
(elf_x86_64_nacl_plt): Likewise.
(elf_x86_64_finish_dynamic_sections): Use plt_tlsdesc_entry,
plt_tlsdesc_entry_size, plt_tlsdesc_got1_offset,
plt_tlsdesc_got2_offset, plt_tlsdesc_got1_insn_end and
plt_tlsdesc_got2_insn_end to update TLSDESC entry.
* elfxx-x86.h (elf_x86_lazy_plt_layout): Update comments.
Add plt_tlsdesc_entry, plt_tlsdesc_entry_size,
plt_tlsdesc_got1_offset, plt_tlsdesc_got2_offset,
plt_tlsdesc_got1_insn_end and plt_tlsdesc_got2_insn_end.
(elf_x86_non_lazy_plt_layout): Update comments.
(elf_x86_plt_layout): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
* [binutils-gdb] Remove "struct" keyword in range-based for loops
@ 2018-05-30 1:23 sergiodj+buildbot
2018-09-18 21:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
0 siblings, 1 reply; 2083+ messages in thread
From: sergiodj+buildbot @ 2018-05-30 1:23 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 5294170687db7d997a00f88b765ef353121aa441 ***
Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 5294170687db7d997a00f88b765ef353121aa441
Remove "struct" keyword in range-based for loops
I get this kind of errors with GCC 6.3.0:
/home/simark/src/binutils-gdb/gdb/breakpoint.c: In function 'void print_solib_event(int)':
/home/simark/src/binutils-gdb/gdb/breakpoint.c:4618:12: error: types may not be defined in a for-range-declaration [-Werror]
for (struct so_list *iter : current_program_space->added_solibs)
^~~~~~
Removing the struct keyword makes it happy.
gdb/ChangeLog:
* breakpoint.c (print_solib_event, check_status_catch_solib):
Remove struct keyword in range-based for loops.
* dbxread.c (find_corresponding_bincl_psymtab): Likewise.
* dwarf2read.c (compute_delayed_physnames, rust_union_quirks);
Likewise.
* linespec.c (find_superclass_methods, search_minsyms_for_name):
Likewise.
* symfile.c (addr_info_make_relative): Likewise.
* thread.c (value_in_thread_stack_temporaries): Likewise.
^ permalink raw reply [flat|nested] 2083+ messages in thread
end of thread, other threads:[~2018-09-17 23:16 UTC | newest]
Thread overview: 2083+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-25 4:31 [binutils-gdb] Remove lwp -> pid conversion in linux_nat_xfer_partial sergiodj+buildbot
2017-03-25 4:30 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch master sergiodj+buildbot
2017-03-25 4:59 ` Failures on Ubuntu-AArch64-m64, " sergiodj+buildbot
2017-03-25 18:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, " sergiodj+buildbot
2017-03-25 18:49 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, " sergiodj+buildbot
2017-03-25 19:12 ` Failures on Ubuntu-AArch32-m32, " sergiodj+buildbot
2017-06-04 23:27 ` Failures on Fedora-ppc64le-native-gdbserver-m64, " sergiodj+buildbot
2017-06-05 11:14 ` Failures on Fedora-ppc64le-native-extended-gdbserver-m64, " sergiodj+buildbot
2017-06-24 9:04 ` Failures on Debian-s390x-native-gdbserver-m64, " sergiodj+buildbot
2017-06-24 9:10 ` Failures on Debian-s390x-native-extended-gdbserver-m64, " sergiodj+buildbot
2017-08-20 11:53 ` Failures on Fedora-ppc64be-native-extended-gdbserver-m64, " sergiodj+buildbot
2017-08-20 21:49 ` Failures on Fedora-ppc64be-m64, " sergiodj+buildbot
2017-08-20 22:06 ` Failures on Fedora-ppc64be-native-gdbserver-m64, " sergiodj+buildbot
2017-09-15 15:50 [binutils-gdb] linux-low: Remove unused variables sergiodj+buildbot
2017-09-15 17:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-15 16:41 [binutils-gdb] Add -l option to src-release script sergiodj+buildbot
2017-09-15 18:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-15 16:54 [binutils-gdb] gdbserver: Move detach code to its own function sergiodj+buildbot
2017-09-15 21:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-15 17:29 [binutils-gdb] Deduplicate require_running macros and move them up sergiodj+buildbot
2017-09-15 19:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-15 19:36 [binutils-gdb] Sync libiberty/ & include/ with GCC sergiodj+buildbot
2017-09-16 4:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-16 4:36 [binutils-gdb] Use std::vector on tdesc->reg_defs (gdbserver/tdesc.h) sergiodj+buildbot
2017-09-16 12:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-16 12:13 [binutils-gdb] mi_load_progress: Use unique_ptr to manage ui_out lifetime sergiodj+buildbot
2017-09-16 13:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-16 12:47 [binutils-gdb] mi_load_progress: Restore current_uiout using a scoped_restore sergiodj+buildbot
2017-09-16 14:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-16 13:24 [binutils-gdb] Add unit test for xml_escape_text sergiodj+buildbot
2017-09-16 17:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-16 14:50 [binutils-gdb] Make xml_escape_text return an std::string sergiodj+buildbot
2017-09-17 3:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-18 11:43 [binutils-gdb] dwarf2expr: Remove unused abort_expression label in execute_stack_op sergiodj+buildbot
2017-09-18 20:28 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-18 20:44 [binutils-gdb] Check error return from bfd_canonicalize_dynamic_reloc sergiodj+buildbot
2017-09-19 5:29 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-19 5:56 [binutils-gdb] PR22150, ld keeps a version reference for gc'd symbols sergiodj+buildbot
2017-09-19 6:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-19 10:48 [binutils-gdb] Remove one explicit rule for monitor.o sergiodj+buildbot
2017-09-19 19:25 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-19 19:46 [binutils-gdb] Add a 'starti' command sergiodj+buildbot
2017-09-20 3:27 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-20 14:10 [binutils-gdb] gdb - avx512: tests were failing due to missing memory aligment sergiodj+buildbot
2017-09-20 15:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-20 15:28 [binutils-gdb] [OBV] amd64-features-makefile: add missing backslash sergiodj+buildbot
2017-09-20 16:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-20 17:04 [binutils-gdb] Make "list ambiguous" show symbol names too sergiodj+buildbot
2017-09-20 22:25 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-20 22:31 [binutils-gdb] Overload catch_command_errors sergiodj+buildbot
2017-09-20 23:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-21 0:06 [binutils-gdb] eval.c:evaluate_subexp_standard: Use RAII to avoid leaks sergiodj+buildbot
2017-09-21 4:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-21 6:48 [binutils-gdb] Change counted_command_line to a shared_ptr sergiodj+buildbot
2017-09-21 8:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-21 8:31 [binutils-gdb] [SIM, ARM] Fix build failure sergiodj+buildbot
2017-09-21 9:41 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-21 9:36 [binutils-gdb] Fix aarch64-freebsd build failure sergiodj+buildbot
2017-09-21 12:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-21 12:52 [binutils-gdb] microblaze-tdep: Add ATTRIBUTE_PRINTF to microblaze_debug sergiodj+buildbot
2017-09-21 14:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-21 13:51 [binutils-gdb] linux-waitpid: Get rid of format string warning sergiodj+buildbot
2017-09-21 16:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-21 16:21 [binutils-gdb] S/390: Fix Elf note swap s390_gs_bc vs. s390_gs_cb sergiodj+buildbot
2017-09-21 18:33 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-21 16:58 [binutils-gdb] gdbserver: Remove traces of ancient Hc handling sergiodj+buildbot
2017-09-21 19:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-21 19:14 [binutils-gdb] Add target method for converting thread handle to thread_info struct pointer sergiodj+buildbot
2017-09-21 20:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-21 19:39 [binutils-gdb] Add `thread_from_thread_handle' method to (Python) gdb.Inferior sergiodj+buildbot
2017-09-21 21:41 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-21 20:08 [binutils-gdb] Add thread_db_notice_clone to gdbserver sergiodj+buildbot
2017-09-21 22:51 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-21 20:48 [binutils-gdb] Test case for Inferior.thread_from_thread_handle sergiodj+buildbot
2017-09-22 5:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-22 9:29 [binutils-gdb] Fix gdb 8.1 Solaris compilation sergiodj+buildbot
2017-09-22 14:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-22 14:18 [binutils-gdb] Fix sometimes-uninitialized warning in gdbscm_value_address sergiodj+buildbot
2017-09-22 15:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-22 14:55 [binutils-gdb] bfd/version.h: Add rationale for BFD_VERSION_DATE sergiodj+buildbot
2017-09-22 16:44 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-22 15:29 [binutils-gdb] x86: Return -1 if bfd_canonicalize_dynamic_reloc returns 0 sergiodj+buildbot
2017-09-22 17:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-22 15:58 [binutils-gdb] gdbserver x86 on win32: call init_target_desc sergiodj+buildbot
2017-09-22 19:00 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-22 18:25 [binutils-gdb] Get rid of "gdb_dirbuf" and use "getcwd (NULL, 0)" sergiodj+buildbot
2017-09-22 21:38 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-22 20:52 [binutils-gdb] LVU: dump loclists with locviews sergiodj+buildbot
2017-09-22 22:23 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-22 22:17 [binutils-gdb] Change type of scoped_input_handler::m_quit_handler sergiodj+buildbot
2017-09-23 7:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-23 21:05 [binutils-gdb] Removed unused declaration sergiodj+buildbot
2017-09-24 7:06 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-24 7:39 [binutils-gdb] PR22167, NULL pointer dereference in scan_unit_for_symbols sergiodj+buildbot
2017-09-24 9:41 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-24 8:08 [binutils-gdb] PR22169, heap-based buffer overflow in read_1_byte sergiodj+buildbot
2017-09-24 10:54 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-24 8:28 [binutils-gdb] PR22186, divide-by-zero in decode_line_info sergiodj+buildbot
2017-09-24 12:21 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-24 8:40 [binutils-gdb] PR22187, infinite loop in find_abstract_instance_name sergiodj+buildbot
2017-09-24 13:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-24 12:42 [binutils-gdb] PR22191, memory leak in dwarf2.c sergiodj+buildbot
2017-09-24 18:27 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-24 12:59 [binutils-gdb] PR22197, buffer overflow in bfd_get_debug_link_info_1 sergiodj+buildbot
2017-09-25 5:25 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-25 13:52 [binutils-gdb] PR22200, DWARF5 .debug_line sanity check sergiodj+buildbot
2017-09-25 14:57 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-25 14:14 [binutils-gdb] PR22201, DW_AT_name with out of bounds reference sergiodj+buildbot
2017-09-25 16:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-25 15:04 [binutils-gdb] PR22202, buffer overflow in parse_die sergiodj+buildbot
2017-09-25 18:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-25 16:24 [binutils-gdb] S390: Add guarded-storage register support to GDB sergiodj+buildbot
2017-09-25 22:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-25 17:02 [binutils-gdb] S390: Add guarded-storage register support to gdbserver sergiodj+buildbot
2017-09-26 0:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-26 0:40 [binutils-gdb] PR22204, Lack of DW_LNE_end_sequence causes "infinite" loop sergiodj+buildbot
2017-09-26 2:14 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-26 1:17 [binutils-gdb] PR22205, .debug_line file table NULL filename sergiodj+buildbot
2017-09-26 3:06 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-26 2:45 [binutils-gdb] Remove make_cleanup_regcache_xfree sergiodj+buildbot
2017-09-26 7:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-26 3:25 [binutils-gdb] Remove make_cleanup_regcache_invalidate sergiodj+buildbot
2017-09-26 9:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-26 10:06 [binutils-gdb] Allow the macw and macl instructions to be used on CPUs that have emacs support sergiodj+buildbot
2017-09-26 13:07 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-26 14:35 [binutils-gdb] Remove support for Solaris < 10 (PR gdb/22185) sergiodj+buildbot
2017-09-26 17:55 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-26 15:21 [binutils-gdb] Avoid needless resource usage when processing a corrupt DWARF directory or file name table sergiodj+buildbot
2017-09-26 19:23 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-26 16:00 [binutils-gdb] Tidy reading data in read_formatted_entries sergiodj+buildbot
2017-09-26 21:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-26 17:12 [binutils-gdb] Allow linking GDB with ncursesw sergiodj+buildbot
2017-09-26 23:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-26 17:59 [binutils-gdb] Use "switch_to_thread" more thoroughly on gdbserver sergiodj+buildbot
2017-09-27 1:38 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-26 18:56 [binutils-gdb] dwarf2read: Restrict ICC workaround to ICC<14 sergiodj+buildbot
2017-09-27 6:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-26 22:02 [binutils-gdb] x86-64: Don't pass output_bfd to info->callbacks->minfo sergiodj+buildbot
2017-09-27 6:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-27 14:49 [binutils-gdb] Add support for __VA_OPT__ sergiodj+buildbot
2017-09-27 16:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-27 15:48 [binutils-gdb] Add add_cmd function overloads sergiodj+buildbot
2017-09-27 17:00 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-27 17:17 [binutils-gdb] Constify not_just_help_class_command sergiodj+buildbot
2017-09-27 19:59 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-27 17:48 [binutils-gdb] Constify info_probes_dtrace_command sergiodj+buildbot
2017-09-27 21:41 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-27 18:56 [binutils-gdb] Constify two functions in cp-abi.c sergiodj+buildbot
2017-09-28 1:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-27 19:06 [binutils-gdb] Constify two functions in linux-fork.c sergiodj+buildbot
2017-09-28 2:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-27 19:37 [binutils-gdb] Constify two functions in valprint.c sergiodj+buildbot
2017-09-27 22:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-27 19:46 [binutils-gdb] Constify some functions in psymtab.c sergiodj+buildbot
2017-09-28 5:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-27 20:01 [binutils-gdb] Constify first_component_command sergiodj+buildbot
2017-09-28 6:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-27 20:54 [binutils-gdb] Constify maintenance_cplus_namespace sergiodj+buildbot
2017-09-28 7:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-27 21:51 [binutils-gdb] Constify maintenance_print_user_registers sergiodj+buildbot
2017-09-28 9:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-27 23:15 [binutils-gdb] Constify show_convenience sergiodj+buildbot
2017-09-28 11:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-27 23:21 [binutils-gdb] Constify some functions in memattr.c sergiodj+buildbot
2017-09-28 12:39 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-28 0:29 [binutils-gdb] Constify cmd_record_full_restore sergiodj+buildbot
2017-09-28 14:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-28 0:41 [binutils-gdb] Constify interpreter_exec_cmd sergiodj+buildbot
2017-09-28 15:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-28 1:36 [binutils-gdb] Constify commands in cli-dump.c sergiodj+buildbot
2017-09-28 22:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-28 2:14 [binutils-gdb] Constify core_file_command sergiodj+buildbot
2017-09-28 10:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-30 7:29 [binutils-gdb] Remove cleanup from complaints.c sergiodj+buildbot
2017-10-02 7:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-30 7:51 [binutils-gdb] Remove cleanup from xstormy16-tdep.c sergiodj+buildbot
2017-10-02 8:32 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-30 9:29 [binutils-gdb] Remove a cleanup from symtab.c sergiodj+buildbot
2017-10-02 11:21 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-30 10:20 [binutils-gdb] Remove make_cleanup_defer_target_commit_resume sergiodj+buildbot
2017-10-02 14:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-30 11:26 [binutils-gdb] Remove cleanups from mi_cmd_break_insert_1 sergiodj+buildbot
2017-10-02 15:02 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-30 11:49 [binutils-gdb] Remove cleanups from mi-cmd-var.c sergiodj+buildbot
2017-10-02 16:13 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-09-30 15:12 [binutils-gdb] Use std::string in mi-main.c sergiodj+buildbot
2017-10-02 22:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
[not found] <8abcee91738bf0be98e949049c559839ef811ae4@gdb-build>
2017-10-02 6:07 ` sergiodj+buildbot
[not found] <9754d8c4c48209eaefb044d03dc25f14dca8a263@gdb-build>
2017-10-02 12:51 ` sergiodj+buildbot
[not found] <6afe2f4a39badf0ea1ccf9fd34417e729577c6e6@gdb-build>
2017-10-02 18:51 ` sergiodj+buildbot
2017-10-02 20:33 [binutils-gdb] Allow indexing of &str in Rust sergiodj+buildbot
2017-10-03 11:57 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-02 21:04 [binutils-gdb] Fix ptype of Rust slices sergiodj+buildbot
2017-10-03 13:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-03 12:07 [binutils-gdb] Change record_full_gdb_operation_disable_set not to return a cleanup sergiodj+buildbot
2017-10-03 15:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-03 21:48 [binutils-gdb] Update my email address sergiodj+buildbot
2017-10-03 22:30 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-04 6:40 [binutils-gdb] Introduce gdb_tilde_expand sergiodj+buildbot
2017-10-04 7:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-04 6:49 [binutils-gdb] Implement "set cwd" command on GDB sergiodj+buildbot
2017-10-04 8:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-04 7:08 [binutils-gdb] Extend "set cwd" to work on gdbserver sergiodj+buildbot
2017-10-04 10:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-04 12:21 [binutils-gdb] Move code out of 'between TRY and CATCH' sergiodj+buildbot
2017-10-04 13:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-04 16:48 [binutils-gdb] Fix -list-thread-groups --available logic and add test sergiodj+buildbot
2017-10-04 17:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-04 17:39 [binutils-gdb] Fix "Remote 'g' packet reply is too long" problems with multiple inferiors sergiodj+buildbot
2017-10-04 21:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-04 23:08 [binutils-gdb] PR21167, relocation sections not included in groups sergiodj+buildbot
2017-10-04 23:57 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-05 1:42 [binutils-gdb] bfd_set_input_error sergiodj+buildbot
2017-10-05 3:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-05 4:45 [binutils-gdb] Update my email address sergiodj+buildbot
2017-10-05 5:33 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-05 13:02 [binutils-gdb] tile: Dump dynamic relocation info to the map file sergiodj+buildbot
2017-10-05 13:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-05 17:00 [binutils-gdb] Handle the NT_ARM_VFP core dump note on FreeBSD sergiodj+buildbot
2017-10-05 18:59 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-05 17:00 [binutils-gdb] Handle FreeBSD-specific AT_EHDRFLAGS and AT_HWCAP auxiliary vector types sergiodj+buildbot
2017-10-05 17:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-05 17:00 [binutils-gdb] Add a signal frame unwinder for FreeBSD/mipsn32 sergiodj+buildbot
2017-10-05 20:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-05 17:18 [binutils-gdb] Clean up includes of doublest.h and floatformat.h sergiodj+buildbot
2017-10-05 22:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-05 17:18 [binutils-gdb] Remove unused "union agent_val" from ax.h sergiodj+buildbot
2017-10-06 0:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-05 17:35 [binutils-gdb] Fix fork-related regressions on GNU/Linux sergiodj+buildbot
2017-10-06 2:21 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-06 7:18 [binutils-gdb] x86: Add TLS_TRANSITION_IE_TO_LE_P sergiodj+buildbot
2017-10-06 8:33 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-06 7:26 [binutils-gdb] x86: Add NEED_DYNAMIC_RELOCATION_P sergiodj+buildbot
2017-10-06 10:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-06 7:30 [binutils-gdb] Add RESOLVED_LOCALLY_P sergiodj+buildbot
2017-10-06 12:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-06 7:36 [binutils-gdb] x86: Add GENERATE_RELATIVE_RELOC_P sergiodj+buildbot
2017-10-06 13:27 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-06 7:44 [binutils-gdb] x86: Add GENERATE_DYNAMIC_RELOCATION_P sergiodj+buildbot
2017-10-06 16:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-06 7:51 [binutils-gdb] x86: Add VERIFY_PLT_ENTRY sergiodj+buildbot
2017-10-06 18:27 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-06 7:54 [binutils-gdb] x86: Add VERIFY_COPY_RELOC sergiodj+buildbot
2017-10-06 20:13 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-06 10:23 [binutils-gdb] Share code updating gdb_target_obs sergiodj+buildbot
2017-10-07 0:30 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-06 10:53 [binutils-gdb] Fix GDB build under msys+mingw gcc 32bit sergiodj+buildbot
2017-10-07 2:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-06 11:06 [binutils-gdb] Fix more GDB build breakage on mingw32 sergiodj+buildbot
2017-10-07 3:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-06 12:54 [binutils-gdb] Add "do/while(0); " to COPY_INPUT_RELOC_P/VERIFY_COPY_RELOC sergiodj+buildbot
2017-10-07 5:02 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-06 13:56 [binutils-gdb] Move aarch64-insn.o to arch/aarch64-insn.o and Remove a rule for arch/*.c sergiodj+buildbot
2017-10-07 9:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-06 21:43 [binutils-gdb] Account for padding in FreeBSD/mipsn32 NT_PRSTATUS notes sergiodj+buildbot
2017-10-07 10:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-07 1:04 [binutils-gdb] x86: Use zero_undefweak in elf_x86_link_hash_entry sergiodj+buildbot
2017-10-07 13:02 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-08 0:51 [binutils-gdb] sparc: Dump dynamic relocation info to the map file sergiodj+buildbot
2017-10-08 1:57 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-08 21:53 [binutils-gdb] tilegx: Set this_hdr.sh_entsize only if section size > 0 sergiodj+buildbot
2017-10-08 22:23 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-09 5:11 [binutils-gdb] PR22212, memory leak in nm sergiodj+buildbot
2017-10-09 5:38 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-09 5:31 [binutils-gdb] Change search_symbols to return std::vector sergiodj+buildbot
2017-10-09 6:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-09 5:51 [binutils-gdb] Remove make_cleanup_value_free sergiodj+buildbot
2017-10-09 8:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-09 7:27 [binutils-gdb] Remove some cleanups from dwarf2read.c sergiodj+buildbot
2017-10-09 12:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-09 8:52 [binutils-gdb] Remove cleanup from frame_prepare_for_sniffer sergiodj+buildbot
2017-10-09 10:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-09 12:16 [binutils-gdb] Fix gdb.base/print-file-var-main.c value check logic sergiodj+buildbot
2017-10-09 13:39 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-09 15:34 [binutils-gdb] Make cp_remove_params return a gdb::unique_xmalloc_ptr sergiodj+buildbot
2017-10-09 16:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-09 16:13 [binutils-gdb] Fix automatic dependency tracking sergiodj+buildbot
2017-10-09 18:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-09 17:56 [binutils-gdb] S/390: Sync with latest POP - 3 new instructions sergiodj+buildbot
2017-10-09 21:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-09 19:00 [binutils-gdb] Use gdbarch_long_bit to determine layout of FreeBSD siginfo_t sergiodj+buildbot
2017-10-09 23:41 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-10 0:03 [binutils-gdb] Remove "do_nothing" sergiodj+buildbot
2017-10-10 6:22 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-10 0:15 [binutils-gdb] bfin: Don't create .interp section for info->nointerp sergiodj+buildbot
2017-10-10 4:00 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-10 0:23 [binutils-gdb] Remove free_splay_tree cleanup sergiodj+buildbot
2017-10-10 8:21 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-10 5:29 [binutils-gdb] Prepare powerpc64 for late check_relocs sergiodj+buildbot
2017-10-10 9:51 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-10 5:49 [binutils-gdb] riscv: Cache the max alignment of output sections sergiodj+buildbot
2017-10-10 11:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-10 17:00 [binutils-gdb] Eliminate catch_exceptions/catch_exceptions_with_msg sergiodj+buildbot
2017-10-10 19:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-11 12:08 [binutils-gdb] Rename _doprnt -> _bfd_doprnt to fix DJGPP bfd build (and likely others) sergiodj+buildbot
2017-10-11 13:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-11 14:08 [binutils-gdb] Use std::vector for symtab_fns sergiodj+buildbot
2017-10-11 15:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-11 14:30 [binutils-gdb] Garbage collect reattach_breakpoints sergiodj+buildbot
2017-10-11 16:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-11 15:19 [binutils-gdb] ELF/BFD: Fix padding in `elf_external_linux_prpsinfo64' sergiodj+buildbot
2017-10-11 18:02 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-11 16:30 [binutils-gdb] ELF/BFD: Handle both variants of the 64-bit Linux core PRPSINFO note sergiodj+buildbot
2017-10-11 20:30 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-11 20:32 [binutils-gdb] Add native target for FreeBSD/arm sergiodj+buildbot
2017-10-12 0:13 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-11 22:52 [binutils-gdb] Remove prepare_re_set_context sergiodj+buildbot
2017-10-12 2:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-11 23:12 [binutils-gdb] Constify add_prefix_cmd sergiodj+buildbot
2017-10-12 4:05 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-12 2:45 [binutils-gdb] Remove cleanups from TUI sergiodj+buildbot
2017-10-12 5:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-12 3:23 [binutils-gdb] Fix remaining targets using wrong .interp conditions sergiodj+buildbot
2017-10-12 6:29 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-12 3:43 [binutils-gdb] _bfd_elf_link_hash_hide_symbol calls in generic ELF code sergiodj+buildbot
2017-10-12 8:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-12 9:37 [binutils-gdb] x86: Add _bfd_x86_elf_hide_symbol sergiodj+buildbot
2017-10-12 10:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-12 13:05 [binutils-gdb] Force the AArch64 linker backend to refuse to link when it encounters unresoleable relocations sergiodj+buildbot
2017-10-12 13:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-12 18:10 [binutils-gdb] Enable gdb.base/inferior-died.exp on is_remote target boards sergiodj+buildbot
2017-10-12 19:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-12 18:52 [binutils-gdb] Tighten remote check in gdb.base/argv0-symlink.exp sergiodj+buildbot
2017-10-12 21:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-12 19:33 [binutils-gdb] checkpoint.exp: Check for non-"target native" instead of isnative/is_remote sergiodj+buildbot
2017-10-12 23:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-12 21:52 [binutils-gdb] lwp_info: Make the arch code free arch_lwp_info sergiodj+buildbot
2017-10-13 2:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-12 23:51 [binutils-gdb] linux low: Make the arch code free arch_process_info sergiodj+buildbot
2017-10-13 3:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-13 0:06 [binutils-gdb] Run gdb.base/catch-fork-static.exp on remote target boards sergiodj+buildbot
2017-10-13 0:55 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-13 0:40 [binutils-gdb] C++-ify prologue-value's pv_area sergiodj+buildbot
2017-10-13 5:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-13 3:01 [binutils-gdb] Remove is_remote check in labels.exp sergiodj+buildbot
2017-10-13 8:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-13 3:20 [binutils-gdb] Remove references to gdb64 in the testsuite sergiodj+buildbot
2017-10-13 10:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-13 4:53 [binutils-gdb] FT32: support for FT32B processor - part 1 sergiodj+buildbot
2017-10-13 15:05 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-13 9:47 [binutils-gdb] Eliminate is_remote check in gdb.base/shlib-call.exp sergiodj+buildbot
2017-10-13 18:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-13 11:37 [binutils-gdb] Fix is_remote check in gdb.base/remote.exp sergiodj+buildbot
2017-10-13 21:51 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-13 12:26 [binutils-gdb] Skip gdb.threads/thread_events.exp on RSP targets properly sergiodj+buildbot
2017-10-14 0:22 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-13 12:51 [binutils-gdb] kfail gdb.python/py-evsignal.exp on RSP targets properly sergiodj+buildbot
2017-10-14 1:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-13 14:31 [binutils-gdb] Remove is_remote kfail from gdb.python/py-evthreads.exp sergiodj+buildbot
2017-10-14 4:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-13 15:16 [binutils-gdb] Change objfile to use new/delete sergiodj+buildbot
2017-10-14 6:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-13 15:42 [binutils-gdb] Regenerate features/s390-gs-linux64.c and features/s390x-gs-linux64.c sergiodj+buildbot
2017-10-14 8:13 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-13 16:57 [binutils-gdb] Make gdb.base/find-unmapped.exp pass on remote targets sergiodj+buildbot
2017-10-14 11:14 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-13 18:20 [binutils-gdb] Fix gdb.base/testenv.exp against --target_board=native-extended-gdbserver sergiodj+buildbot
2017-10-14 13:38 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-13 18:48 [binutils-gdb] Skip a few tests on targets that can't use the "run" commmand sergiodj+buildbot
2017-10-14 14:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-14 2:59 [binutils-gdb] Simplify tic6x and s390x expedite registers sergiodj+buildbot
2017-10-14 9:27 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-14 5:29 [binutils-gdb] Don't run gdb.gdb/ selftests if use_gdb_stub is true sergiodj+buildbot
2017-10-14 12:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-14 12:31 [binutils-gdb] Replace psymbol_allocation_list with std::vector sergiodj+buildbot
2017-10-14 18:02 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-16 10:50 [binutils-gdb] Regenerate gdbserver/configure sergiodj+buildbot
2017-10-16 15:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-16 11:24 [binutils-gdb] Remove regformats/tic6x-{c62x,c64x,c64xp}.dat sergiodj+buildbot
2017-10-16 12:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-16 20:19 [binutils-gdb] Make native gdbserver boards no longer be "remote" (in DejaGnu terms) sergiodj+buildbot
2017-10-16 21:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-16 22:35 [binutils-gdb] Use std::vector in end_symtab_get_static_block sergiodj+buildbot
2017-10-16 23:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-16 23:06 [binutils-gdb] Remove some cleanups from probe.c sergiodj+buildbot
2017-10-17 0:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-17 0:17 [binutils-gdb] Simple cleanup removals in remote.c sergiodj+buildbot
2017-10-17 3:55 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-17 1:24 [binutils-gdb] Return unique_xmalloc_ptr from target_read_stralloc sergiodj+buildbot
2017-10-17 5:07 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-17 2:05 [binutils-gdb] Record and output access specifiers for nested typedefs sergiodj+buildbot
2017-10-17 7:33 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-17 6:41 [binutils-gdb] PR22306, Invalid free() in slurp_symtab() sergiodj+buildbot
2017-10-17 9:06 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-17 12:52 [binutils-gdb] [GDBserver] Move arm.o to arch/arm.o sergiodj+buildbot
2017-10-17 13:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-17 13:53 [binutils-gdb] [GDBserver] Move arm-linux.o and arm-get-next-pcs.o to arch/ sergiodj+buildbot
2017-10-17 14:55 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-17 14:23 [binutils-gdb] [GDBserver] Move aarch64-insn.o to arch/ and remove one Makefile rule sergiodj+buildbot
2017-10-17 16:13 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-17 14:34 [binutils-gdb] Simplify regcache::xfer_part sergiodj+buildbot
2017-10-17 17:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-17 14:44 [binutils-gdb] Fix double-free corruption sergiodj+buildbot
2017-10-17 19:00 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-17 15:53 [binutils-gdb] Remove obsolete assertion from regcache.c sergiodj+buildbot
2017-10-17 21:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-17 17:30 [binutils-gdb] Add several "quit with live inferior" tests sergiodj+buildbot
2017-10-18 0:02 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-18 12:24 [binutils-gdb] Remove features/tic6x-c62x-linux.c sergiodj+buildbot
2017-10-18 13:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-18 14:57 [binutils-gdb] [Visium] Disassemble the operands of the stop instruction sergiodj+buildbot
2017-10-18 15:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-18 18:20 [binutils-gdb] Issue complaint instead of assert for invalid/unhandled DW_AT_accessibility sergiodj+buildbot
2017-10-18 18:44 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-18 19:06 [binutils-gdb] Canonicalize conversion operators sergiodj+buildbot
2017-10-18 20:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-18 23:22 [binutils-gdb] tile: Mark __tls_get_addr in gc_mark_hook sergiodj+buildbot
2017-10-19 0:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-19 13:54 [binutils-gdb] tilegx: Check bfd_link_executable for TLS check sergiodj+buildbot
2017-10-19 16:00 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-19 18:15 [binutils-gdb] Fix build breakage in gdb/xml-support.c sergiodj+buildbot
2017-10-19 20:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-20 0:10 [binutils-gdb] Remove cleanup from call_function_by_hand_dummy sergiodj+buildbot
2017-10-20 0:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-20 2:37 [binutils-gdb] Get rid of VEC(interp_factory_p) sergiodj+buildbot
2017-10-20 3:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-20 15:58 [binutils-gdb] Fix 'gdb.base/quit.exp hangs forever' if the test fails sergiodj+buildbot
2017-10-20 17:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-20 16:28 [binutils-gdb] Introduce new_bfd_ref sergiodj+buildbot
2017-10-20 19:00 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-20 17:24 [binutils-gdb] Use "new" to allocate gdb_bfd_data sergiodj+buildbot
2017-10-20 20:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-20 19:05 [binutils-gdb] Use std::vector in gdb_bfd_data sergiodj+buildbot
2017-10-20 21:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-21 18:29 [binutils-gdb] Get rid of VEC (mem_region) sergiodj+buildbot
2017-10-21 20:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-26 7:22 [binutils-gdb] Enable Intel VAES instructions sergiodj+buildbot
2017-10-26 11:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-26 9:40 [binutils-gdb] Fix unstable test names in gdb.base/startup-with-shell.exp sergiodj+buildbot
2017-10-26 18:55 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-26 11:38 [binutils-gdb] Drop /proc/PID/status polling from gdb.threads/attach-into-signal.exp sergiodj+buildbot
2017-10-26 23:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-26 12:26 [binutils-gdb] Reindent gdb.threads/attach-into-signal.exp sergiodj+buildbot
2017-10-27 0:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-26 13:10 [binutils-gdb] Fix unstable test names in gdb.arch/arc-tdesc-cpu.exp sergiodj+buildbot
2017-10-26 17:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-26 13:38 [binutils-gdb] Fix gdb.opt/inline-cmds.exp regressions sergiodj+buildbot
2017-10-27 3:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-26 14:06 [binutils-gdb] RISC-V: Only relax to C.LUI when imm != 0 and rd != 0/2 sergiodj+buildbot
2017-10-27 4:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-26 14:44 [binutils-gdb] Fix unstable test names in gdb.gdb/unittest.exp sergiodj+buildbot
2017-10-26 20:08 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-26 16:13 [binutils-gdb] Fix unstable test names in gdb.python/py-objfile.exp sergiodj+buildbot
2017-10-26 21:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-26 16:36 [binutils-gdb] Use const reference for decimal_from_string argument sergiodj+buildbot
2017-10-27 10:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-26 19:13 [binutils-gdb] PR22348, conflicting global vars in crx and cr16 sergiodj+buildbot
2017-10-27 17:21 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-26 19:34 [binutils-gdb] Target FP: Use target format throughout expression parsing sergiodj+buildbot
2017-10-27 18:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-26 20:23 [binutils-gdb] s/get_regcache_arch (regcache)/regcache->arch ()/g sergiodj+buildbot
2017-10-27 19:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-26 20:53 [binutils-gdb] const-fy function parameter struct address_space *aspace sergiodj+buildbot
2017-10-27 21:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-26 21:14 [binutils-gdb] const-fy breakpoint_ops->breakpoint_hit parameter aspace sergiodj+buildbot
2017-10-27 22:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-27 3:57 [binutils-gdb] RISC-V: Fix disassembly of c.addi4spn, c.addi16sp, c.lui when imm=0 sergiodj+buildbot
2017-10-27 12:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-27 4:29 [binutils-gdb] Fix racy test in gdb.base/new-ui.exp sergiodj+buildbot
2017-10-27 13:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-27 13:22 [binutils-gdb] Remove regular_breakpoint_inserted_here_p declaration sergiodj+buildbot
2017-10-27 23:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-27 15:45 [binutils-gdb] Add common AARCH64 REGNUM defines sergiodj+buildbot
2017-10-27 16:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-28 3:31 [binutils-gdb] Get rid of VEC(filename_language) sergiodj+buildbot
2017-10-28 10:02 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-28 5:03 [binutils-gdb] Get rid of VEC(loaded_script_ptr) sergiodj+buildbot
2017-10-28 12:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-28 5:38 [binutils-gdb] Allocate breakpoint_objfile_data with new sergiodj+buildbot
2017-10-28 13:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-28 6:56 [binutils-gdb] Remove find_inferior usage for thread_search sergiodj+buildbot
2017-10-28 21:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-28 8:07 [binutils-gdb] C++ify xml-syscall.c sergiodj+buildbot
2017-10-28 16:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-28 8:39 [binutils-gdb] common-utils-selftests.c: Add ATTRIBUTE_PRINTF sergiodj+buildbot
2017-10-28 17:59 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-28 12:08 [binutils-gdb] PR22300, Abort in elf32_hppa_relocate_section building polyml sergiodj+buildbot
2017-10-28 22:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-29 17:24 [binutils-gdb] xtensa-xtregs: Fix formatting issues sergiodj+buildbot
2017-10-29 18:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-30 2:05 [binutils-gdb] relocs_compatible test for gc-sections sergiodj+buildbot
2017-10-30 3:42 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-30 2:25 [binutils-gdb] frv-elf --gc-sections failures sergiodj+buildbot
2017-10-30 4:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-30 3:36 [binutils-gdb] darwin-nat: Remove gdb.h include sergiodj+buildbot
2017-10-30 6:08 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-30 13:20 [binutils-gdb] remote.c, QCatchSyscalls: Build std::string instead of unique_xmalloc_ptr sergiodj+buildbot
2017-10-30 15:38 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-31 1:56 [binutils-gdb] gdb/Makefile.in: fix 'make tags' failure sergiodj+buildbot
2017-10-31 3:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-31 14:53 [binutils-gdb] Fix illegal memory access triggered when parsing a PE binary with a corrupt data dictionary sergiodj+buildbot
2017-10-31 15:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-10-31 19:14 [binutils-gdb] tracepoint: Remove unnecessary const_cast sergiodj+buildbot
2017-10-31 19:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-01 1:59 [binutils-gdb] Use console uiout when executing breakpoint commands sergiodj+buildbot
2017-11-01 2:59 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-01 8:21 [binutils-gdb] PR22374, PowerPC unnecessary PLT entries sergiodj+buildbot
2017-11-01 10:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-01 11:58 [binutils-gdb] Fix an invalid free called when attempting to link a COFF object against an ELF archive with --no-keep-memory enabled sergiodj+buildbot
2017-11-01 12:51 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-02 15:52 [binutils-gdb] Remove code wrapped by "#if 0" sergiodj+buildbot
2017-11-02 17:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-02 16:13 [binutils-gdb] New method regcache::assert_regnum sergiodj+buildbot
2017-11-02 18:59 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-02 19:26 [binutils-gdb] const-fy regcache::m_readonly_p sergiodj+buildbot
2017-11-02 23:55 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-03 11:02 [binutils-gdb] Skip gdb.python/py-thrhandle.exp if python is not enabled sergiodj+buildbot
2017-11-03 12:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-03 15:03 [binutils-gdb] [ARC] Force the disassam to use the hexadecimal number for printing sergiodj+buildbot
2017-11-03 16:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-03 18:40 [binutils-gdb] x86: Remove func_pointer_refcount sergiodj+buildbot
2017-11-03 20:42 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-04 17:45 [binutils-gdb] Remove cleanups from link_callbacks_einfo sergiodj+buildbot
2017-11-04 19:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-04 18:06 [binutils-gdb] Use std::vector in compile-loc2c.c sergiodj+buildbot
2017-11-04 20:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-04 18:59 [binutils-gdb] Use unique_xmalloc_ptr in find_separate_debug_file_by_debuglink sergiodj+buildbot
2017-11-04 22:00 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-04 19:51 [binutils-gdb] Remove directive-searched cleanups sergiodj+buildbot
2017-11-04 23:32 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-04 20:14 [binutils-gdb] Replace start_rbreak_breakpoints and end_rbreak_breakpoints sergiodj+buildbot
2017-11-05 0:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-04 20:56 [binutils-gdb] Remove make_cleanup_free_objfile sergiodj+buildbot
2017-11-05 3:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-04 23:25 [binutils-gdb] Remove cleanups from linux-tdep.c sergiodj+buildbot
2017-11-05 5:59 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-04 23:46 [binutils-gdb] Use unique_xmalloc_ptr in c_type_print_base sergiodj+buildbot
2017-11-05 7:13 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-05 0:50 [binutils-gdb] PR22394, hppa-linux-ld fails to emit dynamic relocations sergiodj+buildbot
2017-11-05 12:06 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-05 3:51 [binutils-gdb] Introduce gdb_breakpoint_up sergiodj+buildbot
2017-11-05 9:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-05 7:46 [binutils-gdb] powerpc TLS in PIEs sergiodj+buildbot
2017-11-05 15:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-06 15:56 [binutils-gdb] Target FP: Add string routines to target-float.{c,h} sergiodj+buildbot
2017-11-06 17:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-06 16:44 [binutils-gdb] Target FP: Add conversion routines to target-float.{c, h} sergiodj+buildbot
2017-11-06 18:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-06 17:27 [binutils-gdb] Target FP: Add binop and compare routines to target-float.{c, h} sergiodj+buildbot
2017-11-06 20:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-06 20:20 [binutils-gdb] Target FP: Remove unused floating-point routines sergiodj+buildbot
2017-11-07 1:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-06 21:12 [binutils-gdb] Target FP: Merge doublest.c and dfp.c into target-float.c sergiodj+buildbot
2017-11-07 3:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-06 22:47 [binutils-gdb] Don't set terminal flags twice in a row sergiodj+buildbot
2017-11-07 6:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-07 1:06 [binutils-gdb] Test attaching to a process that isn't a process group leader sergiodj+buildbot
2017-11-07 10:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-07 2:03 [binutils-gdb] Update my e-mail address sergiodj+buildbot
2017-11-07 12:57 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-07 9:31 [binutils-gdb] Require ngettext in test of system gettext implementation sergiodj+buildbot
2017-11-07 15:22 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-07 10:07 [binutils-gdb] PowerPC64 statistics message sergiodj+buildbot
2017-11-07 16:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-07 10:42 [binutils-gdb] This patch similarly to the AArch64 one enables Dot Product support by default for the Cortex-A55 and Cortex-A75 which have hardware support for these instructions sergiodj+buildbot
2017-11-07 17:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-07 11:32 [binutils-gdb] Allow enabling/disabling breakpoint location ranges sergiodj+buildbot
2017-11-07 19:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-07 12:55 [binutils-gdb] Add base 'enable/disable invalid location range' tests sergiodj+buildbot
2017-11-07 22:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-07 14:20 [binutils-gdb] Add some more breakpoint/location range tests sergiodj+buildbot
2017-11-08 0:42 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-07 20:49 [binutils-gdb] opcodes/arc: Fix incorrect insn_class for some nps insns sergiodj+buildbot
2017-11-08 3:42 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-07 21:27 [binutils-gdb] Constify add_abbrev_prefix_cmd sergiodj+buildbot
2017-11-08 5:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-07 21:57 [binutils-gdb] Constify add_com_suppress_notification sergiodj+buildbot
2017-11-08 6:07 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-07 23:28 [binutils-gdb] Constify add_path and friends sergiodj+buildbot
2017-11-08 10:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-07 23:48 [binutils-gdb] Remove cleanup from backtrace_command sergiodj+buildbot
2017-11-08 11:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-08 1:18 [binutils-gdb] Constify add_setshow_* sergiodj+buildbot
2017-11-08 16:23 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-09 10:49 [binutils-gdb] Change the type of the aarch64_feature_set typedef to unsigned long long so that it will work on 32-bit hosts sergiodj+buildbot
2017-11-09 11:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-09 16:31 [binutils-gdb] Simplify the psymbol hash function sergiodj+buildbot
2017-11-09 18:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-09 17:04 [binutils-gdb] Adds the new Fields and Operand types for the new instructions in Armv8.4-a sergiodj+buildbot
2017-11-09 20:07 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-09 20:24 [binutils-gdb] fix typos in ada-lang.c comment sergiodj+buildbot
2017-11-10 2:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-09 23:12 [binutils-gdb] Fix racy output matching in gdb.asm/asm-source.exp sergiodj+buildbot
2017-11-10 3:38 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-09 23:46 [binutils-gdb] Fix racy output matching in gdb.base/completion.exp sergiodj+buildbot
2017-11-10 5:28 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-10 0:28 [binutils-gdb] Fix racy output matching in gdb.base/memattr.exp sergiodj+buildbot
2017-11-10 6:41 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-12 10:14 [binutils-gdb] non_got_ref after adjust_dynamic_relocs sergiodj+buildbot
2017-11-12 12:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-12 10:49 [binutils-gdb] weakdef list handling sergiodj+buildbot
2017-11-12 13:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-13 1:32 [binutils-gdb] ld: Remove PF_X from PT_PHDR segment sergiodj+buildbot
2017-11-13 2:28 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-13 11:44 [binutils-gdb] x86: {f, }xsave64 / {f, }xrstor64 / xsaveopt64 should not allow q suffix sergiodj+buildbot
2017-11-13 12:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-13 15:31 [binutils-gdb] Enable hardware single step for m68k in GDBServer sergiodj+buildbot
2017-11-13 16:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-14 5:41 [binutils-gdb] Inconsistent .eh_frame_hdr on powerpc64 sergiodj+buildbot
2017-11-14 6:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-14 9:28 [binutils-gdb] x86: add disassembler support for XOP VPCOM* pseudo-ops sergiodj+buildbot
2017-11-14 12:06 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-15 8:44 [binutils-gdb] x86: drop VEXI4_Fixup() sergiodj+buildbot
2017-11-15 10:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-15 9:40 [binutils-gdb] x86: use correct register names sergiodj+buildbot
2017-11-15 12:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-15 10:29 [binutils-gdb] Fix M68HC11_NUM_REGS sergiodj+buildbot
2017-11-15 13:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-15 12:22 [binutils-gdb] Handle ' and I format flags sergiodj+buildbot
2017-11-15 16:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-15 15:43 [binutils-gdb] Move self to Past Maintainers sergiodj+buildbot
2017-11-15 19:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-15 17:36 [binutils-gdb] Separate the new FP16 instructions backported from Armv8.4-a to Armv8.2-a into a new flag order to distinguish them from the rest of the already existing optional FP16 instructions in Armv8.2-a sergiodj+buildbot
2017-11-15 22:05 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-15 21:02 [binutils-gdb] Include <array> to declare std::array<> sergiodj+buildbot
2017-11-16 3:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-16 10:28 [binutils-gdb] Fix tic6x-uclinux GDBserver build failure sergiodj+buildbot
2017-11-16 11:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-16 16:44 [binutils-gdb] GDBserver: Fix ignored Ctrl-C after reconnection sergiodj+buildbot
2017-11-16 22:39 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-16 18:53 [binutils-gdb] Add new AArch64 FP16 FM{A|S} instructions sergiodj+buildbot
2017-11-17 4:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-16 20:25 [binutils-gdb] Fix testing gdb.rust/modules.exp against gdbserver sergiodj+buildbot
2017-11-17 9:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-16 21:11 [binutils-gdb] gdb/inflow.c: Move SIGTTOU temporary ignoring to a RAII class sergiodj+buildbot
2017-11-17 10:51 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-16 23:37 [binutils-gdb] Don't ever Quit out of resume sergiodj+buildbot
2017-11-17 14:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-16 23:48 [binutils-gdb] Test breakpoint commands w/ "continue" + Ctrl-C sergiodj+buildbot
2017-11-17 17:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-17 12:33 [binutils-gdb] x86: Pass "%F%P:" to linker callback in case of error sergiodj+buildbot
2017-11-17 19:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-17 18:49 [binutils-gdb] Make output_thread_groups take an std::vector<int> sergiodj+buildbot
2017-11-17 22:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-17 22:05 [binutils-gdb] Handle dereferencing Rust trait objects sergiodj+buildbot
2017-11-18 4:21 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-19 1:27 [binutils-gdb] Fix error message typo sergiodj+buildbot
2017-11-19 2:38 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-20 3:48 [binutils-gdb] Remove usage of find_inferior in win32-i386-low.c sergiodj+buildbot
2017-11-20 4:42 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-20 8:34 [binutils-gdb] Remove usage of find_thread when calling resume_status_pending_p sergiodj+buildbot
2017-11-20 19:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-20 10:03 [binutils-gdb] Remove usage of find_inferior when calling kill_one_lwp_callback sergiodj+buildbot
2017-11-20 21:27 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-21 0:29 [binutils-gdb] 0xff chars in name components table; cp-name-parser lex UTF-8 identifiers sergiodj+buildbot
2017-11-21 2:22 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-21 1:02 [binutils-gdb] Unit test name-component bounds searching directly sergiodj+buildbot
2017-11-21 3:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-21 2:07 [binutils-gdb] Fix mapped_index::find_name_components_bounds upper bound computation sergiodj+buildbot
2017-11-21 4:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-21 4:54 [binutils-gdb] Fix build failure in darwin-nat.c sergiodj+buildbot
2017-11-21 7:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-21 18:08 [binutils-gdb] [PowerPC] Detect different long double floating-point formats sergiodj+buildbot
2017-11-21 19:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-22 0:26 [binutils-gdb] Add multiple-CPU support in ravenscar-thread.c sergiodj+buildbot
2017-11-22 1:57 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-22 1:10 [binutils-gdb] problem debugging ravenscar programs if runtime is stripped sergiodj+buildbot
2017-11-22 3:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-22 1:50 [binutils-gdb] (Ada) crash connecting to TSIM simulator sergiodj+buildbot
2017-11-22 4:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-22 12:42 [binutils-gdb] Fix build with GCC 8: strncpy -> memcpy sergiodj+buildbot
2017-11-22 13:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-22 15:10 [binutils-gdb] Target FP: Make use of MPFR if available sergiodj+buildbot
2017-11-22 17:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-22 16:24 [binutils-gdb] [testsuite] Pass -pie in ldflags sergiodj+buildbot
2017-11-22 19:38 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-22 17:05 [binutils-gdb] [testsuite] Don't skip gdb.dwarf2/pr10770.exp for non-gcc compiler sergiodj+buildbot
2017-11-22 22:05 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-22 17:26 [binutils-gdb] [testsuite] Pass pthreads in prepare_for_testing sergiodj+buildbot
2017-11-22 23:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-22 20:23 [binutils-gdb] Remove obsolete core-regset.c sergiodj+buildbot
2017-11-23 0:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-22 22:42 [binutils-gdb] Show optimized out local variables in "info locals" sergiodj+buildbot
2017-11-23 8:08 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-22 23:03 [binutils-gdb] C++ify osdata sergiodj+buildbot
2017-11-23 9:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-23 13:28 [binutils-gdb] Rename u.weakdef and make it a circular list sergiodj+buildbot
2017-11-23 17:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-23 19:54 [binutils-gdb] Revert unexpected rename in previous patch sergiodj+buildbot
2017-11-24 1:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-24 8:04 [binutils-gdb] x86: don't omit disambiguating suffixes from "fi*" sergiodj+buildbot
2017-11-24 8:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-24 9:50 [binutils-gdb] Change tic6x target descriptions sergiodj+buildbot
2017-11-24 10:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-24 11:34 [binutils-gdb] Change value_contents_eq return bool sergiodj+buildbot
2017-11-24 12:54 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-24 12:40 [binutils-gdb] Add aarch64_create_target_description sergiodj+buildbot
2017-11-24 14:08 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-24 13:09 [binutils-gdb] Use flexible target descriptors for aarch64 sergiodj+buildbot
2017-11-24 16:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-24 14:23 [binutils-gdb] regcache::cooked_read unit test sergiodj+buildbot
2017-11-24 19:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-24 14:52 [binutils-gdb] Add xml selftests for aarch64 target description sergiodj+buildbot
2017-11-24 17:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-24 16:34 [binutils-gdb] elf: Properly compute offsets of note descriptor and next note sergiodj+buildbot
2017-11-24 21:44 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-24 17:40 [binutils-gdb] Remove dead code in regcache::dump sergiodj+buildbot
2017-11-24 23:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-24 20:00 [binutils-gdb] remote: C++ify thread_item and threads_listing_context sergiodj+buildbot
2017-11-25 3:55 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-24 20:32 [binutils-gdb] Create private_thread_info hierarchy sergiodj+buildbot
2017-11-25 5:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-24 23:37 [binutils-gdb] Workaround build bug with GCC 6.2.1 sergiodj+buildbot
2017-11-25 10:29 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-25 2:17 [binutils-gdb] Make strcmp_iw NOT ignore whitespace in the middle of tokens sergiodj+buildbot
2017-11-25 17:54 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-25 3:37 [binutils-gdb] Revert "elf: Properly compute offsets of note descriptor and next note" sergiodj+buildbot
2017-11-25 11:44 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-25 8:52 [binutils-gdb] Add comprehensive C++ operator linespec/location/completion tests sergiodj+buildbot
2017-11-25 20:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-26 18:30 [binutils-gdb] Removes a cleanup from gcore.c sergiodj+buildbot
2017-11-26 21:32 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-27 12:30 [binutils-gdb] [PR ld/22269] aarch64: Handle local undefined weak symbols sergiodj+buildbot
2017-11-27 16:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-28 0:24 [binutils-gdb] A simpler way to make the "arch" build directory sergiodj+buildbot
2017-11-28 1:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-28 1:08 [binutils-gdb] Move mi objects to mi subdirectory sergiodj+buildbot
2017-11-28 5:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-28 2:28 [binutils-gdb] Move unittests object files to unittests subdirectory sergiodj+buildbot
2017-11-28 11:38 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-28 11:31 [binutils-gdb] Remove REMOTE_OBS sergiodj+buildbot
2017-11-29 1:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-28 12:16 [binutils-gdb] ld: Set non_ir_ref_regular on symbols referenced in regular objects sergiodj+buildbot
2017-11-29 3:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-28 14:12 [binutils-gdb] ELF: Don't set non_ir_ref_regular in check_relocs sergiodj+buildbot
2017-11-29 9:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-28 14:37 [binutils-gdb] Fix a memory access violation when attempting to parse a corrupt COFF binary with a relocation that points beyond the end of the section to be relocated sergiodj+buildbot
2017-11-29 11:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-28 20:11 [binutils-gdb] Prevent a memory exhaustion problem when trying to read in strings from a COFF binary with a corrupt string table size sergiodj+buildbot
2017-11-29 13:23 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-29 11:10 [binutils-gdb] [gdb/testsuite] Fix wrong return type in tests sergiodj+buildbot
2017-11-29 17:32 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-29 16:44 [binutils-gdb] Fix add-symbol-file usage and errors sergiodj+buildbot
2017-11-29 21:25 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-29 20:48 [binutils-gdb] Handle custom completion match prefix / LCD sergiodj+buildbot
2017-11-30 9:33 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-29 21:46 [binutils-gdb] Make "break foo" find "A::foo", A::B::foo", etc. [C++ and wild matching] sergiodj+buildbot
2017-11-30 11:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-29 22:06 [binutils-gdb] Breakpoints in symbols with ABI tags (PR c++/19436) sergiodj+buildbot
2017-11-30 13:25 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-30 0:53 [binutils-gdb] preserve type length in ada-lang.c::to_fixed_range_type sergiodj+buildbot
2017-11-30 15:22 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-30 1:14 [binutils-gdb] Define MPFR_USE_INTMAX_T so that mpfr.h assumes intmax_t is available sergiodj+buildbot
2017-11-30 17:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-30 12:28 [binutils-gdb] x86: derive DispN from BaseIndex sergiodj+buildbot
2017-11-30 23:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-30 16:51 [binutils-gdb] Fix gdb.linespec/cpls-ops.exp on 32-bit sergiodj+buildbot
2017-12-01 3:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-30 17:48 [binutils-gdb] Use boards/local-board.exp more sergiodj+buildbot
2017-12-01 5:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-11-30 23:21 [binutils-gdb] PR22533, dynamic relocs generated for weak aliases sergiodj+buildbot
2017-12-01 7:32 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-01 7:34 [binutils-gdb] readonly_dynrelocs sergiodj+buildbot
2017-12-01 10:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-01 12:00 [binutils-gdb] Replace mail address with the URL in copyright header sergiodj+buildbot
2017-12-01 12:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-01 12:37 [binutils-gdb] x86: Print dynreloc in readonly section for map file output sergiodj+buildbot
2017-12-01 13:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-01 13:57 [binutils-gdb] Update GDB's list of maintainers to reflect today's reality sergiodj+buildbot
2017-12-01 15:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-01 17:42 [binutils-gdb] Use consistent types for holding instructions, instruction masks, etc sergiodj+buildbot
2017-12-01 18:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-03 1:53 [binutils-gdb] Fix typo in poison.h sergiodj+buildbot
2017-12-03 2:23 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-03 2:14 [binutils-gdb] Remove usage of find_inferior in regcache_invalidate_pid sergiodj+buildbot
2017-12-03 3:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-03 2:33 [binutils-gdb] Remove usage of find_inferior in lynx_mourn sergiodj+buildbot
2017-12-03 5:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-03 2:54 [binutils-gdb] Remove usages of find_inferior in linux-mips-low.c sergiodj+buildbot
2017-12-03 6:23 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-03 6:09 [binutils-gdb] Remove find_inferior_in_random sergiodj+buildbot
2017-12-03 10:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-03 6:32 [binutils-gdb] Remove usages of find_inferior in select_event_lwp sergiodj+buildbot
2017-12-03 18:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-03 8:38 [binutils-gdb] Remove usages of find_inferior that call proceed_one_lwp sergiodj+buildbot
2017-12-03 23:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-03 8:58 [binutils-gdb] Update comments sergiodj+buildbot
2017-12-04 0:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-03 10:05 [binutils-gdb] Remove for_each_inferior_with_data sergiodj+buildbot
2017-12-04 4:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-03 10:23 [binutils-gdb] Remove usages of find_inferior calling not_stopped_callback sergiodj+buildbot
2017-12-03 16:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-03 12:00 [binutils-gdb] Remove usage of find_inferior in linux_stabilize_threads sergiodj+buildbot
2017-12-03 19:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-03 15:50 [binutils-gdb] Remove find_inferior sergiodj+buildbot
2017-12-04 1:39 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-03 18:21 [binutils-gdb] Make make-target-delegates grok namespace scope op and template params sergiodj+buildbot
2017-12-04 11:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-03 18:49 [binutils-gdb] Remove mem_region_vector typedef sergiodj+buildbot
2017-12-04 13:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-03 22:43 [binutils-gdb] Fix "FAIL: VLE relocations 3" sergiodj+buildbot
2017-12-04 8:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-04 16:38 [binutils-gdb] Fix displaced-stepping RIP-relative VEX-encoded instructions (AVX) (PR gdb/22499) sergiodj+buildbot
2017-12-04 17:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-04 18:06 [binutils-gdb] Implement 'set dump-excluded-mappings' command sergiodj+buildbot
2017-12-04 19:41 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-05 21:31 [binutils-gdb] Remove some unused variables sergiodj+buildbot
2017-12-05 22:02 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-05 22:06 [binutils-gdb] Redefine gdb_static_assert as static_assert sergiodj+buildbot
2017-12-05 23:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-05 22:53 [binutils-gdb] Make target_desc::properties an std::vector sergiodj+buildbot
2017-12-06 0:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-06 0:02 [binutils-gdb] Make tdesc_feature::name an std::string sergiodj+buildbot
2017-12-06 5:25 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-06 0:22 [binutils-gdb] Make tdesc_feature::registers an std::vector sergiodj+buildbot
2017-12-06 6:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-06 0:22 [binutils-gdb] Make target_desc::features an std::vector sergiodj+buildbot
2017-12-06 4:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-06 0:44 [binutils-gdb] Make tdesc_reg string fields std::string sergiodj+buildbot
2017-12-06 7:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-06 1:05 [binutils-gdb] Make tdesc_feature::types an std::vector sergiodj+buildbot
2017-12-06 9:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-06 1:26 [binutils-gdb] Make tdesc_type::name an std::string sergiodj+buildbot
2017-12-06 11:06 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-06 2:59 [binutils-gdb] Split tdesc_type into multiple classes sergiodj+buildbot
2017-12-06 14:54 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-06 5:26 [binutils-gdb] Make tdesc_type::u::u::fields an std::vector sergiodj+buildbot
2017-12-06 12:23 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-06 7:50 [binutils-gdb] Comment tidy sergiodj+buildbot
2017-12-06 17:25 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-06 8:12 [binutils-gdb] dyn_relocs tidy sergiodj+buildbot
2017-12-06 18:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-06 8:32 [binutils-gdb] Fix Common symbol override test fails sergiodj+buildbot
2017-12-06 20:02 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-06 8:55 [binutils-gdb] BFD whitespace fixes sergiodj+buildbot
2017-12-06 21:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-06 21:56 [binutils-gdb] Fix syscall group completion sergiodj+buildbot
2017-12-07 0:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-06 23:13 [binutils-gdb] target_set_syscall_catchpoint, use gdb::array_view and bool sergiodj+buildbot
2017-12-07 1:39 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-07 13:37 [binutils-gdb] gdb/MAINTAINERS: restore m68hc11, score and xstormy16 entries sergiodj+buildbot
2017-12-07 14:07 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-07 17:07 [binutils-gdb] Implement explicit locations for Python breakpoints sergiodj+buildbot
2017-12-07 18:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-07 17:45 [binutils-gdb] Add virtual destructor to selftest sergiodj+buildbot
2017-12-07 21:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-07 19:12 [binutils-gdb] Initialize target description early in IPA sergiodj+buildbot
2017-12-07 22:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-07 19:41 [binutils-gdb] Fix build with g++ 6.3.1 sergiodj+buildbot
2017-12-08 0:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-07 23:49 [binutils-gdb] Record nested types sergiodj+buildbot
2017-12-08 4:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-08 0:32 [binutils-gdb] Validate explicit locations with early termination sergiodj+buildbot
2017-12-08 5:25 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-08 6:55 [binutils-gdb] Add aix 64-bit check to bfd_get_sign_extend_vma sergiodj+buildbot
2017-12-08 7:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-08 10:27 [binutils-gdb] Fix stripping relocs in a file with mergeable notes sergiodj+buildbot
2017-12-08 11:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-08 16:06 [binutils-gdb] Fix PR 22567: set SAL .section in minsym_found sergiodj+buildbot
2017-12-08 16:38 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-08 19:17 [binutils-gdb] Adjust breakpoint address by clearing non-significant bits sergiodj+buildbot
2017-12-08 21:39 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-08 20:59 [binutils-gdb] Fix thinko on dtrace-probe.c:dtrace_process_dof_probe sergiodj+buildbot
2017-12-09 0:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-08 21:57 [binutils-gdb] Work around sparc glibc bug sergiodj+buildbot
2017-12-09 2:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-09 0:49 [binutils-gdb] DWARF-5: .debug_names index producer sergiodj+buildbot
2017-12-09 6:42 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-09 1:35 [binutils-gdb] Change dwarf2_initialize_objfile's return value sergiodj+buildbot
2017-12-09 7:57 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-09 4:00 [binutils-gdb] DWARF-5: .debug_names index consumer sergiodj+buildbot
2017-12-09 12:29 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-09 5:22 [binutils-gdb] dwarf2read.c:mapped_index, use gdb::array_view, simplify symbol table sergiodj+buildbot
2017-12-09 13:44 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-11 8:38 [binutils-gdb] Adapt gdb.ada/variant_record_packed_array.exp to accept reordered components sergiodj+buildbot
2017-12-11 9:05 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-11 14:55 [binutils-gdb] [MPFR] Fix regression on 32-bit host systems sergiodj+buildbot
2017-12-11 15:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-11 16:19 [binutils-gdb] [Binutils][Objdump]Check symbol section information while search a mapping symbol backward sergiodj+buildbot
2017-12-11 17:54 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-12 13:33 [binutils-gdb] PR22576, ppc64_skip_trampoline_code uses wrong r2 for EXEC_REVERSE sergiodj+buildbot
2017-12-12 14:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-12 16:06 [binutils-gdb] gdb: testsuite: Add or1k l.nop instruction sergiodj+buildbot
2017-12-12 17:55 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-12 18:13 [binutils-gdb] sim: cgen: add remainder functions (needed for OR1K lf.rem.[sd]) sergiodj+buildbot
2017-12-12 22:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-12 20:43 [binutils-gdb] sim: or1k: add cgen generated files sergiodj+buildbot
2017-12-13 2:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-12 21:23 [binutils-gdb] sim: or1k: add autoconf generated files sergiodj+buildbot
2017-12-13 4:13 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-12 22:06 [binutils-gdb] sim: testsuite: add testsuite for or1k sim sergiodj+buildbot
2017-12-13 5:29 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-13 13:44 [binutils-gdb] This patch enables disassembler_needs_relocs for PRU. It is needed to print correct symbols when disassembling arguments of "call" instructions with a relocation sergiodj+buildbot
2017-12-13 14:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-13 15:34 [binutils-gdb] gdb: Fix ARI warnings in or1k-tdep.c sergiodj+buildbot
2017-12-13 18:08 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-13 17:00 [binutils-gdb] Factor out final completion match string building sergiodj+buildbot
2017-12-13 20:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-13 18:40 [binutils-gdb] Tighten regexp of lib/completion-support.exp:test_gdb_complete_tab_multiple sergiodj+buildbot
2017-12-13 23:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-13 19:21 [binutils-gdb] python: Add qualified parameter to gdb.Breakpoint sergiodj+buildbot
2017-12-14 0:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-14 4:30 [binutils-gdb] (Ada) Add support for task switching when debugging core files sergiodj+buildbot
2017-12-14 5:44 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-14 13:12 [binutils-gdb] Update the address of the FSF in the copyright notice of files which were using the old address sergiodj+buildbot
2017-12-14 13:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-15 9:44 [binutils-gdb] Fix disassembly for PowerPC sergiodj+buildbot
2017-12-15 10:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-15 11:47 [binutils-gdb] Skip 'maintenance check xml-descriptions' if XML is disabled sergiodj+buildbot
2017-12-15 14:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-16 22:41 [binutils-gdb] gdb: Add news entries for new or1k target sergiodj+buildbot
2017-12-16 23:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-18 4:13 [binutils-gdb] (Ada) crash assigning to record component which is an array sergiodj+buildbot
2017-12-18 5:59 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-18 4:51 [binutils-gdb] improved error message when getting an exception printing a variable sergiodj+buildbot
2017-12-18 7:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-18 8:56 [binutils-gdb] x86: replace Reg8, Reg16, Reg32, and Reg64 sergiodj+buildbot
2017-12-18 10:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-18 9:35 [binutils-gdb] x86: drop FloatReg and FloatAcc sergiodj+buildbot
2017-12-18 11:41 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-18 11:26 [binutils-gdb] x86: fold certain AVX and AVX2 templates sergiodj+buildbot
2017-12-18 14:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-19 12:47 [binutils-gdb] Add support for V_4B so we can properly reject it sergiodj+buildbot
2017-12-19 13:21 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-20 21:59 [binutils-gdb] RISC-V: Add compressed instruction hints, and a few misc cleanups sergiodj+buildbot
2017-12-20 23:27 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-21 2:01 [binutils-gdb] Remove write-only assignment in rs6000-tdep.c sergiodj+buildbot
2017-12-21 2:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-23 21:51 [binutils-gdb] Add ATTRIBUTE_PRINTF to printf_field_type_assignment sergiodj+buildbot
2017-12-23 22:32 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-27 15:03 [binutils-gdb] reggroups: Add test and docs for `info reg $reggroup` feature sergiodj+buildbot
2017-12-27 15:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-27 15:46 [binutils-gdb] reggroups: Convert reggroups from post_init to pre_init sergiodj+buildbot
2017-12-27 18:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-27 16:45 [binutils-gdb] reggroups: Add reggroup_gdbarch_new, reggroup_find for dynamic reggroups sergiodj+buildbot
2017-12-27 21:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-27 17:51 [binutils-gdb] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p sergiodj+buildbot
2017-12-27 23:51 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-28 17:51 [binutils-gdb] Remove unused HP-UX TARGET_OBJECT_ enums sergiodj+buildbot
2017-12-28 18:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-30 3:17 [binutils-gdb] Remove unnecessary call to get_thread_db_info sergiodj+buildbot
2017-12-30 4:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-30 4:57 [binutils-gdb] Ignore warning about using different types of enums in switch sergiodj+buildbot
2017-12-30 6:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-30 7:02 [binutils-gdb] Make mapped_debug_names and mapped_index final sergiodj+buildbot
2017-12-30 7:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-31 2:43 [binutils-gdb] dwarf2read: Silence -Wenum-compare-switch warning sergiodj+buildbot
2017-12-31 4:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-31 4:57 [binutils-gdb] Only ignore -Wenum-compare-switch if it exists sergiodj+buildbot
2017-12-31 6:02 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-31 11:04 [binutils-gdb] Avoid indexing std::vector past the end sergiodj+buildbot
2017-12-31 15:32 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-02 3:57 [binutils-gdb] Yearly rotation of the gdb/ChangeLog file sergiodj+buildbot
2018-01-02 4:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-02 4:44 [binutils-gdb] Update copyright year in version message of GDB, GDBserver and GDBreplay sergiodj+buildbot
2018-01-02 6:32 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-02 5:29 [binutils-gdb] gdb/copyright.py: Do not forget to remind about MULTIPLE_COPYRIGHT_HEADERS sergiodj+buildbot
2018-01-02 8:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-02 6:58 [binutils-gdb] Update copyright year range in all GDB files sergiodj+buildbot
2018-01-02 13:23 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-02 8:44 [binutils-gdb] Add support for dynamic DW_AT_byte_stride sergiodj+buildbot
2018-01-02 16:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-02 12:52 [binutils-gdb] x86: partial revert of 10c17abdd0 sergiodj+buildbot
2018-01-02 21:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-02 17:37 [binutils-gdb] Fix compile time warning (in the ARM simulator) about a print statement with insufficient arguments sergiodj+buildbot
2018-01-02 23:32 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-03 4:17 [binutils-gdb] Unbreak spurious fails in gdb.base/step-line.exp sergiodj+buildbot
2018-01-03 5:44 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-03 7:50 [binutils-gdb] Update year range in copyright notice of binutils files sergiodj+buildbot
2018-01-03 8:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-03 20:29 [binutils-gdb] Create pseudo sections for FreeBSD NT_PROCSTAT_(PROC|FILES|VMMAP) notes sergiodj+buildbot
2018-01-03 21:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-04 8:52 [binutils-gdb] Add gdb.ada/info_addr_mixed_case new testcase sergiodj+buildbot
2018-01-04 10:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-04 9:35 [binutils-gdb] Add "complete break ada" test to gdb.ada/complete.exp sergiodj+buildbot
2018-01-04 12:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-04 11:13 [binutils-gdb] gdb.ada/maint_with_ada.exp: New testcase sergiodj+buildbot
2018-01-04 17:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-04 22:38 [binutils-gdb] RISC-V: Add 2 missing privileged registers sergiodj+buildbot
2018-01-04 23:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-05 5:59 [binutils-gdb] Bump version to 8.1.50.DATE-git sergiodj+buildbot
2018-01-05 9:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-05 6:37 [binutils-gdb] Update NEWS post GDB 8.1 branch creation sergiodj+buildbot
2018-01-05 11:51 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-05 7:31 [binutils-gdb] (Ada) Remove printing of array's first index when unneeded sergiodj+buildbot
2018-01-05 13:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-05 10:38 [binutils-gdb] memory error printing component of record from convenience variable sergiodj+buildbot
2018-01-05 15:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-05 11:59 [binutils-gdb] (Ada) Fix Length attribute on array access sergiodj+buildbot
2018-01-05 17:27 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-05 17:13 [binutils-gdb] Fix gdb.ada/info_addr_mixed_case.exp (PR gdb/22670) sergiodj+buildbot
2018-01-05 23:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-05 18:57 [binutils-gdb] Fix gdb/spu-tdep.c build breakage sergiodj+buildbot
2018-01-06 1:42 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-05 19:58 [binutils-gdb] Fix regression: cannot start with LD_PRELOAD=libSegFault.so (PR gdb/18653#c7) sergiodj+buildbot
2018-01-06 5:33 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-07 14:48 [binutils-gdb] C++ify xmethod_worker, get rid of VEC(xmethod_worker_ptr) sergiodj+buildbot
2018-01-07 16:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-07 15:59 [binutils-gdb] Remove xmethod_worker::clone sergiodj+buildbot
2018-01-07 17:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-07 16:23 [binutils-gdb] Replace VEC(gdb_xml_value_s) with std::vector sergiodj+buildbot
2018-01-07 20:05 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-07 17:08 [binutils-gdb] Replace VEC(converted_character_d) with std::vector sergiodj+buildbot
2018-01-07 22:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-07 18:03 [binutils-gdb] Make parse_debug_format_options return an std::string sergiodj+buildbot
2018-01-08 0:00 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-07 18:45 [binutils-gdb] Replace objfile field in dwarf2_cu and dwarf2_per_cu_data with dwarf2_per_objfile sergiodj+buildbot
2018-01-08 1:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-07 19:29 [binutils-gdb] Remove dwarf2_per_objfile global sergiodj+buildbot
2018-01-08 3:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-07 20:11 [binutils-gdb] Remove dwarf2_cu::dwarf2_per_objfile sergiodj+buildbot
2018-01-08 5:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-08 5:16 [binutils-gdb] (Ada) Fix print of array using non-contiguous enumeration indexes sergiodj+buildbot
2018-01-08 7:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-08 10:42 [binutils-gdb] Fix GDB build failure when $development is false sergiodj+buildbot
2018-01-08 13:33 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-08 13:11 [binutils-gdb] x86: Properly encode vmovd with 64-bit memeory sergiodj+buildbot
2018-01-08 20:28 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-09 9:16 [binutils-gdb] PR22662, nds32: Fix a typographical error sergiodj+buildbot
2018-01-09 11:13 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-09 11:49 [binutils-gdb] Add support for the AArch64's CSDB instruction sergiodj+buildbot
2018-01-09 16:00 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-09 22:14 [binutils-gdb] Support 'info proc' for FreeBSD process core dumps sergiodj+buildbot
2018-01-09 23:21 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-09 23:38 [binutils-gdb] Use gdb::unique_xmalloc_ptr<> instead of a deleter that invokes free() sergiodj+buildbot
2018-01-10 5:06 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-10 0:28 [binutils-gdb] Support 'info proc' for native FreeBSD processes sergiodj+buildbot
2018-01-10 7:23 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-10 1:01 [binutils-gdb] Document support for 'info proc' on FreeBSD sergiodj+buildbot
2018-01-10 9:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-10 2:16 [binutils-gdb] RISC-V: Disassemble x0 based addresses as 0 sergiodj+buildbot
2018-01-10 11:29 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-10 14:58 [binutils-gdb] x86: fix Disp8 handling for scalar AVX512_4FMAPS insns sergiodj+buildbot
2018-01-10 18:29 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-10 15:48 [binutils-gdb] Update the libiberty sources with the latest patches found in the master sources sergiodj+buildbot
2018-01-10 20:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-11 0:21 [binutils-gdb] Fix gdb.ada/complete.exp's "complete break ada" test (PR gdb/22670) sergiodj+buildbot
2018-01-11 2:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-11 1:05 [binutils-gdb] Ada: make verbatim matcher override other language matchers (PR gdb/22670) sergiodj+buildbot
2018-01-11 5:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-11 1:53 [binutils-gdb] language_get_symbol_name_matcher -> get_symbol_name_matcher sergiodj+buildbot
2018-01-11 6:42 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-11 5:36 [binutils-gdb] Remove VL variants for 4FMAPS and 4VNNIW insns sergiodj+buildbot
2018-01-11 15:25 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-11 6:23 [binutils-gdb] Fix backwards compatibility with old GDBservers (PR remote/22597) sergiodj+buildbot
2018-01-11 17:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-11 18:02 [binutils-gdb] ld: Keep PREINIT_ARRAY/INIT_ARRAY/FINI_ARRAY sections for -r --gc-sections sergiodj+buildbot
2018-01-11 22:07 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-11 19:05 [binutils-gdb] gdb.base/breakpoint-in-ro-region.exp regression on sss targets (PR gdb/22583) sergiodj+buildbot
2018-01-11 23:42 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-11 23:57 [binutils-gdb] Ignore dynamic references on forced local symbols sergiodj+buildbot
2018-01-12 4:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-12 2:29 [binutils-gdb] gdb_compile_shlib: Only consider shlib= options when building executables sergiodj+buildbot
2018-01-12 6:44 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-12 4:24 [binutils-gdb] ld: Create a new LOAD segment for separate code segment sergiodj+buildbot
2018-01-12 11:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-12 11:03 [binutils-gdb] Fixes for "Ignore dynamic references on forced local symbols" sergiodj+buildbot
2018-01-12 21:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-12 11:55 [binutils-gdb] Fix override of common symbols for a.out sergiodj+buildbot
2018-01-12 23:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-12 13:37 [binutils-gdb] Optimize the performance of the group_setup function sergiodj+buildbot
2018-01-13 0:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-12 19:19 [binutils-gdb] Fix GDB hang with remote after error from resume sergiodj+buildbot
2018-01-13 2:33 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-12 20:00 [binutils-gdb] Add testcase for GDB hang fixed by previous commit sergiodj+buildbot
2018-01-13 6:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-12 23:43 [binutils-gdb] Install and generate docs for gdb-add-index sergiodj+buildbot
2018-01-13 15:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-13 0:00 [binutils-gdb] gdb/testsuite: Don't attempt tests if they fail to compile sergiodj+buildbot
2018-01-13 17:14 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-13 13:46 [binutils-gdb] Add note about 2.30 branch creation to changelogs sergiodj+buildbot
2018-01-13 20:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-13 14:31 [binutils-gdb] Bump version number to 2.30.51 sergiodj+buildbot
2018-01-13 23:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-13 16:17 [binutils-gdb] Update notes on how to make a release sergiodj+buildbot
2018-01-14 3:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-15 20:05 [binutils-gdb] Fix scm-ports.exp regression sergiodj+buildbot
2018-01-15 22:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-15 23:14 [binutils-gdb] gdb/common/signals-state-save-restore.c: Fix typos sergiodj+buildbot
2018-01-16 2:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-16 0:18 [binutils-gdb] RISC-V: Add support for addi that compresses to c.nop sergiodj+buildbot
2018-01-16 4:33 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-16 13:03 [binutils-gdb] Update translations for various binutils components sergiodj+buildbot
2018-01-16 14:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-17 11:10 [binutils-gdb] Warning fix sergiodj+buildbot
2018-01-17 12:23 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-17 11:56 [binutils-gdb] Relax gdb.compile/compile.exp to match the address printed for frame sergiodj+buildbot
2018-01-17 14:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-17 17:04 [binutils-gdb] Replace CET bit with IBT and SHSTK bits sergiodj+buildbot
2018-01-18 4:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-17 17:53 [binutils-gdb] linux-nat: Remove unnecessary xstrdup sergiodj+buildbot
2018-01-18 6:41 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-17 17:59 [binutils-gdb] Make linux_ptrace_attach_fail_reason return an std::string sergiodj+buildbot
2018-01-18 8:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-17 18:49 [binutils-gdb] Fix gdb segv when objfile can't be opened sergiodj+buildbot
2018-01-18 10:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-17 19:45 [binutils-gdb] Allocate dwarf2_cu with new sergiodj+buildbot
2018-01-18 16:38 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-17 19:57 [binutils-gdb] Change dwarf2_cu::method_info to be a std::vector sergiodj+buildbot
2018-01-18 18:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-17 20:09 [binutils-gdb] Remove objfile argument from add_dyn_prop sergiodj+buildbot
2018-01-18 20:59 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-17 20:16 [binutils-gdb] Allocate abbrev_table with new sergiodj+buildbot
2018-01-18 15:00 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-17 20:21 [binutils-gdb] Remove symbolp typedef sergiodj+buildbot
2018-01-18 23:08 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-17 22:21 [binutils-gdb] RISC-V: Fix bug in prior addi/c.nop patch sergiodj+buildbot
2018-01-19 1:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-17 23:20 [binutils-gdb] Fix warning on gdb/compile/compile.c (C++-ify "triplet_rx") sergiodj+buildbot
2018-01-19 4:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-18 12:14 [binutils-gdb] PowerPC PLT stub alignment fixes sergiodj+buildbot
2018-01-19 9:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-18 12:35 [binutils-gdb] Call cooked_read in ppu2spu_prev_register sergiodj+buildbot
2018-01-19 12:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-18 18:56 [binutils-gdb] S390: Use soft float in s390-tdbregs test case sergiodj+buildbot
2018-01-19 16:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-19 6:21 [binutils-gdb] Make tests expect [ \t]+ pattern instead of \t for "info reg" command sergiodj+buildbot
2018-01-19 20:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-19 9:33 [binutils-gdb] Find arm-linux-gnueabi(hf)?-gcc in compile sergiodj+buildbot
2018-01-19 22:27 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-19 10:00 [binutils-gdb] Don't pass -m32 to libcc1 on arm-linux sergiodj+buildbot
2018-01-20 0:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-19 13:35 [binutils-gdb] S390: Improve comments for s390-tdbregs test case sergiodj+buildbot
2018-01-20 5:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-19 17:34 [binutils-gdb] Pass inferior down to target_detach and to_detach sergiodj+buildbot
2018-01-20 10:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-19 17:48 [binutils-gdb] Make linux_nat_detach/thread_db_detach use the inferior parameter sergiodj+buildbot
2018-01-20 12:41 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-19 19:04 [binutils-gdb] gdb: Fix ia64 defining TRAP_HWBKPT before including gdb_wait.h sergiodj+buildbot
2018-01-20 15:23 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-19 19:06 [binutils-gdb] gdb: Add missing #ifdef USE_THREAD_DB to gdbserver sergiodj+buildbot
2018-01-20 17:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-19 19:19 [binutils-gdb] S390: Fix infcalls in s390-vregs test case sergiodj+buildbot
2018-01-20 20:07 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-19 22:47 [binutils-gdb] Fix qualified name lookup for Rust sergiodj+buildbot
2018-01-20 21:57 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-20 22:46 [binutils-gdb] x86: Check the versioned __tls_get_addr symbol sergiodj+buildbot
2018-01-21 0:29 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-21 15:22 [binutils-gdb] gdb: Add test for some error cases of @entry usage sergiodj+buildbot
2018-01-21 16:28 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-21 16:05 [binutils-gdb] gdb: Remove duplicate declaration of global innermost_block sergiodj+buildbot
2018-01-21 18:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-21 16:42 [binutils-gdb] gdb: Remove out of date comment sergiodj+buildbot
2018-01-21 23:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-21 16:50 [binutils-gdb] gdb: New API for tracking innermost block sergiodj+buildbot
2018-01-21 19:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-21 17:01 [binutils-gdb] gdb: PR mi/20395: Fix -var-update for registers in frames 1 and up sergiodj+buildbot
2018-01-21 21:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-21 19:13 [binutils-gdb] gdb: Don't store a thread-id for floating varobj sergiodj+buildbot
2018-01-22 2:25 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-22 4:32 [binutils-gdb] wrong line number in breakpoint location sergiodj+buildbot
2018-01-22 5:54 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-22 11:23 [binutils-gdb] Don't call gdbarch_pseudo_register_read_value in jit.c sergiodj+buildbot
2018-01-22 13:06 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-22 11:47 [binutils-gdb] Replace regcache_raw_read with regcache->raw_read sergiodj+buildbot
2018-01-22 17:54 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-22 12:07 [binutils-gdb] Remove mt port sergiodj+buildbot
2018-01-22 15:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-22 12:12 [binutils-gdb] regcache::cooked_write test sergiodj+buildbot
2018-01-23 0:06 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-23 13:15 [binutils-gdb] s390: Allocate gdbarch & tdep at start of gdbarch_init sergiodj+buildbot
2018-01-23 15:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-23 13:40 [binutils-gdb] s390: gdbarch_tdep add field tdesc sergiodj+buildbot
2018-01-23 20:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-23 14:30 [binutils-gdb] s390: Hook s390 into OSABI mechanism sergiodj+buildbot
2018-01-24 1:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-23 14:44 [binutils-gdb] s390: gdbarch_tdep add hook for syscall record sergiodj+buildbot
2018-01-24 3:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-23 15:13 [binutils-gdb] s390: Move record-replay to s390-tdep.c sergiodj+buildbot
2018-01-24 6:29 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-23 16:25 [binutils-gdb] s390: Move tdesc validation to separate function sergiodj+buildbot
2018-01-23 21:39 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-23 17:23 [binutils-gdb] s390: if -> gdb_assert for tdesc_has_registers check sergiodj+buildbot
2018-01-23 23:29 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-23 17:26 [binutils-gdb] Enable Intel WBNOINVD instruction sergiodj+buildbot
2018-01-24 11:21 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-23 17:39 [binutils-gdb] Enable Intel PCONFIG instruction sergiodj+buildbot
2018-01-24 13:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-23 19:18 [binutils-gdb] MIPS/BFD: Update a stale `mips_elf32_section_processing' reference sergiodj+buildbot
2018-01-24 15:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-24 16:51 [binutils-gdb] [LD][AARCH64]Add group relocations to create PC-relative offset sergiodj+buildbot
2018-01-24 22:33 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-24 18:49 [binutils-gdb] Fix GCC PR83906 - [8 Regression] Random FAIL: libstdc++-prettyprinters/80276.cc whatis p4 sergiodj+buildbot
2018-01-25 0:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-25 11:35 [binutils-gdb] Fix PR ld/22727 (TLS breakage in PIC/PIE mode on SPARC) sergiodj+buildbot
2018-01-25 12:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-25 11:50 [binutils-gdb] PR22746, crash when running 32-bit objdump on corrupted file sergiodj+buildbot
2018-01-25 14:38 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-26 5:59 [binutils-gdb] PowerPC PLT stub matching sergiodj+buildbot
2018-01-26 11:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-26 6:02 [binutils-gdb] Define __start/__stop symbols when there is only a dynamic def sergiodj+buildbot
2018-01-26 8:25 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-26 15:05 [binutils-gdb] Add myself as a write-after-approval GDB maintainer sergiodj+buildbot
2018-01-26 15:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-27 14:46 [binutils-gdb] Updated Russian translation for the bfd sub-directory sergiodj+buildbot
2018-01-27 15:42 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-27 16:43 [binutils-gdb] Avoid compilation warning in libiberty/simple-object-xcoff.c sergiodj+buildbot
2018-01-27 17:33 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-28 17:24 [binutils-gdb] Remove dwarf2_per_objfile_free and use after free of dwarf2_per_objfile sergiodj+buildbot
2018-01-28 18:00 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-29 5:45 [binutils-gdb] PR22741, objcopy segfault on fuzzed COFF object sergiodj+buildbot
2018-01-29 6:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-29 18:21 [binutils-gdb] Don't call "detach_inferior" on "remote_follow_fork" sergiodj+buildbot
2018-01-29 19:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-30 8:44 [binutils-gdb] PR22758, FAIL: Run pr22393-2 sergiodj+buildbot
2018-01-30 10:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-30 15:53 [binutils-gdb] linux-nat: Eliminate custom target_terminal_{inferior, ours}, stop using set_sigint_trap sergiodj+buildbot
2018-01-30 17:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-30 16:06 [binutils-gdb] Per-inferior target_terminal state, fix PR gdb/13211, more sergiodj+buildbot
2018-01-30 18:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-30 16:50 [binutils-gdb] s390: Fix gdb.base/all-architectures.exp with --enable-targets=all sergiodj+buildbot
2018-01-30 20:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-30 18:05 [binutils-gdb] Improve junk file removal in source tarball creation script sergiodj+buildbot
2018-01-30 22:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-31 7:35 [binutils-gdb] internal-error using '@' (repeat) operator on array of dynamic objects sergiodj+buildbot
2018-01-31 9:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-31 13:41 [binutils-gdb] (Ada) Add gdb-mi support for stopping at start of exception handler sergiodj+buildbot
2018-01-31 21:06 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-31 13:56 [binutils-gdb] (Ada) C++fy conditional string when catching exception sergiodj+buildbot
2018-01-31 18:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-31 15:00 [binutils-gdb] bfd_elf_define_start_stop: Fix check sergiodj+buildbot
2018-02-01 1:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-01-31 15:21 [binutils-gdb] gdb: Fix remote-sim/MinGW/Darwin builds sergiodj+buildbot
2018-02-01 3:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-01 13:38 [binutils-gdb] Fix compile time warnings building the binutils with clang sergiodj+buildbot
2018-02-01 14:39 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-01 15:47 [binutils-gdb] set ret signed in arm_record_extension_space sergiodj+buildbot
2018-02-01 19:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-01 16:11 [binutils-gdb] Rewrite arm_record_coproc_data_proc and arm_record_data_proc_misc_ld_str sergiodj+buildbot
2018-02-01 20:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-02 3:50 [binutils-gdb] Do not classify C struct members as a filename sergiodj+buildbot
2018-02-02 4:41 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-02 12:31 [binutils-gdb] PowerPC64, don't relocate nops sergiodj+buildbot
2018-02-02 13:33 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-02 19:21 [binutils-gdb] MI: Allow non-raw varobj evaluation sergiodj+buildbot
2018-02-02 20:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-03 17:11 [binutils-gdb] gdb/testsuite: Remove use of dejagnu cleanup proc sergiodj+buildbot
2018-02-03 18:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-05 5:03 [binutils-gdb] Move comment in gdb/dwarf2read.c::dwarf2_physname sergiodj+buildbot
2018-02-05 5:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-05 14:17 [binutils-gdb] ELF/BFD: Propagate the return status from backend section processing sergiodj+buildbot
2018-02-05 17:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-05 14:29 [binutils-gdb] MIPS/BFD: Correctly report unsupported `.reginfo' section size sergiodj+buildbot
2018-02-05 21:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-05 14:42 [binutils-gdb] RISC-V/BFD: Correct a missing initializer error with pre-4.7 GCC sergiodj+buildbot
2018-02-05 23:02 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-05 16:54 [binutils-gdb] Use visitors for make_gdb_type sergiodj+buildbot
2018-02-06 0:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-05 17:05 [binutils-gdb] x86: Remove the unused _GLOBAL_OFFSET_TABLE_ sergiodj+buildbot
2018-02-06 2:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-05 18:11 [binutils-gdb] Remove myself as a write-after-approval GDB maintainer sergiodj+buildbot
2018-02-06 4:30 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-05 19:45 [binutils-gdb] ppc64: Fix stwux encoding sergiodj+buildbot
2018-02-06 8:14 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-06 16:04 [binutils-gdb] Allow the find_abstract_instance_name() function in the BFD library to also return file and line number information sergiodj+buildbot
2018-02-06 17:14 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-06 16:48 [binutils-gdb] Prevent attempts to call strncpy with a zero-length field by chacking the size of debuglink sections sergiodj+buildbot
2018-02-06 20:07 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-06 17:02 [binutils-gdb] Fix GCC 8's -Wstringop-overflow on bfd/coff-rs6000.c sergiodj+buildbot
2018-02-06 22:38 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-06 17:17 [binutils-gdb] Improve the find_nearest_line function for the MIPS target so that it tries harder to find a function name sergiodj+buildbot
2018-02-07 0:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-06 17:29 [binutils-gdb] Treat OP_F77_UNDETERMINED_ARGLIST as OP_FUNCALL sergiodj+buildbot
2018-02-07 2:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-06 17:43 [binutils-gdb] Fix PR ld/22263 on SPARC sergiodj+buildbot
2018-02-07 4:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-06 20:29 [binutils-gdb] Remove some $ARCH_read_pc and $ARCH_write_pc sergiodj+buildbot
2018-02-07 7:08 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-07 4:11 [binutils-gdb] Revert "PowerPC PLT speculative execution barriers" sergiodj+buildbot
2018-02-07 11:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-07 14:04 [binutils-gdb] Fix type of values representing optimized out static members sergiodj+buildbot
2018-02-07 14:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-08 19:05 [binutils-gdb] Remove a cleanup from gdbserver sergiodj+buildbot
2018-02-08 19:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-08 19:18 [binutils-gdb] Remove make_cleanup_restore_current_thread from gdbserver sergiodj+buildbot
2018-02-08 22:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-08 20:25 [binutils-gdb] Use gdb::def_vector in find_source_lines sergiodj+buildbot
2018-02-09 8:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-08 21:32 [binutils-gdb] RISC-V: Add comment for previous change sergiodj+buildbot
2018-02-09 14:05 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-08 23:17 [binutils-gdb] Remove cleanups from solib.c sergiodj+buildbot
2018-02-09 12:21 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-09 0:11 [binutils-gdb] Use unique_xmalloc_ptr in build_id_to_debug_bfd sergiodj+buildbot
2018-02-09 10:02 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-09 0:47 [binutils-gdb] x86: Keep the unused _GLOBAL_OFFSET_TABLE_ for Solaris sergiodj+buildbot
2018-02-09 16:14 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-09 1:04 [binutils-gdb] x86: Set need_global_offset_table with info->output_bfd->xvec sergiodj+buildbot
2018-02-09 17:57 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-09 12:24 [binutils-gdb] gdb/NEWS: Clarify the news entry for "rbreak" in GDB 8.1 sergiodj+buildbot
2018-02-09 20:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-09 13:19 [binutils-gdb] Use std::string in execute_script_contents sergiodj+buildbot
2018-02-10 1:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-09 13:31 [binutils-gdb] Use gdb::unique_xmalloc_ptr in auto_load_section_scripts sergiodj+buildbot
2018-02-10 4:32 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-09 13:44 [binutils-gdb] common: add scoped_fd sergiodj+buildbot
2018-02-10 6:25 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-09 14:22 [binutils-gdb] btrace: prepare for throwing exceptions when enabling btrace sergiodj+buildbot
2018-02-10 11:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-09 14:47 [binutils-gdb] btrace, gdbserver: remove the to_supports_btrace target method sergiodj+buildbot
2018-02-10 15:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-09 15:12 [binutils-gdb] btrace: check perf_event_paranoid sergiodj+buildbot
2018-02-10 21:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-09 15:25 [binutils-gdb] btrace: reword error messages sergiodj+buildbot
2018-02-10 22:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-09 16:32 [binutils-gdb] btrace, gdbserver: use exceptions to convey btrace enable/disable errors sergiodj+buildbot
2018-02-10 13:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-09 19:26 [binutils-gdb] Don't reference past the end of the vector sergiodj+buildbot
2018-02-11 1:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-10 2:13 [binutils-gdb] Fix GOT relocation overflow on SPARC sergiodj+buildbot
2018-02-11 5:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-12 12:16 [binutils-gdb] oops - actually remove the assignment this time: bfd/elf32-nds32.c:9693]: (warning) Redundant assignment of 'irel->r_addend' to itself sergiodj+buildbot
2018-02-12 14:02 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-12 12:31 [binutils-gdb] Fix compile time warning: bfd/elf32-arc.c:1537]: (warning) Redundant assignment of 'rel->r_offset' to itself sergiodj+buildbot
2018-02-12 16:11 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-13 0:11 [binutils-gdb] gdb: Remove cleanup from dw2_do_instantiate_symtab sergiodj+buildbot
2018-02-13 1:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-13 6:47 [binutils-gdb] Fix prefix of maint set/show per-command sergiodj+buildbot
2018-02-13 7:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-13 9:23 [binutils-gdb] PR22829, objcopy/strip removes PT_GNU_RELRO from lld binaries sergiodj+buildbot
2018-02-13 10:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-13 12:41 [binutils-gdb] PR22836, "-r -s" doesn't work with -g3 using GCC 7 sergiodj+buildbot
2018-02-13 13:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-13 13:31 [binutils-gdb] WebAssembly: Disable subdirectory configuration for unsupported LD sergiodj+buildbot
2018-02-13 18:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-13 13:43 [binutils-gdb] Fix compile time warning messages from gcc version 8 about cast between incompatible function types sergiodj+buildbot
2018-02-13 20:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-13 15:41 [binutils-gdb] Fix typo in Russian translation for the bfd/ sub-directory which could lead to a seg-fault in the linker sergiodj+buildbot
2018-02-13 22:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-13 15:51 [binutils-gdb] x86-64: Generate branch with PLT32 relocation sergiodj+buildbot
2018-02-13 23:55 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-13 17:36 [binutils-gdb] Use enum flags for flags passed to openp sergiodj+buildbot
2018-02-14 1:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-13 22:52 [binutils-gdb] x86: Properly check building shared library sergiodj+buildbot
2018-02-14 3:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-14 11:04 [binutils-gdb] Remove references to ada_name_for_lookup (deleted) sergiodj+buildbot
2018-02-14 13:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-14 12:04 [binutils-gdb] x86-64: Use PLT address for PC-relative reloc sergiodj+buildbot
2018-02-14 14:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-14 15:16 [binutils-gdb] Fix compilation of the BFD sub-directory with a gcc v8 compiler by adding extra casts sergiodj+buildbot
2018-02-14 17:13 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-14 15:50 [binutils-gdb] Move some declarations to source.h sergiodj+buildbot
2018-02-14 21:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-14 16:14 [binutils-gdb] Constify target_so_ops::bfd_open sergiodj+buildbot
2018-02-15 1:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-15 4:34 [binutils-gdb] delete ada-lang.c::ada_to_fixed_value_create advance declaration sergiodj+buildbot
2018-02-15 5:07 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-15 15:29 [binutils-gdb] PR ld/22832 on SPARC sergiodj+buildbot
2018-02-15 19:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-15 19:14 [binutils-gdb] RISC-V: Give error for ignored pcrel_lo addend sergiodj+buildbot
2018-02-15 21:27 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-15 22:04 [binutils-gdb] RISC-V: Fix relocation failure with zero address sections sergiodj+buildbot
2018-02-16 0:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-16 8:56 [binutils-gdb] Remove bfd stub function casts sergiodj+buildbot
2018-02-16 10:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-16 16:34 [binutils-gdb] New class allocate_on_obstack sergiodj+buildbot
2018-02-16 17:59 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-17 0:02 [binutils-gdb] Ignore degenerate PT_LOAD segments sergiodj+buildbot
2018-02-17 0:54 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-20 11:13 [binutils-gdb] Fix make 3.81 build errors sergiodj+buildbot
2018-02-20 12:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-20 13:30 [binutils-gdb] btrace, testsuite: do not force BTS sergiodj+buildbot
2018-02-20 14:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-20 13:39 [binutils-gdb] gnulib: import mkstemp sergiodj+buildbot
2018-02-20 16:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-20 16:58 [binutils-gdb] remote-sim: Add missing ATTRIBUTE_PRINTF sergiodj+buildbot
2018-02-20 20:06 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-21 11:39 [binutils-gdb] Class reg_buffer sergiodj+buildbot
2018-02-21 13:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-21 11:47 [binutils-gdb] class readable_regcache and pass readable_regcache to gdbarch pseudo_register_read and pseudo_register_read_value sergiodj+buildbot
2018-02-21 15:54 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-21 12:00 [binutils-gdb] Remove regcache_save and regcache_cpy sergiodj+buildbot
2018-02-21 18:22 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-21 12:12 [binutils-gdb] Class readonly_detached_regcache sergiodj+buildbot
2018-02-21 21:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-21 12:25 [binutils-gdb] Class detached_regcache sergiodj+buildbot
2018-02-21 23:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-21 12:37 [binutils-gdb] Replace regcache::dump with class register_dump sergiodj+buildbot
2018-02-22 2:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-21 12:50 [binutils-gdb] No longer create readonly regcache sergiodj+buildbot
2018-02-22 4:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-21 13:02 [binutils-gdb] Remove regcache::m_readonly_p sergiodj+buildbot
2018-02-22 6:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-21 16:31 [binutils-gdb] Remove a cleanup from parse_expression_for_completion sergiodj+buildbot
2018-02-22 15:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-21 17:11 [binutils-gdb] Remove a cleanup from call_function_by_hand_dummy sergiodj+buildbot
2018-02-22 12:32 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-21 19:23 [binutils-gdb] Add "common-defs.h" include to files in arch/ subdir not yet including it sergiodj+buildbot
2018-02-22 17:30 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-21 20:49 [binutils-gdb] Fix a typo sergiodj+buildbot
2018-02-22 20:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-22 19:44 [binutils-gdb] RISC-V: Make disassebler work for --enable-targets=all config sergiodj+buildbot
2018-02-23 0:27 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-22 22:16 [binutils-gdb] New plugin interface to get list of symbols wrapped with --wrap option sergiodj+buildbot
2018-02-23 2:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-23 11:31 [binutils-gdb] PR22881, null pointer dereference in assign_file_positions_for_non_load_sections sergiodj+buildbot
2018-02-23 13:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-23 18:26 [binutils-gdb] dwarf: Make sect_offset 64-bits sergiodj+buildbot
2018-02-23 19:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-23 20:31 [binutils-gdb] GDB/testsuite: Fix a typo in $actual_line sergiodj+buildbot
2018-02-23 22:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-24 17:31 [binutils-gdb] Remove most cleanups from linux-thread-db.c sergiodj+buildbot
2018-02-24 20:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-25 20:37 [binutils-gdb] Fix double space expected in cp_test_ptype_class sergiodj+buildbot
2018-02-25 22:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26 0:13 [binutils-gdb] unrecognized/unsupported reloc message sergiodj+buildbot
2018-02-26 2:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26 0:14 [binutils-gdb] ELF linker messages sergiodj+buildbot
2018-02-26 5:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26 0:53 [binutils-gdb] ARM and AArch64 messages sergiodj+buildbot
2018-02-26 9:07 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26 1:03 [binutils-gdb] AOUT/COFF/PE messages sergiodj+buildbot
2018-02-26 11:28 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26 1:16 [binutils-gdb] BFD messages sergiodj+buildbot
2018-02-26 13:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26 1:28 [binutils-gdb] assorted target messages sergiodj+buildbot
2018-02-26 15:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26 1:40 [binutils-gdb] crx string overflow warning sergiodj+buildbot
2018-02-26 18:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26 1:53 [binutils-gdb] Segfault on phdrs allocated but not created sergiodj+buildbot
2018-02-26 20:59 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26 12:02 [binutils-gdb] Move arch/tdesc.h to common/tdesc.h sergiodj+buildbot
2018-02-26 22:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26 15:54 [binutils-gdb] Re-write partial_die_info allocation in load_partial_dies sergiodj+buildbot
2018-02-27 1:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26 17:16 [binutils-gdb] Initial support for variant parts sergiodj+buildbot
2018-02-27 14:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26 17:35 [binutils-gdb] Change find_partial_die_in_comp_unit to dwarf2_cu::find_partial_die sergiodj+buildbot
2018-02-27 4:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26 18:06 [binutils-gdb] Change frame_filter_flags to use DEF_ENUM_FLAGS_TYPE sergiodj+buildbot
2018-02-27 23:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26 18:41 [binutils-gdb] Move read_partial_die to partial_die_info::read sergiodj+buildbot
2018-02-27 10:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26 19:59 [binutils-gdb] MIPS: Reorder ABI determination ahead of target description loading sergiodj+buildbot
2018-02-28 1:21 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-27 0:14 [binutils-gdb] Handle DW_TAG_variant_part and DW_TAG_variant sergiodj+buildbot
2018-02-27 18:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-27 16:46 [binutils-gdb] Explicitly specify common tdesc.h for use with aarch64.h sergiodj+buildbot
2018-02-28 12:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-27 19:20 [binutils-gdb] Change target_write_memory_blocks to use std::vector sergiodj+buildbot
2018-02-28 15:29 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-27 21:14 [binutils-gdb] Update get_args documentation sergiodj+buildbot
2018-02-28 18:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-28 1:47 [binutils-gdb] Workaround a FreeBSD ptrace() bug with clearing thread events sergiodj+buildbot
2018-02-28 19:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-28 10:29 [binutils-gdb] Fix potential integer overflow when reading corrupt dwarf1 debug information sergiodj+buildbot
2018-02-28 21:54 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-28 14:13 [binutils-gdb] testsuite: Restore gdb_is_target_remote_prompt sergiodj+buildbot
2018-03-01 1:44 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-28 17:02 [binutils-gdb] Create new common/pathstuff.[ch] sergiodj+buildbot
2018-03-01 3:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-02-28 23:57 [binutils-gdb] Add missing translations to ALL_LINGUAS sergiodj+buildbot
2018-03-01 8:08 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-01 11:41 [binutils-gdb] btrace, gdbserver: check btrace target pointers sergiodj+buildbot
2018-03-01 13:21 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-01 14:29 [binutils-gdb] x86: Encode AVX256/AVX512 vpsub[bwdq] with VEX128/EVEX128 sergiodj+buildbot
2018-03-01 15:02 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-01 22:37 [binutils-gdb] RISC-V: Fix symbol size bug when relaxation deletes bytes sergiodj+buildbot
2018-03-01 23:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-01 22:44 [binutils-gdb] Improve gcore shell quoting and portability sergiodj+buildbot
2018-03-02 1:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-02 12:07 [binutils-gdb] [GDB/testsuite] Use %progbits in watch-loc.c sergiodj+buildbot
2018-03-02 13:00 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-03 1:20 [binutils-gdb] opcodes error messages sergiodj+buildbot
2018-03-03 1:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-03 4:46 [binutils-gdb] Make delim_string_to_char_ptr_vec return an std::vector sergiodj+buildbot
2018-03-03 5:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-03 5:05 [binutils-gdb] Make program_space::deleted_solibs a vector of std::string sergiodj+buildbot
2018-03-03 7:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-03 8:16 [binutils-gdb] Remove free_char_ptr_vec sergiodj+buildbot
2018-03-03 11:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-04 5:54 [binutils-gdb] Implement "to_stopped_by_hw_breakpoint" for x86 debug registers sergiodj+buildbot
2018-03-04 6:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-05 1:19 [binutils-gdb] Propagate gdb_disassembly_flags to btrace_print_lines sergiodj+buildbot
2018-03-05 1:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-06 10:29 [binutils-gdb] gdb/amd64: Ignore zero sized fields when calling functions sergiodj+buildbot
2018-03-06 11:08 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-06 15:24 [binutils-gdb] btrace: Remove VEC cleanups sergiodj+buildbot
2018-03-06 19:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-06 17:58 [binutils-gdb] btrace: Remove ui_out cleanups sergiodj+buildbot
2018-03-06 20:44 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-06 20:09 [binutils-gdb] gdb/riscv: Remove partial target description support sergiodj+buildbot
2018-03-07 0:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-06 20:30 [binutils-gdb] gdb/riscv: Remove 'Contributed by....' comments sergiodj+buildbot
2018-03-06 23:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-07 7:01 [binutils-gdb] mips64 rtype_to_howto error status sergiodj+buildbot
2018-03-07 7:39 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-07 17:55 [binutils-gdb] gdb: Add riscv to list of architectures with a save_reggroup sergiodj+buildbot
2018-03-07 19:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-08 8:06 [binutils-gdb] x86/Intel: correct disassembly of fsub*/fdiv* sergiodj+buildbot
2018-03-08 11:06 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-08 8:27 [binutils-gdb] x86: bogus VMOVD with 64-bit operands should only allow for registers sergiodj+buildbot
2018-03-08 9:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-08 8:54 [binutils-gdb] x86: drop {X,Y,Z}MMWORD_MNEM_SUFFIX sergiodj+buildbot
2018-03-08 16:25 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-08 9:07 [binutils-gdb] x86: fold FMA and FMA4 templates sergiodj+buildbot
2018-03-08 18:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-08 9:44 [binutils-gdb] x86: fold VEX-encoded GFNI templates sergiodj+buildbot
2018-03-09 1:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-08 10:21 [binutils-gdb] Remove MAX_REGISTER_SIZE define sergiodj+buildbot
2018-03-09 6:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-08 10:37 [binutils-gdb] x86: avoid SSE check for LDMXCSR/STMXCSR sergiodj+buildbot
2018-03-08 13:44 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-08 20:05 [binutils-gdb] x86-64: Also optimize "clr reg64" sergiodj+buildbot
2018-03-09 11:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-08 23:13 [binutils-gdb] Don't redefine upload/download/file in gdbserver-base sergiodj+buildbot
2018-03-09 13:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-08 23:36 [binutils-gdb] linux_qxfer_libraries_svr4: Use std::string sergiodj+buildbot
2018-03-09 15:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-09 0:25 [binutils-gdb] Use std::string to simplify build_id_to_debug_bfd sergiodj+buildbot
2018-03-09 19:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-09 5:14 [binutils-gdb] Change enable_thread_stack_temporaries to an RAII class sergiodj+buildbot
2018-03-09 22:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-09 5:23 [binutils-gdb] Use scoped_fd in more places sergiodj+buildbot
2018-03-09 23:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-12 3:49 [binutils-gdb] Use std::vector for field lists in dwarf2read.c sergiodj+buildbot
2018-03-12 5:22 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-12 22:14 [binutils-gdb] gdb/riscv: Fix some ARI issues sergiodj+buildbot
2018-03-12 22:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-13 14:19 [binutils-gdb] Prevent memory access violations when attempting to parse an x86_64 PE binary containing corrupt unwind information sergiodj+buildbot
2018-03-13 15:42 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-14 11:43 [binutils-gdb] GC: Also check the local debug definition section sergiodj+buildbot
2018-03-14 12:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-14 12:19 [binutils-gdb] PowerPC64 debian bug 886264, out-of-line save/restore functions sergiodj+buildbot
2018-03-14 13:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-14 13:59 [binutils-gdb] Update my email address sergiodj+buildbot
2018-03-14 14:54 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-14 16:04 [binutils-gdb] Add usage to printf command sergiodj+buildbot
2018-03-14 16:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-14 23:20 [binutils-gdb] RISC-V: Add .insn support sergiodj+buildbot
2018-03-15 0:29 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-16 19:56 [binutils-gdb] Fix tspeed test case: copy libinproctrace to target sergiodj+buildbot
2018-03-16 20:33 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-16 20:41 [binutils-gdb] Remove make_cleanup_free_section_addr_info sergiodj+buildbot
2018-03-16 21:51 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-16 21:30 [binutils-gdb] Add silent Makefile rules sergiodj+buildbot
2018-03-16 23:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-17 19:46 [binutils-gdb] Change auto_load_objfile_script_1 to use std::string sergiodj+buildbot
2018-03-17 20:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-19 4:11 [binutils-gdb] Remove some cleanups from solib.c sergiodj+buildbot
2018-03-19 4:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-19 11:10 [binutils-gdb] Updated Spanish translation for the bfd/ sub-directory, and updated Ukranian translation for the gas/ sub-directory sergiodj+buildbot
2018-03-19 11:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-19 12:29 [binutils-gdb] Testsuite: Fix ambiguous "break" due to libinproctrace sergiodj+buildbot
2018-03-19 13:07 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-19 15:59 [binutils-gdb] Convert observers to C++ sergiodj+buildbot
2018-03-19 16:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-20 11:08 [binutils-gdb] Set non_ir_ref_dynamic if a symbol is made dynamic sergiodj+buildbot
2018-03-20 11:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-21 11:32 [binutils-gdb] Don't exceed reloc array bounds sergiodj+buildbot
2018-03-21 12:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-21 11:59 [binutils-gdb] Make tls_mask unsigned in elf32-ppc.c sergiodj+buildbot
2018-03-21 14:54 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-21 16:59 [binutils-gdb] S390: Enable re-attaching with native-extended-gdbserver sergiodj+buildbot
2018-03-21 19:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-21 18:30 [binutils-gdb] S390: Make IPA recognize tdescs with guarded storage sergiodj+buildbot
2018-03-21 21:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-22 4:50 [binutils-gdb] Make parse_static_tracepoint_marker_definition work with multiple static tracepoint definitions sergiodj+buildbot
2018-03-22 5:28 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-22 7:50 [binutils-gdb] x86: fold a few XOP templates sergiodj+buildbot
2018-03-22 8:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-22 8:02 [binutils-gdb] x86/Intel: fix fallout from earlier template folding sergiodj+buildbot
2018-03-22 10:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-22 8:17 [binutils-gdb] x86: fix swapped operand handling for BNDMOV sergiodj+buildbot
2018-03-22 12:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-22 8:31 [binutils-gdb] x86: drop remaining redundant DispN sergiodj+buildbot
2018-03-22 13:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-22 9:20 [binutils-gdb] S390: Correct brace style in s390_get_wordsize sergiodj+buildbot
2018-03-22 15:59 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-22 9:34 [binutils-gdb] Make "info proc cmdline" show args on GNU/Linux sergiodj+buildbot
2018-03-22 17:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-22 11:31 [binutils-gdb] x86: drop pointless VecESize sergiodj+buildbot
2018-03-22 14:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-23 3:37 [binutils-gdb] Remove some cleanups from record-full.c sergiodj+buildbot
2018-03-23 4:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-23 11:26 [binutils-gdb] Move gdbserver tdesc header funcs to c file sergiodj+buildbot
2018-03-23 12:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-23 12:14 [binutils-gdb] gdb: Minor cleanup in some gdb.arch/* tests sergiodj+buildbot
2018-03-23 13:39 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-23 15:04 [binutils-gdb] Make gdbserver find_register_by_number static sergiodj+buildbot
2018-03-23 16:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-23 19:13 [binutils-gdb] Add psymbols for nested types sergiodj+buildbot
2018-03-23 19:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-25 18:14 [binutils-gdb] eval.c: reverse minsym and sym sergiodj+buildbot
2018-03-25 18:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-26 11:05 [binutils-gdb] Make gdbserver reg_defs a vector of objects sergiodj+buildbot
2018-03-26 11:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-26 17:54 [binutils-gdb] Remove struct keyword from section_addr_info sergiodj+buildbot
2018-03-26 19:13 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-26 20:03 [binutils-gdb] Remove DEF_VEC_I(offset_type) sergiodj+buildbot
2018-03-26 21:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27 4:34 [binutils-gdb] Change backtrace_command_1 calling to use flags sergiodj+buildbot
2018-03-27 6:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27 4:49 [binutils-gdb] Allow hiding of some filtered frames sergiodj+buildbot
2018-03-27 7:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27 5:03 [binutils-gdb] Remove EXT_LANG_BT_COMPLETED sergiodj+buildbot
2018-03-27 9:27 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27 5:31 [binutils-gdb] Allow C-c to work in backtrace in more cases sergiodj+buildbot
2018-03-27 12:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27 6:17 [binutils-gdb] Move some code later in backtrace_command_1 sergiodj+buildbot
2018-03-27 15:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27 6:58 [binutils-gdb] Improve "backtrace" help text sergiodj+buildbot
2018-03-27 20:30 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27 7:12 [binutils-gdb] Simplify exception handling in py-framefilter.c sergiodj+buildbot
2018-03-27 21:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27 7:57 [binutils-gdb] Return EXT_LANG_BT_ERROR in one more spot in py-framefilter.c sergiodj+buildbot
2018-03-27 17:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27 14:13 [binutils-gdb] problem looking up some symbols when they have a linkage name sergiodj+buildbot
2018-03-28 0:28 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27 14:24 [binutils-gdb] Move DWARF index-related things to a separate file sergiodj+buildbot
2018-03-28 1:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27 15:13 [binutils-gdb] Include <cmath> in dwarf-index-write.c sergiodj+buildbot
2018-03-28 4:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27 16:58 [binutils-gdb] C++-ify typedef hash sergiodj+buildbot
2018-03-28 5:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27 17:14 [binutils-gdb] Remove cleanups from gdb_readline_wrapper sergiodj+buildbot
2018-03-28 7:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27 17:29 [binutils-gdb] Remove cleanups from prompt_for_continue sergiodj+buildbot
2018-03-28 8:30 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-28 9:04 [binutils-gdb] Enhance the AARCH64 assembler to support LDFF1xx instructions which use REG+REG addressing with an assumed offset register sergiodj+buildbot
2018-03-28 10:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-28 12:42 [binutils-gdb] x86: don't show suffixes for to-scalar-int conversion insns sergiodj+buildbot
2018-03-28 14:08 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-28 12:56 [binutils-gdb] x86: fold to-scalar-int conversion insns sergiodj+buildbot
2018-03-28 15:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-28 13:10 [binutils-gdb] x86: convert broadcast insn attribute to boolean sergiodj+buildbot
2018-03-28 17:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-28 17:35 [binutils-gdb] [1/2][GAS][AARCH64]Add BFD_RELOC_AARCH64_TLSLE_LDST8/16/32/64_TPREL_LO12 support in GAS sergiodj+buildbot
2018-03-28 21:28 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-28 22:32 [binutils-gdb] BFD/PA: Remove ATTRIBUTE_UNUSED from `elf_hppa_info_to_howto_rel' sergiodj+buildbot
2018-03-29 2:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-30 19:31 [binutils-gdb] Remove make_cleanup_unpush_target sergiodj+buildbot
2018-03-30 20:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-30 19:55 [binutils-gdb] Remove parameter from free_dwo_file sergiodj+buildbot
2018-03-31 0:08 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-30 20:21 [binutils-gdb] Change target_read_string to use unique_xmalloc_ptr sergiodj+buildbot
2018-03-31 2:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-03-31 1:27 [binutils-gdb] Use std::vector and std::string instead of VEC(char_ptr) in gdbserver tdesc sergiodj+buildbot
2018-03-31 6:44 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-01 18:40 [binutils-gdb] Remove char_ptr typedef sergiodj+buildbot
2018-04-01 19:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-02 22:13 [binutils-gdb] Add myself as a write-after-approval GDB maintainer sergiodj+buildbot
2018-04-02 22:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-03 18:20 [binutils-gdb] Change read_alphacoff_dynamic_symtab to use gdb::byte_vector sergiodj+buildbot
2018-04-03 18:59 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-04 1:17 [binutils-gdb] PR binutils/22875: MIPS/ELF: Also fail with relocation placeholders sergiodj+buildbot
2018-04-04 1:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-04 2:02 [binutils-gdb] PR binutils/22875: FRV/ELF: Prevent an out-of-bounds howto table access sergiodj+buildbot
2018-04-04 3:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-04 2:16 [binutils-gdb] PR binutils/22875: Visium/ELF: Prevent an out-of-bounds howto table access sergiodj+buildbot
2018-04-04 6:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-04 2:44 [binutils-gdb] PR binutils/22875: HPPA/ELF: Also fail with relocation placeholders sergiodj+buildbot
2018-04-04 10:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-04 11:58 [binutils-gdb] i386: Clear vex instead of vex.evex sergiodj+buildbot
2018-04-04 13:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-05 0:02 [binutils-gdb] elf-hppa.h warning fix sergiodj+buildbot
2018-04-05 1:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-05 13:56 [binutils-gdb] Remove some cleanups from search_minsyms_for_name sergiodj+buildbot
2018-04-05 14:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-05 14:37 [binutils-gdb] Return std::string from canonical_to_fullform sergiodj+buildbot
2018-04-05 19:05 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-05 14:52 [binutils-gdb] Have filter_results take a std::vector sergiodj+buildbot
2018-04-05 21:06 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-05 15:05 [binutils-gdb] Remove a string copy from event_location_to_sals sergiodj+buildbot
2018-04-06 1:23 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-05 16:01 [binutils-gdb] Remove unnecessary include from linespec.h sergiodj+buildbot
2018-04-06 6:44 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-05 18:17 [binutils-gdb] Change streq to return bool sergiodj+buildbot
2018-04-06 2:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-05 22:53 [binutils-gdb] Use dlsym to check if libdl is needed for plugin sergiodj+buildbot
2018-04-06 10:57 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-06 12:23 [binutils-gdb] x86-64: Don't mask out R_X86_64_converted_reloc_bit sergiodj+buildbot
2018-04-06 13:02 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-06 22:03 [binutils-gdb] Introduce a gdb_ref_ptr specialization for struct value sergiodj+buildbot
2018-04-06 22:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-06 22:31 [binutils-gdb] Change last_examine_value to value_ref_ptr sergiodj+buildbot
2018-04-07 1:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-06 23:00 [binutils-gdb] Change value history to use value_ref_ptr sergiodj+buildbot
2018-04-07 4:05 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-06 23:29 [binutils-gdb] Remove free_value_chain sergiodj+buildbot
2018-04-07 6:43 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-07 0:11 [binutils-gdb] Change value::parent to a value_ref_ptr sergiodj+buildbot
2018-04-07 11:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-07 0:41 [binutils-gdb] Change varobj to use value_ref_ptr sergiodj+buildbot
2018-04-07 2:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-07 4:04 [binutils-gdb] Remove value::next and value::released sergiodj+buildbot
2018-04-07 8:05 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-07 17:38 [binutils-gdb] Make target_read_alloc & al return vectors sergiodj+buildbot
2018-04-07 18:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-07 18:05 [binutils-gdb] Fix generation of x86-64 gdbarch with osabi none (PR 22979) sergiodj+buildbot
2018-04-07 20:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-07 18:34 [binutils-gdb] Implement write_async_safe for mi_console_file (PR 22299) sergiodj+buildbot
2018-04-07 23:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-07 18:47 [binutils-gdb] Defer breakpoint reset when cloning progspace for fork child sergiodj+buildbot
2018-04-08 0:55 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-07 19:29 [binutils-gdb] Remove some usages of get_dwarf2_per_objfile sergiodj+buildbot
2018-04-08 4:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-07 19:57 [binutils-gdb] Make dwarf2_per_objfile::all_type_units an std::vector sergiodj+buildbot
2018-04-08 7:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-07 20:17 [binutils-gdb] Remove stale file i386-avx.dat sergiodj+buildbot
2018-04-07 22:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-07 20:26 [binutils-gdb] Fix indentation in gdb.mi/mi-stack.exp sergiodj+buildbot
2018-04-08 11:27 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-07 20:40 [binutils-gdb] Fix gdb.mi/mi-stack.exp when gcc generates a stack protector sergiodj+buildbot
2018-04-08 13:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-09 9:03 [binutils-gdb] Rearrange PLT reloc output on powerpc sergiodj+buildbot
2018-04-09 14:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-09 9:17 [binutils-gdb] Support PLT16 relocs against local symbols sergiodj+buildbot
2018-04-09 16:30 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-09 9:47 [binutils-gdb] Inline PLT call optimization sergiodj+buildbot
2018-04-09 20:33 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-09 11:16 [binutils-gdb] PowerPC inline PLT call support sergiodj+buildbot
2018-04-09 18:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-09 13:04 [binutils-gdb] MIPS64/BFD: Fix a crash with invalid `r_sym' in relocation sergiodj+buildbot
2018-04-09 21:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-09 13:12 [binutils-gdb] MIPS64/BFD: Fix a crash with STN_UNDEF in relocation sergiodj+buildbot
2018-04-09 23:23 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-09 15:13 [binutils-gdb] Apply "Convert observers to C++" edit to gdbarch.sh sergiodj+buildbot
2018-04-10 0:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-09 18:55 [binutils-gdb] Copy string_view files from libstdc++ sergiodj+buildbot
2018-04-10 3:38 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-09 19:11 [binutils-gdb] Add gdb::string_view sergiodj+buildbot
2018-04-10 4:57 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-09 19:25 [binutils-gdb] Copy string_view tests from libstdc++ sergiodj+buildbot
2018-04-10 6:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-09 20:08 [binutils-gdb] Use an std::vector for inline_states sergiodj+buildbot
2018-04-10 11:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-09 20:22 [binutils-gdb] Add selftests for range_contains and insert_into_bit_range_vector sergiodj+buildbot
2018-04-10 13:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-10 14:11 [binutils-gdb] Replace finish_thread_state_cleanup with a RAII class sergiodj+buildbot
2018-04-10 14:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-11 11:23 [binutils-gdb] File I/O file handles after target closes sergiodj+buildbot
2018-04-11 14:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-11 14:46 [binutils-gdb] Add Rust test case for ".." struct initializer sergiodj+buildbot
2018-04-11 19:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-11 20:14 [binutils-gdb] Enable Intel WAITPKG instructions sergiodj+buildbot
2018-04-12 0:32 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-12 16:59 [binutils-gdb] Eliminate target_has_exited sergiodj+buildbot
2018-04-12 18:14 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-12 17:40 [binutils-gdb] Fix Solaris build sergiodj+buildbot
2018-04-12 22:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-13 8:59 [binutils-gdb] infrun: step through indirect branch thunks sergiodj+buildbot
2018-04-13 11:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-13 9:59 [binutils-gdb] btrace: fix output of "set record btrace" sergiodj+buildbot
2018-04-13 13:30 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-13 10:21 [binutils-gdb] btrace: set/show record btrace cpu sergiodj+buildbot
2018-04-13 18:29 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-13 17:44 [binutils-gdb] Show line numbers in output for "info var/func/type" sergiodj+buildbot
2018-04-13 20:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-14 9:08 [binutils-gdb] powerpc max-page-size vs __QNXTARGET__ sergiodj+buildbot
2018-04-14 13:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-15 20:05 [binutils-gdb] Add x86-tdep.o to i386/amd64 target build sergiodj+buildbot
2018-04-15 21:16 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-16 8:43 [binutils-gdb] Remove tandem support sergiodj+buildbot
2018-04-16 15:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-16 9:17 [binutils-gdb] Remove IEEE 695 object support sergiodj+buildbot
2018-04-16 17:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-16 9:50 [binutils-gdb] Remove h8300-coff support sergiodj+buildbot
2018-04-16 19:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-16 10:44 [binutils-gdb] Remove h8500 support sergiodj+buildbot
2018-04-16 21:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-16 14:17 [binutils-gdb] gdb: Remove support for SH-5/SH64 sergiodj+buildbot
2018-04-17 5:08 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-17 10:18 [binutils-gdb] Enable Intel CLDEMOTE instruction sergiodj+buildbot
2018-04-17 14:38 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-17 13:19 [binutils-gdb] Resync libiberty sources with master version in GCC repository sergiodj+buildbot
2018-04-17 16:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-17 14:06 [binutils-gdb] Add a check for a NULL table pointer before attempting to compute a DWARF filename sergiodj+buildbot
2018-04-17 18:57 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-17 17:52 [binutils-gdb] Don't print symbol declaration's line number in rbreak output sergiodj+buildbot
2018-04-17 23:15 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-17 22:07 [binutils-gdb] [MicroBlaze] PIC data text relative sergiodj+buildbot
2018-04-18 5:42 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-18 1:33 [binutils-gdb] x86: Use a normal input file with compatible relocation sergiodj+buildbot
2018-04-18 10:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-18 2:13 [binutils-gdb] elf32_bed/elf64_bed sergiodj+buildbot
2018-04-18 12:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-18 8:44 [binutils-gdb] Remove mips aout, coff, and pe support sergiodj+buildbot
2018-04-18 15:00 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-18 14:34 [binutils-gdb] Commonise tdesc types and makes use of them in gdbserver tdesc sergiodj+buildbot
2018-04-18 21:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-18 15:15 [binutils-gdb] Add tdesc osabi and architecture functions sergiodj+buildbot
2018-04-19 2:28 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-18 20:22 [binutils-gdb] Add feature reference in .dat files sergiodj+buildbot
2018-04-19 6:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-18 20:43 [binutils-gdb] Create xml from target descriptions sergiodj+buildbot
2018-04-19 8:14 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-18 21:46 [binutils-gdb] Remove xml files from gdbserver sergiodj+buildbot
2018-04-19 14:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-19 0:40 [binutils-gdb] Reinstate mips ecoff support sergiodj+buildbot
2018-04-19 17:07 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-19 22:02 [binutils-gdb] [OB PATCH] Fix some comments in thread.c sergiodj+buildbot
2018-04-19 23:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-20 21:47 [binutils-gdb] Improve on-line help for thread_apply_command and thread_apply_all_command sergiodj+buildbot
2018-04-20 23:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-21 18:17 [binutils-gdb] FreeBSD: Fix 'Couldn't get registers: Device busy' error (PR gdb/23077) sergiodj+buildbot
2018-04-22 9:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-23 12:15 [binutils-gdb] Prevent an illegal memory access in gprof by ensuring that string tables for aout format files are always zero-terminated sergiodj+buildbot
2018-04-23 13:27 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-23 14:42 [binutils-gdb] Revert bfd part of "Silence gcc-8 warnings" sergiodj+buildbot
2018-04-23 15:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-24 14:45 [binutils-gdb] Reindent cli-out.h sergiodj+buildbot
2018-04-24 17:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-24 16:07 [binutils-gdb] Fix an illegal memory access when copying a PE format file with corrupt debug information sergiodj+buildbot
2018-04-24 22:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-25 0:47 [binutils-gdb] Remove arm-aout and arm-coff support sergiodj+buildbot
2018-04-25 5:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-25 8:21 [binutils-gdb] Silence gcc-8 warnings sergiodj+buildbot
2018-04-25 10:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-25 12:59 [binutils-gdb] Fix the mask for the sqrdml(a|s)h instructions sergiodj+buildbot
2018-04-25 14:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-25 18:28 [binutils-gdb] Fix new inferior events output sergiodj+buildbot
2018-04-25 19:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-25 21:40 [binutils-gdb] [ARM] Add armelf_linux_fdpiceabi and armelfb_linux_fdpiceabi BFD backends sergiodj+buildbot
2018-04-25 22:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-25 22:20 [binutils-gdb] [ARM] Add FDPIC OSABI flag support sergiodj+buildbot
2018-04-26 1:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-25 23:36 [binutils-gdb] [ARM] Implement FDPIC relocations sergiodj+buildbot
2018-04-26 6:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 0:55 [binutils-gdb] [ARM] Add TLS relocations for FDPIC sergiodj+buildbot
2018-04-26 11:23 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 1:29 [binutils-gdb] [ARM] FDPIC: Add stack segment sergiodj+buildbot
2018-04-26 13:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 2:23 [binutils-gdb] [ARM] FDPIC: Make _GLOBAL_OFFSET_TABLE_ a relative symbol sergiodj+buildbot
2018-04-26 18:39 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 8:36 [binutils-gdb] x86: CpuXSAVE is a prereq for various other features sergiodj+buildbot
2018-04-27 6:07 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 9:03 [binutils-gdb] x86: fold various non-memory operand AVX512VL templates sergiodj+buildbot
2018-04-27 8:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 10:29 [binutils-gdb] x86: x87-related adjustments sergiodj+buildbot
2018-04-27 1:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 12:47 [binutils-gdb] Fix breakpoints in ifunc after inferior resolved it (@got.plt symbol creation) sergiodj+buildbot
2018-04-27 11:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 13:28 [binutils-gdb] Calling ifunc functions when target has no debug info but resolver has sergiodj+buildbot
2018-04-27 16:54 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 14:27 [binutils-gdb] Fix calling ifunc functions when resolver has debug info and different name sergiodj+buildbot
2018-04-27 13:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 14:33 [binutils-gdb] Calling ifunc functions when resolver has debug info, user symbol same name sergiodj+buildbot
2018-04-27 19:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 14:53 [binutils-gdb] Fix setting breakpoints on ifunc functions after they're already resolved sergiodj+buildbot
2018-04-27 23:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 15:18 [binutils-gdb] Breakpoints, don't skip prologue of ifunc resolvers with debug info sergiodj+buildbot
2018-04-28 1:42 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 16:07 [binutils-gdb] Factor out minsym_found/find_function_start_sal overload sergiodj+buildbot
2018-04-28 7:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 16:34 [binutils-gdb] For PPC64: elf_gnu_ifunc_record_cache: handle plt symbols in .text section sergiodj+buildbot
2018-04-28 9:44 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 17:15 [binutils-gdb] Fix stepping past GNU ifunc resolvers (introduce lookup_msym_prefer) sergiodj+buildbot
2018-04-28 12:25 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 18:05 [binutils-gdb] PPC64: always make synthetic .text symbols for GNU ifunc symbols sergiodj+buildbot
2018-04-28 18:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 18:42 [binutils-gdb] Extend GNU ifunc testcases sergiodj+buildbot
2018-04-28 21:21 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 19:45 [binutils-gdb] Fix resolving GNU ifunc bp locations when inferior runs resolver sergiodj+buildbot
2018-04-28 23:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 22:02 [binutils-gdb] Enable Intel MOVDIRI, MOVDIR64B instructions sergiodj+buildbot
2018-04-29 1:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 23:25 [binutils-gdb] Fix remote 'g' command error handling (PR remote/9665) sergiodj+buildbot
2018-04-29 4:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-27 9:52 [binutils-gdb] PR23123, PowerPC32 ifunc regression sergiodj+buildbot
2018-04-29 7:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-27 11:12 [binutils-gdb] Regenerate some files for recent ARM patches sergiodj+buildbot
2018-04-29 10:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-27 19:21 [binutils-gdb] Enable -Wsuggest-override sergiodj+buildbot
2018-04-29 15:33 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-27 20:09 [binutils-gdb] Add inclusive range support for Rust sergiodj+buildbot
2018-04-29 17:41 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-29 16:18 [binutils-gdb] Fix race when building ada-lex.c sergiodj+buildbot
2018-04-30 5:06 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-29 16:52 [binutils-gdb] proc-events.c: fix compilation on Solaris sergiodj+buildbot
2018-04-30 7:55 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-30 15:27 [binutils-gdb] Use bool in read_index_from_section sergiodj+buildbot
2018-04-30 17:32 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-30 17:32 [binutils-gdb] Add initial type alignment support sergiodj+buildbot
2018-04-30 21:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-30 18:19 [binutils-gdb] Handle alignof and _Alignof sergiodj+buildbot
2018-05-01 0:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-30 19:20 [binutils-gdb] Expose type alignment on gdb.Type sergiodj+buildbot
2018-05-01 3:06 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-30 20:28 [binutils-gdb] Remove rust_type_alignment sergiodj+buildbot
2018-05-01 7:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-30 20:51 [binutils-gdb] Remove long_long_align_bit gdbarch attribute sergiodj+buildbot
2018-05-01 11:08 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-30 21:37 [binutils-gdb] Remove new_bfd_ref sergiodj+buildbot
2018-05-01 15:48 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-30 21:46 [binutils-gdb] Introduce ref_ptr::new_reference sergiodj+buildbot
2018-05-01 13:22 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-04-30 23:38 [binutils-gdb] Remove some uses of is_mi_like_p from py-framefilter.c sergiodj+buildbot
2018-05-02 2:45 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-01 0:19 [binutils-gdb] Remove a use of is_mi_like_p from tracepoint.c sergiodj+buildbot
2018-05-02 7:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-01 1:23 [binutils-gdb] Remove a use of is_mi_like_p from darwin-nat-info.c sergiodj+buildbot
2018-05-02 11:32 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-01 15:30 [binutils-gdb] Add the Netronome Flow Processor as a build target to the top-level configure.ac file sergiodj+buildbot
2018-05-02 17:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-01 16:57 [binutils-gdb] Fix unintialized memory in aarch64 opcodes sergiodj+buildbot
2018-05-02 22:57 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-02 23:59 [binutils-gdb] Eliminate procfs.c:procfs_use_watchpoints sergiodj+buildbot
2018-05-03 4:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-03 2:19 [binutils-gdb] Convert struct target_ops to C++ sergiodj+buildbot
2018-05-03 14:05 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-03 17:01 [binutils-gdb] BFD: Prevent writing the MIPS _gp_disp symbol into symbol tables sergiodj+buildbot
2018-05-04 3:00 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-03 22:18 [binutils-gdb] Use flex's -t option instead of --stdout sergiodj+buildbot
2018-05-04 6:39 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-04 10:22 [binutils-gdb] -Wstringop-truncation warnings sergiodj+buildbot
2018-05-04 14:14 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-04 11:04 [binutils-gdb] gdb/testsuite: Fix broken regexp in gdbstub case sergiodj+buildbot
2018-05-04 15:24 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-04 19:36 [binutils-gdb] Return std::string from ada_exception_catchpoint_cond_string sergiodj+buildbot
2018-05-05 6:30 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-04 20:33 [binutils-gdb] Use previous count when 'x' command is repeated sergiodj+buildbot
2018-05-05 13:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-04 21:12 [binutils-gdb] (SPARC/LEON) fix incorrect array return value printed by "finish" sergiodj+buildbot
2018-05-05 18:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-04 22:30 [binutils-gdb] aarch64: PR 19806: watchpoints: false negatives + PR 20207 contiguous ones sergiodj+buildbot
2018-05-06 5:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-05 1:57 [binutils-gdb] Let gdb.execute handle multi-line commands sergiodj+buildbot
2018-05-09 16:35 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-05 7:23 [binutils-gdb] Add two fall-through comments in rs6000-tdep.c sergiodj+buildbot
2018-05-12 19:30 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-07 15:05 [binutils-gdb] Cleanup ppc code dealing with opcode dumps sergiodj+buildbot
2018-05-17 9:13 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-08 14:08 [binutils-gdb] Correct powerpc spe opcode lookup sergiodj+buildbot
2018-06-09 4:32 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-09 5:28 [binutils-gdb] PR23147, Heap buffer overflow in pe_print_idata sergiodj+buildbot
2018-06-12 17:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-10 10:11 [binutils-gdb] Fix tagged pointer support sergiodj+buildbot
2018-06-16 14:59 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-12 1:03 [binutils-gdb] gdb: xtensa: drop gdb_target definition sergiodj+buildbot
2018-06-23 10:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-15 13:56 [binutils-gdb] Fix error messages in the NFP sources when building for 32-bit targets sergiodj+buildbot
2018-06-28 0:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-15 15:48 [binutils-gdb] testsuite: Fix a `server_pid' access crash in gdb.server/server-kill.exp sergiodj+buildbot
2018-06-28 21:39 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-15 17:55 [binutils-gdb] MIPS: Make `mask_address_var' static sergiodj+buildbot
2018-06-29 15:12 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-17 15:50 [binutils-gdb] value.c: Remove unused variables sergiodj+buildbot
2018-07-07 6:19 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-18 0:01 [binutils-gdb] Don't elide all inlined frames sergiodj+buildbot
2018-07-09 2:51 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-18 22:33 [binutils-gdb] format_pieces-selftests.c: Silence ARI warnings sergiodj+buildbot
2018-07-16 2:40 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-19 3:50 [binutils-gdb] x86: Don't set eh->local_ref to 1 for versioned symbol sergiodj+buildbot
2018-07-26 1:08 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-20 0:37 [binutils-gdb] Remove useless variable int i in backtrace_command_1 sergiodj+buildbot
2018-07-26 21:52 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-21 18:22 [binutils-gdb] Remove cleanup from ada-lang.c sergiodj+buildbot
2018-07-29 23:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-22 1:57 [binutils-gdb] MIPS/Linux: Disable n32 USR `ptrace' accesses to 64-bit registers sergiodj+buildbot
2018-08-03 9:57 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-22 4:46 [binutils-gdb] ld: Hide symbols defined by HIDDEN/PROVIDE_HIDDEN sergiodj+buildbot
2018-08-04 9:47 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-22 17:26 [binutils-gdb] [PowerPC] Consolidate wordsize getter between native and gdbserver sergiodj+buildbot
2018-08-06 23:09 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-22 20:16 [binutils-gdb] Support UTF-8 identifiers in C/C++ expressions (PR gdb/22973) sergiodj+buildbot
2018-08-12 17:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-22 22:50 [binutils-gdb] remote: Make readahead_cache a C++ class sergiodj+buildbot
2018-08-14 0:34 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-22 22:55 [binutils-gdb] remote: multiple remote_arch_state instances per arch sergiodj+buildbot
2018-08-14 11:02 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-23 0:48 [binutils-gdb] Handle "show remote memory-write-packet-size" when not connected sergiodj+buildbot
2018-08-16 5:04 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-23 2:03 [binutils-gdb] gdb/x86: Fix `-Wstrict-overflow' build error in `i387_collect_xsave' sergiodj+buildbot
2018-08-17 22:51 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-23 16:40 [binutils-gdb] Remove elements from complaint_series sergiodj+buildbot
2018-08-21 11:56 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-23 17:01 [binutils-gdb] Remove "noisy" parameter from clear_complaints sergiodj+buildbot
2018-08-22 9:44 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-23 18:49 [binutils-gdb] Remove vcomplaint sergiodj+buildbot
2018-08-23 22:36 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-24 15:23 [binutils-gdb] testsuite: Extend TLS core file testing with an OS-generated dump sergiodj+buildbot
2018-08-31 19:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-24 18:01 [binutils-gdb] gdb: Restore selected frame in print_frame_local_vars sergiodj+buildbot
2018-09-02 0:55 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-24 20:09 [binutils-gdb] Update help strings in skip.c sergiodj+buildbot
2018-09-04 4:39 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-25 3:02 [binutils-gdb] gdb: Split func_command into two parts sergiodj+buildbot
2018-09-09 2:46 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-25 7:27 [binutils-gdb] s12z regen sergiodj+buildbot
2018-09-09 6:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-25 20:32 [binutils-gdb] Change the as_*_interp functions to use dynamic_cast sergiodj+buildbot
2018-09-13 11:32 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-25 20:59 [binutils-gdb] Remove interp_name sergiodj+buildbot
2018-09-13 14:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-26 21:47 [binutils-gdb] Remove cleanups from dbxread.c sergiodj+buildbot
2018-09-13 17:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-27 22:16 [binutils-gdb] Remove last reference to REMOTE_OBS sergiodj+buildbot
2018-09-14 17:14 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-28 16:20 [binutils-gdb] ld: Unify STT_GNU_IFUNC handling sergiodj+buildbot
2018-09-15 4:21 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-28 19:57 [binutils-gdb] x86-64: Add TLSDESC fields to elf_x86_lazy_plt_layout sergiodj+buildbot
2018-09-15 22:31 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-30 1:23 [binutils-gdb] Remove "struct" keyword in range-based for loops sergiodj+buildbot
2018-09-18 21:37 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).