public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Tighten remote check in gdb.base/argv0-symlink.exp
@ 2017-10-12 18:52 sergiodj+buildbot
  2017-10-12 18:52 ` Failures on Fedora-s390x-m64, branch master sergiodj+buildbot
                   ` (12 more replies)
  0 siblings, 13 replies; 2920+ messages in thread
From: sergiodj+buildbot @ 2017-10-12 18:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 30440677f3d0cdd2085bea40496774ffa24f6bb1 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 30440677f3d0cdd2085bea40496774ffa24f6bb1

Tighten remote check in gdb.base/argv0-symlink.exp

Check for gdbserver instead of dejagnu remote.  Unlike what the
comment says, the test actually fails with target remote + gdbserver
(it does pass with extended-remote).  The result is:

 FAIL -> KFAIL with --target_board=native-gdbserver
 KPASS -> PASS with --target_board=native-extended-gdbserver

gdb/testsuite/ChangeLog:
2017-10-12  Pedro Alves  <palves@redhat.com>
	    Simon Marchi  <simon.marchi@polymtl.ca>

	* gdb.base/argv0-symlink.exp: kfail on remote gdbserver,
	instead of on dejagnu remote boards.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb: Add news entries for new or1k target.
@ 2017-12-16 22:41 sergiodj+buildbot
  2017-12-16 22:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2017-12-16 22:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b282f0f2b56903c7b58f1eb94b88e468851928e8 ***

Author: Stafford Horne <shorne@gmail.com>
Branch: master
Commit: b282f0f2b56903c7b58f1eb94b88e468851928e8

gdb: Add news entries for new or1k target.

gdb/ChangeLog:

yyyy-mm-dd  Stafford Horne  <shorne@gmail.com>

	* NEWS (Changes since GDB 8.0): Mention new or1k target and new
	commands to set/show or1k debug.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb: Fix function parameter alignments in or1k-tdep.c.
@ 2017-12-16 23:29 sergiodj+buildbot
  2017-12-17  0:06 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2017-12-16 23:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 38af1824019684e819ffb880bdf7fb03a2c2000a ***

Author: Stafford Horne <shorne@gmail.com>
Branch: master
Commit: 38af1824019684e819ffb880bdf7fb03a2c2000a

gdb: Fix function parameter alignments in or1k-tdep.c.

As suggested by Joel Brobecker <brobecker@adacore.com> and as per fsf
coding standards.  Also fix a few more issues with directly printing
pointers.

gdb/ChangeLog:

	* gdb/or1k-tdep.c (show_or1k_debug): Fix function parameter alignment.
	(or1k_analyse_inst): Likewise.
	(or1k_single_step_through_delay): Likewise.
	(or1k_frame_cache): Fix parameter alignment and use paddress()
	instead of %x.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Ada: fix bad handling in ada_convert_actual
@ 2017-12-18  3:22 sergiodj+buildbot
  2017-12-18  3:36 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2017-12-18  3:22 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cb923fcc23e07fe3dfb3837f47249aba79cdee6f ***

Author: Xavier Roirand <roirand@adacore.com>
Branch: master
Commit: cb923fcc23e07fe3dfb3837f47249aba79cdee6f

Ada: fix bad handling in ada_convert_actual

Using this small example:

procedure Foo is

   type Integer_Access is access all Integer;

   procedure P (A : Integer_Access) is
   begin
      null;
   end P;

begin
   P (null);
end Foo;

and doing this debug session:

(gdb) b p
Breakpoint 1 at 0x402d67: file foo.adb, line 7.
(gdb) print p(null)

Breakpoint 1, foo.p (a=0x641010) at foo.adb:10
...                  ^^^^^^^^^^

shows that something goes wrong between the initial null value and the
received parameter value in the 'f' function.
The value for the parameter 'a' we get is the address of the value we
would expect instead of the value itself. This can be checked by doing:

(gdb) p *a
$1 = 0

Before this fix, in ada_convert_value, this function was looking to the
actual value (the null value here) to determine if the formal (parameter
'a' in the procedure 'P' in this exemple) requires a pointer or not which
is a wrong assumption and leads to push the address of the value to the
inferior instead of the value itself.

This is fixed by this patch.

gdb/ChangeLog:

        * ada-lang.c (ada_convert_actual): Change the way actual value
        are passed to the inferior when the inferior expects a pointer type.

gdb/testsuite/ChangeLog:

        * gdb.ada/funcall_ptr: New testcase.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] (Ada) crash assigning to record component which is an array
@ 2017-12-18  4:13 sergiodj+buildbot
  2017-12-18  5:14 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2017-12-18  4:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0e2da9f01334a01d1a6e224ecd592d6fbbb22515 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 0e2da9f01334a01d1a6e224ecd592d6fbbb22515

(Ada) crash assigning to record component which is an array

Consider the following code, which declares a variabled called "input"
of type "parameter", which is a record with one component called "u2",
where the type of that component is a simple 3-element array of
floating point values:

   type Float_Array_3 is array (1 .. 3) of Float;
   type parameters is record
      u2 : Float_Array_3;
   end record;
   input : parameters;

Trying to assign a value to input.u2 causes GDB to crash:

    (gdb) p input.u2 := (0.25,0.5,0.75)
    [1]    20228 segmentation fault (core dumped) [...]/gdb

The crash occurs because input.u2 is described in the debugging
info as a typedef of an array. Indeed, input's type is:

 <1><ae9>: Abbrev Number: 7 (DW_TAG_structure_type)
    <aea>   DW_AT_name        : (indirect string, offset: 0x1045): target_wrapper__parameters
    [...]
 <2><af5>: Abbrev Number: 8 (DW_TAG_member)
    <af6>   DW_AT_name        : u2
    [...]
    <afb>   DW_AT_type        : <0xaca>

and, looking at DIE 0xaca to get input.u2's type, we see:

 <1><aca>: Abbrev Number: 4 (DW_TAG_typedef)
    <acb>   DW_AT_name        : (indirect string, offset: 0x1060): target_wrapper__float_array_3
    [...]
    <ad1>   DW_AT_type        : <0xad5>

We can also confirm, following the DW_AT_type attribute (0xad5), that
it's a typedef of our array:

 <1><ad5>: Abbrev Number: 5 (DW_TAG_array_type)
    <ad6>   DW_AT_name        : (indirect string, offset: 0x1060): target_wrapper__float_array_3
    [...]

In fact, this scenario uncovered 2 areas where typedef handling
is missing, thus causing a crash. The first happens inside
assign_aggregate:

   if (ada_is_direct_array_type (lhs_type))
     {
       lhs = ada_coerce_to_simple_array (lhs);
       lhs_type = value_type (lhs);
       low_index = TYPE_ARRAY_LOWER_BOUND_VALUE (lhs_type);
       high_index = TYPE_ARRAY_UPPER_BOUND_VALUE (lhs_type);
     }

Here, lhs_type is a TYPE_CODE_TYPEDEF. ada_is_direct_array_type
knows how to handle it, but TYPE_ARRAY_LOWER_BOUND_VALUE assumes
that the given type is a TYPE_CODE_ARRAY. As such, it ends up
accessing some fields in lhs_type which it shouldn't, and kaboom.

We fixed this issue by making sure that the TYPE_CODE_TYPEDEF
layer gets stripped.

Once this is done, we hit a different kind of error, also leading to
a SEGV, this time in assign_component. The code looks like this:

  if (TYPE_CODE (value_type (lhs)) == TYPE_CODE_ARRAY)
    [...]
  else
    [...]

Because once again lhs is a TYPE_CODE_TYPEDEF, the check fail,
and we end up assuming that lhs is a struct, executing the "else"
block, which is:

  else
    {
      elt = ada_index_struct_field (index, lhs, 0, value_type (lhs));
      elt = ada_to_fixed_value (elt);
    }

Since lhs is not a struct, ada_index_struct_field returns NULL,
which ada_to_fixed_value does not handle well, hence another crash.

This patch fixes this other issue the same way, by stripping
TYPE_CODE_TYPEDEF layers.

gdb/ChangeLog:

        * ada-lang.c (assign_component): Strip any TYPE_CODE_TYPEDEF
        layer from lhs' type.
        (assign_aggregate): Likewise.

gdb/testsuite:

        * gdb.ada/assign_arr: New testcase.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] improved error message when getting an exception printing a variable
@ 2017-12-18  4:51 sergiodj+buildbot
  2017-12-18  7:06 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2017-12-18  4:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT eccab96d54a9455557d3c4d5bff431f6e526d0b7 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: eccab96d54a9455557d3c4d5bff431f6e526d0b7

improved error message when getting an exception printing a variable

Consider the following Ada code defining a global variable whose
type is an array of static bounds (1 .. 2), but where its elements
are a variant record whose size is not statically known:

    type Ints is array (Natural range <>) of Integer;
    type Bounded_Ints (Max_Size : Natural) is record
       Length : Natural := 0;
       Objs   : Ints (1 .. Max_Size);
    end record;

    type Ints_Doubled is array (1 .. 2) of Bounded_Ints (Idem (0));

    Global : Ints_Doubled;

When compiling this program at -O2 using a GCC-6.4-based compiler
on x86_64-linux, trying to print the value of that global variable
yields:

    (gdb) p global
    $1 =

Let's look at the debugging info, which starts with the global
variable itself...

        .uleb128 0x19   # (DIE (0x25e) DW_TAG_variable)
        .long   .LASF32 # DW_AT_name: "fd__global"
        .long   0x273   # DW_AT_type

... its type is a reference to a typedef ...

        .uleb128 0x14   # (DIE (0x273) DW_TAG_reference_type)
        .byte   0x8     # DW_AT_byte_size
        .long   0x202   # DW_AT_type
        [...]
        .uleb128 0x15   # (DIE (0x202) DW_TAG_typedef)
        .long   .LASF19 # DW_AT_name: "fd__ints_doubled"
        .long   0x20d   # DW_AT_type

... of an array (1..2) ...

        .uleb128 0x2    # (DIE (0x20d) DW_TAG_array_type)
        .long   .LASF19 # DW_AT_name: "fd__ints_doubled"
        .long   0x15b   # DW_AT_type
        .long   0x221   # DW_AT_sibling
        .uleb128 0x16   # (DIE (0x21a) DW_TAG_subrange_type)
        .long   0x40    # DW_AT_type
        .sleb128 2      # DW_AT_upper_bound
        .byte   0       # end of children of DIE 0x20d

... of a struct whose name is fd__Tints_doubledC:

        .uleb128 0x10   # (DIE (0x15b) DW_TAG_structure_type)
        .long   .LASF11 # DW_AT_name: "fd__Tints_doubledC"
        .long   0x1e4   # DW_AT_GNAT_descriptive_type
                        # DW_AT_artificial
        .long   0x1e4   # DW_AT_sibling
        .uleb128 0x7    # (DIE (0x16a) DW_TAG_member)
        .long   .LASF4  # DW_AT_name: "max_size"
        [snip]

The error occurs while Ada evaluator is trying to "fix"
the element type inside the array, so as to determine its actual
size. For that, it searches for a parallel "XVZ" variable,
which, when found, contains the object's actual size.

Unfortunately in our case, the variable exists but has been
optimized out, as seen by the presence of a variable DIE in
the debugging info, but with no address attribute:

        .uleb128 0x18   # (DIE (0x24e) DW_TAG_variable)
        .long   .LASF31 # DW_AT_name: "fd__Tints_doubledC___XVZ"
        .long   0x257   # DW_AT_type
                        # DW_AT_artificial

Discussing this with some members of AdaCore's compiler team,
it is expected that the optimizer can get rid of this variable,
and we don't want to pessimize the code just to improve debuggability,
since -O2 is about performance. So, the idea of this patch is
not to make it work, but provide a bit more information to help
users understand what kind of error is preventing GDB from being
able to print the variable's value.

The first hurdle we had to clear was the fact that ada_val_print
traps all exceptions (including QUIT ones!), and does so completly
silently. So, the fix was to add a trace of the exception being
generated. While doing so, we fix an old XXX/FIXME by only catching
errors, letting QUIT exceptions go through.

Once this is done, we now get an error message, which gives a first
clue as to what was happening:

    (gdb) p fd.global
    $1 = <error reading variable: value has been optimized out>

However, it would be more useful to know which value it was
that was optimized out. For that purpose, we enhanced
ada-lang.c::ada_to_fixed_type_1 so as to re-throw the error
with a message which indicates which variable we failed to read.

With those changes, the new output is now:

    (gdb) p fd.global
    $1 = <error reading variable: unable to read value of fd__Tints_doubledC___XVZ (value has been optimized out)>

gdb/ChangeLog:

        * ada-lang.c (ada_to_fixed_type_1): Rethrow errors with
        a more detailed exception message when getting an exception
        while trying to read the value of an XVZ variable.
        * ada-valprint.c (ada_val_print): Only catch RETURN_MASK_ERROR
        exceptions.  Print an error message when an exception is caught.

gdb/testsuite/ChangeLog:

        * gdb.dwarf2/ada-valprint-error.c: New file.
        * gdb.dwarf2/ada-valprint-error.exp: New file.

Tested on x86_64-linux


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: replace Reg8, Reg16, Reg32, and Reg64
@ 2017-12-18  8:56 sergiodj+buildbot
  2017-12-18  9:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2017-12-18  8:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT dc821c5f9ae5208ad1ec438718f75e224f856deb ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: dc821c5f9ae5208ad1ec438718f75e224f856deb

x86: replace Reg8, Reg16, Reg32, and Reg64

Use a combination of a single new Reg bit and Byte, Word, Dword, or
Qword instead.

Besides shrinking the number of operand type bits this has the benefit
of making register handling more similar to accumulator handling (a
generic flag is being accompanied by a "size qualifier"). It requires,
however, to split a few insn templates, as it is no longer correct to
have combinations like Reg32|Reg64|Byte. This slight growth in size will
hopefully be outweighed by this change paving the road for folding a
presumably much larger number of templates later on.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: drop FloatReg and FloatAcc
@ 2017-12-18  9:35 sergiodj+buildbot
  2017-12-18 11:15 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2017-12-18  9:35 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ca0d63fe0703ed36af1a7bda6097958805895b3a ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: ca0d63fe0703ed36af1a7bda6097958805895b3a

x86: drop FloatReg and FloatAcc

Express them as Reg|Tbyte and Acc|Tbyte respectively.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: fold RegXMM/RegYMM/RegZMM into RegSIMD
@ 2017-12-18 10:42 sergiodj+buildbot
  2017-12-18 12:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2017-12-18 10:42 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1b54b8d7e4fc8055f9220a5287e8a94d8a65a88d ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 1b54b8d7e4fc8055f9220a5287e8a94d8a65a88d

x86: fold RegXMM/RegYMM/RegZMM into RegSIMD

... qualified by their respective sizes, allowing to drop FirstXmm0 at
the same time.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: fold certain AVX and AVX2 templates
@ 2017-12-18 11:26 sergiodj+buildbot
  2017-12-18 13:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2017-12-18 11:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 10c17abdd052c5f8f9c2bcdf8b01dffe5d06baf0 ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 10c17abdd052c5f8f9c2bcdf8b01dffe5d06baf0

x86: fold certain AVX and AVX2 templates

Just like for instructions in GPRs, there's no need to have separate
templates for otherwise identical insns acting on XMM or YMM registers
(or memory of the same size).


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PR22626, invalid dynindx used for dynamic relocs against section syms
@ 2017-12-18 22:34 sergiodj+buildbot
  2017-12-18 22:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2017-12-18 22:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 63f452a8bfd9c89b56dcc087cea84151e7a9ec24 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 63f452a8bfd9c89b56dcc087cea84151e7a9ec24

PR22626, invalid dynindx used for dynamic relocs against section syms

_bfd_elf_link_renumber_dynsyms is called twice by the linker.  The
first call in bfd_elf_size_dynamic_sections is just to answer the
question as to whether there are there any dynamic symbols.  The
second call in bfd_elf_size_dynsym_hash_dynstr sets the st_shndx value
that dynamic symbols will have.  strip_excluded_output_sections is
called between these two calls.  So sections seen on the first
_bfd_elf_link_renumber_dynsyms pass might differ from those seen on
the second pass.  Unfortunately, that can result in a stripped
section's dynamic symbol being assigned a dynindx on the first pass
but not corrected to the final value (of zero, ie. not dynamic) on the
second pass.  PowerPC, x86, mips, and most other targets that emit
dynamic section symbols, just test that section symbol dynindx is
non-zero before using a given section symbol in dynamic relocations.

This patch prevents _bfd_elf_link_renumber_dynsyms from setting any
section symbol dynindx on the first pass.

	PR 22626
	* elflink.c (_bfd_elf_link_renumber_dynsyms): Don't set section
	dynindx when section_sym_count is NULL.
	(bfd_elf_size_dynamic_sections): Pass NULL section_sym_count to
	preliminary _bfd_elf_link_renumber_dynsyms call.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add support for V_4B so we can properly reject it.
@ 2017-12-19 12:47 sergiodj+buildbot
  2017-12-19 12:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2017-12-19 12:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a3b3345ae62503982698171bcfce0afe23bd8a31 ***

Author: Tamar Christina <tamar.christina@arm.com>
Branch: master
Commit: a3b3345ae62503982698171bcfce0afe23bd8a31

Add support for V_4B so we can properly reject it.

Previously parse_vector_type_for_operand was changed to allow the use of 4b
register size for indexed lane instructions. However this had the unintended
side effect of also allowing 4b for normal vector registers.

Because this support was only partial the rest of the tool silently treated
4b as 8b and continued. This patch adds full support for 4b so it can be
properly distinguished from 8b and the correct errors are generated.

With this patch you still can't encode any instruction which actually requires
v<num>.4b but such instructions don't exist so to prevent needing a workaround
in get_vreg_qualifier_from_value this was just omitted.

gas/

	PR gas/22529
	* config/tc-aarch64.c (vectype_to_qualifier): Support AARCH64_OPND_QLF_V_4B.
	* gas/testsuite/gas/aarch64/pr22529.s: New.
	* gas/testsuite/gas/aarch64/pr22529.d: New.
	* gas/testsuite/gas/aarch64/pr22529.l: New.

include/

	PR gas/22529
	* opcode/aarch64.h (aarch64_opnd_qualifier): Add AARCH64_OPND_QLF_V_4B.

opcodes/

	PR gas/22529
	* aarch64-opc.c (aarch64_opnd_qualifiers): Add 4b variant.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Correct disassembly of dot product instructions.
@ 2017-12-19 13:25 sergiodj+buildbot
  2017-12-19 14:11 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2017-12-19 13:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 00c2093f698e8f40c04340cb1832d09e11ece237 ***

Author: Tamar Christina <tamar.christina@arm.com>
Branch: master
Commit: 00c2093f698e8f40c04340cb1832d09e11ece237

Correct disassembly of dot product instructions.

Dot products deviate from the normal disassembly rules for lane indexed
instruction. Their canonical representation is in the form of:

v0.2s, v0.8b, v0.4b[0] instead of v0.2s, v0.8b, v0.b[0] to try to denote
that these instructions select 4x 1 byte elements instead of a single 1 byte
element.

Previously we were disassembling them following the normal rules, this patch
corrects the disassembly.

gas/

	PR gas/22559
	* config/tc-aarch64.c (vectype_to_qualifier): Support AARCH64_OPND_QLF_S_4B.
	* gas/testsuite/gas/aarch64/dotproduct.d: Update disassembly.

include/

	PR gas/22559
	* aarch64.h (aarch64_opnd_qualifier): Add AARCH64_OPND_QLF_S_4B.

opcodes/

	PR gas/22559
	* aarch64-asm.c (aarch64_ins_reglane): Change AARCH64_OPND_QLF_S_B to
	AARCH64_OPND_QLF_S_4B
	* aarch64-dis.c (aarch64_ext_reglane): Change AARCH64_OPND_QLF_S_B to
	AARCH64_OPND_QLF_S_4B
	* aarch64-opc.c (aarch64_opnd_qualifiers): Add 4b variant.
	* aarch64-tbl.h (QL_V2DOT): Change S_B to S_4B.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [Cell/B.E.] Fix regression due to gdbarch_significant_addr_bit
@ 2017-12-20 13:37 sergiodj+buildbot
  2017-12-20 13:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2017-12-20 13:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 396d3980f518cfc9a936e3fb8138b0492399525a ***

Author: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Branch: master
Commit: 396d3980f518cfc9a936e3fb8138b0492399525a

[Cell/B.E.] Fix regression due to gdbarch_significant_addr_bit

On Cell/B.E. multi-architecture debugging we use a "merged" address space
that encodes both the main PowerPC address space and the local store address
spaces of all active SPUs.  This will always occupy 64 bits.

However, gdbarch_addr_bit is set to 32 on SPU, and may be set to 32 as well
on PowerPC.  Since the new gdbarch_significant_addr_bit defaults to the
value of gdbarch_addr_bit, this means addresses may be improperly truncated.

Work around this problem by explicitly setting gdbarch_significant_addr_bit
to 64 both for the SPU target and also for PowerPC target that support
Cell/B.E. execution.

gdb/ChangeLog:
2017-12-20  Ulrich Weigand  <uweigand@de.ibm.com>

	* spu-tdep.c (spu_gdbarch_init): Set set_gdbarch_significant_addr_bit
	to 64 bits.
	(ppc_linux_init_abi): Likewise, if Cell/B.E. is supported.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] RISC-V: Add compressed instruction hints, and a few misc cleanups.
@ 2017-12-20 21:59 sergiodj+buildbot
  2017-12-20 22:13 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2017-12-20 21:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 21a186f28061ea51e422ae47d062793ceac2180f ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 21a186f28061ea51e422ae47d062793ceac2180f

RISC-V: Add compressed instruction hints, and a few misc cleanups.

	gas/
	* config/tc-riscv.c (risc_ip) <o>: Add comment.
	* testsuite/gas/riscv/c-nonzero-imm.d,
	* testsuite/gas/riscv/c-nonzero-imm.l,
	* testsuite/gas/riscv/c-nonzero-imm.s,
	* testsuite/gas/riscv/c-nonzero-reg.d,
	* testsuite/gas/riscv/c-nonzero-reg.l,
	* testsuite/gas/riscv/c-nonzero-reg.s,
	* testsuite/gas/riscv/c-zero-imm-64.d,
	* testsuite/gas/riscv/c-zero-imm-64.s,
	* testsuite/gas/riscv/c-zero-imm.d, testsuite/gas/riscv/c-zero-imm.s,
	* testsuite/gas/riscv/c-zero-reg.d,
	* testsuite/gas/riscv/c-zero-reg.s: New.

	opcodes/
	* riscv-opc.c (match_c_add_with_hint, match_c_lui_with_hint): New.
	(riscv_opcodes) <li>: Delete "d,0" line.  Change Cj to Co.
	<andi, and, add, addiw, addw, c.addi>: Change Cj to Co.
	<add>: Add explanatory comment for 4-operand add instruction.
	<c.nop>: Add support for immediate operand.
	<c.mv, c.add>: Use match_c_add_with_hint instead of match_c_add.
	<c.lui>: Use match_c_lui_with_hint instead of match_c_lui.
	<c.li, c.slli>: Use match_opcode instead of match_rd_nonzero.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove write-only assignment in rs6000-tdep.c
@ 2017-12-21  2:01 sergiodj+buildbot
  2017-12-21  2:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2017-12-21  2:01 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 27e9ff87a627614fda7ddd89ddef745de5e988bb ***

Author: Uros Bizjak <ubizjak@gmail.com>
Branch: master
Commit: 27e9ff87a627614fda7ddd89ddef745de5e988bb

Remove write-only assignment in rs6000-tdep.c

The result of this memory read is never used, so it can be removed.

gdb/ChangeLog:

	* rs6000-tdep.c (ppc_deal_with_atomic_sequence): Remove
	write-only assignment to "insn" variable.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Do not emit "field_type" var if not needed on "maint print c-tdesc"
@ 2017-12-21 23:57 sergiodj+buildbot
  2017-12-21 23:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2017-12-21 23:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a8d2e5856f87a658d69018fe1ccd56482eebdd59 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: a8d2e5856f87a658d69018fe1ccd56482eebdd59

Do not emit "field_type" var if not needed on "maint print c-tdesc"

While fiddling a bit with -Wunused-variable, Sergio noticed that "maint
print c-tdesc" was always generating code for the "tdesc_type
*field_type" variable, even when it wasn't used.  This is caught by GCC
when using -Wunused-variable, of course.

This patch changes the print_c_tdesc class to only output the field
declaration when we actually need it.

It shouldn't be necessary to do the same with the other variable
declarations (type_with_fields and element_type), because they are
always if they are declared.

The C files in features/ are regenerated, some declarations of
field_type are removed, as expected, while some others move to where
they are used for the first time.

gdb/ChangeLog:

	* target-descriptions.c (print_c_tdesc) <visit>: Don't output
	field_type declaration, use printf_field_type_assignment
	instead.
	<printf_field_type_assignment>: New method.
	* features/aarch64-core.c, features/aarch64-fpu.c
	features/arc-arcompact.c, features/arc-v2.c,
	features/arm/arm-with-iwmmxt.c, features/i386/32bit-core.c,
	features/i386/32bit-mpx.c, features/i386/32bit-sse.c,
	features/i386/64bit-avx512.c, features/i386/64bit-core.c,
	features/i386/64bit-mpx.c, features/i386/64bit-sse.c,
	features/i386/x32-core.c, features/or1k.c,
	features/rs6000/powerpc-7400.c,
	features/rs6000/powerpc-altivec32.c,
	features/rs6000/powerpc-altivec32l.c,
	features/rs6000/powerpc-altivec64.c,
	features/rs6000/powerpc-altivec64l.c,
	features/rs6000/powerpc-cell32l.c,
	features/rs6000/powerpc-cell64l.c,
	features/rs6000/powerpc-isa205-altivec32l.c,
	features/rs6000/powerpc-isa205-altivec64l.c,
	features/rs6000/powerpc-isa205-vsx32l.c,
	features/rs6000/powerpc-isa205-vsx64l.c,
	features/rs6000/powerpc-vsx32.c,
	features/rs6000/powerpc-vsx32l.c,
	features/rs6000/powerpc-vsx64.c,
	features/rs6000/powerpc-vsx64l.c, features/s390-gs-linux64.c,
	features/s390-tevx-linux64.c, features/s390-vx-linux64.c,
	features/s390x-gs-linux64.c, features/s390x-tevx-linux64.c,
	features/s390x-vx-linux64.c: Re-generate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add ATTRIBUTE_PRINTF to printf_field_type_assignment
@ 2017-12-23 21:51 sergiodj+buildbot
  2017-12-23 22:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2017-12-23 21:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6e8c24fe27098f407000812e61fa8210095a7970 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 6e8c24fe27098f407000812e61fa8210095a7970

Add ATTRIBUTE_PRINTF to printf_field_type_assignment

Get rid of:

/home/simark/src/binutils-gdb/gdb/target-descriptions.c:2026:25: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
    vprintf_unfiltered (fmt, args);

when building with clang.

gdb/ChangeLog:

	* target-descriptions.c (print_c_tdesc)
	<printf_field_type_assignment>: Add ATTRIBUTE_PRINTF.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] reggroups: Add test and docs for `info reg $reggroup` feature
@ 2017-12-27 15:03 sergiodj+buildbot
  2017-12-27 15:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2017-12-27 15:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b67d92b06e6155a392a0c2d413f87d050880dbf4 ***

Author: Stafford Horne <shorne@gmail.com>
Branch: master
Commit: b67d92b06e6155a392a0c2d413f87d050880dbf4

reggroups: Add test and docs for `info reg $reggroup` feature

Until now this feature has existed but was not documented.  Adding docs
and tests.

gdb/ChangeLog:

yyyy-mm-dd  Stafford Horne  <shorne@gmail.com>

	* infcmd.c (_initialize_infcmd): Add help for info reg $reggroup
	and info all-registers $reggroup feature.

gdb/doc/ChangeLog:

yyyy-mm-dd  Stafford Horne  <shorne@gmail.com>

	* gdb.texinfo (Registers): Document info reg $reggroup feature.

gdb/testsuite/ChangeLog:

yyyy-mm-dd  Stafford Horne  <shorne@gmail.com>

	* gdb.base/reggroups.c: New file.
	* gdb.base/reggroups.exp: New file.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] reggroups: Convert reggroups from post_init to pre_init
@ 2017-12-27 15:46 sergiodj+buildbot
  2017-12-27 17:30 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2017-12-27 15:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c1166ca9f3543b28e8b0057ecaf2cd3251cd51c5 ***

Author: Stafford Horne <shorne@gmail.com>
Branch: master
Commit: c1166ca9f3543b28e8b0057ecaf2cd3251cd51c5

reggroups: Convert reggroups from post_init to pre_init

Currently the reggroups gdbarch_data cannot be manipulated until after
the gdbarch is completely initialized.  This is usually done when the
object init depends on architecture specific fields.  In the case of
reggroups it only depends on the obstack being available.

Coverting this to pre_init allows using reggroups during gdbarch
initialization.  This is needed to allow registering arbitrary reggroups
during gdbarch initializations.

gdb/ChangeLog:

yyyy-mm-dd  Stafford Horne  <shorne@gmail.com>

	* reggroups.c (reggroups_init): Change to depend only on
	obstack rather than gdbarch.
	(reggroup_add): Remove logic for forcing premature init.
	(_initialize_reggroup): Set `reggroups_data` with
	gdbarch_data_register_pre_init() rather than
	gdbarch_data_register_post_init().


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] reggroups: Add reggroup_gdbarch_new, reggroup_find for dynamic reggroups
@ 2017-12-27 16:45 sergiodj+buildbot
  2017-12-27 20:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2017-12-27 16:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f7efd549485db1fd84dbd2f2ee36d80c2739f224 ***

Author: Stafford Horne <shorne@gmail.com>
Branch: master
Commit: f7efd549485db1fd84dbd2f2ee36d80c2739f224

reggroups: Add reggroup_gdbarch_new, reggroup_find for dynamic reggroups

Traditionally reggroups have been created via reggroup_new() during
initialization code and never freed.  Now, if we want to initialize
reggroups dynamically (i.e. in target description) we should be able to
free them.  Create this function reggroup_gdbarch_new() which will
allocate the reggroup memory onto the passed gdbarch obstack.

Also creating reggroup_find() as a utility to find a gdbarch registered
reggroup object by name.

gdb/ChangeLog:

yyyy-mm-dd  Stafford Horne  <shorne@gmail.com>

	* reggroups.c (reggroup_gdbarch_new): New function.
	(reggroup_find): New function.
	* reggroups.h (reggroup_gdbarch_new): New function.
	(reggroup_find): New function.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p
@ 2017-12-27 17:51 sergiodj+buildbot
  2017-12-27 23:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2017-12-27 17:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cef0f8684e818f8b6c71c44dc9cc28a6d0ac3754 ***

Author: Stafford Horne <shorne@gmail.com>
Branch: master
Commit: cef0f8684e818f8b6c71c44dc9cc28a6d0ac3754

tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p

tdesc_register_in_reggroup_p in now able to handle arbitrary
groups. This is useful when groups are created while the
target descriptor file is received from the remote.

This can be the case of a soft core target processor where
registers/groups can change.

gdb/ChangeLog:

yyyy-mm-dd  Franck Jullien  <franck.jullien@gmail.com>
	    Stafford Horne  <shorne@gmail.com>

	* target-descriptions.c (tdesc_register_in_reggroup_p): Support
	arbitrary strings.
	(tdesc_use_registers): Add logic to register new reggroups.
	(tdesc_reg::group): Update comment to indicate we allow
	arbitrary strings.
	* NEWS (Changes since GDB 8.0): Announce that GDB supports
	arbitrary reggroups.

gdb/testsuite/ChangeLog:

yyyy-mm-dd  Stafford Horne  <shorne@gmail.com>

	* gdb.xml/extra-regs.xml: Add example foo reggroup.
	* gdb.xml/tdesc-regs.exp: Add test to check for foo reggroup.

gdb/doc/ChangeLog:

yyyy-mm-dd  Stafford Horne  <shorne@gmail.com>

	* gdb.texinfo (Target Description Format): Explain that arbitrary
	strings are now allowed for register groups.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove unused HP-UX TARGET_OBJECT_ enums
@ 2017-12-28 17:51 sergiodj+buildbot
  2017-12-28 18:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2017-12-28 17:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4ee2b642ddc70393d5b3ab04956fadad02954d4a ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 4ee2b642ddc70393d5b3ab04956fadad02954d4a

Remove unused HP-UX TARGET_OBJECT_ enums

These two enumerators are unused, remove them.

gdb/ChangeLog:

	* target.h (enum target_object) <TARGET_OBJECT_HPUX_UREGS,
	TARGET_OBJECT_HPUX_SOLIB_GOT>: Remove.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] RISC-V: Add missing privileged spec registers.
@ 2017-12-28 21:41 sergiodj+buildbot
  2017-12-28 21:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2017-12-28 21:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d9be0c189a9a9b77a6bf4501f8891544b8ce9593 ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: d9be0c189a9a9b77a6bf4501f8891544b8ce9593

RISC-V: Add missing privileged spec registers.

	gas/
	* testsuite/gas/riscv/priv-reg.d, testsuite/gas/riscv/priv-reg.s: New.

	include/
	* opcode/riscv-opc.h (DECLARE_CSR): Add missing privileged registers.
	Sort to match privileged spec documentation order.
	(DECLARE_CSR_ALIAS): Add ubadaddr, and comments.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove unnecessary call to get_thread_db_info
@ 2017-12-30  3:17 sergiodj+buildbot
  2017-12-30  3:44 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2017-12-30  3:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 502a625ab01da27e851333b598c893d6f2c20bd0 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 502a625ab01da27e851333b598c893d6f2c20bd0

Remove unnecessary call to get_thread_db_info

In thread_db_detach, we call get_thread_db_info to first check if there
exists a thread_db_info entry for the pid to detach.  If there is, then
we call delete_thread_db_info.  It's unnecessary to call
get_thread_db_info in the first place, since delete_thread_db_info
handles the case where no thread_db_info entry exist for the given pid.

gdb/ChangeLog:

	* linux-thread-db.c (thread_db_detach): Remove call to
	delete_thread_db_info.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Ignore warning about using different types of enums in switch
@ 2017-12-30  4:57 sergiodj+buildbot
  2017-12-30  5:39 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2017-12-30  4:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0436426c7f7798b8eb4b48be9867495da8ef28f0 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 0436426c7f7798b8eb4b48be9867495da8ef28f0

Ignore warning about using different types of enums in switch

When compiling with clang 6, I see a bunch of warnings like this:

/home/emaisin/src/binutils-gdb/gdb/amd64-linux-tdep.c:1427:8: error: comparison of two values with different enumeration types in switch statement ('enum amd64_syscall' and 'amd
64_x32_syscall') [-Werror,-Wenum-compare-switch]
  case amd64_x32_sys_move_pages:
       ^~~~~~~~~~~~~~~~~~~~~~~~

In this switch, we indeed use enumerators of both types
amd64_x32_syscall and amd64_syscall.  This is done on purpose, and the
enum values are chosen so that they are complementary.

I think it's still a useful warning, so I chose to ignore just that
particular case.

gdb/ChangeLog:

	* common/diagnostics.h
	(DIAGNOSTIC_IGNORE_SWITCH_DIFFERENT_ENUM_TYPES): New macro.
	* amd64-linux-tdep.c (amd64_canonicalize_syscall): Use it.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Make mapped_debug_names and mapped_index final
@ 2017-12-30  7:02 sergiodj+buildbot
  2017-12-30  7:15 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2017-12-30  7:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fc898b42e355fef58e6a029799fdd71b9dda5dc6 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: fc898b42e355fef58e6a029799fdd71b9dda5dc6

Make mapped_debug_names and mapped_index final

When compiling with Clang 6, I see these warnings:

/home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:25421:5: error: destructor called on non-final 'mapped_index' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
    data->index_table->~mapped_index ();
    ^
In file included from /home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:31:
In file included from /home/emaisin/src/binutils-gdb/gdb/defs.h:28:
In file included from /home/emaisin/src/binutils-gdb/gdb/common/common-defs.h:92:
In file included from /home/emaisin/src/binutils-gdb/gdb/common/gdb_unique_ptr.h:23:
In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/memory:81:
/usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/unique_ptr.h:76:2: error: delete called on non-final 'mapped_debug_names' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
        delete __ptr;
        ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/unique_ptr.h:236:4: note: in instantiation of member function 'std::default_delete<mapped_debug_names>::operator()' requested here
          get_deleter()(__ptr);
          ^
/home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:2374:21: note: in instantiation of member function 'std::unique_ptr<mapped_debug_names, std::default_delete<mapped_debug_names> >::~unique_ptr' requested here
dwarf2_per_objfile::dwarf2_per_objfile (struct objfile *objfile_,
                    ^

This patch silences these warnings by making the classes final.

gdb/ChangeLog:

	* dwarf2read.c (struct mapped_debug_names): Make final.
	(struct mapped_index): Make final.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] C++-ify parser_state
@ 2017-12-31  0:34 sergiodj+buildbot
  2017-12-31  0:45 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2017-12-31  0:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e9d9f57e11db6427db347bc5b9b100071355e63f ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: e9d9f57e11db6427db347bc5b9b100071355e63f

C++-ify parser_state

This mildly C++-ifies parser_state and stap_parse_info -- just enough
to remove some cleanups.

This version includes the changes implemented by Simon.

Regression tested by the buildbot.

gdb/ChangeLog
2017-12-30  Tom Tromey  <tom@tromey.com>
	    Simon Marchi  <simon.marchi@ericsson.com>

	* stap-probe.h (struct stap_parse_info): Add constructor,
	destructor.
	* stap-probe.c (stap_parse_argument): Update.
	* rust-exp.y (rust_lex_tests): Update.
	* parser-defs.h (struct parser_state): Add constructor,
	destructor, release method.
	<expout>: Change type to expression_up.
	(null_post_parser): Change type.
	(initialize_expout, reallocate_expout): Remove.
	* parse.c (parser_state::parser_state): Rename from
	initialize_expout.
	(parser_state::release): Rename from reallocate_expout.
	(write_exp_elt, parse_exp_in_context_1, increase_expout_size):
	Update.
	(null_post_parser): Change type of "exp".
	* dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
	* ada-lang.c (resolve, resolve_subexp)
	(replace_operator_with_call): Change type of "expp".
	* language.h (struct language_defn) <la_post_parser>: Change type
	of "expp".


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] dwarf2read: Silence -Wenum-compare-switch warning
@ 2017-12-31  2:43 sergiodj+buildbot
  2017-12-31  3:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2017-12-31  2:43 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 132448f8359a268f34f074b0908b5255b568da06 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 132448f8359a268f34f074b0908b5255b568da06

dwarf2read: Silence -Wenum-compare-switch warning

Compiling with Clang 6 gives:

/home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:24385:14: error: comparison of two values with different enumeration types in switch statement ('enum dwarf_macro_record_type' and 'dwarf_macinfo_record_type') [-Werror,-Wenum-compare-switch]
        case DW_MACINFO_vendor_ext:
             ^~~~~~~~~~~~~~~~~~~~~
/home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:24561:7: error: comparison of two values with different enumeration types in switch statement ('enum dwarf_macro_record_type' and 'dwarf_macinfo_record_type') [-Werror,-Wenum-compare-switch]
        case DW_MACINFO_vendor_ext:
             ^~~~~~~~~~~~~~~~~~~~~

This code uses the two enum types on purpose, because it handles both
.debug_macro and .debug_macinfo sections.  Add some pragmas to disable
the warning in these specific cases.

gdb/ChangeLog:

	* dwarf2read.c (dwarf_decode_macro_bytes): Ignore
	-Wenum-compare-switch warning.
	(dwarf_decode_macros): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Only ignore -Wenum-compare-switch if it exists
@ 2017-12-31  4:57 sergiodj+buildbot
  2017-12-31  5:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2017-12-31  4:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cfa27c399ec9236a100ef794505d35f60da41a6d ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: cfa27c399ec9236a100ef794505d35f60da41a6d

Only ignore -Wenum-compare-switch if it exists

My patch

  dwarf2read: Silence -Wenum-compare-switch warning
  132448f8359a268f34f074b0908b5255b568da06

made some parts of dwarf2read.c ignore warnings about switch using enums
of different kinds.  What I did not realize was that older Clang
versions (prior to 6) did not have that warning, and therefore give this
error:

/home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:24187:7: error: unknown warning group '-Wenum-compare-switch', ignored [-Werror,-Wunknown-pragmas]
      DIAGNOSTIC_IGNORE_SWITCH_DIFFERENT_ENUM_TYPES
      ^
/home/emaisin/src/binutils-gdb/gdb/common/diagnostics.h:42:3: note: expanded from macro 'DIAGNOSTIC_IGNORE_SWITCH_DIFFERENT_ENUM_TYPES'
  DIAGNOSTIC_IGNORE ("-Wenum-compare-switch")
  ^
/home/emaisin/src/binutils-gdb/gdb/common/diagnostics.h:27:3: note: expanded from macro 'DIAGNOSTIC_IGNORE'
  _Pragma (STRINGIFY (GCC diagnostic ignored option))
  ^
<scratch space>:10:25: note: expanded from here
 GCC diagnostic ignored "-Wenum-compare-switch"
                        ^

Clang has a way to test if it knows about a particular warning.  This
patch uses that feature to only define
DIAGNOSTIC_IGNORE_SWITCH_DIFFERENT_ENUM_TYPES to something if the
warning is recognized by the Clang version being used.  I tested
building dwarf2read.c with clang 4, 5, 6, as well as gcc.

gdb/ChangeLog:

	* common/diagnostics.h
	(DIAGNOSTIC_IGNORE_SWITCH_DIFFERENT_ENUM_TYPES): Only
	define if the compiler knows about -Wenum-compare-switch.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Avoid indexing std::vector past the end
@ 2017-12-31 11:04 sergiodj+buildbot
  2017-12-31 15:00 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2017-12-31 11:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 47fea877452b84b94ac6ffb26f194f12845526fa ***

Author: Ruslan Kabatsayev <b7.10110111@gmail.com>
Branch: master
Commit: 47fea877452b84b94ac6ffb26f194f12845526fa

Avoid indexing std::vector past the end

The code here wants to find address of an element, and often this
element is one past the end of std::vector. Dereferencing that element
leads to undefined behavior, so it's better to simply use pointer
arithmetic instead of taking address of invalid dereference.

gdb/ChangeLog:

	* psymtab.c (recursively_search_psymtabs): Use pointer arithmetic
	instead of dereferencing std::vector past the end.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Yearly rotation of the gdb/ChangeLog file
@ 2018-01-02  3:57 sergiodj+buildbot
  2018-01-02  4:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-02  3:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 053f54e57f64ca88596999f37bf3bd329b497d20 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 053f54e57f64ca88596999f37bf3bd329b497d20

Yearly rotation of the gdb/ChangeLog file

gdb/ChangeLog

        * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2017.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Update copyright year in version message of GDB, GDBserver and GDBreplay
@ 2018-01-02  4:44 sergiodj+buildbot
  2018-01-02  6:00 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-02  4:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 82e1e79a420734bcb1fa255a1e7b3250e6acee65 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 82e1e79a420734bcb1fa255a1e7b3250e6acee65

Update copyright year in version message of GDB, GDBserver and GDBreplay

gdb/ChangeLog:

	* top.c (print_gdb_version): Update Copyright year in version
	message.

gdb/gdbserver/ChangeLog:

	* gdbreplay.c (gdbreplay_version): Update copyright year in
	version message.
	* server.c (gdbserver_version): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb/copyright.py: Do not forget to remind about MULTIPLE_COPYRIGHT_HEADERS
@ 2018-01-02  5:29 sergiodj+buildbot
  2018-01-02  8:15 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-02  5:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0f0c98a8a1ca2fa2e73170849b1db4876c3ea954 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 0f0c98a8a1ca2fa2e73170849b1db4876c3ea954

gdb/copyright.py: Do not forget to remind about MULTIPLE_COPYRIGHT_HEADERS

There is a small logical error in the part of the script that
dumps the list of files in BY_HAND + MULTIPLE_COPYRIGHT_HEADERS
but only checkis the contents of BY_HAND. The issue becomes
apparent as soon as BY_HAND is empty. Prevent this from happening
by treating the two lists separately, as this allows us to provide
a more informative message in the case of MULTIPLE_COPYRIGHT_HEADERS.

gdb/ChangeLog:

        * copyright.py (main): Dump the contents of
        MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND,
        even if BY_HAND is empty.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb/copyright.py: Remove testsuite/gdb.base/step-line.{c, inp} special handling
@ 2018-01-02  6:13 sergiodj+buildbot
  2018-01-02 10:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-02  6:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1690bb24d855c387211f7bc5a77334c11cc75f4b ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 1690bb24d855c387211f7bc5a77334c11cc75f4b

gdb/copyright.py: Remove testsuite/gdb.base/step-line.{c,inp} special handling

In the past, these files needed to be handled by hand, because
the testcase was sensitive to the length of the header, which was
potentially changing when new copyright years were added to
the copyright header. Now that we simply maintain and update
a range, the length of the copyright header should not change
as a consequence of the update performed by this script, so
special handling of those files is no longer necessary.

gdb/ChangeLog:

        * copyright.py (BY_HAND): Remove gdb/testsuite/gdb.base/step-line.inp
        and gdb/testsuite/gdb.base/step-line.c.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Update copyright year range in all GDB files
@ 2018-01-02  6:58 sergiodj+buildbot
  2018-01-02 12:48 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-02  6:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e2882c85786571175a0b0bfc3bcd2f14620b1ea3 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: e2882c85786571175a0b0bfc3bcd2f14620b1ea3

Update copyright year range in all GDB files

gdb/ChangeLog:

        Update copyright year range in all GDB files


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] treat Ada DW_TAG_unspecified_type DIEs as stub types
@ 2018-01-02  7:54 sergiodj+buildbot
  2018-01-02 14:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-02  7:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 74a2f8ffb83172de1af0da6751a65c08a722986f ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 74a2f8ffb83172de1af0da6751a65c08a722986f

treat Ada DW_TAG_unspecified_type DIEs as stub types

Consider the gdb.ada/taft_type.exp testcase, which exercises
the situation where a variable is defined using a type which
is a pointer to an incomplete type, with the actual type
definition being provided by another unit. Up to now, the
strategy used by GNAT when generating the DWARF debugging info
was to produce a incomplete DW_TAG_enumeration_type DIE with
a DW_AT_declaration flag attached to it:

        .uleb128 0x4    # (DIE (0x3e) DW_TAG_enumeration_type)
        .long   .LASF4  # DW_AT_name: "pck__empty"
                        # DW_AT_declaration

However, a more standard way for the compiler to describe
this kind of type is to use the DW_TAG_unspecified_type tag.
When the compiler is enhanced to do so, we'll need to treat
such types as stubs -- we only do so with types from Ada units,
however, as the meaning of this TAG is intentionally left
permissive and language-specific by the DWARF standard.

Without this patch, running the testcase above with an enhanced
compiler now yields:

    (gdb) print w.e.all
    Attempt to dereference a generic pointer.
    FAIL: gdb.ada/taft_type.exp: print w.e.all

gdb/ChangeLog:

	* dwarf2read.c (read_unspecified_type): Treat
        DW_TAG_enumeration_type DIEs from Ada units as stubs.

Tested on x86_64-linux, fixes the FAIL in gdb.ada/taft_type.exp above.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add support for dynamic DW_AT_byte_stride.
@ 2018-01-02  8:44 sergiodj+buildbot
  2018-01-02 16:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-02  8:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a405673cc5b56c260de4e1202cead709d1a4f24c ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: a405673cc5b56c260de4e1202cead709d1a4f24c

Add support for dynamic DW_AT_byte_stride.

This patch adds support for DW_AT_byte_stride, using Ada as one
example of where this would be useful. However, the implementation
is language-agnostic.

Consider the following Ada code:

   procedure Nested (L, U : Integer) is
      subtype Small_Type is Integer range L .. U;
      type Record_Type (I : Small_Type := L) is record
         S : String (1 .. I);
      end record;
      type Array_Type is array (Integer range <>) of Record_Type;

      A1 : Array_Type :=
        (1 => (I => 0, S => <>),
         2 => (I => 1, S => "A"),
         3 => (I => 2, S => "AB"));

      procedure Discard (R : Record_Type) is
      begin
         null;
      end Discard;

   begin
      Discard (A1 (1));  -- STOP
   end;

It defines an array A1 of Record_Type, which is a variant record
type whose maximum size actually depends on the value of the
parameters passed when calling Nested. As a result, the stride
of the array A1 cannot be known statically, which leads the compiler
to generate a dynamic DW_AT_byte_stride attribute for our type.
Here is what the debugging info looks like with GNAT:

        .uleb128 0x10   # (DIE (0x14e) DW_TAG_array_type)
        .long   .LASF17 # DW_AT_name: "foo__nested__T18b"
        .long   0x141   # DW_AT_byte_stride
        .long   0xdc    # DW_AT_type
        .uleb128 0x11   # (DIE (0x15f) DW_TAG_subrange_type)
        .long   0x166   # DW_AT_type
        .byte   0x3     # DW_AT_upper_bound
        .byte   0       # end of children of DIE 0x14e

There DW_AT_byte_stride is a reference to a local (internal)
variable:

        .uleb128 0x9    # (DIE (0x141) DW_TAG_variable)
        .long   .LASF6  # DW_AT_name: "foo__nested__T18b___PAD___XVZ"

This patch enhances GDB to handle this dynamic byte stride attribute
by first adding a new dynamic_prop_node_kind (DYN_PROP_BYTE_STRIDE)
to store the array dynamic stride info (when dynamic). It then enhances
the dynamic type resolver to handle this dynamic property.

Before applying this patch, trying to print the value of some of
A1's elements after having stopped at the "STOP" comment does not
work. For instance:

    (gdb) p a1(2)
    Cannot access memory at address 0x80000268dec0

With this patch applied, GDB now prints the value of all 3 elements
correctly:

    (gdb) print A1(1)
    $1 = (i => 0, s => "")
    (gdb) print A1(2)
    $2 = (i => 1, s => "A")
    (gdb) print A1(3)
    $3 = (i => 2, s => "AB")

gdb/ChangeLog:

        * gdbtypes.h (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_STRIDE>:
        New enum value.
        (create_array_type_with_stride): Add byte_stride_prop parameter.
        * gdbtypes.c (create_array_type_with_stride) <byte_stride_prop>:
        New parameter.  Update all callers in this file.
        (array_type_has_dynamic_stride): New function.
        (is_dynamic_type_internal, resolve_dynamic_array): Add handling
        of arrays with dynamic byte strides.
        * dwarf2read.c (read_array_type): Add support for dynamic
        DW_AT_byte_stride attributes.

gdb/testsuite/ChangeLog:

        * gdb.ada/dyn_stride: New testcase.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [gdb/Ada] slices of arrays with dynamic strides
@ 2018-01-02  9:37 sergiodj+buildbot
  2018-01-02 18:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-02  9:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9fe561ab7fc5ee3a06061dae6909cd61b49435df ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 9fe561ab7fc5ee3a06061dae6909cd61b49435df

[gdb/Ada] slices of arrays with dynamic strides

    Consider the following Ada code:

       procedure Nested (L, U : Integer) is
          subtype Small_Type is Integer range L .. U;
          type Record_Type (I : Small_Type := L) is record
             S : String (1 .. I);
          end record;
          type Array_Type is array (Integer range <>) of Record_Type;

          A1 : Array_Type :=
            (1 => (I => 0, S => <>),
             2 => (I => 1, S => "A"),
             3 => (I => 2, S => "AB"));

          procedure Discard (R : Record_Type) is
          begin
             null;
          end Discard;

       begin
          Discard (A1 (1));  -- STOP
       end;

Trying to print a slice of that array currently yields:

    (gdb) p a1(1..3)
    $1 = ((i => 0, s => ""), (i => 0, s => ""), (i => 0, s => ""))

We expected instead:

    (gdb) p a1(1..3)
    $1 = ((i => 0, s => ""), (i => 1, s => "A"), (i => 2, s => "AB"))

This is because the functions we use in ada-lang.c to create the type
of the array slice (ada_value_slice and ada_value_slice_from_ptr) was
not taking into account the stride of the array. This patch fixes this.

gdb/ChangeLog:

        * ada-lang.c (ada_value_slice_from_ptr): Take array stride into
        account when creating the array type of the slice.
        (ada_value_slice): Likewise.

gdb/testsuite/ChangeLog:

        * gdb.ada/dyn_stride.exp: Add slice test.

Note that, with the current use of ada_value_slice, the enhancement
to handle dynamic array strides seems unnecessary, because I do not
see how an array with a dynamic stride can be referenced by either
by reference or pointer. Since references are coerced to array pointers,
in both cases, the slice is performed by ada_value_slice_from_ptr.
But ada_value_slice is enhanced nonetheless, in the spirit of making
the code more robust, in case we missed something, and also as similar
as possible with its from_ptr counterpart.

tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: partial revert of 10c17abdd0
@ 2018-01-02 12:52 sergiodj+buildbot
  2018-01-02 20:45 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-02 12:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1508bbf535b03e3b9105d01a9e19f29f131b3d1a ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 1508bbf535b03e3b9105d01a9e19f29f131b3d1a

x86: partial revert of 10c17abdd0

Other than the variables in tc-i386.c using them, OPERAND_TYPE_REGYMM
and OPERAND_TYPE_REGZMM they aren't entirely unused. No need to update
i386-init.h though, as it mistakenly wasn't updated by the original
commit.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix compile time warning (in the ARM simulator) about a print statement with insufficient arguments.
@ 2018-01-02 17:37 sergiodj+buildbot
  2018-01-02 23:00 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-02 17:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 43724d16bebb38fe6794f6a3741352a7698038de ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 43724d16bebb38fe6794f6a3741352a7698038de

Fix compile time warning (in the ARM simulator) about a print statement with insufficient arguments.

	PR 22663
	* maverick.c (DSPCDP4): Add missing parameter to debug print
	statement.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Unbreak spurious fails in gdb.base/step-line.exp
@ 2018-01-03  4:17 sergiodj+buildbot
  2018-01-03  5:13 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-03  4:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bd570f80f6e47c93f4b1cc1e94688cdde33ca931 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: bd570f80f6e47c93f4b1cc1e94688cdde33ca931

Unbreak spurious fails in gdb.base/step-line.exp

My copyright year update in the copyright headers of the step-line
testcase caused it to start failing, due to shift in line numbers.

    FAIL: gdb.base/step-line.exp: continue to f1
    FAIL: gdb.base/step-line.exp: next to dummy 2
    FAIL: gdb.base/step-line.exp: next over dummy 2
    FAIL: gdb.base/step-line.exp: step into f2
    FAIL: gdb.base/step-line.exp: next over dummy 4
    FAIL: gdb.base/step-line.exp: next to dummy 5
    FAIL: gdb.base/step-line.exp: next to dummy 6
    FAIL: gdb.base/step-line.exp: next over dummy 6
    FAIL: gdb.base/step-line.exp: next to dummy 7
    FAIL: gdb.base/step-line.exp: next to dummy 8
    FAIL: gdb.base/step-line.exp: next over dummy 8
    FAIL: gdb.base/step-line.exp: next to dummy 9
    FAIL: gdb.base/step-line.exp: next to dummy 10
    FAIL: gdb.base/step-line.exp: next over dummy 10

This was caused by the copyright.py script after I changed it to
also update this testcase, which made the following transformation:

    -   Copyright (C) 2001-2017
    -   Free Software Foundation, Inc.
    +   Copyright (C) 2001-2018 Free Software Foundation, Inc.

We can easily unbreak the testcase without having to go back to
manual edits each year by adding an extra line in the header.

gdb/testsuite/ChangeLog:

	* gdb.base/step-line.c: Add extra empty line in copyright header.
        * gdb.base/step-line.inp: Likewise.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Update year range in copyright notice of binutils files
@ 2018-01-03  7:50 sergiodj+buildbot
  2018-01-03  8:06 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-03  7:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 219d1afa89d0d53ca93a684cac341f16470f3ca0 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 219d1afa89d0d53ca93a684cac341f16470f3ca0

Update year range in copyright notice of binutils files


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] (Ada) New command to stop at start of exception handler.
@ 2018-01-03 10:27 sergiodj+buildbot
  2018-01-03 10:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-03 10:27 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9f757bf7fcb8834ead780e0c4a76d6029b1402c2 ***

Author: Xavier Roirand <roirand@adacore.com>
Branch: master
Commit: 9f757bf7fcb8834ead780e0c4a76d6029b1402c2

(Ada) New command to stop at start of exception handler.

When using gdb for debugging Ada source code, there are several catchpoint
types you can define in order to stop upon certain conditions.  Let's
use this small example:

procedure Foo is
begin
   begin
      raise Constraint_Error;
   exception
      when Program_Error =>
         null;
      when Constraint_Error =>
         null;
      when others =>
         null;
   end;
end Foo;

One can stop when the exception is being raised by using the exception
catchpoint like below:

(gdb) catch exception
Catchpoint 1: all Ada exceptions
(gdb)

In that case, when running Foo, gdb will stop at the line where the exception
was raised:

   begin
>>>   raise Constraint_Error;
   exception

This patch introduces new type of catchpoint, when the user wants to stop
at the location of the exception handling.
Imagine we want to stop on any exception handled by the program, we can do:

(gdb) catch handlers
Catchpoint 1: all Ada exceptions handlers
(gdb) r
Starting program: /tmp/foo

By doing so, when running Foo, gdb will stop here:

Catchpoint 1, exception at 0x000000000040255a in foo () at foo.adb:25
25          when Constraint_Error =>
(gdb)

It is also possible to stop when the Constraint_Error exception is being
handled in this program.  With this patch, we can use:

(gdb) catch handlers Constraint_Error
Catchpoint 1: `Constraint_Error' Ada exception handlers
(gdb)

Like for other catchpoint, you can set a condition when adding a catchpoint
on exception handlers.
Here the handlers catchpoint checks Global_Var:

(gdb) catch handlers Constraint_Error if Global_Var /= 0

gdb/ChangeLog:

        * ada-lang.h (ada_exception_catchpoint_kind) <ada_catch_handlers>:
        Add field.
        * ada-lang.c (struct exception_support_info) <catch_handlers_sym>:
        Add field.
        (default_exception_support_info) <catch_handlers_sym>: Add field.
        (exception_support_info_fallback) <catch_handlers_sym>: Add field.
        (ada_exception_name_addr_1): Add "catch handlers" handling.
        (ada_exception_catchpoint_cond_string) <ex>: New parameter.
        Update all callers.
        (create_excep_cond_exprs) <ex>: Add parameter.
        (re_set_exception): Update create_excep_cond_exprs call.
        (print_it_exception, print_one_exception, print_mention_exception)
        (print_recreate_exception): Add "catch handler" handling.
        (allocate_location_catch_handlers, re_set_catch_handlers)
        (check_status_catch_handlers, print_it_catch_handlers)
        (print_one_catch_handlers, print_mention_catch_handlers)
        (print_recreate_catch_handlers): New function.
        (catch_handlers_breakpoint_ops): New variable.
        (catch_ada_exception_command_split) <is_catch_handlers_cmd>:
        Add parameter.  Add "catch handler" handling.
        (ada_exception_sym_name, ada_exception_breakpoint_ops):
        Add "catch handler" handling.
        (ada_exception_catchpoint_cond_string): Add "catch handler"
        handling.
        (create_ada_exception_catchpoint): Update create_excep_cond_exprs
        call.
        (catch_ada_handlers_command): New function.
        (initialize_ada_catchpoint_ops): Initialize "catch handlers"
        operations structure.
        (_initialize_ada_language): Add "catch handlers" command entry.
        * NEWS: Document "catch handlers" feature.

gdb/doc/ChangeLog:

        * gdb.texinfo (Set Catchpoints): Add documentation for new
        "catch handlers" action.

gdb/testsuite/ChangeLog:

        * gdb.ada/excep_handle.exp: New testcase.
        * gdb.ada/excep_handle/foo.adb: New file.
        * gdb.ada/excep_handle/pck.ads: New file.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Create pseudo sections for FreeBSD NT_PROCSTAT_(PROC|FILES|VMMAP) notes.
@ 2018-01-03 20:29 sergiodj+buildbot
  2018-01-03 20:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-03 20:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ddb2bbcf0624ef5f75c0a007c6b192c09b6fa70b ***

Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: ddb2bbcf0624ef5f75c0a007c6b192c09b6fa70b

Create pseudo sections for FreeBSD NT_PROCSTAT_(PROC|FILES|VMMAP) notes.

bfd/ChangeLog:

	* elf.c (elfcore_grok_freebsd_note): Handle
	NT_FREEBSD_PROCSTAT_PROC, NT_FREEBSD_PROCSTAT_FILES, and
	NT_FREEBSD_PROCSTAT_VMMAP.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add gdb.ada/info_addr_mixed_case new testcase
@ 2018-01-04  8:52 sergiodj+buildbot
  2018-01-04  9:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-04  8:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 66fc87a0d50d2b91322cc24d17461c07925fa867 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 66fc87a0d50d2b91322cc24d17461c07925fa867

Add gdb.ada/info_addr_mixed_case new testcase

This patch adds a new testcase to demonstrate a regression introduced by:

    commit b5ec771e60c1a0863e51eb491c85c674097e9e13
    Date:   Wed Nov 8 14:22:32 2017 +0000
    Subject: Introduce lookup_name_info and generalize Ada's FULL/WILD name matching

The purpose of the testcase is to verify that a user can use any
casing for an Ada symbol name passed to the "info address" command.
After the patch above was applied, GDB was no longer able to find
the symbol:

    (gdb) info address My_Table
    No symbol "My_Table" in current context.

gdb/testsuite/ChangeLog:

	PR gdb/22670
	* gdb.ada/info_addr_mixed_case: New testcase.

Tested on x86_64-linux, both before and after the patch.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add "complete break ada" test to gdb.ada/complete.exp
@ 2018-01-04  9:35 sergiodj+buildbot
  2018-01-04 12:13 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-04  9:35 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 344420da6beac1e0b2f7964e7101f8dcdb509b0d ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 344420da6beac1e0b2f7964e7101f8dcdb509b0d

Add "complete break ada" test to gdb.ada/complete.exp

This patch adds a new test to demonstrate a regression introduced by:

    commit b5ec771e60c1a0863e51eb491c85c674097e9e13
    Date:   Wed Nov 8 14:22:32 2017 +0000
    Subject: Introduce lookup_name_info and generalize Ada's FULL/WILD name matching

The original purpose of the new test is to exercise the "complete"
command with an expression for which a large number of matches are
returned and to verify that each match returned is a plausible match.
In this particular case, the commit above causes GDB to generate
additional matches which should in fact not appear in the list
(internally generated symbols, or symbols that should be enclosed
between "<...>"). These extraneous entries are easy to spot, because
they have uppercase characters, such as:

    break ada__stringsS
    break ada__strings__R11s
    [etc]

For now, the new test is KFAIL'ed, to avoid generating a new FAIL
while we work on fixing that regression.

gdb/testsuite/ChangeLog:

        PR gdb/22670
        * gdb.ada/complete.exp: Add "complete break ada" test.

Tested on x86_64-linux with GDB built before and after the patch
that caused the regression (b5ec771e60c1a0863e51eb491c85c674097e9e13).
The test passes before the regression, and generates a KFAIL after.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add new gdb.ada/bp_c_mixed_case testcase for PR gdb/22670
@ 2018-01-04 10:28 sergiodj+buildbot
  2018-01-04 14:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-04 10:28 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 289483b6a06c7a24ee9ae9021d2728ca4700b7a6 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 289483b6a06c7a24ee9ae9021d2728ca4700b7a6

Add new gdb.ada/bp_c_mixed_case testcase for PR gdb/22670

This patch adds a new testcase to demonstrate a regression introduced by:

    commit b5ec771e60c1a0863e51eb491c85c674097e9e13
    Date:   Wed Nov 8 14:22:32 2017 +0000
    Subject: Introduce lookup_name_info and generalize Ada's FULL/WILD name matching

The purpose of the testcase is to verify that a user can insert
a breakpoint on a C function while debugging Ada, even if the name
of the function includes uppercase letters, requiring us to use
Ada's "<...>" notation to tell the GDB that the symbol name should
be looked up verbatim.

As of the commit above, GDB is no longer finding the function:

    (gdb) break <MixedCaseFunc>
    Function "<MixedCaseFunc>" not defined.
    Make breakpoint pending on future shared library load? (y or [n])

Before the patch, the breakpoint was inserted without problem.

gdb/testsuite/ChangeLog:

        PR gdb/22670
        * gdb.ada/bp_c_mixed_case: New testcase.

Tested on x86_64-linux; generates a KPASS before the regression
was introduced, and now generates a KFAIL.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb.ada/maint_with_ada.exp: New testcase
@ 2018-01-04 11:13 sergiodj+buildbot
  2018-01-04 17:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-04 11:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7365ec2ff4a7028503f39655bd2628d54418106c ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 7365ec2ff4a7028503f39655bd2628d54418106c

gdb.ada/maint_with_ada.exp: New testcase

This commit adds a new testcase testing the "check-psymtabs" and
"check-symtabs" maintenance commands.

The "maintenance check-psymtabs" commands is currently known to
produce some errors. While the situation was admetedly made worse
by the following patch...

    commit b5ec771e60c1a0863e51eb491c85c674097e9e13
    Date:   Wed Nov 8 14:22:32 2017 +0000
    Subject: Introduce lookup_name_info and generalize Ada's FULL/WILD name matching

... hence the reference to PR gdb/22670, the command was already
spotting one inconsistency prior to it:

    (gdb) maintenance check-psymtabs
    Global symbol `interfaces__cS' only found in /[...]/b~var_arr_typedef.adb psymtab

For now, the "check-psymtab" test is KFAIL-ed.

gdb/testsuite/ChangeLog:

        PR gdb/22670
        * gdb.ada/maint_with_ada: New testcase.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] RISC-V: Add 2 missing privileged registers.
@ 2018-01-04 22:38 sergiodj+buildbot
  2018-01-04 22:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-04 22:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 645a2c5b46e18013ac9cb16b66ba7b6b97cd01c5 ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 645a2c5b46e18013ac9cb16b66ba7b6b97cd01c5

RISC-V: Add 2 missing privileged registers.

	gas/
	* testsuite/gas/riscv/priv-reg.s: Add missing stval and mtval.
	* testsuite/gas/riscv/priv-reg.d: Likewise.

	include/
	* opcode/riscv-opc.h (CSR_SBADADDR): Rename to CSR_STVAL.  Rename
	DECLARE_CSR entry.  Add alias to map sbadaddr to CSR_STVAL.
	(CSR_MBADADDR): Rename to CSR_MTVAL.  Rename DECLARE_CSR entry.
	Add alias to map mbadaddr to CSR_MTVAL.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Bump version to 8.1.50.DATE-git.
@ 2018-01-05  5:59 sergiodj+buildbot
  2018-01-05  8:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-05  5:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 09aca9495c4794e586680f359e612ece173148ec ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 09aca9495c4794e586680f359e612ece173148ec

Bump version to 8.1.50.DATE-git.

Now that the GDB 8.1 branch has been created, we can
bump the version number.

gdb/ChangeLog:

	GDB 8.1 branch created (5219ac6237c272b938c28517bf371429260c71e7):
	* version.in: Bump version to 8.1.50.DATE-git.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Update NEWS post GDB 8.1 branch creation.
@ 2018-01-05  6:37 sergiodj+buildbot
  2018-01-05 10:55 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-05  6:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cd385f94a7888b619c84e9ab007bac5093c5e894 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: cd385f94a7888b619c84e9ab007bac5093c5e894

Update NEWS post GDB 8.1 branch creation.

gdb/ChangeLog:

	* NEWS: Create a new section for the next release branch.
	Rename the section of the current branch, now that it has
	been cut.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] (Ada) Remove printing of array's first index when unneeded
@ 2018-01-05  7:31 sergiodj+buildbot
  2018-01-05 13:06 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-05  7:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e3861a03138e24e7f2f0e8c4982bdad2a6e1dbaf ***

Author: Xavier Roirand <roirand@adacore.com>
Branch: master
Commit: e3861a03138e24e7f2f0e8c4982bdad2a6e1dbaf

(Ada) Remove printing of array's first index when unneeded

Consider the following code:

  type Table is array (Character) of Natural;
  My_Table : Table := (others => 4874);

Printing this table in gdb leads to:

  (gdb) p my_table
  $1 = ('["00"]' => 4874 <repeats 256 times>)

In this case, the index of the first element in this array is also
the first element of the index type (character type). Similar to what
we do we enumeration types, we do not need to print the index of the
first element when printing the array.

This patch fixes this issue and changes the output as follow:

  (gdb) p my_table
  $1 = (4874 <repeats 256 times>)

gdb/ChangeLog:

        * ada-valprint.c (print_optional_low_bound): Handle
        character-indexed array printing like boolean-indexed array
        printing.

gdb/testuite/ChangeLog:

        * testsuite/gdb.ada/array_char_idx/pck.ads (Table): New type.
        (My_Table): New global variable.
        * testsuite/gdb.ada/array_char_idx.exp: Add test.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] memory error printing component of record from convenience variable
@ 2018-01-05 10:38 sergiodj+buildbot
  2018-01-05 14:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-05 10:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cc0e770c0d00acececc43826f4673896d09b3dff ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: cc0e770c0d00acececc43826f4673896d09b3dff

memory error printing component of record from convenience variable

Consider the following situation Ada code:

   type Kind_T is (One, Two, Three);
   type Time_Set_T is array (Kind_T) of Integer;

   type T  is record
      Started    : Time_Set_T;
   end record;

   Null_T : constant T := (Started => (others => 0));

   My_Item : Pck.T := Pck.Null_T;

Trying to print the value of My_Item.Started is no problem:

    (gdb) p item.started
    $1 = (0, 0, 0)

However, if you save My_Item into a convenience variable first,
and then try to print a component of that record, you get
an unexpected memory error, instead of getting the same result.
For instance:

    (gdb) set variable $item := item
    (gdb) p $item.started
    Cannot access memory at address 0x0

The issue occurs when, after we extracted the component from
the convenience variable, we next try to "fix" it (which is
ada-lang speak for resolving the type into a static type).
This is done in ada_to_fixed_value, which delegates to
ada_to_fixed_value_create via:

    val = ada_to_fixed_value_create (value_type (val),
                                     value_address (val), val);

And looking at ada_to_fixed_value_create, we see that:

  struct type *type = ada_to_fixed_type (type0, 0, address, NULL, 1);

  if (type == type0 && val0 != NULL)
    return val0;
  else
    return value_from_contents_and_address (type, 0, address);

The part that interests us, in this case, is the "else" branch,
where we obviously make the implicit assumption that our object
has an address, which is not true, in this case, because we are
actually dealing with a convenience variable.

This patch plugs that hole by adding special handing for situations
where val does not live in memory. In that case, we just create
a not_lval value using val's contents.

gdb/ChangeLog:

        * ada-lang.c (ada_to_fixed_value_create): Add handling of
        the case where VALUE_LVAL (val0) is not lval_memory.

gdb/testsuite/ChangeLog:

        * gdb.ada/convvar_comp: New testcase.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] (Ada) Fix Length attribute on array access
@ 2018-01-05 11:59 sergiodj+buildbot
  2018-01-05 16:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-05 11:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7150d33cda60fd543e9d9d68eb58d4e6155fb878 ***

Author: Jerome Guitton <guitton@adacore.com>
Branch: master
Commit: 7150d33cda60fd543e9d9d68eb58d4e6155fb878

(Ada) Fix Length attribute on array access

Consider the following variable "Indexed_By_Enum", declared as
an access to an array whose index type is an enumerated type
whose underlying values have "gaps":

   type Enum_With_Gaps is (LIT0, LIT1, LIT2, LIT3, LIT4);
   for Enum_With_Gaps use (LIT0 => 3,
                           LIT1 => 5,
                           LIT2 => 8,
                           LIT3 => 13,
                           LIT4 => 21);
   for Enum_With_Gaps'size use 16;

   type MyWord is range 0 .. 16#FFFF# ;
   for MyWord'Size use 16;

   type AR is array (Enum_With_Gaps range <>) of MyWord;
   type AR_Access is access AR;

   Indexed_By_Enum : AR_Access :=
     new AR'(LIT1 => 1,  LIT2 => 43, LIT3 => 42, LIT4 => 41);

Trying to print the length (number of elements) of this array using
the 'Length attribute does not work:

    (gdb) print indexed_by_enum'length
    'POS only defined on discrete types

The problem occurs while trying to get the array's index type.
It was using TYPE_INDEX_TYPE for that. It does not work for Ada arrays
in general; use ada_index_type instead.

gdb/ChangeLog:

	* ada-lang.c (ada_array_length): Use ada_index_type instead of
	TYPE_INDEX_TYPE.

gdb/testsuite/ChangeLog:

        * gdb.ada/arr_acc_idx_w_gap: New testcase.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] (Ada) problem printing renaming which references a subprogram parameter
@ 2018-01-05 13:34 sergiodj+buildbot
  2018-01-05 19:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-05 13:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 342f82403949c74517a6353baec73b94d18549ad ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 342f82403949c74517a6353baec73b94d18549ad

(Ada) problem printing renaming which references a subprogram parameter

Consider the following code, which creates a local variable B
which is a renaming whose expression references a subprogram
parameter:

   procedure Flip (Bits : in out Bits_Type; I : Natural) is
   begin
      declare
         B : Boolean renames Bits (I);
      begin
         B := not B; -- BREAK
      end;
   end Flip;

Trying to print the value of B when at the "BREAK" line currently
does not work:

    (gdb) p b
    Could not find i

What happens is the following: For the renaming, GNAT generates
a variable whose name is encoded as follow:

    b___XR_bits___XEXSi

GDB properly detects that variable, determines that, to compute
the variable's value, we start from the symbol "Bits", which
we then have to subscript (XS) using 'i' as the index. The error
occurs while trying to find 'i'.

This is because we forgot to pass the block in the call to
ada_lookup_encoded_symbol, which this patch fixes.

gdb/ChangeLog:

        * ada-exp.y (write_object_renaming): When subscripting an array
        using a symbol as the index, pass the block in call to
        ada_lookup_encoded_symbol when looking that symbol up.

gdb/testsuite/ChangeLog:

        * gdb.ada/rename_subscript_param: New testcase.

Tested on x86_64-linux.

Note: This requires the following GCC patch:

  | 2017-04-25  Pierre-Marie de Rodat  <derodat@adacore.com>
  |
  | * exp_dbug.adb: In Debug_Renaming_Declaration,
  | when dealing with indexed component, accept to produce a renaming
  | symbol when the index is an IN parameter or when it is a name
  | defined in an outer scope.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix gdb.ada/info_addr_mixed_case.exp (PR gdb/22670)
@ 2018-01-05 17:13 sergiodj+buildbot
  2018-01-05 22:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-05 17:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f98fc17b3ac4750842ec0fe28a18b51691ddfbda ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: f98fc17b3ac4750842ec0fe28a18b51691ddfbda

Fix gdb.ada/info_addr_mixed_case.exp (PR gdb/22670)

The comments about mixed case in the testcase are actually a red
herring.  The problem here is that we'd get to
ada_lookup_encoded_symbol with "my_table", which wraps the looked up
name in "<>"s to force a verbatim match, and that in turn disables
wild matching.

Fix this by swapping around the internals of ada_lookup_encoded_symbol
and ada_lookup_symbol, thus avoiding the encoding and
verbatim-wrapping in the ada_lookup_symbol case, the case that starts
with a user-provided lookup name.

Ada encoding is still done of course, in the ada_lookup_name_info
ctor.  This could be also seen as avoiding the double-encoding problem
in a different way.

gdb/ChangeLog:
2018-01-05  Pedro Alves  <palves@redhat.com>

	PR gdb/22670
	* ada-lang.c (ada_lookup_encoded_symbol): Reimplement in terms of
	ada_lookup_symbol.
	(ada_lookup_symbol): Reimplement in terms of
	ada_lookup_symbol_list, bits factored out from
	ada_lookup_encoded_symbol.

gdb/testsuite/ChangeLog:
2018-01-05  Pedro Alves  <palves@redhat.com>

	PR gdb/22670
	* gdb.ada/info_addr_mixed_case.exp: Remove kfail.  Extend test to
	exercise lower case too, and to exercise both full matching and
	wild matching.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix gdb/spu-tdep.c build breakage
@ 2018-01-05 18:57 sergiodj+buildbot
  2018-01-06  1:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-05 18:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a655456c134e5e02bab33941e1c738ca33905d23 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: a655456c134e5e02bab33941e1c738ca33905d23

Fix gdb/spu-tdep.c build breakage

Commit de63c46b549d ("Fix regresssion(internal-error) printing
subprogram argument (PR gdb/22670)") missed updating spu-tdep.c for
the block_lookup_symbol interface change, resulting in:

  ../../binutils-gdb/gdb/spu-tdep.c: In function void spu_catch_start(objfile*):
  ../../binutils-gdb/gdb/spu-tdep.c:1969:59: error: cannot convert domain_enum_tag to symbol_name_match_type for argument 3 to symbol* block_lookup_symbol(const block*, const char*, symbol_name_match_type, domain_enum)
	 sym = block_lookup_symbol (block, "main", VAR_DOMAIN);
							     ^

gdb/ChangeLog:
2018-01-05  Pedro Alves  <palves@redhat.com>

	* spu-tdep.c (spu_catch_start): Pass
	symbol_name_match_type::SEARCH_NAME to block_lookup_symbol.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix regression: cannot start with LD_PRELOAD=libSegFault.so (PR gdb/18653#c7)
@ 2018-01-05 19:58 sergiodj+buildbot
  2018-01-06  4:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-05 19:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e379cee61f3890e535e995828e8846b020ef2a32 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: e379cee61f3890e535e995828e8846b020ef2a32

Fix regression: cannot start with LD_PRELOAD=libSegFault.so (PR gdb/18653#c7)

At https://sourceware.org/bugzilla/show_bug.cgi?id=18653#c7, Andrew
reports that the fix for PR gdb/18653 made GDB useless if you preload
libSegFault.so, because GDB internal-errors on startup:

 $ LD_PRELOAD=libSegFault.so gdb
 src/gdb/common/signals-state-save-restore.c:64: internal-error: unexpected signal handler
 A problem internal to GDB has been detected,
 further debugging may prove unreliable.
 Aborted (core dumped)
 $

The internal error comes from the code saving the signal dispositions
inherited from gdb's parent:

 (top-gdb) bt
 #0  0x000000000056b001 in internal_error(char const*, int, char const*, ...) (file=0xaf5f38 "src/gdb/common/signals-state-save-restore.c", line=64, fmt=0xaf5f18 "unexpected signal handler") at src/gdb/common/errors.c:54
 #1  0x00000000005752c9 in save_original_signals_state() () at src/gdb/common/signals-state-save-restore.c:64
 #2  0x00000000007425de in captured_main_1(captured_main_args*) (context=0x7fffffffd860)
     at src/gdb/main.c:509
 #3  0x0000000000743622 in captured_main(void*) (data=0x7fffffffd860) at src/gdb/main.c:1145
 During symbol reading, cannot get low and high bounds for subprogram DIE at 24065.
 #4  0x00000000007436f9 in gdb_main(captured_main_args*) (args=0x7fffffffd860) at src/gdb/main.c:1171
 #5  0x0000000000413acd in main(int, char**) (argc=1, argv=0x7fffffffd968) at src/gdb/gdb.c:32

This commit downgrades the internal error to a warning.  You'll get
instead:

~~~
 $ LD_PRELOAD=libSegFault.so gdb
 warning: Found custom handler for signal 11 (Segmentation fault) preinstalled.
 Some signal dispositions inherited from the environment (SIG_DFL/SIG_IGN)
 won't be propagated to spawned programs.
 GNU gdb (GDB) 8.0.50.20171213-git
 Copyright (C) 2017 Free Software Foundation, Inc.
 License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
 This is free software: you are free to change and redistribute it.
 There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
 and "show warranty" for details.
 This GDB was configured as "x86_64-pc-linux-gnu".
 Type "show configuration" for configuration details.
 For bug reporting instructions, please see:
 <http://www.gnu.org/software/gdb/bugs/>.
 Find the GDB manual and other documentation resources online at:
 <http://www.gnu.org/software/gdb/documentation/>.
 For help, type "help".
 Type "apropos word" to search for commands related to "word"...
 (gdb)
~~~

This also moves the location where save_original_signals_state is
called a bit further below (to after option processing), so that "-q"
disables the warning:

~~~
 $ LD_PRELOAD=libSegFault.so gdb -q
 (gdb)
~~~

New testcase included.

gdb/ChangeLog:
2018-01-05  Pedro Alves  <palves@redhat.com>

	PR gdb/18653
	* common/signals-state-save-restore.c
	(save_original_signals_state): New parameter 'quiet'.  Warn if we
	find a custom handler preinstalled, instead of internal erroring.
	But only warn if !quiet.
	* common/signals-state-save-restore.h
	(save_original_signals_state): New parameter 'quiet'.
	* main.c (captured_main_1): Move save_original_signals_state call
	after option handling, and pass QUIET.

gdb/gdbserver/ChangeLog:
2018-01-05  Pedro Alves  <palves@redhat.com>

	PR gdb/18653
	* server.c (captured_main): Pass quiet=false to
	save_original_signals_state.

gdb/testsuite/ChangeLog:
2018-01-05  Pedro Alves  <palves@redhat.com>

	PR gdb/18653
	* gdb.base/libsegfault.exp: New.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] RISC-V: Print symbol address for jalr w/ zero offset.
@ 2018-01-06  2:13 sergiodj+buildbot
  2018-01-06  7:36 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-06  2:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 35eeb78fa9535df6a273c053d8f102e046261b89 ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 35eeb78fa9535df6a273c053d8f102e046261b89

RISC-V: Print symbol address for jalr w/ zero offset.

	ld/
	* testsuite/ld-riscv-elf/disas-jalr.d: New.
	* testsuite/ld-riscv-elf/disas-jalr.s: New.
	* testsuite/ld-riscv-elf/ld-riscv-elf.exp: Run new testcase.

	opcodes/
	* riscv-dis.c (print_insn_args) <'s'>: Call maybe_print_address for a
	jalr.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] C++ify xmethod_worker, get rid of VEC(xmethod_worker_ptr)
@ 2018-01-07 14:48 sergiodj+buildbot
  2018-01-07 15:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-07 14:48 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ba18742c3a1b62ff218db99bee47bb932af6dab9 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: ba18742c3a1b62ff218db99bee47bb932af6dab9

C++ify xmethod_worker, get rid of VEC(xmethod_worker_ptr)

The initial goal of this patch was to remove the usage of
VEC(xmethod_worker_ptr) and corresponding cleanups.  I ended up having
to  C++ify the xmethod_worker code, to be able to have xmethod_workers
free their data in destructors, and therefore be able to use vectors of
xmethod_worker unique_ptr.

The operations in extension_language_ops that act on one instance of
xmethod_worker (get result type, get args type, invoke) are transformed
to methods of xmethod_worker.  xmethod_worker becomes an abstract base
class with virtual pure methods which python_xmethod_worker implements.
The only xmethod-related operation left in extension_language_ops is
get_matching_xmethod_workers, which returns a list of xmethod_workers.

The changes are relatively straightforward, but here are some notes on
things that may raise eyebrows:

  - I was not really comfortable with the value_of_xmethod function.  At
  first it looks like a simple getter, so I considered making it a
  method of xmethod_worker.  But actually it creates a value and
  transfers the ownership of the xmethod_worker to it.  It would be a
  bit weird and error-prone if calling a method on an object silently
  removed the ownership of the object from the caller.  To reflect the
  behavior more accurately, I renamed it to value_from_xmethod and made
  it accept an rvalue-reference (so the caller knows it gives away the
  ownership).  I noticed the backlink from xmethod_worker to its owning
  value was not used, so I removed it.

  - Some code, like get_matching_xmethod_workers, made each callee fill
  a new vector, which was then merged in the result vector.  I think
  it's safe if we always pass the same vector around, and each
  implementation just appends to it.

  - The clone operation does not seem particularly useful, it is removed
  in the following patch.

gdb/ChangeLog:

	* extension-priv.h (enum ext_lang_rc): Remove, move to extension.h.
	(struct extension_language_ops) <clone_xmethod_worker_data>: Remove.
	<free_xmethod_worker_data>: Remove.
	<get_matching_xmethod_workers>: Chance VEC to std::vector.
	<get_xmethod_arg_types>: Remove.
	<get_xmethod_result_type>: Remove.
	<invoke_xmethod>: Remove.
	* extension.c (new_xmethod_worker): Remove.
	(clone_xmethod_worker): Remove.
	(get_matching_xmethod_workers): Return void, pass std::vector by
	pointer.
	(get_xmethod_arg_types): Rename to...
	(xmethod_worker::get_arg_types): ... this, and adjust.
	(get_xmethod_result_type): Rename to...
	(xmethod_worker::get_result_type): ... this, and adjust.
	(invoke_xmethod): Remove.
	(free_xmethod_worker): Remove.
	(free_xmethod_worker_vec): Remove.
	* extension.h (enum ext_lang_rc): Move here from
	extension-priv.h.
	(struct xmethod_worker): Add constructor and destructor.
	<data>: Remove.
	<value>: Remove.
	<invoke, clone, do_get_result_type, do_get_arg_types>: New
	virtual pure methods.
	<get_arg_types, get_result_type>: New methods.
	(xmethod_worker_ptr): Remove typedef.
	(DEF_VEC_P (xmethod_worker_ptr)): Remove.
	(xmethod_worker_vec): Remove typedef.
	(xmethod_worker_up): New typedef.
	(invoke_xmethod): Remove.
	(clone_xmethod_worker): Remove.
	(free_xmethod_worker): Remove.
	(free_xmethod_worker_vec): Remove.
	(get_xmethod_arg_types): Remove.
	(get_xmethod_result_type): Remove.
	* valops.c (find_method_list): Use std::vector, don't use
	intermediate vector.
	(value_find_oload_method_list): Use std::vector.
	(find_overload_match): Use std::vector.
	(find_oload_champ): Use std::vector.
	* value.c (value_free): Use operator delete.
	(value_of_xmethod): Rename to...
	(value_from_xmethod): ... this.  Don't assign
	xmethod_worker::value, take rvalue-reference.
	(result_type_of_xmethod): Adjust.
	(call_xmethod): Adjust.
	* value.h: Include extension.h.
	(struct xmethod_worker): Don't forward-declare.
	(value_of_xmethod): Rename to...
	(value_from_xmethod): ... this, take rvalue-reference.
	* python/py-xmethods.c (struct gdbpy_worker_data): Rename to...
	(struct python_xmethod_worker): ... this, add constructor and
	destructor.
	<invoke, clone, do_get_arg_types, do_get_result_type>: Implement.
	(gdbpy_free_xmethod_worker_data): Rename to...
	(python_xmethod_worker::~python_xmethod_worker): ... this and
	adjust.
	(gdbpy_clone_xmethod_worker_data): Rename to...
	(python_xmethod_worker::clone): ... this and adjust.
	(gdbpy_get_matching_xmethod_workers): Use std::vector, don't use
	temporary vector.
	(gdbpy_get_xmethod_arg_types): Rename to...
	(python_xmethod_worker::do_get_arg_types): ... this and adjust.
	(gdbpy_get_xmethod_result_type): Rename to...
	(python_xmethod_worker::do_get_result_type): ... this and
	adjust.
	(gdbpy_invoke_xmethod): Rename to...
	(python_xmethod_worker::invoke): ... this and adjust.
	(new_python_xmethod_worker): Rename to...
	(python_xmethod_worker::python_xmethod_worker): ... this and
	adjust.
	* python/python-internal.h (gdbpy_clone_xmethod_worker_data):
	Remove.
	(gdbpy_free_xmethod_worker_data): Remove.
	(gdbpy_get_matching_xmethod_workers): Use std::vector.
	(gdbpy_get_xmethod_arg_types): Remove.
	(gdbpy_get_xmethod_result_type): Remove.
	(gdbpy_invoke_xmethod): Remove.
	* python/python.c (python_extension_ops): Remove obsolete
	callbacks.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove xmethod_worker::clone
@ 2018-01-07 15:59 sergiodj+buildbot
  2018-01-07 17:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-07 15:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f979c73fd0be9a8a683f79af40c7b939c2a65d9f ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: f979c73fd0be9a8a683f79af40c7b939c2a65d9f

Remove xmethod_worker::clone

I think that the clone method of xmethod_worker can be removed.  It is
only used in find_overload_match, to clone an xmethod we want to
keep.  Instead, we can just std::move it out of the vector and into
value_from_xmethod.  value_from_xmethod creates a value that will own
the xmethod_worker from that point.  Other xmethod_workers left in the
vector will get destroyed when the vector gets destroyed, but the chosen
one will keep living inside the value struct.

gdb/ChangeLog:

	* extension.h (struct xmethod_worker) <clone>: Remove.
	* python/py-xmethods.c (struct python_xmethod_worker) <clone>:
	Remove.
	(python_xmethod_worker::clone): Remove.
	* valops.c (find_overload_match): Use std::move instead of
	clone.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Replace VEC(gdb_xml_value_s) with std::vector
@ 2018-01-07 16:23 sergiodj+buildbot
  2018-01-07 18:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-07 16:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4d0fdd9b357aff1fea3ef3def55d12464a41bf5b ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 4d0fdd9b357aff1fea3ef3def55d12464a41bf5b

Replace VEC(gdb_xml_value_s) with std::vector

This patch replaces VEC(gdb_xml_value_s), which is passed to XML
visitors, with an std::vector.  In order to be able to remove the
cleanup in gdb_xml_parser::start_element, the gdb_xml_parser structure
is made to own the value with a gdb::unique_xmalloc_ptr.

This patch has been tested on the buildbot.

gdb/ChangeLog:

	* xml-support.h (struct gdb_xml_value): Add constructor.
	<value>: Change type to unique_xmalloc_ptr.
	(gdb_xml_value_s): Remove typedef.
	(DEF_VEC_O (gdb_xml_value_s)): Remove.
	(gdb_xml_element_start_handler): Change parameter type to
	std::vector.
	(xml_find_attribute): Likewise.
	* xml-support.c (xml_find_attribute): Change parameter type to
	std::vector and adjust.
	(gdb_xml_values_cleanup): Remove.
	(gdb_xml_parser::start_element): Adjust to std::vector.
	(xinclude_start_include): Change paraeter type to std::vector
	and adjust.
	* btrace.c (check_xml_btrace_version): Likewise.
	(parse_xml_btrace_block): Likewise.
	(parse_xml_btrace_pt_config_cpu): Likewise.
	(parse_xml_btrace_pt): Likewise.
	(parse_xml_btrace_conf_bts): Likewise.
	(parse_xml_btrace_conf_pt): Likewise.
	* memory-map.c (memory_map_start_memory): Likewise.
	(memory_map_start_property): Likewise.
	* osdata.c (osdata_start_osdata): Likewise.
	(osdata_start_item): Likewise.
	(osdata_start_column): Likewise.
	* remote.c (start_thread): Likewise.
	* solib-aix.c (library_list_start_library): Likewise.
	(library_list_start_list): Likewise.
	* solib-svr4.c (library_list_start_library): Likewise.
	(svr4_library_list_start_list): Likewise.
	* solib-target.c (library_list_start_segment): Likewise.
	(library_list_start_section): Likewise.
	(library_list_start_library): Likewise.
	(library_list_start_list): Likewise.
	* tracepoint.c (traceframe_info_start_memory): Likewise.
	(traceframe_info_start_tvar): Likewise.
	* xml-syscall.c (syscall_start_syscall): Likewise.
	* xml-tdesc.c (tdesc_start_target): Likewise.
	(tdesc_start_feature): Likewise.
	(tdesc_start_reg): Likewise.
	(tdesc_start_union): Likewise.
	(tdesc_start_struct): Likewise.
	(tdesc_start_flags): Likewise.
	(tdesc_start_enum): Likewise.
	(tdesc_start_field): Likewise.
	(tdesc_start_enum_value): Likewise.
	(tdesc_start_vector): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Replace VEC(converted_character_d) with std::vector
@ 2018-01-07 17:08 sergiodj+buildbot
  2018-01-07 21:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-07 17:08 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b01ba14d4d5391e59fd0e1a3608fd47287edc008 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: b01ba14d4d5391e59fd0e1a3608fd47287edc008

Replace VEC(converted_character_d) with std::vector

This patch changes the usage of VEC(converted_character_d) to use an
std::vector instead.  This allows getting rid of a cleanup.

gdb/ChangeLog:

	* valprint.c (converted_character_d): Remove typedef.
	(DEF_VEC_O (converted_character_d)): Remove.
	(count_next_character): Use std::vector.
	(print_converted_chars_to_obstack): Likewise.
	(generic_printstr): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Make parse_debug_format_options return an std::string
@ 2018-01-07 18:03 sergiodj+buildbot
  2018-01-07 23:30 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-07 18:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2cc050302cd365fd28fac65d49b6c817eed74faf ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 2cc050302cd365fd28fac65d49b6c817eed74faf

Make parse_debug_format_options return an std::string

This avoid having to manually free the return value.

gdb/gdbserver/ChangeLog:

	* server.c (parse_debug_format_options): Return std::string.
	(handle_monitor_command, captured_main): Adjust.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Replace objfile field in dwarf2_cu and dwarf2_per_cu_data with dwarf2_per_objfile
@ 2018-01-07 18:45 sergiodj+buildbot
  2018-01-08  1:05 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-07 18:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e3b94546125849c6c513114cf20f78d2a7aa9db2 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: e3b94546125849c6c513114cf20f78d2a7aa9db2

Replace objfile field in dwarf2_cu and dwarf2_per_cu_data with dwarf2_per_objfile

The next patch aims to remove the dwarf2_per_objfile global.  In many
functions, we need to find a way to get a reference to the current
dwarf2_per_objfile through the objects passed in parameters.  Often, we have
access to a dwarf2_cu or a dwarf2_per_cu_data.  These objects have a reference
to the objfile, through which we can get the dwarf2_per_objfile:

  dwarf2_per_objfile = ((struct dwarf2_per_objfile *)
		        objfile_data (objfile, dwarf2_objfile_data_key));

However, this is a bit cumbersome to do all over the place.  It would be
more logical if the dwarf2_cu and dwarf2_per_cu_data had a reference to
their dwarf2_per_objfile, which would then have a reference to the
objfile.  It would be more in line with the object hierarchy, where
dwarf2_per_objfile owns the dwarf2_per_cu_data instances.  We could
even remove the reference dwarf2_cu has to dwarf2_per_objfile, since we
can access dwarf2_per_objfile through dwarf2_cu::per_cu.

In a graphical way, references would look like this after the current
patch:

  objfile <--- dwarf2_per_objfile <--- dwarf2_per_cu_data
                                    |      ^
				    |      |
                                    `- dwarf2_cu

This patch has been tested on the buildbot.

gdb/ChangeLog:

	* dwarf2read.c (struct dwarf2_cu) <objfile>: Remove.
	<dwarf2_per_objfile>: New field.
	(struct dwarf2_per_cu_data) <objfile>: Remove.
	<dwarf2_per_objfile>: New field.
	(create_cu_from_index_list): Assign dwarf2_per_objfile instead
	of objfile.
	(create_signatured_type_table_from_index): Likewise.
	(create_debug_type_hash_table): Likewise.
	(fill_in_sig_entry_from_dwo_entry): Likewise.
	(lookup_dwo_unit): Access objfile through dwarf2_per_objfile.
	(create_type_unit_group): Assign dwarf2_per_objfile instead of
	objfile.
	(create_partial_symtab): Access objfile through
	dwarf2_per_objfile.
	(process_psymtab_comp_unit_reader): Likewise.
	(read_comp_units_from_section): Likewise.
	(scan_partial_symbols): Likewise.
	(add_partial_symbol): Likewise.
	(add_partial_subprogram): Likewise.
	(peek_die_abbrev): Likewise.
	(fixup_go_packaging): Likewise.
	(process_full_comp_unit): Likewise.
	(process_full_type_unit): Likewise.
	(process_imported_unit_die): Likewise.
	(dwarf2_compute_name): Likewise.
	(dwarf2_physname): Likewise.
	(read_import_statement): Likewise.
	(create_cus_hash_table): Assign dwarf2_physname instead of
	objfile.
	(read_func_scope): Access objfile through dwarf2_per_objfile.
	(read_lexical_block_scope): Likewise.
	(read_call_site_scope): Likewise.
	(read_variable): Likewise.
	(dwarf2_rnglists_process): Likewise.
	(dwarf2_ranges_process): Likewise.
	(dwarf2_ranges_read): Likewise.
	(dwarf2_record_block_ranges): Likewise.
	(dwarf2_add_field): Likewise.
	(dwarf2_add_member_fn): Likewise.
	(read_structure_type): Likewise.
	(process_structure_scope): Likewise.
	(read_enumeration_type): Likewise.
	(read_array_type): Likewise.
	(read_common_block): Likewise.
	(read_namespace_type): Likewise.
	(read_namespace): Likewise.
	(read_module_type): Likewise.
	(read_tag_pointer_type): Likewise.
	(read_tag_ptr_to_member_type): Likewise.
	(read_tag_string_type): Likewise.
	(read_subroutine_type): Likewise.
	(read_typedef): Likewise.
	(read_base_type): Likewise.
	(attr_to_dynamic_prop): Likewise.
	(read_subrange_type): Likewise.
	(read_unspecified_type): Likewise.
	(load_partial_dies): Likewise.
	(read_partial_die): Likewise.
	(find_partial_die): Likewise.
	(guess_partial_die_structure_name): Likewise.
	(fixup_partial_die): Likewise.
	(read_attribute_value): Likewise.
	(read_addr_index_from_leb128): Likewise.
	(dwarf2_read_addr_index): Likewise.
	(dwarf2_string_attr): Likewise.
	(lnp_state_machine::check_line_address): Likewise.
	(dwarf_decode_lines_1): Likewise.
	(dwarf_decode_lines): Likewise.
	(dwarf2_start_symtab): Likewise.
	(var_decode_location): Likewise.
	(new_symbol_full): Likewise.
	(dwarf2_const_value_data): Likewise.
	(dwarf2_const_value_attr): Likewise.
	(dwarf2_const_value): Likewise.
	(die_type): Likewise.
	(die_containing_type): Likewise.
	(lookup_die_type): Likewise.
	(guess_full_die_structure_name): Likewise.
	(anonymous_struct_prefix): Likewise.
	(dwarf2_name): Likewise.
	(follow_die_ref_or_sig): Likewise.
	(follow_die_offset): Likewise.
	(follow_die_ref): Likewise.
	(dwarf2_fetch_die_loc_sect_off): Likewise.
	(dwarf2_fetch_constant_bytes): Likewise.
	(dwarf2_fetch_die_type_sect_off): Likewise.
	(dwarf2_get_die_type): Likewise.
	(follow_die_sig): Likewise.
	(decode_locdesc): Likewise.
	(dwarf2_per_cu_objfile): Likewise.
	(dwarf2_per_cu_text_offset): Likewise.
	(init_one_comp_unit): Assign dwarf2_per_objfile instead of
	objfile.
	(set_die_type): Access objfile through
	dwarf2_per_objfile.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove dwarf2_per_objfile global
@ 2018-01-07 19:29 sergiodj+buildbot
  2018-01-08  3:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-07 19:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ed2dc618b3d2b0be01ffdf74c4c75504b707bcf1 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: ed2dc618b3d2b0be01ffdf74c4c75504b707bcf1

Remove dwarf2_per_objfile global

This patch removes the global variable dwarf2_per_objfile.  This global
variable is set at the various entry points of dwarf2read.c (using
dw2_setup), and is referred to throughout the file.  Instead of passing
data between functions in global variables like this one, it would be
better if the functions that depend on it either received it as argument
or got it from the existing arguments they receive.  For example, a
function receiving a reference to a dwarf2_per_cu_data can access it
from dwarf2_per_cu_data::dwarf2_per_objfile.

This patch has been tested on the buildbot.

gdb/ChangeLog:

	* dwarf2read.c (struct mapped_debug_names): Add constructor.
	<dwarf2_per_objfile>: New field.
	(dwarf2_per_objfile): Remove global.
	(get_dwarf2_per_objfile): New function.
	(set_dwarf2_per_objfile): New function.
	(dwarf2_build_psymtabs_hard): Change objfile parameter to
	dwarf2_per_objfile.
	(abbrev_table_read_table): Add dwarf2_per_objfile parameter.
	(read_abbrev_offset): Likewise.
	(read_indirect_string): Likewise.
	(read_indirect_line_string): Likewise.
	(read_indirect_string_at_offset): Likewise.
	(read_indirect_string_from_dwz): Likewise.
	(dwarf2_find_containing_comp_unit): Change objfile parameter to
	dwarf2_per_objfile.
	(age_cached_comp_units): Add dwarf2_per_objfile parameter.
	(create_all_comp_units): Change objfile parameter to
	dwarf2_per_objfile.
	(create_all_type_units): Likewise.
	(process_queue): Add dwarf2_per_objfile parameter.
	(read_and_check_comp_unit_head): Likewise.
	(lookup_dwo_unit_in_dwp): Likewise.
	(get_dwp_file): Likewise.
	(process_cu_includes): Likewise.
	(struct free_dwo_file_cleanup_data): New struct.
	(dwarf2_has_info): Use get_dwarf2_per_objfile and
	set_dwarf2_per_objfile.
	(dwarf2_get_dwz_file): Add dwarf2_per_objfile parameter.
	(dw2_do_instantiate_symtab): Get dwarf2_per_objfile from
	context, adjust calls.
	(dw2_instantiate_symtab): Likewise.
	(dw2_get_cutu): Add dwarf2_per_objfile parameter.
	(dw2_get_cu): Likewise.
	(create_cu_from_index_list): Change objfile parameter to
	dwarf2_per_objfile.
	(create_cus_from_index_list): Get dwarf2_per_objfile from
	context, adjust calls.
	(create_cus_from_index): Likewise.
	(create_signatured_type_table_from_index): Change objfile
	parameter to dwarf2_per_objfile.
	(create_signatured_type_table_from_debug_names): Change objfile
	parameter to dwarf2_per_objfile.
	(create_addrmap_from_index): Likewise.
	(create_addrmap_from_aranges): Likewise.
	(dwarf2_read_index): Use get_dwarf2_per_objfile, adjust calls.
	(dw2_setup): Remove.
	(dw2_get_file_names_reader): Get dwarf2_per_objfile from
	context.
	(dw2_find_last_source_symtab): Get dwarf2_per_objfile using
	get_dwarf2_per_objfile.
	(dw2_forget_cached_source_info): Likewise.
	(dw2_map_symtabs_matching_filename): Likewise.
	(struct dw2_symtab_iterator) <index>: Remove.
	<dwarf2_per_objfile>: New field.
	(dw2_symtab_iter_init): Replace index parameter with
	dwarf2_per_objfile.
	(dw2_symtab_iter_next): Use dwarf2_per_objfile from iter.
	(dw2_lookup_symbol): Use get_dwarf2_per_objfile and adjust.
	(dw2_print_stats): Likewise.
	(dw2_dump): Likewise.
	(dw2_expand_symtabs_for_function): Likewise.
	(dw2_expand_all_symtabs): Likewise.
	(dw2_expand_symtabs_with_fullname): Likewise.
	(dw2_expand_marked_cus): Replace index and objfile parameters
	with dwarf2_per_objfile.
	(dw_expand_symtabs_matching_file_matcher): Add
	dwarf2_per_objfile parameter and adjust calls.
	(dw2_expand_symtabs_matching): Use get_dwarf2_per_objfile and
	adjust calls.
	(dw2_find_pc_sect_compunit_symtab): Don't call dw2_setup.
	(dw2_map_symbol_filenames): Use get_dwarf2_per_objfile and
	adjust calls.
	(create_cus_from_debug_names_list): Replace objfile parameter
	with dwarf2_per_objfile and adjust calls.
	(create_cus_from_debug_names): Likewise.
	(dwarf2_read_debug_names): Likewise.
	(mapped_debug_names::namei_to_name): Adjust call.
	(dw2_debug_names_iterator::next): Likewise.
	(dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
	(dw2_debug_names_lookup_symbol): Use get_dwarf2_per_objfile.
	(dw2_debug_names_dump): Likewise.
	(dw2_debug_names_expand_symtabs_for_function): Likewise.
	(dw2_debug_names_expand_symtabs_matching): Likewise.
	(dwarf2_initialize_objfile): Likewise.
	(dwarf2_build_psymtabs): Likewise.
	(get_abbrev_section_for_cu): Get dwarf2_per_objfile from
	this_cu.
	(error_check_comp_unit_head): Add dwarf2_per_objfile parameter.
	(read_and_check_comp_unit_head): Likewise.
	(read_abbrev_offset): Likewise.
	(create_debug_type_hash_table): Likewise.
	(create_debug_types_hash_table): Likewise.
	(create_all_type_units): Replace objfile parameter with
	dwarf2_per_objfile.
	(add_type_unit): Add dwarf2_per_objfile parameter.
	(fill_in_sig_entry_from_dwo_entry): Replace objfile parameter
	with dwarf2_per_objfile.
	(lookup_dwo_signatured_type): Get dwarf2_per_objfile from cu.
	(lookup_dwp_signatured_type): Likewise.
	(lookup_signatured_type): Likewise.
	(read_cutu_die_from_dwo): Likewise.
	(init_tu_and_read_dwo_dies): Likewise.
	(init_cutu_and_read_dies): Likewise.
	(init_cutu_and_read_dies_no_follow): Likewise.
	(allocate_type_unit_groups_table): Add objfile parameter.
	(create_type_unit_group): Use dwarf2_per_objfile from cu.
	(get_type_unit_group): Likewise.
	(process_psymtab_comp_unit): Update call.
	(build_type_psymtabs_reader): Use dwarf2_per_objfile from cu.
	(build_type_psymtabs_1): Add dwarf2_per_objfile parameter.
	(print_tu_stats): Likewise.
	(build_type_psymtab_dependencies): Use dwarf2_per_objfile passed
	in void* parameter.
	(build_type_psymtabs): Change objfile parameter to
	dwarf2_per_objfile.
	(process_skeletonless_type_unit): Use dwarf2_per_objfile
	passed in void* parameter.
	(process_skeletonless_type_units): Change objfile parameter to
	dwarf2_per_objfile.
	(set_partial_user): Likewise.
	(dwarf2_build_psymtabs_hard): Likewise.
	(read_comp_units_from_section): Likewise.
	(create_all_comp_units): Likewise.
	(scan_partial_symbols): Update calls.
	(add_partial_symbol): Likewise.
	(dwarf2_read_symtab): Use get_dwarf2_per_objfile.
	(maybe_queue_comp_unit): Use dwarf2_read_symtab from cu.
	(process_queue): Add dwarf2_per_objfile parameter.
	(get_compunit_symtab): Use dwarf2_per_objfile from cu.
	(compute_compunit_symtab_includes): Likewise.
	(process_cu_includes): Add dwarf2_per_objfile parameter.
	(process_full_comp_unit): Use dwarf2_per_objfile from cu.
	(process_full_type_unit): Likewise.
	(process_imported_unit_die): Update call.
	(handle_DW_AT_stmt_list): Use dwarf2_per_objfile from cu.
	(read_file_scope): Likewise.
	(allocate_dwo_file_hash_table): Add objfile parameter.
	(lookup_dwo_file_slot): Add dwarf2_per_objfile parameter.
	(create_cus_hash_table): Likewise.
	(create_dwp_hash_table): Likewise.
	(create_dwo_unit_in_dwp_v1): Likewise.
	(create_dwp_v2_section): Likewise.
	(create_dwo_unit_in_dwp_v2): Likewise.
	(lookup_dwo_unit_in_dwp): Likewise.
	(try_open_dwop_file): Likewise.
	(open_dwo_file): Likewise. Use dwarf2_per_objfile from cu.
	(open_and_init_dwo_file): Use dwarf2_per_objfile from cu, update
	cleanup to include a reference to dwarf2_per_objfile.
	(open_dwp_file): Add dwarf2_per_objfile parameter.
	(open_and_init_dwp_file): Likewise.
	(get_dwp_file): Likewise.
	(lookup_dwo_cutu): Use dwarf2_per_objfile from cu.
	(queue_and_load_all_dwo_tus): Update call.
	(free_dwo_file_cleanup): Use dwarf2_per_objfile from cleanup
	data.
	(dwarf2_rnglists_process): Use dwarf2_per_objfile from cu.
	(dwarf2_ranges_process): Likewise.
	(dwarf2_get_pc_bounds): Likewise.
	(mark_common_block_symbol_computed): Likewise.
	(abbrev_table_read_table): Add dwarf2_per_objfile parameter.
	(dwarf2_read_abbrevs): Update call.
	(read_partial_die): Use dwarf2_per_objfile from cu.
	(find_partial_die): Likewise.
	(fixup_partial_die): Likewise.
	(read_attribute_value): Likewise.
	(read_indirect_string_at_offset_from): Add objfile parameter.
	(read_indirect_string_at_offset): Add dwarf2_per_objfile
	parameter.
	(read_indirect_string_from_dwz): Add objfile parameter.
	(read_indirect_string): Add objfile parameter.
	(read_addr_index_1): Add dwarf2_per_objfile parameter.
	(read_addr_index): Use dwarf2_per_objfile from cu.
	(dwarf2_read_addr_index): Use dwarf2_per_objfile from cu, don't
	call dw2_setup.
	(read_str_index): Use dwarf2_per_objfile from cu.
	(get_debug_line_section): Likewise.
	(read_formatted_entries): Add dwarf2_per_objfile parameter.
	(dwarf_decode_line_header): Use dwarf2_per_objfile from cu.
	(new_symbol_full): Use dwarf2_per_objfile from cu.
	(build_error_marker_type): Likewise.
	(lookup_die_type): Likewise.
	(determine_prefix): Likewise.
	(follow_die_offset): Likewise.
	(dwarf2_fetch_die_loc_sect_off): Use get_dwarf2_per_objfile.
	(dwarf2_fetch_constant_bytes): Don't call dw2_setup.
	(dwarf2_fetch_die_type_sect_off): Likewise.
	(dwarf2_get_die_type): Likewise.
	(follow_die_sig_1): Use dwarf2_per_objfile from cu.
	(get_signatured_type): Likewise.
	(get_DW_AT_signature_type): Likewise.
	(dwarf_decode_macro_bytes): Add dwarf2_per_objfile parameter.
	(dwarf_decode_macros): Use dwarf2_per_objfile from cu.
	(cu_debug_loc_section): Likewise.
	(fill_in_loclist_baton): Likewise.
	(dwarf2_symbol_mark_computed): Likewise.
	(dwarf2_find_containing_comp_unit): Change objfile parameter to
	dwarf2_per_objfile.
	(free_cached_comp_units): Use dwarf2_per_objfile passed in void*
	parameter.
	(age_cached_comp_units): Add dwarf2_per_objfile parameter.
	(free_one_cached_comp_unit): Use dwarf2_per_objfile from cu.
	(dwarf2_free_objfile): Use get_dwarf2_per_objfile.
	(set_die_type): Use dwarf2_free_objfile from cu.
	(get_die_type_at_offset): Likewise.
	(dwarf2_per_objfile_free): Don't assign global variable.
	(debug_names) <constructor>: Add dwarf2_per_objfile
	parameter, update m_debugstrlookup construction.
	(debug_names::debug_str_lookup): Add dwarf2_per_objfile
	parameter.
	<m_dwarf2_per_objfile>: New field.
	<lookup>: Use m_dwarf2_per_objfile.
	(check_dwarf64_offsets): Add dwarf2_per_objfile parameter.
	(psyms_seen_size): Likewise.
	(write_gdbindex): Replace objfile parameter with
	dwarf2_per_objfile.
	(write_debug_names): Likewise.
	(write_psymtabs_to_index): Likewise.
	(save_gdb_index_command): Use get_dwarf2_per_objfile, update
	calls.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove dwarf2_cu::dwarf2_per_objfile
@ 2018-01-07 20:11 sergiodj+buildbot
  2018-01-08  5:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-07 20:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 518817b361167ac91e7cdad8528b4d90cdc3fb26 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 518817b361167ac91e7cdad8528b4d90cdc3fb26

Remove dwarf2_cu::dwarf2_per_objfile

This patch removes the dwarf2_per_objfile field of dwarf2_cu.  It is
redundant, since we can access dwarf2_per_objfile through
dwarf2_per_objfile, which is guaranteed to be set.

gdb/ChangeLog:

	* dwarf2read.c (struct dwarf2_cu) <dwarf2_per_objfile>: Remove.
	(dw2_get_file_names_reader): Adjust.
	(lookup_dwo_signatured_type): Adjust.
	(lookup_dwp_signatured_type): Adjust.
	(lookup_signatured_type): Adjust.
	(create_type_unit_group): Adjust.
	(get_type_unit_group): Adjust.
	(process_psymtab_comp_unit_reader): Adjust.
	(build_type_psymtabs_reader): Adjust.
	(scan_partial_symbols): Adjust.
	(add_partial_symbol): Adjust.
	(add_partial_subprogram): Adjust.
	(peek_die_abbrev): Adjust.
	(fixup_go_packaging): Adjust.
	(process_imported_unit_die): Adjust.
	(dwarf2_compute_name): Adjust.
	(dwarf2_physname): Adjust.
	(read_import_statement): Adjust.
	(handle_DW_AT_stmt_list): Adjust.
	(read_file_scope): Adjust.
	(read_func_scope): Adjust.
	(read_lexical_block_scope): Adjust.
	(read_call_site_scope): Adjust.
	(read_variable): Adjust.
	(dwarf2_rnglists_process): Adjust.
	(dwarf2_ranges_process): Adjust.
	(dwarf2_ranges_read): Adjust.
	(dwarf2_get_pc_bounds): Adjust.
	(dwarf2_record_block_ranges): Adjust.
	(dwarf2_add_field): Adjust.
	(dwarf2_add_member_fn): Adjust.
	(read_structure_type): Adjust.
	(process_structure_scope): Adjust.
	(read_enumeration_type): Adjust.
	(read_array_type): Adjust.
	(mark_common_block_symbol_computed): Adjust.
	(read_common_block): Adjust.
	(read_namespace_type): Adjust.
	(read_namespace): Adjust.
	(read_module_type): Adjust.
	(read_tag_pointer_type): Adjust.
	(read_tag_ptr_to_member_type): Adjust.
	(read_tag_string_type): Adjust.
	(read_subroutine_type): Adjust.
	(read_typedef): Adjust.
	(read_base_type): Adjust.
	(attr_to_dynamic_prop): Adjust.
	(read_subrange_type): Adjust.
	(read_unspecified_type): Adjust.
	(dwarf2_read_abbrevs): Adjust.
	(load_partial_dies): Adjust.
	(read_partial_die): Adjust.
	(find_partial_die): Adjust.
	(guess_partial_die_structure_name): Adjust.
	(fixup_partial_die): Adjust.
	(read_attribute_value): Adjust.
	(read_addr_index): Adjust.
	(read_addr_index_from_leb128): Adjust.
	(read_str_index): Adjust.
	(dwarf2_string_attr): Adjust.
	(get_debug_line_section): Adjust.
	(dwarf_decode_line_header): Adjust.
	(lnp_state_machine::check_line_address): Adjust.
	(dwarf_decode_lines_1): Adjust.
	(dwarf_decode_lines): Adjust.
	(dwarf2_start_symtab): Adjust.
	(var_decode_location): Adjust.
	(new_symbol_full): Adjust.
	(dwarf2_const_value_data): Adjust.
	(dwarf2_const_value_attr): Adjust.
	(dwarf2_const_value): Adjust.
	(die_type): Adjust.
	(die_containing_type): Adjust.
	(build_error_marker_type): Adjust.
	(lookup_die_type): Adjust.
	(guess_full_die_structure_name): Adjust.
	(anonymous_struct_prefix): Adjust.
	(determine_prefix): Adjust.
	(dwarf2_name): Adjust.
	(follow_die_ref_or_sig): Adjust.
	(follow_die_offset): Adjust.
	(follow_die_ref): Adjust.
	(follow_die_sig_1): Adjust.
	(follow_die_sig): Adjust.
	(get_signatured_type): Adjust.
	(get_DW_AT_signature_type): Adjust.
	(decode_locdesc): Adjust.
	(dwarf_decode_macros): Adjust.
	(cu_debug_loc_section): Adjust.
	(fill_in_loclist_baton): Adjust.
	(dwarf2_symbol_mark_computed): Adjust.
	(init_one_comp_unit): Don't assign
	dwarf2_cu::dwarf2_per_objfile.
	(set_die_type): Adjust.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] (Ada) Fix print of array using non-contiguous enumeration indexes
@ 2018-01-08  5:16 sergiodj+buildbot
  2018-01-08  6:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-08  5:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 04bafb1ed002df1f25ca5a5773d87723a4baf46b ***

Author: Xavier Roirand <roirand@adacore.com>
Branch: master
Commit: 04bafb1ed002df1f25ca5a5773d87723a4baf46b

(Ada) Fix print of array using non-contiguous enumeration indexes

Consider the following code:

  type Index is (Index1, Index2);
  Size : constant Integer := 10;
  for Index use (Index1 => 1, Index2 => Size);
  type Array_Index_Enum is array (Index) of Integer;
  my_table : Array_Index_Enum :=(others => 42);

When compiling the code above with a compiler where the GNAT encodings
are turned off (which can be temporarily emulated by using the compiler
switch -fgnat-encodings=minimal), printing this table in gdb leads to:

  (gdb) p my_table
  $1 = (42, 42, 4203344, 10, -8320, 32767, 4203465, 0, 0, 0)

The displayed content is wrong since the handling part believes
that the length of the array is max index value (10) minus the
first index value (1) i+ 1 = 10 which is wrong since index are not
contiguous in this case.

The right behavior is to detect that the array is using enumeration
index hence parse the enumeration values in order to get the number
of indexes in this array (2 indexes here).

This patch fixes this issue and changes the output as follow:

  (gdb) p my_table
  $1 = (42, 42)

gdb/ChangeLog:

        * ada-valprint.c (val_print_packed_array_elements): Use
        proper number of elements when printing an array indexed
        by an enumeration type.

gdb/testsuite/ChangeLog (Joel Brobecker  <brobecker@adacore.com>):

        * gdb.ada/arr_enum_idx_w_gap.exp
        * gdb.ada/arr_enum_idx_w_gap/foo_q418_043.adb

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Relax expected output in gdb.ada/access_tagged_param.exp test
@ 2018-01-08 10:02 sergiodj+buildbot
  2018-01-08 10:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-08 10:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 30066b0b00a2c09baed08e49437c2ae3c44bc4e0 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 30066b0b00a2c09baed08e49437c2ae3c44bc4e0

Relax expected output in gdb.ada/access_tagged_param.exp test

One of the tests in gdb.ada/access_tagged_param.exp verifies
the value of the parameters being printed by GDB when stopping
at a breakpoint inside procedure Pck.Inspect.

In particular, one of these parameters is actually generated
internally by the compiler, and does only indirectly depend
on the user-level code. A recent change in AdaCore's compiler
caused the code expansion to change a little bit, and as a result,
the value of that parameter has changed from 2 to 3. This can be
evindenced by looking at the code post expansion, using the -gnatDG
command-line switch to generate the .dg files:

    $ gnatmake -g -gnatDG foo.adb
    $ vi foo.adb.dg

We can see that the call to pck.inspect used to be:

    pck__inspect (P8b, objL => 2);

With a recent version of GNAT Pro, it is now:

    pck__inspect (P9b, objL => 3);

This change causes a spurious FAIL when running this testcase.
The objL parameter being, at heart, a simple counter of the nesting
level, this commit relaxes the expected output to accept any single-
digit number. We could accept any decimal, but given the example
program, I dout that number will reach double-digit level. If it
does, we'll double-check that this is normal, and relax the expected
output further.

gdb/testsuite/ChangeLog:

        * gdb.ada/access_tagged_param.exp: Relax expected output
        for value of "ObjL" in "continue" to pck.inspect breakpoint
        test.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix GDB build failure when $development is false
@ 2018-01-08 10:42 sergiodj+buildbot
  2018-01-08 12:54 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-08 10:42 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1e5ded6ce688ddee065fa852053dda07fcce959e ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 1e5ded6ce688ddee065fa852053dda07fcce959e

Fix GDB build failure when $development is false

We don't build GDB selftests bits when $development is false.  However, if
we turn bfd/development.sh:$development to false, common/selftest.c is
compiled which is not expected.  It causes the build failure,

selftest.o: In function `selftests::run_tests(char const*)':
binutils-gdb/gdb/common/selftest.c:97: undefined reference to `selftests::reset()'
collect2: error: ld returned 1 exit status

I fix this issue by putting selftest.o selftest-arch.o into CONFIG_OBS
only when $development is true.  After this is fixed, there are other
build failures in maint.c, this patch fixes them as well.

In the release mode, the output of these commands are:

(gdb) maintenance selftest
Selftests are not available in a non-development build.
(gdb) maintenance selftest foo
Selftests are not available in a non-development build.
(gdb) maintenance info selftests
Selftests are not available in a non-development build.

gdb:

2018-01-08  Yao Qi  <yao.qi@linaro.org>
	    Simon Marchi  <simon.marchi@ericsson.com>

	* Makefile.in (COMMON_SFILES): Remove selftest-arch.c and
	common/selftest.c.
	(COMMON_OBS): Remove selftest.o.
	* configure.ac: Append selftest-arch.c and common/selftest.c to
	CONFIG_SRCS.  Append selftest-arch.o and selftest.o to COMMON_OBS.
	* configure: Re-generated.
	* maint.c (maintenance_selftest): Wrap selftests::run_tests with
	GDB_SELF_TEST.
	(maintenance_info_selftests): Likewise.

gdb/testsuite:

2018-01-08  Simon Marchi  <simon.marchi@ericsson.com>

	* gdb.gdb/unittest.exp: Match output in non-development mode.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix GDBserver build failure when $development is false
@ 2018-01-08 11:41 sergiodj+buildbot
  2018-01-08 14:38 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-08 11:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 605fd3c6590fbed834107a2e1d1df0ba58834576 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 605fd3c6590fbed834107a2e1d1df0ba58834576

Fix GDBserver build failure when $development is false

When we set bfd/development.sh:$development to false, GDBserver failed to
build,

selftest.o: In function `selftests::run_tests(char const*)':
binutils-gdb/gdb/gdbserver/../common/selftest.c:97:undefined reference to `selftests::reset()'
collect2: error: ld returned 1 exit status

selftest.o shouldn't be compiled and linked when $development is false.
With this patch, in release mode, GDBserver doesn't nothing with option
--selftest,

$ ./gdbserver --selftest=foo
Selftests are not available in a non-development build.
$ ./gdbserver --selftest
Selftests are not available in a non-development build.

gdb/gdbserver:

2018-01-08  Yao Qi  <yao.qi@linaro.org>
	    Simon Marchi  <simon.marchi@ericsson.com>

	* Makefile.in (OBS): Remove selftest.o.
	* configure.ac: Set srv_selftest_objs if $development is true.
	(GDBSERVER_DEPFILES): Append $srv_selftest_objs.
	* configure: Re-generated.
	* server.c (captured_main): Wrap variable selftest_filter with
	GDB_SELF_TEST.

gdb/testsuite:

2018-01-08  Simon Marchi  <simon.marchi@ericsson.com>

	* gdb.server/unittest.exp: Match the output in non-development
	mode.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: Properly encode vmovd with 64-bit memeory
@ 2018-01-08 13:11 sergiodj+buildbot
  2018-01-08 19:42 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-08 13:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 704a705d7aaab8041df76e2981e2a1efc014aad0 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 704a705d7aaab8041df76e2981e2a1efc014aad0

x86: Properly encode vmovd with 64-bit memeory

For historical reason, we allow movd/vmovd with 64-bit register and
memeory operands.  But for vmovd, we failed to handle 64-bit memeory
operand.  This has been gone unnoticed since AT&T syntax always treats
memory operand as 32-bit memory.  This patch properly encodes vmovd
with 64-bit memeory operands.  It also removes AVX512 vmovd with 64-bit
operands since GCC has

    case TYPE_SSEMOV:
      switch (get_attr_mode (insn))
        {
        case MODE_DI:
          /* Handle broken assemblers that require movd instead of movq.  */
          if (!HAVE_AS_IX86_INTERUNIT_MOVQ
              && (GENERAL_REG_P (operands[0]) || GENERAL_REG_P (operands[1])))
            return "%vmovd\t{%1, %0|%0, %1}";
          return "%vmovq\t{%1, %0|%0, %1}";

and all AVX512 GNU assemblers set HAVE_AS_IX86_INTERUNIT_MOVQ, GCC won't
generate AVX512 vmovd with 64-bit operand.

gas/

	PR gas/22681
	* testsuite/gas/i386/i386.exp: Run x86-64-movd and
	x86-64-movd-intel.
	* testsuite/gas/i386/x86-64-movd-intel.d: New file.
	* testsuite/gas/i386/x86-64-movd.d: Likewise.
	* testsuite/gas/i386/x86-64-movd.s: Likewise.

opcodes/

	PR gas/22681
	* i386-opc.tbl: Properly encode vmovd with Qword memeory operand.
	Remove AVX512 vmovd with 64-bit operands.
	* i386-tbl.h: Regenerated.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] hurd: Add enough auxv support for AT_ENTRY for PIE binaries
@ 2018-01-08 16:52 sergiodj+buildbot
  2018-01-09  0:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-08 16:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9c4ac400f0f7d8daa8483dbe73b5699782ae3e22 ***

Author: Samuel Thibault <samuel.thibault@ens-lyon.org>
Branch: master
Commit: 9c4ac400f0f7d8daa8483dbe73b5699782ae3e22

hurd: Add enough auxv support for AT_ENTRY for PIE binaries

Add PIE support for hurd, by faking an AT_ENTRY auxv entry.  That value
is expected to be read by svr4_exec_displacement, which will propagate
the executable displacement.

gdb/ChangeLog:

	* gdb/gnu-nat.c: Include <elf.h> and <link.h>.
	(gnu_xfer_auxv): New function.
	(gnu_xfer_partial): Call gnu_xfer_auxv when `object' is
	TARGET_OBJECT_AUXV.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PR22662, nds32: Fix a typographical error.
@ 2018-01-09  9:16 sergiodj+buildbot
  2018-01-09  9:45 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-09  9:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6cef73f96f58ca3f0e0b2f594b324602c7590611 ***

Author: Kuan-Lin Chen <kuanlinchentw@gmail.com>
Branch: master
Commit: 6cef73f96f58ca3f0e0b2f594b324602c7590611

PR22662, nds32: Fix a typographical error.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix breakpoint add on inlined function using function name.
@ 2018-01-09 10:03 sergiodj+buildbot
  2018-01-09 13:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-09 10:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b1dc1806fad00fc5b2589164e964646c02a700fa ***

Author: Xavier Roirand <roirand@adacore.com>
Branch: master
Commit: b1dc1806fad00fc5b2589164e964646c02a700fa

Fix breakpoint add on inlined function using function name.

Using this Ada example:

  package B is
    procedure Read_Small with Inline_Always;
  end B;

  package body B is
    Total : Natural := 0;
    procedure Read_Small is
    begin
      Total := Total + 1;
    end Read_Small;
  end B;

and

  with B;

  procedure M is
  begin
    B.Read_Small;
  end M;

% gnatmake -g -O0 -m m.adb -cargs -gnatn
% gdb m

Inserting a breakpoint on Read_Small inlined function does not work:

(gdb) b read_small
Breakpoint 1 at 0x40250e: file b.adb, line 5.
(gdb) info b
Num     Type           Disp Enb Address            What
1       breakpoint     keep y   0x000000000040250e in b.doit at b.adb:5
(gdb)

In this exemple we should have two breakpoints set, one in package B and
the other one in the inlined instance inside procedure M), like below:

(gdb) b read_small
Breakpoint 1 at 0x40250e: b.adb:5. (2 locations)
(gdb) info b
Num     Type           Disp Enb Address            What
1       breakpoint     keep y   <MULTIPLE>
1.1                         y     0x000000000040250e in b.doit at b.adb:5
1.2                         y     0x0000000000402540 in m at b.adb:5
(gdb)

Looking at the DWARF info for inlined instance of Read_Small:

<1><1526>: Abbrev Number: 2 (DW_TAG_subprogram)
    <1527>   DW_AT_name        : ([...], offset: 0x1e82): b__read_small
    <152b>   DW_AT_decl_file   : 2
    <152c>   DW_AT_decl_line   : 3
    <152d>   DW_AT_inline      : 3      (declared as inline and inlined)
[...]
 <2><1547>: Abbrev Number: 4 (DW_TAG_inlined_subroutine)
    <1548>   DW_AT_abstract_origin: <0x1526>
    <154c>   DW_AT_low_pc      : 0x402552
    <1554>   DW_AT_high_pc     : 0x2b
    <155c>   DW_AT_call_file   : 1
    <155d>   DW_AT_call_line   : 5
 <2><155e>: Abbrev Number: 0

During the parsing of DWARF info in order to produce partial DIE linked
list, the DW_TAG_inlined_subroutine were skipped thus not present in the
final partial dies.
Taking DW_TAG_inlined_subroutine in account during the parsing process
fixes the problem.

gdb/ChangeLog:

        * dwarf2read.c (scan_partial_symbols, add_partial_symbol)
        (add_partial_subprogram, load_partial_dies): Add
        DW_TAG_inlined_subroutine handling.

gdb/testsuite/ChangeLog:

        * gdb.ada/bp_inlined_func: New testcase.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add support for the AArch64's CSDB instruction.
@ 2018-01-09 11:49 sergiodj+buildbot
  2018-01-09 14:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-09 11:49 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT be2e7d95414eb78f29312f30e62d4cabd55f9fda ***

Author: James Greenhalgh <james.greenhalgh@arm.com>
Branch: master
Commit: be2e7d95414eb78f29312f30e62d4cabd55f9fda

Add support for the AArch64's CSDB instruction.

CSDB is a new instruction which Arm has defined. It has the same encoding as
HINT #0x14 and is available at all architecture levels.

opcodes	* aarch64-tbl.h (aarch64_opcode_table): Add "csdb".
	* aarch64-asm-2.c: Regenerate.
	* aarch64-dis-2.c: Regenerate.
	* aarch64-opc-2.c: Regenerate.

gas	* testsuite/gas/aarch64/system.d: Update expected results to expect
	CSDB.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [Arm] Add CSDB instruction
@ 2018-01-09 14:53 sergiodj+buildbot
  2018-01-09 17:05 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-09 14:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 91d8b670661883fc0472fd05cf0e54d0e357c187 ***

Author: James Greenhalgh <james.greenhalgh@arm.com>
Branch: master
Commit: 91d8b670661883fc0472fd05cf0e54d0e357c187

[Arm] Add CSDB instruction

CSDB is a new instruction which Arm has defined. As it shares the
encoding space with NOP instructions, it is available from Armv3 in
Arm mode, and Armv6T2 in Thumb mode.

OK? If so, please commit on my behalf as I don't have commit rights
over here.

Thanks, James

---
opcodes/

2018-01-09  James Greenhalgh  <james.greenhalgh@arm.com>

	* arm-dis.c (arm_opcodes): Add csdb.
	(thumb32_opcodes): Add csdb.

gas/

2018-01-09  James Greenhalgh  <james.greenhalgh@arm.com>

	* config/tc-arm.c (insns): Add csdb, enable for Armv3 and above
	in Arm execution state, and Armv6T2 and above in Thumb execution
	state.
	* testsuite/gas/arm/csdb.s: New.
	* testsuite/gas/arm/csdb.d: New.
	* testsuite/gas/arm/thumb2_it_bad.l: Add csdb.
	* testsuite/gas/arm/thumb2_it_bad.s: Add csdb.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Support 'info proc' for FreeBSD process core dumps.
@ 2018-01-09 22:14 sergiodj+buildbot
  2018-01-09 22:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-09 22:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d2176225dc982c22640215a0e611e997e8eeb030 ***

Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: d2176225dc982c22640215a0e611e997e8eeb030

Support 'info proc' for FreeBSD process core dumps.

- Command line arguments are obtained from the pr_psargs[] array
  saved in the NT_PRPSINFO note.
- The 'cwd' and 'exe' values are obtained from the per-process file
  descriptor table stored in the NT_PROCSTAT_FILES core note.
- 'mappings' is implemented by walking the array of VM map entries
  stored in the NT_PROCSTAT_VMMAP core note.
- 'status' output is generated by outputting fields from
  the first structure stored in the NT_PROCSTAT_PROC core note.
- 'stat' is aliased to 'status'.

gdb/ChangeLog:

	* fbsd-tdep.c (KVE_STRUCTSIZE, KVE_START, KVE_END, KVE_OFFSET)
	(KVE_FLAGS, KVE_PROTECTION, KVE_PATH, KINFO_VME_PROT_READ)
	(KINFO_VME_PROT_WRITE, KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
	(KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
	(KINFO_VME_FLAG_SUPER, KINFO_VME_FLAG_GROWS_UP)
	(KINFO_VME_FLAG_GROWS_DOWN, KF_STRUCTSIZE, KF_TYPE, KF_FD)
	(KF_PATH, KINFO_FILE_TYPE_VNODE, KINFO_FILE_FD_TYPE_CWD)
	(KINFO_FILE_FD_TYPE_TEXT, SIG_WORDS, struct kinfo_proc_layout)
	(kinfo_proc_layout_32, kinfo_proc_layout_i386)
	(kinfo_proc_layout_64, fbsd_vm_map_entry_flags)
	(fbsd_core_info_proc_mappings, fbsd_core_vnode_path)
	(fbsd_core_fetch_timeval, fbsd_print_sigset)
	(fbsd_core_info_proc_status, fbsd_core_info_proc): New.
	(fbsd_init_abi):  Install gdbarch "core_info_proc" method.
	* fbsd-tdep.h (fbsd_vm_map_entry_flags): New.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Don't return stale data from fbsd_pid_to_exec_file for kernel processes.
@ 2018-01-09 23:03 sergiodj+buildbot
  2018-01-10  0:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-09 23:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b999e2038dbc54e2c8b1c390f8b8fe50d0f1d10a ***

Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: b999e2038dbc54e2c8b1c390f8b8fe50d0f1d10a

Don't return stale data from fbsd_pid_to_exec_file for kernel processes.

For processes without an associated executable (such as kernel processes),
the kern.proc.pathname.<pid> system control node returns a length of zero
without modifying the user's buffer.  Detect this case and return NULL
rather than the previous contents of the static buffer 'buf'.

gdb/ChangeLog:

	* fbsd-nat.c (fbsd_pid_to_exec_file) [KERN_PROC_PATHNAME]: Return
	NULL for an empty pathname.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use gdb::unique_xmalloc_ptr<> instead of a deleter that invokes free().
@ 2018-01-09 23:38 sergiodj+buildbot
  2018-01-10  3:42 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-09 23:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 262f62f57d987269152412a55c458a03adc6ddd6 ***

Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: 262f62f57d987269152412a55c458a03adc6ddd6

Use gdb::unique_xmalloc_ptr<> instead of a deleter that invokes free().

Since xfree() always wraps free(), it is safe to use the xfree deleter
for buffers allocated by library routines such as kinfo_getvmmap() that
must be released via free().

gdb/ChangeLog:

	* fbsd-nat.c (struct free_deleter): Remove.
	(fbsd_find_memory_regions): Use gdb::unique_xmalloc_ptr<>.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Support 'info proc' for native FreeBSD processes.
@ 2018-01-10  0:28 sergiodj+buildbot
  2018-01-10  6:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-10  0:28 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 92fce24de299a8b9a9a1c0c6b98e0e9c1656f99c ***

Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: 92fce24de299a8b9a9a1c0c6b98e0e9c1656f99c

Support 'info proc' for native FreeBSD processes.

- Command line arguments are fetched via the kern.proc.args.<pid>
  sysctl.
- The 'cwd' and 'exe' values are obtained from the per-process
  file descriptor table returned by kinfo_getfile() from libutil.
- 'mappings' is implemented by walking the array of VM map entries
  returned by kinfo_getvmmap() from libutil.
- 'status' output is generated by outputting fields from the structure
  returned by the kern.proc.pid.<pid> sysctl.
- 'stat' is aliased to 'status'.

gdb/ChangeLog:

	* configure.ac: Check for kinfo_getfile in libutil.
	* configure: Regenerate.
	* config.in: Regenerate.
	* fbsd-nat.c: Include "fbsd-tdep.h".
	(fbsd_fetch_cmdline): New.
	(fbsd_fetch_kinfo_proc): Move earlier and change to return a bool
	rather than calling error.
	(fbsd_info_proc): New.
	(fbsd_thread_name): Report error if fbsd_fetch_kinfo_proc fails.
	(fbsd_wait): Report warning if fbsd_fetch_kinfo_proc fails.
	(fbsd_nat_add_target): Set "to_info_proc" to "fbsd_info_proc".


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Document support for 'info proc' on FreeBSD.
@ 2018-01-10  1:01 sergiodj+buildbot
  2018-01-10  8:34 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-10  1:01 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2d97a5d9d33aea87c3bd02fd1fa417f5d4e1fa05 ***

Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: 2d97a5d9d33aea87c3bd02fd1fa417f5d4e1fa05

Document support for 'info proc' on FreeBSD.

Since the 'info proc' support on FreeBSD does not use /proc, reword
the documentation for 'info proc' to not assume /proc.  This includes
renaming the node to 'Process Information' and suggesting that
additional process information can be queried via different
OS-specific interfaces.  This is also cleans up the description of
'info proc' support for core files a bit as /proc is not used for core
file support on any current platform.

gdb/ChangeLog:

	* NEWS: Document that 'info proc' now works on FreeBSD.

gdb/doc/ChangeLog:

	* gdb.texinfo (pwd): Update cross-reference for Process Information
	node and remove explicit /proc reference.
	(Native): Rename subsection from SVR4 Process Information to
	Process Information.
	(Process Information): Reword introduction to be less /proc
	centric.  Document support for "info proc" on FreeBSD.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] RISC-V: Disassemble x0 based addresses as 0.
@ 2018-01-10  2:16 sergiodj+buildbot
  2018-01-10 10:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-10  2:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 35fd2b2bcf370837a03f077acf1222f0a7e9c4d1 ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 35fd2b2bcf370837a03f077acf1222f0a7e9c4d1

RISC-V: Disassemble x0 based addresses as 0.

	gas/
	* testsuite/gas/riscv/auipc-x0.d: New.
	* testsuite/gas/riscv/auipc-x0.s: New.

	opcodes/
	* riscv-dis.c (maybe_print_address): If base_reg is zero,
	then the hi_addr value is zero.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: fix Disp8 handling for AVX512VL VPCMP*{B, W} variants
@ 2018-01-10 14:11 sergiodj+buildbot
  2018-01-10 14:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-10 14:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c9e9227878d172d93bcbef51dfc76d96f027751d ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: c9e9227878d172d93bcbef51dfc76d96f027751d

x86: fix Disp8 handling for AVX512VL VPCMP*{B,W} variants

In commit 2645e1d079 ("x86: add support for AVX-512 VPCMP*{B,W}
pseudo-ops") I screwed up the Disp8MemShift values of the AVX512VL
variants.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: fix Disp8 handling for scalar AVX512_4FMAPS insns
@ 2018-01-10 14:58 sergiodj+buildbot
  2018-01-10 17:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-10 14:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cbda583ada32e16bf8b6c6aff730cc9eab63b364 ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: cbda583ada32e16bf8b6c6aff730cc9eab63b364

x86: fix Disp8 handling for scalar AVX512_4FMAPS insns

Just like their packed counterparts the memory operand is always 16
bytes wide, and the Disp8 scaling is the same for all of them. (As a
side note: I'm also surprised by there being AVX512VL variants of
these as well as the AVX512_4VNNIW ones - the SDM doesn't define any
such.)

Adjust the test cases also for the packed forms to actually live up to
their promise of testing correct Disp8 encoding.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Update the libiberty sources with the latest patches found in the master sources.
@ 2018-01-10 15:48 sergiodj+buildbot
  2018-01-10 20:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-10 15:48 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2a8ae7146cacb006105e2e9c6f4635aca543e7ec ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 2a8ae7146cacb006105e2e9c6f4635aca543e7ec

Update the libiberty sources with the latest patches found in the master sources.

2017-01-02  Richard Biener  <rguenther@suse.de>

	PR lto/83452
	* simple-object-elf.c (simple_object_elf_copy_lto_debug_section):
	Do not use UNDEF locals for removed symbols but instead just
	define them in the first prevailing section and with no name.
	Use the same gnu_lto_v1 name for all removed globals we promote to
	WEAK UNDEFs so hpux can use a stub to provide this symbol.  Clear
	sh_info and sh_link in removed sections.

2017-10-30  Richard Biener  <rguenther@suse.de>

	PR lto/82757
	* simple-object-elf.c (simple_object_elf_copy_lto_debug_sections):
	Strip two leading _s from the __gnu_lto_* symbols.

2017-10-24  Alan Modra  <amodra@gmail.com>

	PR lto/82687
	PR lto/82575
	* simple-object-elf.c (simple_object_elf_copy_lto_debug_sections):
	Only make __gnu_lto symbols hidden.

2017-10-20  Alan Modra  <amodra@gmail.com>

	PR lto/82575
	* simple-object-elf.c (simple_object_elf_copy_lto_debug_sections):
	Make discarded non-local symbols weak and hidden.

2017-10-18  Jakub Jelinek  <jakub@redhat.com>

	PR lto/82598
	* simple-object.c (handle_lto_debug_sections): Copy over also
	.note.GNU-stack section with unchanged name.
	* simple-object-elf.c (SHF_EXECINSTR): Define.
	(simple_object_elf_copy_lto_debug_section): Drop SHF_EXECINSTR bit
	on .note.GNU-stack section.

2017-09-25  Nathan Sidwell  <nathan@acm.org>

	PR demangler/82195
	* cp-demangle.c (d_encoding): Strip return type when name is a
	LOCAL_NAME.
	(d_local_name): Strip return type of enclosing TYPED_NAME.
	* testsuite/demangle-expected: Add and adjust tests.

2017-09-21  Nathan Sidwell  <nathan@acm.org>

	PR demangler/82195
	* cp-demangle.c (d_name): Revert addition of 'toplevel' parm.
	(has_return_type): Recurse for DEMANGLE_COMPONENT_LOCAL_NAME.
	(d_encoding): Revert d_name change.  Use is_fnqual_component_type
	to strip modifiers that do not belong.
	(d_special_name, d_class_enum_type): Revert d_name call change.
	(d_expresion_1): Commonize DEMANGLE_COMPONENT_UNARY building.
	(d_local_name): Revert parsing of a function type.
	(d_print_comp_inner): An inner LOCAL_NAME might contain a
	TEMPLATE.
	* testsuite/demangle-expected: Add & adjust tests


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Update top level configure files by synchronizing them with gcc.
@ 2018-01-10 17:21 sergiodj+buildbot
  2018-01-10 21:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-10 17:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bf41f30dde0f2ad09c2b7a9894fd7992e4b36a16 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: bf41f30dde0f2ad09c2b7a9894fd7992e4b36a16

Update top level configure files by synchronizing them with gcc.

.	* config-ml.in: Sync with gcc sources.
	* config.guess: Likewise.
	* config.sub: Likewise.
	* configure.ac: Likewise.
	* configure: Regenerate.

config	* Sync with GCC sources:

	2017-11-14 Boris Kolpackov  <boris@codesynthesis.com>

	* gcc-plugin.m4: Add support for MinGW.

	2017-11-17  Igor Tsimbalist  <igor.v.tsimbalist@intel.com>

	* cet.m4: New file.

	2017-11-15  Alexandre Oliva <aoliva@redhat.com>

	* bootstrap-debug-lean.mk (do-compare): Use the
	contrib/compare-debug script.

	2017-10-24  H.J. Lu  <hongjiu.lu@intel.com>

	* bootstrap-cet.mk: New file.

	2017-06-19  Martin Liska  <mliska@suse.cz>

	* bootstrap-lto-noplugin.mk: Enable -flto in all PGO stages.
	* bootstrap-lto.mk: Likewise.

	2017-06-03  Eric Botcazou  <ebotcazou@adacore.com>

	* mt-android: New file.

	2017-02-13  Richard Biener  <rguenther@suse.de>

	* isl.m4: Remove support for ISL 0.14.

	2017-01-19  Uros Bizjak  <ubizjak@gmail.com>

	PR target/78478
	* ax_check_define.m4: New file.

	2017-01-17  Jakub Jelinek  <jakub@redhat.com>

	PR other/79046
	* acx.m4 (GCC_BASE_VER): New m4 function.
	(ACX_TOOL_DIRS): Require GCC_BASE_VER, for
	--with-gcc-major-version-only use just major number from BASE-VER.

	2017-01-06  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	PR go/78978
	* hwcaps.m4 (GCC_CHECK_ASSEMBLER_HWCAP): New macro.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix gdb.ada/bp_c_mixed_case.exp (PR gdb/22670)
@ 2018-01-10 23:32 sergiodj+buildbot
  2018-01-10 23:53 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-10 23:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8825213e97f0476068dc3b52b1b61df96b40708a ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 8825213e97f0476068dc3b52b1b61df96b40708a

Fix gdb.ada/bp_c_mixed_case.exp (PR gdb/22670)

The problem here is that we are using the user-provided lookup name
literally for name comparisons.  I.e., "<MixedCase>" with the "<>"s
included.

This commit fixes the minsym lookup case.  psymbol/symbol lookup will
be fixed in a follow up.

In the minsym case, we're using using the user-provided lookup name
literally for linkage name comparisons.  That obviously can't work
since the "<>" are not really part of the linkage name.

The original idea was that we'd use the symbol's language to select
the right symbol name matching algorithm, but that doesn't work for
Ada because it's not really possible to unambiguously tell from the
linkage name alone whether we're dealing with Ada symbols, so Ada
minsyms end up with no language set, or sometimes C++ set.

So fix this by treating Ada mode specially when determining the
linkage name to match against.

gdb/ChangeLog:
2018-01-10  Pedro Alves  <palves@redhat.com>

	PR gdb/22670
	* minsyms.c (linkage_name_str): New function.
	(iterate_over_minimal_symbols): Use it.

gdb/testsuite/ChangeLog:
2018-01-10  Pedro Alves  <palves@redhat.com>

	PR gdb/22670
	* gdb.ada/bp_c_mixed_case.exp: Remove setup_kfail calls.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix gdb.ada/complete.exp's "complete break ada" test (PR gdb/22670)
@ 2018-01-11  0:21 sergiodj+buildbot
  2018-01-11  1:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-11  0:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d4c2a405cb7535d25b88e9b8dad0e557242950ca ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: d4c2a405cb7535d25b88e9b8dad0e557242950ca

Fix gdb.ada/complete.exp's "complete break ada" test (PR gdb/22670)

This patch fixes the regression covered by the test added by:

    commit 344420da6beac1e0b2f7964e7101f8dcdb509b0d
    Date: Thu Jan 4 03:30:37 2018 -0500
    Subject: Add "complete break ada" test to gdb.ada/complete.exp

The regression had been introduced by:

    commit b5ec771e60c1a0863e51eb491c85c674097e9e13
    Date:   Wed Nov 8 14:22:32 2017 +0000
    Subject: Introduce lookup_name_info and generalize Ada's FULL/WILD name matching

The gist of it is that linespec completion in Ada mode is generating
additional matches that should not appear in the match list
(internally generated symbols, or symbols that should be enclosed
between "<...>").  These extraneous entries have uppercase characters, such as:

    break ada__stringsS
    break ada__strings__R11s
    [etc]

These matches come from minimal symbols.  The problem is that Ada
minsyms end up with no language set (language_auto), and thus we end
up using the generic symbol name matcher for those instead of Ada's.
We already had a special case for in compare_symbol_name to handle
this, but it was limited to expressions, while the case at hand is
completing a linespec.  Fix this by applying the special case to
linespec completion as well.  I.e., remove the EXPRESSION check from
compare_symbol_name.  That alone turns out to not be sufficient still
-- GDB would still show a couple entries that shouldn't be there:

~~
    break ada__exceptions__exception_data__append_info_exception_name__2Xn
    break ada__exceptions__exception_data__exception_name_length__2Xn
~~

The reason is that these minimal symbols end up with their language
set to language_cplus / C++, because those encoded names manage to
demangle successfully as C++ symbols (using an old C++ mangling
scheme):

  $ echo ada__exceptions__exception_data__append_info_exception_name__2Xn | c++filt
  Xn::ada__exceptions__exception_data__append_info_exception_name(void)

It's unfortunate that Ada's encoding scheme doesn't start with some
unique prefix like "_Z" in the C++ Itanium ABI mangling scheme.  For
now, paper over that by treating C++ minsyms as Ada minsyms.

gdb/ChangeLog:
2018-01-10  Pedro Alves  <palves@redhat.com>

        PR gdb/22670
	* ada-lang.c (ada_collect_symbol_completion_matches): If the
	minsym's language is language_auto or language_cplus, pass down
	language_ada instead.
	* symtab.c (compare_symbol_name): Don't frob symbol language here.

gdb/testsuite/ChangeLog:
2018-01-10  Pedro Alves  <palves@redhat.com>

        PR gdb/22670
	* gdb.ada/complete.exp ("complete break ada"): Replace kfail with
	a fail.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Ada: make verbatim matcher override other language matchers (PR gdb/22670)
@ 2018-01-11  1:05 sergiodj+buildbot
  2018-01-11  4:28 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-11  1:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c63d3e8d12f0b08cda95f89aa13274defed215f0 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: c63d3e8d12f0b08cda95f89aa13274defed215f0

Ada: make verbatim matcher override other language matchers (PR gdb/22670)

A previous patch fixed verbatim matching in the lookup at the minimal
symbol level, but we should also be finding that same symbol through
the partial/full symtab search.

For example, this is what happens if we use "print" instead of
"break":

    (gdb) p <MixedCaseFunc>
    $1 = {<text variable, no debug info>} 0x4024dc <MixedCaseFunc>

Before the C++ wildmatching series, GDB knows that MixedCaseFunc is a
function without parameters, and the expression above means calling
it.  If you try it before having started the inferior, you'd get the
following (expected) error:

    (gdb) print  <MixedCaseFunc>
    You can't do that without a process to debug.

The main idea behind making the name matcher be determined by the
symbol's language is so that C++ (etc.) wildmatching in linespecs
works even if the current language is not C++, as e.g., when you step
through C or assembly code.

Ada's verbatim matching syntax however ("<...>") isn't quite the same.
It is more a property of the current language than of a particular
symbol's language.  We want to support this syntax when debugging an
Ada program, but it's reason of existence is to find non-Ada symbols.
This suggests going back to enabling it depending on current language
instead of language of the symbol being matched.

I'm not entirely happy with the "current_language" reference (though I
think that it's harmless).  I think we could try storing the current
language in the lookup_name_info object, and then convert a bunch of
functions more to pass around lookup_name_info objects instead of
"const char *" names.  I.e., build the lookup_name_info higher up.
I'm not sure about that, I'll have to think more about it.  Maybe
something different will be better.  Meanwhile, this gets us going.

I've extended the testcase to also exercise a no-debug-info function,
for extra coverage of the minsyms-only paths.

gdb/ChangeLog:
2018-01-10  Pedro Alves  <palves@redhat.com>

	PR gdb/22670
	* dwarf2read.c
	(gdb_index_symbol_name_matcher::gdb_index_symbol_name_matcher):
	Adjust to use language_get_symbol_name_matcher instead of
	language_defn::la_get_symbol_name_matcher.
	* language.c (language_get_symbol_name_matcher): If in Ada mode
	and the lookup name is a verbatim match, return Ada's matcher.
	* language.h (language_get_symbol_name_matcher): Adjust comment.
	(ada_lookup_name_info::verbatim_p):: New method.

gdb/testsuite/ChangeLog:
2018-01-10  Pedro Alves  <palves@redhat.com>

	PR gdb/22670
	* gdb.ada/bp_c_mixed_case.exp: Add intro comment.  Test printing C
	functions too.  Test setting breakpoints and printing C functions
	with no debug info too.
	* gdb.ada/bp_c_mixed_case/qux.c: New file.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] language_get_symbol_name_matcher -> get_symbol_name_matcher
@ 2018-01-11  1:53 sergiodj+buildbot
  2018-01-11  6:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-11  1:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 618daa933cdce21424d3759ea95a4e2f5c69a1c2 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 618daa933cdce21424d3759ea95a4e2f5c69a1c2

language_get_symbol_name_matcher -> get_symbol_name_matcher

Rename language_get_symbol_name_matcher -> get_symbol_name_matcher,
since the function is no longer a straight "language method".

gdb/ChangeLog:
2018-01-10  Pedro Alves  <palves@redhat.com>

	* language.h (language_get_symbol_name_matcher): Rename ...
	(get_symbol_name_matcher): ... this.
	* language.c (language_get_symbol_name_matcher): Ditto.
	* dictionary.c, linespec.c, minsyms.c, psymtab.c, symtab.c: All
	callers adjusted.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove VL variants for 4FMAPS and 4VNNIW insns.
@ 2018-01-11  5:36 sergiodj+buildbot
  2018-01-11 14:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-11  5:36 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 888a89da7fa5d219695234c3a8dc7b8a57dfe8ee ***

Author: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
Branch: master
Commit: 888a89da7fa5d219695234c3a8dc7b8a57dfe8ee

Remove VL variants for 4FMAPS and 4VNNIW insns.

AVX512_4FMAPS and AVX512_4VNNIW insns are marked as having AVX512VL
variants.  That is wrong as SDM doesn't define such instructions. The
patch removes these VL variants.

gas/
	* testsuite/gas/i386/avx512_4fmaps-warn.l: Change xmm to zmm.
	* testsuite/gas/i386/avx512_4fmaps-warn.s: Likewise.
	* testsuite/gas/i386/avx512_4fmaps_vl-intel.d: Delete.
	* testsuite/gas/i386/avx512_4fmaps_vl-warn.l: Likewise.
	* testsuite/gas/i386/avx512_4fmaps_vl-warn.s: Likewise.
	* testsuite/gas/i386/avx512_4fmaps_vl.d: Likewise.
	* testsuite/gas/i386/avx512_4fmaps_vl.s: Likewise.
	* testsuite/gas/i386/avx512_4vnniw_vl-intel.d: Likewise.
	* testsuite/gas/i386/avx512_4vnniw_vl.d: Likewise.
	* testsuite/gas/i386/avx512_4vnniw_vl.s: Likewise.
	* testsuite/gas/i386/i386.exp: Delete _vl tests for 4fmaps an
	4vnniw tests.
	* testsuite/gas/i386/x86-64-avx512_4fmaps_vl-intel.d: Delete.
	* testsuite/gas/i386/x86-64-avx512_4fmaps_vl-warn.l: Likewise.
	* testsuite/gas/i386/x86-64-avx512_4fmaps_vl-warn.s: Likewise.
	* testsuite/gas/i386/x86-64-avx512_4fmaps_vl.d: Likewise.
	* testsuite/gas/i386/x86-64-avx512_4fmaps_vl.s: Likewise.
	* testsuite/gas/i386/x86-64-avx512_4vnniw_vl-intel.d: Likewise.
	* testsuite/gas/i386/x86-64-avx512_4vnniw_vl.d: Likewise.
	* testsuite/gas/i386/x86-64-avx512_4vnniw_vl.s: Likewise.

opcodes/
	* i386-opc.tbl: Remove VL variants for 4FMAPS and 4VNNIW
	insns.
	* i386-tbl.h: Regenerate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix backwards compatibility with old GDBservers (PR remote/22597)
@ 2018-01-11  6:23 sergiodj+buildbot
  2018-01-11 16:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-11  6:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3cada74087687907311b52781354ff551e10a0ed ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 3cada74087687907311b52781354ff551e10a0ed

Fix backwards compatibility with old GDBservers (PR remote/22597)

At <https://sourceware.org/ml/gdb-patches/2017-12/msg00285.html>,
Maciej reported that commit:

  commit 5cd63fda035d4ba949e6478406162c4673b3c9ef
  Date: Wed Oct 4 18:21:10 2017 +0100
  Subject: Fix "Remote 'g' packet reply is too long" problems with multiple inferiors

made GDB stop working with older stubs.  Any attempt to continue
execution after the initial connection fails with:

  [...]
  Process .../gdb/testsuite/outputs/gdb.base/advance/advance created; pid = 2670
  Listening on port 2346
  target remote [...]:2346
  Remote debugging using [...]:2346
  Reading symbols from .../lib64/ld.so.1...done.
  [Switching to Thread <main>]
  (gdb) continue
  Cannot execute this command without a live selected thread.
  (gdb)

The problem is:

  (gdb) c
  Cannot execute this command without a live selected thread.
  (gdb) info threads
    Id   Target Id         Frame
    1    Thread 14917      0x00007f341cd98ed0 in _start () from /lib64/ld-linux-x86-64.so.2

  The current thread <Thread ID 2> has terminated.  See `help thread'.
		      ^^^^^^^^^^^
  (gdb)

Note, thread _2_.  There's really only one thread in the inferior
(it's still at the entry point), but still GDB added a bogus second
thread.

The reason GDB started adding a second thread after 5cd63fda035d is
this hunk:

+                 if (event->ptid == null_ptid)
+                   {
+                     const char *thr = strstr (p1 + 1, ";thread:");
+                     if (thr != NULL)
+                       event->ptid = read_ptid (thr + strlen (";thread:"),
+                                                NULL);
+                     else
+                       event->ptid = magic_null_ptid;
+                   }

Note the else branch that falls back to magic_null_ptid.  We reach
that when we process the initial stop reply sent back in response to
the the "?" (status) packet early in the connection setup:

 Sending packet: $?#3f...Ack
 Packet received: T0506:0000000000000000;07:40a510f4fd7f0000;10:d0fe1201577f0000;

And note that that response does not include a ";thread:XXX" part.

This stop reply is processed after listing threads with qfThreadInfo /
qsThreadInfo :

 Sending packet: $qfThreadInfo#bb...Ack
 Packet received: m3915
 Sending packet: $qsThreadInfo#c8...Ack
 Packet received: l

meaning, when we process that stop reply, we treat the event as coming
from a thread with ptid == magic_null_ptid, which is not yet in the
thread list, so we add it then:

  (top-gdb) p ptid
  $1 = {m_pid = 42000, m_lwp = -1, m_tid = 1}
  (top-gdb) bt
  #0  0x0000000000840a8c in add_thread_silent(ptid_t) (ptid=...) at src/gdb/thread.c:269
  #1  0x00000000007ad61d in remote_add_thread(ptid_t, int, int) (ptid=..., running=0, executing=0)
      at src/gdb/remote.c:1838
  #2  0x00000000007ad8de in remote_notice_new_inferior(ptid_t, int) (currthread=..., executing=0)
      at src/gdb/remote.c:1921
  #3  0x00000000007b758b in process_stop_reply(stop_reply*, target_waitstatus*) (stop_reply=0x1158860, status=0x7fffffffcc00)
      at src/gdb/remote.c:7217
  #4  0x00000000007b7a38 in remote_wait_as(ptid_t, target_waitstatus*, int) (ptid=..., status=0x7fffffffcc00, options=0)
      at src/gdb/remote.c:7380
  #5  0x00000000007b7cd1 in remote_wait(target_ops*, ptid_t, target_waitstatus*, int) (ops=0x102fac0 <remote_ops>, ptid=..., status=0x7fffffffcc00, options=0) at src/gdb/remote.c:7446
  #6  0x000000000081587b in delegate_wait(target_ops*, ptid_t, target_waitstatus*, int) (self=0x102fac0 <remote_ops>, arg1=..., arg2=0x7fffffffcc00, arg3=0) at src/gdb/target-delegates.c:138
  #7  0x0000000000827d77 in target_wait(ptid_t, target_waitstatus*, int) (ptid=..., status=0x7fffffffcc00, options=0)
      at src/gdb/target.c:2179
  #8  0x0000000000715fda in do_target_wait(ptid_t, target_waitstatus*, int) (ptid=..., status=0x7fffffffcc00, options=0)
      at src/gdb/infrun.c:3589
  #9  0x0000000000716351 in wait_for_inferior() () at src/gdb/infrun.c:3707
  #10 0x0000000000715435 in start_remote(int) (from_tty=1) at src/gdb/infrun.c:3212

things go downhill from this.

We don't see the problem with current master gdbserver, because that
version always sends the ";thread:" part in the initial stop reply:

 Sending packet: $?#3f...Packet received: T0506:0000000000000000;07:a0d4ffffff7f0000;10:d05eddf7ff7f0000;thread:p3cea.3cea;core:3;

Years ago I had added a "--disable-packet=" command line option to
gdbserver which comes in handy for testing this, since the existing
"--disable-packet=Tthread" precisely makes gdbserver not send that
";thread:" part in stop replies.  The testcase added by this commit
emulates old gdbserver making use of that.

I've compared a testrun at 5cd63fda035d^ (before regression) with
'current master+patch', against old gdbserver at f8b73d13b7ca^.  I
hacked out --once, and "monitor exit" to be able to test.  The results
are a bit too unstable to tell accurately, but it looked like there
were no regressions.  Maciej confirmed this worked for him as well.

No regressions on master (against master gdbserver).

gdb/ChangeLog:
2018-01-11  Pedro Alves  <palves@redhat.com>

	PR remote/22597
	* remote.c (remote_parse_stop_reply): Default to the last-set
	general thread instead of to 'magic_null_ptid'.

gdb/testsuite/ChangeLog:
2018-01-11  Pedro Alves  <palves@redhat.com>

	PR remote/22597
	* gdb.server/stop-reply-no-thread.c: New file.
	* gdb.server/stop-reply-no-thread.exp: New file.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] ld: Keep PREINIT_ARRAY/INIT_ARRAY/FINI_ARRAY sections for -r --gc-sections
@ 2018-01-11 18:02 sergiodj+buildbot
  2018-01-11 21:34 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-11 18:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8b6f4cd34fdde524ea035c65f7d48aaa3fb449b5 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 8b6f4cd34fdde524ea035c65f7d48aaa3fb449b5

ld: Keep PREINIT_ARRAY/INIT_ARRAY/FINI_ARRAY sections for -r --gc-sections

We must keep all PREINIT_ARRAY, INIT_ARRAY as well as FINI_ARRAY sections
for ld -r --gc-sections.

bfd/

	PR ld/22677
	* elflink.c (bfd_elf_gc_sections): Keep all PREINIT_ARRAY,
	INIT_ARRAY as well as FINI_ARRAY sections for ld -r --gc-sections.

ld/

	PR ld/22677
	* scripttempl/elf.sc (PREINIT_ARRAY): New.
	Don't add .preinit_array for ld -r.
	* testsuite/ld-elf/pr22677.d: New file.
	* testsuite/ld-elf/pr22677.s: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb.base/breakpoint-in-ro-region.exp regression on sss targets (PR gdb/22583)
@ 2018-01-11 19:05 sergiodj+buildbot
  2018-01-11 23:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-11 19:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 71d378ae60a4f072ce392046878d471255f6c8a1 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 71d378ae60a4f072ce392046878d471255f6c8a1

gdb.base/breakpoint-in-ro-region.exp regression on sss targets (PR gdb/22583)

As Maciej reported at
<https://sourceware.org/ml/gdb-patches/2017-12/msg00212.html>, this
commit:

 commit d930703d68ae160ddfe8ebe5fdcf416fb6090e1e
 Date: Thu Nov 16 18:44:43 2017 +0000
 Subject: Don't ever Quit out of resume

caused regressions on software single-set targets, specifically:

 FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: single-step breakpoint is not left behind
 FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw on: single-step breakpoint is not left behind
 FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted on: auto-hw off: step in ro region (cannot insert hw break)
 FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted on: auto-hw off: single-step breakpoint is not left behind
 FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted on: auto-hw on: single-step breakpoint is not left behind

and indeed detailed logs indicate a breakpoint is left lingering, e.g.:

 (gdb) PASS: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: step in ro region (cannot insert sw break)
 maint info breakpoints 0
 Num     Type           Disp Enb Address    What
 0       sw single-step keep y   0x00400774 in main at [...]/gdb/testsuite/gdb.base/breakpoint-in-ro-region.c:24 inf 1 thread 1
	 stop only in thread 1
 (gdb) FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: single-step breakpoint is not left behind

vs:

 (gdb) PASS: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: step in ro region (cannot insert sw break)
 maint info breakpoints 0
 No breakpoint or watchpoint matching '0'.
 (gdb) PASS: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: single-step breakpoint is not left behind

as at commit d930703d68ae^.

Before commit d930703d68ae, we had a cleanup installed in 'resume'
that would delete single-step breakpoints on error:

  /* Resuming.  */

  /* Things to clean up if we QUIT out of resume ().  */
  static void
  resume_cleanups (void *ignore)
  {
    if (!ptid_equal (inferior_ptid, null_ptid))
     delete_single_step_breakpoints (inferior_thread ());

    normal_stop ();
  }

That whole function was removed by d930703d68ae mainly to eliminate
the normal_stop call:

~~~~
    Note that the exception called from within resume ends up calling
    normal_stop via resume_cleanups.  That's very borked though, because
    normal_stop is going to re-handle whatever was the last reported
    event, possibly even re-running a hook stop...
~~~~

But as the regression shows, removing resume_cleanups completely went
a bit too far, as the delete_single_step_breakpoints call is still
necessary.

So fix the regression by reinstating the
delete_single_step_breakpoints call on error.  However, since we're
trying to eliminate cleanups, restore it in a different form (using
TRY/CATCH).

Tested on x86-64 GNU/Linux both top of master and on top of a series
that implements software single-step on x86.

gdb/ChangeLog:
2018-01-11  Pedro Alves  <palves@redhat.com>

	PR gdb/22583
	* infrun.c (resume): Rename to ...
	(resume_1): ... this.
	(resume): Reimplement as wrapper around resume_1.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Ignore dynamic references on forced local symbols
@ 2018-01-11 23:57 sergiodj+buildbot
  2018-01-12  4:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-11 23:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d664fd41e15f058aab41b70c567ad09f2fab1115 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: d664fd41e15f058aab41b70c567ad09f2fab1115

Ignore dynamic references on forced local symbols

We should ignore dynamic references on forced local symbols during
garbage collection since they can never be referenced dynamically.

bfd/

	PR ld/22649
	* elflink.c (bfd_elf_gc_mark_dynamic_ref_symbol): Ignore dynamic
	references on forced local symbols.

ld/

	PR ld/22649
	* testsuite/ld-elf/pr22649-1.s: New file.
	* testsuite/ld-elf/pr22649-2a.s: Likewise.
	* testsuite/ld-elf/pr22649-2b.s: Likewise.
	* testsuite/ld-elf/pr22649.msg: Likewise.
	* testsuite/ld-elf/shared.exp: Run ld/22649 tests.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb_compile_shlib: Only consider shlib= options when building executables
@ 2018-01-12  2:29 sergiodj+buildbot
  2018-01-12  6:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-12  2:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6181e9c2c5ba252ac016f51903dc35d7bfbbca71 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 6181e9c2c5ba252ac016f51903dc35d7bfbbca71

gdb_compile_shlib: Only consider shlib= options when building executables

Trying to use gdb_compile_shlib with the shlib= option to build a shared
library that depends on another shared library does not work as of
today.  See:

  https://sourceware.org/ml/gdb-patches/2017-10/msg00733.html

The problem is that building the lib is done in two steps, compilation
(.c -> .o) and linking (.o -> .so) and the shlib= options are passed to
both steps.  When compiling the object file (.o), it results in gcc
complaining:

  gcc: warning: .../solib-vanish-lib2.so: linker input file unused because linking not done

The first solution I came up with was to filter the options inside
gdb_compile_shlib to remove the shlib= options from the options we pass
when compiling the .o file.

I then thought it would be simpler to ignore the shlib= options in
gdb_compile when not building an executable (the executable category
includes the shared libraries).  For other compilation types (object
file, preprocess and generate assembly), it doesn't make sense to add
shared libraries to the source file list.

Regtested on the buildbot.

gdb/testsuite/ChangeLog:

	* lib/gdb.exp (gdb_compile): Ignore shlib= and shlib_load
	options when not creating an executable.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] ld: Add "-z separate-code" option to ELF linker
@ 2018-01-12  3:25 sergiodj+buildbot
  2018-01-12  8:04 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-12  3:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 47acac12c83f173481debc64618626b50ecf7498 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 47acac12c83f173481debc64618626b50ecf7498

ld: Add "-z separate-code" option to ELF linker

The new "-z separate-code" option will generate separate code LOAD
segment which must be in wholly disjoint pages from any other data.

include/

	PR ld/22393
	* bfdlink.h (bfd_link_info): Add separate_code.

ld/

	PR ld/22393
	* NEWS: Mention "-z separate-code".
	* emultempl/elf32.em (gld${EMULATION_NAME}_get_script): Get
	builtin linker scripts and return linker scripts from disk for
	"-z separate-code".
	(gld${EMULATION_NAME}_handle_option): Handle "-z separate-code"
	and "-z noseparate-code".
	* genscripts.sh: Generate linker scripts for "-z separate-code".
	(LD_FLAG): Set to *textonly for "-z separate-code".
	* ld.texinfo: Document "-z separate-code".
	* lexsup.c (elf_shlib_list_options): Add linker help messsages
	for "-z separate-code" and "-z noseparate-code".
	* scripttempl/elf.sc (SEPARATE_TEXT): New
	(TEXT_SEGMENT_ALIGN): Likewise.
	Use ${TEXT_SEGMENT_ALIGN} to align and pad text segment to
	${MAXPAGESIZE}.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] ld: Create a new LOAD segment for separate code segment
@ 2018-01-12  4:24 sergiodj+buildbot
  2018-01-12 10:43 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-12  4:24 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2888249fc9eb38b6d6e4bd969ce63c26e3753d5e ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 2888249fc9eb38b6d6e4bd969ce63c26e3753d5e

ld: Create a new LOAD segment for separate code segment

When generating separate code LOAD segment, create a new LOAD segment
if the previous section contains text and the current section doesn't
or vice versa:

Elf file type is DYN (Shared object file)
Entry point 0x200020
There are 7 program headers, starting at offset 52

Program Headers:
  Type           Offset   VirtAddr   PhysAddr   FileSiz MemSiz  Flg Align
  LOAD           0x000000 0x00000000 0x00000000 0x00200 0x00200 R   0x200000
  LOAD           0x200000 0x00200000 0x00200000 0x00036 0x00036 R E 0x200000
  LOAD           0x400000 0x00400000 0x00400000 0x00064 0x00064 R   0x200000
  LOAD           0x400f80 0x00600f80 0x00600f80 0x000a0 0x000a0 RW  0x200000
  DYNAMIC        0x400f80 0x00600f80 0x00600f80 0x00080 0x00080 RW  0x4
  GNU_STACK      0x000000 0x00000000 0x00000000 0x00000 0x00000 RW  0x10
  GNU_RELRO      0x400f80 0x00600f80 0x00600f80 0x00080 0x00080 R   0x1

 Section to Segment mapping:
  Segment Sections...
   00     .hash .gnu.hash .dynsym .dynstr .rela.plt
   01     .plt .text
   02     .rodata .eh_frame
   03     .dynamic .got.plt
   04     .dynamic
   05
   06     .dynamic

to prevent fetching or executing data in code pages as instructions.

Also don't put a writable section in a read-only segment if there is a
RELRO segment.

Since code segment is aligned and padded to the maximum page size on
disk, the minimum file size is bigger than the maximum page size which
is 2MB (0x200000):

-rwxr-xr-x 1 hjl hjl 4201932 Jan 10 10:41 libfoo.so

"-z max-page-size=0x1000" can be used to reduce the maximum page size to
4KB (0x1000):

-rwxr-xr-x 1 hjl hjl   15820 Jan 10 10:44 libfoo.so

	PR ld/22393
	* elf.c (_bfd_elf_map_sections_to_segments): When generating
	separate code and read-only data LOAD segments, create a new
	LOAD segment if the previous section contains text and the
	current section doesn't or vice versa.  Don't put a writable
	section in a read-only segment if there is a RELRO segment.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] _bfd_mips_elf_final_link: Notify user about wrong .reginfo size
@ 2018-01-12 10:06 sergiodj+buildbot
  2018-01-12 19:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-12 10:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 58807c48a5a317ad3e2d39a8755168a3d4d5fdf8 ***

Author: Vlad Ivanov <vlad@ivanov.email>
Branch: master
Commit: 58807c48a5a317ad3e2d39a8755168a3d4d5fdf8

_bfd_mips_elf_final_link: Notify user about wrong .reginfo size

One of assertions in _bfd_mips_elf_final_link could be triggered by
a combination of input files and a linker script.  This happens when
either the input doesn't contain .reginfo section or when this section
is oversized.  This patch replaces the assertion with a more useful
error message.

	* elfxx-mips.c (_bfd_mips_elf_final_link): Notify user when
	.reginfo section has wrong size.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fixes for "Ignore dynamic references on forced local symbols"
@ 2018-01-12 11:03 sergiodj+buildbot
  2018-01-12 21:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-12 11:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 87e79a6515951fece72ee08871dd6e112b1042ba ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 87e79a6515951fece72ee08871dd6e112b1042ba

Fixes for "Ignore dynamic references on forced local symbols"

PowerPC64 has its own mark_dynamic_ref, which needs the same change as
made by d664fd41e1 to the generic ELF version.  Some other targets
discard more than just .data, so allow for that too in expected ld
messages.

bfd/
	PR ld/22649
	* elf64-ppc.c (ppc64_elf_gc_mark_dynamic_ref): Ignore dynamic
	references on forced local symbols.
ld/
	PR ld/22649
	* testsuite/ld-elf/pr22649.msg: Allow other messages.
	* testsuite/ld-elf/shared.exp: Check that --gc-sections is
	supported before running ld/22649 tests.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix override of common symbols for a.out
@ 2018-01-12 11:55 sergiodj+buildbot
  2018-01-12 22:39 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-12 11:55 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a78eea1623aa6d05a395a73414bf01f6c8ae81c6 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: a78eea1623aa6d05a395a73414bf01f6c8ae81c6

Fix override of common symbols for a.out

The default should be bfd_link_common_skip_none, as in the original
patch at https://sourceware.org/ml/binutils/2002-07/msg00717.html

	* aoutx.h (aout_link_check_ar_symbols): Remove default and handle
	bfd_link_common_skip_none in switch.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Optimize the performance of the group_setup function.
@ 2018-01-12 13:37 sergiodj+buildbot
  2018-01-13  0:13 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-12 13:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 564e11c9a9d9570b233b38cd995f1b4eb7c757e8 ***

Author: Jens Widell <jl@opera.com>
Branch: master
Commit: 564e11c9a9d9570b233b38cd995f1b4eb7c757e8

Optimize the performance of the group_setup function.

When processing a section that is a member of a group, the group
that contains it is looked up using a linear search. The resulting
O(n^2) complexity causes significant performance issues when
dealing with object files with very many groups.

By remembering the index of the last found group and restarting
the next search from that index, the search instead becomes O(n)
in common cases.

	* elf.c (setup_group): Optimize search for group by remembering
	last found group and restarting search at that index.
	* elf-bfd.h (struct elf_obj_tdata): Add group_search_offset field.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix GDB hang with remote after error from resume
@ 2018-01-12 19:19 sergiodj+buildbot
  2018-01-13  2:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-12 19:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bdf2a94aa535016a1640d56e9b2b539c4376bf31 ***

Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: bdf2a94aa535016a1640d56e9b2b539c4376bf31

Fix GDB hang with remote after error from resume

Since this commit --

  Fix PR18360 - internal error when using "interrupt -a"
  (https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=c65d6b55)

-- the testsuite shows long delays on s390 with native-gdbserver when
executing certain tests, such as watchpoints.exp.  These hangs have been
discussed before in the context of buildbot problems, see here:

  https://sourceware.org/ml/gdb-patches/2017-12/msg00413.html

The problem can easily be triggered by stopping on a breakpoint, then
setting impossible watchpoints, and finally doing "continue".  Then, after
having set the step-over state (in keep_going_pass_signal in infrun.c),
GDB tries to insert breakpoints and watchpoints into the inferior.  This
fails, and the "continue" command is aborted.  But the step-over state is
not cleared in this case, which causes future step-over attempts to be
skipped since GDB thinks that "we already have an in-line step-over
operation ongoing" (see start_step_over in infrun.c).  Thus the next
"continue" just goes on to wait for events from the remote, which will
never occur.

The problem can also be reproduced on amd64 with native-gdbserver, using
the following change to watchpoints.exp:

 -- >8 --
 --- a/gdb/testsuite/gdb.base/watchpoints.exp
 +++ b/gdb/testsuite/gdb.base/watchpoints.exp
 @@ -61,2 +61,3 @@ with_test_prefix "before inferior start" {
      gdb_test "watch ival3" ".*" ""
 +    gdb_test "watch *(char \[256\] *) main"

 -- >8 --

To fix the hang, this patch clears the step-over info when
insert_breakpoints has failed.  Of course, with native-gdbserver the
watchpoints.exp test case still causes many FAILs on s390, because
gdbserver does not support watchpoints for that target.  This is a
separate issue.

gdb/ChangeLog:
2018-01-12  Andreas Arnez  <arnez@linux.vnet.ibm.com>

	* infrun.c (keep_going_pass_signal): Clear step-over info when
	insert_breakpoints fails.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add testcase for GDB hang fixed by previous commit
@ 2018-01-12 20:00 sergiodj+buildbot
  2018-01-13  4:55 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-12 20:00 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT eea61984abfea2c0acdc7e46ec182a14698b3bf9 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: eea61984abfea2c0acdc7e46ec182a14698b3bf9

Add testcase for GDB hang fixed by previous commit

This adds a testcase for the previous commit.  The regression was
related to in-line step overs.  The reason we didn't see it on native
x86-64/s390 GNU/Linux testing is that native debugging uses displaced
stepping by default (because native debugging defaults to "maint set
target-non-stop on"), unlike remote debugging.

So in order to trigger the bug with native debugging as well, the
testcase disables displaced stepping explicitly.

Also, instead of using watchpoints to trigger the regression, the
testcase uses a breakpoint at address 0, which should be more
portable.

gdb/testsuite/ChangeLog:
2018-01-12  Pedro Alves  <palves@redhat.com>

	* gdb.base/continue-after-aborted-step-over.c: New.
	* gdb.base/continue-after-aborted-step-over.exp: New.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use the correct value for the offset of 'kve_protection'.
@ 2018-01-12 22:32 sergiodj+buildbot
  2018-01-13 12:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-12 22:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 906b4aac4c1d3cdb2b1ea7105133cfbe25e04e14 ***

Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: 906b4aac4c1d3cdb2b1ea7105133cfbe25e04e14

Use the correct value for the offset of 'kve_protection'.

I had forgotten to convert the decimal output of 'ptype /o' to hex
(but still used a 0x prefix) for the KVE_PROTECTION constant defining
the offset of the 'kve_protection' field in the 'kinfo_vmentry'
structure.  This resulted in garbage permissions for entries in 'info
proc mappings' for FreeBSD core dumps.

gdb/ChangeLog:

	* fbsd-tdep.c (KVE_PROTECTION): Correct value.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Install and generate docs for gdb-add-index
@ 2018-01-12 23:43 sergiodj+buildbot
  2018-01-13 14:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-12 23:43 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ba643918cf869fa0d064d733f69b453b6fe642ea ***

Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: ba643918cf869fa0d064d733f69b453b6fe642ea

Install and generate docs for gdb-add-index

The "gdb-add-index" script has been resurrected on:

  commit caf26be91a584ef141ac5d3cb31007731af8b8e3
  Author: Samuel Bronson <naesten@gmail.com>
  Date:   Fri Nov 15 16:09:33 2013 -0500

      Resurrect gdb-add-index as a contrib script

However, for some reason (I couldn't find it in the archives), only
the script has been checked-in; the Makefile parts responsible for
installing it in the system were left out.  This commit fixes that, by
also resurrecting the Makefile and documentation bits.

This commit is part of our effort to upstream the local Fedora GDB
changes.  With this commit, we'll only carry a very small
Fedora-specific modification to the script.

gdb/ChangeLog:
2017-01-12  Tom Tromey  <tom@tromey.com>
	    Sergio Durigan Junior  <sergiodj@redhat.com>

	* Makefile.in (install-only): Install gdb-add-index.

gdb/doc/ChangeLog:
2017-01-12  Tom Tromey  <tom@tromey.com>
	    Sergio Durigan Junior  <sergiodj@redhat.com>

	* gdb.texinfo (Index Files): Mention gdb-add-index.
	(gdb-add-index man): New section.
	* Makefile.in (gdb-add-index.1): New rule to generate manpage
	from gdb.texinfo.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb/testsuite: Don't attempt tests if they fail to compile
@ 2018-01-13  0:00 sergiodj+buildbot
  2018-01-13 16:42 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-13  0:00 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cbcdb1aaddb4dd1a388eadbea6b6ec342c7ab067 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: cbcdb1aaddb4dd1a388eadbea6b6ec342c7ab067

gdb/testsuite: Don't attempt tests if they fail to compile

In the gdb.base/whatis-ptype-typedefs.exp test, if the test program
fails to compile, don't run the tests.

gdb/testsuite/ChangeLog:

	* gdb.base/whatis-ptype-typedefs.exp: Don't run tests if we failed
	to prepare.
	(prepare): Return 0 on error, 1 on success.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add note about 2.30 branch creation to changelogs
@ 2018-01-13 13:46 sergiodj+buildbot
  2018-01-13 19:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-13 13:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT faf766e31794722b7e2c24e44e920d0476cede32 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: faf766e31794722b7e2c24e44e920d0476cede32

Add note about 2.30 branch creation to changelogs


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Bump version number to 2.30.51
@ 2018-01-13 14:31 sergiodj+buildbot
  2018-01-13 22:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-13 14:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 769c7ea507209948135facd04bf8defc3f21a8a4 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 769c7ea507209948135facd04bf8defc3f21a8a4

Bump version number to 2.30.51

bfd/
	* version.m4: Bump version to 2.30.51
	* configure: Regenerate.

binutils/
	* configure: Regenerate.

gas/
	* configure: Regenerate.

gprof/
	* configure: Regenerate.

ld/
	* configure: Regenerate.

opcodes/
	* configure: Regenerate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Update pot files
@ 2018-01-13 15:45 sergiodj+buildbot
  2018-01-14  0:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-13 15:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3957a4963f38fb249eced6c880efacd22f10eb28 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 3957a4963f38fb249eced6c880efacd22f10eb28

Update pot files


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Update notes on how to make a release
@ 2018-01-13 16:17 sergiodj+buildbot
  2018-01-14  3:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-13 16:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 19e2900bd399d1ba272afe8b5b50b1b29a948bbe ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 19e2900bd399d1ba272afe8b5b50b1b29a948bbe

Update notes on how to make a release


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Update Ukranian translations for bfd, binutils, gas, gold, ld and opcodes
@ 2018-01-15 12:32 sergiodj+buildbot
  2018-01-15 12:49 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-15 12:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 616dcb87abe148edf7278581e04cf23aff97411e ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 616dcb87abe148edf7278581e04cf23aff97411e

Update Ukranian translations for bfd, binutils, gas, gold, ld and opcodes


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix scm-ports.exp regression
@ 2018-01-15 20:05 sergiodj+buildbot
  2018-01-15 21:29 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-15 20:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 86d6a90c58ee3fb924bcbca154f4e32347437e6c ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 86d6a90c58ee3fb924bcbca154f4e32347437e6c

Fix scm-ports.exp regression

In https://sourceware.org/ml/gdb-patches/2017-12/msg00215.html, Jan
pointed out that the scalar printing patches caused a regression in
scm-ports.exp on x86.

What happens is that on x86, this:

	set sp_reg [get_integer_valueof "\$sp" 0]

... ends up setting sp_reg to a negative value, because
get_integer_valueof uses "print/d":

    print /d $sp
    $1 = -11496

Then later the test suite does:

    gdb_test "guile (print (seek rw-mem-port (value->integer sp-reg) SEEK_SET))" \
	"= $sp_reg" \
	"seek to \$sp"

... expecting this value to be identical to the saved $sp_reg value.
However it gets:

    guile (print (seek rw-mem-port (value->integer sp-reg) SEEK_SET))
    = 4294955800

"print" is just a wrapper for guile's format:

    gdb_test_no_output "guile (define (print x) (format #t \"= ~A\" x) (newline))"

The seek function returns a scm_t_off, the printing of which is
handled by guile, not by gdb.

Tested on x86-64 Fedora 26 using an ordinary build and also a -m32
build.

2018-01-15  Tom Tromey  <tom@tromey.com>

	* gdb.guile/scm-ports.exp (test_mem_port_rw): Use get_valueof to
	compute sp_reg.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb/common/signals-state-save-restore.c: Fix typos
@ 2018-01-15 23:14 sergiodj+buildbot
  2018-01-16  1:38 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-15 23:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT db422fb2120e311318657d9c7dd0e7b0b5a5eac9 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: db422fb2120e311318657d9c7dd0e7b0b5a5eac9

gdb/common/signals-state-save-restore.c: Fix typos

gdb/ChangeLog:
2018-01-15  Pedro Alves  <palves@redhat.com>

	* common/signals-state-save-restore.c
	(save_original_signals_state): Fix typos.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] RISC-V: Add support for addi that compresses to c.nop.
@ 2018-01-16  0:18 sergiodj+buildbot
  2018-01-16  3:30 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-16  0:18 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2721d702a055fe0f7621386123b103b5c4d84662 ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 2721d702a055fe0f7621386123b103b5c4d84662

RISC-V: Add support for addi that compresses to c.nop.

	gas/
	* testsuite/gas/riscv/c-zero-imm.s: Test addi that compresses to c.nop.
	* testsuite/gas/riscv/c-zero-imm.d: Likewise.
	opcodes/
	* riscv-opc.c (match_c_nop): New.
	(riscv_opcodes) <addi>: Handle an addi that compresses to c.nop.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Mark register unavailable when PTRACE_PEEKUSER fails
@ 2018-01-16  9:25 sergiodj+buildbot
  2018-01-16 10:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-16  9:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9a70f35c8d872bb5542e98e34b8b044228dcb844 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 9a70f35c8d872bb5542e98e34b8b044228dcb844

Mark register unavailable when PTRACE_PEEKUSER fails

As described in PR 18749, GDB/GDBserver may get an error on accessing
memory or register because the thread may disappear.  However, some
path doesn't expect the error.  This patch fixes this problem by
marking the register unavailable when PTRACE_PEEKUSER fails instead
of throwing error.

gdb/gdbserver:

2018-01-16  Yao Qi  <yao.qi@linaro.org>

	PR gdb/18749
	* linux-low.c (fetch_register): Call supply_register instead of
	error.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Update translations for various binutils components.
@ 2018-01-16 13:03 sergiodj+buildbot
  2018-01-16 13:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-16 13:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f6efed019b4e49a4c27b518afbdf2d9bf0652843 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: f6efed019b4e49a4c27b518afbdf2d9bf0652843

Update translations for various binutils components.

ld      * po/pt_BR.po: Updated Brazilian Portugese translation.

opcodes * po/pt_BR.po: Updated Brazilian Portugese translation.
        * po/de.po: Updated German translation.

gas     * po/fr.po: Updated French translation.

binutils* po/fr.po: Updated French translation.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Warning fix
@ 2018-01-17 11:10 sergiodj+buildbot
  2018-01-17 11:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 11:10 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c75bc4f76fe456c57ef1e446db5378182692c429 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: c75bc4f76fe456c57ef1e446db5378182692c429

Warning fix

	* elf64-ppc.c (ppc64_elf_build_stubs): Silence gcc warning.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Relax gdb.compile/compile.exp to match the address printed for frame
@ 2018-01-17 11:56 sergiodj+buildbot
  2018-01-17 13:48 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 11:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d8447b6b9fd288ebd35620178ba720b1f0ce7ebf ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: d8447b6b9fd288ebd35620178ba720b1f0ce7ebf

Relax gdb.compile/compile.exp to match the address printed for frame

One test in gdb.compile/compile.exp passes on one fedora builder,

 bt
 #0  0x00007ffff7ff43f6 in _gdb_expr (__regs=0x7ffff7ff2000) at gdb
 command line:1^M
 #1  <function called from gdb>^M
 #2  main () at /home/gdb-buildbot/fedora-x86-64-1/fedora-x86-64/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.compile/compile.c:106^M
 (gdb) PASS: gdb.compile/compile.exp: bt

but fails on my machine with gcc trunk,

 bt^M
 #0  _gdb_expr (__regs=0x7ffff7ff3000) at gdb command line:1^M
 #1  <function called from gdb>^M
 #2  main () at gdb/testsuite/gdb.compile/compile.c:106^M
 (gdb) FAIL: gdb.compile/compile.exp: bt

The test should be tweaked to match both cases (pc in the start of line
vs pc in the middle of line).  Note that I am not clear that why libcc1
emits debug info this way so that the address is in the middle of line.

gdb/testsuite:

2018-01-17  Yao Qi  <yao.qi@linaro.org>

	* gdb.compile/compile.exp: Match the address printed for
	frame in the output of command "bt".


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Don't pass -m64 to libcc1 on aarch64-linux.
@ 2018-01-17 13:23 sergiodj+buildbot
  2018-01-17 17:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 13:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7045b1ca73b8c0cb12d1158f3bc59d251dca0fa5 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 7045b1ca73b8c0cb12d1158f3bc59d251dca0fa5

Don't pass -m64 to libcc1 on aarch64-linux.

Nowadays, if we use "compile" on aarch64-linux, we'll get the following
error,

(gdb) compile code -- ;
aarch64-none-linux-gnu-gcc: error: unrecognized command line option '-m64'

because the default gcc_target_options returns "-m64" and
"-mcmodel=large", neither is useful to aarch64-linux.

gdb:

2018-01-17  Yao Qi  <yao.qi@linaro.org>

	* aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): New
	function.
	(aarch64_linux_init_abi): Install it to gdbarch hook
	gcc_target_options.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] configure: Fix test for fs_base/gs_base in <sys/user.h>
@ 2018-01-17 13:48 sergiodj+buildbot
  2018-01-17 22:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 13:48 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f517c1805ac50c64c2dbb086c16b3bcf33b15a89 ***

Author: Eldar Abusalimov <eldar.abusalimov@jetbrains.com>
Branch: master
Commit: f517c1805ac50c64c2dbb086c16b3bcf33b15a89

configure: Fix test for fs_base/gs_base in <sys/user.h>

Make <sys/types.h> be included prior to including <sys/user.h>.

glibc versions older than 2.14 use __uintNN_t types within certain
structures defined in <sys/user.h> probably assuming these types are
defined prior to including the header. This results in the following
`configure` feature test compilation error that makes it think that
`struct user_regs_struct` doesn't have `fs_base`/`gs_base` fields,
althouh it does.

    configure:13617: checking for struct user_regs_struct.fs_base
    configure:13617: gcc -c -g -O2 -I/linux/include conftest.c >&5
    In file included from conftest.c:158:0:
    /usr/include/sys/user.h:32:3: error: unknown type name '__uint16_t'
       __uint16_t  cwd;
       ^
    /usr/include/sys/user.h:33:3: error: unknown type name '__uint16_t'
       __uint16_t  swd;
       ^
    /usr/include/sys/user.h:34:3: error: unknown type name '__uint16_t'
       __uint16_t  ftw;
       ^
    /usr/include/sys/user.h:35:3: error: unknown type name '__uint16_t'
       __uint16_t  fop;
       ^
    /usr/include/sys/user.h:36:3: error: unknown type name '__uint64_t'
       __uint64_t  rip;
       ^
    /usr/include/sys/user.h:37:3: error: unknown type name '__uint64_t'
       __uint64_t  rdp;
       ^
    /usr/include/sys/user.h:38:3: error: unknown type name '__uint32_t'
       __uint32_t  mxcsr;
       ^
    /usr/include/sys/user.h:39:3: error: unknown type name '__uint32_t'
       __uint32_t  mxcr_mask;
       ^
    /usr/include/sys/user.h:40:3: error: unknown type name '__uint32_t'
       __uint32_t  st_space[32];   /* 8*16 bytes for each FP-reg = 128 bytes */
       ^
    /usr/include/sys/user.h:41:3: error: unknown type name '__uint32_t'
       __uint32_t  xmm_space[64];  /* 16*16 bytes for each XMM-reg = 256 bytes */
       ^
    /usr/include/sys/user.h:42:3: error: unknown type name '__uint32_t'
       __uint32_t  padding[24];
       ^
    configure:13617: $? = 1
    configure: failed program was:
    | /* confdefs.h */
    ...
    | /* end confdefs.h.  */
    | #include <sys/user.h>
    |
    | int
    | main ()
    | {
    | static struct user_regs_struct ac_aggr;
    | if (ac_aggr.fs_base)
    | return 0;
    |   ;
    |   return 0;
    | }

Recent glibc versions don't use typedef'ed int types in <sys/user.h>,
thus allowing it to be included as is
(glibc commit d79a9c949c84e7f0ba33e87447c47af833e9f11a).
However there're still some distros alive that use older glibc,
for instance, RHEL/CentOS 6 package glibc 2.12.

Also affects PR gdb/21559:

    ../../gdb/regcache.c:1087: internal-error: void regcache_raw_supply(regcache, int, const void): Assertion `regnum >= 0 && regnum < regcache->descr->nr_raw_registers' failed.

As noted by Andrew Paprocki, who submitted the PR
(https://sourceware.org/bugzilla/show_bug.cgi?id=21559#c3):

    > It should be noted that modifying `configure` to force on
    > `HAVE_STRUCT_USER_REGS_STRUCT_FS_BASE` and
    > `HAVE_STRUCT_USER_REGS_STRUCT_GS_BASE` fixes this issue. For some
    > reason the `configure` tests for `fs_base` and `gs_base` fail
    > even though `sys/user.h` on RHEL5 has the fields defined in
    > `user_regs_struct`.

Note that this patch does NOT fix the root cause of PR gdb/21559,
although now that `configure` properly detects the presence of the
fields and sets HAVE_XXX accordingly, the execution takes another
path, which doesn't lead to the assertion failure in question.

gdb/ChangeLog:
2018-01-17  Eldar Abusalimov  <eldar.abusalimov@jetbrains.com>

	PR gdb/21559
	* configure.ac: Include <sys/types.h> prior to <sys/user.h> when
	checking for fs_base/gs_base fields in struct user_regs_struct.
	* configure: Regenerate.

gdb/gdbserver/ChangeLog:
2018-01-17  Eldar Abusalimov  <eldar.abusalimov@jetbrains.com>

	PR gdb/21559
	* configure.ac: Include <sys/types.h> prior to <sys/user.h> when
	checking for fs_base/gs_base fields in struct user_regs_struct.
	* configure: Regenerate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Update Ukranian and Russian translations in bfd library
@ 2018-01-17 16:08 sergiodj+buildbot
  2018-01-18  2:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 16:08 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4bfce1283654832d83a01b700e61518233c8bbda ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 4bfce1283654832d83a01b700e61518233c8bbda

Update Ukranian and Russian translations in bfd library


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Replace CET bit with IBT and SHSTK bits.
@ 2018-01-17 17:04 sergiodj+buildbot
  2018-01-18  4:15 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 17:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d777820bf5abea433c36e956b53b299502e0f708 ***

Author: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
Branch: master
Commit: d777820bf5abea433c36e956b53b299502e0f708

Replace CET bit with IBT and SHSTK bits.

The latest specification for Intel CET technology defined two
new bits instead of previously used CET bit. These are IBT and
SHSTK bits. The patch replaces CET bit with IBT and SHSTK bits.

gas/
	* config/tc-i386.c (cpu_arch): Delete .cet. Add .ibt, .shstk.
	(cpu_noarch): Add noibt, noshstk.
	(parse_insn): Change cpucet to cpuibt.
	* doc/c-i386.texi: Delete .cet. Add .ibt, .shstk.
	* testsuite/gas/i386/cet-ibt-inval.l: New test.
	* testsuite/gas/i386/cet-ibt-inval.s: Likewise.
	* testsuite/gas/i386/cet-shstk-inval.l: Likewise.
	* testsuite/gas/i386/cet-shstk-inval.s: Likewise.
	* testsuite/gas/i386/x86-64-cet-ibt-inval.l: Likewise.
	* testsuite/gas/i386/x86-64-cet-ibt-inval.s: Likewise.
	* testsuite/gas/i386/x86-64-cet-shstk-inval.l: Likewise.
	* testsuite/gas/i386/x86-64-cet-shstk-inval.s: Likewise.

opcodes/
	* i386-gen.c (cpu_flag_init): Delete CPU_CET_FLAGS,
	CpuCET. Add CPU_IBT_FLAGS, CPU_SHSTK_FLAGS, CPY_ANY_IBT_FLAGS,
	CPU_ANY_SHSTK_FLAGS, CpuIBT, CpuSHSTK.
	(cpu_flags): Add CpuIBT, CpuSHSTK.
	* i386-opc.h (enum): Add CpuIBT, CpuSHSTK.
	(i386_cpu_flags): Add cpuibt, cpushstk.
	* i386-opc.tbl: Change CpuCET to CpuSHSTK and CpuIBT.
	* i386-init.h: Regenerate.
	* i386-tbl.h: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] linux-nat: Remove unnecessary xstrdup
@ 2018-01-17 17:53 sergiodj+buildbot
  2018-01-18  5:53 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 17:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a7b2d0fbeb4ca22ffbf56d19d06b7d1cb774e383 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: a7b2d0fbeb4ca22ffbf56d19d06b7d1cb774e383

linux-nat: Remove unnecessary xstrdup

I think this xstrdup is not useful.  We can pass ex.message directly to
throw_error instead.

gdb/ChangeLog:

	* linux-nat.c (linux_nat_attach): Remove xstrdup.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Make linux_ptrace_attach_fail_reason return an std::string
@ 2018-01-17 17:59 sergiodj+buildbot
  2018-01-18  7:45 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 17:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4d9b86e17505063c96a01d40cdf5b4fc2080a798 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 4d9b86e17505063c96a01d40cdf5b4fc2080a798

Make linux_ptrace_attach_fail_reason return an std::string

This patch makes linux_ptrace_attach_fail_reason and
linux_ptrace_attach_fail_reason_string return std::string.  It also
replaces usages of struct buffer with std::string.  This allows getting
rid of a cleanup in in linux_ptrace_attach_fail_reason_string and
simplifies the code in general.

Something that looks odd to me is that in
linux_ptrace_attach_fail_reason, if the two messages are appended, there
is no separating space or \n, so the result won't be very nice.  I left
it as-is for now though.

gdb/ChangeLog:

	* nat/linux-ptrace.h (linux_ptrace_attach_fail_reason): Return
	std::string.
	(linux_ptrace_attach_fail_reason_string): Likewise.
	* nat/linux-ptrace.c (linux_ptrace_attach_fail_reason):
	Likewise.
	(linux_ptrace_attach_fail_reason_string): Likewise.
	* linux-nat.c (attach_proc_task_lwp_callback): Adjust.

gdb/gdbserver/ChangeLog:

	* linux-low.c (attach_proc_task_lwp_callback): Adjust to
	linux_ptrace_attach_fail_reason_string now returning an
	std::string.
	(linux_attach): Likewise.
	* thread-db.c (attach_thread): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix gdb segv when objfile can't be opened
@ 2018-01-17 18:49 sergiodj+buildbot
  2018-01-18  9:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 18:49 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 416675305692976aca45860e24b963982a2e682a ***

Author: Mike Gulick <mike.gulick@mathworks.com>
Branch: master
Commit: 416675305692976aca45860e24b963982a2e682a

Fix gdb segv when objfile can't be opened

This fixes PR 16577.

This patch changes gdb_bfd_map_section to issue a warning rather than an error
if it is unable to read the object file, and sets the size of the section/frame
that it attempted to read to 0 on error.

The description of gdb_bfd_map_section states that it will try to read or map
the contents of the section SECT, and if successful, the section data is
returned and *SIZE is set to the size of the section data.  This function was
throwing an error and leaving *SIZE as-is.  Setting the section size to 0
indicates to dwarf2_build_frame_info that there is no data to read, otherwise
it will try to read from an invalid frame pointer.

Changing the error to a warning allows this to be handled gracefully.
Additionally, the error was clobbering the breakpoint output indicating the
current frame (function name, arguments, source file, and line number).  E.g.

Thread 3 "foo" hit Breakpoint 1, BFD: reopening /tmp/jna-1013829440/jna2973250704389291330.tmp: No such file or directory
BFD: reopening /tmp/jna-1013829440/jna2973250704389291330.tmp: No such file or directory
(gdb)

While the "BFD: reopening ..." messages will still appear interspersed in the
breakpoint output, the current frame info is now displayed:

Thread 3 "foo" hit Breakpoint 1, BFD: reopening /tmp/jna-1013829440/jna1875755897659885075.tmp: No such file or directory
BFD: reopening /tmp/jna-1013829440/jna1875755897659885075.tmp: No such file or directory
warning: Can't read data for section '.eh_frame' in file '/tmp/jna-1013829440/jna1875755897659885075.tmp'
do_something () at file.cpp:80
80	{
(gdb)


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Unify new_symbol and new_symbol_full
@ 2018-01-17 19:20 sergiodj+buildbot
  2018-01-18 12:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 19:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5e2db402c8e665b0c6ac81047a10cbf4e26329f2 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 5e2db402c8e665b0c6ac81047a10cbf4e26329f2

Unify new_symbol and new_symbol_full

This patch unifies new_symbol with new_symbol_full, replacing a
wrapper function with a default parameter.

2018-01-17  Tom Tromey  <tom@tromey.com>

	* dwarf2read.c (dwarf2_compute_name): Update comment.
	(read_func_scope, read_variable): Update.
	(new_symbol): Remove.
	(new_symbol_full): Rename to new_symbol.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Allocate dwarf2_cu with new
@ 2018-01-17 19:45 sergiodj+buildbot
  2018-01-18 16:05 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 19:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fcd3b13d80a2d0e5fc31ef6a245be62db6a11420 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: fcd3b13d80a2d0e5fc31ef6a245be62db6a11420

Allocate dwarf2_cu with new

This changes dwarf2_cu to be allocated with new, and fixes up the
users.

2018-01-17  Tom Tromey  <tom@tromey.com>
	    Simon Marchi  <simon.marchi@ericsson.com>

	* dwarf2read.c (struct dwarf2_cu): Add constructor, destructor.
	(dwarf2_per_objfile::free_cached_comp_units)
	(init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
	(init_cutu_and_read_dies_no_follow): Update.
	(dwarf2_cu::dwarf2_cu): Rename from init_one_comp_unit.
	(dwarf2_cu::~dwarf2_cu): New.
	(free_heap_comp_unit, free_stack_comp_unit): Remove.
	(age_cached_comp_units, free_one_cached_comp_unit): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Change dwarf2_cu::method_info to be a std::vector
@ 2018-01-17 19:57 sergiodj+buildbot
  2018-01-18 17:43 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 19:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c89b44cdc52b6a9c0848a795689895e292ad1f46 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: c89b44cdc52b6a9c0848a795689895e292ad1f46

Change dwarf2_cu::method_info to be a std::vector

This changes the type of dwarf2_cu::method_info and fixes up the uses.
In order to remove cleanups from process_full_comp_unit and
process_full_type_unit, psymtab_include_file_name also had to be
changed to avoid leaving dangling cleanups.

2018-01-17  Tom Tromey  <tom@tromey.com>

	* dwarf2read.c (delayed_method_info): Remove typedef.
	(dwarf2_cu::method_info): Now a std::vector.
	(add_to_method_list): Update.
	(free_delayed_list): Remove.
	(compute_delayed_physnames): Update.
	(process_full_comp_unit, process_full_type_unit): Clear the method
	list.  Remove cleanups.
	(psymtab_include_file_name): Add name_holder parameter.  Use
	unique_xmalloc_ptr.
	(dwarf_decode_lines): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove objfile argument from add_dyn_prop
@ 2018-01-17 20:09 sergiodj+buildbot
  2018-01-18 20:13 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 20:09 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 50a820477b5d48d4c2d28ca1c22ba6d93c9fd7cb ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 50a820477b5d48d4c2d28ca1c22ba6d93c9fd7cb

Remove objfile argument from add_dyn_prop

The objfile argument to add_dyn_prop is redundant, so this patch
removes it.

2018-01-17  Tom Tromey  <tom@tromey.com>

	* gdbtypes.h (add_dyn_prop): Remove objfile parameter.
	* gdbtypes.c (add_dyn_prop): Remove objfile parameter.
	(create_array_type_with_stride): Update.
	* dwarf2read.c (set_die_type): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Allocate abbrev_table with new
@ 2018-01-17 20:16 sergiodj+buildbot
  2018-01-18 14:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 20:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 685af9cd2283b07a222157723e239f09d6ea2682 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 685af9cd2283b07a222157723e239f09d6ea2682

Allocate abbrev_table with new

This changes dwarf2read.c to allocate abbrev tables using "new", and
then updates the users.

This version of the patch incorporates the changes that Simon
implemented.  These changes simplify the ownership rules for abbrev
tables.

2018-01-17  Tom Tromey  <tom@tromey.com>
	    Simon Marchi  <simon.marchi@ericsson.com>

	* dwarf2read.c (struct dwarf2_cu) <abbrev_table>: Remove.
	(struct die_reader_specs) <abbrev_table>: New member.
	(struct abbrev_table): Add constructor.
	<alloc_abbrev, add_abbrev, lookup_abbrev>: Declare.
	<abbrev_obstack>: Now an auto_obstack.
	(abbrev_table_up): New typedef.
	(init_cu_die_reader): Add abbrev_table parameter.
	(read_cutu_die_from_dwo): Remove abbrev_table_provided parameter.
	Add result_dwo_abbrev_table.
	(init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
	(init_cutu_and_read_dies_no_follow, build_type_psymtabs_1):
	Update.
	(peek_die_abbrev): Take die_reader_specs, not dwarf_cu as
	parameter.
	(skip_children): Update.
	(abbrev_table::alloc_abbrev): Rename from
	abbrev_table_alloc_abbrev.
	(abbrev_table::add_abbrev): Rename from abbrev_table_add_abbrev.
	(abbrev_table::lookup_abbrev): Rename from
	abbrev_table_lookup_abbrev.
	(abbrev_table_read_table): Return abbrev_table_up.
	(abbrev_table_free, abbrev_table_free_cleanup)
	(dwarf2_read_abbrevs, dwarf2_free_abbrev_table): Remove.
	(load_partial_dies): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove symbolp typedef
@ 2018-01-17 20:21 sergiodj+buildbot
  2018-01-18 22:00 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 20:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9e14690d06ac55136b7f051a2d2b8e173fa3bbdf ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 9e14690d06ac55136b7f051a2d2b8e173fa3bbdf

Remove symbolp typedef

This removes the symbolp typedef from dwarf2read.c.  It is no longer
used.

2018-01-17  Tom Tromey  <tom@tromey.com>

	* dwarf2read.c (symbolp): Remove typedef.  Don't instantiate VEC.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] RISC-V: Fix bug in prior addi/c.nop patch.
@ 2018-01-17 22:21 sergiodj+buildbot
  2018-01-19  0:27 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 22:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e925c834ecdb4a0ce595ad8d3da9c7d4f499ede0 ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: e925c834ecdb4a0ce595ad8d3da9c7d4f499ede0

RISC-V: Fix bug in prior addi/c.nop patch.

	gas/
	* config/tc-riscv.c (validate_riscv_insn) <'z'>: New.
	(riscv_ip) <'z'>: New.
	opcodes/
	* riscv-opc.c (riscv_opcodes) <addi>: Use z instead of 0.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix warning on gdb/compile/compile.c (C++-ify "triplet_rx")
@ 2018-01-17 23:20 sergiodj+buildbot
  2018-01-19  3:18 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 23:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7d937cad0acdccd0ff485435fbe16f005e994c66 ***

Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: 7d937cad0acdccd0ff485435fbe16f005e994c66

Fix warning on gdb/compile/compile.c (C++-ify "triplet_rx")

This fixes a GCC warning that happens when compiling
gdb/compile/compile.c on some GCC versions (e.g., "gcc (GCC) 7.2.1
20180104 (Red Hat 7.2.1-6)"):

../../gdb/compile/compile.c: In function 'void eval_compile_command(command_line*, const char*, compile_i_scope_types, void*)':
../../gdb/compile/compile.c:548:19: warning: 'triplet_rx' may be used uninitialized in this function [-Wmaybe-uninitialized]
     error_message = compiler->fe->ops->set_arguments_v0 (compiler->fe, triplet_rx,
     ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         argc, argv);
         ~~~~~~~~~~~
../../gdb/compile/compile.c:466:9: note: 'triplet_rx' was declared here
   char *triplet_rx;
         ^~~~~~~~~~

It's a simple patch that converts "triplet_rx" from "char *" to
"std::string", thus guaranteeing that it will be always initialized.

I've regtested this patch and did not find any regressions.  OK to
apply on both master and 8.1 (after creating a bug for it)?

gdb/ChangeLog:
2018-01-17  Sergio Durigan Junior  <sergiodj@redhat.com>

	* compile/compile.c (compile_to_object): Convert "triplet_rx"
	to "std::string".


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PowerPC PLT stub alignment fixes
@ 2018-01-18 12:14 sergiodj+buildbot
  2018-01-19  8:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-18 12:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 691d2e9af211ff8dd5fa8c96cb961b73a78394d7 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 691d2e9af211ff8dd5fa8c96cb961b73a78394d7

PowerPC PLT stub alignment fixes

Asking for ppc32 plt call stubs to be aligned at 32 byte boundaries
didn't quite work.  For ld.bfd they were spaced 32 bytes apart, but
only started on a 16 byte boundary.  ld.gold also didn't get it right.

Finding that bug made me check over the ppc64 plt stub alignment,
where I found that negative values for alignment (meaning align to
minimize boundary crossing) were not accepted.  Since no one has
complained about that, I guess I could have removed the feature from
ld.bfd documentation, but I've opted instead to correct the code.

I've also added an optional alignment paramenter for ppc32
--plt-align, for some consistency with gold and ppc64 ld.bfd.

bfd/
	* elf32-ppc.c (ppc_elf_create_glink): Correct alignment of .glink.
	* elf64-ppc.c (ppc64_elf_size_stubs): Handle negative plt_stub_align.
	(ppc64_elf_build_stubs): Likewise.
gold/
	* powerpc.cc (param_plt_align): New function supplying default
	--plt-align values.  Use it..
	(Stub_table::plt_call_align): ..here, and..
	(Output_data_glink::global_entry_align): ..here.
	(Stub_table::stub_align): Correct 32-bit minimum alignment.
ld/
	* emultempl/ppc32elf.em: Support optional --plt-align arg.
	* emultempl/ppc64elf.em: Support negative --plt-align arg.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Call cooked_read in ppu2spu_prev_register
@ 2018-01-18 12:35 sergiodj+buildbot
  2018-01-19 10:58 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-18 12:35 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d679c21a43852305c5eeae957854f6e13d6f884c ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: d679c21a43852305c5eeae957854f6e13d6f884c

Call cooked_read in ppu2spu_prev_register

The code in ppu2spu_prev_register is in fact regcache_cooked_read,
because spu doesn't have gdbarch method pseudo_register_read_value.

gdb:

2018-01-18  Yao Qi  <yao.qi@linaro.org>

	* ppc-linux-tdep.c (ppu2spu_prev_register): Call cooked_read.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Make abbrev_table::abbrevs private
@ 2018-01-18 15:43 sergiodj+buildbot
  2018-01-19 14:04 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-18 15:43 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4a17f7688fbab8f170144fa13ffcd06bc749e6ec ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 4a17f7688fbab8f170144fa13ffcd06bc749e6ec

Make abbrev_table::abbrevs private

abbrev_table::abbrevs is only access within abbrev_table's methods, so
it can be private.  Add "m_" prefix.

gdb:

2018-01-18  Yao Qi  <yao.qi@linaro.org>

	* dwarf2read.c (abbrev_table) <abbrevs>: Rename it to
	m_abbrevs.
	(abbrev_table::add_abbrev): Update.
	(abbrev_table::lookup_abbrev): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] S390: Use soft float in s390-tdbregs test case
@ 2018-01-18 18:56 sergiodj+buildbot
  2018-01-19 15:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-18 18:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 25d4fd80936744adfa49f133524e3f342604a1cb ***

Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: 25d4fd80936744adfa49f133524e3f342604a1cb

S390: Use soft float in s390-tdbregs test case

The GDB test case s390-tdbregs.exp verifies GDB's handling of the
"transaction diagnostic block".  For simplicity, the test case uses the
"transaction begin" (TBEGIN) instruction with the "allow floating-point
operation" flag set to zero.  But some GCC versions may indeed emit
floating point or vector instructions for this test case.  If this happens
in the transaction, it aborts, and an endless loop results.

This change tells the compiler to produce a soft-float binary, so no
floating-point or vector registers are touched.

gdb/testsuite/ChangeLog:

	* gdb.arch/s390-tdbregs.exp: Add the compile option -msoft-float.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] GDB testsuite: Re-enable -fdiagnostics-color=never
@ 2018-01-18 19:09 sergiodj+buildbot
  2018-01-19 18:38 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-18 19:09 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT dcc069254040954ee72b3ed65b772d48cdff93df ***

Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: dcc069254040954ee72b3ed65b772d48cdff93df

GDB testsuite: Re-enable -fdiagnostics-color=never

In August 2017 the GDB test suite was changed to always add the compile
option "-fdiagnostics-color=never", see:

  https://sourceware.org/ml/gdb-patches/2017-08/msg00150.html

Since this option is not understood by rustc, a commit from 09/2017
dropped its use in that case:

  https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=5eb5f850
  ("Don't use -fdiagnostics-color=never for rustc")

But that change goes overboard and stops using the option for other
languages as well.  Thus compiler diagnostics written into gdb.log may
contain colored output again.  This is fixed.

gdb/testsuite/ChangeLog:

	* lib/gdb.exp (gdb_compile): Re-enable use of
	universal_compile_options for languages other than Rust.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Make tests expect [ \t]+ pattern instead of \t for "info reg" command
@ 2018-01-19  6:21 sergiodj+buildbot
  2018-01-19 20:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-19  6:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT adf8243ba9220966bbb8f67460b2d323e00cbfdb ***

Author: Ruslan Kabatsayev <b7.10110111@gmail.com>
Branch: master
Commit: adf8243ba9220966bbb8f67460b2d323e00cbfdb

Make tests expect [ \t]+ pattern instead of \t for "info reg" command

This will allow to format output of "info reg" command as we wish,
without breaking the tests. In particular, it'll let us correctly align
raw and natural values of the registers using spaces instead of current
badly-working approach with tabs.

This change is forwards- and backwards-compatible, so that the amended
tests will work in the same way before and after reformatting patches
(unless the tests check formatting, of course, but I've not come across
any such tests).

Some tests already used this expected pattern, so they didn't
even have to be modified. Others are changed by this patch.

I've checked this on a i386 system, with no noticeable differences in
test results, so at least on i386 nothing seems to be broken by this.

gdb/testsuite/ChangeLog:

	* gdb.arch/powerpc-d128-regs.exp: Replace expected "\[\t\]*" from
	"info reg" with "\[ \t\]*".
	* gdb.arch/altivec-regs.exp: Replace expected "\t" from "info reg" with
	"\[ \t\]+".
	* gdb.arch/s390-multiarch.exp: Ditto.
	* gdb.base/pc-fp.exp: Ditto.
	* gdb.reverse/i386-precsave.exp: Ditto.
	* gdb.reverse/i386-reverse.exp: Ditto.
	* gdb.reverse/i387-env-reverse.exp: Ditto.
	* gdb.reverse/i387-stack-reverse.exp: Ditto.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Find arm-linux-gnueabi(hf)?-gcc in compile
@ 2018-01-19  9:33 sergiodj+buildbot
  2018-01-19 21:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-19  9:33 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT dea445b940545f9564972c5410ac8792b72cc9c3 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: dea445b940545f9564972c5410ac8792b72cc9c3

Find arm-linux-gnueabi(hf)?-gcc in compile

GCC for arm-linux has different names on different distros.  It is
arm-linux-gnu-gcc on fedora.  Debian/Ubuntu has arm-linux-gnueabihf-gcc
and arm-linux-gnueabi-gcc.  So when I run gdb.compile/ tests on arm-linux,
I get,

(gdb) compile code -- ;
Could not find a compiler matching "^arm(-[^-]*)?-linux(-gnu)?-gcc$"

This patch extend the regexp to match both arm-linux-gnu-gcc and
arm-linux-gnueabihf-gcc.

gdb:

2018-01-19  Yao Qi  <yao.qi@linaro.org>

	* osabi.c (gdb_osabi_names): Extend the regexp for
	arm-linux-gnueabihf and arm-linux-gnueabi.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Don't pass -m32 to libcc1 on arm-linux
@ 2018-01-19 10:00 sergiodj+buildbot
  2018-01-19 23:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-19 10:00 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 88af8ea80b9732f951e61a4ed8868e722f337c8e ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 88af8ea80b9732f951e61a4ed8868e722f337c8e

Don't pass -m32 to libcc1 on arm-linux

When I run gdb.compile/ tests on arm-linux, I get the following fails,

(gdb) compile code -- ;^M
arm-none-linux-gnueabihf-gcc: error: unrecognized command line option '-m32'; did you mean '-mbe32'?^M
Compilation failed.^M
(gdb) compile code (void) param^M
arm-none-linux-gnueabihf-gcc: error: unrecognized command line option '-m32'; did you mean '-mbe32'?^M
Compilation failed.^M
(gdb) FAIL: gdb.compile/compile-ops.exp: compile code (void) param

This patch fixes it by implementing gcc_target_options gdbarch method
for arm-linux to override option "-m32".

gdb:

2018-01-19  Yao Qi  <yao.qi@linaro.org>

	* arm-linux-tdep.c (arm_linux_gcc_target_options): New function.
	(arm_linux_init_abi): Install it.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Update French translation in bfd sub-directory
@ 2018-01-19 11:05 sergiodj+buildbot
  2018-01-20  1:44 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-19 11:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ee3fbc1ebb0cdd0785f4c328c5daaa4a4cdf3f91 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: ee3fbc1ebb0cdd0785f4c328c5daaa4a4cdf3f91

Update French translation in bfd sub-directory


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] S390: Improve comments for s390-tdbregs test case
@ 2018-01-19 13:35 sergiodj+buildbot
  2018-01-20  5:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-19 13:35 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d6ad07fdef94777bb512f072361706bcc743d51c ***

Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: d6ad07fdef94777bb512f072361706bcc743d51c

S390: Improve comments for s390-tdbregs test case

This adds more explanation as to why the test case must be compiled with
the -msoft-float option.  It also documents the my_tbegin and my_tend
functions.

gdb/testsuite/ChangeLog:

	* gdb.arch/s390-tdbregs.c (my_tbegin): Add comment documenting the
	function.
	(my_tend): Likewise.
	* gdb.arch/s390-tdbregs.exp: Enhance comment; explain the
	rationale of avoiding FP- and vector instructions.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove args from target detach
@ 2018-01-19 17:17 sergiodj+buildbot
  2018-01-20  6:45 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-19 17:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6bd6f3b6569945700386847f624dc9e8b7f57450 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 6bd6f3b6569945700386847f624dc9e8b7f57450

Remove args from target detach

I was looking into adding a parameter to target_detach, and was
wondering what the args parameter was.  It seems like in the distant
past, it was possible to specify a signal number when detaching.  That
signal was injected in the process before it was detached.  There is an
example of code handling this in linux_nat_detach.  With today's GDB, I
can't get this to work.  Doing "detach 15" (15 == SIGTERM) doesn't work,
because detach is a prefix command and doesn't recognize the sub-command
15.  Doing "detach inferiors 15" doesn't work because it expects a list
of inferior id to detach.  Therefore, I don't think there's a way of
invoking detach_command with a non-NULL args.  I also didn't find any
documentation related to this feature.

I assume that this feature stopped working when detach was made a prefix
command, which is in f73adfeb8bae36885e6ea248d12223ab0d5eb9cb (sorry,
there's no commit title) from 2006.  Given that this feature was broken
for such a long time and we haven't heard anything (AFAIK, I did not
find any related bug), I think it's safe to remove it, as well as the
args parameter to target_detach.  If someone wants to re-introduce it, I
would suggest rethinking the user interface, and in particular would
suggest using signal name instead of numbers.

I tried to fix all the impacted code, but I might have forgotten some
spots.  It shouldn't be hard to fix if that's the case.  I also couldn't
build-test everything I changed, especially the nto and solaris stuff.

gdb/ChangeLog:

	* target.h (struct target_ops) <to_detach>: Remove args
	parameter.
	(target_detach): Likewise.
	* target.c (dispose_inferior): Adjust.
	(target_detach): Remove args parameter, adjust.
	* aix-thread.c (aix_thread_detach): Adjust.
	* corefile.c (core_file_command): Adjust.
	* corelow.c (core_detach): Adjust.
	* darwin-nat.c (darwin_detach): Adjust.
	* gnu-nat.c (gnu_detach): Adjust.
	* inf-ptrace.c (inf_ptrace_detach): Adjust.
	* infcmd.c (detach_command): Adjust
	* infrun.c (follow_fork_inferior): Adjust.
	(handle_vfork_child_exec_or_exit): Adjust.
	* linux-fork.c (linux_fork_detach): Remove args parameter.
	* linux-fork.h (linux_fork_detach): Likewise.
	* linux-nat.c (linux_nat_detach): Likewise, and adjust.
	* linux-thread-db.c (thread_db_detach): Likewise.
	* nto-procfs.c (procfs_detach): Likewise.
	* procfs.c (procfs_detach): Likewise.
	(do_detach): Remove signo parameter.
	* record.c (record_detach): Remove args parameter.
	* record.h (record_detach): Likewise.
	* remote-sim.c (gdbsim_detach): Likewise.
	* remote.c (remote_detach_1): Likewise.
	(remote_detach): Likewise.
	(extended_remote_detach): Likewise.
	* sol-thread.c (sol_thread_detach): Likewise.
	* target-delegates.c: Re-generate.
	* top.c (struct qt_args) <args>: Remove field.
	(kill_or_detach): Don't pass args.
	(quit_force): Don't set args.
	* windows-nat.c (windows_detach): Remove args parameter.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Pass inferior down to target_detach and to_detach
@ 2018-01-19 17:34 sergiodj+buildbot
  2018-01-20  8:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-19 17:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6e1e1966bac965c5a26b5e5cae69cb0ed21be4cc ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 6e1e1966bac965c5a26b5e5cae69cb0ed21be4cc

Pass inferior down to target_detach and to_detach

The to_detach target_ops method implementations are currently expected
to work on current_inferior/inferior_ptid.  In order to make things more
explicit, and remove some "shadow" parameter passing through globals,
this patch adds an "inferior" parameter to to_detach.  Implementations
will be expected to use this instead of relying on the global.  However,
to keep things simple, this patch only does the minimum that is
necessary to add the parameter.  The following patch gives an example of
how one such implementation would be adapted.  If the approach is deemed
good, we can then look into adapting more implementations.  Until then,
they'll continue to work as they do currently.

gdb/ChangeLog:

	* target.h (struct target_ops) <to_detach>: Add inferior
	parameter.
	(target_detach): Likewise.
	* target.c (dispose_inferior): Pass inferior down.
	(target_detach): Pass inferior down.  Assert that it is equal to
	the current inferior.
	* aix-thread.c (aix_thread_detach): Pass inferior down.
	* corefile.c (core_file_command): Pass current_inferior() down.
	* corelow.c (core_detach): Add inferior parameter.
	* darwin-nat.c (darwin_detach): Likewise.
	* gnu-nat.c (gnu_detach): Likewise.
	* inf-ptrace.c (inf_ptrace_detach): Likewise.
	* infcmd.c (detach_command): Pass current_inferior() down to
	target_detach.
	* infrun.c (follow_fork_inferior): Pass parent_inf to
	target_detach.
	(handle_vfork_child_exec_or_exit): Pass inf->vfork_parent to
	target_detach.
	* linux-nat.c (linux_nat_detach): Add inferior parameter.
	* linux-thread-db.c (thread_db_detach): Likewise.
	* nto-procfs.c (procfs_detach): Likewise.
	* procfs.c (procfs_detach): Likewise.
	* record.c (record_detach): Likewise.
	* record.h (struct inferior): Forward-declare.
	(record_detach): Add inferior parameter.
	* remote-sim.c (gdbsim_detach): Likewise.
	* remote.c (remote_detach_1): Likewise.
	(remote_detach): Likewise.
	(extended_remote_detach): Likewise.
	* sol-thread.c (sol_thread_detach): Likewise.
	* target-debug.h (target_debug_print_inferior_p): New macro.
	* target-delegates.c: Re-generate.
	* top.c (kill_or_detach): Pass inferior down to target_detach.
	* windows-nat.c (windows_detach): Add inferior parameter.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Make linux_nat_detach/thread_db_detach use the inferior parameter
@ 2018-01-19 17:48 sergiodj+buildbot
  2018-01-20 11:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-19 17:48 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bc09b0c14fb713a9aec25e09b78499f3bc2441b5 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: bc09b0c14fb713a9aec25e09b78499f3bc2441b5

Make linux_nat_detach/thread_db_detach use the inferior parameter

This patch makes these two functions actually use the inferior parameter
added by the previous patch, instead of reading inferior_ptid.  I chose
these two, because they are the one actually used when I detach on my
GNU/Linux system, so they were easy to test.

I took the opportunity to pass the inferior being detached to
inf_ptrace_detach_success, so it could use it too.  From there, it made
sense to add an overload of detach_inferior that takes the inferior
directly rather than the pid, to avoid having to pass inf->pid only for
the callee to look up the inferior structure by pid.

gdb/ChangeLog:

	* inf-ptrace.c (inf_ptrace_detach): Adjust call to
	inf_ptrace_detach_success.
	(inf_ptrace_detach_success): Add inferior parameter, use it
	instead of inferior_ptid, pass it to detach_inferior.
	* inf-ptrace.h (inf_ptrace_detach_success): Add inferior
	parameter.
	* inferior.c (detach_inferior): Add overload that takes an
	inferior object.
	* inferior.h (detach_inferior): Likewise.
	* linux-nat.c (linux_nat_detach): Use the inf parameter, don't
	use inferior_ptid, adjust call to inf_ptrace_detach_success.
	* linux-thread-db.c (thread_db_detach): Use inf parameter.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb: Fix ia64 defining TRAP_HWBKPT before including gdb_wait.h
@ 2018-01-19 19:04 sergiodj+buildbot
  2018-01-20 14:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-19 19:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5a6c3296a7a90694ad4042f6256f3da6d4fa4ee8 ***

Author: James Clarke <jrtc27@jrtc27.com>
Branch: master
Commit: 5a6c3296a7a90694ad4042f6256f3da6d4fa4ee8

gdb: Fix ia64 defining TRAP_HWBKPT before including gdb_wait.h

On ia64, gdb_wait.h eventually includes siginfo-consts-arch.h, which
contains an enum with TRAP_HWBKPT, along with a #define. Thus we cannot
define TRAP_HWBKPT to 4 beforehand, and so gdb_wait.h must be included
earlier; include it from linux-ptrace.h so it can never come afterwards.

gdb/ChangeLog:

	* nat/linux-ptrace.c: Remove unnecessary reinclusion of
	gdb_ptrace.h, and move including gdb_wait.h ...
	* nat/linux-ptrace.h: ... to here.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb: Add missing #ifdef USE_THREAD_DB to gdbserver
@ 2018-01-19 19:06 sergiodj+buildbot
  2018-01-20 17:04 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-19 19:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a0aad53764f45a634462288befe4c2eaecbf302d ***

Author: James Clarke <jrtc27@jrtc27.com>
Branch: master
Commit: a0aad53764f45a634462288befe4c2eaecbf302d

gdb: Add missing #ifdef USE_THREAD_DB to gdbserver

Otherwise, linking fails with:

  [...]/linux-low.c:664: undefined reference to `thread_db_notice_clone(thread_info*, ptid_t)'

gdb/gdbserver/ChangeLog:

	* linux-low.c (handle_extended_wait): Surround call to
	thread_db_notice_clone with #ifdef USE_THREAD_DB.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] S390: Fix infcalls in s390-vregs test case
@ 2018-01-19 19:19 sergiodj+buildbot
  2018-01-20 19:36 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-19 19:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 634c1c3109a2ffdf43ef9dab839c88108d9980f3 ***

Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: 634c1c3109a2ffdf43ef9dab839c88108d9980f3

S390: Fix infcalls in s390-vregs test case

GDB used to assume that functions without debug info return int.  It
accepted an expression containing such a function call and silently
interpreted the function's return value as int.  But nowadays GDB yields
an error message instead, see

  https://sourceware.org/ml/gdb-patches/2017-07/msg00139.html

This affects the s390-vregs test case, because it contains calls to
setrlimit64 and chdir.  When no glibc debug info is installed, these lead
to unnecessary FAILs.  Fix this by adding appropriate casts to the
inferior function calls.

gdb/testsuite/ChangeLog:

	* gdb.arch/s390-vregs.exp: Explicitly cast the return values of
	setrlimit and chdir to int.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix qualified name lookup for Rust
@ 2018-01-19 22:47 sergiodj+buildbot
  2018-01-20 21:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-19 22:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fcfcc376969c4d7a6d20827c47b584db389a32b9 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: fcfcc376969c4d7a6d20827c47b584db389a32b9

Fix qualified name lookup for Rust

In https://github.com/rust-lang/rust/pull/46457, "m4b" pointed out
that the Rust support in gdb doesn't properly handle the lookup of
qualified names.

In particular, as shown in the test case in this patch, something like
"::NAME" should be found in the global scope, but is not.

This turns out to happen because rust_lookup_symbol_nonlocal does not
search the global scope unless the name in question is unqualified.
However, lookup_symbol_aux does not search the global scope, and
appears to search the static scope only as a fallback (I wonder if
this is needed?).

This patch fixes the problem by changing rust_lookup_symbol_nonlocal
to search the static and global blocks in more cases.

Regression tested against various versions of the rust compiler on
Fedora 26 x86-64.  (Note that there are unrelated failures with newer
versions of rustc; I will be addressing those separately.)

2018-01-19  Tom Tromey  <tom@tromey.com>

	* rust-lang.c (rust_lookup_symbol_nonlocal): Look up qualified
	symbols in the static and global blocks.

2018-01-19  Tom Tromey  <tom@tromey.com>

	* gdb.rust/modules.rs (TWENTY_THREE): New global.
	* gdb.rust/modules.exp: Add ::-qualified lookup test.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: Check the versioned __tls_get_addr symbol
@ 2018-01-20 22:46 sergiodj+buildbot
  2018-01-20 23:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-20 22:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8a1b824af786989f879ab1421a4279f60bba141a ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 8a1b824af786989f879ab1421a4279f60bba141a

x86: Check the versioned __tls_get_addr symbol

We need to check the versioned __tls_get_addr symbol when looking up
"__tls_get_addr".

bfd/

	PR ld/22721
	* elfxx-x86.c (_bfd_x86_elf_link_check_relocs): Check the
	versioned __tls_get_addr symbol.

ld/

	PR ld/22721
	* testsuite/ld-plugin/lto.exp: Run PR ld/22721 tests.
	* testsuite/ld-plugin/pr22721.t: New file.
	* testsuite/ld-plugin/pr22721a.s: Likewise.
	* testsuite/ld-plugin/pr22721b.c: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb: Add test for some error cases of @entry usage
@ 2018-01-21 15:22 sergiodj+buildbot
  2018-01-21 15:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-21 15:22 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b1b189e04cb5ea5da1cbb07bd6cceccd4d2ac969 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: b1b189e04cb5ea5da1cbb07bd6cceccd4d2ac969

gdb: Add test for some error cases of @entry usage

Adds a test that using @entry for a non-parameter, or for an unknown
symbol, both give the expected error.  This error message was
previously untested.

gdb/testsuite/ChangeLog:

	* gdb.arch/amd64-entry-value.exp: Test using @entry on a
	non-parameter, and on an unknown symbol.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb: Remove duplicate declaration of global innermost_block
@ 2018-01-21 16:05 sergiodj+buildbot
  2018-01-21 17:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-21 16:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 396af9a1527b396c251e70b5c79b5fc83fd1d7ff ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 396af9a1527b396c251e70b5c79b5fc83fd1d7ff

gdb: Remove duplicate declaration of global innermost_block

The global 'innermost_block' is declared in two header files.  Remove
one of the declarations, and add an include of the other header into
the one source file that could no longer see a declaration of
'innermost_block'.

gdb/ChangeLog:

	* expression.h (innermost_block): Remove declaration.
	* varobj.c: Add 'parser-defs.h' include.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb: Remove out of date comment
@ 2018-01-21 16:42 sergiodj+buildbot
  2018-01-21 22:59 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-21 16:42 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 03d0bf7b78b142a5e03dfa1c80100893753d0022 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 03d0bf7b78b142a5e03dfa1c80100893753d0022

gdb: Remove out of date comment

Comment clean up.

gdb/ChangeLog:

	* varobj.c (varobj_create): Remove out of date comment.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb: New API for tracking innermost block
@ 2018-01-21 16:50 sergiodj+buildbot
  2018-01-21 19:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-21 16:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT aee1fcdf979d65c7623533ddd6d871767be9de13 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: aee1fcdf979d65c7623533ddd6d871767be9de13

gdb: New API for tracking innermost block

This commit is preparation for a later change, at this point there
should be no user visible change.

We currently maintain a global innermost_block which tracks the most
inner block encountered when parsing an expression.

This commit wraps the innermost_block into a new class, and switches all
direct accesses to the variable to use the class API.

gdb/ChangeLog:

	* ada-exp.y (write_var_from_sym): Switch to innermost_block API.
	* ada-lang.c (resolve_subexp): Likewise.
	* breakpoint.c (set_breakpoint_condition) Likewise.
	(watch_command_1) Likewise.
	* c-exp.y (variable): Likewise.
	* d-exp.y (PrimaryExpression): Likewise.
	* f-exp.y (variable): Likewise.
	* go-exp.y (variable): Likewise.
	* m2-exp.y (variable): Likewise.
	* objfiles.c (objfile::~objfile): Likewise.
	* p-exp.y (variable): Likewise.
	* parse.c (innermost_block): Change type.
	* parser-defs.h (class innermost_block_tracker): New.
	(innermost_block): Change to innermost_block_tracker.
	* printcmd.c (display_command): Switch to innermost_block API.
	(do_one_display): Likewise.
	* rust-exp.y (do_one_display): Likewise.
	* symfile.c (clear_symtab_users): Likewise.
	* varobj.c (varobj_create): Switch to innermost_block API, replace
	use of innermost_block with block stored on varobj object.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb: PR mi/20395: Fix -var-update for registers in frames 1 and up
@ 2018-01-21 17:01 sergiodj+buildbot
  2018-01-21 20:48 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-21 17:01 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ae45162705fb76ee534336474a67b11373209c62 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: ae45162705fb76ee534336474a67b11373209c62

gdb: PR mi/20395: Fix -var-update for registers in frames 1 and up

This patch fixes a problem with using the MI -var-update command
to access the values of registers in frames other than the current
frame.  The patch includes a test that demonstrates the problem:

* run so there are several frames on the stack
* create a fixed varobj for $pc in each frame, #'s 1 and above
* step one instruction, to modify the value of $pc
* call -var-update for each of the previously created varobjs
  to verify that they are not reported as having changed.

Without the patch, the -var-update command reported that $pc for all
frames 1 and above had changed to the value of $pc in frame 0.

A varobj is created as either fixed, the expression is evaluated within
the context of a specific frame, or floating, the expression is
evaluated within the current frame, whatever that may be.

When a varobj is created by -var-create we set two fields of the varobj
to track the context in which the varobj was created, these two fields
are varobj->root->frame and var->root->valid_block.

If a varobj is of type fixed, then, when we subsequently try to
reevaluate the expression associated with the varobj we must determine
if the original frame (and block) is still available, if it is not then
the varobj can no longer be evaluated.

The problem is that for register expressions varobj->root->valid_block
is not set correctly.  This block tracking is done using the global
'innermost_block' which is set in the various parser files (for example
c-exp.y).  However, this is not set for register expressions.

The fix then seems like it should be to just update the innermost block
when parsing register expressions, however, that solution causes several
test regressions.

The problem is that in some cases we rely on the expression parsing
code not updating the innermost block for registers, one example is
when we parse the expression for a 'display' command.  The display
commands treats registers like floating varobjs, but symbols are
treated like fixed varobjs.  So 'display $reg_name' will always show
the value of '$reg_name' even as the user moves from frame to frame,
while 'display my_variable' will only show 'my_variable' while it is
in the current frame and/or block, when the user moves to a new frame
and/or block (even one with a different 'my_variable' in) then the
display of 'my_variable' stops.  For the case of 'display', without
the option to force fixed or floating expressions, the current
behaviour is probably the best choice.  For the varobj system though,
we can choose between floating and fixed, and we should try to make
this work for registers.

There's only one existing test case that needs to be updated, in that
test a fixed varobj is created using a register, the MI output now
include the thread-id in which the varobj should be evaluated, which I
believe is correct behaviour.  I also added a new floating test case
into the same test script, however, right now this also includes the
thread-id in the expected output, which I believe is an existing gdb
bug, which I plan to fix next.

Tested on x86_64 Linux native and native-gdbserver, no regressions.

gdb/ChangeLog:

	PR mi/20395
	* ada-exp.y (write_var_from_sym): Pass extra parameter when
	updating innermost block.
	* parse.c (innermost_block_tracker::update): Take extra type
	parameter, and check types match before updating innermost block.
	(write_dollar_variable): Update innermost block for registers.
	* parser-defs.h (enum innermost_block_tracker_type): New enum.
	(innermost_block_tracker::innermost_block_tracker): Initialise
	m_types member.
	(innermost_block_tracker::reset): Take type parameter.
	(innermost_block_tracker::update): Take type parameter, and pass
	type through as needed.
	(innermost_block_tracker::m_types): New member.
	* varobj.c (varobj_create): Pass type when reseting innermost
	block.

gdb/testsuite/ChangeLog:

	* gdb.mi/basics.c: Add new global.
	* gdb.mi/mi-frame-regs.exp: New file.
	* gdb.mi/mi-var-create-rtti.exp: Update expected results, add new
	case.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb: Don't store a thread-id for floating varobj
@ 2018-01-21 19:13 sergiodj+buildbot
  2018-01-22  1:14 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-21 19:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e707fc445e68ccfa136a52cd4989b0cb778d1ca7 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: e707fc445e68ccfa136a52cd4989b0cb778d1ca7

gdb: Don't store a thread-id for floating varobj

When creating a varobj with -var-create a user can create either fixed
varobj, or floating varobj.

A fixed varobj will always be evaluated within the thread/frame/block in
which the varobj was created, if that thread/frame/block is no longer
available then the varobj is considered out of scope.

A floating varobj will always be evaluated within the current
thread/frame/block.

Despite never using them GDB was storing the thread/frame/block into a
floating varobj, and the thread-id would then be displayed when GDB
reported on the state of the varobj, this could confuse a user into
thinking that the thread-id was relevant.

This commit prevents GDB storing the thread/frame/block onto floating
varobj, and updates the few tests where this impacts the results.

gdb/ChangeLog:

	* varobj.c (varobj_create): Don't set valid_block when creating a
	floating varobj.

gdb/testsuite/ChangeLog:

	* gdb.python/py-mi.exp: Don't expect a thread-id for floating
	varobj.
	* gdb.mi/mi-var-create-rtti.exp: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] wrong line number in breakpoint location
@ 2018-01-22  4:32 sergiodj+buildbot
  2018-01-22  4:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-22  4:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a9e408182d2faaed5c2457b68ea3276c719a590f ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: a9e408182d2faaed5c2457b68ea3276c719a590f

wrong line number in breakpoint location

Consider the following situation, where we have one file containing...

    $ cat -n body.inc
         1  i = i + 1;

... we include that file from some code, like so:

    $ cat -n cat -n small.c
        [...]
        17  int
        18  next (int i)
        19  {
        20  #include "body.inc"
        21    return i;
        22  }

When trying to insert a breakpoint on line 18, for instance:

    (gdb) b small.c:18
    Breakpoint 1 at 0x40049f: file body.inc, line 18.
                                                  ^^
                                                  ||

Here, the issue is that GDB reports the breakpoint to be in file
body.inc, which is true, but with the line number that corresponding
to the user-requested location, which is not correct.

Although the simple reproducer may look slightly artificial,
the above is simply one way to reproduce the same issue observed
when trying to insert a breakpoint on a function provided in
a .h files and then subsequently inlined in a C file.

What happens is the following:

  1. We resolve the small.c:18 linespec into a symtab_and_line which
     has "small.c" and 18 as the symtab and line number.

  2. Next, we call skip_prologue_sal, which calculates the PC
     past the prologue, and updates the symtab_and_line: PC,
     but also symtab (now body.inc) and the new line (now 1).

  3. However, right after that, we do:

            /* Make sure the line matches the request, not what was
               found.  */
            intermediate_results.sals[i].line = val.line;

We should either restore both symtab and line, or leave the actual
line to match the actual symtab.  This patch chose the latter.
This introduces a few changes in a few tests, which required some
updates, but looking at those change, I believe them to be expected.

gdb/ChangeLog:

        * linespec.c (create_sals_line_offset): Remove code that preserved
        the symtab_and_line's line number.

gdb/testsuite/ChangeLog:

        * gdb.base/break-include.c, gdb.base/break-include.inc,
        gdb.base/break-include.exp: New files.
        * gdb.base/ending-run.exp: Minor adaptations due to the breakpoint's
        line number now being the actual line number where the breakpoint
        was inserted.
        * gdb.mi/mi-break.exp: Likewise.
        * gdb.mi/mi-reverse.exp: Likewise.
        * gdb.mi/mi-simplerun.exp: Ditto.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Ada/DWARF: Assume the Ada compiler produces descriptive type attributes
@ 2018-01-22  5:10 sergiodj+buildbot
  2018-01-22  7:00 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-22  5:10 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT de4cb04a20782b817fc80b49bba83b43cf1cb85d ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: de4cb04a20782b817fc80b49bba83b43cf1cb85d

Ada/DWARF: Assume the Ada compiler produces descriptive type attributes

GCC was enhanced in 2011 to generate this attribute, so I think we can
now assume that it is available when using that compiler. Doing so
allows us to speed up what we call "parallel type" lookups when
processing certain types encoded using the GNAT encoding.

This patch changes need_gnat_info to always expect those attributes
to be generated when the language is Ada. This is an assumption
that on the surfcace looks like it might be a bit on the edge; but
in practice, it should be OK because this is only useful in the
context of handling GNAT-specific encodings. Other Ada compilers
would presumably produce debugging information using pure DWARF
constructs, so would not be impacted by this.

gdb/ChangeLog:

        * dwarf2read.c (need_gnat_info): Return nonzero if the cu's
        language is Ada.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Don't call gdbarch_pseudo_register_read_value in jit.c
@ 2018-01-22 11:23 sergiodj+buildbot
  2018-01-22 11:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-22 11:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3f5a868b2277a3678f7eeb8fdf88935913b5918b ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 3f5a868b2277a3678f7eeb8fdf88935913b5918b

Don't call gdbarch_pseudo_register_read_value in jit.c

gdbarch_pseudo_register_read_value is not implemented in every gdbarch, so
the predicate gdbarch_pseudo_register_read_value_p is needed before
calling it.  However, there is no such guard in jit_frame_prev_register, I
am wondering how does jit work on the arch without having gdbarch method
pseudo_register_read_value.

The proper way to get register value is to call cooked_read, and then
create the value object from the buffer.

gdb:

2018-01-22  Yao Qi  <yao.qi@linaro.org>

	* jit.c (jit_frame_prev_register): Call regcache::cooked_read
	instead of gdbarch_pseudo_register_read_value.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Replace regcache_raw_read with regcache->raw_read
@ 2018-01-22 11:47 sergiodj+buildbot
  2018-01-22 17:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-22 11:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 03f50fc878f75fcdebf0e3273f201fb4b62b0bae ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 03f50fc878f75fcdebf0e3273f201fb4b62b0bae

Replace regcache_raw_read with regcache->raw_read

The patch later in this series will move regcache's raw_read and
cooked_read methods to a new class regcache_read, and regcache is
dervied from it.  Also pass regcache_read instead of regcache to gdbarch
methods pseudo_register_read and pseudo_register_read_value.  In order
to prepare for this change, this patch changes regcache_raw_read to
regcache->raw_read.  On the other hand, since we are in C++, I prefer
using class method (regcache->raw_read).

gdb:

2018-01-22  Yao Qi  <yao.qi@linaro.org>

	* aarch64-tdep.c (aarch64_pseudo_read_value): Call regcache
	method raw_read instead of regcache_raw_read.
	* amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
	* arm-tdep.c (arm_neon_quad_read): Likewise.
	* avr-tdep.c (avr_pseudo_register_read): Likewise.
	* bfin-tdep.c (bfin_pseudo_register_read): Likewise.
	* frv-tdep.c (frv_pseudo_register_read): Likewise.
	* h8300-tdep.c (h8300_pseudo_register_read): Likewise.
	* i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
	(i386_pseudo_register_read_into_value): Likewise.
	* mep-tdep.c (mep_pseudo_cr32_read): Likewise.
	* msp430-tdep.c (msp430_pseudo_register_read): Likewise.
	* nds32-tdep.c (nds32_pseudo_register_read): Likewise.
	* rl78-tdep.c (rl78_pseudo_register_read): Likewise.
	* s390-linux-tdep.c (s390_pseudo_register_read): Likewise.
	* sparc-tdep.c (sparc32_pseudo_register_read):  Likewise.
	* sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
	* spu-tdep.c (spu_pseudo_register_read_spu):  Likewise.
	* xtensa-tdep.c (xtensa_pseudo_register_read): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove mt port
@ 2018-01-22 12:07 sergiodj+buildbot
  2018-01-22 14:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-22 12:07 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT dc71152484248c0d8075618ec2146db4ea173b12 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: dc71152484248c0d8075618ec2146db4ea173b12

Remove mt port

This patch removes the MT port.  The removal was annoucned
https://sourceware.org/ml/gdb-announce/2017/msg00006.html
I'll remove MT from the top-level configure later.

gdb:

2018-01-22  Yao Qi  <yao.qi@linaro.org>

	* Makefile.in (ALL_TARGET_OBS): Remove mt-tdep.o.
	* configure.tgt: Remove target mt.
	* mt-tdep.c: Remove.
	* regcache.c (cooked_read_test): Remove the check for mt.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] regcache::cooked_write test
@ 2018-01-22 12:12 sergiodj+buildbot
  2018-01-22 22:58 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-22 12:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ec7a5fcbfd90b2f67f1a0e3f9866b11c5968ae61 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: ec7a5fcbfd90b2f67f1a0e3f9866b11c5968ae61

regcache::cooked_write test

Since my following patches will change how each gdbarch read and write
pseudo registers, it's better to write a unit test to
regcache::cooked_write, to make sure my following changes don't cause
any regressions.  See the comments on cooked_write_test.

gdb:

2018-01-22  Yao Qi  <yao.qi@linaro.org>

	* regcache.c (cooked_write_test): New function.
	(_initialize_regcache): Register the test.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] regcache_cooked_read -> regcache->cooked_read
@ 2018-01-22 13:34 sergiodj+buildbot
  2018-01-22 20:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-22 13:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 11f57cb67ecf5c69911eff21b54e05e93bbf2734 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 11f57cb67ecf5c69911eff21b54e05e93bbf2734

regcache_cooked_read -> regcache->cooked_read

Similarly, this patch replaces regcache_cooked_read with
regcache->cooked_read.

gdb:

2018-01-22  Yao Qi  <yao.qi@linaro.org>

	* ia64-tdep.c (ia64_pseudo_register_read): Call
	regcache->cooked_read instead of regcache_cooked_read_unsigned.
	* m32c-tdep.c (m32c_cat_read): Likewise.
	(m32c_r3r2r1r0_read): Likewise.
	* m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
	* xtensa-tdep.c (xtensa_register_read_masked): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] MAINTAINERS: Update my company e-mail address
@ 2018-01-22 15:56 sergiodj+buildbot
  2018-01-23  1:15 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-22 15:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d65ce302abcb260e14ca5f201b78e8e6d4a2e720 ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: d65ce302abcb260e14ca5f201b78e8e6d4a2e720

MAINTAINERS: Update my company e-mail address

Following my recent transition from Imagination Technologies to the
reincarnated MIPS company update MAINTAINERS entries accordingly.

	binutils/
	* MAINTAINERS: Update my company e-mail address.

	gdb/
	* MAINTAINERS: Update my company e-mail address.

	sim/
	* MAINTAINERS: Update my company e-mail address.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix segfault with 'set print object on' + 'whatis <struct>' & co
@ 2018-01-22 19:51 sergiodj+buildbot
  2018-01-23  3:30 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-22 19:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5c319bb260fa9637048cfae5fceba807e7849b39 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 5c319bb260fa9637048cfae5fceba807e7849b39

Fix segfault with 'set print object on' + 'whatis <struct>' & co

Compiling GDB with a recent GCC exposes a problem:

  ../../gdb/typeprint.c: In function 'void whatis_exp(const char*, int)':
  ../../gdb/typeprint.c:515:12: warning: 'val' may be used uninitialized in this function [-Wmaybe-uninitialized]
    real_type = value_rtti_type (val, &full, &top, &using_enc);
    ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The warning is correct.  There are indeed code paths that use
uninitialized 'val', leading to crashes.  Inside the
value_rtti_indirect_type/value_rtti_type calls here in whatis_exp:

  if (opts.objectprint)
    {
      if (((TYPE_CODE (type) == TYPE_CODE_PTR) || TYPE_IS_REFERENCE (type))
	  && (TYPE_CODE (TYPE_TARGET_TYPE (type)) == TYPE_CODE_STRUCT))
        real_type = value_rtti_indirect_type (val, &full, &top, &using_enc);
      else if (TYPE_CODE (type) == TYPE_CODE_STRUCT)
	real_type = value_rtti_type (val, &full, &top, &using_enc);
    }

We reach those calls above with "set print object on", and then with
any of:

  (gdb) whatis struct some_structure_type
  (gdb) whatis struct some_structure_type *
  (gdb) whatis struct some_structure_type &

because "whatis" with a type argument enters this branch:

      /* The behavior of "whatis" depends on whether the user
	 expression names a type directly, or a language expression
	 (including variable names).  If the former, then "whatis"
	 strips one level of typedefs, only.  If an expression,
	 "whatis" prints the type of the expression without stripping
	 any typedef level.  "ptype" always strips all levels of
	 typedefs.  */
      if (show == -1 && expr->elts[0].opcode == OP_TYPE)
	{

which does not initialize VAL.  Trying the above triggers crashes like
this:

  (gdb) set print object on
  (gdb) whatis some_structure_type

  Thread 1 "gdb" received signal SIGSEGV, Segmentation fault.
  0x00000000005dda90 in check_typedef (type=0x6120736573756170) at src/gdb/gdbtypes.c:2388
  2388      int instance_flags = TYPE_INSTANCE_FLAGS (type);
  ...

This is a regression caused by a recent-ish refactoring of the code on
'whatis_exp', introduced by:

  commit c973d0aa4a2c737ab527ae44a617f1c357e07364
  Date:   Mon Aug 21 11:34:32 2017 +0100

      Fix type casts losing typedefs and reimplement "whatis" typedef stripping

Fix this by setting VAL to NULL in the "whatis TYPE" case, and
skipping fetching the dynamic type if there's no value to fetch it
from.

New tests included.

gdb/ChangeLog:
2018-01-22  Pedro Alves  <palves@redhat.com>
	    Sergio Durigan Junior  <sergiodj@redhat.com>

	* typeprint.c (whatis_exp): Initialize "val" in the "whatis type"
	case.

gdb/testsuite/ChangeLog:
2018-01-22  Pedro Alves  <palves@redhat.com>
	    Sergio Durigan Junior  <sergiodj@redhat.com>

	* gdb.base/whatis.exp: Add tests for 'set print object on' +
	'whatis <struct>' 'whatis <struct> *' and 'whatis <struct> &'.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] s390: Remove duplicate checks for cached gdbarch at init
@ 2018-01-23 13:07 sergiodj+buildbot
  2018-01-23 13:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 13:07 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0eb97953adcb12aa49e4924d1e28ce6af046d6e2 ***

Author: Philipp Rudo <prudo@linux.vnet.ibm.com>
Branch: master
Commit: 0eb97953adcb12aa49e4924d1e28ce6af046d6e2

s390: Remove duplicate checks for cached gdbarch at init

When initializing the gdbarch there is a check whether an appropriate
gdbarch already exists in the gdbarch_list.  Failing of some of the checks
would lead to a different target description.  However
gdbarch_list_lookup_by_info already checks for

	if (info->target_desc != arches->gdbarch->target_desc)
	  continue;

Remove these duplicate checks.

gdb/ChangeLog:

	* s390-linux-tdep.c (s390_gdbarch_init): Remove duplicate checks
	when looking for cached gdbarch and add comment for remaining.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] s390: Allocate gdbarch & tdep at start of gdbarch_init
@ 2018-01-23 13:15 sergiodj+buildbot
  2018-01-23 15:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 13:15 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 21f6f5ffc652e116e518fee29ebdc8fbfeeaa734 ***

Author: Philipp Rudo <prudo@linux.vnet.ibm.com>
Branch: master
Commit: 21f6f5ffc652e116e518fee29ebdc8fbfeeaa734

s390: Allocate gdbarch & tdep at start of gdbarch_init

Moving the allocation of gdbarch_tdep to the start of s390_gdbarch_init
allows us to use its fields for tracking the different features instead of
using separate variables.  To make the code a little nicer move the actual
allocation and initialization to a separate function.  Also move the
allocation of gdbarch to keep the two together.

gdb/ChangeLog:

	* s390-linux-tdep (s390_abi_kind) <ABI_NONE>: New default field.
	(gdbarch_tdep) <have_upper, have_vx>: New fields.
	(s390_gdbarch_tdep_alloc): New function.
	(s390_gdbarch_init): Allocate tdep at start and use its fields
	instead of separate variables.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] s390: gdbarch_tdep add field tdesc
@ 2018-01-23 13:40 sergiodj+buildbot
  2018-01-23 19:29 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 13:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 095085d8473689d86e00cd7d9a63680ca8faeda6 ***

Author: Philipp Rudo <prudo@linux.vnet.ibm.com>
Branch: master
Commit: 095085d8473689d86e00cd7d9a63680ca8faeda6

s390: gdbarch_tdep add field tdesc

Add a field for the target description to gdbarch_tdep.  This will later be
needed to pass the 'correct' target description from osabi_init to
gdbarch_init.  Unfortunately this cannot be done using gdbarch_info as it
is only passed by copy, not reference.

gdb/ChangeLog:

	* s390-linux-tdep.c (gdbarch_tdep) <tdesc>: New field.
	(s390_gdbarch_tdep_alloc): Adjust.
	(s390_gdbarch_init): Adjust.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] s390: Hook s390 into OSABI mechanism
@ 2018-01-23 14:30 sergiodj+buildbot
  2018-01-24  0:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 14:30 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7042632bf7976d29889ba89fe4867654c5f38e2d ***

Author: Philipp Rudo <prudo@linux.vnet.ibm.com>
Branch: master
Commit: 7042632bf7976d29889ba89fe4867654c5f38e2d

s390: Hook s390 into OSABI mechanism

Do what the title says and distinguish between 31- and 64-bit systems.
The goal is to init the OSABI as late as possible in gdbarch_init so the
OSABI has the chance to overwrite the defaults.

There are two pitfalls to be aware of:

First, the dwarf2 unwinder must be appended before the OSABI is
initialized.  Otherwise the OS could add a default unwinder which always
takes control before the dwarf unwinder even gets a chance.

Second, tdesc_use_registers has to be handled with extra care.  It sets
several gdbarch hooks, especially gdbarch_register_name, which has to be
overwritten again after the call.  Furthermore it deletes the tdesc_data
without checking.  Therefore there must not be a call to
tdesc_data_cleanup afterwards or GDB will crash with a double free.

gdb/ChangeLog:

	* s390-linux-tdep.c (osabi.h): New include.
	(s390_linux_init_abi_31, s390_linux_init_abi_64)
	(s390_linux_init_abi_any): New functions.
	(s390_gdbarch_init, _initialize_s390_tdep): Adjust.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] s390: gdbarch_tdep add hook for syscall record
@ 2018-01-23 14:44 sergiodj+buildbot
  2018-01-24  2:43 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 14:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9c0b896ee1d4edfe30c783b027ed5c081845a63d ***

Author: Philipp Rudo <prudo@linux.vnet.ibm.com>
Branch: master
Commit: 9c0b896ee1d4edfe30c783b027ed5c081845a63d

s390: gdbarch_tdep add hook for syscall record

Most parts of s390_process_record are common for the architecture.  Only
the system call handling differs between the OSes.  In order to be able to
move s390_process_record to a common code file add a hook to record
syscalls to gdbarch_tdep.  So every OS can implement their own handling.

gdb/ChangeLog:

	* s390-linux-tdep.c (gdbarch_tdep.s390_syscall_record): New hook.
	(s390_process_record, s390_gdbarch_tdep_alloc)
	(s390_linux_init_abi_any): Use/set new hook.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] s390: gdbarch_tdep.have_* int -> bool
@ 2018-01-23 14:44 sergiodj+buildbot
  2018-01-23 17:15 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 14:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ab9bcc67975f2a04dfa0e670096fc8161d7840b9 ***

Author: Philipp Rudo <prudo@linux.vnet.ibm.com>
Branch: master
Commit: ab9bcc67975f2a04dfa0e670096fc8161d7840b9

s390: gdbarch_tdep.have_* int -> bool

Currently the gdbarch_tdep.have_* flags are a mix of int and bool.  Clean
this up by making them all bool.

gdb/ChangeLog:

	* s390-linux-tdep.c (gdbarch_tdep) <have_linux_v1, have_linux_v2>
	<have_tdb>: Change type to bool.
	(s390_gdbarch_tdep_alloc): Adjust.
	(s390_gdbarch_init): Adjust.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] s390: Split up s390-linux-tdep.c into two files
@ 2018-01-23 14:57 sergiodj+buildbot
  2018-01-24  4:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 14:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d6e5894564754ed81faaa3dc92f0cc0e90d7994b ***

Author: Philipp Rudo <prudo@linux.vnet.ibm.com>
Branch: master
Commit: d6e5894564754ed81faaa3dc92f0cc0e90d7994b

s390: Split up s390-linux-tdep.c into two files

Currently all target dependent code for s390 is in one file,
s390-linux-tdep.c.  This includes code general for the architecture as
well as code specific for uses in GNU/Linux (user space).  Up until now
this was OK as GNU/Linux was the only supported OS.  In preparation to
support the new Linux kernel 'OS' split up the existing s390 code into a
general s390-tdep and a GNU/Linux-specific s390-linux-tdep.

Note: The record-replay feature will be moved in a separate patch.  This
is simply due to the fact that the combined patch would be too large for
the mailing list.  This requires setting the process_record hook during
OSABI init to keep the code bisectable.  The patch moving record-replay
cleans up this hack.

gdb/ChangeLog:

	* s390-linux-nat.c (s390-tdep.h): New include.
	* Makefile.in (ALL_TARGET_OBS): Add s390-tdep.o.
	(HFILES_NO_SRCDIR): Add s390-tdep.h.
	(ALLDEPFILES): Add s390-tdep.c.
	* configure.tgt (s390*-*-linux*): Add s390-tdep.o.
	* s390-linux-tdep.h (HWCAP_S390_*, S390_*_REGNUM): Move to...
	* s390-tdep.h: ...this.  New file.
	* s390-linux-tdep.c (s390-tdep.h): New include.
	(_initialize_s390_tdep): Rename to...
	(_initialize_s390_linux_tdep): ...this and adjust.
	(s390_abi_kind, s390_vector_abi_kind, gdbarch_tdep)
	(enum named opcodes, S390_NUM_GPRS, S390_NUM_FPRS): Move to
	s390-tdep.h.
	(s390_break_insn, s390_breakpoint, s390_readinstruction, is_ri)
	(is_ril, is_rr, is_rre, is_rs, is_rsy, is_rx, is_rxy)
	(s390_is_partial_instruction, s390_software_single_step)
	(is_non_branch_ril, s390_displaced_step_copy_insn)
	(s390_displaced_step_fixup, s390_displaced_step_hw_singlestep)
	(s390_prologue_data, s390_addr, s390_store, s390_load)
	(s390_check_for_saved, s390_analyze_prologue, s390_skip_prologue)
	(s390_register_call_saved, s390_guess_tracepoint_registers)
	(s390_register_name, s390_dwarf_regmap, s390_dwarf_reg_to_regnum)
	(regnum_is_gpr_full, regnum_is_vxr_full, s390_value_from_register)
	(s390_pseudo_register_name, s390_pseudo_register_type)
	(s390_pseudo_register_read, s390_pseudo_register_write)
	(s390_pseudo_register_reggroup_p, s390_ax_pseudo_register_collect)
	(s390_ax_pseudo_register_push_stack, s390_gen_return_address)
	(s390_addr_bits_remove, s390_address_class_type_flags)
	(s390_address_class_type_flags_to_name)
	(s390_address_class_name_to_type_flags, s390_effective_inner_type)
	(s390_function_arg_float, s390_function_arg_vector)
	(is_power_of_two, s390_function_arg_integer, s390_arg_state)
	(s390_handle_arg, s390_push_dummy_call, s390_dummy_id)
	(s390_frame_align, s390_register_return_value, s390_return_value)
	(s390_stack_frame_destroyed_p, s390_unwind_pc, s390_unwind_sp)
	(s390_unwind_pseudo_register, s390_adjust_frame_regnum)
	(s390_dwarf2_prev_register, s390_dwarf2_frame_init_reg)
	(s390_trad_frame_prev_register, s390_unwind_cache)
	(s390_prologue_frame_unwind_cache)
	(s390_backchain_frame_unwind_cache, s390_frame_unwind_cache)
	(s390_frame_this_id, s390_frame_prev_register, s390_frame_unwind)
	(s390_stub_unwind_cache, s390_stub_frame_unwind_cache)
	(s390_stub_frame_this_id, s390_stub_frame_prev_register)
	(s390_stub_frame_sniffer, s390_stub_frame_unwind)
	(s390_frame_base_address, s390_local_base_address)
	(s390_frame_base, s390_gcc_target_options)
	(s390_gnu_triplet_regexp, s390_stap_is_single_operand)
	(s390_validate_reg_range, s390_tdesc_valid)
	(s390_gdbarch_tdep_alloc, s390_gdbarch_init): Move to...
	* s390-tdep.c: ...this.  New file.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] s390: Move record-replay to s390-tdep.c
@ 2018-01-23 15:13 sergiodj+buildbot
  2018-01-24  5:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 15:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ef8914a4d7d231fe3590f3e004316613e25f3617 ***

Author: Philipp Rudo <prudo@linux.vnet.ibm.com>
Branch: master
Commit: ef8914a4d7d231fe3590f3e004316613e25f3617

s390: Move record-replay to s390-tdep.c

Record-replay is independent of the OS.  So it can be moved to the common
s390 code without problem.

gdb/ChangeLog:

	* s390-linux-tdep.c (s390_record_address_mask)
	(s390_record_calc_disp_common, s390_record_calc_disp)
	(s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
	(s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
	(s390_process_record): Move to s390-tdep.c.
	(s390_linux_init_abi_any): Adjust.
	* s390-tdep.c (s390_record_address_mask)
	(s390_record_calc_disp_common, s390_record_calc_disp)
	(s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
	(s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
	(s390_process_record): Moved from s390-linux-tdep.c
	(s390_gdbarch_init): Adjust.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] s390: Clean up s390-linux-tdep.c
@ 2018-01-23 15:28 sergiodj+buildbot
  2018-01-24  7:54 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 15:28 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 14c41f479f2eb6b34ab2d2bb0cedb88e9d51f211 ***

Author: Philipp Rudo <prudo@linux.vnet.ibm.com>
Branch: master
Commit: 14c41f479f2eb6b34ab2d2bb0cedb88e9d51f211

s390: Clean up s390-linux-tdep.c

After moving big parts of the code to the new s390-tdep.c file
s390-linux-tdep.c now contains many includes it doesn't need anymore.
Furthermore, there are some functions lacking a description.

Fix both and order the remaining includes alphabetically.

gdb/ChangeLog
	* s390-linux-tdep.c: Remove unneeded includes and order them
	alphabetically.  Add comments to functions without description.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] s390: Move tdesc validation to separate function
@ 2018-01-23 16:25 sergiodj+buildbot
  2018-01-23 21:06 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 16:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 47c9317e71768ba9788c6dc055fb6932d0f0923a ***

Author: Philipp Rudo <prudo@linux.vnet.ibm.com>
Branch: master
Commit: 47c9317e71768ba9788c6dc055fb6932d0f0923a

s390: Move tdesc validation to separate function

Simplify s390_gdbarch_init by moving the target description validation to
a separate function.

gdb/ChangeLog:

	* s390-linux-tdep.c (s390_tdesc_valid): New function.
	(s390_validate_reg_range): New macro.
	(s390_gdbarch_init): Adjust.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] s390: if -> gdb_assert for tdesc_has_registers check
@ 2018-01-23 17:23 sergiodj+buildbot
  2018-01-23 22:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 17:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 650f5e137006fb7aea98e33d2ca9c6ac6712334c ***

Author: Philipp Rudo <prudo@linux.vnet.ibm.com>
Branch: master
Commit: 650f5e137006fb7aea98e33d2ca9c6ac6712334c

s390: if -> gdb_assert for tdesc_has_registers check

Before doing the tdesc validation there is a check whether the tdesc has
registers or not.  This check is not only unnecessary but wrong.

First the check is done after a default tdesc is assigned if the original
tdesc has no registers.  These default tdescs always have registers so the
check alway returns true.

Second if the default tdesc would not have registers the check only skips
the tdesc validation instead of returning an error.  This would trigger a
gdb_assert later on in tdesc_use_registers.

gdb/ChangeLog:

	* s390-linux-tdep.c (s390_gdbarch_init): Use gdb_assert for
	tdesc_has_registers check


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Enable Intel WBNOINVD instruction.
@ 2018-01-23 17:26 sergiodj+buildbot
  2018-01-24 10:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 17:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3233d7d074e59b83f68a22071cff597f00d5ae81 ***

Author: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
Branch: master
Commit: 3233d7d074e59b83f68a22071cff597f00d5ae81

Enable Intel WBNOINVD instruction.

Intel has disclosed a set of new instructions for Icelake processor.
The spec is
https://software.intel.com/sites/default/files/managed/c5/15/architecture-instruction-set-extensions-programming-reference.pdf

This patch enables Intel WBNOINVD instruction.

gas/
	* config/tc-i386.c (cpu_arch): Add .wbnoinvd.
	* doc/c-i386.texi: Document .wbnoinvd.
	* testsuite/gas/i386/i386.exp: Add WBNOINVD tests.
	* testsuite/gas/i386/wbnoinvd-intel.d: New test.
	* testsuite/gas/i386/wbnoinvd.d: Likewise.
	* testsuite/gas/i386/wbnoinvd.s: Likewise.
	* testsuite/gas/i386/x86-64-wbnoinvd-intel.d: Likewise.
	* testsuite/gas/i386/x86-64-wbnoinvd.d: Likewise.
	* testsuite/gas/i386/x86-64-wbnoinvd.s: Likewise.
opcodes/
	* i386-dis.c (enum): Add PREFIX_0F09.
	* i386-gen.c (cpu_flag_init): Add CPU_WBNOINVD_FLAGS.
	(cpu_flags): Add CpuWBNOINVD.
	* i386-opc.h (enum): Add CpuWBNOINVD.
	(i386_cpu_flags): Add cpuwbnoinvd.
	* i386-opc.tbl: Add WBNOINVD instruction.
	* i386-init.h: Regenerate.
	* i386-tbl.h: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Enable Intel PCONFIG instruction.
@ 2018-01-23 17:39 sergiodj+buildbot
  2018-01-24 12:48 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 17:39 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT be3a8dca2d7241878302ca55f45129d532b6f746 ***

Author: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
Branch: master
Commit: be3a8dca2d7241878302ca55f45129d532b6f746

Enable Intel PCONFIG instruction.

Intel has disclosed a set of new instructions for Icelake processor.
The spec is
https://software.intel.com/sites/default/files/managed/c5/15/architecture-instruction-set-extensions-programming-reference.pdf

This patch enables Intel PCONFIG instruction.

gas/
	* config/tc-i386.c (cpu_arch): Add .pconfig.
	* doc/c-i386.texi: Document .pconfig.
	* testsuite/gas/i386/i386.exp: Add PCONFIG tests.
	* testsuite/gas/i386/pconfig-intel.d: New test.
	* testsuite/gas/i386/pconfig.d: Likewise.
	* testsuite/gas/i386/pconfig.s: Likewise.
	* testsuite/gas/i386/x86-64-pconfig-intel.d: Likewise.
	* testsuite/gas/i386/x86-64-pconfig.d: Likewise.
	* testsuite/gas/i386/x86-64-pconfig.s: Likewise.
opcodes/
	* i386-dis.c (enum): Add pconfig.
	* i386-gen.c (cpu_flag_init): Add CPU_PCONFIG_FLAGS.
	(cpu_flags): Add CpuPCONFIG.
	* i386-opc.h (enum): Add CpuPCONFIG.
	(i386_cpu_flags): Add cpupconfig.
	* i386-opc.tbl: Add PCONFIG instruction.
	* i386-init.h: Regenerate.
	* i386-tbl.h: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] MIPS/BFD: Update a stale `mips_elf32_section_processing' reference
@ 2018-01-23 19:18 sergiodj+buildbot
  2018-01-24 15:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 19:18 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1c5e4ee9ab4c173aca017d488cc074ef66562a12 ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 1c5e4ee9ab4c173aca017d488cc074ef66562a12

MIPS/BFD: Update a stale `mips_elf32_section_processing' reference

Update a stale reference to `mips_elf32_section_processing', following a
merge of the function into `_bfd_mips_elf_section_processing' made with
commit 103186c62b99 ("PATCH for MIPS 64-bit ABI suport"),
<https://sourceware.org/ml/binutils/1999-q3/msg00072.html>.

	bfd/
	* elfxx-mips.c (_bfd_mips_elf_final_link): Update a stale
	`mips_elf32_section_processing' comment reference.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [GAS][AARCH64]Add group relocations to create PC-relative offset.
@ 2018-01-24 16:36 sergiodj+buildbot
  2018-01-24 17:48 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-24 16:36 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 322474019df79a1305e83ff7620a72f31a5c7b55 ***

Author: Renlin Li <renlin.li@arm.com>
Branch: master
Commit: 322474019df79a1305e83ff7620a72f31a5c7b55

[GAS][AARCH64]Add group relocations to create PC-relative offset.

This is a patch to add the gas support for group relocations to create a
16, 32, 48, or 64 bit PC-relative offset inline.

The following relocations are added along with the test cases:
BFD_RELOC_AARCH64_MOVW_PREL_G0, BFD_RELOC_AARCH64_MOVW_PREL_G0_NC,
BFD_RELOC_AARCH64_MOVW_PREL_G1, BFD_RELOC_AARCH64_MOVW_PREL_G1_NC,
BFD_RELOC_AARCH64_MOVW_PREL_G2, BFD_RELOC_AARCH64_MOVW_PREL_G2_NC,
BFD_RELOC_AARCH64_MOVW_PREL_G3.

bfd/

2018-01-24  Renlin Li  <renlin.li@arm.com>

	* reloc.c: Add BFD_RELOC_AARCH64_MOVW_PREL_G0,
	BFD_RELOC_AARCH64_MOVW_PREL_G0_NC, BFD_RELOC_AARCH64_MOVW_PREL_G1,
	BFD_RELOC_AARCH64_MOVW_PREL_G1_NC, BFD_RELOC_AARCH64_MOVW_PREL_G2,
	BFD_RELOC_AARCH64_MOVW_PREL_G2_NC, BFD_RELOC_AARCH64_MOVW_PREL_G3.
	* bfd-in2.h: Regenerate.
	* libbfd.h: Regenerate.
	* elfnn-aarch64.c (elfNN_aarch64_howto_table): Add entries for
	BFD_RELOC_AARCH64_MOVW_PREL_G0, BFD_RELOC_AARCH64_MOVW_PREL_G0_NC,
	BFD_RELOC_AARCH64_MOVW_PREL_G1, BFD_RELOC_AARCH64_MOVW_PREL_G1_NC,
	BFD_RELOC_AARCH64_MOVW_PREL_G2, BFD_RELOC_AARCH64_MOVW_PREL_G2_NC,
	BFD_RELOC_AARCH64_MOVW_PREL_G3.

gas/

2018-01-24  Renlin Li  <renlin.li@arm.com>

	* config/tc-aarch64.c (reloc_table): add entries for
	BFD_RELOC_AARCH64_MOVW_PREL_G0, BFD_RELOC_AARCH64_MOVW_PREL_G0_NC,
	BFD_RELOC_AARCH64_MOVW_PREL_G1, BFD_RELOC_AARCH64_MOVW_PREL_G1_NC,
	BFD_RELOC_AARCH64_MOVW_PREL_G2, BFD_RELOC_AARCH64_MOVW_PREL_G2_NC,
	BFD_RELOC_AARCH64_MOVW_PREL_G3.
	(process_movw_reloc_info): Supports newly added MOVW_PREL relocations.
	(md_apply_fix): Likewise
	* testsuite/gas/aarch64/prel_g0.s: New.
	* testsuite/gas/aarch64/prel_g0.d: New.
	* testsuite/gas/aarch64/prel_g0_nc.s: New.
	* testsuite/gas/aarch64/prel_g0_nc.d: New.
	* testsuite/gas/aarch64/prel_g1.s: New.
	* testsuite/gas/aarch64/prel_g1.d: New.
	* testsuite/gas/aarch64/prel_g1_nc.s: New.
	* testsuite/gas/aarch64/prel_g1_nc.d: New.
	* testsuite/gas/aarch64/prel_g2.s: New.
	* testsuite/gas/aarch64/prel_g2.d: New.
	* testsuite/gas/aarch64/prel_g2_nc.s: New.
	* testsuite/gas/aarch64/prel_g2_nc.d: New.
	* testsuite/gas/aarch64/prel_g3.s: New.
	* testsuite/gas/aarch64/prel_g3.d: New.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [LD][AARCH64]Add group relocations to create PC-relative offset.
@ 2018-01-24 16:51 sergiodj+buildbot
  2018-01-24 21:59 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-24 16:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1daf502a16e052b55a28bd52b4fde185ccc3b27b ***

Author: Renlin Li <renlin.li@arm.com>
Branch: master
Commit: 1daf502a16e052b55a28bd52b4fde185ccc3b27b

[LD][AARCH64]Add group relocations to create PC-relative offset.

This is a patch to add linker support for group relocations to create a
16, 32, 48, or 64 bit PC-relative offset inline.

The following relocations are added along with the test cases:
BFD_RELOC_AARCH64_MOVW_PREL_G0, BFD_RELOC_AARCH64_MOVW_PREL_G0_NC,
BFD_RELOC_AARCH64_MOVW_PREL_G1, BFD_RELOC_AARCH64_MOVW_PREL_G1_NC,
BFD_RELOC_AARCH64_MOVW_PREL_G2, BFD_RELOC_AARCH64_MOVW_PREL_G2_NC,
BFD_RELOC_AARCH64_MOVW_PREL_G3.

bfd/

2018-01-24  Renlin Li  <renlin.li@arm.com>

	* elfnn-aarch64.c (elfNN_aarch64_final_link_relocate): Add support for
	BFD_RELOC_AARCH64_MOVW_PREL_G0, BFD_RELOC_AARCH64_MOVW_PREL_G0_NC,
	BFD_RELOC_AARCH64_MOVW_PREL_G1, BFD_RELOC_AARCH64_MOVW_PREL_G1_NC,
	BFD_RELOC_AARCH64_MOVW_PREL_G2, BFD_RELOC_AARCH64_MOVW_PREL_G2_NC,
	BFD_RELOC_AARCH64_MOVW_PREL_G3.
	* elfxx-aarch64.c (_bfd_aarch64_elf_put_addend): Likewise.
	(_bfd_aarch64_elf_resolve_relocation): Likewise.

ld/

2018-01-24  Renlin Li  <renlin.li@arm.com>

	* testsuite/ld-aarch64/aarch64-elf.exp: Run new testes.
	* testsuite/ld-aarch64/emit-relocs-287.s: Fix test case.
	* testsuite/ld-aarch64/emit-relocs-287.d: Fix expected output.
	* testsuite/ld-aarch64/emit-relocs-287-overflow.s: New.
	* testsuite/ld-aarch64/emit-relocs-287-overflow.d: New.
	* testsuite/ld-aarch64/emit-relocs-288.d: New.
	* testsuite/ld-aarch64/emit-relocs-288.s: New.
	* testsuite/ld-aarch64/emit-relocs-289.d: New.
	* testsuite/ld-aarch64/emit-relocs-289.s: New.
	* testsuite/ld-aarch64/emit-relocs-289-overflow.s: New.
	* testsuite/ld-aarch64/emit-relocs-289-overflow.d: New.
	* testsuite/ld-aarch64/emit-relocs-290.d: New.
	* testsuite/ld-aarch64/emit-relocs-290.s: New.
	* testsuite/ld-aarch64/emit-relocs-291.d: New.
	* testsuite/ld-aarch64/emit-relocs-291.s: New.
	* testsuite/ld-aarch64/emit-relocs-291-overflow.s: New.
	* testsuite/ld-aarch64/emit-relocs-291-overflow.d: New.
	* testsuite/ld-aarch64/emit-relocs-292.d: New.
	* testsuite/ld-aarch64/emit-relocs-292.s: New.
	* testsuite/ld-aarch64/emit-relocs-293.d: New.
	* testsuite/ld-aarch64/emit-relocs-293.s: New.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix GCC PR83906 - [8 Regression] Random FAIL: libstdc++-prettyprinters/80276.cc whatis p4
@ 2018-01-24 18:49 sergiodj+buildbot
  2018-01-24 23:37 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-24 18:49 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0f59d5fc1ce646348dfae3ca90b32f9228d1d514 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 0f59d5fc1ce646348dfae3ca90b32f9228d1d514

Fix GCC PR83906 - [8 Regression] Random FAIL: libstdc++-prettyprinters/80276.cc whatis p4

GCC PR83906 [1] is about a GCC/libstdc++ GDB/Python type printer
testcase failing randomly, as shown by running (in libstdc++'s
testsuite):

 make check RUNTESTFLAGS=prettyprinters.exp=80276.cc

in a loop.  Sometimes you get this:

 FAIL: libstdc++-prettyprinters/80276.cc whatis p4

I.e., this:
 type = std::unique_ptr<std::vector<std::unique_ptr<std::list<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >>[]>>[99]>

instead of this:
 type = std::unique_ptr<std::vector<std::unique_ptr<std::list<std::string>[]>>[99]>

Jonathan Wakely tracked it on the printer side to this bit in
libstdc++'s type printer:

            if self.type_obj == type_obj:
                return strip_inline_namespaces(self.name)

This assumes the two types resolve to the same gdb.Type but some times
the comparison unexpectedly fails.

Running the testcase manually under Valgrind finds the problem in GDB:

 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 ==6118== Conditional jump or move depends on uninitialised value(s)
 ==6118==    at 0x4C35CB0: bcmp (vg_replace_strmem.c:1100)
 ==6118==    by 0x6F773A: check_types_equal(type*, type*, VEC_type_equality_entry_d**) (gdbtypes.c:3515)
 ==6118==    by 0x6F7B00: check_types_worklist(VEC_type_equality_entry_d**, bcache*) (gdbtypes.c:3618)
 ==6118==    by 0x6F7C03: types_deeply_equal(type*, type*) (gdbtypes.c:3655)
 ==6118==    by 0x4D5B06: typy_richcompare(_object*, _object*, int) (py-type.c:1007)
 ==6118==    by 0x63D7E6C: PyObject_RichCompare (object.c:961)
 ==6118==    by 0x646EAEC: PyEval_EvalFrameEx (ceval.c:4960)
 ==6118==    by 0x646DC08: PyEval_EvalFrameEx (ceval.c:4519)
 ==6118==    by 0x646DC08: PyEval_EvalFrameEx (ceval.c:4519)
 ==6118==    by 0x646DC08: PyEval_EvalFrameEx (ceval.c:4519)
 ==6118==    by 0x646DC08: PyEval_EvalFrameEx (ceval.c:4519)
 ==6118==    by 0x646DC08: PyEval_EvalFrameEx (ceval.c:4519)
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~

That "bcmp" call is really a memcmp call in check_types_equal.  The
problem is that gdb is memcmp'ing two objects that are equal in value:

 (top-gdb) p *TYPE_RANGE_DATA (type1)
 $1 = {low = {kind = PROP_CONST, data = {const_val = 0, baton = 0x0}}, high = {kind = PROP_CONST, data = {const_val = 15, baton = 0xf}}, flag_upper_bound_is_count = 0,
   flag_bound_evaluated = 0}
 (top-gdb) p *TYPE_RANGE_DATA (type2)
 $2 = {low = {kind = PROP_CONST, data = {const_val = 0, baton = 0x0}}, high = {kind = PROP_CONST, data = {const_val = 15, baton = 0xf}}, flag_upper_bound_is_count = 0,
   flag_bound_evaluated = 0}

but differ in padding.  Notice the 4-byte hole:

  (top-gdb) ptype /o range_bounds
  /* offset    |  size */  type = struct range_bounds {
  /*    0      |    16 */    struct dynamic_prop {
  /*    0      |     4 */        dynamic_prop_kind kind;
  /* XXX  4-byte hole  */
  /*    8      |     8 */        union dynamic_prop_data {
  /*                 8 */            LONGEST const_val;
  /*                 8 */            void *baton;

				     /* total size (bytes):    8 */
				 } data;

which is filled with garbage:

  (top-gdb) x /40bx TYPE_RANGE_DATA (type1)
  0x2fa7ea0:      0x01    0x00    0x00    0x00    0x43    0x01    0x00    0x00
						  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  0x2fa7ea8:      0x00    0x00    0x00    0x00    0x00    0x00    0x00    0x00
  0x2fa7eb0:      0x01    0x00    0x00    0x00    0xfe    0x7f    0x00    0x00
  0x2fa7eb8:      0x0f    0x00    0x00    0x00    0x00    0x00    0x00    0x00
  0x2fa7ec0:      0x00    0x00    0x00    0x00    0x00    0x00    0x00    0x00
  (top-gdb) x /40bx TYPE_RANGE_DATA (type2)
  0x20379b0:      0x01    0x00    0x00    0x00    0xfe    0x7f    0x00    0x00
						  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  0x20379b8:      0x00    0x00    0x00    0x00    0x00    0x00    0x00    0x00
  0x20379c0:      0x01    0x00    0x00    0x00    0xfe    0x7f    0x00    0x00
  0x20379c8:      0x0f    0x00    0x00    0x00    0x00    0x00    0x00    0x00
  0x20379d0:      0x00    0x00    0x00    0x00    0x00    0x00    0x00    0x00

  (top-gdb) p memcmp (TYPE_RANGE_DATA (type1), TYPE_RANGE_DATA (type2), sizeof (*TYPE_RANGE_DATA (type1)))
  $3 = -187

In some cases objects of type range_bounds are memset when allocated,
but then their dynamic_prop low/high fields are copied over from some
template dynamic_prop object that wasn't memset.  E.g.,
create_static_range_type's low/high locals are left with garbage in
the padding, and then that padding is copied over to the range_bounds
object's low/high fields.

At first, I considered making sure to always memset range_bounds
objects, thinking that maybe type objects are being put in some bcache
instance somewhere.  But then I hacked bcache/bcache_full to poison
non-pod types, and made dynamic_prop a non-pod, and GDB still
compiled.

So given that, it seems safest to not assume padding will always be
memset, and instead treat them as regular value types, implementing
(in)equality operators and using those instead of memcmp.

This fixes the random FAILs in GCC's testcase.

[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83906

gdb/ChangeLog:
2018-01-24  Pedro Alves  <palves@redhat.com>

	GCC PR libstdc++/83906
	* gdbtypes.c (operator==(const dynamic_prop &,
	const dynamic_prop &)): New.
	(operator==(const range_bounds &, const range_bounds &)): New.
	(check_types_equal): Use them instead of memcmp.
	* gdbtypes.h (operator==(const dynamic_prop &,
	const dynamic_prop &)): Declare.
	(operator!=(const dynamic_prop &, const dynamic_prop &)): Declare.
	(operator==(const range_bounds &, const range_bounds &)): Declare.
	(operator!=(const range_bounds &, const range_bounds &)): Declare.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix PR ld/22727 (TLS breakage in PIC/PIE mode on SPARC).
@ 2018-01-25 11:35 sergiodj+buildbot
  2018-01-25 12:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-25 11:35 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bb363086e7743506d78bc6b1e56face0fb1fc93f ***

Author: Eric Botcazou <ebotcazou@gcc.gnu.org>
Branch: master
Commit: bb363086e7743506d78bc6b1e56face0fb1fc93f

Fix PR ld/22727 (TLS breakage in PIC/PIE mode on SPARC).

There are actually 2 different bugs:
 1. TLS transition is broken in PIE mode.
 2. TLS is broken in PIC/PIE mode when the __tls_get_addr symbol
    is versioned  (as is the case on Linux and Solaris at least).

The 1st bug is fixed by reverting the problematic change for now
(note that the associated test doesn't pass on SPARC because of another
issue so there is  no formal regression in the testsuite). The 2nd bug
is fixed by changing the  call to _bfd_generic_link_add_one_symbol
on __tls_get_addr into a mere lookup in _bfd_sparc_elf_check_relocs.

bfd/
	* elfxx-sparc.c (_bfd_sparc_elf_check_relocs) <R_SPARC_TLS_GD_CALL>:
	Do a mere lookup of the __tls_get_addr symbol instead of adding it.

	Revert
	2017-10-19  H.J. Lu  <hongjiu.lu@intel.com>

	PR ld/22263
	* elfxx-sparc.c (sparc_elf_tls_transition): Replace
	bfd_link_pic with !bfd_link_executable, !bfd_link_pic with
	bfd_link_executable for TLS check.
	(_bfd_sparc_elf_check_relocs): Likewise.
	(allocate_dynrelocs): Likewise.
	(_bfd_sparc_elf_relocate_section): Likewise.
ld/
	* testsuite/ld-sparc/sparc.exp (32-bit: Helper shared library):
	Link with a version script.
	(32-bit: TLS -fpie): New test.
	(64-bit: Helper shared library): Link with a version script.
	(64-bit: TLS -fpie): New test.
	(64-bit: GOTDATA relocations): Pass -Av9 to the assembler.
	* testsuite/ld-sparc/tlslib.ver: New file.
	* testsuite/ld-sparc/tlspie32.dd: Likewise.
	* testsuite/ld-sparc/tlspie32.s: Likewise.
	* testsuite/ld-sparc/tlspie64.dd: Likewise.
	* testsuite/ld-sparc/tlspie64.s: Likewise.
	* testsuite/ld-sparc/tlssunbin32.dd: Adjust for versioned symbol.
	* testsuite/ld-sparc/tlssunbin32.rd: Likewise.
	* testsuite/ld-sparc/tlssunbin32.sd: Likewise.
	* testsuite/ld-sparc/tlssunbin64.dd: Likewise.
	* testsuite/ld-sparc/tlssunbin64.rd: Likewise.
	* testsuite/ld-sparc/tlssunbin64.sd: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PR22746, crash when running 32-bit objdump on corrupted file
@ 2018-01-25 11:50 sergiodj+buildbot
  2018-01-25 13:59 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-25 11:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 38e64b0ecc7f4ee64a02514b8d532782ac057fa2 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 38e64b0ecc7f4ee64a02514b8d532782ac057fa2

PR22746, crash when running 32-bit objdump on corrupted file

Avoid unsigned int overflow by performing bfd_size_type multiplication.

	PR 22746
	* elfcode.h (elf_object_p): Avoid integer overflow.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PowerPC64 .branch_lt size change leads to "stubs don't match calculated size"
@ 2018-01-26  5:34 sergiodj+buildbot
  2018-01-26  5:54 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-26  5:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ba21f5646454c418e75eb06f6bf1a00a173641ca ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: ba21f5646454c418e75eb06f6bf1a00a173641ca

PowerPC64 .branch_lt size change leads to "stubs don't match calculated size"

https://bugzilla.redhat.com/show_bug.cgi?id=1523457

I haven't analyzed this myself, I'm relying on Nick's excellent
analysis.  What I believe is happening is that after some number of
stub sizing iterations, a long-branch stub needs to be converted to a
plt-branch, but either due to stub alignment or other stubs shrinking
in size, the stub group section size doesn't change.

That means we exit from ppc64_elf_size_stubs after sizing with an
incorrect layout, in fact the additional .branch_lt entry overlays
.got!  Since .TOC. is normally set to .got + 0x8000 the stub sizing
code decides that entry is within +/-32k of the TOC pointer and so a
three insn stub is sufficient.  When we come to build the stubs using
a correct non-overlaying layout, a four insn plt-branch stub is
generated and the stub group size doesn't match that calculated
earlier.

	* elf64-ppc.c (ppc64_elf_size_stubs): Iterate sizing when
	.branch_lt changes size.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PowerPC PLT stub matching
@ 2018-01-26  5:59 sergiodj+buildbot
  2018-01-26  9:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-26  5:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7433498b7f1a79bf98ba272fd461f0ff9f1daa02 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 7433498b7f1a79bf98ba272fd461f0ff9f1daa02

PowerPC PLT stub matching

This patch fixes a number of bugs in ppc32 plt stub matching code.
1) The 4-insn stubs for shared libs and PIEs weren't matched.
2) The executable stub miscalculated PLT entry address (by oring a
   sign-extended quantity rather than adding).
3) Comments were not accurate.

In addition, the insn arrays are made const.

	* ppc-linux-tdep.c (powerpc32_plt_stub): Make const.
	(powerpc32_plt_stub_so_1): Rename from powerpc32_plt_stub_so.
	Remove nop.  Make const.  Comment.
	(powerpc32_plt_stub_so_2): New.
	(POWERPC32_PLT_CHECK_LEN): Rename from POWERPC32_PLT_STUB_LEN.
	Correct count.  Update uses.
	(ppc_skip_trampoline_code): Match powerpc32_plt_stub_so_2 too.
	Move common code reading PLT entry word.  Correct
	powerpc32_plt_stub PLT address calculation.
	* ppc64-tdep.c (ppc64_standard_linkage1): Make const.
	(ppc64_standard_linkage2, ppc64_standard_linkage3): Likewise.
	(ppc64_standard_linkage4, ppc64_standard_linkage5): Likewise.
	(ppc64_standard_linkage6, ppc64_standard_linkage7): Likewise.
	(ppc64_standard_linkage8): Likewise.
	* rs6000-tdep.c (ppc_insns_match_pattern): Make pattern const.
	Correct insns description.
	* ppc-tdep.h (ppc_insns_match_pattern): Update prototype.

Reviewed-By: Yao Qi <qiyaoltc@gmail.com>


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Define __start/__stop symbols when there is only a dynamic def
@ 2018-01-26  6:02 sergiodj+buildbot
  2018-01-26  7:28 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-26  6:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 32253bb7963ac7caa166ec41e336372f2ffc03d4 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 32253bb7963ac7caa166ec41e336372f2ffc03d4

Define __start/__stop symbols when there is only a dynamic def

This patch fixes a case where a user had a C-representable named
section in both the executable and shared libraries, and of course
wanted the size of the local section in the executable, not the
dynamic section.  It does mean that __start and __stop symbols don't
behave exactly like PROVIDEd symbols, but I think that's a reasonable
difference particularly since this is the way they used to behave.

	* elflink.c (bfd_elf_define_start_stop): Override symbols when
	they are defined dynamically.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add myself as a write-after-approval GDB maintainer.
@ 2018-01-26 15:05 sergiodj+buildbot
  2018-01-26 15:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-26 15:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 56ae9dc397bdf08c4e8f1ef0b64f4320bf88ba3e ***

Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: 56ae9dc397bdf08c4e8f1ef0b64f4320bf88ba3e

Add myself as a write-after-approval GDB maintainer.

gdb/
    * MAINTAINERS (Write After Approval): Add Alan Hayward.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add myself as a write-after-approval GDB maintainer.
@ 2018-01-26 16:01 sergiodj+buildbot
  2018-01-26 17:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-26 16:01 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0bdd8eac9b4512fb392415da65cc7eb7186a50c5 ***

Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: 0bdd8eac9b4512fb392415da65cc7eb7186a50c5

Add myself as a write-after-approval GDB maintainer.

gdb/
    * MAINTAINERS (Write After Approval): Add Alan Hayward.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Updated Russian translation for the bfd sub-directory
@ 2018-01-27 14:46 sergiodj+buildbot
  2018-01-27 15:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-27 14:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7d73b4c8dfc8ae59dc1334e67c7ae2ea493dd121 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 7d73b4c8dfc8ae59dc1334e67c7ae2ea493dd121

Updated Russian translation for the bfd sub-directory


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Avoid compilation warning in libiberty/simple-object-xcoff.c
@ 2018-01-27 16:43 sergiodj+buildbot
  2018-01-27 17:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-27 16:43 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT de54ee813f35cdeee51729c6d50b82935dc88634 ***

Author: Eli Zaretskii <eliz@gnu.org>
Branch: master
Commit: de54ee813f35cdeee51729c6d50b82935dc88634

Avoid compilation warning in libiberty/simple-object-xcoff.c

gdb/ChangeLog:
2018-01-27  Eli Zaretskii  <eliz@gnu.org>

	* simple-object-xcoff.c (simple_object_xcoff_find_sections): Avoid
	compilation warning in 32-bit builds not supported by
	AC_SYS_LARGEFILE.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Avoid compilation errors in MinGW native builds of GDB
@ 2018-01-27 17:07 sergiodj+buildbot
  2018-01-27 20:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-27 17:07 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b2a426e2c5632644b6b8bc0dde4cd32d42d548e2 ***

Author: Eli Zaretskii <eliz@gnu.org>
Branch: master
Commit: b2a426e2c5632644b6b8bc0dde4cd32d42d548e2

Avoid compilation errors in MinGW native builds of GDB

The error is triggered by including python-internal.h, and the
error message is:

     In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0,
	      from build-gnulib/import/math.h:27,
	      from d:/usr/Python26/include/pyport.h:235,
	      from d:/usr/Python26/include/Python.h:58,
	      from python/python-internal.h:94,
	      from python/py-arch.c:24:
     d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared
        using ::hypot;
	        ^~~~~

This happens because Python headers define 'hypot' to expand to
'_hypot' in the Windows builds.

gdb/ChangeLog:
2018-01-27  Eli Zaretskii  <eliz@gnu.org>

	* python/python-internal.h (_hypot) [__MINGW32__]: Define back to
	'hypoth'.  This avoids a compilation error.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove dwarf2_per_objfile_free and use after free of dwarf2_per_objfile
@ 2018-01-28 17:24 sergiodj+buildbot
  2018-01-28 17:35 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-28 17:24 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fc8e7e75c2be02237a7961688b06869814f36a18 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: fc8e7e75c2be02237a7961688b06869814f36a18

Remove dwarf2_per_objfile_free and use after free of dwarf2_per_objfile

I got some crashes while doing some work with dwarf2_per_objfile.  It
turns out that dwarf2_per_objfile_free is using the dwarf2_per_objfile
objects after their destructor has ran.

The easiest way to reproduce this is to run the inferior twice (do
"start" twice).  Currently, it goes unnoticed, but when I tried to
change all_comp_units and all_type_units to std::vectors, things started
crashing.

The dwarf2_per_objfile objects get destroyed here:

 #0  dwarf2_per_objfile::~dwarf2_per_objfile (this=0x35afe70, __in_chrg=<optimized out>) at /home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:2422
 #1  0x0000000000833282 in dwarf2_free_objfile (objfile=0x356cff0) at /home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:25363
 #2  0x0000000000699255 in elf_symfile_finish (objfile=0x356cff0) at /home/emaisin/src/binutils-gdb/gdb/elfread.c:1309
 #3  0x0000000000911ed3 in objfile::~objfile (this=0x356cff0, __in_chrg=<optimized out>) at /home/emaisin/src/binutils-gdb/gdb/objfiles.c:674

and just after that the dwarf2read per-objfile registry cleanup function
gets called:

 #0  dwarf2_per_objfile_free (objfile=0x356cff0, d=0x35afe70) at /home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:25667
 ... registry boilerplate ...
 #4  0x00000000009103ea in objfile_free_data (container=0x356cff0) at /home/emaisin/src/binutils-gdb/gdb/objfiles.c:61
 #5  0x0000000000911ee2 in objfile::~objfile (this=0x356cff0, __in_chrg=<optimized out>) at /home/emaisin/src/binutils-gdb/gdb/objfiles.c:678

In dwarf2_per_objfile_free, we access fields of the dwarf2_per_objfile
object, which is invalid since its destructor has been executed.

This patch moves the content of dwarf2_per_objfile_free to the
destructor of dwarf2_per_objfile.  The call to
register_objfile_data_with_cleanup in _initialize_dwarf2_read can be
changed to the simpler register_objfile_data.

gdb/ChangeLog:

	* dwarf2read.c (free_dwo_files): Add forward-declaration.
	(dwarf2_per_objfile::~dwarf2_per_objfile): Move content from
	dwarf2_per_objfile_free here.
	(dwarf2_per_objfile_free): Remove.
	(_initialize_dwarf2_read): Don't register
	dwarf2_per_objfile_free as a registry cleanup.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PR22741, objcopy segfault on fuzzed COFF object
@ 2018-01-29  5:45 sergiodj+buildbot
  2018-01-29  6:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-29  5:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT eb77f6a4621795367a39cdd30957903af9dbb815 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: eb77f6a4621795367a39cdd30957903af9dbb815

PR22741, objcopy segfault on fuzzed COFF object

	PR 22741
	* coffgen.c (coff_pointerize_aux): Ensure auxent tagndx is in
	range before converting to a symbol table pointer.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Prevent patch remnants from being included in release tarballs.
@ 2018-01-29 13:45 sergiodj+buildbot
  2018-01-29 13:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-29 13:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b431b4ea88c8cc1b75edc4aeaa592942a905c18f ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: b431b4ea88c8cc1b75edc4aeaa592942a905c18f

Prevent patch remnants from being included in release tarballs.

	* src-release.sh (do_proto_toplev): Strip patch remnant files from
	the sources before creating the tarball.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Don't call "detach_inferior" on "remote_follow_fork"
@ 2018-01-29 18:21 sergiodj+buildbot
  2018-01-29 19:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-29 18:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 69ab5edb4d601611ba7b4d05e56689d4b60ca3b1 ***

Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: 69ab5edb4d601611ba7b4d05e56689d4b60ca3b1

Don't call "detach_inferior" on "remote_follow_fork"

This patch fixes a regression that has been introduced by:

  commit bc09b0c14fb713a9aec25e09b78499f3bc2441b5
  Date:   Fri Jan 19 11:48:11 2018 -0500

      Make linux_nat_detach/thread_db_detach use the inferior parameter

It is possible to trigger this failure with gdb.base/foll-fork.exp (in
which case a bunch of ERROR's will be printed), but one can also use
the test below.

Consider the following example program:

  #include <unistd.h>

  int
  main (int argc, char *argv[])
  {
    fork ();

    return 0;
  }

When running it under gdbserver:

  # ./gdb/gdbserver/gdbserver --multi --once :2345

And debugging it under GDB, we see a segmentation fault:

  # ./gdb/gdb -q -batch -ex 'set remote exec-file ./a.out' -ex 'tar extended-remote :2345' -ex r ./a.out
  Starting program:
  ...
  [Detaching after fork from child process 16102.]
  Segmentation fault (core dumped)

The problem happens on inferior.c:detach_inferior:

  void
  detach_inferior (inferior *inf)
  {
    /* Save the pid, since exit_inferior_1 will reset it.  */
    int pid = inf->pid;
              ^^^^^^^^^

    exit_inferior_1 (inf, 0);

    if (print_inferior_events)
      printf_unfiltered (_("[Inferior %d detached]\n"), pid);
  }

When this code is called from remote.c:remote_follow_fork, the PID is
valid but there is no 'inferior' associated with it, which means that
'inf == NULL'.

The proper fix here is to not call "detach_inferior" when doing remote
follow-fork, because we don't have an inferior to detach on the host
side.

Before bc09b0c1, that call was already a nop (exit_inferior_1 bails
out early if you pass it a NULL inferior), except that it printed
"Inferior PID detached" when "set print inferior-events" is on.  Since
native debugging doesn't call detach_inferior in this case, removing
the call from remote aligns remote debugging output with native
debugging output further.

This has been regtested using BuildBot and no regressions were found.

gdb/ChangeLog:
2018-01-29  Sergio Durigan Junior  <sergiodj@redhat.com>

	* remote.c (remote_follow_fork): Don't call "detach_inferior".


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Make __start/__stop symbols dynamic and add testcase
@ 2018-01-30  0:09 sergiodj+buildbot
  2018-01-30  0:27 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-30  0:09 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 36b8fda5d614cb5aaf701a92befa9919bd0b195a ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 36b8fda5d614cb5aaf701a92befa9919bd0b195a

Make __start/__stop symbols dynamic and add testcase

bfd/
	* elflink.c (bfd_elf_define_start_stop): Make __start and __stop
	symbols dynamic.
ld/
	* testsuite/ld-elf/pr21964-3a.c: New file.
	* testsuite/ld-elf/pr21964-3c.c: New file.
	* testsuite/ld-elf/shared.exp: Run new __start/__stop testcase.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb.base/break.exp: fix last "info break" test failure on Ubuntu 16.04
@ 2018-01-30  4:20 sergiodj+buildbot
  2018-01-30  4:39 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-30  4:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fc413dc467e4c46013f6e5a60dc5db24d63f72ea ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: fc413dc467e4c46013f6e5a60dc5db24d63f72ea

gdb.base/break.exp: fix last "info break" test failure on Ubuntu 16.04

The last test of this testcase fails when run on Ubuntu 16.04 using
the system compiler (16.04):

    FAIL: gdb.base/break.exp: verify that they were cleared

This is because the testcase expected that a breakpoint on line 47 of break.c...

    printf ("%d\n", factorial (atoi ("6")));  /* set breakpoint 1 here */

... would actually be inserted on an instruction belonging to
that line. However, what actually happens is that system GCC on
that version of Ubuntu ends up inlining everything, including
the call to printf, thus reporting every instruction of generated
for this line of code as belonging to a different function. As
a result, GDB ends up insering the breakpoint on the next line
of code, which is line 49:

    (gdb) break break.c:$l
    Breakpoint 3 at 0x4005c1: file /[...]/gdb.base/break.c, line 49.

This causes a spurious failure in the "info break" test later on,
as it assumed that the breakpoint above is inserted on line 47:

    gdb_test "info break" "$srcfile:$line" "verify that they were cleared"

This patch fixes the issue by saving the actual source location where
the breakpoint was inserted.

gdb/testsuite/ChangeLog:

        * gdb.base/break.exp: Save the location where the breakpoint
        on break.c:47 was actually inserted when debugging the version
        compiled at -O2 and use it in the expected output of the "info
        break" test performed soon after.

tested on x86_64-linux, with two configurations:
  - Ubuntu 16.04 with the system compiler (breakpoint lands on line 49)
  - Ubuntu 16.04 with GCC 7.3.1 (breakpoint lands on line 47)


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PR22758, FAIL: Run pr22393-2
@ 2018-01-30  8:44 sergiodj+buildbot
  2018-01-30  9:29 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-30  8:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 76cb3a89a6615cf3418fa1efe8268bf6673a5c8a ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 76cb3a89a6615cf3418fa1efe8268bf6673a5c8a

PR22758, FAIL: Run pr22393-2

We can't map different disk pages into the same memory page; The last
page mapped will simply overwrite any previous pages.  The
executable/non-executable new_segment test ignored this fact, leading
to a ld.so segfault on hppa when .dynamic is overwritten with zeros.

This patch moves existing tests for demand paging with lma on the same
memory page, to a new test performed before any case where we want a
new segment due to protection or loadable conflicts.

	PR 22758
	* elf.c (_bfd_elf_map_sections_to_segments): Don't start a new
	segment when demand paged with lma on the same page.  Test this
	before load/non-load, executable/non-executable,
	writable/non-writable tests and simplify.  Delete bogus relro
	condition in writable/non-writable test.  Delete outdated
	comment.  Formatting.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] linux-nat: Eliminate custom target_terminal_{inferior, ours}, stop using set_sigint_trap
@ 2018-01-30 15:53 sergiodj+buildbot
  2018-01-30 16:36 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-30 15:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9c3a5d9319648db16b30a91253ad02d41d242cef ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 9c3a5d9319648db16b30a91253ad02d41d242cef

linux-nat: Eliminate custom target_terminal_{inferior,ours}, stop using set_sigint_trap

This patch gets rid of linux-nat.c's custom
target_terminal_inferior/target_terminal_ours implementations.

The only remaining reason those overrides exist is to install
clear_sigint_trap in order to pass Ctrl-C/SIGINT to the inferior
process in case the inferior is not sharing GDB's terminal (and
target_wait was called without TARGET_WNOHANG).

However, I think that's better handled by QUIT / target_pass_ctrlc
nowadays.  Going that route avoids the issue with set_sigint_trap only
looking at the current inferior to know whether to override SIGINT or
not, which doesn't really work correctly with multi-inferior in the
picture.  Also centralizing on a single SIGINT handler as much as
possible seems better considering a future multi-target world.

Tested on x86-64 GNU/Linux.

gdb/ChangeLog:
2018-01-30  Pedro Alves  <palves@redhat.com>

	* linux-nat.c (wait_for_signal): New function.
	(wait_lwp, linux_nat_wait_1): Use it instead of calling sigsuspend
	directly.
	(async_terminal_is_ours)
	(linux_nat_terminal_inferior, linux_nat_terminal_ours): Delete.
	(linux_nat_add_target): Don't override
	to_terminal_inferior/to_terminal_ours.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Per-inferior target_terminal state, fix PR gdb/13211, more
@ 2018-01-30 16:06 sergiodj+buildbot
  2018-01-30 18:15 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-30 16:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e671cd59d74cec9f53e110ce887128d1eeadb7f2 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: e671cd59d74cec9f53e110ce887128d1eeadb7f2

Per-inferior target_terminal state, fix PR gdb/13211, more

In my multi-target branch I ran into problems with GDB's terminal
handling that exist in master as well, with multi-inferior debugging.

This patch adds a testcase for said problems
(gdb.multi/multi-term-settings.exp), fixes the problems, fixes PR
gdb/13211 as well (and adds a testcase for that too,
gdb.base/interrupt-daemon.exp).

The basis of the problem I ran into is the following.  Consider a
scenario where you have:

 - inferior 1 - started with "attach", process is running on some
   other terminal.

 - inferior 2 - started with "run", process is sharing gdb's terminal.

In this scenario, when you stop/resume both inferiors, you want GDB to
save/restore the terminal settings of inferior 2, the one that is
sharing GDB's terminal.  I.e., you want inferior 2 to "own" the
terminal (in target_terminal::is_ours/target_terminal::is_inferior
sense).

Unfortunately, that's not what you get currently.  Because GDB doesn't
know whether an attached inferior is actually sharing GDB's terminal,
it tries to save/restore its settings anyway, ignoring errors.  In
this case, this is pointless, because inferior 1 is running on a
different terminal, but GDB doesn't know better.

And then, because it is only possible to have the terminal settings of
a single inferior be in effect at a time, or make one inferior/pgrp be
the terminal's foreground pgrp (aka, only one inferior can "own" the
terminal, ignoring fork children here), if GDB happens to try to
restore the terminal settings of inferior 1 first, then GDB never
restores the terminal settings of inferior 2.

This patch fixes that and a few things more along the way:

 - Moves enum target_terminal::terminal_state out of the
   target_terminal class (it's currently private) and makes it a
   scoped enum so that it can be easily used elsewhere.

 - Replaces the inflow.c:terminal_is_ours boolean with a
   target_terminal_state variable.  This allows distinguishing is_ours
   and is_ours_for_output states.  This allows finally making
   child_terminal_ours_1 do something with its "output_only"
   parameter.

 - Makes each inferior have its own copy of the
   is_ours/is_ours_for_output/is_inferior state.

 - Adds a way for GDB to tell whether the inferior is sharing GDB's
   terminal.  Works best on Linux and Solaris; the fallback works just
   as well as currently.

 - With that, we can remove the inf->attach_flag tests from
   child_terminal_inferior/child_terminal_ours.

 - Currently target_ops.to_ours is responsible for both saving the
   current inferior's terminal state, and restoring gdb's state.
   Because each inferior has its own terminal state (possibly handled
   by different targets in a multi-target world, even), we need to
   split the inferior-saving part from the gdb-restoring part.  The
   patch adds a new target_ops.to_save_inferior target method for
   that.

 - Adds a new target_terminal::save_inferior() function, so that
   sequences like:

     scoped_restore_terminal_state save_state;
     target_terminal::ours_for_output ();

   ... restore back inferiors that were
   target_terminal_state::is_inferior before back to is_inferior, and
   leaves inferiors that were is_ours alone.

 - Along the way, this adds a default implementation of
   target_pass_ctrlc to inflow.c (for inf-child.c), that handles
   passing the Ctrl-C to a process running on GDB's terminal or to
   some other process otherwise.

 - Similarly, adds a new target default implementation of
   target_interrupt, for the "interrupt" command.  The current
   implementation of this hook in inf-ptrace.c kills the whole process
   group, but that's incorrect/undesirable because we may not be
   attached to all processes in the process group.  And also, it's
   incorrect because inferior_process_group() doesn't really return
   the inferior's real process group id if the inferior is not a
   process group leader...  This is the cause of PR gdb/13211 [1],
   which this patch fixes.  While at it, that target method's "ptid"
   parameter is eliminated, because it's not really used.

 - A new test is included that exercises and fixes PR gdb/13211, and
   also fixes a GDB issue reported on stackoverflow that I ran into
   while working on this [2].  The problem is similar to PR gdb/13211,
   except that it also triggers with Ctrl-C.  When debugging a daemon
   (i.e., a process that disconnects from the controlling terminal and
   is not a process group leader, then Ctrl-C doesn't work, you just
   can't interrupt the inferior at all, resulting in a hung debug
   session.  The problem is that since the inferior is no longer
   associated with gdb's session / controlling terminal, then trying
   to put the inferior in the foreground fails.  And so Ctrl-C never
   reaches the inferior directly.  pass_signal is only used when the
   inferior is attached, but that is not the case here.  This is fixed
   by the new child_pass_ctrlc.  Without the fix, the new
   interrupt-daemon.exp testcase fails with timeout waiting for a
   SIGINT that never arrives.

[1] PR gdb/13211 - Async / Process group and interrupt not working
https://sourceware.org/bugzilla/show_bug.cgi?id=13211

[2] GDB not reacting Ctrl-C when after fork() and setsid()
https://stackoverflow.com/questions/46101292/gdb-not-reacting-ctrl-c-when-after-fork-and-setsid

Note this patch does _not_ fix:

 - PR gdb/14559 - The 'interrupt' command does not work if sigwait is in use
   https://sourceware.org/bugzilla/show_bug.cgi?id=14559

 - PR gdb/9425 - When using "sigwait" GDB doesn't trap SIGINT. Ctrl+C terminates program when should break gdb.
   https://sourceware.org/bugzilla/show_bug.cgi?id=9425

The only way to fix that that I know of (without changing the kernel)
is to make GDB put inferiors in a separate session (create a
pseudo-tty master/slave pair, make the inferior run with the slave as
its terminal, and have gdb pump output/input on the master end).

gdb/ChangeLog:
2018-01-30  Pedro Alves  <palves@redhat.com>

	PR gdb/13211
	* config.in, configure: Regenerate.
	* configure.ac: Check for getpgid.
	* go32-nat.c (go32_pass_ctrlc): New.
	(go32_target): Install it.
	* inf-child.c (inf_child_target): Install
	child_terminal_save_inferior, child_pass_ctrlc and
	child_interrupt.
	* inf-ptrace.c (inf_ptrace_interrupt): Delete.
	(inf_ptrace_target): No longer install it.
	* infcmd.c (interrupt_target_1): Adjust.
	* inferior.h (child_terminal_save_inferior, child_pass_ctrlc)
	(child_interrupt): Declare.
	(inferior::terminal_state): New.
	* inflow.c (struct terminal_info): Update comments.
	(inferior_process_group): Delete.
	(terminal_is_ours): Delete.
	(gdb_tty_state): New.
	(child_terminal_init): Adjust.
	(is_gdb_terminal, sharing_input_terminal_1)
	(sharing_input_terminal): New functions.
	(child_terminal_inferior): Adjust.  Use sharing_input_terminal.
	Set the process's actual process group in the foreground if
	possible.  Handle is_ours_for_output/is_ours distinction.  Don't
	mark terminal as the inferior's if not sharing GDB's terminal.
	Don't check attach_flag.
	(child_terminal_ours_for_output, child_terminal_ours): Adjust to
	pass down a target_terminal_state.
	(child_terminal_save_inferior): New, factored out from ...
	(child_terminal_ours_1): ... this.  Handle
	target_terminal_state::is_ours_for_output.
	(child_interrupt, child_pass_ctrlc): New.
	(inflow_inferior_exit): Clear the inferior's terminal_state.
	(copy_terminal_info): Copy the inferior's terminal state.
	(_initialize_inflow): Remove reference to terminal_is_ours.
	* inflow.h (inferior_process_group): Delete.
	* nto-procfs.c (nto_handle_sigint, procfs_interrupt): Adjust.
	* procfs.c (procfs_target): Don't install procfs_interrupt.
	(procfs_interrupt): Delete.
	* remote.c (remote_serial_quit_handler): Adjust.
	(remote_interrupt): Remove ptid parameter.  Adjust.
	* target-delegates.c: Regenerate.
	* target.c: Include "terminal.h".
	(target_terminal::terminal_state): Rename to ...
	(target_terminal::m_terminal_state): ... this.
	(target_terminal::init): Adjust.
	(target_terminal::inferior): Adjust to per-inferior
	terminal_state.
	(target_terminal::restore_inferior, target_terminal_is_ours_kind): New.
	(target_terminal::ours, target_terminal::ours_for_output): Use
	target_terminal_is_ours_kind.
	(target_interrupt): Remove ptid parameter.  Adjust.
	(default_target_pass_ctrlc): Adjust.
	* target.h (target_ops::to_terminal_save_inferior): New field.
	(target_ops::to_interrupt): Remove ptid_t parameter.
	(target_interrupt): Remove ptid_t parameter.  Update comment.
	(target_pass_ctrlc): Update comment.
	* target/target.h (target_terminal_state): New scoped enum,
	factored out of ...
	(target_terminal::terminal_state): ... here.
	(target_terminal::inferior): Update comments.
	(target_terminal::restore_inferior): New.
	(target_terminal::is_inferior, target_terminal::is_ours)
	(target_terminal::is_ours_for_output): Adjust.
	(target_terminal::scoped_restore_terminal_state): Adjust to
	rename, and call restore_inferior() instead of inferior().
	(target_terminal::scoped_restore_terminal_state::m_state): Change
	type.
	(target_terminal::terminal_state): Rename to ...
	(target_terminal::m_terminal_state): ... this and change type.

gdb/gdbserver/ChangeLog:
2018-01-30  Pedro Alves  <palves@redhat.com>

	PR gdb/13211
	* target.c (target_terminal::terminal_state): Rename to ...
	(target_terminal::m_terminal_state): ... this.

gdb/testsuite/ChangeLog:
2018-01-30  Pedro Alves  <palves@redhat.com>

	PR gdb/13211
	* gdb.base/interrupt-daemon.c: New.
	* gdb.base/interrupt-daemon.exp: New.
	* gdb.multi/multi-term-settings.c: New.
	* gdb.multi/multi-term-settings.exp: New.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] s390: Fix gdb.base/all-architectures.exp with --enable-targets=all
@ 2018-01-30 16:50 sergiodj+buildbot
  2018-01-30 19:54 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-30 16:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c81e88797907fc0698abec09767e49cee33b2bd5 ***

Author: Philipp Rudo <prudo@linux.vnet.ibm.com>
Branch: master
Commit: c81e88797907fc0698abec09767e49cee33b2bd5

s390: Fix gdb.base/all-architectures.exp with --enable-targets=all

With 7042632bf79 (s390: Hook s390 into OSABI mechanism) assigning a
default target description was moved from s390_gdbarch_init to
s390_linux_init_abi_*.  This causes problems when GDB is built with
--enable-targets=all and the user sets an unsupported OSABI, e.g. "set
osabi AIX".  In this case there is no valid tdesc, and GDB crashes with an
internal error.  Fix this by reverting parts of 7042632bf79.

gdb/ChangeLog:

	* s390-linux-tdep.c: Remove includes "features/s390-linux32.c" and
	"features/s390x-linux64.c".
	(_initialize_s390_linux_tdep): Remove initialization of tdescs
	s390_linux32 and s390x_linux64.
	(s390_linux_init_abi_31, s390_linux_init_abi_64): Don't set
	default tdesc.
	* s390-tdep.c: Include "features/s390-linux32.c" and
	"features/s390x-linux64.c".
	(s390_tdesc_valid): Add check for tdesc_has_registers.
	(s390_gdbarch_init): Make sure there is always a valid tdesc.
	(_initialize_s390_tdep): Initialize tdesc_s390_linux32 and
	tdesc_s390x_linux64.
	* s390-linux-tdep.h: Move export of tdesc_s390_linux32 and
	tdesc_s390x_linux64 to...
	* s390-tdep.h: ...here.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Improve junk file removal in source tarball creation script.
@ 2018-01-30 18:05 sergiodj+buildbot
  2018-01-30 22:15 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-30 18:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 52b2f30022323367b2cd727f402c9876bdc53b0d ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 52b2f30022323367b2cd727f402c9876bdc53b0d

Improve junk file removal in source tarball creation script.

	* src-release.sh (do_proto_toplev): Add patterns for more junk files
	to delete before creating the tarball.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] internal-error using '@' (repeat) operator on array of dynamic objects
@ 2018-01-31  7:35 sergiodj+buildbot
  2018-01-31  8:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-31  7:35 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 929b5ad40f70fbd5bdf37d30281a761d56c87b59 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 929b5ad40f70fbd5bdf37d30281a761d56c87b59

internal-error using '@' (repeat) operator on array of dynamic objects

Using the following Ada declarations (the same as in
gdb.ada/dyn_stride.exp)...

      subtype Small_Type is Integer range L .. U;
      type Record_Type (I : Small_Type := L) is record
         S : String (1 .. I);
      end record;
      type Array_Type is array (Integer range <>) of Record_Type;

      A1 : Array_Type :=
        (1 => (I => U, S => (others => ASCII.NUL)),
         2 => (I => 1, S => "A"),
         3 => (I => 2, S => "AB"));

... where "L" and "U" are variables, trying to apply the repeat
operator to "A1(1)" yields to an internal error:

  | (gdb) print a1(1)@3
  | $5 = /[...]/gdbtypes.c:4883: internal-error: type* copy_type(const type*):
  | Assertion `TYPE_OBJFILE_OWNED (type)' failed.

What happens first is that the ada-lang module evaluated the "A1(1)"
sub-expression returning a structure where "I" (one of the fields
in that structure) has a type which is dynamic, because it is
a range type whose bounds are not statically known.

Next, we apply the repeat ('@') operator, which is done via
allocate_repeat_value, which creates an array type with the correct
bounds to associate to our value, by calling lookup_array_range_type:

  | struct type *
  | lookup_array_range_type (struct type *element_type,
  |                          LONGEST low_bound, LONGEST high_bound)
  | {
  |   struct gdbarch *gdbarch = get_type_arch (element_type);
  |   struct type *index_type = builtin_type (gdbarch)->builtin_int;
  |   struct type *range_type
  |     = create_static_range_type (NULL, index_type, low_bound, high_bound);
  |
  |   return create_array_type (NULL, element_type, range_type);
  | }

As we can see, this creates an array type whose index type is
always owned by the gdbarch. This is where the problem lies.

Next, we use that type to construct a struct value. That value
then gets passed to the valprint module, which then checks
whether our object is dynamic or not. And because field "I" above
had a dynamic range type, we end up determining by association
that the artificial repeat array itself is also dynamic. So
we attempt to resolve the type, which leads to trying to copying
that type. And because the artifical array created by
lookup_array_range_type has an index which is not objfile-owned,
we trip the assertion.

This patch fixes the issue by enhancing lookup_array_range_type
to create an index type which has the same owner as the element
type.

gdb/ChangeLog:

        * gdbtypes.c (lookup_array_range_type): Make sure the array's
        index type is objfile-owned if the element type is as well.

gdb/testsuite/ChangeLog:

        * testsuite/gdb.ada/dyn_stride.exp: Add "print a1(1)@3" test.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] (Ada) Add testcase for catch assert with condition
@ 2018-01-31 13:03 sergiodj+buildbot
  2018-01-31 13:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-31 13:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 395507f62b98a6a1f6778295a5667110b0fc4b57 ***

Author: Xavier Roirand <roirand@adacore.com>
Branch: master
Commit: 395507f62b98a6a1f6778295a5667110b0fc4b57

(Ada) Add testcase for catch assert with condition

gdb/testsuite/ChangeLog:

    * gdb.ada/catch_assert_if.exp: New testcase.
    * gdb.ada/catch_assert_if/bla.adb: New file.
    * gdb.ada/catch_assert_if/pck.ads: New file.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] (Ada/MI) Add testcase for mi catch assert with condition
@ 2018-01-31 13:16 sergiodj+buildbot
  2018-01-31 14:58 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-31 13:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4fa955b25e31cd071ca7f3b03a2cc89811f9705d ***

Author: Xavier Roirand <roirand@adacore.com>
Branch: master
Commit: 4fa955b25e31cd071ca7f3b03a2cc89811f9705d

(Ada/MI) Add testcase for mi catch assert with condition

gdb/testsuite/ChangeLog:

    * gdb.ada/mi_catch_assert.exp: New testcase.
    * gdb.ada/mi_catch_assert/bla.adb: New file.
    * gdb.ada/mi_catch_assert/pck.ads: New file.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] (Ada) Add gdb-mi support for stopping at start of exception handler.
@ 2018-01-31 13:41 sergiodj+buildbot
  2018-01-31 20:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-31 13:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bea298f9547372e6cb7854fabc2c0646e1d3d9be ***

Author: Xavier Roirand <roirand@adacore.com>
Branch: master
Commit: bea298f9547372e6cb7854fabc2c0646e1d3d9be

(Ada) Add gdb-mi support for stopping at start of exception handler.

Following my previous commit which add support for stopping at start of
exception handler, this commit adds required gdb-mi support for this
feature.

gdb/ChangeLog:

    * mi/mi-cmd-catch.c (mi_cmd_catch_handlers): New function.
    * mi/mi-cmds.c (mi_cmds): Add catch-handlers command.
    * mi/mi-cmds.h (mi_cmd_catch_handlers): Add external declaration.
    * NEWS: Document "-catch-handlers" command.

gdb/doc/ChangeLog:

    * gdb.texinfo (Ada Exception gdb/mi Catchpoints): Add
    documentation for new "-catch-handlers" command.

gdb/testsuite/ChangeLog:

    * gdb.ada/mi_catch_ex_hand.exp: New testcase.
    * gdb.ada/mi_catch_ex_hand/foo.adb: New file.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Check if __start/__stop symbols are referenced by shared objects
@ 2018-01-31 13:56 sergiodj+buildbot
  2018-01-31 22:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-31 13:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 823143c6ca8ef4267e67ba03771991e08d09fabd ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 823143c6ca8ef4267e67ba03771991e08d09fabd

Check if __start/__stop symbols are referenced by shared objects

Define  __start/__stop symbols if they are referenced by shared objects,
not if they are also defined in shared objects.

bfd/

	PR ld/21964
	* elflink.c (bfd_elf_define_start_stop): Check if __start and
	__stop symbols are referenced by shared objects.

ld/

	PR ld/21964
	* testsuite/ld-elf/pr21964-4.c: New file.
	* testsuite/ld-elf/shared.exp: Run pr21964-4 test on Linux.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] (Ada) C++fy conditional string when catching exception.
@ 2018-01-31 13:56 sergiodj+buildbot
  2018-01-31 17:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-31 13:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 56ecd069f031d6bcdaa46664c68a16cb27b379c3 ***

Author: Xavier Roirand <roirand@adacore.com>
Branch: master
Commit: 56ecd069f031d6bcdaa46664c68a16cb27b379c3

(Ada) C++fy conditional string when catching exception.

This commit C++fy the conditional string used when catching Ada exception.

gdb/ChangeLog:

        * ada-lang.c (catch_ada_exception_command_split)
        (create_ada_exception_catchpoint) <cond_string>: Change parameter
        type.  Update code accordingly.
        (catch_ada_exception_command, catch_ada_handlers_command): Use
        C++ string instead of char* for conditional var.
        (catch_ada_assert_command_split) <cond_string>: Change parameter
        type.  Update code accordingly.
        (catch_assert_command): Use C++ string instead of char* for
        conditional var.
        * ada-lang.h (create_ada_exception_catchpoint) <cond_string>:
        Update declaration.
        * mi/mi-cmd-catch.c (mi_cmd_catch_assert, mi_cmd_catch_exception):
        Use std::string instead of char* for condition string.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] bfd_elf_define_start_stop: Fix check
@ 2018-01-31 15:00 sergiodj+buildbot
  2018-02-01  0:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-31 15:00 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bf3077a6c3c9ff21c072a6f42c91bffefd35bc15 ***

Author: Michael Matz <matz@suse.de>
Branch: master
Commit: bf3077a6c3c9ff21c072a6f42c91bffefd35bc15

bfd_elf_define_start_stop: Fix check

We really need to check for a dynamic def, not only a ref.
See added testcase.

bfd/
	* elflink.c (bfd_elf_define_start_stop): Fix check of
	def_dynamic.

ld/
	* testsuite/ld-elf/pr21964-5.c: New test.
	* testsuite/ld-elf/shared.exp: Run it.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb: Fix remote-sim/MinGW/Darwin builds
@ 2018-01-31 15:21 sergiodj+buildbot
  2018-02-01  2:58 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-31 15:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f6cfb42730ed37bfb32cb27ef627df930f437f08 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: f6cfb42730ed37bfb32cb27ef627df930f437f08

gdb: Fix remote-sim/MinGW/Darwin builds

The recent commit e671cd59 ("Per-inferior target_terminal state, fix
PR gdb/13211, more") missed adjusting a few targets to the new
target_ops->to_interrupt interface, breaking the build for those
targets.  This fixes it.

Note: remote-sim doesn't really support async execution, so I don't
think gdbsim_interrupt is ever reached via target_interrupt.  (It is
reached via gdbsim_cntrl_c though).

The inflow.c changes are a bit ugly, but they're just doing what other
parts of the file already do to handle the same missing functions.
Targets that don't have 'kill', like mingw have their own
target_ops->to_interrupt implementation, so it's fine to make
child_interrupt be a nop.

gdb/ChangeLog:
2018-01-31  Pedro Alves  <palves@redhat.com>

	* darwin-nat.c (darwin_interrupt): Remove ptid_t parameter.
	* inflow.c (child_terminal_save_inferior): Wrap reference to
	tcgetpgrp in HAVE_TERMIOS_H.
	(child_interrupt, child_pass_ctrlc): Wrap references to signal in
	_WIN32.
	* remote-sim.c (gdbsim_interrupt): Remove ptid_t parameter and
	always iterate over all inferiors.
	(gdbsim_cntrl_c): Adjust.
	* windows-nat.c (windows_interrupt): Remove 'ptid_t' parameter.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix for prologue processing on PowerPC
@ 2018-01-31 18:40 sergiodj+buildbot
  2018-02-01  4:48 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-01-31 18:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 07e5f5cf883c64f7bd8a2afa4302c0479670b03f ***

Author: Nikola Prica <nikola.prica@rt-rk.com>
Branch: master
Commit: 07e5f5cf883c64f7bd8a2afa4302c0479670b03f

Fix for prologue processing on PowerPC

One of conditions in skip_prologue() was never visited if there was mflr
instruction that moves the link register to a register different than r0.
This condition expects non shifted value of `lr_reg`. Previously offset
of link register was never saved for registers different than r0.

gdb/ChangeLog:

2018-01-31  Nikola Prica  <nikola.prica@rt-rk.com>

	* rs6000-tdep.c (skip_prologue): Remove shifting for lr_reg and
	assign shifted lr_reg to fdata->lr_register when lr_reg is set.

gdb/testsuite/ChangeLog:

2018-01-31  Nikola Prica  <nikola.prica@rt-rk.com>

	* gdb.arch/powerpc-prologue-frame.s: New file.
	* gdb.arch/powerpc-prologue-frame.c: Likewise.
	* gdb.arch/powerpc-prologue-frame.exp: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix compile time warnings building the binutils with clang.
@ 2018-02-01 13:38 sergiodj+buildbot
  2018-02-01 13:58 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-01 13:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e99955cd8eca9ac8eff828e8c7b676955fd46e04 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: e99955cd8eca9ac8eff828e8c7b676955fd46e04

Fix compile time warnings building the binutils with clang.

bfdI would like to fix instances of the following warning, when building
with clang with no special CFLAGS other than -g3 -O0.

/home/emaisin/src/binutils-gdb/bfd/elflink.c:5425:45: error: performing pointer arithmetic on a null pointer has undefined behavior [-Werror,-Wnull-pointer-arithmetic]
    return (struct elf_link_hash_entry *) 0 - 1;
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^

Replacing those with "(struct elf_link_hash_entry *) -1" gets rid of the
warning.  I wanted to check that it didn't change the resulting code, so
I tried to build this:

  $ cat test.c
  int *before()
  {
          return (int *) 0 - 1;
  }

  int *after()
  {
          return (int *) - 1;
  }

  $ gcc -c test.c -g
  $ objdump -d test.o

  test.o:     file format elf64-x86-64

  Disassembly of section .text:

  0000000000000000 <before>:
     0:   55                      push   %rbp
     1:   48 89 e5                mov    %rsp,%rbp
     4:   48 c7 c0 fc ff ff ff    mov    $0xfffffffffffffffc,%rax
     b:   5d                      pop    %rbp
     c:   c3                      retq

  000000000000000d <after>:
     d:   55                      push   %rbp
     e:   48 89 e5                mov    %rsp,%rbp
    11:   48 c7 c0 ff ff ff ff    mov    $0xffffffffffffffff,%rax
    18:   5d                      pop    %rbp
    19:   c3                      retq

This shows that the previous code doesn't actually return -1 as the
function documentation says, but the new one does, so it's kind of a
bugfix.

bfd	* elf64-ppc.c (ppc64_elf_archive_symbol_lookup): Avoid pointer
	arithmetic on NULL pointer.
	* elflink.c (_bfd_elf_archive_symbol_lookup,
	elf_link_add_archive_symbols): Likewise.

ld	* ldexp.c (fold_name, exp_fold_tree_1): Avoid pointer arithmetic
	on NULL pointer.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix gdb.base/attach.exp fails when gdb is configured --with-sysroot=/
@ 2018-02-01 15:05 sergiodj+buildbot
  2018-02-01 15:54 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-01 15:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d4d38844faaff1576b021558d0835dedbd415e8d ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: d4d38844faaff1576b021558d0835dedbd415e8d

Fix gdb.base/attach.exp fails when gdb is configured --with-sysroot=/

I see some test fails in gdb.base/attach.exp when gdb is configured
--with-sysroot=/.

FAIL: gdb.base/attach.exp: attach2, with no file
FAIL: gdb.base/attach.exp: load file manually, after attach2 (re-read) (got interactive prompt)
FAIL: gdb.base/attach.exp: attach when process' a.out not in cwd

If gdb is configured this way, sysroot is "/" in default, and if binfile
is a absolute path, the regexp pattern $sysroot$escapedbinfile is
incorrect.

There are different ways to fix it, but I don't want to complicate the
test, so I choose this naive way.

gdb/testsuite:

2018-02-01  Yao Qi  <yao.qi@linaro.org>

	* gdb.base/attach.exp (do_attach_tests): Set sysroot to
	"\[^\r\n\]*".


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] set ret signed in arm_record_extension_space
@ 2018-02-01 15:47 sergiodj+buildbot
  2018-02-01 18:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-01 15:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT df95a9cf09867c237ddf9b4eb65a990e86de1e17 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: df95a9cf09867c237ddf9b4eb65a990e86de1e17

set ret signed in arm_record_extension_space

Variable 'ret' should be int rather than unsigned, as it can be -1.

gdb:

2018-02-01  Yao Qi  <yao.qi@linaro.org>

	* arm-tdep.c (arm_record_extension_space): Change ret to signed.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Rewrite arm_record_coproc_data_proc and arm_record_data_proc_misc_ld_str
@ 2018-02-01 16:11 sergiodj+buildbot
  2018-02-01 20:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-01 16:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2d9e6acbdbc528563a9df5445584a8a150a86527 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 2d9e6acbdbc528563a9df5445584a8a150a86527

Rewrite arm_record_coproc_data_proc and arm_record_data_proc_misc_ld_str

When I triage some reverse debugging test fails on arm-linux, I find
arm_record_coproc_data_proc and arm_record_data_proc_misc_ld_str is not
friendly to instruction encoding on ARM ARM.  This patch rewrites them, in
a way match more closely to the manual.

gdb:

2018-02-01  Yao Qi  <yao.qi@linaro.org>

	* arm-tdep.c (arm_record_data_proc_misc_ld_str): Rewrite it.
	(arm_record_coproc_data_proc): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Do not classify C struct members as a filename
@ 2018-02-02  3:50 sergiodj+buildbot
  2018-02-02  4:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-02  3:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 59498c305e6f1db2a1ed8d44cb58f0d24ec092fe ***

Author: Leszek Swirski <leszeks@google.com>
Branch: master
Commit: 59498c305e6f1db2a1ed8d44cb58f0d24ec092fe

Do not classify C struct members as a filename

There is existing logic in C/C++ expression parsing to avoid classifying
names as a filename when they are a field on the this object. This
change extends this logic to also avoid classifying names after a
struct-op (-> or .) as a filename, which otherwise causes a syntax
error.

Thus, it is now possible in the file

    #include <map>
    struct D {
        void map();
    }
    D d;

to call

    (gdb) print d.map()

where previously this would have been a syntax error.

Tested on gdb.cp/*.exp

gdb/ChangeLog:

        * c-exp.y (lex_one_token, classify_name, yylex): Don't classify
        names after a structop as a filename

gdb/testsuite/ChangeLog:

        * gdb.cp/filename.cc, gdb.cp/filename.exp: Test that member
        functions with the same name as an include file are parsed
        correctly.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PowerPC64, don't relocate nops
@ 2018-02-02 12:31 sergiodj+buildbot
  2018-02-02 12:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-02 12:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d830549dba59f4e11412fd6dc18b7b1d4c6cf557 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: d830549dba59f4e11412fd6dc18b7b1d4c6cf557

PowerPC64, don't relocate nops

This fixes a "bug" in that nops emitted as part of code optimization
were being relocated.  As it happens the relocation value was always
zero so the nop wasn't changed.  Whew!  I've also moved the use of
"howto" later since I was caught out in some recent code changes with
the howto not matching r_type.

	* elf64-ppc.c (ppc64_elf_relocate_section): Don't relocate nops
	emitted for toc sequence optimization.  Set and use "howto" later.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] MI: Allow non-raw varobj evaluation
@ 2018-02-02 19:21 sergiodj+buildbot
  2018-02-02 19:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-02 19:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0625771b9e29116dc1fb0b597501f18e4bb0e18c ***

Author: Leszek Swirski via gdb-patches <gdb-patches@sourceware.org>
Branch: master
Commit: 0625771b9e29116dc1fb0b597501f18e4bb0e18c

MI: Allow non-raw varobj evaluation

Make the MI variable object expression evaluation, with the
-var-evaluate-expression command, recursively call pretty printers, to
match the output of normal expression printing.

Consider the following code:

        struct Foo { int val; };
        struct Wrapper { Foo foo; };

        int main() {
                Wrapper w;
                w.foo.val = 23;
        }

and this pretty printer file:

        import gdb.printing

        class FooPrinter:
          def __init__(self, val):
            self.val = val
          def to_string(self):
            return "Foo" + str(self.val["val"])

        class WrapperPrinter:
          def __init__(self, val):
            self.val = val
          def to_string(self):
            return self.val["foo"]

        test_printer = gdb.printing.RegexpCollectionPrettyPrinter("test")
        test_printer.add_printer('Foo', '^Foo$', FooPrinter)
        test_printer.add_printer('Wrapper', '^Wrapper$', WrapperPrinter)

        gdb.printing.register_pretty_printer(None, test_printer)

Setting a breakpoint at the end of the function, we call the following commands:

        -enable-pretty-printing
        ^done

        -var-create var_w @ w
        ^done,name="var_w",numchild="0",value="{val = 23}",type="Wrapper",dynamic="1",has_more="0"
        -var-create var_w_foo @ w.foo
        ^done,name="var_w_foo",numchild="0",value="Foo23",type="Foo",dynamic="1",has_more="0"

        -var-evaluate-expression var_w
        ^done,value="{val = 23}"
        -var-evaluate-expression var_w_foo
        ^done,value="Foo23"

        -data-evaluate-expression w
        ^done,value="Foo23"
        -data-evaluate-expression w.foo
        ^done,value="Foo23"

So, in the -var-evaluate-expression var_w case, we print the "raw" value
of w.foo, while in the -data-evaluate-expression w case, we print the
pretty printed w.foo value. After this patch, all of the above print
"Foo23".

gdb/ChangeLog:

	* varobj.c (varobj_formatted_print_options): Allow recursive
	pretty printing if pretty printing is enabled.

gdb/testsuite/ChangeLog:

	* gdb.python/py-prettyprint.c
	(struct to_string_returns_value_inner,
	struct to_string_returns_value_wrapper): New.
	(main): Add tsrvw variable.
	* gdb.python/py-prettyprint.py (ToStringReturnsValueInner,
	ToStringReturnsValueWrapper): New classes.
	(register_pretty_printers): Register new pretty-printers.
	* gdb.python/py-prettyprint.exp (run_lang_tests): Test printing
	recursive pretty printer.
	* gdb.python/py-mi.exp: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] RISC-V: Fix --wrap and relaxation conflict.
@ 2018-02-02 20:58 sergiodj+buildbot
  2018-02-02 21:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-02 20:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7f02625eb48105e100d2da58091d56978ed041ef ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 7f02625eb48105e100d2da58091d56978ed041ef

RISC-V: Fix --wrap and relaxation conflict.

	bfd/
	PR ld/22756
	* elfnn-riscv.c (riscv_relax_delete_bytes): New parameter link_info.
	If link_info->wrap_hash, check for a duplicate symbol and ignore.
	(_bfd_riscv_relax_call, bfd_riscv_relax_lui, _bfd_riscv_relax_tls_le):
	Pass new argument to riscv_relax_delete_bytes.
	(_bfd_riscv_relax_align, _bfd_riscv_relax_delete): Likewise.  Remove
	ATTRIBUTE_UNUSED from link_info parameter.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb/testsuite: Remove use of dejagnu cleanup proc
@ 2018-02-03 17:11 sergiodj+buildbot
  2018-02-03 17:30 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-03 17:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f721678315fc6bbec25341bd616a906976d72693 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: f721678315fc6bbec25341bd616a906976d72693

gdb/testsuite: Remove use of dejagnu cleanup proc

The 'cleanup' proc has been removed from dejagnu (Feb 15 2016).  The
proc has not done anything useful since at least 2001 so removing
these calls should be harmless.

gdb/testsuite/ChangeLog:

	* config/sid.exp (gdb_target_sid): Remove use of cleanup.
	* config/sim.exp (gdb_target_sim): Remove use of cleanup.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Move comment in gdb/dwarf2read.c::dwarf2_physname
@ 2018-02-05  5:03 sergiodj+buildbot
  2018-02-05  5:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-05  5:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0eb876f52f348ff08be24bca6cbca00e302839b2 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 0eb876f52f348ff08be24bca6cbca00e302839b2

Move comment in gdb/dwarf2read.c::dwarf2_physname

This commit just moves a comment right next to where it is actually
relevant. No actual code change.

gdb/ChangeLog:

        * dwarf2read.c (dwarf2_physname): Move commment.

Tested by rebuilding GDB.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Align natural-format register values to the same column
@ 2018-02-05  8:46 sergiodj+buildbot
  2018-02-05  9:54 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-05  8:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e813d34aaabee0ca034fa5ddd50e76ade80318bc ***

Author: Ruslan Kabatsayev <b7.10110111@gmail.com>
Branch: master
Commit: e813d34aaabee0ca034fa5ddd50e76ade80318bc

Align natural-format register values to the same column

Currently, commands such as "info reg", "info all-reg", as well as register
window in the TUI print badly aligned columns, like here:

eax            0x1      1
ecx            0xffffd3e0       -11296
edx            0xffffd404       -11260
ebx            0xf7fa5ff4       -134586380
esp            0xffffd390       0xffffd390
ebp            0xffffd3c8       0xffffd3c8
esi            0x0      0
edi            0x0      0
eip            0x8048b60        0x8048b60 <main+16>
eflags         0x286    [ PF SF IF ]
cs             0x23     35
ss             0x2b     43
ds             0x2b     43
es             0x2b     43
fs             0x0      0
gs             0x63     99

After this patch, these commands print the third column values consistently
aligned one under another, provided the second column is not too long.
Originally, the third column was (attempted to be) aligned using a simple tab
character. This patch changes the alignment to spaces only. The tests checking
the output and expecting the single tab have been fixed in a previous patch, so
this change doesn't break any.

gdb/ChangeLog:

	* infcmd.c (default_print_one_register_info): Align natural-format
	column values consistently one under another.
	(pad_to_column): New function.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Updated Brazillian portuguese and Russian translation
@ 2018-02-05 13:23 sergiodj+buildbot
  2018-02-05 13:42 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-05 13:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f174ef9fb2d7d858fc77807045b6308e9502bd82 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: f174ef9fb2d7d858fc77807045b6308e9502bd82

Updated Brazillian portuguese and Russian translation


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] ELF/BFD: Propagate the return status from backend section processing
@ 2018-02-05 14:17 sergiodj+buildbot
  2018-02-05 16:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-05 14:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7550610057c51d47e3815ef93893d4f4faa7e03d ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 7550610057c51d47e3815ef93893d4f4faa7e03d

ELF/BFD: Propagate the return status from backend section processing

Fix the issue of any failure from `->elf_backend_section_processing'
not being propagated by `_bfd_elf_write_object_contents'.  The MIPS
`_bfd_mips_elf_section_processing' handler can actually potentially
fail, however the caller currently ignores that.

	bfd/
	* elf.c (_bfd_elf_write_object_contents): Propagate a failure
	status from `->elf_backend_section_processing'.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] MIPS/BFD: Correctly report unsupported `.reginfo' section size
@ 2018-02-05 14:29 sergiodj+buildbot
  2018-02-05 20:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-05 14:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2d6dda71611ba6cc16fe2bd21ac816d5f7d1e74d ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 2d6dda71611ba6cc16fe2bd21ac816d5f7d1e74d

MIPS/BFD: Correctly report unsupported `.reginfo' section size

Report an error when an unsupported `.reginfo' section size is found in
`_bfd_mips_elf_section_processing', removing an assertion that triggers
at elfxx-mips.c:7105 in GAS when assembling input like:

	.section	.reginfo
	.word		0xdeadbeef

and in `objcopy --rename-section' when renaming an incorrectly sized
section to `.reginfo'.

	bfd/
	* elfxx-mips.c (_bfd_mips_elf_section_processing): For
	SHT_MIPS_REGINFO sections don't assert the correct size and
	report an error instead.

	binutils/
	* testsuite/binutils-all/mips/mips-reginfo.d: New test.
	* testsuite/binutils-all/mips/mips-reginfo-n32.d: New test.
	* testsuite/binutils-all/mips/mips-reginfo.s: New test source.
	* testsuite/binutils-all/mips/mips.exp: Run the new tests.

	gas/
	* testsuite/gas/mips/reginfo-2.d: New test.
	* testsuite/gas/mips/reginfo-2-n32.d: New test.
	* testsuite/gas/mips/reginfo-2.l: New test stderr output.
	* testsuite/gas/mips/reginfo-2.s: New test source.
	* testsuite/gas/mips/mips.exp: Run the new tests.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] RISC-V/BFD: Correct a missing initializer error with pre-4.7 GCC
@ 2018-02-05 14:42 sergiodj+buildbot
  2018-02-05 22:30 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-05 14:42 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e65b1a78686f840ab46fe97355d674919185adc8 ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: e65b1a78686f840ab46fe97355d674919185adc8

RISC-V/BFD: Correct a missing initializer error with pre-4.7 GCC

Correct a commit 9d06997adb88 ("RISC-V: Relax RISCV_PCREL_* to
RISCV_GPREL_*") regression and remove a `-Wmissing-field-initializers'
compilation error:

cc1: warnings being treated as errors
.../bfd/elfnn-riscv.c: In function '_bfd_riscv_relax_pc':
.../bfd/elfnn-riscv.c:3117: error: missing initializer
.../bfd/elfnn-riscv.c:3117: error: (near initialization for 'hi_reloc.hi_addend')
make[4]: *** [elf64-riscv.lo] Error 1

which for versions of GCC before 4.7 prevents support for RISC-V targets
from being built.  See also GCC PR c/36750.

	bfd/
	* elfnn-riscv.c (_bfd_riscv_relax_pc): Use `memset' to
	initialize `hi_reloc'.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use visitors for make_gdb_type
@ 2018-02-05 16:54 sergiodj+buildbot
  2018-02-06  0:06 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-05 16:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b8df6ca79e69678a07d3216b9b2b552fce27cda8 ***

Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: b8df6ca79e69678a07d3216b9b2b552fce27cda8

Use visitors for make_gdb_type

Remove the make_gdb_type functions from the tdesc_type_ classes.
Replace with a static make_gdb_type function that uses a element
visitor called gdb_type_creator.

gdb/
	* target-descriptions.c (tdesc_element_visitor) Add empty implementations.
	(tdesc_type): Move make_gdb_type from here.
	(tdesc_type_builtin): Likewise.
	(tdesc_type_vector): Likewise.
	(tdesc_type_with_fields): Move make_gdb_type_ functions from here.
	(make_gdb_type_struct): Move from tdesc_type_with_fields.
	(make_gdb_type_union): Likewise.
	(make_gdb_type_flags): Likewise.
	(make_gdb_type_enum): Likewise.
	(make_gdb_type): New function.
	(tdesc_register_type): Use static make_gdb_type.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: Remove the unused _GLOBAL_OFFSET_TABLE_
@ 2018-02-05 17:05 sergiodj+buildbot
  2018-02-06  2:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-05 17:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cd04836359da82ae1dc67e5a05565536f4427b51 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: cd04836359da82ae1dc67e5a05565536f4427b51

x86: Remove the unused _GLOBAL_OFFSET_TABLE_

Since _GLOBAL_OFFSET_TABLE_ may be referenced implicitly on x86,
checking ref_regular_nonweak leaves the unused _GLOBAL_OFFSET_TABLE_
in output.  This patch checks explicit GOT references instead.

ld-i386/discarded1.s and ld-x86-64/discarded1.s are updated to avoid
linker optimization which removes GOT references.

bfd/

	PR ld/22782
	* elf32-i386.c (elf_i386_check_relocs): Set got_referenced if
	_GLOBAL_OFFSET_TABLE_ is referenced or GOT is needed to resolve
	undefined weak symbol to 0.
	* elf64-x86-64.c (elf_x86_64_check_relocs): Set got_referenced
	if _GLOBAL_OFFSET_TABLE_ is referenced.
	* elfxx-x86.c (_bfd_x86_elf_size_dynamic_sections): Check
	got_referenced instead of ref_regular_nonweak.  Remove the
	unused _GLOBAL_OFFSET_TABLE_ from symbol table.
	* elfxx-x86.h (elf_x86_link_hash_table): Add got_referenced.

ld/

	PR ld/22782
	* testsuite/ld-i386/discarded1.s: Replace mov with div.
	* testsuite/ld-x86-64/discarded1.s: Likewise.
	* testsuite/ld-i386/i386.exp: Run pr22782.
	* testsuite/ld-i386/load1-nacl.d: Updated for removing
	_GLOBAL_OFFSET_TABLE_ from output.
	* testsuite/ld-i386/load1.d: Likewise.
	* testsuite/ld-x86-64/load1a-nacl.d: Likewise.
	* testsuite/ld-x86-64/load1a.d: Likewise.
	* testsuite/ld-x86-64/load1b-nacl.d: Likewise.
	* testsuite/ld-x86-64/load1b.d: Likewise.
	* testsuite/ld-i386/pr22782.d: New file.
	* testsuite/ld-i386/pr22782.s: Likewise.
	* testsuite/ld-x86-64/pr22782.s: Likewise.
	* testsuite/ld-x86-64/pr22782a.d: Likewise.
	* testsuite/ld-x86-64/pr22782b.d: Likewise.
	* testsuite/ld-x86-64/x86-64.exp: Run pr22782a and pr22782b.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove myself as a write-after-approval GDB maintainer.
@ 2018-02-05 18:11 sergiodj+buildbot
  2018-02-06  3:58 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-05 18:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f3b91ed8f96a4d41eef1c64a7e77c406ec763612 ***

Author: Antoine Tremblay <antoine.tremblay@ericsson.com>
Branch: master
Commit: f3b91ed8f96a4d41eef1c64a7e77c406ec763612

Remove myself as a write-after-approval GDB maintainer.

Since I'll be leaving Ericsson.

gdb/
	* MAINTAINERS (Write After Approval): Remove Antoine Tremblay.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [PR22764][LD][AARCH64]Allow R_AARCH64_ABS16 and R_AARCH64_ABS32 against absolution symbol or undefine symbol in shared object.
@ 2018-02-05 18:56 sergiodj+buildbot
  2018-02-06  5:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-05 18:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 279b2f94168ee91e02ccd070d27c983fc001fe12 ***

Author: Renlin Li <renlin.li@arm.com>
Branch: master
Commit: 279b2f94168ee91e02ccd070d27c983fc001fe12

[PR22764][LD][AARCH64]Allow R_AARCH64_ABS16 and R_AARCH64_ABS32 against absolution symbol or undefine symbol in shared object.

The assumption that R_AARCH64_ABS16 and R_AARCH64_ABS32 relocation in LP64 abi
will be used to generate an address does not hold for absolute symbol.
In this case, it is a value fixed at static linking time.

The condition to check the relocations is relax to allow absolute symbol and
undefined symbol case.

bfd/

2018-02-05  Renlin Li  <renlin.li@arm.com>

	PR ld/22764
	* elfnn-aarch64.c (elfNN_aarch64_check_relocs): Relax the
	R_AARCH64_ABS32 and R_AARCH64_ABS16 for absolute symbol. Apply the
	check for writeable section as well.

ld/

2018-02-05  Renlin Li  <renlin.li@arm.com>

	PR ld/22764
	* testsuite/ld-aarch64/emit-relocs-258.s: Define symbol as an address.
	* testsuite/ld-aarch64/emit-relocs-259.s: Likewise.
	* testsuite/ld-aarch64/aarch64-elf.exp: Run new test.
	* testsuite/ld-aarch64/pr22764.s: New.
	* testsuite/ld-aarch64/pr22764.d: New.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] ppc64: Fix stwux encoding
@ 2018-02-05 19:45 sergiodj+buildbot
  2018-02-06  7:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-05 19:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 72dd27306224497c8ba97f391d30b774d4d973fb ***

Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Branch: master
Commit: 72dd27306224497c8ba97f391d30b774d4d973fb

ppc64: Fix stwux encoding

With gcc-8.0.1-0.9.fc28.x86_64 I get:

../../gdb/rs6000-tdep.c: In function 'CORE_ADDR skip_prologue(gdbarch*, CORE_ADDR, CORE_ADDR, rs6000_framedata*)':
../../gdb/rs6000-tdep.c:1911:34: error: bitwise comparison always evaluates to false [-Werror=tautological-compare]
       else if ((op & 0xfc1f016a) == 0x7c01016e)
                ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~

https://www.ibm.com/support/knowledgecenter/en/ssw_aix_72/com.ibm.aix.alangref/idalangref_stwux_stux_instrs.htm
says
	bit 21 - 30 = 183
	Those are bits 1..10 in normal bit order: 183<<1 = 0x16e

gdb/ChangeLog
2018-02-04  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* rs6000-tdep.c (skip_prologue): Fix stwux encoding.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Allow the find_abstract_instance_name() function in the BFD library to also return file and line number information.
@ 2018-02-06 16:04 sergiodj+buildbot
  2018-02-06 16:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-06 16:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 422f3d3d6d5713bf9235b7b7696818a70b3b578d ***

Author: Paul Carroll <pcarroll@codesourcery.com>
Branch: master
Commit: 422f3d3d6d5713bf9235b7b7696818a70b3b578d

Allow the find_abstract_instance_name() function in the BFD library to also return file and line number information.

The nm utility supports -l for using debug information to obtain file and line information for each symbol, if available.
We have a tool that consumes this information and displays it.
This identified a problem with the 'nm' utility.

When a source is compiled with -O2, functions can be inlined.  The compiler also produces an uninlined copy of the function, normally for linking to other object files.
In the case of DWARF2 debug information, the compiler generates debug information to describe a function.  If that function is inlined, the compiler then references that debug information from the inlined and uninlined copies of the routine through the use of the DW_AT_abstract_origin reference.
When nm is used on such a file, it is not able to find file and line information because that information is present in the common debug information and not at each actual implementation of the function.
The 'nm' utility only retrieves the name of the function from the abstract origin debug information and no more.

What I am proposing is to modify the find_abstract_instance_name() function (which I renamed to find_abstract_instance() ) to return the name of the function as well as any file and line information.  The routine is already parsing all of the debug information in the abstract instance, so it is easy to pick up the file and line information at that time. If, for some reason, the file and line information is not present, the routine behaves as before.

For example, if I have a simple test case:

int foo(int j)
{
        if (j < 15)
                j += j << 2;
        else
                j += j << 6;
        return j;
}

int main (int argc,char **argv)
{
        int i = argc;
        i += foo(i);
        return i;
}

If that test case is compiled with -O2 and then 'nm -l' reads that executable, it currently produces this symbol output (ignoring a lot of library symbols):

8048400 T foo
080482e0 T main /scratch/pcarroll/its254/test/mytest.c:12

If I modify 'nm' to return file and line information for abstract instances, it produces the following output:

08048400 T foo  /scratch/pcarroll/its254/test/mytest.c:1
080482e0 T main /scratch/pcarroll/its254/test/mytest.c:12
--------------------------------------------------------------------------
bfd	* bfd/dwarf2.c (find_abstract_name): Modified to return file and
	line information in addition to name, if they can be found.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Prevent attempts to call strncpy with a zero-length field by chacking the size of debuglink sections.
@ 2018-02-06 16:48 sergiodj+buildbot
  2018-02-06 19:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-06 16:48 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 64e234d417d5685a4aec0edc618114d9991c031b ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 64e234d417d5685a4aec0edc618114d9991c031b

Prevent attempts to call strncpy with a zero-length field by chacking the size of debuglink sections.

	PR 22794
	* opncls.c (bfd_get_debug_link_info_1): Check the size of the
	section before attempting to read it in.
	(bfd_get_alt_debug_link_info): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix GCC 8's -Wstringop-overflow on bfd/coff-rs6000.c
@ 2018-02-06 17:02 sergiodj+buildbot
  2018-02-06 21:48 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-06 17:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8278e7cec35536046caf596f4e55c7c037d06cf0 ***

Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: 8278e7cec35536046caf596f4e55c7c037d06cf0

Fix GCC 8's -Wstringop-overflow on bfd/coff-rs6000.c

GCC 8 will bring a new warning option which will detect possible
overflow and truncation on string manipulation functions.  For more
details, see:

  https://gcc.gnu.org/ml/gcc-patches/2017-08/msg00471.html

While compiling BFD with it, I can see one place on bfd/coff-rs6000.c
where the warning is triggered.  This:

  (void) strncpy (fhdr.magic, XCOFFARMAG, SXCOFFARMAG);

will not include the trailing NUL on fhdr.magic, but that's fine
because it's a magic number.  The fix is trivial: just use memcpy
instead.

OK to push?

2018-02-06  Sergio Durigan Junior  <sergiodj@redhat.com>

	* coff-rs6000.c (xcoff_write_archive_contents_old): Use
	'memcpy' instead of 'strncpy' when writing the magic number.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Improve the find_nearest_line function for the MIPS target so that it tries harder to find a function name.
@ 2018-02-06 17:17 sergiodj+buildbot
  2018-02-06 23:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-06 17:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 46d09186d340407fdcf066fea25444682e989512 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 46d09186d340407fdcf066fea25444682e989512

Improve the find_nearest_line function for the MIPS target so that it tries harder to find a function name.

	PR 22789
	* elfxx-mips.c (_bfd_mips_elf_find_nearest_line): If the dwarf
	functions failed to find the function name, try the generic elf
	find function instead.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Treat OP_F77_UNDETERMINED_ARGLIST as OP_FUNCALL
@ 2018-02-06 17:29 sergiodj+buildbot
  2018-02-07  1:49 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-06 17:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bca65a2394ce11bb4a0b001b8a986961c2e84881 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: bca65a2394ce11bb4a0b001b8a986961c2e84881

Treat OP_F77_UNDETERMINED_ARGLIST as OP_FUNCALL

When I debug some fortran expression parsing, I got

(gdb) set debug expression 1
(gdb) p intvla(5,5,5)
Dump of expression @ 0x205fa80, before conversion to prefix form:
	Language fortran, 19 elements, 16 bytes each.
	Index                Opcode         Hex Value  String Value
	    0          OP_VAR_VALUE  40  (...............
	    1    <unknown 31863232>  31863232  .1..............
....
	   14             BINOP_REM  5  ................
	   15               OP_LONG  38  &...............
	   16  OP_F77_UNDETERMINED_ARGLIST  48  0...............
	   17             BINOP_MUL  3  ................
	   18  OP_F77_UNDETERMINED_ARGLIST  48  0...............
Dump of expression @ 0x205fa80, after conversion to prefix form:
Expression: `Invalid expression
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

This patch fixes this problem by handling OP_F77_UNDETERMINED_ARGLIST in
the same way as handling OP_FUNCALL.  With this patch applied, the output
looks better,

(gdb) p intvla (5,5,5)
Dump of expression @ 0x2d75590, before conversion to prefix form:
	Language fortran, 19 elements, 16 bytes each.
	Index                Opcode         Hex Value  String Value
	    0          OP_VAR_VALUE  40  (...............
....
	   16  OP_F77_UNDETERMINED_ARGLIST  48  0...............
	   17             BINOP_MUL  3  ................
	   18  OP_F77_UNDETERMINED_ARGLIST  48  0...............
Dump of expression @ 0x2d75590, after conversion to prefix form:
Expression: `vla_primitives::intvla (5, 5, 5)'
	Language fortran, 19 elements, 16 bytes each.

	    0  OP_F77_UNDETERMINED_ARGLIST  Number of args: 3
	    3    OP_VAR_VALUE          Block @0x297e1c0, symbol @0x297cd50 (intvla)
	    7    OP_LONG               Type @0x2976900 (int), value 5 (0x5)
	   11    OP_LONG               Type @0x2976900 (int), value 5 (0x5)
	   15    OP_LONG               Type @0x2976900 (int), value 5 (0x5)

gdb:

2018-02-06  Yao Qi  <yao.qi@linaro.org>

	* expprint.c (print_subexp_standard): Handle
	OP_F77_UNDETERMINED_ARGLIST.
	(dump_subexp_body_standard): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix PR ld/22263 on SPARC.
@ 2018-02-06 17:43 sergiodj+buildbot
  2018-02-07  4:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-06 17:43 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c20c30f615756ddfccc4bb75c65ccfc1a399466e ***

Author: Eric Botcazou <ebotcazou@gcc.gnu.org>
Branch: master
Commit: c20c30f615756ddfccc4bb75c65ccfc1a399466e

Fix PR ld/22263 on SPARC.

This is -fpie -pie generating dynamic relocations in the text section,
simply because no TLS transitions are applied in PIE mode.  The meat
of the patch is to turn calls to bfd_link_pic (info) in TLS-related code
into !bfd_link_executable (info) and there are quite a lot of them...

bfd/
	* elfxx-sparc.c (sparc_elf_tls_transition): Turn call to bfd_link_pic
	into call to !bfd_link_executable and tidy up.
	(_bfd_sparc_elf_check_relocs): Fix formatting and tidy up.
	<R_SPARC_TLS_LE_HIX22>: Turn call to bfd_link_pic into call to
	!bfd_link_executable.
	<R_SPARC_TLS_IE_HI22>: Likewise.
	<GOT relocations>: Remove useless code, tidy and merge blocks.
	<R_SPARC_TLS_GD_CALL>: Turn call to bfd_link_pic into call to
	!bfd_link_executable.
	<R_SPARC_WPLT30>: Tidy up.
	(_bfd_sparc_elf_gc_mark_hook): Turn call to bfd_link_pic into call
	to !bfd_link_executable.
	(allocate_dynrelocs): Likewise.
	(_bfd_sparc_elf_relocate_section): Fix formatting and tidy up.
	<R_SPARC_TLS_GD_HI22>: Merge into...
	<R_SPARC_TLS_GD_LO10>: ...this.  Adjust 4th argument in call to
	sparc_elf_tls_transition and remove redundant code.
	<R_SPARC_TLS_LDM_HI22>: Turn call to bfd_link_pic into call to
	!bfd_link_executable.
	<R_SPARC_TLS_LDO_HIX22>: Likewise.
	<R_SPARC_TLS_LE_HIX22>: Likewise.  Tidy up.
	<R_SPARC_TLS_LDM_CALL>: Likewise.
	<R_SPARC_TLS_GD_CALL>: Likewise.  Tidy up.
	<R_SPARC_TLS_GD_ADD>: Likewise.
	<R_SPARC_TLS_LDM_ADD>: Likewise.
	<R_SPARC_TLS_LDO_ADD>: Likewise.
	<R_SPARC_TLS_IE_LD>: Likewise.
ld/
	* testsuite/ld-elf/tls.exp (AFLAGS_PIC): Define on SPARC.
	(pr22263-1): Pass AFLAGS_PIC to the assembler.
	* testsuite/ld-sparc/tlspie32.s: Add test for other 3 transitions.
	* testsuite/ld-sparc/tlspie32.dd: Adjust to above.
	* testsuite/ld-sparc/tlspie64.s: Add test for other 3 transitions.
	* testsuite/ld-sparc/tlspie64.dd: Adjust to above.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove some $ARCH_read_pc and $ARCH_write_pc
@ 2018-02-06 20:29 sergiodj+buildbot
  2018-02-07  5:54 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-06 20:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3f8c94b478c8f2e5c82a1425fd49e977ed969a7f ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 3f8c94b478c8f2e5c82a1425fd49e977ed969a7f

Remove some $ARCH_read_pc and $ARCH_write_pc

Nowadays, gdbarch_read_pc is called in this way,

  if (gdbarch_read_pc_p (gdbarch))
    pc_val = gdbarch_read_pc (gdbarch, regcache);
  /* Else use per-frame method on get_current_frame.  */
  else if (gdbarch_pc_regnum (gdbarch) >= 0)
    {
      ULONGEST raw_val;

      if (regcache_cooked_read_unsigned (regcache,
					 gdbarch_pc_regnum (gdbarch),
					 &raw_val) == REG_UNAVAILABLE)

some ports don't have to define its own gdbarch read_pc method if the
pc value is simply a unsigned value from "pc" register.  The same rule
applies to regcache_write_pc.  This patch removes these $ARCH_read_pc
and $ARCH_write_pc functions.

gdb:

2018-02-06  Yao Qi  <yao.qi@linaro.org>

	* ft32-tdep.c (ft32_read_pc): Remove.
	(ft32_write_pc): Remove.
	(ft32_gdbarch_init): Update.
	* m32r-tdep.c (m32r_read_pc): Remove.
	(m32r_gdbarch_init): Update.
	* mep-tdep.c (mep_read_pc): Remove.
	(mep_gdbarch_init): Update.
	* microblaze-tdep.c (microblaze_write_pc): Remove.
	(microblaze_gdbarch_init): Update.
	* mn10300-tdep.c (mn10300_read_pc): Remove.
	(mn10300_write_pc): Remove.
	(mn10300_gdbarch_init): Update.
	* moxie-tdep.c (moxie_read_pc): Remove.
	(moxie_write_pc): Remove.
	(moxie_gdbarch_init): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] RISC-V: Eliminate spurious error w/ reloc truncated message
@ 2018-02-07  1:08 sergiodj+buildbot
  2018-02-07  8:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-07  1:08 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ed01220cc81fac2f65abde945d9b77b11d004361 ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: ed01220cc81fac2f65abde945d9b77b11d004361

RISC-V: Eliminate spurious error w/ reloc truncated message

	bfd/
	* elfnn-riscv.c (riscv_elf_relocate_section): Return TRUE if used
	callback to report an error.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Revert "PowerPC PLT speculative execution barriers"
@ 2018-02-07  4:11 sergiodj+buildbot
  2018-02-07 10:38 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-07  4:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 407aa07cee4d075c8e7996a5e994c02e76f19276 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 407aa07cee4d075c8e7996a5e994c02e76f19276

Revert "PowerPC PLT speculative execution barriers"

This reverts most of commit 1be5d8d3bb.
Left in place are addition of --no-plt-align to some ppc32 ld tests
and the ld.texinfo --no-plt-thread-safe fix.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix type of values representing optimized out static members
@ 2018-02-07 14:04 sergiodj+buildbot
  2018-02-07 14:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-07 14:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c2e0e465f9488970c7e460a41e3fb7c366530619 ***

Author: Simon Marchi <simark@simark.ca>
Branch: master
Commit: c2e0e465f9488970c7e460a41e3fb7c366530619

Fix type of values representing optimized out static members

As reported here:

  https://sourceware.org/ml/gdb/2018-02/msg00019.html

the type of values representing static members that are optimized out is
wrong.  It currently assigns the type of the containing class rather
than the type of the field.  This patch fixes that.

I found a place in m-static.exp already dealing with optimized out
static members, so I just added some gdb_test there.

gdb/ChangeLog:

	* value.c (value_static_field): Assign field type instead of
	containing type when returning an optimized out value.

gdb/testsuite/ChangeLog:

	* gdb.cp/m-static.exp: Check type of optimized out static
	member.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix a seg-fault in the ELF note parser when a note with an excessively large alignment is encountered.
@ 2018-02-08 10:45 sergiodj+buildbot
  2018-02-08 11:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-08 10:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ef135d4314fd4c2d7da66b9d7b59af4a85b0f7e6 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: ef135d4314fd4c2d7da66b9d7b59af4a85b0f7e6

Fix a seg-fault in the ELF note parser when a note with an excessively large alignment is encountered.

	PR 22788
	* elf.c (elf_parse_notes): Reject notes with excessuively large
	alignments.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove a cleanup from gdbserver
@ 2018-02-08 19:05 sergiodj+buildbot
  2018-02-08 19:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-08 19:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 45dd3607e24aaf515b5d75c666b351575410392b ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 45dd3607e24aaf515b5d75c666b351575410392b

Remove a cleanup from gdbserver

This removes a cleanup from gdbserver's set_raw_breakpoint_at,
replacing it with unique_xmalloc_ptr.

2018-02-08  Tom Tromey  <tom@tromey.com>

	* mem-break.c (set_raw_breakpoint_at): Use
	gdb::unique_xmalloc_ptr.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove make_cleanup_restore_current_thread from gdbserver
@ 2018-02-08 19:18 sergiodj+buildbot
  2018-02-08 21:36 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-08 19:18 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8ce47547b34fddec16d1ccd801f025a56976af95 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 8ce47547b34fddec16d1ccd801f025a56976af95

Remove make_cleanup_restore_current_thread from gdbserver

This removes make_cleanup_restore_current_thread from gdbserver,
replacing it with a use of scoped_restore.

2018-02-08  Tom Tromey  <tom@tromey.com>

	* linux-low.c (install_software_single_step_breakpoints): Use
	make_scoped_restore.
	* inferiors.c (make_cleanup_restore_current_thread): Remove.
	(do_restore_current_thread_cleanup): Remove.
	* gdbthread.h (make_cleanup_restore_current_thread): Don't
	declare.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Return unique_xmalloc_ptr from macro scope functions
@ 2018-02-08 19:32 sergiodj+buildbot
  2018-02-09  0:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-08 19:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f6c2623eb8ac7296b6d7a76657394272a71f5aee ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: f6c2623eb8ac7296b6d7a76657394272a71f5aee

Return unique_xmalloc_ptr from macro scope functions

This changes the macro scope functions (sal_macro_scope,
user_macro_scope, and default_macro_scope) to return a
unique_xmalloc_ptr, then fixes up the users.  This allowed for the
removal of several cleanups.

2018-02-08  Tom Tromey  <tom@tromey.com>

	* symtab.c (default_collect_symbol_completion_matches_break_on):
	Use unique_xmalloc_ptr.
	* macroscope.h: (sal_macro_scope, user_macro_scope)
	(default_macro_scope): Return unique_xmalloc_ptr.
	* macroscope.c (sal_macro_scope, user_macro_scope)
	(default_macro_scope): Return unique_xmalloc_ptr.
	* macroexp.h (macro_expand, macro_expand_once): Return
	unique_xmalloc_ptr.
	* macroexp.c (macro_expand, macro_expand_once): Return
	unique_xmalloc_ptr.
	* macrocmd.c (macro_expand_command, macro_expand_once_command)
	(info_macro_command, info_macros_command): Use
	unique_xmalloc_ptr.
	* compile/compile-c-support.c (write_macro_definitions): Use
	unique_xmalloc_ptr.
	* c-exp.y (c_parse): Use unique_xmalloc_ptr.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove cleanups from macro_define_command
@ 2018-02-08 20:13 sergiodj+buildbot
  2018-02-09  5:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-08 20:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 84f27c6fcbbf580434c7d56e68fa42fe7cf7ccb9 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 84f27c6fcbbf580434c7d56e68fa42fe7cf7ccb9

Remove cleanups from macro_define_command

This removes cleanups from macro_define_command, by introducing a new
struct temporary_macro_definition that cleans up after itself.

2018-02-08  Tom Tromey  <tom@tromey.com>

	* macrocmd.c (struct temporary_macro_definition): New.
	(macro_define_command): Use temporary_macro_definition.  Remove
	cleanups.
	(free_macro_definition_ptr): Remove.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use gdb::def_vector in find_source_lines
@ 2018-02-08 20:25 sergiodj+buildbot
  2018-02-09  7:29 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-08 20:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a9abc4345150a3f3e30da78f8d68c1f9e0198772 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: a9abc4345150a3f3e30da78f8d68c1f9e0198772

Use gdb::def_vector in find_source_lines

This replaces an explicit malloc and a cleanup with a gdb::def_vector.

2018-02-08  Tom Tromey  <tom@tromey.com>

	* source.c (find_source_lines): Use gdb::def_vector.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Class-ify macro_buffer
@ 2018-02-08 20:47 sergiodj+buildbot
  2018-02-09  1:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-08 20:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1739cf248ff21b21271d1e9d5f77a12589c3856c ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 1739cf248ff21b21271d1e9d5f77a12589c3856c

Class-ify macro_buffer

This patch changes macro_buffer to be a bit more of a C++ class,
adding constructors, a destructor, and some members.  Then this is
used to remove various cleanups in macroexp.c.

2018-02-08  Tom Tromey  <tom@tromey.com>

	* macroexp.c (struct macro_buffer): Add initializers for some
	members.
	(init_buffer, init_shared_buffer, free_buffer)
	(free_buffer_return_text): Remove.
	(macro_buffer): New constructors.
	(~macro_buffer): New destructor.
	(macro_buffer::set_shared): New method.
	(macro_buffer::resize_buffer, macro_buffer::appendc)
	(macro_buffer::appendmem): Now methods, not free functions.
	(set_token, append_tokens_without_splicing, stringify)
	(macro_stringify): Update.
	(gather_arguments): Change return type.  Remove argc_p argument,
	add args_ptr argument.  Use std::vector.
	(substitute_args): Remove argc argument.  Accept std::vector.
	(expand): Update.  Use std::vector.
	(scan, macro_expand, macro_expand_next): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] RISC-V: Add comment for previous change.
@ 2018-02-08 21:32 sergiodj+buildbot
  2018-02-09 13:35 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-08 21:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3f48fe4a95ec0e67b81d5d606762c91ad9a6b799 ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 3f48fe4a95ec0e67b81d5d606762c91ad9a6b799

RISC-V: Add comment for previous change.

	bfd/
	* elfnn-riscv.c (riscv_elf_relocate_section): Add comment for previous
	change.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use std::string in maybe_expand
@ 2018-02-08 22:04 sergiodj+buildbot
  2018-02-09  3:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-08 22:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0354904bdacb9bf1ebdf3ebdf3723f8a550bcdab ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 0354904bdacb9bf1ebdf3ebdf3723f8a550bcdab

Use std::string in maybe_expand

This patch changes maybe_expand to use std::string rather than an
explicit malloc and a cleanup.

2018-02-08  Tom Tromey  <tom@tromey.com>

	* macroexp.c (maybe_expand): Use std::string.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove cleanups from solib.c
@ 2018-02-08 23:17 sergiodj+buildbot
  2018-02-09 11:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-08 23:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9a897d43f034544cd09292d0fb6fded7eb64ae8d ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 9a897d43f034544cd09292d0fb6fded7eb64ae8d

Remove cleanups from solib.c

This removes a couple of cleanups from solib.c, replacing one with
std::string and another with unique_xmalloc_ptr.

2018-02-08  Tom Tromey  <tom@tromey.com>

	* solib.c (solib_find_1): Use std::string.
	(solib_bfd_fopen): Use unique_xmalloc_ptr.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use unique_xmalloc_ptr in build_id_to_debug_bfd
@ 2018-02-09  0:11 sergiodj+buildbot
  2018-02-09  9:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-09  0:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 58ef3771fbbdf7fd891fceefdd4bf2720c6c1ee7 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 58ef3771fbbdf7fd891fceefdd4bf2720c6c1ee7

Use unique_xmalloc_ptr in build_id_to_debug_bfd

This changes build_id_to_debug_bfd to use a unique_xmalloc_ptr,
removing a cleanup.

2018-02-08  Tom Tromey  <tom@tromey.com>

	* build-id.c (build_id_to_debug_bfd): Use unique_xmalloc_ptr.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: Keep the unused _GLOBAL_OFFSET_TABLE_ for Solaris
@ 2018-02-09  0:47 sergiodj+buildbot
  2018-02-09 15:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-09  0:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT dc11dea21281758b71113c03a8d8be92d175a46c ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: dc11dea21281758b71113c03a8d8be92d175a46c

x86: Keep the unused _GLOBAL_OFFSET_TABLE_ for Solaris

Solaris requires to keep _GLOBAL_OFFSET_TABLE_ even if it isn't used.
This patch detects Solaris target and keeps _GLOBAL_OFFSET_TABLE_ for
Solaris.

	* elf32-i386.c (elf32_i386_copy_solaris_special_section_fields):
	New prototype.
	(elf_i386_link_setup_gnu_properties): Set need_global_offset_table
	for Solaris.
	* elf64-x86-64.c (elf64_x86_64_copy_solaris_special_section_fields):
	New prototype.
	(elf_x86_64_link_setup_gnu_properties): Set
	need_global_offset_table for Solaris.
	* elfxx-x86.c (_bfd_x86_elf_size_dynamic_sections): Keep the
	unused _GLOBAL_OFFSET_TABLE_ for Solaris.
	(_bfd_x86_elf_link_setup_gnu_properties): Copy
	need_global_offset_table.
	* elfxx-x86.h (elf_x86_link_hash_table): Add
	need_global_offset_table.
	(elf_x86_init_table): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: Set need_global_offset_table with info->output_bfd->xvec
@ 2018-02-09  1:04 sergiodj+buildbot
  2018-02-09 17:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-09  1:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 15b23f3612ffa19bd7fb20ce07485cdb3c06162f ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 15b23f3612ffa19bd7fb20ce07485cdb3c06162f

x86: Set need_global_offset_table with info->output_bfd->xvec

	* elf32-i386.c (elf32_i386_copy_solaris_special_section_fields):
	Remove prototype.
	(i386_elf32_sol2_vec): Declared.
	(elf_i386_link_setup_gnu_properties): Set
	need_global_offset_table with info->output_bfd->xvec.
	* elf64-x86-64.c (elf64_x86_64_copy_solaris_special_section_fields):
	Remove prototype.
	(x86_64_elf64_sol2_vec): Declared.
	(elf_x86_64_link_setup_gnu_properties): Set
	need_global_offset_table with info->output_bfd->xvec.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb/NEWS: Clarify the news entry for "rbreak" in GDB 8.1
@ 2018-02-09 12:24 sergiodj+buildbot
  2018-02-09 19:28 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-09 12:24 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4e7253479941cd6d59a0c8efbb1113d3734b7f56 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 4e7253479941cd6d59a0c8efbb1113d3734b7f56

gdb/NEWS: Clarify the news entry for "rbreak" in GDB 8.1

gdb/ChangeLog:

        * NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
        Python function, rather than a new command.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use std::string in execute_script_contents
@ 2018-02-09 13:19 sergiodj+buildbot
  2018-02-10  0:02 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-09 13:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a37a2ae7080898244de86d136961de81fe28a434 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: a37a2ae7080898244de86d136961de81fe28a434

Use std::string in execute_script_contents

This changes execute_script_contents to use a std::string, allowing
the removal of a cleanup.

2018-02-09  Tom Tromey  <tom@tromey.com>

	* auto-load.c (execute_script_contents): Use std::string.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use gdb::unique_xmalloc_ptr in auto_load_section_scripts
@ 2018-02-09 13:31 sergiodj+buildbot
  2018-02-10  3:59 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-09 13:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 869e8290ea62f594d2472476303bb74604e9326b ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 869e8290ea62f594d2472476303bb74604e9326b

Use gdb::unique_xmalloc_ptr in auto_load_section_scripts

This changes auto_load_section_scripts to use gdb::unique_xmalloc_ptr,
allowing the removal of a cleanup.

2018-02-09  Tom Tromey  <tom@tromey.com>

	* auto-load.c (auto_load_section_scripts): Use
	gdb::unique_xmalloc_ptr.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] common: add scoped_fd
@ 2018-02-09 13:44 sergiodj+buildbot
  2018-02-10  5:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-09 13:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ea4a0888120dec61348cae460ffa08de663e2852 ***

Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: ea4a0888120dec61348cae460ffa08de663e2852

common: add scoped_fd

Add a simple helper to automatically close a file descriptor.

gdb/
	* common/scoped_fd.h: New.
	* unittests/scoped_fd-selftest.c: New.
	* Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
	unittests/scoped_fd-selftest.c.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] btrace: prepare for throwing exceptions when enabling btrace
@ 2018-02-09 14:22 sergiodj+buildbot
  2018-02-10 10:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-09 14:22 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5c3284c1ec2edc28b0697532fd094d93d5ecf31b ***

Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: 5c3284c1ec2edc28b0697532fd094d93d5ecf31b

btrace: prepare for throwing exceptions when enabling btrace

We indicate success or failure for enabling branch tracing via the pointer
return value.  Depending on the type of error, errno may provide additional
information.

Prepare for using exceptions with more descriptive error messages by using smart
pointers and objects with automatic destruction to hold intermediate results.

gdb/
	* nat/linux-btrace.c: Include scoped_fd.h and scoped_mmap.h.
	(perf_event_pt_event_type): Use gdb_file_up.
	(linux_enable_bts, linux_enable_pt): Use gdb::unique_xmalloc_ptr,
	scoped_fd, and scoped_mmap.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] btrace, gdbserver: remove the to_supports_btrace target method
@ 2018-02-09 14:47 sergiodj+buildbot
  2018-02-10 15:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-09 14:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT de6242d3075700ec4b73bdee583dc216f3a0b046 ***

Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: de6242d3075700ec4b73bdee583dc216f3a0b046

btrace, gdbserver: remove the to_supports_btrace target method

Remove the to_supports_btrace target method and instead rely on detecting errors
when trying to enable recording.  This will also provide a suitable error
message explaining why recording is not possible.

For remote debugging, gdbserver will now always advertise branch tracing related
packets.  When talking to an older GDB, this will cause GDB to try to enable
branch tracing and gdbserver to report a suitable error message every time.

An older gdbserver will not advertise branch tracing related packets if the
one-time check failed, so a newer GDB with this patch will fail to enable branch
tracing at remote_enable_btrace() rather than at btrace_enable().  The error
message is the same in both cases so there should be no user-visible change.

gdb/
	* btrace.c (btrace_enable): Remove target_supports_btrace call.
	* nat/linux-btrace.c (perf_event_pt_event_type): Move.
	(kernel_supports_bts, kernel_supports_pt, linux_supports_bts)
	(linux_supports_pt, linux_supports_btrace): Remove.
	(linux_enable_bts): Call cpu_supports_bts.
	* nat/linux-btrace.h (linux_supports_btrace): Remove.
	* remote.c (remote_supports_btrace): Remove.
	(init_remote_ops): Remove remote_supports_btrace.
	* target-delegates.c: Regenerated.
	* target.c (target_supports_btrace): Remove.
	* target.h (target_ops) <to_supports_btrace>: Remove
	(target_supports_btrace): Remove.
	* x86-linux-nat.c (x86_linux_create_target): Remove
	linux_supports_btrace.

gdbserver/
	* linux-low.c (linux_target_ops): Remove linux_supports_btrace.
	* nto-low.c (nto_target_ops): Remove NULL for supports_btrace.
	* spu-low.c (spu_target_ops): Likewise.
	* win32-low.c (win32_target_ops): Likewise.
	* server.c (supported_btrace_packets): Report packets unconditionally.
	* target.h (target_ops) <supports_btrace>: Remove.
	(target_supports_btrace): Remove.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] btrace: improve enable error messages
@ 2018-02-09 15:00 sergiodj+buildbot
  2018-02-10 17:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-09 15:00 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 17ad2a4f466f22b7a75b5ebf8a68446bb328c40c ***

Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: 17ad2a4f466f22b7a75b5ebf8a68446bb328c40c

btrace: improve enable error messages

Improve the error message when GDB fails to start recording branch trace.

This patch also removes a zero buffer size check for PT to align with BTS.  The
buffer size can not be configured to be zero.

gdb/
	* nat/linux-btrace.c (perf_event_pt_event_type): Improve error message.
	Remove parameter and change return type.  Update callers.  Move it.
	(linux_enable_bts, linux_enable_pt): Improve error message.
	(linux_enable_pt): Remove zero buffer size check.
	(linux_enable_btrace): Improve error messages.  Remove NULL return
	check.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] btrace: check perf_event_paranoid
@ 2018-02-09 15:12 sergiodj+buildbot
  2018-02-10 20:44 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-09 15:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 88711fbfeadd6e4663d986962dfcd7ab660c61d1 ***

Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: 88711fbfeadd6e4663d986962dfcd7ab660c61d1

btrace: check perf_event_paranoid

One recurring error on Debian systems is that the default perf_event_paranoid
setting disables the perf_event interface for user-space.

Check the current level and point the user to the file.

gdb/
	* nat/linux-btrace.c (diagnose_perf_event_open_fail): New.
	(linux_enable_pt, linux_enable_bts): Call
	diagnose_perf_event_open_fail.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] btrace: reword error messages
@ 2018-02-09 15:25 sergiodj+buildbot
  2018-02-10 22:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-09 15:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c4e126313219ecde255a644a2c74008831edff5a ***

Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: c4e126313219ecde255a644a2c74008831edff5a

btrace: reword error messages

Reword some btrace error messages to align with the format discussed in
https://sourceware.org/ml/gdb-patches/2018-02/msg00135.html.

gdb/
	* remote.c (remote_btrace_maybe_reopen): Change error message.
	* btrace.c (btrace_enable): Likewise.
	(parse_xml_btrace): Likewise.
	(parse_xml_btrace_conf): Likewise.

testsuite/
	* lib/gdb.exp (skip_btrace_pt_tests): Update expected error message.
	Fix test name.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] common: add scoped_mmap
@ 2018-02-09 15:52 sergiodj+buildbot
  2018-02-10  7:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-09 15:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 84696f37ae92280ded0e6600074ad8bc518255fa ***

Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: 84696f37ae92280ded0e6600074ad8bc518255fa

common: add scoped_mmap

Add a simple helper to automatically unmap a memory mapping.

gdb/
	* common/scoped_mmap.h: New.
	* unittests/scoped_mmap-selftest.c: New.
	* Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
	unittests/scoped_mmap-selftest.c.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] btrace, gdbserver: use exceptions to convey btrace enable/disable errors
@ 2018-02-09 16:32 sergiodj+buildbot
  2018-02-10 12:38 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-09 16:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9ee23a853c18da3c83530c7957464bc6b6e9fb16 ***

Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: 9ee23a853c18da3c83530c7957464bc6b6e9fb16

btrace, gdbserver: use exceptions to convey btrace enable/disable errors

Change error reporting to use exceptions and be prepared to catch them in
gdbserver.  We use the exception message in our error reply to GDB.

This may remove some detail from the error message in the native case since
errno is no longer printed.  Later patches will improve that.

We're still using error strings on the RSP level.  This patch does not affect
the interoperability of older/newer GDB/gdbserver.

gdbserver/
	* server.c (handle_btrace_enable_bts, handle_btrace_enable_pt)
	(handle_btrace_disable): Change return type to void.  Use exceptions
	to report errors.
	(handle_btrace_general_set): Catch exception and copy message to
	return message.

gdb/
	* nat/linux-btrace.c (linux_enable_btrace): Throw exception if enabling
	btrace failed.
	* x86-linux-nat.c (x86_linux_enable_btrace): Catch btrace enabling
	exception and use message in own exception.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: Add is_solaris to elf_x86_target_os
@ 2018-02-09 17:02 sergiodj+buildbot
  2018-02-11  2:34 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-09 17:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3b4c384407ebbdd9ed4ad5057080b3be038b8748 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 3b4c384407ebbdd9ed4ad5057080b3be038b8748

x86: Add is_solaris to elf_x86_target_os

Add is_solaris to elf_x86_target_os since Solaris is quite different.

	* elf32-i386.c (elf_i386_get_synthetic_symtab): Also handle
	is_solaris.
	(i386_elf32_sol2_vec): Don't declare.
	(elf_i386_link_setup_gnu_properties): Also handle is_solaris.
	Don't set need_global_offset_table.
	(elf_i386_solaris_arch_bed): New.
	(elf_backend_arch_data): Set to elf_i386_solaris_arch_bed for
	Solaris.
	* elf64-x86-64.c (elf_x86_64_get_synthetic_symtab): Check
	target_os != is_nacl instead of target_os == is_normal.
	(x86_64_elf64_sol2_vec): Don't declare.
	(elf_x86_64_link_setup_gnu_properties): Check target_os !=
	is_nacl instead of target_os == is_normal.  Don't set
	need_global_offset_table.
	(elf_x86_64_solaris_arch_bed): New.
	(elf_backend_arch_data): Set to elf_x86_64_solaris_arch_bed for
	Solaris.
	* elfxx-x86.c (_bfd_x86_elf_size_dynamic_sections): Keep
	_GLOBAL_OFFSET_TABLE_ for Solaris.
	(_bfd_x86_elf_link_setup_gnu_properties): Don't copy
	need_global_offset_table.
	* elfxx-x86.h (elf_x86_target_os): Add is_solaris.
	(elf_x86_link_hash_table): Remove need_global_offset_table.
	(elf_x86_init_table): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Don't reference past the end of the vector
@ 2018-02-09 19:26 sergiodj+buildbot
  2018-02-11  0:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-09 19:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9c3630e983df43e68006b526a92c2a9a2b64dfd9 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 9c3630e983df43e68006b526a92c2a9a2b64dfd9

Don't reference past the end of the vector

An earlier change made find_source_lines read:

    end = &data[size];

However, since 'size' is the size of the vector, this seems fishy.
More obviously ok is to compute the end of the data directly:

    end = data.data () + size;

2018-02-09  Tom Tromey  <tom@tromey.com>

	* source.c (find_source_lines): Don't reference past the end of
	the vector.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix GOT relocation overflow on SPARC.
@ 2018-02-10  2:13 sergiodj+buildbot
  2018-02-11  4:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-10  2:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a8735c82b8519d8b18915765ca983fc07154a17d ***

Author: Eric Botcazou <ebotcazou@gcc.gnu.org>
Branch: master
Commit: a8735c82b8519d8b18915765ca983fc07154a17d

Fix GOT relocation overflow on SPARC.

There are 2 failures left in the linker testsuite on SPARC64/Linux and
they are caused by 2 different issues leading to the same end effect:
the overflow of the relocation section for the GOT, i.e. the linker
generates too many dynamic relocations for the GOT wrt the size of the
relocation section, leading to memory corruption and missing relocations
in the final binary.

The first issue was introduced by:
  https://sourceware.org/ml/binutils/2017-06/msg00368.html
which makes the linker generate more R_SPARC_RELATIVE relocations for
the GOT without adjusting the size of the relocation section.  This is
fixed by (1) preventively adjusting this size in allocate_dynrelocs and
(2) generating R_SPARC_NONE if needed when R_SPARC_GOTDATA_OP is relaxed.

The second issue is that we generate a GOT relocation for an undefined
weak symbol with non-default visibility in a PIC binary without accounting
for that  in the size of the relocation section.  Since the address of the
symbol should resolve to 0 at run time, it is fixed by not generating the
relocation at all, i.e. leaving the GOT entry zeroed.

bfd/
	* elfxx-sparc.c (UNDEFINED_WEAK_RESOLVED_TO_ZERO): Reorder conditions.
	(sparc_elf_append_rela): Assert that there is enough room in section.
	(_bfd_sparc_elf_copy_indirect_symbol): Fix formatting.
	(_bfd_sparc_elf_adjust_dynamic_symbol): Minor tweak.
	(allocate_dynrelocs): Remove outdated comments and reorder conditions.
	For a symbol subject to a GOT relocation, reserve a slot in the
	relocation section if the symbol isn't dynamic and we are in PIC mode.
	(_bfd_sparc_elf_relocate_section) <R_SPARC_GOTDATA_OP>: If relocation
	is relaxed and a slot was reserved, generate a R_SPARC_NONE relocation.
	<R_SPARC_GOTDATA_OP_HIX22>: Adjust comments.
	<R_SPARC_PC10>: Reorder conditions.  Remove always-false assertion.
	(_bfd_sparc_elf_finish_dynamic_symbol): Rename local_undefweak into
	resolved_to_zero.  Do not generate a dynamic GOT relocation for an
	undefined weak symbol with non-default visibility.  Remove superfluous
	'else' and fix formatting.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] oops - actually remove the assignment this time: bfd/elf32-nds32.c:9693]: (warning) Redundant assignment of 'irel->r_addend' to itself.
@ 2018-02-12 12:16 sergiodj+buildbot
  2018-02-12 13:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-12 12:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6444b19b244d7c84537fc796005ef756917135ae ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 6444b19b244d7c84537fc796005ef756917135ae

oops - actually remove the assignment this time: bfd/elf32-nds32.c:9693]: (warning) Redundant assignment of 'irel->r_addend' to itself.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix compile time warning: bfd/elf32-arc.c:1537]: (warning) Redundant assignment of 'rel->r_offset' to itself.
@ 2018-02-12 12:31 sergiodj+buildbot
  2018-02-12 15:36 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-12 12:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0b8683b7eb25cc150c7738ddc0d237f255e0fa70 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 0b8683b7eb25cc150c7738ddc0d237f255e0fa70

Fix compile time warning: bfd/elf32-arc.c:1537]: (warning) Redundant assignment of 'rel->r_offset' to itself.

	* elf32-arc.c (elf_arc_relocate_section):  Remove redundant
	assignment.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add support for reading msdos MZ executables.
@ 2018-02-12 13:36 sergiodj+buildbot
  2018-02-12 18:02 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-12 13:36 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 830db0485e19000985ccfdbacda4d4d5d62583bb ***

Author: Zebediah Figura <z.figura12@gmail.com>
Branch: master
Commit: 830db0485e19000985ccfdbacda4d4d5d62583bb

Add support for reading msdos MZ executables.

See email thread starting here:  https://www.sourceware.org/ml/binutils/2018-01/msg00001.html

include	* coff/msdos.h: New header.
	* coff/pe.h: Move common defines to msdos.h.
	* coff/powerpc.h: Likewise.

bfd	* i386msdos.c (msdos_mkobject); New function.
	(msdos_object_p): New function.
	(i386_msdos_vec): Use msdos_object_p as the check_format
	function.
	* peicode.h: Rename external_PEI_DOS_hdr, DOSMAGIC, and
	NT_SIGNATURE to external_DOS_hdr, IMAGE_DOS_SIGNATURE, and
	IMAGE_NT_SIGNATURE.
	* peXXigen.c: Likewise.
	* coff-ia64.c: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] MIPS: Fix encoding for MIPSr6 sigrie instruction.
@ 2018-02-12 15:14 sergiodj+buildbot
  2018-02-12 21:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-12 15:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d2159fdc0f0ac1d0aaafab725b930e78a8793494 ***

Author: Henry Wong <henry@stuffedcow.net>
Branch: master
Commit: d2159fdc0f0ac1d0aaafab725b930e78a8793494

MIPS: Fix encoding for MIPSr6 sigrie instruction.

The instruction encoding for the MIPS r6 sigrie instruction seems to be
incorrect.  It's currently 0x4170xxxx (which overlaps with ei, di, evp,
and dvp), but should be 0x0417xxxx.  See ISA reference[1][2].

References:

[1] "MIPS Architecture for Programmers Volume II-A: The MIPS32
    Instruction Set Manual", Imagination Technologies, Inc., Document
    Number: MD00086, Revision 6.06, December 15, 2016, Table A.4 "MIPS32
    REGIMM Encoding of rt Field", p. 452

[2] "MIPS Architecture For Programmers Volume II-A: The MIPS64
    Instruction Set Reference Manual", Imagination Technologies, Inc.,
    Document Number: MD00087, Revision 6.06, December 15, 2016, Table
    A.4 "MIPS64 REGIMM Encoding of rt Field", p. 581

	opcodes/
	* mips-opc.c (mips_builtin_opcodes): Correct "sigrie" encoding.

	gas/
	* testsuite/gas/mips/r6.d: Update for "sigrie" encoding fix.
	* testsuite/gas/mips/r6-n32.d: Likewise.
	* testsuite/gas/mips/r6-n64.d: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb: Remove cleanup from dw2_do_instantiate_symtab
@ 2018-02-13  0:11 sergiodj+buildbot
  2018-02-13  1:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-13  0:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b303c6f688c6cd1ffd986ae65ac3f2dc11f27b93 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: b303c6f688c6cd1ffd986ae65ac3f2dc11f27b93

gdb: Remove cleanup from dw2_do_instantiate_symtab

When running the test gdb.dwarf2/dw2-bad-parameter-type.exp under
valgrind, I see the following issue reported (on x86-64 Fedora):

  (gdb) ptype f
  ==5203== Invalid read of size 1
  ==5203==    at 0x6931FE: process_die_scope::~process_die_scope() (dwarf2read.c:10642)
  ==5203==    by 0x66818F: process_die(die_info*, dwarf2_cu*) (dwarf2read.c:10664)
  ==5203==    by 0x66A01F: read_file_scope(die_info*, dwarf2_cu*) (dwarf2read.c:11650)
  ==5203==    by 0x667F2D: process_die(die_info*, dwarf2_cu*) (dwarf2read.c:10672)
  ==5203==    by 0x6677B6: process_full_comp_unit(dwarf2_per_cu_data*, language) (dwarf2read.c:10445)
  ==5203==    by 0x66657A: process_queue(dwarf2_per_objfile*) (dwarf2read.c:9945)
  ==5203==    by 0x6559B4: dw2_do_instantiate_symtab(dwarf2_per_cu_data*) (dwarf2read.c:3163)
  ==5203==    by 0x66683D: psymtab_to_symtab_1(partial_symtab*) (dwarf2read.c:10034)
  ==5203==    by 0x66622A: dwarf2_read_symtab(partial_symtab*, objfile*) (dwarf2read.c:9811)
  ==5203==    by 0x787984: psymtab_to_symtab(objfile*, partial_symtab*) (psymtab.c:792)
  ==5203==    by 0x786E3E: psym_lookup_symbol(objfile*, int, char const*, domain_enum_tag) (psymtab.c:522)
  ==5203==    by 0x804BD0: lookup_symbol_via_quick_fns(objfile*, int, char const*, domain_enum_tag) (symtab.c:2383)
  ==5203==  Address 0x147ed063 is 291 bytes inside a block of size 4,064 free'd
  ==5203==    at 0x4C2CD5A: free (vg_replace_malloc.c:530)
  ==5203==    by 0x444415: void xfree<void>(void*) (common-utils.h:60)
  ==5203==    by 0x9DA8C2: call_freefun (obstack.c:103)
  ==5203==    by 0x9DAD35: _obstack_free (obstack.c:280)
  ==5203==    by 0x44464C: auto_obstack::~auto_obstack() (gdb_obstack.h:73)
  ==5203==    by 0x68AFB0: dwarf2_cu::~dwarf2_cu() (dwarf2read.c:25080)
  ==5203==    by 0x68B204: free_one_cached_comp_unit(dwarf2_per_cu_data*) (dwarf2read.c:25174)
  ==5203==    by 0x66668C: dwarf2_release_queue(void*) (dwarf2read.c:9982)
  ==5203==    by 0x563A4C: do_my_cleanups(cleanup**, cleanup*) (cleanups.c:154)
  ==5203==    by 0x563AA7: do_cleanups(cleanup*) (cleanups.c:176)
  ==5203==    by 0x5646CE: throw_exception_cxx(gdb_exception) (common-exceptions.c:289)
  ==5203==    by 0x5647B7: throw_exception(gdb_exception) (common-exceptions.c:317)
  ==5203==  Block was alloc'd at
  ==5203==    at 0x4C2BBAD: malloc (vg_replace_malloc.c:299)
  ==5203==    by 0x564BE8: xmalloc (common-utils.c:44)
  ==5203==    by 0x9DA872: call_chunkfun (obstack.c:94)
  ==5203==    by 0x9DA935: _obstack_begin_worker (obstack.c:141)
  ==5203==    by 0x9DAA3C: _obstack_begin (obstack.c:164)
  ==5203==    by 0x4445E0: auto_obstack::auto_obstack() (gdb_obstack.h:70)
  ==5203==    by 0x68AE07: dwarf2_cu::dwarf2_cu(dwarf2_per_cu_data*) (dwarf2read.c:25073)
  ==5203==    by 0x661A8A: init_cutu_and_read_dies(dwarf2_per_cu_data*, abbrev_table*, int, int, void (*)(die_reader_specs const*, unsigned char const*, die_info*, int, void*), void*) (dwarf2read.c:7869)
  ==5203==    by 0x666A29: load_full_comp_unit(dwarf2_per_cu_data*, language) (dwarf2read.c:10108)
  ==5203==    by 0x655847: load_cu(dwarf2_per_cu_data*) (dwarf2read.c:3120)
  ==5203==    by 0x655928: dw2_do_instantiate_symtab(dwarf2_per_cu_data*) (dwarf2read.c:3148)
  ==5203==    by 0x66683D: psymtab_to_symtab_1(partial_symtab*) (dwarf2read.c:10034)

There's actually a series of three issues reported, but it turns out
they're all related, so we can consider on the first one.

The invalid read is triggered from a destructor which is being invoked
as part of a stack unwind after throwing an error.  At the time the
error is thrown, the stack looks like this:

    #0  0x00000000009f4ecd in __cxa_throw ()
    #1  0x0000000000564761 in throw_exception_cxx (exception=...) at ../../src/gdb/common/common-exceptions.c:303
    #2  0x00000000005647b8 in throw_exception (exception=...) at ../../src/gdb/common/common-exceptions.c:317
    #3  0x00000000005648ff in throw_it(return_reason, errors, const char *, typedef __va_list_tag __va_list_tag *) (reason=RETURN_ERROR,
        error=GENERIC_ERROR, fmt=0xb33020 "Dwarf Error: Cannot find DIE at 0x%x referenced from DIE at 0x%x [in module %s]",
        ap=0x7fff387f2d68) at ../../src/gdb/common/common-exceptions.c:373
    #4  0x0000000000564929 in throw_verror (error=GENERIC_ERROR,
        fmt=0xb33020 "Dwarf Error: Cannot find DIE at 0x%x referenced from DIE at 0x%x [in module %s]", ap=0x7fff387f2d68)
        at ../../src/gdb/common/common-exceptions.c:379
    #5  0x0000000000867be4 in verror (string=0xb33020 "Dwarf Error: Cannot find DIE at 0x%x referenced from DIE at 0x%x [in module %s]",
        args=0x7fff387f2d68) at ../../src/gdb/utils.c:251
    #6  0x000000000056879d in error (fmt=0xb33020 "Dwarf Error: Cannot find DIE at 0x%x referenced from DIE at 0x%x [in module %s]")
        at ../../src/gdb/common/errors.c:43
    #7  0x0000000000686875 in follow_die_ref (src_die=0x30bc8a0, attr=0x30bc8c8, ref_cu=0x7fff387f2ed0) at ../../src/gdb/dwarf2read.c:22969
    #8  0x00000000006844cd in lookup_die_type (die=0x30bc8a0, attr=0x30bc8c8, cu=0x30bc5d0) at ../../src/gdb/dwarf2read.c:21976
    #9  0x0000000000683f27 in die_type (die=0x30bc8a0, cu=0x30bc5d0) at ../../src/gdb/dwarf2read.c:21832
    #10 0x0000000000679b39 in read_subroutine_type (die=0x30bc830, cu=0x30bc5d0) at ../../src/gdb/dwarf2read.c:17343
    #11 0x00000000006845fb in read_type_die_1 (die=0x30bc830, cu=0x30bc5d0) at ../../src/gdb/dwarf2read.c:22035
    #12 0x0000000000684576 in read_type_die (die=0x30bc830, cu=0x30bc5d0) at ../../src/gdb/dwarf2read.c:22010
    #13 0x000000000067003f in read_func_scope (die=0x30bc830, cu=0x30bc5d0) at ../../src/gdb/dwarf2read.c:13822
    #14 0x0000000000667f5e in process_die (die=0x30bc830, cu=0x30bc5d0) at ../../src/gdb/dwarf2read.c:10679
    #15 0x000000000066a020 in read_file_scope (die=0x30bc720, cu=0x30bc5d0) at ../../src/gdb/dwarf2read.c:11650
    #16 0x0000000000667f2e in process_die (die=0x30bc720, cu=0x30bc5d0) at ../../src/gdb/dwarf2read.c:10672
    #17 0x00000000006677b7 in process_full_comp_unit (per_cu=0x3089b80, pretend_language=language_minimal)
        at ../../src/gdb/dwarf2read.c:10445
    #18 0x000000000066657b in process_queue (dwarf2_per_objfile=0x30897d0) at ../../src/gdb/dwarf2read.c:9945
    #19 0x00000000006559b5 in dw2_do_instantiate_symtab (per_cu=0x3089b80) at ../../src/gdb/dwarf2read.c:3163
    #20 0x000000000066683e in psymtab_to_symtab_1 (pst=0x3089bd0) at ../../src/gdb/dwarf2read.c:10034
    #21 0x000000000066622b in dwarf2_read_symtab (self=0x3089bd0, objfile=0x3073f40) at ../../src/gdb/dwarf2read.c:9811
    #22 0x0000000000787985 in psymtab_to_symtab (objfile=0x3073f40, pst=0x3089bd0) at ../../src/gdb/psymtab.c:792
    #23 0x0000000000786e3f in psym_lookup_symbol (objfile=0x3073f40, block_index=1, name=0x30b2e30 "f", domain=VAR_DOMAIN)
        at ../../src/gdb/psymtab.c:522
    #24 0x0000000000804bd1 in lookup_symbol_via_quick_fns (objfile=0x3073f40, block_index=1, name=0x30b2e30 "f", domain=VAR_DOMAIN)
        at ../../src/gdb/symtab.c:2383
    #25 0x0000000000804fe4 in lookup_symbol_in_objfile (objfile=0x3073f40, block_index=1, name=0x30b2e30 "f", domain=VAR_DOMAIN)
        at ../../src/gdb/symtab.c:2558
    #26 0x0000000000805125 in lookup_static_symbol (name=0x30b2e30 "f", domain=VAR_DOMAIN) at ../../src/gdb/symtab.c:2595
    #27 0x0000000000804357 in lookup_symbol_aux (name=0x30b2e30 "f", match_type=symbol_name_match_type::FULL, block=0x0,
        domain=VAR_DOMAIN, language=language_c, is_a_field_of_this=0x0) at ../../src/gdb/symtab.c:2105
    #28 0x0000000000803ad9 in lookup_symbol_in_language (name=0x30b2e30 "f", block=0x0, domain=VAR_DOMAIN, lang=language_c,
        is_a_field_of_this=0x0) at ../../src/gdb/symtab.c:1887
    #29 0x0000000000803b53 in lookup_symbol (name=0x30b2e30 "f", block=0x0, domain=VAR_DOMAIN, is_a_field_of_this=0x0)
        at ../../src/gdb/symtab.c:1899
    #30 0x000000000053b246 in classify_name (par_state=0x7fff387f6090, block=0x0, is_quoted_name=false, is_after_structop=false)
        at ../../src/gdb/c-exp.y:2879
    #31 0x000000000053b7e9 in c_yylex () at ../../src/gdb/c-exp.y:3083
    #32 0x000000000053414a in c_yyparse () at c-exp.c:1903
    #33 0x000000000053c2e7 in c_parse (par_state=0x7fff387f6090) at ../../src/gdb/c-exp.y:3255
    #34 0x0000000000774a02 in parse_exp_in_context_1 (stringptr=0x7fff387f61c0, pc=0, block=0x0, comma=0, void_context_p=0, out_subexp=0x0)
        at ../../src/gdb/parse.c:1213
    #35 0x000000000077476a in parse_exp_in_context (stringptr=0x7fff387f61c0, pc=0, block=0x0, comma=0, void_context_p=0, out_subexp=0x0)
        at ../../src/gdb/parse.c:1115
    #36 0x0000000000774714 in parse_exp_1 (stringptr=0x7fff387f61c0, pc=0, block=0x0, comma=0) at ../../src/gdb/parse.c:1106
    #37 0x0000000000774c53 in parse_expression (string=0x27ff996 "f") at ../../src/gdb/parse.c:1253
    #38 0x0000000000861dc4 in whatis_exp (exp=0x27ff996 "f", show=1) at ../../src/gdb/typeprint.c:472
    #39 0x00000000008620d8 in ptype_command (type_name=0x27ff996 "f", from_tty=1) at ../../src/gdb/typeprint.c:561
    #40 0x000000000047430b in do_const_cfunc (c=0x3012010, args=0x27ff996 "f", from_tty=1) at ../../src/gdb/cli/cli-decode.c:106
    #41 0x000000000047715e in cmd_func (cmd=0x3012010, args=0x27ff996 "f", from_tty=1) at ../../src/gdb/cli/cli-decode.c:1886
    #42 0x00000000008431bb in execute_command (p=0x27ff996 "f", from_tty=1) at ../../src/gdb/top.c:630
    #43 0x00000000006bf946 in command_handler (command=0x27ff990 "ptype f") at ../../src/gdb/event-top.c:583
    #44 0x00000000006bfd12 in command_line_handler (rl=0x30bb3a0 "\240\305\v\003") at ../../src/gdb/event-top.c:774

The problem is that in `process_die` (frames 14 and 16) we create a
`process_die_scope` object, that takes a copy of the `struct
dwarf2_cu *` passed into the frame.  The destructor of the
`process_die_scope` dereferences the stored pointer.  This wouldn't be
an issue, except...

... in dw2_do_instantiate_symtab (frame 19) a clean up was registered that
clears the dwarf2_queue in case of an error.  Part of this clean up
involves deleting the `struct dwarf2_cu`s referenced from the queue..

The problem then, is that cleanups are processed at the site of the
throw, while, class destructors are invoked as we unwind their frame.
The result is that we process the frame 19 cleanup (and delete the
struct dwarf2_cu) before we process the destructors in frames 14 and 16.
When we do get back to frames 14 and 16 the objects being references
have already been deleted.

The solution is to remove the cleanup from dw2_do_instantiate_symtab, and
instead use a destructor to release the dwarf2_queue instead.  With this
patch in place, the valgrind errors are now resolved.

gdb/ChangeLog:

	* dwarf2read.c (dwarf2_release_queue): Delete function, move body
	into...
	(class dwarf2_queue_guard): ...the destructor of this new class.
	(dw2_do_instantiate_symtab): Create instance of the new class
	dwarf2_queue_guard, remove cleanup.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix prefix of maint set/show per-command
@ 2018-02-13  6:47 sergiodj+buildbot
  2018-02-13  6:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-13  6:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 387cd15b93fdca3a66bbda427c4e1d9340bfb532 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 387cd15b93fdca3a66bbda427c4e1d9340bfb532

Fix prefix of maint set/show per-command

I noticed this:

(gdb) apropos per-command
maintenance set per-command -- Per-command statistics settings
set per-command space -- Set whether to display per-command space usage
set per-command symtab -- Set whether to display per-command symtab statistics
set per-command time -- Set whether to display per-command execution time
maintenance show per-command -- Show per-command statistics settings
show per-command space -- Show whether to display per-command space usage
show per-command symtab -- Show whether to display per-command symtab statistics
show per-command time -- Show whether to display per-command execution time

The subcommands of "maintenance set per-command" are missing the
maintenance keyword.  This is because that command is registered with
the wrong prefix.  This patch fixes that.

gdb/ChangeLog:

	* maint.c (_initialize_maint_cmds): Fix prefix of maint set/show
	per-command.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PR22829, objcopy/strip removes PT_GNU_RELRO from lld binaries
@ 2018-02-13  9:23 sergiodj+buildbot
  2018-02-13 10:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-13  9:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f2731e0c374e5323ce4cdae2bcc7b7fe22da1a6f ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: f2731e0c374e5323ce4cdae2bcc7b7fe22da1a6f

PR22829, objcopy/strip removes PT_GNU_RELRO from lld binaries

lld lays out the relro segment differently to GNU ld, not bothering to
include the first few bytes of .got.plt and padding out to a page at
the end of the segment.  This patch teaches binutils to recognize the
different (and somewhat inferior) layout as valid.

bfd/
	PR 22829
	* elf.c (assign_file_positions_for_non_load_sections): Rewrite
	PT_GNU_RELRO setup.
ld/
	* testsuite/ld-x86-64/pr14207.d: Adjust relro p_filesz.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PR22836, "-r -s" doesn't work with -g3 using GCC 7
@ 2018-02-13 12:41 sergiodj+buildbot
  2018-02-13 13:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-13 12:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6e5e9d58c1eeef5677c90886578a895cb8c164c5 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 6e5e9d58c1eeef5677c90886578a895cb8c164c5

PR22836, "-r -s" doesn't work with -g3 using GCC 7

This fixes the case where all of a group is removed with ld -r, the
situation in the PR, and failures where part of a group is removed
that contain relocs.

bfd/
	PR 22836
	* elf.c (_bfd_elf_fixup_group_sections): Account for removed
	relocation sections.  If size reduces to just the flag word,
	remove that too and mark with SEC_EXCLUDE.
	* elflink.c (bfd_elf_final_link): Strip empty group sections.
binutils/
	* testsuite/binutils-all/group-7.s,
	* testsuite/binutils-all/group-7a.d,
	* testsuite/binutils-all/group-7b.d,
	* testsuite/binutils-all/group-7c.d: New tests.
	* testsuite/binutils-all/objcopy.exp: Run them.
ld/
	* testsuite/ld-elf/pr22836-2.d,
	* testsuite/ld-elf/pr22836-2.s: New test.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] WebAssembly: Correct an `index' global shadowing error for pre-4.8 GCC
@ 2018-02-13 13:28 sergiodj+buildbot
  2018-02-13 14:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-13 13:28 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 87993319a56af838d3ab7e251fa4902476ca63c8 ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 87993319a56af838d3ab7e251fa4902476ca63c8

WebAssembly: Correct an `index' global shadowing error for pre-4.8 GCC

Remove `-Wshadow' compilation errors:

cc1: warnings being treated as errors
.../bfd/wasm-module.c: In function 'wasm_scan_name_function_section':
.../bfd/wasm-module.c:312: error: declaration of 'index' shadows a global declaration
/usr/include/string.h:303: error: shadowed declaration is here
.../bfd/wasm-module.c: In function 'wasm_register_section':
.../bfd/wasm-module.c:494: error: declaration of 'index' shadows a global declaration
/usr/include/string.h:303: error: shadowed declaration is here
.../bfd/wasm-module.c: In function 'wasm_compute_custom_section_file_position':
.../bfd/wasm-module.c:523: error: declaration of 'index' shadows a global declaration
/usr/include/string.h:303: error: shadowed declaration is here

and:

cc1: warnings being treated as errors
.../opcodes/wasm32-dis.c: In function 'print_insn_wasm32':
.../opcodes/wasm32-dis.c:272: error: declaration of 'index' shadows a global declaration
/usr/include/string.h:303: error: shadowed declaration is here
make[4]: *** [wasm32-dis.lo] Error 1

which for versions of GCC before 4.8 prevent support for the WebAssembly
target from being built.  See also GCC PR c/53066.

	bfd/
	* wasm-module.c (wasm_scan_name_function_section): Rename
	`index' local variable to `idx'.

	opcodes/
	* wasm32-dis.c (print_insn_wasm32): Rename `index' local
	variable to `function_index'.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] WebAssembly: Disable subdirectory configuration for unsupported LD
@ 2018-02-13 13:31 sergiodj+buildbot
  2018-02-13 17:27 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-13 13:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b29d26411c62fef6b1401aff4f2c6a157053de4d ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: b29d26411c62fef6b1401aff4f2c6a157053de4d

WebAssembly: Disable subdirectory configuration for unsupported LD

Remove an LD subdirectory configuration error:

*** ld does not support target wasm32-unknown-none
*** see ld/configure.tgt for supported targets
make[1]: *** [configure-ld] Error 1

which prevents binutils for the WebAssembly target from being built
unless an explicit `--disable-ld' configuration option has been given.
Users must not have to disable features selected by default to get a
working configuration.

	/
	* configure.ac <wasm32-*-*> (noconfigdirs): Add `ld'.
	* configure: Regenerate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix compile time warning messages from gcc version 8 about cast between incompatible function types.
@ 2018-02-13 13:43 sergiodj+buildbot
  2018-02-13 19:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-13 13:43 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 68d206766637a041bbbeb89c8a1bfdd76317e192 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 68d206766637a041bbbeb89c8a1bfdd76317e192

Fix compile time warning messages from gcc version 8 about cast between incompatible function types.

	PR 22823
bfd	Fix compile time warnings generated by gcc version 8.
	* libbfd-in.h: Remove extraneous text from prototypes.
	Add prototypes for bfd_false_any, bfd_true_any,
	bfd_nullvoidptr_any, bfd_0_any, bfd_0u_any, bfd_0l_any,
	bfd_n1_any, bfd_void_any.
	(_bfd_generic_bfd_copy_private_bfd_data): Use vararg based dummy
	function.
	(_bfd_generic_bfd_merge_private_bfd_data): Likewise.
	(_bfd_generic_bfd_set_private_flags): Likewise.
	(_bfd_generic_bfd_copy_private_section_data): Likewise.
	(_bfd_generic_bfd_copy_private_symbol_data): Likewise.
	(_bfd_generic_bfd_copy_private_header_data): Likewise.
	(_bfd_generic_bfd_print_private_bfd_data): Likewise.
	(_bfd_noarchive_construct_extended_name_table): Likewise.
	(_bfd_noarchive_truncate_arname): Likewise.
	(_bfd_noarchive_write_ar_hdr): Likewise.
	(_bfd_noarchive_get_elt_at_index): Likewise.
	(_bfd_nosymbols_canonicalize_symtab): Likewise.
	(_bfd_nosymbols_print_symbol): Likewise.
	(_bfd_nosymbols_get_symbol_info): Likewise.
	(_bfd_nosymbols_get_symbol_version_string): Likewise.
	(_bfd_nosymbols_bfd_is_local_label_name): Likewise.
	(_bfd_nosymbols_bfd_is_target_special_symbol): Likewise.
	(_bfd_nosymbols_get_lineno): Likewise.
	(_bfd_nosymbols_find_nearest_line): Likewise.
	(_bfd_nosymbols_find_line): Likewise.
	(_bfd_nosymbols_find_inliner_info): Likewise.
	(_bfd_nosymbols_bfd_make_debug_symbol): Likewise.
	(_bfd_nosymbols_read_minisymbols): Likewise.
	(_bfd_nosymbols_minisymbol_to_symbol): Likewise.
	(_bfd_norelocs_bfd_reloc_type_lookup): Likewise.
	(_bfd_norelocs_bfd_reloc_name_lookup): Likewise.
	(_bfd_nowrite_set_arch_mach): Likewise.
	(_bfd_nowrite_set_section_contents): Likewise.
	(_bfd_nolink_sizeof_headers): Likewise.
	(_bfd_nolink_bfd_get_relocated_section_contents): Likewise.
	(_bfd_nolink_bfd_relax_section): Likewise.
	(_bfd_nolink_bfd_gc_sections): Likewise.
	(_bfd_nolink_bfd_lookup_section_flags): Likewise.
	(_bfd_nolink_bfd_merge_sections): Likewise.
	(_bfd_nolink_bfd_is_group_section): Likewise.
	(_bfd_nolink_bfd_discard_group): Likewise.
	(_bfd_nolink_bfd_link_hash_table_create): Likewise.
	(_bfd_nolink_bfd_link_add_symbols): Likewise.
	(_bfd_nolink_bfd_link_just_syms): Likewise.
	(_bfd_nolink_bfd_copy_link_hash_symbol_type): Likewise.
	(_bfd_nolink_bfd_final_link): Likewise.
	(_bfd_nolink_bfd_link_split_section): Likewise.
	(_bfd_nolink_section_already_linked): Likewise.
	(_bfd_nolink_bfd_define_common_symbol): Likewise.
	(_bfd_nolink_bfd_define_start_stop): Likewise.
	(_bfd_nodynamic_canonicalize_dynamic_symtab): Likewise.
	(_bfd_nodynamic_get_synthetic_symtab): Likewise.
	(_bfd_nodynamic_get_dynamic_reloc_upper_bound _bfd_): Likewise.
	(_bfd_nodynamic_canonicalize_dynamic_reloc): Likewise.
	* libbfd.c (bfd_false_any): New function.  Like bfd_false but
	accepts one or more arguments.
	(bfd_true_any): Likewise.
	(bfd_nullvoidptr_any): Likewise.
	(bfd_0_any): Likewise.
	(bfd_0u_any): Likewise.
	(bfd_0l_any): Likewise.
	(_bfd_n1_any): Likewise.
	(bfd_void_any): Likewise.
	* libbfd.h (extern): Regenerate
	* aout-target.h (MY_bfd_is_target_special_symbol): Use vararg
	based dummy function.
	* aout-tic30.c (tic30_aout_set_arch_mach): Likewise.
	* binary.c (binary_get_symbol_info): Likewise.
	* coff-alpha.c (alpha_ecoff_backend_data): Likewise.
	* coff-mips.c (mips_ecoff_backend_data): Likewise.
	* coffcode.h (coff_set_alignment_hook): Likewise.
	(symname_in_debug_hook): Likewise.
	(bfd_coff_backend_data bigobj_swap_table): Likewise.
	* elf-m10300.c (elf_backend_omit_section_dynsym): Likewise.
	* elf32-cr16.c (elf_backend_omit_section_dynsym): Likewise.
	* elf32-lm32.c (elf_backend_omit_section_dynsym): Likewise.
	* elf32-m32r.c (elf_backend_omit_section_dynsym): Likewise.
	* elf32-metag.c (elf_backend_omit_section_dynsym): Likewise.
	* elf32-score.c (elf_backend_omit_section_dynsym): Likewise.
	* elf32-score7.c (elf_backend_omit_section_dynsym): Likewise.
	* elf32-xstormy16.c (elf_backend_omit_section_dynsym): Likewise.
	* elf32-xtensa.c (elf_backend_omit_section_dynsym): Likewise.
	* elf64-alpha.c (elf_backend_omit_section_dynsym): Likewise.
	* elf64-hppa.c (elf_backend_omit_section_dynsym): Likewise.
	* elf64-ia64-vms.c (elf_backend_omit_section_dynsym): Likewise.
	* elf64-mmix.c (elf_backend_omit_section_dynsym): Likewise.
	* elf64-sh64.c (elf_backend_omit_section_dynsym): Likewise.
	* elfnn-ia64.c (elf_backend_omit_section_dynsym): Likewise.
	* elfxx-target.h (bfd_elfNN_bfd_debug_info_accumulate): Likewise.
	(bfd_elfNN_bfd_make_debug_symbol): Likewise.
	(bfd_elfNN_bfd_merge_private_bfd_data): Likewise.
	(bfd_elfNN_bfd_set_private_flags): Likewise.
	(bfd_elfNN_bfd_is_target_special_symbol): Likewise.
	(elf_backend_init_index_section): Likewise.
	(elf_backend_allow_non_load_phdr): Likewise.
	* elfxx-x86.h (elf_backend_omit_section_dynsym): Likewise.
	* i386msdos.c (msdos_bfd_is_target_special_symbol): Likewise.
	* ieee.c (ieee_construct_extended_name_table): Likewise.
	(ieee_write_armap): Likewise.
	(ieee_write_ar_hdr): Likewise.
	(ieee_bfd_is_target_special_symbol): Likewise.
	* ihex.c (ihex_canonicalize_symtab): Likewise.
	(ihex_bfd_is_target_special_symbol): Likewise.
	* libaout.h (aout_32_bfd_is_target_special_symbol): Likewise.
	* libecoff.h (_bfd_ecoff_bfd_is_target_special_symbol): Likewise.
	(_bfd_ecoff_set_alignment_hook): Likewise.
	* mach-o-target.c (bfd_mach_o_bfd_is_target_special_symbol): Likewise.
	* mmo.c (mmo_bfd_is_target_special_symbol): Likewise.
	* nlm-target.h (nlm_bfd_is_target_special_symbol): Likewise.
	* oasys.c (oasys_construct_extended_name_table): Likewise.
	(oasys_write_armap): Likewise.
	(oasys_write_ar_hdr): Likewise.
	(oasys_bfd_is_target_special_symbol): Likewise.
	* pef.c (bfd_pef_bfd_is_target_special_symbol): Likewise.
	* plugin.c (bfd_plugin_bfd_is_target_special_symbol): Likewise.
	* ppcboot.c (ppcboot_bfd_is_target_special_symbol): Likewise.
	* som.c (som_bfd_is_target_special_symbol): Likewise.
	* srec.c (srec_bfd_is_target_special_symbol): Likewise.
	* tekhex.c (tekhex_bfd_is_target_special_symbol): Likewise.
	* verilog.c (verilog_bfd_is_target_special_symbol): Likewise.
	* versados.c (versados_bfd_is_target_special_symbol): Likewise.
	(versados_bfd_reloc_name_lookup): Likewise.
	* vms-alpha.c (vms_bfd_is_target_special_symbol): Likewise.
	(vms_bfd_define_start_stop): Likewise.
	(alpha_vms_bfd_is_target_special_symbol): Likewise.
	* wasm-module.c (wasm_bfd_is_target_special_symbol): Likewise.
	* xsym.c (bfd_sym_bfd_is_target_special_symbol): Likewise.
	* elf32-arc.c (get_replace_function): Assign replacement function
	to func pointer.
	* elf32-i370.c (i370_noop): Update prototype.

gas	* config/obj-elf.c (elf_pseudo_table): Remove now redundant
	casts.
	(obj_elf_vtable_inherit): Rename to obj_elf_get_vtable_inherit.
	(obj_elf_vtable_inherit): New stub function that calls
	obj_elf_get_vtable_inherit.
	(obj_elf_vtable_entry): Rename to obj_elf_get_vtable_entry.
	(obj_elf_vtable_entry): New stub function that calls
	obj_elf_get_vtable_entry.
	* config/obj-elf.h (obj_elf_vtable_inherit): Update prototype.
	(obj_elf_vtable_entry) Likewise.
	(obj_elf_get_vtable_inherit) Likewise.
	(obj_elf_get_vtable_entry) Likewise.
	* config/tc-arm.c (md_pseudo_table): Remove now redundant cast.
	* config/tc-i386c (md_pseudo_table): Likewise.
	* config/tc-hppa.c (pa_vtable_entry): Call
	obj_elf_get_vtable_entry.
	(pa_vtable_inherit): Call obj_elf_get_vtable_inherit.
	* config/tc-mips.c (s_mips_file): Replace call to dwarf2_get_file
	with call to dwarf2_get_filename.
	* dwarf2dbg.c (dwarf2_directive_file): Rename to
	dwarf2_directive_filename.
	(dwarf2_directive_file): New stub function that calls
	dwarf2_directive_filename.
	* dwarf2dbg.h: Prototype dwarf2_directive_filename.

opcodes	* metag-dis.c (print_fmmov): Double buffer size to avoid warning
	about truncation of printing.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix typo in Russian translation for the bfd/ sub-directory which could lead to a seg-fault in the linker.
@ 2018-02-13 15:41 sergiodj+buildbot
  2018-02-13 21:44 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-13 15:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 80c96350467f23a54546580b3e2b67a65ec65b66 ***

Author: Sergei Trofimovich <slyfox@inbox.ru>
Branch: master
Commit: 80c96350467f23a54546580b3e2b67a65ec65b66

Fix typo in Russian translation for the bfd/ sub-directory which could lead to a seg-fault in the linker.

	PR 22828
	* po/ru.po: Fix typo in Russian translation.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86-64: Generate branch with PLT32 relocation
@ 2018-02-13 15:51 sergiodj+buildbot
  2018-02-13 23:22 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-13 15:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bd7ab16b4537788ad53521c45469a1bdae84ad4a ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: bd7ab16b4537788ad53521c45469a1bdae84ad4a

x86-64: Generate branch with PLT32 relocation

Since there is no need to prepare for PLT branch on x86-64, generate
R_X86_64_PLT32, instead of R_X86_64_PC32, if possible, which can be
used as a marker for 32-bit PC-relative branches.

To compile Linux kernel, this patch:

From: "H.J. Lu" <hjl.tools@gmail.com>
Subject: [PATCH] x86: Treat R_X86_64_PLT32 as R_X86_64_PC32

On i386, there are 2 types of PLTs, PIC and non-PIC.  PIE and shared
objects must use PIC PLT.  To use PIC PLT, you need to load
_GLOBAL_OFFSET_TABLE_ into EBX first.  There is no need for that on
x86-64 since x86-64 uses PC-relative PLT.

On x86-64, for 32-bit PC-relative branches, we can generate PLT32
relocation, instead of PC32 relocation, which can also be used as
a marker for 32-bit PC-relative branches.  Linker can always reduce
PLT32 relocation to PC32 if function is defined locally.   Local
functions should use PC32 relocation.  As far as Linux kernel is
concerned, R_X86_64_PLT32 can be treated the same as R_X86_64_PC32
since Linux kernel doesn't use PLT.

is needed.  It is available on hjl/plt32/master branch at

https://github.com/hjl-tools/linux

bfd/

	PR gas/22791
	* elf64-x86-64.c (is_32bit_relative_branch): Removed.
	(elf_x86_64_relocate_section): Check PIC relocations in PIE.
	Remove is_32bit_relative_branch usage.  Disallow PC32 reloc
	against protected function in shared object.

gas/

	PR gas/22791
	* config/tc-i386.c (need_plt32_p): New function.
	(output_jump): Generate BFD_RELOC_X86_64_PLT32 if possible.
	(md_estimate_size_before_relax): Likewise.
	* testsuite/gas/i386/reloc64.d: Updated.
	* testsuite/gas/i386/x86-64-jump.d: Likewise.
	* testsuite/gas/i386/x86-64-mpx-branch-1.d: Likewise.
	* testsuite/gas/i386/x86-64-mpx-branch-2.d: Likewise.
	* testsuite/gas/i386/x86-64-relax-2.d: Likewise.
	* testsuite/gas/i386/x86-64-relax-3.d: Likewise.
	* testsuite/gas/i386/ilp32/reloc64.d: Likewise.
	* testsuite/gas/i386/ilp32/x86-64-branch.d: Likewise.

ld/

	PR gas/22791
	* testsuite/ld-x86-64/mpx1c.rd: Updated.
	* testsuite/ld-x86-64/pr22791-1.err: New file.
	* testsuite/ld-x86-64/pr22791-1a.c: Likewise.
	* testsuite/ld-x86-64/pr22791-1b.s: Likewise.
	* testsuite/ld-x86-64/pr22791-2.rd: Likewise.
	* testsuite/ld-x86-64/pr22791-2a.s: Likewise.
	* testsuite/ld-x86-64/pr22791-2b.c: Likewise.
	* testsuite/ld-x86-64/pr22791-2c.s: Likewise.
	* testsuite/ld-x86-64/x86-64.exp: Run PR ld/22791 tests.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use enum flags for flags passed to openp
@ 2018-02-13 17:36 sergiodj+buildbot
  2018-02-14  1:04 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-13 17:36 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 24b9144d4ba83d37751786b08b48ad62fb7aef26 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 24b9144d4ba83d37751786b08b48ad62fb7aef26

Use enum flags for flags passed to openp

gdb/ChangeLog:

	* defs.h (enum openp_flags): New enum.
	(OPF_TRY_CWD_FIRST, OPF_SEARCH_IN_PATH, OPF_RETURN_REALPATH):
	Move to enum openp_flags.
	(openp_flags): New enum flags.
	(openp): Change parameter type to openp_flags.
	* source.c (openp): Change parameter type to openp_flags.
	* cli/cli-cmds.c (find_and_open_script): Use openp_flags.
	* dwarf2read.c (try_open_dwop_file): Use openp_flags.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: Properly check building shared library
@ 2018-02-13 22:52 sergiodj+buildbot
  2018-02-14  2:43 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-13 22:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1031c264fd23641111df1e12a35d0a8f7e82fb80 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 1031c264fd23641111df1e12a35d0a8f7e82fb80

x86: Properly check building shared library

If a symbol is not defined in a regular file, and we are not generating
a shared library, then set the symbol to its location in the .plt.  This
is required to make function pointers compare as equal between the normal
executable and the shared library.

	* elfxx-x86.c (elf_x86_allocate_dynrelocs): Check bfd_link_dll,
	instead of bfd_link_pic, for building shared library.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove references to ada_name_for_lookup (deleted)
@ 2018-02-14 11:04 sergiodj+buildbot
  2018-02-14 12:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-14 11:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f98b2e334fcca666afaee3c6546b9fc91a4963d4 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: f98b2e334fcca666afaee3c6546b9fc91a4963d4

Remove references to ada_name_for_lookup (deleted)

This function was deleted on 2017-11-08, but its declaration and
a reference to it in a comment was left behind.  This patch just
removes those.

gdb/ChangeLog:

        * ada-lang.c (name_match_type_from_name): Remove reference to
        ada_name_for_lookup in function's documentation.
        * ada-lang.h (ada_name_for_lookup): Delete declaration.

Tested by rebuilding GDB.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86-64: Use PLT address for PC-relative reloc
@ 2018-02-14 12:04 sergiodj+buildbot
  2018-02-14 14:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-14 12:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 451875b4f976a527395e9303224c7881b65e12ed ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 451875b4f976a527395e9303224c7881b65e12ed

x86-64: Use PLT address for PC-relative reloc

Since PLT in PDE and PC-relative PLT in PIE can be used as function
address, there is no need for dynamic PC-relative relocation against
a dynamic function definition in PIE.  Linker should resolve PC-relative
reference to its PLT address.

NB: i386 has non-PIC PLT and PIC PLT.  Only non-PIC PLT in PDE can
be used as function address.  PIC PLT in PIE can't be used as
function address.

bfd/

	PR ld/22842
	* elf32-i386.c (elf_i386_check_relocs): Pass FALSE for non
	PC-relative PLT to NEED_DYNAMIC_RELOCATION_P.
	* elf64-x86-64.c (elf_x86_64_check_relocs): Create PLT for
	R_X86_64_PC32 reloc against dynamic function in data section.
	Pass TRUE for PC-relative PLT to NEED_DYNAMIC_RELOCATION_P.
	(elf_x86_64_relocate_section): Use PLT for R_X86_64_PC32 reloc
	against dynamic function in data section.
	* elfxx-x86.c (elf_x86_allocate_dynrelocs): Use PLT in PIE as
	function address only if pcrel_plt is true.
	(_bfd_x86_elf_link_hash_table_create): Set pcrel_plt.
	* elfxx-x86.h (NEED_DYNAMIC_RELOCATION_P): Add PCREL_PLT for
	PC-relative PLT.  If PLT is PC-relative, don't generate dynamic
	PC-relative relocation against a function definition in data
	secton in PIE.  Remove the obsolete comments.
	(elf_x86_link_hash_table): Add pcrel_plt.

ld/

	PR ld/22842
	* testsuite/ld-i386/i386.exp: Run PR ld/22842 tests.
	* testsuite/ld-x86-64/x86-64.exp: Likewise.
	* testsuite/ld-i386/pr22842a.c: New file.
	* testsuite/ld-i386/pr22842b.S: Likewise.
	* testsuite/ld-x86-64/pr22842a.c: Likewise.
	* testsuite/ld-x86-64/pr22842a.rd: Likewise.
	* testsuite/ld-x86-64/pr22842b.S: Likewise.
	* testsuite/ld-x86-64/pr22842b.rd: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix compilation of the BFD sub-directory with a gcc v8 compiler by adding extra casts.
@ 2018-02-14 15:16 sergiodj+buildbot
  2018-02-14 16:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-14 15:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 12ef3f5a7c5a6b89964842fd3da047b8d07dec91 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 12ef3f5a7c5a6b89964842fd3da047b8d07dec91

Fix compilation of the BFD sub-directory with a gcc v8 compiler by adding extra casts.

GCC v8 issues warnings about mis-matching casts of function pointers.
A previous patch tried to fix this problem by adding new dummy functions
which accepted a variable number of arguments.  But this introduces serious
problems when compiled with other versions of gcc, (notably gcc 4.4).  This
patch reverts that previous solution and instead adds extra casts (to
function types without a parameter list).

For more details see: https://sourceware.org/ml/binutils/2018-02/msg00198.html

	PR 22823
	Revert previous delta.  Add extra casts to avoid compile time
	warnings instead.
	* libbfd-in.h (_bfd_generic_bfd_copy_private_bfd_data): Add extra
	cast to avoid warning from gcc v8 compiler.
	(_bfd_generic_bfd_merge_private_bfd_data): Likewise.
	(_bfd_generic_bfd_set_private_flags): Likewise.
	(_bfd_generic_bfd_copy_private_section_data): Likewise.
	(_bfd_generic_bfd_copy_private_symbol_data): Likewise.
	(_bfd_generic_bfd_copy_private_header_data): Likewise.
	(_bfd_generic_bfd_print_private_bfd_data): Likewise.
	(_bfd_noarchive_construct_extended_name_table): Likewise.
	(_bfd_noarchive_truncate_arname): Likewise.
	(_bfd_noarchive_write_ar_hdr): Likewise.
	(_bfd_noarchive_get_elt_at_index): Likewise.
	(_bfd_nosymbols_canonicalize_symtab): Likewise.
	(_bfd_nosymbols_print_symbol): Likewise.
	(_bfd_nosymbols_get_symbol_info): Likewise.
	(_bfd_nosymbols_get_symbol_version_string): Likewise.
	(_bfd_nosymbols_bfd_is_local_label_name): Likewise.
	(_bfd_nosymbols_bfd_is_target_special_symbol): Likewise.
	(_bfd_nosymbols_get_lineno): Likewise.
	(_bfd_nosymbols_find_nearest_line): Likewise.
	(_bfd_nosymbols_find_line): Likewise.
	(_bfd_nosymbols_find_inliner_info): Likewise.
	(_bfd_nosymbols_bfd_make_debug_symbol): Likewise.
	(_bfd_nosymbols_read_minisymbols): Likewise.
	(_bfd_nosymbols_minisymbol_to_symbol): Likewise.
	(_bfd_norelocs_bfd_reloc_type_lookup): Likewise.
	(_bfd_norelocs_bfd_reloc_name_lookup): Likewise.
	(_bfd_nowrite_set_arch_mach): Likewise.
	(_bfd_nowrite_set_section_contents): Likewise.
	(_bfd_nolink_sizeof_headers): Likewise.
	(_bfd_nolink_bfd_get_relocated_section_contents): Likewise.
	(_bfd_nolink_bfd_relax_section): Likewise.
	(_bfd_nolink_bfd_gc_sections): Likewise.
	(_bfd_nolink_bfd_lookup_section_flags): Likewise.
	(_bfd_nolink_bfd_merge_sections): Likewise.
	(_bfd_nolink_bfd_is_group_section): Likewise.
	(_bfd_nolink_bfd_discard_group): Likewise.
	(_bfd_nolink_bfd_link_hash_table_create): Likewise.
	(_bfd_nolink_bfd_link_add_symbols): Likewise.
	(_bfd_nolink_bfd_link_just_syms): Likewise.
	(_bfd_nolink_bfd_copy_link_hash_symbol_type): Likewise.
	(_bfd_nolink_bfd_final_link): Likewise.
	(_bfd_nolink_bfd_link_split_section): Likewise.
	(_bfd_nolink_section_already_linked): Likewise.
	(_bfd_nolink_bfd_define_common_symbol): Likewise.
	(_bfd_nolink_bfd_define_start_stop): Likewise.
	(_bfd_nodynamic_canonicalize_dynamic_symtab): Likewise.
	(_bfd_nodynamic_get_synthetic_symtab): Likewise.
	(_bfd_nodynamic_get_dynamic_reloc_upper_bound _bfd_): Likewise.
	(_bfd_nodynamic_canonicalize_dynamic_reloc): Likewise.
	* libbfd.c (bfd_false_any): Delete.
	(bfd_true_any, bfd_nullvoidptr_any, bfd_0_any): Delete.
	(bfd_0u_any, bfd_0l_any, _bfd_n1_any, bfd_void_any): Delete.
	* libbfd.h (extern): Regenerate
	* aout-target.h (MY_bfd_is_target_special_symbol): Add extra
	cast to avoid warning from gcc v8 compiler.
	* aout-tic30.c (tic30_aout_set_arch_mach): Likewise.
	* binary.c (binary_get_symbol_info): Likewise.
	* coff-alpha.c (alpha_ecoff_backend_data): Likewise.
	* coff-mips.c (mips_ecoff_backend_data): Likewise.
	* coffcode.h (coff_set_alignment_hook): Likewise.
	(symname_in_debug_hook): Likewise.
	(bfd_coff_backend_data bigobj_swap_table): Likewise.
	* elf-m10300.c (elf_backend_omit_section_dynsym): Likewise.
	* elf32-cr16.c (elf_backend_omit_section_dynsym): Likewise.
	* elf32-lm32.c (elf_backend_omit_section_dynsym): Likewise.
	* elf32-m32r.c (elf_backend_omit_section_dynsym): Likewise.
	* elf32-metag.c (elf_backend_omit_section_dynsym): Likewise.
	* elf32-score.c (elf_backend_omit_section_dynsym): Likewise.
	* elf32-score7.c (elf_backend_omit_section_dynsym): Likewise.
	* elf32-xstormy16.c (elf_backend_omit_section_dynsym): Likewise.
	* elf32-xtensa.c (elf_backend_omit_section_dynsym): Likewise.
	* elf64-alpha.c (elf_backend_omit_section_dynsym): Likewise.
	* elf64-hppa.c (elf_backend_omit_section_dynsym): Likewise.
	* elf64-ia64-vms.c (elf_backend_omit_section_dynsym): Likewise.
	* elf64-mmix.c (elf_backend_omit_section_dynsym): Likewise.
	* elf64-sh64.c (elf_backend_omit_section_dynsym): Likewise.
	* elfnn-ia64.c (elf_backend_omit_section_dynsym): Likewise.
	* elfxx-target.h (bfd_elfNN_bfd_debug_info_accumulate): Likewise.
	(bfd_elfNN_bfd_make_debug_symbol): Likewise.
	(bfd_elfNN_bfd_merge_private_bfd_data): Likewise.
	(bfd_elfNN_bfd_set_private_flags): Likewise.
	(bfd_elfNN_bfd_is_target_special_symbol): Likewise.
	(elf_backend_init_index_section): Likewise.
	(elf_backend_allow_non_load_phdr): Likewise.
	* elfxx-x86.h (elf_backend_omit_section_dynsym): Likewise.
	* i386msdos.c (msdos_bfd_is_target_special_symbol): Likewise.
	* ieee.c (ieee_construct_extended_name_table): Likewise.
	(ieee_write_armap): Likewise.
	(ieee_write_ar_hdr): Likewise.
	(ieee_bfd_is_target_special_symbol): Likewise.
	* ihex.c (ihex_canonicalize_symtab): Likewise.
	(ihex_bfd_is_target_special_symbol): Likewise.
	* libaout.h (aout_32_bfd_is_target_special_symbol): Likewise.
	* libecoff.h (_bfd_ecoff_bfd_is_target_special_symbol): Likewise.
	(_bfd_ecoff_set_alignment_hook): Likewise.
	* mach-o-target.c (bfd_mach_o_bfd_is_target_special_symbol): Likewise.
	* mmo.c (mmo_bfd_is_target_special_symbol): Likewise.
	* nlm-target.h (nlm_bfd_is_target_special_symbol): Likewise.
	* oasys.c (oasys_construct_extended_name_table): Likewise.
	(oasys_write_armap): Likewise.
	(oasys_write_ar_hdr): Likewise.
	(oasys_bfd_is_target_special_symbol): Likewise.
	* pef.c (bfd_pef_bfd_is_target_special_symbol): Likewise.
	* plugin.c (bfd_plugin_bfd_is_target_special_symbol): Likewise.
	* ppcboot.c (ppcboot_bfd_is_target_special_symbol): Likewise.
	* som.c (som_bfd_is_target_special_symbol): Likewise.
	* srec.c (srec_bfd_is_target_special_symbol): Likewise.
	* tekhex.c (tekhex_bfd_is_target_special_symbol): Likewise.
	* verilog.c (verilog_bfd_is_target_special_symbol): Likewise.
	* versados.c (versados_bfd_is_target_special_symbol): Likewise.
	(versados_bfd_reloc_name_lookup): Likewise.
	* vms-alpha.c (vms_bfd_is_target_special_symbol): Likewise.
	(vms_bfd_define_start_stop): Likewise.
	(alpha_vms_bfd_is_target_special_symbol): Likewise.
	* wasm-module.c (wasm_bfd_is_target_special_symbol): Likewise.
	* xsym.c (bfd_sym_bfd_is_target_special_symbol): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Return unique_xmalloc_ptr from some solib.c functions
@ 2018-02-14 15:37 sergiodj+buildbot
  2018-02-14 18:18 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-14 15:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 797bc1cb25b9dbdbc663cf711aecb0acc2450276 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 797bc1cb25b9dbdbc663cf711aecb0acc2450276

Return unique_xmalloc_ptr from some solib.c functions

This changes a couple of solib.c functions -- exec_file_find and
solib_find -- to return a unique_xmalloc_ptr, and then fixes up the
users.  This allows the removal of some cleanups.

This also changes solib_bfd_open to not take ownership of its
argument.  I think this change is somewhat cleaner.

gdb/ChangeLog
2018-02-14  Tom Tromey  <tom@tromey.com>

	* solist.h (exec_file_find, solib_find): Return
	unique_xmalloc_ptr.
	(solib_bfd_fopen): Take a const char *.
	* solib.c (solib_find_1): Return unique_xmalloc_ptr.
	(exec_file_find, solib_find): Likewise.
	(solib_bfd_fopen): Do not take ownership of "pathname".
	(solib_bfd_open): Use unique_xmalloc_ptr.
	* solib-darwin.c (darwin_bfd_open): Use unique_xmalloc_ptr.
	* solib-aix.c (solib_aix_bfd_open): Use unique_xmalloc_ptr.
	* infrun.c (follow_exec): Use unique_xmalloc_ptr.
	* exec.c (exec_file_locate_attach): Use unique_xmalloc_ptr.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Move some declarations to source.h
@ 2018-02-14 15:50 sergiodj+buildbot
  2018-02-14 20:55 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-14 15:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b46a8d7c1d50c06e641af99b58301db0499111b9 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: b46a8d7c1d50c06e641af99b58301db0499111b9

Move some declarations to source.h

I noticed a few declarations in defs.h that really could be put into
source.h.  I think it's generally preferable to something out of
defs.h unless it is needed by most of the files in gdb.

gdb/ChangeLog
2018-02-14  Tom Tromey  <tom@tromey.com>

	* solib.c: Include source.h.
	* nto-tdep.c: Include source.h.
	* mi/mi-cmd-env.c: Include source.h.
	* infcmd.c: Include source.h.
	* exec.c: Include source.h.
	* defs.h (enum openp_flag, openp, source_full_path_of, mod_path)
	(add_path, directory_switch, source_path, init_source_path): Move
	declarations...
	* source.h (enum openp_flag, openp, source_full_path_of, mod_path)
	(add_path, directory_switch, source_path, init_source_path):
	...here.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Change openp et al to use a unique_xmalloc_ptr
@ 2018-02-14 16:02 sergiodj+buildbot
  2018-02-14 23:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-14 16:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e0cc99a62f9ceb9a0db0b5bc28711fd8c82a6151 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: e0cc99a62f9ceb9a0db0b5bc28711fd8c82a6151

Change openp et al to use a unique_xmalloc_ptr

This changes openp, source_full_path_of, and find_and_open_source to
take a unique_xmalloc_ptr, rather than a char*, as an outgoing
argument type.  This simplifies the API, ownership-wise, and allows
for the removal of some cleanups.

gdb/ChangeLog
2018-02-14  Tom Tromey  <tom@tromey.com>

	* symfile.c (symfile_bfd_open): Update.
	* source.h (openp, source_full_path_of, find_and_open_source):
	Change argument type to unique_xmalloc_ptr.
	* source.c (openp): Take a unique_xmalloc_ptr.
	(source_full_path_of, find_and_open_source): Likewise.
	(open_source_file, symtab_to_fullname): Update.
	* solist.h (struct target_so_ops) <find_and_open_solib>: Take a
	unique_xmalloc_ptr.
	* solib.c (solib_find_1): Use unique_xmalloc_ptr.
	(exec_file_find): Update.
	* psymtab.c (psymtab_to_fullname): Update.
	* nto-tdep.h (nto_find_and_open_solib): Update.
	* nto-tdep.c (nto_find_and_open_solib): Change temp_path to a
	unique_xmalloc_ptr.
	* exec.c (exec_file_attach): Update.
	* dwarf2read.c (try_open_dwop_file): Use unique_xmalloc_ptr.
	* cli/cli-cmds.c (find_and_open_script): Use unique_xmalloc_ptr.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Constify target_so_ops::bfd_open
@ 2018-02-14 16:14 sergiodj+buildbot
  2018-02-15  0:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-14 16:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 692d6f9760bc67b68a5c96baac47067fd7dfa711 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 692d6f9760bc67b68a5c96baac47067fd7dfa711

Constify target_so_ops::bfd_open

This constifies the bfd_open method of struct target_so_ops.

gdb/ChangeLog
2018-02-14  Tom Tromey  <tom@tromey.com>

	* solist.h (struct target_so_ops) <bfd_open>: Make pathname
	const.
	(solib_bfd_open): Make pathname const.
	* solib.c (solib_bfd_open): Make pathname const.
	* solib-spu.c (spu_bfd_fopen): Make name const.
	(spu_bfd_open): Make pathname const.
	* solib-darwin.c (darwin_bfd_open): Make pathname const.
	* solib-aix.c (solib_aix_bfd_open): Make pathname const.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix GDB crash after Quit thrown from unwinder sniffer
@ 2018-02-14 19:26 sergiodj+buildbot
  2018-02-15  2:55 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-14 19:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 980548fd880338d2cdf4ce641ca39632dc040426 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 980548fd880338d2cdf4ce641ca39632dc040426

Fix GDB crash after Quit thrown from unwinder sniffer

I ran into a GDB crash in gdb.base/bp-cmds-continue-ctrl-c.exp in my
multi-target branch, which turns out exposed a bug that exists in
master too.

That testcase has a breakpoint with a "continue" command associated.
Then the breakpoint is constantly being hit.  At the same time, the
testcase is continualy interrupting the program with Ctrl-C, and
re-resuming it, in a loop.

Running that testcase manually under Valgrind, after a few sequences
of 'Ctrl-C' + 'continue', I got:

 Breakpoint 1, Quit
 (gdb) ==21270== Invalid read of size 8
 ==21270==    at 0x4D8185: pyuw_this_id(frame_info*, void**, frame_id*) (py-unwind.c:461)
 ==21270==    by 0x6D426A: compute_frame_id(frame_info*) (frame.c:505)
 ==21270==    by 0x6D43B7: get_frame_id(frame_info*) (frame.c:537)
 ==21270==    by 0x84F3B8: scoped_restore_current_thread::scoped_restore_current_thread() (thread.c:1678)
 ==21270==    by 0x718E3D: fetch_inferior_event(void*) (infrun.c:4076)
 ==21270==    by 0x7067C9: inferior_event_handler(inferior_event_type, void*) (inf-loop.c:43)
 ==21270==    by 0x45BEF9: handle_target_event(int, void*) (linux-nat.c:4419)
 ==21270==    by 0x6C4255: handle_file_event(file_handler*, int) (event-loop.c:733)
 ==21270==    by 0x6C47F8: gdb_wait_for_event(int) (event-loop.c:859)
 ==21270==    by 0x6C3666: gdb_do_one_event() (event-loop.c:322)
 ==21270==    by 0x6C3712: start_event_loop() (event-loop.c:371)
 ==21270==    by 0x746801: captured_command_loop() (main.c:329)
 ==21270==  Address 0x0 is not stack'd, malloc'd or (recently) free'd
 ==21270==
 ==21270==
 ==21270== Process terminating with default action of signal 11 (SIGSEGV): dumping core
 ==21270==  Access not within mapped region at address 0x0
 ==21270==    at 0x4D8185: pyuw_this_id(frame_info*, void**, frame_id*) (py-unwind.c:461)
 ==21270==    by 0x6D426A: compute_frame_id(frame_info*) (frame.c:505)
 ==21270==    by 0x6D43B7: get_frame_id(frame_info*) (frame.c:537)
 ==21270==    by 0x84F3B8: scoped_restore_current_thread::scoped_restore_current_thread() (thread.c:1678)
 ==21270==    by 0x718E3D: fetch_inferior_event(void*) (infrun.c:4076)
 ==21270==    by 0x7067C9: inferior_event_handler(inferior_event_type, void*) (inf-loop.c:43)
 ==21270==    by 0x45BEF9: handle_target_event(int, void*) (linux-nat.c:4419)
 ==21270==    by 0x6C4255: handle_file_event(file_handler*, int) (event-loop.c:733)
 ==21270==    by 0x6C47F8: gdb_wait_for_event(int) (event-loop.c:859)
 ==21270==    by 0x6C3666: gdb_do_one_event() (event-loop.c:322)
 ==21270==    by 0x6C3712: start_event_loop() (event-loop.c:371)
 ==21270==    by 0x746801: captured_command_loop() (main.c:329)
 ==21270==  If you believe this happened as a result of a stack
 ==21270==  overflow in your program's main thread (unlikely but
 ==21270==  possible), you can try to increase the size of the
 ==21270==  main thread stack using the --main-stacksize= flag.
 ==21270==  The main thread stack size used in this run was 8388608.
 ==21270==

Above, when we get to compute_frame_id, fi->unwind is non-NULL,
meaning, we found an unwinder, in this case the Python unwinder, but
somehow, fi->prologue_cache is left NULL.  pyuw_this_id then crashes
because it assumes fi->prologue_cache is non-NULL:

  static void
  pyuw_this_id (struct frame_info *this_frame, void **cache_ptr,
		struct frame_id *this_id)
  {
    *this_id = ((cached_frame_info *) *cache_ptr)->frame_id;
                                      ^^^^^^^^^^

'*cache_ptr' here is 'fi->prologue_cache'.

There's a quit() call in pyuw_sniffer that I believe is the one that
sometimes triggers the crash above.  The crash can be reproduced
easily with this hack to force a quit out of the python unwinder:

 --- a/gdb/python/py-unwind.c
 +++ b/gdb/python/py-unwind.c
 @@ -497,6 +497,8 @@ pyuw_sniffer (const struct frame_unwind *self, struct frame_info *this_frame,
    struct gdbarch *gdbarch = (struct gdbarch *) (self->unwind_data);
    cached_frame_info *cached_frame;

 +  quit ();
 +
    gdbpy_enter enter_py (gdbarch, current_language);

    TRACE_PY_UNWIND (3, "%s (SP=%s, PC=%s)\n", __FUNCTION__,

After that quit is thrown, any subsequent operation that involves
unwinding results in GDB crashing with SIGSEGV like above.

The problem is that this commit:

  commit 30a9c02feff56bd58a276c2a7262f364baa558ac
  CommitDate: Sun Oct 8 23:16:42 2017 -0600
  Subject: Remove cleanup from frame_prepare_for_sniffer

missed that we need to call frame_cleanup_after_sniffer before
rethrowing the exception too.

Without the fix, the "bt" added to
gdb.base/bp-cmds-continue-ctrl-c.exp in this commit makes GDB crash:

  Running src/gdb/testsuite/gdb.base/bp-cmds-continue-ctrl-c.exp ...
  ERROR: Process no longer exists

gdb/ChangeLog:
2018-02-14  Pedro Alves  <palves@redhat.com>

	* frame-unwind.c (frame_unwind_try_unwinder): Always call
	frame_cleanup_after_sniffer on exception.

gdb/testsuite/ChangeLog:
2018-02-14  Pedro Alves  <palves@redhat.com>

	* gdb.base/bp-cmds-continue-ctrl-c.exp (do_test): Test "bt" after
	getting a "Quit".


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] delete ada-lang.c::ada_to_fixed_value_create advance declaration
@ 2018-02-15  4:34 sergiodj+buildbot
  2018-02-15  4:34 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-15  4:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 355c559b74518b67eb113e635363cc890058746c ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 355c559b74518b67eb113e635363cc890058746c

delete ada-lang.c::ada_to_fixed_value_create advance declaration

This advance declaration really isn't necesary, since the implementation
of this function comes before the first reference to it.

gdb/ChangeLog:

        * ada-lang.c (ada_to_fixed_value_create): Delete advance
        declaration.

Tested by rebuilding GDB.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Reset inferior::control on inferior exit
@ 2018-02-15 15:04 sergiodj+buildbot
  2018-02-15 15:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-15 15:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 85046ae23f853bfd01db6b4a840e80220487bffd ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 85046ae23f853bfd01db6b4a840e80220487bffd

Reset inferior::control on inferior exit

When we kill an inferior, the inferior is not deleted.  What is more, it
is reused when the new process is created, so we need to reset inferior's
state when it exits.

gdb:

2018-02-15  Yao Qi  <yao.qi@linaro.org>

	PR gdb/22849
	* inferior.c (exit_inferior_1): Reset inf->control.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PR ld/22832 on SPARC.
@ 2018-02-15 15:29 sergiodj+buildbot
  2018-02-15 19:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-15 15:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e513bd38a6b91401947d90ba5f301f01d3991b8e ***

Author: Eric Botcazou <ebotcazou@gcc.gnu.org>
Branch: master
Commit: e513bd38a6b91401947d90ba5f301f01d3991b8e

PR ld/22832 on SPARC.

The fix for PR ld/22727 on SPARC passed TRUE as the 'create' argument
in the call to bfd_link_hash_lookup.  It turns out this was a bad idea
because, if the symbol is created at this point, the link will abort
later in elf_link_output_extsym.  This changes the TRUE into a FALSE
and puts an assertion on the result of the call, making it easier to
debug the issue; that's exactly in keeping with what Gold does.

bfd/
	* elfxx-sparc.c (_bfd_sparc_elf_check_relocs) <R_SPARC_TLS_GD_CALL>:
	Pass FALSE instead of TRUE as 'create' argument to bfd_link_hash_lookup
	and assert that the result of the call is not NULL.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] RISC-V: Give error for ignored pcrel_lo addend.
@ 2018-02-15 19:14 sergiodj+buildbot
  2018-02-15 20:54 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-15 19:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2a0d98534964649bc6884b7833c6c4089159a6df ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 2a0d98534964649bc6884b7833c6c4089159a6df

RISC-V: Give error for ignored pcrel_lo addend.

	bfd/
	* elfnn-riscv.c (riscv_elf_relocate_section): Use bfd_reloc_dangerous
	when pcrel_lo reloc has an addend.  Use reloc_dangerous callback for
	bfd_reloc_dangerous.  Use einfo instead of warning callback for errors.
	Add %X%P to error messages.

	ld/
	* testsuite/ld-riscv-elf/ld-riscv-elf.exp: Run pcrel-lo-addend test.
	* testsuite/ld-riscv-elf/pcrel-lo-addend.d: New.
	* testsuite/ld-riscv-elf/pcrel-lo-addend.s: New.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] RISC-V: Fix relocation failure with zero address sections.
@ 2018-02-15 22:04 sergiodj+buildbot
  2018-02-15 23:11 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-15 22:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 09ca4b9d9bd61ecb779386a6cc7796cb05dde1af ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 09ca4b9d9bd61ecb779386a6cc7796cb05dde1af

RISC-V: Fix relocation failure with zero address sections.

	bfd/
	* elfnn-riscv.c (_bfd_riscv_relax_section): Ifdef out check to ignore
	symbols whose section address is zero.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove bfd stub function casts.
@ 2018-02-16  8:56 sergiodj+buildbot
  2018-02-16  9:38 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-16  8:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d00dd7dc5e415503de88614bf2ea4aafa2bca819 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: d00dd7dc5e415503de88614bf2ea4aafa2bca819

Remove bfd stub function casts.

This patch defines a bunch of new functions to use in the BFD target
structs rather than casting bfd_false or bfd_true and similar stub
functions.  I've also renamed the stub functions to reflect their
parameters and put "error" in the name if they set bfd_error.  The
latter change is important since there were quite a few uses of
bfd_false where setting bfd_error was inappropriate, for example in
elf_backend_allow_non_load_phdr and is_target_special_symbol.

	* libbfd.c (_bfd_bool_bfd_false_error): Rename from bfd_false.
	(_bfd_bool_bfd_true): Rename from bfd_true.
	(_bfd_ptr_bfd_null_error): Rename from bfd_nullvoidptr.
	(_bfd_int_bfd_0): Rename from bfd_0.
	(_bfd_uint_bfd_0): Rename from bfd_0u.
	(_bfd_long_bfd_0): Rename from bfd_0l.
	(_bfd_long_bfd_n1_error): Rename from _bfd_n1.
	(_bfd_void_bfd): Rename from bfd_void.
	(_bfd_bool_bfd_false, _bfd_bool_bfd_asymbol_false),
	(_bfd_bool_bfd_link_false_error),
	(_bfd_bool_bfd_link_true, _bfd_bool_bfd_bfd_true),
	(_bfd_bool_bfd_uint_true, _bfd_bool_bfd_ptr_true),
	(_bfd_bool_bfd_asection_bfd_asection_true),
	(_bfd_bool_bfd_asymbol_bfd_asymbol_true),
	(_bfd_void_bfd_link, _bfd_void_bfd_asection): New functions.
	* archive.c (_bfd_noarchive_get_elt_at_index),
	(_bfd_noarchive_openr_next_archived_file),
	(_bfd_noarchive_construct_extended_name_table),
	(_bfd_noarchive_write_ar_hdr, _bfd_noarchive_truncate_arname),
	(_bfd_noarchive_write_armap): New functions.
	* archures.c (_bfd_nowrite_set_arch_mach): New function.
	* coff-alpha.c (alpha_ecoff_swap_coff_aux_in),
	(alpha_ecoff_swap_coff_sym_in, alpha_ecoff_swap_coff_lineno_in),
	(alpha_ecoff_swap_coff_aux_out, alpha_ecoff_swap_coff_sym_out),
	(alpha_ecoff_swap_coff_lineno_out),
	(alpha_ecoff_swap_coff_reloc_out): New functions.
	* coff-mips.c (mips_ecoff_swap_coff_aux_in),
	(mips_ecoff_swap_coff_sym_in, mips_ecoff_swap_coff_lineno_in),
	(mips_ecoff_swap_coff_aux_out, mips_ecoff_swap_coff_sym_out),
	(mips_ecoff_swap_coff_lineno_out),
	(mips_ecoff_swap_coff_reloc_out): New functions.
	* coffcode.h (coff_set_alignment_hook): Replace define with
	new function.
	(symname_in_debug_hook): Likewise.
	* ecoff.c (_bfd_ecoff_set_alignment_hook): New function.
	* elfxx-target.h (elf_backend_allow_non_load_phdr): Default to 0.
	* elf.c (assign_file_positions_except_relocs): Test
	elf_backend_allow_non_load_phdr for NULL.
	* elflink.c (_bfd_elf_omit_section_dynsym_default): Rename from
	_bfd_elf_link_omit_section_dynsym.  Update uses.
	(_bfd_elf_omit_section_dynsym_all): New function.
	* elf-bfd.h (_bfd_elf_link_omit_section_dynsym): Delete.
	(_bfd_elf_omit_section_dynsym_default): Declare.
	(_bfd_elf_omit_section_dynsym_all): Declare.
	* linker.c (_bfd_nolink_sizeof_headers, _bfd_nolink_bfd_relax_section),
	(_bfd_nolink_bfd_get_relocated_section_contents),
	(_bfd_nolink_bfd_lookup_section_flags),
	(_bfd_nolink_bfd_is_group_section, _bfd_nolink_bfd_discard_group),
	(_bfd_nolink_bfd_link_hash_table_create),
	(_bfd_nolink_bfd_link_just_syms),
	(_bfd_nolink_bfd_copy_link_hash_symbol_type),
	(_bfd_nolink_bfd_link_split_section),
	(_bfd_nolink_section_already_linked),
	(_bfd_nolink_bfd_define_common_symbol),
	(_bfd_nolink_bfd_define_start_stop): New functions.
	* reloc.c (_bfd_norelocs_bfd_reloc_type_lookup),
	(_bfd_norelocs_bfd_reloc_name_lookup),
	(_bfd_nodynamic_canonicalize_dynamic_reloc): New functions.
	* section.c (_bfd_nowrite_set_section_contents): New function.
	* syms.c (_bfd_nosymbols_canonicalize_symtab),
	(_bfd_nosymbols_print_symbol, _bfd_nosymbols_get_symbol_info),
	(_bfd_nosymbols_get_symbol_version_string),
	(_bfd_nosymbols_bfd_is_local_label_name),
	(_bfd_nosymbols_get_lineno, _bfd_nosymbols_find_nearest_line),
	(_bfd_nosymbols_find_line, _bfd_nosymbols_find_inliner_info),
	(_bfd_nosymbols_bfd_make_debug_symbol),
	( _bfd_nosymbols_read_minisymbols),
	( _bfd_nosymbols_minisymbol_to_symbol),
	(_bfd_nodynamic_get_synthetic_symtab): New functions.
	* libbfd-in.h: Declare new functions.  Update existing defines,
	removing casts.
	* aix386-core.c: Update to use new hooks.  Formatting.
	* aout-adobe.c: Likewise.
	* aout-arm.c: Likewise.
	* aout-target.h: Likewise.
	* aout-tic30.c: Likewise.
	* aoutf1.h: Likewise.
	* binary.c: Likewise.
	* bout.c: Likewise.
	* cisco-core.c: Likewise.
	* coff-alpha.c: Likewise.
	* coff-i386.c: Likewise.
	* coff-i860.c: Likewise.
	* coff-i960.c: Likewise.
	* coff-ia64.c: Likewise.
	* coff-mips.c: Likewise.
	* coff-ppc.c: Likewise.
	* coff-rs6000.c: Likewise.
	* coff-sh.c: Likewise.
	* coff-tic30.c: Likewise.
	* coff-tic54x.c: Likewise.
	* coff-x86_64.c: Likewise.
	* coff64-rs6000.c: Likewise.
	* coffcode.h: Likewise.
	* elf-m10300.c: Likewise.
	* elf32-cr16.c: Likewise.
	* elf32-lm32.c: Likewise.
	* elf32-m32r.c: Likewise.
	* elf32-metag.c: Likewise.
	* elf32-score.c: Likewise.
	* elf32-score7.c: Likewise.
	* elf32-tilepro.c: Likewise.
	* elf32-xstormy16.c: Likewise.
	* elf32-xtensa.c: Likewise.
	* elf64-alpha.c: Likewise.
	* elf64-hppa.c: Likewise.
	* elf64-ia64-vms.c: Likewise.
	* elf64-mmix.c: Likewise.
	* elf64-sh64.c: Likewise.
	* elfnn-ia64.c: Likewise.
	* elfxx-sparc.c: Likewise.
	* elfxx-target.h: Likewise.
	* elfxx-tilegx.c: Likewise.
	* elfxx-x86.h: Likewise.
	* hp300hpux.c: Likewise.
	* hppabsd-core.c: Likewise.
	* hpux-core.c: Likewise.
	* i386msdos.c: Likewise.
	* i386os9k.c: Likewise.
	* ieee.c: Likewise.
	* ihex.c: Likewise.
	* irix-core.c: Likewise.
	* libaout.h: Likewise.
	* libecoff.h: Likewise.
	* mach-o-target.c: Likewise.
	* mach-o.c: Likewise.
	* mipsbsd.c: Likewise.
	* mmo.c: Likewise.
	* netbsd-core.c: Likewise.
	* nlm-target.h: Likewise.
	* oasys.c: Likewise.
	* osf-core.c: Likewise.
	* pdp11.c: Likewise.
	* pe-mips.c: Likewise.
	* pe-x86_64.c: Likewise.
	* pef.c: Likewise.
	* plugin.c: Likewise.
	* ppcboot.c: Likewise.
	* ptrace-core.c: Likewise.
	* sco5-core.c: Likewise.
	* som.c: Likewise.
	* sparclynx.c: Likewise.
	* srec.c: Likewise.
	* tekhex.c: Likewise.
	* trad-core.c: Likewise.
	* verilog.c: Likewise.
	* versados.c: Likewise.
	* vms-alpha.c: Likewise.
	* vms-lib.c: Likewise.
	* wasm-module.c: Likewise.
	* xsym.c: Likewise.
	* libbfd.h: Regenerate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] New class allocate_on_obstack
@ 2018-02-16 16:34 sergiodj+buildbot
  2018-02-16 17:29 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-16 16:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fd90ace4c1e77c94e90d2942cebe84e9a2019c0f ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: fd90ace4c1e77c94e90d2942cebe84e9a2019c0f

New class allocate_on_obstack

This patch adds a new class allocate_on_obstack, and let dwarf2_per_objfile
inherit it, so that dwarf2_per_objfile is automatically allocated on
obstack, and "delete dwarf2_per_objfile" doesn't de-allocate any space.

gdb:

2018-02-16  Yao Qi  <yao.qi@linaro.org>

	* block.c (block_namespace_info): Inherit allocate_on_obstack.
	(block_initialize_namespace): Use new.
	* dwarf2read.c (dwarf2_per_objfile): Inherit allocate_on_obstack.
	(dwarf2_free_objfile): Use delete.
	* gdbtypes.c (type_pair): Inherit allocate_on_obstack.
	(copy_type_recursive): Use new.
	* gdb_obstack.h (allocate_on_obstack): New.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Ignore degenerate PT_LOAD segments
@ 2018-02-17  0:02 sergiodj+buildbot
  2018-02-17  0:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-17  0:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 325ba6fb34be799c885fad9287d883e86b835c84 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 325ba6fb34be799c885fad9287d883e86b835c84

Ignore degenerate PT_LOAD segments

Fixes a failure triggered by -z separate-code.  p_memsz is tested
rather than p_filesz for objcopy --only-keep-debug where p_filesz is
set to zero.

	PR 22845
	* elf.c (assign_file_positions_for_non_load_sections): Ignore
	degenerate zero size PT_LOAD segments when finding one overlapping
	the PT_GNU_RELRO segment.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PT_LOAD and PT_GNU_RELRO segment overlap
@ 2018-02-19  3:38 sergiodj+buildbot
  2018-02-19  3:58 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-19  3:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT dbc88fc14992c556b94e77de563a8f7abcb0b653 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: dbc88fc14992c556b94e77de563a8f7abcb0b653

PT_LOAD and PT_GNU_RELRO segment overlap

Commit 325ba6fb34 excluded degenerate zero length PT_LOAD segments,
but that only fixed part of the problem, which was that the load
segment limits were not calculated properly.

	PR 22845
	* elf.c (IS_TBSS): Define.
	(_bfd_elf_map_sections_to_segments): Use IS_TBSS.
	(assign_file_positions_for_non_load_sections): Revert last change.
	Properly calculate load segment limits to compare against relro limits.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix make 3.81 build errors
@ 2018-02-20 11:13 sergiodj+buildbot
  2018-02-20 11:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-20 11:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a543c5ca7c1285548726e6d92ca6044dc1963340 ***

Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: a543c5ca7c1285548726e6d92ca6044dc1963340

Fix make 3.81 build errors

gdbserver/
	* Makefile.in: Switch order of make rules.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] btrace, testsuite: do not force BTS
@ 2018-02-20 13:30 sergiodj+buildbot
  2018-02-20 13:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-20 13:30 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT de65820cd69a4d9aaa87079a809c70364571efab ***

Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: de65820cd69a4d9aaa87079a809c70364571efab

btrace, testsuite: do not force BTS

In gdb.btrace/buffer-size.exp we explicitly ask for the BTS recording format.
This may lead to spurious fails on systems where PT is being used by some other
process at the same time.

Set both PT and BTS buffer sizes to 1 and check that whatever recording format
is used will use a 4KB buffer.

testsuite/
	* gdb.btrace/buffer-size.exp: Do not force BTS.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gnulib: import mkstemp
@ 2018-02-20 13:39 sergiodj+buildbot
  2018-02-20 15:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-20 13:39 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2d8adcbd07fc12a3212a9f045605ef712f5fb3ab ***

Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: 2d8adcbd07fc12a3212a9f045605ef712f5fb3ab

gnulib: import mkstemp

Older versions of MinGW do not support mkstemp causing:

    gdb/unittests/scoped_fd-selftests.c:37:29: error: \
    'mkstemp' was not declared in this scope
       int fd = mkstemp (filename);
                             ^
    gdb/unittests/scoped_fd-selftests.c: In function 'void
    selftests::scoped_fd::test_release()':
    gdb/unittests/scoped_fd-selftests.c:56:29: error: \
    'mkstemp' was not declared in this scope
       int fd = mkstemp (filename);
                             ^

Import mkstemp from gnulib.

gdb/
	* gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkstemp.
	* gnulib/aclocal.m4: Regenerated.
	* gnulib/config.in: Regenerated.
	* gnulib/configure: Regenerated.
	* gnulib/import/Makefile.am: Regenerated.
	* gnulib/import/Makefile.in: Regenerated.
	* gnulib/import/m4/gnulib-cache.m4: Regenerated.
	* gnulib/import/m4/gnulib-comp.m4: Regenerated.
	* gnulib/import/m4/mkstemp.m4: Imported.
	* gnulib/import/m4/secure_getenv.m4: Imported.
	* gnulib/import/m4/tempname.m4: Imported.
	* gnulib/import/mkstemp.c: Imported.
	* gnulib/import/secure_getenv.c: Imported.
	* gnulib/import/tempname.c: Imported.
	* gnulib/import/tempname.h: Imported.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Enable link time garbage collection support for the IA64 target.
@ 2018-02-20 14:56 sergiodj+buildbot
  2018-02-20 17:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-20 14:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6e8d06db1a6e63e0da80035114dbfefeabf63d87 ***

Author: Jason Duerstock <jason.duerstock@gmail.com>
Branch: master
Commit: 6e8d06db1a6e63e0da80035114dbfefeabf63d87

Enable link time garbage collection support for the IA64 target.

As suggested in long ago in a galaxy far, far away [1], I tried
turning it on and it seems to work, as is evidenced by the Mesa
package in Debian/ia64.  Please enable it with the following patch.
[1] https://sourceware.org/ml/binutils/2007-07/msg00241.html

bfd	* elfnn-ia64.c (elf_backend_can_gc_sections): Enable.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] remote-sim: Add missing ATTRIBUTE_PRINTF
@ 2018-02-20 16:58 sergiodj+buildbot
  2018-02-20 19:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-20 16:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7104e59bece90e387d70f617eb7ed4c34087283d ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 7104e59bece90e387d70f617eb7ed4c34087283d

remote-sim: Add missing ATTRIBUTE_PRINTF

Fixes:

/home/emaisin/src/binutils-gdb/gdb/remote-sim.c:385:34: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
  vfprintf_filtered (gdb_stdout, format, args);
                                 ^~~~~~
/home/emaisin/src/binutils-gdb/gdb/remote-sim.c:394:34: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
  vfprintf_filtered (gdb_stdout, format, ap);
                                 ^~~~~~
/home/emaisin/src/binutils-gdb/gdb/remote-sim.c:402:34: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
  vfprintf_filtered (gdb_stderr, format, ap);
                                 ^~~~~~
/home/emaisin/src/binutils-gdb/gdb/remote-sim.c:413:11: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
  verror (format, args);
          ^~~~~~
4 errors generated.

gdb/ChangeLog:

	* remote-sim.c (gdb_os_printf_filtered, gdb_os_vprintf_filtered,
	gdb_os_evprintf_filtered, gdb_os_error): Add ATTRIBUTE_PRINTF.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] MIPS16/opcodes: Free up `M' operand code
@ 2018-02-20 21:11 sergiodj+buildbot
  2018-02-20 21:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-20 21:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 75f31665204bf965cc5b3dd699636be12fb6bcfa ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 75f31665204bf965cc5b3dd699636be12fb6bcfa

MIPS16/opcodes: Free up `M' operand code

The `M' and `m' MIPS16 operand codes are functionally the same, denoting
a 7-bit register list that is encoded the same way for both SAVE and
RESTORE.  Use `m' for both instructions then, making `M' available for a
different use.

	opcodes/
	* mips16-opc.c (decode_mips16_operand) <'M'>: Remove case.
	(mips16_opcodes): Replace `M' with `m' for "restore".

	include/
	* opcode/mips.h: Remove `M' operand code.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Class reg_buffer
@ 2018-02-21 11:39 sergiodj+buildbot
  2018-02-21 12:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 11:39 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 31716595b5bda8524fc841378468fd1c47510dd3 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 31716595b5bda8524fc841378468fd1c47510dd3

Class reg_buffer

This patch adds a new class reg_buffer, and regcache inherits it.  Class
reg_buffer is a very simple class, which has the buffer for register
contents and status only.  It doesn't have any methods to set contents and
status, and it is expected that its children classes can inherit it and
add different access methods.

Another reason I keep class reg_buffer so simple is that I think
reg_buffer can be even reused in other classes which need to record the
registers contents and status, like frame cache for example.

gdb:

2018-02-21  Yao Qi  <yao.qi@linaro.org>

	* regcache.c (regcache::regcache): Call reg_buffer ctor.
	(regcache::arch): Move it to reg_buffer::arch.
	(regcache::register_buffer): Likewise.
	(regcache::assert_regnum): Likewise.
	(regcache::num_raw_registers): Likewise.
	* regcache.h (reg_buffer): New class.
	(regcache): Inherit reg_buffer.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] class readable_regcache and pass readable_regcache to gdbarch pseudo_register_read and pseudo_register_read_value
@ 2018-02-21 11:47 sergiodj+buildbot
  2018-02-21 14:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 11:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 849d0ba802323fe05e3039ed5b22957db2c85a67 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 849d0ba802323fe05e3039ed5b22957db2c85a67

class readable_regcache and pass readable_regcache to gdbarch pseudo_register_read and pseudo_register_read_value

pseudo registers are either from raw registers or memory, so
gdbarch methods pseudo_register_read and pseudo_register_read_value
should have regcache object which only have read methods.  In other
words, we should disallow writing to regcache in these two gdbarch
methods.  In order to apply this restriction, this patch adds a new
class readable_regcache, derived from reg_buffer, and it only has
raw_read and cooked_read methods.  regcache is derived from
readable_regcache.  This patch also passes readable_regcache instead of
regcache to gdbarch methods pseudo_register_read and
pseudo_register_read_value.

This patch moves raw_read* and cooked_read* methods to readable_regcache,
which is straightforward.  One thing not straightforward is that I split
regcache::xfer_part to readable_regcache::read_part and regcache::write_part,
because readable_regcache can only have methods to read.

readable_regcache is an abstract base class, and it has a pure virtual
function raw_update, because I don't want readable_regcache know where
these raw registers are from.  They can be from either the target
(readwrite regcache) or the regcache itself (readonly regcache).

gdb:

2018-02-21  Yao Qi  <yao.qi@linaro.org>

	* aarch64-tdep.c (aarch64_pseudo_register_read_value): Change
	parameter type to 'readable_regcache *'.
	* amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
	* arm-tdep.c (arm_neon_quad_read): Likewise.
	(arm_pseudo_read): Likewise.
	* avr-tdep.c (avr_pseudo_register_read): Likewise.
	* bfin-tdep.c (bfin_pseudo_register_read): Likewise.
	* frv-tdep.c (frv_pseudo_register_read): Likewise.
	* gdbarch.c: Re-generated.
	* gdbarch.h: Re-generated.
	* gdbarch.sh (pseudo_register_read): Change parameter type to
	'readable_regcache *'.
	(pseudo_register_read_value): Likewise.
	* h8300-tdep.c (pseudo_from_raw_register): Likewise.
	(h8300_pseudo_register_read): Likewise.
	* hppa-tdep.c (hppa_pseudo_register_read): Likewise.
	* i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
	(i386_pseudo_register_read_into_value): Likewise.
	(i386_pseudo_register_read_value): Likewise.
	* i386-tdep.h (i386_pseudo_register_read_into_value): Update
	declaration.
	* ia64-tdep.c (ia64_pseudo_register_read): Likewise.
	* m32c-tdep.c (m32c_raw_read): Likewise.
	(m32c_read_flg): Likewise.
	(m32c_banked_register): Likewise.
	(m32c_banked_read): Likewise.
	(m32c_sb_read): Likewise.
	(m32c_part_read): Likewise.
	(m32c_cat_read): Likewise.
	(m32c_r3r2r1r0_read): Likewise.
	(m32c_pseudo_register_read): Likewise.
	* m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
	* mep-tdep.c (mep_pseudo_cr32_read): Likewise.
	(mep_pseudo_cr64_read): Likewise.
	(mep_pseudo_register_read): Likewise.
	* mips-tdep.c (mips_pseudo_register_read): Likewise.
	* msp430-tdep.c (msp430_pseudo_register_read): Likewise.
	* nds32-tdep.c (nds32_pseudo_register_read): Likewise.
	* regcache.c (regcache::raw_read): Move it to readable_regcache.
	(regcache::cooked_read): Likewise.
	(regcache::cooked_read_value): Likewise.
	(regcache_cooked_read_signed):
	(regcache::cooked_read): Likewise.
	* regcache.h (readable_regcache): New class.
	(regcache): Inherit readable_regcache.  Move some methods to
	readable_regcache.
	* rl78-tdep.c (rl78_pseudo_register_read): Change
	parameter type to 'readable_regcache *'.
	* rs6000-tdep.c (do_regcache_raw_read): Remove.
	(e500_pseudo_register_read): Change parameter type to
	'readable_regcache *'.
	(dfp_pseudo_register_read): Likewise.
	(vsx_pseudo_register_read): Likewise.
	(efpr_pseudo_register_read): Likewise.
	* s390-tdep.c (s390_pseudo_register_read): Likewise.
	* sh-tdep.c (sh_pseudo_register_read): Likewise.
	* sh64-tdep.c (pseudo_register_read_portions): Likewise.
	(sh64_pseudo_register_read): Likewise.
	* sparc-tdep.c (sparc32_pseudo_register_read): Likewise.
	* sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
	* spu-tdep.c (spu_pseudo_register_read_spu): Likewise.
	(spu_pseudo_register_read): Likewise.
	* xtensa-tdep.c	(xtensa_register_read_masked): Likewise.
	(xtensa_pseudo_register_read): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove regcache_save and regcache_cpy
@ 2018-02-21 12:00 sergiodj+buildbot
  2018-02-21 17:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 12:00 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fc5b87361580d915e28ae5f3cc4794b75b671b5a ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: fc5b87361580d915e28ae5f3cc4794b75b671b5a

Remove regcache_save and regcache_cpy

... instead we start to use regcache methods save and restore.  It is
quite straightforward to replace regcache_save with regcache->save.

regcache_cpy has some asserts, some of them not necessary, like

 gdb_assert (src != dst);

because we already assert !m_readonly_p and src->m_readonly_p, so
src isn't dst.  Some of the asserts are moved to ::restore.

gdb:

2018-02-21  Yao Qi  <yao.qi@linaro.org>

	* frame.c (frame_save_as_regcache): Use regcache method save.
	(frame_pop): Use regcache method restore.
	* infrun.c (restore_infcall_suspend_state): Likewise.
	* linux-fork.c (fork_load_infrun_state): Likewise.
	* ppc-linux-tdep.c (ppu2spu_sniffer): User regcache method
	save.
	* regcache.c (regcache_save): Remove.
	(regcache::restore): More asserts.
	(regcache_cpy): Remove.
	* regcache.h (regcache_save): Remove the declaration.
	(regcache::restore): Move from private to public.
	Remove the friend declaration of regcache_cpy.
	(regcache_cpy): Remove declaration.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Class readonly_detached_regcache
@ 2018-02-21 12:12 sergiodj+buildbot
  2018-02-21 20:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 12:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT daf6667d1f94c7e74df4076daf021cd28a2797b6 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: daf6667d1f94c7e74df4076daf021cd28a2797b6

Class readonly_detached_regcache

This patch adds a new class (type) for readonly regcache, which is
created via regcache::save.  readonly_detached_regcache inherits
readable_regcache.

gdb:

2018-02-21  Yao Qi  <yao.qi@linaro.org>

	* dummy-frame.c (dummy_frame_cache) <prev_regcache>: Use
	readonly_detached_regcache.
	(dummy_frame_prev_register): Use regcache->cooked_read.
	* frame.c (frame_save_as_regcache): Change return type.
	(frame_pop): Update.
	* frame.h (frame_save_as_regcache): Update declaration.
	* inferior.h (get_infcall_suspend_state_regcache): Update
	declaration.
	* infrun.c (infcall_suspend_state) <registers>: use
	readonly_detached_regcache.
	(save_infcall_suspend_state): Don't use regcache_dup.
	(get_infcall_suspend_state_regcache): Change return type.
	* linux-fork.c (struct fork_info) <savedregs>: Change to
	readonly_detached_regcache.
	<pc>: New field.
	(fork_save_infrun_state): Don't use regcache_dup.
	(info_checkpoints_command): Adjust.
	* mi/mi-main.c (register_changed_p): Update declaration.
	(mi_cmd_data_list_changed_registers): Use
	readonly_detached_regcache.
	(register_changed_p): Change parameter type to
	readonly_detached_regcache.
	* ppc-linux-tdep.c (ppu2spu_cache) <regcache>: Use
	readonly_detached_regcache.
	(ppu2spu_sniffer): Construct a new readonly_detached_regcache.
	* regcache.c (readonly_detached_regcache::readonly_detached_regcache):
	New.
	(regcache::save): Move it to reg_buffer.
	(regcache::restore): Change parameter type.
	(regcache_dup): Remove.
	* regcache.h (reg_buffer) <save>: New method.
	(readonly_detached_regcache): New class.
	* spu-tdep.c (spu2ppu_cache) <regcache>: Use
	readonly_detached_regcache.
	(spu2ppu_sniffer): Construct a new readonly_detached_regcache.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Class detached_regcache
@ 2018-02-21 12:25 sergiodj+buildbot
  2018-02-21 22:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 12:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c8ec2f334c3751c28d5f952d07dea9c0558ca0a0 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: c8ec2f334c3751c28d5f952d07dea9c0558ca0a0

Class detached_regcache

jit.c uses the regcache in a slightly different way, the regcache dosen't
write through to target, but it has read and write methods.  If I apply
regcache in record-full.c, it has the similar use pattern.  This patch
adds a new class detached_regcache, a register buffer, but can be
read and written.

Since jit.c doesn't want to write registers through to target, it uses
regcache as a readonly regcache (because only readonly regcache
disconnects from the target), but it adds a hole in regcache
(raw_set_cached_value) in order to modify a readonly regcache.  This patch
fixes this hole completely.

regcache inherits detached_regcache, and detached_regcache inherits
readable_regcache.  The ideal design is that both detached_regcache and
readable_regcache inherit reg_buffer, and regcache inherit
detached_regcache and regcache_read (virtual inheritance).  I concern
about the performance overhead of virtual inheritance, so I don't do it in
the patch.

gdb:

2018-02-21  Yao Qi  <yao.qi@linaro.org>

	* jit.c (struct jit_unwind_private) <regcache>: Change its type to
	 reg_buffer_rw *.
	(jit_unwind_reg_set_impl): Call raw_supply.
	(jit_frame_sniffer): Use reg_buffer_rw.
	* record-full.c (record_full_core_regbuf): Change its type.
	(record_full_core_open_1): Use reg_buffer_rw.
	(record_full_close): Likewise.
	(record_full_core_fetch_registers): Use regcache->raw_supply.
	(record_full_core_store_registers): Likewise.
	* regcache.c (regcache::get_register_status): Move it to
	reg_buffer.
	(regcache_raw_set_cached_value): Remove.
	(regcache::raw_set_cached_value): Remove.
	(regcache::raw_write): Call raw_supply.
	(regcache::raw_supply): Move it to reg_buffer_rw.
	* regcache.h (regcache_raw_set_cached_value): Remove.
	(reg_buffer_rw): New class.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Replace regcache::dump with class register_dump
@ 2018-02-21 12:37 sergiodj+buildbot
  2018-02-22  0:58 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 12:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f3384e664de76c4bb9f8fd9920afcec86557f1f0 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: f3384e664de76c4bb9f8fd9920afcec86557f1f0

Replace regcache::dump with class register_dump

Nowadays, we need to dump registers contents from "readwrite" regcache and
"readonly" regcache,

  if (target_has_registers)
    get_current_regcache ()->dump (out, what_to_dump);
  else
    {
      /* For the benefit of "maint print registers" & co when
         debugging an executable, allow dumping a regcache even when
         there is no thread selected / no registers.  */
      regcache dummy_regs (target_gdbarch ());
      dummy_regs.dump (out, what_to_dump);
    }

since we'll have two different types/classes for "readwrite" regcache and
"readonly" regcache, we have to move dump method to their parent class,
reg_buffer.  However, the functionality of "dump" looks unnecessary to
reg_buffer (because some dump modes like regcache_dump_none,
regcache_dump_remote and regcache_dump_groups don't need reg_buffer at
all, they need gdbarch to do the dump), so I decide to move "dump" into a
separate classes, and each sub-class is about each mode of dump.

gdb:

2018-02-21  Yao Qi  <yao.qi@linaro.org>

	* regcache.c (class register_dump): New class.
	(register_dump_regcache, register_dump_none): New class.
	(register_dump_remote, register_dump_groups): New class.
	(regcache_print): Update.
	* regcache.h (regcache_dump_what): Move it to regcache.c.
	(regcache) <dump>: Remove.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] No longer create readonly regcache
@ 2018-02-21 12:50 sergiodj+buildbot
  2018-02-22  3:15 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 12:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 215c69dc9a7d8f868198b5523abcf41458fb6e4a ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 215c69dc9a7d8f868198b5523abcf41458fb6e4a

No longer create readonly regcache

Nowadays, we create a readonly regcache in get_return_value, and pass it
to gdbarch_return_value to get the return value.  In theory, we can pass a
readable_regcache instance and get the return value, because we don't need
to modify the regcache.  Unfortunately, gdbarch_return_value is designed
to multiplex regcache, according to READBUF and WRITEBUF.

 # If READBUF is not NULL, extract the return value and save it in this
 # buffer.
 #
 # If WRITEBUF is not NULL, it contains a return value which will be
 # stored into the appropriate register.

In fact, gdbarch_return_value should be split to three functions, 1) only
return return_value_convention, 2) pass regcache_readonly and readbuf, 3)
pass regcache and writebuf.  These changes are out of the scope of this
patch series, so I pass regcache to gdbarch_return_value even for read,
and trust each gdbarch backend doesn't modify regcache.

gdb:

2018-02-21  Yao Qi  <yao.qi@linaro.org>

	* infcmd.c (get_return_value): Let stop_regs point to
	get_current_regcache.
	* regcache.c (regcache::regcache): Remove.
	(register_dump_reg_buffer): New class.
	(regcache_print): Adjust.
	* regcache.h (regcache): Remove constructors.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove regcache::m_readonly_p
@ 2018-02-21 13:02 sergiodj+buildbot
  2018-02-22  5:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 13:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 796bb0264184e8d9343f041c2f11cb898c0d18ac ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 796bb0264184e8d9343f041c2f11cb898c0d18ac

Remove regcache::m_readonly_p

Now, m_readonly_p is always false, so we can remove it, and regcache no
longer includes pseudo registers.  Some regcache methods are lift up to
its parent class, like reg_buffer or detached_regcache.

gdb:

2018-02-21  Yao Qi  <yao.qi@linaro.org>

	* regcache.c (regcache::regcache): Update.
	(regcache::invalidate): Move it to detached_regcache::invalidate.
	(get_thread_arch_aspace_regcache): Update.
	(regcache::raw_update): Update.
	(regcache::cooked_read): Remove some code.
	(regcache::cooked_read_value): Likewise.
	(regcache::raw_write): Remove assert on m_readonly_p.
	(regcache::raw_supply_integer): Move it to
	detached_regcache::raw_supply_integer.
	(regcache::raw_supply_zeroed): Likewise.
	* regcache.h (detached_regcache) <raw_supply_integer>: New
	declaration.
	<raw_supply_zeroed, invalidate>: Likewise.
	(regcache) <raw_supply_integer, raw_supply_zeroed>: Removed.
	<invalidate>: Likewise.
	<m_readonly_p>: Removed.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Pass readable_regcache to gdbarch method read_pc
@ 2018-02-21 13:27 sergiodj+buildbot
  2018-02-22  8:55 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 13:27 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c113ed0ca238bbcbc161f059ffe9b064e3ece333 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: c113ed0ca238bbcbc161f059ffe9b064e3ece333

Pass readable_regcache to gdbarch method read_pc

We can pass readable_regcache to gdbarch method read_pc where it is
allowed to do read from regcache.

gdb:

2018-02-21  Yao Qi  <yao.qi@linaro.org>

	* avr-tdep.c (avr_read_pc): Change parameter type to
	readable_regcache.
	* gdbarch.sh (read_pc): Likewise.
	* gdbarch.c: Re-generated.
	* gdbarch.h: Re-generated.
	* hppa-tdep.c (hppa_read_pc): Change parameter type to
	readable_regcache.
	* ia64-tdep.c (ia64_read_pc): Likewise.
	* mips-tdep.c (mips_read_pc): Likewise.
	* spu-tdep.c (spu_read_pc): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Move register_dump to regcache-dump.c
@ 2018-02-21 15:39 sergiodj+buildbot
  2018-02-22  7:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 15:39 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4c74fe6b84d82066eb3f004bacd4a376cd82d140 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 4c74fe6b84d82066eb3f004bacd4a376cd82d140

Move register_dump to regcache-dump.c

gdb:

2018-02-21  Yao Qi  <yao.qi@linaro.org>

	* Makefile.in (COMMON_SFILES): Add regcache-dump.c
	* regcache-dump.c: New file.
	* regcache.c: Move register_dump to regcache-dump.c.
	(maintenance_print_registers): Likewise.
	(maintenance_print_raw_registers): Likewise.
	(maintenance_print_cooked_registers): Likewise.
	(maintenance_print_register_groups): Likewise.
	(maintenance_print_remote_registers): Likewise.
	(_initialize_regcache): Likewise.
	* regcache.h (register_dump): Moved from regcache.c.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove a cleanup from parse_expression_for_completion
@ 2018-02-21 16:31 sergiodj+buildbot
  2018-02-22 14:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 16:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3eac2b654808f9e233885f910045eea9d2ca0aa0 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 3eac2b654808f9e233885f910045eea9d2ca0aa0

Remove a cleanup from parse_expression_for_completion

This removes a cleanup from parse_expression_for_completion, by
changing various expression-completion functions to use
gdb::unique_xmalloc_ptry rather than explicit malloc+free.

Regression tested by the buildbot.

gdb/ChangeLog
2018-02-21  Tom Tromey  <tom@tromey.com>

	* value.h: (extract_field_op): Update.
	* eval.c (extract_field_op): Return a const char *.
	* expression.h (parse_expression_for_completion): Update.
	* completer.c (complete_expression): Update.
	(add_struct_fields): Make fieldname const.
	* parse.c (expout_completion_name): Now a unique_xmalloc_ptr.
	(mark_completion_tag, parse_exp_in_context_1): Update.
	(parse_expression_for_completion): Change "name" to
	unique_xmalloc_ptr*.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove a cleanup from call_function_by_hand_dummy
@ 2018-02-21 17:11 sergiodj+buildbot
  2018-02-22 11:34 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 17:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6ccb583f751e020a6db768d517c2dd3ba6d93cc4 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 6ccb583f751e020a6db768d517c2dd3ba6d93cc4

Remove a cleanup from call_function_by_hand_dummy

This removes a cleanup from call_function_by_hand_dummy, replacing
manual allocation with std::vector.

Regression tested by the buildbot.

gdb/ChangeLog
2018-02-21  Tom Tromey  <tom@tromey.com>

	* infcall.c (call_function_by_hand_dummy): Use std::vector.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add "common-defs.h" include to files in arch/ subdir not yet including it.
@ 2018-02-21 19:23 sergiodj+buildbot
  2018-02-22 16:43 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 19:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8ec57239e91f22f427f8065eb742e6c8bfa223f1 ***

Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: 8ec57239e91f22f427f8065eb742e6c8bfa223f1

Add "common-defs.h" include to files in arch/ subdir not yet including it.

This fixes a build breakage on FreeBSD hosts.

gdb/ChangeLog:

	* arch/aarch64.c: Include "common-defs.h".
	* arch/amd64.c: Likewise.
	* arch/i386.c: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix a typo.
@ 2018-02-21 20:49 sergiodj+buildbot
  2018-02-22 19:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 20:49 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 54a27fe598e6d44eb59bc94882f7f56585bfd5cd ***

Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: 54a27fe598e6d44eb59bc94882f7f56585bfd5cd

Fix a typo.

gdb/testsuite/ChangeLog:

	* gdb.arch/amd64-i386-address.exp: Fix a typo.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: Add {rex} pseudo prefix
@ 2018-02-22 14:40 sergiodj+buildbot
  2018-02-22 22:02 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-22 14:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6b6b680700699c15e22b6c36975729035676eef1 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 6b6b680700699c15e22b6c36975729035676eef1

x86: Add {rex} pseudo prefix

Add {rex} pseudo prefix to generate a REX byte for integer and legacy
vector instructions if possible.  Note that this differs from the rex
prefix which generates REX prefix unconditionally.

gas/

	* config/tc-i386.c (_i386_insn): Add rex_encoding.
	(md_assemble): When i.rex_encoding is true, generate a REX byte
	if possible.
	(parse_insn): Set i.rex_encoding for {rex}.
	* doc/c-i386.texi: Document {rex}.
	* testsuite/gas/i386/x86-64-pseudos.s: Add {rex} tests.
	* testsuite/gas/i386/x86-64-pseudos.d: Updated.

opcodes/

	* i386-opc.tbl: Add {rex},
	* i386-tbl.h: Regenerated.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] RISC-V: Make disassebler work for --enable-targets=all config.
@ 2018-02-22 19:44 sergiodj+buildbot
  2018-02-22 23:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-22 19:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0bccfb2994d307601ceba5c3a6223b7ca7cf5338 ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 0bccfb2994d307601ceba5c3a6223b7ca7cf5338

RISC-V: Make disassebler work for --enable-targets=all config.

	opcodes/
	* disassemble.c (ARCH_riscv): Define if ARCH_all.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] New plugin interface to get list of symbols wrapped with --wrap option.
@ 2018-02-22 22:16 sergiodj+buildbot
  2018-02-23  1:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-22 22:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0b65c07b97c43e8891c2e14061270878a85222c8 ***

Author: Sriraman Tallam <tmsriram@google.com>
Branch: master
Commit: 0b65c07b97c43e8891c2e14061270878a85222c8

New plugin interface to get list of symbols wrapped with --wrap option.

2018-02-22  Sriraman Tallam  <tmsriram@google.com>

	* plugin.cc (get_wrap_symbols): New plugin interface.
	(load): Add get_wrap_symbols to transfer vector.
	* plugin-api.h (ld_plugin_get_wrap_symbols): New plugin interface.
	* testsuite/plugin_test.c (onload): Call and check get_wrap_symbols
	interface.
	* testsuite/plugin_test_wrap_symbols.sh: New test script.
	* testsuite/plugin_test_wrap_symbols_1.cc: New file.
	* testsuite/plugin_test_wrap_symbols_2.cc: New file.
	* testsuite/Makefile.am (plugin_test_wrap_symbols): New test.
	* testsuite/Makefile.in: Regenerate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] nds32: Support target directive .ict_model.
@ 2018-02-23  7:38 sergiodj+buildbot
  2018-02-23  7:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-23  7:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e859f6558cc027261fb733e4e86938e1d31c13ca ***

Author: Kuan-Lin Chen <kuanlinchentw@gmail.com>
Branch: master
Commit: e859f6558cc027261fb733e4e86938e1d31c13ca

nds32: Support target directive .ict_model.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PR22881, null pointer dereference in assign_file_positions_for_non_load_sections
@ 2018-02-23 11:31 sergiodj+buildbot
  2018-02-23 12:36 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-23 11:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 01f7e10cf2dcf403462b2feed06c43135651556d ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 01f7e10cf2dcf403462b2feed06c43135651556d

PR22881, null pointer dereference in assign_file_positions_for_non_load_sections

	PR 22881
	* elf.c (assign_file_positions_for_non_load_sections): Remove RELRO
	segment if no matching LOAD segment.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] dwarf: Make sect_offset 64-bits
@ 2018-02-23 18:26 sergiodj+buildbot
  2018-02-23 18:39 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-23 18:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9d8780f0d0f53d9d326a9d64b7919fe1a628b767 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 9d8780f0d0f53d9d326a9d64b7919fe1a628b767

dwarf: Make sect_offset 64-bits

Does anybody have an opinion about this?  It would be nice to unbreak
the "default" build with clang (i.e. without passing special -Wno-error=
flags).

Here's a version rebased on today's master.

>From 47d28075117fa2ddb93584ec50881e33777a85e5 Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@ericsson.com>
Date: Sat, 30 Dec 2017 22:48:18 -0500
Subject: [PATCH] dwarf: Make sect_offset 64-bits

Compiling with Clang 6 shows these errors:

/home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:26610:43: error: result of comparison of constant 4294967296 with expression of type 'typename std::underlying_type<sect_offset>::type' (a
ka 'unsigned int') is always false [-Werror,-Wtautological-constant-out-of-range-compare]
      if (to_underlying (per_cu.sect_off) >= (static_cast<uint64_t> (1) << 32))
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:26618:43: error: result of comparison of constant 4294967296 with expression of type 'typename std::underlying_type<sect_offset>::type' (a
ka 'unsigned int') is always false [-Werror,-Wtautological-constant-out-of-range-compare]
      if (to_underlying (per_cu.sect_off) >= (static_cast<uint64_t> (1) << 32))
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The code in question checks if there is any offset exceeding 32 bits,
and therefore if we need to use the 64-bit DWARF format when writing the
.debug_names section.  The type we use currently to represent section
offsets is an unsigned int (32-bits), which means a value of this type
will never exceed 32 bits, hence the errors above.

There are many signs that we want to support 64-bits DWARF (although I
haven't tested), such as:

 - We correctly read initial length fields (read_initial_length)
 - We take that into account when reading offsets (read_offset_1)
 - The check_dwarf64_offsets function

However, I don't see how it can work if sect_offset is a 32-bits type.
Every time we record a section offset, we risk truncating the value.
And if a file uses the 64-bit DWARF format, it's most likely because
there are such offset values that overflow 32 bits.

Because of this, I think the way forward is to change sect_offset to be
a uint64_t.  It will be able to represent any offset, regardless of the
bitness of the DWARF info.

This patch was regtested on the buildbot.

gdb/ChangeLog:

	* gdbtypes.h (sect_offset): Change type to uint64_t.
	(sect_offset_str): New function.
	* dwarf2read.c (create_addrmap_from_aranges): Use
	sect_offset_str.
	(error_check_comp_unit_head): Likewise.
	(create_debug_type_hash_table): Likewise.
	(read_cutu_die_from_dwo): Likewise.
	(init_cutu_and_read_dies): Likewise.
	(init_cutu_and_read_dies_no_follow): Likewise.
	(process_psymtab_comp_unit_reader): Likewise.
	(partial_die_parent_scope): Likewise.
	(peek_die_abbrev): Likewise.
	(process_queue): Likewise.
	(dwarf2_physname): Likewise.
	(read_namespace_alias): Likewise.
	(read_import_statement): Likewise.
	(create_dwo_cu_reader): Likewise.
	(create_cus_hash_table): Likewise.
	(lookup_dwo_cutu): Likewise.
	(inherit_abstract_dies): Likewise.
	(read_func_scope): Likewise.
	(read_call_site_scope): Likewise.
	(dwarf2_add_member_fn): Likewise.
	(read_common_block): Likewise.
	(read_module_type): Likewise.
	(read_typedef): Likewise.
	(read_subrange_type): Likewise.
	(load_partial_dies): Likewise.
	(read_partial_die): Likewise.
	(find_partial_die): Likewise.
	(read_str_index): Likewise.
	(dwarf2_string_attr): Likewise.
	(build_error_marker_type): Likewise.
	(lookup_die_type): Likewise.
	(dump_die_shallow): Likewise.
	(follow_die_ref): Likewise.
	(dwarf2_fetch_die_loc_sect_off): Likewise.
	(dwarf2_fetch_constant_bytes): Likewise.
	(follow_die_sig): Likewise.
	(get_signatured_type): Likewise.
	(get_DW_AT_signature_type): Likewise.
	(dwarf2_find_containing_comp_unit): Likewise.
	(set_die_type): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] GDB/testsuite: Fix a typo in $actual_line
@ 2018-02-23 20:31 sergiodj+buildbot
  2018-02-23 21:29 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-23 20:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 11b031457e89d5739922ddd0bc65c9d781b6db35 ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 11b031457e89d5739922ddd0bc65c9d781b6db35

GDB/testsuite: Fix a typo in $actual_line

Fix a commit 883fd55ab104 ("Record nested types") issue:

ERROR: tcl error sourcing .../gdb/testsuite/gdb.cp/nested-types.exp.
ERROR: can't read "actual_linejj": no such variable
    while executing
"append txt " definition: $actual_linejj""
    (procedure "cp_test_ptype_class" line 324)
    invoked from within
"cp_test_ptype_class $name "ptype $name (limit = $limit)" $key  $name $children"    (procedure "test_nested_limit" line 28)
    invoked from within
"test_nested_limit -1 false"
    (file ".../gdb/testsuite/gdb.cp/nested-types.exp" line 310)
    invoked from within
"source .../gdb/testsuite/gdb.cp/nested-types.exp"
    ("uplevel" body line 1)
    invoked from within
"uplevel #0 source .../gdb/testsuite/gdb.cp/nested-types.exp"
    invoked from within
"catch "uplevel #0 source $test_file_name""
testcase .../gdb/testsuite/gdb.cp/nested-types.exp completed in 9 seconds

caused by $actual_line having been accidentally referred to as
$actual_linejj in one place.

	gdb/testsuite/
	* lib/cp-support.exp (cp_test_ptype_class): Fix a typo in the
	name of a variable: $actual_linejj -> $actual_line.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove cleanups from check_fast_tracepoint_sals
@ 2018-02-24 17:19 sergiodj+buildbot
  2018-02-24 17:37 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-24 17:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 281d762b1a56317171e462666b98d50bfa31a08a ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 281d762b1a56317171e462666b98d50bfa31a08a

Remove cleanups from check_fast_tracepoint_sals

This changes the gdbarch fast_tracepoint_valid_at method to use a
std::string as its out parameter, and then updates all the uses.  This
allows removing a cleanup from breakpoint.c.

Regression tested by the buildbot.

ChangeLog
2018-02-24  Tom Tromey  <tom@tromey.com>

	* i386-tdep.c (i386_fast_tracepoint_valid_at): "msg" now a
	std::string.
	* gdbarch.sh (fast_tracepoint_valid_at): Change "msg" to a
	std::string*.
	* gdbarch.c: Rebuild.
	* gdbarch.h: Rebuild.
	* breakpoint.c (check_fast_tracepoint_sals): Use std::string.
	* arch-utils.h (default_fast_tracepoint_valid_at): Update.
	* arch-utils.c (default_fast_tracepoint_valid_at): "msg" now a
	std::string*.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove most cleanups from linux-thread-db.c
@ 2018-02-24 17:31 sergiodj+buildbot
  2018-02-24 20:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-24 17:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9b292f68805700c7ae46fc149231fdb79554bd17 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 9b292f68805700c7ae46fc149231fdb79554bd17

Remove most cleanups from linux-thread-db.c

This removes most (but not all) cleanups from linux-thread-db.c.
std::string and std::vector are used in place of manual memory
management.

The remaining cleanup in linux-thread-db.c uses
make_cleanup_free_char_ptr_vec, which requires a somewhat bigger
change.

Regression tested by the buildbot.

ChangeLog
2018-02-24  Tom Tromey  <tom@tromey.com>

	* linux-thread-db.c (try_thread_db_load_from_pdir_1)
	(try_thread_db_load_from_dir, thread_db_load_search): Use
	std::string.
	(info_auto_load_libthread_db_compare): Return bool.  Change
	argument types.
	(info_auto_load_libthread_db): Use std::vector, std::string.
	Remove cleanups.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix double space expected in cp_test_ptype_class
@ 2018-02-25 20:37 sergiodj+buildbot
  2018-02-25 20:49 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-25 20:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6f6d0c269ecdc11aca9166940534ec61b6dbc39d ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 6f6d0c269ecdc11aca9166940534ec61b6dbc39d

Fix double space expected in cp_test_ptype_class

I noticed some failures of some buildbot slaves, e.g.:

FAIL: gdb.cp/nested-types.exp: ptype S10 (limit = 1) // wrong nested type enum definition: enum S10::E10 {S10::A10, S10::B10, S10::C10};

The issue is that they have an older gcc (not c++11 by default?) that
doesn't emit the enum underlying type information.  When the
enum type is printed by ptype, it looks like this:

  enum S10::E10 {S10::A10, S10::B10, S10::C10};

instead of this on older gccs:

  enum S10::E10 : unsigned int {S10::A10, S10::B10, S10::C10};

The regex that matches this is in cp_test_ptype_class, and is

  enum $nested_name (: (unsigned )?int)? \{

If the "unsigned int" portion is not present, then it requires the
string to have two spaces between the enum name and opening bracket.
The fix is simply to move the trailing space inside the ? group.

gdb/testsuite/ChangeLog:

	* lib/cp-support.exp (cp_test_ptype_class): Move space inside
	parentheses.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PPC error/warning messages
@ 2018-02-25 23:25 sergiodj+buildbot
  2018-02-26  0:00 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-25 23:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cf97bcb0c3f33460e9cfa57a2890df1c38a497d7 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: cf97bcb0c3f33460e9cfa57a2890df1c38a497d7

PPC error/warning messages

The GNU coding standard says error messages should be of the form
  program:sourcefile:lineno: message
or
  program: message

and
"The string message should not begin with a capital letter when it
follows a program name and/or file name, because that isnt the
beginning of a sentence. (The sentence conceptually starts at the
beginning of the line.) Also, it should not end with a period."

This patch does that for ppc, and removes some British spelling.
I've also switched some error output from using the linker callback
einfo to _bfd_error_handler, due to improved compilation time
argument checking now done for the latter function.

bfd/
	* elf32-ppc.c: Standardize error/warning messages.  Use
	_bfd_error_handler rather than einfo when einfo features not used.
	* elf64-ppc.c: Likewise.
ld/
	* testsuite/ld-powerpc/attr-gnu-12-21.d: Update.
	* testsuite/ld-powerpc/attr-gnu-4-12.d: Update.
	* testsuite/ld-powerpc/attr-gnu-4-13.d: Update.
	* testsuite/ld-powerpc/attr-gnu-4-21.d: Update.
	* testsuite/ld-powerpc/attr-gnu-4-23.d: Update.
	* testsuite/ld-powerpc/attr-gnu-4-31.d: Update.
	* testsuite/ld-powerpc/attr-gnu-4-32.d: Update.
	* testsuite/ld-powerpc/attr-gnu-8-23.d: Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] unrecognized/unsupported reloc message
@ 2018-02-26  0:13 sergiodj+buildbot
  2018-02-26  2:14 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-26  0:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0aa13feeeb78fc9323bee329c4d91c30f25de121 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 0aa13feeeb78fc9323bee329c4d91c30f25de121

unrecognized/unsupported reloc message

It must get boring translating all the variants we have of
unrecognized/unsupported/invalid/unexpected reloc number.  This patch
cuts down on the number of variations.

	* aoutx.h, * coff-alpha.c, * coff-i860.c, * coff-m68k.c,
	* coff-mcore.c, * coff-ppc.c, * coff-rs6000.c, * coff-sh.c,
	* coff-tic4x.c, * coff-tic54x.c, * coff-tic80.c, * coff-w65.c,
	* elf-bfd.h, * elf-m10300.c, * elf.c, * elf32-avr.c, * elf32-bfin.c,
	* elf32-cr16.c, * elf32-cr16c.c, * elf32-cris.c, * elf32-crx.c,
	* elf32-d10v.c, * elf32-d30v.c, * elf32-dlx.c, * elf32-epiphany.c,
	* elf32-fr30.c, * elf32-frv.c, * elf32-i370.c, * elf32-i386.c,
	* elf32-i960.c, * elf32-ip2k.c, * elf32-iq2000.c, * elf32-lm32.c,
	* elf32-m32c.c, * elf32-m32r.c, * elf32-m68hc11.c, * elf32-m68hc12.c,
	* elf32-m68k.c, * elf32-mcore.c, * elf32-mep.c, * elf32-metag.c,
	* elf32-microblaze.c, * elf32-mips.c, * elf32-moxie.c,
	* elf32-msp430.c, * elf32-mt.c, * elf32-nds32.c, * elf32-or1k.c,
	* elf32-pj.c, * elf32-ppc.c, * elf32-rl78.c, * elf32-rx.c,
	* elf32-s390.c, * elf32-sh.c, * elf32-spu.c, * elf32-tic6x.c,
	* elf32-v850.c, * elf32-vax.c, * elf32-visium.c, * elf32-wasm32.c,
	* elf32-xgate.c, * elf32-xtensa.c, * elf64-alpha.c,
	* elf64-ia64-vms.c, * elf64-mips.c, * elf64-mmix.c,
	* elf64-ppc.c, * elf64-s390.c, * elf64-sparc.c, * elf64-x86-64.c,
	* elfn32-mips.c, * elfnn-aarch64.c, * elfnn-ia64.c,
	* elfnn-riscv.c, * elfxx-mips.c, * elfxx-riscv.c, * elfxx-riscv.h,
	* elfxx-sparc.c, * elfxx-sparc.h, * reloc.c: Standardize
	unrecognized/unsupported reloc message.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] ELF linker messages
@ 2018-02-26  0:14 sergiodj+buildbot
  2018-02-26  4:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-26  0:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9793eb77929a4ab2c0192d9bf5d3f8d20dd17394 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 9793eb77929a4ab2c0192d9bf5d3f8d20dd17394

ELF linker messages

This fixes a number of cases where we capitalized error messages or
printed a full-stop, and corrects "Dwarf" to "DWARF".

bfd/
	* dwarf2.c, * elf-attrs.c, * elf-eh-frame.c, * elf.c, * elf32-gen.c,
	* elflink.c: Standardize error/warning messages.  Replace use of
	linker callback einfo with _bfd_error_handler when possible.
ld/
	* testsuite/ld-elf/indirect.exp,
	* testsuite/ld-elf/pr22649-2ab-mips.msg,
	* testsuite/ld-elf/pr22649-2cd-mips.msg,
	* testsuite/ld-elf/pr22649.msg,
	* testsuite/ld-elf/tls_common.exp,
	* testsuite/ld-elfcomm/elfcomm.exp,
	* testsuite/ld-arm/attr-merge-incompatible.d,
	* testsuite/ld-tic6x/attr-compatibility-gnu-other.d,
	* testsuite/ld-tic6x/attr-compatibility-other-gnu.d,
	* testsuite/ld-tic6x/attr-compatibility-other-other.d,
	* testsuite/ld-i386/warn1.d: Update expected error/warning messages.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] MIPS messages
@ 2018-02-26  0:38 sergiodj+buildbot
  2018-02-26  6:22 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-26  0:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2c1c96795601a19554fa3a86700a1b9e9d57c931 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 2c1c96795601a19554fa3a86700a1b9e9d57c931

MIPS messages

More standardization of messages.

bfd/
	* elfxx-mips.c: Standardize error/warning messages.
binutils/
	* testsuite/binutils-all/mips/mips-reginfo-n32.d,
	* testsuite/binutils-all/mips/mips-reginfo.d: Update.
gas/
	* testsuite/gas/mips/reginfo-2.l: Update.
ld/
	* testsuite/ld-mips-elf/attr-gnu-4-12.d,
	* testsuite/ld-mips-elf/attr-gnu-4-13.d,
	* testsuite/ld-mips-elf/attr-gnu-4-14.d,
	* testsuite/ld-mips-elf/attr-gnu-4-16.d,
	* testsuite/ld-mips-elf/attr-gnu-4-17.d,
	* testsuite/ld-mips-elf/attr-gnu-4-18.d,
	* testsuite/ld-mips-elf/attr-gnu-4-19.d,
	* testsuite/ld-mips-elf/attr-gnu-4-21.d,
	* testsuite/ld-mips-elf/attr-gnu-4-23.d,
	* testsuite/ld-mips-elf/attr-gnu-4-24.d,
	* testsuite/ld-mips-elf/attr-gnu-4-25.d,
	* testsuite/ld-mips-elf/attr-gnu-4-26.d,
	* testsuite/ld-mips-elf/attr-gnu-4-27.d,
	* testsuite/ld-mips-elf/attr-gnu-4-28.d,
	* testsuite/ld-mips-elf/attr-gnu-4-29.d,
	* testsuite/ld-mips-elf/attr-gnu-4-31.d,
	* testsuite/ld-mips-elf/attr-gnu-4-32.d,
	* testsuite/ld-mips-elf/attr-gnu-4-34.d,
	* testsuite/ld-mips-elf/attr-gnu-4-35.d,
	* testsuite/ld-mips-elf/attr-gnu-4-36.d,
	* testsuite/ld-mips-elf/attr-gnu-4-37.d,
	* testsuite/ld-mips-elf/attr-gnu-4-38.d,
	* testsuite/ld-mips-elf/attr-gnu-4-39.d,
	* testsuite/ld-mips-elf/attr-gnu-4-41.d,
	* testsuite/ld-mips-elf/attr-gnu-4-42.d,
	* testsuite/ld-mips-elf/attr-gnu-4-43.d,
	* testsuite/ld-mips-elf/attr-gnu-4-45.d,
	* testsuite/ld-mips-elf/attr-gnu-4-46.d,
	* testsuite/ld-mips-elf/attr-gnu-4-47.d,
	* testsuite/ld-mips-elf/attr-gnu-4-48.d,
	* testsuite/ld-mips-elf/attr-gnu-4-49.d,
	* testsuite/ld-mips-elf/attr-gnu-4-52.d,
	* testsuite/ld-mips-elf/attr-gnu-4-53.d,
	* testsuite/ld-mips-elf/attr-gnu-4-54.d,
	* testsuite/ld-mips-elf/attr-gnu-4-58.d,
	* testsuite/ld-mips-elf/attr-gnu-4-59.d,
	* testsuite/ld-mips-elf/attr-gnu-4-61.d,
	* testsuite/ld-mips-elf/attr-gnu-4-62.d,
	* testsuite/ld-mips-elf/attr-gnu-4-63.d,
	* testsuite/ld-mips-elf/attr-gnu-4-64.d,
	* testsuite/ld-mips-elf/attr-gnu-4-68.d,
	* testsuite/ld-mips-elf/attr-gnu-4-69.d,
	* testsuite/ld-mips-elf/attr-gnu-4-71.d,
	* testsuite/ld-mips-elf/attr-gnu-4-72.d,
	* testsuite/ld-mips-elf/attr-gnu-4-73.d,
	* testsuite/ld-mips-elf/attr-gnu-4-74.d,
	* testsuite/ld-mips-elf/attr-gnu-4-78.d,
	* testsuite/ld-mips-elf/attr-gnu-4-79.d,
	* testsuite/ld-mips-elf/attr-gnu-4-81.d,
	* testsuite/ld-mips-elf/attr-gnu-4-89.d,
	* testsuite/ld-mips-elf/attr-gnu-8-12.d,
	* testsuite/ld-mips-elf/attr-gnu-8-21.d,
	* testsuite/ld-mips-elf/bal-jalx-pic-micromips-n32.d,
	* testsuite/ld-mips-elf/bal-jalx-pic-micromips-n64.d,
	* testsuite/ld-mips-elf/bal-jalx-pic-micromips.d,
	* testsuite/ld-mips-elf/bal-jalx-pic-n32.d,
	* testsuite/ld-mips-elf/bal-jalx-pic-n64.d,
	* testsuite/ld-mips-elf/bal-jalx-pic.d,
	* testsuite/ld-mips-elf/mode-change-error-1.d,
	* testsuite/ld-mips-elf/unaligned-branch-2.d,
	* testsuite/ld-mips-elf/unaligned-branch-ignore-2.d,
	* testsuite/ld-mips-elf/unaligned-branch-ignore-micromips.d,
	* testsuite/ld-mips-elf/unaligned-branch-ignore-mips16.d,
	* testsuite/ld-mips-elf/unaligned-branch-ignore-r6-1.d,
	* testsuite/ld-mips-elf/unaligned-branch-micromips.d,
	* testsuite/ld-mips-elf/unaligned-branch-mips16.d,
	* testsuite/ld-mips-elf/unaligned-branch-r6-1.d,
	* testsuite/ld-mips-elf/unaligned-branch-r6-2.d,
	* testsuite/ld-mips-elf/unaligned-branch.d,
	* testsuite/ld-mips-elf/unaligned-jalx-1.d,
	* testsuite/ld-mips-elf/unaligned-jalx-3.d,
	* testsuite/ld-mips-elf/unaligned-jalx-addend-1.d,
	* testsuite/ld-mips-elf/unaligned-jalx-addend-3.d,
	* testsuite/ld-mips-elf/unaligned-jalx-addend-micromips-1.d,
	* testsuite/ld-mips-elf/unaligned-jalx-addend-mips16-1.d,
	* testsuite/ld-mips-elf/unaligned-jalx-micromips-1.d,
	* testsuite/ld-mips-elf/unaligned-jalx-mips16-1.d,
	* testsuite/ld-mips-elf/unaligned-jump-micromips.d,
	* testsuite/ld-mips-elf/unaligned-jump-mips16.d,
	* testsuite/ld-mips-elf/unaligned-jump.d: Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] ARM and AArch64 messages
@ 2018-02-26  0:53 sergiodj+buildbot
  2018-02-26  8:15 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-26  0:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 90b6238f06197c2abff953ab5920ae5b6d39f97f ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 90b6238f06197c2abff953ab5920ae5b6d39f97f

ARM and AArch64 messages

More standarization of error/warning messages.  The ARM backend has
some multi-line error messages, which don't fit particularly well with
the GNU coding standard insistence that error messages shouldn't be
capitalized or have a full-stop.  I've replaced the line breaks with
semicolons.

So for instance the following
  system/path/to/ld: myobject.o: invalid special symbol `foo'.
  system/path/to/ld: It must be a global or weak function symbol.
becomes
  system/path/to/ld: myobject.o: invalid special symbol `foo'; it must be a global or weak function symbol

bfd/
	* elf32-arm.c, * elfnn-aarch64.c: Standardize error/warning messages.
ld/
	* testsuite/ld-aarch64/reloc-overflow-bad.d,
	* testsuite/ld-arm/attr-merge-9.out,
	* testsuite/ld-arm/attr-merge-arch-2.d,
	* testsuite/ld-arm/attr-merge-unknown-1.d,
	* testsuite/ld-arm/attr-merge-unknown-2.d,
	* testsuite/ld-arm/attr-merge-unknown-2r.d,
	* testsuite/ld-arm/attr-merge-unknown-3.d,
	* testsuite/ld-arm/cmse-implib-errors.out,
	* testsuite/ld-arm/cmse-new-earlier-later-implib.out,
	* testsuite/ld-arm/cmse-new-implib-no-output.out,
	* testsuite/ld-arm/cmse-new-implib-not-sg-in-implib.out,
	* testsuite/ld-arm/cmse-new-implib.out,
	* testsuite/ld-arm/cmse-new-wrong-implib.out,
	* testsuite/ld-arm/cmse-veneers-no-gnu_sgstubs.out,
	* testsuite/ld-arm/cmse-veneers-wrong-entryfct.out,
	* testsuite/ld-arm/group-relocs-alu-bad-2.d,
	* testsuite/ld-arm/group-relocs-alu-bad.d,
	* testsuite/ld-arm/group-relocs-ldc-bad-2.d,
	* testsuite/ld-arm/group-relocs-ldc-bad.d,
	* testsuite/ld-arm/group-relocs-ldr-bad-2.d,
	* testsuite/ld-arm/group-relocs-ldr-bad.d,
	* testsuite/ld-arm/group-relocs-ldrs-bad-2.d,
	* testsuite/ld-arm/group-relocs-ldrs-bad.d,
	* testsuite/ld-arm/stm32l4xx-cannot-fix-far-ldm.d: Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] AOUT/COFF/PE messages
@ 2018-02-26  1:03 sergiodj+buildbot
  2018-02-26 10:36 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-26  1:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 59d08d6ce8cb6c41691266e133304c961c270e85 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 59d08d6ce8cb6c41691266e133304c961c270e85

AOUT/COFF/PE messages

Capitalization, full-stops and unnecessary trailing \n fixes.

	* aout-adobe.c, * aout-cris.c, * i386linux.c, * m68klinux.c,
	* sparclinux.c, * coff-alpha.c, * coff-arm.c, * coff-mcore.c,
	* coffcode.h, * coffgen.c, * cofflink.c, * ecoff.c, * pe-mips.c,
	* peXXigen.c, * peicode.h: Standardize error/warning messages.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] BFD messages
@ 2018-02-26  1:16 sergiodj+buildbot
  2018-02-26 13:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-26  1:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6e05870c978aaa057b5ae0f525a2e9b803047ac8 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 6e05870c978aaa057b5ae0f525a2e9b803047ac8

BFD messages

bfd/
	* archive.c, * bfd.c, * linker.c, * reloc.c, * stabs.c,
	* syms.c: Standardize error/warning messages.
binutils/
	* testsuite/binutils-all/mips/mips-reginfo-n32.d,
	* testsuite/binutils-all/mips/mips-reginfo.d: Update.
gas/
	* testsuite/gas/mips/reginfo-2.l: Update.
ld/
	* testsuite/ld-arm/cmse-implib-errors.out,
	* testsuite/ld-arm/cmse-new-earlier-later-implib.out,
	* testsuite/ld-arm/cmse-new-implib-not-sg-in-implib.out,
	* testsuite/ld-arm/cmse-new-wrong-implib.out,
	* testsuite/ld-arm/cmse-veneers-no-gnu_sgstubs.out,
	* testsuite/ld-arm/cmse-veneers-wrong-entryfct.out,
	* testsuite/ld-cris/badgotr1.d,
	* testsuite/ld-cris/tls-err-24.d,
	* testsuite/ld-cris/tls-err-25.d,
	* testsuite/ld-cris/tls-err-26.d,
	* testsuite/ld-cris/tls-err-27.d,
	* testsuite/ld-cris/tls-err-28.d,
	* testsuite/ld-cris/tls-err-40.d,
	* testsuite/ld-cris/tls-err-44.d,
	* testsuite/ld-cris/tls-err-48.d,
	* testsuite/ld-cris/tls-err-52.d,
	* testsuite/ld-cris/tls-err-53.d,
	* testsuite/ld-cris/tls-err-55.d,
	* testsuite/ld-cris/tls-err-56.d,
	* testsuite/ld-cris/tls-err-62.d,
	* testsuite/ld-cris/tls-err-65.d,
	* testsuite/ld-cris/tls-err-77.d,
	* testsuite/ld-elf/empty-implib.out,
	* testsuite/ld-elf/indirect.exp: Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] assorted target messages
@ 2018-02-26  1:28 sergiodj+buildbot
  2018-02-26 15:15 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-26  1:28 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 38f14ab8fcfa4eab8bab417a5a165b7403ef9b0e ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 38f14ab8fcfa4eab8bab417a5a165b7403ef9b0e

assorted target messages

bfd/
	* elf-m10300.c, * elf-s390-common.c, * elf32-arc.c, * elf32-cris.c,
	* elf32-dlx.c, * elf32-frv.c, * elf32-i370.c, * elf32-lm32.c,
	* elf32-m32r.c, * elf32-m68hc1x.c, * elf32-m68k.c,
	* elf32-microblaze.c, * elf32-msp430.c, * elf32-nds32.c,
	* elf32-nios2.c, * elf32-or1k.c, * elf32-rl78.c, * elf32-rx.c,
	* elf32-score.c, * elf32-score7.c, * elf32-sh-symbian.c,
	* elf32-sh.c, * elf32-spu.c, * elf32-v850.c, * elf32-xtensa.c,
	* elf64-alpha.c, * elf64-ia64-vms.c, * elf64-mmix.c,
	* elf64-sh64.c, * elf64-sparc.c, * elfnn-ia64.c, * elfxx-tilegx.c,
	* mmo.c, * osf-core.c, * srec.c, * vms-alpha.c: Standardize
	error/warning messages.
ld/
	* testsuite/ld-cris/pcrelcp-1.d,
	* testsuite/ld-mmix/start-2.d: Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] crx string overflow warning
@ 2018-02-26  1:40 sergiodj+buildbot
  2018-02-26 17:11 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-26  1:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e95b887f85a192eb1597cd5d358673520029ad14 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: e95b887f85a192eb1597cd5d358673520029ad14

crx string overflow warning

gcc8 complains wrongly about the buffer not being large enough, at
least at -Og optimization.

	* crx-dis.c (getregliststring): Allocate a large enough buffer
	to silence false positive gcc8 warning.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Segfault on phdrs allocated but not created
@ 2018-02-26  1:53 sergiodj+buildbot
  2018-02-26 19:54 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-26  1:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6838f2bed6459514c1b0c549e6aa3fc7dbb1d7ec ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 6838f2bed6459514c1b0c549e6aa3fc7dbb1d7ec

Segfault on phdrs allocated but not created

A number of ARM tests show results like:
ld-new: no address assigned to the veneers output section .gnu.sgstubs
ld-new: can not size stub section: invalid operation
ld-new: warning: cannot find entry symbol _start; defaulting to 0000000000010074
ld-new: tmpdir/cmse-veneers-no-gnu_sgstubs: warning: allocated section `.text' not in segment
Segmentation fault
PASS: Secure gateway veneers: no .gnu.sgstubs section

The PASS despite the segv shows the danger of using "#..." to match
error output.  This patch doesn't try to fix the testuite, but does
prevent the segfault.

	* elf.c (assign_file_positions_except_relocs): Don't segfault
	when actual number of phdrs is less than allocated.  Delete
	outdated comment.  Formatting.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Move arch/tdesc.h to common/tdesc.h
@ 2018-02-26 12:02 sergiodj+buildbot
  2018-02-26 22:15 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 12:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f46cd62a69b8050c7c30a53b29a781a9b5e9f062 ***

Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: f46cd62a69b8050c7c30a53b29a781a9b5e9f062

Move arch/tdesc.h to common/tdesc.h

gdb/
	* arch/amd64.h: Use common/tdesc.h.
	* arch/i386.c: Likewise.
	* arch/i386.h: Likewise.
	* arch/tic6x.c: Likewise.
	* arch/tdesc.h: Move file from here...
	* common/tdesc.h: ...to here.
	* features/aarch64-core.c: Regenerate.
	* features/aarch64-fpu.c: Regenerate.
	* features/i386/32bit-avx.c: Regenerate.
	* features/i386/32bit-avx512.c: Regenerate.
	* features/i386/32bit-core.c: Regenerate.
	* features/i386/32bit-linux.c: Regenerate.
	* features/i386/32bit-mpx.c: Regenerate.
	* features/i386/32bit-pkeys.c: Regenerate.
	* features/i386/32bit-sse.c: Regenerate.
	* features/i386/64bit-avx.c: Regenerate.
	* features/i386/64bit-avx512.c: Regenerate.
	* features/i386/64bit-core.c: Regenerate.
	* features/i386/64bit-linux.c: Regenerate.
	* features/i386/64bit-mpx.c: Regenerate.
	* features/i386/64bit-pkeys.c: Regenerate.
	* features/i386/64bit-segments.c: Regenerate.
	* features/i386/64bit-sse.c: Regenerate.
	* features/i386/x32-core.c: Regenerate.
	* features/tic6x-c6xp.c: Regenerate.
	* features/tic6x-core.c: Regenerate.
	* features/tic6x-gp.c: Regenerate.
	* target-descriptions.c: Use common/tdesc.h.
	* target-descriptions.h: Likewise.

gdbserver/
	* tdesc.c: Use common/tdesc.h.
	* tdesc.h: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Re-write partial_die_info allocation in load_partial_dies
@ 2018-02-26 15:54 sergiodj+buildbot
  2018-02-27  0:15 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 15:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cd9983dd5f16803aa60e9fe1692b7e6716ac3927 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: cd9983dd5f16803aa60e9fe1692b7e6716ac3927

Re-write partial_die_info allocation in load_partial_dies

load_partial_dies has a "while (1)" loop to visit each die, and create
partial_die_info if needed in each iteration, like this,

  part_die = XOBNEW (&cu->comp_unit_obstack, struct partial_die_info);

  while (1)
   {
      if (foo1) continue;

      if (foo2) continue;

      read_partial_die (, , part_die, ,);

      ....
      part_die = XOBNEW (&cu->comp_unit_obstack, struct partial_die_info);
   };

the code was written in a way that spaces are allocated on necessary on
cu->comp_unit_obstack.  I want to class-fy partial_die_info, but
partial_die_info ctor can't follow XOBNEW immediately, so this patch
rewrite this loop to:

  while (1)
   {
      if (foo1) continue;

      if (foo2) continue;

      struct partial_die_info pdi;
      read_partial_die (, , &pdi, ,);

      part_die = XOBNEW (&cu->comp_unit_obstack, struct partial_die_info);
      memcpy (part_die, &pdi, sizeof (pdi));
   };

we create a local variable pdi, if we need it, call XOBNEW, and copy.
This also reduce one XOBNEW call.  I measured the number of XOBNEW call in
load_partial_dies when gdb reads dwarf2read.o, without this patch, it is
18827, and with this patch, it is 18826.

gdb:

2018-026-26  Yao Qi  <yao.qi@linaro.org>

	* dwarf2read.c (load_partial_dies): Move the location of XOBNEW.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Class-fy partial_die_info
@ 2018-02-26 16:32 sergiodj+buildbot
  2018-02-27  6:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 16:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6f06d47ba0965013203af25c17854c01caae5544 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 6f06d47ba0965013203af25c17854c01caae5544

Class-fy partial_die_info

This patch is to class-fy partial_die_info.  Two things special here,

 - disable assignment operator, but keep copy ctor, which is used in
   load_partial_dies,
 - have a private ctor which is only used by dwarf2_cu::find_partial_die,
   I don't want other code use it, so make it private,

gdb:

2018-02-26  Yao Qi  <yao.qi@linaro.org>

	* dwarf2read.c (struct partial_die_info): Add ctor, delete
	assignment operator.
	(load_partial_dies): Use ctor and copy ctor.
	(read_partial_die): Update.
	(dwarf2_cu::find_partial_die): Use ctor.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Don't check abbrev is NULL in read_partial_die
@ 2018-02-26 16:36 sergiodj+buildbot
  2018-02-27  2:11 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 16:36 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fd0a254f815b133c67230c50dd84eb0d4b31a93d ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: fd0a254f815b133c67230c50dd84eb0d4b31a93d

Don't check abbrev is NULL in read_partial_die

'abbrev' won't be NULL, so don't check it.

gdb:

2018-02-26  Yao Qi  <yao.qi@linaro.org>

	* dwarf2read.c (read_partial_die): Remove the code checking abbrev
	is NULL.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Initial support for variant parts
@ 2018-02-26 17:16 sergiodj+buildbot
  2018-02-27 14:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 17:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7c22600aabfd10e190e98fff0b7c2d69cd191325 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 7c22600aabfd10e190e98fff0b7c2d69cd191325

Initial support for variant parts

This adds some initial support for variant parts to gdbtypes.h.  A
variant part is represented as a union.  The union has a flag
indicating that it has a discriminant, and information about the
discriminant is attached using the dynamic property system.

2018-02-26  Tom Tromey  <tom@tromey.com>

	* value.h (value_union_variant): Declare.
	* valops.c (value_union_variant): New function.
	* gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): New macro.
	(struct discriminant_info): New.
	(enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: New
	enumerator.
	(struct main_type) <flag_discriminated_union>: New field.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Change find_partial_die_in_comp_unit to dwarf2_cu::find_partial_die
@ 2018-02-26 17:35 sergiodj+buildbot
  2018-02-27  4:11 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 17:35 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d590ff257c81d5aac51928148ce74b0131bbf81c ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: d590ff257c81d5aac51928148ce74b0131bbf81c

Change find_partial_die_in_comp_unit to dwarf2_cu::find_partial_die

This patch changes find_partial_die_in_comp_unit to a dwarf2_cu method
find_partial_die.

gdb:

2018-02-26  Yao Qi  <yao.qi@linaro.org>

	* dwarf2read.c (struct dwarf2_cu) <find_partial_die>: New method.
	(find_partial_die_in_comp_unit): Change it to
	dwarf2_cu::find_partial_die.
	(find_partial_die): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Make "bt N" print correct number of frames when using a frame filter
@ 2018-02-26 17:54 sergiodj+buildbot
  2018-02-27 20:39 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 17:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6893c19a8b81a399953edbf26aaef6e714a7ab0e ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 6893c19a8b81a399953edbf26aaef6e714a7ab0e

Make "bt N" print correct number of frames when using a frame filter

PR python/16497 notes that using "bt" with a positive argument prints
the wrong number of frames when a frame filter is in use.  Also, in this
case, the non-frame-filter path will print a message about "More stack
frames" when there are more; but this is not done in the frame-filter
case.

The first problem is that backtrace_command_1 passes the wrong value
to apply_ext_lang_frame_filter -- that function takes the final
frame's number as an argument, but backtrace_command_1 passes the
count, which is off by one.

The solution to the second problem is to have the C stack-printing
code stop at the correct number of frames and then print the message.

Tested using the buildbot.

ChangeLog
2018-02-26  Tom Tromey  <tom@tromey.com>

	PR python/16497:
	* stack.c (backtrace_command_1): Set PRINT_MORE_FRAMES flag.  Fix
	off-by-one in py_end computation.
	* python/py-framefilter.c (gdbpy_apply_frame_filter): Handle
	PRINT_MORE_FRAMES.
	* extension.h (enum frame_filter_flags) <PRINT_MORE_FRAMES>: New
	constant.

2018-02-26  Tom Tromey  <tom@tromey.com>

	PR python/16497:
	* gdb.python/py-framefilter.exp: Update test.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Change frame_filter_flags to use DEF_ENUM_FLAGS_TYPE
@ 2018-02-26 18:06 sergiodj+buildbot
  2018-02-27 22:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 18:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d4dd32824a1194718c81773804017ab546cb3aab ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: d4dd32824a1194718c81773804017ab546cb3aab

Change frame_filter_flags to use DEF_ENUM_FLAGS_TYPE

This changes frame_filter_flags to use DEF_ENUM_FLAGS_TYPE, and
updates all the uses.  It also changes the enum constants to use <<,
as suggested by Sergio.

ChangeLog
2018-02-26  Tom Tromey  <tom@tromey.com>

	* stack.c (backtrace_command_1): Update.
	* python/python-internal.h (gdbpy_apply_frame_filter): Change type
	of "flags".
	* python/py-framefilter.c (py_print_frame)
	(gdbpy_apply_frame_filter): Change type of "flags".
	* mi/mi-cmd-stack.c (mi_apply_ext_lang_frame_filter): Change type
	of "flags".
	(mi_cmd_stack_list_frames, mi_cmd_stack_list_locals)
	(mi_cmd_stack_list_args, mi_cmd_stack_list_variables): Update.
	* extension.h (enum frame_filter_flag): Rename from
	frame_filter_flags.
	(frame_filter_flags): Define using DEF_ENUM_FLAGS_TYPE.
	(apply_ext_lang_frame_filter): Change type of "flags".
	* extension.c (apply_ext_lang_frame_filter): Change type of
	"flags".
	* extension-priv.h (struct extension_language_ops)
	<apply_frame_filter>: Change type of "flags".


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Move read_partial_die to partial_die_info::read
@ 2018-02-26 18:41 sergiodj+buildbot
  2018-02-27  9:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 18:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 48fbe735fb8f0e65976d2b9dd345bf2f947ad258 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 48fbe735fb8f0e65976d2b9dd345bf2f947ad258

Move read_partial_die to partial_die_info::read

gdb:

2018-02-26  Yao Qi  <yao.qi@linaro.org>

	* dwarf2read.c (struct partial_die_info) <read>: New method.
	(read_partial_die): Remove the declaration.
	(load_partial_dies): Update.
	(partial_die_info::partial_die_info):
	(read_partial_die): Change it to partial_die_info::read.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] MIPS: Reorder ABI determination ahead of target description loading
@ 2018-02-26 19:59 sergiodj+buildbot
  2018-02-28  0:55 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 19:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 37c33887bda54afb8fbf4786d400ce549c0e3de8 ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 37c33887bda54afb8fbf4786d400ce549c0e3de8

MIPS: Reorder ABI determination ahead of target description loading

Move ABI determination code ahead of target description loading so that
architecture information can be adjusted according to the ABI selected,
and then used in OS dependent register information initialization needed
for target description processing.  No functional change.

	gdb/
	* gdb/mips-tdep.c (mips_gdbarch_init): Reorder ABI determination
	ahead of target description loading.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] MIPS: Don't use a 32-bit BFD architecture with a 64-bit ABI
@ 2018-02-26 20:30 sergiodj+buildbot
  2018-02-28  2:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 20:30 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c5196c9298b7df29652c0ebe24a43ac6c9c76b0d ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: c5196c9298b7df29652c0ebe24a43ac6c9c76b0d

MIPS: Don't use a 32-bit BFD architecture with a 64-bit ABI

Select `bfd_mach_mips4000', which corresponds to the MIPS III ISA, the
earlies with 64-bit support, whenever a 32-bit BFD architecture has been
chosen to use with a 64-bit ABI.  The situation can happen in a few
cases:

1. When the user has used `set architecture' or `set mips abi' commands
   to override automatic selection and then starts a debug session by
   requesting to run, attach or connect to a target.

2. In native debugging when reattaching to a previously debugged process
   where the program to be debugged has been since discarded, as
   observed with:

FAIL: gdb.base/attach.exp: attach2, with no file (GDB internal error)

   in n32 and n64 regression testing.

3. In remote debugging with a non-XML debug stub when discarding the
   program to be debugged while connected to the remote target, as
   observed with:

FAIL: gdb.base/break-unload-file.exp: cmdline: always-inserted on: break: file (GDB internal error)

   in n32 and n64 regression testing.

In the latter two cases the ABI, quite rightfully, is retained while the
program to be debugged is discarded.  This is because in that case the
ABI previously determined is carried over along with `gdbarch' in use,
which is retained.  The BFD architecture is however discarded and the
default then applies, because it is not attached to `gdbarch'.

In all these cases we trip with an internal error message as follows:

.../gdb/mips-tdep.c:766: internal-error: bad register size
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Quit this debugging session? (y or n) n

This is a bug, please report it.  For instructions, see:
<http://www.gnu.org/software/gdb/bugs/>.

coming from `mips_pseudo_register_read', because the raw register width
inferred from the BFD architecture turns out to be 4 for the general
registers while the cooked register width inferred from the ABI in
effect is 8.

We do not hit this internal error in remote debugging with an XML debug
stub, because in that case raw register width information is passed by
the stub along with the XML target description.

Ultimately I think we ought to make the BFD architecture sticky like the
ABI, however in the interim this simple fix will do, removing the error
across all three cases.  The case where the user has used `set mips abi'
or `set architecture' commands has to be handled anyway, and although a
more sophisticated solution could be envisaged, such as reporting an
error with the respective `set' command, I think this is too much of a
corner case to bother.

	gdb/
	* mips-tdep.c (mips_gdbarch_init): Don't use a 32-bit BFD
	architecture with a 64-bit ABI.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Convert Rust to use discriminated unions
@ 2018-02-26 21:31 sergiodj+buildbot
  2018-02-27 16:05 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 21:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c9317f214b274b805190b8e878c79f4181d93bb4 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: c9317f214b274b805190b8e878c79f4181d93bb4

Convert Rust to use discriminated unions

A Rust enum is, essentially, a discriminated union.  Currently the
Rust language support handles Rust enums locally, in rust-lang.c.
However, because I am changing the Rust compiler to use
DW_TAG_variant* to represent enums, it seemed better to have a single
internal representation for Rust enums in gdb.

This patch implements this idea by moving the current Rust enum
handling code to dwarf2read.  This allows the simplification of some
parts of rust-lang.c as well.

2018-02-26  Tom Tromey  <tom@tromey.com>

	* rust-lang.h (rust_last_path_segment): Declare.
	* rust-lang.c (rust_last_path_segment): Now public.  Change
	contract.
	(struct disr_info): Remove.
	(RUST_ENUM_PREFIX, RUST_ENCODED_ENUM_REAL)
	(RUST_ENCODED_ENUM_HIDDEN, rust_union_is_untagged)
	(rust_get_disr_info, rust_tuple_variant_type_p): Remove.
	(rust_enum_p, rust_enum_variant): New function.
	(rust_underscore_fields): Remove "offset" parameter.
	(rust_print_enum): New function.
	(rust_val_print) <TYPE_CODE_UNION>: Remove enum code.
	<TYPE_CODE_STRUCT>: Call rust_print_enum when appropriate.
	(rust_print_struct_def): Add "for_rust_enum" parameter.  Handle
	enums.
	(rust_internal_print_type): New function, from rust_print_type.
	Remove enum code.
	(rust_print_type): Call rust_internal_print_type.
	(rust_evaluate_subexp) <STRUCTOP_ANONYMOUS, STRUCTOP_STRUCT>:
	Update enum handling.
	* dwarf2read.c (struct dwarf2_cu) <rust_unions>: New field.
	(rust_fully_qualify, alloc_discriminant_info, quirk_rust_enum)
	(rust_union_quirks): New functions.
	(process_full_comp_unit, process_full_type_unit): Call
	rust_union_quirks.
	(process_structure_scope): Update rust_unions if necessary.

2018-02-26  Tom Tromey  <tom@tromey.com>

	* gdb.rust/simple.exp: Accept more possible results in enum test.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] IA-64: Fix linker error with --no-keep-memory.
@ 2018-02-26 22:19 sergiodj+buildbot
  2018-02-28  6:05 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 22:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6f6372fadcfffc89ef511d51323678f88624be5c ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 6f6372fadcfffc89ef511d51323678f88624be5c

IA-64: Fix linker error with --no-keep-memory.

	bfd/
	PR 15904
	* elfnn-ia64.c (elfNN_ia64_relax_section): After ia64_elf_relax_brl
	call, set changed_contents and changed_relocs.  Likewise after
	successful ia64_elf_relax_br call.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Handle DW_TAG_variant_part and DW_TAG_variant
@ 2018-02-27  0:14 sergiodj+buildbot
  2018-02-27 18:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-27  0:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2ddeaf8a7d64094f4caf6cdc412d8162f49f73a1 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 2ddeaf8a7d64094f4caf6cdc412d8162f49f73a1

Handle DW_TAG_variant_part and DW_TAG_variant

This changes dwarf2read to understand DW_TAG_variant_part and
DW_TAG_variant.

Note that DW_AT_discr_list is not handled.  I did not need this for
Rust.  I imagine this should not be too hard to add later, should
someone need it.  Meanwhile I have gdb emit a complaint if it is seen.

There is a lurking issue concerning the placement of the discriminant
in the DWARF.  For Rust, I ended up following the letter of the
standard and having the discriminant be a child of the
DW_TAG_variant_part.  However, GCC's Ada support does not do this.
Pierre-Marie filed this with the DWARF committee:

    http://dwarfstd.org/ShowIssue.php?issue=180123.1

However as that is read-only, if you have comments you might consider
adding them to the GCC bug:

    https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83935

Finally, there is a DWARF extension lurking in here.  In Rust, a
univariant enum will not have a discriminant.  However, in order to
unify the representation of all data-carrying enums, I've made LLVM
(and my forthcoming rustc patch) emit a univariant enum using a
DW_TAG_variant with a single variant part and without DW_AT_discr.
The lack of this DW_AT_discr is the extension.  I will submit an issue
on dwarfstd.org about this.

2018-02-26  Tom Tromey  <tom@tromey.com>

	* dwarf2read.c (struct variant_field): New.
	(struct nextfield) <variant>: New field.
	(dwarf2_add_field): Handle DW_TAG_variant_part.
	(dwarf2_attach_fields_to_type): Attach a discriminant_info to a
	discriminated union.
	(read_structure_type): Handle DW_TAG_variant_part.
	(handle_struct_member_die): New function, extracted from
	process_structure_scope.  Handle DW_TAG_variant.
	(process_structure_scope): Handle discriminated unions.  Call
	handle_struct_member_die.

2018-02-26  Tom Tromey  <tom@tromey.com>

	* gdb.dwarf2/variant.c: New file.
	* gdb.dwarf2/variant.exp: New file.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add test for load command
@ 2018-02-27  0:40 sergiodj+buildbot
  2018-02-28  3:29 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-27  0:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3275ef477498e0500d7ea440f1bc51787acf4610 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 3275ef477498e0500d7ea440f1bc51787acf4610

Add test for load command

There doesn't seem to by any test for the load command.  I suggest to
add this test, so that we can have a minimum of confidence we don't
break it completely while refactoring the code that implements it.

gdb/testsuite/ChangeLog:

	* gdb.base/load-command.c: New file.
	* gdb.base/load-command.exp: New file.
	* lib/gdb.exp (gdb_is_target_remote_prompt): Rename to...
	(gdb_is_target_1): ...this, and generalize for other targets
	than just remote.
	(gdb_is_target_remote): Use gdb_is_target_1.
	(gdb_is_target_native): use gdb_is_target_1.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Have info_to_howto functions return a success/fail status. Check this result. Stop strip from completeing if one of these functions fails.
@ 2018-02-27 10:41 sergiodj+buildbot
  2018-02-28  7:22 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-27 10:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f3185997ac0951edac802e29df03dfc0844fda34 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: f3185997ac0951edac802e29df03dfc0844fda34

Have info_to_howto functions return a success/fail status.  Check this result.  Stop strip from completeing if one of these functions fails.

bfd	PR 22875
	* elf-bfd.h (struct elf_backend_data): Change the return type of
	the elf_info_to_howto and elf_info_to_howto_rel function pointers
	to bfd_boolean.
	* elfcode.h (elf_slurp_reloc_table_from_section): Check the return value from the info_to_howto function and fail if that function failed.
	* elf32-h8300.c (elf32_h8_relocate_section): Check return value from the info_to_howto function.
	(elf32_h8_relax_section): Likewise.
	* elf32-lm32.c (lm32_elf_relocate_section): Likewise.
	* elf32-m68hc1x.c (elf32_m68hc11_relocate_section): Likewise.
	* elf32-score.c (s3_bfd_score_elf_relocate_section): Likewise.
	* elf32-score7.c (s7_bfd_score_elf_relocate_section): Likewise.
	* elf32-tic6x.c (elf32_tic6x_relocate_section): Likewise.
	* elf64-ia64-vms.c (elf64_ia64_relocate_section): Likewise.
	* elf64-sparc.c (elf64_sparc_slurp_one_reloc_table): Likewise.
	* elf64-x86-64.c (elf_x86_64_tls_transition): Likewise.
	* elfnn-ia64.c (elfNN_ia64_relocate_section): Likewise.
	* elfnn-riscv.c (riscv_elf_check_relocs): Likewise.
	(riscv_elf_relocate_section): Likewise.
	* elf-hppa.h (elf_hppa_info_to_howto): Change return type to
	bfd_boolean.  Issue an error message, set an error value and
	return FALSE if the reloc is not recognized.
	(elf_hppa_info_to_howto_rel): Likewise.
	* elf-m10200.c (mn10200_info_to_howto): Likewise.
	* elf-m10300.c (mn10300_info_to_howto): Likewise.
	* elf.c (_bfd_elf_no_info_to_howto): Likewise.
	* elf32-arc.c (arc_info_to_howto_rel): Likewise.
	* elf32-arm.c (elf32_arm_info_to_howto): Likewise.
	* elf32-avr.c (avr_info_to_howto_rela): Likewise.
	* elf32-bfin.c (bfin_info_to_howto): Likewise.
	* elf32-cr16.c (elf_cr16_info_to_howto): Likewise.
	* elf32-cr16c.c (elf_cr16c_info_to_howto): Likewise.
	* elf32-cris.c (elf_cr16c_info_to_howto_rel, cris_info_to_howto_rela): Likewise.
	* elf32-crx.c (elf_crx_info_to_howto): Likewise.
	* elf32-d10v.c (d10v_info_to_howto_rel): Likewise.
	* elf32-d30v.c (d30v_info_to_howto_rel, d30v_info_to_howto_rela): Likewise.
	* elf32-dlx.c (dlx_rtype_to_howto, elf32_dlx_info_to_howto, elf32_dlx_info_to_howto_rel): Likewise.
	* elf32-epiphany.c (epiphany_info_to_howto_rela): Likewise.
	* elf32-fr30.c (fr30_info_to_howto_rela): Likewise.
	* elf32-frv.c (frv_info_to_howto_rela, 	frvfdpic_info_to_howto_rel): Likewise.
	* elf32-ft32.c (ft32_info_to_howto_rela): Likewise.
	* elf32-gen.c (elf_generic_info_to_howto, elf_generic_info_to_howto_rel): Likewise.
	* elf32-h8300.c (elf32_h8_info_to_howto, elf32_h8_info_to_howto_rel): Likewise.
	* elf32-i370.c (i370_elf_info_to_howto): Likewise.
	* elf32-i386.c (elf_i386_reloc_type_lookup, elf_i386_rtype_to_howto, elf_i386_info_to_howto_rel): Likewise.
	* elf32-i860.c (lookup_howto, elf32_i860_info_to_howto_rela): Likewise.
	* elf32-i960.c (elf32_i960_info_to_howto_rel): Likewise.
	* elf32-ip2k.c (ip2k_info_to_howto_rela): Likewise.
	* elf32-iq2000.c (iq2000_info_to_howto_rela): Likewise.
	* elf32-lm32.c (lm32_info_to_howto_rela): Likewise.
	* elf32-m32c.c (m32c_info_to_howto_rela): Likewise.
	* elf32-m32r.c (m32r_info_to_howto_rel, m32r_info_to_howto): Likewise.
	* elf32-m68hc11.c (m68hc11_info_to_howto_rel): Likewise.
	* elf32-m68hc12.c (m68hc11_info_to_howto_rel): Likewise.
	* elf32-m68k.c (rtype_to_howto): Likewise.
	* elf32-mcore.c (mcore_elf_info_to_howto): Likewise.
	* elf32-mep.c (mep_info_to_howto_rela): Likewise.
	* elf32-metag.c (metag_info_to_howto_rela): Likewise.
	* elf32-microblaze.c (microblaze_elf_info_to_howto): Likewise.
	* elf32-mips.c (mips_info_to_howto_rel, mips_info_to_howto_rela): Likewise.
	* elf32-moxie.c (moxie_info_to_howto_rela): Likewise.
	* elf32-msp430.c (msp430_info_to_howto_rela): Likewise.
	* elf32-mt.c (mt_info_to_howto_rela): Likewise.
	* elf32-nds32.c (nds32_info_to_howto_rel, nds32_info_to_howto): Likewise.
	* elf32-nios2.c (nios2_elf32_info_to_howto): Likewise.
	* elf32-or1k.c (or1k_info_to_howto_rela): Likewise.
	* elf32-pj.c (pj_elf_info_to_howto): Likewise.
	* elf32-ppc.c (ppc_elf_info_to_howto): Likewise.
	* elf32-pru.c (pru_elf32_info_to_howto): Likewise.
	* elf32-rl78.c (rl78_info_to_howto_rela): Likewise.
	* elf32-rx.c (rx_info_to_howto_rela): Likewise.
	* elf32-s390.c (elf_s390_info_to_howto): Likewise.
	* elf32-score.c (s3_bfd_score_info_to_howto, _bfd_score_info_to_howto): Likewise.
	* elf32-score7.c (s7_bfd_score_info_to_howto): Likewise.
	* elf32-sh.c (sh_elf_info_to_howto): Likewise.
	* elf32-spu.c (spu_elf_info_to_howto): Likewise.
	* elf32-tic6x.c (elf32_tic6x_info_to_howto, elf32_tic6x_info_to_howto_rel): Likewise.
	* elf32-tilepro.c (tilepro_info_to_howto_rela): Likewise.
	* elf32-v850.c (v850_elf_info_to_howto_rel, v850_elf_info_to_howto_rela, v800_elf_info_to_howto): Likewise.
	* elf32-vax.c (rtype_to_howto): Likewise.
	* elf32-visium.c (visium_info_to_howto_rela): Likewise.
	* elf32-wasm32.c (elf32_wasm32_rtype_to_howto, elf32_wasm32_info_to_howto_rela): Likewise.
	* elf32-xc16x.c (elf32_xc16x_info_to_howto): Likewise.
	* elf32-xgate.c (xgate_info_to_howto_rel): Likewise.
	* elf32-xstormy16.c (xstormy16_info_to_howto_rela): Likewise.
	* elf32-xtensa.c (elf_xtensa_info_to_howto_rela): Likewise.
	* elf64-alpha.c (elf64_alpha_info_to_howto): Likewise.
	* elf64-gen.c (elf_generic_info_to_howto, elf_generic_info_to_howto_rel): Likewise.
	* elf64-ia64-vms.c (elf64_ia64_info_to_howto): Likewise.
	* elf64-mips.c (mips_elf64_info_to_howto_rela): Likewise.
	* elf64-mmix.c (mmix_info_to_howto_rela): Likewise.
	* elf64-ppc.c (ppc64_elf_info_to_howto): Likewise.
	* elf64-s390.c (elf_s390_reloc_type_lookup): Likewise.
	* elf64-sh64.c (elf_s390_info_to_howto, sh_elf64_info_to_howto): Likewise.
	* elf64-x86-64.c (elf_x86_64_info_to_howto): Likewise.
	* elfn32-mips.c (mips_info_to_howto_rel, mips_info_to_howto_rela): Likewise.
	* elfnn-aarch64.c (elfNN_aarch64_info_to_howto): Likewise.
	* elfnn-ia64.c (elfNN_ia64_info_to_howto): Likewise.
	* elfnn-riscv.c (riscv_info_to_howto_rela): Likewise.
	* elfxx-ia64.c (ia64_elf_reloc_type_lookup): Likewise.
	* elfxx-sparc.c (_bfd_sparc_elf_info_to_howto): Likewise.
	* elfxx-tilegx.c (tilegx_info_to_howto_rela): Likewise.
	* elf32-score.h (s7_bfd_score_info_to_howto): Update prototype.
	* elfxx-sparc.h (_bfd_sparc_elf_info_to_howto): Update prototype.
	* elfxx-tilegx.h (tilegx_info_to_howto_rela): Update prototype.
	* elfxx-target.h (elf_info_to_howto, elf_info_to_howto_rel): Default to NULL.

binutils PR 22875
	* objcopy.c (copy_object): Check the error status after marking symbols used in relocations.
	* testsuite/binutils-all/strip-13.s: New test source file.
	* testsuite/binutils-all/strip-13.s: New test driver file.
	* testsuite/binutils-all/objcopy.exp: Run the new test.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use standardized error message for unrecognized relocs.
@ 2018-02-27 12:32 sergiodj+buildbot
  2018-02-28  8:43 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-27 12:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e8f5af786c7665141f6644998b8c427ad466d474 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: e8f5af786c7665141f6644998b8c427ad466d474

Use standardized error message for unrecognized relocs.

bfd	* aout-cris.c (swap_ext_reloc_out): Standadize error/warning
	message.
	* elf-hppa.h (elf_hppa_info_to_howto_rel): Likewise.
	* elf32-i386.c (elf_i386_reloc_type_lookup): Likewise.
	* elf32-xtensa.c (elf_xtensa_reloc_type_lookup): Likewise.
	* elf64-ppc.c (ppc64_elf_reloc_type_lookup): Likewise.
	* elf64-s390.c (elf_s390_reloc_type_lookup): Likewise.
	* elf64-sh64.c (sh_elf64_info_to_howto): Likewise.
	* elfxx-ia64.c (ia64_elf_reloc_type_lookup): Likewise.
	* elfxx-sparc.c (_bfd_sparc_elf_reloc_type_lookup): Likewise.
	* elfxx-tilegx.c (tilegx_reloc_type_lookup): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: Add -O[2|s] assembler command-line options
@ 2018-02-27 16:36 sergiodj+buildbot
  2018-02-28 10:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-27 16:36 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b6f8c7c45229a8a5405079e586bfbaad396d2cbe ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: b6f8c7c45229a8a5405079e586bfbaad396d2cbe

x86: Add -O[2|s] assembler command-line options

On x86, some instructions have alternate shorter encodings:

1. When the upper 32 bits of destination registers of

andq $imm31, %r64
testq $imm31, %r64
xorq %r64, %r64
subq %r64, %r64

known to be zero, we can encode them without the REX_W bit:

andl $imm31, %r32
testl $imm31, %r32
xorl %r32, %r32
subl %r32, %r32

This optimization is enabled with -O, -O2 and -Os.
2. Since 0xb0 mov with 32-bit destination registers zero-extends 32-bit
immediate to 64-bit destination register, we can use it to encode 64-bit
mov with 32-bit immediates.  This optimization is enabled with -O, -O2
and -Os.
3. Since the upper bits of destination registers of VEX128 and EVEX128
instructions are extended to zero, if all bits of destination registers
of AVX256 or AVX512 instructions are zero, we can use VEX128 or EVEX128
encoding to encode AVX256 or AVX512 instructions.  When 2 source
registers are identical, AVX256 and AVX512 andn and xor instructions:

VOP %reg, %reg, %dest_reg

can be encoded with

VOP128 %reg, %reg, %dest_reg

This optimization is enabled with -O2 and -Os.
4. 16-bit, 32-bit and 64-bit register tests with immediate may be
encoded as 8-bit register test with immediate.  This optimization is
enabled with -Os.

This patch does:

1. Add {nooptimize} pseudo prefix to disable instruction size
optimization.
2. Add optimize to i386_opcode_modifier to tell assembler that encoding
of an instruction may be optimized.

gas/

	PR gas/22871
	* NEWS: Mention -O[2|s].
	* config/tc-i386.c (_i386_insn): Add no_optimize.
	(optimize): New.
	(optimize_for_space): Likewise.
	(fits_in_imm7): New function.
	(fits_in_imm31): Likewise.
	(optimize_encoding): Likewise.
	(md_assemble): Call optimize_encoding to optimize encoding.
	(parse_insn): Handle {nooptimize}.
	(md_shortopts): Append "O::".
	(md_parse_option): Handle -On.
	* doc/c-i386.texi: Document -O0, -O, -O1, -O2 and -Os as well
	as {nooptimize}.
	* testsuite/gas/cfi/cfi-x86_64.d: Pass -O0 to assembler.
	* testsuite/gas/i386/ilp32/cfi/cfi-x86_64.d: Likewise.
	* testsuite/gas/i386/i386.exp: Run optimize-1, optimize-2,
	optimize-3, x86-64-optimize-1, x86-64-optimize-2,
	x86-64-optimize-3 and x86-64-optimize-4.
	* testsuite/gas/i386/optimize-1.d: New file.
	* testsuite/gas/i386/optimize-1.s: Likewise.
	* testsuite/gas/i386/optimize-2.d: Likewise.
	* testsuite/gas/i386/optimize-2.s: Likewise.
	* testsuite/gas/i386/optimize-3.d: Likewise.
	* testsuite/gas/i386/optimize-3.s: Likewise.
	* testsuite/gas/i386/x86-64-optimize-1.s: Likewise.
	* testsuite/gas/i386/x86-64-optimize-1.d: Likewise.
	* testsuite/gas/i386/x86-64-optimize-2.d: Likewise.
	* testsuite/gas/i386/x86-64-optimize-2.s: Likewise.
	* testsuite/gas/i386/x86-64-optimize-3.d: Likewise.
	* testsuite/gas/i386/x86-64-optimize-3.s: Likewise.
	* testsuite/gas/i386/x86-64-optimize-4.d: Likewise.
	* testsuite/gas/i386/x86-64-optimize-4.s: Likewise.

opcodes/

	PR gas/22871
	* i386-gen.c (opcode_modifiers): Add Optimize.
	* i386-opc.h (Optimize): New enum.
	(i386_opcode_modifier): Add optimize.
	* i386-opc.tbl: Add "Optimize" to "mov $imm, reg",
	"sub reg, reg/mem", "test $imm, acc", "test $imm, reg/mem",
	"and $imm, acc", "and $imm, reg/mem", "xor reg, reg/mem",
	"movq $imm, reg" and AVX256 and AVX512 versions of vandnps,
	vandnpd, vpandn, vpandnd, vpandnq, vxorps, vxorpd, vpxor,
	vpxord and vpxorq.
	* i386-tbl.h: Regenerated.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Explicitly specify common tdesc.h for use with aarch64.h
@ 2018-02-27 16:46 sergiodj+buildbot
  2018-02-28 12:30 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-27 16:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0c305b6176408347afd8452abb8fe974a7e3f999 ***

Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: 0c305b6176408347afd8452abb8fe974a7e3f999

Explicitly specify common tdesc.h for use with aarch64.h

gdb/
	* arch/aarch64.h: Use common/tdesc.h.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [ARM] Remove ARM_FEATURE_COPY macro
@ 2018-02-27 16:59 sergiodj+buildbot
  2018-02-28 13:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-27 16:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5b616beff49ce5fe10c5efc2784b6b234bb8cb4f ***

Author: Thomas Preud'homme <thomas.preudhomme@arm.com>
Branch: master
Commit: 5b616beff49ce5fe10c5efc2784b6b234bb8cb4f

[ARM] Remove ARM_FEATURE_COPY macro

Among the macros to manipulate an arm_feature_set structure is the
ARM_FEATURE_COPY which copy the value of a feature set into another.
This can be achieved with a simple assignement which most of the
existing code does. This patch removes the last 2 uses of that macro and
remove the macro altogether.

2018-02-27  Thomas Preud'homme  <thomas.preudhomme@arm.com>

include/
	* opcode/arm.h (ARM_FEATURE_COPY): Remove macro definition.

2018-02-27  Thomas Preud'homme  <thomas.preudhomme@arm.com>

opcodes/
	* arm-dis.c (print_insn_coprocessor): Replace uses of ARM_FEATURE_COPY
	macro by assignements.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Change target_write_memory_blocks to use std::vector
@ 2018-02-27 19:20 sergiodj+buildbot
  2018-02-28 15:04 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-27 19:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 55089490f79ce1ddb9610fd6abeeaf896825fb71 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 55089490f79ce1ddb9610fd6abeeaf896825fb71

Change target_write_memory_blocks to use std::vector

This changes target_write_memory_blocks to use std::vector, rather
than VEC.  This allows the removal of some cleanups.

This version incorporates the additions that Simon made.

Regression tested by the buildbot.

ChangeLog
2018-02-27  Simon Marchi  <simon.marchi@polymtl.ca>
	    Tom Tromey  <tom@tromey.com>

	* target.h (memory_write_request_s): Remove typedef.  Don't define
	VEC.
	(target_write_memory_blocks): Change argument to std::vector.
	(struct memory_write_request): Add constructor.
	* target-memory.c (compare_block_starting_address): Return bool.
	Change argument types.
	(claim_memory): Change arguments to use std::vector.
	(split_regular_and_flash_blocks, blocks_to_erase)
	(compute_garbled_blocks): Likewise.
	(cleanup_request_data, cleanup_write_requests_vector): Remove.
	(target_write_memory_blocks): Change argument to std::vector.
	* symfile.c (struct load_section_data): Add constructor and
	destructor.  Use std::vector for "requests".
	(struct load_progress_data): Add initializers.
	(load_section_callback): Update.  Use "new".
	(clear_memory_write_data): Remove.
	(generic_load): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] ld: Add --enable-separate-code
@ 2018-02-27 20:21 sergiodj+buildbot
  2018-02-28 16:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-27 20:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f6aec96dce1ddbd8961a3aa8a2925db2021719bb ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: f6aec96dce1ddbd8961a3aa8a2925db2021719bb

ld: Add --enable-separate-code

This patch adds --enable-separate-code to ld configure to turn on
-z separate-code by default and enables it by default for Linux/x86.
This avoids mixing code pages with data to improve cache performance
as well as security.

To reduce x86-64 executable and shared object sizes, the maximum page
size is reduced from 2MB to 4KB when -z separate-code is turned on by
default.  Note: -z max-page-size= can be used to set the maximum page
size.

We compared SPEC CPU 2017 performance before and after this change on
Skylake server.  There are no any significant performance changes.
Everything is mostly below +/-1%.

bfd/

	* config.in: Regenerated.
	* configure: Likewise.
	* configure.ac: Add --enable-separate-code.
	(DEFAULT_LD_Z_SEPARATE_CODE): New AC_DEFINE_UNQUOTED.  Default
	to 1 for Linux/x86 targets,
	* elf64-x86-64.c (ELF_MAXPAGESIZE): Set to 0x1000 if
	DEFAULT_LD_Z_SEPARATE_CODE is 1.

ld/

	* NEWS: Mention --enable-separate-code.
	* configure.ac: Add --enable-separate-code.
	(DEFAULT_LD_Z_SEPARATE_CODE): New AC_DEFINE_UNQUOTED.
	* configure.tgt: Default ac_default_ld_z_separate_code to 1 for
	Linux/x86 targets.
	* config.in: Regenerated.
	* configure: Likewise.
	* emultempl/elf32.em (gld${EMULATION_NAME}_before_parse): Set
	link_info.separate_code DEFAULT_LD_Z_SEPARATE_CODE.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Update get_args documentation
@ 2018-02-27 21:14 sergiodj+buildbot
  2018-02-28 17:37 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-27 21:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e05cac70d855cd404eae9aeea5fcfb83ce8aabcf ***

Author: Phil Muldoon <pmuldoon@redhat.com>
Branch: master
Commit: e05cac70d855cd404eae9aeea5fcfb83ce8aabcf

Update get_args documentation

This patch adds argument compilation documentation, expanding on the
already existing comments, giving a more thorough explanation of
the source of the arguments used in the final argument string.

gdb/ChangeLog:

	* compile/compile.c (get_args): Add additional comments
	explaining function.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Workaround a FreeBSD ptrace() bug with clearing thread events.
@ 2018-02-28  1:47 sergiodj+buildbot
  2018-02-28 18:54 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-28  1:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f169cfdc08761a3d9fcd587ad8661102672403ec ***

Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: f169cfdc08761a3d9fcd587ad8661102672403ec

Workaround a FreeBSD ptrace() bug with clearing thread events.

When multiple threads within a process wish to report STOPPED events
from wait(), the kernel picks one thread event as the thread event to
report.  The chosen thread event is retrieved via PT_LWPINFO by
passing the process ID as the request pid.  If multiple events are
pending, then the subsequent wait() after resuming a process will
report another STOPPED event after resuming the process to handle the
next thread event and so on.

A single thread event is cleared as a side effect of resuming the
process with PT_CONTINUE, PT_STEP, etc.  In older kernels, however,
the request pid was used to select which thread's event was cleared
rather than always clearing the event that was just reported.  To
avoid clearing the event of the wrong LWP, always pass the process ID
instead of an LWP ID to PT_CONTINUE or PT_SYSCALL.

In the case of stepping, the process ID cannot be used with PT_STEP
since it would step the thread that reported an event which may not be
the thread indicated by PTID.  For stepping, use PT_SETSTEP to enable
stepping on the desired thread before resuming the process via
PT_CONTINUE instead of using PT_STEP.

This manifested as a failure in the
gdb.threads/continue-pending-status.exp test.  Specifically, if thread
2 reported a breakpoint and the test thus switched to thread 3 before
continuing, thread 3's event (if any) was discarded and thread 2's
breakpoint remained pending and was reported a second time as a
duplicate event.  As a result, the PC was decremented twice for the
same breakpoint resulting in an illegal instruction fault on x86.

gdb/ChangeLog:

	* fbsd-nat.c (fbsd_resume): Use PT_SETSTEP for stepping and a
	wildcard process pid for super_resume for kernels with a
	specific bug.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Nonsense error messages on invalid aout string offset
@ 2018-02-28  7:57 sergiodj+buildbot
  2018-02-28 20:11 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-28  7:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0d329c0a83a23cebb86fbe0ebddd780dc0df2424 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 0d329c0a83a23cebb86fbe0ebddd780dc0df2424

Nonsense error messages on invalid aout string offset

translate_symbol_table returns false on detecting an out of range name
string offset, hooray for error checking, but doesn't set bfd_error or
print a useful error.  bfd_error therefore contains whatever it had
previously, in my testing, bfd_error_system_call.  So the error
printed depended on errno.

	PR 22887
	* aoutx.h (translate_symbol_table): Print an error message and set
	bfd_error on finding an invalid name string offset.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix potential integer overflow when reading corrupt dwarf1 debug information.
@ 2018-02-28 10:29 sergiodj+buildbot
  2018-02-28 21:28 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-28 10:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT eef104664efb52965d85a28bc3fc7c77e52e48e2 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: eef104664efb52965d85a28bc3fc7c77e52e48e2

Fix potential integer overflow when reading corrupt dwarf1 debug information.

	PR 22894
	* dwarf1.c (parse_die): Check the length of form blocks before
	advancing the data pointer.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PR22887, null pointer dereference in aout_32_swap_std_reloc_out
@ 2018-02-28 12:05 sergiodj+buildbot
  2018-02-28 22:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-28 12:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 116acb2c268c89c89186673a7c92620d21825b25 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 116acb2c268c89c89186673a7c92620d21825b25

PR22887, null pointer dereference in aout_32_swap_std_reloc_out

	PR 22887
	* aoutx.h (swap_std_reloc_in): Correct r_index bound check.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Catch integer overflows/underflows when parsing corrupt DWARF FORM blocks.
@ 2018-02-28 12:18 sergiodj+buildbot
  2018-03-01  0:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-28 12:18 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 12c963421d045a127c413a0722062b9932c50aa9 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 12c963421d045a127c413a0722062b9932c50aa9

Catch integer overflows/underflows when parsing corrupt DWARF FORM blocks.

	PR 22895
	PR 22893
	* dwarf2.c (read_n_bytes): Replace size parameter with dwarf_block
	pointer.  Drop unused abfd parameter.  Check the size of the block
	before initialising the data field.  Return the end pointer if the
	size is invalid.
	(read_attribute_value): Adjust invocations of read_n_bytes.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] testsuite: Restore gdb_is_target_remote_prompt
@ 2018-02-28 14:13 sergiodj+buildbot
  2018-03-01  1:18 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-28 14:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3083294d65393a31522586e058500f6abda29b83 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 3083294d65393a31522586e058500f6abda29b83

testsuite: Restore gdb_is_target_remote_prompt

In patch

  Add test for load command
  3275ef477498e0500d7ea440f1bc51787acf4610

I removed gdb_is_target_remote_prompt, but did not realize it was used
in mi_is_target_remote.  This makes the gdb.mi/mi-nonstop.exp crash, for
example:

  ERROR: (DejaGnu) proc "gdb_is_target_remote_prompt {[(]gdb[)]
  }" does not exist.
  The error code is TCL LOOKUP COMMAND gdb_is_target_remote_prompt
  The info on the error is:
  invalid command name "gdb_is_target_remote_prompt"
      while executing
  "::tcl_unknown gdb_is_target_remote_prompt {[(]gdb[)]
  }"
      ("uplevel" body line 1)
      invoked from within
  "uplevel 1 ::tcl_unknown $args"

This patch restores it.

gdb/testsuite/ChangeLog:

	* lib/gdb.exp (gdb_is_target_1): Add prompt_regexp parameter and
	use it.
	(gdb_is_target_remote_prompt): New proc.
	(gdb_is_target_remote): Use gdb_is_target_remote_prompt.
	(gdb_is_target_native): Pass prompt parameter to
	gdb_is_target_1.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Create new common/pathstuff.[ch]
@ 2018-02-28 17:02 sergiodj+buildbot
  2018-03-01  2:35 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-28 17:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b4987c956dfa44ca9fd8552f63e15f5fa094b2a4 ***

Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: b4987c956dfa44ca9fd8552f63e15f5fa094b2a4

Create new common/pathstuff.[ch]

This commit moves the path manipulation routines found on utils.c to a
new common/pathstuff.c, and updates the Makefile.in's accordingly.
The routines moved are "gdb_realpath", "gdb_realpath_keepfile" and
"gdb_abspath".

This will be needed because gdbserver will have to call "gdb_abspath"
on my next patch, which implements a way to expand the path of the
inferior provided by the user in order to allow specifying just the
binary name when starting gdbserver, like:

  $ gdbserver :1234 a.out

With the recent addition of the startup-with-shell feature on
gdbserver, this scenario doesn't work anymore if the user doesn't have
the current directory listed in the PATH variable.

I had to do a minor adjustment on "gdb_abspath" because we don't have
access to "tilde_expand" on gdbserver, so now the function is using
"gdb_tilde_expand" instead.  Otherwise, the code is the same.

Regression tested on the BuildBot, without regressions.

gdb/ChangeLog:
2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>

	* Makefile.in (COMMON_SFILES): Add "common/pathstuff.c".
	(HFILES_NO_SRCDIR): Add "common/pathstuff.h".
	* auto-load.c: Include "common/pathstuff.h".
	* common/common-def.h (current_directory): Move here.
	* common/gdb_tilde_expand.c (gdb_tilde_expand_up): New
	function.
	* common/gdb_tilde_expand.h (gdb_tilde_expand_up): New
	prototype.
	* common/pathstuff.c: New file.
	* common/pathstuff.h: New file.
	* compile/compile.c: Include "common/pathstuff.h".
	* defs.h (current_directory): Move to "common/common-defs.h".
	* dwarf2read.c: Include "common/pathstuff.h".
	* exec.c: Likewise.
	* guile/scm-safe-call.c: Likewise.
	* linux-thread-db.c: Likewise.
	* main.c: Likewise.
	* nto-tdep.c: Likewise.
	* objfiles.c: Likewise.
	* source.c: Likewise.
	* symtab.c: Likewise.
	* utils.c: Include "common/pathstuff.h".
	(gdb_realpath): Move to "common/pathstuff.c".
	(gdb_realpath_keepfile): Likewise.
	(gdb_abspath): Likewise.
	* utils.h (gdb_realpath): Move to "common/pathstuff.h".
	(gdb_realpath_keepfile): Likewise.
	(gdb_abspath): Likewise.

gdb/gdbserver/ChangeLog:
2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>

	* Makefile.in (SFILES): Add "$(srcdir)/common/pathstuff.c".
	(OBJS): Add "pathstuff.o".
	* server.c (current_directory): New global variable.
	(captured_main): Initialize "current_directory".


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Make gdbserver work with filename-only binaries
@ 2018-02-28 17:06 sergiodj+buildbot
  2018-03-01  3:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-28 17:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 25e3c82c0e927398e759e2d5e35623012b8683f7 ***

Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: 25e3c82c0e927398e759e2d5e35623012b8683f7

Make gdbserver work with filename-only binaries

Simon mentioned on IRC that, after the startup-with-shell feature has
been implemented on gdbserver, it is not possible to specify a
filename-only binary, like:

  $ gdbserver :1234 a.out
  /bin/bash: line 0: exec: a.out: not found
  During startup program exited with code 127.
  Exiting

This happens on systems where the current directory "." is not listed
in the PATH environment variable.  Although including "." in the PATH
variable is a possible workaround, this can be considered a regression
because before startup-with-shell it was possible to use only the
filename (due to reason that gdbserver used "exec*" directly).

The idea of the patch is to verify if the program path provided by the
user (or by the remote protocol) contains a directory separator
character.  If it doesn't, it means we're dealing with a filename-only
binary, so we call "gdb_abspath" to properly expand it and transform
it into a full path.  Otherwise, we leave the program path untouched.
This mimicks the behaviour seen on GDB (look at "openp" and
"attach_inferior", for example).

I am also submitting a testcase which exercises the scenario described
above.  This test requires gdbserver to be executed in a different CWD
than the original, so I also created a helper function, "with_cwd" (on
testsuite/lib/gdb.exp), which takes care of cd'ing into and out of the
specified dir.

Built and regtested on BuildBot, without regressions.

gdb/ChangeLog:
2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
	    Simon Marchi  <simon.marchi@polymtl.ca>

	* common/common-utils.c: Include "sys/stat.h".
	(is_regular_file): Move here from "source.c"; change return
	type to "bool".
	* common/common-utils.h (is_regular_file): New prototype.
	* common/pathstuff.c (contains_dir_separator): New function.
	* common/pathstuff.h (contains_dir_separator): New prototype.
	* source.c: Don't include "sys/stat.h".
	(is_regular_file): Move to "common/common-utils.c".

gdb/gdbserver/ChangeLog:
2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>

	* server.c: Include "filenames.h" and "pathstuff.h".
	(program_name): Delete variable.
	(program_path): New anonymous class.
	(get_exec_wrapper): Use "program_path" instead of
	"program_name".
	(handle_v_run): Likewise.
	(captured_main): Likewise.
	(process_serial_event): Likewise.

gdb/testsuite/ChangeLog:
2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>

	* gdb.server/abspath.exp: New file.
	* lib/gdb.exp (with_cwd): New procedure.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Change order of error message printed when gdbserver can't find CWD
@ 2018-02-28 17:19 sergiodj+buildbot
  2018-03-01  5:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-28 17:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 815615463b1171cbff7c5e54f62fc708cc1bbc99 ***

Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: 815615463b1171cbff7c5e54f62fc708cc1bbc99

Change order of error message printed when gdbserver can't find CWD

I forgot to address Pedro's comment about my last patch and change the
order of the message printed when getcwd returns NULL on gdbserver.
This obvious commit does it.

gdb/gdbserver/ChangeLog:
2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>

	* server.c (captured_main): Change order of error message printed
	when the current working directory cannot be found.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] correct ft32 reloc range test
@ 2018-02-28 23:16 sergiodj+buildbot
  2018-03-01  6:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-28 23:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5224fa039966557e869338d2591e7945cdcecb74 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 5224fa039966557e869338d2591e7945cdcecb74

correct ft32 reloc range test

	* elf32-ft32.c (ft32_info_to_howto_rela): Correct range test.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add missing translations to ALL_LINGUAS
@ 2018-02-28 23:57 sergiodj+buildbot
  2018-03-01  7:43 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-02-28 23:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e184813fdb0578fe7c5a3f3fc39b56d0ee4d1505 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: e184813fdb0578fe7c5a3f3fc39b56d0ee4d1505

Add missing translations to ALL_LINGUAS

binutils/
	* configure.ac (ALL_LINGUAS): Add sr.  Sort.
	* configure: Regenerate.
gas/
	* configure.ac (ALL_LINGUAS): Add uk.  Sort.
	* configure: Regenerate.
gprof/
	* configure.ac (ALL_LINGUAS): Add it, ro, ru, uk.  Sort.
	* configure: Regenerate.
ld/
	* configure.ac (ALL_LINGUAS): Add ja.  Sort.
	* configure: Regenerate.
opcodes/
	* configure.ac (ALL_LINGUAS): Sort.
	* configure: Regenerate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] btrace, gdbserver: check btrace target pointers
@ 2018-03-01 11:41 sergiodj+buildbot
  2018-03-01 12:55 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-01 11:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b1223e789040e9e8cdc6869a8a1fd1fd7acc109d ***

Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: b1223e789040e9e8cdc6869a8a1fd1fd7acc109d

btrace, gdbserver: check btrace target pointers

By removing the supports_btrace gdbserver target method we relied on GDB
trying to enable branch tracing and failing on the attempt.

For targets that do not provide the btrace methods, however, an initial
request from GDB for the branch trace configuration to detect whether
gdbserver is already recording resulted in a protocol error.

Have the btrace target methods throw a "Target does not suppor branch
tracing" error and be prepared to handle exceptions in all functions that
call btrace target methods.  We therefore turn the target_* macros into
static inline functions.

Also remove the additional btrace target method checks that resulted in
the above protocol error.

Thanks to Maciej W. Rozycki <macro@mips.com> for reporting this.

gdbserver/
	* target.h (target_enable_btrace, target_disable_btrace)
	(target_read_btrace, target_read_btrace_conf): Turn macro into
	inline function.  Throw error if target method is not defined.
	* server.c (handle_qxfer_btrace, handle_qxfer_btrace_conf): Remove
	check for btrace target method.  Be prepared to handle exceptions
	from btrace target methods.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: Encode AVX256/AVX512 vpsub[bwdq] with VEX128/EVEX128
@ 2018-03-01 14:29 sergiodj+buildbot
  2018-03-01 14:37 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-01 14:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8305403a1ffa8e551fd1c7bd88af1a65c0ba747c ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 8305403a1ffa8e551fd1c7bd88af1a65c0ba747c

x86: Encode AVX256/AVX512 vpsub[bwdq] with VEX128/EVEX128

When 2 source registers are identical, AVX256 and AVX512 vpsub[bwdq]
instructions can be encoded with VEX128 or EVEX128 encodings.

gas/

	* config/tc-i386.c (optimize_encoding): Optimize AVX256 and
	AVX512 vpsub[bwdq] instructions.
	* testsuite/gas/i386/optimize-1.s: Add tests for AVX256 and
	AVX512 vpsub[bwdq] instructions.
	* testsuite/gas/i386/x86-64-optimize-2.s: Likewise.
	* testsuite/gas/i386/optimize-1.d: Updated.
	* testsuite/gas/i386/x86-64-optimize-2.d: Likewise.

opcodes/

	* * i386-opc.tbl: Add "Optimize" to AVX256 and AVX512
	vpsub[bwdq] instructions.
	* i386-tbl.h: Regenerated.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Propagate record_print_flags
@ 2018-03-01 16:07 sergiodj+buildbot
  2018-03-01 16:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-01 16:07 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0cb7c7b0bb79be910e261f3d30c58ace6b0d06d1 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 0cb7c7b0bb79be910e261f3d30c58ace6b0d06d1

Propagate record_print_flags

These flags are returned as an int by get_call_history_modifiers, and
get cast back to record_print_flags in the btrace code.  Instead, we can
make the arguments of that type from start to end.

gdb/ChangeLog:

	* record.c (get_call_history_modifiers): Return a
	record_print_flags.
	(cmd_record_call_history): Adjust.
	* record-btrace.c (record_btrace_call_history): Adjust.
	(record_btrace_call_history_range): Adjust.
	(record_btrace_call_history_from): Adjust.
	* target-debug.h (target_debug_print_record_print_flags): New.
	* target-delegates.c: Re-generate.
	* target.c (target_call_history): Change flags type.
	(target_call_history_from): Likewise.
	(target_call_history_range): Likewise.
	* target.h (struct target_ops) <target_call_history>: Likewise.
	(target_call_history_from): Likewise.
	(target_call_history_range): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix Rust enum test failures
@ 2018-03-01 16:51 sergiodj+buildbot
  2018-03-01 17:35 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-01 16:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c7b15a66dc9ef2285f0983759d41baf5b9933505 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: c7b15a66dc9ef2285f0983759d41baf5b9933505

Fix Rust enum test failures

Pedro pointed out that some Rust tests were failing after the recent
enum change.  I was able to reproduce this even with the most current
Rust compiler -- no test was failing, but rather the gdb internal
error was causing an "untested" result, which I didn't notice.

The internal error is caused by a bad assertion in
alloc_discriminant_info.  This happened because, in an earlier version
of the patch, the discriminant could only appear at index 0.  However,
it can now appear anywhere.  This patch fixes the assertion in the
obvious way, and adds a second assertion to ensure that the
discriminant is also correct.

Fixing this revealed a real failure, which was caused by using the
wrong base name when computing the name of a univariant enum's sole
member.  This is also fixed here.

Tested by running the gdb.rust tests with rustc 1.23 and
double-checking the summary:

    # of expected passes		276

Note that if you try this yourself, it is still possible to get an
"untested" result from traits.exp if your Rust compiler is old enough.

2018-03-01  Tom Tromey  <tom@tromey.com>

	* dwarf2read.c (alloc_discriminant_info): Fix default_index
	assertion.  Add assertion for discriminant_index.
	(quirk_rust_enum): Use correct base type name in univariant case.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] RISC-V: Fix symbol size bug when relaxation deletes bytes.
@ 2018-03-01 22:37 sergiodj+buildbot
  2018-03-01 23:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-01 22:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 788af978df01c3667be99a1607b774f5fa844113 ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 788af978df01c3667be99a1607b774f5fa844113

RISC-V: Fix symbol size bug when relaxation deletes bytes.

	bfd/
	PR 22756
	* elfnn-riscv.c (riscv_relax_delete_bytes): When adjust st_size, use
	else if instead of if.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Improve gcore shell quoting and portability
@ 2018-03-01 22:44 sergiodj+buildbot
  2018-03-02  0:44 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-01 22:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e1e6f073a9f5d7c3183cb8096fb24a42c28ba36b ***

Author: Georg Sauthoff <mail@georg.so>
Branch: master
Commit: e1e6f073a9f5d7c3183cb8096fb24a42c28ba36b

Improve gcore shell quoting and portability

The gcore shell script (gdb/gcore.in) doesn't quote its variables
enough.

For example, trying to write a core file with - say - a space
ungraciously fails like this:

    $ gcore -o 'foo bar' 6270
    /usr/bin/gcore: line 92: [: foo: binary operator expected
    gcore: failed to create foo bar.6270

Similarly, one can inject meta characters like * (by accident)
that may yield unexpected results, e.g. as in:

    $ gcore -o foobar '*'

This change fixes these issues in several places.

Aso, since the script uses array syntax, the patch changes the
the shell in the first line from `/bin/sh` to /bin/bash`.

POSIX doesn't specify the array syntax for shell, thus, the
script doesn't work on systems where /bin/sh is linked to - say -
dash.

Since the source gcore.in already is processed by a pre-processor
one could even auto-detect the path to bash and thus dynamically
generate the first line. For systems where bash isn't available
via /bin/bash. But I think this would be overkill and /bin/bash
is good enough as most systems probably have it.

gdb/ChangeLog:

	PR gdb/22888
	* gcore.in: Quote variables and switch interpreter to bash.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Ensure 8-byte alignment for AArch64 stubs.
@ 2018-03-02 11:03 sergiodj+buildbot
  2018-03-02 11:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-02 11:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9a2ebffd4dd9cffac395177e997f6f47408b4782 ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 9a2ebffd4dd9cffac395177e997f6f47408b4782

Ensure 8-byte alignment for AArch64 stubs.

	PR 22903
bfd	* elfnn-aarch64.c (_bfd_aarch64_resize_stubs): Add 8 bytes for branch
	and nop instead of 4.
	(elfNN_arch64_build_stubs): Add nop after branch.  Increase size by
	8 instead of 4.

ld	* emultempl/aarch64elf.em (elf${ELFSIZE}_aarch64_add_stub_section):
	Give stub_sec 8 byte alignment.
	* emulparams/aarch64cloudabi.sh (NOP): Set to 0x1f2003d5.
	* emulparams/aarch64elf.sh (NOP): Likewise.
	* emulparams/aarch64elf32.sh (NOP): Likewise.
	* emulparams/aarch64fbsd.sh (NOP): Likewise.
	* emulparams/aarch64linux.sh (NOP): Likewise.
	* emulparams/aarch64linux32.sh (NOP): Likewise.
	* testsuite/ld-aarch64/erratum835769.d: Adjust for added nop.
	* testsuite/ld-aarch64/erratum843419.d: Likewise.
	* testsuite/ld-aarch64/farcall-b-defsym.d: Likewise.
	* testsuite/ld-aarch64/farcall-b-none-function.d: Likewise.
	* testsuite/ld-aarch64/farcall-b-plt.d: Likewise.
	* testsuite/ld-aarch64/farcall-b-section.d: Likewise.
	* testsuite/ld-aarch64/farcall-b.d: Likewise.
	* testsuite/ld-aarch64/farcall-back.d: Likewise.
	* testsuite/ld-aarch64/farcall-bl-defsym.d: Likewise.
	* testsuite/ld-aarch64/farcall-bl-none-function.d: Likewise.
	* testsuite/ld-aarch64/farcall-bl-plt.d: Likewise.
	* testsuite/ld-aarch64/farcall-bl-section.d: Likewise.
	* testsuite/ld-aarch64/farcall-bl.d: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [GDB/testsuite] Use %progbits in watch-loc.c
@ 2018-03-02 12:07 sergiodj+buildbot
  2018-03-02 12:34 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-02 12:07 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ecc054c097e7ced281d02ef9632eb0261a410b96 ***

Author: Thomas Preud'homme <thomas.preudhomme@arm.com>
Branch: master
Commit: ecc054c097e7ced281d02ef9632eb0261a410b96

[GDB/testsuite] Use %progbits in watch-loc.c

While using @progbits in .pushsection work on some targets, it does not
work on arm target where this introduces a comment. This patch replaces
its use in gdb.dlang/watch-loc.c and gdb.mi/dw2-ref-missing-frame-func.c
by %progbits which should work on all targets since it is used in
target-independent elf/section7.s GAS test.

2018-03-02  Thomas Preud'homme  <thomas.preudhomme@arm.com>

gdb/testsuite/
	* gdb.dlang/watch-loc.c: Use %progbits instead of @progbits.
	* gdb.mi/dw2-ref-missing-frame-func.c: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Conditionally include "<windows.h>" on common/pathstuff.c (and unbreak build on mingw*)
@ 2018-03-02 12:46 sergiodj+buildbot
  2018-03-02 13:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-02 12:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ab818ade016bcd794980438775e15c7a74f054f9 ***

Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: ab818ade016bcd794980438775e15c7a74f054f9

Conditionally include "<windows.h>" on common/pathstuff.c (and unbreak build on mingw*)

commit b4987c956dfa44ca9fd8552f63e15f5fa094b2a4
Author: Sergio Durigan Junior <sergiodj@redhat.com>
Date:   Fri Feb 9 18:44:59 2018 -0500

    Create new common/pathstuff.[ch]

Introduced a regression when compiling for mingw*:

  /gdb/common/pathstuff.c: In function 'gdb::unique_xmalloc_ptr<char>
  gdb_realpath(const char*)':
  /gdb/common/pathstuff.c:56:14: error: 'MAX_PATH' was not declared in this scope
       char buf[MAX_PATH];
		^
  /gdb/common/pathstuff.c:57:5: error: 'DWORD' was not declared in this scope
       DWORD len = GetFullPathName (filename, MAX_PATH, buf, NULL);
       ^
  /gdb/common/pathstuff.c:57:11: error: expected ';' before 'len'
       DWORD len = GetFullPathName (filename, MAX_PATH, buf, NULL);
	     ^
  /gdb/common/pathstuff.c:63:9: error: 'len' was not declared in this scope
       if (len > 0 && len < MAX_PATH)
	   ^
  /gdb/common/pathstuff.c:64:54: error: 'buf' was not declared in this scope
	 return gdb::unique_xmalloc_ptr<char> (xstrdup (buf));
							^
  make[2]: *** [pathstuff.o] Error 1

The proper fix is to conditionally include "<windows.h>".  This commit
does that, without introducing any regressions as per tests made by
our BuildBot.

gdb/ChangeLog:
2018-03-01  Sergio Durigan Junior  <sergiodj@redhat.com>

	PR gdb/22907
	* common/pathstuff.c: Conditionally include "<windows.h>".


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] opcodes error messages
@ 2018-03-03  1:20 sergiodj+buildbot
  2018-03-03  1:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-03  1:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a6743a5420aa02a0550b0f7be004f6c06e90ce21 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: a6743a5420aa02a0550b0f7be004f6c06e90ce21

opcodes error messages

Another patch aimed at making binutils comply with the GNU coding
standard.  The generated files require
https://sourceware.org/ml/cgen/2018-q1/msg00004.html

cpu/
	* frv.opc: Include opintl.h.
	(add_next_to_vliw): Use opcodes_error_handler to print error.
	Standardize error message.
	(fr500_check_insn_major_constraints, frv_vliw_add_insn): Likewise.
opcodes/
	* sysdep.h (opcodes_error_handler): Define.
	(_bfd_error_handler): Declare.
	* Makefile.am: Remove stray #.
	* opc2c.c (main): Remove bogus -l arg handling.  Print "DO NOT
	EDIT" comment.
	* aarch64-dis.c, * arc-dis.c, * arm-dis.c, * avr-dis.c,
	* d30v-dis.c, * h8300-dis.c, * mmix-dis.c, * ppc-dis.c,
	* riscv-dis.c, * s390-dis.c, * sparc-dis.c, * v850-dis.c: Use
	opcodes_error_handler to print errors.  Standardize error messages.
	* msp430-decode.opc, * nios2-dis.c, * rl78-decode.opc: Likewise,
	and include opintl.h.
	* nds32-asm.c: Likewise, and include sysdep.h and opintl.h.
	* i386-gen.c: Standardize error messages.
	* msp430-decode.c, * rl78-decode.c, rx-decode.c: Regenerate.
	* Makefile.in: Regenerate.
	* epiphany-asm.c, * epiphany-desc.c, * epiphany-dis.c,
	* epiphany-ibld.c, * fr30-asm.c, * fr30-desc.c, * fr30-dis.c,
	* fr30-ibld.c, * frv-asm.c, * frv-desc.c, * frv-dis.c, * frv-ibld.c,
	* frv-opc.c, * ip2k-asm.c, * ip2k-desc.c, * ip2k-dis.c, * ip2k-ibld.c,
	* iq2000-asm.c, * iq2000-desc.c, * iq2000-dis.c, * iq2000-ibld.c,
	* lm32-asm.c, * lm32-desc.c, * lm32-dis.c, * lm32-ibld.c,
	* m32c-asm.c, * m32c-desc.c, * m32c-dis.c, * m32c-ibld.c,
	* m32r-asm.c, * m32r-desc.c, * m32r-dis.c, * m32r-ibld.c,
	* mep-asm.c, * mep-desc.c, * mep-dis.c, * mep-ibld.c, * mt-asm.c,
	* mt-desc.c, * mt-dis.c, * mt-ibld.c, * or1k-asm.c, * or1k-desc.c,
	* or1k-dis.c, * or1k-ibld.c, * xc16x-asm.c, * xc16x-desc.c,
	* xc16x-dis.c, * xc16x-ibld.c, * xstormy16-asm.c, * xstormy16-desc.c,
	* xstormy16-dis.c, * xstormy16-ibld.c: Regenerate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Make delim_string_to_char_ptr_vec return an std::vector
@ 2018-03-03  4:46 sergiodj+buildbot
  2018-03-03  4:53 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-03  4:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e80aaf6183c6692ecc167bf26cbdc53f8f1a55f0 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: e80aaf6183c6692ecc167bf26cbdc53f8f1a55f0

Make delim_string_to_char_ptr_vec return an std::vector

This patch makes delim_string_to_char_ptr_vec and all related functions
use std::vector of gdb::unique_xmalloc_ptr.  This allows getting rid of
make_cleanup_free_char_ptr_vec.  Returning a vector of
unique_xmalloc_ptr instead of std::string allows to minimize the impacts
on the calling code.  We can evaluate later whether we could/should
return a vector of std::strings instead.

gdb/ChangeLog:

	* common/gdb_vecs.h (make_cleanup_free_char_ptr_vec): Remove.
	(delim_string_to_char_ptr_vec): Return std::vector of
	gdb::unique_xmalloc_ptr.
	(dirnames_to_char_ptr_vec_append): Take std::vector of
	gdb::unique_xmalloc_ptr.
	(dirnames_to_char_ptr_vec): Return std::vector of
	gdb::unique_xmalloc_ptr.
	* common/gdb_vecs.c (delim_string_to_char_ptr_vec_append):
	Take std::vector of gdb::unique_xmalloc_ptr, adjust the code.
	(delim_string_to_char_ptr_vec): Return an std::vector of
	gdb::unique_xmalloc_ptr, adjust the code.
	(dirnames_to_char_ptr_vec_append): Take an std::vector of
	gdb::unique_xmalloc_ptr, adjust the code.
	(dirnames_to_char_ptr_vec): Return an std::vector of
	gdb::unique_xmalloc_ptr, adjust the code.
	* auto-load.c (auto_load_safe_path_vec): Change type to
	std::vector of gdb::unique_xmalloc_ptr.
	(auto_load_expand_dir_vars): Return an std::vector of
	gdb::unique_xmalloc_ptr, adjust the code.
	(auto_load_safe_path_vec_update): Adjust.
	(filename_is_in_auto_load_safe_path_vec): Adjust.
	(auto_load_objfile_script_1): Adjust.
	* build-id.c (build_id_to_debug_bfd): Adjust.
	* linux-thread-db.c (thread_db_load_search): Adjust.
	* source.c (add_path): Adjust.
	(openp): Adjust.
	* symfile.c (find_separate_debug_file): Adjust.
	* utils.c (do_free_char_ptr_vec): Remove.
	(make_cleanup_free_char_ptr_vec): Remove.

gdb/gdbserver/ChangeLog:

	* server.c (parse_debug_format_options): Adjust to
	delim_string_to_char_ptr_vec changes.
	* thread-db.c (thread_db_load_search): Adjust to
	dirnames_to_char_ptr_vec changes.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] C++ify program_space
@ 2018-03-03  4:53 sergiodj+buildbot
  2018-03-03  6:11 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-03  4:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 564b1e3f2906bbbf53d003d6fdbcfc83661385e2 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 564b1e3f2906bbbf53d003d6fdbcfc83661385e2

C++ify program_space

This patch makes program_space a C++ object by adding a
constructor/destructor, giving default values to fields, and using
new/delete.

gdb/ChangeLog:

	* progspace.h (struct program_space): Add constructor and
	destructor, initialize fields.
	(add_program_space): Remove.
	* progspace.c (add_program_space): Rename to...
	(program_space::program_space): ... this.
	(release_program_space): Rename to...
	(program_space::~program_space): ... this.
	(delete_program_space): Use delete to delete program_space.
	(initialize_progspace): Use new to allocate program_space.
	* inferior.c (add_inferior_with_spaces): Likewise.
	(clone_inferior_command): Likewise.
	* infrun.c (follow_fork_inferior): Likewise.
	(handle_vfork_child_exec_or_exit): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Make program_space::deleted_solibs a vector of std::string
@ 2018-03-03  5:05 sergiodj+buildbot
  2018-03-03  7:27 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-03  5:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6fb16ce6eaba92b86a22eac58eb0eb61b3fd8804 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 6fb16ce6eaba92b86a22eac58eb0eb61b3fd8804

Make program_space::deleted_solibs a vector of std::string

This allows removing a usage of free_char_ptr_vec.

gdb/ChangeLog:

	* progspace.h (struct program_space) <deleted_solibs>: Change
	type to std::vector<std::string>.
	* progspace.c (clear_program_space_solib_cache): Adjust.
	* breakpoint.c (print_solib_event): Adjust.
	(check_status_catch_solib): Adjust.
	* solib.c (update_solib_list): Adjust.
	* ui-out.h (class ui_out) <field_string>: New overload.
	* ui-out.c (ui_out::field_string): New overload.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] C++ify charsets
@ 2018-03-03  5:17 sergiodj+buildbot
  2018-03-03  8:54 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-03  5:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ccb2231cd848c89f04ab2e1e54b013d69ea34893 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: ccb2231cd848c89f04ab2e1e54b013d69ea34893

C++ify charsets

This patch makes the charset list an std::vector instead of a VEC.
Because we must have access to the raw pointers as a simple array, we
can't use a vector of unique_ptr/unique_xmalloc_ptr.  Therefore, wrap
the vector in a simple class to facilitate the cleanup.  This allows
removing one usage of free_char_ptr_vec.

gdb/ChangeLog:

	* charset.c (struct charset_vector): New.
	(charsets): Change type to charset_vector.
	(find_charset_names): Adjust.
	(add_one): Adjust.
	(_initialize_charset): Adjust.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] handle_general_set: Remove useless xstrdup
@ 2018-03-03  5:54 sergiodj+buildbot
  2018-03-03 12:11 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-03  5:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b9671caf8fe1abd737846edf7dcd627870f986cc ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: b9671caf8fe1abd737846edf7dcd627870f986cc

handle_general_set: Remove useless xstrdup

Unless I'm missing something very obvious, this xstrdup seems
unnecessary to me.  We can pass "mode" directly to sprintf.

gdb/gdbserver/ChangeLog:

	* server.c (handle_general_set): Remove unnecessary xstrdup.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove free_char_ptr_vec
@ 2018-03-03  8:16 sergiodj+buildbot
  2018-03-03 10:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-03  8:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 54693cf5f11bf292ae308604caf6e866dbb03e6f ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 54693cf5f11bf292ae308604caf6e866dbb03e6f

Remove free_char_ptr_vec

Nothing is using it anymore.

gdb/ChangeLog:

	* common/gdb_vecs.c (free_char_ptr_vec): Remove.
	* common/gdb_vecs.h (free_char_ptr_vec): Remove.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PR ld/21900: MIPS: Fix relocation processing with undefined symbols
@ 2018-03-03 16:07 sergiodj+buildbot
  2018-03-03 16:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-03 16:07 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT dfb93f11587ca08b820c7c785278366f2505cfd1 ***

Author: James Cowgill <james.cowgill@mips.com>
Branch: master
Commit: dfb93f11587ca08b820c7c785278366f2505cfd1

PR ld/21900: MIPS: Fix relocation processing with undefined symbols

Currently, when `mips_elf_calculate_relocation' is asked to relocate an
undefined symbol, it reports an error or a warning and immediately
returns without performing the relocation.  This is fine if the link
fails, but if unresolved_syms_in_objects == RM_GENERATE_WARNING, the
link will continue and output some unrelocated code, which is a
regression from commit e7e2196da3f0 ("MIPS/BFD: Correctly report
undefined relocations").

Fix this by continuing after calling the `undefined_symbol' hook unless
this is an error condition.

	bfd/
	PR ld/21900
	* elfxx-mips.c (mips_elf_calculate_relocation): Only return
	after calling `undefined_symbol' hook if this is an error
	condition.  Assume the value of 0 for the symbol requested
	otherwise.

	ld/
	PR ld/21900
	* testsuite/ld-mips-elf/undefined-warn.d: New test.
	* testsuite/ld-mips-elf/undefined.s: Add padding at the end.
	* testsuite/ld-mips-elf/mips-elf.exp: Run the new test.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Implement "to_stopped_by_hw_breakpoint" for x86 debug registers.
@ 2018-03-04  5:54 sergiodj+buildbot
  2018-03-04  6:05 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-04  5:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 12279366d71627bfbdd74d1a6675dca825d8feca ***

Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: 12279366d71627bfbdd74d1a6675dca825d8feca

Implement "to_stopped_by_hw_breakpoint" for x86 debug registers.

Report that a thread is stopped by a hardware breakpoint if a non-data
watchpoint is set in DR6.  This change should be a no-op since a target
still needs to implement the "to_supports_stopped_by_hw_breakpoint"
method before this function is used.

gdb/ChangeLog:

	* nat/x86-dregs.c (x86_dr_stopped_by_hw_breakpoint): New function.
	* nat/x86-dregs.h (x86_dr_stopped_by_hw_breakpoint): New
	prototype.
	* x86-nat.c (x86_stopped_by_hw_breakpoint): New function.
	(x86_use_watchpoints): Set "stopped_by_hw_breakpoint" target
	method.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add a new debug knob for the FreeBSD native target.
@ 2018-03-04  6:07 sergiodj+buildbot
  2018-03-04  7:22 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-04  6:07 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 386a86761838df16c1459275d465ed21a1c35d9f ***

Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: 386a86761838df16c1459275d465ed21a1c35d9f

Add a new debug knob for the FreeBSD native target.

For now this just logs information about the state of the current LWP
for each STOPPED event in fbsd_wait().

gdb/ChangeLog:

	* NEWS (Changes since GDB 8.1): Add "set/show debug fbsd-nat".
	* fbsd-nat.c (debug_fbsd_nat): New variable.
	(show_fbsd_nat_debug): New function.
	(fbsd_wait): Log LWP info if "debug_fbsd_nat" is enabled.
	(_initialize_fbsd_nat): Add "fbsd-nat" debug boolean command.

gdb/doc/ChangeLog:

	* gdb.texinfo (Debugging Output): Document "set/show debug
	fbsd-nat".


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use signal information to determine SIGTRAP type for FreeBSD.
@ 2018-03-04  6:38 sergiodj+buildbot
  2018-03-04  8:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-04  6:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7efba073e2b83803a47fd89e701fe60b98f2debc ***

Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: 7efba073e2b83803a47fd89e701fe60b98f2debc

Use signal information to determine SIGTRAP type for FreeBSD.

Use the signal code from siginfo_t to distinguish SIGTRAP events due
to trace traps (TRAP_TRACE) and software breakpoints (TRAP_BRKPT).
For software breakpoints, adjust the PC when the event is reported as
part of the API when supplying "stopped_by_sw_breakpoint".  Currently
FreeBSD only supports hardware watchpoints and breakpoints on x86
which are reported as trace traps.  Signal information is not used on
MIPS and sparc64 kernels which do not reliably report TRAP_BRKPT for
software breakpoints.

gdb/ChangeLog:

	* fbsd-nat.c: Include "inf-ptrace.h".
	(USE_SIGTRAP_SIGINFO): Conditionally define.
	[USE_SIGTRAP_SIGINFO] (fbsd_handle_debug_trap): New function.
	(fbsd_wait) [USE_SIGTRAP_SIGINFO]: Call "fbsd_handle_debug_trap".
	[USE_SIGTRAP_SIGINFO] (fbsd_stopped_by_sw_breakpoint): New
	function.
	[USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_sw_breakpoint):
	Likewise.
	[USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_hw_breakpoint):
	Likewise.
	(fbsd_nat_add_target) [USE_SIGTRAP_SIGINFO]: Set
	"stopped_by_sw_breakpoint", "supports_stopped_by_sw_breakpoint",
	"supports_stopped_by_hw_breakpoint" target methods.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Propagate gdb_disassembly_flags to btrace_print_lines
@ 2018-03-05  1:19 sergiodj+buildbot
  2018-03-05  1:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-05  1:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3dea1ef72c646d808e5b287e98253f3b8670c450 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 3dea1ef72c646d808e5b287e98253f3b8670c450

Propagate gdb_disassembly_flags to btrace_print_lines

This function can take the flags as the gdb_disassembly_flags type
instead of int.

gdb/ChangeLog:

	* record-btrace.c (btrace_print_lines): Change type of flags to
	gdb_disassembly_flags.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb/amd64: Ignore zero sized fields when calling functions
@ 2018-03-06 10:29 sergiodj+buildbot
  2018-03-06 10:42 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-06 10:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5dc4391345f6e86906a57af1434025cfb47b4100 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 5dc4391345f6e86906a57af1434025cfb47b4100

gdb/amd64: Ignore zero sized fields when calling functions

In some cases passing an argument to a function on amd64, or attempting
to fetch the return value, can trigger an assertion failure within GDB.
An example of a type that would trigger such an error is:

  struct foo_t
  {
    long double a;
    struct {
      struct {
        /* Empty.  */
      } es1;
    } s1;
  };

GCC does permit empty structures, so we should probably support this.

The test that exposes this bug is in the next commit along with the
RiscV support.

gdb/ChangeLog:

	* amd64-tdep.c (amd64_classify_aggregate): Ignore zero sized
	fields within aggregates.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb/riscv: Additional print format string fixes
@ 2018-03-06 14:36 sergiodj+buildbot
  2018-03-06 15:00 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-06 14:36 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fb2946557216c813310ed062a06b55d5dc466bb0 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: fb2946557216c813310ed062a06b55d5dc466bb0

gdb/riscv: Additional print format string fixes

Another riscv format string fix.

gdb/ChangeLog:

	* riscv-tdep.c (riscv_push_dummy_call): Use core_addr_to_string_nz
	where appropriate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] btrace: Remove btrace disable cleanup
@ 2018-03-06 15:11 sergiodj+buildbot
  2018-03-06 17:36 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-06 15:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 228f15081e22abed7ea336126caba26de5a3b791 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 228f15081e22abed7ea336126caba26de5a3b791

btrace: Remove btrace disable cleanup

This patch removes a cleanup that disables btrace on threads in case of
failure, so we don't leave it enabled for some the threads and disabled
for the rest.

gdb/ChangeLog:

	* record-btrace.c (record_btrace_disable_callback): Remove.
	(struct scoped_btrace_disable): New.
	(record_btrace_open): Use scoped_btrace_disable.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] btrace: Remove VEC cleanups
@ 2018-03-06 15:24 sergiodj+buildbot
  2018-03-06 19:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-06 15:24 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 531270084129e069772e68ead40c97404d1c0dd7 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 531270084129e069772e68ead40c97404d1c0dd7

btrace: Remove VEC cleanups

This patch replaces two VEC(tp_t) with std::vector<thread_info *>, which
allows to remove two cleanups.  To make it easier to map the old code to
the new code, I added the ordered_remove and unordered_remove functions,
which operate on std::vector and do the same as VEC's
ordered_remove/unordered_remove.

gdb/ChangeLog:

	* record-btrace.c (record_btrace_maybe_mark_async_event): Change
	parameter types to std::vector.  Use bool.
	(record_btrace_wait): Replace VEC(tp_t) with
	std::vector<thread_info *>.
	* common/gdb_vecs.h (unordered_remove, ordered_remove): New.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb/riscv: Fix type when reading register from regcache
@ 2018-03-06 15:28 sergiodj+buildbot
  2018-03-06 16:18 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-06 15:28 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b2970c238e24e6239760b72c924ee7dd2df9ccd1 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: b2970c238e24e6239760b72c924ee7dd2df9ccd1

gdb/riscv: Fix type when reading register from regcache

Should use a ULONGEST when reading from the regcache.

gdb/ChangeLog:

	* riscv-tdep.c (riscv_return_value): Change type to ULONGEST for
	reading values from registers.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] btrace: Remove ui_out cleanups
@ 2018-03-06 17:58 sergiodj+buildbot
  2018-03-06 20:18 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-06 17:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7ea78b5973525193eda8e379cc351c7804653216 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 7ea78b5973525193eda8e379cc351c7804653216

btrace: Remove ui_out cleanups

This patch replaces the cleanups that close the list and tuple of the
btrace instruction history output with ui_out_emit_tuple and
ui_out_emit_list.

This allows removing make_cleanup_ui_out_tuple_begin_end and
make_cleanup_ui_out_list_begin_end.

This patch (along with the previous ones in the series) was regtested on
the buildbot.

gdb/ChangeLog:

	* record-btrace.c (btrace_print_lines): Replace cleanup
	parameter with RAII equivalents.
	(btrace_insn_history): Replace cleanup with RAII equivalents.
	* ui-out.h (make_cleanup_ui_out_list_begin_end,
	make_cleanup_ui_out_tuple_begin_end): Remove.
	* ui-out.c (struct ui_out_end_cleanup_data, do_cleanup_end,
	make_cleanup_ui_out_end, make_cleanup_ui_out_tuple_begin_end,
	make_cleanup_ui_out_list_begin_end): Remove.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb/riscv: Remove use of pseudo registers
@ 2018-03-06 19:45 sergiodj+buildbot
  2018-03-06 21:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-06 19:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d74aff3d95928db6647a11865c396204c50bc157 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: d74aff3d95928db6647a11865c396204c50bc157

gdb/riscv: Remove use of pseudo registers

The code making use of pseudo registers was initially intended to
support running 32-bit ABI files on 64-bit riscv targets.  However, the
implementation was incomplete, and broken.

For now I've removed all reference to pseudo registers from the riscv
target, we've not lost any functionality, and this cleans up failures in
the selftests.

Once the riscv target has matured a little we'll probably end up
bringing back some of the use of pseudo registers in order to better
support running 32-bit executables on a 64-bit target.

gdb/ChangeLog:

	* riscv-tdep.c (riscv_pseudo_register_read): Delete.
	(riscv_pseudo_register_write): Delete.
	(riscv_gdbarch_init): Remove all use of pseudo registers.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb/riscv: Remove partial target description support
@ 2018-03-06 20:09 sergiodj+buildbot
  2018-03-07  0:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-06 20:09 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9add17f218409f357d5ed8b831c777ac93f41ec4 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 9add17f218409f357d5ed8b831c777ac93f41ec4

gdb/riscv: Remove partial target description support

Some parts of the target description support were committed with the
initial riscv patch.  As target descriptions are not currently supported
on riscv this commit removes the two pieces for code that relate to
target description support.

It is expected that target description support will be added in the
future, at which point this, or similar code will be added back.

gdb/ChangeLog:

	* riscv-tdep.c (riscv_register_name): Remove target description
	support.
	(riscv_gdbarch_init): Remove target description check.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb/riscv: Remove 'Contributed by....' comments
@ 2018-03-06 20:30 sergiodj+buildbot
  2018-03-06 23:00 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-06 20:30 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c9486dfe2753a3a9683dbb131ecfb4f5808a27c1 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: c9486dfe2753a3a9683dbb131ecfb4f5808a27c1

gdb/riscv: Remove 'Contributed by....' comments

The GDB coding standard states these lines should never have been
added.

gdb/ChangeLog:

	* riscv-tdep.c: Remove 'Contributed by ...' lines from header
	comment.
	* riscv-tdep.h: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Formatting fixes in rust-exp.y
@ 2018-03-06 21:53 sergiodj+buildbot
  2018-03-07  1:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-06 21:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d8344f3d05565ae24a39a8f02533c396b544a780 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: d8344f3d05565ae24a39a8f02533c396b544a780

Formatting fixes in rust-exp.y

I noticed a few formatting buglets in rust-exp.y: A couple of lines
were too long, and a couple of parser rules did not follow the same
formatting as the rest of the code.

I'm checking this in as obvious.  Tested by rebuilding.

2018-03-06  Tom Tromey  <tom@tromey.com>

	* rust-exp.y: Formatting fixes.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] mips64 rtype_to_howto error status
@ 2018-03-07  7:01 sergiodj+buildbot
  2018-03-07  7:13 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-07  7:01 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0118219e1850a05ceb181a4f47a6906c01c17c83 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 0118219e1850a05ceb181a4f47a6906c01c17c83

mips64 rtype_to_howto error status

	* elf64-mips.c (mips_elf64_rtype_to_howto): Return NULL on error.
	(mips_elf64_slurp_one_reloc_table): Pass on error.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] XCOFF disassembler
@ 2018-03-07  7:12 sergiodj+buildbot
  2018-03-07  8:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-07  7:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 52fe4420b771a0f3b4fc7c6535bbd6e9b279f775 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 52fe4420b771a0f3b4fc7c6535bbd6e9b279f775

XCOFF disassembler

xcoff (32-bit) objdump accepted but ignored -M options unless
-mpowerpc was also given.  This patch fixes that, leaving the default
as -Mpwr for xcoff.  I've also enabled more tests for xcoff targets.

binutils/
	* configure.ac: Add objdump_private_desc_xcoff for rs6000.
	* configure: Regenerate.
gas/
	* testsuite/gas/ppc/aix.exp: Run for rs6000 too.
	* testsuite/gas/ppc/ppc.exp: Run more tests for non-ELF targets.
	* testsuite/gas/ppc/machine.d: Don't run for PE targets.
opcodes/
	* disassemble.c (disassembler): Use bfd_arch_powerpc entry for
	bfd_arch_rs6000.
	* disassemble.h (print_insn_rs6000): Delete.
	* ppc-dis.c (powerpc_init_dialect): Handle rs6000.
	(disassemble_init_powerpc): Call powerpc_init_dialect for rs6000.
	(print_insn_rs6000): Delete.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix watching structs in C++
@ 2018-03-07 13:44 sergiodj+buildbot
  2018-03-07 14:00 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-07 13:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e95a97d41a186ac65077ba3103dc10e5d41fe7b5 ***

Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: e95a97d41a186ac65077ba3103dc10e5d41fe7b5

Fix watching structs in C++

Some of the watchpoint logic depends on the fact that the head of the
value chain represents the user-specified value to watch.  Thus no
additional values should be added to the value chain after that.  However,
if a watchpoint is defined for a C++ structure/class object, then run-time
type information (RTTI) may be present.  Thus, while constructing the
value chain for the watchpoint, the dynamic type is fetched by
gnuv3_rrti_type, which invokes value_addr, which then adds a new value to
the head of the value chain.  This new value represents the pointer to the
structure instead of the structure itself.

With such a "polluted" value chain the watchpoint logic does not recognize
when the user intended to watch a struct, and can_use_hardware_watchpoint
returns zero.  Instead of a hardware watchpoint, a software watchpoint
will then be set for no apparent reason.

This is fixed by adding an early exit to gnuv3_rtti_type when the input
value is not a dynamic class object.

gdb/testsuite/ChangeLog:

	* gdb.cp/watch-cp.cc: New test.
	* gdb.cp/watch-cp.exp: New file.

gdb/ChangeLog:

	* gnu-v3-abi.c (gnuv3_rtti_type): Add early exit if the given
	value is not a dynamic class object.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [PR20402][LD][AARCH64]Don't emit RELATIVE relocation for absolute symbols which are resolved at static linking time.
@ 2018-03-07 17:03 sergiodj+buildbot
  2018-03-07 17:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-07 17:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0c1ded8dc0be9c61975e04a0b416b064223f7bda ***

Author: Renlin Li <renlin.li@arm.com>
Branch: master
Commit: 0c1ded8dc0be9c61975e04a0b416b064223f7bda

[PR20402][LD][AARCH64]Don't emit RELATIVE relocation for absolute symbols which are resolved at static linking time.

For absolute symbols which are forced local or not dynamic, the ABS relocation
should be resolved at static linking time.

Originally, an RELATIVE/ABS relocation will be generated even for absolution
symbols for the dynamic linker to resolve.

bfd/

2018-03-07  Renlin Li  <renlin.li@arm.com>

	PR ld/20402
	* elfnn-aarch64.c (elfNN_aarch64_final_link_relocate): Check absolute symbol,
	and don't emit relocation in specific case.

ld/

2018-03-07  Renlin Li  <renlin.li@arm.com>

	PR ld/20402
	* testsuite/ld-aarch64/aarch64-elf.exp: Run new test.
	* testsuite/ld-aarch64/pr20402.s: New.
	* testsuite/ld-aarch64/pr20402.d: New.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb: Add riscv to list of architectures with a save_reggroup
@ 2018-03-07 17:55 sergiodj+buildbot
  2018-03-07 18:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-07 17:55 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ea005f31ca7a823680c70a75ae073bee52487859 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: ea005f31ca7a823680c70a75ae073bee52487859

gdb: Add riscv to list of architectures with a save_reggroup

The regcache cooked_read test needs to know which architectures have a
save_reggroup, riscv does and needs adding to the list.

gdb/ChangeLog:

	* regcache.c (cooked_read_test): Add riscv to the list of
	architectures that have a save_reggroup.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Return gdb::optional<std::string> from target_fileio_readlink
@ 2018-03-07 23:02 sergiodj+buildbot
  2018-03-07 23:14 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-07 23:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e0d3522b888033febd153a4a7d3b7c5c13641f09 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: e0d3522b888033febd153a4a7d3b7c5c13641f09

Return gdb::optional<std::string> from target_fileio_readlink

This changes to_fileio_readlink and target_fileio_readlink to return a
gdb::optional<std::sring>, and then fixes up the callers and
implementations.  This allows the removal of some cleanups.

Regression tested by the buildbot.

gdb/ChangeLog
2018-03-07  Tom Tromey  <tom@tromey.com>

	* linux-tdep.c (linux_info_proc): Update.
	* target.h (struct target_ops) <to_fileio_readlink>: Return
	optional<string>.
	(target_fileio_readlink): Return optional<string>.
	* remote.c (remote_hostio_readlink): Return optional<string>.
	* inf-child.c (inf_child_fileio_readlink): Return
	optional<string>.
	* target.c (target_fileio_readlink): Return optional<string>.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: fold AVX vcvtpd2ps memory forms
@ 2018-03-08  7:42 sergiodj+buildbot
  2018-03-08  7:55 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-08  7:42 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 73053c1fc454fe8554db170f1a30a3442546824e ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 73053c1fc454fe8554db170f1a30a3442546824e

x86: fold AVX vcvtpd2ps memory forms

This requires a change to ModR/M handling: Recording of displacement
types must not discard operand size information. Change the respective
code to alter only .disp<N>.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86/Intel: correct disassembly of fsub*/fdiv*
@ 2018-03-08  8:06 sergiodj+buildbot
  2018-03-08 10:39 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-08  8:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d53e6b98a2599ba4ce6ad14f711b76e44a32eea5 ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: d53e6b98a2599ba4ce6ad14f711b76e44a32eea5

x86/Intel: correct disassembly of fsub*/fdiv*

fsub/fsubr/fsubp/fsubrp as well as fdiv/fdivr/fdivp/fdivrp disassembly
should match (a) the Intel SDM and (b) respective input fed to gas (both
of course with the exception of when we intentionally convert bogus
insns, accompanied by a warning).


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: bogus VMOVD with 64-bit operands should only allow for registers
@ 2018-03-08  8:27 sergiodj+buildbot
  2018-03-08  9:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-08  8:27 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2907c2f55555de6b1df9a0262629003f4856807d ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 2907c2f55555de6b1df9a0262629003f4856807d

x86: bogus VMOVD with 64-bit operands should only allow for registers

These templates exist solely to satisfy gcc's needs, and gcc only
produces these with register operands.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: drop bogus NoAVX
@ 2018-03-08  8:43 sergiodj+buildbot
  2018-03-08 14:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-08  8:43 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1b193f0b1263a677f630fb419d13fc14a1d99981 ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 1b193f0b1263a677f630fb419d13fc14a1d99981

x86: drop bogus NoAVX

These are meaningful only for insns with CpuSSE* (and a few other Cpu*)
attribute.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: drop {X,Y,Z}MMWORD_MNEM_SUFFIX
@ 2018-03-08  8:54 sergiodj+buildbot
  2018-03-08 15:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-08  8:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d2224064f1a70969a77a8a82b117489793d6653e ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: d2224064f1a70969a77a8a82b117489793d6653e

x86: drop {X,Y,Z}MMWORD_MNEM_SUFFIX

They aren't really useful (anymore?): The conflicting operand size check
isn't applicable to any insn validly using respective memory operand
sizes (and if they're used wrongly, another error would result), and the
logic in process_suffix() can be easily changed to work without them.

While re-structuring conditionals in process_suffix() also drop the
CMPXCHG8B special case in favor of a NoRex64 attribute in the opcode
table.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: fold FMA and FMA4 templates
@ 2018-03-08  9:07 sergiodj+buildbot
  2018-03-08 17:39 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-08  9:07 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 25a4277fec9efb37b107f6bb6c9246f05cd3c348 ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 25a4277fec9efb37b107f6bb6c9246f05cd3c348

x86: fold FMA and FMA4 templates


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: fold a few AVX512F templates
@ 2018-03-08  9:32 sergiodj+buildbot
  2018-03-08 22:35 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-08  9:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3682415023547d90050dbb7ac8507e0c77109906 ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 3682415023547d90050dbb7ac8507e0c77109906

x86: fold a few AVX512F templates

The differences between some of the register and memory forms of the
same insn often don't really require the templates to be separate. For
example, Disp8MemShift is simply irrelevant to register forms. Fold them
as far as possible. Further folding is possible, but needs other prereq
work done first.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: fold VEX-encoded GFNI templates
@ 2018-03-08  9:44 sergiodj+buildbot
  2018-03-09  0:18 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-08  9:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 454172a99e4aebafa2cd42d389cd63a8733a046a ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 454172a99e4aebafa2cd42d389cd63a8733a046a

x86: fold VEX-encoded GFNI templates


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: fold certain AVX512 rotate and shift templates
@ 2018-03-08  9:56 sergiodj+buildbot
  2018-03-09  3:02 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-08  9:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ed438a93f18024da926eb4f56a0f96f597254a55 ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: ed438a93f18024da926eb4f56a0f96f597254a55

x86: fold certain AVX512 rotate and shift templates

Their memory forms were bogusly using VexLWP instead of VexNDD. Adjust
VexNDD handling to cope with these, allowing their register and memory
forms to be folded.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove MAX_REGISTER_SIZE define
@ 2018-03-08 10:21 sergiodj+buildbot
  2018-03-09  6:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-08 10:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4ef0bef68cfc777e59156fce1563583c0ffb76d9 ***

Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: 4ef0bef68cfc777e59156fce1563583c0ffb76d9

Remove MAX_REGISTER_SIZE define

gdb/
	* defs.h: Remove MAX_REGISTER_SIZE.
	* regcache.c (init_regcache_descr): Remove MAX_REGISTER_SIZE
	asserts.
	* python/py-unwind.c (pyuw_sniffer): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: avoid SSE check for LDMXCSR/STMXCSR
@ 2018-03-08 10:37 sergiodj+buildbot
  2018-03-08 13:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-08 10:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f2f6a710f46e3e7b357128d907002945751afcfd ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: f2f6a710f46e3e7b357128d907002945751afcfd

x86: avoid SSE check for LDMXCSR/STMXCSR

Neither touches any XMM register, so the check is pointless. It is imo
even questionable whether in SSE2AVX mode the two should be converted to
their AVX counterparts.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: fold LWP templates
@ 2018-03-08 13:06 sergiodj+buildbot
  2018-03-08 20:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-08 13:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e7f5c0a99ec597c097cf65e0c8503b7075e32d16 ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: e7f5c0a99ec597c097cf65e0c8503b7075e32d16

x86: fold LWP templates

Also drop the no longer necessary explicit Disp<N> from them.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: Remove support for old (<= 2.8.1) versions of gcc
@ 2018-03-08 14:48 sergiodj+buildbot
  2018-03-09  8:22 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-08 14:48 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bd5dea8822e515faf305690ca5c5281132d95587 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: bd5dea8822e515faf305690ca5c5281132d95587

x86: Remove support for old (<= 2.8.1) versions of gcc

Old (<= 2.8.1) versions of gcc generate broken fsubp, fsubrp, fdivp and
fdivrp instructions.  Assembler translates them to correct ones with a
warning:

[hjl@gnu-cfl-1 gas]$ cat x.s
	fsubp %st(3),%st
[hjl@gnu-cfl-1 gas]$ gcc -c x.s
x.s: Assembler messages:
x.s:1: Warning: translating to `fsubp %st,%st(3)'
[hjl@gnu-cfl-1 gas]$

This patch removes support for old (<= 2.8.1) versions of gcc:

[hjl@gnu-cfl-1 gas]$ ./as-new -o x.o x.s
x.s: Assembler messages:
x.s:1: Error: operand type mismatch for `fsubp'
[hjl@gnu-cfl-1 gas]$

gas/

	* NEWS: Mention -mold-gcc removal.
	* config/tc-i386.c (i386_error): Remove old_gcc_only.
	(old_gcc): Removed.
	(match_template): Remove old gcc support.
	(OPTION_MOLD_GCC): Removed.
	(OPTION_MRELAX_RELOCATIONS): Updated.
	(md_longopts): Remove OPTION_MOLD_GCC.
	(md_parse_option): Likewise.
	(md_show_usage): Remove -mold-gcc.
	* testsuite/gas/i386/general.s: Convert fsub/fdiv tests for old
	(<= 2.8.1) versions of gcc.
	* testsuite/gas/i386/intel.s: Likewise.
	* testsuite/gas/i386/general.l: Updated.
	* testsuite/gas/i386/intel-intel.d: Likewise.
	* testsuite/gas/i386/intel.d: Likewise.
	* testsuite/gas/i386/intel.e: Likewise.
	* testsuite/gas/i386/i386.exp: Don't pass -mold-gcc to general.

include/

	* opcode/i386 (OLDGCC_COMPAT): Removed.

opcodes/

	* i386-gen.c (opcode_modifiers): Remove OldGcc.
	* i386-opc.h (OldGcc): Removed.
	(i386_opcode_modifier): Remove oldgcc.
	* i386-opc.tbl: Remove fsubp, fsubrp, fdivp and fdivrp
	instructions for old (<= 2.8.1) versions of gcc.
	* i386-tbl.h: Regenerated.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: Treat relocation against IFUNC symbol as FUNC
@ 2018-03-08 15:00 sergiodj+buildbot
  2018-03-09  9:49 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-08 15:00 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 347a87745eab23d8427349787bde4a938a1e8c3e ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 347a87745eab23d8427349787bde4a938a1e8c3e

x86: Treat relocation against IFUNC symbol as FUNC

When resolving a relocation against IFUNC symbol in a SHT_NOTE section
without SHF_ALLOC, we treat it as relocation against FUNC symbol since
it needs the address of IFUNC symbol, not the address returned by IFUNC
function.

bfd/

	PR ld/22929
	* elf32-i386.c (elf_i386_relocate_section): Treat relocation
	against IFUNC symbol in SHT_NOTE section without SHF_ALLOC as
	relocation against FUNC symbol.
	* elf64-x86-64.c (elf_x86_64_relocate_section): Likewise.

ld/

	PR ld/22929
	* testsuite/ld-i386/i386.exp: Run PR ld/22929 test.
	* testsuite/ld-x86-64/x86-64.exp: Likewise.
	* testsuite/ld-i386/pr22929.d: New file.
	* testsuite/ld-i386/pr22929.s: Likewise.
	* testsuite/ld-x86-64/pr22929.d: Likewise.
	* testsuite/ld-x86-64/pr22929.s: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: fold several AVX512VL templates
@ 2018-03-08 16:07 sergiodj+buildbot
  2018-03-09  5:06 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-08 16:07 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e771e7c9fb79487d7b192769bc2d91fbe4118ba6 ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: e771e7c9fb79487d7b192769bc2d91fbe4118ba6

x86: fold several AVX512VL templates

The differences between some of the register and memory forms of the
same insn often don't really require the templates to be separate. For
example, Disp8MemShift is simply irrelevant to register forms. Fold
these as far as possible, and also fold register-only forms. Further
folding is possible, but needs other prereq work done first.

A note regarding EVEXDYN: This is intended to be used only when no other
properties of the template would make is_evex_encoding() return true. In
all "normal" cases I think it is preferable to omit this indicator, to
keep the table half way readable.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86-64: Also optimize "clr reg64"
@ 2018-03-08 20:05 sergiodj+buildbot
  2018-03-09 11:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-08 20:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d3d50934a9101416c3106497d6ea9ce548760253 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: d3d50934a9101416c3106497d6ea9ce548760253

x86-64: Also optimize "clr reg64"

"clr reg" is an alias of "xor reg, reg".  We can encode "clr reg64" as
"xor reg32, reg32".

gas/

	* config/tc-i386.c (optimize_encoding): Also encode "clr reg64"
	as "xor reg32, reg32".
	* testsuite/gas/i386/x86-64-optimize-1.s: Add "clr reg64" tests.
	* testsuite/gas/i386/x86-64-optimize-1.d: Updated.

opcodes/

	* i386-opc.tbl: Add Optimize to clr.
	* i386-tbl.h: Regenerated.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Don't redefine upload/download/file in gdbserver-base
@ 2018-03-08 23:13 sergiodj+buildbot
  2018-03-09 12:37 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-08 23:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e4fe3756763773940b003159649f224a5ac42ee0 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: e4fe3756763773940b003159649f224a5ac42ee0

Don't redefine upload/download/file in gdbserver-base

Before patch

  Make native gdbserver boards no longer be "remote" (in DejaGnu terms)
  739b3f1d8ff7072dcc66240c25b026c6433bda1a

the local gdbserver boards (except native-extended-gdbserver...) were
considered as remote by DejaGNU.  To avoid DejaGNU trying to use ssh/scp
to download the files to the target (which is actually local), the
gdbserver-base.exp file defined some _download, _upload and _file board
operations to override the default behavior, and instead just use local
operations.

The same patch also changed remote-stdio-gdbserver.exp to make it
inherit from gdbserver-base.exp.  Since then, this board (which is
actually remote) uses the overrides with local file operations.  As a
result, files are never actually copied to the target.

I think we can simply remove the overrides from gdbserver-base.exp.
Because all boards should be properly considered local or remote by
DejaGNU, it should by default use the right method for transferring
files.

gdb/testsuite/ChangeLog:

	PR gdb/22841
	* boards/gdbserver-base.exp (${board}_file, ${board}_download,
	${board}_upload): Remove.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] remote-stdio-gdbserver: Pass "target" to remote_exec to delete file
@ 2018-03-08 23:24 sergiodj+buildbot
  2018-03-09 13:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-08 23:24 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4872dc464db25a003c66ef91773b616495cc504f ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 4872dc464db25a003c66ef91773b616495cc504f

remote-stdio-gdbserver: Pass "target" to remote_exec to delete file

As described here

  https://sourceware.org/bugzilla/show_bug.cgi?id=22841

there seems to be situations where the remote-stdio-gdbserver board
fails to delete the uploaded binary file.  Passing "target" fixes the
issue for Christian who reported the bug.

I did not experience this problem, but passing "target" to remote_exec
still works for me, so I'm fine with changing it.

Any objection?

gdb/testsuite/ChangeLog:

	PR gdb/22841
	* boards/remote-stdio-gdbserver.exp (${board}_file): Pass
	"target" to remote_exec.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] linux_qxfer_libraries_svr4: Use std::string
@ 2018-03-08 23:36 sergiodj+buildbot
  2018-03-09 15:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-08 23:36 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f6e8a41e6724e641d3b831983e4d158ff069b8ed ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: f6e8a41e6724e641d3b831983e4d158ff069b8ed

linux_qxfer_libraries_svr4: Use std::string

Use std::string, removing some manual memory management.

gdb/gdbserver/ChangeLog:

	* linux-low.c (linux_qxfer_libraries_svr4): Use std::string.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add xml_escape_text_append and use it
@ 2018-03-08 23:48 sergiodj+buildbot
  2018-03-09 16:34 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-08 23:48 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e6a58aa8a70c7fd17d9930e7df8d158a7e3c8c8e ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: e6a58aa8a70c7fd17d9930e7df8d158a7e3c8c8e

Add xml_escape_text_append and use it

[This patch should go on top of "linux_qxfer_libraries_svr4: Use
 std::string", I should have sent them together as a series.]

I noticed that linux_qxfer_libraries_svr4 used xml_escape_text, which
returns an std::string.  That string is then copied into a larger
buffer.  It would be more efficient if we had a version of
xml_escape_text which appended to an existing string instead of
returning a new one.  This is what this patch does.

I manually verified that the output of linux_qxfer_libraries_svr4 didn't
change before/after the patch.

gdb/ChangeLog:

	* common/xml-utils.c (xml_escape_text): Move code to...
	(xml_escape_text_append): ... this new function.
	* common/xml-utils.h (xml_escape_text_append): New declaration.
	* unittests/xml-utils-selftests.c (test_xml_escape_text_append):
	New function.
	(_initialize_xml_utils): register test_xml_escape_text_append as
	a selftest.

gdb/gdbserver/ChangeLog:

	* linux-low.c (linux_qxfer_libraries_svr4): Use
	xml_escape_text_append.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Make find_separate_debug_file* return std::string
@ 2018-03-09  0:12 sergiodj+buildbot
  2018-03-09 17:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-09  0:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a8dbfd5853e3a5f7f2a3ca817e96d9e0759061a2 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: a8dbfd5853e3a5f7f2a3ca817e96d9e0759061a2

Make find_separate_debug_file* return std::string

This patch makes the find_separate_debug_file* functions return
std::string, which allows to get rid of some manual memory management
and one cleanup.

gdb/ChangeLog:

	* build-id.c (find_separate_debug_file_by_buildid): Return
	std::string.
	* build-id.h (find_separate_debug_file_by_buildid): Return
	std::string.
	* coffread.c (coff_symfile_read): Adjust to std::string.
	* elfread.c (elf_symfile_read): Adjust to std::string.
	* symfile.c (separate_debug_file_exists): Change parameter to
	std::string.
	(find_separate_debug_file): Return std::string.
	(find_separate_debug_file_by_debuglink): Return std::string.
	* symfile.h (find_separate_debug_file_by_debuglink): Return
	std::string.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use std::string to simplify build_id_to_debug_bfd
@ 2018-03-09  0:25 sergiodj+buildbot
  2018-03-09 19:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-09  0:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 00b400574aa75c1c5fe469233ab16930e2d8a4c8 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 00b400574aa75c1c5fe469233ab16930e2d8a4c8

Use std::string to simplify build_id_to_debug_bfd

Using std::string here makes the string building simpler thank playing
with char*.  A stack allocation is replaced with heap allocation, but
I don't think this is really performance-critical code.

gdb/ChangeLog:

	* build-id.c (build_id_to_debug_bfd): Use std::string.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix misreporting of omitted bytes for large remote packets
@ 2018-03-09  0:49 sergiodj+buildbot
  2018-03-09 20:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-09  0:49 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 567a3e54d211ab8d09119f99fed10b57db895450 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 567a3e54d211ab8d09119f99fed10b57db895450

Fix misreporting of omitted bytes for large remote packets

In remote.c, when the output of "set debug remote" is truncated, the
number of characters reported is incorrect.  What is reported is the
number of characters added by the quoting, not the number of characters
that were truncated.

gdb/ChangeLog:

	* remote.c (putpkt_binary): Fix omitted bytes reporting.
	(getpkt_or_notif_sane_1): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Change enable_thread_stack_temporaries to an RAII class
@ 2018-03-09  5:14 sergiodj+buildbot
  2018-03-09 21:43 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-09  5:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fdf07f3aeba5906fec462fba33801c173862f241 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: fdf07f3aeba5906fec462fba33801c173862f241

Change enable_thread_stack_temporaries to an RAII class

This started as a patch to change enable_thread_stack_temporaries to
be an RAII class, but then I noticed that this code used a VEC, so I
went ahead and did a bit more C++-ification, changing
stack_temporaries_enabled to a bool and changing stack_temporaries to
a std::vector.

Regression tested by the buildbot.

gdb/ChangeLog
2018-03-08  Tom Tromey  <tom@tromey.com>

	* infcall.c (struct call_return_meta_info)
	<stack_temporaries_enabled>: Remove.
	(get_call_return_value, call_function_by_hand_dummy): Update.
	* thread.c (disable_thread_stack_temporaries): Remove.
	(enable_thread_stack_temporaries): Remove.
	(thread_stack_temporaries_enabled_p): Return bool.
	(push_thread_stack_temporary, value_in_thread_stack_temporaries)
	(get_last_thread_stack_temporary): Update.
	* eval.c (evaluate_subexp): Update.
	* gdbthread.h (class enable_thread_stack_temporaries): Now a
	class, not a function.
	(value_ptr, value_vec): Remove typedefs.
	(class thread_info) <stack_temporaries_enabled>: Now bool.
	<stack_temporaries>: Now a std::vector.
	(thread_stack_temporaries_enabled_p)
	(value_in_thread_stack_temporaries): Return bool.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use scoped_fd in more places
@ 2018-03-09  5:23 sergiodj+buildbot
  2018-03-09 23:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-09  5:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5dc1a7047a77f86de7518a99805af64891d4e22a ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 5dc1a7047a77f86de7518a99805af64891d4e22a

Use scoped_fd in more places

This changes a few more places to use scoped_fd.  This allows the
removal of some cleanups.

Regression tested by the buildbot, though note that I'm not sure
whether the buildbot actually builds anything using all of these
files.

gdb/ChangeLog
2018-03-08  Tom Tromey  <tom@tromey.com>

	* source.c (get_filename_and_charpos): Use scoped_fd.
	* nto-procfs.c (procfs_open_1): Use scoped_fd.
	(procfs_pidlist): Likewise.
	* procfs.c (proc_get_LDT_entry): Use scoped_fd.
	(iterate_over_mappings): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Update "gdb --configuration" with recently added features
@ 2018-03-09 14:17 sergiodj+buildbot
  2018-03-10  0:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-09 14:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9bd8e0b072ad5fc5b8956fd5d3e51dc5a9b0f236 ***

Author: Eli Zaretskii <eliz@gnu.org>
Branch: master
Commit: 9bd8e0b072ad5fc5b8956fd5d3e51dc5a9b0f236

Update "gdb --configuration" with recently added features

This adds display of a few recently added optional features.

gdb/ChangeLog:
2018-03-09  Eli Zaretskii  <eliz@gnu.org>

	* top.c (print_gdb_configuration): Reflect LIBIPT, LIBMEMCHECK,
	and LIBMPFR in the printed configuration.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix Sparc, s390 and AArch64 targets so that they can handle relocs against ifunc symbols found in note sections.
@ 2018-03-09 15:01 sergiodj+buildbot
  2018-03-10  1:35 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-09 15:01 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f657f8c4a1dc0ac69b16b1dc6eacbf5286f1f0a0 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: f657f8c4a1dc0ac69b16b1dc6eacbf5286f1f0a0

Fix Sparc, s390 and AArch64 targets so that they can handle relocs against ifunc symbols found in note sections.

  Following on from PR 22929, I have found the same problem exists with
  other ifunc supporting targets too.  Plus see this link for the bug
  being reported against the s390x binutils for Fedora rawhide:

     https://bugzilla.redhat.com/show_bug.cgi?id=1553705

  So I am going to check in the patch below which applies the same
  change that H.J. made for the x86_64 target to the other affected
  targets.  (Specifically: S390, AArch64 and Sparc).  Plus it adds a new
  test to the linker testsuite to make sure that this problem stays
  fixed.

bfd	* elf64-s390.c (elf_s390_relocate_section): Move check for
	relocations against non-allocated sections to before the code that
	handles ifunc relocations.
	* elf32-s390.c (elf_s390_relocate_section): Likewise.
	* elfnn-aarch64.c (elfNN_aarch64_final_link_relocate): Treat
	relocs against IFUNC symbols in non-allocated sections as relocs
	against FUNC symbols.
	* elfxx-sparc.c (_bfd_sparc_elf_relocate_section): Likewise.

ld	* testsuite/ld-ifunc/ifuncmod5.s: New test.  Checks that targets
	that support IFUNC symbols can handle relocations against those
	symbols in NOTE sections.
	* testsuite/ld-ifunc/ifuncmod5.d: New file:  Driver for the new
	test.
	* testsuite/ld-ifunc/ifunc.exp: Run the new test.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove cleanup from build_type_psymtabs_1
@ 2018-03-12  3:22 sergiodj+buildbot
  2018-03-12  3:38 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-12  3:22 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 484cf504af0e9403e3437a5d2c5fb361c73daa90 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 484cf504af0e9403e3437a5d2c5fb361c73daa90

Remove cleanup from build_type_psymtabs_1

This removes a cleanup from build_type_psymtabs_1, by using
std::vector rather than manual memory management.

gdb/ChangeLog
2018-03-11  Tom Tromey  <tom@tromey.com>

	* dwarf2read.c (sort_tu_by_abbrev_offset): Change to be suitable
	for use by std::sort.
	(build_type_psymtabs_1): Use std::vector.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use std::vector for field lists in dwarf2read.c
@ 2018-03-12  3:49 sergiodj+buildbot
  2018-03-12  4:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-12  3:49 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT be2daae6b8df45f3f6de5d94a1938cef54336a72 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: be2daae6b8df45f3f6de5d94a1938cef54336a72

Use std::vector for field lists in dwarf2read.c

This changes dwarf2read.c to use std::vector rather than a linked list
when managing the fields and base classes to be added to a type.  This
removes some bookkeeping types and also allows the removal of some
cleanups.

gdb/ChangeLog
2018-03-11  Tom Tromey  <tom@tromey.com>

	* dwarf2read.c (struct nextfield): Add initializers.
	(struct nextfnfield): Remove.
	(struct fnfieldlist): Add initializers.  Remove "length" and
	"head", use std::vector.
	(struct decl_field_list): Remove.
	(struct field_info): Add initializers.
	<fields, baseclasses>: Now std::vector.
	<nbaseclasses, nfnfields, typedef_field_list_count,
	nested_types_list_count>: Remove.
	(dwarf2_add_field, dwarf2_add_type_defn)
	(dwarf2_attach_fields_to_type, dwarf2_add_member_fn)
	(dwarf2_attach_fn_fields_to_type, handle_struct_member_die)
	(process_structure_scope): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix ia64 GDB build
@ 2018-03-12  9:32 sergiodj+buildbot
  2018-03-12  9:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-12  9:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 933522d1dbc9162fbc69453f0ab5f72998df2955 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 933522d1dbc9162fbc69453f0ab5f72998df2955

Fix ia64 GDB build

Commit 849d0ba8 breaks GDB build for ia64 with --with-libunwind-ia64=yes.
This patch fixes it.

gdb:

2018-03-12  Yao Qi  <yao.qi@linaro.org>

	* ia64-libunwind-tdep.c (libunwind_get_reg_special): Change
	parameter type to readable_regcache.
	* ia64-libunwind-tdep.h (libunwind_get_reg_special): Update
	the declaration.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use gdb::byte_vector when reading section data
@ 2018-03-12 14:44 sergiodj+buildbot
  2018-03-12 14:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-12 14:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 984c72381ccd9f950a87d4d7edecc6fa30db8b41 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 984c72381ccd9f950a87d4d7edecc6fa30db8b41

Use gdb::byte_vector when reading section data

This changes a couple of spots that read section data to use
gdb::byte_vector rather than a cleanup.

Regression tested by the buildbot.  I am not certain that the buildbot
actually tests the code in question, so I recommend careful review.

gdb/ChangeLog
2018-03-12  Tom Tromey  <tom@tromey.com>

	* rs6000-aix-tdep.c (rs6000_aix_core_xfer_shared_libraries_aix):
	Use gdb::byte_vector.
	* arm-tdep.c (arm_exidx_new_objfile): Use gdb::byte_vector.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb/riscv: Fix some ARI issues
@ 2018-03-12 22:14 sergiodj+buildbot
  2018-03-12 22:29 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-12 22:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 89a3b63e52be3e9bcf4b3d15e210652a5cb839c5 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 89a3b63e52be3e9bcf4b3d15e210652a5cb839c5

gdb/riscv: Fix some ARI issues

Fix some ARI issues in recently added riscv code, the ARI email is:

  https://sourceware.org/ml/gdb-patches/2018-03/msg00156.html

gdb/ChangeLog:

	* riscv-tdep.c (riscv_sw_breakpoint_from_kind): Add localization
	to error message string.
	(riscv_register_name): Use xsnprintf instead of sprintf.
	(riscv_insn::fetch_instruction): Use gdb_assert instead of
	internal_error.
	(riscv_print_arg_location): Use gdb_assert_not_reached instead of
	error.
	(riscv_push_dummy_call): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Prevent memory access violations when attempting to parse an x86_64 PE binary containing corrupt unwind information.
@ 2018-03-13 14:19 sergiodj+buildbot
  2018-03-13 15:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-13 14:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3e33b239450771394fa6c83b67b9de80169f35e8 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 3e33b239450771394fa6c83b67b9de80169f35e8

Prevent memory access violations when attempting to parse an x86_64 PE binary containing corrupt unwind information.

	PR 22113
incldue	* coff/pe.h (struct pex64_unwind_info): Add a rawUnwindCodesEnd
	field.

bfd	* pei-x86_64.c (pex64_get_unwind_info): Change to a boolean
	function.  Add an end address parameter.  Check access of the data
	pointer to make sure that they do not extend beyond the end
	address.  Return FALSE if any check fails.  Add the end address
	pointer to the ui structure.
	(pex64_xdata_print_uwd_codes): Check accesses of the raw unwind
	codes to make sure that they do not extend beyond the end address
	pointer.  Print an error message and return immediately if any
	check fails.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Updated Russian and Brazilian Portuguese translations.
@ 2018-03-13 17:14 sergiodj+buildbot
  2018-03-13 17:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-13 17:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b4a3689a68d88291d5aa73b9179322f58b562db7 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: b4a3689a68d88291d5aa73b9179322f58b562db7

Updated Russian and Brazilian Portuguese translations.

ld	* po/pt_BR.po: Updated Brazilian Portuguese translation.
opcodes	* po/pt_BR.po: Updated Brazilian Portuguese translation.
gas	* po/ru.po: Updated Russian translation.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove two cleanups using std::string
@ 2018-03-13 23:55 sergiodj+buildbot
  2018-03-14  0:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-13 23:55 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b577b6af8e7f4cc53e73ee01188d1700fb8d3b82 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: b577b6af8e7f4cc53e73ee01188d1700fb8d3b82

Remove two cleanups using std::string

This patches removes cleanups from a couple of spots by using
std::string rather than manual memory management.

Regression tested by the buildbot, though note that I don't believe
the buildbot actually exercises the machoread code.

gdb/ChangeLog
2018-03-13  Tom Tromey  <tom@tromey.com>

	* machoread.c (macho_check_dsym): Change filenamep to a
	std::string*.
	(macho_symfile_read): Update.
	* symfile.c (load_command): Use std::string.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] GC: Also check the local debug definition section
@ 2018-03-14 11:43 sergiodj+buildbot
  2018-03-14 11:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-14 11:43 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9e223787a474c672c5f1cfd4574857241ae4eafa ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 9e223787a474c672c5f1cfd4574857241ae4eafa

GC: Also check the local debug definition section

Extend

commit b7c871edcd83ccdc5fcd8148a7f433efd6b52255
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Wed May 17 07:57:15 2017 -0700

    Mark debug sections referenced by kept debug sections

to handle the local debug definition section.

bfd/

	PR ld/20882
	* elflink.c (elf_gc_mark_debug_section): Also check the local
	debug definition section.

ld/

	PR ld/20882
	* testsuite/ld-gc/pr20882.d: Also dump and check .debug_abbrev
	section.
	* testsuite/ld-gc/pr20882b.s: Add .debug_abbrev section.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PowerPC64 debian bug 886264, out-of-line save/restore functions
@ 2018-03-14 12:19 sergiodj+buildbot
  2018-03-14 13:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-14 12:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7dda8d3cf3b089bb7e03c4cdbec827fc6a188c88 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 7dda8d3cf3b089bb7e03c4cdbec827fc6a188c88

PowerPC64 debian bug 886264, out-of-line save/restore functions

This calculation in relocate_section

	      if (stub_entry->stub_type == ppc_stub_save_res)
		relocation += (stub_sec->output_offset
			       + stub_sec->output_section->vma
			       + stub_sec->size - htab->sfpr->size
			       - htab->sfpr->output_offset
			       - htab->sfpr->output_section->vma);

to adjust from the original out-of-line save/restore function address
in sfpr to a copy at the end of stub_sec goes wrong when stub_sec is
padded, because the copy is no longer at the end of stub_sec.  The
solution is to pad before copying sfpr, so the copy is always at the
end of stub_sec.

	* elf64-ppc.c (sfpr_define): Adjust for stub_sec size having
	sfpr size added before defining alias symbols.
	(ppc64_elf_build_stubs): Add stub section padding before
	copying sfpr contents and defining save/restore alias symbols.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Update my email address
@ 2018-03-14 13:59 sergiodj+buildbot
  2018-03-14 14:28 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-14 13:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0d671d99a6125e8406e4d06efb58542d3f0aa955 ***

Author: Yao Qi <qiyao@sourceware.org>
Branch: master
Commit: 0d671d99a6125e8406e4d06efb58542d3f0aa955

Update my email address

gdb:

2018-03-14  Yao Qi  <qiyao@sourceware.org>

	* MAINTAINERS: Update my email address.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add usage to printf command
@ 2018-03-14 16:04 sergiodj+buildbot
  2018-03-14 16:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-14 16:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 80ae639d3cc4f1e83f1ad48686f87417c06ca6dc ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 80ae639d3cc4f1e83f1ad48686f87417c06ca6dc

Add usage to printf command

This patch adds the "Usage:" text to the printf command's help text,
and tries to improve the text a tiny bit.

gdb/ChangeLog
2018-03-14  Tom Tromey  <tom@tromey.com>

	* printcmd.c (_initialize_printcmd): Add usage to printf.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Special case NULL when using printf's %s format
@ 2018-03-14 16:46 sergiodj+buildbot
  2018-03-14 19:05 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-14 16:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3ae9ce5dd7d1119ca2c94c63a07b04921048ebe3 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 3ae9ce5dd7d1119ca2c94c63a07b04921048ebe3

Special case NULL when using printf's %s format

This changes the printf command's %s and %ls formats to special-case
NULL, and print "(null)" for these.  This is PR cli/14977.  This
behavior seems a bit friendlier; I was undecided on whether other
invalid pointers should be handled specially somehow, so for the time
being I've left those out.

gdb/ChangeLog
2018-03-14  Tom Tromey  <tom@tromey.com>

	PR cli/14977:
	* printcmd.c (printf_c_string, printf_wide_c_string): Special case
	for NULL.

gdb/gdbserver/ChangeLog
2018-03-14  Tom Tromey  <tom@tromey.com>

	PR cli/14977:
	* ax.c (ax_printf): Special case for NULL.

gdb/testsuite/ChangeLog
2018-03-14  Tom Tromey  <tom@tromey.com>

	PR cli/14977:
	* gdb.base/printcmds.exp (test_printf): Add printf test of %s with
	a null pointer.
	* gdb.base/wchar.exp: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Allow - in %p for printf
@ 2018-03-14 17:26 sergiodj+buildbot
  2018-03-14 17:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-14 17:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b8c2339b2f46d4885b933b832fc5b37c7ca101a6 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: b8c2339b2f46d4885b933b832fc5b37c7ca101a6

Allow - in %p for printf

PR cli/19918 points out that a printf format like "%-5p" will cause a
gdb crash.  The bug is problem is that printf_pointer doesn't take the
"-" flag into account.

gdb/ChangeLog
2018-03-14  Tom Tromey  <tom@tromey.com>

	PR cli/19918:
	* printcmd.c (printf_pointer): Allow "-" in format.

gdb/testsuite/ChangeLog
2018-03-14  Tom Tromey  <tom@tromey.com>

	PR cli/19918:
	* gdb.base/printcmds.exp (test_printf): Add printf test using '-'
	flag.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] RISC-V: Add .insn support.
@ 2018-03-14 23:20 sergiodj+buildbot
  2018-03-14 23:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-14 23:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0e35537d754f1c687850d1caccb2d78d2e418391 ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 0e35537d754f1c687850d1caccb2d78d2e418391

RISC-V: Add .insn support.

	gas/ChangeLog
	2018-03-07  Kito Cheng  <kito.cheng@gmail.com>
	* config/tc-riscv.c (opcode_name_list): New.
	(opcode_names_hash): Likewise.
	(init_opcode_names_hash): Likewise.
	(opcode_name_lookup): Likewise.
	(validate_riscv_insn): New argument length, and add new format
	which used in .insn directive.
	(md_begin): Refine hash table initialization logic into
	init_opcode_hash.
	(init_opcode_hash): New.
	(my_getOpcodeExpression): Parse opcode name for .insn.
	(riscv_ip): New argument hash, able to handle .insn directive.
	(s_riscv_insn): Handler for .insn directive.
	(riscv_pseudo_table): New entry for .insn.
	* doc/c-riscv.texi: Add documentation for .insn directive.
	* testsuite/gas/riscv/insn.d: Add testcase for .insn directive.
	* testsuite/gas/riscv/insn.s: Likewise.

	include/ChangeLog
	2018-03-07  Kito Cheng  <kito.cheng@gmail.com>
	* opcode/riscv.h (OP_MASK_FUNCT3): New.
	(OP_SH_FUNCT3): Likewise.
	(OP_MASK_FUNCT7): Likewise.
	(OP_SH_FUNCT7): Likewise.
	(OP_MASK_OP2): Likewise.
	(OP_SH_OP2): Likewise.
	(OP_MASK_CFUNCT4): Likewise.
	(OP_SH_CFUNCT4): Likewise.
	(OP_MASK_CFUNCT3): Likewise.
	(OP_SH_CFUNCT3): Likewise.
	(riscv_insn_types): Likewise.

	opcodes/ChangeLog
	2018-03-07  Kito Cheng  <kito.cheng@gmail.com>
	* riscv-opc.c (riscv_insn_types): New.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] nds32: Remove the unsupported target feature.
@ 2018-03-15  8:04 sergiodj+buildbot
  2018-03-15  8:18 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-15  8:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f9671640954362a918c669700bcc9a57be25782d ***

Author: Kuan-Lin Chen <kuanlinchentw@gmail.com>
Branch: master
Commit: f9671640954362a918c669700bcc9a57be25782d

nds32: Remove the unsupported target feature.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] xtensa: bfd: fix assertion in xlate_offset_with_removed_text
@ 2018-03-15 21:11 sergiodj+buildbot
  2018-03-15 21:22 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-15 21:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0854d50445a11847f80e655482fd180d7c4e4d00 ***

Author: Max Filippov <jcmvbkbc@gmail.com>
Branch: master
Commit: 0854d50445a11847f80e655482fd180d7c4e4d00

xtensa: bfd: fix assertion in xlate_offset_with_removed_text

Linking objects containing jumps targeting the end of a section triggers
assertion in the xlate_offset_with_removed_text. Such jumps may be
generated by a compiler as a dead code and not removed at -O0. Allow
such jumps.
While at it make bsearch argument match comparison function expectations
and use bfd_vma for address fields in the struct xlate_map_entry.

bfd/
2018-03-15  Max Filippov  <jcmvbkbc@gmail.com>

	* elf32-xtensa.c (xlate_map_entry): Change types of address
	fields from 'unsigned' to 'bfd_vma'.
	(xlate_offset_with_removed_text): Use struct xlate_map_entry as
	the key argument to bsearch. Allow offsets past the end of a
	section, use the last map entry for translation of such offsets.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add selftest for substitute_path_component
@ 2018-03-16  2:19 sergiodj+buildbot
  2018-03-16  2:36 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-16  2:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 03afa6ef8ac9e5acfa68b1005aec6756eaa1d093 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 03afa6ef8ac9e5acfa68b1005aec6756eaa1d093

Add selftest for substitute_path_component

This patch add some unit tests for the substitute_path_component
function.

gdb/ChangeLog:

	* Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
	unittests/utils-selftests.c.
	* unittests/utils-selftests.c: New file.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix tspeed test case: copy libinproctrace to target
@ 2018-03-16 19:56 sergiodj+buildbot
  2018-03-16 20:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-16 19:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8b067d2cf5bf801eb143b4b04da5c22607673471 ***

Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: 8b067d2cf5bf801eb143b4b04da5c22607673471

Fix tspeed test case: copy libinproctrace to target

The tspeed test case does not execute correctly because libinproctrace.so
is not copied to the target.  This is fixed.

gdb/testsuite/ChangeLog:

	* gdb.trace/tspeed.exp: Add invocation of gdb_load_shlib to ensure
	that libinproctrace is copied to the target.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove make_cleanup_free_section_addr_info
@ 2018-03-16 20:41 sergiodj+buildbot
  2018-03-16 21:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-16 20:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 37e136b1684929df204ddd09c38978c705fa7228 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 37e136b1684929df204ddd09c38978c705fa7228

Remove make_cleanup_free_section_addr_info

This removes make_cleanup_free_section_addr_info.  Instead -- per
Simon's suggestion -- this changes section_addr_info to be a
std::vector.

Regression tested by the buildbot.

gdb/ChangeLog
2018-03-16  Tom Tromey  <tom@tromey.com>

	* xcoffread.c (xcoff_symfile_offsets): Change type of "addrs".
	* utils.h (make_cleanup_free_section_addr_info): Don't declare.
	* utils.c (do_free_section_addr_info)
	(make_cleanup_free_section_addr_info): Remove.
	* symfile.h (struct other_sections): Add constructor.
	(struct section_addr_info): Remove.
	(section_addr_info): New typedef.
	(struct sym_fns) <sym_offsets>: Change type of parameter.
	(build_section_addr_info_from_objfile)
	(relative_addr_info_to_section_offsets, addr_info_make_relative)
	(default_symfile_offsets, symbol_file_add)
	(symbol_file_add_from_bfd)
	(build_section_addr_info_from_section_table): Update.
	(alloc_section_addr_info, free_section_addr_info): Don't declare.
	* symfile.c (alloc_section_addr_info): Remove.
	(build_section_addr_info_from_section_table): Change return type.
	Update.
	(build_section_addr_info_from_bfd)
	(build_section_addr_info_from_objfile): Likewise.
	(free_section_addr_info): Remove.
	(relative_addr_info_to_section_offsets): Change type of "addrs".
	(addrs_section_compar): Now a std::sort comparator.
	(addrs_section_sort): Change return type.
	(addr_info_make_relative): Change type of "addrs".  Update.
	(default_symfile_offsets, syms_from_objfile_1)
	(syms_from_objfile, symbol_file_add_with_addrs): Likewise.
	(symbol_file_add_separate): Update.
	(symbol_file_add): Change type of "addrs".  Update.
	(add_symbol_file_command): Update.  Remove cleanups.
	* symfile-mem.c (symbol_file_add_from_memory): Update.  Remove
	cleanups.
	* symfile-debug.c (debug_sym_offsets): Change type of "info".
	* solib.c (solib_read_symbols): Update.
	* objfiles.c (objfile_relocate): Update.  Remove cleanups.
	* machoread.c (macho_symfile_offsets): Update.
	* jit.c (jit_bfd_try_read_symtab): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add silent Makefile rules
@ 2018-03-16 21:30 sergiodj+buildbot
  2018-03-16 22:43 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-16 21:30 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 39be3c7e98728df57cfddd37fb7747f1339a319b ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 39be3c7e98728df57cfddd37fb7747f1339a319b

Add silent Makefile rules

Many projects (e.g. the Linux kernel) and build systems use "silent"
rules, which means that they'll only print a summary of what's being
done instead of printing all the detailed command lines.  While chatting
on the #gdb IRC channel, I realized a few people (including me) thought
it would be nice to have it in GDB too.

The idea is that too much text is not useful, the important information
gets lost.  If there's only the essential information, it's more likely
to be useful.  Most of the time, when I look at the build output, it's
to see how it's progressing.  By just printing a brief summary of each
operation, I can easily spot what's currently being compiled and
therefore how the build progresses (with time you know the order in
which files are compiled almost by heart).

As with other projects (Linux, automake-based things, probably others),
it's possible to print the complete command lines by passing V=1 to make
(or any other non-zero value).

I had one hesitation about this: when people report build failures, we
are more likely to miss the full compile command line.  We'll probably
sometimes need to ask people to include the build log with "make V=1".
I don't think it's a big downside, if other projects the size of the
Linux kernel can live with it, I'm sure we can too.

gdb/ChangeLog:

	* silent-rules.mk: New.
	* Makefile.in: Include silent-rules.mk
	(srcdir, VPATH, top_srcdir): Move up.
	(COMPILE): Add ECHO_CXX.
	(test-cp-name-parser$(EXEEXT)): Add ECHO_CXXLD.
	(init.c): Add ECHO_INIT_C.
	(gdb$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
	(version.c): Add ECHO_GEN.
	(printcmd.o): Add ECHO_CXX.
	(target-float.o): Add ECHO_CXX.
	(ada-exp.o): Add ECHO_CXX.
	(stamp-xml): Add SILENCE and ECHO_GEN_XML_BUILTIN.
	(insight$(EXEEXT)): Add ECHO_CXXLD.
	* gnulib/configure.ac: Add AM_SILENT_RULES.
	* gnulib/aclocal.m4: Re-generate.
	* gnulib/configure: Re-generate.
	* gnulib/import/Makefile.in: Re-generate.

gdb/gdbserver/ChangeLog:

	* Makefile.in: Include silent-rules.mk.
	(srcdir, abs_top_srcdir, abs_srcdir, VPATH): Move up.
	(COMPILE): Add ECHO_CXX.
	(gdbserver$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
	(gdbreplay$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
	($(IPA_LIB)): Add SILENCE and ECHO_CXXLD.
	(version-generated.c): Add ECHO_GEN.
	(stamp-xml): Add SILENCE and ECHO_GEN_XML_BUILTIN_GENERATED.
	(IPAGENT_COMPILE): Add ECHO_CXX.
	(%-generated.c): Add ECHO_REGDAT.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove target_fileio_close_cleanup
@ 2018-03-17 15:47 sergiodj+buildbot
  2018-03-17 15:58 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-17 15:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 770623f79f7fdff38f62c641438759748cf3f138 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 770623f79f7fdff38f62c641438759748cf3f138

Remove target_fileio_close_cleanup

This removes target_fileio_close_cleanup in favor of a new RAII class.
The new class is similar to scoped_fd but calls
target_fileio_close_cleanup rather than close.

Regression tested by the buildbot.

gdb/ChangeLog
2018-03-17  Tom Tromey  <tom@tromey.com>

	* target.c (class scoped_target_fd): New.
	(target_fileio_close_cleanup): Remove.
	(target_fileio_read_alloc_1): Use scoped_target_fd.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Change auto_load_objfile_script_1 to use std::string
@ 2018-03-17 19:46 sergiodj+buildbot
  2018-03-17 19:59 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-17 19:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a06ab151cbab6f3da8735d2e5e06ede9454ca4c1 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: a06ab151cbab6f3da8735d2e5e06ede9454ca4c1

Change auto_load_objfile_script_1 to use std::string

This replaces some manual string manipulation in
auto_load_objfile_script_1 with std::string, simplifying the code and
allowing the removal of some cleanups.

Tested by the buildbot.

2018-03-17  Tom Tromey  <tom@tromey.com>

	* auto-load.c (auto_load_objfile_script_1): Use std::string.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove some cleanups from solib.c
@ 2018-03-19  4:11 sergiodj+buildbot
  2018-03-19  4:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-19  4:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1cb1f3dae747fef1a576fe38078891e545fa92e5 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 1cb1f3dae747fef1a576fe38078891e545fa92e5

Remove some cleanups from solib.c

This removes some cleanups from solib.c, replacing them with
gdb::def_vector.

Regression tested by the buildbot.

gdb/ChangeLog
2018-03-18  Tom Tromey  <tom@tromey.com>

	* solib.c (gdb_bfd_lookup_symbol_from_symtab): Use
	gdb::def_vector.
	(bfd_lookup_symbol_from_dyn_symtab): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Updated Spanish translation for the bfd/ sub-directory, and updated Ukranian translation for the gas/ sub-directory.
@ 2018-03-19 11:10 sergiodj+buildbot
  2018-03-19 11:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-19 11:10 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 315aa1cf834a3d78a567263fa3fbda9b2027457e ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 315aa1cf834a3d78a567263fa3fbda9b2027457e

Updated Spanish translation for the bfd/ sub-directory, and updated Ukranian translation for the gas/ sub-directory.

bfd	* po/es.po: Updated Spanish translation.
gas	* po/uk.po: Updated Ukranian translation.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Testsuite: Fix ambiguous "break" due to libinproctrace
@ 2018-03-19 12:29 sergiodj+buildbot
  2018-03-19 12:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-19 12:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 194ed4130dadb7dd1668f6af87405bdcd8041199 ***

Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: 194ed4130dadb7dd1668f6af87405bdcd8041199

Testsuite: Fix ambiguous "break" due to libinproctrace

Some of GDB's trace test cases define a function end() and place a
breakpoint there with "break end".  However, when libinproctrace is linked
to the binary, there are multiple methods named "end", such as
std::string::end() from the C++ library or format_pieces::end() from
common/format.h.  GDB then creates multiple breakpoints instead of just a
single one, and some FAILs result, such as these:

  FAIL: gdb.trace/trace-mt.exp: ftrace on: break end
  FAIL: gdb.trace/trace-mt.exp: ftrace off: break end

Fix this by adding the "-qualified" option to the break commands.  For
consistency, change all occurrences of "break end" (and similar) in all
trace test cases, even if the current behavior does not cause problems.
Also, consequently use the gdb_breakpoint convenience proc.

gdb/testsuite/ChangeLog:

	* gdb.trace/actions-changed.exp: Call gdb_breakpoint with the
	"qualified" option when setting breakpoints.
	* gdb.trace/backtrace.exp: Likewise.
	* gdb.trace/circ.exp: Likewise.
	* gdb.trace/collection.exp: Likewise.
	* gdb.trace/disconnected-tracing.exp: Likewise.
	* gdb.trace/ftrace-lock.exp: Likewise.
	* gdb.trace/ftrace.exp: Likewise.
	* gdb.trace/infotrace.exp: Likewise.
	* gdb.trace/packetlen.exp: Likewise.
	* gdb.trace/passc-dyn.exp: Likewise.
	* gdb.trace/qtro.exp: Likewise.
	* gdb.trace/read-memory.exp: Likewise.
	* gdb.trace/report.exp: Likewise.
	* gdb.trace/signal.exp: Likewise.
	* gdb.trace/status-stop.exp: Likewise.
	* gdb.trace/strace.exp: Likewise.
	* gdb.trace/tfind.exp: Likewise.
	* gdb.trace/trace-break.exp: Likewise.
	* gdb.trace/trace-condition.exp: Likewise.
	* gdb.trace/trace-mt.exp: Likewise.
	* gdb.trace/tstatus.exp: Likewise.
	* gdb.trace/tsv.exp: Likewise.
	* gdb.trace/unavailable-dwarf-piece.exp: Likewise.
	* gdb.trace/unavailable.exp: Likewise.
	* gdb.trace/while-dyn.exp: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Convert observers to C++
@ 2018-03-19 15:59 sergiodj+buildbot
  2018-03-19 16:11 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-19 15:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 76727919ceb590f03ff0f6db08b7ceab5b7aeaff ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 76727919ceb590f03ff0f6db08b7ceab5b7aeaff

Convert observers to C++

This converts observers from using a special source-generating script
to be plain C++.  This version of the patch takes advantage of C++11
by using std::function and variadic templates; incorporates Pedro's
patches; and renames the header file to "observable.h" (this change
eliminates the need for a clean rebuild).

Note that Pedro's patches used a template lambda in tui-hooks.c, but
this failed to compile on some buildbot instances (presumably due to
differing C++ versions); I replaced this with an ordinary template
function.

Regression tested on the buildbot.

gdb/ChangeLog
2018-03-19  Pedro Alves  <palves@redhat.com>
	    Tom Tromey  <tom@tromey.com>

	* unittests/observable-selftests.c: New file.
	* common/observable.h: New file.
	* observable.h: New file.
	* ada-lang.c, ada-tasks.c, agent.c, aix-thread.c, annotate.c,
	arm-tdep.c, auto-load.c, auxv.c, break-catch-syscall.c,
	breakpoint.c, bsd-uthread.c, cli/cli-interp.c, cli/cli-setshow.c,
	corefile.c, dummy-frame.c, event-loop.c, event-top.c, exec.c,
	extension.c, frame.c, gdbarch.c, guile/scm-breakpoint.c,
	infcall.c, infcmd.c, inferior.c, inflow.c, infrun.c, jit.c,
	linux-tdep.c, linux-thread-db.c, m68klinux-tdep.c,
	mi/mi-cmd-break.c, mi/mi-interp.c, mi/mi-main.c, objfiles.c,
	ppc-linux-nat.c, ppc-linux-tdep.c, printcmd.c, procfs.c,
	python/py-breakpoint.c, python/py-finishbreakpoint.c,
	python/py-inferior.c, python/py-unwind.c, ravenscar-thread.c,
	record-btrace.c, record-full.c, record.c, regcache.c, remote.c,
	riscv-tdep.c, sol-thread.c, solib-aix.c, solib-spu.c, solib.c,
	spu-multiarch.c, spu-tdep.c, stack.c, symfile-mem.c, symfile.c,
	symtab.c, thread.c, top.c, tracepoint.c, tui/tui-hooks.c,
	tui/tui-interp.c, valops.c: Update all users.
	* tui/tui-hooks.c (tui_bp_created_observer)
	(tui_bp_deleted_observer, tui_bp_modified_observer)
	(tui_inferior_exit_observer, tui_before_prompt_observer)
	(tui_normal_stop_observer, tui_register_changed_observer):
	Remove.
	(tui_observers_token): New global.
	(attach_or_detach, tui_attach_detach_observers): New functions.
	(tui_install_hooks, tui_remove_hooks): Use
	tui_attach_detach_observers.
	* record-btrace.c (record_btrace_thread_observer): Remove.
	(record_btrace_thread_observer_token): New global.
	* observer.sh: Remove.
	* observer.c: Rename to observable.c.
	* observable.c (namespace gdb_observers): Define new objects.
	(observer_debug): Move into gdb_observers namespace.
	(struct observer, struct observer_list, xalloc_observer_list_node)
	(xfree_observer_list_node, generic_observer_attach)
	(generic_observer_detach, generic_observer_notify): Remove.
	(_initialize_observer): Update.
	Don't include observer.inc.
	* Makefile.in (generated_files): Remove observer.h, observer.inc.
	(clean mostlyclean): Likewise.
	(observer.h, observer.inc): Remove targets.
	(SUBDIR_UNITTESTS_SRCS): Add observable-selftests.c.
	(COMMON_SFILES): Use observable.c, not observer.c.
	* .gitignore: Remove observer.h.

gdb/doc/ChangeLog
2018-03-19  Tom Tromey  <tom@tromey.com>

	* observer.texi: Remove.

gdb/testsuite/ChangeLog
2018-03-19  Tom Tromey  <tom@tromey.com>

	* gdb.gdb/observer.exp: Remove.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Support bare-identifier field initializers in Rust
@ 2018-03-19 17:31 sergiodj+buildbot
  2018-03-19 17:44 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-19 17:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 926300415b642367cdc2febac6619f8cb8a80b46 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 926300415b642367cdc2febac6619f8cb8a80b46

Support bare-identifier field initializers in Rust

In Rust one can initialize a struct member from an identically-named
local variable by simply mentioning the member name in the
initializer, like:

    let x = 0;
    let y = Struct { x };

This initializes "Struct::x" from "x".

This patch adds this form of initializer to the Rust expression parser
and adds a test.

Tested on x86-64 Fedora 26 using rustc 1.23.

2018-03-19  Tom Tromey  <tom@tromey.com>

	* rust-exp.y (struct_expr_tail, struct_expr_list): Add plain
	"IDENT" production.

2018-03-19  Tom Tromey  <tom@tromey.com>

	* gdb.rust/simple.rs (main): Add local variables field1, field2,
	y0.
	* gdb.rust/simple.exp: Test bare identifier form of struct
	initializer.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Set non_ir_ref_dynamic if a symbol is made dynamic
@ 2018-03-20 11:08 sergiodj+buildbot
  2018-03-20 11:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-20 11:08 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 416c34d683f2a17aefe19afb466af4316c7c603b ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 416c34d683f2a17aefe19afb466af4316c7c603b

Set non_ir_ref_dynamic if a symbol is made dynamic

If a symbol is made dynamic by --dynamic-list, it has non-IR reference.

bfd/

	PR ld/22983
	* elflink.c (bfd_elf_link_mark_dynamic_symbol): Set
	non_ir_ref_dynamic if a symbol is made dynamic by --dynamic-list.

ld/

	PR ld/22983
	* testsuite/ld-plugin/lto.exp: Run PR ld/22983 test.
	* testsuite/ld-plugin/pr22983.d: New file.
	* testsuite/ld-plugin/pr22983.t: Likewise.
	* testsuite/ld-plugin/pr22983a.c: Likewise.
	* testsuite/ld-plugin/pr22983b.c: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Replace the linear search in find_pc_sect_line with a binary search.
@ 2018-03-20 14:14 sergiodj+buildbot
  2018-03-20 14:35 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-20 14:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4ee89e903de920496a69c01df70db13a70a2a0be ***

Author: Stephen Roberts <stephen.roberts@arm.com>
Branch: master
Commit: 4ee89e903de920496a69c01df70db13a70a2a0be

Replace the linear search in find_pc_sect_line with a binary search.

This patch addresses slowness when setting breakpoints, especially in
heavily templatized code. Profiling showed that find_pc_sect_line in
symtab.c was the performance bottleneck.  The original logic performed a
linear search over ordered data. This patch uses a binary search, as
suggested by comments around the function.  There are no behavioural
changes, but gdb is now faster at setting breakpoints in template code.
Tested using on make check on an x86 target. The optimisation speeds up
the included template-breakpoints.py performance test by a factor of 7
on my machine.

ChangeLog:

2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>

        * gdb/symtab.c (find_pc_sect_line): now uses binary search.

gdb/testsuite/

        * gdb.perf/template-breakpoints.cc: New file.
        * gdb.perf/template-breakpoints.exp: New file.
        * gdb.perf/template-breakpoints.py: New file.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix misleading indentation error.
@ 2018-03-20 16:41 sergiodj+buildbot
  2018-03-20 16:53 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-20 16:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7cbe16e99d8a61a168579354487902ee50413e08 ***

Author: Stephen Roberts <stephen.roberts@arm.com>
Branch: master
Commit: 7cbe16e99d8a61a168579354487902ee50413e08

Fix misleading indentation error.

This patch fixes a compile error introduced by my previous change, which
caused the indentation of the following code block to become incorrect.

ChangeLog:

2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>

        * gdb/symtab.c (find_pc_sect_line): fixed indentation.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Don't exceed reloc array bounds
@ 2018-03-21 11:32 sergiodj+buildbot
  2018-03-21 11:44 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-21 11:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 675e28092f9d92c56c38d40d13ad5b766bdede05 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 675e28092f9d92c56c38d40d13ad5b766bdede05

Don't exceed reloc array bounds

	* elf64-ppc.c (ppc64_elf_relocate_section): Don't access rel[1]
	without first checking array bounds.
	* elf32-ppc.c (ppc_elf_relocate_section): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Correct multi-toc tprel relocs
@ 2018-03-21 11:46 sergiodj+buildbot
  2018-03-21 13:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-21 11:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6a3858a69e6bdff1d10136c59bfcf7a0cbe47059 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 6a3858a69e6bdff1d10136c59bfcf7a0cbe47059

Correct multi-toc tprel relocs

Commit f15d0b545b trimmed some unnecessary TPREL relocs, but missed
changing another place where they are allocated.

	* elf64-ppc.c (ppc_size_one_stub): Fix comment typo.
	(ppc64_elf_layout_multitoc): Allocate relocs for tprel as we
	do in size_dynamic_sections.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Make tls_mask unsigned in elf32-ppc.c
@ 2018-03-21 11:59 sergiodj+buildbot
  2018-03-21 14:27 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-21 11:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bac3c8c5e7fb88ddb3615b895ad57847b9842171 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: bac3c8c5e7fb88ddb3615b895ad57847b9842171

Make tls_mask unsigned in elf32-ppc.c

	* elf32-ppc.c (struct ppc_elf_link_hash_entry): Make tls_mask
	field unsigned.
	(update_local_sym_info): Likewise for local_got_tls_masks.
	(ppc_elf_tls_optimize): Likewise for lgot_masks.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Delete unused elf32-ppc.c code
@ 2018-03-21 12:13 sergiodj+buildbot
  2018-03-21 15:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-21 12:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4bad6366a74c9cdf92e6aef3849c29771c77af36 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 4bad6366a74c9cdf92e6aef3849c29771c77af36

Delete unused elf32-ppc.c code

Local symbols were being read but not used.

	* elf32-ppc.c (ppc_elf_tls_optimize): Delete locsyms.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PowerPC64 synthetic symbols
@ 2018-03-21 12:27 sergiodj+buildbot
  2018-03-21 17:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-21 12:27 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0ccf57bd817a73e7d7cef714039f1302fa5298ec ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 0ccf57bd817a73e7d7cef714039f1302fa5298ec

PowerPC64 synthetic symbols

STT_FILE and a bunch of other symbol types aren't proper symbols to
mark the start of a function's code.

	* elf64-ppc.c (ppc64_elf_get_synthetic_symtab): Trim uninteresting
	symbols.  Use size_t counts.  Delete redundant opd test.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] S390: Enable re-attaching with native-extended-gdbserver
@ 2018-03-21 16:59 sergiodj+buildbot
  2018-03-21 18:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-21 16:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7edb9bd32ba23247a509cbe9d44ccb02da97b66e ***

Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: 7edb9bd32ba23247a509cbe9d44ccb02da97b66e

S390: Enable re-attaching with native-extended-gdbserver

On s390x, when running attach.exp with native-extended-gdbserver,
gdbserver crashes in find_regno like this:

  .../regcache.c:252: A problem internal to GDBserver has been detected.
  Unknown register tdb0 requested

On the GDB side it looks like this:

  (gdb) attach 31568
  Attaching to process 31568
  Remote connection closed

The test case attempts to attach to a new process via the already running
gdbserver.  Thus s390_arch_setup is called a second time, and that's where
the problem occurs.  In order to determine the word width (32 or 64 bits),
s390_arch_setup reads the pswm register through the regcache.  For that it
uses a temporary tdesc which is supposed to work for all s390 targets,
since the actual tdesc has not been determined yet.  But in this second
round this doesn't work, because s390_regsets has been updated already and
now contains regsets not described by the temporary tdesc, such as the one
containing tdb0.

This is fixed by rearranging the logic in s390_arch_setup.

gdb/gdbserver/ChangeLog:

	* linux-s390-low.c (s390_get_hwcap): Replace tdesc parameter by
	the word size.  Add comment.
	(s390_get_wordsize): New function.
	(s390_arch_setup): No longer select a temporary tdesc to fetch the
	pswm with it.  Instead, use s390_get_wordsize to determine the
	word size first and derive the correct tdesc from that directly.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] S390: gdbserver: Don't write guarded storage registers
@ 2018-03-21 17:13 sergiodj+buildbot
  2018-03-21 20:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-21 17:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c49bd90bdb03f3013a796ea920830547cacc3c48 ***

Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: c49bd90bdb03f3013a796ea920830547cacc3c48

S390: gdbserver: Don't write guarded storage registers

On S390, the guarded storage register set is only valid if guarded storage
is active.  Reading/writing the register set yields errors if this is not
the case.  Then gdbserver emits warnings like these:

  Warning: ptrace(regsets_store_inferior_registers): No data available

Apart from confusing the user, this can also lead to test case failures
due to unexpected output.  To suppress this, make the guarded storage
regsets read-only for now.

gdb/gdbserver/ChangeLog:

	* linux-s390-low.c (s390_fill_gs): Remove function.
	(s390_fill_gsbc): Remove function.
	(s390_regsets): Set fill functions for the guarded storage regsets
	to NULL.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] S390: Make IPA recognize tdescs with guarded storage
@ 2018-03-21 18:30 sergiodj+buildbot
  2018-03-21 21:27 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-21 18:30 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ce29f8439f94adfa56655940e657afbe07a0c99e ***

Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: ce29f8439f94adfa56655940e657afbe07a0c99e

S390: Make IPA recognize tdescs with guarded storage

The in-process agent does not handle tdescs with guarded storage yet.
This is fixed.

gdb/gdbserver/ChangeLog:

	* linux-s390-ipa.c (get_ipa_tdesc): Add handling for
	S390_TDESC_GS.
	* linux-s390-low.c (s390_get_ipa_tdesc_idx): Likewise.
	(initialize_low_tracepoint): Call init_registers_s390x_gs_linux64
	and init_registers_s390_gs_linux64.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] DT_FLAGS_1: Add Solaris bits
@ 2018-03-21 20:10 sergiodj+buildbot
  2018-03-21 22:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-21 20:10 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b1202ffa53484b65d95787fddef1bc6175e05ca9 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: b1202ffa53484b65d95787fddef1bc6175e05ca9

DT_FLAGS_1: Add Solaris bits

The following bits in DT_FLAGS_1 are used by Solaris:

 #define DF_1_KMOD       0x10000000 /* kernel module */
 #define DF_1_WEAKFILTER 0x20000000 /* apply weak binding to DT_FILTER */
 #define DF_1_NOCOMMON   0x40000000 /* no COMMON symbols exist */

binutils/

	* readelf.c (process_dynamic_section): Also dump DF_1_KMOD,
	DF_1_WEAKFILTER and DF_1_NOCOMMON.

include/

	* elf/common.h (DF_1_KMOD): New.
	(DF_1_WEAKFILTER): Likewise.
	(DF_1_NOCOMMON): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add myself as a write-after-approval GDB maintainer.
@ 2018-03-21 20:49 sergiodj+buildbot
  2018-03-22  0:04 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-21 20:49 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7eb2418fa4641c60f6713986de7d3a50fd7a22c0 ***

Author: Pedro Franco de Carvalho <pedromfc@linux.vnet.ibm.com>
Branch: master
Commit: 7eb2418fa4641c60f6713986de7d3a50fd7a22c0

Add myself as a write-after-approval GDB maintainer.

gdb/ChangeLog:

2018-03-21  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>

	* MAINTAINERS (Write After Approval): Add Pedro Franco de
	Carvalho.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Make parse_static_tracepoint_marker_definition work with multiple static tracepoint definitions
@ 2018-03-22  4:50 sergiodj+buildbot
  2018-03-22  5:02 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-22  4:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 62c222b6d9fcce8adf65f48fca2e528f777afeeb ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 62c222b6d9fcce8adf65f48fca2e528f777afeeb

Make parse_static_tracepoint_marker_definition work with multiple static tracepoint definitions

Since I modify the parse_static_tracepoint_marker_definition function in
the next patch, I wanted to write a unit test for it.  Doing so showed
that it doesn't handle multiple consecutive static tracepoint
definitions separated by commas.  However, the RSP documentation [1]
states that servers may return multiple definitions, like:

  1234:6d61726b657231:6578747261207374756666,abba:6d61726b657232:

The problem is that the function uses strlen to compute the length of
the last field (the extra field).  If there are additional definitions
in addition to the one we are currently parsing, the returned length
will include those definitions, and we'll try to hex-decode past the
extra field.

This patch changes parse_static_tracepoint_marker_definition to consider
the case where the current definition is followed by a comma and more
definitions.  It also adds the unit test that found the issue in the
first place.

I don't think this causes any backwards compatibility issues, because
the previous code only handled single static tracepoint definitions, and
the new code handles that correctly.

gdb/ChangeLog:

	* tracepoint.c (parse_static_tracepoint_marker_definition):
	Consider case where the definition is followed by more
	definitions.
	* Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
	tracepoint-selftests.c.
	* unittests/tracepoint-selftests.c: New.

[1] https://sourceware.org/gdb/onlinedocs/gdb/Tracepoint-Packets.html#qTfSTM


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Get rid of VEC(static_tracepoint_marker_p)
@ 2018-03-22  5:04 sergiodj+buildbot
  2018-03-22  6:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-22  5:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5d9310c4b88f807c1a3f1a0b4d7b6c10925dcaf7 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 5d9310c4b88f807c1a3f1a0b4d7b6c10925dcaf7

Get rid of VEC(static_tracepoint_marker_p)

This patch replaces VEC(static_tracepoint_marker_p) with std::vector,
and does some c++ification around that.  I thought a new overload of
hex2str was useful, so I added it as well as corresponding unit tests.
I also added an overload of ui_out::field_string that takes an
std::string directly.

gdb/ChangeLog:

	* tracepoint.h (struct static_tracepoint_marker): Initialize
	fields, define default constructor, move constructor and move
	assignment, disable the rest.
	<str_id, extra>: Make std::string.
	(release_static_tracepoint_marker): Remove.
	(free_current_marker): Remove.
	* tracepoint.c (free_current_marker): Remove.
	(parse_static_tracepoint_marker_definition): Adjust to
	std::string, use new hex2str overload.
	(release_static_tracepoint_marker): Remove.
	(print_one_static_tracepoint_marker): Get marker by reference
	and adjust to std::string.
	(info_static_tracepoint_markers_command): Adjust to std::vector
	changes
	* target.h (static_tracepoint_marker_p): Remove typedef.
	(DEF_VEC_P(static_tracepoint_marker_p)): Remove.
	(struct target_ops) <to_static_tracepoint_marker_at>: Return
	bool.
	<to_static_tracepoint_markers_by_strid>: Return std::vector.
	* target-debug.h
	(target_debug_print_VEC_static_tracepoint_marker_p_p): Remove.
	(target_debug_print_std_vector_static_tracepoint_marker): New.
	(target_debug_print_struct_static_tracepoint_marker_p): Rename
	to...
	(target_debug_print_static_tracepoint_marker_p): ... this.
	* target-delegates.c: Re-generate.
	* breakpoint.h (struct tracepoint) <static_trace_marker_id>:
	Make std::string.
	* breakpoint.c (init_breakpoint_sal): Adjust to std::string.
	(decode_static_tracepoint_spec): Adjust to std::vector.
	(tracepoint_print_one_detail): Adjust to std::string.
	(strace_marker_decode_location): Adjust to std::string.
	(update_static_tracepoint): Adjust to std::string, remove call
	to release_static_tracepoint_marker.
	* linux-nat.c (linux_child_static_tracepoint_markers_by_strid):
	Adjust to std::vector.
	* remote.c (remote_static_tracepoint_marker_at): Return bool.
	(remote_static_tracepoint_markers_by_strid): Adjust to
	std::vector.
	* common/rsp-low.h (hex2str): New overload with explicit count
	of bytes.
	* common/rsp-low.c (hex2str): New overload with explicit count
	of bytes.
	* unittests/rsp-low-selftests.c (test_hex2str): New function.
	(_initialize_rsp_low_selftests): Add test_hex2str test.
	* unittests/tracepoint-selftests.c
	(test_parse_static_tracepoint_marker_definition): Adjust to
	std::string.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: fold a few XOP templates
@ 2018-03-22  7:50 sergiodj+buildbot
  2018-03-22  8:06 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-22  7:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f776822506b417ce25170c67c33cc05870b37adf ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: f776822506b417ce25170c67c33cc05870b37adf

x86: fold a few XOP templates

Also add a new test case verifying that mixed operands of SIMD insns
with a size-less memory operand in the middle are properly rejected.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86/Intel: fix fallout from earlier template folding
@ 2018-03-22  8:02 sergiodj+buildbot
  2018-03-22 10:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-22  8:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d6793fa1acf384a93c83db6eb916e3b9eedd9ef4 ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: d6793fa1acf384a93c83db6eb916e3b9eedd9ef4

x86/Intel: fix fallout from earlier template folding

While many templates allowing multiple suitably matching XMM/YMM/ZMM
operand sizes can be folded, a few need to be split in order to not
wrongly accept "xmmword ptr" operands when only XMM registers are
permitted (and memory operands are more narrow). Add a test case
validating this.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: fix swapped operand handling for BNDMOV
@ 2018-03-22  8:17 sergiodj+buildbot
  2018-03-22 11:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-22  8:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9f79e88693dae859f838bcf684158e6e6f8f3b6b ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 9f79e88693dae859f838bcf684158e6e6f8f3b6b

x86: fix swapped operand handling for BNDMOV

The wrong placement of the Load attribute in the templates prevented
this from working. The disassembler also didn't handle this consistently
with other similar dual-encoding insns.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: drop remaining redundant DispN
@ 2018-03-22  8:31 sergiodj+buildbot
  2018-03-22 12:53 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-22  8:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 96bc132a736fe44cc021d5d4e8ed6780b9520f22 ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 96bc132a736fe44cc021d5d4e8ed6780b9520f22

x86: drop remaining redundant DispN

A few of them were missed in commit 7ac2002247 ("x86: derive DispN
from BaseIndex") and also couldn't be removed by subsequent commits
touching certain templates anyway.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] S390: Correct brace style in s390_get_wordsize
@ 2018-03-22  9:20 sergiodj+buildbot
  2018-03-22 15:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-22  9:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f69c5afb18871a773af88484a24d7da12c3a104c ***

Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: f69c5afb18871a773af88484a24d7da12c3a104c

S390: Correct brace style in s390_get_wordsize

This corrects bad formatting in the newly introduced function
s390_get_wordsize.

gdb/gdbserver/ChangeLog:

	* linux-s390-low.c (s390_get_wordsize): Correct brace style.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Make "info proc cmdline" show args on GNU/Linux
@ 2018-03-22  9:34 sergiodj+buildbot
  2018-03-22 16:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-22  9:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 26d6cec4a9291f154e549fb6f4318ace6cfaa2a5 ***

Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: 26d6cec4a9291f154e549fb6f4318ace6cfaa2a5

Make "info proc cmdline" show args on GNU/Linux

Currently "info proc cmdline" on GNU/Linux does not show the full command
line, but only argument 0.  And even a warning is shown if there are more.
This was discussed in 2014 already:

  https://sourceware.org/ml/gdb-patches/2014-04/msg00212.html

Follow the advice there and avoid target_fileio_read_stralloc.  Instead,
use target_fileio_read_alloc to read the whole command line and then
replace NUL characters by spaces.  Also add an appropriate test case.
Note that gdbserver already handles this correctly.

gdb/ChangeLog:

	* linux-tdep.c (linux_info_proc): For "info proc cmdline", print
	command line args instead of emitting a warning.

gdb/testsuite/ChangeLog:

	* gdb.base/info-proc.exp: Add test for "info proc cmdline".


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: drop pointless VecESize
@ 2018-03-22 11:31 sergiodj+buildbot
  2018-03-22 14:13 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-22 11:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b8c169f359dd99900994baff60c57417f13351b3 ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: b8c169f359dd99900994baff60c57417f13351b3

x86: drop pointless VecESize

The attribute is meaningful only in templates allowing embedded
broadcast. Drop them everywhere else.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] ppc: Detect when LR is saved through frame pointer
@ 2018-03-22 13:41 sergiodj+buildbot
  2018-03-22 18:27 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-22 13:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT dd6d677f0b06341dce90d259785c9d513d2e3935 ***

Author: Pedro Franco de Carvalho <pedromfc@linux.vnet.ibm.com>
Branch: master
Commit: dd6d677f0b06341dce90d259785c9d513d2e3935

ppc: Detect when LR is saved through frame pointer

This patch extends rs6000-tdep.c:skip_prologue so that it can detect
when the Link Register is saved using the frame pointer (usually r31)
in adition to the stack pointer (r1).

The frame pointer offset from the frame base is tracked separately
from the stack pointer offset for cases when the frame pointer is not
in synch with the stack pointer at the moment of the LR save.

Previously, "stq" could also be detected as an instruction that saves
LR or CR. Because this was likely unintentional, this patch also
restricts the matches to stw/stwu/std/stdu.

gdb/ChangeLog:

	* rs6000-tdep.c (store_insn_p): New function.
	(skip_prologue): New variable alloca_reg_offset. Set lr_reg
	and cr_reg to their unshifted values. Use store_insn_p to
	match LR saves using either R1 or fdata->alloca_reg. Use
	store_insn_p to match CR saves. Set alloca_reg_offset
	when alloca_reg and framep are set. Remove lr_reg shift
	when assigning to fdata->lr_register.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] ppc: Fix stwux and stdux masks in skip_prologue
@ 2018-03-22 13:54 sergiodj+buildbot
  2018-03-22 19:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-22 13:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7a8f494c7b171f6cbad20a14ef03a5d7acaa6ccb ***

Author: Pedro Franco de Carvalho <pedromfc@linux.vnet.ibm.com>
Branch: master
Commit: 7a8f494c7b171f6cbad20a14ef03a5d7acaa6ccb

ppc: Fix stwux and stdux masks in skip_prologue

This patch merges the masks for matching the stwux and stdux
instructions in rs6000-tdep.c:skip_prologue into a single mask that
only matches these two instructions.

Commit 72dd273062 fixed the warning described in PR tdep/18295, this
patch addresses the comment in the same PR indicating that the mask
was too permissive.

gdb/Changelog:

	PR tdep/18295
	* rs6000-tdep.c (skip_prologue): Match both stwux and stdux
	a single mask.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove some cleanups from record-full.c
@ 2018-03-23  3:37 sergiodj+buildbot
  2018-03-23  3:54 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-23  3:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a2b2bc12af45f48617729c1413a1a01c0ee957ca ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: a2b2bc12af45f48617729c1413a1a01c0ee957ca

Remove some cleanups from record-full.c

This removes some cleanups from record-full.c in a straightforward
way.

Tested by the buildbot.

gdb/ChangeLog
2018-03-22  Tom Tromey  <tom@tromey.com>

	* record-full.c (record_full_exec_insn): Use gdb::byte_vector.
	(record_full_goto_bookmark): Use std::string.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Testsuite: fully migrate to use_gdb_stub convenience func
@ 2018-03-23  9:56 sergiodj+buildbot
  2018-03-23 10:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-23  9:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 079670b94ade4b5792fa74b29a6b5b4626f27185 ***

Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: 079670b94ade4b5792fa74b29a6b5b4626f27185

Testsuite: fully migrate to use_gdb_stub convenience func

In the GDB test suite, there are still multiple invocations of
"target_info exists use_gdb_stub".  However, the recommended way of
checking for use_gdb_stub is to call the convenience function of the same
name.

Replace these occurrences and just call "use_gdb_stub" instead.

gdb/testsuite/ChangeLog:

	* gdb.ada/exec_changed.exp: Replace "target_info exists
	use_gdb_stub" by "use_gdb_stub".
	* gdb.ada/start.exp: Likewise.
	* gdb.base/async-shell.exp: Likewise.
	* gdb.base/attach-pie-misread.exp: Likewise.
	* gdb.base/attach-wait-input.exp: Likewise.
	* gdb.base/break-entry.exp: Likewise.
	* gdb.base/break-interp.exp: Likewise.
	* gdb.base/dprintf-detach.exp: Likewise.
	* gdb.base/nostdlib.exp: Likewise.
	* gdb.base/solib-nodir.exp: Likewise.
	* gdb.base/statistics.exp: Likewise.
	* gdb.base/testenv.exp: Likewise.
	* gdb.mi/mi-exec-run.exp: Likewise.
	* gdb.mi/mi-start.exp: Likewise.
	* gdb.multi/dummy-frame-restore.exp: Likewise.
	* gdb.multi/multi-arch-exec.exp: Likewise.
	* gdb.multi/multi-arch.exp: Likewise.
	* gdb.multi/tids.exp: Likewise.
	* gdb.multi/watchpoint-multi.exp: Likewise.
	* gdb.python/py-events.exp: Likewise.
	* gdb.threads/attach-into-signal.exp: Likewise.
	* gdb.threads/attach-stopped.exp: Likewise.
	* gdb.threads/threadapply.exp: Likewise.
	* lib/selftest-support.exp: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Move gdbserver tdesc header funcs to c file
@ 2018-03-23 11:26 sergiodj+buildbot
  2018-03-23 11:39 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-23 11:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d80e524238a17878eee0c620d56e2fad072556bc ***

Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: d80e524238a17878eee0c620d56e2fad072556bc

Move gdbserver tdesc header funcs to c file

gdbserver/
	* tdesc.c (target_desc::~target_desc): Move to here.
	(target_desc::operator==): Likewise.
	* tdesc.h (target_desc::~target_desc): Move from here.
	(target_desc::operator==): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb: Minor cleanup in some gdb.arch/* tests
@ 2018-03-23 12:14 sergiodj+buildbot
  2018-03-23 13:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-23 12:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 066cfa988ddf88ad32b7a114f2e984a13a3848c8 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 066cfa988ddf88ad32b7a114f2e984a13a3848c8

gdb: Minor cleanup in some gdb.arch/* tests

A small number of tests incorrectly tried to pass -Wa,-g through to
GCC as an extra compile time flag, either to gdb_compile or
prepare_for_testing.

The problem is that the syntax used for passing the flags was
incorrect, and as a result these extra flags were being ignored.
Luckily, the 'debug' flag was being passed in each case anyway, which
means that the '-g' flag would already be added.

Given that all these tests pass 'debug', and the invalid flag has been
ignored for some time, I'm just removing the flags in this commit.

I've also changed the tests from using gdb_compile to
prepare_for_testing, which allows some extra code to be removed from a
couple of tests scripts.

There should be no change in the test results after this commit.

gdb/testsuite/ChangeLog:

	* gdb.arch/amd64-disp-step-avx.exp: Remove unneeded assembler flag
	option, syntax was wrong anyway.
	* gdb.arch/arm-disp-step.exp: Likewise.
	* gdb.arch/sparc64-regs.exp: Likewise.
	* gdb.arch/amd64-disp-step.exp: Remove unneeded assembler flag
	option, syntax was wrong anyway, switch to use
	prepare_for_testing.
	* gdb.arch/i386-disp-step.exp: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb: Fix testsuite issue in gdb.arch/amd64-disp-step-avx.exp
@ 2018-03-23 13:00 sergiodj+buildbot
  2018-03-23 14:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-23 13:00 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 376be529a7c99a70050bc48c51d891f1bea9777f ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 376be529a7c99a70050bc48c51d891f1bea9777f

gdb: Fix testsuite issue in gdb.arch/amd64-disp-step-avx.exp

This test starts up and confirms that $xmm0 has the value 0, it then
modifies $xmm0 (in the inferior) and confirms that the new value can
be read (in GDB).

On some machines I was noticing that this test would occasionally
fail, and on investigation I believe that the reason for this is that
the test is linked as a dynamically linked executable and makes use of
the system libraries during startup.  The reason that this causes
problems is that both the runtime linker and the startup code run
before main can, and do (on at least some platforms) make use of the
XMM registers.

In this commit I modify the test program slightly to allow it to be
linked statically, without using the startup libraries.  Now by the
time GDB reaches the symbol main we have only executed one 'nop'
instruction, and the XMM registers should all have the value 0.  I've
extended the test script to confirm that $xmm0 to $xmm15 are all
initially 0, and I also check that at the point after $xmm0 has been
modified, all the other XMM registers ($xmm1 to $xmm15) are still 0.

The test program is still linked against libc in order that we can
call the exit function, however, we now call _exit rather than exit in
order to avoid all of the usual cleanup that exit does.  This clean up
tries to tear down things that are usually setup during the startup
code, but now this isn't called calling exit will just result in a
crash.

gdb/testsuite/ChangeLog:

	* gdb.arch/amd64-disp-step-avx.S: Add '_start' label.
	(done): Call '_exit' not 'exit' to avoid atexit handlers.
	* gdb.arch/amd64-disp-step-avx.exp: Pass -static, and
	-nostartfiles when compiling the test.  Confirm that all registers
	xmm0 to xmm15 are initially 0, and that xmm1 to xmm15 are 0 after.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Make gdbserver find_register_by_number static
@ 2018-03-23 15:04 sergiodj+buildbot
  2018-03-23 15:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-23 15:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT dff7492c9b221aacd4efa6675bb288dfb5d50f80 ***

Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: dff7492c9b221aacd4efa6675bb288dfb5d50f80

Make gdbserver find_register_by_number static

gdbserver/
	* regcache.c (find_register_by_number): Make static.
	(find_regno): Use find_register_by_number
	* regcache.h (struct reg): Remove declaration.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Change machoread.c to use std::vector
@ 2018-03-23 16:23 sergiodj+buildbot
  2018-03-23 17:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-23 16:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2cc9b3048bcbb827e69059fb6beacb9bccbc5d7c ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 2cc9b3048bcbb827e69059fb6beacb9bccbc5d7c

Change machoread.c to use std::vector

This changes machoread.c to use std::vector rather than VEC.  This
allows removing some cleanups.

Regression tested by the buildbot, though I don't think anything
actually tests macho reading.

gdb/ChangeLog
2018-03-23  Tom Tromey  <tom@tromey.com>

	* machoread.c (struct oso_el): Add a constructor.  Don't define as
	a typedef.
	(macho_register_oso): Remove.
	(macho_symtab_read): Take a std::vector.
	(oso_el_compare_name): Now a std::sort comparator.
	(macho_symfile_read_all_oso): Take a std::vector.
	(macho_symfile_read): Use std::vector.  Remove cleanups.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add psymbols for nested types
@ 2018-03-23 19:13 sergiodj+buildbot
  2018-03-23 19:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-23 19:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b7fee5a3268c340975a1dddb131733abfd153d5e ***

Author: Keith Seitz <keiths@redhat.com>
Branch: master
Commit: b7fee5a3268c340975a1dddb131733abfd153d5e

Add psymbols for nested types

c++/22968 involves the inability of ptype to find a type definition for
a type defined inside another type.  I recently added some additional
support for nested type definitions, but I apparently overlooked psymbols.

The user reports that using -readnow fixes the problem:

$ gdb 22968 -ex "ptype Outer::Inner"
There is no field named Inner

$ gdb -readnow 22968 -ex "ptype Outer::Inner"
type = struct Outer::Inner {
  <no data field>
}

We clearly did not find a psymbol for Outer::Inner because it was located
in another CU.  This patch addresses this problem by scanning structs
for additional psymbols.  Rust is already doing this.

With this patch, the identical result to "-readnow" is given (without
using `-readnow', of course).

gdb/ChangeLog:

	PR c++/22968
	* dwarf2read.c (scan_partial_symbols): Scan structs/classes for
	nested type definitions for C++, too.

gdb/testsuite/ChangeLog:

	PR c++/22968
	* gdb.cp/subtypes.exp: New file.
	* gdb.cp/subtypes.h: New file.
	* gdb.cp/subtypes.cc: New file.
	* gdb.cp/subtypes-2.cc: New file.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] aarch64: Make "info address" resolve TLS variables
@ 2018-03-24  3:23 sergiodj+buildbot
  2018-03-24  3:35 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-24  3:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bce02d8884d6baa72c537d0d7c59f924cb290799 ***

Author: Weimin Pan <weimin.pan@oracle.com>
Branch: master
Commit: bce02d8884d6baa72c537d0d7c59f924cb290799

aarch64: Make "info address" resolve TLS variables

TLS variables can't be resolved on aarch64-linux-gnu

Running the test case with upstream gdb shows two failures:

(1) Receiving different error messages when printing TLS variable before
    program runs - because the ARM compiler does not emit dwarf attribute
    DW_AT_location for TLS, the result is expected and the baseline may
    need to be changed for aarch64.

(2) Using "info address" command on C++ static TLS object resulted in
    "symbol unresolved" error - below is a snippet from the test case:

class K {
 public:
  static __thread int another_thread_local;
};

__thread int K::another_thread_local;

(gdb) info address K::another_thread_local
Symbol "K::another_thread_local" is unresolved.

This patch contains fix for (2).

Function info_address_command() handles the "info address" command and
calls lookup_minimal_symbol_and_objfile() to find sym's symbol entry in
mininal symbol table if SYMBOL_COMPUTED_OPS (sym) is false. Problem is
that function lookup_minimal_symbol_and_objfile() only looked up an
objfile's minsym ordinary hash table, not its demangled hash table, which
was the reason why the C++ name was not found.

The fix is to call lookup_minimal_symbol(), which already looks up entries
in both minsym's hash tables, to find names when traversing the object file
list in lookup_minimal_symbol_and_objfile().

Tested in both aarch64-linux-gnu and amd64-linux-gnu. No regressions.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86-64: Add ENDBR64 to the TLSDESC PLT entry
@ 2018-03-25 12:23 sergiodj+buildbot
  2018-03-25 12:35 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-25 12:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bf54968b128a2133174d81c438d402ecfaf83042 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: bf54968b128a2133174d81c438d402ecfaf83042

x86-64: Add ENDBR64 to the TLSDESC PLT entry

The TLSDESC entry in a lazy procedure linkage table is called indirectly
with "callq *(%rax)".  This patch adds an ENDBR64 to support indirect
branch tracking in Intel CET.  The TLSDESC PLT entry now looks like:

0xf3, 0x0f, 0x1e, 0xfa,  /* endbr64             */
0xff, 0x35, 8, 0, 0, 0,  /* pushq GOT+8(%rip)   */
0xff, 0x25, 16, 0, 0, 0  /* jmpq *GOT+TDG(%rip)  */

The BND prefix isn't needed since MPX isn't used for TLSDESC.

bfd/

	PR ld/23000
	* elf64-x86-64.c (elf_x86_64_finish_dynamic_sections): Add
	ENDBR64 to the TLSDESC PLT entry.

ld/

	PR ld/23000
	* testsuite/ld-x86-64/tlsdesc.pd: Updated.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] eval.c: reverse minsym and sym
@ 2018-03-25 18:14 sergiodj+buildbot
  2018-03-25 18:27 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-25 18:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3e5ef9a4de7919971130f7f2ca3052898a069e76 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 3e5ef9a4de7919971130f7f2ca3052898a069e76

eval.c: reverse minsym and sym

I noticed that in evaluate_funcall, where we handle
OP_VAR_MSYM_VALUE/OP_VAR_VALUE to figure out the symbol's name gets
the minimal_symbol/symbol backwards.  Happens to be harmless in
practice because the symbol name is recorded in the common initial
sequence (in the general_symbol_info field).

gdb/ChangeLog:
2018-03-25  Pedro Alves  <palves@redhat.com>

	* eval.c (evaluate_funcall): Swap OP_VAR_MSYM_VALUE/OP_VAR_VALUE
	if then/else bodies in var_func_name extraction.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Make gdbserver reg_defs a vector of objects
@ 2018-03-26 11:05 sergiodj+buildbot
  2018-03-26 11:18 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-26 11:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5cd3e386e0ac84b0ba1e0737853f4504ba24f677 ***

Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: 5cd3e386e0ac84b0ba1e0737853f4504ba24f677

Make gdbserver reg_defs a vector of objects

gdb/
	* regformats/regdef.h (reg): Add constructors.

gdb/gdbserver/
	* regcache.c (find_register_by_number): Return a ref.
	(find_regno): Use references.
	(register_size): Likewise.
	(register_data): Likewise.
	* tdesc.c (target_desc::~target_desc): Remove free calls.
	(target_desc::operator==): Use std::vector compare.
	(init_target_desc): Use reference.
	(tdesc_create_reg): Use reg constructors.
	* tdesc.h (struct target_desc): Replace pointer with object.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove struct keyword from section_addr_info
@ 2018-03-26 17:54 sergiodj+buildbot
  2018-03-26 18:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-26 17:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4f7ae6f5059924a5acc4490880449d6410dc5c93 ***

Author: Keith Seitz <keiths@redhat.com>
Branch: master
Commit: 4f7ae6f5059924a5acc4490880449d6410dc5c93

Remove struct keyword from section_addr_info

Buildbot pointed out a failiure in windows-nat.c:

../../binutils-gdb/gdb/windows-nat.c:582:10: error: using typedef-name 'section_addr_info' after 'struct'
   struct section_addr_info *addrs;
          ^~~~~~~~~~~~~~~~~
In file included from ../../binutils-gdb/gdb/windows-nat.c:49:0:
../../binutils-gdb/gdb/symfile.h:75:37: note: 'section_addr_info' has a previous declaration here
 typedef std::vector<other_sections> section_addr_info;
                                     ^~~~~~~~~~~~~~~~~

A recursive grep of the sources for "struct section_addr_info" reveals one
additional reference in a comment.  In both cases, this patch simply removes
the struct keyword.

gdb/ChangeLog:

	* symfile.c (place_section): Remove "struct" from section_addr_info
	in comment.
	* windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Remove
	"struct" keyword from section_addr_info.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add include guard to filename-seen-cache.h
@ 2018-03-26 19:51 sergiodj+buildbot
  2018-03-26 20:06 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-26 19:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ce1459e528772057d51a507fa0c2bb1c8cbdca97 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: ce1459e528772057d51a507fa0c2bb1c8cbdca97

Add include guard to filename-seen-cache.h

While moving things around, I stumbled on filename_seen_cache being
re-defined, because filename-seen-cache.h doesn't have an include guard.

gdb/ChangeLog:

	* filename-seen-cache.h: Add include guard.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove DEF_VEC_I(offset_type)
@ 2018-03-26 20:03 sergiodj+buildbot
  2018-03-26 21:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-26 20:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9f034d7573ec4fb4bd3879ce66fef0a20167a2ba ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 9f034d7573ec4fb4bd3879ce66fef0a20167a2ba

Remove DEF_VEC_I(offset_type)

It is unused.

gdb/ChangeLog:

	* dwarf2read.c (DEF_VEC_I(offset_type)): Remove.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Rationalize "backtrace" command line parsing
@ 2018-03-27  4:21 sergiodj+buildbot
  2018-03-27  4:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-27  4:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ea3b06874c8a1037bad4fd5b9396d196e6963ac6 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: ea3b06874c8a1037bad4fd5b9396d196e6963ac6

Rationalize "backtrace" command line parsing

The backtrace command has peculiar command-line parsing.  In
particular, it splits the command line, then loops over the arguments.
If it sees a word it recognizes, like "full", it effectively drops
this word from the argument vector.  Then, it pastes together the
remaining arguments, passing them on to backtrace_command_1, which in
turn passes the resulting string to parse_and_eval_long.

The documentation doesn't mention the parse_and_eval_long at all, so
it is a bit of a hidden feature that you can "bt 3*2".  The strange
algorithm above also means you can "bt 3 * no-filters 2" and get 6
frames...

This patch changes backtrace's command line parsing to be a bit more
rational.  Now, special words like "full" are only recognized at the
start of the command.

This also updates the documentation to describe the various bt options
individually.

gdb/ChangeLog
2018-03-26  Tom Tromey  <tom@tromey.com>

	* stack.c (backtrace_command): Rewrite command line parsing.

gdb/doc/ChangeLog
2018-03-26  Tom Tromey  <tom@tromey.com>

	* gdb.texinfo (Backtrace): Describe options individually.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Change backtrace_command_1 calling to use flags
@ 2018-03-27  4:34 sergiodj+buildbot
  2018-03-27  5:53 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-27  4:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1cf7e64086d1490649dc56e1c0505be91c600218 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 1cf7e64086d1490649dc56e1c0505be91c600218

Change backtrace_command_1 calling to use flags

The next patch will add more flags to backtrace_command_1; and rather
than add another boolean argument, this patch changes it to accept a
flags value.

gdb/ChangeLog
2018-03-26  Tom Tromey  <tom@tromey.com>

	* stack.c (backtrace_command_1): Remove "show_locals" parameter,
	add "flags".
	(backtrace_command): Remove "fulltrace", add "flags".


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Allow hiding of some filtered frames
@ 2018-03-27  4:49 sergiodj+buildbot
  2018-03-27  7:13 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-27  4:49 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 978d6c756fcb0332ddf12e19305dd0e53b98a93d ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 978d6c756fcb0332ddf12e19305dd0e53b98a93d

Allow hiding of some filtered frames

When a frame filter elides some frames, they are still printed by
"bt", indented a few spaces.  PR backtrace/15582 notes that it would
be nice for users if elided frames could simply be dropped.  This
patch adds this capability.

gdb/ChangeLog
2018-03-26  Tom Tromey  <tom@tromey.com>

	PR backtrace/15582:
	* stack.c (backtrace_command): Parse "hide" argument.
	* python/py-framefilter.c (py_print_frame): Handle PRINT_HIDE.
	* extension.h (enum frame_filter_flags) <PRINT_HIDE>: New
	constant.

gdb/doc/ChangeLog
2018-03-26  Tom Tromey  <tom@tromey.com>

	PR backtrace/15582:
	* gdb.texinfo (Backtrace): Mention "hide" argument.

gdb/testsuite/ChangeLog
2018-03-26  Tom Tromey  <tom@tromey.com>

	PR backtrace/15582:
	* gdb.python/py-framefilter.exp: Add "bt hide" test.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove EXT_LANG_BT_COMPLETED
@ 2018-03-27  5:03 sergiodj+buildbot
  2018-03-27  8:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-27  5:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 63283d4a2983eaefd5d0860ddffcf946f0fe92db ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 63283d4a2983eaefd5d0860ddffcf946f0fe92db

Remove EXT_LANG_BT_COMPLETED

While looking at the frame filter code, I noticed that
EXT_LANG_BT_COMPLETED is not really needed.  Semantically there is no
difference between the "completed" and "ok" results.  So, this patch
removes this constant.

gdb/ChangeLog
2018-03-26  Tom Tromey  <tom@tromey.com>

	* python/py-framefilter.c (py_print_frame): Return
	EXT_LANG_BT_OK.
	(gdbpy_apply_frame_filter): Update comment.
	* extension.h (enum ext_lang_bt_status) <EXT_LANG_BT_COMPLETED>:
	Remove.
	<EXT_LANG_BT_NO_FILTERS>: Change value.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Avoid manual resource management in py-framefilter.c
@ 2018-03-27  5:17 sergiodj+buildbot
  2018-03-27 10:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-27  5:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7a630bc2f99fcd55ddd83274574531d526ca1925 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 7a630bc2f99fcd55ddd83274574531d526ca1925

Avoid manual resource management in py-framefilter.c

This patch removes the last bit of manual resource management from
py-framefilter.c.  This will be useful in the next patch.

gdb/ChangeLog
2018-03-26  Tom Tromey  <tom@tromey.com>

	* python/py-framefilter.c (enumerate_args): Use
	gdb::unique_xmalloc_ptr.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Allow C-c to work in backtrace in more cases
@ 2018-03-27  5:31 sergiodj+buildbot
  2018-03-27 12:14 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-27  5:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 92256134f3e5557dcc321c63c48e8175ea90ca27 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 92256134f3e5557dcc321c63c48e8175ea90ca27

Allow C-c to work in backtrace in more cases

PR cli/17716 notes that it is difficult to C-c (or "q" at a pagination
prompt) while backtracing using a frame filter.  One reason for this
is that many places in py-framefilter.c use RETURN_MASK_ALL in a
try/catch.

This patch changes these spots to use RETURN_MASK_ERROR instead.  This
is safe to do because this entire file is exception safe now.

gdb/ChangeLog
2018-03-26  Tom Tromey  <tom@tromey.com>

	PR cli/17716:
	* python/py-framefilter.c (py_print_type, py_print_value)
	(enumerate_args, py_print_args, gdbpy_apply_frame_filter): Use
	RETURN_MASK_ERROR.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Throw a "quit" on a KeyboardException in py-framefilter.c
@ 2018-03-27  5:44 sergiodj+buildbot
  2018-03-27 13:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-27  5:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4ca59a9f3616ba324952632233acc657fffa8be1 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 4ca59a9f3616ba324952632233acc657fffa8be1

Throw a "quit" on a KeyboardException in py-framefilter.c

If a C-c comes while the Python code for a frame filter is running, it
will be turned into a Python KeyboardException.  It seems good for
this to be treated like a GDB quit, so this patch changes
py-framefilter.c to notice this situation and call throw_quit in this
case.

gdb/ChangeLog
2018-03-26  Tom Tromey  <tom@tromey.com>

	* python/py-framefilter.c (throw_quit_or_print_exception): New
	function.
	(gdbpy_apply_frame_filter): Use it.

gdb/testsuite/ChangeLog
2018-03-26  Tom Tromey  <tom@tromey.com>

	* gdb.python/py-framefilter.exp: Add test for KeyboardInterrupt.
	* gdb.python/py-framefilter.py (name_error): New global.
	(ErrorInName.function): Use name_error.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Move some code later in backtrace_command_1
@ 2018-03-27  6:17 sergiodj+buildbot
  2018-03-27 15:11 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-27  6:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fb7eb8b5826f059e2b7a18e42ff9c20972e626bc ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: fb7eb8b5826f059e2b7a18e42ff9c20972e626bc

Move some code later in backtrace_command_1

PR backtrace/15584 notes that some code in backtrace_command_1 is not
useful when frame filters are in use.  This patch moves this code into
the no-frame-filters "if".  This also removes the unused local
"trailing_level", which I noticed while moving the code around.

gdb/ChangeLog
2018-03-26  Tom Tromey  <tom@tromey.com>

	PR backtrace/15584:
	* stack.c (backtrace_command_1): Move some code into no-filters
	"if".


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Call wrap_hint in one more spot in py-framefilter.c
@ 2018-03-27  6:44 sergiodj+buildbot
  2018-03-27 18:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-27  6:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT eb68e48764d4b038858dd4255ed248dbee6c4c0e ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: eb68e48764d4b038858dd4255ed248dbee6c4c0e

Call wrap_hint in one more spot in py-framefilter.c

PR python/16486 notes that "bt" output is still wrapped differently
when a frame filter is in use.  This patch brings it a bit closer by
adding one more wrap_hint call, in a place where stack.c does this as
well.

gdb/ChangeLog
2018-03-26  Tom Tromey  <tom@tromey.com>

	PR python/16486:
	* python/py-framefilter.c (py_print_args): Call wrap_hint.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Improve "backtrace" help text
@ 2018-03-27  6:58 sergiodj+buildbot
  2018-03-27 20:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-27  6:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9507b29c0a00fb62f015fe69f82aaf8f5377ab35 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 9507b29c0a00fb62f015fe69f82aaf8f5377ab35

Improve "backtrace" help text

This improves help text in stack.c in two ways.  First, it removes
trailing newlines from various help strings.  I think these are never
needed.  Second, it adds a "Usage" line to the "backtrace" text, as
suggested by Pedro.

gdb/ChangeLog
2018-03-26  Tom Tromey  <tom@tromey.com>

	* stack.c (_initialize_stack): Remove trailing newlines from help
	text.  Add "Usage" line to "backtrace" help.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Simplify exception handling in py-framefilter.c
@ 2018-03-27  7:12 sergiodj+buildbot
  2018-03-27 21:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-27  7:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 76c939acfd21928957b45816bf78935363438b0a ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 76c939acfd21928957b45816bf78935363438b0a

Simplify exception handling in py-framefilter.c

This patch changes py-framefilter.c as suggested by Pedro in:
https://sourceware.org/ml/gdb-patches/2017-06/msg00748.html

In particular, gdb exceptions are now caught at the outermost layer,
rather than in each particular function.  This simplifies much of the
code.

gdb/ChangeLog
2018-03-26  Tom Tromey  <tom@tromey.com>

	* python/py-framefilter.c (py_print_type): Don't catch
	exceptions.  Return void.
	(py_print_value): Likewise.
	(py_print_single_arg): Likewise.
	(enumerate_args): Don't catch exceptions.
	(py_print_args): Likewise.
	(py_print_frame): Likewise.
	(gdbpy_apply_frame_filter): Catch exceptions here.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove verbose code from backtrace command
@ 2018-03-27  7:27 sergiodj+buildbot
  2018-03-27 22:43 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-27  7:27 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 675015399bf80896706865e3d77d3af7fc925932 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 675015399bf80896706865e3d77d3af7fc925932

Remove verbose code from backtrace command

In https://sourceware.org/ml/gdb-patches/2017-06/msg00741.html,
Pedro asks:

> Doesn't the "info verbose on" bit affect frame filters too?

The answer is that yes, it could.  However, it's not completely
effective, because the C code can't guess how many frames might need
to be unwound to satisfy the request -- a frame filter will request as
many frames as it needs.

Also, I tried removing this code from backtrace, and I think the
result is better without it.  In particular, now the expansion line
occurs just before the frame that caused the expansion, like:

    (gdb) bt no-filters
    #0  0x00007ffff576cecd in poll () from /lib64/libc.so.6
    Reading in symbols for ../../binutils-gdb/gdb/event-loop.c...done.
    #1  0x00000000007ecc33 in gdb_wait_for_event (block=1)
	at ../../binutils-gdb/gdb/event-loop.c:772
    #2  0x00000000007ec006 in gdb_do_one_event ()
	at ../../binutils-gdb/gdb/event-loop.c:347
    #3  0x00000000007ec03e in start_event_loop ()
	at ../../binutils-gdb/gdb/event-loop.c:371
    Reading in symbols for ../../binutils-gdb/gdb/main.c...done.
    #4  0x000000000086693d in captured_command_loop (
	Reading in symbols for ../../binutils-gdb/gdb/exceptions.c...done.
    data=0x0) at ../../binutils-gdb/gdb/main.c:325

So, I am proposing this patch to simply remove this code.

gdb/ChangeLog
2018-03-26  Tom Tromey  <tom@tromey.com>

	* stack.c (backtrace_command_1): Remove verbose code.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Return EXT_LANG_BT_ERROR in one more spot in py-framefilter.c
@ 2018-03-27  7:57 sergiodj+buildbot
  2018-03-27 16:49 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-27  7:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1f111921a0f8e3f62a19808349ff9bcbd4e54043 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 1f111921a0f8e3f62a19808349ff9bcbd4e54043

Return EXT_LANG_BT_ERROR in one more spot in py-framefilter.c

While reading py-framefilter.c, I found one spot where an exception
could be caught but then not be turned into EXT_LANG_BT_ERROR.  This
patch fixes this spot.

gdb/ChangeLog
2018-03-26  Tom Tromey  <tom@tromey.com>

	* python/py-framefilter.c (py_print_single_arg): Return
	EXT_LANG_BT_ERROR from catch.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] problem looking up some symbols when they have a linkage name
@ 2018-03-27 14:13 sergiodj+buildbot
  2018-03-28  0:02 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-27 14:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 59cc4834e53565da1de4a7b615ed8890ed55c7da ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 59cc4834e53565da1de4a7b615ed8890ed55c7da

problem looking up some symbols when they have a linkage name

This patch fixes a known failure in gdb.ada/maint_with_ada.exp
(maintenance check-psymtabs). Another way to witness the same
issue is by considering the following Ada declarations...

   type Wrapper is record
      A : Integer;
   end record;
   u00045 : constant Wrapper := (A => 16#060287af#);
   pragma Export (C, u00045, "symada__cS");

... which declares a variable name "u00045" but with a linkage
name which is "symada__cS". This variable is a record with one
component, the Ada equivalent of a struct with one field in C.
Trying to print that variable's value currently yields:

    (gdb) p /x <symada__cS>
    'symada(char, signed)' has unknown type; cast it to its declared type

This indicates that GDB was only able to find the minimal symbol,
but not the full symbol. The expected output is:

    (gdb) print /x <symada__cS>
    $1 = (a => 0x60287af)

The error message gives a hint about what's happening: We processed
the symbol through gdb_demangle, which in the case of this particular
symbol name, ends up matching the C++ naming scheme. As a result,
the demangler transforms our symbol name into 'symada(char, signed)',
thus breaking Ada lookups.

This patch fixes the issue by first introducing a new language_defn
attribute called la_store_sym_names_in_linkage_form_p, which is a boolean
to be set to true for the few languages that do not want their symbols
to have their names stored in demangled form, and false otherwise.
We then use this language attribute to skip the call to gdb_demangle
for all languages whose la_store_sym_names_in_linkage_form_p is true.

In terms of the selection of languages for which the new attribute
is set to true, the selection errs on the side of preserving the
existing behavior, and only changes the behavior for the languages
where we are certain storing symbol names in demangling form is not
needed. It is conceivable that other languages might be in the same
situation, but I not knowing in detail the symbol name enconding
strategy, I decided to play it safe and let other language maintainers
potentially adjust their language if it makes sense to do so.

gdb/ChangeLog:

        PR gdb/22670
        * dwarf2read.c (dwarf2_physname): Do not return the demangled
        symbol name if the CU's language stores symbol names in linkage
        format.
        * language.h (struct language_defn)
        <la_store_sym_names_in_linkage_form_p>: New field.  Adjust
        all instances of this struct.

gdb/testsuite/ChangeLog:

        * gdb.ada/maint_with_ada.exp: Remove PR gdb/22670 setup_kfail.

        * gdb.ada/notcplusplus: New testcase.

        * gdb.base/c-linkage-name.c: New file.
        * gdb.base/c-linkage-name.exp: New testcase.

Tested on x86_64-linux.
This also passes AdaCore's internal GDB testsuite.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Move DWARF index-related things to a separate file
@ 2018-03-27 14:24 sergiodj+buildbot
  2018-03-28  1:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-27 14:24 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cd4fb1b2ffc88911e4109444ff729e31920d01ec ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: cd4fb1b2ffc88911e4109444ff729e31920d01ec

Move DWARF index-related things to a separate file

I want to add a DWARF index-related feature (automatically produce index
files when loading objfiles in GDB), but I don't want to add many
hundred lines to the already too big dwarf2read.c.  I thought it would
be a logical split to move everything related to the DWARF index to its
own file.

I first tried to move everything that reads and writes DWARF indices to
a separate file, but found that the "read" part is a little bit
entangled with the rest of dwarf2read.c, so the line is hard to draw
about where to split.  The write part is quite isolated though, so I
moved this part to a new file, dwarf-index-write.c.  Some things are
necessary to both reading and writing indices, so I placed them in
dwarf-index-common.{c,h}.  The idea would be to have a
dwarf-index-read.c eventually that would use it too (for now that code
is still in dwarf2read.c).

This required moving some things to a new dwarf2read.h header, so they
can be read by the code that writes the index.

The patch is big in number of lines, but it's all existing code being
moved around.  The only changes are that some functions are not static
anymore, a declaration is added in a .h file, and therefore the comment
is moved there.

I built-tested it with a little and big endian target.

This patch is also available on the users/simark/split-dwarf2read
branch.

gdb/ChangeLog:

	* Makefile.in (COMMON_SFILES): Add dwarf-index-common.c and
	dwarf-index-write.c
	(HFILES_NO_SRCDIR): Add dwarf-index-common.h and dwarf2read.h.
	* dwarf-index-common.c: New file.
	* dwarf-index-common.h: New file.
	* dwarf-index-write.c: New file.
	* dwarf2read.c: Include dwarf2read.h and dwarf-index-common.h.
	(struct dwarf2_section_info): Move from here.
	(dwarf2_section_info_def): Likewise.
	(DEF_VEC_O (dwarf2_section_info_def)): Likewise.
	(offset_type): Likewise.
	(DW2_GDB_INDEX_SYMBOL_STATIC_SET_VALUE): Likewise.
	(DW2_GDB_INDEX_SYMBOL_KIND_SET_VALUE): Likewise.
	(DW2_GDB_INDEX_CU_SET_VALUE): Likewise.
	(byte_swap): Likewise.
	(MAYBE_SWAP): Likewise.
	(dwarf2_per_cu_ptr): Likewise.
	(DEF_VEC_P (dwarf2_per_cu_ptr)): Likewise.
	(struct tu_stats): Likewise.
	(struct dwarf2_per_objfile): Likewise.
	(struct dwarf2_per_cu_data): Likewise.
	(struct signatured_type): Likewise.
	(sig_type_ptr): Likewise.
	(DEF_VEC_P (sig_type_ptr)): Likewise.
	(INDEX4_SUFFIX): Likewise.
	(INDEX5_SUFFIX): Likewise.
	(DEBUG_STR_SUFFIX): Likewise.
	(dwarf2_read_section): Make non-static.
	(mapped_index_string_hash): Move from here.
	(dwarf5_djb_hash): Likewise.
	(file_write): Likewise.
	(class data_buf): Likewise.
	(struct symtab_index_entry): Likewise.
	(struct mapped_symtab): Likewise.
	(find_slot): Likewise.
	(hash_expand): Likewise.
	(add_index_entry): Likewise.
	(uniquify_cu_indices): Likewise.
	(class c_str_view): Likewise.
	(class c_str_view_hasher): Likewise.
	(class vector_hasher): Likewise.
	(write_hash_table): Likewise.
	(psym_index_map): Likewise.
	(struct addrmap_index_data): Likewise.
	(add_address_entry): Likewise.
	(add_address_entry_worker): Likewise.
	(write_address_map): Likewise.
	(symbol_kind): Likewise.
	(write_psymbols): Likewise.
	(struct signatured_type_index_data): Likewise.
	(write_one_signatured_type): Likewise.
	(recursively_count_psymbols): Likewise.
	(recursively_write_psymbols): Likewise.
	(class debug_names): Likewise.
	(check_dwarf64_offsets): Likewise.
	(psyms_seen_size): Likewise.
	(write_gdbindex): Likewise.
	(write_debug_names): Likewise.
	(assert_file_size): Likewise.
	(write_psymtabs_to_index): Likewise.
	(save_gdb_index_command): Likewise.
	(_initialize_dwarf2_read): Don't register the "save gdb-index"
	command.
	* dwarf2read.h: New file.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] set varsize-limit: New GDB setting for maximum dynamic object size
@ 2018-03-27 14:32 sergiodj+buildbot
  2018-03-28  2:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-27 14:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3fcded8f30b6b0c1930d4f82914476315027aa2e ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 3fcded8f30b6b0c1930d4f82914476315027aa2e

set varsize-limit: New GDB setting for maximum dynamic object size

This is a command we somehow forgot to contribute at the time the Ada
language was first contributed to the FSF. This command allows
the user to change the maximum size we allow when reading memory
from dynamic objects (the default is 65536 bytes).

At the moment, this limit is only used by Ada, and so the implementation
is kept inside ada-lang.c. However, it is conceivable that other language
might want to use it also to handle the same kind of issues; for instance,
this might be useful when handling dynamic types in C. So the name
of the setting was made language-neutral, to allow for this.

Note that an alias for "set var" needs to be introduced as well.
We are not adding a test for that, since this is a feature that is
already exercized by numerous existing tests.

gdb/ChangeLog

        * NEWS: Add entry describing new "set|show varsize-limit" command.
        * ada-lang.c (_initialize_ada_language): Add "set/show varsize-limit"
        command.
        * printcmd.c (_initialize_printcmd): Add "set var" alias of
        "set variable".

gdb/doc/ChangeLog:

        * gdb.texinfo (Ada Settings): New subsubsection.

gdb/testsuite/ChangeLog:

        * gdb.ada/varsize_limit: New testcase.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Include <cmath> in dwarf-index-write.c
@ 2018-03-27 15:13 sergiodj+buildbot
  2018-03-28  4:00 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-27 15:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 608219fb2917d407058952adf164eb616880662b ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 608219fb2917d407058952adf164eb616880662b

Include <cmath> in dwarf-index-write.c

On x86-64 Fedora 26, when building with the system gcc, I get:

../../binutils-gdb/gdb/dwarf-index-write.c: In member function void debug_names::build():
../../binutils-gdb/gdb/dwarf-index-write.c:705:13: error: pow is not a member of std

There are actually more messages, but this is sufficient to show the
problem.

The fix is to include <cmath>.

I'm checking this in as obvious.  Tested by building.

gdb/ChangeLog
2018-03-27  Tom Tromey  <tom@tromey.com>

	* dwarf-index-write.c: Include <cmath>.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] C++-ify typedef hash
@ 2018-03-27 16:58 sergiodj+buildbot
  2018-03-28  5:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-27 16:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c819b2c0b216c69a4ae5bfba0eac71ffdf1b3596 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: c819b2c0b216c69a4ae5bfba0eac71ffdf1b3596

C++-ify typedef hash

This changes the typedef_hash_table structure to be a C++ class.  It
adds constructors and destructors and changes some functions to be
methods of the class.  Then it changes the various users of this class
to adapt.  This allows for the removal of some cleanups.

Regression tested by the buildbot.

gdb/ChangeLog
2018-03-27  Tom Tromey  <tom@tromey.com>

	* typeprint.h (struct type_print_options) <local_typedefs,
	global_typedefs>: Remove "struct" keyword.
	(class typedef_hash_table): New class.
	(recursively_update_typedef_hash, add_template_parameters)
	(create_typedef_hash, free_typedef_hash, copy_typedef_hash)
	(find_typedef_in_hash): Don't declare.
	* typeprint.c (struct typedef_hash_table): Move to typeprint.h.
	(typedef_hash_table::recursively_update): Rename from
	recursively_update_typedef_hash.  Now a member.
	(typedef_hash_table::add_template_parameters): Rename from
	add_template_parameters.  Now a member.
	(typedef_hash_table::typedef_hash_table): Now a constructor;
	rename from create_typedef_hash.
	(typedef_hash_table::~typedef_hash_table): Now a destructor;
	rename from free_typedef_hash.
	(do_free_typedef_hash, make_cleanup_free_typedef_hash)
	(do_free_global_table): Remove.
	(typedef_hash_table::typedef_hash_table): New constructor; renamed
	from copy_type_recursive.
	(create_global_typedef_table): Remove.
	(typedef_hash_table::find_global_typedef): Now a member of
	typedef_hash_table.
	(typedef_hash_table::find_typedef): Rename from
	find_typedef_in_hash; now a member.
	(whatis_exp): Update.
	* extension.h (struct ext_lang_type_printers): Add constructor and
	destructor.
	(start_ext_lang_type_printers, free_ext_lang_type_printers): Don't
	declare.
	* extension.c (ext_lang_type_printers::ext_lang_type_printers):
	Now a constructor; rename from start_ext_lang_type_printers.
	(ext_lang_type_printers): Now a destructor; rename from
	free_ext_lang_type_printers.
	* c-typeprint.c (find_typedef_for_canonicalize, c_print_type_1):
	Update.
	(c_type_print_base_struct_union): Update.  Remove cleanups.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove cleanups from gdb_readline_wrapper
@ 2018-03-27 17:14 sergiodj+buildbot
  2018-03-28  6:38 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-27 17:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1dbeed45b6a81ddcb725b68ff12236e7c8386a47 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 1dbeed45b6a81ddcb725b68ff12236e7c8386a47

Remove cleanups from gdb_readline_wrapper

This removes some cleanups from gdb_readline_wrapper by changing the
existing gdb_readline_wrapper_cleanup struct to have a constructor and
destructor, and then changing gdb_readline_wrapper to simply
instantiate it on the stack.

gdb/ChangeLog
2018-03-27  Pedro Alves  <palves@redhat.com>
	    Tom Tromey  <tom@tromey.com>

	* top.c (class gdb_readline_wrapper_cleanup): Add constructor,
	destructor.  Now a class.
	(gdb_readline_wrapper_cleanup): Remove function.
	(gdb_readline_wrapper): Remove cleanups.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove cleanups from prompt_for_continue
@ 2018-03-27 17:29 sergiodj+buildbot
  2018-03-28  7:58 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-27 17:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5aa892761c6a9f76c5b5ec2a9509e994b4f4de07 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 5aa892761c6a9f76c5b5ec2a9509e994b4f4de07

Remove cleanups from prompt_for_continue

This removes the cleanups from prompt_for_continue by the use of
unique_xmalloc_ptr.

gdb/ChangeLog
2018-03-27  Tom Tromey  <tom@tromey.com>

	* utils.c (prompt_for_continue): Use unique_xmalloc_ptr.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Enhance the AARCH64 assembler to support LDFF1xx instructions which use REG+REG addressing with an assumed offset register.
@ 2018-03-28  9:04 sergiodj+buildbot
  2018-03-28  9:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-28  9:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c8d59609b1cf66eaff3c486e483f5e3d647c66ff ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: c8d59609b1cf66eaff3c486e483f5e3d647c66ff

Enhance the AARCH64 assembler to support LDFF1xx instructions which use REG+REG addressing with an assumed offset register.

	PR 22988
opcode	* opcode/aarch64.h (enum aarch64_opnd): Add
	AARCH64_OPND_SVE_ADDR_R.

opcodes	* aarch64-tbl.h (aarch64_opcode_table): Add entries for LDFF1xx
	instructions with only a base address register.
	* aarch64-opc.c (operand_general_constraint_met_p): Add code to
	handle AARHC64_OPND_SVE_ADDR_R.
	(aarch64_print_operand): Likewise.
	* aarch64-asm-2.c: Regenerate.
	* aarch64_dis-2.c: Regenerate.
	* aarch64-opc-2.c: Regenerate.

gas	* config/tc-aarch64.c (parse_operands): Add code to handle
	AARCH64_OPN_SVE_ADDR_R.
	* testsuite/gas/aarch64/sve.s: Add tests for LDFF1xx instructions
	with an assumed XZR offset address register.
	* testsuite/gas/aarch64/sve.d: Update expected disassembly.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PR ld/22972 on SPARC.
@ 2018-03-28 10:35 sergiodj+buildbot
  2018-03-28 11:29 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-28 10:35 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f8745e1cd139b5c6a5bd8a30ea84ccbd45dec81c ***

Author: Eric Botcazou <ebotcazou@gcc.gnu.org>
Branch: master
Commit: f8745e1cd139b5c6a5bd8a30ea84ccbd45dec81c

PR ld/22972 on SPARC.

This is a regression for the corner case of a hidden symbol in a PIC/PIE
binary which is subject to both a new-style GOTDATA relocation and an
old-style GOT relocation.  In this case, depending  on the link order,
the R_SPARC_RELATIVE dynamic relocation for the GOT slot needed because
of the old-style relocation can be replaced with R_SPARC_NONE coming
from the GOTDATA relocation.

The fix simply records whether an old-style GOT relocation is seen for a
symbol and prevents the R_SPARC_NONE from being generated in this case.

bfd/
	* elfxx-sparc.c (struct _bfd_sparc_elf_link_hash_entry): Add new flag
	has_old_style_got_reloc.
	(_bfd_sparc_elf_check_relocs) <GOT relocations>: Set it for old-style
	relocations.  Fix a couple of long lines.
	(_bfd_sparc_elf_relocate_section) <R_SPARC_GOTDATA_OP>: Do not generate
	a R_SPARC_NONE for the GOT slot if the symbol is also subject to
	old-style GOT relocations.
ld/
	* testsuite/ld-sparc/sparc.exp: Add test for mixed GOTDATA/GOT relocs.
	* testsuite/ld-sparc/gotop-hidden.c: New file.
	* testsuite/ld-sparc/got-hidden32.s: Likewise.
	* testsuite/ld-sparc/got-hidden64.s: Likewise.
	* testsuite/ld-sparc/pass.out: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: don't show suffixes for to-scalar-int conversion insns
@ 2018-03-28 12:42 sergiodj+buildbot
  2018-03-28 13:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-28 12:42 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9646c87b5a6c0462e8a9b6305d9e449bd099f19d ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 9646c87b5a6c0462e8a9b6305d9e449bd099f19d

x86: don't show suffixes for to-scalar-int conversion insns

In the course of folding their patterns (possible now that the pointless
and partly even bogus VecESize are no longer in the way) I've noticed
that vcvt*2usi, other than their vcvt*2si counterparts, don't allow for
any suffixes. As that is supposedly intentional, make the disassembler
consistently omit suffixes for all to-scalar-int conversion insns.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: fold to-scalar-int conversion insns
@ 2018-03-28 12:56 sergiodj+buildbot
  2018-03-28 15:04 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-28 12:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9f123b911ec8c460304c3e1a3f18f1c2a311d97a ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 9f123b911ec8c460304c3e1a3f18f1c2a311d97a

x86: fold to-scalar-int conversion insns


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: convert broadcast insn attribute to boolean
@ 2018-03-28 13:10 sergiodj+buildbot
  2018-03-28 16:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-28 13:10 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8e6e0792d17be5d4321def520d12c1764dc0ba2a ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 8e6e0792d17be5d4321def520d12c1764dc0ba2a

x86: convert broadcast insn attribute to boolean

The (only) valid broadcast type for an insn can be inferred from other
information.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: drop VecESize
@ 2018-03-28 15:04 sergiodj+buildbot
  2018-03-28 18:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-28 15:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c39e5b267180a5d61a6434b24bcc7888bf3c0ca7 ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: c39e5b267180a5d61a6434b24bcc7888bf3c0ca7

x86: drop VecESize

It again can be inferred from other information.

The vpopcntd templates all need to have Dword added to their memory
operands; the lack thereof was actually a bug preventing certain Intel
syntax code to assemble, so test cases get extended.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [1/2][GAS][AARCH64]Add BFD_RELOC_AARCH64_TLSLE_LDST8/16/32/64_TPREL_LO12 support in GAS.
@ 2018-03-28 17:35 sergiodj+buildbot
  2018-03-28 20:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-28 17:35 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 84f1b9fb081372a726fd70dfd8258a707833caef ***

Author: Renlin Li <renlin.li@arm.com>
Branch: master
Commit: 84f1b9fb081372a726fd70dfd8258a707833caef

[1/2][GAS][AARCH64]Add BFD_RELOC_AARCH64_TLSLE_LDST8/16/32/64_TPREL_LO12 support in GAS.

This patch adds the following relocation support into binutils gas.
BFD_RELOC_AARCH64_TLSLE_LDST16_TPREL_LO12,
BFD_RELOC_AARCH64_TLSLE_LDST16_TPREL_LO12_NC,
BFD_RELOC_AARCH64_TLSLE_LDST32_TPREL_LO12,
BFD_RELOC_AARCH64_TLSLE_LDST32_TPREL_LO12_NC,
BFD_RELOC_AARCH64_TLSLE_LDST64_TPREL_LO12,
BFD_RELOC_AARCH64_TLSLE_LDST64_TPREL_LO12_NC,
BFD_RELOC_AARCH64_TLSLE_LDST8_TPREL_LO12,
BFD_RELOC_AARCH64_TLSLE_LDST8_TPREL_LO12_NC.

Those relocations includes both ip64 and ilp32 variant.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [2/2][LD][AARCH64]Add BFD_RELOC_AARCH64_TLSLE_LDST8/16/32/64_TPREL_LO12 support in LD.
@ 2018-03-28 17:49 sergiodj+buildbot
  2018-03-28 22:22 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-28 17:49 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e04ef02299ad4aae08da857e8535d98e8643a274 ***

Author: Renlin Li <renlin.li@arm.com>
Branch: master
Commit: e04ef02299ad4aae08da857e8535d98e8643a274

[2/2][LD][AARCH64]Add BFD_RELOC_AARCH64_TLSLE_LDST8/16/32/64_TPREL_LO12 support in LD.

This patch adds the following relocation support into binutils bfd linker.
BFD_RELOC_AARCH64_TLSLE_LDST16_TPREL_LO12,
BFD_RELOC_AARCH64_TLSLE_LDST16_TPREL_LO12_NC,
BFD_RELOC_AARCH64_TLSLE_LDST32_TPREL_LO12,
BFD_RELOC_AARCH64_TLSLE_LDST32_TPREL_LO12_NC,
BFD_RELOC_AARCH64_TLSLE_LDST64_TPREL_LO12,
BFD_RELOC_AARCH64_TLSLE_LDST64_TPREL_LO12_NC,
BFD_RELOC_AARCH64_TLSLE_LDST8_TPREL_LO12,
BFD_RELOC_AARCH64_TLSLE_LDST8_TPREL_LO12_NC.

Those relocations includes both ip64 and ilp32 variant.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] MIPS/BFD: Call `mips_elf32_rtype_to_howto' directly with o32
@ 2018-03-28 20:56 sergiodj+buildbot
  2018-03-28 23:42 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-28 20:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8205a328f8b852086652841dfc2aff4ca0b16d45 ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 8205a328f8b852086652841dfc2aff4ca0b16d45

MIPS/BFD: Call `mips_elf32_rtype_to_howto' directly with o32

Call `mips_elf32_rtype_to_howto' directly rather than via the
`->elf_backend_mips_rtype_to_howto' method in the o32 backend,
complementing commit 861fb55ab50a ("Defer allocation of R_MIPS_REL32 GOT
slots"), <https://sourceware.org/ml/binutils/2008-08/msg00096.html>, and
reverting the change to `mips_info_to_howto_rel' originally made with
commit 0a44bf6950b3 ("mips-vxworks support"),
<https://sourceware.org/ml/binutils/2006-03/msg00179.html>.

With `mips_vxworks_rtype_to_howto' gone there is a single backend method
used across all o32 targets, so there in no need for the indirection and
the associated extra cost.  This also makes the o32 backend consistent
with the n32 and n64 backends.

	bfd/
	* elf32-mips.c (mips_info_to_howto_rel): Call
	`mips_elf32_rtype_to_howto' directly rather than via
	`->elf_backend_mips_rtype_to_howto'.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] BFD/PA: Remove ATTRIBUTE_UNUSED from `elf_hppa_info_to_howto_rel'
@ 2018-03-28 22:32 sergiodj+buildbot
  2018-03-29  2:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-28 22:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8b6a949ae55d3adbade84af4e11415d764647fc9 ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 8b6a949ae55d3adbade84af4e11415d764647fc9

BFD/PA: Remove ATTRIBUTE_UNUSED from `elf_hppa_info_to_howto_rel'

Remove ATTRIBUTE_UNUSED annotation from the `abfd' parameter in
`elf_hppa_info_to_howto' now that commit f3185997ac09 ("PR 22875: Stop
strip corrupting unknown relocs"),
<https://sourceware.org/ml/binutils/2018-02/msg00445.html>, made it
used.

	bfd/
	* elf-hppa.h (elf_hppa_info_to_howto_rel): Remove
	ATTRIBUTE_UNUSED from `abfd'.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] BFD/PA: Correct formatting in `elf_hppa_info_to_howto_rel'
@ 2018-03-28 22:55 sergiodj+buildbot
  2018-03-29  1:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-28 22:55 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d81270c36986a4e470b0017bad5f415a2f916616 ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: d81270c36986a4e470b0017bad5f415a2f916616

BFD/PA: Correct formatting in `elf_hppa_info_to_howto_rel'

Wrap the `_bfd_error_handler' call to fit in 80 columns, fixing commit
e8f5af786c76 ("Use standardized error message for unrecognized relocs.").

	bfd/
	* elf-hppa.h (elf_hppa_info_to_howto_rel): Correct
	`_bfd_error_handler' call formatting.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PR binutils/22875: MIPS: Remove duplicate unsupported relocation processing
@ 2018-03-29 13:26 sergiodj+buildbot
  2018-03-29 13:38 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-29 13:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 75def2abc3dafb52418405905cd49e9c107c2640 ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 75def2abc3dafb52418405905cd49e9c107c2640

PR binutils/22875: MIPS: Remove duplicate unsupported relocation processing

Remove a duplicate `unsupported relocation type' message and the setting
of the `bfd_error_bad_value' error from `mips_elf32_rtype_to_howto',
added with commit f3185997ac09 ("PR 22875: Stop strip corrupting unknown
relocs"), <https://sourceware.org/ml/binutils/2018-02/msg00445.html>.
This message is already produced and the `bfd_error_bad_value' error set
by `mips_elf32_rtype_to_howto' before a NULL howto is returned, so there
is no need to repeat these actions here.

	bfd/
	* elf32-mips.c (mips_info_to_howto_rel): Remove the calls to
	`_bfd_error_handler' and to set the `bfd_error_bad_value' error.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove make_cleanup_unpush_target
@ 2018-03-30 19:31 sergiodj+buildbot
  2018-03-30 20:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-30 19:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9ae79dac31c2bcbd2f5418da2e12af94060e139a ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 9ae79dac31c2bcbd2f5418da2e12af94060e139a

Remove make_cleanup_unpush_target

This removes make_cleanup_unpush_target, replacing it with a
unique_ptr.  This may seem odd, because the object in question is not
actually freed, but unique_ptr provided the necessary functionality.

Tested by the buildbot.

gdb/ChangeLog
2018-03-30  Tom Tromey  <tom@tromey.com>

	* utils.h (make_cleanup_unpush_target): Remove.
	* inf-ptrace.c (struct target_unpusher): New.
	(target_unpush_up) New typedef.
	(inf_ptrace_create_inferior, inf_ptrace_attach): Use
	target_unpush_up.
	* utils.c (do_unpush_target, make_cleanup_unpush_target): Remove.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove parameter from free_dwo_file
@ 2018-03-30 19:55 sergiodj+buildbot
  2018-03-30 23:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-30 19:55 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5dafb3d176ab8d9b9f0a46111d7040bb51ad8f8e ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 5dafb3d176ab8d9b9f0a46111d7040bb51ad8f8e

Remove parameter from free_dwo_file

The objfile parameter to free_dwo_file is unused, so remove it.

gdb/ChangeLog
2018-03-30  Tom Tromey  <tom@tromey.com>

	* dwarf2read.c (free_dwo_file): Remove "objfile" parameter.
	(free_dwo_file_cleanup, free_dwo_file_from_slot): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove free_cached_comp_units cleanups
@ 2018-03-30 20:03 sergiodj+buildbot
  2018-03-30 21:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-30 20:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 11ed8cada64e717900117364c2fee0132c1eb099 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 11ed8cada64e717900117364c2fee0132c1eb099

Remove free_cached_comp_units cleanups

This changes free_cached_comp_units from a cleanup function to an RAII
class.

gdb/ChangeLog
2018-03-30  Tom Tromey  <tom@tromey.com>

	* dwarf2read.c (class free_cached_comp_units): New class.
	(dw2_instantiate_symtab, dwarf2_build_psymtabs_hard): Use it.
	(free_cached_comp_units): Remove function.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Change target_read_string to use unique_xmalloc_ptr
@ 2018-03-30 20:21 sergiodj+buildbot
  2018-03-31  2:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-30 20:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e83e4e24021acb4b095b1e8a45a51c2ea088a1ed ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: e83e4e24021acb4b095b1e8a45a51c2ea088a1ed

Change target_read_string to use unique_xmalloc_ptr

This changes the out parameter of target_read_string to be a
unique_xmalloc_ptr.  This avoids a cleanup and sets the stage for more
cleanup removals.

This patch also removes a seemingly needless alloca from
print_subexp_standard.

gdb/ChangeLog
2018-03-30  Tom Tromey  <tom@tromey.com>

	* windows-nat.c (handle_output_debug_string, handle_exception):
	Update.
	* target.h (target_read_string): Update.
	* target.c (target_read_string): Change "string" to
	unique_xmalloc_ptr.
	* solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
	Update.
	* solib-frv.c (frv_current_sos): Update.
	* solib-dsbt.c (dsbt_current_sos): Update.
	* solib-darwin.c (darwin_current_sos): Update.
	* linux-thread-db.c (inferior_has_bug): Update.
	* expprint.c (print_subexp_standard) <case OP_OBJC_MSGCALL>:
	Update.  Remove alloca.
	* ada-lang.c (ada_main_name): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove some cleanups from solib-svr4.c
@ 2018-03-30 20:35 sergiodj+buildbot
  2018-03-31  3:39 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-30 20:35 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a7961323e2fce4f831e117cc43e20e5144192240 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: a7961323e2fce4f831e117cc43e20e5144192240

Remove some cleanups from solib-svr4.c

This removes a few cleanups from solib-svr4.c in a straightforward
way.

gdb/ChangeLog
2018-03-30  Tom Tromey  <tom@tromey.com>

	* solib-svr4.c (lm_info_read): Use gdb::byte_vector.  Return
	std::unique_ptr.
	(svr4_keep_data_in_core): Update.
	(svr4_read_so_list): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove free_dwo_file_cleanup
@ 2018-03-30 21:01 sergiodj+buildbot
  2018-03-31  1:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-30 21:01 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 263db9a1f4105b76ddf00829d50430ea0a3bcba6 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 263db9a1f4105b76ddf00829d50430ea0a3bcba6

Remove free_dwo_file_cleanup

This removes free_dwo_file_cleanup, the last cleanup in dwarf2read.c.
This is replaced with a unique_ptr; which, despite the fact that a
dwo_file is obstack-allocated, seemed like the best fit.

gdb/ChangeLog
2018-03-30  Tom Tromey  <tom@tromey.com>

	* dwarf2read.c (struct free_dwo_file_cleanup_data): Remove.
	(struct dwo_file_deleter): New.
	(dwo_file_up): New typedef.
	(open_and_init_dwo_file): Use dwo_file_up.
	(free_dwo_file_cleanup): Remove.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove usage of VEC(char_ptr) in gdbscm_parse_function_args
@ 2018-03-30 22:03 sergiodj+buildbot
  2018-03-31  7:37 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-30 22:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d8611974cf819e5f8cb9eb36907251f3e2d721c6 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: d8611974cf819e5f8cb9eb36907251f3e2d721c6

Remove usage of VEC(char_ptr) in gdbscm_parse_function_args

This is a straightforward replacement, no change in behavior are
intended/expected.

This is the last usage of VEC(char_ptr), so it can now be removed.

gdb/ChangeLog:

	* guile/scm-utils.c (gdbscm_parse_function_args): Replace VEC
	with std::vector.
	* common/gdb_vecs.h (DEF_VEC_P (char_ptr)): Remove.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use std::vector in uploaded_tp
@ 2018-03-30 22:45 sergiodj+buildbot
  2018-03-31  4:58 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-30 22:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a18ba4e4c9d64eeb2ea65e5315fbd8b4261a1756 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: a18ba4e4c9d64eeb2ea65e5315fbd8b4261a1756

Use std::vector in uploaded_tp

This patch changes the VEC(char_ptr) fields in uploaded_tp to use
std::vector<char *>.  At first, I wanted to creep in more changes, like
using std::string, but it was making the patch too big and less focused,
so I decided to keep it to just that.

It also looks like the strings in those vectors are never free'd.  If
so, we can fix that in another patch.

gdb/ChangeLog:

	* tracepoint.h (struct uploaded_tp): Initialize fields.
	<actions, step_actions, cmd_strings>: Change type to
	std::vector<char *>.
	* tracepoint.c (get_uploaded_tp): Allocate with new.
	(free_uploaded_tps): Free with delete.
	(parse_tracepoint_definition): Adjust to std::vector change.
	* breakpoint.c (read_uploaded_action): Likewise.
	(create_tracepoint_from_upload): Likewise.
	* ctf.c (ctf_write_uploaded_tp): Likewise.
	(SET_ARRAY_FIELD): Likewise.
	* tracefile-tfile.c (tfile_write_uploaded_tp): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use std::vector and std::string instead of VEC(char_ptr) in gdbserver tdesc
@ 2018-03-31  1:27 sergiodj+buildbot
  2018-03-31  6:18 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-03-31  1:27 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 17d08cd4137063dbc43d9989b9a5cb315171174f ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 17d08cd4137063dbc43d9989b9a5cb315171174f

Use std::vector and std::string instead of VEC(char_ptr) in gdbserver tdesc

This is a straightforward replacement, no change in behavior are
intended/expected.

gdb/gdbserver/ChangeLog:

	* tdesc.h (struct target_desc) <features>: Change type to
	std::vector<std::string>.
	* tdesc.c (target_desc::~target_desc): Adjust to std::vector
	changes.
	(tdesc_get_features_xml): Likewise.
	(tdesc_create_feature): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove char_ptr typedef
@ 2018-04-01 18:40 sergiodj+buildbot
  2018-04-01 18:53 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-01 18:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ec1f2d91e07522a77cbef7a438e132ff4a2a7839 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: ec1f2d91e07522a77cbef7a438e132ff4a2a7839

Remove char_ptr typedef

Now that all instances of VEC(char_ptr) are gone, we can remove the
typedef.  There is just one usage left, that is trivial to replace.

Tested by rebuilding on an enable-targets=all build.

gdb/ChangeLog:

	* common/gdb_vecs.h (char_ptr): Remove.
	* tracepoint.c (encode_actions_1): Remove usage of char_ptr.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Change rs6000_ptrace_ldinfo to return a byte_vector
@ 2018-04-02  2:44 sergiodj+buildbot
  2018-04-02  2:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-02  2:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 09473be85c13eab0d794e363d898b74d66431d72 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 09473be85c13eab0d794e363d898b74d66431d72

Change rs6000_ptrace_ldinfo to return a byte_vector

This changes rs6000_ptrace_ldinfo to return a byte_vector.  I think
this points out an existing double-free in
rs6000_xfer_shared_libraries.

Tested by the buildbot.

gdb/ChangeLog
2018-04-01  Tom Tromey  <tom@tromey.com>

	* rs6000-nat.c (rs6000_ptrace_ldinfo): Return a byte_vector.
	(rs6000_xfer_shared_libraries): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix infinite recursion when printing static member with typedef
@ 2018-04-02 18:45 sergiodj+buildbot
  2018-04-02 18:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-02 18:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 79f18731714e7f07af6e78b8da8a1ffacf4247b7 ***

Author: Weimin Pan <weimin.pan@oracle.com>
Branch: master
Commit: 79f18731714e7f07af6e78b8da8a1ffacf4247b7

Fix infinite recursion when printing static member with typedef

The original problem was fixed (see related PR 22242). But using a typedef
as the declared type for a static member variable, as commented in this PR,
is still causing gdb to get into infinite loop when printing the static
member's value. This problem can be reproduced as follows:

% cat t.cc
class A {
    typedef A type;
public:
    bool operator==(const type& other) { return true; }

    static const type INSTANCE;
};

const A A::INSTANCE;

int main() {
    A a;
    if (a == A::INSTANCE) {
        return -1;
    }
    return 0;
}
% g++ -g t.cc
% gdb -ex "start" -ex "p a" a.out

The fix is rather trivial - in cp_print_static_field(), should call
check_typedef() to get the static member's real type and use it to
check whether it's a struct or an array.

As Simon suggested, I've added a new test case to the testsuite
and am passing the original type, not the real type, as argument
to both cp_print_value_fields() and val_print().

Re-tested on both aarch64-linux-gnu and amd64-linux-gnu. No regressions.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add myself as a write-after-approval GDB maintainer.
@ 2018-04-02 22:13 sergiodj+buildbot
  2018-04-02 22:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-02 22:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b39efc483ac8caefa8b6480b7a01231230bc2298 ***

Author: Weimin Pan <weimin.pan@oracle.com>
Branch: master
Commit: b39efc483ac8caefa8b6480b7a01231230bc2298

Add myself as a write-after-approval GDB maintainer.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Change read_alphacoff_dynamic_symtab to use gdb::byte_vector
@ 2018-04-03 18:20 sergiodj+buildbot
  2018-04-03 18:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-03 18:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c5edbf3d1c58d59135788f084a3bf681a49e0f9a ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: c5edbf3d1c58d59135788f084a3bf681a49e0f9a

Change read_alphacoff_dynamic_symtab to use gdb::byte_vector

This changes read_alphacoff_dynamic_symtab to use gdb::byte_vector.
This allows for the removal of some cleanups.

Tested by the buildbot; though I don't know whether this code path is
ever actually run.

gdb/ChangeLog
2018-04-03  Tom Tromey  <tom@tromey.com>

	* mipsread.c (read_alphacoff_dynamic_symtab): Use
	gdb::byte_vector.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PR binutils/22875: MIPS/ELF: Also fail with relocation placeholders
@ 2018-04-04  1:17 sergiodj+buildbot
  2018-04-04  1:30 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-04  1:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7ed6f92aaffdcc0995b0247379fb8ea621854dce ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 7ed6f92aaffdcc0995b0247379fb8ea621854dce

PR binutils/22875: MIPS/ELF: Also fail with relocation placeholders

Do not consider placeholder EMPTY_HOWTO relocation entries valid in
`rtype_to_howto' MIPS handlers.  Instead issue an unsupported relocation
type error and return a NULL howto as with relocations outside the three
ISA-specific min-max ranges.

	bfd/
	* elf32-mips.c (mips_elf32_rtype_to_howto): Also return
	unsuccessfully for placeholder howtos.
	* elf64-mips.c (mips_elf64_rtype_to_howto): Likewise.
	* elfn32-mips.c (mips_elf_n32_rtype_to_howto): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PR binutils/22875: IQ2000/ELF: Prevent an out-of-bounds howto table access
@ 2018-04-04  1:44 sergiodj+buildbot
  2018-04-04  4:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-04  1:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0cc919dc6abede5e61b9d8234028fba879166088 ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 0cc919dc6abede5e61b9d8234028fba879166088

PR binutils/22875: IQ2000/ELF: Prevent an out-of-bounds howto table access

Prevent an out-of-bounds `iq2000_elf_howto_table' table access in
`iq2000_info_to_howto_rela' by using the size of the table rather than
R_IQ2000_max to determine the number of entries in the contiguous
regular IQ2000 relocation range defined and described in the table.

	bfd/
	* elf32-iq2000.c (iq2000_info_to_howto_rela): Correct the range
	check for `iq2000_elf_howto_table' table access.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PR binutils/22875: FRV/ELF: Prevent an out-of-bounds howto table access
@ 2018-04-04  2:02 sergiodj+buildbot
  2018-04-04  2:49 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-04  2:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f428698edfd845a21639f5145cba3772eb92abc2 ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: f428698edfd845a21639f5145cba3772eb92abc2

PR binutils/22875: FRV/ELF: Prevent an out-of-bounds howto table access

Prevent an out-of-bounds `elf32_frv_howto_table' table access in
`frv_info_to_howto_rela' by using the size of the table rather than
R_FRV_max to determine the number of entries in the contiguous regular
FRV relocation range defined and described in the table.

	bfd/
	* elf32-frv.c (frv_info_to_howto_rela): Correct the range check
	for `elf32_frv_howto_table' table access.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PR binutils/22875: Visium/ELF: Prevent an out-of-bounds howto table access
@ 2018-04-04  2:16 sergiodj+buildbot
  2018-04-04  5:44 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-04  2:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 707bad1b21c18cf8e570fb8df8f7c5961fb0f3a5 ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 707bad1b21c18cf8e570fb8df8f7c5961fb0f3a5

PR binutils/22875: Visium/ELF: Prevent an out-of-bounds howto table access

Prevent an out-of-bounds `visium_elf_howto_table' table access in
`visium_info_to_howto_rela' by using the size of the table rather than
R_VISIUM_max to determine the number of entries in the contiguous
regular Visium relocation range defined and described in the table.

	bfd/
	* elf32-visium.c (visium_info_to_howto_rela): Correct the range
	check for `visium_elf_howto_table' table access.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PR binutils/22875: i860/ELF: Report unsupported relocation types
@ 2018-04-04  2:30 sergiodj+buildbot
  2018-04-04  7:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-04  2:30 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5d7c8b80485d75242e7c78e79b3ecb4c71abaee3 ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 5d7c8b80485d75242e7c78e79b3ecb4c71abaee3

PR binutils/22875: i860/ELF: Report unsupported relocation types

Complement commit f3185997ac09 ("PR 22875: Stop strip corrupting unknown
relocs"), <https://sourceware.org/ml/binutils/2018-02/msg00445.html>,
and also set the `bfd_error_bad_value' error and report an unsupported
relocation type if a howto lookup fails with the i860 backend, fixing a
confusing `no error' error message and removing a binutils test failure:

failed with: <.../binutils/strip-new: tmpdir/bintest.o: no error>, expected: <.* bad value>
.../binutils/strip-new: tmpdir/bintest.o: no error
FAIL: binutils-all/strip-13

with the `i860-stardent-elf' target.

	bfd/
	* elf32-i860.c (lookup_howto): Add `abfd' parameter.  Set the
	`bfd_error_bad_value' error and call `_bfd_error_handler' on a
	howto lookup failure.
	(elf32_i860_reloc_type_lookup): Adjust `lookup_howto' call
	accordingly.
	(elf32_i860_info_to_howto_rela): Likewise.
	(elf32_i860_relocate_splitn): Likewise.
	(elf32_i860_relocate_pc16): Likewise.
	(elf32_i860_relocate_pc26): Likewise.
	(elf32_i860_relocate_section): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PR binutils/22875: HPPA/ELF: Also fail with relocation placeholders
@ 2018-04-04  2:44 sergiodj+buildbot
  2018-04-04  9:27 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-04  2:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8ee55178c22326c3624ad5872dc5382341ddcd2c ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 8ee55178c22326c3624ad5872dc5382341ddcd2c

PR binutils/22875: HPPA/ELF: Also fail with relocation placeholders

Do not consider R_PARISC_UNIMPLEMENTED placeholder relocation entries of
the `elf_hppa_howto_table' table valid in `info_to_howto' HPPA handlers.
Instead issue an unsupported relocation type error and return a NULL
howto as with relocations whose number is R_PARISC_UNIMPLEMENTED or
beyond.

	bfd/
	* elf-hppa.h (elf_hppa_info_to_howto): Also return
	unsuccessfully for unimplemented relocations.
	(elf_hppa_info_to_howto_rel): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Update Spanish translations for ld/ opcodes/ and gold/ sub-directories
@ 2018-04-04  8:16 sergiodj+buildbot
  2018-04-04 11:49 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-04  8:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4fb0d2b912ad079263ed98a3c4d78e5a7ccc93b0 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 4fb0d2b912ad079263ed98a3c4d78e5a7ccc93b0

Update Spanish translations for ld/ opcodes/ and gold/ sub-directories


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] i386: Clear vex instead of vex.evex
@ 2018-04-04 11:58 sergiodj+buildbot
  2018-04-04 13:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-04 11:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT caf0678c84b5b55fbc4bcc853954745a4ad8b658 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: caf0678c84b5b55fbc4bcc853954745a4ad8b658

i386: Clear vex instead of vex.evex

"vex" has many fields to control how to decode an instruction.  Clear
all fields in "vex" before decoding an instruction to avoid using values
left from the previous instruction.

gas/

	PR binutils/23025
	* testsuite/gas/i386/prefix.s: Add tests for vcvtpd2dq with
	VEX and EVEX prefixes.
	* testsuite/gas/i386/prefix.d: Updated.

opcodes/

	PR binutils/23025
	* i386-dis.c (get_valid_dis386): Don't set vex.prefix nor vex.w
	to 0.
	(print_insn): Clear vex instead of vex.evex.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] elf-hppa.h warning fix
@ 2018-04-05  0:02 sergiodj+buildbot
  2018-04-05  0:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-05  0:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0e8452bb2297b5eb98a447f357ac82bece4e7024 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 0e8452bb2297b5eb98a447f357ac82bece4e7024

elf-hppa.h warning fix

	* elf-hppa.h (elf_hppa_info_to_howto): Init howto to NULL.
	(elf_hppa_info_to_howto_rel): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove some cleanups from search_minsyms_for_name
@ 2018-04-05 13:56 sergiodj+buildbot
  2018-04-05 14:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-05 13:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 41c1efc614472cdc74397e734f5a66018362a80a ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 41c1efc614472cdc74397e734f5a66018362a80a

Remove some cleanups from search_minsyms_for_name

This changes struct collect_minsyms to use a std::vector, which
enables the removal of a cleanup from search_minsyms_for_name.  This
also changes iterate_over_minimal_symbols to take a
gdb::function_view, which makes a function in linespec.c more
type-safe.

ChangeLog
2018-04-05  Tom Tromey  <tom@tromey.com>

	* minsyms.h (iterate_over_minimal_symbols): Update.
	* minsyms.c (iterate_over_minimal_symbols): Take a
	gdb::function_view.
	* linespec.c (struct collect_minsyms): Remove.
	(compare_msyms): Now a std::sort comparator.
	(add_minsym): Add parameters.
	(search_minsyms_for_name): Update.  Use std::vector.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix some indentation in linespec.c
@ 2018-04-05 14:10 sergiodj+buildbot
  2018-04-05 15:43 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-05 14:10 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6a307fc5f59179005e070bd5a5a4cf78a9ecefd4 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 6a307fc5f59179005e070bd5a5a4cf78a9ecefd4

Fix some indentation in linespec.c

This removes some leftover comments and fixes the indentation in a
couple of spots in linespec.c.

ChangeLog
2018-04-05  Tom Tromey  <tom@tromey.com>

	* linespec.c (linespec_parse_basic): Reindent.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Make copy_token_string return unique_xmalloc_ptr
@ 2018-04-05 14:24 sergiodj+buildbot
  2018-04-05 17:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-05 14:24 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a5b5adf529fa64391bc1ef733b3e78f15d94c4b9 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: a5b5adf529fa64391bc1ef733b3e78f15d94c4b9

Make copy_token_string return unique_xmalloc_ptr

This changes copy_token_string to return a unique_xmalloc_ptr, which
allows the removal of some cleanups.

ChangeLog
2018-04-05  Tom Tromey  <tom@tromey.com>

	* linespec.c (copy_token_string): Return a unique_xmalloc_ptr.
	(unexpected_linespec_error): Update.
	(linespec_parse_basic, parse_linespec): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Return std::string from canonical_to_fullform
@ 2018-04-05 14:37 sergiodj+buildbot
  2018-04-05 18:38 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-05 14:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 53a0f8a250199af97ff8708e3899835086c7a24d ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 53a0f8a250199af97ff8708e3899835086c7a24d

Return std::string from canonical_to_fullform

This changes canonical_to_fullform to return a std::string, and
changes decode_line_2 to use std::vector.  This allows for the removal
of some cleanups.

ChangeLog
2018-04-05  Tom Tromey  <tom@tromey.com>

	* linespec.c (canonical_to_fullform): Return std::string.
	(filter_results): Update.
	(struct decode_line_2_item): Add constructor.
	<fullform, displayform>: Now std::string.
	(decode_line_2_compare_items): Now a std::sort comparator.
	(decode_line_2): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Have filter_results take a std::vector
@ 2018-04-05 14:52 sergiodj+buildbot
  2018-04-05 19:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-05 14:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f73c6ece7888af880d3b03b2d57ee7782f2a539b ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: f73c6ece7888af880d3b03b2d57ee7782f2a539b

Have filter_results take a std::vector

This chagnes filter_results to take a std::vector, allowing the
removal of some cleanups in its callers.

ChangeLog
2018-04-05  Tom Tromey  <tom@tromey.com>

	* linespec.c (filter_results): Use std::vector.
	(decode_line_2, decode_line_full): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove a string copy from event_location_to_sals
@ 2018-04-05 15:05 sergiodj+buildbot
  2018-04-05 23:45 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-05 15:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9be2c17a900178df75a2208fd112ceb4325a70c1 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 9be2c17a900178df75a2208fd112ceb4325a70c1

Remove a string copy from event_location_to_sals

The use of "const" showed that a string copy in event_location_to_sals
was unnecessary.  This patch removes it.

ChangeLog
2018-04-05  Tom Tromey  <tom@tromey.com>

	* linespec.c (event_location_to_sals) <case ADDRESS_LOCATION>:
	Remove a string copy.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] More use of std::vector in linespec.c
@ 2018-04-05 15:34 sergiodj+buildbot
  2018-04-06  3:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-05 15:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9b2f85815c57d2eb4322a3d87464b5686cdbb391 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 9b2f85815c57d2eb4322a3d87464b5686cdbb391

More use of std::vector in linespec.c

This changes some spots in linespec.c to take a std::vector.  This
patch spilled out to objc-lang.c a bit as well.  This change allows
for the removal of some cleanups.

ChangeLog
2018-04-05  Tom Tromey  <tom@tromey.com>

	* utils.c (compare_strings): Remove.
	* utils.h (compare_strings): Remove.
	* objc-lang.h (find_imps): Update.
	* objc-lang.c (find_methods): Take a std::vector.
	(uniquify_strings, find_imps): Likewise.
	* linespec.c (find_methods): Take a std::vector.
	(decode_objc): Use std::vector.
	(add_all_symbol_names_from_pspace, find_superclass_methods): Take
	a std::vector.
	(find_method, find_function_symbols): Use std::vector.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove typep and VEC(typep) from linespec.c
@ 2018-04-05 15:48 sergiodj+buildbot
  2018-04-06  4:59 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-05 15:48 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8e8d776ead8187343652bda8aa373babe505bd4e ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 8e8d776ead8187343652bda8aa373babe505bd4e

Remove typep and VEC(typep) from linespec.c

This removes VEC(typep) from linespec.c in favor of std::vector.  It
also removes the "typep" typedef.  This change allowed the removal of
some cleanups.

I believe the previous cleanup code in find_superclass_methods could
result in a memory leak, so this patch is an improvement in that way
as well.

ChangeLog
2018-04-05  Tom Tromey  <tom@tromey.com>

	* linespec.c (typep): Remove typedef.
	(find_methods, find_superclass_methods): Take a std::vector.
	(find_method): Use std::vector.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove unnecessary include from linespec.h
@ 2018-04-05 16:01 sergiodj+buildbot
  2018-04-06  6:18 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-05 16:01 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8a76bd3ba43205b76226f41fe73e2840c2444742 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 8a76bd3ba43205b76226f41fe73e2840c2444742

Remove unnecessary include from linespec.h

linespec.h was inculding vec.h, but doesn't expose any VECs.
So, this include can be removed.

ChangeLog
2018-04-05  Tom Tromey  <tom@tromey.com>

	* linespec.h: Remove include of "vec.h".


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Change streq to return bool
@ 2018-04-05 18:17 sergiodj+buildbot
  2018-04-06  2:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-05 18:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 459a2e4ccf9aadfba9819facba1c9be5297c1625 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 459a2e4ccf9aadfba9819facba1c9be5297c1625

Change streq to return bool

I wanted to use streq with std::unique in another (upcoming) patch in
this seres, so I changed it to return bool.  To my surprise, this lead
to regressions.  The cause turned out to be that streq was used as an
htab callback -- by casting it to the correct function type.  This
sort of cast is invalid, so this patch adds a variant which is
directly suitable for use by htab.  (Note that I did not add an
overload, as I could not get that to work with template deduction in
the other patch.)

ChangeLog
2018-04-05  Tom Tromey  <tom@tromey.com>

	* completer.c (completion_tracker::completion_tracker): Remove
	cast.
	(completion_tracker::discard_completions): Likewise.
	* breakpoint.c (ambiguous_names_p): Remove cast.
	* ada-lang.c (_initialize_ada_language): Remove cast.
	* utils.h (streq): Update.
	(streq_hash): Add new declaration.
	* utils.c (streq): Return bool.
	(streq_hash): New function.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] config: Sync with GCC
@ 2018-04-05 22:49 sergiodj+buildbot
  2018-04-06  8:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-05 22:49 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 552d4da4178cc5e8d567ee150462a28d51f08fc0 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 552d4da4178cc5e8d567ee150462a28d51f08fc0

config: Sync with GCC

	Sync with GCC
	2018-04-05  H.J. Lu  <hongjiu.lu@intel.com>

	PR gas/22318
	* plugins.m4 (AC_PLUGINS): Use dlsym to check if libdl is needed.

	2018-02-14  Igor Tsimbalist  <igor.v.tsimbalist@intel.com>

	PR target/84148
	* cet.m4: Check if target support multi-byte NOPS (SSE).


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use dlsym to check if libdl is needed for plugin
@ 2018-04-05 22:53 sergiodj+buildbot
  2018-04-06 10:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-05 22:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3cba8b6c93ab8c573ba4678255df11486de61c54 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 3cba8b6c93ab8c573ba4678255df11486de61c54

Use dlsym to check if libdl is needed for plugin

config/plugins.m4 has

 if test "$plugins" = "yes"; then
    AC_SEARCH_LIBS([dlopen], [dl])
  fi

Plugin uses dlsym, but libasan.so only intercepts dlopen, not dlsym:

[hjl@gnu-tools-1 binutils-text]$ nm -D /lib64/libasan.so.4| grep " dl"
0000000000038580 W dlclose
                 U dl_iterate_phdr
000000000004dc50 W dlopen
                 U dlsym
                 U dlvsym
[hjl@gnu-tools-1 binutils-text]$

Testing dlopen for libdl leads to false negative when -fsanitize=address
is used.  It results in link failure:

../bfd/.libs/libbfd.a(plugin.o): undefined reference to symbol 'dlsym@@GLIBC_2.16'

dlsym should be used to check if libdl is needed for plugin.

bfd/

	PR gas/22318
	* configure: Regenerated.

binutils/

	PR gas/22318
	* configure: Regenerated.

gas/

	PR gas/22318
	* configure: Regenerated.

gprof/

	PR gas/22318
	* configure: Regenerated.

ld/

	PR gas/22318
	* configure: Regenerated.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86-64: Don't mask out R_X86_64_converted_reloc_bit
@ 2018-04-06 12:23 sergiodj+buildbot
  2018-04-06 12:36 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-06 12:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a6fd92b0578c5d2172799d7f38ddbda1bd87ea03 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: a6fd92b0578c5d2172799d7f38ddbda1bd87ea03

x86-64: Don't mask out R_X86_64_converted_reloc_bit

R_X86_64_converted_reloc_bit is set in elf_x86_64_convert_load_reloc
which is called from elf_x86_64_check_relocs.  Since it is used only
internally by linker, there is no need to mask it out in
elf_x86_64_info_to_howto.

	* elf64-x86-64.c (elf_x86_64_info_to_howto): Don't mask out
	R_X86_64_converted_reloc_bit.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add -Wno-error=deprecated-register to gdb build flags
@ 2018-04-06 20:32 sergiodj+buildbot
  2018-04-06 20:44 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-06 20:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7f8a5d38ed00ad4ecc920322c4b852f3cf905a94 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 7f8a5d38ed00ad4ecc920322c4b852f3cf905a94

Add -Wno-error=deprecated-register to gdb build flags

As shown in PR 23022, building with clang-6 and Python 2 trips on the
fact that the Python 2 headers use the "register" keyword:

/usr/include/python2.7/unicodeobject.h:534:5: error: 'register' storage class specifier is deprecated and incompatible with C++17 [-Werror,-Wdeprecated-register]
    register PyObject *obj,     /* Object */
    ^~~~~~~~~

This patch adds -Wno-error=deprecated-register to our flags, so that we can
still see this class of warnings, but they don't cause a build failure.

gdb/ChangeLog:

	PR gdb/23022
	* warning.m4: Add -Wno-error=deprecated-register.
	* configure: Re-generate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Introduce a gdb_ref_ptr specialization for struct value
@ 2018-04-06 22:03 sergiodj+buildbot
  2018-04-06 22:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-06 22:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 22bc8444e6d377fd016253926c2a2597ff944842 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 22bc8444e6d377fd016253926c2a2597ff944842

Introduce a gdb_ref_ptr specialization for struct value

struct value is internally reference counted and so, while it also has
some ownership rules unique to it, it makes sense to use a gdb_ref_ptr
when managing it automatically.

This patch removes the existing unique_ptr specialization in favor of
a reference-counted pointer.  It also introduces two other
clarifications:

1. Rename value_free to value_decref, which I think is more in line
   with what the function actually does; and

2. Change release_value to return a gdb_ref_ptr.  This change allows
   us to remove the confusing release_value_or_incref function,
   primarily by making it much simpler to reason about the result of
   release_value.

gdb/ChangeLog
2018-04-06  Tom Tromey  <tom@tromey.com>

	* varobj.c (varobj_clear_saved_item)
	(update_dynamic_varobj_children, install_new_value, ~varobj):
	Update.
	* value.h (value_incref): Move declaration earlier.
	(value_decref): Rename from value_free.
	(struct value_ref_policy): New.
	(value_ref_ptr): New typedef.
	(struct value_deleter): Remove.
	(gdb_value_up): Remove typedef.
	(release_value): Change return type.
	(release_value_or_incref): Remove.
	* value.c (set_value_parent): Update.
	(value_incref): Change return type.
	(value_decref): Rename from value_free.
	(value_free_to_mark, free_all_values, free_value_chain): Update.
	(release_value): Return value_ref_ptr.
	(release_value_or_incref): Remove.
	(record_latest_value, set_internalvar, clear_internalvar):
	Update.
	* stack.c (info_frame_command): Don't call value_free.
	* python/py-value.c (valpy_dealloc, valpy_new)
	(value_to_value_object): Update.
	* printcmd.c (do_examine): Update.
	* opencl-lang.c (lval_func_free_closure): Update.
	* mi/mi-main.c (register_changed_p): Don't call value_free.
	* mep-tdep.c (mep_frame_prev_register): Don't call value_free.
	* m88k-tdep.c (m88k_frame_prev_register): Don't call value_free.
	* m68hc11-tdep.c (m68hc11_frame_prev_register): Don't call
	value_free.
	* guile/scm-value.c (vlscm_free_value_smob)
	(vlscm_scm_from_value): Update.
	* frame.c (frame_register_unwind, frame_unwind_register_signed)
	(frame_unwind_register_unsigned, get_frame_register_bytes)
	(put_frame_register_bytes): Don't call value_free.
	* findvar.c (address_from_register): Don't call value_free.
	* dwarf2read.c (dwarf2_compute_name): Don't call value_free.
	* dwarf2loc.c (entry_data_value_free_closure)
	(value_of_dwarf_reg_entry, free_pieced_value_closure)
	(dwarf2_evaluate_loc_desc_full): Update.
	* breakpoint.c (update_watchpoint, breakpoint_init_inferior)
	(~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
	(~watchpoint, watch_command_1)
	(invalidate_bp_value_on_memory_change): Update.
	* alpha-tdep.c (alpha_register_to_value): Don't call value_free.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Change breakpoints to use value_ref_ptr
@ 2018-04-06 22:16 sergiodj+buildbot
  2018-04-06 23:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-06 22:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 850645cfe82f5854af90ce73f2056712e20fcea2 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 850645cfe82f5854af90ce73f2056712e20fcea2

Change breakpoints to use value_ref_ptr

Now that value_ref_ptr exists, it is possible to simplify breakpoint
and bpstat memory management by using a value_ref_ptr rather than
manually handling the reference counts.

gdb/ChangeLog
2018-04-06  Tom Tromey  <tom@tromey.com>

	* value.c (release_value): Update.
	* breakpoint.h (struct watchpoint) <val>: Now a value_ref_ptr.
	(struct bpstats) <val>: Now a value_ref_ptr.
	* breakpoint.c (update_watchpoint, breakpoint_init_inferior)
	(~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
	(~watchpoint, print_it_watchpoint, watch_command_1)
	(invalidate_bp_value_on_memory_change): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Change last_examine_value to value_ref_ptr
@ 2018-04-06 22:31 sergiodj+buildbot
  2018-04-07  0:59 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-06 22:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9b5587295bbc57e5e0453b659e24d7c2b504b894 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 9b5587295bbc57e5e0453b659e24d7c2b504b894

Change last_examine_value to value_ref_ptr

This patch removes some manual reference count manipulation by
changing last_examine_value to be a value_ref_ptr and then updating
the users.

gdb/ChangeLog
2018-04-06  Tom Tromey  <tom@tromey.com>

	* printcmd.c (last_examine_address): Change type to
	value_ref_ptr.
	(do_examine, x_command): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Change value history to use value_ref_ptr
@ 2018-04-06 23:00 sergiodj+buildbot
  2018-04-07  3:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-06 23:00 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4d0266a0e0d9e9b615b04ff209a73d3725495835 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 4d0266a0e0d9e9b615b04ff209a73d3725495835

Change value history to use value_ref_ptr

This simplifies the value history implementation by replacing the
current data structure with a std::vector, and by making the value
history simply hold a reference to each value.

gdb/ChangeLog
2018-04-06  Tom Tromey  <tom@tromey.com>

	* value.c (VALUE_HISTORY_CHUNK, struct value_history_chunk)
	(value_history_chain, value_history_count): Remove.
	(value_history): New global.
	(record_latest_value, access_value_history, show_values)
	(preserve_values): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove free_value_chain
@ 2018-04-06 23:29 sergiodj+buildbot
  2018-04-07  6:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-06 23:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a6535de1903d9caad8c10c1d81c51a29612456a6 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: a6535de1903d9caad8c10c1d81c51a29612456a6

Remove free_value_chain

This patch changes value_release_to_mark and fetch_subexp_value to
return a std::vector of value references, rather than relying on the
"next" field that is contained in a struct value.  This makes it
simpler to reason about the returned values, and also allows for the
removal of free_value_chain.

gdb/ChangeLog
2018-04-06  Tom Tromey  <tom@tromey.com>

	* value.h (fetch_subexp_value, value_release_to_mark): Update.
	(free_value_chain): Remove.
	* value.c (free_value_chain): Remove.
	(value_release_to_mark): Return a std::vector.
	* ppc-linux-nat.c (num_memory_accesses): Change "chain" to a
	std::vector.
	(check_condition): Update.
	* eval.c (fetch_subexp_value): Change "val_chain" to a
	std::vector.
	* breakpoint.c (update_watchpoint): Update.
	(can_use_hardware_watchpoint): Change "vals" to a std::vector.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use new and delete for values
@ 2018-04-06 23:57 sergiodj+buildbot
  2018-04-07  9:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-06 23:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 466ce3aea9cec006b8b0e348c9021ac2c8106022 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 466ce3aea9cec006b8b0e348c9021ac2c8106022

Use new and delete for values

This adds a constructor and destructor to struct value, and then
changes value.c to use "new" and "delete".

While doing this I noticed a memory leak -- value_decref was not
freeing value::optimized_out.  This patch fixes this leak.

gdb/ChangeLog
2018-04-06  Tom Tromey  <tom@tromey.com>

	* value.c (struct value): Add constructor, destructor, and member
	initializers.
	(allocate_value_lazy, value_decref): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Change value::parent to a value_ref_ptr
@ 2018-04-07  0:11 sergiodj+buildbot
  2018-04-07 11:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-07  0:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2c8331b987f41fa53ed371d0bbeaa3cea50bd514 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 2c8331b987f41fa53ed371d0bbeaa3cea50bd514

Change value::parent to a value_ref_ptr

This changes value::parent to a value_ref_ptr.  This removes a bit of
manual reference count management.

gdb/ChangeLog
2018-04-06  Tom Tromey  <tom@tromey.com>

	* value.c (~value): Update.
	(struct value) <parent>: Now a value_ref_ptr.
	(value_parent, set_value_parent, value_address, value_copy):
	Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove range_s VEC
@ 2018-04-07  0:26 sergiodj+buildbot
  2018-04-07 12:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-07  0:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0c7e6dd852f01b3ea38b98c39a2bb36280b02b55 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 0c7e6dd852f01b3ea38b98c39a2bb36280b02b55

Remove range_s VEC

This changes the "optimized_out" and "unavailable" VECs in struct
value to be std::vectors, and then fixes up all the uses.

gdb/ChangeLog
2018-04-06  Tom Tromey  <tom@tromey.com>

	* value.c (range_s): Remove typedef, VEC.
	(struct range): Add operator<.
	(range_lessthan): Remove.
	(ranges_contain): Change type.
	(~value): Update.
	(struct value) <unavailable, optimized_out>: Now std::vector.
	(value_entirely_available)
	(value_entirely_covered_by_range_vector)
	(value_entirely_unavailable, value_entirely_optimized_out):
	Update.
	(insert_into_bit_range_vector): Change argument type.
	(find_first_range_overlap): Likewise.
	(struct ranges_and_idx, value_contents_bits_eq)
	(require_not_optimized_out, require_available): Update.
	(ranges_copy_adjusted): Change argument types.
	(value_optimized_out, value_copy, value_fetch_lazy): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Change value::contents to be a unique_xmalloc_ptr
@ 2018-04-07  0:40 sergiodj+buildbot
  2018-04-07 14:11 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-07  0:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 14c88955a138c24577e703d11f4d25c44a64d0be ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 14c88955a138c24577e703d11f4d25c44a64d0be

Change value::contents to be a unique_xmalloc_ptr

This changes value::contents to be a unique_xmalloc_ptr, removing a
small bit of manual memory management.

gdb/ChangeLog
2018-04-06  Tom Tromey  <tom@tromey.com>

	* value.c (~value): Update.
	(struct value) <contents>: Now unique_xmalloc_ptr.
	(value_contents_bits_eq, allocate_value_contents)
	(value_contents_raw, value_contents_all_raw)
	(value_contents_for_printing, value_contents_for_printing_const)
	(set_value_enclosing_type): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Change varobj to use value_ref_ptr
@ 2018-04-07  0:41 sergiodj+buildbot
  2018-04-07  2:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-07  0:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b4d61099ba840824fd0aac9800403f6278476347 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: b4d61099ba840824fd0aac9800403f6278476347

Change varobj to use value_ref_ptr

This changes varobj to use value_ref_ptr, allowing the removal of some
manual reference count management.

gdb/ChangeLog
2018-04-06  Tom Tromey  <tom@tromey.com>

	* varobj.h (struct varobj) <value>: Now a value_ref_ptr.
	* varobj.c (varobj_set_display_format, varobj_set_value)
	(install_default_visualizer, construct_visualizer)
	(install_new_value, ~varobj, varobj_get_value_type)
	(my_value_of_variable, varobj_editable_p): Update.
	* c-varobj.c (c_describe_child, c_value_of_variable)
	(cplus_number_of_children, cplus_describe_child): Update.
	* ada-varobj.c (ada_number_of_children, ada_name_of_child)
	(ada_path_expr_of_child, ada_value_of_child, ada_type_of_child)
	(ada_value_of_variable, ada_value_is_changeable_p): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove free_all_values
@ 2018-04-07  2:23 sergiodj+buildbot
  2018-04-07  4:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-07  2:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b562120198d9fa2c191823508813daa3b62a3a37 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: b562120198d9fa2c191823508813daa3b62a3a37

Remove free_all_values

free_all_values is unused, so this removes it.

gdb/ChangeLog
2018-04-06  Tom Tromey  <tom@tromey.com>

	* value.h (free_all_values): Remove.
	* value.c (free_all_values): Remove.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove value::next and value::released
@ 2018-04-07  4:04 sergiodj+buildbot
  2018-04-07  7:37 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-07  4:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 062d818d2535d4bc9ccd5dbf3c6702b9f3e763cc ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 062d818d2535d4bc9ccd5dbf3c6702b9f3e763cc

Remove value::next and value::released

This patch converts all_values to simply hold a list of references to
values.  Now, there's no need to have a value record whether or not it
is released -- there is only a single reference-counting mechanism for
values.  So, this also removes value::next, value::released, and
value_next.

gdb/ChangeLog
2018-04-06  Tom Tromey  <tom@tromey.com>

	* value.c (struct value) <released, next>: Remove.
	(all_values): Now a std::vector.
	(allocate_value_lazy): Update.
	(value_next): Remove.
	(value_mark, value_free_to_mark, release_value)
	(value_release_to_mark): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Make target_read_alloc & al return vectors
@ 2018-04-07 17:38 sergiodj+buildbot
  2018-04-07 17:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 17:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9018be22e022e6db2ba07c4e407c7244022bc69a ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 9018be22e022e6db2ba07c4e407c7244022bc69a

Make target_read_alloc & al return vectors

This patch started by changing target_read_alloc_1 to return a
byte_vector, to avoid manual memory management (in target_read_alloc_1
and in the callers).  To communicate failures to the callers, it
actually returns a gdb::optional<gdb::byte_vector>.

Adjusting target_read_stralloc was a bit more tricky, since it wants to
return a buffer of char, and not gdb_byte.  Since you can't just cast a
gdb::byte_vector into a gdb::def_vector<char>, I made
target_read_alloc_1 templated, so both versions (that return vectors of
gdb_byte and char) are generated.  Since target_read_stralloc now
returns a gdb::char_vector instead of a gdb::unique_xmalloc_ptr<char>, a
few callers need to be adjusted.

gdb/ChangeLog:

	* common/byte-vector.h (char_vector): New type.
	* target.h (target_read_alloc): Return
	gdb::optional<byte_vector>.
	(target_read_stralloc): Return gdb::optional<char_vector>.
	(target_get_osdata): Return gdb::optional<char_vector>.
	* target.c (target_read_alloc_1): Templatize.  Replacement
	manual memory management with vector.
	(target_read_alloc): Change return type, adjust.
	(target_read_stralloc): Change return type, adjust.
	(target_get_osdata): Change return type, adjust.
	* auxv.c (struct auxv_info) <length>: Remove.
	<data>: Change type to gdb::optional<byte_vector>.
	(auxv_inferior_data_cleanup): Free auxv_info with delete.
	(get_auxv_inferior_data): Allocate auxv_info with new, adjust.
	(target_auxv_search): Adjust.
	(fprint_target_auxv): Adjust.
	* avr-tdep.c (avr_io_reg_read_command): Adjust.
	* linux-tdep.c (linux_spu_make_corefile_notes): Adjust.
	(linux_make_corefile_notes): Adjust.
	* osdata.c (get_osdata): Adjust.
	* remote.c (remote_get_threads_with_qxfer): Adjust.
	(remote_memory_map): Adjust.
	(remote_traceframe_info): Adjust.
	(btrace_read_config): Adjust.
	(remote_read_btrace): Adjust.
	(remote_pid_to_exec_file): Adjust.
	* solib-aix.c (solib_aix_get_library_list): Adjust.
	* solib-dsbt.c (decode_loadmap): Don't free buf.
	(dsbt_get_initial_loadmaps): Adjust.
	* solib-svr4.c (svr4_current_sos_via_xfer_libraries): Adjust.
	* solib-target.c (solib_target_current_sos): Adjust.
	* tracepoint.c (sdata_make_value): Adjust.
	* xml-support.c (xinclude_start_include): Adjust.
	(xml_fetch_content_from_file): Adjust.
	* xml-support.h (xml_fetch_another): Change return type.
	(xml_fetch_content_from_file): Change return type.
	* xml-syscall.c (xml_init_syscalls_info): Adjust.
	* xml-tdesc.c (file_read_description_xml): Adjust.
	(fetch_available_features_from_target): Change return type.
	(target_fetch_description_xml): Adjust.
	(target_read_description_xml): Adjust.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Make "set osabi none" really work (PR 22980)
@ 2018-04-07 17:53 sergiodj+buildbot
  2018-04-07 19:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 17:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 26540402495f35d5f19762ceba66605bca8fa63b ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 26540402495f35d5f19762ceba66605bca8fa63b

Make "set osabi none" really work (PR 22980)

I was looking for a way to reproduce easily PR 22979 by doing this:

  (gdb) set architecture i386:x86-64
  (gdb) set osabi none

However, I noticed that even though I did "set osabi none", the gdbarch
gdb created was for Linux:

  (gdb) set debug arch 1
  (gdb) set architecture i386:x86-64
  ...
  (gdb) set osabi none
  gdbarch_find_by_info: info.bfd_arch_info i386:x86-64
  gdbarch_find_by_info: info.byte_order 1 (little)
  gdbarch_find_by_info: info.osabi 4 (GNU/Linux)  <--- Wrong?
  gdbarch_find_by_info: info.abfd 0x0
  gdbarch_find_by_info: info.tdep_info 0x0
  gdbarch_find_by_info: Previous architecture 0x1e6fd30 (i386:x86-64)
  selected
  gdbarch_update_p: Architecture 0x1e6fd30 (i386:x86-64) unchanged

This is because the value GDB_OSABI_UNKNOWN has an unclear role,
sometimes meaning "no osabi" and sometimes "please selected
automatically".  Doing "set osabi none" sets the requested osabi to
GDB_OSABI_UNKNOWN, in which case gdbarch_info_fill overrides it with a
value from the target description, or the built-in default osabi.  This
means that it's impossible to force GDB not to use an osabi with "set
osabi".  Since my GDB's built-in default osabi is Linux, it always falls
back to GDB_OSABI_LINUX.

To fix it, I introduced GDB_OSABI_NONE, which really means "I don't want
any osabi".  GDB_OSABI_UNKNOWN can then be used only for "not set yet,
please auto-detect".  GDB_OSABI_UNINITIALIZED now seems unnecessary
since it overlaps with GDB_OSABI_UNKNOWN, so I think it can be removed
and gdbarch_info::osabi can be initialized to GDB_OSABI_UNKNOWN.

gdb/ChangeLog:

	PR gdb/22980
	* defs.h (enum gdb_osabi): Remove GDB_OSABI_UNINITIALIZED, add
	GDB_OSABI_NONE.
	* arch-utils.c (gdbarch_info_init): Don't set info->osabi.
	* osabi.c (gdb_osabi_names): Add "unknown" entry.

gdb/testsuite/ChangeLog:

	PR gdb/22980
	* gdb.base/osabi.exp: New file.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix generation of x86-64 gdbarch with osabi none (PR 22979)
@ 2018-04-07 18:05 sergiodj+buildbot
  2018-04-07 20:29 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 18:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c912f608be7bc2598b919da2b11721b3c262d154 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: c912f608be7bc2598b919da2b11721b3c262d154

Fix generation of x86-64 gdbarch with osabi none (PR 22979)

When a 64-bits (x86-64) gdbarch is created, it is first born as a
32-bits gdbarch in i386_gdbarch_init.  The call gdbarch_init_osabi will
call the handler register for the selected (arch, osabi) pair, such as
amd64_linux_init_abi.  The various amd64 handlers call amd64_init_abi,
which turns the gdbarch into a 64-bits one.

When selecting the i386:x86-64 architecture with no osabi, no such
handler is ever called, so the gdbarch stays (wrongfully) a 32-bits one.

My first idea was to manually call amd64_init_abi & al in
i386_gdbarch_init when the osabi is GDB_OSABI_NONE.  However, this
doesn't work in a build of GDB where i386 is included as a target but
not amd64.  My next option (implemented in this patch), is to allow
registering handlers for GDB_OSABI_NONE.  I added two such handlers in
amd64-tdep.c, so now it works the same as for the "normal" osabis.  It
required re-ordering things in gdbarch_init_osabi to allow running
handlers for GDB_OSABI_NONE.

Without this patch applied (but with the previous one*) :

  (gdb) set osabi none
  (gdb) set architecture i386:x86-64
  The target architecture is assumed to be i386:x86-64
  (gdb) p sizeof(void*)
  $1 = 4

and now:

  (gdb) set osabi none
  (gdb) set architecture i386:x86-64
  The target architecture is assumed to be i386:x86-64
  (gdb) p sizeof(void*)
  $1 = 8

* Before the previous patch, which fixed "set osabi none", this bug was
  hidden because we didn't actually try to generate a gdbarch for no
  osabi, it would always fall back on Linux.  Generating the gdbarch for
  amd64/linux did work.

gdb/ChangeLog:

	PR gdb/22979
	* amd64-tdep.c (amd64_none_init_abi): New function.
	(amd64_x32_none_init_abi): New function.
	(_initialize_amd64_tdep): Register handlers for x86-64 and
	x64_32 with GDB_OSABI_NONE.
	* osabi.c (gdbarch_init_osabi): Allow running handlers for the
	GDB_OSABI_NONE osabi.

gdb/testsuite/ChangeLog:

	PR gdb/22979
	* gdb.arch/amd64-osabi.exp: New file.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Implement write_async_safe for mi_console_file (PR 22299)
@ 2018-04-07 18:34 sergiodj+buildbot
  2018-04-07 23:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 18:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7c4e78cf63f6436ae43e8289badba78d81e2eb2c ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 7c4e78cf63f6436ae43e8289badba78d81e2eb2c

Implement write_async_safe for mi_console_file (PR 22299)

Enabling "set debug lin-lwp 1" with the MI interpreter doesn't work.
When the sigchld_handler function wants to print a debug output
("sigchld\n"), it uses ui_file_write_async_safe.  This ends up in the
default implementation of ui_file::write_async_safe, which aborts GDB.

This patch implements the write_async_safe method for mi_console_file.
The "normal" MI output is line buffered, which means the output
accumulates in m_buffer until a \n is written, at which point it's
flushed in m_raw.  The implementation of write_async_safe provided by
this patch bypasses this buffer and writes directly to m_raw.  There are
two reasons for this:

(1) Appending to m_buffer (therefore to an std::string) is probably not
    async-safe, as it may allocate memory.
(2) We may have a partial output already in m_buffer, so that would lead
    to some nested MI output, not so great.

There is probably still a chance to have bad MI output, if
sigchld_handler is invoked in the middle of mi_console_file's flush, and
the line being flushed is only partially sent to m_raw.  The solution
would probably be to block signals during flushing.  Since this is only
used for debug output, I don't know if it's worth the effort to do that.

To implement write_async_safe, I needed to use the fputstrn_unfiltered,
which does the necessary escaping (e.g. replace \n with \\n).  I started
by adding printchar's callback parameters to fputstrn_unfiltered, to be
able to pass async-safe versions of them.  It's not easy to provide an
async-safe version of do_fprintf, but it turns out that we can easily
replace printchar's callbacks with a single do_fputc quite easily.  The
async-safe version of do_fputc simply calls the underlying ui_file's
write_async_safe method.

gdb/ChangeLog:

	PR mi/22299
	* mi/mi-console.c (do_fputc_async_safe): New.
	(mi_console_file::write_async_safe): New.
	(mi_console_file::flush): Adjust calls to fputstrn_unfiltered.
	* mi/mi-console.h (class mi_console_file) <write_async_safe>:
	New.
	* ui-file.c (ui_file::putstrn): Adjust call to
	fputstrn_unfiltered.
	* utils.c (printchar): Replace do_fputs and do_fprintf
	parameters by do_fputc.
	(fputstr_filtered): Adjust call to printchar.
	(fputstr_unfiltered): Likewise.
	(fputstrn_filtered): Likewise.
	(fputstrn_unfiltered): Add do_fputc parameter, pass to
	printchar.
	* utils.h (do_fputc_ftype): New typedef.
	(fputstrn_unfiltered): Add do_fputc parameter.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Defer breakpoint reset when cloning progspace for fork child
@ 2018-04-07 18:47 sergiodj+buildbot
  2018-04-08  0:28 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 18:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b2e586e850dbf1dafc10beea3250d22e70add4b5 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: b2e586e850dbf1dafc10beea3250d22e70add4b5

Defer breakpoint reset when cloning progspace for fork child

Using this simple test:

  static void
  break_here ()
  {
  }

  int
  main (int argc, char *argv[])
  {
    fork ();
    break_here();
    return 0;
  }

compiled as a PIE:

  $ gcc test.c -g3 -O0 -o test -pie

and running this:

  $ ./gdb -nx -q --data-directory=data-directory ./test -ex "b break_here" -ex "set detach-on-fork off" -ex r

gives:

  Warning:
  Cannot insert breakpoint 1.
  Cannot access memory at address 0x64a

Note that GDB might get stopped by SIGTTOU because of this issue:

  https://sourceware.org/bugzilla/show_bug.cgi?id=23020

In that case, just use "fg" to continue.

This issue happens only with position-independent executables.  Adding
the main objfile for the new inferior (the fork child) causes GDB to try
to reset the breakpoints.  However, that new objfile has not been
relocated yet.  So the breakpoint on "break_here" resolves to an
unrelocated address, from which we are trying to read/write to set a
breakpoint.  Passing SYMFILE_DEFER_BP_RESET avoids that problem.  The
executable is relocated just after, in the follow_fork_inferior
function.

The buildbot seems happy with this patch.  I don't think it's necessary
to add a new test.  Just changing this made many tests go from FAIL to
PASS on my machine, where gcc produces PIE executables by default.  If
anything, I think we would need to add a board file that produces
position-independent executables, so that we can run all the tests with
PIE, even on machines where that is not the default.

gdb/ChangeLog:

	* progspace.c (clone_program_space): Pass SYMFILE_DEFER_BP_RESET
	to symbol_file_add_main.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove some unused variables in dwarf2read.c
@ 2018-04-07 19:01 sergiodj+buildbot
  2018-04-08  1:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 19:01 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5ca3fcb669bc655e2e79866be086e8ac564e472b ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 5ca3fcb669bc655e2e79866be086e8ac564e472b

Remove some unused variables in dwarf2read.c

Most of them are obvious.  The ones in dwarf2_record_block_ranges are
less obvious, because it is a bit suspicious to have that many
variables unused.  But after inspection, it seems like it dates from
commit 5f46c5a54825 ("Code cleanup: Split dwarf2_ranges_read to a
callback"), where dwarf2_record_block_ranges was made to use
dwarf2_ranges_process, which contains the same functionality.

gdb/ChangeLog:

	* dwarf2read.c (create_signatured_type_table_from_debug_names):
	Remove unused variables.
	(dw2_map_symtabs_matching_filename): Likewise.
	(dwarf2_record_block_ranges): Likewise.
	(dwarf2_read_addr_index): Likewise.
	(follow_die_offset): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove some usages of get_dwarf2_per_objfile
@ 2018-04-07 19:29 sergiodj+buildbot
  2018-04-08  4:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 19:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 12359b5e8f2a4034e1e4cd7f0b454fb03151df4c ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 12359b5e8f2a4034e1e4cd7f0b454fb03151df4c

Remove some usages of get_dwarf2_per_objfile

This patch removes some usages of get_dwarf2_per_objfile, where we can
get hold of the dwarf2_per_objfile object in a simpler way.  For
example, it's simpler (and slightly less work) to pass
dwarf2_per_objfile and get the objfile from it than to pass the objfile
and call get_dwarf2_per_objfile.

Ideally, get_dwarf2_per_objfile should only be used in the entry points
of the dwarf2 code, where we receive an objfile.

gdb/ChangeLog:

	* dwarf2read.c (create_cus_from_index_list): Replace objfile arg
	with dwarf2_per_objfile.
	(create_cus_from_index): Likewise.
	(create_signatured_type_table_from_index): Likewise.
	(dwarf2_read_index): Likewise.
	(dwarf2_initialize_objfile): Likewise.
	(dwarf2_fetch_die_loc_sect_off):  Get dwarf2_per_objfile from
	per_cu rather than get_dwarf2_per_objfile.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Make dwarf2_per_objfile::all_comp_units an std::vector
@ 2018-04-07 19:43 sergiodj+buildbot
  2018-04-08  5:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 19:43 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b76e467de35d6b107edff1d4b9de15fb7ebacbbd ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: b76e467de35d6b107edff1d4b9de15fb7ebacbbd

Make dwarf2_per_objfile::all_comp_units an std::vector

Make all_comp_units an std::vector, remove n_comp_units and some manual
memory management.

gdb/ChangeLog:

	* dwarf2read.h (struct dwarf2_per_objfile) <all_comp_units>: Likewise.
	Make an std::vector.
	<n_comp_units>: Remove.
	* dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
	to std::vector change.
	(dwarf2_per_objfile::get_cutu): Likewise.
	(dwarf2_per_objfile::get_cu): Likewise.
	(create_cus_from_index): Likewise.
	(create_addrmap_from_index): Likewise.
	(create_addrmap_from_aranges): Likewise.
	(dwarf2_read_index): Likewise.
	(dw2_find_last_source_symtab): Likewise.
	(dw2_map_symtabs_matching_filename): Likewise.
	(dw2_symtab_iter_next): Likewise.
	(dw2_print_stats): Likewise.
	(dw2_expand_all_symtabs): Likewise.
	(dw2_expand_symtabs_with_fullname): Likewise.
	(dw2_expand_marked_cus): Likewise.
	(dw2_map_symbol_filenames): Likewise.
	(create_cus_from_debug_names): Likewise.
	(dwarf2_read_debug_names): Likewise.
	(dw2_debug_names_iterator::next): Likewise.
	(dwarf2_initialize_objfile): Likewise.
	(set_partial_user): Likewise.
	(dwarf2_build_psymtabs_hard): Likewise.
	(read_comp_units_from_section): Remove arguments, adjust to
	std::vector change.
	(create_all_comp_units): Adjust to std::vector and
	read_comp_units_from_section changes.
	(dwarf2_find_containing_comp_unit): Adjust to std::vector
	change.
	* dwarf-index-write.c (check_dwarf64_offsets): Likewise.
	(psyms_seen_size): Likewise.
	(write_gdbindex): Likewise.
	(write_debug_names): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Make dwarf2_per_objfile::all_type_units an std::vector
@ 2018-04-07 19:57 sergiodj+buildbot
  2018-04-08  7:04 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 19:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b2bdb8cf395f491319264cda42e41538f55a86d9 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: b2bdb8cf395f491319264cda42e41538f55a86d9

Make dwarf2_per_objfile::all_type_units an std::vector

Make all_type_units an std::vector, remove
n_type_units/n_allocated_type_units and some manual memory management.

gdb/ChangeLog:

	* dwarf2read.h (struct dwarf2_per_objfile) <n_type_units>:
	Remove.
	<n_allocated_type_units>: Remove.
	<all_type_units>: Change to std::vector.
	* dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
	to std::vector change.
	(dwarf2_per_objfile::get_cutu): Likewise.
	(dwarf2_per_objfile::get_tu): Likewise.
	(create_signatured_type_table_from_index): Likewise.
	(create_signatured_type_table_from_debug_names): Likewise.
	(dw2_symtab_iter_next): Likewise.
	(dw2_print_stats): Likewise.
	(dw2_expand_all_symtabs): Likewise.
	(dw2_expand_marked_cus): Likewise.
	(dw2_debug_names_iterator::next): Likewise.
	(dwarf2_initialize_objfile): Likewise.
	(add_signatured_type_cu_to_table): Likewise.
	(create_all_type_units): Likewise.
	(add_type_unit): Likewise.
	(struct tu_abbrev_offset): Add constructor.
	(build_type_psymtabs_1): Adjust to std::vector change.
	(print_tu_stats): Likewise.
	* dwarf-index-write.c (check_dwarf64_offsets): Likewise.
	(write_debug_names): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Replace make_cleanup_restore_current_traceframe with RAII class
@ 2018-04-07 20:11 sergiodj+buildbot
  2018-04-08  9:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 20:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6f14adc55864818ec3754460f5df4150c2addf42 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 6f14adc55864818ec3754460f5df4150c2addf42

Replace make_cleanup_restore_current_traceframe with RAII class

I put the constructor in tracepoint.c because it needs to read
traceframe_number, and I prefer to do that than to expose
traceframe_number.

gdb/ChangeLog:

	* tracepoint.c (struct current_traceframe_cleanup): Remove.
	(do_restore_current_traceframe_cleanup): Remove.
	(restore_current_traceframe_cleanup_dtor): Remove.
	(make_cleanup_restore_current_traceframe): Remove.
	(scoped_restore_current_traceframe::scoped_restore_current_traceframe):
	New.
	* tracepoint.h (struct scoped_restore_current_traceframe): New.
	* infrun.c (fetch_inferior_event): Use
	scoped_restore_current_traceframe.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove stale file i386-avx.dat
@ 2018-04-07 20:17 sergiodj+buildbot
  2018-04-07 21:49 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 20:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5dc026d3f04ac657378308202ff7d43a1613f14c ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 5dc026d3f04ac657378308202ff7d43a1613f14c

Remove stale file i386-avx.dat

I noticed that regformats/i386/i386-avx.dat did not get re-generated
when doing "make" in the features directory.  I think it's a leftover
from commit

  f5a29eb0a663 ("Clean up x86 non-linux GDBserver target descriptions")

I build-tested gdbserver with amd64 and i386.

gdb/ChangeLog:

	* regformats/i386/i386-avx.dat: Remove.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix indentation in gdb.mi/mi-stack.exp
@ 2018-04-07 20:26 sergiodj+buildbot
  2018-04-08 10:59 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 20:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9b73db36739a72d216eb14d35edac2acfca7faa3 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 9b73db36739a72d216eb14d35edac2acfca7faa3

Fix indentation in gdb.mi/mi-stack.exp

This patch fixes the indentation in gdb.mi/mi-stack.exp, which is a bit
inconsistent.

gdb/testsuite/ChangeLog:

	* gdb.mi/mi-stack.exp: Fix indentation.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix gdb.mi/mi-stack.exp when gcc generates a stack protector
@ 2018-04-07 20:40 sergiodj+buildbot
  2018-04-08 12:53 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 20:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a0be7a3671e6252c0f3353d128f84c641005fa06 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: a0be7a3671e6252c0f3353d128f84c641005fa06

Fix gdb.mi/mi-stack.exp when gcc generates a stack protector

I see some failures in the gdb.mi/mi-stack.exp test.  The test runs to
the callee4 function:

  int callee4 (void)
  {
    int A=1;
    int B=2;
    int C;
    int D[3] = {0, 1, 2};

    C = A + B;
    return 0;
  }

and expects to be stopped at the A=1 line.  However, when gcc generates
some stack protection code, it will stop at the { instead, as shown by
this disassembly (after I did "break callee4" and "run"):

  (gdb) disassemble /s
  Dump of assembler code for function callee4:
  /home/simark/src/binutils-gdb/gdb/testsuite/gdb.mi/mi-stack.c:
  26	{
     0x00005555555546ca <+0>:	push   %rbp
     0x00005555555546cb <+1>:	mov    %rsp,%rbp
     0x00005555555546ce <+4>:	sub    $0x20,%rsp
  => 0x00005555555546d2 <+8>:	mov    %fs:0x28,%rax
     0x00005555555546db <+17>:	mov    %rax,-0x8(%rbp)
     0x00005555555546df <+21>:	xor    %eax,%eax

  27	  int A=1; /* callee4 begin */
     0x00005555555546e1 <+23>:	movl   $0x1,-0x20(%rbp)

  28	  int B=2;
     0x00005555555546e8 <+30>:	movl   $0x2,-0x1c(%rbp)

The rest of the test relies on execution stopping on the A=1, so many things
fail after that.  This patch uses mi_continue_to_line instead, to stop at the
A=1 line precisely.

gdb/testsuite/ChangeLog:

	* gdb.mi/mi-stack.exp (test_stack_frame_listing): Use
	mi_continue_to_line.
	* gdb.mi/mi-stack.c (callee4): Add comment.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Replace dw2_get_cu/dw2_get_cutu with methods of dwarf2_per_objfile
@ 2018-04-07 20:50 sergiodj+buildbot
  2018-04-08  3:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 20:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ff4c9fec8413fa4e0b11ef092a86669305894a7a ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: ff4c9fec8413fa4e0b11ef092a86669305894a7a

Replace dw2_get_cu/dw2_get_cutu with methods of dwarf2_per_objfile

Those two functions look like good candidates to become methods of
dwarf2_per_objfile.  I did that, and added get_tu as well.  When
replacing usages of dw2_get_cutu, I changed some instances to get_cutu
and others to get_cu, when appropriate (when we know we want a CU and
not a TU).

gdb/ChangeLog:

	* dwarf2read.h (struct signatured_type): Forward declare.
	(struct dwarf2_per_objfile) <get_cutu, get_cu, get_tu>:
	New methods.
	* dwarf2read.c (dwarf2_per_objfile::get_cutu): Rename from...
	(dw2_get_cutu): ...this.
	(dwarf2_per_objfile::get_cu): Rename from...
	(dw2_get_cu): ...this.
	(dwarf2_per_objfile::get_tu): New.
	(create_addrmap_from_index): Adjust.
	(create_addrmap_from_aranges): Adjust.
	(dw2_find_last_source_symtab): Adjust.
	(dw2_map_symtabs_matching_filename): Adjust.
	(dw2_symtab_iter_next): Adjust.
	(dw2_print_stats): Adjust.
	(dw2_expand_all_symtabs): Adjust.
	(dw2_expand_symtabs_with_fullname): Adjust.
	(dw2_expand_marked_cus): Adjust.
	(dw_expand_symtabs_matching_file_matcher): Adjust.
	(dw2_map_symbol_filenames): Adjust.
	(dw2_debug_names_iterator::next): Adjust.
	(dwarf2_initialize_objfile): Adjust.
	(set_partial_user): Adjust.
	(dwarf2_build_psymtabs_hard): Adjust.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PowerPC indirect calls to __tls_get_addr
@ 2018-04-09  8:35 sergiodj+buildbot
  2018-04-09  9:44 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-09  8:35 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 37da22e5c85375b30e1211ecff1b261f425375f0 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 37da22e5c85375b30e1211ecff1b261f425375f0

PowerPC indirect calls to __tls_get_addr

It is possible to construct indirect calls to __tls_get_addr in
assembly that confuse TLS optimization.  (PowerPC gcc doesn't support
such calls, ignoring -mlongcall for __tls_get_addr.)  This patch fixes
the problem by requiring a TLSLD or TLSGD marker reloc before any insn
in an indirect call to __tls_get_addr will be optimized.  They also
need additional marker relocs defined in a later patch, so don't
expect the optimization to work just yet.  The point here is to
prevent mis-optimization of indirect calls without any marker relocs.

The presense of a marker reloc is tracked by a new bit in the tls_mask
field of ppc_link_hash_entry and the corresponding lgot_masks unsigned
char array for local symbols.  Since the field is only 8 bits, we've
run out of space.  However, tracking TLS use for variables, and
tracking IFUNC for functions are independent, and bits can be reused.
TLS_TLS is always set for TLS usage, so can be used to select the
meaning of the other bits.  This patch does that even for elf32-ppc.c
which hasn't yet run out of space in the field.

	* elf64-ppc.c (TLS_TLS, TLS_GD, TLS_LD, TLS_TPREL, TLS_DTPREL,
	TLS_TPRELGD, TLS_EXPLICIT):  Renumber.  Test TLS_TLS throughout
	file when other TLS flags are tested in a mask.
	(TLS_MARK, NON_GOT): Define.
	(PLT_IFUNC): Redefine, and test TLS_TLS throughout file as well.
	(update_local_sym_info): Don't create got entry when NON_GOT.
	(ppc64_elf_check_relocs): Pass NON_GOT with PLT_IFUNC.
	Set TLS_MARK.
	(get_tls_mask): Do toc lookup if tls_mask is just TLS_MARK.
	(ppc64_elf_relocate_section): Likewise.
	(ppc64_elf_tls_optimize): Don't attempt to optimize indirect
	__tls_get_addr calls lacking a marker reloc.
	* elf32-ppc.c (TLS_TLS, TLS_GD, TLS_LD, TLS_TPREL, TLS_DTPREL,
	TLS_TPRELGD): Renumber.  Update comment.
	(TLS_MARK, NON_GOT): Define.
	(PLT_IFUNC): Redefine, and test TLS_TLS throughout file as well.
	(update_local_sym_info): Don't create got entry when NON_GOT.
	(ppc_elf_check_relocs): Pass NON_GOT with PLT_IFUNC.
	Set TLS_MARK.
	(ppc_elf_tls_optimize): Don't attempt to optimize indirect
	__tls_get_addr calls lacking a marker reloc.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PowerPC PLT16 relocations
@ 2018-04-09  8:49 sergiodj+buildbot
  2018-04-09 12:04 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-09  8:49 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 08be322439408ac02cff2ac9b5eca4f7243a0277 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 08be322439408ac02cff2ac9b5eca4f7243a0277

PowerPC PLT16 relocations

The PowerPC64 ELFv2 ABI and the PowerPC SysV ABI support a number of
relocations that can be used to create and access a PLT entry.
However, the relocs are not well defined.  The PLT16 family of relocs
talk about "the section offset or address of the procedure linkage
table entry".  It's plain that we do need a relative address when PIC
as otherwise we'd have dynamic text relocations, but "section offset"
doesn't specify which section.  The most obvious one, ".plt", isn't
that useful because there is no readily available way of addressing
the start of the ".plt" section.  Much more useful would be "the
GOT/TOC-pointer relative offset of the procedure linkage table entry",
and I suppose you could argue that is a "section offset" of sorts.
For PowerPC64 it is better to use the same TOC-pointer relative
addressing even when non-PIC, since ".plt" may be located outside the
range of a 32-bit address.  However, for ppc32 we do want an absolute
address when non-PIC as a GOT pointer may not be set up.  Also, for
ppc32 PIC we have a similar situation to R_PPC_PLTREL24 in that the
GOT pointer is set to a location in the .got2 section and we need to
specify the .got2 offset in the PLT16 reloc addend.

This patch supports PLT16 relocations using these semantics.  This is
not an ABI change for ppc32 since the relocations were not previously
supported by GNU ld, but is for ppc64 where some of the PLT16 relocs
were supported.  I'm not particularly concerned since the old ppc64
PLT16 reloc semantics made them almost completely useless.

bfd/
	* elf32-ppc.c (ppc_elf_check_relocs): Handle PLT16 relocs.
	(ppc_elf_relocate_section): Likewise.
	* elf64-ppc.c (ppc64_elf_check_relocs): Handle PLT16_LO_DS.
	(ppc64_elf_relocate_section): Likewise.  Correct PLT16
	resolution to plt entry relative to toc pointer.
gold/
	* powerpc.cc (Target_powerpc::plt_off): New functions.
	(is_plt16_reloc): New function.
	(Stub_table::plt_off): Use Target_powerpc::plt_off.
	(Stub_table::plt_call_size): Use plt_off.
	(Stub_table::do_write): Likewise.
	(Target_powerpc::Scan::get_reference_flags): Return RELATIVE_REF
	for PLT16 relocations.
	(Target_powerpc::Scan::reloc_needs_plt_for_ifunc): Return true
	for PLT16 relocations.
	(Target_powerpc::Scan::global): Make a PLT entry for PLT16 relocations.
	(Target_powerpc::Relocate::relocate): Support PLT16 relocations.
	(Powerpc_scan_relocatable_reloc::global_strategy): Return RELOC_SPECIAL
	for ppc32 plt16 relocs.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Rearrange PLT reloc output on powerpc
@ 2018-04-09  9:03 sergiodj+buildbot
  2018-04-09 13:28 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-09  9:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 49c09209d06885dc8350042ce77e442bfbb5bf27 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 49c09209d06885dc8350042ce77e442bfbb5bf27

Rearrange PLT reloc output on powerpc

The current scheme where we output PLT relocs for global symbols in
finish_dynamic_symbol, and PLT relocs for local symbols when
outputting stubs does not work if PLT entries are to be used for
inline PLT sequences against non-dynamic globals or local symbols.

bfd/
	* elf64-ppc.c (ppc_build_one_stub): Move output of PLT relocs
	for local symbols to..
	(write_plt_relocs_for_local_syms): ..here.  New function.
	(ppc64_elf_finish_dynamic_symbol): Move output of PLT relocs for
	global symbols to..
	(build_global_entry_stubs_and_plt): ..here.  Rename from
	build_global_entry_stubs.
	(ppc64_elf_build_stubs): Always call build_global_entry_stubs_and_plt.
	Call write_plt_relocs_for_local_syms.
	* elf32-ppc.c (get_sym_h): New function.
	(ppc_elf_relax_section): Use get_sym_h.
	(ppc_elf_relocate_section): Move output of PLT relocs and glink
	stubs for local symbols to..
	(ppc_finish_symbols): ..here.  New function.
	(ppc_elf_finish_dynamic_symbol): Move output of PLT relocs for
	global syms to..
	(write_global_sym_plt): ..here.  New function.
	* elf32-ppc.h (ppc_elf_modify_segment_map): Delete attribute.
	(ppc_finish_symbols): Declare.
ld/
	* ppc32elf.em (ppc_finish): Call ppc_finish_symbols.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Support PLT16 relocs against local symbols
@ 2018-04-09  9:17 sergiodj+buildbot
  2018-04-09 15:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-09  9:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2d7ad24e8726ba4c45c9e67be08223a146a837ce ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 2d7ad24e8726ba4c45c9e67be08223a146a837ce

Support PLT16 relocs against local symbols

Necessary if gcc is to use PLT16 relocs to implement -mlongcall, and
there isn't a good technical reason why local symbols should be
excluded from PLT16 support.  Non-ifunc local symbol PLT entries go in
a separate section to other PLT entries.  In a fixed position
executable they won't need to be relocated, and in a PIE or shared
library I chose to not implement lazy relocation.

bfd/
	* elf64-ppc.c (LOCAL_PLT_ENTRY_SIZE): Define.
	(struct ppc_stub_hash_entry): Add symtype field.
	(PLT_KEEP): Define.
	(struct ppc_link_hash_table): Add pltlocal and relpltlocal.
	(create_linkage_sections): Create pltlocal and relpltlocal.
	(ppc64_elf_check_relocs): Allow PLT relocs on local symbols.
	Set PLT_KEEP.
	(ppc64_elf_adjust_dynamic_symbol): Keep PLT entries for inline calls.
	(allocate_dynrelocs): Allocate pltlocal and relpltlocal.
	(ppc64_elf_size_dynamic_sections): Size pltlocal and relpltlocal.
	Keep PLT entries for inline calls against locals.
	(ppc_build_one_stub): Use pltlocal as appropriate.
	(ppc_size_one_stub): Likewise.
	(ppc64_elf_size_stubs): Set symtype.
	(build_global_entry_stubs_and_plt): Init pltlocal and write
	relpltlocal for globals.
	(write_plt_relocs_for_local_syms): Likewise for local syms.
	(ppc64_elf_relocate_section): Support PLT for local syms.
	* elf32-ppc.c (PLT_KEEP): Define.
	(struct ppc_elf_link_hash_table): Add pltlocal and relpltlocal.
	(ppc_elf_create_glink): Create pltlocal and relpltlocal.
	(ppc_elf_check_relocs): Allow PLT relocs on local symbols.
	Set PLT_KEEP.  Adjust update_local_sym_info call.
	(ppc_elf_adjust_dynamic_symbol): Keep PLT entries for inline calls.
	(allocate_dynrelocs): Allocate pltlocal and relpltlocal.
	(ppc_elf_size_dynamic_sections): Size pltlocal and relpltlocal.
	(ppc_elf_relocate_section): Support PLT16 relocs for local syms.
	(write_global_sym_plt): Init pltlocal and write relpltlocal.
	(ppc_finish_symbols): Likewise for locals.
ld/
	* emulparams/elf32ppc.sh (OTHER_RELRO_SECTIONS_2): Add .branch_lt.
	(OTHER_GOT_RELOC_SECTIONS): Add .rela.branch_lt.
	* testsuite/ld-powerpc/elfv2so.d: Update for symbol/stub reordering.
	* testsuite/ld-powerpc/relbrlt.d: Likewise.
	* testsuite/ld-powerpc/relbrlt.s: Likewise.
	* testsuite/ld-powerpc/tlsso.r: Likewise.
	* testsuite/ld-powerpc/tlstocso.r: Likewise.
gold/
	* powerpc.cc (Target_powerpc::lplt_): New variable.
	(Target_powerpc::lplt_section): Associated accessor.
	(Target_powerpc::plt_off): Handle local non-ifunc symbols.
	(Target_powerpc::make_lplt_section): New function.
	(Target_powerpc::make_local_plt_entry): New function.
	(Powerpc_relobj::do_relocate_sections): Write out lplt.
	(Output_data_plt_powerpc::first_plt_entry_offset): Zero for lplt.
	(Output_data_plt_powerpc::add_local_entry): New function.
	(Output_data_plt_powerpc::do_write): Ignore lplt.
	(Target_powerpc::make_iplt_section): Make lplt first.
	(Target_powerpc::make_brlt_section): Make .branch_lt relro.
	(Target_powerpc::Scan::local): Handle PLT16 relocs.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Inline PLT call optimization
@ 2018-04-09  9:47 sergiodj+buildbot
  2018-04-09 20:06 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-09  9:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3e04d7655bf63f4e5a0d0354c21aa3fa2ece3681 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 3e04d7655bf63f4e5a0d0354c21aa3fa2ece3681

Inline PLT call optimization

This patch adds the analysis part of PLT call optimization, enabling
the code added with the previous patch that actually performs the
optimization.

Gold support is not available yet.

bfd/
	* elf64-ppc.c (struct _ppc64_elf_section_data): Add has_pltcall field.
	(struct ppc_link_hash_table): Add can_convert_all_inline_plt.
	(ppc64_elf_check_relocs): Set has_pltcall.
	(ppc64_elf_adjust_dynamic_symbol): Discard some PLT entries.
	(ppc64_elf_inline_plt): New function.
	(ppc64_elf_size_dynamic_sections): Discard some PLT entries for locals.
	* elf64-ppc.h (ppc64_elf_inline_plt): Declare.
	* elf32-ppc.c (has_pltcall): Define.
	(struct ppc_elf_link_hash_table): Add can_convert_all_inline_plt.
	(ppc_elf_check_relocs): Set has_pltcall.
	(ppc_elf_inline_plt): New function.
	(ppc_elf_adjust_dynamic_symbol): Discard some PLT entries.
	(ppc_elf_size_dynamic_sections): Likewise.
	* elf32-ppc.h (ppc_elf_inline_plt): Declare.
ld/
	* emultempl/ppc64elf.em (no_inline_plt): New var.
	(ppc_before_allocation): Call ppc64_elf_inline_plt.
	(enum ppc64_opt): Add OPTION_NO_INLINE_OPT.
	(PARSE_AND_LIST_LONGOPTS, PARSE_AND_LIST_OPTIONS,
	PARSE_AND_LIST_ARGS_CASES): Handle --no-inline-optimize.
	* emultemps/ppc32elf.em (no_inline_opt): New var.
	(prelim_size_sections): New function, extracted from..
	(ppc_before_allocation): ..here.  Call ppc_elf_inline_plt.
	(enum ppc32_opt): Add OPTION_NO_INLINE_OPT.
	(PARSE_AND_LIST_LONGOPTS, PARSE_AND_LIST_OPTIONS,
	PARSE_AND_LIST_ARGS_CASES): Handle --no-inline-optimize.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PowerPC inline PLT call support
@ 2018-04-09 11:16 sergiodj+buildbot
  2018-04-09 18:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-09 11:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 23cedd1dc90d05c4b80d4a4b000ed5f37b9c3268 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 23cedd1dc90d05c4b80d4a4b000ed5f37b9c3268

PowerPC inline PLT call support

In addition to the existing relocs we need two more to mark all
instructions in the call sequence, PLTCALL on the call itself (plus
the toc restore insn for ppc64), and PLTSEQ on others.  All
relocations in a particular sequence have the same symbol.

Example ppc64 ELFv2 assembly:
 .reloc .,R_PPC64_PLTSEQ,puts
	std 2,24(1)
	addis 12,2,puts@plt@ha	# .reloc .,R_PPC64_PLT16_HA,puts
	ld 12,puts@plt@l(12)	# .reloc .,R_PPC64_PLT16_LO_DS,puts
 .reloc .,R_PPC64_PLTSEQ,puts
	mtctr 12
 .reloc .,R_PPC64_PLTCALL,puts
	bctrl
	ld 2,24(1)

Example ppc32 -fPIC assembly:
	addis 12,30,puts+32768@plt@ha # .reloc .,R_PPC_PLT16_HA,puts+0x8000
	lwz 12,12,puts+32768@plt@l    # .reloc .,R_PPC_PLT16_LO,puts+0x8000
 .reloc .,R_PPC_PLTSEQ,puts+32768
	mtctr 12
 .reloc .,R_PPC_PLTCALL,puts+32768
	bctrl

Marking sequences like this allows the linker to convert them to nops
and a direct call if the target symbol turns out to be local.

When the call is __tls_get_addr, each relocation shown above is paired
with an R_PPC*_TLSLD or R_PPC*_TLSGD reloc to additionally mark the
sequence for possible TLS optimization.  The TLSLD or TLSGD relocs are
emitted first.

include/
	* elf/ppc.h (R_PPC_PLTSEQ, R_PPC_PLTCALL): Define.
	* elf/ppc64.h (R_PPC64_PLTSEQ, R_PPC64_PLTCALL): Define.
bfd/
	* elf32-ppc.c (ppc_elf_howto_raw): Add PLTSEQ and PLTCALL howtos.
	(is_plt_seq_reloc): New function.
	(ppc_elf_check_relocs): Handle PLTSEQ and PLTCALL relocs.
	(ppc_elf_tls_optimize): Handle inline plt call sequence.
	(ppc_elf_relax_section): Handle PLTCALL reloc.
	(ppc_elf_relocate_section): Nop out inline plt call sequence when
	resolving locally.
	* elf64-ppc.c (ppc64_elf_howto_raw): Add R_PPC64_PLTSEQ and
	R_PPC64_PLTCALL entries.  Comment R_PPC64_TOCSAVE.
	(has_tls_get_addr_call): Correct comment.
	(is_branch_reloc): Add PLTCALL.
	(is_plt_seq_reloc): New function.
	(ppc64_elf_check_relocs): Handle PLT16_LO_DS reloc.  Set
	has_tls_reloc for R_PPC64_TLSGD and R_PPC64_TLSLD.  Create plt
	entry for R_PPC64_PLTCALL.
	(ppc64_elf_tls_optimize): Handle inline plt call sequence.
	(ppc_type_of_stub): Handle PLTCALL reloc.
	(toc_adjusting_stub_needed): Likewise.
	(ppc64_elf_relocate_section): Set "can_plt_call" for PLTCALL
	reloc insn.  Nop out inline plt call sequence when resolving
	locally.  Handle __tls_get_addr inline plt call optimization.
elfcpp/
	* powerpc.h (R_POWERPC_PLTSEQ, R_POWERPC_PLTCALL): Define.
gold/
	* powerpc.cc (Target_powerpc::Track_tls::maybe_skip_tls_get_addr_call):
	Handle inline plt sequence relocs.
	(Stub_table::Plt_stub_key::Plt_stub_key): Likewise.
	(Target_powerpc::Scan::reloc_needs_plt_for_ifunc): Likewise.
	(Target_powerpc::Relocate::relocate): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] MIPS64/BFD: Fix a crash with invalid `r_sym' in relocation
@ 2018-04-09 13:04 sergiodj+buildbot
  2018-04-09 21:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-09 13:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9ccfa98b4cbc86ac34734ecf9d35466461c7e34c ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 9ccfa98b4cbc86ac34734ecf9d35466461c7e34c

MIPS64/BFD: Fix a crash with invalid `r_sym' in relocation

Prevent an out-of-range access and a possible segmentation fault in
`mips_elf64_slurp_one_reloc_table':

Program received signal SIGSEGV, Segmentation fault.
mips_elf64_slurp_one_reloc_table (abfd=0x71bd90, asect=0x71cf70,
    rel_hdr=<value optimized out>, reloc_count=1,
    relents=<value optimized out>, symbols=0x7218c0, dynamic=0)
    at .../bfd/elf64-mips.c:3758
3757			      ps = symbols + rela.r_sym - 1;
3758			      s = *ps;

in the MIPS64 (n64 MIPS) ELF backend whenever an invalid symbol index is
retrieved from the `r_sym' field of a relocation seen in input while
running `objcopy' or `strip'.  Issue an error instead, like the generic
ELF backend does, taking code from `elf_slurp_reloc_table_from_section',
except for relocation types that do not refer to a symbol.

This complements commit 1f70368c21a8 ("Stop objdump crash on corrupt
reloc table"), <https://sourceware.org/ml/binutils/2002-09/msg00332.html>,
and commit 05a487dc8c39 ("make check fails on i686-linux-gnu"),
<https://sourceware.org/ml/binutils/2002-09/msg00340.html>, where the
generic ELF backend code comes from.

	bfd/
	* elf64-mips.c (mips_elf64_slurp_one_reloc_table): Issue an
	error for out-of-range `r_sym' values.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] MIPS64/BFD: Fix a crash with STN_UNDEF in relocation
@ 2018-04-09 13:12 sergiodj+buildbot
  2018-04-09 22:53 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-09 13:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT aec2e0d252342aa7575aff608e999a36f27a9147 ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: aec2e0d252342aa7575aff608e999a36f27a9147

MIPS64/BFD: Fix a crash with STN_UNDEF in relocation

Prevent a null BFD pointer dereference and a resulting segmentation
fault in `mips_elf64_write_rel' or `mips_elf64_write_rela':

Program received signal SIGSEGV, Segmentation fault.
0x0000000000437690 in mips_elf64_write_rela (abfd=0x71e130, sec=0x720700,
    rela_hdr=0x721ff8, count=0x7fffffffb82c, data=0x7fffffffb88c)
    at .../bfd/elf64-mips.c:4123
4123	      if ((*ptr->sym_ptr_ptr)->the_bfd->xvec != abfd->xvec
4124		  && ! _bfd_elf_validate_reloc (abfd, ptr))

in the MIPS64 (n64 MIPS) ELF backend whenever the STN_UNDEF symbol index
is retrieved from the `r_sym' field of a relocation seen in input while
running `objcopy' or `strip'.  The reason for the null BFD pointer is
that internally in BFD an STN_UNDEF symbol reference resolves to an
absolute zero symbol that does not have a BFD associated.  Check the
pointer then before using it, like the generic ELF backend does in
`elf_write_relocs'.

This complements the same change made for generic ELF bundled with:

commit e35765a9a2eaff0df62757f3e6480c8ba5ab8ee8
Author: Ian Lance Taylor <ian@airs.com>
Date:   Sun Dec 15 19:59:18 1996 +0000

which (obviously due to a CVS -> GIT repository conversion inaccuracy)
seems to be one corresponding to this ChangeLog entry:

	* elfcode.h (write_relocs): Handle absolute symbol.

from:

commit c86158e591edd8450f49f8cd75f82e4313d4b6d8
Author: Ian Lance Taylor <ian@airs.com>
Date:   Fri Aug 30 22:09:51 1996 +0000

("Add SH ELF support."), which also updated RELA only and not REL (which
has been since fixed with: commit 947216bf8f34 ("ELF reloc code tidy"),
<https://sourceware.org/ml/binutils/2002-11/msg00727.html>).

	bfd/
	* elf64-mips.c (mips_elf64_write_rel): Handle a NULL BFD pointer
	in the BFD symbol referred by the relocation.
	(mips_elf64_write_rela): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Apply "Convert observers to C++" edit to gdbarch.sh
@ 2018-04-09 15:13 sergiodj+buildbot
  2018-04-10  0:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-09 15:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0bee6dd4aa42b928c2a7a496596490b694e5722b ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 0bee6dd4aa42b928c2a7a496596490b694e5722b

Apply "Convert observers to C++" edit to gdbarch.sh

Regenerating gdbarch.c results in:

  --- gdbarch.c   2018-03-26 23:18:52.905548891 +0100
  +++ new-gdbarch.c       2018-04-09 15:32:30.006712207 +0100
  @@ -44,7 +44,7 @@
   #include "reggroups.h"
   #include "osabi.h"
   #include "gdb_obstack.h"
  -#include "observable.h"
  +#include "observer.h"
   #include "regcache.h"
   #include "objfiles.h"
   #include "auxv.h"
  @@ -5457,7 +5457,7 @@
     gdb_assert (new_gdbarch != NULL);
     gdb_assert (new_gdbarch->initialized_p);
     current_inferior ()->gdbarch = new_gdbarch;
  -  gdb::observers::architecture_changed.notify (new_gdbarch);
  +  observer_notify_architecture_changed (new_gdbarch);
     registers_changed ();
   }


Clearly commit 76727919ceb5 ("Convert observers to C++") edited
gdbarch.c directly instead of gdbarch.sh.  This fixes it.

gdb/ChangeLog:
2018-04-09  Pedro Alves  <palves@redhat.com>

	* gdbarch.sh: Include "observable.h" instead of "observer.h".
	(set_target_gdbarch): Call
	gdb::observers::architecture_changed.notify instead of
	observer_notify_architecture_changed.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Update ax_cv_cxx_compile_cxx.m4
@ 2018-04-09 18:41 sergiodj+buildbot
  2018-04-10  1:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-09 18:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 41260ac25d541d9bdd039a0ce82c9ad31fceed35 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 41260ac25d541d9bdd039a0ce82c9ad31fceed35

Update ax_cv_cxx_compile_cxx.m4

This file provides the AX_CXX_COMPILE_STDCXX macro.  In the context of
the following patch, I wanted to build and test GDB in c++17 mode.  The
version of the macro we have in the repo does not support detecting
c++17 compilers, but the upstream version has been updated to do so.

Since we have local modifications to the file, I had to reconcile our
modifications and the updated upstream version (which was relatively
straightforward).

gdb/ChangeLog:

	* ax_cxx_compile_stdcxx.m4: Sync with upstream.
	* configure: Re-generate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Copy string_view files from libstdc++
@ 2018-04-09 18:55 sergiodj+buildbot
  2018-04-10  3:11 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-09 18:55 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7adcdf08e792dc30e09af4eecbf1e479a2f56612 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 7adcdf08e792dc30e09af4eecbf1e479a2f56612

Copy string_view files from libstdc++

This patch copies the following files from libstdc++ (commit
02a4441f002c):

  ${gcc}/libstdc++-v3/include/experimental/string_view
    -> ${binutils-gdb}/gdb/common/gdb_string_view.h

  ${gcc}/libstdc++-v3/include/experimental/bits/string_view.tcc
    -> ${binutils-gdb}/gdb/common/gdb_string_view.tcc

The local modifications are done in the following patch in order to make
it easier to review them.

gdb/ChangeLog:

	* common/gdb_string_view.h: New file.
	* common/gdb_string_view.tcc: New file.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add gdb::string_view
@ 2018-04-09 19:11 sergiodj+buildbot
  2018-04-10  4:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-09 19:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8345c4a2670711eafd41c8b6a8726cf8b0771d6e ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 8345c4a2670711eafd41c8b6a8726cf8b0771d6e

Add gdb::string_view

We had a few times the need for a data structure that does essentially
what C++17's std::string_view does, which is to give an std::string-like
interface (only the read-only operations) to an arbitrary character
buffer.

This patch adapts the files copied from libstdc++ by the previous patch
to integrate them with GDB.  Here's a summary of the changes:

  * Remove things related to wstring_view, u16string_view and
  u32string_view (I don't think we need them, but we can always add them
  later).

  * Remove usages of _GLIBCXX_BEGIN_NAMESPACE_VERSION and
  _GLIBCXX_END_NAMESPACE_VERSION.

  * Put the code in the gdb namespace.  I had to add a few "std::" in
  front of std type usages.

  * Change __throw_out_of_range_fmt() for error().

  * Make gdb::string_view an alias of std::string_view when building
  with >= c++17.

  * Remove a bunch of constexpr, because they are not valid in c++11
  (e.g. they are not a single return line).

  * Use std::common_type<_Tp>::type instead of std::common_type_t<_Tp>,
  because c++11 doesn't have the later.

  * Remove the #pragma GCC system_header, since that silences some
  warnings that we might want to have if we're doing something not
  correctly.

  * Remove operator ""sv.  It would need a lot of work to make all
  supported compilers happy, and we can easily live without it.

  * Remove operator<<.  It is implemented using __ostream_insert (a
  libstdc++ internal).  Bringing it in might be possible, but I don't
  think that would be worth the effort, since we don't really use
  streams at the moment.

  * Replace internal libstdc++ asserts ( __glibcxx_assert and
  __glibcxx_requires_string_len) with gdb_assert.

  * Remove hash helpers, because they use libstdc++ internal functions.
  If we need them we always import them later.

The string_view class in cli/cli-script.c is removed and its usage
replaced with the new gdb::string_view.

gdb/ChangeLog:

	* common/gdb_string_view.h: Remove libstdc++ implementation
	details, adjust to gdb reality.
	* common/gdb_string_view.tcc: Likewise.
	* cli/cli-script.c (struct string_view): Remove.
	(user_args) <m_args>: Change element type to gdb::string_view.
	(user_args::insert_args): Adjust.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Copy string_view tests from libstdc++
@ 2018-04-09 19:25 sergiodj+buildbot
  2018-04-10  5:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-09 19:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fdc116781b03f5d30e93f5013159f39c4c0f3471 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: fdc116781b03f5d30e93f5013159f39c4c0f3471

Copy string_view tests from libstdc++

This patch copies the string_view tests from the gcc repository (commit
02a4441f002c).

  ${gcc}/libstdc++-v3/testsuite/21_strings/basic_string_view ->
    ${binutils-gdb}/gdb/unittests/basic_string_view

The local modifications are done in the following patch, so that it's
easier to review them.

gdb/ChangeLog:

	* unittests/basic_string_view/capacity/1.cc: New file.
	* unittests/basic_string_view/capacity/empty_neg.cc: New file.
	* unittests/basic_string_view/cons/char/1.cc: New file.
	* unittests/basic_string_view/cons/char/2.cc: New file.
	* unittests/basic_string_view/cons/char/3.cc: New file.
	* unittests/basic_string_view/cons/wchar_t/1.cc: New file.
	* unittests/basic_string_view/cons/wchar_t/2.cc: New file.
	* unittests/basic_string_view/cons/wchar_t/3.cc: New file.
	* unittests/basic_string_view/element_access/char/1.cc: New file.
	* unittests/basic_string_view/element_access/char/2.cc: New file.
	* unittests/basic_string_view/element_access/char/empty.cc: New file.
	* unittests/basic_string_view/element_access/char/front_back.cc: New file.
	* unittests/basic_string_view/element_access/wchar_t/1.cc: New file.
	* unittests/basic_string_view/element_access/wchar_t/2.cc: New file.
	* unittests/basic_string_view/element_access/wchar_t/empty.cc: New file.
	* unittests/basic_string_view/element_access/wchar_t/front_back.cc: New file.
	* unittests/basic_string_view/include.cc: New file.
	* unittests/basic_string_view/inserters/char/1.cc: New file.
	* unittests/basic_string_view/inserters/char/2.cc: New file.
	* unittests/basic_string_view/inserters/char/3.cc: New file.
	* unittests/basic_string_view/inserters/pod/10081-out.cc: New file.
	* unittests/basic_string_view/inserters/wchar_t/1.cc: New file.
	* unittests/basic_string_view/inserters/wchar_t/2.cc: New file.
	* unittests/basic_string_view/inserters/wchar_t/3.cc: New file.
	* unittests/basic_string_view/literals/types.cc: New file.
	* unittests/basic_string_view/literals/values.cc: New file.
	* unittests/basic_string_view/modifiers/remove_prefix/char/1.cc: New file.
	* unittests/basic_string_view/modifiers/remove_prefix/wchar_t/1.cc: New file.
	* unittests/basic_string_view/modifiers/remove_suffix/char/1.cc: New file.
	* unittests/basic_string_view/modifiers/remove_suffix/wchar_t/1.cc: New file.
	* unittests/basic_string_view/modifiers/swap/char/1.cc: New file.
	* unittests/basic_string_view/modifiers/swap/wchar_t/1.cc: New file.
	* unittests/basic_string_view/operations/compare/char/1.cc: New file.
	* unittests/basic_string_view/operations/compare/char/13650.cc: New file.
	* unittests/basic_string_view/operations/compare/char/2.cc: New file.
	* unittests/basic_string_view/operations/compare/char/70483.cc: New file.
	* unittests/basic_string_view/operations/compare/wchar_t/1.cc: New file.
	* unittests/basic_string_view/operations/compare/wchar_t/13650.cc: New file.
	* unittests/basic_string_view/operations/compare/wchar_t/2.cc: New file.
	* unittests/basic_string_view/operations/copy/char/1.cc: New file.
	* unittests/basic_string_view/operations/copy/wchar_t/1.cc: New file.
	* unittests/basic_string_view/operations/data/char/1.cc: New file.
	* unittests/basic_string_view/operations/data/wchar_t/1.cc: New file.
	* unittests/basic_string_view/operations/find/char/1.cc: New file.
	* unittests/basic_string_view/operations/find/char/2.cc: New file.
	* unittests/basic_string_view/operations/find/char/3.cc: New file.
	* unittests/basic_string_view/operations/find/char/4.cc: New file.
	* unittests/basic_string_view/operations/find/wchar_t/1.cc: New file.
	* unittests/basic_string_view/operations/find/wchar_t/2.cc: New file.
	* unittests/basic_string_view/operations/find/wchar_t/3.cc: New file.
	* unittests/basic_string_view/operations/find/wchar_t/4.cc: New file.
	* unittests/basic_string_view/operations/rfind/char/1.cc: New file.
	* unittests/basic_string_view/operations/rfind/char/2.cc: New file.
	* unittests/basic_string_view/operations/rfind/char/3.cc: New file.
	* unittests/basic_string_view/operations/rfind/wchar_t/1.cc: New file.
	* unittests/basic_string_view/operations/rfind/wchar_t/2.cc: New file.
	* unittests/basic_string_view/operations/rfind/wchar_t/3.cc: New file.
	* unittests/basic_string_view/operations/string_conversion/1.cc: New file.
	* unittests/basic_string_view/operations/substr/char/1.cc: New file.
	* unittests/basic_string_view/operations/substr/wchar_t/1.cc: New file.
	* unittests/basic_string_view/operators/char/2.cc: New file.
	* unittests/basic_string_view/operators/wchar_t/2.cc: New file.
	* unittests/basic_string_view/range_access/char/1.cc: New file.
	* unittests/basic_string_view/range_access/wchar_t/1.cc: New file.
	* unittests/basic_string_view/requirements/explicit_instantiation/1.cc: New file.
	* unittests/basic_string_view/requirements/explicit_instantiation/char/1.cc: New file.
	* unittests/basic_string_view/requirements/explicit_instantiation/char16_t/1.cc: New file.
	* unittests/basic_string_view/requirements/explicit_instantiation/char32_t/1.cc: New file.
	* unittests/basic_string_view/requirements/explicit_instantiation/wchar_t/1.cc: New file.
	* unittests/basic_string_view/requirements/typedefs.cc: New file.
	* unittests/basic_string_view/typedefs.cc: New file.
	* unittests/basic_string_view/types/1.cc: New file.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove VEC(tsv_s), use std::vector instead
@ 2018-04-09 19:54 sergiodj+buildbot
  2018-04-10  8:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-09 19:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c252925ccc8c3c2ce2a65d12a50acfee53914ce3 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: c252925ccc8c3c2ce2a65d12a50acfee53914ce3

Remove VEC(tsv_s), use std::vector instead

This patch removes VEC(tsv_s), using an std::vector instead.  I C++ified
trace_state_variable a bit in the process, using std::string for the
name.  I also thought it would be nicer to pass a const reference to
target_download_trace_state_variable, since we know it will never be
NULL.  This highlighted that the make-target-delegates script didn't
handle references well, so I adjusted this as well.  It will surely be
useful in the future.

gdb/ChangeLog:

	* tracepoint.h (struct trace_state_variable): Add constructor.
	<name>: Change type to std::string.
	* tracepoint.c (tsv_s): Remove.
	(DEF_VEC_O(tsv_s)): Remove.
	(tvariables): Change to std::vector.
	(create_trace_state_variable): Adjust to std::vector.
	(find_trace_state_variable): Likewise.
	(find_trace_state_variable_by_number): Likewise.
	(delete_trace_state_variable): Likewise.
	(trace_variable_command): Adjust to std::string.
	(delete_trace_variable_command): Likewise.
	(tvariables_info_1): Adjust to std::vector.
	(save_trace_state_variables): Likewise.
	(start_tracing): Likewise.
	(merge_uploaded_trace_state_variables): Adjust to std::vector
	and std::string.
	* target.h (struct target_ops)
	<to_download_trace_state_variable>: Pass reference to
	trace_state_variable.
	* target-debug.h (target_debug_print_const_trace_state_variable_r): New.
	* target-delegates.c: Re-generate.
	* mi/mi-interp.c (mi_tsv_created): Adjust to std::string.
	(mi_tsv_deleted): Likewise.
	* mi/mi-main.c (mi_cmd_trace_frame_collected): Likewise.
	* remote.c (remote_download_trace_state_variable): Change
	pointer to reference and adjust.
	* make-target-delegates (parse_argtypes): Handle references.
	(write_function_header): Likewise.
	(munge_type): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use an std::vector for inline_states
@ 2018-04-09 20:08 sergiodj+buildbot
  2018-04-10 10:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-09 20:08 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b24531ed171b5751a3a64c461728c9ad62092c8a ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: b24531ed171b5751a3a64c461728c9ad62092c8a

Use an std::vector for inline_states

This patch replaces VEC(inline_state) with std::vector<inline_state> and
adjusts the code that uses it.

gdb/ChangeLog:

	* common/gdb_vecs.h (unordered_remove): Add overload that takes
	an iterator.
	* inline-frame.c: Include <algorithm>.
	(struct inline_state): Add constructor.
	(inline_state_s): Remove.
	(DEF_VEC_O(inline_state_s)): Remove.
	(inline_states): Change type to std::vector.
	(find_inline_frame_state): Adjust to std::vector.
	(allocate_inline_frame_state): Remove.
	(clear_inline_frame_state): Adjust to std::vector.
	(skip_inline_frames): Adjust to std::vector.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Adapt and integrate string_view tests
@ 2018-04-09 20:19 sergiodj+buildbot
  2018-04-10  7:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-09 20:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c9638d2669ced9348eac869dadc7be24df85a9a8 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: c9638d2669ced9348eac869dadc7be24df85a9a8

Adapt and integrate string_view tests

The previous patch copied the string_view tests from libstdc++.  This
patch adjusts them in a similar way that the libstdc++ optional tests
are integrated in our unit test suite.

Not all tests are used, some of them require language features not
present in c++11.  For example, we can't use a string_view constructor
where the length is not explicit in a constexpr, because
std::char_traits::length is not a constexpr itself (it is in c++17
though).  Nevertheless, a good number of tests are integrated, which
covers pretty well the string_view features.

gdb/ChangeLog:

	* Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
	string_view-selftests.c.
	* unittests/basic_string_view/capacity/1.cc: Adapt to GDB
	testsuite.
	* unittests/basic_string_view/cons/char/1.cc: Likewise.
	* unittests/basic_string_view/cons/char/2.cc: Likewise.
	* unittests/basic_string_view/cons/char/3.cc: Likewise.
	* unittests/basic_string_view/element_access/char/1.cc:
	Likewise.
	* unittests/basic_string_view/element_access/char/empty.cc:
	Likewise.
	* unittests/basic_string_view/element_access/char/front_back.cc:
	Likewise.
	* unittests/basic_string_view/inserters/char/2.cc: Likewise.
	* unittests/basic_string_view/modifiers/remove_prefix/char/1.cc:
	Likewise.
	* unittests/basic_string_view/modifiers/remove_suffix/char/1.cc:
	Likewise.
	* unittests/basic_string_view/modifiers/swap/char/1.cc:
	Likewise.
	* unittests/basic_string_view/operations/compare/char/1.cc:
	Likewise.
	* unittests/basic_string_view/operations/compare/char/13650.cc:
	Likewise.
	* unittests/basic_string_view/operations/copy/char/1.cc:
	Likewise.
	* unittests/basic_string_view/operations/data/char/1.cc:
	Likewise.
	* unittests/basic_string_view/operations/find/char/1.cc:
	Likewise.
	* unittests/basic_string_view/operations/find/char/2.cc:
	Likewise.
	* unittests/basic_string_view/operations/find/char/3.cc:
	Likewise.
	* unittests/basic_string_view/operations/find/char/4.cc:
	Likewise.
	* unittests/basic_string_view/operations/rfind/char/1.cc:
	Likewise.
	* unittests/basic_string_view/operations/rfind/char/2.cc:
	Likewise.
	* unittests/basic_string_view/operations/rfind/char/3.cc:
	Likewise.
	* unittests/basic_string_view/operations/substr/char/1.cc:
	Likewise.
	* unittests/basic_string_view/operators/char/2.cc: Likewise.
	* unittests/string_view-selftests.c: New file.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add selftests for range_contains and insert_into_bit_range_vector
@ 2018-04-09 20:22 sergiodj+buildbot
  2018-04-10 12:44 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-09 20:22 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d5f4488f09b811b0ca44e687da2acbc286d84d4a ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: d5f4488f09b811b0ca44e687da2acbc286d84d4a

Add selftests for range_contains and insert_into_bit_range_vector

Add some selftests for these two functions.  To to make it easier to
compare sequences of ranges, add operator== and operator!= to compare
two gdb::array_view, and add operator== in struct range.

gdb/ChangeLog:

	* value.c: Include "selftest.h" and "common/array-view.h".
	(struct range) <operator ==>: New.
	(test_ranges_contain): New.
	(check_ranges_vector): New.
	(test_insert_into_bit_range_vector): New.
	(_initialize_values): Register selftests.
	* common/array-view.h (operator==, operator!=): New.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Replace finish_thread_state_cleanup with a RAII class
@ 2018-04-10 14:11 sergiodj+buildbot
  2018-04-10 14:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-10 14:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 731f534f918cfaa35c20b5eb6220a8eba4819f04 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 731f534f918cfaa35c20b5eb6220a8eba4819f04

Replace finish_thread_state_cleanup with a RAII class

gdb/ChangeLog:
2018-04-10  Pedro Alves  <palves@redhat.com>

	* gdbthread.h (finish_thread_state_cleanup): Delete declaration.
	(scoped_finish_thread_state): New class.
	* infcmd.c (run_command_1): Use it instead of finish_thread_state
	cleanup.
	* infrun.c (proceed, prepare_for_detach, wait_for_inferior)
	(fetch_inferior_event, normal_stop): Likewise.
	* thread.c (finish_thread_state_cleanup): Delete.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix gdb.base/fork-running-state.exp race
@ 2018-04-10 14:44 sergiodj+buildbot
  2018-04-10 16:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-10 14:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f50d8a2eaea045cd6e9b8d6d5cf8da55e2047ffb ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: f50d8a2eaea045cd6e9b8d6d5cf8da55e2047ffb

Fix gdb.base/fork-running-state.exp race

On my multi-target branch I was occasionaly seeing a FAIL like this:

  (gdb) PASS: gdb.base/fork-running-state.exp: detach-on-fork=off: follow-fork=parent: non-stop: kill parent
  [Inferior 2 (process 32672) exited normally]
  kill inferior 2
  warning: Inferior ID 2 is not running.
  (gdb) FAIL: gdb.base/fork-running-state.exp: detach-on-fork=off: follow-fork=parent: non-stop: kill child (the program exited)
  ... other similar fails ...

Turns out to be a testcase bug/race.  A tweak like this increases the
changes of hitting the race substancially:

  --- a/gdb/testsuite/gdb.base/fork-running-state.c
  +++ b/gdb/testsuite/gdb.base/fork-running-state.c
  @@ -29,7 +29,7 @@ fork_child (void)
   {
     while (1)
       {
  -      sleep (1);
  +      usleep (100);


The testcase has two processes, parent and child fork.  The problem is
that the child exits itself if it notices the parent is gone, but the
testcase .exp does not expect that.

I first wrote a patch that handled the different combinations of
non-stop/detach-on-fork/follow-fork/schedule-multiple, making the .exp
file know when to expect the child to exit itself vs when to kill it
explicitly, but the result was that the code to kill the parent and
child was getting about as large as the test code that is the actual
point of the testcase, above the kills.

So I scratched that approach and came up with a simpler patch --
simply make the child not exit itself when the parent exits.

The .exp file is going to kill both parent and child explicitly, and,
main() already calls alarm() as a safeguard.  I don't think we lose
anything.

gdb/testsuite/ChangeLog:
2018-04-10  Pedro Alves  <palves@redhat.com>

	* gdb.base/fork-running-state.c (fork_child): Don't exit if parent
	exits.  Instead loop running forever.
	(fork_parent): Run forever too.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Iterate by index in auto_load_safe_path_vec_update
@ 2018-04-10 21:11 sergiodj+buildbot
  2018-04-10 21:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-10 21:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6e22e10d63addd60f39114cef81ade290b15b2c8 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 6e22e10d63addd60f39114cef81ade290b15b2c8

Iterate by index in auto_load_safe_path_vec_update

As reported by Jan, we get this error when building with -D_GLIBCXX_DEBUG:

/usr/include/c++/7/debug/safe_iterator.h:297:
Error: attempt to increment a singular iterator.
Objects involved in the operation:
    iterator "this" @ 0x0x7fffffffd140 {
      type = __gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<std::unique_ptr<char, gdb::xfree_deleter<char> >*, std::__cxx1998::vector<std::unique_ptr<char, gdb::xfree_deleter<char> >, std::allocator<std::unique_ptr<char, gdb::xfree_deleter<char> > > > >, std::__debug::vector<std::unique_ptr<char, gdb::xfree_deleter<char> >, std::allocator<std::unique_ptr<char, gdb::xfree_deleter<char> > > > > (mutable iterator);
      state = singular;
      references sequence with type 'std::__debug::vector<std::unique_ptr<char, gdb::xfree_deleter<char> >, std::allocator<std::unique_ptr<char, gdb::xfree_deleter<char> > > >' @ 0x0x265db40
    }

The bug was introduced by commit

commit e80aaf6183c6692ecc167bf26cbdc53f8f1a55f0
Author: Simon Marchi <simon.marchi@polymtl.ca>
Date:   Fri Mar 2 23:22:06 2018 -0500
Make delim_string_to_char_ptr_vec return an std::vector

The problem is that we iterate using a range-based for on a vector to
which we push in the loop.  Pushing to the vector invalidates the
iterator used in the loop.  Instead, change the code to iterate by index
as was done in the previous code.

gdb/ChangeLog:

	* auto-load.c (auto_load_safe_path_vec_update): Iterate by
	index.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] C++ify fileio_fh_t, replace VEC with std::vector
@ 2018-04-11 10:58 sergiodj+buildbot
  2018-04-11 11:30 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-11 10:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5ff79300aef4f4c991194541ec3ad9a2618ff24c ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 5ff79300aef4f4c991194541ec3ad9a2618ff24c

C++ify fileio_fh_t, replace VEC with std::vector

Preparation for the next patch.

- Replace VEC with std::vector.
- Rewrite a couple macros as methods/functions.
- While at it, rename fileio_fh_t::fd as fileio_fh_t::target_fd to
  avoid confusion between target and host file descriptors.

gdb/ChangeLog:
2018-04-11  Pedro Alves  <palves@redhat.com>

	* target.c (fileio_fh_t): Make it a named struct instead of a
	typedef.
	(fileio_fh_t::is_closed): New method.
	(DEF_VEC_O (fileio_fh_t)): Remove.
	(fileio_fhandles): Now a std::vector.
	(is_closed_fileio_fh): Delete.
	(acquire_fileio_fd): Adjust.  Rename parameters.
	(release_fileio_fd): Adjust.
	(fileio_fd_to_fh): Reimplement as a function instead of a macro.
	(target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
	(target_fileio_close): Adjust.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] File I/O file handles after target closes
@ 2018-04-11 11:23 sergiodj+buildbot
  2018-04-11 13:49 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-11 11:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 20db9c52a2073246a5c46a0274569e10b317866f ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 20db9c52a2073246a5c46a0274569e10b317866f

File I/O file handles after target closes

A future patch will propose making the remote target's target_ops be
heap-allocated (to make it possible to have multiple instances of
remote targets, for multiple simultaneous connections), and will
delete/destroy the remote target at target_close time.

That change trips on a latent problem, though.  File I/O handles
remain open even after the target is gone, with a dangling pointer to
a target that no longer exists.  This results in GDB crashing when it
calls the target_ops backend associated with the file handle:

 (gdb) Disconnect
 Ending remote debugging.
 * GDB crashes deferencing a dangling pointer

Backtrace:

   #0  0x00007f79338570a0 in main_arena () at /lib64/libc.so.6
   #1  0x0000000000858bfe in target_fileio_close(int, int*) (fd=1, target_errno=0x7ffe0499a4c8)
       at src/gdb/target.c:2980
   #2  0x00000000007088bd in gdb_bfd_iovec_fileio_close(bfd*, void*) (abfd=0x1a631b0, stream=0x223c9d0)
       at src/gdb/gdb_bfd.c:353
   #3  0x0000000000930906 in opncls_bclose (abfd=0x1a631b0) at src/bfd/opncls.c:528
   #4  0x0000000000930cf9 in bfd_close_all_done (abfd=0x1a631b0) at src/bfd/opncls.c:768
   #5  0x0000000000930cb3 in bfd_close (abfd=0x1a631b0) at src/bfd/opncls.c:735
   #6  0x0000000000708dc5 in gdb_bfd_close_or_warn(bfd*) (abfd=0x1a631b0) at src/gdb/gdb_bfd.c:511
   #7  0x00000000007091a2 in gdb_bfd_unref(bfd*) (abfd=0x1a631b0) at src/gdb/gdb_bfd.c:615
   #8  0x000000000079ed8e in objfile::~objfile() (this=0x2154730, __in_chrg=<optimized out>)
       at src/gdb/objfiles.c:682
   #9  0x000000000079fd1a in objfile_purge_solibs() () at src/gdb/objfiles.c:1065
   #10 0x00000000008162ca in no_shared_libraries(char const*, int) (ignored=0x0, from_tty=1)
       at src/gdb/solib.c:1251
   #11 0x000000000073b89b in disconnect_command(char const*, int) (args=0x0, from_tty=1)
       at src/gdb/infcmd.c:3035

This goes unnoticed in current master, because the current remote
target's target_ops is never destroyed nowadays, so we end up calling:

  remote_hostio_close -> remote_hostio_send_command

which gracefully fails with FILEIO_ENOSYS if remote_desc is NULL
(because the target is closed).

Fix this by invalidating a target's file I/O handles when the target
is closed.

With this change, remote_hostio_send_command no longer needs to handle the
case of being called with a closed remote target, originally added here:
<https://sourceware.org/ml/gdb-patches/2008-08/msg00359.html>.

gdb/ChangeLog:
2018-04-11  Pedro Alves  <palves@redhat.com>

	* target.c (fileio_fh_t::t): Add comment.
	(target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
	(target_fileio_close): Handle a NULL target.
	(invalidate_fileio_fh): New.
	(target_close): Call it.
	* remote.c (remote_hostio_send_command): No longer check whether
	remote_desc is open.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove i860, i960, bout and aout-adobe targets
@ 2018-04-11 12:52 sergiodj+buildbot
  2018-04-11 16:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-11 12:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a8eb42a8b7d48ff6bd12ac83b0e31967b4f5abf1 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: a8eb42a8b7d48ff6bd12ac83b0e31967b4f5abf1

Remove i860, i960, bout and aout-adobe targets

Plus remove a few leftovers from the 29k support.

include/
	* aout/adobe.h: Delete.
	* aout/reloc.h: Delete.
	* coff/i860.h: Delete.
	* coff/i960.h: Delete.
	* elf/i860.h: Delete.
	* elf/i960.h: Delete.
	* opcode/i860.h: Delete.
	* opcode/i960.h: Delete.
	* aout/aout64.h (enum reloc_type): Trim off 29k and other unused values.
	* aout/ar.h (ARMAGB): Remove.
	* coff/internal.h (struct internal_aouthdr, struct internal_scnhdr,
	union internal_auxent): Remove i960 support.
bfd/
	* aout-adobe.c: Delete.
	* bout.c: Delete.
	* coff-i860.c: Delete.
	* coff-i960.c: Delete.
	* cpu-i860.c: Delete.
	* cpu-i960.c: Delete.
	* elf32-i860.c: Delete.
	* elf32-i960.c: Delete.
	* hosts/i860mach3.h: Delete.
	* Makefile.am: Remove i860, i960, bout, and adobe support.
	* archures.c: Remove i860 and i960 support.
	* coffcode.h: Likewise.
	* reloc.c: Likewise.
	* aoutx.h: Comment updates.
	* archive.c: Remove BOUT and i960 support.
	* bfd.c: Remove BOUT support.
	* coffswap.h: Remove i960 support.
	* config.bfd: Remove i860, i960 and adobe targets.
	* configure.ac: Remove adode, bout, i860, i960, icoff targets.
	* targets.c: Likewise.
	* ieee.c: Remove i960 support.
	* mach-o.c: Remove i860 support.
	* Makefile.in: Regenerate.
	* bfd-in2.h: Regenerate.
	* configure: Regenerate.
	* libbfd.h: Regenerate.
	* po/SRC-POTFILES.in: Regenerate.
opcodes/
	* opcodes/i860-dis.c: Delete.
	* opcodes/i960-dis.c: Delete.
	* Makefile.am: Remove i860 and i960 support.
	* configure.ac: Likewise.
	* disassemble.c: Likewise.
	* disassemble.h: Likewise.
	* Makefile.in: Regenerate.
	* configure: Regenerate.
	* po/POTFILES.in: Regenerate.
binutils/
	* ieee.c: Remove i960 support.
	* od-macho.c: Remove i860 support.
	* readelf.c: Remove i860 and i960 support.
	* testsuite/binutils-all/objcopy.exp: Likewise.
	* testsuite/binutils-all/objdump.exp: Likewise.
	* testsuite/lib/binutils-common.exp: Likewise.
gas/
	* config/aout_gnu.h: Delete.
	* config/tc-i860.c: Delete.
	* config/tc-i860.h: Delete.
	* config/tc-i960.c: Delete.
	* config/tc-i960.h: Delete.
	* doc/c-i860.texi: Delete.
	* doc/c-i960.texi: Delete.
	* testsuite/gas/i860/README.i860: Delete.
	* testsuite/gas/i860/bitwise.d: Delete.
	* testsuite/gas/i860/bitwise.s: Delete.
	* testsuite/gas/i860/branch.d: Delete.
	* testsuite/gas/i860/branch.s: Delete.
	* testsuite/gas/i860/bte.d: Delete.
	* testsuite/gas/i860/bte.s: Delete.
	* testsuite/gas/i860/dir-align01.d: Delete.
	* testsuite/gas/i860/dir-align01.s: Delete.
	* testsuite/gas/i860/dir-intel01.d: Delete.
	* testsuite/gas/i860/dir-intel01.s: Delete.
	* testsuite/gas/i860/dir-intel02.d: Delete.
	* testsuite/gas/i860/dir-intel02.s: Delete.
	* testsuite/gas/i860/dir-intel03-err.l: Delete.
	* testsuite/gas/i860/dir-intel03-err.s: Delete.
	* testsuite/gas/i860/dual01.d: Delete.
	* testsuite/gas/i860/dual01.s: Delete.
	* testsuite/gas/i860/dual02-err.l: Delete.
	* testsuite/gas/i860/dual02-err.s: Delete.
	* testsuite/gas/i860/dual03.d: Delete.
	* testsuite/gas/i860/dual03.s: Delete.
	* testsuite/gas/i860/fldst01.d: Delete.
	* testsuite/gas/i860/fldst01.s: Delete.
	* testsuite/gas/i860/fldst02.d: Delete.
	* testsuite/gas/i860/fldst02.s: Delete.
	* testsuite/gas/i860/fldst03.d: Delete.
	* testsuite/gas/i860/fldst03.s: Delete.
	* testsuite/gas/i860/fldst04.d: Delete.
	* testsuite/gas/i860/fldst04.s: Delete.
	* testsuite/gas/i860/fldst05.d: Delete.
	* testsuite/gas/i860/fldst05.s: Delete.
	* testsuite/gas/i860/fldst06.d: Delete.
	* testsuite/gas/i860/fldst06.s: Delete.
	* testsuite/gas/i860/fldst07.d: Delete.
	* testsuite/gas/i860/fldst07.s: Delete.
	* testsuite/gas/i860/fldst08.d: Delete.
	* testsuite/gas/i860/fldst08.s: Delete.
	* testsuite/gas/i860/float01.d: Delete.
	* testsuite/gas/i860/float01.s: Delete.
	* testsuite/gas/i860/float02.d: Delete.
	* testsuite/gas/i860/float02.s: Delete.
	* testsuite/gas/i860/float03.d: Delete.
	* testsuite/gas/i860/float03.s: Delete.
	* testsuite/gas/i860/float04.d: Delete.
	* testsuite/gas/i860/float04.s: Delete.
	* testsuite/gas/i860/form.d: Delete.
	* testsuite/gas/i860/form.s: Delete.
	* testsuite/gas/i860/i860.exp: Delete.
	* testsuite/gas/i860/iarith.d: Delete.
	* testsuite/gas/i860/iarith.s: Delete.
	* testsuite/gas/i860/ldst01.d: Delete.
	* testsuite/gas/i860/ldst01.s: Delete.
	* testsuite/gas/i860/ldst02.d: Delete.
	* testsuite/gas/i860/ldst02.s: Delete.
	* testsuite/gas/i860/ldst03.d: Delete.
	* testsuite/gas/i860/ldst03.s: Delete.
	* testsuite/gas/i860/ldst04.d: Delete.
	* testsuite/gas/i860/ldst04.s: Delete.
	* testsuite/gas/i860/ldst05.d: Delete.
	* testsuite/gas/i860/ldst05.s: Delete.
	* testsuite/gas/i860/ldst06.d: Delete.
	* testsuite/gas/i860/ldst06.s: Delete.
	* testsuite/gas/i860/pfam.d: Delete.
	* testsuite/gas/i860/pfam.s: Delete.
	* testsuite/gas/i860/pfmam.d: Delete.
	* testsuite/gas/i860/pfmam.s: Delete.
	* testsuite/gas/i860/pfmsm.d: Delete.
	* testsuite/gas/i860/pfmsm.s: Delete.
	* testsuite/gas/i860/pfsm.d: Delete.
	* testsuite/gas/i860/pfsm.s: Delete.
	* testsuite/gas/i860/pseudo-ops01.d: Delete.
	* testsuite/gas/i860/pseudo-ops01.s: Delete.
	* testsuite/gas/i860/regress01.d: Delete.
	* testsuite/gas/i860/regress01.s: Delete.
	* testsuite/gas/i860/shift.d: Delete.
	* testsuite/gas/i860/shift.s: Delete.
	* testsuite/gas/i860/simd.d: Delete.
	* testsuite/gas/i860/simd.s: Delete.
	* testsuite/gas/i860/system.d: Delete.
	* testsuite/gas/i860/system.s: Delete.
	* testsuite/gas/i860/xp.d: Delete.
	* testsuite/gas/i860/xp.s: Delete.
	* Makefile.am: Remove i860 and i960 support.
	* configure.tgt: Likewise.
	* doc/Makefile.am: Likewise.
	* doc/all.texi: Likewise.
	* testsuite/gas/all/gas.exp
	* config/obj-coff.h: Remove i960 support.
	* doc/internals.texi: Likewise.
	* expr.c: Likewise.
	* read.c: Likewise.
	* write.c: Likewise.
	* write.h: Likewise.
	* testsuite/gas/lns/lns.exp: Likewise.
	* testsuite/gas/symver/symver.exp: Likewise.
	* config/tc-m68k.c: Remove BOUT support.
	* config/tc-score.c: Likewise.
	* config/tc-score7.c: Likewise.
	* config/tc-sparc.c: Likewise.
	* symbols.c: Likewise.
	* doc/h8.texi: Likewise.
	* configure.ac: Remove BOUT and i860 support.
	* doc/as.texinfo: Remove BOUT, i860 and i960 support
	* Makefile.in: Regenerate.
	* config.in: Regenerate.
	* configure: Regenerate.
	* doc/Makefile.in: Regenerate.
	* po/POTFILES.in: Regenerate.
ld/
	* emulparams/coff_i860.sh: Delete.
	* emulparams/elf32_i860.sh: Delete.
	* emulparams/elf32_i960.sh: Delete.
	* emulparams/gld960.sh: Delete.
	* emulparams/gld960coff.sh: Delete.
	* emulparams/lnk960.sh: Delete.
	* emultempl/gld960.em: Delete.
	* emultempl/gld960c.em: Delete.
	* emultempl/lnk960.em: Delete.
	* scripttempl/i860coff.sc: Delete.
	* scripttempl/i960.sc: Delete.
	* ld.texinfo: Remove i960 support.
	* Makefile.am: Remove i860 and i960 support.
	* configure.tgt: Likewise.
	* testsuite/ld-discard/extern.d: Likewise.
	* testsuite/ld-discard/start.d: Likewise.
	* testsuite/ld-discard/static.d: Likewise.
	* testsuite/ld-elf/compressed1d.d: Likewise.
	* testsuite/ld-elf/group1.d: Likewise.
	* testsuite/ld-elf/group3b.d: Likewise.
	* testsuite/ld-elf/group8a.d: Likewise.
	* testsuite/ld-elf/group8b.d: Likewise.
	* testsuite/ld-elf/group9a.d: Likewise.
	* testsuite/ld-elf/group9b.d: Likewise.
	* testsuite/ld-elf/linkonce2.d: Likewise.
	* testsuite/ld-elf/merge.d: Likewise.
	* testsuite/ld-elf/merge2.d: Likewise.
	* testsuite/ld-elf/merge3.d: Likewise.
	* testsuite/ld-elf/orphan-10.d: Likewise.
	* testsuite/ld-elf/orphan-11.d: Likewise.
	* testsuite/ld-elf/orphan-12.d: Likewise.
	* testsuite/ld-elf/orphan-9.d: Likewise.
	* testsuite/ld-elf/orphan-region.d: Likewise.
	* testsuite/ld-elf/orphan.d: Likewise.
	* testsuite/ld-elf/orphan3.d: Likewise.
	* testsuite/ld-elf/pr12851.d: Likewise.
	* testsuite/ld-elf/pr12975.d: Likewise.
	* testsuite/ld-elf/pr13177.d: Likewise.
	* testsuite/ld-elf/pr13195.d: Likewise.
	* testsuite/ld-elf/pr17550a.d: Likewise.
	* testsuite/ld-elf/pr17550b.d: Likewise.
	* testsuite/ld-elf/pr17550c.d: Likewise.
	* testsuite/ld-elf/pr17550d.d: Likewise.
	* testsuite/ld-elf/pr17615.d: Likewise.
	* testsuite/ld-elf/pr20528a.d: Likewise.
	* testsuite/ld-elf/pr20528b.d: Likewise.
	* testsuite/ld-elf/pr21562a.d: Likewise.
	* testsuite/ld-elf/pr21562b.d: Likewise.
	* testsuite/ld-elf/pr21562c.d: Likewise.
	* testsuite/ld-elf/pr21562d.d: Likewise.
	* testsuite/ld-elf/pr21562i.d: Likewise.
	* testsuite/ld-elf/pr21562j.d: Likewise.
	* testsuite/ld-elf/pr21562k.d: Likewise.
	* testsuite/ld-elf/pr21562l.d: Likewise.
	* testsuite/ld-elf/pr21562m.d: Likewise.
	* testsuite/ld-elf/pr21562n.d: Likewise.
	* testsuite/ld-elf/pr22677.d: Likewise.
	* testsuite/ld-elf/pr22836-1a.d: Likewise.
	* testsuite/ld-elf/pr22836-1b.d: Likewise.
	* testsuite/ld-elf/pr349.d: Likewise.
	* testsuite/ld-elf/sec-to-seg.exp: Likewise.
	* testsuite/ld-elf/sec64k.exp: Likewise.
	* testsuite/ld-elf/warn1.d: Likewise.
	* testsuite/ld-elf/warn2.d: Likewise.
	* testsuite/ld-elf/warn3.d: Likewise.
	* testsuite/lib/ld-lib.exp: Likewise.
	* Makefile.in: Regenerate.
	* po/BLD-POTFILES.in: Regenerate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add Rust test case for ".." struct initializer
@ 2018-04-11 14:46 sergiodj+buildbot
  2018-04-11 18:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-11 14:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 50146e7022cedafe615bfc9884358d291a00689f ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 50146e7022cedafe615bfc9884358d291a00689f

Add Rust test case for ".." struct initializer

Building with --coverage pointed out that there was no Rust test for
initializing a structure using the ".." initializer.  This patch adds
such a test.

Regression tested on x86-64 Fedora 26.

2018-04-11  Tom Tromey  <tom@tromey.com>

	* gdb.rust/simple.exp: Add test for ".." struct initializer.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add test for following fork on position-independent executables
@ 2018-04-11 19:22 sergiodj+buildbot
  2018-04-11 20:45 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-11 19:22 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6295b6da16f73d5113d24424d1897edbce42bc6a ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 6295b6da16f73d5113d24424d1897edbce42bc6a

Add test for following fork on position-independent executables

Commit

  b2e586e ("Defer breakpoint reset when cloning progspace for fork
  child")

fixed following fork childs when the executable is position-independent.
This patch adds a little test for it.

gdb/testsuite/ChangeLog:

	* gdb.base/pie-fork.c: New file.
	* gdb.base/pie-fork.exp: New file.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Enable Intel WAITPKG instructions.
@ 2018-04-11 20:14 sergiodj+buildbot
  2018-04-11 23:45 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-11 20:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT de89d0a34d52a2d2d28a4ce569e926dd9c7a7d13 ***

Author: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
Branch: master
Commit: de89d0a34d52a2d2d28a4ce569e926dd9c7a7d13

Enable Intel WAITPKG instructions.

Intel has disclosed a set of new instructions for Tremont processor.
The spec is
https://software.intel.com/en-us/intel-architecture-instruction-set-extensions-programming-reference
This patch enables Intel WAITPKG instructions.

gas/
	* config/tc-i386.c (cpu_arch): Add WAITPKG.
	(cpu_noarch): Likewise.
	* doc/c-i386.texi: Document WAITPKG.
	* i386/i386.exp: Run WAITPKG tests.
	* testsuite/gas/i386/waitpkg-intel.d: New test.
	* testsuite/gas/i386/waitpkg.d: Likewise.
	* testsuite/gas/i386/waitpkg.s: Likewise.
	* testsuite/gas/i386/x86-64-waitpkg-intel.d: Likewise.
	* testsuite/gas/i386/x86-64-waitpkg.d: Likewise.
	* testsuite/gas/i386/x86-64-waitpkg.s: Likewise.

opcodes/
	* i386-dis.c (enum): Add PREFIX_MOD_0_0FAE_REG_6,
	PREFIX_MOD_1_0FAE_REG_6.
	(va_mode): New.
	(OP_E_register): Use va_mode.
	* i386-dis-evex.h (prefix_table):
	New instructions (see prefixes above).
	* i386-gen.c (cpu_flag_init): Add WAITPKG.
	(cpu_flags): Likewise.
	* i386-opc.h (enum): Likewise.
	(i386_cpu_flags): Likewise.
	* i386-opc.tbl: Add umonitor, umwait, tpause.
	* i386-init.h: Regenerate.
	* i386-tbl.h: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Eliminate target_has_exited
@ 2018-04-12 16:59 sergiodj+buildbot
  2018-04-12 17:28 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-12 16:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 436411b1c6cb93541fd502321cf5470fe0392b91 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 436411b1c6cb93541fd502321cf5470fe0392b91

Eliminate target_has_exited

Nothing uses this.

gdb/ChangeLog:
2018-04-12  Pedro Alves  <palves@redhat.com>

	* target.h (target_ops::to_has_exited): Delete.
	(target_has_exited): Delete.
	* target-delegates.c: Regenerate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix Solaris build
@ 2018-04-12 17:40 sergiodj+buildbot
  2018-04-12 21:14 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-12 17:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 70b33f195b0d76e140921db40c0bea5a7c9abc42 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 70b33f195b0d76e140921db40c0bea5a7c9abc42

Fix Solaris build

This commit fixes a bit of rot in procfs.c caused by recent changes.

Specifically, the target_ops::to_detach change to pass down 'inferior
*' missed updating a forward declation, and the change to use
scoped_fd in more places missed removing one do_cleanups call.

  src/gdb/procfs.c: In function target_ops* procfs_target():
  src/gdb/procfs.c:167:16: error: invalid conversion from void (*)(target_ops*, const char*, int) to void (*)(target_ops*, inferior*, int) [-fpermissive]
     t->to_detach = procfs_detach;
		  ^
  src/gdb/procfs.c: In function ssd* proc_get_LDT_entry(procinfo*, int):
  src/gdb/procfs.c:1624:17: error: old_chain was not declared in this scope
      do_cleanups (old_chain);
		   ^
  src/gdb/procfs.c: At global scope:
  src/gdb/procfs.c:90:13: error: void procfs_detach(target_ops*, const char*, int) declared static but never defined [-Werror=unused-function]
   static void procfs_detach (struct target_ops *, const char *, int);
	       ^
  src/gdb/procfs.c:1923:1: error: void procfs_detach(target_ops*, inferior*, int) defined but not used [-Werror=unused-function]
   procfs_detach (struct target_ops *ops, inferior *inf, int from_tty)
   ^

gdb/ChangeLog:
2018-04-12  Pedro Alves  <palves@redhat.com>

	* procfs.c (procfs_detach): Make forward declaration's prototype
	match definition's protototype.
	(proc_get_LDT_entry): Remove stale do_cleanups call.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove old univariant code from rust-lang.c
@ 2018-04-12 19:33 sergiodj+buildbot
  2018-04-13  0:06 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-12 19:33 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 53d7df28bcbaecaf2dca7f8a4bf829e3dd786693 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 53d7df28bcbaecaf2dca7f8a4bf829e3dd786693

Remove old univariant code from rust-lang.c

Since moving Rust enum handling into dwarf2read.c, some old code for
handling univariant enums in rust-lang.c has been obsolete.  This
patch removes this code.

Tested on x86-64 Fedora 26, using rustc 1.23 (1.24 emits incorrect
DWARF for enums and so can't be used for this test).

2018-04-12  Tom Tromey  <tom@tromey.com>

	* rust-lang.c (rust_print_struct_def): Remove univariant code.
	(rust_evaluate_subexp): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix -D_GLIBCXX_DEBUG gdb-add-index regression
@ 2018-04-12 20:34 sergiodj+buildbot
  2018-04-13  2:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-12 20:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b4be9bfdabb57f40656e72a50a8466af4f7bd37d ***

Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Branch: master
Commit: b4be9bfdabb57f40656e72a50a8466af4f7bd37d

Fix -D_GLIBCXX_DEBUG gdb-add-index regression

Fedora Rawhide started to use -D_GLIBCXX_DEBUG which made gdb-add-index
failing:
	gdb: Out-of-bounds vector access while running gdb-add-index
	https://bugzilla.redhat.com/show_bug.cgi?id=1540559

/usr/include/c++/7/debug/safe_iterator.h:270:
Error: attempt to dereference a past-the-end iterator.
Objects involved in the operation:
    iterator "this" @ 0x0x7fffffffcb90 {
      type = __gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<unsigned char*, std::__cxx1998::vector<unsigned char, gdb::default_init_allocator<unsigned char, std::allocator<unsigned char> > > >, std::__debug::vector<unsigned char, gdb::default_init_allocator<unsigned char, std::allocator<unsigned char> > > > (mutable iterator);
      state = past-the-end;
      references sequence with type 'std::__debug::vector<unsigned char, gdb::default_init_allocator<unsigned char, std::allocator<unsigned char> > >' @ 0x0x7fffffffcc50
    }

/usr/include/c++/7/debug/vector:417:
Error: attempt to subscript container with out-of-bounds index 556, but
container only holds 556 elements.
Objects involved in the operation:
    sequence "this" @ 0x0x2e87af8 {
      type = std::__debug::vector<partial_symbol*, std::allocator<partial_symbol*> >;
    }

The two -D_GLIBCXX_DEBUG regressions were made by:

commit bc8f2430e08cc2a520db49a42686e0529be4a3bc
Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Date:   Mon Jun 12 16:29:53 2017 +0100
    Code cleanup: C++ify .gdb_index producer

commit af5bf4ada48ff65b6658be1fab8f9c8f8ab5f319
Author: Simon Marchi <simon.marchi@ericsson.com>
Date:   Sat Oct 14 08:06:29 2017 -0400
    Replace psymbol_allocation_list with std::vector

gdb/ChangeLog
2018-04-12  Jan Kratochvil  <jan.kratochvil@redhat.com>

	PR gdb/23053
	* dwarf-index-write.c (data_buf::grow) (write_one_signatured_type)
	(recursively_write_psymbols) (debug_names::recursively_write_psymbols)
	(debug_names::write_one_signatured_type): Fix -D_GLIBCXX_DEBUG
	regression.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] infrun: step through indirect branch thunks
@ 2018-04-13  8:59 sergiodj+buildbot
  2018-04-13 10:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-13  8:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1d509aa625f891e20b37b8cee4659771e87b1ba4 ***

Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: 1d509aa625f891e20b37b8cee4659771e87b1ba4

infrun: step through indirect branch thunks

With version 7.3 GCC supports new options

   -mindirect-branch=<choice>
   -mfunction-return=<choice>

The choices are:

    keep                behaves as before
    thunk               jumps through a thunk
    thunk-external      jumps through an external thunk
    thunk-inline        jumps through an inlined thunk

For thunk and thunk-external, GDB would, on a call to the thunk, step into
the thunk and then resume to its caller assuming that this is an
undebuggable function.  On a return thunk, GDB would stop inside the
thunk.

Make GDB step through such thunks instead.

Before:
    Temporary breakpoint 1, main ()
        at gdb.base/step-indirect-call-thunk.c:37
    37        x = apply (inc, 41);
    (gdb) s
    apply (op=0x80483e6 <inc>, x=41)
        at gdb.base/step-indirect-call-thunk.c:29
    29        return op (x);
    (gdb)
    30      }

After:
    Temporary breakpoint 1, main ()
        at gdb.base/step-indirect-call-thunk.c:37
    37        x = apply (inc, 41);
    (gdb) s
    apply (op=0x80483e6 <inc>, x=41)
        at gdb.base/step-indirect-call-thunk.c:29
    29        return op (x);
    (gdb)
    inc (x=41) at gdb.base/step-indirect-call-thunk.c:23
    23        return x + 1;

This is independent of the step-mode.  In order to step into the thunk,
you would need to use stepi.

When stepping over an indirect call thunk, GDB would first step through
the thunk, then recognize that it stepped into a sub-routine and resume to
the caller (of the thunk).  Not sure whether this is worth optimizing.

Thunk detection is implemented via gdbarch.  I implemented the methods for
IA.  Other architectures may run into unexpected fails.

The tests assume a fixed number of instruction steps to reach a thunk.
This depends on the compiler as well as the architecture.  They may need
adjustments when we add support for more architectures.  Or we can simply
drop those tests that cover being able to step into thunks using
instruction stepping.

When using an older GCC, the tests will fail to build and will be reported
as untested:

    Running .../gdb.base/step-indirect-call-thunk.exp ...
    gdb compile failed, \
    gcc: error: unrecognized command line option '-mindirect-branch=thunk'
    gcc: error: unrecognized command line option '-mfunction-return=thunk'

                    === gdb Summary ===

    # of untested testcases         1

gdb/
	* infrun.c (process_event_stop_test): Call
	gdbarch_in_indirect_branch_thunk.
	* gdbarch.sh (in_indirect_branch_thunk): New.
	* gdbarch.c: Regenerated.
	* gdbarch.h: Regenerated.
	* x86-tdep.h: New.
	* x86-tdep.c: New.
	* Makefile.in (ALL_TARGET_OBS): Add x86-tdep.o.
	(HFILES_NO_SRCDIR): Add x86-tdep.h.
	(ALLDEPFILES): Add x86-tdep.c.
	* arch-utils.h (default_in_indirect_branch_thunk): New.
	* arch-utils.c (default_in_indirect_branch_thunk): New.
	* i386-tdep: Include x86-tdep.h.
	(i386_in_indirect_branch_thunk): New.
	(i386_elf_init_abi): Set in_indirect_branch_thunk gdbarch
	function.
	* amd64-tdep: Include x86-tdep.h.
	(amd64_in_indirect_branch_thunk): New.
	(amd64_init_abi): Set in_indirect_branch_thunk gdbarch function.

testsuite/
	* gdb.base/step-indirect-call-thunk.exp: New.
	* gdb.base/step-indirect-call-thunk.c: New.
	* gdb.reverse/step-indirect-call-thunk.exp: New.
	* gdb.reverse/step-indirect-call-thunk.c: New.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] btrace: fix output of "set record btrace"
@ 2018-04-13  9:59 sergiodj+buildbot
  2018-04-13 12:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-13  9:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b85310e1ec0419c4e1ca091cdd48f7597ebbefd3 ***

Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: b85310e1ec0419c4e1ca091cdd48f7597ebbefd3

btrace: fix output of "set record btrace"

Instead of giving a message that "set record btrace" needs a sub-command,
GDB crashed.  Fix it.  A regression test comes with the next patch.

gdb/
	* record-btrace.c (cmd_set_record_btrace): Print sub-commands.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] record: fix typo in "set record" output
@ 2018-04-13 10:09 sergiodj+buildbot
  2018-04-13 14:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-13 10:09 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 69f90c75b369cd2d66988a67bbc2a000dd6b9816 ***

Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: 69f90c75b369cd2d66988a67bbc2a000dd6b9816

record: fix typo in "set record" output

Alan Hayward pointed out a typo in the output of "set record btrace" that
I took from "set record".  Fix the original.

gdb/
	* record.c (set_record_command): Fix typo in message.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] btrace: set/show record btrace cpu
@ 2018-04-13 10:21 sergiodj+buildbot
  2018-04-13 17:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-13 10:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4a4495d62d185bdae17ed6aae6ea8249ad07c799 ***

Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: 4a4495d62d185bdae17ed6aae6ea8249ad07c799

btrace: set/show record btrace cpu

Add new set/show commands to set the processor that is used for enabling
errata workarounds when decoding branch trace.

The general format is "<vendor>:<identifier>" but we also allow two
special values "auto" and "none".

The default is "auto", which is the current behaviour of having GDB
determine the processor on which the trace was recorded.

If that cpu is not known to the trace decoder, e.g. when using an old
decoder on a new system, decode may fail with "unknown cpu".  In most
cases it should suffice to 'downgrade' decode to assume an older cpu.
Unfortunately, we can't do this automatically.

The other special value, "none", disables errata workarounds.

gdb/
	* NEWS (New options): announce set/show record btrace cpu.
	* btrace.c: Include record-btrace.h.
	(btrace_compute_ftrace_pt): Skip enabling errata workarounds if
	the vendor is unknown.
	(btrace_compute_ftrace_1): Add cpu parameter.  Update callers.
	Maybe overwrite the btrace configuration's cpu.
	(btrace_compute_ftrace): Add cpu parameter.  Update callers.
	(btrace_fetch): Add cpu parameter.  Update callers.
	(btrace_maint_update_pt_packets): Call record_btrace_get_cpu.
	Maybe overwrite the btrace configuration's cpu.  Skip enabling
	errata workarounds if the vendor is unknown.
	* python/py-record-btrace.c: Include record-btrace.h.
	(recpy_bt_begin, recpy_bt_end, recpy_bt_instruction_history)
	(recpy_bt_function_call_history): Call record_btrace_get_cpu.
	* record-btrace.c (record_btrace_cpu_state_kind): New.
	(record_btrace_cpu): New.
	(set_record_btrace_cpu_cmdlist): New.
	(record_btrace_get_cpu): New.
	(require_btrace_thread, record_btrace_info)
	(record_btrace_resume_thread): Call record_btrace_get_cpu.
	(cmd_set_record_btrace_cpu_none): New.
	(cmd_set_record_btrace_cpu_auto): New.
	(cmd_set_record_btrace_cpu): New.
	(cmd_show_record_btrace_cpu): New.
	(_initialize_record_btrace): Initialize set/show record btrace cpu
	commands.
	* record-btrace.h (record_btrace_get_cpu): New.

testsuite/
	* gdb.btrace/cpu.exp: New.

doc/
	* gdb.texinfo: Document set/show record btrace cpu.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Show line numbers in output for "info var/func/type"
@ 2018-04-13 17:44 sergiodj+buildbot
  2018-04-13 19:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-13 17:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b744723f571815e6cee43df371c8e733e34e1edf ***

Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: b744723f571815e6cee43df371c8e733e34e1edf

Show line numbers in output for "info var/func/type"

The GDB commands "info variables", "info functions", and "info types" show
the appropriate list of definitions matching the given pattern.  They also
group them by source files.  But no line numbers within these source files
are shown.

The line number information is particularly useful to the user when a
simple "grep" doesn't readily point to a definition.  This is often the
case when the definition involves a macro, occurs within a namespace, or
when the identifier appears very frequently in the source file.

This patch enriches the printout of these commands by the line numbers and
adjusts affected test cases to the changed output where necessary.  The
new output looks like this:

  (gdb) i variables
  All defined variables:

  File foo.c:
  3:	const char * const foo;
  1:	int x;

The line number is followed by a colon and a tab character, which is then
followed by the symbol definition.  If no line number is available, the
tab is printed out anyhow, so definitions line up.

gdb/ChangeLog:

	* symtab.c (print_symbol_info): Precede the symbol definition by
	the line number when available.
	* NEWS: Advertise this enhancement.

gdb/doc/ChangeLog:

	* gdb.texinfo (Symbols): Mention the fact that "info
	variables/functions/types" show source files and line numbers.

gdb/testsuite/ChangeLog:

	* gdb.ada/info_types.exp: Adjust expected output to the line
	numbers now printed by "info var/func/type".
	* gdb.base/completion.exp: Likewise.
	* gdb.base/included.exp: Likewise.
	* gdb.cp/cp-relocate.exp: Likewise.
	* gdb.cp/cplusfuncs.exp: Likewise.
	* gdb.cp/namespace.exp: Likewise.
	* gdb.dwarf2/dw2-case-insensitive.exp: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] powerpc-lynxos and powerpc-windiss fixes
@ 2018-04-14  8:58 sergiodj+buildbot
  2018-04-14  9:42 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-14  8:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 24acfe5e2b7d4e6c0ccb72ffffc349d7fa88838d ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 24acfe5e2b7d4e6c0ccb72ffffc349d7fa88838d

powerpc-lynxos and powerpc-windiss fixes

Enabling shared lib tests showed the powerpc-lynxos target is broken,
and has been for a long time.  The breakage happened in a 2005-05-07
patch of mine, git commit 3b36f7e62, I think.  There have been no bug
reports I recall so it seems the target is dead.  powerpc-windiss is
similarly broken.

This patch fixes the breakage, and puts the targets on the obsolete
list.

bfd/
	* config.bfd: Add powerpc-*-lynxos* and powerpc-*-windiss*
	to obsolete list.
ld/
	* emulparams/elf32ppcwindiss.sh: Rewrite to use elf32ppc.sh.
	* emulparams/ppclynx.sh: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] powerpc max-page-size vs __QNXTARGET__
@ 2018-04-14  9:08 sergiodj+buildbot
  2018-04-14 12:54 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-14  9:08 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 03aa968462e0345b2d846ca240b8c723d713761a ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 03aa968462e0345b2d846ca240b8c723d713761a

powerpc max-page-size vs __QNXTARGET__

The default max-page-size on ppc32 has been 64k since 1995-02-15 (git
commit bcbe2c71).  There was a change committed 2003-07-12 to chose a
4k page if __QNXTARGET__ is defined, but that particular commit was
from an earlier posted patch
https://sourceware.org/ml/binutils/2003-07/msg00211.html that only
made the change effective for arm, rather than the later one
https://sourceware.org/ml/binutils/2003-07/msg00220.html that also
changed powerpc and sh..

Since the __QNXTARGET__ #ifdef in elf32-ppc.c is ineffective unless
the user defines it in his or her CFLAGS, I'm removing that code.

	* elf32-ppc.c (ELF_MAXPAGESIZE, ELF_COMMONPAGESIZE): Don't depend
	on __QNXTARGET__ define.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] powerpc common-page-size
@ 2018-04-14  9:25 sergiodj+buildbot
  2018-04-14 15:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-14  9:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 702d167134149f420ea3bcbc194d63a2653a0c27 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 702d167134149f420ea3bcbc194d63a2653a0c27

powerpc common-page-size

max-page-size only matters for demand paged executables or shared
libraries, and the ideal size is the largest value used by your
operating system.  Values larger than necessary just waste file space
and memory.  common-page-size also affects file and memory size,
trading a possible small increase in file size for a decrease in
memory size when the operating system is using a common-page-size
page.  With a powerpc max-page-size of 64k and common-page-size of 4k
many executables will use no more memory pages when the system page
size is 4k than an executable linked with -z max-page-size=0x1000,
yet will still run on a system using 64k pages.  However, when running
on a system using 64k pages relro protection will not be completely
effective.

Due to the relro problem, powerpc binutils has been using a default
common-page-size of 64k since 2014-12-18 (git commit 04c6a44c7),
leading to complaints about increased file and memory sizes.  People
not using relro do have a valid reason to complain..

So this patch introduces an extra back-end value to use as the default
for common-page-size when generating relro executables, and enables
the support for powerpc.  Non relro executables will now be generated
with a default common-page-size of 4k.

bfd/
	* elf-bfd.h (struct elf_backend_data): Add relropagesize.
	* elfxx-target.h (ELF_RELROPAGESIZE): Provide default and
	sanity test.
	(elfNN_bed): Init relropagesize.
	* bfd.c (bfd_emul_get_commonpagesize): Add boolean param to
	select relropagesize.
	* elf32-ppc.c (ELF_COMMONPAGESIZE): Define as 0x1000.
	(ELF_RELROPAGESIZE): Define as ELF_MAXPAGESIZE.
	(ELF_MINPAGESIZE): Don't define.
	* elf64-ppc.c (ELF_COMMONPAGESIZE): Define as 0x1000.
	(ELF_RELROPAGESIZE): Define as ELF_MAXPAGESIZE.
	* bfd-in2.h: Regenerate.
ld/
	* ldmain.c (main): Move config.maxpagesize and
	config.commonpagesize initialization to..
	* ldemul.c (after_parse_default): ..here.
	* testsuite/ld-powerpc/ppc476-shared.d: Pass -z common-page-size.
	* testsuite/ld-powerpc/ppc476-shared2.d: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: Allow 32-bit registers for tpause and umwait
@ 2018-04-15 15:56 sergiodj+buildbot
  2018-04-15 16:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-15 15:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ae1d38437284b31d5a1c604bcf391d4543be00a5 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: ae1d38437284b31d5a1c604bcf391d4543be00a5

x86: Allow 32-bit registers for tpause and umwait

Since only the first 32 bits of input operand are used for tpause and
umwait, the REX.W bit is skipped.  Both 32-bit registers and 64-bit
registers are allowed.

gas/

	* testsuite/gas/i386/x86-64-waitpkg.s: Add 32-bit registers
	tests for tpause and umwait.
	* testsuite/gas/i386/x86-64-waitpkg-intel.d: Updated.
	* testsuite/gas/i386/x86-64-waitpkg.d: Likewise.

opcodes/

	* i386-dis.c (prefix_table): Replace Em with Edq on tpause and
	umwait.
	* i386-opc.tbl: Allow 32-bit registers for tpause and umwait in
	64-bit mode.
	* i386-tbl.h: Regenerated.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add x86-tdep.o to i386/amd64 target build
@ 2018-04-15 20:05 sergiodj+buildbot
  2018-04-15 20:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-15 20:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT eda4efb12763893b8a49c10c6f2823a465c1c6ba ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: eda4efb12763893b8a49c10c6f2823a465c1c6ba

Add x86-tdep.o to i386/amd64 target build

We get this error when doing a build with a single amd64 target (the
default when doing just ./configure on x86-64 GNU/Linux):

/home/simark/src/binutils-gdb/gdb/i386-tdep.c:4431: error: undefined reference to 'x86_in_indirect_branch_thunk(unsigned long, char const**, int, int)'
/home/simark/src/binutils-gdb/gdb/amd64-tdep.c:3045: error: undefined reference to 'x86_in_indirect_branch_thunk(unsigned long, char const**, int, int)'

The problem is that commit

  1d509aa625f8 ("infrun: step through indirect branch thunks")

missed adding x86-tdep.o to the list of object file included in an amd64
or i386 build.  The problem is not seen with --enable-targets=all
because that file is included in ALL_TARGET_OBS.

Built-tested using:

  * --host=x86_64-pc-linux-gnu --target=x86_64-pc-linux-gnu
  * --host=armv7-rpi2-linux-gnueabihf --target=x86_64-pc-linux-gnu

gdb/ChangeLog:

	* configure.tgt (x86_tobjs): New variable.
	(amd64_tobjs, i386_tobjs): Use it.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove tahoe support
@ 2018-04-16  6:50 sergiodj+buildbot
  2018-04-16  7:14 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-16  6:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fceadf09517d8b37a0fa77852e26a789fc160d94 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: fceadf09517d8b37a0fa77852e26a789fc160d94

Remove tahoe support

include/
	* opcode/tahoe.h: Delete.
bfd/
	* archures.c: Remove tahoe support.
	* config.bfd: Likewise.
	* configure.ac: Likewise.
	* hosts/tahoe.h: Delete.
	* bfd-in2.h: Regenerate.
	* configure: Regenerate.
opcodes/
	* configure.ac: Remove tahoe support.
	* configure: Regenerate.
binutils/
	* testsuite/binutils-all/objdump.exp: Remove tahoe support.
gprof/
	* Makefile.am: Remove tahoe support.
	* corefile.c: Likewise.
	* tahoe.c: Delete.
	* Makefile.in: Regenerate.
	* po/POTFILES.in: Regenerate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove netware support
@ 2018-04-16  7:26 sergiodj+buildbot
  2018-04-16  9:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-16  7:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b4b594e304d44458e25e106ddb4824a37aaf556c ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: b4b594e304d44458e25e106ddb4824a37aaf556c

Remove netware support

include/
	* nlm/ChangeLog-9315: Delete.
	* nlm/alpha-ext.h: Delete.
	* nlm/common.h: Delete.
	* nlm/external.h: Delete.
	* nlm/i386-ext.h: Delete.
	* nlm/internal.h: Delete.
	* nlm/ppc-ext.h: Delete.
	* nlm/sparc32-ext.h: Delete.
bfd/
	* Makefile.am: Remove netware support.
	* bfd-in.h: Likewise.
	* bfd.c: Likewise.
	* config.bfd: Likewise.
	* configure.ac: Likewise.
	* doc/bfdint.texi: Likewise.
	* ecoff.c: Likewise.
	* targets.c: Likewise.
	* libnlm.h: Delete.
	* nlm-target.h: Delete.
	* nlm.c: Delete.
	* nlm32-alpha.c: Delete.
	* nlm32-i386.c: Delete.
	* nlm32-ppc.c: Delete.
	* nlm32-sparc.c: Delete.
	* nlm32.c: Delete.
	* nlm64.c: Delete.
	* nlmcode.h: Delete.
	* nlmswap.h: Delete.
	* Makefile.in: Regenerate.
	* bfd-in2.h: Regenerate.
	* configure: Regenerate.
	* po/SRC-POTFILES.in: Regenerate.
binutils/
	* .gitignore: Remove netware support.
	* Makefile.am: Likewise.
	* configure.ac: Likewise.
	* doc/Makefile.am: Likewise.
	* doc/binutils.texi: Likewise.
	* testsuite/binutils-all/nm.exp: Likewise.
	* nlmconv.c: Delete.
	* nlmconv.h: Delete.
	* nlmheader.y: Delete.
	* Makefile.in: Regenerate.
	* configure: Regenerate.
	* doc/Makefile.in: Regenerate.
	* po/POTFILES.in: Regenerate.
gas/
	* Makefile.am: Remove netware support.
	* config/tc-i386.c: Likewise.
	* configure.tgt: Likewise.
	* config/te-netware.h: Delete.
	* Makefile.in: Regenerate.
	* po/POTFILES.in: Regenerate.
gprof/
	* corefile.c: Remove netware support.
ld/
	* Makefile.am: Remove netware support.
	* configure.tgt: Likewise.
	* testsuite/ld-powerpc/powerpc.exp: Likewise.
	* emulparams/i386nw.sh: Delete.
	* emulparams/ppcnw.sh: Delete.
	* scripttempl/nw.sc: Delete.
	* Makefile.in: Regenerate.
	* po/BLD-POTFILES.in: Regenerate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove sony newsos3 support
@ 2018-04-16  8:11 sergiodj+buildbot
  2018-04-16 12:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-16  8:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5972ac7375e9b6a6f0c4bdef31d3da574fb1b65e ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 5972ac7375e9b6a6f0c4bdef31d3da574fb1b65e

Remove sony newsos3 support

include/
	* aout/host.h: Remove newsos3 support.
bfd/
	* Makefile.am: Remove newsos3 support.
	* aoutx.h: Likewise.
	* config.bfd: Likewise.
	* configure.ac: Likewise.
	* targets.c: Likewise.
	* newsos3.c: Delete.
	* Makefile.in: Regenerate.
	* configure: Regenerate.
	* po/SRC-POTFILES.in: Regenerate.
binutils/
	* testsuite/binutils-all/copy-2.d: Remove newsos3 support.
	* testsuite/binutils-all/nm.exp: Likewise.
ld/
	* Makefile.am: Remove newsos3 support.
	* configure.tgt: Likewise.
	* emulparams/news.sh: Delete.
	* Makefile.in: Regenerate.
	* po/BLD-POTFILES.in: Regenerate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove tandem support
@ 2018-04-16  8:43 sergiodj+buildbot
  2018-04-16 14:29 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-16  8:43 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT de96689e03235bfd65a33704a9d398cb666140f4 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: de96689e03235bfd65a33704a9d398cb666140f4

Remove tandem support

bfd/
	* config.bfd: Remove tandem support.
ld/
	* Makefile.am: Remove tandem support.
	* configure.tgt: Likewise.
	* emulparams/st2000.sh: Delete.
	* scripttempl/st2000.sc: Delete.
	* Makefile.in: Regenerate.
	* po/BLD-POTFILES.in: Regenerate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove IEEE 695 object support
@ 2018-04-16  9:17 sergiodj+buildbot
  2018-04-16 16:48 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-16  9:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fdef3943443987525aea4f3ebe1f569f7070fcc8 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: fdef3943443987525aea4f3ebe1f569f7070fcc8

Remove IEEE 695 object support

include/
	* ieee.h: Delete.
bfd/
	* Makefile.am: Remove IEEE 695 support.
	* archures.c: Likewise.
	* bfd.c: Likewise.
	* config.bfd: Likewise.
	* configure.ac: Likewise.
	* doc/bfd.texinfo: Likewise.
	* doc/bfdint.texi: Likewise.
	* doc/bfdsumm.texi: Likewise.
	* section.c: Likewise.
	* targets.c: Likewise.
	* ieee.c: Delete.
	* libieee.h: Delete.
	* Makefile.in: Regenerate.
	* bfd-in2.h: Regenerate.
	* configure: Regenerate.
	* po/SRC-POTFILES.in: Regenerate.
binutils/
	* Makefile.am: Remove IEEE 695 support.
	* budbg.h: Likewise.
	* doc/binutils.texi: Likewise.
	* makefile.vms: Likewise.
	* objcopy.c: Likewise.
	* objdump.c: Likewise.
	* rddbg.c: Likewise.
	* ieee.c: Delete.
	* Makefile.in: Regenerate.
	* po/POTFILES.in: Regenerate.
gas/
	* app.c: Remove IEEE 695 support.
	* symbols.c: Likewise.
ld/
	* ld.texinfo: Remove IEEE 695 support.
	* mri.c: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove h8300-coff support
@ 2018-04-16  9:50 sergiodj+buildbot
  2018-04-16 19:06 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-16  9:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fe0bf0fd57ea3ef8458d2e8661b428110fc026e2 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: fe0bf0fd57ea3ef8458d2e8661b428110fc026e2

Remove h8300-coff support

include/
	* coff/h8300.h: Delete.
bfd/
	* Makefile.am: Remove h8300-coff support.
	* coffcode.h: Likewise.
	* config.bfd: Likewise.
	* configure.ac: Likewise.
	* reloc16.c: Likewise.
	* targets.c: Likewise.
	* coff-h8300.c: Delete.
	* Makefile.in: Regenerate.
	* configure: Regenerate.
	* po/SRC-POTFILES.in: Regenerate.
binutils/
	* testsuite/binutils-all/objcopy.exp: Remove h8300-coff support.
gas/
	* config/obj-coff.h: Remove h8300-coff support.
	* config/tc-h8300.c: Likewise.
	* config/tc-h8300.h: Likewise.
	* testsuite/gas/h8300/h8300.exp: Likewise.
	* testsuite/gas/h8300/branch-coff.s: Delete.
	* testsuite/gas/h8300/branchh-coff.s: Delete.
	* testsuite/gas/h8300/branchs-coff.s: Delete.
	* testsuite/gas/h8300/ffxx1-coff.d: Delete.
	* testsuite/gas/h8300/ffxx1-coff.s: Delete.
	* testsuite/gas/h8300/h8300-coff.exp: Delete.
ld/
	* Makefile.am: Remove h8300-coff support.
	* configure.tgt: Likewise.
	* testsuite/ld-h8300/h8300.exp: Likewise.
	* emulparams/h8300.sh: Delete.
	* emulparams/h8300h.sh: Delete.
	* emulparams/h8300hn.sh: Delete.
	* emulparams/h8300s.sh: Delete.
	* emulparams/h8300sn.sh: Delete.
	* emulparams/h8300sx.sh: Delete.
	* emulparams/h8300sxn.sh: Delete.
	* scripttempl/h8300.sc: Delete.
	* scripttempl/h8300h.sc: Delete.
	* scripttempl/h8300hn.sc: Delete.
	* scripttempl/h8300s.sc: Delete.
	* scripttempl/h8300sn.sc: Delete.
	* scripttempl/h8300sx.sc: Delete.
	* scripttempl/h8300sxn.sc: Delete.
	* testsuite/ld-h8300/relax-3-coff.d: Delete.
	* testsuite/ld-h8300/relax-4-coff.d: Delete.
	* testsuite/ld-h8300/relax-5-coff.d: Delete.
	* testsuite/ld-h8300/relax-6-coff.d: Delete.
	* Makefile.in: Regenerate.
	* po/BLD-POTFILES.in: Regenerate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove h8500 support
@ 2018-04-16 10:44 sergiodj+buildbot
  2018-04-16 21:15 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-16 10:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e82aa7944d2b00c54e9d3c1a47c5ed4a0e39393a ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: e82aa7944d2b00c54e9d3c1a47c5ed4a0e39393a

Remove h8500 support

include/
	* coff/h8500.h: Delete.
	* coff/internal.h: Remove h8500 support.
bfd/
	* Makefile.am: Remove h8500 support.
	* archures.c: Likewise.
	* coffcode.h: Likewise.
	* config.bfd: Likewise.
	* configure.ac: Likewise.
	* targets.c: Likewise.
	* coff-h8500.c: Delete.
	* cpu-h8500.c: Delete.
	* Makefile.in: Regenerate.
	* bfd-in2.h: Regenerate.
	* configure: Regenerate.
	* po/SRC-POTFILES.in: Regenerate.
opcodes/
	* Makefile.am: Remove h8500 support.
	* configure.ac: Likewise.
	* disassemble.c: Likewise.
	* disassemble.h: Likewise.
	* h8500-dis.c: Delete.
	* h8500-opc.h: Delete.
	* Makefile.in: Regenerate.
	* configure: Regenerate.
	* po/POTFILES.in: Regenerate.
binutils/
	* testsuite/binutils-all/objcopy.exp: Remove h8500 support.
	* testsuite/lib/binutils-common.exp: Likewise.
gas/
	* config/obj-coff.h: Remove h8500 support.
ld/
	* Makefile.am: Remove h8500 support.
	* configure.tgt: Likewise.
	* emulparams/h8500.sh: Delete.
	* emulparams/h8500b.sh: Delete.
	* emulparams/h8500c.sh: Delete.
	* emulparams/h8500m.sh: Delete.
	* emulparams/h8500s.sh: Delete.
	* scripttempl/h8500.sc: Delete.
	* scripttempl/h8500b.sc: Delete.
	* scripttempl/h8500c.sc: Delete.
	* scripttempl/h8500m.sc: Delete.
	* scripttempl/h8500s.sc: Delete.
	* Makefile.in: Regenerate.
	* po/BLD-POTFILES.in: Regenerate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove i370 support
@ 2018-04-16 10:56 sergiodj+buildbot
  2018-04-16 23:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-16 10:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6793974daae8ff3f8ad4e856a9f0e3bbe4fdf9a3 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 6793974daae8ff3f8ad4e856a9f0e3bbe4fdf9a3

Remove i370 support

include/
	* elf/i370.h: Delete.
	* opcode/i370.h: Delete.
bfd/
	* Makefile.am: Remove i370 support.
	* archures.c: Likewise.
	* config.bfd: Likewise.
	* configure.ac: Likewise.
	* targets.c: Likewise.
	* cpu-i370.c: Delete.
	* elf32-i370.c: Delete.
	* Makefile.in: Regenerate.
	* bfd-in2.h: Regenerate.
	* configure: Regenerate.
	* po/SRC-POTFILES.in: Regenerate.
opcodes/
	* Makefile.am: Remove i370 support.
	* configure.ac: Likewise.
	* disassemble.c: Likewise.
	* disassemble.h: Likewise.
	* i370-dis.c: Delete.
	* i370-opc.c: Delete.
	* Makefile.in: Regenerate.
	* configure: Regenerate.
	* po/POTFILES.in: Regenerate.
binutils/
	* readelf.c: Remove i370 support.
	* testsuite/binutils-all/objdump.exp: Likewise.
gas/
	* Makefile.am: Remove i370 support.
	* app.c: Likewise.
	* config/obj-elf.c: Likewise.
	* configure.tgt: Likewise.
	* doc/Makefile.am: Likewise.
	* doc/as.texinfo: Likewise.
	* testsuite/gas/all/gas.exp: Likewise.
	* testsuite/gas/elf/warn-2.s: Likewise.
	* testsuite/gas/lns/lns.exp: Likewise.
	* config/tc-i370.c: Delete.
	* config/tc-i370.h: Delete.
	* doc/c-i370.texi: Delete.
	* Makefile.in: Regenerate.
	* doc/Makefile.in: Regenerate.
	* po/POTFILES.in: Regenerate.
ld/
	* Makefile.am: Remove i370 support.
	* configure.tgt: Likewise.
	* testsuite/ld-elf/compressed1d.d: Likewise.
	* testsuite/ld-elf/group8a.d: Likewise.
	* testsuite/ld-elf/group8b.d: Likewise.
	* testsuite/ld-elf/group9a.d: Likewise.
	* testsuite/ld-elf/group9b.d: Likewise.
	* testsuite/ld-elf/merge.d: Likewise.
	* testsuite/ld-elf/pr12851.d: Likewise.
	* testsuite/ld-elf/pr12975.d: Likewise.
	* testsuite/ld-elf/pr13177.d: Likewise.
	* testsuite/ld-elf/pr13195.d: Likewise.
	* testsuite/ld-elf/pr17615.d: Likewise.
	* testsuite/ld-elf/pr21562a.d: Likewise.
	* testsuite/ld-elf/pr21562b.d: Likewise.
	* testsuite/ld-elf/pr21562c.d: Likewise.
	* testsuite/ld-elf/pr21562d.d: Likewise.
	* testsuite/ld-elf/pr21562i.d: Likewise.
	* testsuite/ld-elf/pr21562j.d: Likewise.
	* testsuite/ld-elf/pr21562k.d: Likewise.
	* testsuite/ld-elf/pr21562l.d: Likewise.
	* testsuite/ld-elf/pr21562m.d: Likewise.
	* testsuite/ld-elf/pr21562n.d: Likewise.
	* testsuite/ld-elf/pr22677.d: Likewise.
	* testsuite/lib/ld-lib.exp: Likewise.
	* emulparams/elf32i370.sh: Delete.
	* scripttempl/elfi370.sc: Delete.
	* Makefile.in: Regenerate.
	* po/BLD-POTFILES.in: Regenerate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb: Remove support for SH-5/SH64
@ 2018-04-16 14:17 sergiodj+buildbot
  2018-04-17  4:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-16 14:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8a3de5e1a3fb7bdf89195388f127ecf429294f6f ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 8a3de5e1a3fb7bdf89195388f127ecf429294f6f

gdb: Remove support for SH-5/SH64

Since bfd dropped support for SH-5, there's no point in keeping it in
GDB either.

This restores --enable-targets=all builds.

gdb/ChangeLog:
2018-04-16  Pedro Alves  <palves@redhat.com>

	* MAINTAINERS (sh): Remove.
	* Makefile.in (ALL_TARGET_OBS): Remove sh64-tdep.o.
	(HFILES_NO_SRCDIR): Remove sh64-tdep.h.
	(ALLDEPFILES): Remove sh64-tdep.c.
	* NEWS: Mentions that support for SH-5/SH64 is removed.
	* configure.tgt (sh*-*-linux*): Remove reference to sh64-tdep.o.
	(sh*-*-openbsd*): Ditto.
	(sh64-*-elf*): Remove.
	(sh*): Remove.
	* regcache.c (cooked_write_test): Remove bfd_mach_sh5 case.
	* sh-linux-tdep.c: Remove reference to bfd_mach_sh5.
	* sh-tdep.c: No longer include "sh64-tdep.h".
	(sh_gdbarch_init): Remove reference to bfd_mach_sh5.
	* sh64-tdep.c, sh64-tdep.h: Remove files.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Adjust more test cases to changed output of info var/func/type
@ 2018-04-16 19:20 sergiodj+buildbot
  2018-04-17  6:35 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-16 19:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e3a91079b5e5669567424d3b2f31b48b7b89ef72 ***

Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: e3a91079b5e5669567424d3b2f31b48b7b89ef72

Adjust more test cases to changed output of info var/func/type

After this commit:

  b744723f57 -- Show line numbers in output for "info var/func/type"

the test cases dbx.exp and info-fun.exp yield new FAILs because two
regular expressions have not been adjusted to the changed output yet.
This is fixed.

gdb/testsuite/ChangeLog:

	* gdb.base/dbx.exp (test_whereis): Adjust regexp to added line
	number information in output of "whereis" command.
	* gdb.base/info-fun.exp: Likewise, for "info fun" command.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] linux_spu_make_corefile_notes: return note_data instead of nullptr
@ 2018-04-16 21:12 sergiodj+buildbot
  2018-04-17  9:05 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-16 21:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 07d28c777757148d13e429c4463da52cbb50d297 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 07d28c777757148d13e429c4463da52cbb50d297

linux_spu_make_corefile_notes: return note_data instead of nullptr

Since commit

  9018be2 ("Make target_read_alloc & al return vectors")

the test gdb.threads/gcore-stale-thread.exp test results in UNSUPPORTED:

  UNSUPPORTED: gdb.threads/gcore-stale-thread.exp: save a corefile

The problem is that the linux_spu_make_corefile_notes started returning
nullptr when reading TARGET_OBJECT_SPU fails.  The previous (and proper)
behaviour is to return the note_data received as a parameter, so that
other functions may continue to append to this buffer.

With this patch, the test goes back to PASS.

gdb/ChangeLog:

	* linux-tdep.c (linux_spu_make_corefile_notes): Return note_data
	instead of nullptr.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Reinstate readelf decoding of i860, i960 and i370 relocs
@ 2018-04-17  3:38 sergiodj+buildbot
  2018-04-17 11:45 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-17  3:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f954747f10467071b0acde07ee5f5e268ab606a6 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: f954747f10467071b0acde07ee5f5e268ab606a6

Reinstate readelf decoding of i860, i960 and i370 relocs

include/
	* elf/i370.h: Revert removal.
	* elf/i860.h: Likewise.
	* elf/i960.h: Likewise.
binutils
	* readelf.c: Revert 2018-04-16 and 2018-04-11 changes.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Enable Intel CLDEMOTE instruction.
@ 2018-04-17 10:18 sergiodj+buildbot
  2018-04-17 13:55 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-17 10:18 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c48935d75f720ecb006c81b37f4058e751f1dc31 ***

Author: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
Branch: master
Commit: c48935d75f720ecb006c81b37f4058e751f1dc31

Enable Intel CLDEMOTE instruction.

gas/
	* config/tc-i386.c (cpu_arch): Add .cldemote.
	* doc/c-i386.texi: Document cldemote/.cldemote.
	* testsuite/gas/i386/cldemote-intel.d: New.
	* testsuite/gas/i386/cldemote.d: Likewise.
	* testsuite/gas/i386/cldemote.s: Likewise.
	* testsuite/gas/i386/i386.exp: Run new tests.
	* testsuite/gas/i386/x86-64-cldemote-intel.d: New.
	* testsuite/gas/i386/x86-64-cldemote.d: Likewise.
	* testsuite/gas/i386/x86-64-cldemote.s: Likewise.
	* testsuite/gas/i386/ilp32/x86-64-nops.d: Remove 0x0f1c
	NOP encoding that maps to cldemote.
	* testsuite/gas/i386/nops.d: Likewise.
	* testsuite/gas/i386/nops.s: Likewise.
	* testsuite/gas/i386/x86-64-nops.d: Likewise.
	* testsuite/gas/i386/x86-64-nops.s: Likewise.

opcode/
	* i386-dis.c: Add REG_0F1C_MOD_0, MOD_0F1C_PREFIX_0,
	PREFIX_0F1C.
	* i386-gen.c (cpu_flag_init): Add CPU_CLDEMOTE_FLAGS,
	(cpu_flags): Add CpuCLDEMOTE.
	* i386-init.h: Regenerate.
	* i386-opc.h (enum): Add CpuCLDEMOTE,
	(i386_cpu_flags): Add cpucldemote.
	* i386-opc.tbl: Add cldemote.
	* i386-tbl.h: Regenerate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Resync libiberty sources with master version in GCC repository.
@ 2018-04-17 13:19 sergiodj+buildbot
  2018-04-17 16:04 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-17 13:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e9301e762ab6d533f7110d6c9c1dbe8e68e875d7 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: e9301e762ab6d533f7110d6c9c1dbe8e68e875d7

Resync libiberty sources with master version in GCC repository.

2018-04-13  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	PR lto/81968
	* simple-object.c (handle_lto_debug_sections): Keep .comment
	section.

2018-03-02  David Malcolm  <dmalcolm@redhat.com>

	* cp-demangle.c: Update URL for g++ V3 ABI.

2018-01-20  Eli Zaretskii  <eliz@gnu.org>

	* simple-object-xcoff.c (simple_object_xcoff_find_sections): Use
	ulong_type to avoid warning about 32-bit shift.

2018-01-11  Richard Biener  <rguenther@suse.de>
	Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	PR lto/81968
	* simple-object-common.h (struct simple_object_functions):
	Change copy_lto_debug_sections callback signature.
	* simple-object-elf.c (SHN_HIRESERVE, SHT_SYMTAB_SHNDX,
	SHF_INFO_LINK): Add defines.
	(simple_object_elf_copy_lto_debug_sections): Instead of
	leaving not to be copied sections empty unnamed SHT_NULL
	remove them from the target section headers and adjust section
	reference everywhere.  Handle SHN_XINDEX in the symbol table
	processing properly.
	* simple-object.c (handle_lto_debug_sections): Change
	interface to return a modified string and handle renaming
	of relocation sections.

2018-01-10  Daniel van Gerpen  <daniel@vangerpen.de>

	* argv.c (expandargv): Correct check for dynamically
	allocated argv.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add a check for a NULL table pointer before attempting to compute a DWARF filename.
@ 2018-04-17 14:06 sergiodj+buildbot
  2018-04-17 18:14 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-17 14:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6327533b1fd29fa86f6bf34e61c332c010e3c689 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 6327533b1fd29fa86f6bf34e61c332c010e3c689

Add a check for a NULL table pointer before attempting to compute a DWARF filename.

	PR 23065
	* dwarf2.c (concat_filename): Check for a NULL table pointer.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix illegal memory accesses trigeered when linking corrupt input files.
@ 2018-04-17 17:09 sergiodj+buildbot
  2018-04-17 20:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-17 17:09 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 808346fcfcff1c3f2471c98e48613afd7bce3679 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 808346fcfcff1c3f2471c98e48613afd7bce3679

Fix illegal memory accesses trigeered when linking corrupt input files.

	PR 23055
	* aoutx.h (find_nearest_line): Check that the symbol name exists
	and is long enough, before attempting to see if it is for a .o
	file.
	* hash.c (bfd_hash_hash): Add an assertion that the string is not
	NULL.
	* linker.c (bfd_link_hash_lookup): Fail if the table or string are
	NULL.
	(_bfd_generic_link_add_archive_symbols): Fail if an archive entry
	has no name.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Don't print symbol declaration's line number in rbreak output
@ 2018-04-17 17:52 sergiodj+buildbot
  2018-04-17 22:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-17 17:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c7dcbf88c6557f35d9e75ae6223a3e61e1f70578 ***

Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: c7dcbf88c6557f35d9e75ae6223a3e61e1f70578

Don't print symbol declaration's line number in rbreak output

This commit:

  b744723f57 -- Show line numbers in output for "info var/func/type"

adds the symbol declaration's line number to the output of certain GDB
commands.  It also (inadvertently) changes the `rbreak' command's output,
like this:

  (gdb) rbreak foo
  Breakpoint 1 at 0x40049b: file rbreak.c, line 6.
  4:      static int foo1(void);
  Breakpoint 2 at 0x4004b1: file rbreak.c, line 12.
  10:     static int foo2(void);
  (gdb)

where the function declaration is now prefixed by its source line number,
followed by a colon.  But without showing the declaration's file name, the
line number is useless and can possibly cause severe confusion.

No declaration line number was shown before.  Instead, the function
declaration started at the first column:

  (gdb) rbreak foo
  Breakpoint 1 at 0x40049b: file rbreak.c, line 6.
  static int foo1(void);
  Breakpoint 2 at 0x4004b1: file rbreak.c, line 12.
  static int foo2(void);
  (gdb)

This old behavior is restored, fixing some FAILs in fullpath-expand.exp,
realname-expand.exp, and pr10179.exp.

In order to distinguish when to print location information, the meaning of
print_symbol_info()'s parameter `last' is changed.  Now NULL means to skip
any filename or line number information.  Previously NULL meant to always
print the filename.

gdb/ChangeLog:

	* symtab.c (print_symbol_info): Skip printing filename and line
	number when `last' is NULL.
	(symtab_symbol_info): Use empty string instead of NULL for first
	invocation of print_symbol_info.
	(rbreak_command): Pass NULL to `last' parameter of
	print_symbol_info.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix crash in quirk_rust_enum
@ 2018-04-17 20:03 sergiodj+buildbot
  2018-04-18  0:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-17 20:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a037790ec570ae9f9bf535cbce25f238f90e8b4a ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: a037790ec570ae9f9bf535cbce25f238f90e8b4a

Fix crash in quirk_rust_enum

I noticed that quirk_rust_enum can crash when presented with a union
whose fields are all scalar types.

This patch adds a new test case and fixes the bug.

Regression tested on Fedora 26 x86-64.

2018-04-17  Tom Tromey  <tom@tromey.com>

	* dwarf2read.c (quirk_rust_enum): Handle unions correctly.

2018-04-17  Tom Tromey  <tom@tromey.com>

	* gdb.rust/simple.rs (Union): New type.
	(main): New local "u".
	* gdb.rust/simple.exp (test_one_slice): Add new test case.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Conditionally drop the discriminant field in quirk_rust_enum
@ 2018-04-17 20:26 sergiodj+buildbot
  2018-04-18  2:49 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-17 20:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bedda9aced2b3a8ab05e0fbf1372e394e32afbde ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: bedda9aced2b3a8ab05e0fbf1372e394e32afbde

Conditionally drop the discriminant field in quirk_rust_enum

While debugging the crash that Jan reported, I noticed that in some
situations we could end up with a situation where one branch of a Rust
enum type ended up with a field count of -1.

The fix is simple: only conditionally drop the discriminant field when
rewriting the enum variants.

I couldn't find a way to test this; I only noticed it while debugging
the DWARF reader.

2018-04-17  Tom Tromey  <tom@tromey.com>

	* dwarf2read.c (quirk_rust_enum): Conditionally drop the
	discriminant field.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [MicroBlaze] PIC data text relative
@ 2018-04-17 22:07 sergiodj+buildbot
  2018-04-18  4:59 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-17 22:07 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3f0a5f17d7fe1f3d0911ad67a5993be59983fb00 ***

Author: Michael Eager <eager@eagercon.com>
Branch: master
Commit: 3f0a5f17d7fe1f3d0911ad67a5993be59983fb00

[MicroBlaze] PIC data text relative

Andrew Sadek <andrew.sadek.se@gmail.com>

A new implemented feature in GCC Microblaze that allows Position
Independent Code to run using Data Text Relative addressing instead
of using Global Offset Table.

Its aim was to make 'PIC' more efficient and flexible as elf size
excess performance overhead were noticed when using GOT due to the
indirect addressing.

include/ChangeLog:
	* bfdlink.h (Add flag): Add new flag @ 'bfd_link_info' struct.
	* elf/microblaze.h (Add 3 new relocations):
	R_MICROBLAZE_TEXTPCREL_64, R_MICROBLAZE_TEXTREL_64
	and R_MICROBLAZE_TEXTREL_32_LO for relax function.
bfd/ChangeLog:
	* bfd/reloc.c (2 new BFD relocations):
	BFD_RELOC_MICROBLAZE_64_TEXTPCREL &
	BFD_RELOC_MICROBLAZE_64_TEXTPCREL
	* bfd/bfd-in2.h: Regenerate
	* bfd/libbfd.h: Regenerate
	* bfd/elf32-microblaze.c (Handle new relocs): define 'HOWTO' of 3
	new relocs and handle them in both relocate and relax functions.
	(microblaze_elf_reloc_type_lookup): add mapping between for new
	bfd relocs.
	(microblaze_elf_relocate_section): Handle new relocs in case of
	elf relocation.
	(microblaze_elf_relax_section): Handle new relocs for elf relaxation.
gas/ChangeLog:
	* gas/config/tc-microblaze.c (Handle new relocs directives in
	assembler): Handle new relocs from compiler output.
	(imm_types): add new imm types for data text relative addressing
	TEXT_OFFSET, TEXT_PC_OFFSET
	(md_convert_frag): conversion for BFD_RELOC_MICROBLAZE_64_TEXTPCREL,
	BFD_RELOC_MICROBLAZE_64_TEXTPCREL
	(md_apply_fix): apply fix for BFD_RELOC_MICROBLAZE_64_TEXTPCREL,
	BFD_RELOC_MICROBLAZE_64_TEXTPCREL
	(md_estimate_size_before_relax): estimate size for
	BFD_RELOC_MICROBLAZE_64_TEXTPCREL,
	BFD_RELOC_MICROBLAZE_64_TEXTPCREL
	(tc_gen_reloc): generate relocations for
	BFD_RELOC_MICROBLAZE_64_TEXTPCREL,
	BFD_RELOC_MICROBLAZE_64_TEXTPCREL
ld/ChangeLog:
	* ld/lexsup.c (Add 2 ld options):
	(ld_options): add disable-multiple-abs-defs @ 'ld_options' array
	(parse_args): parse new option and pass flag to 'link_info' struct.
	* ld/ldlex.h (Add enum): add new enum @ 'option_values' enum.
	* ld/ld.texinfo (Add new option): Add description for
	'disable-multiple-abs-defs'
	* ld/main.c: Initialize flags with false @ 'main'. Handle
	disable-multiple-abs-defs @ 'mutiple_definition'.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] various i386-aout and i386-coff target removal
@ 2018-04-18  0:23 sergiodj+buildbot
  2018-04-18  7:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-18  0:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c65c21e1ffd1e02d9970a4bca0b7e384788a50f0 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: c65c21e1ffd1e02d9970a4bca0b7e384788a50f0

various i386-aout and i386-coff target removal

Also tidies some other aout leftovers in binutils-common.exp.

bfd/
	* Makefile.am: Remove support for assorted i386 aout and coff targets.
	* config.bfd: Likewise.
	* configure.ac: Likewise.
	* doc/bfdint.texi: Likewise.
	* targets.c: Likewise.
	* freebsd.h: Delete.
	* i386dynix.c: Delete.
	* i386freebsd.c: Delete.
	* i386linux.c: Delete.
	* i386mach3.c: Delete.
	* i386netbsd.c: Delete.
	* i386os9k.c: Delete.
	* Makefile.in: Regenerate.
	* configure: Regenerate.
	* po/SRC-POTFILES.in: Regenerate.
binutils/
	* testsuite/lib/binutils-common.exp: Remove support for assorted
	aout targets.
gas/
	* Makefile.am: Remove support for assorted i386 aout and coff targets.
	* config/obj-elf.c: Likewise.
	* config/tc-i386.h: Likewise.
	* configure.ac: Likewise.
	* configure.tgt: Likewise.
	* config/te-dynix.h: Delete.
	* config/te-i386aix.h: Delete.
	* config/te-mach.h: Delete.
	* Makefile.in: Regenerate.
	* config.in: Regenerate.
	* configure: Regenerate.
	* po/POTFILES.in: Regenerate.
include/
	* aout/dynix3.h: Delete.
ld/
	* Makefile.am: Remove support for assorted i386 aout and coff targets.
	* configure.tgt: Likewise.
	* testsuite/ld-discard/discard.exp: Likewise.
	* testsuite/ld-elf/binutils.exp: Likewise.
	* testsuite/ld-elf/tls.exp: Likewise.
	* testsuite/ld-elf/tls_common.exp: Likewise.
	* testsuite/ld-elfvers/vers.exp: Likewise.
	* testsuite/ld-elfvsb/elfvsb.exp: Likewise.
	* testsuite/ld-elfweak/elfweak.exp: Likewise.
	* testsuite/ld-gc/abi-note.d: Likewise.
	* testsuite/ld-gc/pr19167.d: Likewise.
	* testsuite/ld-gc/pr20022.d: Likewise.
	* testsuite/ld-gc/start.d: Likewise.
	* testsuite/ld-gc/stop.d: Likewise.
	* testsuite/ld-i386/i386.exp: Likewise.
	* testsuite/ld-ifunc/binutils.exp: Likewise.
	* testsuite/ld-ifunc/ifunc.exp: Likewise.
	* testsuite/ld-linkonce/linkonce.exp: Likewise.
	* testsuite/ld-plugin/lto.exp: Likewise.
	* testsuite/ld-scripts/empty-address-2a.d: Likewise.
	* testsuite/ld-scripts/empty-address-2b.d: Likewise.
	* testsuite/ld-scripts/phdrs2.exp: Likewise.
	* testsuite/ld-scripts/section-match-1.d: Likewise.
	* testsuite/ld-shared/shared.exp: Likewise.
	* testsuite/ld-size/size.exp: Likewise.
	* testsuite/ld-sparc/sparc.exp: Likewise.
	* emulparams/i386coff.sh: Delete.
	* emulparams/i386linux.sh: Delete.
	* emulparams/i386mach.sh: Delete.
	* emulparams/i386nbsd.sh: Delete.
	* emulparams/vsta.sh: Delete.
	* scripttempl/i386coff.sc: Delete.
	* Makefile.in: Regenerate.
	* po/BLD-POTFILES.in: Regenerate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: Use a normal input file with compatible relocation
@ 2018-04-18  1:33 sergiodj+buildbot
  2018-04-18  9:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-18  1:33 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e4e6a73d26ef82622d3bd190749aad508534abe6 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: e4e6a73d26ef82622d3bd190749aad508534abe6

x86: Use a normal input file with compatible relocation

Use a normal input file with compatible relocation to hold linker
created sections,

	PR ld/23055
	* elfxx-x86.c (_bfd_x86_elf_link_setup_gnu_properties): Use a
	normal input file with compatible relocation.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] elf32_bed/elf64_bed
@ 2018-04-18  2:13 sergiodj+buildbot
  2018-04-18 12:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-18  2:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8f56f7a23911b6a48b372c8f0893343bfe7ed2e9 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 8f56f7a23911b6a48b372c8f0893343bfe7ed2e9

elf32_bed/elf64_bed


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove mips aout, coff, and pe support
@ 2018-04-18  8:44 sergiodj+buildbot
  2018-04-18 14:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-18  8:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3596d8ceb2cdc35b4fd702ee9daace5a2d880174 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 3596d8ceb2cdc35b4fd702ee9daace5a2d880174

Remove mips aout, coff, and pe support

include/coff/mips.h needs to stay for ecoff debug support.

include/
	* coff/mipspe.h: Delete.
bfd/
	* Makefile.am: Remove mips aout, coff, and pe support.
	* config.bfd: Likewise.
	* configure.ac: Likewise.
	* targets.c: Likewise.
	* coff-mips.c: Delete
	* mipsbsd.c: Delete
	* pe-mips.c: Delete
	* pei-mips.c: Delete
	* Makefile.in: Regenerate.
	* configure: Regenerate.
	* po/SRC-POTFILES.in: Regenerate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Commonise tdesc_reg and makes use of it in gdbserver tdesc
@ 2018-04-18 13:20 sergiodj+buildbot
  2018-04-18 16:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-18 13:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ea3e7d717982e3c467edc7886b1d6cc2807195af ***

Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: ea3e7d717982e3c467edc7886b1d6cc2807195af

Commonise tdesc_reg and makes use of it in gdbserver tdesc

gdb/
	* Makefile.in: Add arch/tdesc.c
	* common/tdesc.c: New file.
	* common/tdesc.h (tdesc_element_visitor): Move to here.
	(tdesc_element): Likewise.
	(tdesc_reg): Likewise.
	(tdesc_reg_up): Likewise.
	* regformats/regdef.h (reg): Add offset to constructors.
	* target-descriptions.c (tdesc_element_visitor): Move from here.
	(tdesc_element): Likewise.
	(tdesc_reg): Likewise.
	(tdesc_reg_up): Likewise.

gdbserver/
	* Makefile.in: Add common/tdesc.c
	* tdesc.c (init_target_desc): init all reg_defs from register vector.
	(tdesc_create_reg): Create tdesc_reg.
	* tdesc.h (tdesc_feature): Add register vector.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Commonise tdesc_feature and makes use of it in gdbserver tdesc
@ 2018-04-18 14:07 sergiodj+buildbot
  2018-04-18 18:34 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-18 14:07 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 82ec9bc7055ca76f1f7dd344f3f58bf6aecec7c8 ***

Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: 82ec9bc7055ca76f1f7dd344f3f58bf6aecec7c8

Commonise tdesc_feature and makes use of it in gdbserver tdesc

gdb/
	* common/tdesc.c (tdesc_feature::accept): Move to here.
	(tdesc_feature::operator==): Likewise.
	(tdesc_create_reg): Likewise.
	* common/tdesc.h (tdesc_type_kind): Likewise.
	(struct tdesc_type): Likewise.
	(struct tdesc_feature): Likewise.
	* regformats/regdat.sh: Create a feature.
	* target-descriptions.c (tdesc_type_kind): Move from here.
	(tdesc_type): Likewise.
	(tdesc_type_up): Likewise.
	(tdesc_feature): Likewise.
	(tdesc_create_reg): Likewise.

gdbserver/
	* tdesc.c (~target_desc): Remove implictly deleted items.
	(init_target_desc): Iterate all features.
	(tdesc_get_features_xml): Use vector.
	(tdesc_create_feature): Create feature.
	* tdesc.h (tdesc_feature) Remove
	(target_desc): Add features.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Commonise tdesc types and makes use of them in gdbserver tdesc
@ 2018-04-18 14:34 sergiodj+buildbot
  2018-04-18 20:43 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-18 14:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT eee8a18dd2d4b62ed5e03324b099508717886193 ***

Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: eee8a18dd2d4b62ed5e03324b099508717886193

Commonise tdesc types and makes use of them in gdbserver tdesc

gdb/
	* common/tdesc.c (tdesc_predefined_type): Move to here.
	(tdesc_named_type): Likewise.
	(tdesc_create_vector): Likewise.
	(tdesc_create_struct): Likewise.
	(tdesc_set_struct_size): Likewise.
	(tdesc_create_union): Likewise.
	(tdesc_create_flags): Likewise.
	(tdesc_create_enum): Likewise.
	(tdesc_add_field): Likewise.
	(tdesc_add_typed_bitfield): Likewise.
	(tdesc_add_bitfield): Likewise.
	(tdesc_add_flag): Likewise.
	(tdesc_add_enum_value): Likewise.
	* common/tdesc.h (struct tdesc_type_builtin): Likewise.
	(struct tdesc_type_vector): Likewise.
	(struct tdesc_type_field): Likewise.
	(struct tdesc_type_with_fields): Likewise.
	(tdesc_create_enum): Add declaration.
	(tdesc_add_typed_bitfield): Likewise.
	(tdesc_add_enum_value): Likewise.
	* target-descriptions.c (tdesc_type_field): Move from here.
	(tdesc_type_builtin): Likewise.
	(tdesc_type_vector): Likewise.
	(tdesc_type_with_fields): Likewise.
	(tdesc_predefined_types): Likewise.
	(tdesc_named_type): Likewise.
	(tdesc_create_vector): Likewise.
	(tdesc_create_struct): Likewise.
	(tdesc_set_struct_size): Likewise.
	(tdesc_create_union): Likewise.
	(tdesc_create_flags): Likewise.
	(tdesc_create_enum): Likewise.
	(tdesc_add_field): Likewise.
	(tdesc_add_typed_bitfield): Likewise.
	(tdesc_add_bitfield): Likewise.
	(tdesc_add_flag): Likewise.
	(tdesc_add_enum_value): Likewise.
	* gdb/target-descriptions.h (tdesc_create_enum): Likewise.
	(tdesc_add_typed_bitfield): Likewise.
	(tdesc_add_enum_value): Likewise.

gdbserver/
	* tdesc.c (tdesc_create_flags): Remove.
	(tdesc_add_flag): Likewise.
	(tdesc_named_type): Likewise.
	(tdesc_create_union): Likewise.
	(tdesc_create_struct): Likewise.
	(tdesc_create_vector): Likewise.
	(tdesc_add_bitfield): Likewise.
	(tdesc_add_field): Likewise.
	(tdesc_set_struct_size): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add tdesc osabi and architecture functions
@ 2018-04-18 15:15 sergiodj+buildbot
  2018-04-19  0:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-18 15:15 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d278f585afe8e096e9232b8fd80404ab5fae5719 ***

Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: d278f585afe8e096e9232b8fd80404ab5fae5719

Add tdesc osabi and architecture functions

gdb/
	* common/tdesc.h (tdesc_architecture_name): Add new declaration.
	(tdesc_osabi_name): Likewise.
	* target-descriptions.c (tdesc_architecture_name): Add new function.
	(tdesc_osabi_name): Likewise.

gdbserver/
	* tdesc.c (tdesc_architecture_name): Add new function.
	(tdesc_osabi_name): Likewise.
	(tdesc_get_features_xml): Use new functions.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add feature reference in .dat files
@ 2018-04-18 20:22 sergiodj+buildbot
  2018-04-19  5:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-18 20:22 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ad7fc756d12a841d4b8dd707568426d875e26755 ***

Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: ad7fc756d12a841d4b8dd707568426d875e26755

Add feature reference in .dat files

For all targets which use the newer style target descriptions, add a
"feature" marker in the dat files.
Update regdat.sh to parse feature, but do not use it (yet).

gdb/
	* features/Makefile: Add feature marker to targets with new style
	target descriptions.
	* regformats/aarch64.dat: Regenerate.
	* regformats/i386/amd64-avx-avx512-linux.dat: Likewise.
	* regformats/i386/amd64-avx-linux.dat: Likewise.
	* regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Likewise.
	* regformats/i386/amd64-avx-mpx-linux.dat: Likewise.
	* regformats/i386/amd64-linux.dat: Likewise.
	* regformats/i386/amd64-mpx-linux.dat: Likewise.
	* regformats/i386/amd64.dat: Likewise.
	* regformats/i386/i386-avx-avx512-linux.dat: Likewise.
	* regformats/i386/i386-avx-linux.dat: Likewise.
	* regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Likewise.
	* regformats/i386/i386-avx-mpx-linux.dat: Likewise.
	* regformats/i386/i386-linux.dat: Likewise.
	* regformats/i386/i386-mmx-linux.dat: Likewise.
	* regformats/i386/i386-mpx-linux.dat: Likewise.
	* regformats/i386/i386.dat: Likewise.
	* regformats/i386/x32-avx-avx512-linux.dat: Likewise.
	* regformats/i386/x32-avx-linux.dat: Likewise.
	* regformats/i386/x32-linux.dat: Likewise.
	* regformats/tic6x-c62x-linux.dat: Likewise.
	* regformats/tic6x-c64x-linux.dat: Likewise.
	* regformats/tic6x-c64xp-linux.dat: Likewise.
	* regformats/regdat.sh: Parse feature marker.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Create xml from target descriptions
@ 2018-04-18 20:43 sergiodj+buildbot
  2018-04-19  7:30 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-18 20:43 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e98577a9dc4da048ded601920dc6471dcab375aa ***

Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: e98577a9dc4da048ded601920dc6471dcab375aa

Create xml from target descriptions

Add a print_xml_feature visitor class which turns a
target description into xml. Both gdb and gdbserver can do this.

gdb/
	* common/tdesc.c (print_xml_feature::visit_pre): Add xml parsing.
	(print_xml_feature::visit_post): Likewise.
	(print_xml_feature::visit): Likewise.
	* common/tdesc.h (tdesc_get_features_xml): Use const tdesc.
	(print_xml_feature): Add new class.
	* regformats/regdat.sh: Null xmltarget on feature targets.
	* target-descriptions.c (struct target_desc): Add xmltarget.
	(maintenance_check_tdesc_xml_convert): Add unittest function.
	(tdesc_get_features_xml): Add function to get xml.
	(maintenance_check_xml_descriptions): Test xml generation.
	* xml-tdesc.c (string_read_description_xml): Add function.
	* xml-tdesc.h (string_read_description_xml): Add declaration.

gdbserver/
	* gdb/gdbserver/server.c (get_features_xml): Remove cast.
	* tdesc.c (void target_desc::accept): Fill in function.
	(tdesc_get_features_xml): Remove old xml creation.
	(print_xml_feature::visit_pre): Add xml vistor.
	* tdesc.h (struct target_desc): Make xmltarget mutable.
	(tdesc_get_features_xml): Remove declaration.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove xml file references from target descriptions
@ 2018-04-18 21:02 sergiodj+buildbot
  2018-04-19 11:53 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-18 21:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3b74854b8db5836707af828b256c1322a71241b3 ***

Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: 3b74854b8db5836707af828b256c1322a71241b3

Remove xml file references from target descriptions

gdb/
	* common/tdesc.h (tdesc_create_feature): Remove xml filename
	parameter.
	* features/aarch64-core.c (create_feature_aarch64_core):
	Regenerate.
	* features/aarch64-fpu.c (create_feature_aarch64_fpu):
	Likewise.
	* features/i386/32bit-avx.c (create_feature_i386_32bit_avx):
	Likewise.
	* features/i386/32bit-avx512.c
	(create_feature_i386_32bit_avx512): Likewise.
	* features/i386/32bit-core.c (create_feature_i386_32bit_core):
	Likewise.
	* features/i386/32bit-linux.c (create_feature_i386_32bit_linux):
	Likewise.
	* features/i386/32bit-mpx.c (create_feature_i386_32bit_mpx):
	Likewise.
	* features/i386/32bit-pkeys.c (create_feature_i386_32bit_pkeys):
	Likewise.
	* features/i386/32bit-sse.c (create_feature_i386_32bit_sse):
	Likewise.
	* features/i386/64bit-avx.c (create_feature_i386_64bit_avx):
	Likewise.
	* features/i386/64bit-avx512.c
	(create_feature_i386_64bit_avx512): Likewise.
	* features/i386/64bit-core.c (create_feature_i386_64bit_core):
	Likewise.
	* features/i386/64bit-linux.c (create_feature_i386_64bit_linux):
	Likewise.
	* features/i386/64bit-mpx.c (create_feature_i386_64bit_mpx):
	Likewise.
	* features/i386/64bit-pkeys.c (create_feature_i386_64bit_pkeys):
	Likewise.
	* features/i386/64bit-segments.c
	(create_feature_i386_64bit_segments): Likewise.
	* features/i386/64bit-sse.c (create_feature_i386_64bit_sse):
	Likewise.
	* features/i386/x32-core.c
	(create_feature_i386_x32_core): Likewise.
	* features/tic6x-c6xp.c (create_feature_tic6x_c6xp): Likewise.
	* features/tic6x-core.c (create_feature_tic6x_core): Likewise.
	* features/tic6x-gp.c (create_feature_tic6x_gp): Likewise.
	* target-descriptions.c: In generated code, don't pass xml
	filename.

gdbserver/
	* tdesc.c: Remove xml parameter.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove xml files from gdbserver
@ 2018-04-18 21:46 sergiodj+buildbot
  2018-04-19 13:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-18 21:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b319b0984b505e9a5e653c3da8ae7d5af76c8f28 ***

Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: b319b0984b505e9a5e653c3da8ae7d5af76c8f28

Remove xml files from gdbserver

For ports which use new target descriptions, remove
the xml files from being built into gdbserver.

gdbserver/
	* configure.srv (aarch64*-*-linux*): Don't include xml.
	(i[34567]86-*-cygwin*): Likewise.
	(i[34567]86-*-linux*): Likewise.
	(i[34567]86-*-lynxos*): Likewise.
	(i[34567]86-*-mingw32ce*): Likewise.
	(i[34567]86-*-mingw*): Likewise.
	(i[34567]86-*-nto*): Likewise.
	(tic6x-*-uclinux): Likewise.
	(x86_64-*-linux*): Likewise.
	(x86_64-*-mingw*): Likewise.
	(x86_64-*-cygwin*): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Reinstate mips ecoff support
@ 2018-04-19  0:40 sergiodj+buildbot
  2018-04-19 15:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-19  0:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8e415ce8fee234cd86f29d8f4ebbbdf0f9c0b031 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 8e415ce8fee234cd86f29d8f4ebbbdf0f9c0b031

Reinstate mips ecoff support

	* Makefile.am: Revert 2018-04-18 coff-mips changes.
	* config.bfd: Add back mips_ecoff_le_vec and mips_ecoff_be_vec
	to selvecs for mips targets change 2018-04-18.
	* configure.ac: Reinstate mips_ecoff_le_vec, mips_ecoff_be_vec
	and  mips_ecoff_bele_vec.
	* targets.c: Likewise.
	* coff-mips.c: Resurrect.
	* Makefile.in: Regenerate.
	* configure: Regenerate.
	* po/SRC-POTFILES.in: Regenerate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PR22537, Segmentation fault with static PIE
@ 2018-04-19  6:29 sergiodj+buildbot
  2018-04-19 17:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-19  6:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f6a8b8c7ac2d5369070a6b76a94ee0f3052433ff ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: f6a8b8c7ac2d5369070a6b76a94ee0f3052433ff

PR22537, Segmentation fault with static PIE

The only stub type that makes sense for undefined symbols, or those
defined in shared libraries, is a plt call stub.  This patch arranges
to have "destination" set to -1 on such symbols, making for an easy
test in hppa_type_of_stub.

	PR 22537
	* elf32-hppa.c (elf32_hppa_size_stubs): Init "destination" to -1.
	(hppa_type_of_stub): Don't return a long branch stub for
	symbols other than those defined statically.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix dependency tracking in gdbserver subdirectories
@ 2018-04-19 17:40 sergiodj+buildbot
  2018-04-19 21:34 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-19 17:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f31c089e788f7b45c9030ac399cd34eb3ccdb9c1 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: f31c089e788f7b45c9030ac399cd34eb3ccdb9c1

Fix dependency tracking in gdbserver subdirectories

The dependency tracking (the thing that knows which source file included
which other source file during last build to know what to rebuild when
an included file changes) is broken for gdbserver subdirectories (arch
and common).

The dependency tracking files are created in the form

  arch/.deps/i386.Po

but we try to include

  .deps/arch/i386.Po

An easy smoke test is too "touch" the gdb/features/i386/32bit-core.c
file in the source directory and try to rebuild gdbserver.  This file is
included by gdb/arch/i386.c, so it should cause
gdb/gdbserver/arch/i386.o in the build directory to be rebuilt.  It
currently isn't rebuilt, but is with this patch applied.

This patch copies the technique used in GDB to transform the dep file
paths to the proper form.

Also, while testing using the depcomp method of dependency tracking (by
just hacking the condition), I noticed that depcomp was not found.  The
path to depcomp seems to be missing a "..".

gdb/gdbserver/ChangeLog:

	* Makefile.in (depcomp): Add "..".
	(all_deps_files): New and use it.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [OB PATCH] Fix some comments in thread.c
@ 2018-04-19 22:02 sergiodj+buildbot
  2018-04-19 22:22 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-19 22:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 224608c3ca1575bcbea82562f05d3fdd0390abcf ***

Author: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Branch: master
Commit: 224608c3ca1575bcbea82562f05d3fdd0390abcf

[OB PATCH] Fix some comments in thread.c

Fix some typos.
Remove obsolete comment about dispatch to thread_apply_command,
rather tell that thread_command either switches to a thread,
or prints the current thread.

2018-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

	* thread.c (thread_apply_all_command): Fix comment.
	(thread_command): Fix comment.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add test case for a known hang in infrun
@ 2018-04-20  3:25 sergiodj+buildbot
  2018-04-20  3:53 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-20  3:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d27d16bfdc3f275b379793214db9bd9467b6f0f8 ***

Author: Richard Bunt <richard.bunt@arm.com>
Branch: master
Commit: d27d16bfdc3f275b379793214db9bd9467b6f0f8

Add test case for a known hang in infrun

The hang occurs when GDB tries to call inferior functions on two
different threads with scheduler-locking turned on. The first call works
fine, with the call to infrun_async(1) causing the signal_handler to be
marked and the event to be handled, but then the event loop resets the
"ready" member to zero, while leaving infrun_is_async set to 1. As a
result, GDB hangs if the user switches to another thread and calls a
second function because calling infrun_async(1) a second time has no
effect, meaning the inferior call events are never handled.

The added test case provokes the above issue.

gdb/testsuite/ChangeLog:

	* gdb.threads/multiple-successive-infcall.c: New test.
	* gdb.threads/multiple-successive-infcall.exp: New file.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PR22978, TLS local-dynamic incorrectly linked on hppa-linux
@ 2018-04-20 14:09 sergiodj+buildbot
  2018-04-20 14:39 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-20 14:09 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4352556b36ab4f1c6f81a0ac3daf4619a419558d ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 4352556b36ab4f1c6f81a0ac3daf4619a419558d

PR22978, TLS local-dynamic incorrectly linked on hppa-linux

We were emitting dynamic relocs on the second word of a TLS GD GOT
entry pair (the dtprel offset), without the addend necessary when no
symbol is present on the dynamic reloc.  Unfortunately the simple
solution of providing the proper addend doesn't work due to an hppa
glibc ld.so bug that ignores such addends.  So instead optimize the
relocs.  The dtprel offset is known at link time for locally defined
symbols (the only case where we'll end up with no symbol on a dynamic
reloc) so we can omit the dynamic reloc in that case.

Furthermore, we can omit a dynamic reloc on the first word of a TLS GD
GOT entry pair (the module id) if the symbol is local and we are
producing an executable.  Similarly, a tprel reloc on a TLS IE GOT
entry is not needed for local symbols in an executable.  So the
condition for TLS GOT relocs can become bfd_link_dll(info) rather than
bfd_link_pic(info) as needed for normal GOT relocs.

This all presumes hppa ld.so doesn't need to differentiate TLS GD GOT
pairs from TLS LD GOT pairs, which is currently true.

	PR 22978
	* elf32-hppa.c (got_relocs_needed): Add extra param to special
	case both dtprel and tprel relocs.
	(allocate_dynrelocs): Adjust conditions for got relocs.
	(elf32_hppa_relocate_section): Likewise for local sym got relocs.
	Emit dynamic relocs on TLS GOT entries for shared libraries,
	not when pic.  Omit dynamic reloc on dtprel entry when local,
	and on tprel entry when local and executable.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Improve on-line help for thread_apply_command and thread_apply_all_command.
@ 2018-04-20 21:47 sergiodj+buildbot
  2018-04-20 22:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-20 21:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5c8f23cdab2a7cde2dae6fcd5f9b18d089efecaf ***

Author: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Branch: master
Commit: 5c8f23cdab2a7cde2dae6fcd5f9b18d089efecaf

Improve on-line help for thread_apply_command and thread_apply_all_command.

Add a Usage: line for thread_apply_command, in particular to mention
the thread ID list.

In thread_apply_command and thread_apply_all_command help, use
uppercase for arg names, as this style seems to be more standard.

2018-04-20  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

	* thread.c (_initialize_thread): improve on-line help for
	thread_apply_command and thread_apply_all_command.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] FreeBSD: Fix 'Couldn't get registers: Device busy' error (PR gdb/23077)
@ 2018-04-21 18:17 sergiodj+buildbot
  2018-04-21 18:58 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-21 18:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 00aecdcf6224e44fedf31a07340e9da11500fcfb ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 00aecdcf6224e44fedf31a07340e9da11500fcfb

FreeBSD: Fix 'Couldn't get registers: Device busy' error (PR gdb/23077)

As Rajendra SY reported at
<https://sourceware.org/ml/gdb-patches/2018-04/msg00399.html>, several
attach-related tests are failing on FreeBSD.  The "attach" command
errors with "Couldn't get registers: Device busy".

When the "attach" command is executed, it calls target_attach ->
inf_ptrace_attach, which just does the ptrace(PT_ATTACH), it does not
wait for the child to stop with SIGSTOP.  Afterwards, the command is
complete and we go back to the event loop.  The event loop wakes up
and we end up in target_wait -> fbsd_wait, and handle the SIGSTOP
stop.

At the end of execute_command, though, before going back to the event
loop, we check if the frame language changed via
check_frame_language_change().  That reads the current PC, which is
what leads to the registers read that fails.

The problem is that we fail to mark the attached-to thread as
executing between the initial attach, and the subsequent target_wait.
Until we see the thread stop with SIGSTOP, we shouldn't try to read
registers off of it.  I guess there may a timing issue here - if
you're "lucky", the thread may stop before gdb reads its registers,
masking the problem.

With that fixed, check_frame_language_change() becomes a nop until the
thread is marked not-executing again, after target_wait is called and
we go through handle_inferior_event -> normal_stop.

We haven't seen the problem on Linux because there, the target_attach
implementation waits for the thread to stop before returning.  Still,
that's supposedly hidden from the core, since the Linux target, like
most targets, is a '!to_attach_no_wait' target.

This fixes:
 FAIL: gdb.base/attach.exp: attach1, after setting file
 FAIL: gdb.base/attach.exp: attach2, with no file
 FAIL: gdb.base/attach.exp: load file manually, after attach2 (re-read) (got interactive prompt)
 FAIL: gdb.base/attach.exp: attach when process' a.out not in cwd

 FAIL: gdb.base/dprintf-detach.exp: bai=on ds=gdb dd=on: re-attach to inferior
 FAIL: gdb.base/dprintf-detach.exp: bai=on ds=gdb dd=off: re-attach to inferior
 FAIL: gdb.base/dprintf-detach.exp: bai=on ds=call dd=on: re-attach to inferior
 FAIL: gdb.base/dprintf-detach.exp: bai=on ds=call dd=off: re-attach to inferior
 FAIL: gdb.base/dprintf-detach.exp: bai=on ds=agent dd=on: re-attach to inferior
 FAIL: gdb.base/dprintf-detach.exp: bai=on ds=agent dd=off: re-attach to inferior
 FAIL: gdb.base/dprintf-detach.exp: bai=off ds=gdb dd=on: re-attach to inferior
 FAIL: gdb.base/dprintf-detach.exp: bai=off ds=gdb dd=off: re-attach to inferior
 FAIL: gdb.base/dprintf-detach.exp: bai=off ds=call dd=on: re-attach to inferior
 FAIL: gdb.base/dprintf-detach.exp: bai=off ds=call dd=off: re-attach to inferior
 FAIL: gdb.base/dprintf-detach.exp: bai=off ds=agent dd=on: re-attach to inferior
 FAIL: gdb.base/dprintf-detach.exp: bai=off ds=agent dd=off: re-attach to inferior

gdb/ChangeLog:
2018-04-21  Pedro Alves  <palves@redhat.com>
	    Rajendra SY  <rajendra.sy@gmail.com>

	* inf-ptrace.c (inf_ptrace_attach): Mark the thread as executing.
	* remote.c (extended_remote_attach): In all-stop mode, mark the
	thread as executing.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fixed test case to compile & run on FreeBSD
@ 2018-04-22 22:41 sergiodj+buildbot
  2018-04-22 23:14 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-22 22:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT db86b02b3ac8426f3fc0754f48f3645235cc2ae6 ***

Author: Rajendra SY <rajendra.sy@gmail.com>
Branch: master
Commit: db86b02b3ac8426f3fc0754f48f3645235cc2ae6

Fixed test case to compile & run on FreeBSD

Problems:
1. linking -dl lib on FreeBSD platform
2. backtrace from ld-elf shows r_debug_state() instead of _dl_debug_state()

Cause:
1. There is no dl library on FreeBSD platform test has to ignore linking "-ldl"
2. The stop due to a shared library event shows backtrace frame #0
   function as r_debug_state()

gdb/ChangeLog:

	PR gdb/23095
	* gdb/testsuite/gdb.base/break-probes.exp: Pass shlib_load to
	prepare_for_testing.  Set normal_bp to r_debug_state if target
	is bsd.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Silence gcc-8 warnings
@ 2018-04-23  9:10 sergiodj+buildbot
  2018-04-23  9:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-23  9:10 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5a6312e8c015d4a98020038f3b6e144db230f3ca ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 5a6312e8c015d4a98020038f3b6e144db230f3ca

Silence gcc-8 warnings

All of these warnings were false positives.  -Wstringop-truncation is
particularly annoying when it warns about strncpy used quite correctly.

bfd/
	* elf-linux-core.h (swap_linux_prpsinfo32_ugid32_out): Disable
	gcc-8 string truncation warning.
	(swap_linux_prpsinfo32_ugid16_out): Likewise.
	(swap_linux_prpsinfo64_ugid32_out): Likewise.
	(swap_linux_prpsinfo64_ugid16_out): Likewise.
	* elf.c (elfcore_write_prpsinfo): Likewise.
gas/
	* stabs.c (generate_asm_file): Use memcpy rather than strncpy.
	Remove call to strlen inside loop.
	* config/tc-cr16.c (getreg_image): Warning fix.
	* config/tc-crx.c (getreg_image): Warning fix.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Prevent an illegal memory access in gprof by ensuring that string tables for aout format files are always zero-terminated.
@ 2018-04-23 12:15 sergiodj+buildbot
  2018-04-23 12:43 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-23 12:15 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bf82069dce1b1a88560e5d7320342c78372b627e ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: bf82069dce1b1a88560e5d7320342c78372b627e

Prevent an illegal memory access in gprof by ensuring that string tables for aout format files are always zero-terminated.

	PR 23056
	* aoutx.h (aout_get_external_symbols): Allocate an extra byte at
	the end of the string table, and zero it.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Revert bfd part of "Silence gcc-8 warnings"
@ 2018-04-23 14:42 sergiodj+buildbot
  2018-04-23 15:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-23 14:42 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b9f26d2e29bb56a0404216c5612d6d7fee54a769 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: b9f26d2e29bb56a0404216c5612d6d7fee54a769

Revert bfd part of "Silence gcc-8 warnings"

The gcc warning has been fixed, and the patch regressed builds with
some older versions of gcc.

	* elf-linux-core.h: Revert last change.
	* elf.c: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Regenerate gdb/configure and gdbserver/configure
@ 2018-04-23 15:50 sergiodj+buildbot
  2018-04-24  0:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-23 15:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 458412c36845f20bcfef47eef3005fb2054a7695 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 458412c36845f20bcfef47eef3005fb2054a7695

Regenerate gdb/configure and gdbserver/configure

Pedro pointed out that gdb/configure and gdbserver/configure weren't
updated after some recent *.m4 changes.

This patch rebuilds those files.  Tested by rebuilding.  Pedro
approved this in the thread where he raised this issue, so I'm pushing
it in.

ChangeLog
2018-04-23  Tom Tromey  <tom@tromey.com>

	* configure: Rebuild.

gdbserver/ChangeLog
2018-04-23  Tom Tromey  <tom@tromey.com>

	* configure: Rebuild.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove a cleanup from scm-frame.c
@ 2018-04-24  0:19 sergiodj+buildbot
  2018-04-24  0:44 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-24  0:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a95c7daba4c74e61ac37ffaaaa0ba49bf16e474e ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: a95c7daba4c74e61ac37ffaaaa0ba49bf16e474e

Remove a cleanup from scm-frame.c

This removes a cleanup from scm-frame.c, replacing it with
unique_xmalloc_ptr and a new scope.  I believe this also fixes a
latent bug involving calling do_cleanups twice for a single cleanup.

Regression tested using the gdb.guile test suite on x86-64 Fedora 26.

ChangeLog
2018-04-23  Tom Tromey  <tom@tromey.com>

	* guile/scm-frame.c (gdbscm_frame_read_var): Use
	gdb::unique_xmalloc_ptr.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove cli_ui_out::out_field_fmt
@ 2018-04-24 13:56 sergiodj+buildbot
  2018-04-24 14:28 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-24 13:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 05b1d8d6fcde4805d25c9121f5b051f59580887a ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 05b1d8d6fcde4805d25c9121f5b051f59580887a

Remove cli_ui_out::out_field_fmt

I noticed that cli_ui_out::out_field_fmt is only used by a single
caller, and it can easily be replaced by fputs_filtered.  So, this
patch removes it.

ChangeLog
2018-04-24  Tom Tromey  <tom@tromey.com>

	* cli-out.c (cli_ui_out::out_field_fmt): Remove.
	(cli_ui_out::do_field_string): Use fputs_filtered.
	* cli-out.h (class cli_ui_out) <out_field_fmt>: Remove.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Reindent cli-out.h
@ 2018-04-24 14:45 sergiodj+buildbot
  2018-04-24 16:34 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-24 14:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e427af1889e6d169c3390f6960f1efdd08dca883 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: e427af1889e6d169c3390f6960f1efdd08dca883

Reindent cli-out.h

I noticed that cli-out.h had incorrect indentation in some spots.
This fixes it.

ChangeLog
2018-04-24  Tom Tromey  <tom@tromey.com>

	* cli-out.h: Reindent.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] info-shared.exp: Replace libs=-ldl with shlib_load
@ 2018-04-24 15:09 sergiodj+buildbot
  2018-04-24 19:14 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-24 15:09 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0a8ddac418d3e8e12a1bb51c3b0da90155f83403 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 0a8ddac418d3e8e12a1bb51c3b0da90155f83403

info-shared.exp: Replace libs=-ldl with shlib_load

As reported in PR 23104, -ldl doesn't work on FreeBSD.  Replace it with
shlib_load, which adds the right flags for dynamic library loading based
on the current target platform.

The test still passes on Linux, and should now pass on FreeBSD, though I
did not test personally.

gdb/testsuite/ChangeLog:

	PR gdb/23104
	* gdb.base/info-shared.exp: Replace libs=-ldl with shlib_load.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix an illegal memory access when copying a PE format file with corrupt debug information.
@ 2018-04-24 16:07 sergiodj+buildbot
  2018-04-24 21:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-24 16:07 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT aa4a8c2a2a67545e90c877162c53cc9de42dc8b4 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: aa4a8c2a2a67545e90c877162c53cc9de42dc8b4

Fix an illegal memory access when copying a PE format file with corrupt debug information.

	PR 23110
	* peXXigen.c (_bfd_XX_bfd_copy_private_bfd_data_common): Check for
	a negative PE_DEBUG_DATA size before iterating over the debug data.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix an illegal memory access when trying to copy an ELF binary with corrupt section symbols.
@ 2018-04-24 16:26 sergiodj+buildbot
  2018-04-25  0:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-24 16:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT db0c309f4011ca94a4abc8458e27f3734dab92ac ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: db0c309f4011ca94a4abc8458e27f3734dab92ac

Fix an illegal memory access when trying to copy an ELF binary with corrupt section symbols.

	PR 23113
	* elf.c (ignore_section_sym): Check for the output_section pointer
	being NULL before dereferencing it.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Enable 'set print inferior-events' and improve detach/fork/kill/exit messages
@ 2018-04-24 20:07 sergiodj+buildbot
  2018-04-25  3:59 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-24 20:07 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f67c0c9171508672167b6868c67211571421a1c6 ***

Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: f67c0c9171508672167b6868c67211571421a1c6

Enable 'set print inferior-events' and improve detach/fork/kill/exit messages

This patch aims to turn 'set print inferior-events' always on, and do
some cleanup on the messages printed by GDB when various inferior
events happen (attach, detach, fork, kill, exit).

To make sure that the patch is correct, I've tested it with a handful
of combinations of 'set follow-fork-mode', 'set detach-on-fork' and
'set print inferior-events'.  In the end, I decided to make my
hand-made test into an official testcase.  More on that below.

Using the following program as an example:

  #include <unistd.h>
  int main ()
  {
    fork ();
    return 0;
  }

We see the following outputs from the patched GDB:

- With 'set print inferior-events on':

    (gdb) r
    Starting program: a.out
    [Detaching after fork from child process 27749]
    [Inferior 1 (process 27745) exited normally]
    (gdb)

- With 'set print inferior-events off':

    (gdb) r
    Starting program: a.out
    [Inferior 1 (process 27823) exited normally]
    (gdb)

  Comparing this against an unpatched GDB:

- With 'set print inferior-events off' and 'set follow-fork-mode
  child':

    (gdb) r
    Starting program: a.out
    [Inferior 2 (process 5993) exited normally]
    (gdb)

  Compare this against an unpatched GDB:

    (unpatched-gdb) r
    Starting program: a.out
    [New process 5702]
    [Inferior 2 (process 5702) exited normally]
    (unpatched-gdb)

  It is possible to notice that, in this scenario, the patched GDB
  will lose the '[New process %d]' message.

- With 'set print inferior-events on', 'set follow-fork-mode child'
  and 'set detach-on-fork on':

    (gdb) r
    Starting program: a.out
    [Attaching after process 27905 fork to child process 27909]
    [New inferior 2 (process 27909)]
    [Detaching after fork from parent process 27905]
    [Inferior 1 (process 27905) detached]
    [Inferior 2 (process 27909) exited normally]
    (gdb)

  Compare this output with an unpatched GDB, using the same settings:

    (unpatched-gdb) r
    Starting program: a.out
    [New inferior 28033]
    [Inferior 28029 detached]
    [New process 28033]
    [Inferior 2 (process 28033) exited normally]
    [Inferior 28033 exited]
    (unpatched-gdb)

As can be seen above, I've also made a few modifications to messages
that are printed when 'set print inferior-events' is on.  For example,
a few of the messages did not contain the '[' and ']' as
prefix/suffix, which led to a few inconsistencies like:

  Attaching after process 22995 fork to child process 22999.
  [New inferior 22999]
  Detaching after fork from child process 22999.
  [Inferior 22995 detached]
  [Inferior 2 (process 22999) exited normally]

So I took the opportunity and included the square brackets where
applicable.  I have also made the existing messages more uniform, by
always printing "Inferior %d (process %d)..." where applicable.  This
makes it easier to identify the inferior number and the PID number
from the messages.

As suggested by Pedro, the "[Inferior %d exited]" message from
'exit_inferior' has been removed, because it got duplicated when
'inferior-events' is on.  I'm also using the
'add_{thread,inferior}_silent' versions (instead of their verbose
counterparts) on some locations, also to avoid duplicated messages.
For example, a patched GDB with 'set print inferior-events on', 'set
detach-on-fork on' and 'set follow-fork-mode child', but using
'add_thread', would print:

  (gdb) run
  Starting program: a.out
  [Attaching after process 25088 fork to child process 25092.]
  [New inferior 25092]   <--- duplicated
  [Detaching after fork from child process 25092.]
  [Inferior 25088 detached]
  [New process 25092]    <--- duplicated
  [Inferior 2 (process 25092) exited normally]

But if we use 'add_thread_silent' (with the same configuration as
before):

  (gdb) run
  Starting program: a.out
  [Attaching after process 31606 fork to child process 31610]
  [New inferior 2 (process 31610)]
  [Detaching after fork from parent process 31606]
  [Inferior 1 (process 31606) detached]
  [Inferior 2 (process 31610) exited normally]

As for the tests, the configuration options being exercised are:

- follow-fork-mode: child/parent
- detach-on-fork: on/off
- print inferior-events: on/off

It was also necessary to perform adjustments on several testcases,
because the expected messages changed considerably.

Built and regtested on BuildBot, without regressions.

gdb/ChangeLog:
2018-04-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
	    Sergio Durigan Junior  <sergiodj@redhat.com>
	    Pedro Alves  <palves@redhat.com>

	* infcmd.c (kill_command): Print message when inferior has
	been killed.
	* inferior.c (print_inferior_events): Remove 'static'.  Set as
	'1'.
	(add_inferior): Improve message printed when
	'print_inferior_events' is on.
	(exit_inferior): Remove message printed when
	'print_inferior_events' is on.
	(detach_inferior): Improve message printed when
	'print_inferior_events' is on.
	(initialize_inferiors): Use 'add_inferior_silent' to set
	'current_inferior_'.
	* inferior.h (print_inferior_events): Declare here as
	'extern'.
	* infrun.c (follow_fork_inferior): Print '[Attaching...]' or
	'[Detaching...]' messages when 'print_inferior_events' is on.
	Use 'add_thread_silent' instead of 'add_thread'.  Add '[' and ']'
	as prefix/suffix for messages.  Remove periods.  Fix erroneous
	'Detaching after fork from child...', replace it by '... from
	parent...'.
	(handle_vfork_child_exec_or_exit): Add '[' and ']' as
	prefix/suffix when printing 'Detaching...' messages.  Print
	them when 'print_inferior_events' is on.
	* remote.c (remote_detach_1): Print message when detaching
	from inferior and '!is_fork_parent'.

gdb/testsuite/ChangeLog:
2018-04-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
	    Sergio Durigan Junior  <sergiodj@redhat.com>
	    Pedro Alves  <palves@redhat.com>

	* gdb.base/attach-non-pgrp-leader.exp: Adjust 'Detaching...'
	regexps to expect for '[Inferior ... detached]' as well.
	* gdb.base/attach.exp: Likewise.
	* gdb.base/catch-syscall.exp (check_for_program_end): Adjust
	"gdb_continue_to_end".
	(test_catch_syscall_with_wrong_args): Likewise.
	* gdb.base/foll-fork.exp: Adjust regexps to match '[' and
	']'.  Don't set 'verbose' on.
	* gdb.base/foll-vfork.exp: Likewise.
	* gdb.base/fork-print-inferior-events.c: New file.
	* gdb.base/fork-print-inferior-events.exp: New file.
	* gdb.base/hook-stop.exp: Adjust regexps to expect for new
	'[Inferior ... has been killed]' message.
	* gdb.base/kill-after-signal.exp: Likewise.
	* gdb.base/solib-overlap.exp: Adjust regexps to expect for new
	detach message.
	* gdb.threads/kill.exp: Adjust regexps to expect for new kill
	message.
	* gdb.threads/clone-attach-detach.exp: Adjust 'Detaching...'
	regexps to expect for '[Inferior ... detached]' as well.
	* gdb.threads/process-dies-while-detaching.exp: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove arm-aout and arm-coff support
@ 2018-04-25  0:47 sergiodj+buildbot
  2018-04-25  4:42 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-25  0:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2ac93be706418f3b2aebeb22159a328023faed52 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 2ac93be706418f3b2aebeb22159a328023faed52

Remove arm-aout and arm-coff support

This also removes arm-netbsd (not arm-netbsdelf!), arm-openbsd, and
arm-riscix.  Those targets weren't on the obsolete list but they are
all aout, and it doesn't make all that much sense to remove arm-aout
without removing them too.

bfd/
	* Makefile.am: Remove arm-aout and arm-coff support.
	* config.bfd: Likewise.
	* configure.ac: Likewise.
	* targets.c: Likewise.
	* aout-arm.c: Delete.
	* armnetbsd.c: Delete.
	* riscix.c: Delete.
	* Makefile.in: Regenerate.
	* configure: Regenerate.
	* po/SRC-POTFILES.in: Regenerate.
binutils/
	* testsuite/binutils-all/arm/objdump.exp: Remove arm-aout and
	arm-coff support.
	* testsuite/binutils-all/objcopy.exp: Likewise.
	* testsuite/lib/binutils-common.exp: Likewise.
gas/
	* Makefile.am: Remove arm-aout and arm-coff support.
	* config/tc-arm.c: Likewise.
	* config/tc-arm.h: Likewise.
	* configure.tgt: Likewise.
	* testsuite/gas/aarch64/codealign.d: Likewise.
	* testsuite/gas/aarch64/mapping.d: Likewise.
	* testsuite/gas/aarch64/mapping2.d: Likewise.
	* testsuite/gas/arm/adds-thumb1-reloc-local-armv7-m.d: Likewise.
	* testsuite/gas/arm/adds-thumb1-reloc-local.d: Likewise.
	* testsuite/gas/arm/addsw-bad.d: Likewise.
	* testsuite/gas/arm/align.d: Likewise.
	* testsuite/gas/arm/align64.d: Likewise.
	* testsuite/gas/arm/arch7.d: Likewise.
	* testsuite/gas/arm/arch7a-mp.d: Likewise.
	* testsuite/gas/arm/arch7em.d: Likewise.
	* testsuite/gas/arm/archv8m-main-dsp-5.d: Likewise.
	* testsuite/gas/arm/arm-it-auto-2.d: Likewise.
	* testsuite/gas/arm/arm-it-auto-3.d: Likewise.
	* testsuite/gas/arm/arm-it-auto.d: Likewise.
	* testsuite/gas/arm/arm-it-bad-2.d: Likewise.
	* testsuite/gas/arm/arm-it.d: Likewise.
	* testsuite/gas/arm/armv7e-m+fpv5-d16.d: Likewise.
	* testsuite/gas/arm/armv7e-m+fpv5-sp-d16.d: Likewise.
	* testsuite/gas/arm/armv8-2-fp16-scalar-thumb.d: Likewise.
	* testsuite/gas/arm/armv8-2-fp16-scalar.d: Likewise.
	* testsuite/gas/arm/armv8-2-fp16-simd-thumb.d: Likewise.
	* testsuite/gas/arm/armv8-2-fp16-simd.d: Likewise.
	* testsuite/gas/arm/armv8-a+crypto.d: Likewise.
	* testsuite/gas/arm/armv8-a+fp.d: Likewise.
	* testsuite/gas/arm/armv8-a+ras.d: Likewise.
	* testsuite/gas/arm/armv8-a+rdma-warning.d: Likewise.
	* testsuite/gas/arm/armv8-a+rdma.d: Likewise.
	* testsuite/gas/arm/armv8-a+simd.d: Likewise.
	* testsuite/gas/arm/armv8-a-barrier-thumb.d: Likewise.
	* testsuite/gas/arm/armv8-r+fp.d: Likewise.
	* testsuite/gas/arm/armv8-r+simd.d: Likewise.
	* testsuite/gas/arm/armv8-r-barrier-thumb.d: Likewise.
	* testsuite/gas/arm/armv8_1-a+simd.d: Likewise.
	* testsuite/gas/arm/armv8_2+rdma.d: Likewise.
	* testsuite/gas/arm/armv8_2-a.d: Likewise.
	* testsuite/gas/arm/armv8_3-a-fp.d: Likewise.
	* testsuite/gas/arm/armv8_3-a-simd.d: Likewise.
	* testsuite/gas/arm/armv8a-automatic-hlt.d: Likewise.
	* testsuite/gas/arm/armv8a-automatic-lda.d: Likewise.
	* testsuite/gas/arm/attr-syntax.d: Likewise.
	* testsuite/gas/arm/automatic-bw.d: Likewise.
	* testsuite/gas/arm/automatic-cbz.d: Likewise.
	* testsuite/gas/arm/automatic-clrex.d: Likewise.
	* testsuite/gas/arm/automatic-lda.d: Likewise.
	* testsuite/gas/arm/automatic-ldaex.d: Likewise.
	* testsuite/gas/arm/automatic-ldaexb.d: Likewise.
	* testsuite/gas/arm/automatic-ldrex.d: Likewise.
	* testsuite/gas/arm/automatic-ldrexd.d: Likewise.
	* testsuite/gas/arm/automatic-movw.d: Likewise.
	* testsuite/gas/arm/automatic-sdiv.d: Likewise.
	* testsuite/gas/arm/automatic-strexb.d: Likewise.
	* testsuite/gas/arm/barrier-bad-thumb.d: Likewise.
	* testsuite/gas/arm/barrier-bad.d: Likewise.
	* testsuite/gas/arm/barrier-thumb.d: Likewise.
	* testsuite/gas/arm/barrier.d: Likewise.
	* testsuite/gas/arm/bignum1.d: Likewise.
	* testsuite/gas/arm/blx-bad.d: Likewise.
	* testsuite/gas/arm/blx-bl-convert.d: Likewise.
	* testsuite/gas/arm/blx-local.s: Likewise.
	* testsuite/gas/arm/crc32-armv8-a-bad.d: Likewise.
	* testsuite/gas/arm/crc32-armv8-a.d: Likewise.
	* testsuite/gas/arm/crc32-armv8-r-bad.d: Likewise.
	* testsuite/gas/arm/crc32-armv8-r.d: Likewise.
	* testsuite/gas/arm/dis-data.d: Likewise.
	* testsuite/gas/arm/dis-data2.d: Likewise.
	* testsuite/gas/arm/dis-data3.d: Likewise.
	* testsuite/gas/arm/eabi_attr_1.d: Likewise.
	* testsuite/gas/arm/fp-save.d: Likewise.
	* testsuite/gas/arm/group-reloc-alu-encoding-bad.d: Likewise.
	* testsuite/gas/arm/group-reloc-alu-parsing-bad.d: Likewise.
	* testsuite/gas/arm/group-reloc-alu.d: Likewise.
	* testsuite/gas/arm/group-reloc-ldc-encoding-bad.d: Likewise.
	* testsuite/gas/arm/group-reloc-ldc-parsing-bad.d: Likewise.
	* testsuite/gas/arm/group-reloc-ldc.d: Likewise.
	* testsuite/gas/arm/group-reloc-ldr-encoding-bad.d: Likewise.
	* testsuite/gas/arm/group-reloc-ldr-parsing-bad.d: Likewise.
	* testsuite/gas/arm/group-reloc-ldr.d: Likewise.
	* testsuite/gas/arm/group-reloc-ldrs-encoding-bad.d: Likewise.
	* testsuite/gas/arm/group-reloc-ldrs-parsing-bad.d: Likewise.
	* testsuite/gas/arm/group-reloc-ldrs.d: Likewise.
	* testsuite/gas/arm/insn-error-a.d: Likewise.
	* testsuite/gas/arm/insn-error-t.d: Likewise.
	* testsuite/gas/arm/inst-po-2.d: Likewise.
	* testsuite/gas/arm/inst-po-3.d: Likewise.
	* testsuite/gas/arm/inst-po-be.d: Likewise.
	* testsuite/gas/arm/inst-po.d: Likewise.
	* testsuite/gas/arm/ldconst.d: Likewise.
	* testsuite/gas/arm/ldgesb-bad.d: Likewise.
	* testsuite/gas/arm/ldgesh-bad.d: Likewise.
	* testsuite/gas/arm/ldst-offset0.d: Likewise.
	* testsuite/gas/arm/local_function.d: Likewise.
	* testsuite/gas/arm/local_label_coff.d: Likewise.
	* testsuite/gas/arm/local_label_elf.d: Likewise.
	* testsuite/gas/arm/mapping.d: Likewise.
	* testsuite/gas/arm/mapping2.d: Likewise.
	* testsuite/gas/arm/mapping3.d: Likewise.
	* testsuite/gas/arm/mapping4.d: Likewise.
	* testsuite/gas/arm/mapshort-elf.d: Likewise.
	* testsuite/gas/arm/mask_1-armv8-a.d: Likewise.
	* testsuite/gas/arm/mask_1-armv8-r.d: Likewise.
	* testsuite/gas/arm/movs-thumb1-reloc-local-armv7-m.d: Likewise.
	* testsuite/gas/arm/movs-thumb1-reloc-local.d: Likewise.
	* testsuite/gas/arm/movw-local.d: Likewise.
	* testsuite/gas/arm/mrs-msr-thumb-v6t2.d: Likewise.
	* testsuite/gas/arm/mrs-msr-thumb-v7-m.d: Likewise.
	* testsuite/gas/arm/mrs-msr-thumb-v7e-m.d: Likewise.
	* testsuite/gas/arm/msr-imm-bad.d: Likewise.
	* testsuite/gas/arm/msr-reg-bad.d: Likewise.
	* testsuite/gas/arm/msr-reg-thumb.d: Likewise.
	* testsuite/gas/arm/nomapping.d: Likewise.
	* testsuite/gas/arm/nops.d: Likewise.
	* testsuite/gas/arm/pic.d: Likewise.
	* testsuite/gas/arm/pinsn.d: Likewise.
	* testsuite/gas/arm/plt-1.d: Likewise.
	* testsuite/gas/arm/pr21458.d: Likewise.
	* testsuite/gas/arm/pr9722.d: Likewise.
	* testsuite/gas/arm/strex-t.d: Likewise.
	* testsuite/gas/arm/t2-branch-global.d: Likewise.
	* testsuite/gas/arm/target-reloc-1.d: Likewise.
	* testsuite/gas/arm/thumb-b-bad.d: Likewise.
	* testsuite/gas/arm/thumb-w-bad.d: Likewise.
	* testsuite/gas/arm/thumb-w-good.d: Likewise.
	* testsuite/gas/arm/thumb.d: Likewise.
	* testsuite/gas/arm/thumb2_it.d: Likewise.
	* testsuite/gas/arm/thumb2_it_auto.d: Likewise.
	* testsuite/gas/arm/thumb2_it_search.d: Likewise.
	* testsuite/gas/arm/thumb2_ldmstm.d: Likewise.
	* testsuite/gas/arm/thumb2_ldr_immediate_armv6.d: Likewise.
	* testsuite/gas/arm/thumb2_ldr_immediate_armv6t2.d: Likewise.
	* testsuite/gas/arm/thumb2_ldr_immediate_highregs_armv6t2.d: Likewise.
	* testsuite/gas/arm/thumb2_pool.d: Likewise.
	* testsuite/gas/arm/thumb2_vpool.d: Likewise.
	* testsuite/gas/arm/thumb2_vpool_be.d: Likewise.
	* testsuite/gas/arm/thumb32.d: Likewise.
	* testsuite/gas/arm/thumbver.d: Likewise.
	* testsuite/gas/arm/tls.d: Likewise.
	* testsuite/gas/arm/tls_vxworks.d: Likewise.
	* testsuite/gas/arm/undefined.d: Likewise.
	* testsuite/gas/arm/undefined_coff.d: Likewise.
	* testsuite/gas/arm/unwind.d: Likewise.
	* testsuite/gas/arm/v4bx.d: Likewise.
	* testsuite/gas/arm/vcmp-noprefix-imm.d: Likewise.
	* testsuite/gas/arm/vcvt-bad.d: Likewise.
	* testsuite/gas/arm/vfma1.d: Likewise.
	* testsuite/gas/arm/vldconst.d: Likewise.
	* testsuite/gas/arm/vldconst_be.d: Likewise.
	* testsuite/gas/arm/vldm-arm.d: Likewise.
	* testsuite/gas/arm/vldr.d: Likewise.
	* testsuite/gas/arm/weakdef-1.d: Likewise.
	* testsuite/gas/arm/weakdef-2.d: Likewise.
	* config/te-riscix.h: Delete.
	* Makefile.in: Regenerate.
	* po/POTFILES.in: Regenerate.
ld/
	* Makefile.am: Remove arm-aout and arm-coff support.
	* configure.tgt: Likewise.
	* testsuite/ld-arm/attr-merge-div-00.d: Likewise.
	* testsuite/ld-arm/attr-merge-div-01-m3.d: Likewise.
	* testsuite/ld-arm/attr-merge-div-01.d: Likewise.
	* testsuite/ld-arm/attr-merge-div-02.d: Likewise.
	* testsuite/ld-arm/attr-merge-div-10-m3.d: Likewise.
	* testsuite/ld-arm/attr-merge-div-10.d: Likewise.
	* testsuite/ld-arm/attr-merge-div-11.d: Likewise.
	* testsuite/ld-arm/attr-merge-div-12.d: Likewise.
	* testsuite/ld-arm/attr-merge-div-120.d: Likewise.
	* testsuite/ld-arm/attr-merge-div-20.d: Likewise.
	* testsuite/ld-arm/attr-merge-div-21.d: Likewise.
	* testsuite/ld-arm/attr-merge-div-22.d: Likewise.
	* testsuite/ld-arm/attr-merge-hardfp-use-1.d: Likewise.
	* testsuite/ld-arm/attr-merge-hardfp-use-2.d: Likewise.
	* testsuite/ld-arm/attr-merge-nosection-1.d: Likewise.
	* testsuite/ld-arm/attr-merge-unknown-2.d: Likewise.
	* testsuite/ld-arm/attr-merge-unknown-2r.d: Likewise.
	* testsuite/ld-arm/attr-merge-unknown-3.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-1.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-10.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-10r.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-11.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-11r.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-12.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-12r.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-13.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-13r.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-14.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-14r.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-1r.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-2.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-2r.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-3.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-3r.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-4.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-4r.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-5.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-5r.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-6.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-6r.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-7.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-7r.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-8.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-8r.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-9.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-9r.d: Likewise.
	* testsuite/ld-arm/attr-merge-wchar-00-nowarn.d: Likewise.
	* testsuite/ld-arm/attr-merge-wchar-00.d: Likewise.
	* testsuite/ld-arm/attr-merge-wchar-02-nowarn.d: Likewise.
	* testsuite/ld-arm/attr-merge-wchar-02.d: Likewise.
	* testsuite/ld-arm/attr-merge-wchar-04-nowarn.d: Likewise.
	* testsuite/ld-arm/attr-merge-wchar-04.d: Likewise.
	* testsuite/ld-arm/attr-merge-wchar-20-nowarn.d: Likewise.
	* testsuite/ld-arm/attr-merge-wchar-20.d: Likewise.
	* testsuite/ld-arm/attr-merge-wchar-22-nowarn.d: Likewise.
	* testsuite/ld-arm/attr-merge-wchar-22.d: Likewise.
	* testsuite/ld-arm/attr-merge-wchar-24-nowarn.d: Likewise.
	* testsuite/ld-arm/attr-merge-wchar-40-nowarn.d: Likewise.
	* testsuite/ld-arm/attr-merge-wchar-40.d: Likewise.
	* testsuite/ld-arm/attr-merge-wchar-42-nowarn.d: Likewise.
	* testsuite/ld-arm/attr-merge-wchar-44-nowarn.d: Likewise.
	* testsuite/ld-arm/attr-merge-wchar-44.d: Likewise.
	* testsuite/ld-arm/eabi-hard-float.d: Likewise.
	* testsuite/ld-arm/eabi-soft-float-ABI4.d: Likewise.
	* testsuite/ld-arm/eabi-soft-float-r.d: Likewise.
	* testsuite/ld-arm/eabi-soft-float.d: Likewise.
	* testsuite/ld-arm/gc-hidden-1.d: Likewise.
	* emulparams/armaoutb.sh: Delete.
	* emulparams/armaoutl.sh: Delete.
	* emulparams/armcoff.sh: Delete.
	* emulparams/armnbsd.sh: Delete.
	* emulparams/riscix.sh: Delete.
	* scripttempl/armaout.sc: Delete.
	* scripttempl/armcoff.sc: Delete.
	* scripttempl/riscix.sc: Delete.
	* Makefile.in: Regenerate.
	* po/BLD-POTFILES.in: Regenerate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Silence gcc-8 warnings
@ 2018-04-25  8:21 sergiodj+buildbot
  2018-04-25  9:18 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-25  8:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d99b4b92c8ed0f7ef98f370bbf65a360ed66ad7b ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: d99b4b92c8ed0f7ef98f370bbf65a360ed66ad7b

Silence gcc-8 warnings

This seems to work with gcc-8 and a bunch of prior gcc versions I tested.

	* elf-linux-core.h: Disable gcc-8 string truncation warning.
	* elf.c (elfcore_write_prpsinfo): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix the mask for the sqrdml(a|s)h instructions.
@ 2018-04-25 12:59 sergiodj+buildbot
  2018-04-25 13:28 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-25 12:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 10bba94bd44045559cfd048cd34376090dd8107a ***

Author: Tamar Christina <tamar.christina@arm.com>
Branch: master
Commit: 10bba94bd44045559cfd048cd34376090dd8107a

Fix the mask for the sqrdml(a|s)h instructions.

Rn is supposed to have a 5 bit range but instead was given 4 bits
causing these instructions to disassemble as unknown instructions.

opcodes/

	* aarch64-tbl.h (sqrdmlah, sqrdmlsh): Fix masks.

gas/

	* testsuite/gas/aarch64/rdma.s: Test for larger register numbers.
	* testsuite/gas/aarch64/rdma.d: Update results.
	* testsuite/gas/aarch64/rdma-directive.d: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: drop redundant AVX512VL shift templates
@ 2018-04-25 14:49 sergiodj+buildbot
  2018-04-25 16:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-25 14:49 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bacd145775e3ca1a9d1a6d0b65c4ba10b307e167 ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: bacd145775e3ca1a9d1a6d0b65c4ba10b307e167

x86: drop redundant AVX512VL shift templates

These were wrongly left in place by commit ed438a93f1 ("x86: fold
certain AVX512 rotate and shift templates").


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix new inferior events output
@ 2018-04-25 18:28 sergiodj+buildbot
  2018-04-25 19:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-25 18:28 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 249b57335279b1051456884f1a908cdec907f43a ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 249b57335279b1051456884f1a908cdec907f43a

Fix new inferior events output

Since f67c0c917150 ("Enable 'set print inferior-events' and improve
detach/fork/kill/exit messages"), when detaching a remote process, we
get, for detach against a remote target:

 (gdb) detach
 Detaching from program: ...., process 5388
 Ending remote debugging.
 [Inferior 1 (Thread 5388.5388) detached]
              ^^^^^^^^^^^^^^^^

That is incorrect, for it is printing a thread id as string while we
should be printing the process id instead.  I.e., either one of:

 [Inferior 1 (process 5388) detached]
 [Inferior 1 (Remote target) detached]

depending on remote stub support for the multi-process extensions.


Similarly, after killing a process, we're printing thread ids while we
should be printing process ids.  E.g., on native GNU/Linux:

 (gdb) k
 Kill the program being debugged? (y or n) y
 [Inferior 1 (Thread 0x7ffff7faa8c0 (LWP 30721)) has been killed]
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

while it should have been:

 Kill the program being debugged? (y or n) y
 [Inferior 1 (process 30721) has been killed]
              ^^^^^^^^^^^^^

There's a wording inconsistency between detach and kill:

 [Inferior 1 (process 30721) has been killed]
 [Inferior 1 (process 30721) detached]

Given we were already saying "detached" instead of "has been
detached", and we used to say just "exited", and given that the "has
been" doesn't really add any information, this commit changes the
message to just "killed":

 [Inferior 1 (process 30721) killed]

gdb/ChangeLog:
2018-04-25  Pedro Alves  <palves@redhat.com>

	* infcmd.c (kill_command): Print the pid as string, not the whole
	thread's ptid.  Add comment.  s/has been killed/killed/ in output
	message.
	* remote.c (remote_detach_1): Print the pid as string, not the
	whole thread's ptid.

gdb/testsuite/ChangeLog:
2018-04-25  Pedro Alves  <palves@redhat.com>

	* gdb.base/hook-stop.exp: Expect "killed" instead of "has been
	killed".
	* gdb.base/kill-after-signal.exp: Likewise.
	* gdb.threads/kill.exp: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [ARM] Add armelf_linux_fdpiceabi and armelfb_linux_fdpiceabi BFD backends
@ 2018-04-25 21:40 sergiodj+buildbot
  2018-04-25 22:05 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-25 21:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 617a5ada88c7d4b6aae201ad5b295f3d2ef07c10 ***

Author: Christophe Lyon <christophe.lyon@st.com>
Branch: master
Commit: 617a5ada88c7d4b6aae201ad5b295f3d2ef07c10

[ARM] Add armelf_linux_fdpiceabi and armelfb_linux_fdpiceabi BFD backends

Initial definition of these new backends.

2018-04-25  Christophe Lyon  <christophe.lyon@st.com>
	Mickal Gun  <mickael.guene@st.com>

	bfd/
	* config.bfd (arm*-*-linux-*): Add arm_elf32_fdpic_be_vec and
	arm_elf32_fdpic_le_vec to targ_selvecs. Accept
	arm*-*-uclinuxfdpiceabi.
	* configure.ac: Add support for arm_elf32_fdpic_be_vec and
	arm_elf32_fdpic_le_vec.
	* configure: Regenerate.
	* elf32-arm.c (struct elf32_arm_link_hash_table): Add fdpic_p.
	(elf32_arm_link_hash_table_create): Initialize fdpic_p.
	(TARGET_LITTLE_SYM, TARGET_LITTLE_NAME, TARGET_BIG_SYM)
	(TARGET_BIG_NAME, elf_match_priority): Define for FDPIC targets.
	(elf32_arm_fdpic_link_hash_table_create): New.
	* targets.c (_bfd_target_vector): Add arm_elf32_fdpic_be_vec and
	arm_elf32_fdpic_le_vec.

	ld/
	* Makefile.am (ALL_EMULATION_SOURCES): Add
	earmelf_linux_fdpiceabi.c and earmelfb_linux_fdpiceabi.c.
	(earmelf_linux_fdpiceabi.c, earmelfb_linux_fdpiceabi.c): New rules.
	* Makefile.in: Regenerate.
	* configure.tgt (arm*-*-uclinuxfdpiceabi): Handle new target.
	* emulparams/armelf_linux_fdpiceabi.sh: New.
	* emulparams/armelfb_linux_fdpiceabi.sh: New.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [ARM] Add FDPIC OSABI flag support.
@ 2018-04-25 22:20 sergiodj+buildbot
  2018-04-26  1:04 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-25 22:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 18a203380502fb3ee75633fd464faa3c83cec710 ***

Author: Christophe Lyon <christophe.lyon@st.com>
Branch: master
Commit: 18a203380502fb3ee75633fd464faa3c83cec710

[ARM] Add FDPIC OSABI flag support.

ELF files targetting ARM FDPIC use the ELFOSABI_ARM_FDPIC flag.
Set it appropriately in file generators (eg. gas), and handle it in
readers (eg. readelf).

2018-04-25  Christophe Lyon  <christophe.lyon@st.com>
	Mickal Gun  <mickael.guene@st.com>

	bfd/
	* elf32-arm.c (elf32_arm_print_private_bfd_data): Support
	EF_ARM_PIC and ELFOSABI_ARM_FDPIC.
	(elf32_arm_post_process_headers): Support ELFOSABI_ARM_FDPIC.
	(ELF_OSABI): Define to ELFOSABI_ARM_FDPIC.

	binutils/
	* readelf.c (decode_ARM_machine_flags): Support EF_ARM_PIC.
	(get_osabi_name): Support ELFOSABI_ARM_FDPIC.

	gas/
	* config/tc-arm.c (arm_fdpic): New.
	(elf32_arm_target_format): Support FDPIC.
	(OPTION_FDPIC): New.
	(md_longopts): Support FDPIC.
	(md_parse_option): Likewise.
	(md_show_usage): Likewise.

	include/
	* elf/arm.h (EF_ARM_FDPIC): New.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [ARM] Add FDPIC relocations definitions
@ 2018-04-25 23:02 sergiodj+buildbot
  2018-04-26  3:22 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-25 23:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 188fd7aea619d9f66a822bad881d8f56892b60aa ***

Author: Christophe Lyon <christophe.lyon@st.com>
Branch: master
Commit: 188fd7aea619d9f66a822bad881d8f56892b60aa

[ARM] Add FDPIC relocations definitions

Add FDPIC relocation definitions in BFD and gas.
Gas rejects them if the --fdpic option was not specified.

2018-04-25  Christophe Lyon  <christophe.lyon@st.com>
	Mickal Gun  <mickael.guene@st.com>

	bfd/
	* bfd-in2.c (BFD_RELOC_ARM_GOTFUNCDESC)
	(BFD_RELOC_ARM_GOTOFFFUNCDESC, BFD_RELOC_ARM_FUNCDESC)
	(BFD_RELOC_ARM_FUNCDESC_VALUE): New.
	* elf32-arm.c (elf32_arm_howto_table_2): Add R_ARM_GOTFUNCDESC,
	R_ARM_GOTOFFFUNCDESC, R_ARM_FUNCDESC, R_ARM_FUNCDESC_VALUE.
	(elf32_arm_howto_from_type): Take new members of
	elf32_arm_howto_table_2 into account.
	(elf32_arm_reloc_map): Add BFD_RELOC_ARM_GOTFUNCDESC,
	BFD_RELOC_ARM_GOTOFFFUNCDESC, BFD_RELOC_ARM_FUNCDESC,
	BFD_RELOC_ARM_FUNCDESC_VALUE.
	* reloc.c: Add BFD_RELOC_ARM_GOTFUNCDESC,
	BFD_RELOC_ARM_GOTOFFFUNCDESC, BFD_RELOC_ARM_FUNCDESC,
	BFD_RELOC_ARM_FUNCDESC_VALUE.

	gas/
	* config/tc-arm.c (reloc_names): Add gotfuncdesc, gotofffuncdesc,
	funcdesc.
	(md_apply_fix): Support the new relocations.
	(tc_gen_reloc): Likewise.
	* testsuite/gas/arm/reloc-fdpic.d: New.
	* testsuite/gas/arm/reloc-fdpic.s: New.

	include/
	* elf/arm.h (R_ARM_GOTFUNCDESC, R_ARM_GOTOFFFUNCDESC)
	(R_ARM_FUNCDESC)
	(R_ARM_FUNCDESC_VALUE): Define new relocations.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [ARM] Implement FDPIC relocations.
@ 2018-04-25 23:36 sergiodj+buildbot
  2018-04-26  5:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-25 23:36 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e8b09b87102504a110f839e67a712094d63dcbab ***

Author: Christophe Lyon <christophe.lyon@st.com>
Branch: master
Commit: e8b09b87102504a110f839e67a712094d63dcbab

[ARM] Implement FDPIC relocations.

This is the main BFD patch, that enables the linker to actually handle
the FDPIC relocations.

2018-04-25  Christophe Lyon  <christophe.lyon@st.com>
	Mickal Gun  <mickael.guene@st.com>

	bfd/
	* elf32-arm.c (struct fdpic_local): New.
	(elf_arm_obj_tdata): Add local_fdpic_cnts field.
	(elf32_arm_local_fdpic_cnts): New.
	(struct fdpic_global): New.
	(elf32_arm_link_hash_entry): Add fdpic_cnts field.
	(elf32_arm_link_hash_table): Add srofixup field.
	(arm_elf_add_rofixup): New.
	(arm_elf_fill_funcdesc): New.
	(elf32_arm_link_hash_newfunc): Handle fdpic_cnts.
	(elf32_arm_allocate_local_sym_info): Likewise.
	(create_got_section): Create .rofixup section.
	(elf32_arm_copy_indirect_symbol): Handle fdpic_cnts.
	(bfd_elf32_arm_set_target_params): Handle FDPIC.
	(elf32_arm_final_link_relocate): Likewise.
	(elf32_arm_check_relocs): Likewise.
	(allocate_dynrelocs_for_symbol): Likewise.
	(elf32_arm_size_dynamic_sections): Likewise.
	(elf32_arm_finish_dynamic_sections): Likewise.
	(elf32_arm_output_arch_local_syms): Likewise.
	(elf32_arm_fdpic_omit_section_dynsym): New.

	ld/
	* emulparams/armelf_linux_fdpiceabi.sh: Add .rofixup section.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [ARM] Implement PLT for FDPIC.
@ 2018-04-26  0:03 sergiodj+buildbot
  2018-04-26  7:28 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-26  0:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7801f98f84fefa495941c86e2a859ea8c6c37770 ***

Author: Christophe Lyon <christophe.lyon@st.com>
Branch: master
Commit: 7801f98f84fefa495941c86e2a859ea8c6c37770

[ARM] Implement PLT for FDPIC.

FDPIC requires special PLT entries, defined in this patch.

Note that lazy binding is not supported because of a race condition
for lack of an atomic 64-bits load instruction.

2018-04-25  Christophe Lyon  <christophe.lyon@st.com>
	Mickal Gun  <mickael.guene@st.com>

	bfd/
	* elf32-arm.c (elf32_arm_fdpic_plt_entry): New.
	(elf32_arm_create_dynamic_sections): Handle FDPIC.
	(elf32_arm_allocate_plt_entry): Likewise.
	(elf32_arm_populate_plt_entry): Likewise.
	(elf32_arm_output_plt_map_1): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [ARM] Add TLS relocations for FDPIC.
@ 2018-04-26  0:55 sergiodj+buildbot
  2018-04-26 10:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-26  0:55 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5c5a4843ec385a60954fbbc4bcf5b64763639bd3 ***

Author: Christophe Lyon <christophe.lyon@st.com>
Branch: master
Commit: 5c5a4843ec385a60954fbbc4bcf5b64763639bd3

[ARM] Add TLS relocations for FDPIC.

Define and handle TLS relocations for FDPIC in BFD and gas.

In gas, the new relocations are rejected if the --fdpic option was not
specified.

We also define the __tdata_start symbol to mark the start of the
.tdata section. This allows FDPIC static binaries to find the start of
.tdata section, since phdr->p_vaddr of TLS segment is not a valid
value for FDPIC.

2018-04-25  Christophe Lyon  <christophe.lyon@st.com>
	Mickal Gun  <mickael.guene@st.com>

	bfd/:
	* bfd-in2.h (BFD_RELOC_ARM_TLS_GD32_FDPIC)
	(BFD_RELOC_ARM_TLS_LDM32_FDPIC, BFD_RELOC_ARM_TLS_IE32_FDPIC): New
	relocations.
	* elf32-arm.c (elf32_arm_howto_table_2): Add R_ARM_TLS_GD32_FDPIC,
	R_ARM_TLS_LDM32_FDPIC, R_ARM_TLS_IE32_FDPIC relocations.
	(elf32_arm_reloc_map): Add R_ARM_TLS_GD32_FDPIC,
	R_ARM_TLS_LDM32_FDPIC, R_ARM_TLS_IE32_FDPIC.
	(struct elf32_arm_link_hash_table): Update comment.
	(elf32_arm_final_link_relocate): Handle TLS FDPIC relocations.
	(IS_ARM_TLS_RELOC): Likewise.
	(elf32_arm_check_relocs): Likewise.
	(allocate_dynrelocs_for_symbol): Likewise.
	(elf32_arm_size_dynamic_sections): Update comment.
	* reloc.c: Add BFD_RELOC_ARM_TLS_GD32_FDPIC,
	BFD_RELOC_ARM_TLS_LDM32_FDPIC, BFD_RELOC_ARM_TLS_IE32_FDPIC.

	gas/
	* config/tc-arm.c (reloc_names): Add TLSGD_FDPIC, TLSLDM_FDPIC,
	GOTTPOFF_FDIC relocations.
	(md_apply_fix): Handle the new TLS FDPIC relocations.
	(tc_gen_reloc): Likewise.
	(arm_fix_adjustable): Likewise.

	include/
	* elf/arm.h: Add R_ARM_TLS_GD32_FDPIC, R_ARM_TLS_LDM32_FDPIC,
	R_ARM_TLS_IE32_FDPIC.

	ld/
	* scripttempl/elf.sc: Define __tdata_start for .tdata section.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [ARM] FDPIC: Add stack segment
@ 2018-04-26  1:29 sergiodj+buildbot
  2018-04-26 13:05 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-26  1:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cb10292c2a6c26349c02ec275e4087147fd1cdf0 ***

Author: Christophe Lyon <christophe.lyon@st.com>
Branch: master
Commit: cb10292c2a6c26349c02ec275e4087147fd1cdf0

[ARM] FDPIC: Add stack segment

The size of the stack segment defaults to 32KB, and can be overridden
by defining the __stacksize symbol.

2018-04-25  Christophe Lyon  <christophe.lyon@st.com>
	Mickal Gun  <mickael.guene@st.com>

	bfd/
	* elf32-arm.c (DEFAULT_STACK_SIZE): New.
	(elf32_arm_always_size_sections): Create stack segment.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [ARM] FDPIC: Translate R_ARM_TARGET2 relocation into R_ARM_GOT32 relocation for FDPIC platform
@ 2018-04-26  1:48 sergiodj+buildbot
  2018-04-26 15:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-26  1:48 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 29e9b073e3b356aae4c249bf3e265b2a608aea6c ***

Author: Christophe Lyon <christophe.lyon@st.com>
Branch: master
Commit: 29e9b073e3b356aae4c249bf3e265b2a608aea6c

[ARM] FDPIC: Translate R_ARM_TARGET2 relocation into R_ARM_GOT32 relocation for FDPIC platform

2018-04-25  Christophe Lyon  <christophe.lyon@st.com>
	Mickal Gun  <mickael.guene@st.com>

	bfd/
	* elf32-arm.c (bfd_elf32_arm_set_target_params): Handle FDPIC case
	for R_ARM_TARGET2.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [ARM] FDPIC: Make _GLOBAL_OFFSET_TABLE_ a relative symbol
@ 2018-04-26  2:23 sergiodj+buildbot
  2018-04-26 17:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-26  2:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fac7bd6475c4058e7c1e0df29dac50579e427b34 ***

Author: Christophe Lyon <christophe.lyon@st.com>
Branch: master
Commit: fac7bd6475c4058e7c1e0df29dac50579e427b34

[ARM] FDPIC: Make _GLOBAL_OFFSET_TABLE_ a relative symbol

2018-04-25  Christophe Lyon  <christophe.lyon@st.com>
	Mickal Gun  <mickael.guene@st.com>

	bfd/
	* elf32-arm.c (elf32_arm_finish_dynamic_symbol): Handle
	_GLOBAL_OFFSET_TABLE_ in FDPIC mode.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [ARM] FDPIC: Implement Thumb-only PLT for FDPIC.
@ 2018-04-26  2:55 sergiodj+buildbot
  2018-04-26 20:39 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-26  2:55 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 59029f57eba1763bad67167c2805d8df3dfa2285 ***

Author: Christophe Lyon <christophe.lyon@st.com>
Branch: master
Commit: 59029f57eba1763bad67167c2805d8df3dfa2285

[ARM] FDPIC: Implement Thumb-only PLT for FDPIC.

2018-04-25  Christophe Lyon  <christophe.lyon@st.com>
	Mickal Gun  <mickael.guene@st.com>

	bfd/
	* elf32-arm.c (elf32_arm_fdpic_thumb_plt_entry): New.
	(elf32_arm_plt_needs_thumb_stub_p): Handle thumb-only case.
	(elf32_arm_populate_plt_entry): Likewise.
	(elf32_arm_output_plt_map_1): Likewise.
	(elf32_arm_output_arch_local_syms): Likewise.

	ld/testsuite/
	* arm-elf.exp: Execute the new FDPIC Thumb-only tests.
	* fdpic-main-m.d: New test.
	* fdpic-main-m.s: New.
	* fdpic-main-m.sym: New.
	* fdpic-shared-m.d: New test.
	* fdpic-shared-m.s: New.
	* fdpic-shared-m.sym: New.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: drop VexImmExt
@ 2018-04-26  7:04 sergiodj+buildbot
  2018-04-26 22:05 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-26  7:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2f1bada2dc2e7215cd633b6c39a6c31dbd875bc0 ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 2f1bada2dc2e7215cd633b6c39a6c31dbd875bc0

x86: drop VexImmExt

It's only used in assertions, and hence not really needed for correct
code generation.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: drop CpuRegMMX, CpuReg[XYZ]MM, and CpuRegMask
@ 2018-04-26  8:13 sergiodj+buildbot
  2018-04-27  2:39 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-26  8:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6e041cf4b0b00e85bee85bee98c411f16bd15747 ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 6e041cf4b0b00e85bee85bee98c411f16bd15747

x86: drop CpuRegMMX, CpuReg[XYZ]MM, and CpuRegMask

It's not clear to me why they had been introduced - the respective
comments in opcodes/i386-gen.c are certainly wrong: ymm<N> registers
are very well supported (and necessary) with just AVX512F.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: CpuXSAVE is a prereq for various other features
@ 2018-04-26  8:36 sergiodj+buildbot
  2018-04-27  6:00 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-26  8:36 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 59ef5df41e8a2addac4c74bb838fe8295cc79ebf ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 59ef5df41e8a2addac4c74bb838fe8295cc79ebf

x86: CpuXSAVE is a prereq for various other features

All of AVX, LWP, MPX, and PKU require XSAVE, and hence it as well as
XRSTOR should be enabled when enabling these ISA extensions. Leverage
these implications to shorten some of the cpu_flag_init[] entries.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: fold various non-memory operand AVX512VL templates
@ 2018-04-26  9:03 sergiodj+buildbot
  2018-04-27  7:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-26  9:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e2195274d4a0752459ea89ffbf50b2704fb0c0b4 ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: e2195274d4a0752459ea89ffbf50b2704fb0c0b4

x86: fold various non-memory operand AVX512VL templates

There's little point carrying up to three templates per insn flavor
when the sole difference is operand size and the dependency on AVX512VL
being enabled. Instead the need for AVX512VL can be derived from an
operand allowing for ZMMword as well as one or both or XMMword and
YMMword (irrespective of whether this is a register or memory operand).
Without further abstraction to deal with the different Disp8MemShift
values between the templates, only a limited set (mostly ones only
allowing for non-memory operands) can be folded, which is being done
here.

Also drop IgnoreSize wherever possible from anything that's being
touched anyway.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: x87-related adjustments
@ 2018-04-26 10:29 sergiodj+buildbot
  2018-04-27  0:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 10:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0e0eea782025d92f894f6d132aae2507c6a90a7b ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 0e0eea782025d92f894f6d132aae2507c6a90a7b

x86: x87-related adjustments

Neither 287 wrt 8087 nor 387 wrt 287 are proper supersets - in each case
some insns get removed from the ISA (they become NOPs, but code intended
for newer co-processors should not use them).

Furthermore with .no87, ST should not be recognized as a register name.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix breakpoints in ifunc after inferior resolved it (@got.plt symbol creation)
@ 2018-04-26 12:47 sergiodj+buildbot
  2018-04-27 10:14 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 12:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 02e169e2dac9b0354162eb0e7ee3fc95134b232d ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 02e169e2dac9b0354162eb0e7ee3fc95134b232d

Fix breakpoints in ifunc after inferior resolved it (@got.plt symbol creation)

Setting a breakpoint on an ifunc symbol after the ifunc has already
been resolved by the inferior should result in creating a breakpoint
location at the ifunc target.  However, that's not what happens on
current Fedora:

  (gdb) n
  53        i = gnu_ifunc (1);    /* break-at-call */
  (gdb)
  54        assert (i == 2);
  (gdb) b gnu_ifunc
  Breakpoint 2 at gnu-indirect-function resolver at 0x7ffff7bd36ee
  (gdb) info breakpoints
  Num     Type                   Disp Enb Address            What
  2       STT_GNU_IFUNC resolver keep y   0x00007ffff7bd36ee <gnu_ifunc+4>

The problem is that elf_gnu_ifunc_resolve_by_got never manages to
resolve an ifunc target.  The reason is that GDB never actually
creates the internal got.plt symbols:

 (gdb) p 'gnu_ifunc@got.plt'
 No symbol "gnu_ifunc@got.plt" in current context.

and this is because GDB expects that rela.plt has relocations for
.plt, while it actually has relocations for .got.plt:

 Relocation section [10] '.rela.plt' for section [22] '.got.plt' at offset 0x570 contains 2 entries:
   Offset              Type            Value               Addend Name
   0x0000000000601018  X86_64_JUMP_SLOT 000000000000000000      +0 __assert_fail
   0x0000000000601020  X86_64_JUMP_SLOT 000000000000000000      +0 gnu_ifunc


Using an older system on the GCC compile farm (machine gcc15, an
x86-64 running Debian 6.0.8, with GNU ld 2.20.1), we see that it used
to be that we'd get a .rela.plt section for .plt:

 Relocation section [ 9] '.rela.plt' for section [11] '.plt' at offset 0x578 contains 3 entries:
   Offset              Type            Value               Addend Name
   0x0000000000600cc0  X86_64_JUMP_SLOT 000000000000000000      +0 __assert_fail
   0x0000000000600cc8  X86_64_JUMP_SLOT 000000000000000000      +0 __libc_start_main
   0x0000000000600cd0  X86_64_JUMP_SLOT 000000000000000000      +0 gnu_ifunc

Those offsets did point into .got.plt, as seen with objdump -h:

  20 .got.plt      00000030  0000000000600ca8  0000000000600ca8  00000ca8  2**3
     		   CONTENTS, ALLOC, LOAD, DATA

I also tested on gcc110 on the compile farm (PPC64 running CentOS
7.4.1708, with GNU ld 2.25.1), and there we see instead:

 Relocation section [ 9] '.rela.plt' for section [23] '.plt' at offset 0x5d0 contains 4 entries:
   Offset              Type            Value               Addend Name
   0x0000000010020148  PPC64_JMP_SLOT  000000000000000000      +0 __libc_start_main
   0x0000000010020160  PPC64_JMP_SLOT  000000000000000000      +0 __gmon_start__
   0x0000000010020178  PPC64_JMP_SLOT  000000000000000000      +0 __assert_fail
   0x0000000010020190  PPC64_JMP_SLOT  000000000000000000      +0 gnu_ifunc

But note that those offsets point into .plt, not .got.plt, as seen
with objdump -h:

 22 .plt          00000078  0000000010020130  0000000010020130  00010130  2**3
                  ALLOC

This commit makes us support all the different combinations above.

With that addressed, we now get:

 (gdb) p 'gnu_ifunc@got.plt'
 $1 = (<text from jump slot in .got.plt, no debug info>) 0x400753 <final>

And setting a breakpoint on the ifunc finds the ifunc target:

 (gdb) b gnu_ifunc
 Breakpoint 2 at 0x400753
 (gdb) info breakpoints
 Num     Type           Disp Enb Address            What
 2       breakpoint     keep y   0x0000000000400753 <final>

gdb/ChangeLog:
2018-04-26  Pedro Alves  <palves@redhat.com>

	* elfread.c (elf_rel_plt_read): Look for relocations for .got.plt too.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Calling ifunc functions when target has no debug info but resolver has
@ 2018-04-26 13:28 sergiodj+buildbot
  2018-04-27 15:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 13:28 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8388016d7ff8b88d29f2427963f26a6b8bbb03b1 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 8388016d7ff8b88d29f2427963f26a6b8bbb03b1

Calling ifunc functions when target has no debug info but resolver has

After the previous patch, on Fedora 27 (glibc 2.26), if you try
calling strlen in the inferior, you now get:

  (top-gdb) p strlen ("hello")
  '__strlen_avx2' has unknown return type; cast the call to its declared return type

This is correct, because __strlen_avx2 is written in assembly.

We can improve on this though -- if the final ifunc resolved/target
function has no debug info, but the ifunc _resolver_ does have debug
info, we can try extracting the final function's type from the type
that the resolver returns.  E.g.,:

  typedef size_t (*strlen_t) (const char*);

  size_t my_strlen (const char *) { /* some implementation */ }
  strlen_t strlen_resolver (unsigned long hwcap) { return my_strlen; }

  extern size_t strlen (const char *s);
  __typeof (strlen) strlen __attribute__ ((ifunc ("strlen_resolver")));

In the strlen example above, the resolver returns strlen_t, which is a
typedef for pointer to a function that returns size_t.  "strlen_t" is
the type of both the user-visible "strlen", and of the the target
function that implements it.

This patch teaches GDB to extract that type.

This is done for actual inferior function calls (in infcall.c), and
for ptype (in eval_call).  By the time we get to either of these
places, we've already lost the original symbol/minsym, and only have
values and types to work with.  Hence the changes to c-exp.y and
evaluate_var_msym_value, to ensure that we propagate the ifunc
minsymbol's info.

The change to make ifunc symbols have no/unknown return type exposes a
latent problem -- gdb.compile/compile-ifunc.exp calls a no-debug-info
function, but we did not warn about it.  The test is fixed by this
commit too.

gdb/ChangeLog:
2018-04-26  Pedro Alves  <palves@redhat.com>

	* blockframe.c (find_gnu_ifunc_target_type): New function.
	(find_function_type): New.
	* eval.c (evaluate_var_msym_value): For GNU ifunc types, always
	return a value with a memory address.
	(eval_call): For calls to GNU ifunc functions, try to find the
	type of the target function from the type that the resolver
	returns.
	* gdbtypes.c (objfile_type): Don't install a return type for ifunc
	symbols.
	* infcall.c (find_function_return_type): Delete.
	(find_function_addr): Add 'function_type' parameter.  For calls to
	GNU ifunc functions, try to find the type of the target function
	from the type that the resolver returns, and return it via
	FUNCTION_TYPE.
	(call_function_by_hand_dummy): Adjust to use the function type
	returned by find_function_addr.
	(find_function_addr): Add 'function_type' parameter and move
	description here.
	* symtab.h (find_function_type, find_gnu_ifunc_target_type): New
	declarations.

gdb/testsuite/ChangeLog:
2018-04-26  Pedro Alves  <palves@redhat.com>

	* gdb.compile/compile-ifunc.exp: Also expect "function has unknown
	return type" warnings.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix calling ifunc functions when resolver has debug info and different name
@ 2018-04-26 14:27 sergiodj+buildbot
  2018-04-27 13:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 14:27 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a376e11d84ba7ea8cc7333c77043e20c7b0cfc91 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: a376e11d84ba7ea8cc7333c77043e20c7b0cfc91

Fix calling ifunc functions when resolver has debug info and different name

Currently, on Fedora 27 (glibc 2.26), if you try to call strlen in the
inferior you get:

 (gdb) p strlen ("hello")
 $1 = (size_t (*)(const char *)) 0x7ffff554aac0 <__strlen_avx2>

strlen is an ifunc function, and what we see above is the result of
calling the ifunc resolver in the inferior.  That returns a pointer to
the actual target function that implements strlen on my machine.  GDB
should have turned around and called the resolver automatically
without the user noticing.

This is was caused by commit:

  commit bf223d3e808e6fec9ee165d3d48beb74837796de
  Date: Mon Aug 21 11:34:32 2017 +0100

      Handle function aliases better (PR gdb/19487, errno printing)

which added the find_function_alias_target call to c-exp.y, to try to
find an alias with debug info for a minsym.  For ifunc symbols, that
finds the ifunc's resolver if it has debug info (in the example it's
called "strlen_ifunc"), with the result that GDB calls that as a
regular function.

After this commit, we get now get:

  (top-gdb) p strlen ("hello")
  '__strlen_avx2' has unknown return type; cast the call to its declared return type

Which is correct, because __strlen_avx2 is written in assembly.
That'll be improved in a following patch, though.

gdb/ChangeLog:
2018-04-26  Pedro Alves  <palves@redhat.com>

	* c-exp.y (variable production): Skip finding an alias for ifunc
	symbols.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix elf_gnu_ifunc_resolve_by_got buglet
@ 2018-04-26 14:27 sergiodj+buildbot
  2018-04-27 19:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 14:27 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 28f4fa4d0540ac6a23930202f39782167667e373 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 28f4fa4d0540ac6a23930202f39782167667e373

Fix elf_gnu_ifunc_resolve_by_got buglet

The next patch will add a call to elf_gnu_ifunc_resolve_by_got that
trips on a latent buglet -- the function is writing to its output
parameter even if the address wasn't found, confusing the caller.  The
function's intro comment says:

  /* Try to find the target resolved function entry address of a STT_GNU_IFUNC
     function NAME.  If the address is found it is stored to *ADDR_P (if ADDR_P
     is not NULL) and the function returns 1.  It returns 0 otherwise.

So fix the function accordingly.

gdb/ChangeLog:
2018-04-26  Pedro Alves  <palves@redhat.com>

	* elfread.c (elf_gnu_ifunc_resolve_by_got): Don't write to *ADDR_P
	unless we actually resolved the ifunc.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Calling ifunc functions when resolver has debug info, user symbol same name
@ 2018-04-26 14:33 sergiodj+buildbot
  2018-04-27 18:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 14:33 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ca31ab1d675c1e20cee5f8cb213c52e3d7352496 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: ca31ab1d675c1e20cee5f8cb213c52e3d7352496

Calling ifunc functions when resolver has debug info, user symbol same name

If the GNU ifunc resolver has the same name as the user visible
symbol, and the resolver has debug info, then the DWARF info for the
resolver masks the ifunc minsym.  In that scenario, if you try calling
the ifunc from GDB, you call the resolver instead.  With the
gnu-ifunc.exp testcase added in a following patch, you'd see:

  (gdb) p gnu_ifunc (3)
  $1 = (int (*)(int)) 0x400753 <final>
  (gdb) FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=1: resolved_debug=0: p gnu_ifunc (3)
                                                       ^^^^^^^^^^^^^^^^

That is, we called the ifunc resolver manually, which returned a
pointer to the ifunc target function ("final").  The "final" symbol is
the function that GDB should have called automatically,

  ~~~~~~~~~~~~
  int
  final (int arg)
  {
    return arg + 1;
  }
  ~~~~~~~~~

which is what happens if you don't have debug info for the resolver:

  (gdb) p gnu_ifunc (3)
  $1 = 4
  (gdb) PASS: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=0: resolved_debug=1: p gnu_ifunc (3)
                                                       ^^^^^^^^^^^^^^^^

or if the resolver's symbol has a different name from the ifunc (as is
the case with modern uses of ifunc via __attribute__ ifunc, such as
glibc uses):

  (gdb) p gnu_ifunc (3)
  $1 = 4
  (gdb) PASS: gdb.base/gnu-ifunc.exp: resolver_attr=1: resolver_debug=1: resolved_debug=0: p gnu_ifunc (3)
                                      ^^^^^^^^^^^^^^^

in which case after this patch, you can still call the resolver
directly if you want:

  (gdb) p gnu_ifunc_resolver (3)
  $1 = (int (*)(int)) 0x400753 <final>

gdb/ChangeLog:
2018-04-26  Pedro Alves  <palves@redhat.com>

	* c-exp.y (variable production): Prefer ifunc minsyms over
	regular function symbols.
	* symtab.c (find_gnu_ifunc): New function.
	* minsyms.h (lookup_msym_prefer): New enum.
	(lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
	parameter by a lookup_msym_prefer parameter.
	* symtab.h (find_gnu_ifunc): New declaration.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix setting breakpoints on ifunc functions after they're already resolved
@ 2018-04-26 14:53 sergiodj+buildbot
  2018-04-27 22:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 14:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3467ec66bc1f30cf3ed7f9fe75234c96fc9c92d5 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 3467ec66bc1f30cf3ed7f9fe75234c96fc9c92d5

Fix setting breakpoints on ifunc functions after they're already resolved

This fixes setting breakpoints on ifunc functions by name after the
ifunc has already been resolved.

In that case, if you have debug info for the ifunc resolver, without
the fix, then gdb puts a breakpoint past the prologue of the resolver,
instead of setting a breakpoint at the ifunc target:

  break gnu_ifunc
  Breakpoint 4 at 0x7ffff7bd36f2: file src/gdb/testsuite/gdb.base/gnu-ifunc-lib.c, line 34.
  (gdb) continue
  Continuing.
  [Inferior 1 (process 13300) exited normally]
  (gdb)

above we should have stopped at "final", but didn't because we never
resolved the ifunc to the final location.

If you don't have debug info for the resolver, GDB manages to resolve
the ifunc target, but, it should be setting a breakpoint after the
prologue of the final function, and instead what you get is that GDB
sets a breakpoint on the first address of the target function.  With
the gnu-ifunc.exp tests added by a later patch, we get, without the
fix:

  (gdb) break gnu_ifunc
  Breakpoint 4 at 0x400753
  (gdb) continue
  Continuing.

  Breakpoint 4, final (arg=1) at src/gdb/testsuite/gdb.base/gnu-ifunc-final.c:20
  20	{

vs, fixed:

  (gdb) break gnu_ifunc
  Breakpoint 4 at 0x40075a: file src/gdb/testsuite/gdb.base/gnu-ifunc-final.c, line 21.
  (gdb) continue
  Continuing.

  Breakpoint 4, final (arg=2) at src/gdb/testsuite/gdb.base/gnu-ifunc-final.c:21
  21	  return arg + 1;
  (gdb)

Fix the problems above by moving the ifunc target resolving to
linespec.c, before we skip a function's prologue.  We need to save
something in the sal, so that set_breakpoint_location_function knows
that it needs to create a bp_gnu_ifunc_resolver bp_location.  Might as
well just save a pointer to the minsym.

gdb/ChangeLog:
2018-04-26  Pedro Alves  <palves@redhat.com>

	* breakpoint.c (set_breakpoint_location_function): Don't resolve
	ifunc targets here.  Instead, if we have an ifunc minsym, use its
	address/name.
	(add_location_to_breakpoint): Store the minsym and the objfile in
	the breakpoint location.
	* breakpoint.h (bp_location) <msymbol, objfile>: New fields.
	* linespec.c (minsym_found): Resolve GNU ifunc targets here.
	Record the minsym in the sal.
	* symtab.h (symtab_and_line) <msymbol>: New field.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Breakpoints, don't skip prologue of ifunc resolvers with debug info
@ 2018-04-26 15:18 sergiodj+buildbot
  2018-04-28  1:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 15:18 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 76af0f26356580771a18c37de4ebccdfbc449356 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 76af0f26356580771a18c37de4ebccdfbc449356

Breakpoints, don't skip prologue of ifunc resolvers with debug info

Without this patch, some of the tests added to gdb.base/gnu-ifunc.exp
by a following patch fail like so:

  FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=1: resolved_debug=0: set-break: before resolving: break gnu_ifunc
  FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=1: resolved_debug=0: set-break: before resolving: info breakpoints
  FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=1: resolved_debug=0: set-break: after resolving: break gnu_ifunc
  FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=1: resolved_debug=0: set-break: after resolving: info breakpoints
  FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=1: resolved_debug=1: set-break: before resolving: break gnu_ifunc
  FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=1: resolved_debug=1: set-break: before resolving: info breakpoints
  FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=1: resolved_debug=1: set-break: after resolving: break gnu_ifunc
  FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=1: resolved_debug=1: set-break: after resolving: info breakpoints

All of them trigger iff:

 - you have debug info for the ifunc resolver.
 - the resolver and the user-visible symbol have the same name.

If you have an ifunc that has a resolver with the same name as the
user visible symbol, debug info for the resolver masks out the ifunc
minsym.  When you set a breakpoint by name on the user visible symbol,
GDB finds the DWARF symbol for the resolver, and thinking that it's a
regular function, sets a breakpoint location past its prologue.

Like so, location 1.2, before the ifunc is resolved by the inferior:

  (gdb) break gnu_ifunc
  Breakpoint 2 at 0x7ffff7bd36ea (2 locations)
  (gdb) info breakpoints
  Num     Type           Disp Enb Address            What
  1       breakpoint     keep y   <MULTIPLE>
  1.1                         y     0x00007ffff7bd36ea <gnu_ifunc>
  1.2                         y     0x00007ffff7bd36f2 in gnu_ifunc at src/gdb/testsuite/gdb.base/gnu-ifunc-lib.c:34
  (gdb)

And like so, location 2.2, if you set the breakpoint after the ifunc
is resolved by the inferior (to "final"):

  (gdb) break gnu_ifunc
  Breakpoint 5 at 0x400757 (2 locations)
  (gdb) info breakpoints
  Num     Type           Disp Enb Address            What
  2       breakpoint     keep y   <MULTIPLE>
  2.1                         y     0x000000000040075a in final at src/gdb/testsuite/gdb.base/gnu-ifunc-resd.c:21
  2.2                         y     0x00007ffff7bd36f2 in gnu_ifunc at src/gdb/testsuite/gdb.base/gnu-ifunc-lib.c:34
  (gdb)

I don't think this is right because when users set a breakpoint at an
ifunc, they don't care about debugging the resolver.  Instead what you
should is a single location for the ifunc in the first case, and a
single location of the ifunc target in the second case.

gdb/ChangeLog:
2018-04-26  Pedro Alves  <palves@redhat.com>

	* linespec.c (struct bound_minimal_symbol_search_key): New.
	(convert_linespec_to_sals): Sort minimal symbols earlier.  Don't
	skip first line if we found a GNU ifunc minimal symbol by name.
	(compare_msymbols): Change parameters to work with a destructured
	lhs minsym.
	(compare_msymbols_for_qsort, compare_msymbols_for_bsearch): New
	functions.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Eliminate find_pc_partial_function_gnu_ifunc
@ 2018-04-26 15:43 sergiodj+buildbot
  2018-04-28  2:48 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 15:43 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a0aca7b0e13d884f43ba77c4c6d752d9140cb54b ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: a0aca7b0e13d884f43ba77c4c6d752d9140cb54b

Eliminate find_pc_partial_function_gnu_ifunc

Not used anywhere any longer.

If this is ever reinstated, note that this case:

	  cache_pc_function_is_gnu_ifunc = TYPE_GNU_IFUNC (SYMBOL_TYPE (f));

was incorrect in that regular symbols never have type marked as GNU
ifunc type, only minimal symbols.  At some point I had some fix that
checking the matching minsym here.  But in the end I ended up just
eliminating need for this function, so that fix was not necessary.

gdb/ChangeLog:
2018-04-26  Pedro Alves  <palves@redhat.com>

	* blockframe.c (cache_pc_function_is_gnu_ifunc): Delete.  Remove
	all references.
	(find_pc_partial_function_gnu_ifunc): Rename to ...
	(find_pc_partial_function): ... this, and remove references to
	'is_gnu_ifunc_p'.
	(find_pc_partial_function): Delete old implementation.
	* symtab.h (find_pc_partial_function_gnu_ifunc): Delete.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Factor out minsym_found/find_function_start_sal overload
@ 2018-04-26 16:07 sergiodj+buildbot
  2018-04-28  5:42 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 16:07 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 42ddae103c9eb20fb87378548ee95b4bd23648a5 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 42ddae103c9eb20fb87378548ee95b4bd23648a5

Factor out minsym_found/find_function_start_sal overload

I need to make the ifunc resolving code in elfread.c skip the target
function's prologue like minsym_found does.  I thought of factoring
that out to a separate function, but turns out there's already a
comment in find_function_start_sal that says that should agree with
minsym_found...

Instead of making sure the code agrees with a comment, factor out the
common code to a separate function and use it from both places.

Note that the current find_function_start_sal does a bit more than
minsym_found's equivalent (the "We always should ..." bit), though
that's probably a latent bug.

gdb/ChangeLog:
2018-04-26  Pedro Alves  <palves@redhat.com>

	* linespec.c (minsym_found): Use find_function_start_sal CORE_ADDR
	overload.
	* symtab.c (find_function_start_sal(CORE_ADDR, obj_section *,bool)):
	New, factored out from ...
	(find_function_start_sal(symbol *, int)): ... this.  Reimplement
	and use bool.
	* symtab.h (find_function_start_sal(CORE_ADDR, obj_section *,bool)):
	New.
	(find_function_start_sal(symbol *, int)): Change boolean parameter
	type to bool.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] For PPC64: elf_gnu_ifunc_record_cache: handle plt symbols in .text section
@ 2018-04-26 16:34 sergiodj+buildbot
  2018-04-28  8:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 16:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1adeb822668d3bd7182ca9b8cf42a7261deb3c7f ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 1adeb822668d3bd7182ca9b8cf42a7261deb3c7f

For PPC64: elf_gnu_ifunc_record_cache: handle plt symbols in .text section

elf_gnu_ifunc_record_cache doesn't ever record anything on PPC64
(tested on gcc110 on the compile farm, CentOS 7.4, ELFv1), because
that expects to find PLT symbols in the .plt section, while there we
get:

  (gdb) info symbol 'gnu_ifunc@plt'
  gnu_ifunc@plt in section .text
                           ^^^^^

I guess that may be related to the comment in ppc-linux-tdep.c that
says "For secure PLT, stub is in .text".

In any case, this commit fixes the issue by making the function look
at the symbol name instead of at the section.

gdb/ChangeLog:
2018-04-26  Pedro Alves  <palves@redhat.com>

	* elfread.c (elf_gnu_ifunc_record_cache): Check if the symbol name
	ends in "@plt" instead of looking at the symbol's section.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix stepping past GNU ifunc resolvers (introduce lookup_msym_prefer)
@ 2018-04-26 17:15 sergiodj+buildbot
  2018-04-28 11:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 17:15 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 20944a6e20324cd897bf6c4c5fd20ef7224dacaa ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 20944a6e20324cd897bf6c4c5fd20ef7224dacaa

Fix stepping past GNU ifunc resolvers (introduce lookup_msym_prefer)

When we're stepping (with "step"), we want to skip trampoline-like
functions automatically, including GNU ifunc resolvers.  That is done
by infrun.c calling into:

  in_solib_dynsym_resolve_code
    -> svr4_in_dynsym_resolve_code
      -> in_gnu_ifunc_stub

A problem here is that if there's a regular text symbol at the same
address as the ifunc symbol, the minimal symbol lookup in
in_gnu_ifunc_stub may miss the GNU ifunc symbol:

(...)
    41: 000000000000071a    53 FUNC    GLOBAL DEFAULT   11 gnu_ifunc_resolver
(...)
    50: 000000000000071a    53 IFUNC   GLOBAL DEFAULT   11 gnu_ifunc
(...)

This causes this FAIL in the tests added later in the series:

 (gdb) PASS: gdb.base/gnu-ifunc.exp: resolver_attr=1: resolver_debug=0: final_debug=0: resolver received HWCAP
 set step-mode on
 (gdb) PASS: gdb.base/gnu-ifunc.exp: resolver_attr=1: resolver_debug=0: final_debug=0: set step-mode on
 step
 0x00007ffff7bd371a in gnu_ifunc_resolver () from build/gdb/testsuite/outputs/gdb.base/gnu-ifunc/gnu-ifunc-lib-1-0-0.so
 (gdb) FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=1: resolver_debug=0: final_debug=0: step

Above, GDB simply thought that it stepped into a regular function, so
it stopped stepping, while it should have continued stepping past the
resolver.

The fix is to teach minimal symbol lookup to prefer GNU ifunc symbols
if desired.

gdb/ChangeLog:
2018-04-26  Pedro Alves  <palves@redhat.com>

	* minsyms.c (lookup_minimal_symbol_by_pc_section_1): Rename to ...
	(lookup_minimal_symbol_by_pc_section): ... this.  Replace
	'want_trampoline' parameter by a lookup_msym_prefer parameter.
	Handle it.
	(lookup_minimal_symbol_by_pc_section): Delete old implementation.
	(lookup_minimal_symbol_by_pc): Adjust.
	(in_gnu_ifunc_stub): Prefer GNU ifunc symbols.
	(lookup_solib_trampoline_symbol_by_pc): Adjust.
	* minsyms.h (lookup_msym_prefer): New enum.
	(lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
	parameter by a lookup_msym_prefer parameter.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] For PPC64/ELFv1: Introduce mst_data_gnu_ifunc
@ 2018-04-26 17:37 sergiodj+buildbot
  2018-04-28 14:35 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 17:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f50776aad58a1df6b8f7f2a7d25a3b10aa074f7b ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: f50776aad58a1df6b8f7f2a7d25a3b10aa074f7b

For PPC64/ELFv1: Introduce mst_data_gnu_ifunc

Running the new tests added later in the series on PPC64 (ELFv1)
revealed that the current ifunc support needs a bit of a design rework
to work properly on PPC64/ELFv1, as most of the new tests fail.  The
ifunc support only kind of works today if the ifunc symbol and the
resolver have the same name, as is currently tested by the
gdb.base/gnu-ifunc.exp testcase, which is unlike how ifuncs are
written nowadays.

The crux of the problem is that ifunc symbols are really function
descriptors, not text symbols:

   44: 0000000000020060    104 FUNC    GLOBAL DEFAULT       18 gnu_ifunc_resolver
   54: 0000000000020060    104 GNU_IFUNC GLOBAL DEFAULT     18 gnu_ifunc

But, currently GDB only knows about ifunc symbols that are text
symbols.  GDB's support happens to work in practice for PPC64 when the
ifunc and resolver are one and only, like in the current
gdb.base/gnu-ifunc.exp testcase:

   15: 0000000000020060    104 GNU_IFUNC GLOBAL DEFAULT       18 gnu_ifunc

because in that case, the synthetic ".gnu_ifunc" entry point text
symbol that bfd creates from the actual GNU ifunc "gnu_ifunc" function
(descriptor) symbol ends up with the the "is a gnu ifunc" flag set /
copied over:

  (gdb) maint print msymbols
  ...
  [ 8] i 0x9c4 .gnu_ifunc section .text                <<< mst_text_gnu_ifunc
  ...
  [29] D 0x20060 gnu_ifunc section .opd  crtstuff.c    <<< mst_data

But, if the resolver gets a distinct symbol/name from the ifunc
symbol, then we end up with this:

  (gdb) maint print msymbols
  [ 8] T 0x9e4 .gnu_ifunc_resolver section .text               <<< mst_text
  ...
  [29] D 0x20060 gnu_ifunc section .opd  crtstuff.c            <<< mst_data
  [30] D 0x20060 gnu_ifunc_resolver section .opd  crtstuff.c   <<< mst_data

I have a follow up bfd patch that turns that into:

   (gdb) maint print msymbols
+  [ 8] i 0x9e4 .gnu_ifunc section .text               <<< mst_text_gnu_ifunc
   [ 8] T 0x9e4 .gnu_ifunc_resolver section .text      <<< mst_text
   ...
   [29] D 0x20060 gnu_ifunc section .opd  crtstuff.c
   [30] D 0x20060 gnu_ifunc_resolver section .opd  crtstuff.c

but that won't help everything.  We still need this patch.

Specifically, when we do a symbol lookup by name, like e.g., to call a
function (see c-exp.y hunk), e.g., "p gnu_ifunc()", then we need to
know that the found "gnu_ifunc" minimal symbol is an ifunc in order to
do some special processing.  But, on PPC, that lookup by name finds
the function descriptor symbol, which presently is just a mst_data
symbol, while at present, we look for mst_text_gnu_ifunc symbols to
decide whether to do special GNU ifunc processing.  In most of those
places, we could try to resolve the function descriptor with
gdbarch_convert_from_func_ptr_addr, and then lookup the minimal symbol
at the resolved PC, see if that finds a minimal symbol of type
mst_text_gnu_ifunc.  If so, then we could assume that the original
mst_dadta / function descriptor "gnu_ifunc" symbol was an ifunc.  I
tried it, and it mostly works, even if it's not the most efficient.

However, there's one case that can't work with such a design -- it's
that of the user calling the ifunc resolver directly to debug it, like
"p gnu_ifunc_resolver(0)", expecting that to return the function
pointer of the final function (which is exercised by the new tests
added later).  In this case, with the not-fully-working solution, we'd
resolve the function descriptor, find that there's an
mst_text_gnu_ifunc symbol for the resolved address, and proceed
calling the function as if we tried to call "gnu_ifunc", the
user-visible GNU ifunc symbol, instead of the resolver.  I.e., it'd be
impossible to call the resolver directly as a normal function.

Introducing mst_data_gnu_ifunc eliminates the need for several
gdbarch_convert_from_func_ptr_addr calls, and, fixes the "call
resolver directly" use case mentioned above too.  It's the cleanest
approach I could think of.

In sum, we make GNU ifunc function descriptor symbols get a new
"mst_data_gnu_ifunc" minimal symbol type instead of the bare mst_data
type.  So when symbol lookup by name finds such a minimal symbol, we
know we found an ifunc symbol, without resolving the entry/text
symbol.  If the user calls the the resolver symbol instead, like "p
gnu_ifunc_resolver(0)", then we'll find the regular mst_data symbol
for "gnu_ifunc_resolver", and we'll call the resolver function as just
another regular function.

With this, most of the GNU ifunc tests added by a later patch pass on
PPC64 too.  The following bfd patch fixes the remaining issues.

gdb/ChangeLog:
2018-04-26  Pedro Alves  <palves@redhat.com>

	* breakpoint.c (set_breakpoint_location_function): Handle
	mst_data_gnu_ifunc.
	* c-exp.y (variable production): Handle mst_data_gnu_ifunc.
	* elfread.c (elf_symtab_read): Give data symbols with
	BSF_GNU_INDIRECT_FUNCTION set mst_data_gnu_ifunc type.
	(elf_rel_plt_read): Update comment.
	* linespec.c (convert_linespec_to_sals): Handle
	mst_data_gnu_ifunc.
	(minsym_found): Handle mst_data_gnu_ifunc.
	* minsyms.c (msymbol_is_function, minimal_symbol_reader::record)
	(find_solib_trampoline_target): Handle mst_data_gnu_ifunc.
	* parse.c (find_minsym_type_and_address): Handle
	mst_data_gnu_ifunc.
	* symmisc.c (dump_msymbols): Handle mst_data_gnu_ifunc.
	* symtab.c (find_gnu_ifunc): Handle mst_data_gnu_ifunc.
	* symtab.h (minimal_symbol_type) <mst_text_gnu_ifunc>: Update
	comment.
	<mst_data_gnu_ifunc>: New enumerator.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PPC64: always make synthetic .text symbols for GNU ifunc symbols
@ 2018-04-26 18:05 sergiodj+buildbot
  2018-04-28 17:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 18:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bfa5bd2ab31a8abb23cb442d51fe6c3836028880 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: bfa5bd2ab31a8abb23cb442d51fe6c3836028880

PPC64: always make synthetic .text symbols for GNU ifunc symbols

If you create an ifunc using GCC's __attribute__ ifunc, like:

 extern int gnu_ifunc (int arg);
 static int gnu_ifunc_target (int arg) { return 0; }
 __typeof (gnu_ifunc) *gnu_ifunc_resolver (unsigned long hwcap) { return gnu_ifunc_target; }
 __typeof (gnu_ifunc) gnu_ifunc __attribute__ ((ifunc ("gnu_ifunc_resolver")));

then you end up with two (function descriptor) symbols, one for the
ifunc itself, and another for the resolver:

   (...)
   12: 0000000000020060    104 FUNC    GLOBAL DEFAULT       18 gnu_ifunc_resolver
   (...)
   16: 0000000000020060    104 GNU_IFUNC GLOBAL DEFAULT       18 gnu_ifunc
   (...)

Both ifunc and resolver symbols have the same address/value, so
ppc64_elf_get_synthetic_symtab only creates a synthetic text symbol
for one of them.  In the case above, it ends up being created for the
resolver, only:

  (gdb) maint print msymbols
  (...)
  [ 7] t 0x980 .frame_dummy section .text
  [ 8] T 0x9e4 .gnu_ifunc_resolver section .text
  [ 9] T 0xa58 __glink_PLTresolve section .text
  (...)

GDB needs to know when a program stepped into an ifunc resolver, so
that it can know whether to step past the resolver into the target
function without the user noticing.  The way GDB does it is my
checking whether the current PC points to an ifunc symbol (since
resolver and ifunc have the same address by design).

The problem is then that ppc64_elf_get_synthetic_symtab never creates
the synchetic symbol for the ifunc, so GDB stops stepping at the
resolver (in a test added by the following patch):

  (gdb) step
  gnu_ifunc_resolver (hwcap=21) at gdb/testsuite/gdb.base/gnu-ifunc-lib.c:33
  33      {
  (gdb) FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=1: resolver_debug=1: final_debug=0: step

After this commit, we get:

  [ 8] i 0x9e4 .gnu_ifunc section .text
  [ 9] T 0x9e4 .gnu_ifunc_resolver section .text

And stepping an ifunc call takes to the final function:
  (gdb) step
  0x00000000100009e8 in .final ()
  (gdb) PASS: gdb.base/gnu-ifunc.exp: resolver_attr=1: resolver_debug=1: final_debug=0: step

An alternative to touching bfd I considered was for GDB to check
whether there's an ifunc data symbol / function descriptor that points
to the current PC, whenever the program stops, but discarded it
because we'd have to do a linear scan over .opd over an over to find a
matching function descriptor for the current PC.  At that point I
considered caching that info, but quickly dismissed it as then that
has no advantage (memory or performance) over just creating the
synthetic ifunc text symbol in the first place.

I ran the binutils and ld testsuites on PPC64 ELFv1 (machine gcc110 on
the GCC compile farm), and saw no regressions.  This commit is part of
a GDB patch series that includes GDB tests that fail without this fix.

bfd/ChangeLog:
2018-04-26  Pedro Alves  <palves@redhat.com>

	* elf64-ppc.c (ppc64_elf_get_synthetic_symtab): Don't consider
	ifunc and non-ifunc symbols duplicates.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Extend GNU ifunc testcases
@ 2018-04-26 18:42 sergiodj+buildbot
  2018-04-28 20:36 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 18:42 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c7075ad5030c4c2e79a04f3517689b751ff41860 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: c7075ad5030c4c2e79a04f3517689b751ff41860

Extend GNU ifunc testcases

This patch extends/rewrites the gdb.base/gnu-ifunc.exp testcase to
cover the many different fixes in earlier patches.  (This was actually
what encovered most of the problems.)

The current testcase uses an ifunc symbol with the same name as the
ifunc resolver symbol and makes sure to compile the ifunc resolver
without debug info.  That does not model how ifuncs are implemented in
gcc/ifunc nowadays.  Instead, what we have is that the glibc ifunc
resolvers nowadays are written in C and end up with debug info.

Also, in some cases the ifunc target is written in assembly, but in
other cases it's written in C.  In the case of target function written
in C, if the target function has debug info, when we set a break on
the ifunc, we want to set it past the prologue of the target function.
Currently GDB gets that wrong.

To make sure we cover all the different scenarios, the testcase is
tweaked to cover all the different combinations of

 - An ifunc resolver with the same name as the user-visible symbol vs
   an ifunc resolver with a different name as the user-visible symbol.

 - ifunc resolver compiled with and without debug info.

 - ifunc target function compiled with and without debug info.

The testcase currently sets breakpoints on ifuncs, calls ifunc
functions, steps into ifunc functions, etc.  After this series, this
all works and the testcase passes cleanly.

While working on this, I noticed that "b gnu_ifunc" before and after
the inferior resolved the ifunc would end up with a breakpoint with
different locations.  That's now covered by new tests inside the new
"set-break" procedure.

It also tests other things like making sure we can't call an ifunc
without a return-type case if we don't know the type of the target.
And making sure that we pass enough arguments when we do know the
type.

gdb/testsuite/ChangeLog:
2018-04-26  Pedro Alves  <palves@redhat.com>

	* gdb.base/gnu-ifunc-final.c: New file.
	* gdb.base/gnu-ifunc.c (final): Delete, moved to gnu-ifunc-final.c.
	* gdb.base/gnu-ifunc.exp (executable): Delete.
	(staticexecutable): Adjust.
	(lib_opts, exec_opts): Delete.
	(make_binsuffix, build, set-break): New procedures.
	(misc_tests): New, with tests factored out from the top level.
	(top level): Test different combinations of ifunc resolver name,
	resolver with and with debug info, and ifunc target with and
	without debug info.  Wrap static tests with with_target_prefix.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix resolving GNU ifunc bp locations when inferior runs resolver
@ 2018-04-26 19:45 sergiodj+buildbot
  2018-04-28 22:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 19:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 79188d8d27a8885aee2ca4ff55238219a6aa7228 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 79188d8d27a8885aee2ca4ff55238219a6aa7228

Fix resolving GNU ifunc bp locations when inferior runs resolver

I noticed that if you set a breakpoint on an ifunc before the ifunc is
resolved, and then let the program call the ifunc, thus resolving it,
GDB end up with a location for that original breakpoint that is
pointing to the ifunc target, but it is left pointing to the first
address of the function, instead of after its prologue.  After
prologue is what you get if you create a new breakpoint at that point.

1) With no debug info for the target function:

  1.a) Set before resolving, and then program continued passed resolving:

    Num     Type           Disp Enb Address            What
    1       breakpoint     keep y   0x0000000000400753 <final>

  1.b) Breakpoint set after inferior resolved ifunc:

    Num     Type           Disp Enb Address            What
    2       breakpoint     keep y   0x0000000000400757 <final+4>


2) With debug info for the target function:

   1.a) Set before resolving, and then program continued passed resolving:

     Num     Type           Disp Enb Address            What
     1       breakpoint     keep y   0x0000000000400753 in final at gdb/testsuite/gdb.base/gnu-ifunc-final.c:20

   1.b) Breakpoint set after inferior resolved ifunc:

     Num     Type           Disp Enb Address            What
     2       breakpoint     keep y   0x000000000040075a in final at gdb/testsuite/gdb.base/gnu-ifunc-final.c:21

The problem is that elf_gnu_ifunc_resolver_return_stop (called by the
internal breakpoint that traps the resolver returning) does not agree
with linespec.c:minsym_found.  It does not skip to the function's
start line (i.e., past the prologue).  We can now use the
find_function_start_sal overload added by the previous commmit to fix
this.

New tests included, which fail before the patch, and pass afterwards.

gdb/ChangeLog:
2018-04-26  Pedro Alves  <palves@redhat.com>

	* elfread.c (elf_gnu_ifunc_resolver_return_stop): Use
	find_function_start_sal instead of find_pc_line.

gdb/testsuite/ChangeLog:
2018-04-26  Pedro Alves  <palves@redhat.com>

	* gdb.base/gnu-ifunc.exp (set-break): Test that GDB resolves
	ifunc breakpoint locations correctly of ifunc breakpoints set
	while the program resolves the ifunc.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Enable Intel MOVDIRI, MOVDIR64B instructions.
@ 2018-04-26 22:02 sergiodj+buildbot
  2018-04-29  1:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 22:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a914a7c95895161c99533d5919b8504b37ea54a0 ***

Author: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
Branch: master
Commit: a914a7c95895161c99533d5919b8504b37ea54a0

Enable Intel MOVDIRI, MOVDIR64B instructions.

gas/
	* config/tc-i386.c (cpu_arch): Add .movdir, .movdir64b.
	(cpu_noarch): Likewise.
	(process_suffix): Add check for register size.
	* doc/c-i386.texi: Document movdiri, movdir64b.
	* testsuite/gas/i386/i386.exp: Run MOVDIR{I,64B} tests.
	* testsuite/gas/i386/movdir-intel.d: New test.
	* testsuite/gas/i386/movdir.d: Likewise.
	* testsuite/gas/i386/movdir.s: Likewise.
	* testsuite/gas/i386/movdir64b-reg.s: Likewise.
	* testsuite/gas/i386/movdir64b-reg.l: Likewise.
	* testsuite/gas/i386/x86-64-movdir-intel.d: Likewise.
	* testsuite/gas/i386/x86-64-movdir.d: Likewise.
	* testsuite/gas/i386/x86-64-movdir.s: Likewise.
	* testsuite/gas/i386/x86-64-movdir64b-reg.s: Likewise.
	* testsuite/gas/i386/x86-64-movdir64b-reg.l: Likewise.

opcodes/
	* i386-dis.c (enum): Add PREFIX_0F38F8, PREFIX_0F38F9.
	(prefix_table): New instructions (see prefix above).
	Add Gva macro and handling in OP_G.
	* i386-gen.c (cpu_flag_init): Add CPU_MOVDIRI_FLAGS,
	CPU_MOVDIR64B_FLAGS.
	(cpu_flags): Likewise.
	(opcode_modifiers): Add AddrPrefixOpReg.
	(i386_opcode_modifier): Likewise.
	* i386-opc.h (enum): Add CpuMOVDIRI, CpuMOVDIR64B.
	(i386_cpu_flags): Likewise.
	* i386-opc.tbl: Add movidir{i,64b}.
	* i386-init.h: Regenerate.
	* i386-tbl.h: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix remote 'g' command error handling (PR remote/9665)
@ 2018-04-26 23:25 sergiodj+buildbot
  2018-04-29  3:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 23:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b75abf5bb636869fd893ecf98414b8b2fe0d4a12 ***

Author: Andrzej Kaczmarek <andrzej.kaczmarek@codecoup.pl>
Branch: master
Commit: b75abf5bb636869fd893ecf98414b8b2fe0d4a12

Fix remote 'g' command error handling (PR remote/9665)

'g' command returns hex-string as response so simply checking for 'E'
to determine if it failed is not enough and can trigger spurious error
messages.  For example, invalid behaviour can be easily triggered on
Cortex-M as follows:

  (gdb) set $r0 = 0xe0
  Sending packet: $P0=e0000000#72...Packet received: OK
  Packet P (set-register) is supported
  Sending packet: $g#67...Packet received: E0000000849A0020...
  Remote failure reply: E0000000849A0020...

This patch fixes the problem by calling putpkt()/getpkt() directly and
checking result with packet_check_result().  This works fine since Enn
response has odd number of bytes while proper response has even number
of bytes.

Also, remote_send() is now not used anywhere so it can be removed.

gdb/Changelog:
2018-04-26  Andrzej Kaczmarek  <andrzej.kaczmarek@codecoup.pl>

	PR remote/9665
	* remote.c (send_g_packet): Use putpkt/getpkt/packet_check_result
	instead of remote_send.
	(remote_send): Remove.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PR23123, PowerPC32 ifunc regression
@ 2018-04-27  9:52 sergiodj+buildbot
  2018-04-29  6:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-27  9:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 04383fd15b3b82d824df9c72e3ade88c43bfb5ac ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 04383fd15b3b82d824df9c72e3ade88c43bfb5ac

PR23123, PowerPC32 ifunc regression

Two of the gcc ifunc tests fail for ppc32, due to my pr22374 fix being
a little too enthusiastic in trimming PLT entries.  ppc64 doesn't have
the same failures because ppc64_elf_check_relocs happens to set
needs_plt for any ifunc reloc.

	PR 23123
	PR 22374
	* elf32-ppc.c (ppc_elf_adjust_dynamic_symbol): Don't drop plt
	relocs for ifuncs.
	* elf64-ppc.c (ppc64_elf_adjust_dynamic_symbol): Comment fixes.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Regenerate some files for recent ARM patches
@ 2018-04-27 11:12 sergiodj+buildbot
  2018-04-29  9:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-27 11:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ffa389a39655f4b35d583783e49fa5b31c288e8f ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: ffa389a39655f4b35d583783e49fa5b31c288e8f

Regenerate some files for recent ARM patches

bfd/
	* bfd-in2.h: Regenerate.
	* libbfd.h: Regenerate.
ld/
	* po/BLD-POTFILES.in: Regenerate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Revert "Enable Intel MOVDIRI, MOVDIR64B instructions."
@ 2018-04-27 13:09 sergiodj+buildbot
  2018-04-29 13:54 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-27 13:09 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT aa178437393fd97f706c3f8bdf60ab2cc53a8cb4 ***

Author: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
Branch: master
Commit: aa178437393fd97f706c3f8bdf60ab2cc53a8cb4

Revert "Enable Intel MOVDIRI, MOVDIR64B instructions."

This reverts commit a914a7c95895161c99533d5919b8504b37ea54a0.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Enable -Wsuggest-override
@ 2018-04-27 19:21 sergiodj+buildbot
  2018-04-29 15:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-27 19:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 632e107b32c0fe8aede62e070b00756e9fdd2c01 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 632e107b32c0fe8aede62e070b00756e9fdd2c01

Enable -Wsuggest-override

I noticed the existence of -Wsuggest-override and so this patch
enables it for gdb.  It found a few spots that could use "override".
Also I went ahead and removed all uses of the "OVERRIDE" macro.

Using override is beneficial because it makes it harder to change a
base class and then forget to change a derived class.

Tested by the buildbot.

ChangeLog
2018-04-27  Tom Tromey  <tom@tromey.com>

	* configure: Rebuild.
	* warning.m4 (AM_GDB_WARNINGS): Add -Wsuggest-override.
	* dwarf2loc.c (class dwarf_evaluate_loc_desc): Use "override", not
	"OVERRIDE".
	(class symbol_needs_eval_context): Likewise.
	* dwarf2read.c (mock_mapped_index::symbol_name_count)
	(mock_mapped_index::symbol_name_at): Use "override".  Remove
	"virtual".
	* dwarf2-frame.c (dwarf_expr_executor::get_addr_index): Use
	"override".
	(class dwarf_expr_executor): Use "override", not "OVERRIDE".
	* aarch64-tdep.c (instruction_reader::read): Use "override".
	(instruction_reader_test::read): Likewise.
	* arm-tdep.c (instruction_reader::read): Use "override".
	(instruction_reader_thumb::read): Likewise.

gdbserver/ChangeLog
2018-04-27  Tom Tromey  <tom@tromey.com>

	* configure: Rebuild.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add inclusive range support for Rust
@ 2018-04-27 20:09 sergiodj+buildbot
  2018-04-29 17:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-27 20:09 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6873858b7e464e114f9a877e216949ad8350b4cf ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 6873858b7e464e114f9a877e216949ad8350b4cf

Add inclusive range support for Rust

This is version 2 of the patch to add inclusive range support for
Rust.  I believe it addresses all review comments.

Rust recently stabilized the inclusive range feature:

    https://github.com/rust-lang/rust/issues/28237

An inclusive range is an expression like "..= EXPR" or "EXPR ..=
EXPR".  It is like an ordinary range, except the upper bound is
inclusive, not exclusive.

This patch adds support for this feature to gdb.

Regression tested on x86-64 Fedora 27.

2018-04-27  Tom Tromey  <tom@tromey.com>

	PR rust/22545:
	* rust-lang.c (rust_inclusive_range_type_p): New function.
	(rust_range): Handle inclusive ranges.
	(rust_compute_range): Likewise.
	* rust-exp.y (struct rust_op) <inclusive>: New field.
	(DOTDOTEQ): New constant.
	(range_expr): Add "..=" productions.
	(operator_tokens): Add "..=" token.
	(ast_range): Add "inclusive" parameter.
	(convert_ast_to_expression) <case OP_RANGE>: Handle inclusive
	ranges.
	* parse.c (operator_length_standard) <case OP_RANGE>: Handle new
	bounds values.
	* expression.h (enum range_type) <NONE_BOUND_DEFAULT_EXCLUSIVE,
	LOW_BOUND_DEFAULT_EXCLUSIVE>: New constants.
	Update comments.
	* expprint.c (print_subexp_standard): Handle new bounds values.
	(dump_subexp_body_standard): Likewise.

2018-04-27  Tom Tromey  <tom@tromey.com>

	PR rust/22545:
	* gdb.rust/simple.exp: Add inclusive range tests.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add libcc1 v1 compatibility to C compile feature
@ 2018-04-27 20:40 sergiodj+buildbot
  2018-04-30  3:35 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-27 20:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 476d250ee86c37386b02b0634a59aae13d07a038 ***

Author: Alexandre Oliva <aoliva@redhat.com>
Branch: master
Commit: 476d250ee86c37386b02b0634a59aae13d07a038

Add libcc1 v1 compatibility to C compile feature

This patch adds v1 compatibiltiy to the C compile feature.  The only change
in v1 concerns the handling of integer types, which permits GDB to specify
the built-in name for the type.

As far as I know, the C frontend is still on v0, so this patch is purely
precautionary. [By default C++ compile uses the equivalent of the C
frontend's int_type and float_type (aka the "v1" versions).]

gdb/ChangeLog:

	* compile/compile-c-types.c (convert_int, convert_float):
	Update for C FE v1.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix race when building ada-lex.c
@ 2018-04-29 16:18 sergiodj+buildbot
  2018-04-30  4:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-29 16:18 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cd8c76e410a5f16a170cc680be1ae2ecb5528821 ***

Author: John Reiser <jreiser@BitWagon.com>
Branch: master
Commit: cd8c76e410a5f16a170cc680be1ae2ecb5528821

Fix race when building ada-lex.c

Prevent a race when building ada-lex.c, and any target of rules .c:.l or
.c:.y.  The target should be written only at the last step, else SIGINT
(^C) can leave an inconsistent state.  Being .PRECIOUS makes it even
worse.

gdb/ChangeLog:

	PR build/22873
	* gdb/Makefile.in: (.c:.l, .c:.y): Write the target only in the
	last step, and do it atomically.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] proc-events.c: fix compilation on Solaris
@ 2018-04-29 16:52 sergiodj+buildbot
  2018-04-30  7:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-29 16:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e28b63a989caffa4a6fba1aaf0d8992b37d13da8 ***

Author: Fabian Groffen <grobian@gentoo.org>
Branch: master
Commit: e28b63a989caffa4a6fba1aaf0d8992b37d13da8

proc-events.c: fix compilation on Solaris

This patch adds a guard around the usage of SYS_uuidsys, which is
not available on (at least) Solaris 10 and OpenIndiana.

gdb/ChangeLog:

	PR gdb/22950
	* proc-events.c (init_syscall_table): Guard usage os SYS_uuidsys
	with #ifdef.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use bool in read_index_from_section
@ 2018-04-30 15:27 sergiodj+buildbot
  2018-04-30 15:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-30 15:27 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d33bc52e51fdb6c464c1c8e8fdf9b2007b522b57 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: d33bc52e51fdb6c464c1c8e8fdf9b2007b522b57

Use bool in read_index_from_section

gdb/ChangeLog:

	* dwarf2read.c (read_index_from_section): Use bool.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] This patch adds support to objdump for disassembly of NFP (Netronome Flow Processor) ELF files (.nffw) as well as some basic readelf support.
@ 2018-04-30 16:10 sergiodj+buildbot
  2018-04-30 18:49 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-30 16:10 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fe944acf8f858cfe6bcfd00670a88847a464717c ***

Author: Francois H. Theron <francois.theron@netronome.com>
Branch: master
Commit: fe944acf8f858cfe6bcfd00670a88847a464717c

This patch adds support to objdump for disassembly of NFP (Netronome Flow Processor) ELF files (.nffw) as well as some basic readelf support.

bfd	* Makefile.am: Added NFP files to build.
	* archures.c: Added bfd_arch_nfp
	* config.bfd: Added NFP support.
	* configure.ac: Added NFP support.
	* cpu-nfp.c: New, for NFP support.
	* elf-bfd.h: Added elf_section_info()
	* elf64-nfp.c: New, for NFP support.
	* po/SRC-POTFILES.in: Added NFP source files.
	* targets.c: Added nfp_elf64_vec
	* bfd-in2.h: Regenerate.
	* Makefile.in: Regenerate.
	* configure: Regenerate.

binutils* readelf.c: Very basic support for EM_NFP and its section types.
	* testsuite/binutils-all/nfp: New directory.
	* testsuite/binutils-all/nfp/objdump.exp: New file.  Run new
	tests.
	* testsuite/binutils-all/nfp/test2_ctx8.d: New file.
	* testsuite/binutils-all/nfp/test2_no-pc_ctx4.d: New file.
	* testsuite/binutils-all/nfp/test1.d: New file.
	* testsuite/binutils-all/nfp/nfp6000.nffw: New file.
	* testsuite/binutils-all/nfp/test2_nfp6000.nffw: New file.
	* NEWS: Mention the new support.

include	* dis-asm.h: Added print_nfp_disassembler_options prototype.
	* elf/common.h: Added EM_NFP, officially assigned. See Google Group
	Generic System V Application Binary Interface.
	* elf/nfp.h: New, for NFP support.
	* opcode/nfp.h: New, for NFP support.

opcodes	Makefile.am: Added nfp-dis.c.
	configure.ac: Added bfd_nfp_arch.
	disassemble.h: Added print_insn_nfp prototype.
	disassemble.c: Added ARCH_nfp and call to print_insn_nfp
	nfp-dis.c: New, for NFP support.
	po/POTFILES.in: Added nfp-dis.c to the list.
	Makefile.in: Regenerate.
	configure: Regenerate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add initial type alignment support
@ 2018-04-30 17:32 sergiodj+buildbot
  2018-04-30 21:05 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-30 17:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2b4424c35b9ebabaab8588b2ba6c38935a48efec ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 2b4424c35b9ebabaab8588b2ba6c38935a48efec

Add initial type alignment support

This adds some basic type alignment support to gdb.  It changes struct
type to store the alignment, and updates dwarf2read.c to handle
DW_AT_alignment.  It also adds a new gdbarch method and updates
i386-tdep.c.

None of this new functionality is used anywhere yet, so tests will
wait until the next patch.

2018-04-30  Tom Tromey  <tom@tromey.com>

	* i386-tdep.c (i386_type_align): New function.
	(i386_gdbarch_init): Update.
	* gdbarch.sh (type_align): New method.
	* gdbarch.c, gdbarch.h: Rebuild.
	* arch-utils.h (default_type_align): Declare.
	* arch-utils.c (default_type_align): New function.
	* gdbtypes.h (TYPE_ALIGN_BITS): New define.
	(struct type) <align_log2>: New field.
	<instance_flags>: Now a bitfield.
	(TYPE_RAW_ALIGN): New macro.
	(type_align, type_raw_align, set_type_align): Declare.
	* gdbtypes.c (type_align, type_raw_align, set_type_align): New
	functions.
	* dwarf2read.c (quirk_rust_enum): Set type alignment.
	(get_alignment, maybe_set_alignment): New functions.
	(read_structure_type, read_enumeration_type, read_array_type)
	(read_set_type, read_tag_pointer_type, read_tag_reference_type)
	(read_subrange_type, read_base_type): Set type alignment.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Handle alignof and _Alignof
@ 2018-04-30 18:19 sergiodj+buildbot
  2018-05-01  0:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-30 18:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 007e1530347330d4dbba387c4e35aae05bc06498 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 007e1530347330d4dbba387c4e35aae05bc06498

Handle alignof and _Alignof

This adds alignof and _Alignof to the C/C++ expression parser, and
adds new tests to test the features.  The tests are written to try to
ensure that gdb's knowledge of alignment rules stays in sync with the
compiler's.

2018-04-30  Tom Tromey  <tom@tromey.com>

	PR exp/17095:
	* NEWS: Update.
	* std-operator.def (UNOP_ALIGNOF): New operator.
	* expprint.c (dump_subexp_body_standard) <case UNOP_ALIGNOF>:
	New.
	* eval.c (evaluate_subexp_standard) <case UNOP_ALIGNOF>: New.
	* c-lang.c (c_op_print_tab): Add alignof.
	* c-exp.y (ALIGNOF): New token.
	(exp): Add "ALIGNOF" production.
	(ident_tokens): Add _Alignof and alignof.

2018-04-30  Tom Tromey  <tom@tromey.com>

	PR exp/17095:
	* gdb.dwarf2/dw2-align.exp: New file.
	* gdb.cp/align.exp: New file.
	* gdb.base/align.exp: New file.
	* lib/gdb.exp (gdb_int128_helper): New proc.
	(has_int128_c, has_int128_cxx): New caching procs.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Expose type alignment on gdb.Type
@ 2018-04-30 19:20 sergiodj+buildbot
  2018-05-01  2:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-30 19:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6d7bb8246b3beaf60ea9c2abe183705e876519cd ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 6d7bb8246b3beaf60ea9c2abe183705e876519cd

Expose type alignment on gdb.Type

This adds an "alignof" attribute to gdb.Type in the Python API.

2018-04-30  Tom Tromey  <tom@tromey.com>

	* NEWS: Mention Type.align.
	* python/py-type.c (typy_get_alignof): New function.
	(type_object_getset): Add "alignof".

2018-04-30  Tom Tromey  <tom@tromey.com>

	* python.texi (Types In Python): Document Type.align.

2018-04-30  Tom Tromey  <tom@tromey.com>

	* gdb.python/py-type.exp: Check align attribute.
	* gdb.python/py-type.c: New "aligncheck" global.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove rust_type_alignment
@ 2018-04-30 20:28 sergiodj+buildbot
  2018-05-01  6:04 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-30 20:28 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2fff16dd8c25831fb5fbf198ca86d5befff629be ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 2fff16dd8c25831fb5fbf198ca86d5befff629be

Remove rust_type_alignment

rust_type_alignment is not needed now that gdb has type alignment
code.  So, this removes it.

2018-04-30  Tom Tromey  <tom@tromey.com>

	* rust-lang.c (rust_type_alignment): Remove.
	(rust_composite_type): Use type_align.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove long_long_align_bit gdbarch attribute
@ 2018-04-30 20:51 sergiodj+buildbot
  2018-05-01 10:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-30 20:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e11fb955fbab035748fa53ffc30c103157a284b6 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: e11fb955fbab035748fa53ffc30c103157a284b6

Remove long_long_align_bit gdbarch attribute

This removes the long_long_align_bit gdbarch attribute in favor of
type_align.  This uncovered two possible issues.

First, arc-tdep.c claimed that long long alignment was 32 bits, but as
discussed on the list, ARC has a maximum alignment of 32 bits, so I've
added an arc_type_align function to account for this.

Second, jit.c, the sole user of long_long_align_bit, was confusing
"long long" with uint64_t.  The relevant structure is defined in the
JIT API part of the manual as:

     struct jit_code_entry
     {
       struct jit_code_entry *next_entry;
       struct jit_code_entry *prev_entry;
       const char *symfile_addr;
       uint64_t symfile_size;
     };

I've changed this code to use uint64_t.

2018-04-30  Tom Tromey  <tom@tromey.com>

	* jit.c (jit_read_code_entry): Use type_align.
	* i386-tdep.c (i386_gdbarch_init): Don't call
	set_gdbarch_long_long_align_bit.
	* gdbarch.sh: Remove long_long_align_bit.
	* gdbarch.c, gdbarch.h: Rebuild.
	* arc-tdep.c (arc_type_align): New function.
	(arc_gdbarch_init): Use arc_type_align.  Don't call
	set_gdbarch_long_long_align_bit.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove new_bfd_ref
@ 2018-04-30 21:37 sergiodj+buildbot
  2018-05-01 15:30 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-30 21:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1831a9f9d3346dbf61202d2aba6935f0093487dd ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 1831a9f9d3346dbf61202d2aba6935f0093487dd

Remove new_bfd_ref

For gdb_bfd_ref_ptr, gdb already had a convenience function like the
new gdb_ref_ptr::new_reference -- called new_bfd_ref.  This patch
removes it in favor of the new common function.

While doing this I also noticed that the comment for gdb_bfd_open was
incorrect (in a way related to reference counting), so this patch
updates the comment as well.

ChangeLog
2018-04-30  Tom Tromey  <tom@tromey.com>

	* symfile-mem.c (symbol_file_add_from_memory): Use new_reference.
	* gdb_bfd.h (new_bfd_ref): Remove.
	(gdb_bfd_open): Update comment.
	* gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
	(gdb_bfd_openw, gdb_bfd_openr_iovec, gdb_bfd_record_inclusion)
	(gdb_bfd_fdopenr): Use new_reference.
	* exec.c (exec_file_attach): Use new_reference.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Introduce ref_ptr::new_reference
@ 2018-04-30 21:46 sergiodj+buildbot
  2018-05-01 12:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-30 21:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7c1b5f3db73d7ecab03dc4e866e291582935fb04 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 7c1b5f3db73d7ecab03dc4e866e291582935fb04

Introduce ref_ptr::new_reference

I noticed a common pattern with gdb::ref_ptr, where callers would
"incref" and then create a new wrapper object, like:

    Py_INCREF (obj);
    gdbpy_ref<> ref (obj);

The ref_ptr constructor intentionally does not acquire a new
reference, but it seemed to me that it would be reasonable to add a
static member function that does so.

In this patch I chose to call the function "new_reference".  I
considered "acquire_reference" as well, but "new" seemed less
ambiguous than "acquire" to me.

ChangeLog
2018-04-30  Tom Tromey  <tom@tromey.com>

	* common/gdb_ref_ptr.h (ref_ptr::new_reference): New static
	method.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use new_reference for struct value
@ 2018-04-30 21:56 sergiodj+buildbot
  2018-05-01 20:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-30 21:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bbfa6f00867946985b954bbec233c0f25f14ac5c ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: bbfa6f00867946985b954bbec233c0f25f14ac5c

Use new_reference for struct value

value_incref returned its argument just as a convenience, which in the
end turned out to only be used in precisely the cases where
new_reference helps.  So, this patch changes value_incref to return
void and changes some value-using code to use new_reference.

I also noticed that the comments for value_incref and value_decref
were swapped, so this patch fixes those.

ChangeLog
2018-04-30  Tom Tromey  <tom@tromey.com>

	* varobj.c (install_new_value): Use new_reference.
	* value.h (value_incref): Return void.  Swap intro comment with
	value_decref.
	* value.c (set_value_parent): Use new_reference.
	(value_incref): Return void.  Update intro comment.
	(release_value): Use new_reference.
	* dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Use new_reference.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Change Python code to use new_reference
@ 2018-04-30 22:16 sergiodj+buildbot
  2018-05-01 21:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-30 22:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7c66fffc1f3dae0b921ae3cf8139824804cf0705 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 7c66fffc1f3dae0b921ae3cf8139824804cf0705

Change Python code to use new_reference

This changes a few spots in the Python code to use new_reference
rather than the manual incref+constructor that was previously being
done.

ChangeLog
2018-04-30  Tom Tromey  <tom@tromey.com>

	* varobj.c (varobj_set_visualizer): Use new_reference.
	* python/python.c (gdbpy_decode_line): Use new_reference.
	* python/py-cmd.c (cmdpy_function, cmdpy_completer_helper): Use
	new_reference.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Make do_is_mi_like_p const.
@ 2018-04-30 23:05 sergiodj+buildbot
  2018-05-02  1:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-30 23:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4904c3c6b69d5c7b5e4682220c1d9503e00a457e ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 4904c3c6b69d5c7b5e4682220c1d9503e00a457e

Make do_is_mi_like_p const.

This changes ui_out to make is_mi_like_p and do_is_mi_like_p "const".

ChangeLog
2018-04-30  Tom Tromey  <tom@tromey.com>

	* ui-out.c: Update.
	* cli-out.h (cli_ui_out::do_is_mi_like_p): Update.
	* ui-out.h (ui_out::is_mi_like_p): Now const.
	(ui_out::do_is_mi_like_p): Now const.
	* mi/mi-out.h (mi_ui_out::do_is_mi_like_p): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove some uses of is_mi_like_p from py-framefilter.c
@ 2018-04-30 23:38 sergiodj+buildbot
  2018-05-02  2:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-30 23:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2038b7fdf30c39bc4d528cc2e5fbf5403e0ba79e ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 2038b7fdf30c39bc4d528cc2e5fbf5403e0ba79e

Remove some uses of is_mi_like_p from py-framefilter.c

Some uses of is_mi_like_p in py-framefilter.c were not needed.  In
general a call to ui_out::text, ui_out::message, or ui_out::spaces
does not need to be guarded -- these are already ignored by MI.

ChangeLog
2018-04-30  Tom Tromey  <tom@tromey.com>

	* python/py-framefilter.c (py_print_single_arg)
	(enumerate_locals, py_print_args, py_print_frame): Remove some
	uses of is_mi_like_p.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove some uses of is_mi_like_p from spu-tdep.c
@ 2018-04-30 23:58 sergiodj+buildbot
  2018-05-02  4:55 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-04-30 23:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 40c03530b197d8d6ef550283ecd6684e8d49301b ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 40c03530b197d8d6ef550283ecd6684e8d49301b

Remove some uses of is_mi_like_p from spu-tdep.c

There were a few spots in spu-tdep.c where a use of is_mi_like_p was
not needed.

ChangeLog
2018-04-30  Tom Tromey  <tom@tromey.com>

	* spu-tdep.c (info_spu_mailbox_list, info_spu_dma_cmdlist)
	(info_spu_event_command): Remove some uses of is_mi_like_p.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove a use of is_mi_like_p from tracepoint.c
@ 2018-05-01  0:19 sergiodj+buildbot
  2018-05-02  6:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-01  0:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f3c6ababac34f3a291997f8d5ea6a63949b58b87 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: f3c6ababac34f3a291997f8d5ea6a63949b58b87

Remove a use of is_mi_like_p from tracepoint.c

This removes a use of is_mi_like_p and changes a printf_filtered into
a call to ui_out::text.

ChangeLog
2018-04-30  Tom Tromey  <tom@tromey.com>

	* tracepoint.c (tvariables_info_1): Remove use of is_mi_like_p.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove some is_mi_like_p from breakpoint code
@ 2018-05-01  0:38 sergiodj+buildbot
  2018-05-02 10:05 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-01  0:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2d33446d4d58edcf993f42957cfe9627c88f112f ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 2d33446d4d58edcf993f42957cfe9627c88f112f

Remove some is_mi_like_p from breakpoint code

This removes some uses of is_mi_like_p from the breakpoint code.  The
break-catch-throw.c change brings it into line with what other
breakpoint classes do.  The other changes simply replace printf calls
with ui_out::text or ui_out::message calls.

ChangeLog
2018-04-30  Tom Tromey  <tom@tromey.com>

	* breakpoint.c (mention): Remove use of is_mi_like_p.
	(print_mention_ranged_breakpoint): Likewise.
	* break-catch-throw.c (print_it_exception_catchpoint): Remove use
	of is_mi_like_p.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove a use of is_mi_like_p from darwin-nat-info.c
@ 2018-05-01  1:23 sergiodj+buildbot
  2018-05-02 10:49 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-01  1:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 767619365467fd825c6f3906a49d97a7a6afafd6 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 767619365467fd825c6f3906a49d97a7a6afafd6

Remove a use of is_mi_like_p from darwin-nat-info.c

This removes a use of is_mi_like_p from darwin-nat-info.c.
This is not needed because MI already ignores ui_out::text.

ChangeLog
2018-04-30  Tom Tromey  <tom@tromey.com>

	* darwin-nat-info.c (darwin_debug_regions_recurse): Remove use of
	is_mi_like_p.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [Ada/ravenscar] error during "continue" after task/thread switch
@ 2018-05-01  1:43 sergiodj+buildbot
  2018-05-02 13:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-01  1:43 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0ca1fc291305ee1701b8236c0e26e8d8c5eaf0a2 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 0ca1fc291305ee1701b8236c0e26e8d8c5eaf0a2

[Ada/ravenscar] error during "continue" after task/thread switch

When debugging a program using the Ada ravenscar profile, resuming
a program's execution after having switched to a different task
sometimes yields the following error:

     (gdb) cont
     Continuing.
     Cannot execute this command while the target is running.
     Use the "interrupt" command to stop the target
     and then try again.

In short, the Ravenscar profile is a standardized subset of Ada which
allows tasking (often mapped to threads). We often use it on baremetal
targets where there is no OS support. Thread support is implemented
as a thread target_ops layer. It sits on top of the "remote" layer,
so we can do thread debugging against baremetal targets to which GDB
is connected via "target remote".

What happens, when the user request the program to resume execution,
is the following:

  - the ravenscar-thread target_ops layer gets the order to resume
    the program's execution. The current thread is not the active
    thread in the inferior, and the "remote" layer doesn't know
    about that thread anyway. So what we do is (see ravenscar_resume):

       + switch inferior_ptid to the ptid of the actually active thread;
       + ask the layer beneath us to actually do the resume.

  - Once that's done, the resuming itself is done. But execute_command
    (in top.c) actually does a bit more. More precisely, it unconditionally
    checks to see if the language may no longer be matching the current
    frame:

        check_frame_language_change ();

The problem, here, is that we haven't received the "stop" event
from the inferior, yet. This part will be handled by the event loop,
which is done later. So, checking for the language-change here
doesn't make sense, since we don't really have a frame. In our
case, the error comes from the fact that we end up trying to read
the registers, which causes the error while the remote protocol
is waiting for the event showing the inferior stopped.

This apparently used to work, but it is believed that this was only
accidental. In other words, we had enough information already cached
within GDB that we were able to perform the entire call to
check_frame_language_change without actually querying the target.
On PowerPC targets, this started to fail as a side-effect of a minor
change in the way we get to the regcache during the handling of
software-single-step (which seems fine).

This patch fixes the issue by only calling check_frame_language_change
in cases the inferior isn't running. Otherwise, it skips it, knowing
that the event loop should eventually get to it.

gdb/ChangeLog:

        * top.c (execute_command): Do not call check_frame_language_change
        if the inferior is running.

Tested on x86_64-linux, no regression. Also tested on aarch64-elf,
arm-elf, leon3-elf, and ppc-elf, but using AdaCore's testsuite.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] rust: Fix null deref when casting (PR 23124)
@ 2018-05-01  8:01 sergiodj+buildbot
  2018-05-02 15:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-01  8:01 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1632f8baf04e7351f387e58957fc04498d90987d ***

Author: Dan Robertson <danlrobertson89@gmail.com>
Branch: master
Commit: 1632f8baf04e7351f387e58957fc04498d90987d

rust: Fix null deref when casting (PR 23124)

Fix a null dereference when casting a value to a unit type.

ChangeLog
2018-04-28  Dan Robertson  <danlrobertson89@gmail.com>

	PR rust/23124
	* gdb/rust-exp.y (convert_params_to_types): Ensure that the params
	pointer is not null before dereferencing it.

testsuite/ChangeLog
2018-04-28  Dan Robertson  <danlrobertson89@gmail.com>

	PR rust/23124
	* gdb.rust/expr.exp: Test that the unit type is correctly parsed
	when casting.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add the Netronome Flow Processor as a build target to the top-level configure.ac file.
@ 2018-05-01 15:30 sergiodj+buildbot
  2018-05-02 16:34 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-01 15:30 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1063beb58c9a2f69913682b6923b08e6a7d192aa ***

Author: Francois H. Theron <francois.theron@netronome.com>
Branch: master
Commit: 1063beb58c9a2f69913682b6923b08e6a7d192aa

Add the Netronome Flow Processor as a build target to the top-level configure.ac file.

	* configure.ac: Added "nfp" target.
	* configure: Regenerate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Bring in support for the NFP target in the config.sub file.
@ 2018-05-01 16:18 sergiodj+buildbot
  2018-05-02 20:49 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-01 16:18 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b5778783adc7c3e69b02b95d77a08285c6259982 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: b5778783adc7c3e69b02b95d77a08285c6259982

Bring in support for the NFP target in the config.sub file.

	* config.guess: Synchronize with config project master sources.
	* config.sub: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix unintialized memory in aarch64 opcodes.
@ 2018-05-01 16:57 sergiodj+buildbot
  2018-05-02 21:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-01 16:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b3ac5c6c286c5b5c1909628e85754edfb403cf1a ***

Author: Tamar Christina <tamar.christina@arm.com>
Branch: master
Commit: b3ac5c6c286c5b5c1909628e85754edfb403cf1a

Fix unintialized memory in aarch64 opcodes.

This patch fixes an issue where the memory for the opcode structure is not zero'd before
the first exit branch. So there is one failure mode for which uninitialized memory
is returned.

This causes weird failures when the return code is not checked before inst is used.

opcodes/

	* aarch64-dis.c (aarch64_opcode_decode): Moved memory clear code.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Handle var_zuinteger and var_zuinteger_unlimited from Python
@ 2018-05-02 16:34 sergiodj+buildbot
  2018-05-02 23:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-02 16:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0489430a0e1a3ea302c22c540f3629e471591f23 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 0489430a0e1a3ea302c22c540f3629e471591f23

Handle var_zuinteger and var_zuinteger_unlimited from Python

PR python/20084 points out that the Python API doesn't handle the
var_zuinteger and var_zuinteger_unlimited parameter types.

This patch adds support for these types.

Regression tested on x86-64 Fedora 26.

ChangeLog
2018-05-02  Tom Tromey  <tom@tromey.com>

	PR python/20084:
	* python/python.c (gdbpy_parameter_value): Handle var_zuinteger
	and var_zuinteger_unlimited.
	* python/py-param.c (struct parm_constant): Add PARAM_ZUINTEGER
	and PARAM_ZUINTEGER_UNLIMITED.
	(set_parameter_value): Handle var_zuinteger and
	var_zuinteger_unlimited.
	(add_setshow_generic): Likewise.
	(parmpy_init): Likewise.

doc/ChangeLog
2018-05-02  Tom Tromey  <tom@tromey.com>

	PR python/20084:
	* python.texi (Parameters In Python): Document PARAM_ZUINTEGER and
	PARAM_ZUINTEGER_UNLIMITED.

testsuite/ChangeLog
2018-05-02  Tom Tromey  <tom@tromey.com>

	PR python/20084:
	* gdb.python/py-parameter.exp: Add PARAM_ZUINTEGER and
	PARAM_ZUINTEGER_UNLIMITED tests.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Set test message in py-parameter.exp
@ 2018-05-02 22:57 sergiodj+buildbot
  2018-05-03  1:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-02 22:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 77d3c63b0dc9d275a87d4ea2191ebd3830f6ca4a ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 77d3c63b0dc9d275a87d4ea2191ebd3830f6ca4a

Set test message in py-parameter.exp

Pedro pointed out that a test in py-parameter.exp had an empty
message.  This fixes it.

testsuite/ChangeLog
2018-05-02  Tom Tromey  <tom@tromey.com>

	* gdb.python/py-parameter.exp: Set test message.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Eliminate procfs.c:procfs_use_watchpoints
@ 2018-05-02 23:59 sergiodj+buildbot
  2018-05-03  3:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-02 23:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b5c8fcb1b40a61be5015b02e8cf456a56c258b5d ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: b5c8fcb1b40a61be5015b02e8cf456a56c258b5d

Eliminate procfs.c:procfs_use_watchpoints

Now that procfs.c is only ever used by Solaris, and, both x86 and
SPARC Solaris support watchpoints (*), we don't need the separate
procfs_use_watchpoints function.  Getting rid of it simplifies
C++ification of target_ops.

(*) and I assume that any other Solaris port would use the same kernel
debug API interfaces for watchpoints.  Otherwise, we can worry about
it if it ever happens.

gdb/ChangeLog:
2018-05-02  Pedro Alves  <palves@redhat.com>

	* procfs.c (procfs_stopped_by_watchpoint)
	(procfs_insert_watchpoint, procfs_remove_watchpoint)
	(procfs_region_ok_for_hw_watchpoint, procfs_stopped_data_address):
	Forward declare.
	(procfs_use_watchpoints): Delete, move contents...
	(procfs_target): ... here.
	* procfs.h (procfs_use_watchpoints): Delete declaration.
	* i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
	procfs_use_watchpoints.
	* sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Don't call
	procfs_use_watchpoints.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] More procfs.c simplification
@ 2018-05-03  0:37 sergiodj+buildbot
  2018-05-03  5:27 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-03  0:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c1955e179201e76330a10c400bfa92cab2afbee0 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: c1955e179201e76330a10c400bfa92cab2afbee0

More procfs.c simplification

There are only two architectures using procfs.c (i386/SPARC), and none
of their corresponding nat files overrides any target method.  Move
the add_target calls to procfs.c directly.

gdb/ChangeLog:
2018-05-02  Pedro Alves  <palves@redhat.com>

	* i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
	procfs_target/add_target here.
	* procfs.c (procfs_target): Make static.
	(_initialize_procfs): Call add_target here.
	* procfs.h (struct target_ops): Remove forward declaration.
	(procfs_target): Remove declaration.
	* sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Delete.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Make inf_ptrace_trad Linux-only, move to separate file
@ 2018-05-03  2:12 sergiodj+buildbot
  2018-05-03  7:43 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-03  2:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6798487f5bc66ab9c34ad81fa28ba25d32a00bd9 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 6798487f5bc66ab9c34ad81fa28ba25d32a00bd9

Make inf_ptrace_trad Linux-only, move to separate file

There are only two inf_ptrace_trad_target users, MIPS GNU/Linux and
Alpha GNU/Linux.  They both call it via linux_trad_target.

Move this code out of inf-ptrace.c to a GNU/Linux-specific new file.

Making this code be GNU/Linux-specific simplifies C++ification of
target_ops, because we can make the trad target inherit linux_nat
instead of inheriting inf_ptrace.  That'll be visible in a later patch.

Note this makes linux_target_install_ops an extern function, but that
is temporary -- the function will disappear once target_ops is made a
C++ class with virtual methods, later in the series.  Also, I did not
rename the functions in the new file for a similar reason.  They'll be
renamed again anyway in a couple of patches.

gdb/ChangeLog:
2018-05-02  Pedro Alves  <palves@redhat.com>

	* alpha-linux-nat.c: Include "linux-nat-trad.h" instead of
	"linux-nat.h".
	* configure.nat (alpha-linux, linux-mips): Add linux-nat-trad.o.
	* inf-ptrace.c (inf_ptrace_register_u_offset)
	(inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
	(inf_ptrace_store_register, inf_ptrace_store_registers)
	(inf_ptrace_trad_target): Move to ...
	* linux-nat-trad.c: ... this new file.
	* linux-nat-trad.h: New file.
	* linux-nat.c (linux_target_install_ops): Make extern.
	(linux_trad_target): Delete.
	* linux-nat.h (linux_trad_target): Delete declaration.
	(linux_target_install_ops): Declare.
	* mips-linux-nat.c: Include "linux-nat-trad.h" instead of
	"linux-nat.h".


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] make-target-delegates: line break between return type and function name
@ 2018-05-03  2:19 sergiodj+buildbot
  2018-05-03 16:14 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-03  2:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ad6a4e2dd69f9d343864181b638e166ff1458861 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: ad6a4e2dd69f9d343864181b638e166ff1458861

make-target-delegates: line break between return type and function name

Before the target_ops C++ification, this wasn't necessary simply
because the methods were wrapped in ()'s, like
  '(*to_my_long_method_name) (target_ops *)',
so
  std::vector<long_type_name>(*to_my_long_method_name) ()TARGET_DEFAULT_IGNORE ()

still parsed correctly.  With the (*) gone, we need this.

gdb/ChangeLog:
2018-05-02  Pedro Alves  <palves@redhat.com>

	* make-target-delegates (scan_target_h): Don't trim lines here.
	Replace sequences of tabs and/or whitespace with a single
	whitespace.
	(top level, parsing methods): Trim each line before processing it
	here.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Convert struct target_ops to C++
@ 2018-05-03  2:19 sergiodj+buildbot
  2018-05-03 12:04 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-03  2:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f6ac5f3d63e03a81c4ff3749aba234961cc9090e ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: f6ac5f3d63e03a81c4ff3749aba234961cc9090e

Convert struct target_ops to C++

I.e., use C++ virtual methods and inheritance instead of tables of
function pointers.

Unfortunately, there's no way to do a smooth transition.  ALL native
targets in the tree must be converted at the same time.  I've tested
all I could with cross compilers and with help from GCC compile farm,
but naturally I haven't been able to test many of the ports.  Still, I
made a best effort to port everything over, and while I expect some
build problems due to typos and such, which should be trivial to fix,
I don't expect any design problems.

* Implementation notes:

- The flattened current_target is gone.  References to current_target
  or current_target.beneath are replaced with references to
  target_stack (the top of the stack) directly.

- To keep "set debug target" working, this adds a new debug_stratum
  layer that sits on top of the stack, prints the debug, and delegates
  to the target beneath.

  In addition, this makes the shortname and longname properties of
  target_ops be virtual methods instead of data fields, and makes the
  debug target defer those to the target beneath.  This is so that
  debug code sprinkled around that does "if (debugtarget) ..."  can
  transparently print the name of the target beneath.

  A patch later in the series actually splits out the
  shortname/longname methods to a separate structure, but I preferred
  to keep that chance separate as it is associated with changing a bit
  the design of how targets are registered and open.

- Since you can't check whether a C++ virtual method is overridden,
  the old method of checking whether a target_ops implements a method
  by comparing the function pointer must be replaced with something
  else.

  Some cases are fixed by adding a parallel "can_do_foo" target_ops
  methods.  E.g.,:

    +  for (t = target_stack; t != NULL; t = t->beneath)
	 {
    -      if (t->to_create_inferior != NULL)
    +      if (t->can_create_inferior ())
	    break;
	 }

  Others are fixed by changing void return type to bool or int return
  type, and have the default implementation return false or -1, to
  indicate lack of support.

- make-target-delegates was adjusted to generate C++ classes and
  methods.

  It needed tweaks to grok "virtual" in front of the target method
  name, and for the fact that methods are no longer function pointers.
  (In particular, the current code parsing the return type was simple
  because it could simply parse up until the '(' in '(*to_foo)'.

  It now generates a couple C++ classes that inherit target_ops:
  dummy_target and debug_target.

  Since we need to generate the class declarations as well, i.e., we
  need to emit methods twice, we now generate the code in two passes.

- The core_target global is renamed to avoid conflict with the
  "core_target" class.

- ctf/tfile targets

  init_tracefile_ops is replaced by a base class that is inherited by
  both ctf and tfile.

- bsd-uthread

  The bsd_uthread_ops_hack hack is gone.  It's not needed because
  nothing was extending a target created by bsd_uthread_target.

- remote/extended-remote targets

  This is a first pass, just enough to C++ify target_ops.

  A later pass will convert more free functions to methods, and make
  remote_state be truly per remote instance, allowing multiple
  simultaneous instances of remote targets.

- inf-child/"native" is converted to an actual base class
  (inf_child_target), that is inherited by all native targets.

- GNU/Linux

  The old weird double-target linux_ops mechanism in linux-nat.c, is
  gone, replaced by adding a few virtual methods to linux-nat.h's
  target_ops, called low_XXX, that the concrete linux-nat
  implementations override.  Sort of like gdbserver's
  linux_target_ops, but simpler, for requiring only one
  target_ops-like hierarchy, which spares implementing the same method
  twice when we need to forward the method to a low implementation.
  The low target simply reimplements the target_ops method directly in
  that case.

  There are a few remaining linux-nat.c hooks that would be better
  converted to low_ methods like above too.  E.g.:

   linux_nat_set_new_thread (t, x86_linux_new_thread);
   linux_nat_set_new_fork (t, x86_linux_new_fork);
   linux_nat_set_forget_process

  That'll be done in a follow up patch.

- We can no longer use functions like x86_use_watchpoints to install
  custom methods on an arbitrary base target.

  The patch replaces instances of such a pattern with template mixins.
  For example memory_breakpoint_target defined in target.h, or
  x86_nat_target in x86-nat.h.

- linux_trad_target, MIPS and Alpha GNU/Linux

  The code in the new linux-nat-trad.h/c files which was split off of
  inf-ptrace.h/c recently, is converted to a C++ base class, and used
  by the MIPS and Alpha GNU/Linux ports.

- BSD targets

  The

    $architecture x NetBSD/OpenBSD/FreeBSD

  support matrix complicates things a bit.  There's common BSD target
  code, and there's common architecture-specific code shared between
  the different BSDs.  Currently, all that is stiched together to form
  a final target, via the i386bsd_target, x86bsd_target,
  fbsd_nat_add_target functions etc.

  This introduces new fbsd_nat_target, obsd_nat_target and
  nbsd_nat_target classes that serve as base/prototype target for the
  corresponding BSD variant.

  And introduces generic i386/AMD64 BSD targets, to be used as
  template mixin to build a final target.  Similarly, a generic SPARC
  target is added, used by both BSD and Linux ports.

- bsd_kvm_add_target, BSD libkvm target

  I considered making bsd_kvm_supply_pcb a virtual method, and then
  have each port inherit bsd_kvm_target and override that method, but
  that was resulting in lots of unjustified churn, so I left the
  function pointer mechanism alone.

gdb/ChangeLog:
2018-05-02  Pedro Alves  <palves@redhat.com>
	    John Baldwin  <jhb@freebsd.org>

	* target.h (enum strata) <debug_stratum>: New.
	(struct target_ops) <all delegation methods>: Replace by C++
	virtual methods, and drop "to_" prefix.  All references updated
	throughout.
	<to_shortname, to_longname, to_doc, to_data,
	to_have_steppable_watchpoint, to_have_continuable_watchpoint,
	to_has_thread_control, to_attach_no_wait>: Delete, replaced by
	virtual methods.  All references updated throughout.
	<can_attach, supports_terminal_ours, can_create_inferior,
	get_thread_control_capabilities, attach_no_wait>: New
	virtual methods.
	<insert_breakpoint, remove_breakpoint>: Now
	TARGET_DEFAULT_NORETURN methods.
	<info_proc>: Now returns bool.
	<to_magic>: Delete.
	(OPS_MAGIC): Delete.
	(current_target): Delete.  All references replaced by references
	to ...
	(target_stack): ... this.  New.
	(target_shortname, target_longname): Adjust.
	(target_can_run): Now a function declaration.
	(default_child_has_all_memory, default_child_has_memory)
	(default_child_has_stack, default_child_has_registers)
	(default_child_has_execution): Remove target_ops parameter.
	(complete_target_initialization): Delete.
	(memory_breakpoint_target): New template class.
	(test_target_ops): Refactor as a C++ class with virtual methods.
	* make-target-delegates (NAME_PART): Tighten.
	(POINTER_PART, CP_SYMBOL): New.
	(SIMPLE_RETURN_PART): Reimplement.
	(VEC_RETURN_PART): Expect less.
	(RETURN_PART, VIRTUAL_PART): New.
	(METHOD): Adjust to C++ virtual methods.
	(scan_target_h): Remove reference to C99.
	(dname): Output "target_ops::" prefix.
	(write_function_header): Adjust to output a C++ class method.
	(write_declaration): New.
	(write_delegator): Adjust to output a C++ class method.
	(tdname): Output "dummy_target::" prefix.
	(write_tdefault, write_debugmethod): Adjust to output a C++ class
	method.
	(tdefault_names, debug_names): Delete.
	(return_types, tdefaults, styles, argtypes_array): New.
	(top level): All methods are delegators.
	(print_class): New.
	(top level): Print dummy_target and debug_target classes.
	* target-delegates.c: Regenerate.
	* target-debug.h (target_debug_print_enum_info_proc_what)
	(target_debug_print_thread_control_capabilities)
	(target_debug_print_thread_info_p): New.
	* target.c (dummy_target): Delete.
	(the_dummy_target, the_debug_target): New.
	(target_stack): Now extern.
	(set_targetdebug): Push/unpush debug target.
	(default_child_has_all_memory, default_child_has_memory)
	(default_child_has_stack, default_child_has_registers)
	(default_child_has_execution): Remove target_ops parameter.
	(complete_target_initialization): Delete.
	(add_target_with_completer): No longer call
	complete_target_initialization.
	(target_supports_terminal_ours): Use regular delegation.
	(update_current_target): Delete.
	(push_target): No longer check magic number.  Don't call
	update_current_target.
	(unpush_target): Don't call update_current_target.
	(target_is_pushed): No longer check magic number.
	(target_require_runnable): Skip for all stratums over
	process_stratum.
	(target_ops::info_proc): New.
	(target_info_proc): Use find_target_at and
	find_default_run_target.
	(target_supports_disable_randomization): Use regular delegation.
	(target_get_osdata): Use find_target_at.
	(target_ops::open, target_ops::close, target_ops::can_attach)
	(target_ops::attach, target_ops::can_create_inferior)
	(target_ops::create_inferior, target_ops::can_run)
	(target_can_run): New.
	(default_fileio_target): Use regular delegation.
	(target_ops::fileio_open, target_ops::fileio_pwrite)
	(target_ops::fileio_pread, target_ops::fileio_fstat)
	(target_ops::fileio_close, target_ops::fileio_unlink)
	(target_ops::fileio_readlink): New.
	(target_fileio_open_1, target_fileio_unlink)
	(target_fileio_readlink): Always call the target method.  Handle
	FILEIO_ENOSYS.
	(return_zero, return_zero_has_execution): Delete.
	(init_dummy_target): Delete.
	(dummy_target::dummy_target, dummy_target::shortname)
	(dummy_target::longname, dummy_target::doc)
	(debug_target::debug_target, debug_target::shortname)
	(debug_target::longname, debug_target::doc): New.
	(target_supports_delete_record): Use regular delegation.
	(setup_target_debug): Delete.
	(maintenance_print_target_stack): Skip debug_stratum.
	(initialize_targets): Instantiate the_dummy_target and
	the_debug_target.
	* auxv.c (target_auxv_parse): Remove 'ops' parameter.  Adjust to
	use target_stack.
	(target_auxv_search, fprint_target_auxv): Adjust.
	(info_auxv_command): Adjust to use target_stack.
	* auxv.h (target_auxv_parse): Remove 'ops' parameter.
	* exceptions.c (print_flush): Handle a NULL target_stack.
	* regcache.c (target_ops_no_register): Refactor as class with
	virtual methods.

	* exec.c (exec_target): New class.
	(exec_ops): Now an exec_target.
	(exec_open, exec_close_1, exec_get_section_table)
	(exec_xfer_partial, exec_files_info, exec_has_memory)
	(exec_make_note_section): Refactor as exec_target methods.
	(exec_file_clear, ignore, exec_remove_breakpoint, init_exec_ops):
	Delete.
	(exec_target::find_memory_regions): New.
	(_initialize_exec): Don't call init_exec_ops.
	* gdbcore.h (exec_file_clear): Delete.

	* corefile.c (core_target): Delete.
	(core_file_command): Adjust.
	* corelow.c (core_target): New class.
	(the_core_target): New.
	(core_close): Remove target_ops parameter.
	(core_close_cleanup): Adjust.
	(core_target::close): New.
	(core_open, core_detach, get_core_registers, core_files_info)
	(core_xfer_partial, core_thread_alive, core_read_description)
	(core_pid_to_str, core_thread_name, core_has_memory)
	(core_has_stack, core_has_registers, core_info_proc): Rework as
	core_target methods.
	(ignore, core_remove_breakpoint, init_core_ops): Delete.
	(_initialize_corelow): Initialize the_core_target.
	* gdbcore.h (core_target): Delete.
	(the_core_target): New.

	* ctf.c: (ctf_target): New class.
	(ctf_ops): Now a ctf_target.
	(ctf_open, ctf_close, ctf_files_info, ctf_fetch_registers)
	(ctf_xfer_partial, ctf_get_trace_state_variable_value)
	(ctf_trace_find, ctf_traceframe_info): Refactor as ctf_target
	methods.
	(init_ctf_ops): Delete.
	(_initialize_ctf): Don't call it.
	* tracefile-tfile.c (tfile_target): New class.
	(tfile_ops): Now a tfile_target.
	(tfile_open, tfile_close, tfile_files_info)
	(tfile_get_tracepoint_status, tfile_trace_find)
	(tfile_fetch_registers, tfile_xfer_partial)
	(tfile_get_trace_state_variable_value, tfile_traceframe_info):
	Refactor as tfile_target methods.
	(tfile_xfer_partial_features): Remove target_ops parameter.
	(init_tfile_ops): Delete.
	(_initialize_tracefile_tfile): Don't call it.
	* tracefile.c (tracefile_has_all_memory, tracefile_has_memory)
	(tracefile_has_stack, tracefile_has_registers)
	(tracefile_thread_alive, tracefile_get_trace_status): Refactor as
	tracefile_target methods.
	(init_tracefile_ops): Delete.
	(tracefile_target::tracefile_target): New.
	* tracefile.h: Include "target.h".
	(tracefile_target): New class.
	(init_tracefile_ops): Delete.

	* spu-multiarch.c (spu_multiarch_target): New class.
	(spu_ops): Now a spu_multiarch_target.
	(spu_thread_architecture, spu_region_ok_for_hw_watchpoint)
	(spu_fetch_registers, spu_store_registers, spu_xfer_partial)
	(spu_search_memory, spu_mourn_inferior): Refactor as
	spu_multiarch_target methods.
	(init_spu_ops): Delete.
	(_initialize_spu_multiarch): Remove references to init_spu_ops,
	complete_target_initialization.

	* ravenscar-thread.c (ravenscar_thread_target): New class.
	(ravenscar_ops): Now a ravenscar_thread_target.
	(ravenscar_resume, ravenscar_wait, ravenscar_update_thread_list)
	(ravenscar_thread_alive, ravenscar_pid_to_str)
	(ravenscar_fetch_registers, ravenscar_store_registers)
	(ravenscar_prepare_to_store, ravenscar_stopped_by_sw_breakpoint)
	(ravenscar_stopped_by_hw_breakpoint)
	(ravenscar_stopped_by_watchpoint, ravenscar_stopped_data_address)
	(ravenscar_mourn_inferior, ravenscar_core_of_thread)
	(ravenscar_get_ada_task_ptid): Refactor as ravenscar_thread_target
	methods.
	(init_ravenscar_thread_ops): Delete.
	(_initialize_ravenscar): Remove references to
	init_ravenscar_thread_ops and complete_target_initialization.

	* bsd-uthread.c (bsd_uthread_ops_hack): Delete.
	(bsd_uthread_target): New class.
	(bsd_uthread_ops): Now a bsd_uthread_target.
	(bsd_uthread_activate): Adjust to refer to bsd_uthread_ops.
	(bsd_uthread_close, bsd_uthread_mourn_inferior)
	(bsd_uthread_fetch_registers, bsd_uthread_store_registers)
	(bsd_uthread_wait, bsd_uthread_resume, bsd_uthread_thread_alive)
	(bsd_uthread_update_thread_list, bsd_uthread_extra_thread_info)
	(bsd_uthread_pid_to_str): Refactor as bsd_uthread_target methods.
	(bsd_uthread_target): Delete function.
	(_initialize_bsd_uthread): Remove reference to
	complete_target_initialization.

	* bfd-target.c (target_bfd_data): Delete.  Fields folded into ...
	(target_bfd): ... this new class.
	(target_bfd_xfer_partial, target_bfd_get_section_table)
	(target_bfd_close): Refactor as target_bfd methods.
	(target_bfd::~target_bfd): New.
	(target_bfd_reopen): Adjust.
	(target_bfd::close): New.

	* record-btrace.c (record_btrace_target): New class.
	(record_btrace_ops): Now a record_btrace_target.
	(record_btrace_open, record_btrace_stop_recording)
	(record_btrace_disconnect, record_btrace_close)
	(record_btrace_async, record_btrace_info)
	(record_btrace_insn_history, record_btrace_insn_history_range)
	(record_btrace_insn_history_from, record_btrace_call_history)
	(record_btrace_call_history_range)
	(record_btrace_call_history_from, record_btrace_record_method)
	(record_btrace_is_replaying, record_btrace_will_replay)
	(record_btrace_xfer_partial, record_btrace_insert_breakpoint)
	(record_btrace_remove_breakpoint, record_btrace_fetch_registers)
	(record_btrace_store_registers, record_btrace_prepare_to_store)
	(record_btrace_to_get_unwinder)
	(record_btrace_to_get_tailcall_unwinder, record_btrace_resume)
	(record_btrace_commit_resume, record_btrace_wait)
	(record_btrace_stop, record_btrace_can_execute_reverse)
	(record_btrace_stopped_by_sw_breakpoint)
	(record_btrace_supports_stopped_by_sw_breakpoint)
	(record_btrace_stopped_by_hw_breakpoint)
	(record_btrace_supports_stopped_by_hw_breakpoint)
	(record_btrace_update_thread_list, record_btrace_thread_alive)
	(record_btrace_goto_begin, record_btrace_goto_end)
	(record_btrace_goto, record_btrace_stop_replaying_all)
	(record_btrace_execution_direction)
	(record_btrace_prepare_to_generate_core)
	(record_btrace_done_generating_core): Refactor as
	record_btrace_target methods.
	(init_record_btrace_ops): Delete.
	(_initialize_record_btrace): Remove reference to
	init_record_btrace_ops.
	* record-full.c (RECORD_FULL_IS_REPLAY): Adjust to always refer to
	the execution_direction global.
	(record_full_base_target, record_full_target)
	(record_full_core_target): New classes.
	(record_full_ops): Now a record_full_target.
	(record_full_core_ops): Now a record_full_core_target.
	(record_full_target::detach, record_full_target::disconnect)
	(record_full_core_target::disconnect)
	(record_full_target::mourn_inferior, record_full_target::kill):
	New.
	(record_full_open, record_full_close, record_full_async): Refactor
	as methods of the record_full_base_target class.
	(record_full_resume, record_full_commit_resume): Refactor
	as methods of the record_full_target class.
	(record_full_wait, record_full_stopped_by_watchpoint)
	(record_full_stopped_data_address)
	(record_full_stopped_by_sw_breakpoint)
	(record_full_supports_stopped_by_sw_breakpoint)
	(record_full_stopped_by_hw_breakpoint)
	(record_full_supports_stopped_by_hw_breakpoint): Refactor as
	methods of the record_full_base_target class.
	(record_full_store_registers, record_full_xfer_partial)
	(record_full_insert_breakpoint, record_full_remove_breakpoint):
	Refactor as methods of the record_full_target class.
	(record_full_can_execute_reverse, record_full_get_bookmark)
	(record_full_goto_bookmark, record_full_execution_direction)
	(record_full_record_method, record_full_info, record_full_delete)
	(record_full_is_replaying, record_full_will_replay)
	(record_full_goto_begin, record_full_goto_end, record_full_goto)
	(record_full_stop_replaying): Refactor as methods of the
	record_full_base_target class.
	(record_full_core_resume, record_full_core_kill)
	(record_full_core_fetch_registers)
	(record_full_core_prepare_to_store)
	(record_full_core_store_registers, record_full_core_xfer_partial)
	(record_full_core_insert_breakpoint)
	(record_full_core_remove_breakpoint)
	(record_full_core_has_execution): Refactor
	as methods of the record_full_core_target class.
	(record_full_base_target::supports_delete_record): New.
	(init_record_full_ops): Delete.
	(init_record_full_core_ops): Delete.
	(record_full_save): Refactor as method of the
	record_full_base_target class.
	(_initialize_record_full): Remove references to
	init_record_full_ops and init_record_full_core_ops.

	* remote.c (remote_target, extended_remote_target): New classes.
	(remote_ops): Now a remote_target.
	(extended_remote_ops): Now an extended_remote_target.
	(remote_insert_fork_catchpoint, remote_remove_fork_catchpoint)
	(remote_insert_vfork_catchpoint, remote_remove_vfork_catchpoint)
	(remote_insert_exec_catchpoint, remote_remove_exec_catchpoint)
	(remote_pass_signals, remote_set_syscall_catchpoint)
	(remote_program_signals, )
	(remote_thread_always_alive): Remove target_ops parameter.
	(remote_thread_alive, remote_thread_name)
	(remote_update_thread_list, remote_threads_extra_info)
	(remote_static_tracepoint_marker_at)
	(remote_static_tracepoint_markers_by_strid)
	(remote_get_ada_task_ptid, remote_close, remote_start_remote)
	(remote_open): Refactor as methods of remote_target.
	(extended_remote_open, extended_remote_detach)
	(extended_remote_attach, extended_remote_post_attach):
	(extended_remote_supports_disable_randomization)
	(extended_remote_create_inferior): : Refactor as method of
	extended_remote_target.
	(remote_set_permissions, remote_open_1, remote_detach)
	(remote_follow_fork, remote_follow_exec, remote_disconnect)
	(remote_resume, remote_commit_resume, remote_stop)
	(remote_interrupt, remote_pass_ctrlc, remote_terminal_inferior)
	(remote_terminal_ours, remote_wait, remote_fetch_registers)
	(remote_prepare_to_store, remote_store_registers)
	(remote_flash_erase, remote_flash_done, remote_files_info)
	(remote_kill, remote_mourn, remote_insert_breakpoint)
	(remote_remove_breakpoint, remote_insert_watchpoint)
	(remote_watchpoint_addr_within_range)
	(remote_remove_watchpoint, remote_region_ok_for_hw_watchpoint)
	(remote_check_watch_resources, remote_stopped_by_sw_breakpoint)
	(remote_supports_stopped_by_sw_breakpoint)
	(remote_stopped_by_hw_breakpoint)
	(remote_supports_stopped_by_hw_breakpoint)
	(remote_stopped_by_watchpoint, remote_stopped_data_address)
	(remote_insert_hw_breakpoint, remote_remove_hw_breakpoint)
	(remote_verify_memory): Refactor as methods of remote_target.
	(remote_write_qxfer, remote_read_qxfer): Remove target_ops
	parameter.
	(remote_xfer_partial, remote_get_memory_xfer_limit)
	(remote_search_memory, remote_rcmd, remote_memory_map)
	(remote_pid_to_str, remote_get_thread_local_address)
	(remote_get_tib_address, remote_read_description): Refactor as
	methods of remote_target.
	(remote_target::fileio_open, remote_target::fileio_pwrite)
	(remote_target::fileio_pread, remote_target::fileio_close): New.
	(remote_hostio_readlink, remote_hostio_fstat)
	(remote_filesystem_is_local, remote_can_execute_reverse)
	(remote_supports_non_stop, remote_supports_disable_randomization)
	(remote_supports_multi_process, remote_supports_cond_breakpoints)
	(remote_supports_enable_disable_tracepoint)
	(remote_supports_string_tracing)
	(remote_can_run_breakpoint_commands, remote_trace_init)
	(remote_download_tracepoint, remote_can_download_tracepoint)
	(remote_download_trace_state_variable, remote_enable_tracepoint)
	(remote_disable_tracepoint, remote_trace_set_readonly_regions)
	(remote_trace_start, remote_get_trace_status)
	(remote_get_tracepoint_status, remote_trace_stop)
	(remote_trace_find, remote_get_trace_state_variable_value)
	(remote_save_trace_data, remote_get_raw_trace_data)
	(remote_set_disconnected_tracing, remote_core_of_thread)
	(remote_set_circular_trace_buffer, remote_traceframe_info)
	(remote_get_min_fast_tracepoint_insn_len)
	(remote_set_trace_buffer_size, remote_set_trace_notes)
	(remote_use_agent, remote_can_use_agent, remote_enable_btrace)
	(remote_disable_btrace, remote_teardown_btrace)
	(remote_read_btrace, remote_btrace_conf)
	(remote_augmented_libraries_svr4_read, remote_load)
	(remote_pid_to_exec_file, remote_can_do_single_step)
	(remote_execution_direction, remote_thread_handle_to_thread_info):
	Refactor as methods of remote_target.
	(init_remote_ops, init_extended_remote_ops): Delete.
	(remote_can_async_p, remote_is_async_p, remote_async)
	(remote_thread_events, remote_upload_tracepoints)
	(remote_upload_trace_state_variables): Refactor as methods of
	remote_target.
	(_initialize_remote): Remove references to init_remote_ops and
	init_extended_remote_ops.

	* remote-sim.c (gdbsim_target): New class.
	(gdbsim_fetch_register, gdbsim_store_register, gdbsim_kill)
	(gdbsim_load, gdbsim_create_inferior, gdbsim_open, gdbsim_close)
	(gdbsim_detach, gdbsim_resume, gdbsim_interrupt)
	(gdbsim_wait, gdbsim_prepare_to_store, gdbsim_xfer_partial)
	(gdbsim_files_info, gdbsim_mourn_inferior, gdbsim_thread_alive)
	(gdbsim_pid_to_str, gdbsim_has_all_memory, gdbsim_has_memory):
	Refactor as methods of gdbsim_target.
	(gdbsim_ops): Now a gdbsim_target.
	(init_gdbsim_ops): Delete.
	(gdbsim_cntrl_c): Adjust.
	(_initialize_remote_sim): Remove reference to init_gdbsim_ops.

	* amd64-linux-nat.c (amd64_linux_nat_target): New class.
	(the_amd64_linux_nat_target): New.
	(amd64_linux_fetch_inferior_registers)
	(amd64_linux_store_inferior_registers): Refactor as methods of
	amd64_linux_nat_target.
	(_initialize_amd64_linux_nat): Adjust.  Set linux_target.
	* i386-linux-nat.c: Don't include "linux-nat.h".
	(i386_linux_nat_target): New class.
	(the_i386_linux_nat_target): New.
	(i386_linux_fetch_inferior_registers)
	(i386_linux_store_inferior_registers, i386_linux_resume): Refactor
	as methods of i386_linux_nat_target.
	(_initialize_i386_linux_nat): Adjust.  Set linux_target.
	* inf-child.c (inf_child_ops): Delete.
	(inf_child_fetch_inferior_registers)
	(inf_child_store_inferior_registers): Delete.
	(inf_child_post_attach, inf_child_prepare_to_store): Refactor as
	methods of inf_child_target.
	(inf_child_target::supports_terminal_ours)
	(inf_child_target::terminal_init)
	(inf_child_target::terminal_inferior)
	(inf_child_target::terminal_ours_for_output)
	(inf_child_target::terminal_ours, inf_child_target::interrupt)
	(inf_child_target::pass_ctrlc, inf_child_target::terminal_info):
	New.
	(inf_child_open, inf_child_disconnect, inf_child_close)
	(inf_child_mourn_inferior, inf_child_maybe_unpush_target)
	(inf_child_post_startup_inferior, inf_child_can_run)
	(inf_child_pid_to_exec_file): Refactor as methods of
	inf_child_target.
	(inf_child_follow_fork): Delete.
	(inf_child_target::can_create_inferior)
	(inf_child_target::can_attach): New.
	(inf_child_target::has_all_memory, inf_child_target::has_memory)
	(inf_child_target::has_stack, inf_child_target::has_registers)
	(inf_child_target::has_execution): New.
	(inf_child_fileio_open, inf_child_fileio_pwrite)
	(inf_child_fileio_pread, inf_child_fileio_fstat)
	(inf_child_fileio_close, inf_child_fileio_unlink)
	(inf_child_fileio_readlink, inf_child_use_agent)
	(inf_child_can_use_agent): Refactor as methods of
	inf_child_target.
	(return_zero, inf_child_target): Delete.
	(inf_child_target::inf_child_target): New.
	* inf-child.h: Include "target.h".
	(inf_child_target): Delete function prototype.
	(inf_child_target): New class.
	(inf_child_open_target, inf_child_mourn_inferior)
	(inf_child_maybe_unpush_target): Delete.
	* inf-ptrace.c (inf_ptrace_target::~inf_ptrace_target): New.
	(inf_ptrace_follow_fork, inf_ptrace_insert_fork_catchpoint)
	(inf_ptrace_remove_fork_catchpoint, inf_ptrace_create_inferior)
	(inf_ptrace_post_startup_inferior, inf_ptrace_mourn_inferior)
	(inf_ptrace_attach, inf_ptrace_post_attach, inf_ptrace_detach)
	(inf_ptrace_detach_success, inf_ptrace_kill, inf_ptrace_resume)
	(inf_ptrace_wait, inf_ptrace_xfer_partial)
	(inf_ptrace_thread_alive, inf_ptrace_files_info)
	(inf_ptrace_pid_to_str, inf_ptrace_auxv_parse): Refactor as
	methods of inf_ptrace_target.
	(inf_ptrace_target): Delete function.
	* inf-ptrace.h: Include "inf-child.h".
	(inf_ptrace_target): Delete function declaration.
	(inf_ptrace_target): New class.
	(inf_ptrace_trad_target, inf_ptrace_detach_success): Delete.
	* linux-nat.c (linux_target): New.
	(linux_ops, linux_ops_saved, super_xfer_partial): Delete.
	(linux_nat_target::~linux_nat_target): New.
	(linux_child_post_attach, linux_child_post_startup_inferior)
	(linux_child_follow_fork, linux_child_insert_fork_catchpoint)
	(linux_child_remove_fork_catchpoint)
	(linux_child_insert_vfork_catchpoint)
	(linux_child_remove_vfork_catchpoint)
	(linux_child_insert_exec_catchpoint)
	(linux_child_remove_exec_catchpoint)
	(linux_child_set_syscall_catchpoint, linux_nat_pass_signals)
	(linux_nat_create_inferior, linux_nat_attach, linux_nat_detach)
	(linux_nat_resume, linux_nat_stopped_by_watchpoint)
	(linux_nat_stopped_data_address)
	(linux_nat_stopped_by_sw_breakpoint)
	(linux_nat_supports_stopped_by_sw_breakpoint)
	(linux_nat_stopped_by_hw_breakpoint)
	(linux_nat_supports_stopped_by_hw_breakpoint, linux_nat_wait)
	(linux_nat_kill, linux_nat_mourn_inferior)
	(linux_nat_xfer_partial, linux_nat_thread_alive)
	(linux_nat_update_thread_list, linux_nat_pid_to_str)
	(linux_nat_thread_name, linux_child_pid_to_exec_file)
	(linux_child_static_tracepoint_markers_by_strid)
	(linux_nat_is_async_p, linux_nat_can_async_p)
	(linux_nat_supports_non_stop, linux_nat_always_non_stop_p)
	(linux_nat_supports_multi_process)
	(linux_nat_supports_disable_randomization, linux_nat_async)
	(linux_nat_stop, linux_nat_close, linux_nat_thread_address_space)
	(linux_nat_core_of_thread, linux_nat_filesystem_is_local)
	(linux_nat_fileio_open, linux_nat_fileio_readlink)
	(linux_nat_fileio_unlink, linux_nat_thread_events): Refactor as
	methods of linux_nat_target.
	(linux_nat_wait_1, linux_xfer_siginfo, linux_proc_xfer_partial)
	(linux_proc_xfer_spu, linux_nat_xfer_osdata): Remove target_ops
	parameter.
	(check_stopped_by_watchpoint): Adjust.
	(linux_xfer_partial): Delete.
	(linux_target_install_ops, linux_target, linux_nat_add_target):
	Delete.
	(linux_nat_target::linux_nat_target): New.
	* linux-nat.h: Include "inf-ptrace.h".
	(linux_nat_target): New.
	(linux_target, linux_target_install_ops, linux_nat_add_target):
	Delete function declarations.
	(linux_target): Declare global.
	* linux-thread-db.c (thread_db_target): New.
	(thread_db_target::thread_db_target): New.
	(thread_db_ops): Delete.
	(the_thread_db_target): New.
	(thread_db_detach, thread_db_wait, thread_db_mourn_inferior)
	(thread_db_update_thread_list, thread_db_pid_to_str)
	(thread_db_extra_thread_info)
	(thread_db_thread_handle_to_thread_info)
	(thread_db_get_thread_local_address, thread_db_get_ada_task_ptid)
	(thread_db_resume): Refactor as methods of thread_db_target.
	(init_thread_db_ops): Delete.
	(_initialize_thread_db): Remove reference to init_thread_db_ops.
	* x86-linux-nat.c: Don't include "linux-nat.h".
	(super_post_startup_inferior): Delete.
	(x86_linux_nat_target::~x86_linux_nat_target): New.
	(x86_linux_child_post_startup_inferior)
	(x86_linux_read_description, x86_linux_enable_btrace)
	(x86_linux_disable_btrace, x86_linux_teardown_btrace)
	(x86_linux_read_btrace, x86_linux_btrace_conf): Refactor as
	methods of x86_linux_nat_target.
	(x86_linux_create_target): Delete.  Bits folded ...
	(x86_linux_add_target): ... here.  Now takes a linux_nat_target
	pointer.
	* x86-linux-nat.h: Include "linux-nat.h" and "x86-nat.h".
	(x86_linux_nat_target): New class.
	(x86_linux_create_target): Delete.
	(x86_linux_add_target): Now takes a linux_nat_target pointer.
	* x86-nat.c (x86_insert_watchpoint, x86_remove_watchpoint)
	(x86_region_ok_for_watchpoint, x86_stopped_data_address)
	(x86_stopped_by_watchpoint, x86_insert_hw_breakpoint)
	(x86_remove_hw_breakpoint, x86_can_use_hw_breakpoint)
	(x86_stopped_by_hw_breakpoint): Remove target_ops parameter and
	make extern.
	(x86_use_watchpoints): Delete.
	* x86-nat.h: Include "breakpoint.h" and "target.h".
	(x86_use_watchpoints): Delete.
	(x86_can_use_hw_breakpoint, x86_region_ok_for_hw_watchpoint)
	(x86_stopped_by_watchpoint, x86_stopped_data_address)
	(x86_insert_watchpoint, x86_remove_watchpoint)
	(x86_insert_hw_breakpoint, x86_remove_hw_breakpoint)
	(x86_stopped_by_hw_breakpoint): New declarations.
	(x86_nat_target): New template class.

	* ppc-linux-nat.c (ppc_linux_nat_target): New class.
	(the_ppc_linux_nat_target): New.
	(ppc_linux_fetch_inferior_registers)
	(ppc_linux_can_use_hw_breakpoint)
	(ppc_linux_region_ok_for_hw_watchpoint)
	(ppc_linux_ranged_break_num_registers)
	(ppc_linux_insert_hw_breakpoint, ppc_linux_remove_hw_breakpoint)
	(ppc_linux_insert_mask_watchpoint)
	(ppc_linux_remove_mask_watchpoint)
	(ppc_linux_can_accel_watchpoint_condition)
	(ppc_linux_insert_watchpoint, ppc_linux_remove_watchpoint)
	(ppc_linux_stopped_data_address, ppc_linux_stopped_by_watchpoint)
	(ppc_linux_watchpoint_addr_within_range)
	(ppc_linux_masked_watch_num_registers)
	(ppc_linux_store_inferior_registers, ppc_linux_auxv_parse)
	(ppc_linux_read_description): Refactor as methods of
	ppc_linux_nat_target.
	(_initialize_ppc_linux_nat): Adjust.  Set linux_target.

	* procfs.c (procfs_xfer_partial): Delete forward declaration.
	(procfs_target): New class.
	(the_procfs_target): New.
	(procfs_target): Delete function.
	(procfs_auxv_parse, procfs_attach, procfs_detach)
	(procfs_fetch_registers, procfs_store_registers, procfs_wait)
	(procfs_xfer_partial, procfs_resume, procfs_pass_signals)
	(procfs_files_info, procfs_kill_inferior, procfs_mourn_inferior)
	(procfs_create_inferior, procfs_update_thread_list)
	(procfs_thread_alive, procfs_pid_to_str)
	(procfs_can_use_hw_breakpoint, procfs_stopped_by_watchpoint)
	(procfs_stopped_data_address, procfs_insert_watchpoint)
	(procfs_remove_watchpoint, procfs_region_ok_for_hw_watchpoint)
	(proc_find_memory_regions, procfs_info_proc)
	(procfs_make_note_section): Refactor as methods of procfs_target.
	(_initialize_procfs): Adjust.
	* sol-thread.c (sol_thread_target): New class.
	(sol_thread_ops): Now a sol_thread_target.
	(sol_thread_detach, sol_thread_resume, sol_thread_wait)
	(sol_thread_fetch_registers, sol_thread_store_registers)
	(sol_thread_xfer_partial, sol_thread_mourn_inferior)
	(sol_thread_alive, solaris_pid_to_str, sol_update_thread_list)
	(sol_get_ada_task_ptid): Refactor as methods of sol_thread_target.
	(init_sol_thread_ops): Delete.
	(_initialize_sol_thread): Adjust.  Remove references to
	init_sol_thread_ops and complete_target_initialization.

	* windows-nat.c (windows_nat_target): New class.
	(windows_fetch_inferior_registers)
	(windows_store_inferior_registers, windows_resume, windows_wait)
	(windows_attach, windows_detach, windows_pid_to_exec_file)
	(windows_files_info, windows_create_inferior)
	(windows_mourn_inferior, windows_interrupt, windows_kill_inferior)
	(windows_close, windows_pid_to_str, windows_xfer_partial)
	(windows_get_tib_address, windows_get_ada_task_ptid)
	(windows_thread_name, windows_thread_alive): Refactor as
	windows_nat_target methods.
	(do_initial_windows_stuff): Adjust.
	(windows_target): Delete function.
	(_initialize_windows_nat): Adjust.

	* darwin-nat.c (darwin_resume, darwin_wait_to, darwin_interrupt)
	(darwin_mourn_inferior, darwin_kill_inferior)
	(darwin_create_inferior, darwin_attach, darwin_detach)
	(darwin_pid_to_str, darwin_thread_alive, darwin_xfer_partial)
	(darwin_pid_to_exec_file, darwin_get_ada_task_ptid)
	(darwin_supports_multi_process): Refactor as darwin_nat_target
	methods.
	(darwin_resume_to, darwin_files_info): Delete.
	(_initialize_darwin_inferior): Rename to ...
	(_initialize_darwin_nat): ... this.  Adjust to C++ification.
	* darwin-nat.h: Include "inf-child.h".
	(darwin_nat_target): New class.
	(darwin_complete_target): Delete.
	* i386-darwin-nat.c (i386_darwin_nat_target): New class.
	(darwin_target): New.
	(i386_darwin_fetch_inferior_registers)
	(i386_darwin_store_inferior_registers): Refactor as methods of
	darwin_nat_target.
	(darwin_complete_target): Delete, with ...
	(_initialize_i386_darwin_nat): ... bits factored out here.

	* alpha-linux-nat.c (alpha_linux_nat_target): New class.
	(the_alpha_linux_nat_target): New.
	(alpha_linux_register_u_offset): Refactor as
	alpha_linux_nat_target method.
	(_initialize_alpha_linux_nat): Adjust.
	* linux-nat-trad.c (inf_ptrace_register_u_offset): Delete.
	(inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
	(inf_ptrace_store_register, inf_ptrace_store_registers): Refact as
	methods of linux_nat_trad_target.
	(linux_trad_target): Delete.
	* linux-nat-trad.h (linux_trad_target): Delete function.
	(linux_nat_trad_target): New class.
	* mips-linux-nat.c (mips_linux_nat_target): New class.
	(super_fetch_registers, super_store_registers, super_close):
	Delete.
	(the_mips_linux_nat_target): New.
	(mips64_linux_regsets_fetch_registers)
	(mips64_linux_regsets_store_registers)
	(mips64_linux_fetch_registers, mips64_linux_store_registers)
	(mips_linux_register_u_offset, mips_linux_read_description)
	(mips_linux_can_use_hw_breakpoint)
	(mips_linux_stopped_by_watchpoint)
	(mips_linux_stopped_data_address)
	(mips_linux_region_ok_for_hw_watchpoint)
	(mips_linux_insert_watchpoint, mips_linux_remove_watchpoint)
	(mips_linux_close): Refactor as methods of mips_linux_nat.
	(_initialize_mips_linux_nat): Adjust to C++ification.

	* aix-thread.c (aix_thread_target): New class.
	(aix_thread_ops): Now an aix_thread_target.
	(aix_thread_detach, aix_thread_resume, aix_thread_wait)
	(aix_thread_fetch_registers, aix_thread_store_registers)
	(aix_thread_xfer_partial, aix_thread_mourn_inferior)
	(aix_thread_thread_alive, aix_thread_pid_to_str)
	(aix_thread_extra_thread_info, aix_thread_get_ada_task_ptid):
	Refactor as methods of aix_thread_target.
	(init_aix_thread_ops): Delete.
	(_initialize_aix_thread): Remove references to init_aix_thread_ops
	and complete_target_initialization.
	* rs6000-nat.c (rs6000_xfer_shared_libraries): Delete.
	(rs6000_nat_target): New class.
	(the_rs6000_nat_target): New.
	(rs6000_fetch_inferior_registers, rs6000_store_inferior_registers)
	(rs6000_xfer_partial, rs6000_wait, rs6000_create_inferior)
	(rs6000_xfer_shared_libraries): Refactor as rs6000_nat_target methods.
	(super_create_inferior): Delete.
	(_initialize_rs6000_nat): Adjust to C++ification.

	* arm-linux-nat.c (arm_linux_nat_target): New class.
	(the_arm_linux_nat_target): New.
	(arm_linux_fetch_inferior_registers)
	(arm_linux_store_inferior_registers, arm_linux_read_description)
	(arm_linux_can_use_hw_breakpoint, arm_linux_insert_hw_breakpoint)
	(arm_linux_remove_hw_breakpoint)
	(arm_linux_region_ok_for_hw_watchpoint)
	(arm_linux_insert_watchpoint, arm_linux_remove_watchpoint)
	(arm_linux_stopped_data_address, arm_linux_stopped_by_watchpoint)
	(arm_linux_watchpoint_addr_within_range): Refactor as methods of
	arm_linux_nat_target.
	(_initialize_arm_linux_nat): Adjust to C++ification.

	* aarch64-linux-nat.c (aarch64_linux_nat_target): New class.
	(the_aarch64_linux_nat_target): New.
	(aarch64_linux_fetch_inferior_registers)
	(aarch64_linux_store_inferior_registers)
	(aarch64_linux_child_post_startup_inferior)
	(aarch64_linux_read_description)
	(aarch64_linux_can_use_hw_breakpoint)
	(aarch64_linux_insert_hw_breakpoint)
	(aarch64_linux_remove_hw_breakpoint)
	(aarch64_linux_insert_watchpoint, aarch64_linux_remove_watchpoint)
	(aarch64_linux_region_ok_for_hw_watchpoint)
	(aarch64_linux_stopped_data_address)
	(aarch64_linux_stopped_by_watchpoint)
	(aarch64_linux_watchpoint_addr_within_range)
	(aarch64_linux_can_do_single_step): Refactor as methods of
	aarch64_linux_nat_target.
	(super_post_startup_inferior): Delete.
	(_initialize_aarch64_linux_nat): Adjust to C++ification.

	* hppa-linux-nat.c (hppa_linux_nat_target): New class.
	(the_hppa_linux_nat_target): New.
	(hppa_linux_fetch_inferior_registers)
	(hppa_linux_store_inferior_registers): Refactor as methods of
	hppa_linux_nat_target.
	(_initialize_hppa_linux_nat): Adjust to C++ification.

	* ia64-linux-nat.c (ia64_linux_nat_target): New class.
	(the_ia64_linux_nat_target): New.
	(ia64_linux_insert_watchpoint, ia64_linux_remove_watchpoint)
	(ia64_linux_stopped_data_address)
	(ia64_linux_stopped_by_watchpoint, ia64_linux_fetch_registers)
	(ia64_linux_store_registers, ia64_linux_xfer_partial): Refactor as
	ia64_linux_nat_target methods.
	(super_xfer_partial): Delete.
	(_initialize_ia64_linux_nat): Adjust to C++ification.

	* m32r-linux-nat.c (m32r_linux_nat_target): New class.
	(the_m32r_linux_nat_target): New.
	(m32r_linux_fetch_inferior_registers)
	(m32r_linux_store_inferior_registers): Refactor as
	m32r_linux_nat_target methods.
	(_initialize_m32r_linux_nat): Adjust to C++ification.

	* m68k-linux-nat.c (m68k_linux_nat_target): New class.
	(the_m68k_linux_nat_target): New.
	(m68k_linux_fetch_inferior_registers)
	(m68k_linux_store_inferior_registers): Refactor as
	m68k_linux_nat_target methods.
	(_initialize_m68k_linux_nat): Adjust to C++ification.

	* s390-linux-nat.c (s390_linux_nat_target): New class.
	(the_s390_linux_nat_target): New.
	(s390_linux_fetch_inferior_registers)
	(s390_linux_store_inferior_registers, s390_stopped_by_watchpoint)
	(s390_insert_watchpoint, s390_remove_watchpoint)
	(s390_can_use_hw_breakpoint, s390_insert_hw_breakpoint)
	(s390_remove_hw_breakpoint, s390_region_ok_for_hw_watchpoint)
	(s390_auxv_parse, s390_read_description): Refactor as methods of
	s390_linux_nat_target.
	(_initialize_s390_nat): Adjust to C++ification.

	* sparc-linux-nat.c (sparc_linux_nat_target): New class.
	(the_sparc_linux_nat_target): New.
	(_initialize_sparc_linux_nat): Adjust to C++ification.
	* sparc-nat.c (sparc_fetch_inferior_registers)
	(sparc_store_inferior_registers): Remove target_ops parameter.
	* sparc-nat.h (sparc_fetch_inferior_registers)
	(sparc_store_inferior_registers): Remove target_ops parameter.
	* sparc64-linux-nat.c (sparc64_linux_nat_target): New class.
	(the_sparc64_linux_nat_target): New.
	(_initialize_sparc64_linux_nat): Adjust to C++ification.

	* spu-linux-nat.c (spu_linux_nat_target): New class.
	(the_spu_linux_nat_target): New.
	(spu_child_post_startup_inferior, spu_child_post_attach)
	(spu_child_wait, spu_fetch_inferior_registers)
	(spu_store_inferior_registers, spu_xfer_partial)
	(spu_can_use_hw_breakpoint): Refactor as spu_linux_nat_target
	methods.
	(_initialize_spu_nat): Adjust to C++ification.

	* tilegx-linux-nat.c (tilegx_linux_nat_target): New class.
	(the_tilegx_linux_nat_target): New.
	(fetch_inferior_registers, store_inferior_registers):
	Refactor as methods.
	(_initialize_tile_linux_nat): Adjust to C++ification.

	* xtensa-linux-nat.c (xtensa_linux_nat_target): New class.
	(the_xtensa_linux_nat_target): New.
	(xtensa_linux_fetch_inferior_registers)
	(xtensa_linux_store_inferior_registers): Refactor as
	xtensa_linux_nat_target methods.
	(_initialize_xtensa_linux_nat): Adjust to C++ification.

	* fbsd-nat.c (USE_SIGTRAP_SIGINFO): Delete.
	(fbsd_pid_to_exec_file, fbsd_find_memory_regions)
	(fbsd_find_memory_regions, fbsd_info_proc, fbsd_xfer_partial)
	(fbsd_thread_alive, fbsd_pid_to_str, fbsd_thread_name)
	(fbsd_update_thread_list, fbsd_resume, fbsd_wait)
	(fbsd_stopped_by_sw_breakpoint)
	(fbsd_supports_stopped_by_sw_breakpoint, fbsd_follow_fork)
	(fbsd_insert_fork_catchpoint, fbsd_remove_fork_catchpoint)
	(fbsd_insert_vfork_catchpoint, fbsd_remove_vfork_catchpoint)
	(fbsd_post_startup_inferior, fbsd_post_attach)
	(fbsd_insert_exec_catchpoint, fbsd_remove_exec_catchpoint)
	(fbsd_set_syscall_catchpoint)
	(super_xfer_partial, super_resume, super_wait)
	(fbsd_supports_stopped_by_hw_breakpoint): Delete.
	(fbsd_handle_debug_trap): Remove target_ops parameter.
	(fbsd_nat_add_target): Delete.
	* fbsd-nat.h: Include "inf-ptrace.h".
	(fbsd_nat_add_target): Delete.
	(USE_SIGTRAP_SIGINFO): Define.
	(fbsd_nat_target): New class.

	* amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers)
	(amd64bsd_store_inferior_registers): Remove target_ops parameter.
	(amd64bsd_target): Delete.
	* amd64-bsd-nat.h: New file.
	* amd64-fbsd-nat.c: Include "amd64-bsd-nat.h" instead of
	"x86-bsd-nat.h".
	(amd64_fbsd_nat_target): New class.
	(the_amd64_fbsd_nat_target): New.
	(amd64fbsd_read_description): Refactor as method of
	amd64_fbsd_nat_target.
	(amd64_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
	(_initialize_amd64fbsd_nat): Adjust to C++ification.
	* amd64-nat.h (amd64bsd_target): Delete function declaration.
	* i386-bsd-nat.c (i386bsd_fetch_inferior_registers)
	(i386bsd_store_inferior_registers): Remove target_ops parameter.
	(i386bsd_target): Delete.
	* i386-bsd-nat.h (i386bsd_target): Delete function declaration.
	(i386bsd_fetch_inferior_registers)
	(i386bsd_store_inferior_registers): Declare.
	(i386_bsd_nat_target): New class.
	* i386-fbsd-nat.c (i386_fbsd_nat_target): New class.
	(the_i386_fbsd_nat_target): New.
	(i386fbsd_resume, i386fbsd_read_description): Refactor as
	i386_fbsd_nat_target methods.
	(i386_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
	(_initialize_i386fbsd_nat): Adjust to C++ification.
	* x86-bsd-nat.c (super_mourn_inferior): Delete.
	(x86bsd_mourn_inferior, x86bsd_target): Delete.
	(_initialize_x86_bsd_nat): Adjust to C++ification.
	* x86-bsd-nat.h: Include "x86-nat.h".
	(x86bsd_target): Delete declaration.
	(x86bsd_nat_target): New class.

	* aarch64-fbsd-nat.c (aarch64_fbsd_nat_target): New class.
	(the_aarch64_fbsd_nat_target): New.
	(aarch64_fbsd_fetch_inferior_registers)
	(aarch64_fbsd_store_inferior_registers): Refactor as methods of
	aarch64_fbsd_nat_target.
	(_initialize_aarch64_fbsd_nat): Adjust to C++ification.
	* alpha-bsd-nat.c (alpha_bsd_nat_target): New class.
	(the_alpha_bsd_nat_target): New.
	(alphabsd_fetch_inferior_registers)
	(alphabsd_store_inferior_registers): Refactor as
	alpha_bsd_nat_target methods.
	(_initialize_alphabsd_nat): Refactor as methods of
	alpha_bsd_nat_target.
	* amd64-nbsd-nat.c: Include "amd64-bsd-nat.h".
	(the_amd64_nbsd_nat_target): New.
	(_initialize_amd64nbsd_nat): Adjust to C++ification.
	* amd64-obsd-nat.c: Include "amd64-bsd-nat.h".
	(the_amd64_obsd_nat_target): New.
	(_initialize_amd64obsd_nat): Adjust to C++ification.
	* arm-fbsd-nat.c (arm_fbsd_nat_target): New.
	(the_arm_fbsd_nat_target): New.
	(arm_fbsd_fetch_inferior_registers)
	(arm_fbsd_store_inferior_registers, arm_fbsd_read_description):
	(_initialize_arm_fbsd_nat): Refactor as methods of
	arm_fbsd_nat_target.
	(_initialize_arm_fbsd_nat): Adjust to C++ification.
	* arm-nbsd-nat.c (arm_netbsd_nat_target): New class.
	(the_arm_netbsd_nat_target): New.
	(armnbsd_fetch_registers, armnbsd_store_registers): Refactor as
	arm_netbsd_nat_target.
	(_initialize_arm_netbsd_nat): Adjust to C++ification.
	* hppa-nbsd-nat.c (hppa_nbsd_nat_target): New class.
	(the_hppa_nbsd_nat_target): New.
	(hppanbsd_fetch_registers, hppanbsd_store_registers): Refactor as
	hppa_nbsd_nat_target methods.
	(_initialize_hppanbsd_nat): Adjust to C++ification.
	* hppa-obsd-nat.c (hppa_obsd_nat_target): New class.
	(the_hppa_obsd_nat_target): New.
	(hppaobsd_fetch_registers, hppaobsd_store_registers): Refactor as
	methods of hppa_obsd_nat_target.
	(_initialize_hppaobsd_nat): Adjust to C++ification.  Use
	add_target.
	* i386-nbsd-nat.c (the_i386_nbsd_nat_target): New.
	(_initialize_i386nbsd_nat): Adjust to C++ification.  Use
	add_target.
	* i386-obsd-nat.c (the_i386_obsd_nat_target): New.
	(_initialize_i386obsd_nat): Use add_target.
	* m68k-bsd-nat.c (m68k_bsd_nat_target): New class.
	(the_m68k_bsd_nat_target): New.
	(m68kbsd_fetch_inferior_registers)
	(m68kbsd_store_inferior_registers): Refactor as methods of
	m68k_bsd_nat_target.
	(_initialize_m68kbsd_nat): Adjust to C++ification.
	* mips-fbsd-nat.c (mips_fbsd_nat_target): New class.
	(the_mips_fbsd_nat_target): New.
	(mips_fbsd_fetch_inferior_registers)
	(mips_fbsd_store_inferior_registers): Refactor as methods of
	mips_fbsd_nat_target.
	(_initialize_mips_fbsd_nat): Adjust to C++ification.  Use
	add_target.
	* mips-nbsd-nat.c (mips_nbsd_nat_target): New class.
	(the_mips_nbsd_nat_target): New.
	(mipsnbsd_fetch_inferior_registers)
	(mipsnbsd_store_inferior_registers): Refactor as methods of
	mips_nbsd_nat_target.
	(_initialize_mipsnbsd_nat): Adjust to C++ification.
	* mips64-obsd-nat.c (mips64_obsd_nat_target): New class.
	(the_mips64_obsd_nat_target): New.
	(mips64obsd_fetch_inferior_registers)
	(mips64obsd_store_inferior_registers): Refactor as methods of
	mips64_obsd_nat_target.
	(_initialize_mips64obsd_nat): Adjust to C++ification.  Use
	add_target.
	* nbsd-nat.c (nbsd_pid_to_exec_file): Refactor as method of
	nbsd_nat_target.
	* nbsd-nat.h: Include "inf-ptrace.h".
	(nbsd_nat_target): New class.
	* obsd-nat.c (obsd_pid_to_str, obsd_update_thread_list)
	(obsd_wait): Refactor as methods of obsd_nat_target.
	(obsd_add_target): Delete.
	* obsd-nat.h: Include "inf-ptrace.h".
	(obsd_nat_target): New class.
	* ppc-fbsd-nat.c (ppc_fbsd_nat_target): New class.
	(the_ppc_fbsd_nat_target): New.
	(ppcfbsd_fetch_inferior_registers)
	(ppcfbsd_store_inferior_registers): Refactor as methods of
	ppc_fbsd_nat_target.
	(_initialize_ppcfbsd_nat): Adjust to C++ification.  Use
	add_target.
	* ppc-nbsd-nat.c (ppc_nbsd_nat_target): New class.
	(the_ppc_nbsd_nat_target): New.
	(ppcnbsd_fetch_inferior_registers)
	(ppcnbsd_store_inferior_registers): Refactor as methods of
	ppc_nbsd_nat_target.
	(_initialize_ppcnbsd_nat): Adjust to C++ification.
	* ppc-obsd-nat.c (ppc_obsd_nat_target): New class.
	(the_ppc_obsd_nat_target): New.
	(ppcobsd_fetch_registers, ppcobsd_store_registers): Refactor as
	methods of ppc_obsd_nat_target.
	(_initialize_ppcobsd_nat): Adjust to C++ification.  Use
	add_target.
	* sh-nbsd-nat.c (sh_nbsd_nat_target): New class.
	(the_sh_nbsd_nat_target): New.
	(shnbsd_fetch_inferior_registers)
	(shnbsd_store_inferior_registers): Refactor as methods of
	sh_nbsd_nat_target.
	(_initialize_shnbsd_nat): Adjust to C++ification.
	* sparc-nat.c (sparc_xfer_wcookie): Make extern.
	(inf_ptrace_xfer_partial): Delete.
	(sparc_xfer_partial, sparc_target): Delete.
	* sparc-nat.h (sparc_fetch_inferior_registers)
	(sparc_store_inferior_registers, sparc_xfer_wcookie): Declare.
	(sparc_target): Delete function declaration.
	(sparc_target): New template class.
	* sparc-nbsd-nat.c (the_sparc_nbsd_nat_target): New.
	(_initialize_sparcnbsd_nat): Adjust to C++ification.
	* sparc64-fbsd-nat.c (the_sparc64_fbsd_nat_target): New.
	(_initialize_sparc64fbsd_nat): Adjust to C++ification.  Use
	add_target.
	* sparc64-nbsd-nat.c (the_sparc64_nbsd_nat_target): New.
	(_initialize_sparc64nbsd_nat): Adjust to C++ification.
	* sparc64-obsd-nat.c (the_sparc64_obsd_nat_target): New.
	(_initialize_sparc64obsd_nat): Adjust to C++ification.  Use
	add_target.
	* vax-bsd-nat.c (vax_bsd_nat_target): New class.
	(the_vax_bsd_nat_target): New.
	(vaxbsd_fetch_inferior_registers)
	(vaxbsd_store_inferior_registers): Refactor as vax_bsd_nat_target
	methods.
	(_initialize_vaxbsd_nat): Adjust to C++ification.

	* bsd-kvm.c (bsd_kvm_target): New class.
	(bsd_kvm_ops): Now a bsd_kvm_target.
	(bsd_kvm_open, bsd_kvm_close, bsd_kvm_xfer_partial)
	(bsd_kvm_files_info, bsd_kvm_fetch_registers)
	(bsd_kvm_thread_alive, bsd_kvm_pid_to_str): Refactor as methods of
	bsd_kvm_target.
	(bsd_kvm_return_one): Delete.
	(bsd_kvm_add_target): Adjust to C++ification.

	* nto-procfs.c (nto_procfs_target, nto_procfs_target_native)
	(nto_procfs_target_procfs): New classes.
	(procfs_open_1, procfs_thread_alive, procfs_update_thread_list)
	(procfs_files_info, procfs_pid_to_exec_file, procfs_attach)
	(procfs_post_attach, procfs_wait, procfs_fetch_registers)
	(procfs_xfer_partial, procfs_detach, procfs_insert_breakpoint)
	(procfs_remove_breakpoint, procfs_insert_hw_breakpoint)
	(procfs_remove_hw_breakpoint, procfs_resume)
	(procfs_mourn_inferior, procfs_create_inferior, procfs_interrupt)
	(procfs_kill_inferior, procfs_store_registers)
	(procfs_pass_signals, procfs_pid_to_str, procfs_can_run): Refactor
	as methods of nto_procfs_target.
	(nto_procfs_ops): Now an nto_procfs_target_procfs.
	(nto_native_ops): Delete.
	(procfs_open, procfs_native_open): Delete.
	(nto_native_ops): Now an nto_procfs_target_native.
	(init_procfs_targets): Adjust to C++ification.
	(procfs_can_use_hw_breakpoint, procfs_remove_hw_watchpoint)
	(procfs_insert_hw_watchpoint, procfs_stopped_by_watchpoint):
	Refactor as methods of nto_procfs_target.

	* go32-nat.c (go32_nat_target): New class.
	(the_go32_nat_target): New.
	(go32_attach, go32_resume, go32_wait, go32_fetch_registers)
	(go32_store_registers, go32_xfer_partial, go32_files_info)
	(go32_kill_inferior, go32_create_inferior, go32_mourn_inferior)
	(go32_terminal_init, go32_terminal_info, go32_terminal_inferior)
	(go32_terminal_ours, go32_pass_ctrlc, go32_thread_alive)
	(go32_pid_to_str): Refactor as methods of go32_nat_target.
	(go32_target): Delete.
	(_initialize_go32_nat): Adjust to C++ification.

	* gnu-nat.c (gnu_wait, gnu_resume, gnu_kill_inferior)
	(gnu_mourn_inferior, gnu_create_inferior, gnu_attach, gnu_detach)
	(gnu_stop, gnu_thread_alive, gnu_xfer_partial)
	(gnu_find_memory_regions, gnu_pid_to_str): Refactor as methods of
	gnu_nat_target.
	(gnu_target): Delete.
	* gnu-nat.h (gnu_target): Delete.
	(gnu_nat_target): New class.
	* i386-gnu-nat.c (gnu_base_target): New.
	(i386_gnu_nat_target): New class.
	(the_i386_gnu_nat_target): New.
	(_initialize_i386gnu_nat): Adjust to C++ification.

gdb/testsuite/ChangeLog:
2018-05-02  Pedro Alves  <palves@redhat.com>

	* gdb.base/breakpoint-in-ro-region.exp: Adjust to to_resume and
	to_log_command renames.
	* gdb.base/sss-bp-on-user-bp-2.exp: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] target_ops: Use bool throughout
@ 2018-05-03  2:21 sergiodj+buildbot
  2018-05-03 17:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-03  2:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 57810aa7e8032c598897454daea14ed17df0f89d ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 57810aa7e8032c598897454daea14ed17df0f89d

target_ops: Use bool throughout

After the previous target_ops/C++ patches are all squashed and merged,
this one can go in separately.

This patch adjusts all the target methods to return bool instead of int
when they're returning a boolean.

gdb/ChangeLog:
2018-05-02  Pedro Alves  <palves@redhat.com>

	* target.h (target_ops)
	<stopped_by_sw_breakpoint, supports_stopped_by_sw_breakpoint,
	stopped_by_hw_breakpoint, supports_stopped_by_hw_breakpoint,
	stopped_by_watchpoint, have_continuable_watchpoint,
	stopped_data_address, watchpoint_addr_within_range,
	can_accel_watchpoint_condition, can_run, thread_alive,
	has_all_memory, has_memory, has_stack, has_registers,
	has_execution, can_async_p, is_async_p, supports_non_stop,
	always_non_stop_p, can_execute_reverse, supports_multi_process,
	supports_enable_disable_tracepoint,
	supports_disable_randomization, supports_string_tracing,
	supports_evaluation_of_breakpoint_conditions,
	can_run_breakpoint_commands, filesystem_is_local,
	can_download_tracepoint, get_trace_state_variable_value,
	set_trace_notes, get_tib_address, use_agent, can_use_agent,
	record_is_replaying, record_will_replay,
	augmented_libraries_svr4_read>: Adjust to return bool.
	* aarch64-linux-nat.c: All implementations adjusted.
	* aix-thread.c: All implementations adjusted.
	* arm-linux-nat.c: All implementations adjusted.
	* breakpoint.c: All implementations adjusted.
	* bsd-kvm.c: All implementations adjusted.
	* bsd-uthread.c: All implementations adjusted.
	* corelow.c: All implementations adjusted.
	* ctf.c: All implementations adjusted.
	* darwin-nat.c: All implementations adjusted.
	* darwin-nat.h: All implementations adjusted.
	* exec.c: All implementations adjusted.
	* fbsd-nat.c: All implementations adjusted.
	* fbsd-nat.h: All implementations adjusted.
	* gnu-nat.c: All implementations adjusted.
	* gnu-nat.h: All implementations adjusted.
	* go32-nat.c: All implementations adjusted.
	* ia64-linux-nat.c: All implementations adjusted.
	* inf-child.c: All implementations adjusted.
	* inf-child.h: All implementations adjusted.
	* inf-ptrace.c: All implementations adjusted.
	* inf-ptrace.h: All implementations adjusted.
	* linux-nat.c: All implementations adjusted.
	* linux-nat.h: All implementations adjusted.
	* mips-linux-nat.c: All implementations adjusted.
	* nto-procfs.c: All implementations adjusted.
	* ppc-linux-nat.c: All implementations adjusted.
	* procfs.c: All implementations adjusted.
	* ravenscar-thread.c: All implementations adjusted.
	* record-btrace.c: All implementations adjusted.
	* record-full.c: All implementations adjusted.
	* remote-sim.c: All implementations adjusted.
	* remote.c: All implementations adjusted.
	* s390-linux-nat.c: All implementations adjusted.
	* sol-thread.c: All implementations adjusted.
	* spu-multiarch.c: All implementations adjusted.
	* target-delegates.c: All implementations adjusted.
	* target.c: All implementations adjusted.
	* target.h: All implementations adjusted.
	* tracefile-tfile.c: All implementations adjusted.
	* tracefile.c: All implementations adjusted.
	* tracefile.h: All implementations adjusted.
	* windows-nat.c: All implementations adjusted.
	* x86-linux-nat.h: All implementations adjusted.
	* x86-nat.h: All implementations adjusted.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] linux_nat_target: More low methods
@ 2018-05-03  2:26 sergiodj+buildbot
  2018-05-03 18:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-03  2:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 135340afdf3b333cde11e4429fb16271d5170335 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 135340afdf3b333cde11e4429fb16271d5170335

linux_nat_target: More low methods

This converts the remaining linux-nat.c hooks low_ methods like had
been started in a previous patch.  The linux_nat_set_foo routines are
all gone with this.

gdb/ChangeLog:
2018-05-02  Pedro Alves  <palves@redhat.com>

	* linux-nat.h (linux_nat_target) <low_new_thread,
	low_delete_thread, low_new_fork, low_forget_process,
	low_prepare_to_resume, low_siginfo_fixup, low_status_is_event>:
	New virtual methods.
	(linux_nat_set_new_thread, linux_nat_set_delete_thread)
	(linux_nat_new_fork_ftype, linux_nat_set_new_fork)
	(linux_nat_forget_process_ftype, linux_nat_set_forget_process)
	(linux_nat_forget_process, linux_nat_set_siginfo_fixup)
	(linux_nat_set_prepare_to_resume, linux_nat_set_status_is_event):
	Delete.
	* linux-fork.c (delete_fork): Adjust to call low method.
	* linux-nat.c (linux_nat_new_thread, linux_nat_delete_thread)
	(linux_nat_new_fork, linux_nat_forget_process_hook)
	(linux_nat_prepare_to_resume, linux_nat_siginfo_fixup)
	(linux_nat_status_is_event):
	(linux_nat_target::follow_fork, lwp_free, add_lwp, detach_one_lwp)
	(linux_resume_one_lwp_throw, linux_handle_extended_wait): Adjust
	to call low method.
	(sigtrap_is_event): Rename to ...
	(linux_nat_target::low_status_is_event): ... this.
	(linux_nat_set_status_is_event): Delete.
	(save_stop_reason, linux_nat_wait_1)
	(linux_nat_target::mourn_inferior, siginfo_fixup): Adjust to call
	low methods.
	(linux_nat_set_new_thread, linux_nat_set_delete_thread)
	(linux_nat_set_new_fork, linux_nat_set_forget_process)
	(linux_nat_forget_process, linux_nat_set_siginfo_fixup)
	(linux_nat_set_prepare_to_resume): Delete.
	* aarch64-linux-nat.c: All linux_nat_set_* callbacks converted to
	low virtual methods.
	* amd64-linux-nat.c: Likewise.
	* arm-linux-nat.c: Likewise.
	* i386-linux-nat.c: Likewise.
	* ia64-linux-nat.c: Likewise.
	* mips-linux-nat.c: Likewise.
	* ppc-linux-nat.c: Likewise.
	* s390-linux-nat.c: Likewise.
	* sparc64-linux-nat.c: Likewise.
	* x86-linux-nat.c: Likewise.
	* x86-linux-nat.h: Include "nat/x86-linux.h".
	(x86_linux_nat_target) <low_new_fork, low_forget_process,
	low_prepare_to_resume, low_new_thread, low_delete_thread>:
	Override methods.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] target factories, target open and multiple instances of targets
@ 2018-05-03  2:31 sergiodj+buildbot
  2018-05-03 20:48 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-03  2:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d9f719f1adb653ab40a55e4c1b8c300215b400ff ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: d9f719f1adb653ab40a55e4c1b8c300215b400ff

target factories, target open and multiple instances of targets

Currently, to open a target, with "target TARGET_NAME", GDB finds the
target_ops instance with "TARGET_NAME" as short name, and then calls
its target_ops::open virtual method.  In reality, there's no actual
target/name lookup, a pointer to the target_ops object was associated
with the "target TARGET_NAME" command at add_target time (when GDB is
initialized), as the command's context.

This creates a chicken and egg situation.  Consider the case of
wanting to open multiple remote connections.  We want to be able to
have one remote target_ops instance per connection, but, if we're not
connected yet, so we don't yet have an instance to call target->open()
on...

This patch fixes this by separating out common info about a target_ops
to a separate structure (shortname, longname, doc), and changing the
add_target routine to take a reference to such an object instead of a
pointer to a target_ops, and a pointer to a factory function that is
responsible to open an instance of the corresponding target when the
user types "target TARGET_NAME".

 -extern void add_target (struct target_ops *);
 +extern void add_target (const target_info &info, target_open_ftype *func);

I.e. this factory function replaces the target_ops::open virtual
method.

For static/singleton targets, nothing changes, the target_open_ftype
function pushes the global target_ops instance on the target stack.
At target_close time, the connection is tor down, but the global
target_ops object remains live.

However, targets that support being open multiple times will make
their target_open_ftype routine allocate a new target_ops instance on
the heap [e.g., new remote_target()], and push that on the stack.  At
target_close time, the new object is destroyed (by the
target_ops::close virtual method).

Both the core target and the remote targets will support being open
multiple times (others could/should too, but those were my stopping
point), but not in this patch yet.  We need to get rid of more globals
first before that'd be useful.

Native targets are somewhat special, given find_default_run_target &
friends.  Those routines also expect to return a target_ops pointer,
even before we've open the target.  However, we'll never need more
than one instance of the native target, so we can assume/require that
native targets are global/simpletons, and have the backends register a
pointer to the native target_ops.  Since all native targets inherit
inf_child_target, we can centralize that registration.  See
add_inf_child_target, get_native_target/set_native_target and
find_default_run_target.

gdb/ChangeLog:
2018-05-02  Pedro Alves  <palves@redhat.com>

	* aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Use
	add_inf_child_target.
	* aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Use
	add_inf_child_target.
	* aix-thread.c (aix_thread_target_info): New.
	(aix_thread_target) <shortname, longname, doc>: Delete.
	<info>: New.
	* alpha-bsd-nat.c (_initialize_alphabsd_nat): Use
	add_inf_child_target.
	* alpha-linux-nat.c (_initialize_alpha_linux_nat): Use
	add_inf_child_target.
	* amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Use
	add_inf_child_target.
	* amd64-linux-nat.c (_initialize_amd64_linux_nat): Use
	add_inf_child_target.
	* amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Use
	add_inf_child_target.
	* amd64-obsd-nat.c (_initialize_amd64obsd_nat): Use
	add_inf_child_target.
	* arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Use
	add_inf_child_target.
	* arm-linux-nat.c (_initialize_arm_linux_nat): Use
	add_inf_child_target.
	* arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Use
	add_inf_child_target.
	* bfd-target.c (target_bfd_target_info): New.
	(target_bfd) <shortname, longname, doc>: Delete.
	<info>: New.
	* bsd-kvm.c (bsd_kvm_target_info): New.
	(bsd_kvm_target) <shortname, longname, doc>: Delete.
	<info>: New.
	(bsd_kvm_target::open): Rename to ...
	(bsd_kvm_target_open): ... this.  Adjust.
	* bsd-uthread.c (bsd_uthread_target_info): New.
	(bsd_uthread_target) <shortname, longname, doc>: Delete.
	<info>:	New.
	* corefile.c (core_file_command): Adjust.
	* corelow.c (core_target_info): New.
	(core_target) <shortname, longname, doc>: Delete.
	<info>: New.
	(core_target::open): Rename to ...
	(core_target_open): ... this.  Adjust.
	* ctf.c (ctf_target_info): New.
	(ctf_target) <shortname, longname, doc>: Delete.
	<info>:	New.
	(ctf_target::open): Rename to ...
	(ctf_target_open): ... this.
	(_initialize_ctf): Adjust.
	* exec.c (exec_target_info): New.
	(exec_target) <shortname, longname, doc>: Delete.
	<info>:	New.
	(exec_target::open): Rename to ...
	(exec_target_open): ... this.
	* gdbcore.h (core_target_open): Declare.
	* go32-nat.c (_initialize_go32_nat): Use add_inf_child_target.
	* hppa-linux-nat.c (_initialize_hppa_linux_nat): Use
	add_inf_child_target.
	* hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Use
	add_inf_child_target.
	* hppa-obsd-nat.c (_initialize_hppaobsd_nat): Use
	add_inf_child_target.
	* i386-darwin-nat.c (_initialize_i386_darwin_nat): Use
	add_inf_child_target.
	* i386-fbsd-nat.c (_initialize_i386fbsd_nat): Use
	add_inf_child_target.
	* i386-gnu-nat.c (_initialize_i386gnu_nat): Use
	add_inf_child_target.
	* i386-linux-nat.c (_initialize_i386_linux_nat): Use
	add_inf_child_target.
	* i386-nbsd-nat.c (_initialize_i386nbsd_nat): Use
	add_inf_child_target.
	* i386-obsd-nat.c (_initialize_i386obsd_nat): Use
	add_inf_child_target.
	* ia64-linux-nat.c (_initialize_ia64_linux_nat): Use
	add_inf_child_target.
	* inf-child.c (inf_child_target_info): New.
	(inf_child_target::info): New.
	(inf_child_open_target): Remove 'target' parameter.  Use
	get_native_target instead.
	(inf_child_target::open): Delete.
	(add_inf_child_target): New.
	* inf-child.h (inf_child_target) <shortname, longname, doc, open>:
	Delete.
	<info>:	New.
	(add_inf_child_target): Declare.
	(inf_child_open_target): Declare.
	* linux-thread-db.c (thread_db_target_info): New.
	(thread_db_target) <shortname, longname, doc>: Delete.
	<info>:	New.
	* m32r-linux-nat.c (_initialize_m32r_linux_nat): Use
	add_inf_child_target.
	* m68k-bsd-nat.c (_initialize_m68kbsd_nat): Use
	add_inf_child_target.
	* m68k-linux-nat.c (_initialize_m68k_linux_nat): Use
	add_inf_child_target.
	* m88k-bsd-nat.c (_initialize_m88kbsd_nat): Use
	add_inf_child_target.
	* make-target-delegates (print_class): Adjust.
	* mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Use
	add_inf_child_target.
	* mips-linux-nat.c (_initialize_mips_linux_nat): Use
	add_inf_child_target.
	* mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Use
	add_inf_child_target.
	* mips64-obsd-nat.c (_initialize_mips64obsd_nat): Use
	add_inf_child_target.
	* nto-procfs.c (nto_native_target_info): New.
	(nto_procfs_target_native) <shortname, longname, doc>:
	Delete.
	<info>:	New.
	(nto_procfs_target_info): New.
	(nto_procfs_target_procfs) <shortname, longname, doc>:
	Delete.
	<info>:	New.
	(init_procfs_targets): Adjust.
	* ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Use
	add_inf_child_target.
	* ppc-linux-nat.c (_initialize_ppc_linux_nat): Use
	add_inf_child_target.
	* ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Use
	add_inf_child_target.
	* ppc-obsd-nat.c (_initialize_ppcobsd_nat): Use
	add_inf_child_target.
	* ravenscar-thread.c (ravenscar_target_info): New.
	(ravenscar_thread_target) <shortname, longname, doc>:
	Delete.
	<info>:	New.
	* record-btrace.c (record_btrace_target_info):
	(record_btrace_target) <shortname, longname, doc>: Delete.
	<info>: New.
	(record_btrace_target::open): Rename to ...
	(record_btrace_target_open): ... this.  Adjust.
	* record-full.c (record_longname, record_doc): New.
	(record_full_base_target) <shortname, longname, doc>: Delete.
	<info>: New.
	(record_full_target_info): New.
	(record_full_target): <shortname>: Delete.
	<info>: New.
	(record_full_core_open_1, record_full_open_1): Update comments.
	(record_full_base_target::open): Rename to ...
	(record_full_open): ... this.
	(cmd_record_full_restore): Update.
	(_initialize_record_full): Update.
	* remote-sim.c (remote_sim_target_info): New.
	(gdbsim_target) <shortname, longname, doc>: Delete.
	<info>: New.
	(gdbsim_target::open): Rename to ...
	(gdbsim_target_open): ... this.
	(_initialize_remote_sim): Adjust.
	* remote.c (remote_doc): New.
	(remote_target_info): New.
	(remote_target) <shortname, longname, doc>: Delete.
	<info>: New.
	(extended_remote_target_info): New.
	(extended_remote_target) <shortname, longname, doc>: Delete.
	<info>: New.
	(remote_target::open_1): Make static.  Adjust.
	* rs6000-nat.c (_initialize_rs6000_nat): Use add_inf_child_target.
	* s390-linux-nat.c (_initialize_s390_nat): Use
	add_inf_child_target.
	* sh-nbsd-nat.c (_initialize_shnbsd_nat): Use
	add_inf_child_target.
	* sol-thread.c (thread_db_target_info): New.
	(sol_thread_target) <shortname, longname, doc>: Delete.
	<info>: New.
	* sparc-linux-nat.c (_initialize_sparc_linux_nat): Use
	add_inf_child_target.
	* sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Use
	add_inf_child_target.
	* sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Use
	add_inf_child_target.
	* sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Use
	add_inf_child_target.
	* sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Use
	add_inf_child_target.
	* sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Use
	add_inf_child_target.
	* spu-linux-nat.c (_initialize_spu_nat): Use
	add_inf_child_target.
	* spu-multiarch.c (spu_multiarch_target_info): New.
	(spu_multiarch_target) <shortname, longname, doc>: Delete.
	<info>: New.
	* target-delegates.c: Regenerate.
	* target.c: Include <unordered_map>.
	(target_ops_p): Delete.
	(DEF_VEC_P(target_ops_p)): Delete.
	(target_factories): New.
	(test_target_info): New.
	(test_target_ops::info): New.
	(open_target): Adjust to use target_factories.
	(add_target_with_completer): Rename to ...
	(add_target): ... this.  Change prototype.  Register target_info
	and open callback in target_factories.  Register target_info in
	command context instead of target_ops.
	(add_target): Delete old implementation.
	(add_deprecated_target_alias): Change prototype.  Adjust.
	(the_native_target): New.
	(set_native_target, get_native_target): New.
	(find_default_run_target): Use the_native_target.
	(find_attach_target, find_run_target): Simplify.
	(target_ops::open): Delete.
	(dummy_target_info): New.
	(dummy_target::shortname, dummy_target::longname)
	(dummy_target::doc): Delete.
	(dummy_target::info): New.
	(debug_target::shortname, debug_target::longname)
	(debug_target::doc): Delete.
	(debug_target::info): New.
	* target.h (struct target_info): New.
	(target_ops::~target_ops): Add comment.
	(target_ops::info): New.
	(target_ops::shortname, target_ops::longname, target_ops::doc): No
	longer virtual.  Implement in terms of target_info.
	(set_native_target, get_native_target): Declare.
	(target_open_ftype): New.
	(add_target, add_target_with_completer)
	(add_deprecated_target_alias): Change prototype.
	(test_target) <shortname, longname, doc>: Delete.
	<info>: New.
	* tilegx-linux-nat.c (_initialize_tile_linux_nat): Use
	add_inf_child_target.
	* tracefile-tfile.c (tfile_target_info): New.
	(tfile_target) <shortname, longname, doc>: Delete.
	<info>: New.
	(tfile_target::open): Rename to ...
	(tfile_target_open): ... this.
	(_initialize_tracefile_tfile): Adjust.
	* vax-bsd-nat.c (_initialize_vaxbsd_nat): Use
	add_inf_child_target.
	* windows-nat.c (_initialize_windows_nat): Use
	add_inf_child_target.
	* xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Use
	add_inf_child_target.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Eliminate target_ops::to_xclose
@ 2018-05-03  2:54 sergiodj+buildbot
  2018-05-03 11:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-03  2:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3fffc0701a26bc0baa563fdc793cafb3d3f02a93 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 3fffc0701a26bc0baa563fdc793cafb3d3f02a93

Eliminate target_ops::to_xclose

In the multi-target branch, I found no need for the target_close vs
target_xclose distinction.  Heap-allocated targets simply delete
themselves in their target_close implementation, while
singleton/static targets don't.

The target_ops C++ification patches will add more commentary around
target_ops's destructor, but there's no destructor yet...

gdb/ChangeLog:
2018-05-02  Pedro Alves  <palves@redhat.com>

	* bfd-target.c (target_bfd_xclose): Rename to ...
	(target_bfd_close): ... this.
	(target_bfd_reopen): Adjust.
	* target.c (target_close): Remove references to to_xclose.
	* target.h (target_ops::to_xclose): Delete.
	(target_ops::to_close): Update comments.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix s390 GNU/Linux build
@ 2018-05-03 11:31 sergiodj+buildbot
  2018-05-03 22:43 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-03 11:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bd732259bd3bec9494a2f1f39f74255dd4a9be85 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: bd732259bd3bec9494a2f1f39f74255dd4a9be85

Fix s390 GNU/Linux build

- Fixes this compile error:

  ../../src/gdb/s390-linux-nat.c:125:8: error: virtual bool s390_linux_nat_target::have_continuable_watchpoint() can be marked override [-Werror=suggest-override]
     bool have_continuable_watchpoint () { return 1; }
	  ^~~~~~~~~~~~~~~~~~~~~~~~~~~

  s390 never implemented that hook.  The declaration of the method got
  there simply via copy/paste from some other target.

  Return 'true' instead of '1' while at it.

- Fixes this link error:

  s390-linux-nat.o:(.rodata._ZTV21s390_linux_nat_target[_ZTV21s390_linux_nat_target]+0x120): undefined reference to `s390_linux_nat_target::watchpoint_addr_within_range(unsigned long, unsigned long, int)'

gdb/ChangeLog:
2018-05-03  Pedro Alves  <palves@redhat.com>

	* s390-linux-nat.c
	(s390_linux_nat_target::have_continuable_watchpoint): Mark with
	override.  Write 'true' instead of '1'.
	(s390_linux_nat_target::watchpoint_addr_within_range): Remove
	declaration.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] BFD: Prevent writing the MIPS _gp_disp symbol into symbol tables
@ 2018-05-03 17:01 sergiodj+buildbot
  2018-05-04  1:34 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-03 17:01 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3be08ea4728b56d35e136af4e6fd3086ade17764 ***

Author: Simon Atanasyan <simon@atanasyan.com>
Branch: master
Commit: 3be08ea4728b56d35e136af4e6fd3086ade17764

BFD: Prevent writing the MIPS _gp_disp symbol into symbol tables

The _gp_disp is a magic symbol, always implicitly defined by the linker.
It does not make a sense to write it into symbol tables for output files.
Moreover, now if the linker gets a version script, the _gp_disp symbol
gets zero version definition index.  The zero index means[1]:

"The symbol is local, not available outside the object."

But the _gp_disp symbol has GLOBAL binding.  That confuses some tools
like for example the LLD linker when they get such files as inputs.

This patch fixes the problem - it prevents writing the _gp_disp symbol
in regular and dynamic symbol tables.

This was tested by running LD test suite on a mipsel-linux board.

References:

[1] "Linux Standard Base Specification", Section "10.7.2 Symbol
    Version Table", p. 32

2018-05-03  Simon Atanasyan  <simon@atanasyan.com>

bfd/

	* elf32-mips.c: (elf32_mips_fixup_symbol): New function.
	(elf_backend_fixup_symbol): New macro.
	* elfxx-mips.c: (mips_elf_output_extsym): Discard _gp_disp
	handling.
	(_bfd_mips_elf_finish_dynamic_symbol): Likewise.

ld/

	* testsuite/ld-mips-elf/gp-disp-sym.d: New test.
	* testsuite/ld-mips-elf/gp-disp-sym.s: New test source.
	* testsuite/ld-mips-elf/mips-elf.exp: Run the new test.
	* testsuite/ld-mips-elf/mips16-pic-2.ad: Update for _gp_disp
	symbol removal.
	* testsuite/ld-mips-elf/mips16-pic-2.nd: Likewise.
	* testsuite/ld-mips-elf/pic-and-nonpic-3a.dd: Likewise.
	* testsuite/ld-mips-elf/tlslib-o32-hidden.got: Likewise.
	* testsuite/ld-mips-elf/tlslib-o32-ver.got: Likewise.
	* testsuite/ld-mips-elf/tlslib-o32.got: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb/testsuite: Filter out some registers for riscv
@ 2018-05-03 21:34 sergiodj+buildbot
  2018-05-04  4:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-03 21:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9b0797e268d96e8b46c328792aec3d6289585aa2 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 9b0797e268d96e8b46c328792aec3d6289585aa2

gdb/testsuite: Filter out some registers for riscv

On riscv the cycle counter, and instructions retired counter CSRs are
read only, this causes problems in the gdb.base/callfuncs.exp test, as
the values in these CSRs change after an inferior call, the check that
no target registers have been modified then fails.

Luckily the test already has a mechanism in place for filtering out
registers that are modified (and can't be restored) by an inferior call,
so this commit adds the problem registers into this list for riscv.

In the future we may end up needing to filter out more CSRs, but right
now, for the targets I have access too, these are the only ones causing
problems.

gdb/testsuite/ChangeLog:

	* gdb.base/callfuncs.exp (fetch_all_registers): Add riscv register
	filter pattern.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use flex's -t option instead of --stdout
@ 2018-05-03 22:18 sergiodj+buildbot
  2018-05-04  5:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-03 22:18 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4ea17de8f1985273215b515d48fbd59b2ced3cd1 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 4ea17de8f1985273215b515d48fbd59b2ced3cd1

Use flex's -t option instead of --stdout

As reported in

  https://sourceware.org/ml/gdb-patches/2018-05/msg00042.html

some old versions of flex (2.5.4) don't support the --stdout switch.
Use -t, which is an alias.

gdb/ChangeLog:

	* Makefile.in (%.c: %.l): Use -t instead of --stdout.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] ppc: Fix warning messages when IBM and IEEE long double are mixed
@ 2018-05-04  9:34 sergiodj+buildbot
  2018-05-04 10:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-04  9:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a27ca19c95ad3ebc5bd73f072facdd71b5a976ad ***

Author: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
Branch: master
Commit: a27ca19c95ad3ebc5bd73f072facdd71b5a976ad

ppc: Fix warning messages when IBM and IEEE long double are mixed

When IBM long double is used, the .gnu_attribute 4 is set to 1 | (1 *
4).  IEEE long double sets the same .gnu_attribute to 1 | (3 * 4).

	* elf32-ppc.c (_bfd_elf_ppc_merge_fp_attributes): Fix the order
	of arguments when warning about different long double types.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] -Wstringop-truncation warnings
@ 2018-05-04 10:22 sergiodj+buildbot
  2018-05-04 13:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-04 10:22 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 602f16570454a1597c2af28af66852133432d1f2 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 602f16570454a1597c2af28af66852133432d1f2

-Wstringop-truncation warnings

This patch is aimed at silencing gcc8 -Wstringop-truncation warnings.

Unfortunately adding  __attribute__ ((__nonstring)) doesn't work in a
number of the places patched here, (see
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85643) so if you have
recent glibc headers installed you'll need to configure binutils with
--disable-werror to compile using gcc8 or gcc9.

include/
	* ansidecl.h: Import from gcc.
	* coff/internal.h (struct internal_scnhdr): Add ATTRIBUTE_NONSTRING
	to s_name.
	(struct internal_syment): Add ATTRIBUTE_NONSTRING to _n_name.
bfd/
	* elf-linux-core.h (struct elf_external_linux_prpsinfo32_ugid32),
	(struct elf_external_linux_prpsinfo32_ugid16),
	(struct elf_external_linux_prpsinfo64_ugid32),
	(struct elf_external_linux_prpsinfo64_ugid16): Add ATTRIBUTE_NONSTRING
	to pr_fname and pr_psargs fields.  Remove GCC diagnostic pragmas.
	Move comment to..
	* elf.c (elfcore_write_prpsinfo): ..here.  Indent nested preprocessor
	directives.
	* elf32-arm.c (elf32_arm_nabi_write_core_note): Add ATTRIBUTE_NONSTRING
	to data.
	* elf32-ppc.c (ppc_elf_write_core_note): Likewise.
	* elf32-s390.c (elf_s390_write_core_note): Likewise.
	* elf64-s390.c (elf_s390_write_core_note): Likewise.
	* elfxx-aarch64.c (_bfd_aarch64_elf_write_core_note): Likewise.
	* elf64-x86-64.c (elf_x86_64_write_core_note): Add GCC diagnostic
	pragmas.
	* peXXigen.c (_bfd_XXi_swap_scnhdr_out): Use strnlen to avoid
	false positive gcc-8 warning.
gas/
	* config/obj-evax.c (shorten_identifier): Use memcpy in place
	of strncpy.
	* config/obj-macho.c (obj_mach_o_make_or_get_sect): Ensure
	segname and sectname fields are NUL terminated.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb/testsuite: Fix broken regexp in gdbstub case
@ 2018-05-04 11:04 sergiodj+buildbot
  2018-05-04 14:35 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-04 11:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 089a949083dcd5c679376033e975d54093007408 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 089a949083dcd5c679376033e975d54093007408

gdb/testsuite: Fix broken regexp in gdbstub case

When $use_gdb_stub is true then, when we start an MI target there's a
regexp to match GDB's startup pattern.  Unfortunately the pattern is
broken, and we're also missing a timeout case in the match list (which
would have helped point out that the regexp was broken).

The changes to the regexp are:

  1. Remove '${run_match}' prefix, the issued command doesn't include
  '${run_prefix}' so expecting '${run_match}' is wrong.

  2. Replaced '\\n' with '\\\\n' in order to match literal '\n' in
  GDBs output (that is, match a backslash followed by 'n', not a
  newline character).

  3. Replaced a '.' (matching any character) with '\.' to match a '.'
  and moved the '\.' into the correct place in the regexp.

  4. Replaced '\r\n' with '[\r\n]+' to match the end of a line.  This
  change isn't esential, but matches the other end of line patterns
  within this regexp.

Here's an example of the output that the regexp should match taken
from a testfile log, the first line is the command sent to GDB, and
the remaining lines are the response from GDB:

  jump *_start
  &"jump *_start\n"
  ~"Continuing at 0x10074.\n"
  ^running
  *running,thread-id="all"
  (gdb)

gdb/testsuite/ChangeLog:

	* lib/mi-support.exp (mi_run_cmd_full): Fix regexp and add a
	timeout.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] configure uses incorrect link order when testing libpython
@ 2018-05-04 14:14 sergiodj+buildbot
  2018-05-04 17:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-04 14:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bf27f0e2c76839af8524e053cca271934150a90c ***

Author: Paul Pluzhnikov <ppluzhnikov@google.com>
Branch: master
Commit: bf27f0e2c76839af8524e053cca271934150a90c

configure uses incorrect link order when testing libpython

References:

https://stackoverflow.com/a/49868387
https://sourceware.org/bugzilla/show_bug.cgi?id=11420

Configure uses "gcc -o conftest -g ... conftest.c -ldl -lncurses -lm -ldl
... -lpthread ... -lpython2.7" when deciding whether give libpython is
usable.

That of course is the wrong link order, and only works for shared libraries
(mostly by accident), and only on some systems.

gdb/ChangeLog:

	PR gdb/11420
	* configure.ac: Prepend libpython.
	* python/python-config.py: Likewise.
	* configure: Regenerate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb/testsuite: Handle targets with lots of registers
@ 2018-05-04 15:01 sergiodj+buildbot
  2018-05-04 18:55 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-04 15:01 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 11859c310cd6b6fd892337a5ee1d36921e6d08d8 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 11859c310cd6b6fd892337a5ee1d36921e6d08d8

gdb/testsuite: Handle targets with lots of registers

In gdb.base/maint.exp a test calls 'maint print registers'.  If the
target has lots of registers this may overflow expect's buffers,
causing the test to fail.

After this commit we process the output line at a time until we get back
to the GDB prompt, this should prevent buffer overrun while still
testing that the command works as required.

gdb/testsuite/ChangeLog:

	* gdb.base/maint.exp: Process output from 'maint print registers'
	line at a time.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove a cleanup from remote.c
@ 2018-05-04 15:39 sergiodj+buildbot
  2018-05-04 21:05 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-04 15:39 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 69b6ecb049143078f43a9372b68ac90a4601dc8c ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 69b6ecb049143078f43a9372b68ac90a4601dc8c

Remove a cleanup from remote.c

This removes a cleanup from remote.c by using std::string to construct
the qSupported packet.

Tested by the buildbot.

ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	* remote.c (remote_query_supported_append): Change type.
	(remote_check_symbols): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [spu] Fix build break
@ 2018-05-04 17:42 sergiodj+buildbot
  2018-05-04 23:18 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-04 17:42 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2be4d7f0e0f733ba0acc2120fdff62bd83fb8b3a ***

Author: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Branch: master
Commit: 2be4d7f0e0f733ba0acc2120fdff62bd83fb8b3a

[spu] Fix build break

gdb/ChangeLog:
2018-05-04  Ulrich Weigand  <uweigand@de.ibm.com>

	* spu-linux-nat.c (spu_linux_nat_target::wait): Fix syntax error.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use gdb_bfd_ref_ptr in target_bfd
@ 2018-05-04 18:25 sergiodj+buildbot
  2018-05-05  1:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-04 18:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ade72a3453670d518ba14fe47bc7a64df81ce766 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: ade72a3453670d518ba14fe47bc7a64df81ce766

Use gdb_bfd_ref_ptr in target_bfd

I noticed that target_bfd was using manual reference counting for the
BFD it held.  This patch changes it to use gdb_bfd_ref_ptr instead.

Tested by the buildbot.

ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	* bfd-target.c (target_bfd::m_bfd): Now a gdb_bfd_ref_ptr.
	(target_bfd::target_bfd, target_bfd::~target_bfd): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove cleanup from old_renaming_is_invisible
@ 2018-05-04 19:03 sergiodj+buildbot
  2018-05-05  3:39 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-04 19:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 49d83361cda4614f571f46c6bc0464092daf3dc9 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 49d83361cda4614f571f46c6bc0464092daf3dc9

Remove cleanup from old_renaming_is_invisible

This removes a cleanup from ada-lang.c by changing xget_renaming_scope
to return a std::string.

ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	* ada-lang.c (xget_renaming_scope): Return std::string.
	(old_renaming_is_invisible): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Return std::string from ada_exception_catchpoint_cond_string
@ 2018-05-04 19:36 sergiodj+buildbot
  2018-05-05  5:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-04 19:36 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cb7de75eb33b2ceda391c903cac5e5ed63933b99 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: cb7de75eb33b2ceda391c903cac5e5ed63933b99

Return std::string from ada_exception_catchpoint_cond_string

This changes ada_exception_catchpoint_cond_string to return a
std::string, allowing for the removal of a cleanup in
create_excep_cond_exprs.

ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	* ada-lang.c (create_excep_cond_exprs): Update.
	(ada_exception_catchpoint_cond_string): Use std::string.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove do_closedir_cleanup
@ 2018-05-04 20:13 sergiodj+buildbot
  2018-05-05 11:02 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-04 20:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f0b3976bdcd29e308bed185630a24806037a717c ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: f0b3976bdcd29e308bed185630a24806037a717c

Remove do_closedir_cleanup

This removes both copies of do_closedir_cleanup in favor of a new
unique_ptr specialization.

Tested by the buildbot, though I'm not sure that these code paths are
exercised there.

ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	* nto-procfs.c (do_closedir_cleanup): Remove.
	(procfs_pidlist): Use gdb_dir_up.
	* procfs.c (do_closedir_cleanup): Remove.
	(proc_update_threads): Use gdb_dir_up.
	* common/filestuff.h (struct gdb_dir_deleter): New.
	(gdb_dir_up): New typedef.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove cleanup from print_mention_exception
@ 2018-05-04 20:29 sergiodj+buildbot
  2018-05-05  8:00 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-04 20:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 862d101ada6b6e8496e545c0bcd801cf8b9a46c1 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 862d101ada6b6e8496e545c0bcd801cf8b9a46c1

Remove cleanup from print_mention_exception

This removes a cleanup from print_mention_exception by using
string_printf.

ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	* ada-lang.c (print_mention_exception): Use std::string.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use previous count when 'x' command is repeated
@ 2018-05-04 20:33 sergiodj+buildbot
  2018-05-05 13:00 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-04 20:33 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9be2ae8fc6b908746d9d7ebaf77aec8abba5dd2c ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 9be2ae8fc6b908746d9d7ebaf77aec8abba5dd2c

Use previous count when 'x' command is repeated

About the 'x' command, the manual says:

    If you use <RET> to repeat the 'x' command, the repeat count N is
    used again; the other arguments default as for successive uses of
    'x'.

However, PR gdb/22619 points out that this does not work.

This patch fixes the problem.

ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	PR gdb/22619:
	* printcmd.c (last_count): New global.
	(x_command): Use saved count when repeating.

testsuite/ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	PR gdb/22619:
	* gdb.base/long_long.exp (gdb_test_long_long): Add test for repeat
	behavior.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Minor cleanups in printcmd.c
@ 2018-05-04 20:53 sergiodj+buildbot
  2018-05-05 15:22 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-04 20:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2f433492bd9dd3af10aab8d92dc0bfbf8ff6c5e8 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 2f433492bd9dd3af10aab8d92dc0bfbf8ff6c5e8

Minor cleanups in printcmd.c

This changes decode_format to use skip_spaces, and changes printcmd.c
not to include tui.h, which apparently is not needed.

2018-05-04  Tom Tromey  <tom@tromey.com>

	* printcmd.c: Don't include tui.h.
	(decode_format): Use skip_spaces.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] (SPARC/LEON) fix incorrect array return value printed by "finish"
@ 2018-05-04 21:12 sergiodj+buildbot
  2018-05-05 17:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-04 21:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 05bc7456b872b81044d3b0e7c4d74c1de57217fd ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 05bc7456b872b81044d3b0e7c4d74c1de57217fd

(SPARC/LEON) fix incorrect array return value printed by "finish"

Consider the code in the gdb.ada/array_return.exp testcase, which
defines a function returning an array of 2 integers:

   type Data_Small is array (1 .. 2) of Integer;
   function Create_Small return Data_Small;

When doing a "finish" from inside function Create_Small, we expect
GDB to tell us that the return value was "(1, 1)". However, it currently
prints the wrong value:

    (gdb) finish
    Run till exit from #0  pck.create_small () at /[...]/pck.adb:5
    p () at /[...]/p.adb:10
    10         Large := Create_Large;
    Value returned is $1 = (0, 0)

This is a regression which I traced back to the following commit...

    | commit 1933fd8ee01ad2e74a9c6341bc40f54962a8f889
    | Date:   Fri May 19 03:06:19 2017 -0700
    | Subject: gdb: fix TYPE_CODE_ARRAY handling in sparc targets

... which, despite what the subject says, is not really about
TYPE_CODE_ARRAY handling, which is a bit of an implementation detail,
but about the GNU vectors extension.

The author of the patch equated TYPE_CODE_ARRAY with vectors, which
is not correct. Vectors are TYPE_CODE_ARRAY types with the TYPE_VECTOR
flag set. So at the very minimum, the patch should have been checking
for both TYPE_CODE_ARRAY and TYPE_VECTOR.

But, that's not the only thing that did not seem right to me. When
looking at the ABI, and at the summary of the implementation in GCC
of the calling conventions for that architecture:

                                size      argument     return value

      small integer              <4       int. reg.      int. reg.
      word                        4       int. reg.      int. reg.
      double word                 8       int. reg.      int. reg.

      _Complex small integer     <8       int. reg.      int. reg.
      _Complex word               8       int. reg.      int. reg.
      _Complex double word       16        memory        int. reg.

      vector integer            <=8       int. reg.       FP reg.
      vector integer             >8        memory         memory

      float                       4       int. reg.       FP reg.
      double                      8       int. reg.       FP reg.
      long double                16        memory         memory

      _Complex float              8        memory         FP reg.
      _Complex double            16        memory         FP reg.
      _Complex long double       32        memory         FP reg.

      vector float              any        memory         memory

      aggregate                 any        memory         memory

The nice thing about the patch above is that it nicely factorized
the code that determines how arguments are passed/returns. The bad
news is that the implementation, particularly for the handling of
arrays and vectors, doesn't seem to match the summary above. Hence,
the regression we observed.

So what I did was review and re-implement some of the predicate functions
according to the summary above. Because dejagnu crashes all our Solaris
machines real bad, I can't run the dejagnu testsuite there. So what I did
was test the patch with AdaCore's testsuite against leon3-elf, no
regression. I verified that this fixes the regression above while
at the same time still passing gdb.base/gnu_vector.exp (I transposed
that testcase to our testsuite), which is the testcase that was cited
in the commit above as seeing some FAIL->PASS improvements.

This patch also removes one assertion...

      gdb_assert (sparc_integral_or_pointer_p (type)
                  || (TYPE_CODE (type) == TYPE_CODE_ARRAY && len <= 8));

... because that assertion is really the "negative" of the other conditions
written in the same "if, else if, else [assert]" block in this function.
To me, this assertion forces us to maintain two versions of the same code,
and is an unnecessary burden. In particular, the above is not the
correct condition, and the ABI summary table above shows that we need
a more complex condition to describe the situations where we expect
arguments to be passed by register.

gdb/ChangeLog:

        * sparc-tdep.c (sparc_structure_return_p): Re-implement to
        match the ABI as summarized in GCC's gcc/config/sparc/sparc.c.
        (sparc_arg_by_memory_p): Renamed from sparc_arg_on_registers_p.
        Re-implement to match the ABI as summarized in GCC's
        gcc/config/sparc/sparc.c.  All callers updated.
        (sparc32_store_arguments): Remove assertion.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb: Make test names unique in gdb.base/maint.exp
@ 2018-05-04 22:05 sergiodj+buildbot
  2018-05-05 20:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-04 22:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 45fe4a03b495f778013f0a0deb06512913e1955b ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 45fe4a03b495f778013f0a0deb06512913e1955b

gdb: Make test names unique in gdb.base/maint.exp

Add prefixes or suffixes to some test names to make them unique.

Replace a send_gdb/gdb_expect with a gdb_test, and make the test name
unique.

Remove test of 'help maint' as this is already covered by a later call
to test_prefix_command_help.

Removed test of 'help maint info' and add a new call to
test_prefix_command_help instead.

gdb/testsuite/ChangeLog:

	* gdb.base/maint.exp: Make test names unique, use
	test_prefix_command_help to test 'help maint info', and remove
	repeated test of 'help maint'.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] aarch64: PR 19806: watchpoints: false negatives + PR 20207 contiguous ones
@ 2018-05-04 22:30 sergiodj+buildbot
  2018-05-06  1:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-04 22:30 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a3b60e4588606354b93508a0008a5ca04b68fad8 ***

Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Branch: master
Commit: a3b60e4588606354b93508a0008a5ca04b68fad8

aarch64: PR 19806: watchpoints: false negatives + PR 20207 contiguous ones

Some unaligned watchpoints were currently missed.

On old kernels as specified in
	kernel RFE: aarch64: ptrace: BAS: Support any contiguous range (edit)
	https://sourceware.org/bugzilla/show_bug.cgi?id=20207
after this patch some other unaligned watchpoints will get reported as false
positives.

With new kernels all the watchpoints should work exactly.

There may be a regresion that it now less merges watchpoints so that with
multiple overlapping watchpoints it may run out of the 4 hardware watchpoint
registers.  But as discussed in the original thread GDB needs some generic
watchpoints merging framework to be used by all the target specific code.
Even current FSF GDB code does not merge it perfectly.  Also with the more
precise watchpoints one can technically merge them less.  And I do not think
it matters too much to improve mergeability only for old kernels.
Still even on new kernels some better merging logic would make sense.

There remains one issue:
	kernel-4.15.14-300.fc27.armv7hl
	FAIL: gdb.base/watchpoint-unaligned.exp: continue
	FAIL: gdb.base/watchpoint-unaligned.exp: continue
	(gdb) continue
	Continuing.
	Unexpected error setting watchpoint: Invalid argument.
	(gdb) FAIL: gdb.base/watchpoint-unaligned.exp: continue
But that looks as a kernel bug to me.
(1) It is not a regression by this patch.
(2) It is unrelated to this patch.

gdb/ChangeLog
2018-05-04  Jan Kratochvil  <jan.kratochvil@redhat.com>
	    Pedro Alves <palves@redhat.com>

	PR breakpoints/19806 and support for PR external/20207.
	* NEWS: Mention Aarch64 watchpoint improvements.
	* aarch64-linux-nat.c (aarch64_linux_stopped_data_address): Fix missed
	watchpoints and PR external/20207 watchpoints.
	* nat/aarch64-linux-hw-point.c
	(kernel_supports_any_contiguous_range): New.
	(aarch64_watchpoint_offset): New.
	(aarch64_watchpoint_length): Support PR external/20207 watchpoints.
	(aarch64_point_encode_ctrl_reg): New parameter offset, new asserts.
	(aarch64_point_is_aligned): Support PR external/20207 watchpoints.
	(aarch64_align_watchpoint): New parameters aligned_offset_p and
	next_addr_orig_p.  Support PR external/20207 watchpoints.
	(aarch64_downgrade_regs): New.
	(aarch64_dr_state_insert_one_point): New parameters offset and
	addr_orig.
	(aarch64_dr_state_remove_one_point): Likewise.
	(aarch64_handle_breakpoint): Update caller.
	(aarch64_handle_aligned_watchpoint): Likewise.
	(aarch64_handle_unaligned_watchpoint): Support addr_orig and
	aligned_offset.
	(aarch64_linux_set_debug_regs): Remove const from state.  Call
	aarch64_downgrade_regs.
	(aarch64_show_debug_reg_state): Print also dr_addr_orig_wp.
	* nat/aarch64-linux-hw-point.h (DR_CONTROL_LENGTH): Rename to ...
	(DR_CONTROL_MASK): ... this.
	(struct aarch64_debug_reg_state): New field dr_addr_orig_wp.
	(unsigned int aarch64_watchpoint_offset): New prototype.
	(aarch64_linux_set_debug_regs): Remove const from state.
	* utils.c (align_up, align_down): Move to ...
	* common/common-utils.c (align_up, align_down): ... here.
	* utils.h (align_up, align_down): Move to ...
	* common/common-utils.h (align_up, align_down): ... here.

gdb/gdbserver/ChangeLog
2018-05-04  Jan Kratochvil  <jan.kratochvil@redhat.com>
	    Pedro Alves <palves@redhat.com>

	* linux-aarch64-low.c (aarch64_stopped_data_address):
	Likewise.

gdb/testsuite/ChangeLog
2018-05-04  Jan Kratochvil  <jan.kratochvil@redhat.com>
	    Pedro Alves <palves@redhat.com>

	PR breakpoints/19806 and support for PR external/20207.
	* gdb.base/watchpoint-unaligned.c: New file.
	* gdb.base/watchpoint-unaligned.exp: New file.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Allocate cmd_list_element with new
@ 2018-05-04 23:18 sergiodj+buildbot
  2018-05-06 21:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-04 23:18 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e2fc72e2c594968084b936bc5dc4702a2c0694f8 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: e2fc72e2c594968084b936bc5dc4702a2c0694f8

Allocate cmd_list_element with new

This adds a constructor and destructor to cmd_list_element and changes
it to be allocated with new.  This will be useful in a subsequent
patch.

ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	* cli/cli-decode.h (cmd_list_element): New constructor.
	(~cmd_list_element): New destructor.
	(struct cmd_list_element): Add initializers.
	* cli/cli-decode.c (do_add_cmd): Use "new".
	(delete_cmd): Use "delete".


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use counted_command_line everywhere
@ 2018-05-04 23:49 sergiodj+buildbot
  2018-05-07  3:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-04 23:49 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 12973681f5d46a2407a8dc97c3352fa6c9971716 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 12973681f5d46a2407a8dc97c3352fa6c9971716

Use counted_command_line everywhere

Currently command lines are reference counted using shared_ptr only
when attached to breakpoints.  This patch changes gdb to use
shared_ptr in commands as well.  This allows for the removal of
copy_command_lines.

Note that the change to execute_user_command explicitly makes a new
reference to the command line.  This will be used in a later patch.

This simplifies struct command_line based on the observation that a
given command can have at most two child bodies: an "if" can have both
"then" and "else" parts.  Perhaps the names I've chosen for the
replacements here are not very good -- your input requested.

ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	* tracepoint.c (all_tracepoint_actions): Rename from
	all_tracepoint_actions_and_cleanup.  Change return type.
	(actions_command, encode_actions_1, encode_actions)
	(trace_dump_actions, tdump_command): Update.
	* remote.c (remote_download_command_source): Update.
	* python/python.c (gdbpy_eval_from_control_command)
	(python_command, python_interactive_command): Update.
	* mi/mi-cmd-break.c (mi_cmd_break_commands): Update.
	* guile/guile.c (guile_command)
	(gdbscm_eval_from_control_command, guile_command): Update.
	* compile/compile.c (compile_code_command)
	(compile_print_command, compile_to_object): Update.
	* cli/cli-script.h (struct command_lines_deleter): New.
	(counted_command_line): New typedef.
	(struct command_line): Add constructor, destructor.
	<body_list>: Remove.
	<body_list_0, body_list_1>: New members.
	(command_line_up): Remove typedef.
	(read_command_lines, read_command_lines_1, get_command_line):
	Update.
	(copy_command_lines): Don't declare.
	* cli/cli-script.c (build_command_line): Use "new".
	(get_command_line): Return counted_command_line.
	(print_command_lines, execute_user_command)
	(execute_control_command_1, while_command, if_command): Update.
	(realloc_body_list): Remove.
	(process_next_line, recurse_read_control_structure): Update.
	(read_command_lines, read_command_lines_1): Return counted_command_line.
	(free_command_lines): Use "delete".
	(copy_command_lines): Remove.
	(define_command, document_command, show_user_1): Update.
	* cli/cli-decode.h (struct cmd_list_element) <user_commands>: Now
	a counted_command_line.
	* breakpoint.h (counted_command_line): Remove typedef.
	(breakpoint_set_commands): Update.
	* breakpoint.c (check_no_tracepoint_commands)
	(validate_commands_for_breakpoint): Update.
	(breakpoint_set_commands): Change commands to be a
	counted_command_line.
	(commands_command_1, update_dprintf_command_list)
	(create_tracepoint_from_upload): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use function_view in cli-script.c
@ 2018-05-05  1:14 sergiodj+buildbot
  2018-05-08 14:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-05  1:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 60b3cef2e49ba72dea55181a8ad0cb8dbf3f8a5b ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 60b3cef2e49ba72dea55181a8ad0cb8dbf3f8a5b

Use function_view in cli-script.c

This changes some functions in cli-script.c to use function_view
rather than a function pointer and closure argument.  This simplifies
the code a bit and is useful in a subsequent patch.

ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	* tracepoint.c (actions_command): Update.
	* mi/mi-cmd-break.c (mi_command_line_array)
	(mi_command_line_array_cnt, mi_command_line_array_ptr)
	(mi_read_next_line): Remove.
	(mi_cmd_break_commands): Update.
	* cli/cli-script.h (read_command_lines, read_command_lines_1): Use
	function_view.
	* cli/cli-script.c (get_command_line): Update.
	(process_next_line): Use function_view.  Constify.
	(recurse_read_control_structure, read_command_lines)
	(read_command_lines_1): Change argument types to function_view.
	(do_define_command, document_command): Update.
	* breakpoint.h (check_tracepoint_command): Don't declare.
	* breakpoint.c (check_tracepoint_command): Remove.
	(commands_command_1, create_tracepoint_from_upload): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Allow breakpoint commands to be set from Python
@ 2018-05-05  1:34 sergiodj+buildbot
  2018-05-09  5:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-05  1:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a913fffbdee21fdd50e8de0596358be425775678 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: a913fffbdee21fdd50e8de0596358be425775678

Allow breakpoint commands to be set from Python

This changes the Python API so that breakpoint commands can be set by
writing to the "commands" attribute.

ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	PR python/22731:
	* NEWS: Mention that breakpoint commands are writable.
	* python/py-breakpoint.c (bppy_set_commands): New function.
	(breakpoint_object_getset) <"commands">: Use it.

doc/ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	PR python/22731:
	* python.texi (Breakpoints In Python): Mention that "commands" is
	writable.

testsuite/ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	PR python/22731:
	* gdb.python/py-breakpoint.exp: Test setting breakpoint commands.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Make print_command_trace varargs
@ 2018-05-05  1:36 sergiodj+buildbot
  2018-05-07 14:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-05  1:36 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1263a9d5f1c6198cdb4e73bafe86ca451d35684d ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 1263a9d5f1c6198cdb4e73bafe86ca451d35684d

Make print_command_trace varargs

I noticed some code in execute_control_command_1 that could be
simplified by making print_command_trace a printf-like function.  This
patch makes this change.

ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	* top.c (execute_command): Update.
	* cli/cli-script.h (print_command_lines): Now varargs.
	* cli/cli-script.c (print_command_lines): Now varargs.
	(execute_control_command_1) <case while_control, case if_control>:
	Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Let gdb.execute handle multi-line commands
@ 2018-05-05  1:57 sergiodj+buildbot
  2018-05-09 11:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-05  1:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 56bcdbea2bed27ea83bf0e4fe472ab744b4beaa1 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 56bcdbea2bed27ea83bf0e4fe472ab744b4beaa1

Let gdb.execute handle multi-line commands

This changes the Python API so that gdb.execute can now handle
multi-line commands, like "commands" or "define".

ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	PR python/22730:
	* NEWS: Mention gdb.execute change.
	* gdbcmd.h (execute_control_command): Don't declare.
	* python/python.c (execute_gdb_command): Use read_command_lines_1,
	execute_control_commands, execute_control_commands_to_string.
	* cli/cli-script.h (execute_control_commands)
	(execute_control_commands_to_string): Declare.
	(execute_control_command): Add from_tty parameter.
	* cli/cli-script.c (execute_control_commands)
	(execute_control_commands_to_string): New functions.
	(execute_user_command): Use execute_control_commands.
	(execute_control_command_1): Add "from_tty" parameter.  Update.
	(execute_control_command): Likewise.

testsuite/ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	PR python/22730:
	* gdb.python/python.exp: Test multi-line execute.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Constify prompt argument to read_command_lines
@ 2018-05-05  2:10 sergiodj+buildbot
  2018-05-07 18:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-05  2:10 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 295dc222a712b700d9afa7e2462a68b866b120e1 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 295dc222a712b700d9afa7e2462a68b866b120e1

Constify prompt argument to read_command_lines

The prompt argument to read_command_lines can be const.  This patch
makes this change, and also removes some fixed-sized buffers in favor
of using string_printf.

ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	* tracepoint.c (actions_command): Update.
	* cli/cli-script.h (read_command_lines): Update.
	* cli/cli-script.c (read_command_lines): Constify prompt_arg.
	(MAX_TMPBUF): Remove define.
	(define_command): Use string_printf.
	(document_command): Likewise.
	* breakpoint.c (commands_command_1): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Allow defining a user command inside a user command
@ 2018-05-05  4:07 sergiodj+buildbot
  2018-05-08 11:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-05  4:07 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7a2c85f25977ff9b11728ba85b1417538e22c246 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 7a2c85f25977ff9b11728ba85b1417538e22c246

Allow defining a user command inside a user command

PR gdb/11750 concerns defining a command inside a user commnad, like:

    define outer
      define inner
	echo hi\n
      end
    end

This patch adds this capability to gdb.

ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	PR gdb/11750:
	* cli/cli-script.h (enum command_control_type) <define_control>:
	New constant.
	* cli/cli-script.c (multi_line_command_p): Handle define_control.
	(build_command_line, execute_control_command_1)
	(process_next_line): Likewise.
	(do_define_command): New function, extracted from define_command.
	(define_command): Use it.

testsuite/ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	PR gdb/11750:
	* gdb.base/define.exp: Test defining a user command inside a user
	command.
	* gdb.base/commands.exp (define_if_without_arg_test): Test "define".


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix "fall through" comments
@ 2018-05-05  4:33 sergiodj+buildbot
  2018-05-10  4:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-05  4:33 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 86a73007627a3c52d1c624ed430ac0e74fb8cc3e ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 86a73007627a3c52d1c624ed430ac0e74fb8cc3e

Fix "fall through" comments

This patch updates existing "fall through" comments so that they can
be recognized by gcc's -Wimplicit-fallthrough comment-parsing
heuristic.

ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	* s390-tdep.c (s390_process_record): Fix fall-through comments.
	* xcoffread.c (scan_xcoff_symtab): Move comment later.
	* symfile.c (section_is_mapped): Fix fall-through comment.
	* stabsread.c (define_symbol, read_member_functions): Fix
	fall-through comment.
	* s390-linux-tdep.c (s390_process_record): Fix fall-through
	comment.
	* remote.c (remote_wait_as): Fix fall-through comment.
	* p-exp.y (yylex): Fix fall-through comment.
	* nat/x86-dregs.c (x86_length_and_rw_bits): Fix fall-through
	comment.
	* msp430-tdep.c (msp430_gdbarch_init): Fix fall-through comment.
	* mdebugread.c (parse_partial_symbols): Fix fall-through comment.
	* jv-exp.y (yylex): Fix fall-through comment.
	* go-exp.y (lex_one_token): Fix fall-through comment.
	* gdbtypes.c (get_discrete_bounds, rank_one_type): Fix
	fall-through comment.
	* f-exp.y (yylex): Fix fall-through comment.
	* dwarf2read.c (process_die): Fix fall-through comments.
	* dbxread.c (process_one_symbol): Fix fall-through comment.
	* d-exp.y (lex_one_token): Fix fall-through comment.
	* cp-name-parser.y (yylex): Fix fall-through comment.
	* coffread.c (coff_symtab_read): Fix fall-through comment.
	* c-exp.y (lex_one_token): Fix fall-through comment.
	* arm-tdep.c (arm_decode_miscellaneous): Fix fall-through
	comment.
	* arch/arm.c (arm_instruction_changes_pc): Fix fall-through
	comment.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add missing ATTRIBUTE_NORETURNs
@ 2018-05-05  6:03 sergiodj+buildbot
  2018-05-10  9:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-05  6:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 621846f4e258167be2147894e013c85e42de1447 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 621846f4e258167be2147894e013c85e42de1447

Add missing ATTRIBUTE_NORETURNs

This patch adds a missing ATTRIBUTE_NORETURN.  This lets
-Wimplicit-fallthrough recognize that a given case does not fall
through.

ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	* dwarf2loc.c (unimplemented): Add ATTRIBUTE_NORETURN.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add a fall-through comment to stabsread.c
@ 2018-05-05  6:43 sergiodj+buildbot
  2018-05-11  5:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-05  6:43 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0019cd49ca954c03737cef3a8ee60c233d081d35 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 0019cd49ca954c03737cef3a8ee60c233d081d35

Add a fall-through comment to stabsread.c

This adds a fall-through comment to stabsread.c.  I skimmed the stabs
manual a bit and it seems that 'p' and 'P' are similar enough that
this makes sense.  Also, stabs is mostly deprecated, and the code has
been this way for a long time, so it seemed safest to keep the status
quo.

ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	* stabsread.c (define_symbol) <case 'p'>: Add fall-through
	comment.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add fall-through comment to i386-tdep.c
@ 2018-05-05  7:03 sergiodj+buildbot
  2018-05-11 15:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-05  7:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT da0e15638de59238ad811cdc3cc1d1a7803829c7 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: da0e15638de59238ad811cdc3cc1d1a7803829c7

Add fall-through comment to i386-tdep.c

This adds a fall-through comment in i386-tdep.c.  I was not sure what
to do here, so I elected to preserve the status quo.  In review, John
Baldwin pointed out that: "I believe this is correct based on the diff
that added the special cases for xgetbv and xsetbv as previously ldgt
and lidt were treated the same".

gdb/ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	* i386-tdep.c (i386_process_record): Add fall-through comment.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix "obvious" fall-through warnings
@ 2018-05-05  7:16 sergiodj+buildbot
  2018-05-10 18:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-05  7:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 565e0edacc48c86adfb12515ed6911c08c1f64d9 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 565e0edacc48c86adfb12515ed6911c08c1f64d9

Fix "obvious" fall-through warnings

This patch fixes the subset of -Wimplicit-fallthrough warnings that I
considered obvious.  In most cases it was obvious from context that
falling through was desired; here I added the appropriate comment.  In
a couple of cases it seemed clear that a "break" was missing.

ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	* riscv-tdep.c (riscv_isa_xlen): Add fall-through comment.
	* utils.c (can_dump_core) <LIMIT_CUR>: Add fall-through comment.
	* eval.c (fetch_subexp_value) <MEMORY_ERROR>: Add fall-through
	comment.
	* d-valprint.c (d_val_print) <TYPE_CODE_STRUCT>: Add fall-through
	comment.
	* coffread.c (coff_symtab_read) <C_LABEL>: Add fall-through
	comment.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add two fall-through comments in rs6000-tdep.c
@ 2018-05-05  7:23 sergiodj+buildbot
  2018-05-12  9:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-05  7:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e3829d13f6d0615f663d2a85ef4281a4365a947c ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: e3829d13f6d0615f663d2a85ef4281a4365a947c

Add two fall-through comments in rs6000-tdep.c

This adds two fall-through comments in rs6000-tdep.c.  I looked at the
PPC instruction manual and convinced myself that this was correct.
And, this isn't a semantic change.  However, close review would still
be good.

2018-05-04  Tom Tromey  <tom@tromey.com>

	* rs6000-tdep.c (ppc_process_record_op4)
	(ppc_process_record_op63): Add fall-through comment.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add a missing break in record_linux_system_call
@ 2018-05-05  8:19 sergiodj+buildbot
  2018-05-13 22:58 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-05  8:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 449b1ac7ad5f3da9ef689c91144aa057cb253df6 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 449b1ac7ad5f3da9ef689c91144aa057cb253df6

Add a missing break in record_linux_system_call

This adds a "break" at the end of the RECORD_SYS_RECVFROM case in
record_linux_system_call.  This seemed correct to me.

2018-05-04  Tom Tromey  <tom@tromey.com>

	* linux-record.c (record_linux_system_call) <case
	RECORD_SYS_RECVFROM>: Add "break".


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add -Wimplicit-fallthrough
@ 2018-05-05  8:54 sergiodj+buildbot
  2018-05-14 11:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-05  8:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 85e26832a019ffc00dad9f1eb7e670b85c8eca7f ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 85e26832a019ffc00dad9f1eb7e670b85c8eca7f

Add -Wimplicit-fallthrough

This adds -Wimplicit-fallthrough to the set of default warnings.

2018-05-04  Tom Tromey  <tom@tromey.com>

	* configure: Rebuild.
	* warning.m4 (AM_GDB_WARNINGS): Add -Wimplicit-fallthrough.

gdbserver/ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	* configure: Rebuild.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add missing "breaks"
@ 2018-05-05 10:19 sergiodj+buildbot
  2018-05-13  8:35 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-05 10:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 15c9ffd6977a93869243dce04988cbaa8340bb00 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 15c9ffd6977a93869243dce04988cbaa8340bb00

Add missing "breaks"

This adds a "break" to a couple of spots where it was erroneously
omitted.  I think these are the two (potential) real bugs caught by
this series.

2018-05-04  Tom Tromey  <tom@tromey.com>

	* mi/mi-main.c (mi_cmd_trace_frame_collected) <REGISTERS_FORMAT>:
	Add missing "break".
	* mi/mi-cmd-stack.c (mi_cmd_stack_list_locals) <NO_FRAME_FILTERS>:
	Add missing "break".


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Replace uses of strncmp with memcmp
@ 2018-05-07  3:23 sergiodj+buildbot
  2018-05-16 12:06 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-07  3:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7bd8862c3ad0ee291d27837ae3cd30288a00b922 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 7bd8862c3ad0ee291d27837ae3cd30288a00b922

Replace uses of strncmp with memcmp

Avoids gcc pr85623 for these calls.

	* cofflink.c (_bfd_coff_link_input_bfd): Use memcmp rather than
	strncmp when checking for ".bf" special symbol.
	* prXXigen.c (_bfd_XXi_swap_scnhdr_out): Make pe_required_section_flags
	section name a char array, remove sentinal known_sections entry,
	and adjust loop over known_sections to suit.  Use memcmp rather
	than strncmp.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Cleanup ppc code dealing with opcode dumps.
@ 2018-05-07 15:05 sergiodj+buildbot
  2018-05-16 23:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-07 15:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2ceb7719f763b9e541a379d8ac7d53a72794fdd4 ***

Author: Peter Bergner <bergner@vnet.ibm.com>
Branch: master
Commit: 2ceb7719f763b9e541a379d8ac7d53a72794fdd4

Cleanup ppc code dealing with opcode dumps.

include/
	* opcode/ppc.h (powerpc_num_opcodes): Change type to unsigned.
	(vle_num_opcodes): Likewise.
	(spe2_num_opcodes): Likewise.

opcodes/
	* ppc-opc.c (powerpc_num_opcodes): Likewise.
	(vle_num_opcodes): Likewise.
	(spe2_num_opcodes): Likewise.
	* ppc-dis.c (disassemble_init_powerpc) <powerpc_opcd_indices>: Rewrite
	initialization loop.
	(disassemble_init_powerpc) <vle_opcd_indices>: Likewise.
	(disassemble_init_powerpc) <spe2_opcd_indices>: Likewise.  Initialize
	only once.

gas/
	* config/tc-ppc.c (ppc_setup_opcodes) <powerpc_opcodes>: Rewrite code
	to dump the entire opcode table.
	(ppc_setup_opcodes) <spe2_opcodes>: Likewise.
	(ppc_setup_opcodes) <vle_opcodes>: Likewise.  Fix calculation of
	opcode index.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix decoding of ARM VFP instructions
@ 2018-05-07 15:27 sergiodj+buildbot
  2018-05-18 13:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-07 15:27 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ce887586b48acd02080c36d5495891116f886e8e ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: ce887586b48acd02080c36d5495891116f886e8e

Fix decoding of ARM VFP instructions

-Wduplicated-cond pointed out that arm_record_vfp_data_proc_insn
checks "opc1 == 0x0b" twice.  I filed this a while ago as
PR tdep/20362.

Based on the ARM instruction manual at
https://www.scss.tcd.ie/~waldroj/3d1/arm_arm.pdf, I think the
instruction decoding in this function has two bugs.

First, opc1 is computed as:

  opc1 = bits (arm_insn_r->arm_insn, 20, 23);
[...]
  opc1 = opc1 & 0x04;

This means that tests like:

  else if (opc1 == 0x01)

can never be true.

In the ARM manual, "opc1" corresponds to these bits:

    name   bit
    r      20
    q      21
    D      22
    p      23

... where the D bit is not used for VFP instruction decoding.

So, I believe this code should use ~0x04 instead.

Second, VDIV is recognized by the bits "pqrs" being equal to "1000".
This tranlates to opc1 == 0x08 -- not 0x0b.  Note that pqrs==1001 is
an undefined encoding, which is probably why opc2 is not checked here;
this code doesn't seem to really deal with undefined encodings in
general, so I've left that as is.

I don't have an ARM machine or any reasonable way to test this.

ChangeLog
2018-05-07  Tom Tromey  <tom@tromey.com>

	PR tdep/20362:
	* arm-tdep.c (arm_record_vfp_data_proc_insn): Properly mask off D
	bit.  Use correct value for VDIV.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add -Wduplicated-cond
@ 2018-05-07 16:17 sergiodj+buildbot
  2018-05-24  1:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-07 16:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT aff689d36d66dd45a59008f3778d3d22e3cfcb9b ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: aff689d36d66dd45a59008f3778d3d22e3cfcb9b

Add -Wduplicated-cond

This adds -Wduplicated-cond to warnings.m4.  This caught one bug.

I tried adding -Wduplicated-branches as well, but it results in some
spurious failures from code like this in cgen.h:

    #define CGEN_ATTR_TYPE(n) \
    struct { unsigned int bool_; \
	     CGEN_ATTR_VALUE_TYPE nonbool[(n) ? (n) : 1]; }

This will trigger a warning if passed n==1, which seems like a
perfectly valid thing to do; and there were other issues like this as
well.

ChangeLog
2018-05-07  Tom Tromey  <tom@tromey.com>

	* configure: Rebuild.
	* warning.m4 (AM_GDB_WARNINGS): Add -Wduplicated-cond.

gdbserver/ChangeLog
2018-05-07  Tom Tromey  <tom@tromey.com>

	* configure: Rebuild.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: Replace AddrPrefixOp0 with AddrPrefixOpReg
@ 2018-05-07 17:23 sergiodj+buildbot
  2018-05-29  3:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-07 17:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 75c0a438994f00240ecd1baca3e3c11cc3b219e5 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 75c0a438994f00240ecd1baca3e3c11cc3b219e5

x86: Replace AddrPrefixOp0 with AddrPrefixOpReg

This patch replaces AddrPrefixOp0 with AddrPrefixOpReg to indicate that
the size of register operand is controlled by the address size prefix.
This will be used by Intel MOVDIRI and MOVDIR64B instructions later.

gas/

	* config/tc-i386.c (process_suffix): Check addrprefixopreg
	instead of addrprefixop0.

opcodes/

	* i386-gen.c (opcode_modifiers): Replace AddrPrefixOp0 with
	AddrPrefixOpReg.
	* i386-opc.h (AddrPrefixOp0): Renamed to ...
	(AddrPrefixOpReg): This.
	(i386_opcode_modifier): Rename addrprefixop0 to addrprefixopreg.
	* i386-opc.tbl: Replace AddrPrefixOp0 with AddrPrefixOpReg.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Enable Intel MOVDIRI, MOVDIR64B instructions
@ 2018-05-08  0:29 sergiodj+buildbot
  2018-06-02 15:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-08  0:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c0a30a9f0ab48fd7cb0fed0cd6710fe478650a7f ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: c0a30a9f0ab48fd7cb0fed0cd6710fe478650a7f

Enable Intel MOVDIRI, MOVDIR64B instructions

gas/

	* config/tc-i386.c (cpu_arch): Add .movdir, .movdir64b.
	(cpu_noarch): Likewise.
	(process_suffix): Add check for register size.
	* doc/c-i386.texi: Document movdiri, movdir64b.
	* testsuite/gas/i386/i386.exp: Run MOVDIR{I,64B} tests.
	* testsuite/gas/i386/movdir-intel.d: New file.
	* testsuite/gas/i386/movdir.d: Likewise.
	* testsuite/gas/i386/movdir.s: Likewise.
	* testsuite/gas/i386/movdir64b-reg.s: Likewise.
	* testsuite/gas/i386/movdir64b-reg.l: Likewise.
	* testsuite/gas/i386/x86-64-movdir-intel.d: Likewise.
	* testsuite/gas/i386/x86-64-movdir.d: Likewise.
	* testsuite/gas/i386/x86-64-movdir.s: Likewise.
	* testsuite/gas/i386/x86-64-movdir64b-reg.s: Likewise.
	* testsuite/gas/i386/x86-64-movdir64b-reg.l: Likewise.

opcodes/

	* i386-dis.c (Gva): New.
	(enum): Add PREFIX_0F38F8, PREFIX_0F38F9,
	MOD_0F38F8_PREFIX_2, MOD_0F38F9_PREFIX_0.
	(prefix_table): New instructions (see prefix above).
	(mod_table): New instructions (see prefix above).
	(OP_G): Handle va_mode.
	* i386-gen.c (cpu_flag_init): Add CPU_MOVDIRI_FLAGS,
	CPU_MOVDIR64B_FLAGS.
	(cpu_flags): Add CpuMOVDIRI and CpuMOVDIR64B.
	* i386-opc.h (enum): Add CpuMOVDIRI, CpuMOVDIR64B.
	(i386_cpu_flags): Add cpumovdiri and cpumovdir64b.
	* i386-opc.tbl: Add movidir{i,64b}.
	* i386-init.h: Regenerated.
	* i386-tbl.h: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Simplify VLE handling in print_insn_powerpc().
@ 2018-05-08  2:10 sergiodj+buildbot
  2018-06-03  6:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-08  2:10 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a87a64780fde9dc8d1c3af8eda93fc1b878cd3cf ***

Author: Peter Bergner <bergner@vnet.ibm.com>
Branch: master
Commit: a87a64780fde9dc8d1c3af8eda93fc1b878cd3cf

Simplify VLE handling in print_insn_powerpc().

opcodes/
	* ppc-dis.c (print_insn_powerpc) <insn_is_short>: Replace this...
	<insn_length>: ...with this.  Update usage.
	Remove duplicate call to *info->memory_error_func.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Prevent a memory exhaustion failure when running objdump on a fuzzed input file with corrupt string and attribute sections.
@ 2018-05-08 12:20 sergiodj+buildbot
  2018-06-03 16:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-08 12:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 95a6d23566165208853a68d9cd3c6eedca840ec6 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 95a6d23566165208853a68d9cd3c6eedca840ec6

Prevent a memory exhaustion failure when running objdump on a fuzzed input file with corrupt string and attribute sections.

	PR 22809
	* elf.c (bfd_elf_get_str_section): Check for an excessively large
	string section.
	* elf-attrs.c (_bfd_elf_parse_attributes): Issue an error if the
	attribute section is larger than the size of the file.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [spu] Fix "info spu event" output formatting
@ 2018-05-08 12:43 sergiodj+buildbot
  2018-06-04  9:38 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-08 12:43 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 968ae51bac6201d2c63e0c2b4405832dca0795f0 ***

Author: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Branch: master
Commit: 968ae51bac6201d2c63e0c2b4405832dca0795f0

[spu] Fix "info spu event" output formatting

The formatting of the output of the "info spu event" command changed, causing
spurious test suite failures.  Use phex instead of phex_nz to get back the
expected format, and fix emission of new line characters.

gdb/ChangeLog:
2018-05-08  Ulrich Weigand  <uweigand@de.ibm.com>

	* spu-tdep.c (info_spu_event_command): Fix output formatting.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] watchpoint-unaligned.exp: Use skip_hw_watchpoint_tests
@ 2018-05-08 13:27 sergiodj+buildbot
  2018-06-05 18:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-08 13:27 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7785df4880f3828db8cf1715038127e6b858a670 ***

Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Branch: master
Commit: 7785df4880f3828db8cf1715038127e6b858a670

watchpoint-unaligned.exp: Use skip_hw_watchpoint_tests

gdb/testsuite/ChangeLog
2018-05-08  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* gdb.base/watchpoint-unaligned.exp: Use skip_hw_watchpoint_tests.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Correct powerpc spe opcode lookup
@ 2018-05-08 14:08 sergiodj+buildbot
  2018-06-08 14:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-08 14:08 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f413a91378902aadbe4e338a6dc8f33f5f7148a0 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: f413a91378902aadbe4e338a6dc8f33f5f7148a0

Correct powerpc spe opcode lookup

Defining SPE2_OPCD_SEGS as 13 discounts the possibility that we'd
ever look up spe2_opcd_indices[14..16], which I think is possible.
Extend that array to size 16+1, using the macros we use to index the
array.  Similarly use the index macros for PPC_OPCD_SEGS and
VLE_OPCD_SEGS.

	* ppc-dis.c (PPC_OPCD_SEGS): Define using PPC_OP.
	(VLE_OPCD_SEGS, SPE2_OPCD_SEGS): Similarly, using macros used to
	partition opcode space for index lookup.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb/x86: Handle kernels using compact xsave format
@ 2018-05-08 17:40 sergiodj+buildbot
  2018-06-09 19:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-08 17:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8ee22052f690c007556b97eed59f49350ece5ca9 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 8ee22052f690c007556b97eed59f49350ece5ca9

gdb/x86: Handle kernels using compact xsave format

For GNU/Linux on x86-64, if the target is using the xsave format for
passing the floating-point information from the inferior then there
currently exists a bug relating to the x87 control registers, and the
mxcsr register.

The xsave format allows different floating-point features to be lazily
enabled, a bit in the xsave format tells GDB which floating-point
features have been enabled, and which have not.

Currently in GDB, when reading the floating point state, we check the
xsave bit flags, if the feature is enabled then we read the feature
from the xsave buffer, and if the feature is not enabled, then we
supply the default value from within GDB.

Within GDB, when writing the floating point state, we first fetch the
xsave state from the target and then, for any feature that is not yet
enabled, we write the default values into the xsave buffer.  Next we
compare the regcache value with the value in the xsave buffer, and, if
the value has changed we update the value in the xsave buffer, and
mark the feature enabled in the xsave bit flags.

The problem then, is that the x87 control registers were not following
this pattern.  We assumed that these registers were always written out
by the kernel, and we always wrote them out to the xsave buffer (but
didn't enabled the feature).  The result of this is that if the kernel
had not yet enabled the x87 feature then within GDB we would see
random values for the x87 floating point control registers, and if the
user tried to modify one of these register, that modification would be
lost.

Finally, the mxcsr register was also broken in the same way as the x87
control registers.  The added complexity with this case is that the
mxcsr register is part of both the avx and sse floating point feature
set.  When reading or writing this register we need to check that at
least one of these features is enabled.

This bug was present in native GDB, and within gdbserver.  Both are
fixed with this commit.

gdb/ChangeLog:

	* common/x86-xstate.h (I387_FCTRL_INIT_VAL): New constant.
	(I387_MXCSR_INIT_VAL): New constant.
	* amd64-tdep.c (amd64_supply_xsave): Only read state from xsave
	buffer if it was supplied by the inferior.
	* i387-tdep.c (i387_supply_fsave): Use I387_MXCSR_INIT_VAL.
	(i387_xsave_get_clear_bv): New function.
	(i387_supply_xsave): Only read x87 control registers from the
	xsave buffer if the feature is enabled, and the state will have
	been written, otherwise, provide a suitable default.
	(i387_collect_xsave): Pre-clear all registers in xsave buffer,
	including x87 control registers.  Update control registers if they
	have changed from the default value, and mark features as enabled
	as required.
	* i387-tdep.h (i387_xsave_get_clear_bv): Declare.

gdb/gdbserver/ChangeLog:

	* i387-fp.c (i387_cache_to_xsave): Only write x87 control
	registers to the cache if their values have changed.
	(i387_xsave_to_cache): Provide default values for x87 control
	registers when these features are available, but disabled.
	* regcache.c (supply_register_by_name_zeroed): New function.
	* regcache.h (supply_register_by_name_zeroed): Declare new
	function.

gdb/testsuite/ChangeLog:

	* gdb.arch/amd64-init-x87-values.S: New file.
	* gdb.arch/amd64-init-x87-values.exp: New file.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Define GNULIB_NAMESPACE in unittests/string_view-selftests.c
@ 2018-05-08 21:06 sergiodj+buildbot
  2018-06-10  7:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-08 21:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7402fbcae1c282e27aafd5c5c90aca7eabbdf45c ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 7402fbcae1c282e27aafd5c5c90aca7eabbdf45c

Define GNULIB_NAMESPACE in unittests/string_view-selftests.c

When building with x86_64-w64-mingw32-g++ (to test cross-compiling for
Windows), I get this error:

unittests/string_view-selftests.o: In function `selftests::string_view::inserters_2::test05(unsigned long long)':
/home/emaisin/src/binutils-gdb/gdb/unittests/basic_string_view/inserters/char/2.cc:60: undefined reference to `std::basic_ofstream<char, std::char_traits<char> >::rpl_close()'

This is caused by gnulib redefining "close" as "rpl_close", and
therefore messing up the declaration of basic_ofstream in the libstdc++
header.  The solution would be to use gnulib namespaces [1].  Until we
use them across GDB, we can use them locally in files that are
problematic, like this one.

gdb/ChangeLog:

	* unittests/string_view-selftests.c: Define GNULIB_NAMESPACE.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] RISC-V: Add missing hint instructions from RV128I.
@ 2018-05-08 23:14 sergiodj+buildbot
  2018-06-10 17:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-08 23:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e6f372ba661bb0d8eec1e22a6dc1ad9937336e4d ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: e6f372ba661bb0d8eec1e22a6dc1ad9937336e4d

RISC-V: Add missing hint instructions from RV128I.

	gas/
	* testsuite/gas/riscv/c-zero-imm.d: Add more tests.
	* testsuite/gas/riscv/c-zero-imm.s: Likewise.
	* testsuite/gas/riscv/c-zero-reg.d: Fix typo in test.  Add disabled
	future test for RV128 support.
	* testsuite/gas/riscv/c-zero-reg.s: Likewise.

	include/
	* opcode/riscv-opc.h (MATCH_C_SRLI64, MASK_C_SRLI64): New.
	(MATCH_C_SRAI64, MASK_C_SRAI64): New.
	(MATCH_C_SLLI64, MASK_C_SLLI64): New.

	opcodes/
	* riscv-opc.c (match_c_slli, match_slli_as_c_slli): New.
	(match_c_slli64, match_srxi_as_c_srxi): New.
	(riscv_opcodes) <slli, sll>: Use match_slli_as_c_slli.
	<srli, srl, srai, sra>: Use match_srxi_as_c_srxi.
	<c.slli, c.srli, c.srai>: Use match_s_slli.
	<c.slli64, c.srli64, c.srai64>: New.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PR23147, Heap buffer overflow in pe_print_idata
@ 2018-05-09  5:28 sergiodj+buildbot
  2018-06-12 10:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-09  5:28 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 53db9cf9fc363fd8ab3a9d97cdcb2ea1f639a243 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 53db9cf9fc363fd8ab3a9d97cdcb2ea1f639a243

PR23147, Heap buffer overflow in pe_print_idata

	PR 23147
	* peXXigen.c (pe_print_idata): Bound check hint_addr.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PR23148, Heap buffer overflow in pe_print_edata
@ 2018-05-09  5:52 sergiodj+buildbot
  2018-06-12 20:37 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-09  5:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b4560c7d159f598c82a64b214e30fd00d88aa1fb ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: b4560c7d159f598c82a64b214e30fd00d88aa1fb

PR23148, Heap buffer overflow in pe_print_edata

	PR 23148
	* peXXigen.c (pe_print_edata): Correct minimum size.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PR22069, Several instances of register accidentally spelled as regsiter
@ 2018-05-09  7:01 sergiodj+buildbot
  2018-06-13  7:18 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-09  7:01 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 84f9f8c33021593afd79fc89cc419db44f7bc112 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 84f9f8c33021593afd79fc89cc419db44f7bc112

PR22069, Several instances of register accidentally spelled as regsiter

	PR 22069
binutils/
	* od-macho.c (dump_unwind_encoding_x86): Adjust for macro renaming.
cpu/ChangeLog
	* or1kcommon.cpu (spr-reg-info): Typo fix.
include/ChangeLog
	* mach-o/unwind.h (MACH_O_UNWIND_X86_64_RBP_FRAME_REGISTERS):
	Rename from MACH_O_UNWIND_X86_64_RBP_FRAME_REGSITERS.
	(MACH_O_UNWIND_X86_EBP_FRAME_REGISTERS): Rename from
	MACH_O_UNWIND_X86_EBP_FRAME_REGSITERS.
opcodes/ChangeLog
	* cr16-opc.c (cr16_instruction): Comment typo fix.
	* hppa-dis.c (print_insn_hppa): Likewise.
sim/ppc/ChangeLog
	* e500_registers.h: Comment typo fix.
	* ppc-instructions (ppc_insn_mfcr): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix binary compatibility between GCC and the TI compiler for the PRU target.
@ 2018-05-09 11:03 sergiodj+buildbot
  2018-06-13 17:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-09 11:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 493ffac5aad8c39215702435c2506fd4d3077191 ***

Author: Dimitar Dimitrov <dimitar@dinux.eu>
Branch: master
Commit: 493ffac5aad8c39215702435c2506fd4d3077191

Fix binary compatibility between GCC and the TI compiler for the PRU target.

My original implementation for LDI32 pseudo does not conform to
the TI ABI.  I wrongly documented my TI PRU ELF object files inspection,
which got propagated into my binutils implementation.

Issue was exposed when running the GCC ABI testsuite against TI toolchain.
According to TI ABI, LDI32 must use first LDI instruction to load
the MSB 16bits, and second LDI instruction for the LSB 16bits.

This patch will break binary compatibility with previously released
binutils versions for PRU. Still, I think it is better to fix
binutils to conform to the chip vendor ABI.

bfd	* elf32-pru.c (pru_elf32_do_ldi32_relocate): Make LDI32 relocation
	conformant to TI ABI.
	(pru_elf32_relax_section): Likewise.
	(pru_elf_relax_delete_bytes): Fix offsets for new LDI32 code.
	* elf32-pru.c (pru_elf32_do_ldi32_relocate): Ignore addend.
	(pru_elf32_pmem_relocate): Trap - should not get here.
	(pru_elf32_relocate_section): Add support for REL relocations.
	(elf_info_to_howto_rel): Enable REL.
	(elf_backend_may_use_rel_p): Likewise.
	(elf_backend_may_use_rela_p): Likewise.
	(elf_backend_default_use_rela_p): Likewise.

gas	* config/tc-pru.c (md_apply_fix): Make LDI32 relocation conformant
	to TI ABI.
	(pru_assemble_arg_i): Likewise.
	(output_insn_ldi32): Likewise.
	* testsuite/gas/pru/ldi.d: Update test for the now fixed LDI32.
	* gas/config/tc-pru.c (pru_assemble_arg_b): Check imm8 operand range.
	* gas/testsuite/gas/pru/illegal2.l: New test.
	* gas/testsuite/gas/pru/illegal2.s: New test.
	* gas/testsuite/gas/pru/pru.exp: Register new illegal2 test.

ld	* scripttempl/pru.sc: Add LD sections to allow linking TI
	toolchain object files.
	* scripttempl/pru.sc: Switch to init_array.
	* testsuite/ld-pru/ldi32.d: Update LDI32 test to conform to TI ABI.
	* testsuite/ld-pru/norelax_ldi32-data.d: Likewise.
	* testsuite/ld-pru/norelax_ldi32-dis.d: Likewise.
	* testsuite/ld-pru/relax_ldi32-data.d: Likewise.
	* testsuite/ld-pru/relax_ldi32-dis.d: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb: xtensa: handle privileged registers
@ 2018-05-09 16:53 sergiodj+buildbot
  2018-06-14 10:27 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-09 16:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 37d9e0623102352e0ae27c311760a9e6569ae5e0 ***

Author: Max Filippov <jcmvbkbc@gmail.com>
Branch: master
Commit: 37d9e0623102352e0ae27c311760a9e6569ae5e0

gdb: xtensa: handle privileged registers

xtensa GDB may be used with both bare-metal and linux-based
applications. In case of bare-metal application gdbserver is able to
provide information about all CPU registers: both unprivileged and
privileged. In case of linux-based application only a small subset of
privileged state is available. Currently xtensa GDB only expects
unprivileged registers in 'g' packets and it fails to communicate with
server that sends both privileged and unprivileged registers.

Allow bare-metal xtensa GDB to deal with both privileged and
unprivileged registers by initializing tdep->num_regs with the total
number of target CPU registers. Keep linux-based xtensa GDB
functionality as is by copying tdep->num_nopriv_regs to tdep->num_regs.

gdb/
2018-05-09  Max Filippov  <jcmvbkbc@gmail.com>

	* xtensa-linux-tdep.c (xtensa-tdep.h): New include.
	(xtensa_linux_init_abi): Limit tdep->num_regs by
	tdep->num_nopriv_regs.
	* xtensa-tdep.c (xtensa_derive_tdep): Calculate
	tdep->num_nopriv_regs and only copy it to tdep->num_regs if it's
	not initialized.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: Remove Disp<N> from movidir{i,64b}
@ 2018-05-09 18:41 sergiodj+buildbot
  2018-06-15 14:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-09 18:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 06cfb1c89510d08217da8b3ccea05ecd4cdb5bc6 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 06cfb1c89510d08217da8b3ccea05ecd4cdb5bc6

x86: Remove Disp<N> from movidir{i,64b}

	* i386-opc.tbl: Remove Disp<N> from movidir{i,64b}.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix tagged pointer support
@ 2018-05-10 10:11 sergiodj+buildbot
  2018-06-16 11:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-10 10:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8727de56b0dbe25b7b4a3bd04f72ac41992463ed ***

Author: Omair Javaid <omair.javaid@linaro.org>
Branch: master
Commit: 8727de56b0dbe25b7b4a3bd04f72ac41992463ed

Fix tagged pointer support

This patch fixes tagged pointer support for AArch64 GDB. Linux kernel
debugging failure was reported after tagged pointer support was committed.

After a discussion around best path forward to manage tagged pointers
on GDB side we are going to disable tagged pointers support for
aarch64-none-elf-gdb because for non-linux applications we cant be
sure if tagged pointers will be used by MMU or not.

Also for aarch64-linux-gdb we are going to sign extend user-space
address after clearing tag bits. This will help debug both kernel
and user-space addresses based on information from linux kernel
documentation given below:

According to AArch64 memory map:
https://www.kernel.org/doc/Documentation/arm64/memory.txt

"User addresses have bits 63:48 set to 0 while the kernel addresses have
the same bits set to 1."

According to AArch64 tagged pointers document:
https://www.kernel.org/doc/Documentation/arm64/tagged-pointers.txt

The kernel configures the translation tables so that translations made
via TTBR0 (i.e. userspace mappings) have the top byte (bits 63:56) of
the virtual address ignored by the translation hardware. This frees up
this byte for application use.

Running gdb testsuite after applying this patch introduces no regressions
and tagged pointer test cases still pass.

gdb/ChangeLog:
2018-05-10  Omair Javaid  <omair.javaid@linaro.org>

	PR gdb/23127
	* aarch64-linux-tdep.c (aarch64_linux_init_abi): Add call to
	set_gdbarch_significant_addr_bit.
	* aarch64-tdep.c (aarch64_gdbarch_init): Remove call to
	set_gdbarch_significant_addr_bit.
	* utils.c (address_significant): Update to sign extend addr.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add support for detecting Freescale S12Z binaries in readelf.
@ 2018-05-10 12:28 sergiodj+buildbot
  2018-06-16 22:13 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-10 12:28 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 637b19704cf8325875de8df4f8b000197d261e3b ***

Author: John Darrington <john@darrington.wattle.id.au>
Branch: master
Commit: 637b19704cf8325875de8df4f8b000197d261e3b

Add support for detecting Freescale S12Z binaries in readelf.

* include/elf/common.h (EM_S12Z): New macro
* binutils/readelf.c (get_machine_name): EM_S12Z - handle new case.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [gdbserver/win32] fatal "glob could not process pattern '(null)'" error
@ 2018-05-10 17:03 sergiodj+buildbot
  2018-06-18  1:05 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-10 17:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 906994d9d50eb40dc89a5bf0830e15ed10938641 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 906994d9d50eb40dc89a5bf0830e15ed10938641

[gdbserver/win32] fatal "glob could not process pattern '(null)'" error

Trying to start GDBserver on Windows currently yields the following
error...

    $ gdbserver.exe --once :4444 simple_main.exe
    glob could not process pattern '(null)'.
    Exiting

... after which GDB terminates with a nonzero status.

This is because create_process in win32-low.c calls gdb_tilde_expand
with the result of a call to get_inferior_cwd without verifying that
the returned directory is not NULL:

    | static BOOL
    | create_process (const char *program, char *args,
    |                 DWORD flags, PROCESS_INFORMATION *pi)
    | {
    |   const char *inferior_cwd = get_inferior_cwd ();
    |   std::string expanded_infcwd = gdb_tilde_expand (inferior_cwd);

This patch avoids this by only calling gdb_tilde_expand when
INFERIOR_CWD is not NULL, which is similar to what is done on
GNU/Linux for instance.

gdb/gdbserver/ChangeLog:

        PR server/23158:
        * win32-low.c (create_process): Only call gdb_tilde_expand if
        inferior_cwd is not NULL.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdbserver/Windows: Fix "no program to debug" error
@ 2018-05-10 17:18 sergiodj+buildbot
  2018-06-18  7:18 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-10 17:18 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7dbac825b09f0847e608b50c80db816ef20d9315 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 7dbac825b09f0847e608b50c80db816ef20d9315

gdbserver/Windows: Fix "no program to debug" error

Trying to start a program with GDBserver on Windows yields
the following error:

    $ gdbserver.exe --once :4444 simple_main.exe
    Killing process(es): 5008
    No program to debug
    Exiting

The error itself comes from the following code shortly after
create_inferior gets called (in server.c::main):

    /* Wait till we are at first instruction in program.  */
    create_inferior (program_path.get (), program_args);
    [...]

    if (last_status.kind == TARGET_WAITKIND_EXITED
        || last_status.kind == TARGET_WAITKIND_SIGNALLED)
      was_running = 0;
    else
      was_running = 1;

    if (!was_running && !multi_mode)
      error ("No program to debug");

What happens is that the "last_status" global starts initialized
as zeroes, which means last_status.kind == TARGET_WAITKIND_EXITED,
and we expect create_inferior to be waiting for the inferior to
start until reaching the SIGTRAP, and to set the "last_status"
global to match that last event we received.

I suspect this is an unintended side-effect of the following change...

    commit 2090129c36c7e582943b7d300968d19b46160d84
    Date:   Thu Dec 22 21:11:11 2016 -0500
    Subject: Share fork_inferior et al with gdbserver

... which removes some code in server.c that was responsible for
starting the inferior in a functin that was named start_inferior,
and looked like this:

   signal_pid = create_inferior (new_argv[0], &new_argv[0]);
   [...]
   /* Wait till we are at 1st instruction in program, return new pid
      (assuming success).  */
   last_ptid = mywait (pid_to_ptid (signal_pid), &last_status, 0, 0);

The code has been transitioned to using fork_inferior, but sadly,
only for the targets that support it. On Windows, the calls to wait
setting "last_status" simply disappeared.

This patch adds it back in the Windows-specific implementation of
create_inferior.

gdb/gdbserver/ChangeLog:

        PR server/23158:
        * win32-low.c (win32_create_inferior): Add call to my_wait
        setting last_status global.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdbserver/Windows: crash during connection establishment phase
@ 2018-05-10 17:39 sergiodj+buildbot
  2018-06-18 20:42 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-10 17:39 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 190852c8ac75cb62a737c58edfadfb0e1fcef78a ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 190852c8ac75cb62a737c58edfadfb0e1fcef78a

gdbserver/Windows: crash during connection establishment phase

On Windows, starting a new process with GDBserver seems to work,
in the sense that the program does get started, and GDBserver
confirms that it is listening for GDB to connect. However, as soon as
GDB establishes the connection with GDBserver, and starts discussing
with it, GDBserver crashes, with a SEGV.

This SEGV occurs in remote-utils.c::prepare_resume_reply...

  | regp = current_target_desc ()->expedite_regs;
  | [...]
  | while (*regp)

... because, in our case, REGP is NULL.

This patches fixes the issues by adding a parameter to init_target_desc,
in order to make sure that we always provide the list of registers when
we initialize a target description.

gdb/ChangeLog:

        PR server/23158:
        * regformats/regdat.sh: Adjust script, following the addition
        of the new expedite_regs parameter to init_target_desc.

gdb/gdbserver/ChangeLog:

        PR server/23158:
        * tdesc.h (init_target_desc) <expedite_regs>: New parameter.
        * tdesc.c (init_target_desc) <expedite_regs>: New parameter.
        Use it to set the expedite_regs field in the given tdesc.
        * x86-tdesc.h: New file.
        * linux-aarch64-tdesc.c (aarch64_linux_read_description):
        Adjust following the addition of the new expedite_regs parameter
        to init_target_desc.
        * linux-tic6x-low.c (tic6x_read_description): Likewise.
        * linux-x86-tdesc.c: #include "x86-tdesc.h".
        (i386_linux_read_description, amd64_linux_read_description):
        Adjust following the addition of the new expedite_regs parameter
        to init_target_desc.
        * lynx-i386-low.c: #include "x86-tdesc.h".
        (lynx_i386_arch_setup): Adjust following the addition of the new
        expedite_regs parameter to init_target_desc.
        * nto-x86-low.c: #include "x86-tdesc.h".
        (nto_x86_arch_setup): Adjust following the addition of the new
        expedite_regs parameter to init_target_desc.
        * win32-i386-low.c: #include "x86-tdesc.h".
        (i386_arch_setup): Adjust following the addition of the new
        expedite_regs parameter to init_target_desc.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86 LynxOS-178: Adjust floating-point context structure
@ 2018-05-10 20:09 sergiodj+buildbot
  2018-06-20 14:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-10 20:09 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 55271bf969c2c09b98aecd97b36170fbf76c3fc4 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 55271bf969c2c09b98aecd97b36170fbf76c3fc4

x86 LynxOS-178: Adjust floating-point context structure

The floating point context structure on x86 LynxOS-178 is not
the same as on LynxOS 5.x. As a consequence, trying to print
the return value of a function returning a float, for instance,
yields incorrect results.

This patch fixes the issue by providing an updated definition
for LynxOS-178 (the reason why we cannot access the actual definition
provided by the system still remains true).

gdb/gdbserver/ChangeLog:

        * lynx-i386-low.c (LYNXOS_178): New macro.
        [LYNXOS_178] (usr_fcontext_t): Provide a definition that matches
        the layout on LynxOS-178.
        (lynx_i386_fill_fpregset, lynx_i386_store_fpregset): Do not
        handle floating point registers that are not supported by
        LynxOS-178.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix the clang build
@ 2018-05-10 20:54 sergiodj+buildbot
  2018-06-19 16:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-10 20:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1a34f210bb9389e58d93caf4384800934fc7113a ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 1a34f210bb9389e58d93caf4384800934fc7113a

Fix the clang build

Simon pointed out that gdb would not build with clang, due to the
addition of -Wimplicit-fallthrough.  This patch fixes the problem by
using -Wimplicit-fallthrough=3 -- this does not work with clang,
bypassing the issue.

Tested by rebuilding with both gcc and clang; and also by verifying
that -Wimplicit-fallthrough=3 is used in the gcc build.

I will file a follow-up bug to convert the fall-through comments to a
form that can be used by both clang and gcc.

gdb/ChangeLog
2018-05-10  Tom Tromey  <tom@tromey.com>

	* configure: Rebuild.
	* warning.m4 (AM_GDB_WARNINGS): Use -Wimplicit-fallthrough=3.

gdb/gdbserver/ChangeLog
2018-05-10  Tom Tromey  <tom@tromey.com>

	* configure: Rebuild.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove cleanups from mdebugread.c
@ 2018-05-11 17:54 sergiodj+buildbot
  2018-06-21  3:28 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-11 17:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 633cf2548bcd3dafe297e21a1dd3574240280d48 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 633cf2548bcd3dafe297e21a1dd3574240280d48

Remove cleanups from mdebugread.c

This removes the remaining cleanups from mdebugread.c, replacing them
with gdb::def_vector.

Tested by the buildbot, though I doubt this exercises mdebugread.

gdb/ChangeLog
2018-05-11  Tom Tromey  <tom@tromey.com>

	* mdebugread.c (parse_partial_symbols, psymtab_to_symtab_1): Use
	gdb::def_vector.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Move core_bfd to program space
@ 2018-05-11 20:37 sergiodj+buildbot
  2018-06-21  9:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-11 20:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e540a5a22319f2ab5661db882639839d1d867542 ***

Author: Tom Tromey <tromey@redhat.com>
Branch: master
Commit: e540a5a22319f2ab5661db882639839d1d867542

Move core_bfd to program space

This moves the core_bfd global to be a field of the program space.  It
then replaces core_bfd with a macro to avoid a massive patch -- the
same approach taken for various other program space fields.

This is a basic transformation for multi-target work.

2018-05-11  Tom Tromey  <tromey@redhat.com>
	    Pedro Alves  <tromey@redhat.com>

	* corefile.c (core_bfd): Remove.
	* gdbcore.h (core_bfd): Now a macro.
	* progspace.h (struct program_space) <cbfd>: New field.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Eliminate the 'the_core_target' global
@ 2018-05-11 21:20 sergiodj+buildbot
  2018-06-21 19:36 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-11 21:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 451953fa440aa0ade02b652159155fae689483a3 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 451953fa440aa0ade02b652159155fae689483a3

Eliminate the 'the_core_target' global

(previously called 'core_target', but since renamed because
'core_target' is the name of the target_ops class now.)

This eliminates the "the_core_target" global, as preparation for being
able to have more than one core loaded.  When we get there, we will
instantiate one core_target object per core instead.

Essentially, this replaces the reference to the_core_target in
core_file_command by a reference to core_bfd, which is per
program_space.

Currently, core_file_command calls 'the_core_target->detach()' even if
the core target is not open and pushed on the target stack.  If it is
indeed not open, then the practical effect is that
core_target::detach() prints "No core file now.".  That is preserved
by printing that directly from within core_file_command if not
debugging a core.

gdb/ChangeLog:
2018-05-11  Pedro Alves  <palves@redhat.com>

	* corefile.c (core_file_command): Move to corelow.c.
	* corelow.c (the_core_target): Delete.
	(core_file_command): Moved from corefile.c.  Check exec_bfd
	instead of the_core_target.  Use target_detach instead of calling
	into the_core_target directly.
	(maybe_say_no_core_file_now): New.
	(core_target::detach): Use it.
	(_initialize_corelow): Remove references to the_core_target.
	* gdbcore.h (the_core_target): Delete.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Heap-allocate core_target instances
@ 2018-05-11 21:45 sergiodj+buildbot
  2018-06-22 11:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-11 21:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1524450719d3867e10fc6a8dbc051b8dc7924898 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 1524450719d3867e10fc6a8dbc051b8dc7924898

Heap-allocate core_target instances

This gets rid of the core_ops global, and replaces it with
heap-allocated core_target instances.  In practice, there will only be
one such instance, though that will change further ahead as more
pieces of multi-target support are merged.

Notice that this replaces one heap-allocated object for another, the
number of allocations is the same.  Specifically, currently we
heap-allocate the 'core_data' object, which holds the core's section
table.  With this patch, that object is made a field of the
core_target class, and no longer allocated separately.

Note that this bit:

  -  /* Looks semi-reasonable.  Toss the old core file and work on the
  -     new.  */
  -
  -  unpush_target (&core_ops);

does not need a replacement, because by the time we get here, the
target_preopen call at the top of core_target_open has already
unpushed any previous target.

gdb/ChangeLog:
2018-05-11  Pedro Alves  <palves@redhat.com>

	* corelow.c (core_target) <core_target>: No longer inline.
	Initialize m_core_gdbarch, m_core_vec and build the section table
	here.
	<~core_target>: New.
	<core_gdbarch, get_core_register_section>: New methods.
	<m_core_section_table, m_core_vec, m_core_gdbarch>: New fields,
	factored out from ...
	<core_data, core_vec, core_gdbarch>: ... these deleted globals.
	(core_ops): Delete.
	(sniff_core_bfd): Add gdbarch parameter.
	(core_close): Delete, merged into ...
	(core_target::close): ... here.  Delete self.
	(core_close_cleanup): Delete.
	(core_target_open): Allocate a core_target on the heap.  Use a
	unique_ptr instead of a cleanup.  Bits moved into the core_target
	ctor.  Adjust to use core_target methods instead of globals.
	(get_core_register_section): Rename to ...
	(core_target::get_core_register_section): ... this and adjust.
	(struct get_core_registers_cb_data): New.
	(get_core_registers_cb): Use it.  Use bool.
	(core_target::fetch_registers, core_target::files_info)
	(core_target::xfer_partial, core_target::read_description)
	(core_target::pid_to, core_target::thread_name): Adjust to
	reference class fields instead of globals.
	* target.h (struct target_ops_deleter, target_ops_up): New.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb/x86: Fix write out of mxcsr register for xsave targets
@ 2018-05-11 22:31 sergiodj+buildbot
  2018-06-23 22:05 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-11 22:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cf4912ae570ceae019b344785e4eeaf8cf273df3 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: cf4912ae570ceae019b344785e4eeaf8cf273df3

gdb/x86: Fix write out of mxcsr register for xsave targets

In commit:

  commit 8ee22052f690c007556b97eed59f49350ece5ca9
  Author: Andrew Burgess <andrew.burgess@embecosm.com>
  Date:   Thu May 3 17:46:14 2018 +0100

      gdb/x86: Handle kernels using compact xsave format

in two places FXSAVE_ADDR was used instead of FXSAVE_MXCSR_ADDR to get
the address of the mxcsr register within the xsave buffer.  This will
mean we are potentially accessing the wrong location within the xsave
buffer.

There are no tests included with this patch.  The first mistake would
only trigger an issue if/when the user tries to manually set the mxcsr
register to a value that matches the random (value off stack) value
that is in the xsave buffer, in this case the change by the user will
go unnoticed by GDB, and the default value of mxcsr will be preserved.

The second mistake only happens on the code path where all x87
registers are being written out of the register cache.  I'm not sure
how to trigger that code path.

gdb/ChangeLog:

	* i387-tdep.c (i387_collect_xsave): Use FXSAVE_MXCSR_ADDR not
	FXSAVE_ADDR for the mxcsr register.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb: xtensa: drop gdb_target definition
@ 2018-05-12  1:03 sergiodj+buildbot
  2018-06-22 16:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-12  1:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 67e6f569eb32332b8a70a919b0b14012247d320a ***

Author: Max Filippov <jcmvbkbc@gmail.com>
Branch: master
Commit: 67e6f569eb32332b8a70a919b0b14012247d320a

gdb: xtensa: drop gdb_target definition

gdb_target definitions were removed from configure.tgt in 2007, before
xtensa port was merged. Remove it from the xtensa target as well.

gdb/
2018-05-11  Max Filippov  <jcmvbkbc@gmail.com>

	* configure.tgt (xtensa*-*-linux*): Drop gdb_target definition.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PR20659, Objcopy and change section lma failing
@ 2018-05-12  7:32 sergiodj+buildbot
  2018-06-24 17:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-12  7:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9933dc52736dd349503e00a68cd0b9be4388f5a9 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 9933dc52736dd349503e00a68cd0b9be4388f5a9

PR20659, Objcopy and change section lma failing

Sections may well belong in multiple segments.  The testcase in the PR
saw an allocated section being assigned to an ABIFLAGS segment, then
not being assigned to a LOAD segment because it had already been
handled.  To fix that particular problem this patch sets and tests
segment_mark only for LOAD segments.  I kept the segment_mark test for
LOAD segments because I think there may otherwise be a problem with
zero size sections.

A few other problems showed up with the testcase.  Some targets align
.dynamic, resulting in the test failing with "section .dynamic lma
0x800000c0 adjusted to 0x800000cc" and similar messages.  I've tried
to handle that with some more hacks to the segment lma, which do the
right thing for the testcase, but may well fail in other situations.

I've also removed the tests of segment lma (p_paddr) and code involved
in deciding that an adjusted segment no longer covers the file or
program headers.  Those test can't be correct in the face of objcopy
--change-section-lma.  It may be necessary to reinstate the tests but
do them modulo page size, but we'll see how this goes.

	PR 20659
bfd/
	* elf.c (rewrite_elf_program_header): Use segment_mark only for
	PT_LOAD headers.  Delete first_matching_lma and first_suggested_lma.
	Instead make matching_lma and suggested_lma pointers to the
	sections.  Align section vma and lma calculated from segment.
	Don't clear includes_phdrs or includes_filehdr based on p_paddr
	test.  Try to handle alignment padding before first section by
	adjusting new segment lma down.  Adjust PT_PHDR map p_paddr.
ld/
	* testsuite/ld-elf/changelma.d,
	* testsuite/ld-elf/changelma.lnk,
	* testsuite/ld-elf/changelma.s: New test.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: Mark __bss_start, _end and _edata locally defined
@ 2018-05-14 12:32 sergiodj+buildbot
  2018-06-26 12:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-14 12:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9bc935ef3380a2d471b9447e2bf8e61297654e2f ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 9bc935ef3380a2d471b9447e2bf8e61297654e2f

x86: Mark __bss_start, _end and _edata locally defined

__bss_start, _end and _edata are defined by linker to mark regions
within executables and shared libraries.  All references within
executables should be locally resolved.

This patch doesn't change how their references within shared libraries
are resolved.

bfd/

	PR ld/23162
	* elfxx-x86.c (elf_x86_linker_defined): New function.
	(_bfd_x86_elf_link_check_relocs): Use it to mark __bss_start,
	_end and _edata locally defined within executables.

ld/

	PR ld/23162
	* testsuite/ld-elf/pr23162.map: New file.
	* testsuite/ld-elf/pr23162.rd: Likewise.
	* testsuite/ld-elf/pr23162a.c: Likewise.
	* testsuite/ld-elf/pr23162b.c: Likewise.
	* testsuite/ld-elf/shared.exp: Run PR ld/23162 tests.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86; Allow IFUNC pointer defined in PDE
@ 2018-05-14 12:39 sergiodj+buildbot
  2018-06-26 14:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-14 12:39 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4ec0995016801cc5d5cf13baf6e10163861e6852 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 4ec0995016801cc5d5cf13baf6e10163861e6852

x86; Allow IFUNC pointer defined in PDE

If IFUNC symbol is defined in position-dependent executable, we should
change it to the normal function and set its address to its PLT entry
which should be resolved by R_*_IRELATIVE at run-time.  All external
references should be resolved to its PLT in executable.

bfd/

	PR ld/23169
	* elf-ifunc.c (_bfd_elf_allocate_ifunc_dyn_relocs): Don't issue
	an error on IFUNC pointer defined in PDE.
	* elf32-i386.c (elf_i386_finish_dynamic_symbol): Call
	_bfd_x86_elf_link_fixup_ifunc_symbol.
	* elf64-x86-64.c (elf_x86_64_finish_dynamic_symbol): Likewise.
	* elfxx-x86.c (_bfd_x86_elf_link_fixup_ifunc_symbol): New
	function.
	* elfxx-x86.h (_bfd_x86_elf_link_fixup_ifunc_symbol): New.

ld/

	PR ld/23169
	* testsuite/ld-ifunc/ifunc-9-i386.d: New file.
	* testsuite/ld-ifunc/ifunc-9-x86-64.d: Likewise.
	* testsuite/ld-ifunc/pr23169a.c: Likewise.
	* testsuite/ld-ifunc/pr23169a.rd: Likewise.
	* testsuite/ld-ifunc/pr23169b.c: Likewise.
	* testsuite/ld-ifunc/pr23169b.c: Likewise.
	* testsuite/ld-ifunc/pr23169c.rd: Likewise.
	* testsuite/ld-ifunc/pr23169c.rd: Likewise.
	* testsuite/ld-ifunc/ifunc-9-x86.d: Removed.
	* testsuite/ld-ifunc/ifunc.exp: Run PR ld/23169 tests.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Clear rust_unions in rust_union_quirks
@ 2018-05-14 16:38 sergiodj+buildbot
  2018-06-27  3:44 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-14 16:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2d79090eabe8aa972b07cb71a3dd73ef9498acfa ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 2d79090eabe8aa972b07cb71a3dd73ef9498acfa

Clear rust_unions in rust_union_quirks

It turns out that a dwarf2_cu can remain allocated after psymtab
expansion is done, and so it makes sense to clear rust_unions when
done processing it.

Tested on x86-64 Fedora 27.

2018-05-14  Tom Tromey  <tom@tromey.com>

	* dwarf2read.c (rust_union_quirks): Clear rust_unions.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add a new Portuguese translation for the bfd sub-directory.
@ 2018-05-15 13:22 sergiodj+buildbot
  2018-06-27 15:11 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-15 13:22 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 293b4d4fe9f8a9624531fdd37f365d1b683d4623 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 293b4d4fe9f8a9624531fdd37f365d1b683d4623

Add a new Portuguese translation for the bfd sub-directory.

	* po/pt.po: New Portuguese translation.
	* configure.ac (ALL_LINGUAS): Add pt.
	* configure: Regenerate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix error messages in the NFP sources when building for 32-bit targets.
@ 2018-05-15 13:56 sergiodj+buildbot
  2018-06-27 21:14 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-15 13:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1678bd35a35a3bace2d4aee39b64d96c638651f0 ***

Author: Francois H. Theron <francois.theron@netronome.com>
Branch: master
Commit: 1678bd35a35a3bace2d4aee39b64d96c638651f0

Fix error messages in the NFP sources when building for 32-bit targets.

bfd	* targets.c: Wrap nfp_elf64_vec in BFD64 ifdef.

include	* opcode/nfp.h: Use uint64_t instead of bfd_vma.

opcodes	* nfp-dis.c: Use uint64_t for instruction variables, not bfd_vma.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix uninitialised memory acccess in COFF bfd backend
@ 2018-05-15 14:05 sergiodj+buildbot
  2018-06-28  7:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-15 14:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 810ed4db984d378ca9c8e3d152966fb81c23ef95 ***

Author: Christophe Guillon <christophe.guillon@st.com>
Branch: master
Commit: 810ed4db984d378ca9c8e3d152966fb81c23ef95

Fix uninitialised memory acccess in COFF bfd backend

2018-05-15  Christophe Guillon  <christophe.guillon@st.com>

	* coffcode.h (coff_bigobj_swap_aux_in): Make sure that all fields
	of the aux structure are initialised.

Change-Id: I81be255ac6611afbe00995fac550e98e6a07e5df


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] testsuite: Fix a `server_pid' access crash in gdb.server/server-kill.exp
@ 2018-05-15 15:48 sergiodj+buildbot
  2018-06-28 17:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-15 15:48 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0726fcc61a8b7c943de513ec598b2189c5f67715 ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 0726fcc61a8b7c943de513ec598b2189c5f67715

testsuite: Fix a `server_pid' access crash in gdb.server/server-kill.exp

Fix a commit f90183d7e31b ("Get GDBserver pid on remote target") bug and
correctly handle the case where the PID of `gdbserver' could not have
been retrieved.  If that happens, $server_pid is unset causing:

FAIL: gdb.server/server-kill.exp: p server_pid
ERROR: tcl error sourcing .../gdb/testsuite/gdb.server/server-kill.exp.
ERROR: can't read "server_pid": no such variable
    while executing
"if {$server_pid == "" } {
    return -1
}"
    (file ".../gdb/testsuite/gdb.server/server-kill.exp" line 49)
    invoked from within
"source .../gdb/testsuite/gdb.server/server-kill.exp"
    ("uplevel" body line 1)
    invoked from within
"uplevel #0 source .../gdb/testsuite/gdb.server/server-kill.exp"
    invoked from within
"catch "uplevel #0 source $test_file_name""

Verify that the variable exists then rather than trying to access it.

	gdb/testsuite/
	* gdb.server/server-kill.exp: Verify whether `server_pid' exists
	rather then trying to access it in determining whether the PID
	of `gdbserver' could have been retrieved.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] MIPS/Linux/native: Supply $zero for the !PTRACE_GETREGS case
@ 2018-05-15 16:51 sergiodj+buildbot
  2018-06-29 21:53 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-15 16:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4e6ff0e1b86f736ba20a5034509ffe9f8f05b971 ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 4e6ff0e1b86f736ba20a5034509ffe9f8f05b971

MIPS/Linux/native: Supply $zero for the !PTRACE_GETREGS case

With native MIPS/Linux targets the $zero register is inaccessible, with
its supposed context slot provided by the OS occupied by the $restart
register.  The PTRACE_GETREGS path takes care of it by artificially
supplying the hardwired contents of $zero in `mips_supply_gregset' or
`mips64_supply_gregset', as applicable, however the PTRACE_PEEKUSER
fallback does not, making the register unavailable, e.g.:

(gdb) info registers
         zero       at       v0       v1       a0       a1       a2       a3
R0    <unavl> 00000001 00000001 d2f1a9fc 00000000 00000000 00417158 00417150
           t0       t1       t2       t3       t4       t5       t6       t7
R8   00000004 00000000 fffffff8 00000000 00000000 00000000 00000001 00000007
           s0       s1       s2       s3       s4       s5       s6       s7
R16  00000000 00405e30 00000000 00500000 00000000 0052ec08 00000000 00000000
           t8       t9       k0       k1       gp       sp       s8       ra
R24  00000000 00417008 00000000 00000000 0041e220 7fff4ce0 7fff4ce0 00405d0c
       status       lo       hi badvaddr    cause       pc
      <unavl> 00441cf1 00000017 00417004 00800024 00405d10
         fcsr      fir  restart
     00800000 00f30000 00000000
(gdb)

or (under certain circumstances):

(gdb) stepi
Register 0 is not available
(gdb)

This is specifically because `mips_linux_register_addr' and
`mips64_linux_register_addr', both correctly return -1 for
MIPS_ZERO_REGNUM, and therefore `linux_nat_trad_target::fetch_registers'
faithfully marks this register as unavailable.

Supply this register artificially then in the PTRACE_PEEKUSER case as
well, correcting this issue.

	gdb/
	* mips-linux-nat.c (mips_linux_nat_target::fetch_registers):
	Supply the MIPS_ZERO_REGNUM register.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] MIPS: Make `mask_address_var' static
@ 2018-05-15 17:55 sergiodj+buildbot
  2018-06-29 11:45 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-15 17:55 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ea33cd9290063d977fb2c31ea6a8567da585ab88 ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: ea33cd9290063d977fb2c31ea6a8567da585ab88

MIPS: Make `mask_address_var' static

Make the `mask_address_var' variable static, it is not used outside
mips-tdep.c and having no target name embedded within it causes a risk
of a namespace clash.

	gdb/
	* mips-tdep.c (mask_address_var): Make variable static.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Implement Read/Write constraints on system registers on AArch64
@ 2018-05-15 21:45 sergiodj+buildbot
  2018-07-01  4:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-15 21:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f9830ec1655e7cc2aa88c9c34a20503978d9dc88 ***

Author: Tamar Christina <tamar.christina@arm.com>
Branch: master
Commit: f9830ec1655e7cc2aa88c9c34a20503978d9dc88

Implement Read/Write constraints on system registers on AArch64

This patch adds constraints for read and write only system registers with the
msr and mrs instructions.  The code will treat having both flags set and none
set as the same.  These flags add constraints that must be matched up. e.g. a
system register with a READ only flag set, can only be used with mrs.  If The
constraint fails a warning is emitted.

Examples of the warnings generated:

test.s: Assembler messages:
test.s:5: Warning: specified register cannot be written to at operand 1 -- `msr dbgdtrrx_el0,x3'
test.s:7: Warning: specified register cannot be read from at operand 2 -- `mrs x3,dbgdtrtx_el0'
test.s:8: Warning: specified register cannot be written to at operand 1 -- `msr midr_el1,x3'

and disassembly notes:

0000000000000000 <main>:
   0:	d5130503 	msr	dbgdtrtx_el0, x3
   4:	d5130503 	msr	dbgdtrtx_el0, x3
   8:	d5330503 	mrs	x3, dbgdtrrx_el0
   c:	d5330503 	mrs	x3, dbgdtrrx_el0
  10:	d5180003 	msr	midr_el1, x3	; note: writing to a read-only register.

Note that because dbgdtrrx_el0 and dbgdtrtx_el0 have the same encoding, during
disassembly the constraints are use to disambiguate between the two.  An exact
constraint match is always prefered over partial ones if available.

As always the warnings can be suppressed with -w and also be made errors using
warnings as errors.

binutils/

	PR binutils/21446
	* doc/binutils.texi (-M): Document AArch64 options.

gas/

	PR binutils/21446
	* testsuite/gas/aarch64/illegal-sysreg-2.s: Fix pmbidr_el1 test.
	* testsuite/gas/aarch64/illegal-sysreg-2.l: Likewise.
	* testsuite/gas/aarch64/illegal-sysreg-2.d: Likewise.
	* testsuite/gas/aarch64/sysreg-diagnostic.s: New.
	* testsuite/gas/aarch64/sysreg-diagnostic.l: New.
	* testsuite/gas/aarch64/sysreg-diagnostic.d: New.

include/

	PR binutils/21446
	* opcode/aarch64.h (F_SYS_READ, F_SYS_WRITE): New.

opcodes/

	PR binutils/21446
	* aarch64-asm.c (opintl.h): Include.
	(aarch64_ins_sysreg): Enforce read/write constraints.
	* aarch64-dis.c (aarch64_ext_sysreg): Likewise.
	* aarch64-opc.h (F_DEPRECATED, F_ARCHEXT, F_HASXT): Moved here.
	(F_REG_READ, F_REG_WRITE): New.
	* aarch64-opc.c (aarch64_print_operand): Generate notes for
	AARCH64_OPND_SYSREG.
	(F_DEPRECATED, F_ARCHEXT, F_HASXT): Move to aarch64-opc.h.
	(aarch64_sys_regs): Add constraints to currentel, midr_el1, ctr_el0,
	mpidr_el1, revidr_el1, aidr_el1, dczid_el0, id_dfr0_el1, id_pfr0_el1,
	id_pfr1_el1, id_afr0_el1, id_mmfr0_el1, id_mmfr1_el1, id_mmfr2_el1,
	id_mmfr3_el1, id_mmfr4_el1, id_isar0_el1, id_isar1_el1, id_isar2_el1,
	id_isar3_el1, id_isar4_el1, id_isar5_el1, mvfr0_el1, mvfr1_el1,
	mvfr2_el1, ccsidr_el1, id_aa64pfr0_el1, id_aa64pfr1_el1,
	id_aa64dfr0_el1, id_aa64dfr1_el1, id_aa64isar0_el1, id_aa64isar1_el1,
	id_aa64mmfr0_el1, id_aa64mmfr1_el1, id_aa64mmfr2_el1, id_aa64afr0_el1,
	id_aa64afr0_el1, id_aa64afr1_el1, id_aa64zfr0_el1, clidr_el1,
	csselr_el1, vsesr_el2, erridr_el1, erxfr_el1, rvbar_el1, rvbar_el2,
	rvbar_el3, isr_el1, tpidrro_el0, cntfrq_el0, cntpct_el0, cntvct_el0,
	mdccsr_el0, dbgdtrrx_el0, dbgdtrtx_el0, osdtrrx_el1, osdtrtx_el1,
	mdrar_el1, oslar_el1, oslsr_el1, dbgauthstatus_el1, pmbidr_el1,
	pmsidr_el1, pmswinc_el0, pmceid0_el0, pmceid1_el0.
	* aarch64-tbl.h (aarch64_opcode_table): Add constraints to
	msr (F_SYS_WRITE), mrs (F_SYS_READ).


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix disassembly mask for vector sdot on AArch64.
@ 2018-05-16 12:21 sergiodj+buildbot
  2018-07-01 14:39 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-16 12:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ff329288d503d392de11f34ce64c7fdd3c62e50f ***

Author: Tamar Christina <tamar.christina@arm.com>
Branch: master
Commit: ff329288d503d392de11f34ce64c7fdd3c62e50f

Fix disassembly mask for vector sdot on AArch64.

This patch corrects the disassembly masks for by element dot product
instructions. The bit 10 was wrong and supposed to be 1.

This caused incorrect disassembly of instructions in the unallocated space to
disassemble as dot product instructions.

No encoding errors can arrise from this issue.

opcodes/

	PR binutils/23109
	* aarch64-tbl.h (aarch64_opcode_table): Correct sdot and udot.
	* aarch64-dis-2.c: Regenerate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PR22458, failure to choose a matching ELF target
@ 2018-05-16 13:10 sergiodj+buildbot
  2018-07-02  0:58 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-16 13:10 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7cf7fcc83ca9fb4c4b591b3142bcf12e6e8a2aa5 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 7cf7fcc83ca9fb4c4b591b3142bcf12e6e8a2aa5

PR22458, failure to choose a matching ELF target

https://sourceware.org/ml/binutils/2013-05/msg00271.html was supposed
to banish "file format is ambiguous" errors for ELF.  It didn't,
because the code supposedly detecting formats that implement
match_priority didn't work.  That was due to not placing all matching
targets into the vector of matching targets.  ELF objects should all
match the generic ELF target (priority 2), plus one or more machine
specific targets (priority 1), and perhaps a single machine specific
target with OS/ABI set (priority 0, best match).  So the armel object
in the testcase actually matches elf32-littlearm,
elf32-littlearm-symbian, and elf32-littlearm-vxworks (all priority 1),
and elf32-little (priority 2).  As the PR reported, elf32-little
wasn't seen as matching.  Fixing that part of the problem wasn't too
difficult but matching the generic ELF target as well as the ARM ELF
targets resulted in ARM testsuite failures.

These proved to be the annoying reordering of stubs that occurs from
time to time due to the stub names containing the section id.
Matching another target causes more sections to be created in
elf_object_p.  If section ids change, stub names change, which results
in different hashing and can therefore result in different hash table
traversal and stub creation order.  That particular problem is fixed
by resetting section_id to the initial state before attempting each
target match, and taking a snapshot of its value after a successful
match.

	PR 22458
	* format.c (struct bfd_preserve): Add section_id.
	(bfd_preserve_save, bfd_preserve_restore): Save and restore
	_bfd_section_id.
	(bfd_reinit): Set _bfd_section_id.
	(bfd_check_format_matches): Put all matches of any priority into
	matching_vector.  Save initial section id and start each attempted
	match at that section id.
	* libbfd-in.h (_bfd_section_id): Declare.
	* section.c (_bfd_section_id): Rename from section_id and make
	global.  Adjust uses.
	(bfd_get_next_section_id): Delete.
	* elf64-ppc.c (ppc64_elf_setup_section_lists): Replace use of
	bfd_get_section_id with _bfd_section_id.
	* libbfd.h: Regenerate.
	* bfd-in2.h: Regenerate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] regcache.c: Remove unused typedefs
@ 2018-05-16 17:23 sergiodj+buildbot
  2018-07-02 11:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-16 17:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3acb7083a675fb3077739a2ae41a4a4cd6ef9cc3 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 3acb7083a675fb3077739a2ae41a4a4cd6ef9cc3

regcache.c: Remove unused typedefs

gdb/ChangeLog:

	* regcache.c (regcache_read_ftype, regcache_write_ftype):
	Remove.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use a distinguishing name for minidebug objfile
@ 2018-05-16 18:44 sergiodj+buildbot
  2018-07-03 10:55 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-16 18:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 921222e2e8e8427c6a609b1ff66265dceb0d07eb ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 921222e2e8e8427c6a609b1ff66265dceb0d07eb

Use a distinguishing name for minidebug objfile

One part of PR cli/19551 is that the mini debug info objfile reuses the
name of the main objfile from which it comes.  This can be seen because
gdb claims to be reading symbols from the same file two times, like:

Reading symbols from /bin/gdb...Reading symbols from /bin/gdb...(no debugging symbols found)...done.

I think this would be less confusing if the minidebug objfile were given
a different name.  That is what this patch implements.  It also arranges
for the minidebug objfile to be marked OBJF_NOT_FILENAME.

After this patch the output looks like:

Reading symbols from /bin/gdb...Reading symbols from .gnu_debugdata for /usr/libexec/gdb...(no debugging symbols found)...done.

Tested by the buildbot.

gdb/ChangeLog
2018-05-16  Tom Tromey  <tom@tromey.com>

	PR cli/19551:
	* symfile-add-flags.h (enum symfile_add_flags)
	<SYMFILE_NOT_FILENAME>: New constant.
	* symfile.c (read_symbols): Use SYMFILE_NOT_FILENAME.  Get
	objfile name from BFD.
	(symbol_file_add_with_addrs): Check SYMFILE_NOT_FILENAME.
	* minidebug.c (find_separate_debug_file_in_section): Put
	".gnu_debugdata" into BFD's file name.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Make "cbfd" a gdb_bfd_ref_ptr
@ 2018-05-16 19:34 sergiodj+buildbot
  2018-07-05  6:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-16 19:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 06333fea767dc1eaf88ac286293fcbaa0ef2de9e ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 06333fea767dc1eaf88ac286293fcbaa0ef2de9e

Make "cbfd" a gdb_bfd_ref_ptr

This changes program_space::cbfd to be a gdb_bfd_ref_ptr.  This makes
it somewhat less error-prone to use, because now it manages the
reference counting automatically.

Tested by the buildbot.

2018-05-16  Tom Tromey  <tom@tromey.com>

	* gdbcore.h (core_bfd): Redefine.
	* corelow.c (core_target::close): Update.
	(core_target_open): Update.
	* progspace.h (struct program_space) <cbfd>: Now a
	gdb_bfd_ref_ptr.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] NDS32/BFD: Fix build error in `nds32_convert_32_to_16'
@ 2018-05-16 20:38 sergiodj+buildbot
  2018-07-05 19:42 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-16 20:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1624c9ca3fd32bf25b2cb63f99270abe41f718f5 ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 1624c9ca3fd32bf25b2cb63f99270abe41f718f5

NDS32/BFD: Fix build error in `nds32_convert_32_to_16'

Fix:

cc1: warnings being treated as errors
.../bfd/elf32-nds32.c: In function 'nds32_convert_32_to_16':
.../bfd/elf32-nds32.c:6816: error: 'insn_type' may be used uninitialized in this function
make[4]: *** [elf32-nds32.lo] Error 1

seen with GCC 4.1.2 and 4.4.7.

	bfd/
	* elf32-nds32.c (nds32_convert_32_to_16): Preset `insn_type'.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PR gdb/22286: linux-nat-trad: Support arbitrary register widths
@ 2018-05-16 20:39 sergiodj+buildbot
  2018-07-06  6:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-16 20:39 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1d7611244c140a1a08f3365cd5881120eba7749d ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 1d7611244c140a1a08f3365cd5881120eba7749d

PR gdb/22286: linux-nat-trad: Support arbitrary register widths

Update `fetch_register' and `store_register' code to support arbitrary
register widths rather than only ones that are a multiply of the size of
the `ptrace' data type used with PTRACE_PEEKUSR and PTRACE_POKEUSR
requests to access registers.  Remove associated assertions, correcting
an issue with accessing the DSPControl (`$dspctl') register on n64 MIPS
native targets:

(gdb) print /x $dspctl
.../gdb/linux-nat-trad.c:50: internal-error: void linux_nat_trad_target::fetch_register(regcache*, int): Assertion `(size % sizeof (PTRACE_TYPE_RET)) == 0' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Quit this debugging session? (y or n) n

This is a bug, please report it.  For instructions, see:
<http://www.gnu.org/software/gdb/bugs/>.

.../gdb/linux-nat-trad.c:50: internal-error: void linux_nat_trad_target::fetch_register(regcache*, int): Assertion `(size % sizeof (PTRACE_TYPE_RET)) == 0' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Create a core file of GDB? (y or n) n
Command aborted.
(gdb)

All registers are now reported correctly and their architectural
hardware widths respected:

(gdb) print /x $dspctl
$1 = 0x55aa33cc
(gdb) info registers
                  zero               at               v0               v1
 R0   0000000000000000 0000000000000001 000000fff7ffeb20 0000000000000000
                    a0               a1               a2               a3
 R4   0000000000000001 000000ffffffeaf8 000000ffffffeb08 0000000000000000
                    a4               a5               a6               a7
 R8   000000fff7ee3800 000000fff7ede8f0 000000ffffffeaf0 2f2f2f2f2f2f2f2f
                    t0               t1               t2               t3
 R12  0000000000000437 0000000000000002 000000fff7ffd000 0000000120000ad0
                    s0               s1               s2               s3
 R16  000000fff7ee2068 0000000120000e60 0000000000000000 0000000000000000
                    s4               s5               s6               s7
 R20  0000000000521ec8 0000000000522608 0000000000000000 0000000000000000
                    t8               t9               k0               k1
 R24  0000000000000000 0000000120000d9c 0000000000000000 0000000000000000
                    gp               sp               s8               ra
 R28  0000000120019030 000000ffffffe990 000000ffffffe990 000000fff7d5b88c
                status               lo               hi         badvaddr
      0000000000109cf3 0000000000005ea5 0000000000000211 000000fff7fc6fe0
                 cause               pc
      0000000000800024 0000000120000dbc
                  fcsr              fir              hi1              lo1
              00000000         00f30000 0000000000000000 0101010101010101
                   hi2              lo2              hi3              lo3
      0202020202020202 0303030303030303 0404040404040404 0505050505050505
                dspctl          restart
              55aa33cc 0000000000000000
(gdb)

NB due to the lack of access to 64-bit DSP hardware all DSP register
values in the dumps are artificial and have been created with a debug
change applied to the kernel handler of the `ptrace' syscall.

The use of `store_unsigned_integer' and `extract_unsigned_integer'
unconditionally in all cases rather than when actual data occupies a
part of the data quantity exchanged with `ptrace' makes code perhaps
marginally slower, however I think avoiding it is not worth code
obfuscation it would cause.  If this turns out unfounded, then there
should be no problem with optimizing this code later.

	gdb/
	PR gdb/22286
	* linux-nat-trad.c (linux_nat_trad_target::fetch_register):
	Also handle registers whose width is not a multiple of
	PTRACE_TYPE_RET.
	(linux_nat_trad_target::store_register): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] value.c: Remove unused variables
@ 2018-05-17 15:50 sergiodj+buildbot
  2018-07-07  2:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-17 15:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3e6188349fbf16e9da69837e5e1211537805e422 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 3e6188349fbf16e9da69837e5e1211537805e422

value.c: Remove unused variables

Obvious patch to remove unused local variables (found by adding
-Wunused).  I didn't touch this one in value_fetch_lazy, because
check_typedef could have a desired side-effect.

  3743  struct type *type = check_typedef (value_type (val));

gdb/ChangeLog:

	* value.c (release_value): Remove unused variable.
	(record_latest_value): Likewise.
	(access_value_history): Likewise.
	(preserve_values): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Updated simplified Chinese translation for the opcodes directory.
@ 2018-05-17 15:55 sergiodj+buildbot
  2018-07-07 13:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-17 15:55 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 809276d28ad0212dd5a3f9074090e1425e5e4d8e ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 809276d28ad0212dd5a3f9074090e1425e5e4d8e

Updated simplified Chinese translation for the opcodes directory.

opcodes	* po/zh_CN.po: Updated simplified Chinese translation.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix for dwz-related crash
@ 2018-05-17 17:06 sergiodj+buildbot
  2018-07-07 23:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-17 17:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 58f0c71853f98afe623ab89c4362682885905ebb ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 58f0c71853f98afe623ab89c4362682885905ebb

Fix for dwz-related crash

PR symtab/23010 reports a crash that occurs when using -readnow
on a dwz-generated debuginfo file.

The crash occurs because the DWARF has a partial CU with no language
set, and then a full CU that references this partial CU using
DW_AT_abstract_origin.

In this case, the partial CU is read by dw2_expand_all_symtabs using
language_minimal; but then this conflicts with the creation of the
block's symbol table in the C++ CU.

This patch fixes the problem by arranging for partial CUs not to be
read by -readnow.  I tend to think that it doesn't make sense to read
a partial CU in isolation -- they should only be read when imported
into some other CU.

In conjunction with some other patches I am going to post, this also
fixes the Rust -readnow crash that Jan reported.

There are two problems with this patch:

1. It is difficult to reason about.  There are many cases where I've
   patched the code to call init_cutu_and_read_dies with the flag set
   to "please do read partial units" -- but I find it difficult to be
   sure that this is always correct.

2. It is still missing a standalone test case.  This seemed hard.

2018-05-17  Tom Tromey  <tom@tromey.com>

	PR symtab/23010:
	* dwarf2read.c (load_cu, dw2_do_instantiate_symtab)
	(dw2_instantiate_symtab): Add skip_partial parameter.
	(dw2_find_last_source_symtab, dw2_map_expand_apply)
	(dw2_lookup_symbol, dw2_expand_symtabs_for_function)
	(dw2_expand_all_symtabs, dw2_expand_symtabs_with_fullname)
	(dw2_expand_symtabs_matching_one)
	(dw2_find_pc_sect_compunit_symtab)
	(dw2_debug_names_lookup_symbol)
	(dw2_debug_names_expand_symtabs_for_function): Update.
	(init_cutu_and_read_dies): Add skip_partial parameter.
	(process_psymtab_comp_unit, build_type_psymtabs_1)
	(process_skeletonless_type_unit, load_partial_comp_unit)
	(psymtab_to_symtab_1): Update.
	(load_full_comp_unit): Add skip_partial parameter.
	(process_imported_unit_die, dwarf2_read_addr_index)
	(follow_die_offset, dwarf2_fetch_die_loc_sect_off)
	(dwarf2_fetch_constant_bytes, dwarf2_fetch_die_type_sect_off)
	(read_signatured_type): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Make format_pieces recognize the \e escape sequence
@ 2018-05-17 17:59 sergiodj+buildbot
  2018-07-08  9:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-17 17:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b17992c1c02a2d8a832a887c2de23a7f3ab869f8 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: b17992c1c02a2d8a832a887c2de23a7f3ab869f8

Make format_pieces recognize the \e escape sequence

I noticed that the printf command did not recognize the \e escape
sequence, used amongst other things to use colors:

  (gdb) printf "This is \e[32mgreen\e[m!\n"
  Unrecognized escape character \e in format string.

This patch makes format_pieces recognize it, which makes that command
print the expected result in glorious color.

I wrote a really simple unit test for format_pieces.
format_pieces::operator[] is unused so I removed it.  I added
format_piece::operator==, which is needed to compare vectors of
format_piece.

gdb/ChangeLog:

	PR cli/14975
	* Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
	unittests/format_pieces-selftests.c.
	* common/format.h (format_piece) <operator==>: New.
	(format_pieces) <operator[]>: Remove.
	* common/format.c (format_pieces::format_pieces): Handle \e.
	* unittests/format_pieces-selftests.c: New.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Don't elide all inlined frames
@ 2018-05-18  0:01 sergiodj+buildbot
  2018-07-08 20:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-18  0:01 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ddfe970e6bec29f779a60b071f12590e53cfe6eb ***

Author: Keith Seitz <keiths@redhat.com>
Branch: master
Commit: ddfe970e6bec29f779a60b071f12590e53cfe6eb

Don't elide all inlined frames

This patch essentially causes GDB to treat inlined frames like "normal"
frames from the user's perspective.  This means, for example, that when a
user sets a breakpoint in an inlined function, GDB will now actually stop
"in" that function.

Using the test case from breakpoints/17534,

3	static inline void NVIC_EnableIRQ(int IRQn)
4	{
5	  volatile int y;
6	  y = IRQn;
7	}
8
9	__attribute__( ( always_inline ) ) static inline void __WFI(void)
10	{
11	    __asm volatile ("nop");
12	}
13
14	int main(void) {
15
16	    x= 42;
17
18	    if (x)
19	      NVIC_EnableIRQ(16);
20	    else
21	      NVIC_EnableIRQ(18);
(gdb) b NVIC_EnableIRQ
Breakpoint 1 at 0x4003e4: NVIC_EnableIRQ. (2 locations)
(gdb) r
Starting program: 17534

Breakpoint 1, main () at 17534.c:19
19	      NVIC_EnableIRQ(16);

Because skip_inline_frames currently skips every inlined frame, GDB "stops"
in the caller.  This patch adds a new parameter to skip_inline_frames
that allows us to pass in a bpstat stop chain.  The breakpoint locations
on the stop chain can be used to determine if we've stopped inside an inline
function (due to a user breakpoint).  If we have, we do not elide the frame.

With this patch, GDB now reports that the inferior has stopped inside the
inlined function:

(gdb) r
Starting program: 17534

Breakpoint 1, NVIC_EnableIRQ (IRQn=16) at 17534.c:6
6	  y = IRQn;

Many thanks to Jan and Pedro for guidance on this.

gdb/ChangeLog:

	* breakpoint.c (build_bpstat_chain): New function, moved from
	bpstat_stop_status.
	(bpstat_stop_status): Add optional parameter, `stop_chain'.
	If no stop chain is passed, call build_bpstat_chain to build it.
	* breakpoint.h (build_bpstat_chain): Declare.
	(bpstat_stop_status): Move documentation here from breakpoint.c.
	* infrun.c (handle_signal_stop): Before eliding inlined frames,
	build the stop chain and pass it to skip_inline_frames.
	Pass this stop chain to bpstat_stop_status.
	* inline-frame.c: Include breakpoint.h.
	(stopped_by_user_bp_inline_frame): New function.
	(skip_inline_frames): Add parameter `stop_chain'.
	Move documention to inline-frame.h.
	If non-NULL, use stopped_by_user_bp_inline_frame to determine
	whether the frame should be elided.
	* inline-frame.h (skip_inline_frames): Add parameter `stop_chain'.
	Add moved documentation and update for new parameter.

gdb/testsuite/ChangeLog:

	* gdb.ada/bp_inlined_func.exp: Update inlined frame locations
	in expected breakpoint stop locations.
	* gdb.dwarf2/implptr.exp (implptr_test_baz): Use up/down to
	move to proper scope to test variable values.
	* gdb.opt/inline-break.c (inline_func1, not_inline_func1)
	(inline_func2, not_inline_func2, inline_func3, not_inline_func3):
	New functions.
	(main): Call not_inline_func3.
	* gdb.opt/inline-break.exp: Start inferior and set breakpoints at
	inline_func1, inline_func2, and inline_func3.  Test that when each
	breakpoint is hit, GDB properly reports both the stop location
	and the backtrace. Repeat tests for temporary breakpoints.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] opcodes sources should not include libbfd.h
@ 2018-05-18  4:22 sergiodj+buildbot
  2018-07-10 10:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-18  4:22 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 29e0f0a144fcabb6fa088c58b49e5924d7c43967 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 29e0f0a144fcabb6fa088c58b49e5924d7c43967

opcodes sources should not include libbfd.h

	* nfp-dis.c: Don't #include libbfd.h.
	(init_nfp3200_priv): Use bfd_get_section_contents.
	(nit_nfp6000_mecsr_sec): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] libbfd.h and libcoff.h include guards
@ 2018-05-18  4:54 sergiodj+buildbot
  2018-07-11 15:49 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-18  4:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0b4395434942ecc6f3006004784d19d9a4fbbf55 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 0b4395434942ecc6f3006004784d19d9a4fbbf55

libbfd.h and libcoff.h include guards

	* libbfd-in.h: Add include guard.
	* libcoff-in.h: Likewise.
	* doc/Makefile.am (libbfd.h, libcoff.h): Append another #endif.
	* doc/Makefile.in: Regenerate.
	* libbfd.h: Regenerate.
	* libcoff.h: Regenerate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] ATTRIBUTE_HIDDEN for libbfd.h
@ 2018-05-18  6:58 sergiodj+buildbot
  2018-07-13  3:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-18  6:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8722de9c419c98ce2fb1f294097244c0bc45e030 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 8722de9c419c98ce2fb1f294097244c0bc45e030

ATTRIBUTE_HIDDEN for libbfd.h

	* libbfd-in.h (ATTRIBUTE_HIDDEN): Define and use throughout.
	* configure.ac (HAVE_HIDDEN): Check compiler support for hidden
	visibility.
	* libbfd.h: Regenerate.
	* configure: Regenerate.
	* config.in: Regenerate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PR23199, Invalid SHT_GROUP entry leads to group confusion
@ 2018-05-18  9:45 sergiodj+buildbot
  2018-07-14  2:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-18  9:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4bba0fb1c6d391a217c25e44398a7e1c7090155f ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 4bba0fb1c6d391a217c25e44398a7e1c7090155f

PR23199, Invalid SHT_GROUP entry leads to group confusion

This patch prevents elf_next_in_group list pointer confusion when
SHT_GROUP sections specify other SHT_GROUP sections in their list of
group sections.

	PR 23199
	* elf.c (setup_group): Formatting.  Check that SHT_GROUP entries
	don't point at other SHT_GROUP sections.  Set shdr corresponding
	to invalid entry, to NULL rather than section 0.  Identify
	SHT_GROUP section index when reporting an error.  Cope with NULL
	shdr pointer.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: Don't set eh->local_ref to 1 for linker defined symbols
@ 2018-05-18 14:23 sergiodj+buildbot
  2018-07-14 13:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-18 14:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 011b32fd4270fb7111ee1f63695ccd44562ee7df ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 011b32fd4270fb7111ee1f63695ccd44562ee7df

x86: Don't set eh->local_ref to 1 for linker defined symbols

Since symbols created by HIDDEN and PROVIDE_HIDDEN assignments in
linker script may be marked as defined, but not hidden, we can't
set eh->local_ref to 1 in _bfd_x86_elf_link_symbol_references_local.

Also R_386_GOT32X should be handled as just like R_386_GOT32 when
relocating a section.  The input R_386_GOT32X relocations, which
can be relaxed, should have been converted to R_386_PC32, R_386_32
or R_386_GOTOFF.

bfd/

	PR ld/23189
	* elf32-i386.c (elf_i386_relocate_section): Handle R_386_GOT32X
	like R_386_GOT32.
	* elfxx-x86.c (_bfd_x86_elf_link_symbol_references_local): Don't
	set eh->local_ref to 1 for linker defined symbols.

ld/

	PR ld/23189
	* testsuite/ld-i386/i386.exp: Run pr23189.
	* testsuite/ld-x86-64/x86-64.exp: Likewise.
	* testsuite/ld-i386/pr23189.d: New file.
	* testsuite/ld-i386/pr23189.s: Likewise.
	* testsuite/ld-i386/pr23189.t: Likewise.
	* testsuite/ld-x86-64/pr23189.d: Likewise.
	* testsuite/ld-x86-64/pr23189.s: Likewise.
	* testsuite/ld-x86-64/pr23189.t: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add support for the Freescale s12z processor.
@ 2018-05-18 15:27 sergiodj+buildbot
  2018-07-14 23:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-18 15:27 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7b4ae824289504c173a597e86a00ceab452095b7 ***

Author: John Darrington <john@darrington.wattle.id.au>
Branch: master
Commit: 7b4ae824289504c173a597e86a00ceab452095b7

Add support for the Freescale s12z processor.

bfd	* Makefile.am: Add s12z files.
	* Makefile.in: Regenerate.
	* archures.c: Add bfd_s12z_arch.
	* bfd-in.h: Add exports of bfd_putb24 and bfd_putl24.
	* bfd-in2.h: Regenerate.
	* config.bfd: Add s12z target.
	* configure.ac: Add s12z target.
	* configure: Regenerate.
	* cpu-s12z.c: New file.
	* elf32-s12z.c: New file.
	* libbfd.c (bfd_putb24): New function.
	(bfd_putl24): New function.
	* libbfd.h: Regenerate.
	* reloc.c: Add s12z relocations.
	(bfd_get_reloc_size): Handle size 5 relocs.
	* targets.c: Add s12z_elf32_vec.

opcodes	* Makefile.am: Add support for s12z architecture.
	* configure.ac: Likewise.
	* disassemble.c: Likewise.
	* disassemble.h: Likewise.
	* Makefile.in: Regenerate.
	* configure: Regenerate.
	* s12z-dis.c: New file.
	* s12z.h: New file.

include	* elf/s12z.h: New header.

ld	* Makefile.am: Add support for s12z architecture.
	* configure.tgt: Likewise.
	* Makefile.in: Regenerate.
	* emulparams/m9s12zelf.sh: New file.
	* scripttempl/elfm9s12z.sc: New file.
	* testsuite/ld-discard/static.d: Expect to fail for the s12z
	target.
	* testsuite/ld-elf/endsym.d: Likewise.
	* testsuite/ld-elf/merge.d: Likewise.
	* testsuite/ld-elf/pr14926.d: Skip for the s12z target.
	* testsuite/ld-elf/sec64k.exp: Likewise.
	* testsuite/ld-s12z: New directory.
	* testsuite/ld-s12z/opr-linking.d: New file.
	* testsuite/ld-s12z/opr-linking.s: New file.
	* testsuite/ld-s12z/relative-linking.d: New file.
	* testsuite/ld-s12z/relative-linking.s: New file.
	* testsuite/ld-s12z/z12s.exp: New file.

gas	* Makefile.am: Add support for s12z target.
	* Makefile.in: Regenerate.
	* NEWS: Mention the new support.
	* config/tc-s12z.c: New file.
	* config/tc-s12z.h: New file.
	* configure.tgt: Add  s12z support.
	* doc/Makefile.am: Likewise.
	* doc/Makefile.in: Regenerate.
	* doc/all.texi: Add s12z documentation.
	* doc/as.textinfo: Likewise.
	* doc/c-s12z.texi: New file.
	* testsuite/gas/s12z: New directory.
	* testsuite/gas/s12z/abs.d: New file.
	* testsuite/gas/s12z/abs.s: New file.
	* testsuite/gas/s12z/adc-imm.d: New file.
	* testsuite/gas/s12z/adc-imm.s: New file.
	* testsuite/gas/s12z/adc-opr.d: New file.
	* testsuite/gas/s12z/adc-opr.s: New file.
	* testsuite/gas/s12z/add-imm.d: New file.
	* testsuite/gas/s12z/add-imm.s: New file.
	* testsuite/gas/s12z/add-opr.d: New file.
	* testsuite/gas/s12z/add-opr.s: New file.
	* testsuite/gas/s12z/and-imm.d: New file.
	* testsuite/gas/s12z/and-imm.s: New file.
	* testsuite/gas/s12z/and-opr.d: New file.
	* testsuite/gas/s12z/and-opr.s: New file.
	* testsuite/gas/s12z/and-or-cc.d: New file.
	* testsuite/gas/s12z/and-or-cc.s: New file.
	* testsuite/gas/s12z/bfext-special.d: New file.
	* testsuite/gas/s12z/bfext-special.s: New file.
	* testsuite/gas/s12z/bfext.d: New file.
	* testsuite/gas/s12z/bfext.s: New file.
	* testsuite/gas/s12z/bit-manip.d: New file.
	* testsuite/gas/s12z/bit-manip.s: New file.
	* testsuite/gas/s12z/bit.d: New file.
	* testsuite/gas/s12z/bit.s: New file.
	* testsuite/gas/s12z/bra-expression-defined.d: New file.
	* testsuite/gas/s12z/bra-expression-defined.s: New file.
	* testsuite/gas/s12z/bra-expression-undef.d: New file.
	* testsuite/gas/s12z/bra-expression-undef.s: New file.
	* testsuite/gas/s12z/bra.d: New file.
	* testsuite/gas/s12z/bra.s: New file.
	* testsuite/gas/s12z/brclr-symbols.d: New file.
	* testsuite/gas/s12z/brclr-symbols.s: New file.
	* testsuite/gas/s12z/brset-clr-opr-imm-rel.d: New file.
	* testsuite/gas/s12z/brset-clr-opr-imm-rel.s: New file.
	* testsuite/gas/s12z/brset-clr-opr-reg-rel.d: New file.
	* testsuite/gas/s12z/brset-clr-opr-reg-rel.s: New file.
	* testsuite/gas/s12z/brset-clr-reg-imm-rel.d: New file.
	* testsuite/gas/s12z/brset-clr-reg-imm-rel.s: New file.
	* testsuite/gas/s12z/brset-clr-reg-reg-rel.d: New file.
	* testsuite/gas/s12z/brset-clr-reg-reg-rel.s: New file.
	* testsuite/gas/s12z/clb.d: New file.
	* testsuite/gas/s12z/clb.s: New file.
	* testsuite/gas/s12z/clr-opr.d: New file.
	* testsuite/gas/s12z/clr-opr.s: New file.
	* testsuite/gas/s12z/clr.d: New file.
	* testsuite/gas/s12z/clr.s: New file.
	* testsuite/gas/s12z/cmp-imm.d: New file.
	* testsuite/gas/s12z/cmp-imm.s: New file.
	* testsuite/gas/s12z/cmp-opr-inc.d: New file.
	* testsuite/gas/s12z/cmp-opr-inc.s: New file.
	* testsuite/gas/s12z/cmp-opr-rdirect.d: New file.
	* testsuite/gas/s12z/cmp-opr-rdirect.s: New file.
	* testsuite/gas/s12z/cmp-opr-reg.d: New file.
	* testsuite/gas/s12z/cmp-opr-reg.s: New file.
	* testsuite/gas/s12z/cmp-opr-rindirect.d: New file.
	* testsuite/gas/s12z/cmp-opr-rindirect.s: New file.
	* testsuite/gas/s12z/cmp-opr-sxe4.d: New file.
	* testsuite/gas/s12z/cmp-opr-sxe4.s: New file.
	* testsuite/gas/s12z/cmp-opr-xys.d: New file.
	* testsuite/gas/s12z/cmp-opr-xys.s: New file.
	* testsuite/gas/s12z/cmp-s-imm.d: New file.
	* testsuite/gas/s12z/cmp-s-imm.s: New file.
	* testsuite/gas/s12z/cmp-s-opr.d: New file.
	* testsuite/gas/s12z/cmp-s-opr.s: New file.
	* testsuite/gas/s12z/cmp-xy.d: New file.
	* testsuite/gas/s12z/cmp-xy.s: New file.
	* testsuite/gas/s12z/com-opr.d: New file.
	* testsuite/gas/s12z/com-opr.s: New file.
	* testsuite/gas/s12z/complex-shifts.d: New file.
	* testsuite/gas/s12z/complex-shifts.s: New file.
	* testsuite/gas/s12z/db-tb-cc-opr.d: New file.
	* testsuite/gas/s12z/db-tb-cc-opr.s: New file.
	* testsuite/gas/s12z/db-tb-cc-reg.d: New file.
	* testsuite/gas/s12z/db-tb-cc-reg.s: New file.
	* testsuite/gas/s12z/dbCC.d: New file.
	* testsuite/gas/s12z/dbCC.s: New file.
	* testsuite/gas/s12z/dec-opr.d: New file.
	* testsuite/gas/s12z/dec-opr.s: New file.
	* testsuite/gas/s12z/dec.d: New file.
	* testsuite/gas/s12z/dec.s: New file.
	* testsuite/gas/s12z/div.d: New file.
	* testsuite/gas/s12z/div.s: New file.
	* testsuite/gas/s12z/eor.d: New file.
	* testsuite/gas/s12z/eor.s: New file.
	* testsuite/gas/s12z/exg.d: New file.
	* testsuite/gas/s12z/exg.s: New file.
	* testsuite/gas/s12z/ext24-ld-xy.d: New file.
	* testsuite/gas/s12z/ext24-ld-xy.s: New file.
	* testsuite/gas/s12z/inc-opr.d: New file.
	* testsuite/gas/s12z/inc-opr.s: New file.
	* testsuite/gas/s12z/inc.d: New file.
	* testsuite/gas/s12z/inc.s: New file.
	* testsuite/gas/s12z/inh.d: New file.
	* testsuite/gas/s12z/inh.s: New file.
	* testsuite/gas/s12z/jmp.d: New file.
	* testsuite/gas/s12z/jmp.s: New file.
	* testsuite/gas/s12z/jsr.d: New file.
	* testsuite/gas/s12z/jsr.s: New file.
	* testsuite/gas/s12z/ld-imm-page2.d: New file.
	* testsuite/gas/s12z/ld-imm-page2.s: New file.
	* testsuite/gas/s12z/ld-imm.d: New file.
	* testsuite/gas/s12z/ld-imm.s: New file.
	* testsuite/gas/s12z/ld-immu18.d: New file.
	* testsuite/gas/s12z/ld-immu18.s: New file.
	* testsuite/gas/s12z/ld-large-direct.d: New file.
	* testsuite/gas/s12z/ld-large-direct.s: New file.
	* testsuite/gas/s12z/ld-opr.d: New file.
	* testsuite/gas/s12z/ld-opr.s: New file.
	* testsuite/gas/s12z/ld-s-opr.d: New file.
	* testsuite/gas/s12z/ld-s-opr.s: New file.
	* testsuite/gas/s12z/ld-small-direct.d: New file.
	* testsuite/gas/s12z/ld-small-direct.s: New file.
	* testsuite/gas/s12z/lea-immu18.d: New file.
	* testsuite/gas/s12z/lea-immu18.s: New file.
	* testsuite/gas/s12z/lea.d: New file.
	* testsuite/gas/s12z/lea.s: New file.
	* testsuite/gas/s12z/mac.d: New file.
	* testsuite/gas/s12z/mac.s: New file.
	* testsuite/gas/s12z/min-max.d: New file.
	* testsuite/gas/s12z/min-max.s: New file.
	* testsuite/gas/s12z/mod.d: New file.
	* testsuite/gas/s12z/mod.s: New file.
	* testsuite/gas/s12z/mov.d: New file.
	* testsuite/gas/s12z/mov.s: New file.
	* testsuite/gas/s12z/mul-imm.d: New file.
	* testsuite/gas/s12z/mul-imm.s: New file.
	* testsuite/gas/s12z/mul-opr-opr.d: New file.
	* testsuite/gas/s12z/mul-opr-opr.s: New file.
	* testsuite/gas/s12z/mul-opr.d: New file.
	* testsuite/gas/s12z/mul-opr.s: New file.
	* testsuite/gas/s12z/mul-reg.d: New file.
	* testsuite/gas/s12z/mul-reg.s: New file.
	* testsuite/gas/s12z/mul.d: New file.
	* testsuite/gas/s12z/mul.s: New file.
	* testsuite/gas/s12z/neg-opr.d: New file.
	* testsuite/gas/s12z/neg-opr.s: New file.
	* testsuite/gas/s12z/not-so-simple-shifts.d: New file.
	* testsuite/gas/s12z/not-so-simple-shifts.s: New file.
	* testsuite/gas/s12z/opr-18u.d: New file.
	* testsuite/gas/s12z/opr-18u.s: New file.
	* testsuite/gas/s12z/opr-expr.d: New file.
	* testsuite/gas/s12z/opr-expr.s: New file.
	* testsuite/gas/s12z/opr-ext-18.d: New file.
	* testsuite/gas/s12z/opr-ext-18.s: New file.
	* testsuite/gas/s12z/opr-idx-24-reg.d: New file.
	* testsuite/gas/s12z/opr-idx-24-reg.s: New file.
	* testsuite/gas/s12z/opr-idx3-reg.d: New file.
	* testsuite/gas/s12z/opr-idx3-reg.s: New file.
	* testsuite/gas/s12z/opr-idx3-xysp-24.d: New file.
	* testsuite/gas/s12z/opr-idx3-xysp-24.s: New file.
	* testsuite/gas/s12z/opr-indirect-expr.d: New file.
	* testsuite/gas/s12z/opr-indirect-expr.s: New file.
	* testsuite/gas/s12z/opr-symbol.d: New file.
	* testsuite/gas/s12z/opr-symbol.s: New file.
	* testsuite/gas/s12z/or-imm.d: New file.
	* testsuite/gas/s12z/or-imm.s: New file.
	* testsuite/gas/s12z/or-opr.d: New file.
	* testsuite/gas/s12z/or-opr.s: New file.
	* testsuite/gas/s12z/p2-mul.d: New file.
	* testsuite/gas/s12z/p2-mul.s: New file.
	* testsuite/gas/s12z/page2-inh.d: New file.
	* testsuite/gas/s12z/page2-inh.s: New file.
	* testsuite/gas/s12z/psh-pul.d: New file.
	* testsuite/gas/s12z/psh-pul.s: New file.
	* testsuite/gas/s12z/qmul.d: New file.
	* testsuite/gas/s12z/qmul.s: New file.
	* testsuite/gas/s12z/rotate.d: New file.
	* testsuite/gas/s12z/rotate.s: New file.
	* testsuite/gas/s12z/s12z.exp: New file.
	* testsuite/gas/s12z/sat.d: New file.
	* testsuite/gas/s12z/sat.s: New file.
	* testsuite/gas/s12z/sbc-imm.d: New file.
	* testsuite/gas/s12z/sbc-imm.s: New file.
	* testsuite/gas/s12z/sbc-opr.d: New file.
	* testsuite/gas/s12z/sbc-opr.s: New file.
	* testsuite/gas/s12z/shift.d: New file.
	* testsuite/gas/s12z/shift.s: New file.
	* testsuite/gas/s12z/simple-shift.d: New file.
	* testsuite/gas/s12z/simple-shift.s: New file.
	* testsuite/gas/s12z/single-ops.d: New file.
	* testsuite/gas/s12z/single-ops.s: New file.
	* testsuite/gas/s12z/specd6.d: New file.
	* testsuite/gas/s12z/specd6.s: New file.
	* testsuite/gas/s12z/st-large-direct.d: New file.
	* testsuite/gas/s12z/st-large-direct.s: New file.
	* testsuite/gas/s12z/st-opr.d: New file.
	* testsuite/gas/s12z/st-opr.s: New file.
	* testsuite/gas/s12z/st-s-opr.d: New file.
	* testsuite/gas/s12z/st-s-opr.s: New file.
	* testsuite/gas/s12z/st-small-direct.d: New file.
	* testsuite/gas/s12z/st-small-direct.s: New file.
	* testsuite/gas/s12z/st-xy.d: New file.
	* testsuite/gas/s12z/st-xy.s: New file.
	* testsuite/gas/s12z/sub-imm.d: New file.
	* testsuite/gas/s12z/sub-imm.s: New file.
	* testsuite/gas/s12z/sub-opr.d: New file.
	* testsuite/gas/s12z/sub-opr.s: New file.
	* testsuite/gas/s12z/tfr.d: New file.
	* testsuite/gas/s12z/tfr.s: New file.
	* testsuite/gas/s12z/trap.d: New file.
	* testsuite/gas/s12z/trap.s: New file.

binutils* readelf.c: Add support for s12z architecture.
	* testsuite/lib/binutils-common.exp (is_elf_format): Excluse s12z
	targets.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Show padding in ptype/o output
@ 2018-05-18 20:15 sergiodj+buildbot
  2018-07-15  9:44 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-18 20:15 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ce1e8424c69793139ec8d2a60c4a21ab136ae9e0 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: ce1e8424c69793139ec8d2a60c4a21ab136ae9e0

Show padding in ptype/o output

I was recently using ptype/o to look at the layout of some objects in
gdb.  I noticed that trailing padding was not shown -- but I wanted to
be able to look at that, too.

This patch changes ptype/o to also print trailing holes.

Tested on x86-64 Fedora 26.

gdb/ChangeLog
2018-05-18  Tom Tromey  <tom@tromey.com>

	* c-typeprint.c (maybe_print_hole): New function.
	(c_print_type_struct_field_offset): Update.
	(c_type_print_base_struct_union): Call maybe_print_hole.

gdb/testsuite/ChangeLog
2018-05-18  Tom Tromey  <tom@tromey.com>

	* gdb.base/ptype-offsets.exp: Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] format_pieces-selftests.c: Silence ARI warnings
@ 2018-05-18 22:33 sergiodj+buildbot
  2018-07-15 20:06 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-18 22:33 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1d143c36eedc0f0b124e6aa6fb3b98b1e6ff74b0 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 1d143c36eedc0f0b124e6aa6fb3b98b1e6ff74b0

format_pieces-selftests.c: Silence ARI warnings

Silence this:

unittests/format_pieces-selftests.c:51: warning: code: Do not use printf("%ll"), instead use printf("%s",phex()) to dump a `long long' value
unittests/format_pieces-selftests.c:56: warning: code: Do not use printf("%ll"), instead use printf("%s",phex()) to dump a `long long' value

gdb/ChangeLog:

	* unittests/format_pieces-selftests.c (test_format_specifier):
	Add ARI comments.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove mapped_index::total_size
@ 2018-05-18 23:56 sergiodj+buildbot
  2018-07-17 10:30 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-18 23:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d3d02dee8d33ef46ed91b3e87ea1b377b14ec845 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: d3d02dee8d33ef46ed91b3e87ea1b377b14ec845

Remove mapped_index::total_size

It is unused.

gdb/ChangeLog:

	* dwarf2read.c (mapped_index) <total_size>: Remove.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use new to allocate mapped_index
@ 2018-05-19  1:31 sergiodj+buildbot
  2018-07-20  0:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-19  1:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3063847f29cb83bae0cdf018c2dca68b65a50780 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 3063847f29cb83bae0cdf018c2dca68b65a50780

Use new to allocate mapped_index

This changes struct mapped_index to be allocated with new.  This
simplifies the creation a bit (see dwarf2_read_index) and also removes
a somewhat ugly explicit destructor call from ~dwarf2_per_objfile.

Tested by the buildbot.

gdb/ChangeLog
2018-05-18  Tom Tromey  <tom@tromey.com>

	* dwarf2read.c (dwarf2_per_objfile): Update.
	(struct mapped_index): Add initializers.
	(dwarf2_read_index): Use new.
	(dw2_symtab_iter_init): Update.
	* dwarf2read.h (struct dwarf2_per_objfile) <index_table>: Now a
	unique_ptr.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Allocate dwp_file with new
@ 2018-05-19  1:41 sergiodj+buildbot
  2018-07-22  0:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-19  1:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 400174b12a46fffbfad7c2504c33bb3ac29f3ef9 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 400174b12a46fffbfad7c2504c33bb3ac29f3ef9

Allocate dwp_file with new

This adds a constructor and initializer to dwp_file and changes it to
be allocated with "new".  This removes a bit of manual refcount
management.

Tested by the buildbot.

gdb/ChangeLog
2018-05-18  Tom Tromey  <tom@tromey.com>

	* dwarf2read.h (struct dwarf2_per_objfile) <dwp_file>: Now a
	unique_ptr.
	* dwarf2read.c (struct dwp_file): Add constructor and
	initializers.
	(open_and_init_dwp_file): Return a unique_ptr.
	(dwarf2_per_objfile, create_dwp_hash_table)
	(create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2)
	(lookup_dwo_unit_in_dwp): Update.
	(open_and_init_dwp_file, get_dwp_file): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] RISC-V: Add RV32E support.
@ 2018-05-19  2:16 sergiodj+buildbot
  2018-07-22 16:42 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-19  2:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7f99954970001cfc1b155d877ac2966d77e2c647 ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 7f99954970001cfc1b155d877ac2966d77e2c647

RISC-V: Add RV32E support.

	Kito Cheng  <kito.cheng@gmail.com>
	Monk Chiang  <sh.chiang04@gmail.com>

	bfd/
	* elfnn-riscv.c (_bfd_riscv_elf_merge_private_bfd_data): Handle
	EF_RISCV_RVE.

	binutils/
	* readelf.c (get_machine_flags): Handle EF_RISCV_RVE.

	gas/
	* config/tc-riscv.c (rve_abi): New.
	(riscv_set_options): Add rve field.  Initialize it.
	(riscv_set_rve) New function.
	(riscv_set_arch): Support 'e' ISA subset.
	(reg_lookup_internal): If rve, check register is available.
	(riscv_set_abi): New parameter rve.
	(md_parse_option): Pass new argument to riscv_set_abi.
	(riscv_after_parse_args): Call riscv_set_rve.  If rve_abi, set
	EF_RISCV_RVE.
	* doc/c-riscv.texi (-mabi): Document new ilp32e argument.

	include/
	* elf/riscv.h (EF_RISCV_RVE): New define.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Allocate dwz_file with new
@ 2018-05-19  3:06 sergiodj+buildbot
  2018-07-24 13:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-19  3:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7ff8cb8c51adec9cd1b461f9b670223d01223fef ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 7ff8cb8c51adec9cd1b461f9b670223d01223fef

Allocate dwz_file with new

This adds a constructor to struct dwz_file and arranges for it to be
allocated with "new" and wrapped in a unique_ptr.  This cuts down on
the amount of manual memory management that must be done.

Regression tested by the buildbot.

gdb/ChangeLog
2018-05-18  Tom Tromey  <tom@tromey.com>

	* dwarf2read.c (struct dwz_file): Add constructor, initializers.
	<dwz_bfd>: Now a gdb_bfd_ref_ptr.
	(~dwarf2_per_objfile): Update
	(dwarf2_get_dwz_file): Use new.
	* dwarf2read.h (struct dwarf2_per_objfile) <dwz_file>: Now a
	unique_ptr.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86: Don't set eh->local_ref to 1 for versioned symbol
@ 2018-05-19  3:50 sergiodj+buildbot
  2018-07-25 21:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-19  3:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 97373b2eba6077d5059370a95931b93a8b118813 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 97373b2eba6077d5059370a95931b93a8b118813

x86: Don't set eh->local_ref to 1 for versioned symbol

bfd_hide_sym_by_version can't be used to check if a versioned symbol is
hidden.  It has to be synced with _bfd_elf_link_assign_sym_version to
get the correct answer.

bfd/

	PR ld/23194
	* elfxx-x86.c (_bfd_x86_elf_link_symbol_references_local): Don't
	set eh->local_ref to 1 if a symbol is versioned and there is a
	version script.

ld/

	PR ld/23194
	* testsuite/ld-i386/i386.exp: Run pr23194.
	* testsuite/ld-x86-64/x86-64.exp: Likewise.
	* testsuite/ld-i386/pr23194.d: New file.
	* testsuite/ld-i386/pr23194.map: Likewise.
	* testsuite/ld-i386/pr23194.s: Likewise.
	* testsuite/ld-x86-64/pr23194.d: Likewise.
	* testsuite/ld-x86-64/pr23194.map: Likewise.
	* testsuite/ld-x86-64/pr23194.s: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] RISC-V: Fix ld-elf/pr22269* testcases.
@ 2018-05-19  6:14 sergiodj+buildbot
  2018-07-19 10:22 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-19  6:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6487709f3fca687ba1420b6487db5cd1e7cf8cde ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 6487709f3fca687ba1420b6487db5cd1e7cf8cde

RISC-V: Fix ld-elf/pr22269* testcases.

	bfd/
	* elfnn-riscv.c (allocate_dynrelocs): Discard dynamic relocations if
	UNDEFWEAK_NO_DYNAMIC_RELOC is true.
	(riscv_elf_relocate_section): Don't generate dynamic relocation if
	UNDEFWEAK_NO_DYNAMIC_RELOC is true.
	(riscv_elf_finish_dynamic_symbol): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix reference in comment: SRC_AND_LOC instead of LOC_AND_SRC
@ 2018-05-19  7:33 sergiodj+buildbot
  2018-07-26  8:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-19  7:33 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 50c65c2d60b371b8b85a804a5a71bf967ba9b355 ***

Author: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Branch: master
Commit: 50c65c2d60b371b8b85a804a5a71bf967ba9b355

Fix reference in comment: SRC_AND_LOC instead of LOC_AND_SRC

Pushed as obvious


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove useless variable int i in backtrace_command_1
@ 2018-05-20  0:37 sergiodj+buildbot
  2018-07-26 18:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-20  0:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 59f66be3aca7ef310c1d4464e93b251fe87135e0 ***

Author: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Branch: master
Commit: 59f66be3aca7ef310c1d4464e93b251fe87135e0

Remove useless variable int i in backtrace_command_1

value of int i was not used in the loop or after the loop.
Pushed as obvious.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Introduce obstack_new, poison other "typed" obstack functions
@ 2018-05-21  1:51 sergiodj+buildbot
  2018-07-27  5:00 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-21  1:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 284a0e3cbffa92ee5c94065fcdd5a528482344fc ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 284a0e3cbffa92ee5c94065fcdd5a528482344fc

Introduce obstack_new, poison other "typed" obstack functions

Since we use obstacks with objects that are not default constructible,
we sometimes need to manually call the constructor by hand using
placement new:

  foo *f = obstack_alloc (obstack, sizeof (foo));
  f = new (f) foo;

It's possible to use allocate_on_obstack instead, but there are types
that we sometimes want to allocate on an obstack, and sometimes on the
regular heap.  This patch introduces a utility to make this pattern
simpler if allocate_on_obstack is not an option:

  foo *f = obstack_new<foo> (obstack);

Right now there's only one usage (in tdesc_data_init).

To help catch places where we would forget to call new when allocating
such an object on an obstack, this patch also poisons some other methods
of allocating an instance of a type on an obstack:

  - OBSTACK_ZALLOC/OBSTACK_CALLOC
  - XOBNEW/XOBNEW
  - GDBARCH_OBSTACK_ZALLOC/GDBARCH_OBSTACK_CALLOC

Unfortunately, there's no way to catch wrong usages of obstack_alloc.

By pulling on that string though, it tripped on allocating struct
template_symbol using OBSTACK_ZALLOC.  The criterion currently used to
know whether it's safe to "malloc" an instance of a struct is whether it
is a POD.  Because it inherits from struct symbol, template_symbol is
not a POD.  This criterion is a bit too strict however, it should still
safe to allocate memory for a template_symbol and memset it to 0.  We
didn't use is_trivially_constructible as the criterion in the first
place only because it is not available in gcc < 5.  So here I considered
two alternatives:

1. Relax that criterion to use std::is_trivially_constructible and add a
   bit more glue code to make it work with gcc < 5
2. Continue pulling on the string and change how the symbol structures
   are allocated and initialized

I managed to do both, but I decided to go with #1 to keep this patch
simpler and more focused.  When building with a compiler that does not
have is_trivially_constructible, the check will just not be enforced.

gdb/ChangeLog:

	* common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Define if
	compiler supports std::is_trivially_constructible.
	* common/poison.h: Include obstack.h.
	(IsMallocable): Define to is_trivially_constructible if the
	compiler supports it, define to true_type otherwise.
	(xobnew): New.
	(XOBNEW): Redefine.
	(xobnewvec): New.
	(XOBNEWVEC): Redefine.
	* gdb_obstack.h (obstack_zalloc): New.
	(OBSTACK_ZALLOC): Redefine.
	(obstack_calloc): New.
	(OBSTACK_CALLOC): Redefine.
	(obstack_new): New.
	* gdbarch.sh: Include gdb_obstack in gdbarch.h.
	(gdbarch_obstack): New declaration in gdbarch.h, definition in
	gdbarch.c.
	(GDBARCH_OBSTACK_CALLOC, GDBARCH_OBSTACK_ZALLOC): Use
	obstack_calloc/obstack_zalloc.
	(gdbarch_obstack_zalloc): Remove.
	* target-descriptions.c (tdesc_data_init): Use obstack_new.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Initialize py_type_printers in ext_lang_type_printers
@ 2018-05-21  2:19 sergiodj+buildbot
  2018-07-06 16:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-21  2:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fe10fe3131e688d528877706db1e98e15434c0dc ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: fe10fe3131e688d528877706db1e98e15434c0dc

Initialize py_type_printers in ext_lang_type_printers

When running gdb in the build directory without passing
--data-directory, I noticed I could provoke a crash by:

    $ ./gdb -nx ./gdb
    (gdb) ptype/o struct dwarf2_per_objfile

... and then trying to "q" out at the pagination prompt.

valgrind complained about an uninitialized use of py_type_printers.
Initializing this member fixes the bug.

I believe this bug can occur even when the gdb Python libraries are
available, for example if get_type_recognizers fails.

Tested by hand on x86-64 Fedora 26.  No test case because it seemed
difficult to guarantee failures.

gdb/ChangeLog
2018-05-17  Tom Tromey  <tom@tromey.com>

	* extension.h (struct ext_lang_type_printers) <py_type_printers>:
	Initialize.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use XOBNEW/XOBNEWVEC/OBSTACK_ZALLOC when possible
@ 2018-05-21  3:56 sergiodj+buildbot
  2018-07-27 15:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-21  3:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e39db4db7c553ae1c4aaf158cd0ebf3cf6d478fb ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: e39db4db7c553ae1c4aaf158cd0ebf3cf6d478fb

Use XOBNEW/XOBNEWVEC/OBSTACK_ZALLOC when possible

Since XOBNEW/XOBNEWVEC/OBSTACK_ZALLOC are now poisoned to prevent using
them with non-trivially-constructible objects, it is worth using them
over plain obstack_alloc.  This patch changes the locations I could find
where we can do that change easily.

gdb/ChangeLog:

	* ada-lang.c (cache_symbol): Use XOBNEW and/or XOBNEWVEC and/or
	OBSTACK_ZALLOC.
	* dwarf2-frame.c (dwarf2_build_frame_info): Likewise.
	* hppa-tdep.c (hppa_init_objfile_priv_data): Likewise.
	* mdebugread.c (mdebug_build_psymtabs): Likewise.
	(add_pending): Likewise.
	(parse_symbol): Likewise.
	(parse_partial_symbols): Likewise.
	(psymtab_to_symtab_1): Likewise.
	(new_psymtab): Likewise.
	(elfmdebug_build_psymtabs): Likewise.
	* minsyms.c (terminate_minimal_symbol_table): Likewise.
	* objfiles.c (get_objfile_bfd_data): Likewise.
	(objfile_register_static_link): Likewise.
	* psymtab.c (allocate_psymtab): Likewise.
	* stabsread.c (read_member_functions): Likewise.
	* xcoffread.c (xcoff_end_psymtab): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix copy-pasto, allocate objfile_per_bfd_storage with obstack_new
@ 2018-05-21  3:57 sergiodj+buildbot
  2018-07-28  1:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-21  3:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 184cde7552b5434196b8380be23b39ff4a5a17e6 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 184cde7552b5434196b8380be23b39ff4a5a17e6

Fix copy-pasto, allocate objfile_per_bfd_storage with obstack_new

I realized after pushing that I made a copy-pasto, I had:

  # define HAVE_IS_TRIVIALLY_COPYABLE 1

instead of

  # define HAVE_IS_TRIVIALLY_CONSTRUCTIBLE 1

with the consequence that IsMallocable was always std::true_type (and
was therefore not enforcing anything).  Fixing that mistake triggered a
build failure:

/home/simark/src/binutils-gdb/gdb/objfiles.c:150:12:   required from here
/home/simark/src/binutils-gdb/gdb/common/poison.h:228:3: error: static assertion failed: Trying to use XOBNEW with a non-POD data type.

I am not sure why I did not see this when I originally wrote the patch
(but I saw and fixed other failures).  In any case, I swapped XOBNEW
with obstack_new to get rid of it.

Regtested on the buildbot.

gdb/ChangeLog:

	* common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Rename the wrong
	instance to...
	(HAVE_IS_TRIVIALLY_CONSTRUCTIBLE): ... this.
	* objfiles.c (get_objfile_bfd_data): Allocate
	objfile_per_bfd_storage with obstack_new when allocating on
	obstack.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use std::unique_ptr in dwarf2_read_debug_names
@ 2018-05-21 16:43 sergiodj+buildbot
  2018-07-28 13:06 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-21 16:43 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 22ca247e9e29c11ccfc99b5d187c7dc925608b78 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 22ca247e9e29c11ccfc99b5d187c7dc925608b78

Use std::unique_ptr in dwarf2_read_debug_names

This changes dwarf2_read_debug_names to use std::unique_ptr from the
outset.  This simplifies the code that installs the resulting map into
dwarf2_per_objfile.

Tested by the buildbot.

ChangeLog
2018-05-21  Tom Tromey  <tom@tromey.com>

	* dwarf2read.c (dwarf2_read_debug_names): Use std::unique_ptr.
	(mapped_index_base): Use DISABLE_COPY_AND_ASSIGN.  Default
	constructor.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use std::string in reread_symbols
@ 2018-05-21 17:46 sergiodj+buildbot
  2018-07-28 23:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-21 17:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c0c9f665d9d4cdcef59cc7951396d843a7ea6a48 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: c0c9f665d9d4cdcef59cc7951396d843a7ea6a48

Use std::string in reread_symbols

This removes a cleanup from reread_symbols by using std::string.  This
fixes a memory leak, because this cleanup is ordinarily discarded, not
run.

Tested by the buildbot.

ChangeLog
2018-05-21  Tom Tromey  <tom@tromey.com>

	* symfile.c (reread_symbols): Use std::string for original_name.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove a cleanup from trace_dump_actions
@ 2018-05-21 18:16 sergiodj+buildbot
  2018-07-29  9:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-21 18:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 15b6611c69f6fdb7a20cd50d33d9acf8c5c32037 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 15b6611c69f6fdb7a20cd50d33d9acf8c5c32037

Remove a cleanup from trace_dump_actions

This changes trace_dump_actions to use std::string, removing a
cleanup.

Tested by the buildbot.

ChangeLog
2018-05-21  Tom Tromey  <tom@tromey.com>

	* tracepoint.c (trace_dump_actions): Use std::string.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove cleanup from ada-lang.c
@ 2018-05-21 18:22 sergiodj+buildbot
  2018-07-29 20:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-21 18:22 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6f46ac8531ead61003c96b8e2fa6a383ea8d8c58 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 6f46ac8531ead61003c96b8e2fa6a383ea8d8c58

Remove cleanup from ada-lang.c

This removes a cleanup from ada-lang.c by having
ada_exception_message_1 return a unique_xmalloc_ptr.

ChangeLog
2018-05-21  Tom Tromey  <tom@tromey.com>

	* ada-lang.c (ada_exception_message_1, ada_exception_message):
	Return unique_xmalloc_ptr.
	(print_it_exception): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove cleanup from ada_collect_symbol_completion_matches
@ 2018-05-21 18:46 sergiodj+buildbot
  2018-07-30  6:27 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-21 18:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 790217f6736cc0f0a177a681ba1c7cc5f995cfe7 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 790217f6736cc0f0a177a681ba1c7cc5f995cfe7

Remove cleanup from ada_collect_symbol_completion_matches

ada_collect_symbol_completion_matches installs a null_cleanup but not
any other cleanups.  This patch removes it.

ChangeLog
2018-05-21  Tom Tromey  <tom@tromey.com>

	* ada-lang.c (ada_collect_symbol_completion_matches): Remove
	cleanup.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Change ada_catchpoint::excep_string to be a std::string
@ 2018-05-21 20:19 sergiodj+buildbot
  2018-07-30 16:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-21 20:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bc18fbb575437dd10089ef4619e46c0b9a93097d ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: bc18fbb575437dd10089ef4619e46c0b9a93097d

Change ada_catchpoint::excep_string to be a std::string

This changes ada_catchpoint::excep_string to be a std::string and then
fixes up all t he users.

This found a memory leak in catch_ada_exception_command_split, where
"cond" was copied but never freed.

I changed the type of the "cond_string" argument to
catch_ada_exception_command_split to follow the rule that out
parameters should be pointers and not references.

This patch enables the removal of some cleanups and also the function
ada_get_next_arg.

ChangeLog
2018-05-21  Tom Tromey  <tom@tromey.com>

	* mi/mi-cmd-catch.c (mi_cmd_catch_assert)
	(mi_cmd_catch_exception, mi_cmd_catch_handlers): Update.
	* ada-lang.h (create_ada_exception_catchpoint): Update.
	* ada-lang.c (struct ada_catchpoint) <excep_string>: Now a
	std::string.
	(create_excep_cond_exprs, ~ada_catchpoint)
	(should_stop_exception, print_one_exception)
	(print_mention_exception, print_recreate_exception): Update.
	(ada_get_next_arg): Remove.
	(catch_ada_exception_command_split): Use std::string.  Change type
	of "excep_string", "cond_string".
	(catch_ada_exception_command): Update.
	(create_ada_exception_catchpoint): Change type of excep_string.
	(ada_exception_sal): Remove excep_string parameter.
	(~ada_catchpoint): Remove.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove output_command_const
@ 2018-05-21 20:25 sergiodj+buildbot
  2018-07-31 12:35 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-21 20:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 122b53ea6a99c8811fb9cb84869b949b1ac55b22 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 122b53ea6a99c8811fb9cb84869b949b1ac55b22

Remove output_command_const

I happened to notice that output_command_const still exists, but is
not needed any more -- commands are always const-correct now.  This
patch removes this leftover.

2018-05-21  Tom Tromey  <tom@tromey.com>

	* printcmd.c (output_command): Remove.
	(output_command_const): Rename to output_command.
	* valprint.h (output_command): Rename from output_command_const.
	* tracepoint.c (trace_dump_actions): Call output_command.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove fake operand handling for extended mnemonics.
@ 2018-05-22  0:14 sergiodj+buildbot
  2018-08-02  3:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-22  0:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 98553ad33eba6353b0e4181ae51dfdf2d7e652ac ***

Author: Peter Bergner <bergner@vnet.ibm.com>
Branch: master
Commit: 98553ad33eba6353b0e4181ae51dfdf2d7e652ac

Remove fake operand handling for extended mnemonics.

opcodes/
	* ppc-opc.c (insert_bat, extract_bat, insert_bba, extract_bba,
	insert_rbs, extract_rbs, insert_xb6s, extract_xb6s): Delete functions.
	(insert_bab, extract_bab, insert_btab, extract_btab,
	insert_rsb, extract_rsb, insert_xab6, extract_xab6): New functions.
	(BAT, BBA VBA RBS XB6S): Delete macros.
	(BTAB, BAB, VAB, RAB, RSB, XAB6): New macros.
	(BB, BD, RBX, XC6): Update for new macros.
	(powerpc_opcodes) <evmr, evnot, vmr, vnot, crnot, crclr, crset,
	crmove, not, not., mr, mr., xxspltd, xxswapd, xvmovsp, xvmovdp,
	e_crnot, e_crclr, e_crset, e_crmove>: Likewise.
	* ppc-dis.c (print_insn_powerpc): Delete handling of fake operands.

include/
	* opcode/ppc.h (PPC_OPERAND_FAKE): Delete macro.

gas/
	* config/tc-ppc.c (md_assemble): Delete handling of fake operands.
	* testsuite/gas/ppc/common.s (crmove, cror, or., or, nor., nor): Add
	test of extended mnemonics.
	* testsuite/gas/ppc/common.d: Likewise.  Don't match instruction offset.
	* testsuite/gas/ppc/spe.s (evor, evnor): Add test of extended mnemonics.
	* testsuite/gas/ppc/spe.d: Likewise.  Don't match instruction offset.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] MIPS/gdbserver: Fix issues with $zero register reads
@ 2018-05-22  0:40 sergiodj+buildbot
  2018-08-02 13:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-22  0:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e4439e4346ec0d2cb0e65b497d26382e1054c93b ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: e4439e4346ec0d2cb0e65b497d26382e1054c93b

MIPS/gdbserver: Fix issues with $zero register reads

Consistently supply hardwired $zero as a zeroed register, correcting
issues with the PTRACE_GETREGS path that currently copies the value of
$restart into $zero as illustrated by this program:

$ cat read.c

int
main (void)
{
  char buf[1024];
  ssize_t size;

  size = read (0, buf, sizeof (buf));

  return size;
}
$

and this corresponding debug session:

(gdb) break main
Breakpoint 1 at 0x120000970: file read.c, line 9.
(gdb) target remote :2346
Remote debugging using :2346
Reading symbols from .../sysroot/mips-r2-hard/lib64/ld.so.1...done.
0x000000fff7fca5a0 in __start ()
   from .../sysroot/mips-r2-hard/lib64/ld.so.1
(gdb) continue
Continuing.

Breakpoint 1, main () at read.c:9
9	  size = read (0, buf, sizeof (buf));
(gdb) info registers
                  zero               at               v0               v1
 R0   0000000000000000 0000000000000001 000000fff7ffe710 0000000000000000
                    a0               a1               a2               a3
 R4   0000000000000001 000000ffffffeb88 000000ffffffeb98 0000000000000000
                    a4               a5               a6               a7
 R8   000000fff7fc8800 000000fff7fc38f0 000000ffffffeb80 2f2f2f2f2f2f2f2f
                    t0               t1               t2               t3
 R12  0000000000000437 0000000000000002 000000fff7ffd000 0000000120000a00
                    s0               s1               s2               s3
 R16  000000fff7fc7068 0000000120000b90 0000000000000000 0000000000000000
                    s4               s5               s6               s7
 R20  0000000000521d88 0000000000522608 0000000000000000 0000000000000000
                    t8               t9               k0               k1
 R24  0000000000000000 0000000120000970 0000000000000000 0000000000000000
                    gp               sp               s8               ra
 R28  000000fff7fc8800 000000ffffffea50 0000000000000000 000000fff7e4088c
                status               lo               hi         badvaddr
      0000000000109cf3 0000000000005ea5 0000000000000211 000000fff7eadf00
                 cause               pc
      0000000000800024 0000000120000970
                  fcsr              fir          restart
              00000000         00f30000 0000000000000000
(gdb) continue
Continuing.
^C

Program received signal SIGINT, Interrupt.
0x000000fff7f084ac in __GI___libc_read (fd=0, buf=0xffffffe640, nbytes=1024)
    at ../sysdeps/unix/sysv/linux/read.c:27
27	  return SYSCALL_CANCEL (read, fd, buf, nbytes);
(gdb) info registers
                  zero               at               v0               v1
 R0   0000000000001388 0000000000000001 0000000000000200 000000fff7ffe710
                    a0               a1               a2               a3
 R4   0000000000000000 000000ffffffe640 0000000000000400 0000000000000001
                    a4               a5               a6               a7
 R8   000000fff7fc8800 000000fff7fc38f0 000000ffffffeb80 2f2f2f2f2f2f2f2f
                    t0               t1               t2               t3
 R12  00000000000005e3 0000000000000002 000000fff7ffd000 000000012000099c
                    s0               s1               s2               s3
 R16  000000fff7fc7068 0000000120000b90 0000000000000000 0000000000000000
                    s4               s5               s6               s7
 R20  0000000000521d88 0000000000522608 0000000000000000 0000000000000000
                    t8               t9               k0               k1
 R24  0000000000000000 000000fff7f2da20 0000000000000000 0000000000000000
                    gp               sp               s8               ra
 R28  000000fff7fc8800 000000ffffffe600 0000000000000000 000000012000099c
                status               lo               hi         badvaddr
      0000000000109cf3 00000000000001e6 00000000000000be 000000fff7f08470
                 cause               pc
      0000000000800020 000000fff7f084ac
                  fcsr              fir          restart
              00000000         00f30000 0000000000001388
(gdb)

and with the PTRACE_PEEKUSR path that does not supply this register at
all, causing issues analogous to ones addressed for the native MIPS
backend with commit 4e6ff0e1b86f ("MIPS/Linux/native: Supply $zero for
the !PTRACE_GETREGS case"):

(gdb) info registers
                  zero               at               v0               v1
 R0      <unavailable> 0000000000000001 0000000000000001 0000000000000000
                    a0               a1               a2               a3
 R4   00000001200212b0 0000000000000000 0000000000000021 000000012001a260
                    a4               a5               a6               a7
 R8   000000012001a260 0000000000000004 800000010cab1680 fffffffffffffff8
                    t0               t1               t2               t3
 R12  0000000000000000 000000fff7edab68 0000000000000001 0000000000000000
                    s0               s1               s2               s3
 R16  000000fff7ee2068 0000000120008b80 0000000000000000 0000000000000000
                    s4               s5               s6               s7
 R20  000000000052e5c8 000000000052f008 0000000000000000 0000000000000000
                    t8               t9               k0               k1
 R24  0000000000000000 00000001200027c0 0000000000000000 0000000000000000
                    gp               sp               s8               ra
 R28  00000001200212b0 000000ffffffc880 000000ffffffc880 0000000120005ee8
                status               lo               hi         badvaddr
         <unavailable> 0000000000943efe 000000000000000e 000000012001a008
                 cause               pc
      0000000000800024 0000000120005ee8
                  fcsr              fir          restart
              0e800000         00f30000 0000000000000000
(gdb)

and (under certain circumstances):

(gdb) next
Register 0 is not available
(gdb)

The problem with PTRACE_GETREGS happens because `mips_store_gregset'
supplies the contents of register slot #0, occupied by $restart, to
$zero.  The problem with PTRACE_PEEKUSR happens because for $zero
`mips_cannot_fetch_register' returns one, and no alternative way to
supply that register has been defined.

Correct `mips_store_gregset' then for the PTRACE_GETREGS case and add
`mips_fetch_register' for the PTRACE_PEEKUSR case.

	gdb/gdbserver/
	* linux-mips-low.c (mips_fetch_register): New function.  Update
	preceding comment.
	(mips_store_gregset): Supply 0 rather than $restart for $zero.
	(the_low_target): Wire `mips_fetch_register'.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] MIPS/Linux: Disable n32 USR `ptrace' accesses to 64-bit registers
@ 2018-05-22  1:57 sergiodj+buildbot
  2018-08-03  3:22 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-22  1:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 75d74ccace05f6166a45dbaa352abf753891d3be ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 75d74ccace05f6166a45dbaa352abf753891d3be

MIPS/Linux: Disable n32 USR `ptrace' accesses to 64-bit registers

On the MIPS target DSP ASE registers can only be accessed with the
PTRACE_PEEKUSR and PTRACE_POKEUSR `ptrace' requests.  With the n32 ABI
these requests only pass 32-bit data quantities, which are narrower than
the width of DSP accumulator registers, which are 64-bit.

Generic code is prepared to transfer registers wider than the `ptrace'
data type by offsetting into the USR address space, by the data width
transferred.  That however does not work with the MIPS target, because
of how the API has been defined, where USR register addresses are
actually indices rather than offsets.  Consequently given address `a'
using `a + 4' accesses the fourth next register rather than the upper
half of the original register.

With native debugging this causes clobbered register contents, as well
as access failures as locations beyond the available USR space are
addressed:

(gdb) info registers
                  zero               at               v0               v1
 R0   0000000000000000 0000000000000001 0000000000000001 0000000000000000
                    a0               a1               a2               a3
 R4   0000000010019158 0000000000000000 0000000000000011 0000000010019160
                    a4               a5               a6               a7
 R8   0000000010019160 fffffffffff00000 fffffffffffffff8 0000000000000000
                    t0               t1               t2               t3
 R12  0000000010019150 0000000000000001 0000000000000001 000000000000000f
                    s0               s1               s2               s3
 R16  0000000077ee6f20 0000000010007bb0 0000000000000000 0000000000000000
                    s4               s5               s6               s7
 R20  000000000052e668 000000000052f008 0000000000000000 0000000000000000
                    t8               t9               k0               k1
 R24  0000000000000001 0000000010019010 0000000000000000 0000000000000000
                    gp               sp               s8               ra
 R28  0000000010020280 000000007fff4c10 000000007fff4c10 0000000010004f48
                status               lo               hi         badvaddr
      0000000000109cf3 0000000000943efe 000000000000000e 000000001001900c
                 cause               pc
      0000000000800024 0000000010004f48
                  fcsr              fir              hi1              lo1
              0e800000         00f30000 0000000004040404 0101010105050505
                   hi2              lo2              hi3              lo3
      0202020255aa33cc Couldn't read register  (#75): Input/output error.
(gdb)

With `gdbserver' this makes debugging impossible due to a fatal failure:

(gdb) target remote :2346
Remote debugging using :2346
Reading symbols from .../sysroot/mips-r2-hard/lib32/ld.so.1...done.
0x77fc3d50 in __start () from .../sysroot/mips-r2-hard/lib32/ld.so.1
(gdb) continue
Continuing.
warning: Remote failure reply: E01
Remote communication error.  Target disconnected.: Connection reset by peer.
(gdb)

Correct the problem by marking any register in the MIPS backend whose
width exceeds the width of the `ptrace' data type unavailable for the
purpose of PTRACE_PEEKUSR and PTRACE_POKEUSR requests:

(gdb) info registers
                  zero               at               v0               v1
 R0   0000000000000000 0000000000000001 0000000000000001 0000000000000000
                    a0               a1               a2               a3
 R4   0000000010019158 0000000000000000 0000000000000011 0000000010019160
                    a4               a5               a6               a7
 R8   0000000010019160 fffffffffff00000 fffffffffffffff8 0000000000000000
                    t0               t1               t2               t3
 R12  0000000010019150 0000000000000001 0000000000000001 000000000000000f
                    s0               s1               s2               s3
 R16  0000000077ee6f20 0000000010007bb0 0000000000000000 0000000000000000
                    s4               s5               s6               s7
 R20  000000000052e5c8 000000000052f008 0000000000000000 0000000000000000
                    t8               t9               k0               k1
 R24  0000000000000001 0000000010019010 0000000000000000 0000000000000000
                    gp               sp               s8               ra
 R28  0000000010020280 000000007fff4be0 000000007fff4be0 0000000010004f48
                status               lo               hi         badvaddr
      0000000000109cf3 0000000000943efe 000000000000000e 000000001001900c
                 cause               pc
      0000000000800024 0000000010004f48
                  fcsr              fir              hi1              lo1
              0e800000         00f30000    <unavailable>    <unavailable>
                   hi2              lo2              hi3              lo3
         <unavailable>    <unavailable>    <unavailable>    <unavailable>
                dspctl          restart
              55aa33cc 0000000000000000
(gdb)

as there is no way to access full contents of these registers with the
limited API available anyway.

This obviously does not affect general-purpose registers (which use the
PTRACE_GETREGS and PTRACE_SETREGS requests for access) or floating-point
general registers (which use PTRACE_GETFPREGS and PTRACE_SETFPREGS).
And $dspctl, being 32-bit, remains accessible too, which is important
for BPOSGE32 branch decoding in single-stepping.

For DSP accumulator access with the n32 ABI a new `ptrace' API is required
on the kernel side.

	gdb/
	* mips-linux-nat.c (mips64_linux_register_addr): Return -1 if
	the width of the requested register exceeds the width of the
	`ptrace' data type.

	gdb/gdbserver/
	* linux-mips-low.c (mips_cannot_fetch_register): Return 1 if the
	width of the requested register exceeds the width of the
	`ptrace' data type.
	(mips_cannot_store_register): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Mark section in a section group with SHF_GROUP
@ 2018-05-22  4:05 sergiodj+buildbot
  2018-08-03 20:00 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-22  4:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bae363f1146378207e1dffe5f23845644a1d0b7a ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: bae363f1146378207e1dffe5f23845644a1d0b7a

Mark section in a section group with SHF_GROUP

All sections in a section group should be marked with SHF_GROUP.  But
some tools generate broken objects without SHF_GROUP.  This patch fixes
them up for objcopy and strip.

	PR binutils/23199
	* elf.c (setup_group): Mark section in a section group with
	SHF_GROUP.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] ld: Hide symbols defined by HIDDEN/PROVIDE_HIDDEN
@ 2018-05-22  4:46 sergiodj+buildbot
  2018-08-04  6:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-22  4:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 34a87bb07a4a3b2202fc25167a6b0f12575edc87 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 34a87bb07a4a3b2202fc25167a6b0f12575edc87

ld: Hide symbols defined by HIDDEN/PROVIDE_HIDDEN

There should be no difference in output for symbols defined by HIDDEN
or PROVIDE_HIDDEN assignments whether they are explicitly marked as
hidden or not.  This patch adds a new BFD function, bfd_link_hide_symbol,
to hide symbols defined by HIDDEN and PROVIDE_HIDDEN assignments.

bfd

	PR ld/23201
	* aout-target.h (MY_bfd_link_hide_symbol): New.
	* aout-tic30.c (MY_bfd_link_hide_symbol): Likewise.
	* binary.c (binary_bfd_link_hide_symbol): Likewise.
	* coff-alpha.c (_bfd_ecoff_bfd_link_hide_symbol): Likewise.
	* coff-mips.c (_bfd_ecoff_bfd_link_hide_symbol): Likewise.
	* coff-rs6000.c (_bfd_xcoff_bfd_link_hide_symbol): Likewise.
	* coffcode.h (coff_bfd_link_hide_symbol): Likewise.
	* elf-bfd.h (_bfd_elf_link_hide_symbol): Likewise.
	* elfxx-target.h (bfd_elfNN_bfd_link_hide_symbol): Likewise.
	* i386msdos.c (msdos_bfd_link_hide_symbol): Likewise.
	* ihex.c (ihex_bfd_link_hide_symbol): Likewise.
	* libbfd-in.h (_bfd_nolink_bfd_link_hide_symbol): Likewise.
	* linker.c (_bfd_generic_link_hide_symbol): Likewise.
	(bfd_link_hide_symbol): Likewise.
	* mach-o-target.c (bfd_mach_o_bfd_link_hide_symbol): Likewise.
	* mmo.c (mmo_bfd_link_hide_symbol): Likewise.
	* pef.c (bfd_pef_bfd_link_hide_symbol): Likewise.
	* plugin.c (bfd_plugin_bfd_link_hide_symbol): Likewise.
	* ppcboot.c (ppcboot_bfd_link_hide_symbol): Likewise.
	* som.c (som_bfd_link_hide_symbol): Likewise.
	* srec.c (srec_bfd_link_hide_symbol): Likewise.
	* tekhex.c (tekhex_bfd_link_hide_symbol): Likewise.
	* vms-alpha.c (vms_bfd_link_hide_symbol): Likewise.
	(alpha_vms_bfd_link_hide_symbol): Likewise.
	* xsym.c (bfd_sym_bfd_link_hide_symbol): Likewise.
	* coff64-rs6000.c (rs6000_xcoff64_vec): Add
	_bfd_generic_link_hide_symbol.
	(rs6000_xcoff64_aix_vec): Likewise.
	* elflink.c (bfd_elf_record_link_assignment): Don't make forced
	local symbol dynamic.
	(_bfd_elf_link_hide_symbol): New function.
	* elfxx-x86.c (_bfd_x86_elf_link_symbol_references_local): Don't
	check root.ldscript_def.
	* targets.c (bfd_target): Add _bfd_link_hide_symbol.
	(BFD_JUMP_TABLE_LINK): Add NAME##_bfd_link_hide_symbol.
	* bfd-in2.h: Regenerated.
	* libbfd.h: Likewise.

ld/

	PR ld/23201
	* ldexp.c (exp_fold_tree_1): Call bfd_link_hide_symbol to hide
	a symbol.
	* testsuite/ld-elf/provide-hidden-dynabs.nd: Removed.
	* testsuite/ld-elf/provide-hidden-dynsec.nd: Likewise.
	* testsuite/ld-elf/provide-hidden.exp: Replace
	provide-hidden-dynsec.nd with provide-hidden-sec.nd and
	provide-hidden-dyn.nd.  Replace provide-hidden-dynabs.nd with
	provide-hidden-abs.nd and provide-hidden-dyn.nd.
	* testsuite/ld-i386/pr23189.d: Expect no dynamic relocation.
	* testsuite/ld-x86-64/pr23189.d: Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PR23207, hppa ld SIGSEGVs on invalid object files
@ 2018-05-22  6:36 sergiodj+buildbot
  2018-08-04 16:43 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-22  6:36 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7455c018e45766ab7193cbd45f98f781e0dc7d84 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 7455c018e45766ab7193cbd45f98f781e0dc7d84

PR23207, hppa ld SIGSEGVs on invalid object files

We don't create PLT call stubs for anything in non-alloc sections,
so it doesn't pay to go looking for them.  The problem is that
non-alloc sections aren't processed by group_sections and thus don't
get a link_sec set up for them.

	PR 23207
	* elf32-hppa.c (final_link_relocate): Don't look for plt call
	stubs in non-alloc sections.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PR23207, hppa ld SIGSEGVs on invalid object files
@ 2018-05-22 11:00 sergiodj+buildbot
  2018-08-05  9:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-22 11:00 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 215f527155ea776fff3f2f836d5da1e300e8c370 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 215f527155ea776fff3f2f836d5da1e300e8c370

PR23207, hppa ld SIGSEGVs on invalid object files

The last patch was enough to cure the testcase, but not the original
object file.  This patch does the same for hppa as is done for ppc64,
simply test for the section belonging to a group.  I've also
restricted stubs to load, alloc, code sections.

	PR 23207
	* elf32-hppa.c (hppa_get_stub_entry): Return NULL when link_sec
	is NULL.
	(elf32_hppa_size_stubs): Only create stubs for load, alloc, code
	sections.
	(final_link_relocate): Revert last change.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] fix "stale cleanup" internal-warning when using "catch assert" command
@ 2018-05-22 15:04 sergiodj+buildbot
  2018-08-05 22:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-22 15:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 241db429d5735ae8875e38991c82204b310c2ff5 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 241db429d5735ae8875e38991c82204b310c2ff5

fix "stale cleanup" internal-warning when using "catch assert" command

Trying to insert a catchpoint on all Ada assertions now triggers
the following internal warning regardless of the situation. For
instance, not even debugging any program:

    (gdb) catch assert
    /[...]/gdb/common/cleanups.c:264: internal-warning:
    restore_my_cleanups has found a stale cleanup

This is due to a small bug in the following C++-ification commit:

    commit bc18fbb575437dd10089ef4619e46c0b9a93097d
    Author: Tom Tromey <tom@tromey.com>
    Date:   Fri May 18 15:58:50 2018 -0600
    Subject: Change ada_catchpoint::excep_string to be a std::string

The stale cleanup in question is the following one in top.c:execute_command:

    cleanup_if_error = make_bpstat_clear_actions_cleanup ();

This cleanup is expected to be discarded if there are no exception.
There were no GDB exception; however, a C++ exception was triggered,
because we passed NULL as the excep_string argument when calling
create_ada_exception_catchpoint, which is a reference to a const
string. So we get a C++ exception during the std::string constructor,
which propagates up, causing the cleanup to unexpectedly remain
in the cleanup chain.

This patch fixes the immediate issue of the incorrect call to
create_ada_exception_catchpoint.

gdb/ChangeLog:

        * ada-lang.c (catch_assert_command): Pass empty string instead
        of NULL for excep_string argument.

Tested on x86_64-linux, fixes the following failures:

  * catch_assert_if.exp: insert catchpoint on failed assertions with condition
  * catch_ex.exp: insert catchpoint on failed assertions

This also fixes about a dozen UNRESOLVED tests that are a consequence
of the two tests above failing and crashing GDB.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [PowerPC] Consolidate linux target description selection
@ 2018-05-22 15:57 sergiodj+buildbot
  2018-08-06  9:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-22 15:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bd64614eb737096f40b976fb505ddd42e7f1614c ***

Author: Pedro Franco de Carvalho <pedromfc@linux.vnet.ibm.com>
Branch: master
Commit: bd64614eb737096f40b976fb505ddd42e7f1614c

[PowerPC] Consolidate linux target description selection

Share target description declarations and selection among ppc linux
native targets, core files, gdbserver and IPA.

To avoid complicated define guards, gdbserver and IPA now have
declarations for all descriptions, including 64-bit generated
descriptions when compiled in 32-bit mode. These have always been
linked into the gdbserver and IPA binaries. Because they might be
uninitialized, the selection function checks that the selected
description is initialized.

gdb/ChangeLog:
2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>

	* arch/ppc-linux-common.c: New file.
	* arch/ppc-linux-common.h: New file.
	* arch/ppc-linux-tdesc.h: New file.
	* configure.tgt (powerpc*-*-linux*): Add arch/ppc-linux-common.o.
	* Makefile.in (ALL_TARGET_OBS): Add arch/ppc-linux-common.o.
	(HFILES_NO_SRCDIR): Add arch/ppc-linux-common.h and
	arch/ppc-linux-tdesc.h.
	* ppc-linux-nat.c: Include arch/ppc-linux-common.h and
	arch/ppc-linux-tdesc.h.
	(ppc_linux_nat_target::read_description): Remove target
	description matching code. Fill a ppc_linux_features struct and
	call ppc_linux_match_description with it. Move comment about ISA
	2.05 to ppc-linux-common.c.
	* ppc-linux-tdep.c: Include arch/ppc-linux-common.h and
	arch/ppc-linux-tdesc.h.
	(ppc_linux_core_read_description): Remove target description
	matching code. Fill a ppc_linux_features struct and call
	ppc_linux_match_description with it.
	* ppc-linux-tdep.h (tdesc_powerpc_32l, tdesc_powerpc_64l)
	(tdesc_powerpc_altivec32l, tdesc_powerpc_altivec64l)
	(tdesc_powerpc_cell32l, tdesc_powerpc_cell64l)
	(tdesc_powerpc_vsx32l, tdesc_powerpc_vsx64l)
	(tdesc_powerpc_isa205_32l, tdesc_powerpc_isa205_64l)
	(tdesc_powerpc_isa205_altivec32l, tdesc_powerpc_isa205_altivec64l)
	(tdesc_powerpc_isa205_vsx32l, tdesc_powerpc_isa205_vsx64l)
	(tdesc_powerpc_e500l): Remove.

gdb/gdbserver/ChangeLog:
2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>

	* configure.srv (srv_tgtobj): Add arch/ppc-linux-common.o.
	* Makefile.in (SFILES): Add arch/ppc-linux-common.c.
	* linux-ppc-tdesc.h: Rename to linux-ppc-tdesc-init.h.
	* linux-ppc-tdesc-init.h (tdesc_powerpc_32l, tdesc_powerpc_64l)
	(tdesc_powerpc_altivec32l, tdesc_powerpc_altivec64l)
	(tdesc_powerpc_cell32l, tdesc_powerpc_cell64l)
	(tdesc_powerpc_vsx32l, tdesc_powerpc_vsx64l)
	(tdesc_powerpc_isa205_32l, tdesc_powerpc_isa205_64l)
	(tdesc_powerpc_isa205_altivec32l, tdesc_powerpc_isa205_altivec64l)
	(tdesc_powerpc_isa205_vsx32l, tdesc_powerpc_isa205_vsx64l)
	(tdesc_powerpc_e500l): Remove.
	* linux-ppc-ipa.c: Include arch/ppc-linux-tdesc.h and
	linux-ppc-tdesc-init.h. Don't include linux-ppc-tdesc.h.
	* linux-ppc-low.c: Include arch/ppc-linux-common.h,
	arch/ppc-linux-tdesc.h, and linux-ppc-tdesc-init.h. Don't include
	linux-ppc-tdesc.h.
	(ppc_arch_setup): Remove target description matching code. Fill a
	ppc_linux_features struct and call ppc_linux_match_description
	with it.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [PowerPC] Disable regsets using zero sizes in gdbserver
@ 2018-05-22 16:47 sergiodj+buildbot
  2018-08-07  6:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-22 16:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7273b5fc4baef93f8caaed678476e8cb3625338d ***

Author: Pedro Franco de Carvalho <pedromfc@linux.vnet.ibm.com>
Branch: master
Commit: 7273b5fc4baef93f8caaed678476e8cb3625338d

[PowerPC] Disable regsets using zero sizes in gdbserver

Currently the linux-ppc-low.c fill/store functions for extended
regsets check whether they should execute by using the global hwcap
variable.

This patch explicitly sets the regset sizes to zero when needed to
disable them instead, so that the fill/store functions are not called
in the first place by regsets_fetch_inferior_registers in linux-low.c.

gdb/gdbserver/ChangeLog:
2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>

	* linux-ppc-low.c (ppc_fill_vsxregset): Remove ppc_hwcap check.
	(ppc_store_vsxregset): Likewise.
	(ppc_fill_vrregset): Likewise.
	(ppc_store_vrregset): Likewise.
	(ppc_fill_evrregset): Likewise.
	(ppc_store_evrregset): Likewise.
	(ppc_regsets): Set VSX/VR/EVR regset sizes to 0.
	(ppc_arch_setup): Iterate through ppc_regsets and set sizes when
	needed.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [PowerPC] Consolidate linux vector regset sizes
@ 2018-05-22 17:02 sergiodj+buildbot
  2018-08-07 16:39 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-22 17:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d078308a2ed1290e587b4365e2d7382d951a26af ***

Author: Pedro Franco de Carvalho <pedromfc@linux.vnet.ibm.com>
Branch: master
Commit: d078308a2ed1290e587b4365e2d7382d951a26af

[PowerPC] Consolidate linux vector regset sizes

This patch defines constants for the sizes of the two vector
regsets (vector-scalar registers and regular vector registers).

The native, gdbserver and core file targets are changed to use these
constants.

The Linux ptrace calls return (or read) a smaller regset than the one
found in core files for vector registers, because ptrace uses a single
4-byte quantity for vrsave at the end of the regset, while the
core-file regset uses a full 16-byte field for vrsave. For simplicity,
the larger size is used in both cases, and so a buffer with 12 unused
additional bytes is passed to ptrace in the native target.

gdb/ChangeLog:
2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>

	* arch/ppc-linux-common.h (PPC_LINUX_SIZEOF_VRREGSET)
	(PPC_LINUX_SIZEOF_VSXREGSET): Define.
	* ppc-linux-nat.c (SIZEOF_VSXREGS, SIZEOF_VRREGS): Remove.
	(gdb_vrregset_t): Change array type size to
	PPC_LINUX_SIZEOF_VRREGSET.
	(gdb_vsxregset_t): Change array type size to
	PPC_LINUX_SIZEOF_VSXREGSET.
	* ppc-linux-tdep.c (ppc_linux_iterate_over_regset_sections):
	Change integer literals to PPC_LINUX_SIZEOF_VRREGSET and
	PPC_LINUX_SIZEOF_VSXREGSET.

gdb/gdbserver/ChangeLog:
2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>

	* linux-ppc-low.c (SIZEOF_VSXREGS, SIZEOF_VRREGS): Remove.
	(ppc_arch_setup): Change SIZEOF_VRREGS and SIZEOF_VSXREGS to
	PPC_LINUX_SIZEOF_VRREGSET and PPC_LINUX_SIZEOF_VSXREGSET.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [PowerPC] Consolidate wordsize getter between native and gdbserver
@ 2018-05-22 17:26 sergiodj+buildbot
  2018-08-06 19:42 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-22 17:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2e077f5e67aeff78e096a250bd225cd4658a35dc ***

Author: Pedro Franco de Carvalho <pedromfc@linux.vnet.ibm.com>
Branch: master
Commit: 2e077f5e67aeff78e096a250bd225cd4658a35dc

[PowerPC] Consolidate wordsize getter between native and gdbserver

This patch moves the native target wordsize getter for ppc linux to
nat/ so that it can be used to simplify ppc_arch_setup in
gdbserver. The ptrace call used to get MSR for this is ultimately the
same as before, but it is no longer necessary to create a temporary
regcache to call fetch_inferior_registers.

gdb/ChangeLog:
2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>

	* configure.nat <linux powerpc>: Add ppc-linux.o to NATDEPFILES.
	* ppc-linux-nat.c (ppc_linux_target_wordsize): Move to
	nat/ppc-linux.c.
	(ppc_linux_nat_target::auxv_parse): Get thread id tid. Call
	ppc_linux_target_wordsize with tid.
	(ppc_linux_nat_target::read_description): Call ppc_linux_target
	wordsize with tid.
	* nat/ppc-linux.c: Include nat/gdb_ptrace.h.
	(ppc64_64bit_inferior_p): Add static and inline specifiers.
	(ppc_linux_target_wordsize): Move here from ppc-linux-nat.c. Add
	tid parameter. Remove static specifier.
	* nat/ppc-linux.h (ppc64_64bit_inferior_p): Remove declaration.
	(ppc_linux_target_wordsize): New declaration.

gdb/gdbserver/ChangeLog:
2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>

	* linux-ppc-low.c (ppc_arch_setup): Remove code for getting the
	wordsize of the inferior. Call ppc_linux_target_wordsize.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [PowerPC] Fix access to VSCR in linux targets
@ 2018-05-22 17:34 sergiodj+buildbot
  2018-08-08 21:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-22 17:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1d75a65809b49d41e97518b99c551a4bb2517500 ***

Author: Pedro Franco de Carvalho <pedromfc@linux.vnet.ibm.com>
Branch: master
Commit: 1d75a65809b49d41e97518b99c551a4bb2517500

[PowerPC] Fix access to VSCR in linux targets

The 4-byte VSCR register is found inside a 16-byte field in the regset
returned by ptrace and in core files. The position of VSCR depends on
the endianess of the target, which was previously assumed to be
big-endian for the purpose of getting VSCR. This patch removes this
assumption to fix access to VSCR in little-endian mode.

gdb/ChangeLog:
2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>

	* ppc-tdep.h (struct ppc_reg_offsets): Remove vector register
	offset fields.
	* ppc-fbsd-tdep.c (ppc32_fbsd_reg_offsets): Remove initializers
	for vector register offset fields.
	(ppc64_fbsd_reg_offsets): Likewise.
	* ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
	to vector register offset fields.
	* ppc-obsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
	to vector register offset fields.
	* ppc-obsd-nat.c (_initialize_ppcobsd_nat): Remove assignment to
	vector register offset fields.
	* rs6000-aix-tdep.c (rs6000_aix32_reg_offsets): Remove
	initializers for vector register offset fields.
	(rs6000_aix64_reg_offsets): Likewise.
	* rs6000-tdep.c (ppc_vrreg_offset): Remove.
	(ppc_supply_vrregset): Remove.
	(ppc_collect_vrregset): Remove.
	* ppc-linux-tdep.c (ppc_linux_collect_vrregset): New function.
	(ppc_linux_vrregset) : New function.
	(ppc32_le_linux_vrregmap, ppc32_be_linux_vrregmap)
	(ppc32_le_linux_vrregset, ppc32_be_linux_vrregset): New globals.
	(ppc32_linux_vrregset): Remove.
	(ppc_linux_iterate_over_regset_sections): Call ppc_linux_vrregset
	and use result instead of ppc32_linux_vrregset.
	(ppc32_linux_reg_offsets): Remove initializers for vector register
	offset fields.
	(ppc64_linux_reg_offsets): Likewise.
	* ppc-linux-tdep.h (ppc_linux_vrregset): New declaration.
	* ppc-linux-nat.c: Include regset.h.
	(gdb_vrregset_t): Adjust comment to account for little-endian
	mode.
	(supply_vrregset, fill_vrregset): Remove.
	(fetch_altivec_register, store_altivec_register): Remove.
	(fetch_altivec_registers): Add regno parameter. Get regset using
	ppc_linux_vrregset. Use regset to supply registers.
	(store_altivec_registers): Add regno parameter. Get regset using
	ppc_linux_vrregset. Use regset to collect registers.
	(fetch_register): Call fetch_altivec_registers instead of
	fetch_altivec_register.
	(store_register): Call store_altivec_registers instead of
	store_altivec_register.
	(fetch_ppc_registers): Call fetch_altivec_registers with -1 for
	the new regno parameter.
	(store_ppc_registers): Call store_altivec_registers with -1 for
	the new regno parameter.

gdb/gdbserver/ChangeLog:
2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>

	* linux-ppc-low.c (ppc_fill_vrregset): Add vscr_offset variable.
	Set vscr_offset to 0 in little-endian mode and 12 in big-endian
	mode. Call collect_register_by_name with vscr using
	vscr_offset. Zero-pad vscr and vrsave fields in collector buffer.
	(ppc_store_vrregset): Add and set vscr_offset variable as in
	ppc_fill_vrregset. Call supply_register_by_name with vscr using
	vscr_offset.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [PowerPC] Fix VSX registers in linux core files
@ 2018-05-22 18:22 sergiodj+buildbot
  2018-08-10  2:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-22 18:22 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2c3305f6b0432e37d26ce7761d0c4415ab5ca911 ***

Author: Pedro Franco de Carvalho <pedromfc@linux.vnet.ibm.com>
Branch: master
Commit: 2c3305f6b0432e37d26ce7761d0c4415ab5ca911

[PowerPC] Fix VSX registers in linux core files

The functions used by the VSX regset to collect and supply registers
from core files where incorrect. This patch changes the regset to use
the standard regset collect/supply functions to fix this. The native
target is also changed to use the same regset.

gdb/ChangeLog:
2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>

	* ppc-linux-tdep.c (ppc_linux_vsxregset): New function.
	(ppc32_linux_vsxregmap): New global.
	(ppc32_linux_vsxregset): Initialize with ppc32_linux_vsxregmap,
	regcache_supply_regset, and regcache_collect_regset.
	* ppc-linux-tdep.h (ppc_linux_vsxregset): Declare.
	* ppc-linux-nat.c (supply_vsxregset, fill_vsxregset): Remove.
	(fetch_vsx_register, store_vsx_register): Remove.
	(fetch_vsx_registers): Add regno parameter. Get regset using
	ppc_linux_vsxregset. Use regset to supply registers.
	(store_vsx_registers): Add regno parameter. Get regset using
	ppc_linux_vsxregset. Use regset to collect registers.
	(fetch_register): Call fetch_vsx_registers instead of
	fetch_vsx_register.
	(store_register): Call store_vsx_registers instead of
	store_vsx_register.
	(fetch_ppc_registers): Call fetch_vsx_registers with -1 for the
	new regno parameter.
	(store_ppc_registers): Call store_vsx_registers with -1 for the
	new regno parameter.
	* rs6000-tdep.c (ppc_vsx_support_p, ppc_supply_vsxreget)
	(ppc_collect_vsxregset): Remove.

gdb/testsuite/ChangeLog:
2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>

	* gdb.arch/powerpc-vsx-gcore.exp: New file.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [PowerPC] Fix inclusion of dfp pseudoregs in tdep
@ 2018-05-22 19:13 sergiodj+buildbot
  2018-08-10 13:13 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-22 19:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0fb2aaa15e04238644471f7d89be3667784b19c0 ***

Author: Pedro Franco de Carvalho <pedromfc@linux.vnet.ibm.com>
Branch: master
Commit: 0fb2aaa15e04238644471f7d89be3667784b19c0

[PowerPC] Fix inclusion of dfp pseudoregs in tdep

Previously, decimal floating point pseudoregisters were always included
in the target if it had a floating point unit.

This patch changes this to only include them if the target description
indicates that they are present, i.e. if the FPSCR register has more
than 32 bits.

gdb/ChangeLog:
2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>

	* rs6000-tdep.c (rs6000_gdbarch_init): Assign 1 to have_dfp only
	if the size of fpscr is larger than 32 bits.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] [PowerPC] Recognize isa205 in linux core files
@ 2018-05-22 19:25 sergiodj+buildbot
  2018-08-11  8:59 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-22 19:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0ec848ad25bb77edd9c9c3c097c3dd5b8874a6c0 ***

Author: Pedro Franco de Carvalho <pedromfc@linux.vnet.ibm.com>
Branch: master
Commit: 0ec848ad25bb77edd9c9c3c097c3dd5b8874a6c0

[PowerPC] Recognize isa205 in linux core files

Currently the ppc linux core file target doesn't return target
descriptions with the lager FPSCR introduced in isa205.

This patch changes the core file target so that the auxv is read from
the core file to determine the size of FPSCR, so that the appropriate
target description is selected.

gdb/ChangeLog:
2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>

	* arch/ppc-linux-common.c (ppc_linux_has_isa205): Change the
	parameter type to CORE_ADDR.
	* arch/ppc-linux-common.h (ppc_linux_has_isa205): Change the
	parameter type in declaration to CORE_ADDR.
	* ppc-linux-tdep.c (ppc_linux_core_read_description): Call
	target_auxv_search to get AT_HWCAP and use the result to get the
	target description.
	* ppc-linux-nat.c (ppc_linux_get_hwcap): Change the return type
	to CORE_ADDR. Remove the cast of the return value to unsigned
	long. Fix error predicate of target_auxv_search.
	(ppc_linux_nat_target::read_description): Change the type of the
	hwcap variable to CORE_ADDR.

gdb/testsuite/ChangeLog:
2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>

	* gdb.arch/powerpc-fpscr-gcore.exp: New file.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Support UTF-8 identifiers in C/C++ expressions (PR gdb/22973)
@ 2018-05-22 20:16 sergiodj+buildbot
  2018-08-12 10:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-22 20:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b1b60145aedb8adcb0b9dcf43a5ae735c2f03b51 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: b1b60145aedb8adcb0b9dcf43a5ae735c2f03b51

Support UTF-8 identifiers in C/C++ expressions (PR gdb/22973)

Factor out cp_ident_is_alpha/cp_ident_is_alnum out of
gdb/cp-name-parser.y and use it in the C/C++ expression parser too.

New test included.

gdb/ChangeLog:
2018-05-22  Pedro Alves  <palves@redhat.com>
	      <zjz@zjz.name>

	PR gdb/22973
	* c-exp.y: Include "c-support.h".
	(parse_number, c_parse_escape, lex_one_token): Use TOLOWER instead
	of tolower.  Use c_ident_is_alpha to scan names.
	* c-lang.c: Include "c-support.h".
	(convert_ucn, convert_octal, convert_hex, convert_escape): Use
	ISXDIGIT instead of isxdigit and ISDIGIT instead of isdigit.
	* c-support.h: New file, with bits factored out from ...
	* cp-name-parser.y: ... this file.
	Include "c-support.h".
	(cp_ident_is_alpha, cp_ident_is_alnum): Deleted, moved to
	c-support.h and renamed.
	(symbol_end, yylex): Adjust.

gdb/testsuite/ChangeLog:
2018-05-22  Pedro Alves  <palves@redhat.com>

	PR gdb/22973
	* gdb.base/utf8-identifiers.c: New file.
	* gdb.base/utf8-identifiers.exp: New file.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] remote: struct remote_state, use op new, fix leaks
@ 2018-05-22 21:16 sergiodj+buildbot
  2018-08-13  0:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-22 21:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT de44f5a73576b426b32b605e0d5016d4fae9b4b1 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: de44f5a73576b426b32b605e0d5016d4fae9b4b1

remote: struct remote_state, use op new, fix leaks

A bit of C++ification.  Also plugs a few leaks, since currently
nothing is freeing a few fields of remote_state.  They're now freed in
the added destructor.

gdb/ChangeLog:
2018-05-22  Pedro Alves  <palves@redhat.com>

	(struct vCont_action_support): Use bool and initialize all fields.
	(struct readahead_cache): Initialize all fields.
	(remote_state): Use bool and initialize all fields.
	(remote_state::remote_state, remote_state::~remote_state): New.
	(new_remote_state): Delete.
	(_initialize_remote): Use new to allocate remote_state.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] remote: Eliminate remote_hostio_close_cleanup
@ 2018-05-22 22:22 sergiodj+buildbot
  2018-08-13 10:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-22 22:22 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 440b7aece49b9a1e9ff4537214134c3cd06425d9 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 440b7aece49b9a1e9ff4537214134c3cd06425d9

remote: Eliminate remote_hostio_close_cleanup

gdb/ChangeLog:
2018-05-22  Pedro Alves  <palves@redhat.com>

	* remote.c (remote_hostio_close_cleanup): Delete.
	(class scoped_remote_fd): New.
	(remote_file_put, remote_file_get): Use it.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] remote: Make readahead_cache a C++ class
@ 2018-05-22 22:50 sergiodj+buildbot
  2018-08-13 21:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-22 22:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT dd194f6b36727987dc7f0d707512bd886982099c ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: dd194f6b36727987dc7f0d707512bd886982099c

remote: Make readahead_cache a C++ class

The idea here is eliminate the get_remote_state calls from within
readahead_cache_invalidate, readahead_cache_invalidate_fd,
remote_hostio_pread_from_cache by making those functions be class
methods instead.  Later on we'll have one readahead_cache instance per
remote connection, and this change makes that easier.

gdb/ChangeLog:
2018-05-22  Pedro Alves  <palves@redhat.com>

	* remote.c (struct readahead_cache) <invalidate, invalidate_fd,
	pread>: New method declarations.
	(remote_target::open_1): Adjust.
	(readahead_cache_invalidate): Rename to ...
	(readahead_cache::invalidate): ... this, and adjust to be a class
	method.
	(readahead_cache_invalidate_fd): Rename to ...
	(readahead_cache::invalidate_fd): ... this, and adjust to be a
	class method.
	(remote_hostio_pwrite): Adjust.
	(remote_hostio_pread_from_cache): Rename to ...
	(readahead_cache::pread): ... this, and adjust to be a class
	method.
	(remote_hostio_close): Adjust.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] remote: multiple remote_arch_state instances per arch
@ 2018-05-22 22:55 sergiodj+buildbot
  2018-08-14  7:28 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-22 22:55 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9d6eea31325e4027b5f035e941864fa6d780a8ca ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 9d6eea31325e4027b5f035e941864fa6d780a8ca

remote: multiple remote_arch_state instances per arch

Currently, we associate gdbarch-related remote protocol state on a
per-gdbarch data object.  Things like the size of the g/G packet, and
the max remote packet size.  If we'll support being connected to
different remote servers at the same time, then we need to cope with
each having their own packet sizes, even if they are each debugging
programs of the same architecture.  I.e., a single instance of
remote_arch_state per arch is not sufficient.

This patch moves the remote_arch_state object to a map of
gdbarch-to-remote_arch_state saved in the remote_state structure.
Usually there will only be one entry in the map, though we may see
more with stubs that support multi-process and/or archs with multiple
ABIs (e.g, one remote_arch_state for 64-bit inferiors and another for
32-bit inferiors).

gdb/ChangeLog:
2018-05-22  Pedro Alves  <palves@redhat.com>

	* remote.c: Include <unordered_map>.
	(remote_state): Now a class.
	(remote_state) <get_remote_arch_state>: Declare method.
	<get_remote_arch_state>: New field.
	(remote_arch_state) <remote_arch_state>: Declare ctor.
	<regs>: Now a unique_ptr.
	(remote_gdbarch_data_handle): Delete.
	(get_remote_arch_state): Delete.
	(remote_state::get_remote_arch_state): New.
	(get_remote_state): Adjust to call remote_state's
	get_remote_arch_state method.
	(init_remote_state): Delete, bits factored out to ...
	(remote_arch_state::remote_arch_state): ... this new method.
	(get_remote_packet_size, get_memory_packet_size)
	(process_g_packet, remote_target::fetch_registers)
	(remote_target::prepare_to_store, store_registers_using_G)
	(remote_target::store_registers, remote_target::get_trace_status):
	Adjust to call remote_state's method.
	(_initialize_remote): Remove reference to
	remote_gdbarch_data_handle.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] remote: remote_arch_state pointers -> remote_arch_state objects
@ 2018-05-22 23:27 sergiodj+buildbot
  2018-08-14 18:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-22 23:27 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 43c3a0e4735033ed2fe3a4cb65f911cee69f55ae ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 43c3a0e4735033ed2fe3a4cb65f911cee69f55ae

remote: remote_arch_state pointers -> remote_arch_state objects

The previous patch made the map store pointers to remote_arch_state
instead of objects directly, simply because struct remote_arch_state
is still incomplete where struct remote_state is declared.  This patch
thus moves the remote_arch_state declaration higher up in the file,
and makes the map store remote_arch_state objects directly instead of
pointers to objects.

gdb/ChangeLog:
2018-05-22  Pedro Alves  <palves@redhat.com>

	* remote.c (struct packet_reg, struct remote_arch_state):
	Move higher up in the file.
	(remote_state) <m_arch_states>: Store remote_arch_state values
	instead of remote_arch_state pointers.
	(remote_state::get_remote_arch_state): Adjust.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] remote: Small cleanup in compare_section_command
@ 2018-05-22 23:57 sergiodj+buildbot
  2018-08-15  4:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-22 23:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0e9a6b2f040e016c9dd7f9841a0272e488ed2fd5 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 0e9a6b2f040e016c9dd7f9841a0272e488ed2fd5

remote: Small cleanup in compare_section_command

The set_general_process call in compare_sections_command isn't
actually needed.  remote_target::verify_memory and
remote_target::xfer_partial already handle making sure the remote is
pointing at the right process or thread.

Getting this out of the way helps a bit with further elimination of
the remote_state global, because we have to handle the case of a user
invoking the command even if not connect to a remote target.

gdb/ChangeLog:
2018-05-22  Pedro Alves  <palves@redhat.com>

	* remote.c (compare_section_command): Remove set_general_process
	call.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Handle "show remote memory-write-packet-size" when not connected
@ 2018-05-23  0:48 sergiodj+buildbot
  2018-08-16  1:38 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-23  0:48 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cc0be08f80d4348e8f81471c80409710c4d4cd1a ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: cc0be08f80d4348e8f81471c80409710c4d4cd1a

Handle "show remote memory-write-packet-size" when not connected

Currently "show remote memory-write-packet-size" says that the packet
size is limited to whatever is stored in the remote_state global, even
if not connected to a target.

When we get to support multiple instances of remote targets, there
won't be a remote_state global anymore, so that must be replaced by
something else.

Since it doesn't make sense to print the limit of the packet size of a
non-existing connection, this patch makes us say that the limit will
be further reduced when we connect.

The text is taken from the command's online help, which says:

 "The actual limit is further reduced dependent on the target."

Note that a value of "0" is special, as per "help set remote
memory-write-packet-size":

 ~~~
 Specify the number of bytes in a packet or 0 (zero) for the
 default packet size.
 ~~~

I've tweaked "show remote memory-write-packet-size" to include
"(default)" in the output in that case, like this:

 (gdb) show remote memory-write-packet-size
 The memory-write-packet-size is 0 (default). The actual limit will be further reduced dependent on the target.

While working on this, I noticed that an explicit "set remote
write-packet-size 0" does not makes GDB go back to the exact same
state as the default state when GDB starts up:

 (gdb) show remote memory-write-packet-size
 The memory-write-packet-size is 0. [...]
                                 ^^

 (gdb) set remote memory-write-packet-size 0
 (gdb) show remote memory-write-packet-size
 The memory-write-packet-size is 16384. [...]
                                 ^^^^^

The "16384" number comes from DEFAULT_MAX_MEMORY_PACKET_SIZE.

This happens because git commit a5c0808e221c ("gdb: remove packet size
limit") at
<https://sourceware.org/ml/gdb-patches/2015-08/msg00743.html>, added
this:

  /* So that the query shows the correct value.  */
  if (size <= 0)
    size = DEFAULT_MAX_MEMORY_PACKET_SIZE;

to set_memory_packet_size, but despite what the comment suggests, that
also has the side-effect of recording DEFAULT_MAX_MEMORY_PACKET_SIZE
in config->size.

Finally, DEFAULT_MAX_MEMORY_PACKET_SIZE only makes sense for "set
remote memory-write-packet-size fixed", so I've renamed it
accordingly, to make it a little bit clearer.

gdb/ChangeLog:
2018-05-22  Pedro Alves  <palves@redhat.com>

	* remote.c (DEFAULT_MAX_MEMORY_PACKET_SIZE): Rename to ...
	(DEFAULT_MAX_MEMORY_PACKET_SIZE_FIXED): ... this.
	(get_fixed_memory_packet_size): New.
	(get_memory_packet_size): Use it.
	(set_memory_packet_size): Don't override the config size with
	DEFAULT_MAX_MEMORY_PACKET_SIZE.
	(show_memory_packet_size): Use get_fixed_memory_packet_size.
	Don't refer to get_memory_packet_size if not connected to a remote
	target.  Show "(default)" if configured size is 0.

gdb/testsuite/ChangeLog:
2018-05-22  Pedro Alves  <palves@redhat.com>

	* gdb.base/remote.exp: Adjust expected output of "show remote
	memory-write-packet-size".  Add tests for "set remote
	memory-write-packet-size 0" and "set remote
	memory-write-packet-size fixed/limit".


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] remote: Move discard_pending_stop_replies call
@ 2018-05-23  1:22 sergiodj+buildbot
  2018-08-15 14:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-23  1:22 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9607784ac00f9278094e962963f6271472b1dfca ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 9607784ac00f9278094e962963f6271472b1dfca

remote: Move discard_pending_stop_replies call

This helps because discard_pending_stop_replies will later become a
method of remote_target.  Otherwise, when we have multiple instances
of remote_target, we'd have to make discard_pending_stop_replies find
the inferior's target_ops, and upcast it to remote_target (if indeed a
remote) to find the pending stop replies queue to clear.

gdb/ChangeLog:
2018-05-22  Pedro Alves  <palves@redhat.com>

	* remote.c (remote_target::mourn_inferior): Move
	discard_pending_stop_replies call here from ...
	(_initialize_remote): ... here.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] remote: one struct remote_state per struct remote_target
@ 2018-05-23  1:41 sergiodj+buildbot
  2018-08-16 22:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-23  1:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6b8edb5101861228778b7c2d014e20c5ba0c156a ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 6b8edb5101861228778b7c2d014e20c5ba0c156a

remote: one struct remote_state per struct remote_target

'struct remote_state' today contains per-connection state, however
there's only a single global instance of that type.  In order to
support multiple connections, we must have one such object per
connection.

Thus this patch eliminates the 'remote_state' global in favor of
having a remote_state instance per remote_target instance.

The get_remote_state free function is eliminated as well, by making it
a remote_target method instead.

The patch then fixes the fallout by making all free functions that
refer to get_remote_state() directly or indirectly be methods of
remote_target too.

Likewise, remote-fileio.c and remote-notif.c routines are
parameterized with a remote_target pointer too, so they can call into
the right remote_target instance.

References to the global 'get_remote_state ()->remote_desc' to tell
whether the remote target is open (!= nullptr) must be replaced with
something else:

 - Command implementations use a new get_current_remote_target free
 function.

 - remote_target::open_1 checks the exception type instead.

Finally, remote_target and extended_remote_target are made
heap-allocated targets.  As with the earlier core target patches, it
still won't be possible to have more than one remote_target instance
in practice, but this puts us closer.

gdb/ChangeLog:
2018-05-22  Pedro Alves  <palves@redhat.com>

	* remote-fileio.c (remote_fileio_reply, remote_fileio_ioerror)
	(remote_fileio_badfd, remote_fileio_return_errno)
	(remote_fileio_return_success, remote_fileio_func_open)
	(remote_fileio_func_open, remote_fileio_func_close)
	(remote_fileio_func_read, remote_fileio_func_write)
	(remote_fileio_func_lseek, remote_fileio_func_rename)
	(remote_fileio_func_unlink, remote_fileio_func_stat)
	(remote_fileio_func_fstat, remote_fileio_func_gettimeofday)
	(remote_fileio_func_isatty, remote_fileio_func_system): Add
	remote_target parameter.
	(remote_fio_func_map) <func>: Add remote_target parameter.
	(do_remote_fileio_request, remote_fileio_request):
	* remote-fileio.h (remote_fileio_request):
	* remote-notif.c (remote_notif_ack, remote_notif_parse, ): Add
	remote_target parameter.
	(remote_notif_process, handle_notification): Adjust to pass down
	the remote.
	(remote_notif_state_allocate): Add remote_target parameter.  Save
	it.
	* remote-notif.h (struct remote_target): Forward declare.
	(struct notif_client) <parse, ack, can_get_pending_events>: Add
	remote_target parameter.
	(struct remote_notif_state) <remote>: New field.
	(remote_notif_ack, remote_notif_parse): Add remote_target
	parameter.
	(remote_notif_state_allocate, remote_notif_state_allocate): Add
	remote_target parameter.
	* remote.c (OPAQUETHREADBYTES, threadref, gdb_ext_thread_info)
	(threads_listing_context, rmt_thread_action, protocol_feature)
	(packet_reg, stop_reply, stop_reply_p, enum packet_support)
	(packet_result, struct threads_listing_context, remote_state):
	Move definitions and declarations higher up.
	(remote_target) <~remote_target>: Declare.
	(remote_download_command_source, remote_file_put, remote_file_get)
	(remote_file_delete, remote_hostio_pread, remote_hostio_pwrite)
	(remote_hostio_pread_vFile, remote_hostio_send_command)
	(remote_hostio_set_filesystem, remote_hostio_open)
	(remote_hostio_close, remote_hostio_unlink, remote_state)
	(get_remote_state, get_remote_packet_size, get_memory_packet_size)
	(get_memory_write_packet_size, get_memory_read_packet_size)
	(append_pending_thread_resumptions, remote_detach_1)
	(append_resumption, remote_resume_with_vcont)
	(add_current_inferior_and_thread, wait_ns, wait_as)
	(process_stop_reply, remote_notice_new_inferior)
	(process_initial_stop_replies, remote_add_thread)
	(btrace_sync_conf, remote_btrace_maybe_reopen)
	(remove_new_fork_children, kill_new_fork_children)
	(discard_pending_stop_replies, stop_reply_queue_length)
	(check_pending_events_prevent_wildcard_vcont)
	(discard_pending_stop_replies_in_queue, stop_reply)
	(remote_notif_remove_queued_reply, stop_reply *queued_stop_reply)
	(peek_stop_reply, remote_parse_stop_reply, remote_stop_ns)
	(remote_interrupt_as, remote_interrupt_ns)
	(remote_get_noisy_reply, remote_query_attached)
	(remote_add_inferior, remote_current_thread, get_current_thread)
	(set_thread, set_general_thread, set_continue_thread)
	(set_general_process, write_ptid)
	(remote_unpack_thread_info_response, remote_get_threadinfo)
	(parse_threadlist_response, remote_get_threadlist)
	(remote_threadlist_iterator, remote_get_threads_with_ql)
	(remote_get_threads_with_qxfer)
	(remote_get_threads_with_qthreadinfo, extended_remote_restart)
	(get_offsets, remote_check_symbols, remote_supported_packet)
	(remote_query_supported, remote_packet_size)
	(remote_serial_quit_handler, remote_detach_pid)
	(remote_vcont_probe, remote_resume_with_hc)
	(send_interrupt_sequence, interrupt_query)
	(remote_notif_get_pending_events, fetch_register_using_p)
	(send_g_packet, process_g_packet, fetch_registers_using_g)
	(store_register_using_P, store_registers_using_G)
	(set_remote_traceframe, check_binary_download)
	(remote_write_bytes_aux, remote_write_bytes, remote_read_bytes_1)
	(remote_xfer_live_readonly_partial, remote_read_bytes)
	(remote_send_printf, remote_flash_write, readchar)
	(remote_serial_write, putpkt, putpkt_binary, skip_frame)
	(read_frame, getpkt, getpkt_or_notif_sane_1, getpkt_sane)
	(getpkt_or_notif_sane, remote_vkill, remote_kill_k)
	(extended_remote_disable_randomization, extended_remote_run)
	(send_environment_packet, extended_remote_environment_support)
	(extended_remote_set_inferior_cwd, remote_write_qxfer)
	(remote_read_qxfer, push_stop_reply, vcont_r_supported)
	(packet_command): Now methods of ...
	(remote_target): ... this class.
	(m_remote_state) <remote_target>: New field.
	(struct remote_state) <stop_reply_queue,
	remote_async_inferior_event_token, wait_forever_enabled_p>: New
	fields.
	(remote_state::remote_state): Allocate stop_reply_queue.
	(remote_state): Delete global.
	(get_remote_state_raw): Delete.
	(remote_target::get_remote_state): Allocate m_remote_state on
	demand.
	(get_current_remote_target): New.
	(remote_ops, extended_remote_ops): Delete.
	(wait_forever_enabled_p, remote_async_inferior_event_token):
	Delete, moved to struct remote_state.
	(remote_target::close): Delete self.  Destruction bits split to
	...
	(remote_target::~remote_target): ... this.
	(show_memory_packet_size): Adjust to use
	get_current_remote_target.
	(struct protocol_feature) <func>: Add remote_target parameter.
	All callers adjusted.
	(curr_quit_handler_target): New.
	(remote_serial_quit_handler): Reimplement.
	(remote_target::open_1): Adjust to use get_current_remote_target.
	Heap-allocate remote_target/extended_remote_target instances.
	(vcont_builder::vcont_builder): Add remote_target parameter, and
	save it in m_remote.  All callers adjusted.
	(vcont_builder::m_remote): New field.
	(vcont_builder::restart, vcont_builder::flush)
	(vcont_builder::push_action): Use it.
	(remote_target::commit_resume): Use it.
	(struct queue_iter_param) <remote>: New field.
	(remote_target::remove_new_fork_children): Fill in 'remote' field.
	(check_pending_event_prevents_wildcard_vcont_callback_data): New.
	(check_pending_event_prevents_wildcard_vcont_callback)
	(remote_target::check_pending_events_prevent_wildcard_vcont)
	(remote_target::discard_pending_stop_replies)
	(remote_target::discard_pending_stop_replies_in_queue)
	(remote_target::remote_notif_remove_queued_reply): Fill in
	'remote' field.
	(remote_notif_get_pending_events): New.
	(remote_target::readchar, remote_target::remote_serial_write):
	Save/restore curr_quit_handler_target.
	(putpkt): New.
	(kill_new_fork_children): Fill in 'remote' field.
	(packet_command): Use get_current_remote_target, defer to
	remote_target method of same name.
	(scoped_remote_fd::scoped_remote_fd): Add 'remote_target'
	parameter, and save it in m_remote.  All callers adjusted.
	(scoped_remote_fd::release): Use m_remote.
	(scoped_remote_fd::m_remote): New field.
	(remote_file_put, remote_file_get, remote_file_delete): Use
	get_current_remote_target, defer to remote_target method of same
	name.
	(remote_btrace_reset): Add remote_state paremeter.  Update all
	callers.
	(remote_async_inferior_event_handler). Pass down 'data'.
	(remote_new_objfile): Use get_current_remote_target.
	(remote_target::vcont_r_supported): New.
	(set_range_stepping): Use get_current_remote_target and
	remote_target::vcont_r_supported.
	(_initialize_remote): Don't allocate 'remote_state' and
	'stop_reply_queue' globals.
	* remote.h (struct remote_target): Forward declare.
	(getpkt, putpkt, remote_notif_get_pending_events): Add
	'remote_target' parameter.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] MIPS/gdbserver: Correctly handle narrow big-endian register transfers
@ 2018-05-23  1:46 sergiodj+buildbot
  2018-08-17  8:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-23  1:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7e947ad3438b2954e0bd248fd2c95a86bd9fe33b ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 7e947ad3438b2954e0bd248fd2c95a86bd9fe33b

MIPS/gdbserver: Correctly handle narrow big-endian register transfers

Fix an issue with `gdbserver' on big-endian n64 MIPS targets, where
$dspctl is 32-bit while the `ptrace' transfer data type is 64-bit.

Such register data is held in the low order 32 bits of the 64-bit data
quantity exchanged with the buffer used by `fetch_register' and
`store_register', however `supply_register' and `collect_register'
access the same data as a 32-bit quantity.  Consequently the register is
presented and written as all-zeros held in the most-significant part of
the big-endian 64-bit data quantity represented in the buffer:

(gdb) info registers
                  zero               at               v0               v1
 R0   0000000000000000 0000000000000001 0000000000000001 0000000000000000
                    a0               a1               a2               a3
 R4   00000001200212b0 0000000000000000 0000000000000021 000000012001a260
                    a4               a5               a6               a7
 R8   000000012001a260 0000000000000004 800000010c60c000 fffffffffffffff8
                    t0               t1               t2               t3
 R12  0000000000000000 000000fff7edab68 0000000000000001 0000000000000000
                    s0               s1               s2               s3
 R16  000000fff7ee2068 0000000120008b80 0000000000000000 0000000000000000
                    s4               s5               s6               s7
 R20  000000000052e5c8 000000000052f008 0000000000000000 0000000000000000
                    t8               t9               k0               k1
 R24  0000000000000000 00000001200027c0 0000000000000000 0000000000000000
                    gp               sp               s8               ra
 R28  00000001200212b0 000000ffffffc850 000000ffffffc850 0000000120005ee8
                status               lo               hi         badvaddr
      0000000000109cf3 0000000000943efe 000000000000000e 000000012001a008
                 cause               pc
      0000000000800024 0000000120005ee8
                  fcsr              fir              hi1              lo1
              0e800000         00f30000 0000000000000000 0101010101010101
                   hi2              lo2              hi3              lo3
      0202020202020202 0303030303030303 0404040404040404 0505050505050505
                dspctl          restart
              00000000 0000000000000000
(gdb)

Correct this problem then by using the `mips_supply_register'
`mips_collect_register' accessors for 32-bit registers where the
`ptrace' data type is 64-bit.  These accessors already operate on 32-bit
data quantities held in 64-bit containers:

(gdb) info registers
                  zero               at               v0               v1
 R0   0000000000000000 0000000000000001 0000000000000001 0000000000000000
                    a0               a1               a2               a3
 R4   00000001200212b0 0000000000000000 0000000000000021 000000012001a260
                    a4               a5               a6               a7
 R8   000000012001a260 0000000000000004 800000010d82e900 fffffffffffffff8
                    t0               t1               t2               t3
 R12  0000000000000000 000000fff7edab68 0000000000000001 0000000000000000
                    s0               s1               s2               s3
 R16  000000fff7ee2068 0000000120008b80 0000000000000000 0000000000000000
                    s4               s5               s6               s7
 R20  000000000052e5c8 000000000052f008 0000000000000000 0000000000000000
                    t8               t9               k0               k1
 R24  0000000000000000 00000001200027c0 0000000000000000 0000000000000000
                    gp               sp               s8               ra
 R28  00000001200212b0 000000ffffffc850 000000ffffffc850 0000000120005ee8
                status               lo               hi         badvaddr
      0000000000109cf3 0000000000943efe 000000000000000e 000000012001a008
                 cause               pc
      0000000000800024 0000000120005ee8
                  fcsr              fir              hi1              lo1
              0e800000         00f30000 0000000000000000 0101010101010101
                   hi2              lo2              hi3              lo3
      0202020202020202 0303030303030303 0404040404040404 0505050505050505
                dspctl          restart
              55aa33cc 0000000000000000
(gdb)

	gdb/gdbserver/
	* linux-mips-low.c [HAVE_PTRACE_GETREGS] (mips_collect_register)
	(mips_supply_register): Move outside HAVE_PTRACE_GETREGS.
	(mips_collect_ptrace_register, mips_supply_ptrace_register): New
	functions.
	(the_low_target): Wire them.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb/x86: Fix `-Wstrict-overflow' build error in `i387_collect_xsave'
@ 2018-05-23  2:03 sergiodj+buildbot
  2018-08-17 19:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-23  2:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 35f1fea3fcd44546a6cf074029c284c64ad25b3c ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 35f1fea3fcd44546a6cf074029c284c64ad25b3c

gdb/x86: Fix `-Wstrict-overflow' build error in `i387_collect_xsave'

Make `i' defined within `i387_collect_xsave' unsigned, removing a
`-Werror=strict-overflow' compilation error:

.../gdb/i387-tdep.c: In function 'void i387_collect_xsave(const regcache*, int, void*, int)':
.../gdb/i387-tdep.c:1348:1: error: assuming signed overflow does not occur when assuming that (X + c) < X is always false [-Werror=strict-overflow]
 i387_collect_xsave (const struct regcache *regcache, int regnum,
 ^
cc1plus: all warnings being treated as errors
Makefile:1610: recipe for target 'i387-tdep.o' failed
make: *** [i387-tdep.o] Error 1

seen with GCC 5.4.0, a commit 8ee22052f690 ("gdb/x86: Handle kernels
using compact xsave format") regression.  While `regnum' can be -1 on
entry to the function, to mean all registers, `i' is only used with
non-negative register numbers.

	gdb/
	* i387-tdep.c (i387_collect_xsave): Make `i' unsigned.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] remote: Make vcont_builder a class
@ 2018-05-23  2:22 sergiodj+buildbot
  2018-08-16 11:59 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-23  2:22 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f5db4863f51b83bc6b54504d61e1731011cfdec2 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: f5db4863f51b83bc6b54504d61e1731011cfdec2

remote: Make vcont_builder a class

gdb/ChangeLog:
2018-05-22  Pedro Alves  <palves@redhat.com>

	* remote.c (vcont_builder): Now a class.  Make all data members
	private.
	(vcont_builder) <vcont_builder, restart, flush, push_action>:
	Declare methods.
	(vcont_builder_restart): Rename to ...
	(vcont_builder::restart): ... this.
	(vcont_builder_flush): Rename to ...
	(vcont_builder::flush): ... this.
	(vcont_builder_push_action): Rename to ...
	(vcont_builder::push_action): ... this.
	(remote_target::commit_resume): Adjust.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix gdb.base/remote.exp with native-extended-gdbserver board
@ 2018-05-23  3:06 sergiodj+buildbot
  2018-08-18  5:44 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-23  3:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 035522c0228be33b2124ada2f178187e7e53aa6c ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 035522c0228be33b2124ada2f178187e7e53aa6c

Fix gdb.base/remote.exp with native-extended-gdbserver board

This fixes gdb.base/remote.exp regressions caused by the previous
commit to the testcase, when tested with
--target_board=native-extended-gdbserver.  For example:

  ...
  show remote memory-write-packet-size
  The memory-write-packet-size is 0 (default). Packets are limited to 16383 bytes.
  (gdb) FAIL: gdb.base/remote.exp: write-packet default
  ...

With that board, GDB connects to GDBserver at gdb_start time, so GDB
is showing the actual remote/gdbserver packet size limits.

Fix it using the usual "disconnect" pattern.  While at it, there's no
need to start GDB before compiling the testcase.

gdb/testsuite/ChangeLog:
2018-05-22  Pedro Alves  <palves@redhat.com>

	* gdb.base/remote.exp: Only gdb_start after compiling the
	testcase.  Issue "disconnect" before testing "set remote" command
	defaults.  Issue clean_restart before running to main.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Improve File I/O overflow detection in gdbserver (PR server/23198)
@ 2018-05-23 13:32 sergiodj+buildbot
  2018-08-18 16:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-23 13:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 81e25b7c91efcc3ff54605b11859375a5c885c8b ***

Author: Erik Kurzinger <ekurzinger@nvidia.com>
Branch: master
Commit: 81e25b7c91efcc3ff54605b11859375a5c885c8b

Improve File I/O overflow detection in gdbserver (PR server/23198)

Currently, the function used by gdbserver to parse integers from
received File I/O commands will detect overflow and fail for any value
over 0xfffffff.  Among other things, this has the effect of limiting
the file offsets for reading or writing to about 268MB which can be
insufficient for particularly large libraries.

This change allows the parsing of integers up to the true maximum
positive value of 0x7fffffff, increasing the file size limit to about
2GB.

gdb/gdbserver/ChangeLog:
2018-05-23  Erik Kurzinger  <ekurzinger@nvidia.com>

	PR server/23198
	* hostio.c (require_int): Do not report overflow for integers
	between 0xfffffff and 0x7fffffff.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove internal_complaint
@ 2018-05-23 15:59 sergiodj+buildbot
  2018-08-19 13:53 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-23 15:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2b9496b2b4781b21bc30a70337e24205f8a923d8 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 2b9496b2b4781b21bc30a70337e24205f8a923d8

Remove internal_complaint

I happened to notice that gdb has both complaint_internal and
internal_complaint.  The latter is unused, so this patch removes it.

gdb/ChangeLog
2018-05-23  Tom Tromey  <tom@tromey.com>

	* complaints.c (internal_complaint): Remove.
	* complaints.h (internal_complaint): Remove.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove elements from complaint_series
@ 2018-05-23 16:40 sergiodj+buildbot
  2018-08-21  8:27 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-23 16:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 43ba33c7689a9eeb20a3c36ecb9867574963ee0e ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 43ba33c7689a9eeb20a3c36ecb9867574963ee0e

Remove elements from complaint_series

I couldn't find a way to get complaints to use a couple of cases, and
the difference between the actual printed output for these cases was
minimal anyway.  So, this patch removes a couple of constants from
complaint_series, plus the associated code.

gdb/ChangeLog
2018-05-23  Tom Tromey  <tom@tromey.com>

	* complaints.c (enum complaint_series): Remove FIRST_MESSAGE,
	SUBSEQUENT_MESSAGE.
	(vcomplaint, clear_complaints): Update.
	(symfile_explanations): Remove some messages.

gdb/testsuite/ChangeLog
2018-05-23  Tom Tromey  <tom@tromey.com>

	* gdb.gdb/complaints.exp (test_serial_complaints): Remove.
	(test_short_complaints): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove "noisy" parameter from clear_complaints
@ 2018-05-23 17:01 sergiodj+buildbot
  2018-08-22  0:34 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-23 17:01 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4e9668d0d1ddad73af7c20a92a00704fbea2a8d9 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 4e9668d0d1ddad73af7c20a92a00704fbea2a8d9

Remove "noisy" parameter from clear_complaints

After the previous patch, the "noisy" parameter to clear_complaints is
no longer used, so this patch removes it.

gdb/ChangeLog
2018-05-23  Tom Tromey  <tom@tromey.com>

	* complaints.c (clear_complaints): Remove "noisy" parameter.
	* complaints.h (clear_complaints): Update.
	* symfile.c (syms_from_objfile_1, finish_new_objfile)
	(reread_symbols): Update.

gdb/testsuite/ChangeLog
2018-05-23  Tom Tromey  <tom@tromey.com>

	* gdb.gdb/complaints.exp (test_empty_complaints): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove symfile_complaints
@ 2018-05-23 17:33 sergiodj+buildbot
  2018-08-22 22:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-23 17:33 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b98664d3862579c5a0d23901b1e2fc1f595f39ff ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: b98664d3862579c5a0d23901b1e2fc1f595f39ff

Remove symfile_complaints

The complaint system seems to allow for multiple different complaint
topics.  However, in practice only symfile_complaints has ever been
defined.  Seeing that complaints.c dates to 1992, and that no new
complaints have been added in the intervening years, I think it is
reasonable to admit that complaints are specifically related to
debuginfo reading.

This patch removes symfile_complaints and updates all the callers.
Some of these spots should perhaps be calls to warning instead, but I
did not make that change.

gdb/ChangeLog
2018-05-23  Tom Tromey  <tom@tromey.com>

	* complaints.c (symfile_complaints): Remove.
	(complaint_internal): Remove "complaints" parameter.
	(clear_complaints, vcomplaint): Remove "c" parameter.
	(get_complaints): Remove.
	* dwarf2read.c (dwarf2_statement_list_fits_in_line_number_section_complaint)
	(dwarf2_debug_line_missing_file_complaint)
	(dwarf2_debug_line_missing_end_sequence_complaint)
	(dwarf2_complex_location_expr_complaint)
	(dwarf2_const_value_length_mismatch_complaint)
	(dwarf2_section_buffer_overflow_complaint)
	(dwarf2_macro_malformed_definition_complaint)
	(dwarf2_invalid_attrib_class_complaint)
	(create_addrmap_from_index, dw2_symtab_iter_next)
	(dw2_expand_marked_cus)
	(dw2_debug_names_iterator::find_vec_in_debug_names)
	(dw2_debug_names_iterator::next, dw2_debug_names_iterator::next)
	(create_debug_type_hash_table, init_cutu_and_read_dies)
	(partial_die_parent_scope, add_partial_enumeration)
	(skip_one_die, fixup_go_packaging, quirk_rust_enum, process_die)
	(dwarf2_compute_name, dwarf2_physname, read_namespace_alias)
	(read_import_statement, read_file_scope, create_dwo_cu_reader)
	(create_cus_hash_table, create_dwp_hash_table)
	(inherit_abstract_dies, read_func_scope, read_call_site_scope)
	(dwarf2_rnglists_process, dwarf2_ranges_process)
	(dwarf2_add_type_defn, dwarf2_attach_fields_to_type)
	(dwarf2_add_member_fn, get_alignment, maybe_set_alignment)
	(handle_struct_member_die, process_structure_scope)
	(read_array_type, read_common_block, read_module_type)
	(read_tag_pointer_type, read_typedef, read_base_type)
	(read_subrange_type, load_partial_dies, partial_die_info::read)
	(partial_die_info::read, partial_die_info::read)
	(partial_die_info::read, read_checked_initial_length_and_offset)
	(dwarf2_string_attr, read_formatted_entries)
	(dwarf_decode_line_header)
	(lnp_state_machine::check_line_address, dwarf_decode_lines_1)
	(new_symbol, dwarf2_const_value_attr, lookup_die_type)
	(read_type_die_1, determine_prefix, dwarf2_get_ref_die_offset)
	(dwarf2_get_attr_constant_value, dwarf2_fetch_constant_bytes)
	(get_signatured_type, get_DW_AT_signature_type)
	(decode_locdesc, file_file_name, consume_improper_spaces)
	(skip_form_bytes, skip_unknown_opcode, dwarf_parse_macro_header)
	(dwarf_decode_macro_bytes, dwarf_decode_macros)
	(dwarf2_symbol_mark_computed, set_die_type)
	(read_attribute_value): Update.
	* stap-probe.c (handle_stap_probe, get_stap_base_address):
	Update.
	* dbxread.c (unknown_symtype_complaint)
	(lbrac_mismatch_complaint, repeated_header_complaint)
	(set_namestring, function_outside_compilation_unit_complaint)
	(read_dbx_symtab, process_one_symbol): Update.
	* gdbtypes.c (stub_noname_complaint): Update.
	* windows-nat.c (handle_unload_dll): Update.
	* coffread.c (coff_symtab_read, enter_linenos, decode_type)
	(decode_base_type): Update.
	* xcoffread.c (bf_notfound_complaint, ef_complaint)
	(eb_complaint, record_include_begin, record_include_end)
	(enter_line_range, xcoff_next_symbol_text, read_xcoff_symtab)
	(process_xcoff_symbol, read_symbol)
	(function_outside_compilation_unit_complaint)
	(scan_xcoff_symtab): Update.
	* machoread.c (macho_symtab_read, macho_add_oso_symfile): Update.
	* buildsym.c (finish_block_internal, make_blockvector)
	(end_symtab_get_static_block, augment_type_symtab): Update.
	* dtrace-probe.c (dtrace_process_dof)
	(dtrace_static_probe_ops::get_probes): Update.
	* complaints.h (struct complaint): Don't declare.
	(symfile_complaints): Remove.
	(complaint_internal): Remove "complaints" parameter.
	(complaint): Likewise.
	(clear_complaints): Likewise.
	* symfile.c (syms_from_objfile_1, finish_new_objfile)
	(reread_symbols): Update.
	* dwarf2-frame.c (dwarf2_restore_rule, execute_cfa_program)
	(dwarf2_frame_cache, decode_frame_entry): Update.
	* dwarf2loc.c (dwarf_reg_to_regnum): Update.
	* objc-lang.c (lookup_objc_class, lookup_child_selector)
	(info_selectors_command): Update.
	* macrotab.c (macro_include, check_for_redefinition)
	(macro_undef): Update.
	* objfiles.c (filter_overlapping_sections): Update.
	* stabsread.c (invalid_cpp_abbrev_complaint)
	(reg_value_complaint, stabs_general_complaint, dbx_lookup_type)
	(define_symbol, error_type, read_type, rs6000_builtin_type)
	(stabs_method_name_from_physname, read_member_functions)
	(read_cpp_abbrev, read_baseclasses, read_tilde_fields)
	(attach_fields_to_type, complain_about_struct_wipeout)
	(read_range_type, read_args, common_block_start)
	(common_block_end, cleanup_undefined_types_1, scan_file_globals):
	Update.
	* mdebugread.c (index_complaint, unknown_ext_complaint)
	(basic_type_complaint, bad_tag_guess_complaint)
	(bad_rfd_entry_complaint, unexpected_type_code_complaint)
	(reg_value_complaint, parse_symbol, parse_type, upgrade_type)
	(parse_procedure, parse_lines)
	(function_outside_compilation_unit_complaint)
	(parse_partial_symbols, psymtab_to_symtab_1, cross_ref)
	(bad_tag_guess_complaint, reg_value_complaint): Update.
	* cp-support.c (demangled_name_complaint): Update.
	* macroscope.c (sal_macro_scope): Update.
	* dwarf-index-write.c (class debug_names): Update.

gdb/testsuite/ChangeLog
2018-05-23  Tom Tromey  <tom@tromey.com>

	* gdb.gdb/complaints.exp (test_initial_complaints): Don't mention
	symfile_complaints.
	(test_short_complaints): Likewise.
	(test_empty_complaints): Likewise.
	(test_initial_complaints): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove struct explanation
@ 2018-05-23 18:12 sergiodj+buildbot
  2018-08-23  8:42 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-23 18:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2ac237e52beb08e09037ff917924319246b5ea6d ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 2ac237e52beb08e09037ff917924319246b5ea6d

Remove struct explanation

Now that there's only a single reason for a complaint to be emitted,
this removes "struct explanation" and changes vcomplaint to emit the
desired messages directly.

gdb/ChangeLog
2018-05-23  Tom Tromey  <tom@tromey.com>

	* complaints.c (struct complaints) <explanation>: Remove.
	(symfile_explanations): Remove.
	(symfile_complaint_book): Update.
	(vcomplaint): Update.
	(struct explanation): Remove.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove vcomplaint
@ 2018-05-23 18:49 sergiodj+buildbot
  2018-08-23 19:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-23 18:49 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT de54e1a5d231c5857e870acc788f9b843ff5f050 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: de54e1a5d231c5857e870acc788f9b843ff5f050

Remove vcomplaint

vcomplaint now has a single caller, so merge it with that caller.

gdb/ChangeLog
2018-05-23  Tom Tromey  <tom@tromey.com>

	* complaints.c (vcomplaint): Remove.
	(complaint_internal) Merge in contents of vcomplaint.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove file and line from struct complain
@ 2018-05-23 19:22 sergiodj+buildbot
  2018-08-24  6:59 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-23 19:22 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7ff8817441fcebe3d32343dbd9d514366bfe8e23 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 7ff8817441fcebe3d32343dbd9d514366bfe8e23

Remove file and line from struct complain

The file and line handling in complaints.c wasn't used once
internal_complaint was removed.  This patch removes all the related
code.

gdb/ChangeLog
2018-05-23  Tom Tromey  <tom@tromey.com>

	* complaints.c (struct complain) <file, line>: Remove.
	(find_complaint): Remove file, line parameters.
	(complaint_internal): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove struct complain
@ 2018-05-23 19:44 sergiodj+buildbot
  2018-08-24 22:28 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-23 19:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ff1cf532dbabdee0d34974a77809bf2fa23d43a5 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: ff1cf532dbabdee0d34974a77809bf2fa23d43a5

Remove struct complain

At this point, struct complain is just holds a key, a value, and a
"next" pointer to form a linked list.  It's simpler to replace this
with an unordered map.

gdb/ChangeLog
2018-05-23  Tom Tromey  <tom@tromey.com>

	* complaints.c (counters): New global.
	(struct complain): Remove.
	(struct complaints) <root>: Remove.
	(complaint_sentinel): Remove.
	(symfile_complaint_book): Update.
	(find_complaint) Remove.
	(complaint_internal, clear_complaints): Update.

gdb/testsuite/ChangeLog
2018-05-23  Tom Tromey  <tom@tromey.com>

	* gdb.gdb/complaints.exp (test_initial_complaints): Simplify.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove struct complaints
@ 2018-05-23 20:13 sergiodj+buildbot
  2018-08-25  8:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-23 20:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a8be540e8ae8d16da5854c75d4724f3875aeba2e ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: a8be540e8ae8d16da5854c75d4724f3875aeba2e

Remove struct complaints

struct complaints now just holds a single enum value, so remove it and
symfile_complaint_book and replace it with a global variable.

gdb/ChangeLog
2018-05-23  Tom Tromey  <tom@tromey.com>

	* complaints.c (struct complaints): Remove.
	(symfile_complaint_book): Remove.
	(series): New global.
	(complaint_internal): Update.
	(clear_complaints): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add ATTRIBUTE_NONSTRING to ppc64_elf_write_core_note
@ 2018-05-23 20:46 sergiodj+buildbot
  2018-08-27  2:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-23 20:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9ef6d1e31f380349c8f329d1adb47ee53ec1f6c2 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 9ef6d1e31f380349c8f329d1adb47ee53ec1f6c2

Add ATTRIBUTE_NONSTRING to ppc64_elf_write_core_note

This patch silences gcc8 -Wstringop-truncation warnings.

	* elf64-ppc.c (ppc64_elf_write_core_note): Add ATTRIBUTE_NONSTRING
	to data.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix macOS build, missing override
@ 2018-05-24 13:02 sergiodj+buildbot
  2018-08-31 18:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-24 13:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT da05d921f0b7b9f9f07ac4e78ee228e7ecf847e0 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: da05d921f0b7b9f9f07ac4e78ee228e7ecf847e0

Fix macOS build, missing override

Fixes:

In file included from ../../src/gdb/darwin-nat.c:63:0:
../../src/gdb/darwin-nat.h:28:8: error: 'virtual void darwin_nat_target::create_inferior(const char*, const string&, char**, int)' can be marked override [-Werror=suggest-override]
   void create_inferior (const char *exec_file,
        ^

gdb/ChangeLog:
2018-05-24  Pedro Alves  <palves@redhat.com>

	* darwin-nat.h (darwin_nat_target::create_inferior): Mark with
	override.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] testsuite: Extend TLS core file testing with an OS-generated dump
@ 2018-05-24 15:23 sergiodj+buildbot
  2018-08-31 19:06 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-24 15:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d9f6d7f8b636a2b32004273143d72a77d82b40de ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: d9f6d7f8b636a2b32004273143d72a77d82b40de

testsuite: Extend TLS core file testing with an OS-generated dump

Complementing commit 280ca31f4d60 ("Add test for fetching TLS from
core file") extend gdb.threads/tls-core.exp with an OS-generated dump
where supported.

This verifies not only that our core dump interpreter is consistent
with our producer, but that it matches the OS verified as well,
avoiding a possible case where our interpreter would be bug-compatible
with our producer but not the OS and it would go unnoticed in testing.

This results in:

 PASS: gdb.threads/tls-core.exp: native: load core file
 PASS: gdb.threads/tls-core.exp: native: print thread-local storage variable
 PASS: gdb.threads/tls-core.exp: gcore: load core file
 PASS: gdb.threads/tls-core.exp: gcore: print thread-local storage variable

with local testing and:

 UNSUPPORTED: gdb.threads/tls-core.exp: native: load core file
 UNSUPPORTED: gdb.threads/tls-core.exp: native: print thread-local storage variable
 PASS: gdb.threads/tls-core.exp: gcore: load core file
 PASS: gdb.threads/tls-core.exp: gcore: print thread-local storage variable

with remote testing, or for testing on ports that don't supports
cores.

gdb/testsuite/ChangeLog:
2018-05-24  Maciej W. Rozycki  <macro@mips.com>
	    Pedro Alves  <palves@redhat.com>

	* gdb.threads/tls-core.c: Include <stdlib.h>
	(thread_proc): Call `abort'.
	* gdb.threads/tls-core.exp: Generate a core with core_find too.
	(tls_core_test): New procedure, bits factored out from ...
	(top level): ... here.  Test both native cores and gcore cores.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb: Restore selected frame in print_frame_local_vars
@ 2018-05-24 18:01 sergiodj+buildbot
  2018-09-01  7:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-24 18:01 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 45f25d6c83c31a48a01ef8293bb3978f5e58e653 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 45f25d6c83c31a48a01ef8293bb3978f5e58e653

gdb: Restore selected frame in print_frame_local_vars

PR gdb/23203 reports 'bt full' causing the currently selected frame to
change, this issue is fixed in this commit.

Add a new class scoped_restore_selected_frame that saves and restores
the selected frame.  Make use of this in print_frame_local_vars to
restore the selected frame on exit.

gdb/ChangeLog:

	PR gdb/23203
	* frame.c
	(scoped_restore_selected_frame::scoped_restore_selected_frame):
	Define.
	(scoped_restore_selected_frame::~scoped_restore_selected_frame):
	Define.
	* frame.h (class scoped_restore_selected_frame): New class.
	* stack.c (print_frame_local_vars): Remove catching and rethrowing
	of any exception, use scoped_restore_selected_frame to restore the
	frame instead.

gdb/testsuite/ChangeLog:

	PR gdb/23203
	* gdb.base/bt-selected-frame.c: New file.
	* gdb.base/bt-selected-frame.exp: New file.
	* lib/gdb.exp (get_current_frame_number): New function.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Update help strings in skip.c
@ 2018-05-24 20:09 sergiodj+buildbot
  2018-09-03 16:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-24 20:09 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 784e4b3e80c1093203ae1a0da33be7a670942713 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 784e4b3e80c1093203ae1a0da33be7a670942713

Update help strings in skip.c

This changes help strings in skip.c to follow the GNU style.

2018-04-27  Tom Tromey  <tom@tromey.com>

	* skip.c (_initialize_step_skip): Update help strings.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Update core-related help strings
@ 2018-05-24 20:12 sergiodj+buildbot
  2018-09-04 11:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-24 20:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0cab2f1e91f92130c5e0d89a99ce639ebd8ec1b0 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 0cab2f1e91f92130c5e0d89a99ce639ebd8ec1b0

Update core-related help strings

This updates some help strings in corefile.c and gcore.c.

2018-04-27  Tom Tromey  <tom@tromey.com>

	* corefile.c (_initialize_core): Update help string.
	* gcore.c (_initialize_gcore): Update help string.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Update memattr.c help strings
@ 2018-05-24 20:37 sergiodj+buildbot
  2018-09-04 17:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-24 20:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 99806209a4f89fc76d338982239ab8c214df4b4d ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 99806209a4f89fc76d338982239ab8c214df4b4d

Update memattr.c help strings

This changes memattr.c to use the GNU style for help strings.

2018-04-29  Tom Tromey  <tom@tromey.com>

	* memattr.c (_initialize_mem): Update help string.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Update help strings in TUI
@ 2018-05-24 21:10 sergiodj+buildbot
  2018-09-04 18:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-24 21:10 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bf212be198a7dd7700e08862f241ed85f88408e3 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: bf212be198a7dd7700e08862f241ed85f88408e3

Update help strings in TUI

This updates some help strings in the TUI to more closely follow GNU
standards.  In this case I chose to reuse some existing "usage" macros
in the help text.  Also, I found that XDBWIN_HEIGHT_USAGE is unused,
so I removed it.

ChangeLog
2018-04-29  Tom Tromey  <tom@tromey.com>

	* tui/tui-layout.c (_initialize_tui_layout): Update help text.
	* tui/tui-win.c (WIN_HEIGHT_USAGE, FOCUS_USAGE): Update
	(XDBWIN_HEIGHT_USAGE): Remove.
	(_initialize_tui_win): Use macros.  Update help text.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Update help text in dcache.c
@ 2018-05-24 21:16 sergiodj+buildbot
  2018-09-04 19:28 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-24 21:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ffb2b66cabe9deefefa1312ef0b7bb064656e611 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: ffb2b66cabe9deefefa1312ef0b7bb064656e611

Update help text in dcache.c

This updates some text in dcache.c to follow GNU standards.
Here, I found a couple of spots needing an update.

2018-04-29  Tom Tromey  <tom@tromey.com>

	* dcache.c (dcache_info_1): Update usage text.
	(_initialize_dcache): Update help text.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Update help text for "jump" command
@ 2018-05-24 21:53 sergiodj+buildbot
  2018-09-05  0:13 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-24 21:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0a8ba311d0c4facef158af3d79c78489d5efcc4b ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 0a8ba311d0c4facef158af3d79c78489d5efcc4b

Update help text for "jump" command

This updates the usage text for the "jump" command to conform to the
GNU style.

2018-04-29  Tom Tromey  <tom@tromey.com>

	* infcmd.c (_initialize_infcmd): Update help text.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Update help text in disasm.c
@ 2018-05-24 22:04 sergiodj+buildbot
  2018-09-05  8:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-24 22:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7c9ee61b9f5fcad94fda11af1ab7469d78f17fbe ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 7c9ee61b9f5fcad94fda11af1ab7469d78f17fbe

Update help text in disasm.c

This changes some help text in disasm.c to follow the GNU style.

2018-04-29  Tom Tromey  <tom@tromey.com>

	* disasm.c (_initialize_disasm): Update help text.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Update help text in tracepoint.c
@ 2018-05-24 22:52 sergiodj+buildbot
  2018-09-06  4:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-24 22:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 02d016b71fd38648fad589c1557b83135b1dd552 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 02d016b71fd38648fad589c1557b83135b1dd552

Update help text in tracepoint.c

This changes the help text of a couple of commands in tracepoint.c to
follow the GNU style.

ChangeLog
2018-04-29  Tom Tromey  <tom@tromey.com>

	* tracepoint.c (_initialize_tracepoint): Update help text.

testsuite/ChangeLog
2018-04-30  Tom Tromey  <tom@tromey.com>

	* gdb.trace/tfind.exp: Update help tests.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Update help text in record-btrace.c
@ 2018-05-24 23:52 sergiodj+buildbot
  2018-09-06 14:38 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-24 23:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 55063ddb8e9a3179b65047db21f4c8607782d075 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 55063ddb8e9a3179b65047db21f4c8607782d075

Update help text in record-btrace.c

This updates the help text in record-btrace.c to conform to GNU
standards.

2018-04-29  Tom Tromey  <tom@tromey.com>

	* record-btrace.c (_initialize_record_btrace): Update help text.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Update help text in linux-fork.c
@ 2018-05-24 23:53 sergiodj+buildbot
  2018-09-07 21:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-24 23:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c8a15b78e676b9101045b729a38128cbe5673701 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: c8a15b78e676b9101045b729a38128cbe5673701

Update help text in linux-fork.c

This updates some help text in linux-fork.c to conform to GNU
standards.

2018-04-29  Tom Tromey  <tom@tromey.com>

	* linux-fork.c (_initialize_linux_fork): Update help text.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Update help text in record.c
@ 2018-05-25  0:21 sergiodj+buildbot
  2018-09-08  6:58 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-25  0:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a974b5ec9a253d330290d132098065b77f29bd36 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: a974b5ec9a253d330290d132098065b77f29bd36

Update help text in record.c

This updates some help text in record.c to conform to GNU standards.
I also added a "Usage" line to "record save".

2018-04-29  Tom Tromey  <tom@tromey.com>

	* record.c (_initialize_record): Update help text.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] PATCH (obvious): Fix a comment, and pass stream to cb_data.
@ 2018-05-25  1:35 sergiodj+buildbot
  2018-09-08 22:22 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-25  1:35 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d392224a0942df2f23b1149a71f62afc7f34beb8 ***

Author: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Branch: master
Commit: d392224a0942df2f23b1149a71f62afc7f34beb8

PATCH (obvious): Fix a comment, and pass stream to cb_data.

iterate_over_block_arg_vars is a void function, so does
not return 1 or 0.
print_frame_arg_vars tells it prints on STREAM,
so pass STREAM in the cb_data, not gdb_stdout.

gdb/ChangeLog

2018-05-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

	* stack.c (iterate_over_block_arg_vars): Fix comment.
	(print_frame_arg_vars): Pass stream in cb_data, not gdb_stdout.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] gdb: Split func_command into two parts.
@ 2018-05-25  3:02 sergiodj+buildbot
  2018-09-09  1:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-25  3:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 39f0c2040f13ae0eb3405b8cf2ff6491c6f354a5 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 39f0c2040f13ae0eb3405b8cf2ff6491c6f354a5

gdb: Split func_command into two parts.

The func_command function is used to emulate the dbx 'func' command.
However, finding a stack frame based on function name might be a useful
feature, and so the core of func_command is now split out into a
separate function.

gdb/ChangeLog:

	* stack.c (select_and_print_frame): Delete.
	(struct function_bounds): Move struct within function.
	(func_command): Most content moved into new function
	find_frame_for_function, use new function, print result, add
	function comment.
	(find_frame_for_function): New function, now returns a result.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix hidden visibility compiler test
@ 2018-05-25  7:02 sergiodj+buildbot
  2018-09-09  3:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-25  7:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 629dabe3b731c6194499652301935f34c3c20e0c ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 629dabe3b731c6194499652301935f34c3c20e0c

Fix hidden visibility compiler test

Warnings from configure tests aren't usually checked.  gcc's
"visibility attribute not supported in this configuration" warning is
enabled by default so we don't need to add any warning flag except
-Werror.

	* configure.ac (bfd_cv_hidden): Run test with -Werror in CFLAGS.
	* configure: Regenerate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] s12z regen
@ 2018-05-25  7:27 sergiodj+buildbot
  2018-09-09  3:55 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-25  7:27 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 277eb7f64ae0c949715751a382350368ef14e95e ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 277eb7f64ae0c949715751a382350368ef14e95e

s12z regen

This patch regenerates a number of files that either were edited by
hand or not regenerated when s12z support was added to binutils.

bfd/
	* Makefile.in: Regenerate.
	* po/SRC-POTFILES.in: Regenerate.
gas/
	* po/POTFILES.in: Regenerate.
ld/
	* po/BLD-POTFILES.in: Regenerate.
opcodes/
	* Makefile.in: Regenerate.
	* po/POTFILES.in: Regenerate.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] remote_target::m_remote_state, pointer -> object
@ 2018-05-25 11:59 sergiodj+buildbot
  2018-09-09  7:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-25 11:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3c69da406c72423afa4bd0e4fc4c805ec0b944a1 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 3c69da406c72423afa4bd0e4fc4c805ec0b944a1

remote_target::m_remote_state, pointer -> object

The only reason remote_target::m_remote_state is a pointer is that
struct remote_state is incomplete when struct remote_target is
defined.

This commit thus moves struct remote_state (and its dependencies)
higher up and makes remote_target::m_remote_state an object instead of
a pointer.

gdb/ChangeLog:
2018-05-25  Pedro Alves  <palves@redhat.com>

	* remote.c (struct vCont_action_support, MAXTHREADLISTRESULTS)
	(struct readahead_cache, struct packet_reg, struct
	remote_arch_state, class remote_state): Move higher up in the
	file.
	(remote_target::m_remote_state): Now an object instead of a pointer.
	(remote_target::get_remote_state): Adjust.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix help and documentation for inferior commands
@ 2018-05-25 12:19 sergiodj+buildbot
  2018-09-03  9:53 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-25 12:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a3c25011e4b0519dca984d23a8a2843b92b9ce2c ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: a3c25011e4b0519dca984d23a8a2843b92b9ce2c

Fix help and documentation for inferior commands

This changes inferior.c to add Usage lines for all commands, and to
change how "metasyntactic variables" are written to conform to GNU
style.

While doing this I noticed that the manual doesn't document the
argument to "info inferiors", so I've added that as well.

ChangeLog
2018-04-27  Tom Tromey  <tom@tromey.com>

	* inferior.c (initialize_inferiors): Update help strings.

doc/ChangeLog
2018-04-27  Tom Tromey  <tom@tromey.com>

	* gdb.texinfo (Inferiors and Programs): Document argument to "info
	inferiors".


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] MIPS/Linux: Correct o32 core file FGR interpretation
@ 2018-05-25 12:40 sergiodj+buildbot
  2018-09-10  0:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-25 12:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d8dab6c3bbe6432ff20237e621f2f3a3d30d4d4b ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: d8dab6c3bbe6432ff20237e621f2f3a3d30d4d4b

MIPS/Linux: Correct o32 core file FGR interpretation

Our interpretation of the layout of floating-point general registers
(FGRs) in o32 MIPS/Linux core files is different from how the kernel
makes them, affecting the CP0 Status.FR=0 aka FP32 mode (we don't
currently support the CP0 Status.FR=1 aka FP64 mode with the o32 ABI).

In the FP32 mode pairs of consecutive even/odd-numbered 32-bit registers
are placed together as 64-bit values in even-indexed 64-bit slots
corresponding to the even index, leaving the odd-indexed 64-bit slots
unused.  These 64-bit values are stored according to the endianness in
effect, which is how the MIPS II SDC1 instruction would store them.

It has always been like that with the Linux kernel for MIPS II and
higher ISA processors, which are the vast majority ever supported, as it
is indeed SDC1 that the kernel uses to store FGRs in a floating-point
context.

With MIPS I processors, which lack the SDC1 instruction, a layout that
we expect used to be used long ago, but it was corrected for consistency
with newer processors back in 2002, with `linux-mips.org' (LMO) commit
42533948caac ("Major pile of FP emulator changes."), the fix corrected
with LMO commit 849fa7a50dff ("R3k FPU ptrace() handling fixes."), and
then broken and fixed over and over again, until last time fixed with
commit 80cbfad79096 ("MIPS: Correct MIPS I FP context layout").

Consequently the values we see in FP32 core files or produce with the
`gcore' command are different from those obtained from the same FP
context of a live process, e.g. with a big-endian configuration these
live values:

(gdb) info registers float
f0:  0x4b5c6d7e flt: 14445950          dbl: 1.7446153562345001e-274
f1:  0x0718293a flt: 1.14473244e-34
f2:  0xc3d4e5f6 flt: -425.79657        dbl: -1.046160437414959e-233
f3:  0x8f90a1b2 flt: -1.42617791e-29
f4:  0x4c5d6e7f flt: 58046972          dbl: 1.1908587841220294e-269
f5:  0x08192a3b flt: 4.60914044e-34
f6:  0xc4d5e6f7 flt: -1711.21765       dbl: -6.2784661835068965e-306
f7:  0x8091a2b3 flt: -1.33745124e-38
f8:  0x45566778 flt: 3430.4668         dbl: 1.6530355595710607e-303
f9:  0x01122334 flt: 2.68412219e-38
f10: 0xcddeeff0 flt: -467533312        dbl: -2.1174864564135575e-262
f11: 0x899aabbc flt: -3.72356497e-33
f12: 0x46576879 flt: 13786.1182        dbl: 1.143296486773654e-298
f13: 0x02132435 flt: 1.08102453e-37
f14: 0xcedfe0f1 flt: -1.87803046e+09   dbl: -1.4399511533369862e-257
f15: 0x8a9bacbd flt: -1.4990934e-32
f16: 0x4758697a flt: 55401.4766        dbl: 7.8856820439568725e-294
f17: 0x03142536 flt: 4.3536007e-37
f18: 0xcfd0e1f2 flt: -7.00893696e+09   dbl: -9.7791926757340559e-253
f19: 0x8b9cadbe flt: -6.03504325e-32
f20: 0x48596a7b flt: 222633.922        dbl: 5.4255001483306113e-289
f21: 0x04152637 flt: 1.75324132e-36
f22: 0xc0d1e2f3 flt: -6.55895376       dbl: -6.6332401002310683e-248
f23: 0x8c9daebf flt: -2.42948516e-31
f24: 0x495a6b7c flt: 894647.75         dbl: 3.7244369058749787e-284
f25: 0x05162738 flt: 7.06016945e-36
f26: 0xc1d2e3f4 flt: -26.3613052       dbl: -4.4941535759306202e-243
f27: 0x8d9eafb0 flt: -9.77979703e-31
f28: 0x4a5b6c7d flt: 3595039.25        dbl: 2.5514593711161396e-279
f29: 0x06172839 flt: 2.84294945e-35
f30: 0xc2d3e4f5 flt: -105.947182       dbl: -3.035646690850097e-238
f31: 0x8e9fa0b1 flt: -3.93512664e-30
fcsr: 0x0
fir: 0xf30000
(gdb)

show up in a core file as these:

(gdb) info registers float
f0:  0x0718293a flt: 1.14473244e-34    dbl: nan
f1:  0x7ff80000 flt: nan
f2:  0x8f90a1b2 flt: -1.42617791e-29   dbl: nan
f3:  0x7ff80000 flt: nan
f4:  0x08192a3b flt: 4.60914044e-34    dbl: nan
f5:  0x7ff80000 flt: nan
f6:  0x8091a2b3 flt: -1.33745124e-38   dbl: nan
f7:  0x7ff80000 flt: nan
f8:  0x01122334 flt: 2.68412219e-38    dbl: nan
f9:  0x7ff80000 flt: nan
f10: 0x899aabbc flt: -3.72356497e-33   dbl: nan
f11: 0x7ff80000 flt: nan
f12: 0x02132435 flt: 1.08102453e-37    dbl: nan
f13: 0x7ff80000 flt: nan
f14: 0x8a9bacbd flt: -1.4990934e-32    dbl: nan
f15: 0x7ff80000 flt: nan
f16: 0x03142536 flt: 4.3536007e-37     dbl: nan
f17: 0x7ff80000 flt: nan
f18: 0x8b9cadbe flt: -6.03504325e-32   dbl: nan
f19: 0x7ff80000 flt: nan
f20: 0x04152637 flt: 1.75324132e-36    dbl: nan
f21: 0x7ff80000 flt: nan
f22: 0x8c9daebf flt: -2.42948516e-31   dbl: nan
f23: 0x7ff80000 flt: nan
f24: 0x05162738 flt: 7.06016945e-36    dbl: nan
f25: 0x7ff80000 flt: nan
f26: 0x8d9eafb0 flt: -9.77979703e-31   dbl: nan
f27: 0x7ff80000 flt: nan
f28: 0x06172839 flt: 2.84294945e-35    dbl: nan
f29: 0x7ff80000 flt: nan
f30: 0x8e9fa0b1 flt: -3.93512664e-30   dbl: nan
f31: 0x7ff80000 flt: nan
(gdb)

Notice how values from odd-numbered registers are shown in corresponding
even-numbered registers and how dummy 0x7ff80000 NaN values, which the
kernel places in unused slots, are reported in odd-numbered registers.

Correct our intepretation then, to match the kernel's.  As it happens
the o32 FGR core file representation matches that used by the `ptrace'
PTRACE_GETFPREGS request, which means our 64-bit handlers can be readily
used, as they already correctly handle the differences between o32 FP32
mode vs n32/n64 representations.

Adjust comments accordingly throughout, in particular remove a reference
to the r3000/tx39 MIPS I processor peculiarity, long irrelevant.

Add a test case to verify correctness.  Avoid GCC bugs and limitations
in the test case where possible; the test case still fails to build with
GCC 8 and the o32 FP64 mode (i.e. with `-mips32r2 -mfp64' options)
giving:

mips-fpregset-core.c: In function 'main':
mips-fpregset-core.c:66:3: error: inconsistent operand constraints in an 'asm'
   asm (
   ^~~

(GCC PR target/85909), but that is not a concern for us as yet, because
as noted above we do not currently support the o32 FP64 mode anyway.

	gdb/
	* mips-linux-tdep.h (mips_supply_fpregset, mips_fill_fpregset):
	Remove prototypes.
	* mips-linux-nat.c (supply_fpregset): Always call
	`mips64_supply_fpregset' rather than `mips_supply_fpregset'.
	(fill_fpregset): Always call `mips64_fill_fpregset' rather than
	`mips_fill_fpregset'.
	* mips-linux-tdep.c (mips_supply_fpregset)
	(mips_supply_fpregset_wrapper, mips_fill_fpregset)
	(mips_fill_fpregset_wrapper): Remove functions.
	(mips64_supply_fpregset, mips64_fill_fpregset): Update comments.
	(mips_linux_fpregset): Remove variable.
	(mips_linux_iterate_over_regset_sections): Use
	`mips64_linux_fpregset' in place of `mips_linux_fpregset'.
	(mips_linux_o32_sigframe_init): Remove comment.

	gdb/testsuite/
	* gdb.arch/mips-fpregset-core.exp: New test.
	* gdb.arch/mips-fpregset-core.c: New test source.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use TRY/CATCH in remove_prev_frame
@ 2018-05-25 15:49 sergiodj+buildbot
  2018-09-10 17:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-25 15:49 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 09a5e1b570eefbc029939fd43c99152996060d95 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 09a5e1b570eefbc029939fd43c99152996060d95

Use TRY/CATCH in remove_prev_frame

This changes remove_prev_frame to use TRY/CATCH instead of a cleanup.
TRY/CATCH seemed appropriate here because the cleanup is only needed
in the case where an exception is thrown.

Tested by the buildbot.

ChangeLog
2018-05-25  Tom Tromey  <tom@tromey.com>

	* frame.c (remove_prev_frame): Remove.
	(get_prev_frame_if_no_cycle): Use TRY/CATCH.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove cleanups from coff-pe-read.c
@ 2018-05-25 17:20 sergiodj+buildbot
  2018-09-10 23:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-25 17:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3173aa2fc212389268f76433e70b35116a936a8d ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 3173aa2fc212389268f76433e70b35116a936a8d

Remove cleanups from coff-pe-read.c

This removes cleanups from coff-pe-read.c, using std::string,
std::vector, and gdb::def_vector.

Tested by the buildbot, though I'm not sure these code paths are
exercised there.

ChangeLog
2018-05-25  Tom Tromey  <tom@tromey.com>

	* coff-pe-read.c (struct read_pe_section_data) <section_name>: Now
	a std::string.
	(get_pe_section_index, add_pe_exported_sym): Update.
	(read_pe_exported_syms): Use gdb::def_vector.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use gdb::byte_vector in remote.c
@ 2018-05-25 17:52 sergiodj+buildbot
  2018-09-11  2:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-25 17:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5ca3b2605cc9ab5b33032c6478147366be60cd95 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 5ca3b2605cc9ab5b33032c6478147366be60cd95

Use gdb::byte_vector in remote.c

This changes a couple of spots in remote.c to use gdb::byte_vector,
allowing for some cleanup removal.

ChangeLog
2018-05-25  Tom Tromey  <tom@tromey.com>

	* remote.c (remote_target::remote_file_get): Use
	gdb::byte_vector.
	(remote_target::remote_file_put): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Use scoped_restore in a couple of interp-related places
@ 2018-05-25 19:42 sergiodj+buildbot
  2018-09-11 14:58 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-25 19:42 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 753ff9bd837e2ba183e3ff789847a81221561392 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 753ff9bd837e2ba183e3ff789847a81221561392

Use scoped_restore in a couple of interp-related places

While looking through the "interp" code I found a couple of spots that
could use scoped_restore.

ChangeLog
2018-05-25  Tom Tromey  <tom@tromey.com>

	* cli/cli-interp.c (safe_execute_command): Use scoped_restore.
	* interps.c (interp_exec): Use scoped_restore.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Change the as_*_interp functions to use dynamic_cast
@ 2018-05-25 20:32 sergiodj+buildbot
  2018-09-13 10:02 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-25 20:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 716b8bc52eef6044f1ff361e3e2eeb9307849034 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 716b8bc52eef6044f1ff361e3e2eeb9307849034

Change the as_*_interp functions to use dynamic_cast

This changes the various as_*_interp functions to be implemented using
dynamic_cast.  I believe this is a small improvement, because it is
more typesafe -- the C++ runtime does the type-checking for us.

ChangeLog
2018-05-25  Tom Tromey  <tom@tromey.com>

	* tui/tui-interp.c (as_tui_interp): Use dynamic_cast.
	* mi/mi-interp.c (as_mi_interp): Use dynamic_cast.
	* cli/cli-interp.c (as_cli_interp): Use dynamic_cast.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove interp_name
@ 2018-05-25 20:59 sergiodj+buildbot
  2018-09-13 14:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-25 20:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT da505cff6e29b18244dc9f6886bcb4d436263dee ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: da505cff6e29b18244dc9f6886bcb4d436263dee

Remove interp_name

This removes the interp_name function.  It is only used a few spots --
one of which was only calling it on "this".  It's simpler to remove
it; and should class interp become opaque in the future, it will be
just as easy to update the two remaining spots to use an accessor.

ChangeLog
2018-05-25  Tom Tromey	<tom@tromey.com>

	* interps.c (interp_name): Remove.
	* mi/mi-interp.c (mi_interp::init): Update.
	* interps.h (interp_name): Remove.
	(~scoped_restore_interp): Update.
	* tui/tui.c (tui_enable): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Clear entire "location" in value constructor
@ 2018-05-25 22:57 sergiodj+buildbot
  2018-09-13 21:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-25 22:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 41a883c8edf98e86176d007bc8ad1c86c9675528 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 41a883c8edf98e86176d007bc8ad1c86c9675528

Clear entire "location" in value constructor

My recent change to allocate values with "new" may have introduced a
small bug.  In particular, the previous code allocated with XCNEW, but
the new code only clears a part of the "location" field in the
constructor.  I didn't try very hard to actually trigger a bug here,
the problem remains theoretical.

This patch just arranges to initialize the entire location.

Regression tested by the buildbot.

2018-05-25  Tom Tromey  <tom@tromey.com>

	* value.c (value::location): Initialize.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove interp_ui_out
@ 2018-05-26 17:55 sergiodj+buildbot
  2018-09-13 12:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-26 17:55 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 29f943408122a7cffa25abb41def99833436f097 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 29f943408122a7cffa25abb41def99833436f097

Remove interp_ui_out

The function interp_ui_out simply calls the interp_ui_out method.
However, if it is passed a NULL interpreter, it first finds the
current interpreter.  I believe, though, that NULL is never passed
here, and I think it's simpler to just remove this function and
require callers to be more explicit.

ChangeLog
2018-05-25  Tom Tromey	<tom@tromey.com>

	* utils.c (fputs_maybe_filtered): Update.
	* linespec.c (decode_line_full): Update.
	* mi/mi-interp.c (mi_on_normal_stop_1, mi_tsv_modified)
	(mi_print_breakpoint_for_event, mi_solib_loaded)
	(mi_solib_unloaded, mi_command_param_changed, mi_memory_changed)
	(mi_user_selected_context_changed): Update.
	* mi/mi-main.c (mi_execute_command): Update.
	* cli/cli-script.c (execute_control_command): Update.
	* python/python.c (execute_gdb_command): Update.
	* solib.c (info_sharedlibrary_command): Update.
	* interps.c (interp_ui_out): Remove.
	* interps.h (interp_ui_out): Remove.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add "name" method to class interp
@ 2018-05-26 21:25 sergiodj+buildbot
  2018-09-13 15:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-26 21:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d525a99be1b02dda6c69007e31dd06f276378aea ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: d525a99be1b02dda6c69007e31dd06f276378aea

Add "name" method to class interp

In a review Pedro pointed out that interp::name is intended to be
read-only, and so an accessor would be a better fit.  This patch
renames the field and adds a "name" method that is used instead.

ChangeLog
2018-05-25  Tom Tromey  <tom@tromey.com>

	* tui/tui.c (tui_enable): Update.
	* mi/mi-interp.c (mi_interp::init): Update.
	* interps.h (class interp) <name>: New method.
	<m_name>: Rename from name.
	(~scoped_restore_interp): Update.
	* interps.c (interp::interp): Update.
	(interp_add, interp_set, interp_lookup_existing)
	(current_interp_named_p): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove cleanups from dbxread.c
@ 2018-05-26 21:47 sergiodj+buildbot
  2018-09-13 16:44 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-26 21:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bf259e253f0d27323756fb434ba6e94d50846021 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: bf259e253f0d27323756fb434ba6e94d50846021

Remove cleanups from dbxread.c

This removes the remaining cleanups from dbxread.c, via std::vector,
scoped_restore, and unique_xmalloc_ptr.

Tested by the buildbot.

ChangeLog
2018-05-25  Tom Tromey  <tom@tromey.com>

	* dbxread.c (init_bincl_list): Remove.
	(bincl_list): Now a std::vector.
	(bincls_allocated, next_bincl): Remove.
	(free_bincl_list, do_free_bincl_list_cleanup)
	(make_cleanup_free_bincl_list): Remove.
	(dbx_read_symtab, elfstab_build_psymtabs): Use scoped_restore,
	unique_xmalloc_ptr.
	(find_corresponding_bincl_psymtab, read_dbx_symtab): Update.
	(struct header_file_location): Add constructor.
	(add_bincl_to_list): Remove.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] ld: Add _bfd_elf_link_hide_sym_by_version
@ 2018-05-27  0:24 sergiodj+buildbot
  2018-09-14  1:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-27  0:24 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 099bb8fb97d79d03a20926d6014a5fc27a5ca75e ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 099bb8fb97d79d03a20926d6014a5fc27a5ca75e

ld: Add _bfd_elf_link_hide_sym_by_version

bfd_hide_sym_by_version can't be used to check if a versioned symbol is
hidden.  This patch adds _bfd_elf_link_hide_sym_by_version to support
both versioned and unversioned symbols by extracting versioned symbol
check from _bfd_elf_link_assign_sym_version.

bfd/

	PR ld/23194
	* elf-bfd.h (_bfd_elf_link_hide_sym_by_version): New.
	* elflink.c (_bfd_elf_link_hide_versioned_symbol): New function.
	Extracted from _bfd_elf_link_assign_sym_version.
	(_bfd_elf_link_hide_sym_by_version): New function.
	(_bfd_elf_link_assign_sym_version): Use
	_bfd_elf_link_hide_versioned_symbol.
	* elfxx-x86.c (_bfd_x86_elf_link_symbol_references_local): Call
	_bfd_elf_link_hide_sym_by_version instead of
	bfd_hide_sym_by_version.  Don't check unversioned symbol.

ld/

	PR ld/23194
	* testsuite/ld-i386/pr23194.d: Expect only R_386_GLOB_DAT
	against foobar.
	* testsuite/ld-i386/pr23194.map: Add foobar.
	* testsuite/ld-x86-64/pr23194.map: Likewise.
	* testsuite/ld-i386/pr23194.s: Add a common foobar symbol.
	* testsuite/ld-x86-64/pr23194.s: Likewise.
	* testsuite/ld-x86-64/pr23194.d: Expect only R_X86_64_GLOB_DAT
	against foobar.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove last reference to REMOTE_OBS
@ 2018-05-27 22:16 sergiodj+buildbot
  2018-09-14 12:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-27 22:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b8283aea9e599f17dbae7f52223994e3a9168143 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: b8283aea9e599f17dbae7f52223994e3a9168143

Remove last reference to REMOTE_OBS

REMOTE_OBS was removed from Makefile.in in
18ca73470a0d7eb96a807c97559cbb9fddb4b461, but one reference remains.
This patch removes the lingerer.

ChangeLog
2018-05-27  Tom Tromey  <tom@tromey.com>

	* Makefile.in (DEPFILES): Don't reference REMOTE_OBS.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] ld: Unify STT_GNU_IFUNC handling
@ 2018-05-28 16:20 sergiodj+buildbot
  2018-09-14 23:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-28 16:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ac98f9e2275ffcca560eaa0bddd282a1ff94fc28 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: ac98f9e2275ffcca560eaa0bddd282a1ff94fc28

ld: Unify STT_GNU_IFUNC handling

Take STT_GNU_IFUNC handling scattered across targets and gather it in
the generic ELF linker.

bfd/

	PR ld/23238
	* elf-s390-common.c (elf_s390_add_symbol_hook): Removed.
	* elf32-arc.c (elf_arc_add_symbol_hook): Likewise.
	(elf_backend_add_symbol_hook): Likewise.
	* elf32-m68k.c (elf_m68k_add_symbol_hook): Likewise.
	(elf_backend_add_symbol_hook): Likewise.
	* elf32-s390.c (elf_backend_add_symbol_hook): Likewise.
	* elf32-sparc.c (elf32_sparc_add_symbol_hook): Likewise.
	(elf_backend_add_symbol_hook): Likewise.
	* elf64-s390.c (elf_backend_add_symbol_hook): Likewise.
	* elfxx-aarch64.c (_bfd_aarch64_elf_add_symbol_hook): Likewise.
	* elfxx-aarch64.h (_bfd_aarch64_elf_add_symbol_hook): Likewise.
	(elf_backend_add_symbol_hook): Likewise.
	* elf32-arm.c (elf32_arm_add_symbol_hook): Remove STT_GNU_IFUNC
	handling.
	* elf32-ppc.c (ppc_elf_add_symbol_hook): Likewise.
	* elf64-ppc.c (ppc64_elf_add_symbol_hook): Likewise.
	* elf64-sparc.c (elf64_sparc_add_symbol_hook): Likewise.
	* elflink.c (elf_link_add_object_symbols): Set
	elf_gnu_symbol_ifunc for STT_GNU_IFUNC symbols.

ld/

	PR ld/23238
	* testsuite/ld-ifunc/ifunc-26.d: New file.
	* testsuite/ld-ifunc/ifunc-26.s: Likewise.
	* testsuite/ld-ifunc/ifunc.exp: Run *.d tests without a
	working compiler.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] x86-64: Add TLSDESC fields to elf_x86_lazy_plt_layout
@ 2018-05-28 19:57 sergiodj+buildbot
  2018-09-15 18:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-28 19:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 92e68c1d65f844c0027f471a0c9e1722d781ef7d ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 92e68c1d65f844c0027f471a0c9e1722d781ef7d

x86-64: Add TLSDESC fields to elf_x86_lazy_plt_layout

ENDBR64 is added to the special TLSDESC entry, which is similar to the
PLT0 entry, in the x86-64 lazy procedure linkage table to support Intel
CET.  The NaCl PLT is different from the normal PLT.  This patch adds
plt_tlsdesc_entry, plt_tlsdesc_entry_size, plt_tlsdesc_got1_offset,
plt_tlsdesc_got2_offset, plt_tlsdesc_got1_insn_end and
plt_tlsdesc_got2_insn_end to elf_x86_lazy_plt_layout to support both
normal and NaCl TLSDESC entries.  This fixed

FAIL: TLS descriptor -fpic -shared transitions

for x86_64-nacl.

	* elf32-i386.c (elf_i386_lazy_plt): Add plt_tlsdesc_entry,
	plt_tlsdesc_entry_size, plt_tlsdesc_got1_offset,
	plt_tlsdesc_got2_offset, plt_tlsdesc_got1_insn_end and
	plt_tlsdesc_got2_insn_end for TLSDESC entry.
	(elf_i386_lazy_ibt_plt): Likewise.
	(elf_i386_nacl_plt): Likewise.
	* elf64-x86-64.c (tlsdesc_plt_entry): Moved and renamed to ...
	(elf_x86_64_tlsdesc_plt_entry): This.
	(elf_x86_64_lazy_plt): Add plt_tlsdesc_entry,
	plt_tlsdesc_entry_size, plt_tlsdesc_got1_offset,
	plt_tlsdesc_got2_offset, plt_tlsdesc_got1_insn_end and
	plt_tlsdesc_got2_insn_end for TLSDESC entry.
	(elf_x86_64_lazy_bnd_plt): Likewise.
	(elf_x86_64_lazy_ibt_plt): Likewise.
	(elf_x32_lazy_ibt_plt): Likewise.
	(elf_x86_64_nacl_plt): Likewise.
	(elf_x86_64_finish_dynamic_sections): Use plt_tlsdesc_entry,
	plt_tlsdesc_entry_size, plt_tlsdesc_got1_offset,
	plt_tlsdesc_got2_offset, plt_tlsdesc_got1_insn_end and
	plt_tlsdesc_got2_insn_end to update TLSDESC entry.
	* elfxx-x86.h (elf_x86_lazy_plt_layout): Update comments.
	Add plt_tlsdesc_entry, plt_tlsdesc_entry_size,
	plt_tlsdesc_got1_offset, plt_tlsdesc_got2_offset,
	plt_tlsdesc_got1_insn_end and plt_tlsdesc_got2_insn_end.
	(elf_x86_non_lazy_plt_layout): Update comments.
	(elf_x86_plt_layout): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove const_char_ptr typedef
@ 2018-05-29 16:07 sergiodj+buildbot
  2018-09-16  8:36 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-29 16:07 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4f7deebe0c56863f0c97edfe9ac9931dfdfc8f0a ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 4f7deebe0c56863f0c97edfe9ac9931dfdfc8f0a

Remove const_char_ptr typedef

The const_char_ptr is no longer used, so it can be removed.

ChangeLog
2018-05-29  Tom Tromey  <tom@tromey.com>

	* objc-lang.h: Don't include cp-support.h.
	* common/gdb_vecs.h (const_char_ptr): Remove typedef.  Don't
	declare VEC.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove tp_t typedef
@ 2018-05-29 16:25 sergiodj+buildbot
  2018-09-16 18:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-29 16:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 10b2ded43caa3298cded1df8b620caaaee3f9209 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 10b2ded43caa3298cded1df8b620caaaee3f9209

Remove tp_t typedef

The tp_t typedef is no longer used and can be removed.

ChangeLog
2018-05-29  Tom Tromey  <tom@tromey.com>

	* record-btrace.c (tp_t): Remove typedef.  Don't declare VEC.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove a VEC from type.c
@ 2018-05-29 18:44 sergiodj+buildbot
  2018-09-17  5:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-29 18:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 894882e344735ace5231f179484086f7697d27cc ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 894882e344735ace5231f179484086f7697d27cc

Remove a VEC from type.c

This removes a VEC from type.c, by using std::vector.

While doing this I also took the opportunity to change
types_deeply_equal to return bool.  This caught some weird code in
typy_richcompare, now fixed.

And, since I was changing types_deeply_equal, it seemed like a good
idea to also change types_equal, so this patch includes that as well.

Tested by the buildbot.

ChangeLog
2018-05-29  Tom Tromey  <tom@tromey.com>

	* python/py-type.c (typy_richcompare): Update.
	* guile/scm-type.c (tyscm_equal_p_type_smob): Update.
	* gdbtypes.h (types_deeply_equal): Return bool.
	(types_equal): Likewise.
	* gdbtypes.c (type_equality_entry_d): Remove typedef.  Don't
	declare VEC.
	(check_types_equal): Change worklist to std::vector.  Return
	bool.
	(struct type_equality_entry): Add constructor.
	(compare_maybe_null_strings): Return bool.
	(check_types_worklist): Return bool.  Change worklist to
	std::vector.
	(types_deeply_equal): Use std::vector.
	(types_equal): Return bool.
	(compare_maybe_null_strings): Simplify.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Change program_space::added_solibs to a std::vector
@ 2018-05-29 19:05 sergiodj+buildbot
  2018-09-17 11:49 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-29 19:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bcb430e4cd5bcd913813236536031f1fc7f72aee ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: bcb430e4cd5bcd913813236536031f1fc7f72aee

Change program_space::added_solibs to a std::vector

This changes program_space::added_solibs to a std::vector, removing a
VEC.

Tested by the buildbot.

gdb/ChangeLog
2018-05-29  Tom Tromey  <tom@tromey.com>

	* progspace.h (so_list_ptr): Remove typedef.  Don't declare VEC.
	(struct program_space) <added_solibs>: Now a std::vector.
	* breakpoint.c (print_solib_event): Update.
	(check_status_catch_solib): Update.
	* progspace.c (clear_program_space_solib_cache): Update.
	* solib.c (update_solib_list): Update.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Fix fall-through comment in windows-nat.c
@ 2018-05-29 23:51 sergiodj+buildbot
  2018-09-17 18:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-29 23:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e7ec8713ec12a633fcdfc5524c9ee050389b6f9d ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: e7ec8713ec12a633fcdfc5524c9ee050389b6f9d

Fix fall-through comment in windows-nat.c

Now that the mingw builder in the buildbot is working again, it
pointed out a build failure due to a missing fall-through comment in
windows-nat.c.  This patch fixes the problem.

Tested by first triggering the failure with a local mingw build, then
by rebuilding successfully with the patch.

I'm checking this in as obvious.

gdb/ChangeLog
2018-05-29  Tom Tromey  <tom@tromey.com>

	* windows-nat.c (handle_exception): Update fall-through comment.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Removing lookup_minimal_symbol_and_objfile
@ 2018-05-30  0:37 sergiodj+buildbot
  2018-09-18  3:39 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-30  0:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 64cc34d87089ff24b43e0a8760be132b7afa6f34 ***

Author: Weimin Pan <weimin.pan@oracle.com>
Branch: master
Commit: 64cc34d87089ff24b43e0a8760be132b7afa6f34

Removing lookup_minimal_symbol_and_objfile

Function lookup_minimal_symbol_and_objfile iterates on all objfiles and
calls lookup_minimal_symbol for each of them, effectively searching in all
objfiles.  lookup_bound_minimal_symbol calls lookup_minimal_symbol with NULL,
which also effectively searches all objfiles.  AFAIK, they do exactly the same
thing, so we can get rid of one (and lookup_minimal_symbol_and_objfile happens
to be the most inefficient because it ends up n^2 on the number of objfiles).

Tested in both aarch64-linux-gnu and amd64-linux-gnu. No regressions.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove "struct" keyword in range-based for loops
@ 2018-05-30  1:23 sergiodj+buildbot
  2018-09-18 16:54 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-30  1:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5294170687db7d997a00f88b765ef353121aa441 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 5294170687db7d997a00f88b765ef353121aa441

Remove "struct" keyword in range-based for loops

I get this kind of errors with GCC 6.3.0:

/home/simark/src/binutils-gdb/gdb/breakpoint.c: In function 'void print_solib_event(int)':
/home/simark/src/binutils-gdb/gdb/breakpoint.c:4618:12: error: types may not be defined in a for-range-declaration [-Werror]
       for (struct so_list *iter : current_program_space->added_solibs)
            ^~~~~~

Removing the struct keyword makes it happy.

gdb/ChangeLog:

	* breakpoint.c (print_solib_event, check_status_catch_solib):
	Remove struct keyword in range-based for loops.
	* dbxread.c (find_corresponding_bincl_psymtab): Likewise.
	* dwarf2read.c (compute_delayed_physnames, rust_union_quirks);
	Likewise.
	* linespec.c (find_superclass_methods, search_minsyms_for_name):
	Likewise.
	* symfile.c (addr_info_make_relative): Likewise.
	* thread.c (value_in_thread_stack_temporaries): Likewise.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add znver2 support.
@ 2018-05-30  8:52 sergiodj+buildbot
  2018-09-19  2:27 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-30  8:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a9660a6f4063c7e1fb892ec709c954c56896ab8d ***

Author: Amit Pawar <Amit.Pawar@amd.com>
Branch: master
Commit: a9660a6f4063c7e1fb892ec709c954c56896ab8d

Add znver2 support.

	gas/
	* config/tc-i386.c (cpu_flag_init): Add CPU_ZNVER2_FLAGS.
	* doc/c-i386.texi : Document znver2.
	* gas/testsuite/gas/i386/arch-13.s: Updated for znver2.
	* gas/testsuite/gas/i386/arch-13.d: Updated.
	* gas/testsuite/gas/i386/arch-13-znver1.d: Updated.
	* gas/testsuite/gas/i386/arch-13-znver2.d: New file.
	* gas/testsuite/gas/i386/x86-64-arch-3.s: Updated for znver2.
	* gas/testsuite/gas/i386/x86-64-arch-3.d: Updated.
	* gas/testsuite/gas/i386/x86-64-arch-3-znver1.d: Updated.
	* gas/testsuite/gas/i386/x86-64-arch-3-znver2.d: New file.
	* gas/testsuite/gas/i386/i386.exp: Updated for new test.

	opcode/
	* i386-gen.c (cpu_flag_init): Add CPU_ZNVER2_FLAGS.
	* i386-init.h : Regenerated.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Mark END_CATCH as ATTRIBUTE_NORETURN (-Wmaybe-uninitialized warnings)
@ 2018-05-30 15:56 sergiodj+buildbot
  2018-09-19  9:37 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-30 15:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f7c6f42310233479ea6339430b7c1ca1f9ec68e1 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: f7c6f42310233479ea6339430b7c1ca1f9ec68e1

Mark END_CATCH as ATTRIBUTE_NORETURN (-Wmaybe-uninitialized warnings)

This commit fixes a set of -Wmaybe-uninitialized warnings in GDB and
GDBserver, seen with GCC 7.3.1 on F27 at -O2.  Specifically, all of
these:

 src/gdb/breakpoint.c:5040:4: warning: e may be used uninitialized in this function [-Wmaybe-uninitialized]
 src/gdb/cli/cli-cmds.c:277:71: warning: tracker may be used uninitialized in this function [-Wmaybe-uninitialized]
 src/gdb/cli/cli-cmds.c:302:22: warning: word may be used uninitialized in this function [-Wmaybe-uninitialized]
 src/gdb/gdbserver/server.c:1895:7: warning: result may be used uninitialized in this function [-Wmaybe-uninitialized]
 src/gdb/gdbserver/server.c:1966:7: warning: result may be used uninitialized in this function [-Wmaybe-uninitialized]

For example, looking at one of the gdbserver ones in more detail:

 ../../../src/gdb/gdbserver/server.c: In function int handle_qxfer_btrace_conf(const char*, gdb_byte*, const gdb_byte*, ULONGEST, LONGEST):
 ../../../src/gdb/gdbserver/server.c:1966:7: warning: result may be used uninitialized in this function [-Wmaybe-uninitialized]
	if (result != 0)
	^~

In this case (like the others), the 'result' variable is assigned in
both TRY and CATCH blocks:

      TRY
        {
          result = target_read_btrace_conf (thread->btrace, &cache);
          if (result != 0)
            memcpy (own_buf, cache.buffer, cache.used_size);
        }
      CATCH (exception, RETURN_MASK_ERROR)
        {
          sprintf (own_buf, "E.%s", exception.message);
          result = -1;
        }
      END_CATCH

      if (result != 0)
        return -3;

so it would seem like the warning is bogus.

However, END_CATCH is really a catch block in disguise, and that path
indeed does not initialize the variable:

#define END_CATCH				\
    catch (...)					\
      {						\
	exception_rethrow ();			\
      }						\
  }

exception_rethrow does not return normally (it rethrows the current
exception after running cleanups), but the compiler can not see that.
If it could return normally, then indeed 'result' could be used
uninitialized if the TRY block threw some non-gdb exception, which
would be caught by END_CATCH.

The fix it to let the compiler know that the exception_rethrow does
not return normally, using ATTRIBUTE_NORETURN.

gdb/ChangeLog:
2018-05-30  Pedro Alves  <palves@redhat.com>

	* common/common-exceptions.h (exception_rethrow): Use
	ATTRIBUTE_NORETURN.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] 2018-05-30  Amaan Cheval <amaan.cheval@gmail.com>
@ 2018-05-30 16:17 sergiodj+buildbot
  2018-09-20  9:59 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-30 16:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 421acf18739edb54111b64d2b328ea2e7bf19889 ***

Author: Amaan Cheval <amaan.cheval@gmail.com>
Branch: master
Commit: 421acf18739edb54111b64d2b328ea2e7bf19889

2018-05-30  Amaan Cheval <amaan.cheval@gmail.com>

	* config.bfd (x86_64-*-*): Add pei-x86-64 target to x86_64-*-rtems*
	This is needed to generate UEFI application image files from ELFs.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Add or1k target to --enable-targets=all
@ 2018-05-30 16:57 sergiodj+buildbot
  2018-09-20 18:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-30 16:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fdbe37e35fed48091296434652101a63fa4360cf ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: fdbe37e35fed48091296434652101a63fa4360cf

Add or1k target to --enable-targets=all

The or1k-tdep.o object is missing from the ALL_TARGET_OBS, which means
it's not currently included in an --enable-targets=all build.

gdb/ChangeLog:

	* Makefile.in (ALL_TARGET_OBS): Add or1k-tdep.o.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove regcache_get_ptid
@ 2018-05-30 20:01 sergiodj+buildbot
  2018-09-21 23:00 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-30 20:01 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 222312d359fe0a68f8583ba315583ee8cc94f252 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 222312d359fe0a68f8583ba315583ee8cc94f252

Remove regcache_get_ptid

Remove regcache_get_ptid, change all callers to call the regcache method
directly.

gdb/ChangeLog:

	* regcache.h (regcache_get_ptid): Remove, update all callers to
	call regcache::ptid instead.
	* regcache.c (regcache_get_ptid): Remove.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove regcache_register_status
@ 2018-05-30 20:37 sergiodj+buildbot
  2018-09-23 19:13 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-30 20:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0ec9f11447514a797ae13760825fa45f9deedd8c ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 0ec9f11447514a797ae13760825fa45f9deedd8c

Remove regcache_register_status

Remove regcache_register_status, change callers to use
reg_buffer::get_register_status directly.

gdb/ChangeLog:

	* regcache.h (regcache_register_status): Remove, update callers
	to use reg_buffer::get_register_status directly instead.
	* regcache.c (regcache_register_status): Remove.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
* [binutils-gdb] Remove regcache_raw_update
@ 2018-05-30 20:58 sergiodj+buildbot
  2018-09-24 15:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2920+ messages in thread
From: sergiodj+buildbot @ 2018-05-30 20:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0b47d9858ca0805cd52ba959276d08899c7b9f8c ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 0b47d9858ca0805cd52ba959276d08899c7b9f8c

Remove regcache_raw_update

Remove regcache_raw_update, update callers to use
readable_regcache::raw_update instead.

gdb/ChangeLog:

	* regcache.h (regcache_raw_update): Remove, update callers to
	use readable_regcache::raw_update instead.
	* regcache.c (regcache_raw_update): Remove.


^ permalink raw reply	[flat|nested] 2920+ messages in thread
end of thread, other threads:[~2018-09-20 20:45 UTC | newest]

Thread overview: 2920+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-12 18:52 [binutils-gdb] Tighten remote check in gdb.base/argv0-symlink.exp sergiodj+buildbot
2017-10-12 18:52 ` Failures on Fedora-s390x-m64, branch master sergiodj+buildbot
2017-10-12 19:47 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, " sergiodj+buildbot
2017-10-12 20:13 ` Failures on Ubuntu-AArch32-m32, " sergiodj+buildbot
2017-10-12 20:16 ` Failures on Ubuntu-AArch64-m64, " sergiodj+buildbot
2017-10-12 20:39 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, " sergiodj+buildbot
2017-10-12 21:17 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, " sergiodj+buildbot
2017-10-12 23:46 ` Failures on Fedora-x86_64-m64, " sergiodj+buildbot
2017-10-13  0:55 ` Failures on Fedora-x86_64-native-gdbserver-m32, " sergiodj+buildbot
2017-10-13  1:41 ` Failures on Fedora-x86_64-native-gdbserver-m64, " sergiodj+buildbot
2017-10-13  3:12 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " sergiodj+buildbot
2017-10-13  5:09 ` Failures on Fedora-i686, " sergiodj+buildbot
2017-10-13  5:22 ` Failures on Fedora-x86_64-cc-with-index, " sergiodj+buildbot
2017-10-13  7:17 ` Failures on Fedora-x86_64-m32, " sergiodj+buildbot
2017-12-16 22:41 [binutils-gdb] gdb: Add news entries for new or1k target sergiodj+buildbot
2017-12-16 22:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2017-12-16 23:29 [binutils-gdb] gdb: Fix function parameter alignments in or1k-tdep.c sergiodj+buildbot
2017-12-17  0:06 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2017-12-18  3:22 [binutils-gdb] Ada: fix bad handling in ada_convert_actual sergiodj+buildbot
2017-12-18  3:36 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2017-12-18  4:13 [binutils-gdb] (Ada) crash assigning to record component which is an array sergiodj+buildbot
2017-12-18  5:14 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2017-12-18  4:51 [binutils-gdb] improved error message when getting an exception printing a variable sergiodj+buildbot
2017-12-18  7:06 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2017-12-18  8:56 [binutils-gdb] x86: replace Reg8, Reg16, Reg32, and Reg64 sergiodj+buildbot
2017-12-18  9:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2017-12-18  9:35 [binutils-gdb] x86: drop FloatReg and FloatAcc sergiodj+buildbot
2017-12-18 11:15 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2017-12-18 10:42 [binutils-gdb] x86: fold RegXMM/RegYMM/RegZMM into RegSIMD sergiodj+buildbot
2017-12-18 12:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2017-12-18 11:26 [binutils-gdb] x86: fold certain AVX and AVX2 templates sergiodj+buildbot
2017-12-18 13:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2017-12-18 22:34 [binutils-gdb] PR22626, invalid dynindx used for dynamic relocs against section syms sergiodj+buildbot
2017-12-18 22:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2017-12-19 12:47 [binutils-gdb] Add support for V_4B so we can properly reject it sergiodj+buildbot
2017-12-19 12:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2017-12-19 13:25 [binutils-gdb] Correct disassembly of dot product instructions sergiodj+buildbot
2017-12-19 14:11 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2017-12-20 13:37 [binutils-gdb] [Cell/B.E.] Fix regression due to gdbarch_significant_addr_bit sergiodj+buildbot
2017-12-20 13:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2017-12-20 21:59 [binutils-gdb] RISC-V: Add compressed instruction hints, and a few misc cleanups sergiodj+buildbot
2017-12-20 22:13 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2017-12-21  2:01 [binutils-gdb] Remove write-only assignment in rs6000-tdep.c sergiodj+buildbot
2017-12-21  2:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2017-12-21 23:57 [binutils-gdb] Do not emit "field_type" var if not needed on "maint print c-tdesc" sergiodj+buildbot
2017-12-21 23:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2017-12-23 21:51 [binutils-gdb] Add ATTRIBUTE_PRINTF to printf_field_type_assignment sergiodj+buildbot
2017-12-23 22:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2017-12-27 15:03 [binutils-gdb] reggroups: Add test and docs for `info reg $reggroup` feature sergiodj+buildbot
2017-12-27 15:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2017-12-27 15:46 [binutils-gdb] reggroups: Convert reggroups from post_init to pre_init sergiodj+buildbot
2017-12-27 17:30 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2017-12-27 16:45 [binutils-gdb] reggroups: Add reggroup_gdbarch_new, reggroup_find for dynamic reggroups sergiodj+buildbot
2017-12-27 20:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2017-12-27 17:51 [binutils-gdb] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p sergiodj+buildbot
2017-12-27 23:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2017-12-28 17:51 [binutils-gdb] Remove unused HP-UX TARGET_OBJECT_ enums sergiodj+buildbot
2017-12-28 18:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2017-12-28 21:41 [binutils-gdb] RISC-V: Add missing privileged spec registers sergiodj+buildbot
2017-12-28 21:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2017-12-30  3:17 [binutils-gdb] Remove unnecessary call to get_thread_db_info sergiodj+buildbot
2017-12-30  3:44 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2017-12-30  4:57 [binutils-gdb] Ignore warning about using different types of enums in switch sergiodj+buildbot
2017-12-30  5:39 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2017-12-30  7:02 [binutils-gdb] Make mapped_debug_names and mapped_index final sergiodj+buildbot
2017-12-30  7:15 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2017-12-31  0:34 [binutils-gdb] C++-ify parser_state sergiodj+buildbot
2017-12-31  0:45 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2017-12-31  2:43 [binutils-gdb] dwarf2read: Silence -Wenum-compare-switch warning sergiodj+buildbot
2017-12-31  3:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2017-12-31  4:57 [binutils-gdb] Only ignore -Wenum-compare-switch if it exists sergiodj+buildbot
2017-12-31  5:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2017-12-31 11:04 [binutils-gdb] Avoid indexing std::vector past the end sergiodj+buildbot
2017-12-31 15:00 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-02  3:57 [binutils-gdb] Yearly rotation of the gdb/ChangeLog file sergiodj+buildbot
2018-01-02  4:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-02  4:44 [binutils-gdb] Update copyright year in version message of GDB, GDBserver and GDBreplay sergiodj+buildbot
2018-01-02  6:00 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-02  5:29 [binutils-gdb] gdb/copyright.py: Do not forget to remind about MULTIPLE_COPYRIGHT_HEADERS sergiodj+buildbot
2018-01-02  8:15 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-02  6:13 [binutils-gdb] gdb/copyright.py: Remove testsuite/gdb.base/step-line.{c, inp} special handling sergiodj+buildbot
2018-01-02 10:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-02  6:58 [binutils-gdb] Update copyright year range in all GDB files sergiodj+buildbot
2018-01-02 12:48 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-02  7:54 [binutils-gdb] treat Ada DW_TAG_unspecified_type DIEs as stub types sergiodj+buildbot
2018-01-02 14:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-02  8:44 [binutils-gdb] Add support for dynamic DW_AT_byte_stride sergiodj+buildbot
2018-01-02 16:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-02  9:37 [binutils-gdb] [gdb/Ada] slices of arrays with dynamic strides sergiodj+buildbot
2018-01-02 18:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-02 12:52 [binutils-gdb] x86: partial revert of 10c17abdd0 sergiodj+buildbot
2018-01-02 20:45 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-02 17:37 [binutils-gdb] Fix compile time warning (in the ARM simulator) about a print statement with insufficient arguments sergiodj+buildbot
2018-01-02 23:00 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-03  4:17 [binutils-gdb] Unbreak spurious fails in gdb.base/step-line.exp sergiodj+buildbot
2018-01-03  5:13 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-03  7:50 [binutils-gdb] Update year range in copyright notice of binutils files sergiodj+buildbot
2018-01-03  8:06 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-03 10:27 [binutils-gdb] (Ada) New command to stop at start of exception handler sergiodj+buildbot
2018-01-03 10:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-03 20:29 [binutils-gdb] Create pseudo sections for FreeBSD NT_PROCSTAT_(PROC|FILES|VMMAP) notes sergiodj+buildbot
2018-01-03 20:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-04  8:52 [binutils-gdb] Add gdb.ada/info_addr_mixed_case new testcase sergiodj+buildbot
2018-01-04  9:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-04  9:35 [binutils-gdb] Add "complete break ada" test to gdb.ada/complete.exp sergiodj+buildbot
2018-01-04 12:13 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-04 10:28 [binutils-gdb] Add new gdb.ada/bp_c_mixed_case testcase for PR gdb/22670 sergiodj+buildbot
2018-01-04 14:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-04 11:13 [binutils-gdb] gdb.ada/maint_with_ada.exp: New testcase sergiodj+buildbot
2018-01-04 17:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-04 22:38 [binutils-gdb] RISC-V: Add 2 missing privileged registers sergiodj+buildbot
2018-01-04 22:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-05  5:59 [binutils-gdb] Bump version to 8.1.50.DATE-git sergiodj+buildbot
2018-01-05  8:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-05  6:37 [binutils-gdb] Update NEWS post GDB 8.1 branch creation sergiodj+buildbot
2018-01-05 10:55 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-05  7:31 [binutils-gdb] (Ada) Remove printing of array's first index when unneeded sergiodj+buildbot
2018-01-05 13:06 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-05 10:38 [binutils-gdb] memory error printing component of record from convenience variable sergiodj+buildbot
2018-01-05 14:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-05 11:59 [binutils-gdb] (Ada) Fix Length attribute on array access sergiodj+buildbot
2018-01-05 16:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-05 13:34 [binutils-gdb] (Ada) problem printing renaming which references a subprogram parameter sergiodj+buildbot
2018-01-05 19:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-05 17:13 [binutils-gdb] Fix gdb.ada/info_addr_mixed_case.exp (PR gdb/22670) sergiodj+buildbot
2018-01-05 22:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-05 18:57 [binutils-gdb] Fix gdb/spu-tdep.c build breakage sergiodj+buildbot
2018-01-06  1:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-05 19:58 [binutils-gdb] Fix regression: cannot start with LD_PRELOAD=libSegFault.so (PR gdb/18653#c7) sergiodj+buildbot
2018-01-06  4:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-06  2:13 [binutils-gdb] RISC-V: Print symbol address for jalr w/ zero offset sergiodj+buildbot
2018-01-06  7:36 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-07 14:48 [binutils-gdb] C++ify xmethod_worker, get rid of VEC(xmethod_worker_ptr) sergiodj+buildbot
2018-01-07 15:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-07 15:59 [binutils-gdb] Remove xmethod_worker::clone sergiodj+buildbot
2018-01-07 17:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-07 16:23 [binutils-gdb] Replace VEC(gdb_xml_value_s) with std::vector sergiodj+buildbot
2018-01-07 18:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-07 17:08 [binutils-gdb] Replace VEC(converted_character_d) with std::vector sergiodj+buildbot
2018-01-07 21:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-07 18:03 [binutils-gdb] Make parse_debug_format_options return an std::string sergiodj+buildbot
2018-01-07 23:30 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-07 18:45 [binutils-gdb] Replace objfile field in dwarf2_cu and dwarf2_per_cu_data with dwarf2_per_objfile sergiodj+buildbot
2018-01-08  1:05 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-07 19:29 [binutils-gdb] Remove dwarf2_per_objfile global sergiodj+buildbot
2018-01-08  3:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-07 20:11 [binutils-gdb] Remove dwarf2_cu::dwarf2_per_objfile sergiodj+buildbot
2018-01-08  5:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-08  5:16 [binutils-gdb] (Ada) Fix print of array using non-contiguous enumeration indexes sergiodj+buildbot
2018-01-08  6:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-08 10:02 [binutils-gdb] Relax expected output in gdb.ada/access_tagged_param.exp test sergiodj+buildbot
2018-01-08 10:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-08 10:42 [binutils-gdb] Fix GDB build failure when $development is false sergiodj+buildbot
2018-01-08 12:54 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-08 11:41 [binutils-gdb] Fix GDBserver build failure when $development is false sergiodj+buildbot
2018-01-08 14:38 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-08 13:11 [binutils-gdb] x86: Properly encode vmovd with 64-bit memeory sergiodj+buildbot
2018-01-08 19:42 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-08 16:52 [binutils-gdb] hurd: Add enough auxv support for AT_ENTRY for PIE binaries sergiodj+buildbot
2018-01-09  0:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-09  9:16 [binutils-gdb] PR22662, nds32: Fix a typographical error sergiodj+buildbot
2018-01-09  9:45 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-09 10:03 [binutils-gdb] Fix breakpoint add on inlined function using function name sergiodj+buildbot
2018-01-09 13:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-09 11:49 [binutils-gdb] Add support for the AArch64's CSDB instruction sergiodj+buildbot
2018-01-09 14:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-09 14:53 [binutils-gdb] [Arm] Add CSDB instruction sergiodj+buildbot
2018-01-09 17:05 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-09 22:14 [binutils-gdb] Support 'info proc' for FreeBSD process core dumps sergiodj+buildbot
2018-01-09 22:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-09 23:03 [binutils-gdb] Don't return stale data from fbsd_pid_to_exec_file for kernel processes sergiodj+buildbot
2018-01-10  0:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-09 23:38 [binutils-gdb] Use gdb::unique_xmalloc_ptr<> instead of a deleter that invokes free() sergiodj+buildbot
2018-01-10  3:42 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-10  0:28 [binutils-gdb] Support 'info proc' for native FreeBSD processes sergiodj+buildbot
2018-01-10  6:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-10  1:01 [binutils-gdb] Document support for 'info proc' on FreeBSD sergiodj+buildbot
2018-01-10  8:34 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-10  2:16 [binutils-gdb] RISC-V: Disassemble x0 based addresses as 0 sergiodj+buildbot
2018-01-10 10:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-10 14:11 [binutils-gdb] x86: fix Disp8 handling for AVX512VL VPCMP*{B, W} variants sergiodj+buildbot
2018-01-10 14:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-10 14:58 [binutils-gdb] x86: fix Disp8 handling for scalar AVX512_4FMAPS insns sergiodj+buildbot
2018-01-10 17:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-10 15:48 [binutils-gdb] Update the libiberty sources with the latest patches found in the master sources sergiodj+buildbot
2018-01-10 20:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-10 17:21 [binutils-gdb] Update top level configure files by synchronizing them with gcc sergiodj+buildbot
2018-01-10 21:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-10 23:32 [binutils-gdb] Fix gdb.ada/bp_c_mixed_case.exp (PR gdb/22670) sergiodj+buildbot
2018-01-10 23:53 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-11  0:21 [binutils-gdb] Fix gdb.ada/complete.exp's "complete break ada" test (PR gdb/22670) sergiodj+buildbot
2018-01-11  1:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-11  1:05 [binutils-gdb] Ada: make verbatim matcher override other language matchers (PR gdb/22670) sergiodj+buildbot
2018-01-11  4:28 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-11  1:53 [binutils-gdb] language_get_symbol_name_matcher -> get_symbol_name_matcher sergiodj+buildbot
2018-01-11  6:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-11  5:36 [binutils-gdb] Remove VL variants for 4FMAPS and 4VNNIW insns sergiodj+buildbot
2018-01-11 14:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-11  6:23 [binutils-gdb] Fix backwards compatibility with old GDBservers (PR remote/22597) sergiodj+buildbot
2018-01-11 16:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-11 18:02 [binutils-gdb] ld: Keep PREINIT_ARRAY/INIT_ARRAY/FINI_ARRAY sections for -r --gc-sections sergiodj+buildbot
2018-01-11 21:34 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-11 19:05 [binutils-gdb] gdb.base/breakpoint-in-ro-region.exp regression on sss targets (PR gdb/22583) sergiodj+buildbot
2018-01-11 23:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-11 23:57 [binutils-gdb] Ignore dynamic references on forced local symbols sergiodj+buildbot
2018-01-12  4:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-12  2:29 [binutils-gdb] gdb_compile_shlib: Only consider shlib= options when building executables sergiodj+buildbot
2018-01-12  6:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-12  3:25 [binutils-gdb] ld: Add "-z separate-code" option to ELF linker sergiodj+buildbot
2018-01-12  8:04 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-12  4:24 [binutils-gdb] ld: Create a new LOAD segment for separate code segment sergiodj+buildbot
2018-01-12 10:43 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-12 10:06 [binutils-gdb] _bfd_mips_elf_final_link: Notify user about wrong .reginfo size sergiodj+buildbot
2018-01-12 19:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-12 11:03 [binutils-gdb] Fixes for "Ignore dynamic references on forced local symbols" sergiodj+buildbot
2018-01-12 21:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-12 11:55 [binutils-gdb] Fix override of common symbols for a.out sergiodj+buildbot
2018-01-12 22:39 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-12 13:37 [binutils-gdb] Optimize the performance of the group_setup function sergiodj+buildbot
2018-01-13  0:13 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-12 19:19 [binutils-gdb] Fix GDB hang with remote after error from resume sergiodj+buildbot
2018-01-13  2:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-12 20:00 [binutils-gdb] Add testcase for GDB hang fixed by previous commit sergiodj+buildbot
2018-01-13  4:55 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-12 22:32 [binutils-gdb] Use the correct value for the offset of 'kve_protection' sergiodj+buildbot
2018-01-13 12:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-12 23:43 [binutils-gdb] Install and generate docs for gdb-add-index sergiodj+buildbot
2018-01-13 14:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-13  0:00 [binutils-gdb] gdb/testsuite: Don't attempt tests if they fail to compile sergiodj+buildbot
2018-01-13 16:42 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-13 13:46 [binutils-gdb] Add note about 2.30 branch creation to changelogs sergiodj+buildbot
2018-01-13 19:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-13 14:31 [binutils-gdb] Bump version number to 2.30.51 sergiodj+buildbot
2018-01-13 22:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-13 15:45 [binutils-gdb] Update pot files sergiodj+buildbot
2018-01-14  0:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-13 16:17 [binutils-gdb] Update notes on how to make a release sergiodj+buildbot
2018-01-14  3:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-15 12:32 [binutils-gdb] Update Ukranian translations for bfd, binutils, gas, gold, ld and opcodes sergiodj+buildbot
2018-01-15 12:49 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-15 20:05 [binutils-gdb] Fix scm-ports.exp regression sergiodj+buildbot
2018-01-15 21:29 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-15 23:14 [binutils-gdb] gdb/common/signals-state-save-restore.c: Fix typos sergiodj+buildbot
2018-01-16  1:38 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-16  0:18 [binutils-gdb] RISC-V: Add support for addi that compresses to c.nop sergiodj+buildbot
2018-01-16  3:30 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-16  9:25 [binutils-gdb] Mark register unavailable when PTRACE_PEEKUSER fails sergiodj+buildbot
2018-01-16 10:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-16 13:03 [binutils-gdb] Update translations for various binutils components sergiodj+buildbot
2018-01-16 13:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-17 11:10 [binutils-gdb] Warning fix sergiodj+buildbot
2018-01-17 11:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-17 11:56 [binutils-gdb] Relax gdb.compile/compile.exp to match the address printed for frame sergiodj+buildbot
2018-01-17 13:48 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-17 13:23 [binutils-gdb] Don't pass -m64 to libcc1 on aarch64-linux sergiodj+buildbot
2018-01-17 17:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-17 13:48 [binutils-gdb] configure: Fix test for fs_base/gs_base in <sys/user.h> sergiodj+buildbot
2018-01-17 22:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-17 16:08 [binutils-gdb] Update Ukranian and Russian translations in bfd library sergiodj+buildbot
2018-01-18  2:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-17 17:04 [binutils-gdb] Replace CET bit with IBT and SHSTK bits sergiodj+buildbot
2018-01-18  4:15 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-17 17:53 [binutils-gdb] linux-nat: Remove unnecessary xstrdup sergiodj+buildbot
2018-01-18  5:53 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-17 17:59 [binutils-gdb] Make linux_ptrace_attach_fail_reason return an std::string sergiodj+buildbot
2018-01-18  7:45 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-17 18:49 [binutils-gdb] Fix gdb segv when objfile can't be opened sergiodj+buildbot
2018-01-18  9:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-17 19:20 [binutils-gdb] Unify new_symbol and new_symbol_full sergiodj+buildbot
2018-01-18 12:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-17 19:45 [binutils-gdb] Allocate dwarf2_cu with new sergiodj+buildbot
2018-01-18 16:05 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-17 19:57 [binutils-gdb] Change dwarf2_cu::method_info to be a std::vector sergiodj+buildbot
2018-01-18 17:43 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-17 20:09 [binutils-gdb] Remove objfile argument from add_dyn_prop sergiodj+buildbot
2018-01-18 20:13 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-17 20:16 [binutils-gdb] Allocate abbrev_table with new sergiodj+buildbot
2018-01-18 14:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-17 20:21 [binutils-gdb] Remove symbolp typedef sergiodj+buildbot
2018-01-18 22:00 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-17 22:21 [binutils-gdb] RISC-V: Fix bug in prior addi/c.nop patch sergiodj+buildbot
2018-01-19  0:27 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-17 23:20 [binutils-gdb] Fix warning on gdb/compile/compile.c (C++-ify "triplet_rx") sergiodj+buildbot
2018-01-19  3:18 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-18 12:14 [binutils-gdb] PowerPC PLT stub alignment fixes sergiodj+buildbot
2018-01-19  8:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-18 12:35 [binutils-gdb] Call cooked_read in ppu2spu_prev_register sergiodj+buildbot
2018-01-19 10:58 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-18 15:43 [binutils-gdb] Make abbrev_table::abbrevs private sergiodj+buildbot
2018-01-19 14:04 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-18 18:56 [binutils-gdb] S390: Use soft float in s390-tdbregs test case sergiodj+buildbot
2018-01-19 15:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-18 19:09 [binutils-gdb] GDB testsuite: Re-enable -fdiagnostics-color=never sergiodj+buildbot
2018-01-19 18:38 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-19  6:21 [binutils-gdb] Make tests expect [ \t]+ pattern instead of \t for "info reg" command sergiodj+buildbot
2018-01-19 20:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-19  9:33 [binutils-gdb] Find arm-linux-gnueabi(hf)?-gcc in compile sergiodj+buildbot
2018-01-19 21:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-19 10:00 [binutils-gdb] Don't pass -m32 to libcc1 on arm-linux sergiodj+buildbot
2018-01-19 23:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-19 11:05 [binutils-gdb] Update French translation in bfd sub-directory sergiodj+buildbot
2018-01-20  1:44 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-19 13:35 [binutils-gdb] S390: Improve comments for s390-tdbregs test case sergiodj+buildbot
2018-01-20  5:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-19 17:17 [binutils-gdb] Remove args from target detach sergiodj+buildbot
2018-01-20  6:45 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-19 17:34 [binutils-gdb] Pass inferior down to target_detach and to_detach sergiodj+buildbot
2018-01-20  8:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-19 17:48 [binutils-gdb] Make linux_nat_detach/thread_db_detach use the inferior parameter sergiodj+buildbot
2018-01-20 11:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-19 19:04 [binutils-gdb] gdb: Fix ia64 defining TRAP_HWBKPT before including gdb_wait.h sergiodj+buildbot
2018-01-20 14:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-19 19:06 [binutils-gdb] gdb: Add missing #ifdef USE_THREAD_DB to gdbserver sergiodj+buildbot
2018-01-20 17:04 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-19 19:19 [binutils-gdb] S390: Fix infcalls in s390-vregs test case sergiodj+buildbot
2018-01-20 19:36 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-19 22:47 [binutils-gdb] Fix qualified name lookup for Rust sergiodj+buildbot
2018-01-20 21:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-20 22:46 [binutils-gdb] x86: Check the versioned __tls_get_addr symbol sergiodj+buildbot
2018-01-20 23:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-21 15:22 [binutils-gdb] gdb: Add test for some error cases of @entry usage sergiodj+buildbot
2018-01-21 15:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-21 16:05 [binutils-gdb] gdb: Remove duplicate declaration of global innermost_block sergiodj+buildbot
2018-01-21 17:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-21 16:42 [binutils-gdb] gdb: Remove out of date comment sergiodj+buildbot
2018-01-21 22:59 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-21 16:50 [binutils-gdb] gdb: New API for tracking innermost block sergiodj+buildbot
2018-01-21 19:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-21 17:01 [binutils-gdb] gdb: PR mi/20395: Fix -var-update for registers in frames 1 and up sergiodj+buildbot
2018-01-21 20:48 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-21 19:13 [binutils-gdb] gdb: Don't store a thread-id for floating varobj sergiodj+buildbot
2018-01-22  1:14 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-22  4:32 [binutils-gdb] wrong line number in breakpoint location sergiodj+buildbot
2018-01-22  4:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-22  5:10 [binutils-gdb] Ada/DWARF: Assume the Ada compiler produces descriptive type attributes sergiodj+buildbot
2018-01-22  7:00 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-22 11:23 [binutils-gdb] Don't call gdbarch_pseudo_register_read_value in jit.c sergiodj+buildbot
2018-01-22 11:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-22 11:47 [binutils-gdb] Replace regcache_raw_read with regcache->raw_read sergiodj+buildbot
2018-01-22 17:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-22 12:07 [binutils-gdb] Remove mt port sergiodj+buildbot
2018-01-22 14:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-22 12:12 [binutils-gdb] regcache::cooked_write test sergiodj+buildbot
2018-01-22 22:58 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-22 13:34 [binutils-gdb] regcache_cooked_read -> regcache->cooked_read sergiodj+buildbot
2018-01-22 20:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-22 15:56 [binutils-gdb] MAINTAINERS: Update my company e-mail address sergiodj+buildbot
2018-01-23  1:15 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-22 19:51 [binutils-gdb] Fix segfault with 'set print object on' + 'whatis <struct>' & co sergiodj+buildbot
2018-01-23  3:30 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-23 13:07 [binutils-gdb] s390: Remove duplicate checks for cached gdbarch at init sergiodj+buildbot
2018-01-23 13:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-23 13:15 [binutils-gdb] s390: Allocate gdbarch & tdep at start of gdbarch_init sergiodj+buildbot
2018-01-23 15:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-23 13:40 [binutils-gdb] s390: gdbarch_tdep add field tdesc sergiodj+buildbot
2018-01-23 19:29 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-23 14:30 [binutils-gdb] s390: Hook s390 into OSABI mechanism sergiodj+buildbot
2018-01-24  0:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-23 14:44 [binutils-gdb] s390: gdbarch_tdep add hook for syscall record sergiodj+buildbot
2018-01-24  2:43 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-23 14:44 [binutils-gdb] s390: gdbarch_tdep.have_* int -> bool sergiodj+buildbot
2018-01-23 17:15 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-23 14:57 [binutils-gdb] s390: Split up s390-linux-tdep.c into two files sergiodj+buildbot
2018-01-24  4:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-23 15:13 [binutils-gdb] s390: Move record-replay to s390-tdep.c sergiodj+buildbot
2018-01-24  5:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-23 15:28 [binutils-gdb] s390: Clean up s390-linux-tdep.c sergiodj+buildbot
2018-01-24  7:54 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-23 16:25 [binutils-gdb] s390: Move tdesc validation to separate function sergiodj+buildbot
2018-01-23 21:06 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-23 17:23 [binutils-gdb] s390: if -> gdb_assert for tdesc_has_registers check sergiodj+buildbot
2018-01-23 22:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-23 17:26 [binutils-gdb] Enable Intel WBNOINVD instruction sergiodj+buildbot
2018-01-24 10:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-23 17:39 [binutils-gdb] Enable Intel PCONFIG instruction sergiodj+buildbot
2018-01-24 12:48 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-23 19:18 [binutils-gdb] MIPS/BFD: Update a stale `mips_elf32_section_processing' reference sergiodj+buildbot
2018-01-24 15:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-24 16:36 [binutils-gdb] [GAS][AARCH64]Add group relocations to create PC-relative offset sergiodj+buildbot
2018-01-24 17:48 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-24 16:51 [binutils-gdb] [LD][AARCH64]Add group relocations to create PC-relative offset sergiodj+buildbot
2018-01-24 21:59 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-24 18:49 [binutils-gdb] Fix GCC PR83906 - [8 Regression] Random FAIL: libstdc++-prettyprinters/80276.cc whatis p4 sergiodj+buildbot
2018-01-24 23:37 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-25 11:35 [binutils-gdb] Fix PR ld/22727 (TLS breakage in PIC/PIE mode on SPARC) sergiodj+buildbot
2018-01-25 12:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-25 11:50 [binutils-gdb] PR22746, crash when running 32-bit objdump on corrupted file sergiodj+buildbot
2018-01-25 13:59 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-26  5:34 [binutils-gdb] PowerPC64 .branch_lt size change leads to "stubs don't match calculated size" sergiodj+buildbot
2018-01-26  5:54 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-26  5:59 [binutils-gdb] PowerPC PLT stub matching sergiodj+buildbot
2018-01-26  9:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-26  6:02 [binutils-gdb] Define __start/__stop symbols when there is only a dynamic def sergiodj+buildbot
2018-01-26  7:28 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-26 15:05 [binutils-gdb] Add myself as a write-after-approval GDB maintainer sergiodj+buildbot
2018-01-26 15:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-26 16:01 [binutils-gdb] Add myself as a write-after-approval GDB maintainer sergiodj+buildbot
2018-01-26 17:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-27 14:46 [binutils-gdb] Updated Russian translation for the bfd sub-directory sergiodj+buildbot
2018-01-27 15:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-27 16:43 [binutils-gdb] Avoid compilation warning in libiberty/simple-object-xcoff.c sergiodj+buildbot
2018-01-27 17:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-27 17:07 [binutils-gdb] Avoid compilation errors in MinGW native builds of GDB sergiodj+buildbot
2018-01-27 20:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-28 17:24 [binutils-gdb] Remove dwarf2_per_objfile_free and use after free of dwarf2_per_objfile sergiodj+buildbot
2018-01-28 17:35 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-29  5:45 [binutils-gdb] PR22741, objcopy segfault on fuzzed COFF object sergiodj+buildbot
2018-01-29  6:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-29 13:45 [binutils-gdb] Prevent patch remnants from being included in release tarballs sergiodj+buildbot
2018-01-29 13:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-29 18:21 [binutils-gdb] Don't call "detach_inferior" on "remote_follow_fork" sergiodj+buildbot
2018-01-29 19:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-30  0:09 [binutils-gdb] Make __start/__stop symbols dynamic and add testcase sergiodj+buildbot
2018-01-30  0:27 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-30  4:20 [binutils-gdb] gdb.base/break.exp: fix last "info break" test failure on Ubuntu 16.04 sergiodj+buildbot
2018-01-30  4:39 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-30  8:44 [binutils-gdb] PR22758, FAIL: Run pr22393-2 sergiodj+buildbot
2018-01-30  9:29 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-30 15:53 [binutils-gdb] linux-nat: Eliminate custom target_terminal_{inferior, ours}, stop using set_sigint_trap sergiodj+buildbot
2018-01-30 16:36 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-30 16:06 [binutils-gdb] Per-inferior target_terminal state, fix PR gdb/13211, more sergiodj+buildbot
2018-01-30 18:15 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-30 16:50 [binutils-gdb] s390: Fix gdb.base/all-architectures.exp with --enable-targets=all sergiodj+buildbot
2018-01-30 19:54 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-30 18:05 [binutils-gdb] Improve junk file removal in source tarball creation script sergiodj+buildbot
2018-01-30 22:15 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-31  7:35 [binutils-gdb] internal-error using '@' (repeat) operator on array of dynamic objects sergiodj+buildbot
2018-01-31  8:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-31 13:03 [binutils-gdb] (Ada) Add testcase for catch assert with condition sergiodj+buildbot
2018-01-31 13:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-31 13:16 [binutils-gdb] (Ada/MI) Add testcase for mi catch assert with condition sergiodj+buildbot
2018-01-31 14:58 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-31 13:41 [binutils-gdb] (Ada) Add gdb-mi support for stopping at start of exception handler sergiodj+buildbot
2018-01-31 20:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-31 13:56 [binutils-gdb] Check if __start/__stop symbols are referenced by shared objects sergiodj+buildbot
2018-01-31 22:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-31 13:56 [binutils-gdb] (Ada) C++fy conditional string when catching exception sergiodj+buildbot
2018-01-31 17:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-31 15:00 [binutils-gdb] bfd_elf_define_start_stop: Fix check sergiodj+buildbot
2018-02-01  0:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-31 15:21 [binutils-gdb] gdb: Fix remote-sim/MinGW/Darwin builds sergiodj+buildbot
2018-02-01  2:58 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-01-31 18:40 [binutils-gdb] Fix for prologue processing on PowerPC sergiodj+buildbot
2018-02-01  4:48 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-01 13:38 [binutils-gdb] Fix compile time warnings building the binutils with clang sergiodj+buildbot
2018-02-01 13:58 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-01 15:05 [binutils-gdb] Fix gdb.base/attach.exp fails when gdb is configured --with-sysroot=/ sergiodj+buildbot
2018-02-01 15:54 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-01 15:47 [binutils-gdb] set ret signed in arm_record_extension_space sergiodj+buildbot
2018-02-01 18:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-01 16:11 [binutils-gdb] Rewrite arm_record_coproc_data_proc and arm_record_data_proc_misc_ld_str sergiodj+buildbot
2018-02-01 20:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-02  3:50 [binutils-gdb] Do not classify C struct members as a filename sergiodj+buildbot
2018-02-02  4:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-02 12:31 [binutils-gdb] PowerPC64, don't relocate nops sergiodj+buildbot
2018-02-02 12:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-02 19:21 [binutils-gdb] MI: Allow non-raw varobj evaluation sergiodj+buildbot
2018-02-02 19:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-02 20:58 [binutils-gdb] RISC-V: Fix --wrap and relaxation conflict sergiodj+buildbot
2018-02-02 21:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-03 17:11 [binutils-gdb] gdb/testsuite: Remove use of dejagnu cleanup proc sergiodj+buildbot
2018-02-03 17:30 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-05  5:03 [binutils-gdb] Move comment in gdb/dwarf2read.c::dwarf2_physname sergiodj+buildbot
2018-02-05  5:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-05  8:46 [binutils-gdb] Align natural-format register values to the same column sergiodj+buildbot
2018-02-05  9:54 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-05 13:23 [binutils-gdb] Updated Brazillian portuguese and Russian translation sergiodj+buildbot
2018-02-05 13:42 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-05 14:17 [binutils-gdb] ELF/BFD: Propagate the return status from backend section processing sergiodj+buildbot
2018-02-05 16:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-05 14:29 [binutils-gdb] MIPS/BFD: Correctly report unsupported `.reginfo' section size sergiodj+buildbot
2018-02-05 20:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-05 14:42 [binutils-gdb] RISC-V/BFD: Correct a missing initializer error with pre-4.7 GCC sergiodj+buildbot
2018-02-05 22:30 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-05 16:54 [binutils-gdb] Use visitors for make_gdb_type sergiodj+buildbot
2018-02-06  0:06 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-05 17:05 [binutils-gdb] x86: Remove the unused _GLOBAL_OFFSET_TABLE_ sergiodj+buildbot
2018-02-06  2:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-05 18:11 [binutils-gdb] Remove myself as a write-after-approval GDB maintainer sergiodj+buildbot
2018-02-06  3:58 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-05 18:56 [binutils-gdb] [PR22764][LD][AARCH64]Allow R_AARCH64_ABS16 and R_AARCH64_ABS32 against absolution symbol or undefine symbol in shared object sergiodj+buildbot
2018-02-06  5:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-05 19:45 [binutils-gdb] ppc64: Fix stwux encoding sergiodj+buildbot
2018-02-06  7:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-06 16:04 [binutils-gdb] Allow the find_abstract_instance_name() function in the BFD library to also return file and line number information sergiodj+buildbot
2018-02-06 16:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-06 16:48 [binutils-gdb] Prevent attempts to call strncpy with a zero-length field by chacking the size of debuglink sections sergiodj+buildbot
2018-02-06 19:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-06 17:02 [binutils-gdb] Fix GCC 8's -Wstringop-overflow on bfd/coff-rs6000.c sergiodj+buildbot
2018-02-06 21:48 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-06 17:17 [binutils-gdb] Improve the find_nearest_line function for the MIPS target so that it tries harder to find a function name sergiodj+buildbot
2018-02-06 23:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-06 17:29 [binutils-gdb] Treat OP_F77_UNDETERMINED_ARGLIST as OP_FUNCALL sergiodj+buildbot
2018-02-07  1:49 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-06 17:43 [binutils-gdb] Fix PR ld/22263 on SPARC sergiodj+buildbot
2018-02-07  4:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-06 20:29 [binutils-gdb] Remove some $ARCH_read_pc and $ARCH_write_pc sergiodj+buildbot
2018-02-07  5:54 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-07  1:08 [binutils-gdb] RISC-V: Eliminate spurious error w/ reloc truncated message sergiodj+buildbot
2018-02-07  8:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-07  4:11 [binutils-gdb] Revert "PowerPC PLT speculative execution barriers" sergiodj+buildbot
2018-02-07 10:38 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-07 14:04 [binutils-gdb] Fix type of values representing optimized out static members sergiodj+buildbot
2018-02-07 14:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-08 10:45 [binutils-gdb] Fix a seg-fault in the ELF note parser when a note with an excessively large alignment is encountered sergiodj+buildbot
2018-02-08 11:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-08 19:05 [binutils-gdb] Remove a cleanup from gdbserver sergiodj+buildbot
2018-02-08 19:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-08 19:18 [binutils-gdb] Remove make_cleanup_restore_current_thread from gdbserver sergiodj+buildbot
2018-02-08 21:36 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-08 19:32 [binutils-gdb] Return unique_xmalloc_ptr from macro scope functions sergiodj+buildbot
2018-02-09  0:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-08 20:13 [binutils-gdb] Remove cleanups from macro_define_command sergiodj+buildbot
2018-02-09  5:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-08 20:25 [binutils-gdb] Use gdb::def_vector in find_source_lines sergiodj+buildbot
2018-02-09  7:29 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-08 20:47 [binutils-gdb] Class-ify macro_buffer sergiodj+buildbot
2018-02-09  1:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-08 21:32 [binutils-gdb] RISC-V: Add comment for previous change sergiodj+buildbot
2018-02-09 13:35 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-08 22:04 [binutils-gdb] Use std::string in maybe_expand sergiodj+buildbot
2018-02-09  3:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-08 23:17 [binutils-gdb] Remove cleanups from solib.c sergiodj+buildbot
2018-02-09 11:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-09  0:11 [binutils-gdb] Use unique_xmalloc_ptr in build_id_to_debug_bfd sergiodj+buildbot
2018-02-09  9:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-09  0:47 [binutils-gdb] x86: Keep the unused _GLOBAL_OFFSET_TABLE_ for Solaris sergiodj+buildbot
2018-02-09 15:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-09  1:04 [binutils-gdb] x86: Set need_global_offset_table with info->output_bfd->xvec sergiodj+buildbot
2018-02-09 17:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-09 12:24 [binutils-gdb] gdb/NEWS: Clarify the news entry for "rbreak" in GDB 8.1 sergiodj+buildbot
2018-02-09 19:28 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-09 13:19 [binutils-gdb] Use std::string in execute_script_contents sergiodj+buildbot
2018-02-10  0:02 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-09 13:31 [binutils-gdb] Use gdb::unique_xmalloc_ptr in auto_load_section_scripts sergiodj+buildbot
2018-02-10  3:59 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-09 13:44 [binutils-gdb] common: add scoped_fd sergiodj+buildbot
2018-02-10  5:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-09 14:22 [binutils-gdb] btrace: prepare for throwing exceptions when enabling btrace sergiodj+buildbot
2018-02-10 10:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-09 14:47 [binutils-gdb] btrace, gdbserver: remove the to_supports_btrace target method sergiodj+buildbot
2018-02-10 15:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-09 15:00 [binutils-gdb] btrace: improve enable error messages sergiodj+buildbot
2018-02-10 17:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-09 15:12 [binutils-gdb] btrace: check perf_event_paranoid sergiodj+buildbot
2018-02-10 20:44 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-09 15:25 [binutils-gdb] btrace: reword error messages sergiodj+buildbot
2018-02-10 22:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-09 15:52 [binutils-gdb] common: add scoped_mmap sergiodj+buildbot
2018-02-10  7:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-09 16:32 [binutils-gdb] btrace, gdbserver: use exceptions to convey btrace enable/disable errors sergiodj+buildbot
2018-02-10 12:38 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-09 17:02 [binutils-gdb] x86: Add is_solaris to elf_x86_target_os sergiodj+buildbot
2018-02-11  2:34 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-09 19:26 [binutils-gdb] Don't reference past the end of the vector sergiodj+buildbot
2018-02-11  0:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-10  2:13 [binutils-gdb] Fix GOT relocation overflow on SPARC sergiodj+buildbot
2018-02-11  4:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-12 12:16 [binutils-gdb] oops - actually remove the assignment this time: bfd/elf32-nds32.c:9693]: (warning) Redundant assignment of 'irel->r_addend' to itself sergiodj+buildbot
2018-02-12 13:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-12 12:31 [binutils-gdb] Fix compile time warning: bfd/elf32-arc.c:1537]: (warning) Redundant assignment of 'rel->r_offset' to itself sergiodj+buildbot
2018-02-12 15:36 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-12 13:36 [binutils-gdb] Add support for reading msdos MZ executables sergiodj+buildbot
2018-02-12 18:02 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-12 15:14 [binutils-gdb] MIPS: Fix encoding for MIPSr6 sigrie instruction sergiodj+buildbot
2018-02-12 21:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-13  0:11 [binutils-gdb] gdb: Remove cleanup from dw2_do_instantiate_symtab sergiodj+buildbot
2018-02-13  1:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-13  6:47 [binutils-gdb] Fix prefix of maint set/show per-command sergiodj+buildbot
2018-02-13  6:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-13  9:23 [binutils-gdb] PR22829, objcopy/strip removes PT_GNU_RELRO from lld binaries sergiodj+buildbot
2018-02-13 10:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-13 12:41 [binutils-gdb] PR22836, "-r -s" doesn't work with -g3 using GCC 7 sergiodj+buildbot
2018-02-13 13:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-13 13:28 [binutils-gdb] WebAssembly: Correct an `index' global shadowing error for pre-4.8 GCC sergiodj+buildbot
2018-02-13 14:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-13 13:31 [binutils-gdb] WebAssembly: Disable subdirectory configuration for unsupported LD sergiodj+buildbot
2018-02-13 17:27 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-13 13:43 [binutils-gdb] Fix compile time warning messages from gcc version 8 about cast between incompatible function types sergiodj+buildbot
2018-02-13 19:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-13 15:41 [binutils-gdb] Fix typo in Russian translation for the bfd/ sub-directory which could lead to a seg-fault in the linker sergiodj+buildbot
2018-02-13 21:44 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-13 15:51 [binutils-gdb] x86-64: Generate branch with PLT32 relocation sergiodj+buildbot
2018-02-13 23:22 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-13 17:36 [binutils-gdb] Use enum flags for flags passed to openp sergiodj+buildbot
2018-02-14  1:04 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-13 22:52 [binutils-gdb] x86: Properly check building shared library sergiodj+buildbot
2018-02-14  2:43 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-14 11:04 [binutils-gdb] Remove references to ada_name_for_lookup (deleted) sergiodj+buildbot
2018-02-14 12:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-14 12:04 [binutils-gdb] x86-64: Use PLT address for PC-relative reloc sergiodj+buildbot
2018-02-14 14:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-14 15:16 [binutils-gdb] Fix compilation of the BFD sub-directory with a gcc v8 compiler by adding extra casts sergiodj+buildbot
2018-02-14 16:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-14 15:37 [binutils-gdb] Return unique_xmalloc_ptr from some solib.c functions sergiodj+buildbot
2018-02-14 18:18 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-14 15:50 [binutils-gdb] Move some declarations to source.h sergiodj+buildbot
2018-02-14 20:55 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-14 16:02 [binutils-gdb] Change openp et al to use a unique_xmalloc_ptr sergiodj+buildbot
2018-02-14 23:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-14 16:14 [binutils-gdb] Constify target_so_ops::bfd_open sergiodj+buildbot
2018-02-15  0:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-14 19:26 [binutils-gdb] Fix GDB crash after Quit thrown from unwinder sniffer sergiodj+buildbot
2018-02-15  2:55 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-15  4:34 [binutils-gdb] delete ada-lang.c::ada_to_fixed_value_create advance declaration sergiodj+buildbot
2018-02-15  4:34 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-15 15:04 [binutils-gdb] Reset inferior::control on inferior exit sergiodj+buildbot
2018-02-15 15:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-15 15:29 [binutils-gdb] PR ld/22832 on SPARC sergiodj+buildbot
2018-02-15 19:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-15 19:14 [binutils-gdb] RISC-V: Give error for ignored pcrel_lo addend sergiodj+buildbot
2018-02-15 20:54 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-15 22:04 [binutils-gdb] RISC-V: Fix relocation failure with zero address sections sergiodj+buildbot
2018-02-15 23:11 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-16  8:56 [binutils-gdb] Remove bfd stub function casts sergiodj+buildbot
2018-02-16  9:38 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-16 16:34 [binutils-gdb] New class allocate_on_obstack sergiodj+buildbot
2018-02-16 17:29 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-17  0:02 [binutils-gdb] Ignore degenerate PT_LOAD segments sergiodj+buildbot
2018-02-17  0:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-19  3:38 [binutils-gdb] PT_LOAD and PT_GNU_RELRO segment overlap sergiodj+buildbot
2018-02-19  3:58 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-20 11:13 [binutils-gdb] Fix make 3.81 build errors sergiodj+buildbot
2018-02-20 11:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-20 13:30 [binutils-gdb] btrace, testsuite: do not force BTS sergiodj+buildbot
2018-02-20 13:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-20 13:39 [binutils-gdb] gnulib: import mkstemp sergiodj+buildbot
2018-02-20 15:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-20 14:56 [binutils-gdb] Enable link time garbage collection support for the IA64 target sergiodj+buildbot
2018-02-20 17:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-20 16:58 [binutils-gdb] remote-sim: Add missing ATTRIBUTE_PRINTF sergiodj+buildbot
2018-02-20 19:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-20 21:11 [binutils-gdb] MIPS16/opcodes: Free up `M' operand code sergiodj+buildbot
2018-02-20 21:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-21 11:39 [binutils-gdb] Class reg_buffer sergiodj+buildbot
2018-02-21 12:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-21 11:47 [binutils-gdb] class readable_regcache and pass readable_regcache to gdbarch pseudo_register_read and pseudo_register_read_value sergiodj+buildbot
2018-02-21 14:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-21 12:00 [binutils-gdb] Remove regcache_save and regcache_cpy sergiodj+buildbot
2018-02-21 17:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-21 12:12 [binutils-gdb] Class readonly_detached_regcache sergiodj+buildbot
2018-02-21 20:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-21 12:25 [binutils-gdb] Class detached_regcache sergiodj+buildbot
2018-02-21 22:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-21 12:37 [binutils-gdb] Replace regcache::dump with class register_dump sergiodj+buildbot
2018-02-22  0:58 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-21 12:50 [binutils-gdb] No longer create readonly regcache sergiodj+buildbot
2018-02-22  3:15 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-21 13:02 [binutils-gdb] Remove regcache::m_readonly_p sergiodj+buildbot
2018-02-22  5:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-21 13:27 [binutils-gdb] Pass readable_regcache to gdbarch method read_pc sergiodj+buildbot
2018-02-22  8:55 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-21 15:39 [binutils-gdb] Move register_dump to regcache-dump.c sergiodj+buildbot
2018-02-22  7:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-21 16:31 [binutils-gdb] Remove a cleanup from parse_expression_for_completion sergiodj+buildbot
2018-02-22 14:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-21 17:11 [binutils-gdb] Remove a cleanup from call_function_by_hand_dummy sergiodj+buildbot
2018-02-22 11:34 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-21 19:23 [binutils-gdb] Add "common-defs.h" include to files in arch/ subdir not yet including it sergiodj+buildbot
2018-02-22 16:43 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-21 20:49 [binutils-gdb] Fix a typo sergiodj+buildbot
2018-02-22 19:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-22 14:40 [binutils-gdb] x86: Add {rex} pseudo prefix sergiodj+buildbot
2018-02-22 22:02 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-22 19:44 [binutils-gdb] RISC-V: Make disassebler work for --enable-targets=all config sergiodj+buildbot
2018-02-22 23:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-22 22:16 [binutils-gdb] New plugin interface to get list of symbols wrapped with --wrap option sergiodj+buildbot
2018-02-23  1:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-23  7:38 [binutils-gdb] nds32: Support target directive .ict_model sergiodj+buildbot
2018-02-23  7:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-23 11:31 [binutils-gdb] PR22881, null pointer dereference in assign_file_positions_for_non_load_sections sergiodj+buildbot
2018-02-23 12:36 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-23 18:26 [binutils-gdb] dwarf: Make sect_offset 64-bits sergiodj+buildbot
2018-02-23 18:39 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-23 20:31 [binutils-gdb] GDB/testsuite: Fix a typo in $actual_line sergiodj+buildbot
2018-02-23 21:29 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-24 17:19 [binutils-gdb] Remove cleanups from check_fast_tracepoint_sals sergiodj+buildbot
2018-02-24 17:37 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-24 17:31 [binutils-gdb] Remove most cleanups from linux-thread-db.c sergiodj+buildbot
2018-02-24 20:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-25 20:37 [binutils-gdb] Fix double space expected in cp_test_ptype_class sergiodj+buildbot
2018-02-25 20:49 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-25 23:25 [binutils-gdb] PPC error/warning messages sergiodj+buildbot
2018-02-26  0:00 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26  0:13 [binutils-gdb] unrecognized/unsupported reloc message sergiodj+buildbot
2018-02-26  2:14 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26  0:14 [binutils-gdb] ELF linker messages sergiodj+buildbot
2018-02-26  4:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26  0:38 [binutils-gdb] MIPS messages sergiodj+buildbot
2018-02-26  6:22 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26  0:53 [binutils-gdb] ARM and AArch64 messages sergiodj+buildbot
2018-02-26  8:15 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26  1:03 [binutils-gdb] AOUT/COFF/PE messages sergiodj+buildbot
2018-02-26 10:36 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26  1:16 [binutils-gdb] BFD messages sergiodj+buildbot
2018-02-26 13:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26  1:28 [binutils-gdb] assorted target messages sergiodj+buildbot
2018-02-26 15:15 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26  1:40 [binutils-gdb] crx string overflow warning sergiodj+buildbot
2018-02-26 17:11 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26  1:53 [binutils-gdb] Segfault on phdrs allocated but not created sergiodj+buildbot
2018-02-26 19:54 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26 12:02 [binutils-gdb] Move arch/tdesc.h to common/tdesc.h sergiodj+buildbot
2018-02-26 22:15 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26 15:54 [binutils-gdb] Re-write partial_die_info allocation in load_partial_dies sergiodj+buildbot
2018-02-27  0:15 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26 16:32 [binutils-gdb] Class-fy partial_die_info sergiodj+buildbot
2018-02-27  6:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26 16:36 [binutils-gdb] Don't check abbrev is NULL in read_partial_die sergiodj+buildbot
2018-02-27  2:11 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26 17:16 [binutils-gdb] Initial support for variant parts sergiodj+buildbot
2018-02-27 14:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26 17:35 [binutils-gdb] Change find_partial_die_in_comp_unit to dwarf2_cu::find_partial_die sergiodj+buildbot
2018-02-27  4:11 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26 17:54 [binutils-gdb] Make "bt N" print correct number of frames when using a frame filter sergiodj+buildbot
2018-02-27 20:39 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26 18:06 [binutils-gdb] Change frame_filter_flags to use DEF_ENUM_FLAGS_TYPE sergiodj+buildbot
2018-02-27 22:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26 18:41 [binutils-gdb] Move read_partial_die to partial_die_info::read sergiodj+buildbot
2018-02-27  9:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26 19:59 [binutils-gdb] MIPS: Reorder ABI determination ahead of target description loading sergiodj+buildbot
2018-02-28  0:55 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26 20:30 [binutils-gdb] MIPS: Don't use a 32-bit BFD architecture with a 64-bit ABI sergiodj+buildbot
2018-02-28  2:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26 21:31 [binutils-gdb] Convert Rust to use discriminated unions sergiodj+buildbot
2018-02-27 16:05 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-26 22:19 [binutils-gdb] IA-64: Fix linker error with --no-keep-memory sergiodj+buildbot
2018-02-28  6:05 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-27  0:14 [binutils-gdb] Handle DW_TAG_variant_part and DW_TAG_variant sergiodj+buildbot
2018-02-27 18:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-27  0:40 [binutils-gdb] Add test for load command sergiodj+buildbot
2018-02-28  3:29 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-27 10:41 [binutils-gdb] Have info_to_howto functions return a success/fail status. Check this result. Stop strip from completeing if one of these functions fails sergiodj+buildbot
2018-02-28  7:22 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-27 12:32 [binutils-gdb] Use standardized error message for unrecognized relocs sergiodj+buildbot
2018-02-28  8:43 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-27 16:36 [binutils-gdb] x86: Add -O[2|s] assembler command-line options sergiodj+buildbot
2018-02-28 10:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-27 16:46 [binutils-gdb] Explicitly specify common tdesc.h for use with aarch64.h sergiodj+buildbot
2018-02-28 12:30 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-27 16:59 [binutils-gdb] [ARM] Remove ARM_FEATURE_COPY macro sergiodj+buildbot
2018-02-28 13:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-27 19:20 [binutils-gdb] Change target_write_memory_blocks to use std::vector sergiodj+buildbot
2018-02-28 15:04 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-27 20:21 [binutils-gdb] ld: Add --enable-separate-code sergiodj+buildbot
2018-02-28 16:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-27 21:14 [binutils-gdb] Update get_args documentation sergiodj+buildbot
2018-02-28 17:37 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-28  1:47 [binutils-gdb] Workaround a FreeBSD ptrace() bug with clearing thread events sergiodj+buildbot
2018-02-28 18:54 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-28  7:57 [binutils-gdb] Nonsense error messages on invalid aout string offset sergiodj+buildbot
2018-02-28 20:11 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-28 10:29 [binutils-gdb] Fix potential integer overflow when reading corrupt dwarf1 debug information sergiodj+buildbot
2018-02-28 21:28 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-28 12:05 [binutils-gdb] PR22887, null pointer dereference in aout_32_swap_std_reloc_out sergiodj+buildbot
2018-02-28 22:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-28 12:18 [binutils-gdb] Catch integer overflows/underflows when parsing corrupt DWARF FORM blocks sergiodj+buildbot
2018-03-01  0:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-28 14:13 [binutils-gdb] testsuite: Restore gdb_is_target_remote_prompt sergiodj+buildbot
2018-03-01  1:18 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-28 17:02 [binutils-gdb] Create new common/pathstuff.[ch] sergiodj+buildbot
2018-03-01  2:35 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-28 17:06 [binutils-gdb] Make gdbserver work with filename-only binaries sergiodj+buildbot
2018-03-01  3:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-28 17:19 [binutils-gdb] Change order of error message printed when gdbserver can't find CWD sergiodj+buildbot
2018-03-01  5:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-28 23:16 [binutils-gdb] correct ft32 reloc range test sergiodj+buildbot
2018-03-01  6:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-02-28 23:57 [binutils-gdb] Add missing translations to ALL_LINGUAS sergiodj+buildbot
2018-03-01  7:43 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-01 11:41 [binutils-gdb] btrace, gdbserver: check btrace target pointers sergiodj+buildbot
2018-03-01 12:55 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-01 14:29 [binutils-gdb] x86: Encode AVX256/AVX512 vpsub[bwdq] with VEX128/EVEX128 sergiodj+buildbot
2018-03-01 14:37 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-01 16:07 [binutils-gdb] Propagate record_print_flags sergiodj+buildbot
2018-03-01 16:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-01 16:51 [binutils-gdb] Fix Rust enum test failures sergiodj+buildbot
2018-03-01 17:35 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-01 22:37 [binutils-gdb] RISC-V: Fix symbol size bug when relaxation deletes bytes sergiodj+buildbot
2018-03-01 23:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-01 22:44 [binutils-gdb] Improve gcore shell quoting and portability sergiodj+buildbot
2018-03-02  0:44 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-02 11:03 [binutils-gdb] Ensure 8-byte alignment for AArch64 stubs sergiodj+buildbot
2018-03-02 11:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-02 12:07 [binutils-gdb] [GDB/testsuite] Use %progbits in watch-loc.c sergiodj+buildbot
2018-03-02 12:34 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-02 12:46 [binutils-gdb] Conditionally include "<windows.h>" on common/pathstuff.c (and unbreak build on mingw*) sergiodj+buildbot
2018-03-02 13:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-03  1:20 [binutils-gdb] opcodes error messages sergiodj+buildbot
2018-03-03  1:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-03  4:46 [binutils-gdb] Make delim_string_to_char_ptr_vec return an std::vector sergiodj+buildbot
2018-03-03  4:53 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-03  4:53 [binutils-gdb] C++ify program_space sergiodj+buildbot
2018-03-03  6:11 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-03  5:05 [binutils-gdb] Make program_space::deleted_solibs a vector of std::string sergiodj+buildbot
2018-03-03  7:27 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-03  5:17 [binutils-gdb] C++ify charsets sergiodj+buildbot
2018-03-03  8:54 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-03  5:54 [binutils-gdb] handle_general_set: Remove useless xstrdup sergiodj+buildbot
2018-03-03 12:11 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-03  8:16 [binutils-gdb] Remove free_char_ptr_vec sergiodj+buildbot
2018-03-03 10:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-03 16:07 [binutils-gdb] PR ld/21900: MIPS: Fix relocation processing with undefined symbols sergiodj+buildbot
2018-03-03 16:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-04  5:54 [binutils-gdb] Implement "to_stopped_by_hw_breakpoint" for x86 debug registers sergiodj+buildbot
2018-03-04  6:05 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-04  6:07 [binutils-gdb] Add a new debug knob for the FreeBSD native target sergiodj+buildbot
2018-03-04  7:22 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-04  6:38 [binutils-gdb] Use signal information to determine SIGTRAP type for FreeBSD sergiodj+buildbot
2018-03-04  8:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-05  1:19 [binutils-gdb] Propagate gdb_disassembly_flags to btrace_print_lines sergiodj+buildbot
2018-03-05  1:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-06 10:29 [binutils-gdb] gdb/amd64: Ignore zero sized fields when calling functions sergiodj+buildbot
2018-03-06 10:42 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-06 14:36 [binutils-gdb] gdb/riscv: Additional print format string fixes sergiodj+buildbot
2018-03-06 15:00 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-06 15:11 [binutils-gdb] btrace: Remove btrace disable cleanup sergiodj+buildbot
2018-03-06 17:36 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-06 15:24 [binutils-gdb] btrace: Remove VEC cleanups sergiodj+buildbot
2018-03-06 19:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-06 15:28 [binutils-gdb] gdb/riscv: Fix type when reading register from regcache sergiodj+buildbot
2018-03-06 16:18 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-06 17:58 [binutils-gdb] btrace: Remove ui_out cleanups sergiodj+buildbot
2018-03-06 20:18 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-06 19:45 [binutils-gdb] gdb/riscv: Remove use of pseudo registers sergiodj+buildbot
2018-03-06 21:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-06 20:09 [binutils-gdb] gdb/riscv: Remove partial target description support sergiodj+buildbot
2018-03-07  0:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-06 20:30 [binutils-gdb] gdb/riscv: Remove 'Contributed by....' comments sergiodj+buildbot
2018-03-06 23:00 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-06 21:53 [binutils-gdb] Formatting fixes in rust-exp.y sergiodj+buildbot
2018-03-07  1:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-07  7:01 [binutils-gdb] mips64 rtype_to_howto error status sergiodj+buildbot
2018-03-07  7:13 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-07  7:12 [binutils-gdb] XCOFF disassembler sergiodj+buildbot
2018-03-07  8:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-07 13:44 [binutils-gdb] Fix watching structs in C++ sergiodj+buildbot
2018-03-07 14:00 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-07 17:03 [binutils-gdb] [PR20402][LD][AARCH64]Don't emit RELATIVE relocation for absolute symbols which are resolved at static linking time sergiodj+buildbot
2018-03-07 17:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-07 17:55 [binutils-gdb] gdb: Add riscv to list of architectures with a save_reggroup sergiodj+buildbot
2018-03-07 18:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-07 23:02 [binutils-gdb] Return gdb::optional<std::string> from target_fileio_readlink sergiodj+buildbot
2018-03-07 23:14 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-08  7:42 [binutils-gdb] x86: fold AVX vcvtpd2ps memory forms sergiodj+buildbot
2018-03-08  7:55 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-08  8:06 [binutils-gdb] x86/Intel: correct disassembly of fsub*/fdiv* sergiodj+buildbot
2018-03-08 10:39 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-08  8:27 [binutils-gdb] x86: bogus VMOVD with 64-bit operands should only allow for registers sergiodj+buildbot
2018-03-08  9:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-08  8:43 [binutils-gdb] x86: drop bogus NoAVX sergiodj+buildbot
2018-03-08 14:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-08  8:54 [binutils-gdb] x86: drop {X,Y,Z}MMWORD_MNEM_SUFFIX sergiodj+buildbot
2018-03-08 15:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-08  9:07 [binutils-gdb] x86: fold FMA and FMA4 templates sergiodj+buildbot
2018-03-08 17:39 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-08  9:32 [binutils-gdb] x86: fold a few AVX512F templates sergiodj+buildbot
2018-03-08 22:35 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-08  9:44 [binutils-gdb] x86: fold VEX-encoded GFNI templates sergiodj+buildbot
2018-03-09  0:18 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-08  9:56 [binutils-gdb] x86: fold certain AVX512 rotate and shift templates sergiodj+buildbot
2018-03-09  3:02 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-08 10:21 [binutils-gdb] Remove MAX_REGISTER_SIZE define sergiodj+buildbot
2018-03-09  6:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-08 10:37 [binutils-gdb] x86: avoid SSE check for LDMXCSR/STMXCSR sergiodj+buildbot
2018-03-08 13:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-08 13:06 [binutils-gdb] x86: fold LWP templates sergiodj+buildbot
2018-03-08 20:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-08 14:48 [binutils-gdb] x86: Remove support for old (<= 2.8.1) versions of gcc sergiodj+buildbot
2018-03-09  8:22 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-08 15:00 [binutils-gdb] x86: Treat relocation against IFUNC symbol as FUNC sergiodj+buildbot
2018-03-09  9:49 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-08 16:07 [binutils-gdb] x86: fold several AVX512VL templates sergiodj+buildbot
2018-03-09  5:06 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-08 20:05 [binutils-gdb] x86-64: Also optimize "clr reg64" sergiodj+buildbot
2018-03-09 11:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-08 23:13 [binutils-gdb] Don't redefine upload/download/file in gdbserver-base sergiodj+buildbot
2018-03-09 12:37 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-08 23:24 [binutils-gdb] remote-stdio-gdbserver: Pass "target" to remote_exec to delete file sergiodj+buildbot
2018-03-09 13:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-08 23:36 [binutils-gdb] linux_qxfer_libraries_svr4: Use std::string sergiodj+buildbot
2018-03-09 15:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-08 23:48 [binutils-gdb] Add xml_escape_text_append and use it sergiodj+buildbot
2018-03-09 16:34 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-09  0:12 [binutils-gdb] Make find_separate_debug_file* return std::string sergiodj+buildbot
2018-03-09 17:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-09  0:25 [binutils-gdb] Use std::string to simplify build_id_to_debug_bfd sergiodj+buildbot
2018-03-09 19:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-09  0:49 [binutils-gdb] Fix misreporting of omitted bytes for large remote packets sergiodj+buildbot
2018-03-09 20:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-09  5:14 [binutils-gdb] Change enable_thread_stack_temporaries to an RAII class sergiodj+buildbot
2018-03-09 21:43 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-09  5:23 [binutils-gdb] Use scoped_fd in more places sergiodj+buildbot
2018-03-09 23:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-09 14:17 [binutils-gdb] Update "gdb --configuration" with recently added features sergiodj+buildbot
2018-03-10  0:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-09 15:01 [binutils-gdb] Fix Sparc, s390 and AArch64 targets so that they can handle relocs against ifunc symbols found in note sections sergiodj+buildbot
2018-03-10  1:35 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-12  3:22 [binutils-gdb] Remove cleanup from build_type_psymtabs_1 sergiodj+buildbot
2018-03-12  3:38 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-12  3:49 [binutils-gdb] Use std::vector for field lists in dwarf2read.c sergiodj+buildbot
2018-03-12  4:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-12  9:32 [binutils-gdb] Fix ia64 GDB build sergiodj+buildbot
2018-03-12  9:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-12 14:44 [binutils-gdb] Use gdb::byte_vector when reading section data sergiodj+buildbot
2018-03-12 14:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-12 22:14 [binutils-gdb] gdb/riscv: Fix some ARI issues sergiodj+buildbot
2018-03-12 22:29 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-13 14:19 [binutils-gdb] Prevent memory access violations when attempting to parse an x86_64 PE binary containing corrupt unwind information sergiodj+buildbot
2018-03-13 15:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-13 17:14 [binutils-gdb] Updated Russian and Brazilian Portuguese translations sergiodj+buildbot
2018-03-13 17:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-13 23:55 [binutils-gdb] Remove two cleanups using std::string sergiodj+buildbot
2018-03-14  0:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-14 11:43 [binutils-gdb] GC: Also check the local debug definition section sergiodj+buildbot
2018-03-14 11:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-14 12:19 [binutils-gdb] PowerPC64 debian bug 886264, out-of-line save/restore functions sergiodj+buildbot
2018-03-14 13:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-14 13:59 [binutils-gdb] Update my email address sergiodj+buildbot
2018-03-14 14:28 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-14 16:04 [binutils-gdb] Add usage to printf command sergiodj+buildbot
2018-03-14 16:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-14 16:46 [binutils-gdb] Special case NULL when using printf's %s format sergiodj+buildbot
2018-03-14 19:05 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-14 17:26 [binutils-gdb] Allow - in %p for printf sergiodj+buildbot
2018-03-14 17:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-14 23:20 [binutils-gdb] RISC-V: Add .insn support sergiodj+buildbot
2018-03-14 23:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-15  8:04 [binutils-gdb] nds32: Remove the unsupported target feature sergiodj+buildbot
2018-03-15  8:18 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-15 21:11 [binutils-gdb] xtensa: bfd: fix assertion in xlate_offset_with_removed_text sergiodj+buildbot
2018-03-15 21:22 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-16  2:19 [binutils-gdb] Add selftest for substitute_path_component sergiodj+buildbot
2018-03-16  2:36 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-16 19:56 [binutils-gdb] Fix tspeed test case: copy libinproctrace to target sergiodj+buildbot
2018-03-16 20:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-16 20:41 [binutils-gdb] Remove make_cleanup_free_section_addr_info sergiodj+buildbot
2018-03-16 21:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-16 21:30 [binutils-gdb] Add silent Makefile rules sergiodj+buildbot
2018-03-16 22:43 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-17 15:47 [binutils-gdb] Remove target_fileio_close_cleanup sergiodj+buildbot
2018-03-17 15:58 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-17 19:46 [binutils-gdb] Change auto_load_objfile_script_1 to use std::string sergiodj+buildbot
2018-03-17 19:59 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-19  4:11 [binutils-gdb] Remove some cleanups from solib.c sergiodj+buildbot
2018-03-19  4:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-19 11:10 [binutils-gdb] Updated Spanish translation for the bfd/ sub-directory, and updated Ukranian translation for the gas/ sub-directory sergiodj+buildbot
2018-03-19 11:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-19 12:29 [binutils-gdb] Testsuite: Fix ambiguous "break" due to libinproctrace sergiodj+buildbot
2018-03-19 12:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-19 15:59 [binutils-gdb] Convert observers to C++ sergiodj+buildbot
2018-03-19 16:11 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-19 17:31 [binutils-gdb] Support bare-identifier field initializers in Rust sergiodj+buildbot
2018-03-19 17:44 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-20 11:08 [binutils-gdb] Set non_ir_ref_dynamic if a symbol is made dynamic sergiodj+buildbot
2018-03-20 11:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-20 14:14 [binutils-gdb] Replace the linear search in find_pc_sect_line with a binary search sergiodj+buildbot
2018-03-20 14:35 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-20 16:41 [binutils-gdb] Fix misleading indentation error sergiodj+buildbot
2018-03-20 16:53 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-21 11:32 [binutils-gdb] Don't exceed reloc array bounds sergiodj+buildbot
2018-03-21 11:44 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-21 11:46 [binutils-gdb] Correct multi-toc tprel relocs sergiodj+buildbot
2018-03-21 13:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-21 11:59 [binutils-gdb] Make tls_mask unsigned in elf32-ppc.c sergiodj+buildbot
2018-03-21 14:27 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-21 12:13 [binutils-gdb] Delete unused elf32-ppc.c code sergiodj+buildbot
2018-03-21 15:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-21 12:27 [binutils-gdb] PowerPC64 synthetic symbols sergiodj+buildbot
2018-03-21 17:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-21 16:59 [binutils-gdb] S390: Enable re-attaching with native-extended-gdbserver sergiodj+buildbot
2018-03-21 18:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-21 17:13 [binutils-gdb] S390: gdbserver: Don't write guarded storage registers sergiodj+buildbot
2018-03-21 20:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-21 18:30 [binutils-gdb] S390: Make IPA recognize tdescs with guarded storage sergiodj+buildbot
2018-03-21 21:27 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-21 20:10 [binutils-gdb] DT_FLAGS_1: Add Solaris bits sergiodj+buildbot
2018-03-21 22:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-21 20:49 [binutils-gdb] Add myself as a write-after-approval GDB maintainer sergiodj+buildbot
2018-03-22  0:04 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-22  4:50 [binutils-gdb] Make parse_static_tracepoint_marker_definition work with multiple static tracepoint definitions sergiodj+buildbot
2018-03-22  5:02 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-22  5:04 [binutils-gdb] Get rid of VEC(static_tracepoint_marker_p) sergiodj+buildbot
2018-03-22  6:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-22  7:50 [binutils-gdb] x86: fold a few XOP templates sergiodj+buildbot
2018-03-22  8:06 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-22  8:02 [binutils-gdb] x86/Intel: fix fallout from earlier template folding sergiodj+buildbot
2018-03-22 10:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-22  8:17 [binutils-gdb] x86: fix swapped operand handling for BNDMOV sergiodj+buildbot
2018-03-22 11:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-22  8:31 [binutils-gdb] x86: drop remaining redundant DispN sergiodj+buildbot
2018-03-22 12:53 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-22  9:20 [binutils-gdb] S390: Correct brace style in s390_get_wordsize sergiodj+buildbot
2018-03-22 15:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-22  9:34 [binutils-gdb] Make "info proc cmdline" show args on GNU/Linux sergiodj+buildbot
2018-03-22 16:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-22 11:31 [binutils-gdb] x86: drop pointless VecESize sergiodj+buildbot
2018-03-22 14:13 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-22 13:41 [binutils-gdb] ppc: Detect when LR is saved through frame pointer sergiodj+buildbot
2018-03-22 18:27 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-22 13:54 [binutils-gdb] ppc: Fix stwux and stdux masks in skip_prologue sergiodj+buildbot
2018-03-22 19:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-23  3:37 [binutils-gdb] Remove some cleanups from record-full.c sergiodj+buildbot
2018-03-23  3:54 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-23  9:56 [binutils-gdb] Testsuite: fully migrate to use_gdb_stub convenience func sergiodj+buildbot
2018-03-23 10:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-23 11:26 [binutils-gdb] Move gdbserver tdesc header funcs to c file sergiodj+buildbot
2018-03-23 11:39 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-23 12:14 [binutils-gdb] gdb: Minor cleanup in some gdb.arch/* tests sergiodj+buildbot
2018-03-23 13:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-23 13:00 [binutils-gdb] gdb: Fix testsuite issue in gdb.arch/amd64-disp-step-avx.exp sergiodj+buildbot
2018-03-23 14:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-23 15:04 [binutils-gdb] Make gdbserver find_register_by_number static sergiodj+buildbot
2018-03-23 15:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-23 16:23 [binutils-gdb] Change machoread.c to use std::vector sergiodj+buildbot
2018-03-23 17:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-23 19:13 [binutils-gdb] Add psymbols for nested types sergiodj+buildbot
2018-03-23 19:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-24  3:23 [binutils-gdb] aarch64: Make "info address" resolve TLS variables sergiodj+buildbot
2018-03-24  3:35 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-25 12:23 [binutils-gdb] x86-64: Add ENDBR64 to the TLSDESC PLT entry sergiodj+buildbot
2018-03-25 12:35 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-25 18:14 [binutils-gdb] eval.c: reverse minsym and sym sergiodj+buildbot
2018-03-25 18:27 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-26 11:05 [binutils-gdb] Make gdbserver reg_defs a vector of objects sergiodj+buildbot
2018-03-26 11:18 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-26 17:54 [binutils-gdb] Remove struct keyword from section_addr_info sergiodj+buildbot
2018-03-26 18:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-26 19:51 [binutils-gdb] Add include guard to filename-seen-cache.h sergiodj+buildbot
2018-03-26 20:06 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-26 20:03 [binutils-gdb] Remove DEF_VEC_I(offset_type) sergiodj+buildbot
2018-03-26 21:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27  4:21 [binutils-gdb] Rationalize "backtrace" command line parsing sergiodj+buildbot
2018-03-27  4:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27  4:34 [binutils-gdb] Change backtrace_command_1 calling to use flags sergiodj+buildbot
2018-03-27  5:53 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27  4:49 [binutils-gdb] Allow hiding of some filtered frames sergiodj+buildbot
2018-03-27  7:13 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27  5:03 [binutils-gdb] Remove EXT_LANG_BT_COMPLETED sergiodj+buildbot
2018-03-27  8:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27  5:17 [binutils-gdb] Avoid manual resource management in py-framefilter.c sergiodj+buildbot
2018-03-27 10:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27  5:31 [binutils-gdb] Allow C-c to work in backtrace in more cases sergiodj+buildbot
2018-03-27 12:14 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27  5:44 [binutils-gdb] Throw a "quit" on a KeyboardException in py-framefilter.c sergiodj+buildbot
2018-03-27 13:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27  6:17 [binutils-gdb] Move some code later in backtrace_command_1 sergiodj+buildbot
2018-03-27 15:11 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27  6:44 [binutils-gdb] Call wrap_hint in one more spot in py-framefilter.c sergiodj+buildbot
2018-03-27 18:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27  6:58 [binutils-gdb] Improve "backtrace" help text sergiodj+buildbot
2018-03-27 20:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27  7:12 [binutils-gdb] Simplify exception handling in py-framefilter.c sergiodj+buildbot
2018-03-27 21:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27  7:27 [binutils-gdb] Remove verbose code from backtrace command sergiodj+buildbot
2018-03-27 22:43 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27  7:57 [binutils-gdb] Return EXT_LANG_BT_ERROR in one more spot in py-framefilter.c sergiodj+buildbot
2018-03-27 16:49 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27 14:13 [binutils-gdb] problem looking up some symbols when they have a linkage name sergiodj+buildbot
2018-03-28  0:02 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27 14:24 [binutils-gdb] Move DWARF index-related things to a separate file sergiodj+buildbot
2018-03-28  1:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27 14:32 [binutils-gdb] set varsize-limit: New GDB setting for maximum dynamic object size sergiodj+buildbot
2018-03-28  2:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27 15:13 [binutils-gdb] Include <cmath> in dwarf-index-write.c sergiodj+buildbot
2018-03-28  4:00 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27 16:58 [binutils-gdb] C++-ify typedef hash sergiodj+buildbot
2018-03-28  5:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27 17:14 [binutils-gdb] Remove cleanups from gdb_readline_wrapper sergiodj+buildbot
2018-03-28  6:38 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-27 17:29 [binutils-gdb] Remove cleanups from prompt_for_continue sergiodj+buildbot
2018-03-28  7:58 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-28  9:04 [binutils-gdb] Enhance the AARCH64 assembler to support LDFF1xx instructions which use REG+REG addressing with an assumed offset register sergiodj+buildbot
2018-03-28  9:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-28 10:35 [binutils-gdb] PR ld/22972 on SPARC sergiodj+buildbot
2018-03-28 11:29 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-28 12:42 [binutils-gdb] x86: don't show suffixes for to-scalar-int conversion insns sergiodj+buildbot
2018-03-28 13:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-28 12:56 [binutils-gdb] x86: fold to-scalar-int conversion insns sergiodj+buildbot
2018-03-28 15:04 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-28 13:10 [binutils-gdb] x86: convert broadcast insn attribute to boolean sergiodj+buildbot
2018-03-28 16:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-28 15:04 [binutils-gdb] x86: drop VecESize sergiodj+buildbot
2018-03-28 18:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-28 17:35 [binutils-gdb] [1/2][GAS][AARCH64]Add BFD_RELOC_AARCH64_TLSLE_LDST8/16/32/64_TPREL_LO12 support in GAS sergiodj+buildbot
2018-03-28 20:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-28 17:49 [binutils-gdb] [2/2][LD][AARCH64]Add BFD_RELOC_AARCH64_TLSLE_LDST8/16/32/64_TPREL_LO12 support in LD sergiodj+buildbot
2018-03-28 22:22 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-28 20:56 [binutils-gdb] MIPS/BFD: Call `mips_elf32_rtype_to_howto' directly with o32 sergiodj+buildbot
2018-03-28 23:42 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-28 22:32 [binutils-gdb] BFD/PA: Remove ATTRIBUTE_UNUSED from `elf_hppa_info_to_howto_rel' sergiodj+buildbot
2018-03-29  2:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-28 22:55 [binutils-gdb] BFD/PA: Correct formatting in `elf_hppa_info_to_howto_rel' sergiodj+buildbot
2018-03-29  1:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-29 13:26 [binutils-gdb] PR binutils/22875: MIPS: Remove duplicate unsupported relocation processing sergiodj+buildbot
2018-03-29 13:38 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-30 19:31 [binutils-gdb] Remove make_cleanup_unpush_target sergiodj+buildbot
2018-03-30 20:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-30 19:55 [binutils-gdb] Remove parameter from free_dwo_file sergiodj+buildbot
2018-03-30 23:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-30 20:03 [binutils-gdb] Remove free_cached_comp_units cleanups sergiodj+buildbot
2018-03-30 21:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-30 20:21 [binutils-gdb] Change target_read_string to use unique_xmalloc_ptr sergiodj+buildbot
2018-03-31  2:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-30 20:35 [binutils-gdb] Remove some cleanups from solib-svr4.c sergiodj+buildbot
2018-03-31  3:39 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-30 21:01 [binutils-gdb] Remove free_dwo_file_cleanup sergiodj+buildbot
2018-03-31  1:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-30 22:03 [binutils-gdb] Remove usage of VEC(char_ptr) in gdbscm_parse_function_args sergiodj+buildbot
2018-03-31  7:37 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-30 22:45 [binutils-gdb] Use std::vector in uploaded_tp sergiodj+buildbot
2018-03-31  4:58 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-03-31  1:27 [binutils-gdb] Use std::vector and std::string instead of VEC(char_ptr) in gdbserver tdesc sergiodj+buildbot
2018-03-31  6:18 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-01 18:40 [binutils-gdb] Remove char_ptr typedef sergiodj+buildbot
2018-04-01 18:53 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-02  2:44 [binutils-gdb] Change rs6000_ptrace_ldinfo to return a byte_vector sergiodj+buildbot
2018-04-02  2:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-02 18:45 [binutils-gdb] Fix infinite recursion when printing static member with typedef sergiodj+buildbot
2018-04-02 18:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-02 22:13 [binutils-gdb] Add myself as a write-after-approval GDB maintainer sergiodj+buildbot
2018-04-02 22:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-03 18:20 [binutils-gdb] Change read_alphacoff_dynamic_symtab to use gdb::byte_vector sergiodj+buildbot
2018-04-03 18:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-04  1:17 [binutils-gdb] PR binutils/22875: MIPS/ELF: Also fail with relocation placeholders sergiodj+buildbot
2018-04-04  1:30 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-04  1:44 [binutils-gdb] PR binutils/22875: IQ2000/ELF: Prevent an out-of-bounds howto table access sergiodj+buildbot
2018-04-04  4:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-04  2:02 [binutils-gdb] PR binutils/22875: FRV/ELF: Prevent an out-of-bounds howto table access sergiodj+buildbot
2018-04-04  2:49 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-04  2:16 [binutils-gdb] PR binutils/22875: Visium/ELF: Prevent an out-of-bounds howto table access sergiodj+buildbot
2018-04-04  5:44 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-04  2:30 [binutils-gdb] PR binutils/22875: i860/ELF: Report unsupported relocation types sergiodj+buildbot
2018-04-04  7:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-04  2:44 [binutils-gdb] PR binutils/22875: HPPA/ELF: Also fail with relocation placeholders sergiodj+buildbot
2018-04-04  9:27 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-04  8:16 [binutils-gdb] Update Spanish translations for ld/ opcodes/ and gold/ sub-directories sergiodj+buildbot
2018-04-04 11:49 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-04 11:58 [binutils-gdb] i386: Clear vex instead of vex.evex sergiodj+buildbot
2018-04-04 13:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-05  0:02 [binutils-gdb] elf-hppa.h warning fix sergiodj+buildbot
2018-04-05  0:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-05 13:56 [binutils-gdb] Remove some cleanups from search_minsyms_for_name sergiodj+buildbot
2018-04-05 14:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-05 14:10 [binutils-gdb] Fix some indentation in linespec.c sergiodj+buildbot
2018-04-05 15:43 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-05 14:24 [binutils-gdb] Make copy_token_string return unique_xmalloc_ptr sergiodj+buildbot
2018-04-05 17:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-05 14:37 [binutils-gdb] Return std::string from canonical_to_fullform sergiodj+buildbot
2018-04-05 18:38 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-05 14:52 [binutils-gdb] Have filter_results take a std::vector sergiodj+buildbot
2018-04-05 19:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-05 15:05 [binutils-gdb] Remove a string copy from event_location_to_sals sergiodj+buildbot
2018-04-05 23:45 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-05 15:34 [binutils-gdb] More use of std::vector in linespec.c sergiodj+buildbot
2018-04-06  3:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-05 15:48 [binutils-gdb] Remove typep and VEC(typep) from linespec.c sergiodj+buildbot
2018-04-06  4:59 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-05 16:01 [binutils-gdb] Remove unnecessary include from linespec.h sergiodj+buildbot
2018-04-06  6:18 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-05 18:17 [binutils-gdb] Change streq to return bool sergiodj+buildbot
2018-04-06  2:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-05 22:49 [binutils-gdb] config: Sync with GCC sergiodj+buildbot
2018-04-06  8:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-05 22:53 [binutils-gdb] Use dlsym to check if libdl is needed for plugin sergiodj+buildbot
2018-04-06 10:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-06 12:23 [binutils-gdb] x86-64: Don't mask out R_X86_64_converted_reloc_bit sergiodj+buildbot
2018-04-06 12:36 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-06 20:32 [binutils-gdb] Add -Wno-error=deprecated-register to gdb build flags sergiodj+buildbot
2018-04-06 20:44 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-06 22:03 [binutils-gdb] Introduce a gdb_ref_ptr specialization for struct value sergiodj+buildbot
2018-04-06 22:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-06 22:16 [binutils-gdb] Change breakpoints to use value_ref_ptr sergiodj+buildbot
2018-04-06 23:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-06 22:31 [binutils-gdb] Change last_examine_value to value_ref_ptr sergiodj+buildbot
2018-04-07  0:59 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-06 23:00 [binutils-gdb] Change value history to use value_ref_ptr sergiodj+buildbot
2018-04-07  3:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-06 23:29 [binutils-gdb] Remove free_value_chain sergiodj+buildbot
2018-04-07  6:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-06 23:57 [binutils-gdb] Use new and delete for values sergiodj+buildbot
2018-04-07  9:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-07  0:11 [binutils-gdb] Change value::parent to a value_ref_ptr sergiodj+buildbot
2018-04-07 11:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-07  0:26 [binutils-gdb] Remove range_s VEC sergiodj+buildbot
2018-04-07 12:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-07  0:40 [binutils-gdb] Change value::contents to be a unique_xmalloc_ptr sergiodj+buildbot
2018-04-07 14:11 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-07  0:41 [binutils-gdb] Change varobj to use value_ref_ptr sergiodj+buildbot
2018-04-07  2:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-07  2:23 [binutils-gdb] Remove free_all_values sergiodj+buildbot
2018-04-07  4:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-07  4:04 [binutils-gdb] Remove value::next and value::released sergiodj+buildbot
2018-04-07  7:37 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-07 17:38 [binutils-gdb] Make target_read_alloc & al return vectors sergiodj+buildbot
2018-04-07 17:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-07 17:53 [binutils-gdb] Make "set osabi none" really work (PR 22980) sergiodj+buildbot
2018-04-07 19:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-07 18:05 [binutils-gdb] Fix generation of x86-64 gdbarch with osabi none (PR 22979) sergiodj+buildbot
2018-04-07 20:29 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-07 18:34 [binutils-gdb] Implement write_async_safe for mi_console_file (PR 22299) sergiodj+buildbot
2018-04-07 23:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-07 18:47 [binutils-gdb] Defer breakpoint reset when cloning progspace for fork child sergiodj+buildbot
2018-04-08  0:28 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-07 19:01 [binutils-gdb] Remove some unused variables in dwarf2read.c sergiodj+buildbot
2018-04-08  1:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-07 19:29 [binutils-gdb] Remove some usages of get_dwarf2_per_objfile sergiodj+buildbot
2018-04-08  4:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-07 19:43 [binutils-gdb] Make dwarf2_per_objfile::all_comp_units an std::vector sergiodj+buildbot
2018-04-08  5:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-07 19:57 [binutils-gdb] Make dwarf2_per_objfile::all_type_units an std::vector sergiodj+buildbot
2018-04-08  7:04 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-07 20:11 [binutils-gdb] Replace make_cleanup_restore_current_traceframe with RAII class sergiodj+buildbot
2018-04-08  9:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-07 20:17 [binutils-gdb] Remove stale file i386-avx.dat sergiodj+buildbot
2018-04-07 21:49 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-07 20:26 [binutils-gdb] Fix indentation in gdb.mi/mi-stack.exp sergiodj+buildbot
2018-04-08 10:59 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-07 20:40 [binutils-gdb] Fix gdb.mi/mi-stack.exp when gcc generates a stack protector sergiodj+buildbot
2018-04-08 12:53 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-07 20:50 [binutils-gdb] Replace dw2_get_cu/dw2_get_cutu with methods of dwarf2_per_objfile sergiodj+buildbot
2018-04-08  3:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-09  8:35 [binutils-gdb] PowerPC indirect calls to __tls_get_addr sergiodj+buildbot
2018-04-09  9:44 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-09  8:49 [binutils-gdb] PowerPC PLT16 relocations sergiodj+buildbot
2018-04-09 12:04 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-09  9:03 [binutils-gdb] Rearrange PLT reloc output on powerpc sergiodj+buildbot
2018-04-09 13:28 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-09  9:17 [binutils-gdb] Support PLT16 relocs against local symbols sergiodj+buildbot
2018-04-09 15:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-09  9:47 [binutils-gdb] Inline PLT call optimization sergiodj+buildbot
2018-04-09 20:06 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-09 11:16 [binutils-gdb] PowerPC inline PLT call support sergiodj+buildbot
2018-04-09 18:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-09 13:04 [binutils-gdb] MIPS64/BFD: Fix a crash with invalid `r_sym' in relocation sergiodj+buildbot
2018-04-09 21:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-09 13:12 [binutils-gdb] MIPS64/BFD: Fix a crash with STN_UNDEF in relocation sergiodj+buildbot
2018-04-09 22:53 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-09 15:13 [binutils-gdb] Apply "Convert observers to C++" edit to gdbarch.sh sergiodj+buildbot
2018-04-10  0:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-09 18:41 [binutils-gdb] Update ax_cv_cxx_compile_cxx.m4 sergiodj+buildbot
2018-04-10  1:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-09 18:55 [binutils-gdb] Copy string_view files from libstdc++ sergiodj+buildbot
2018-04-10  3:11 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-09 19:11 [binutils-gdb] Add gdb::string_view sergiodj+buildbot
2018-04-10  4:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-09 19:25 [binutils-gdb] Copy string_view tests from libstdc++ sergiodj+buildbot
2018-04-10  5:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-09 19:54 [binutils-gdb] Remove VEC(tsv_s), use std::vector instead sergiodj+buildbot
2018-04-10  8:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-09 20:08 [binutils-gdb] Use an std::vector for inline_states sergiodj+buildbot
2018-04-10 10:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-09 20:19 [binutils-gdb] Adapt and integrate string_view tests sergiodj+buildbot
2018-04-10  7:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-09 20:22 [binutils-gdb] Add selftests for range_contains and insert_into_bit_range_vector sergiodj+buildbot
2018-04-10 12:44 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-10 14:11 [binutils-gdb] Replace finish_thread_state_cleanup with a RAII class sergiodj+buildbot
2018-04-10 14:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-10 14:44 [binutils-gdb] Fix gdb.base/fork-running-state.exp race sergiodj+buildbot
2018-04-10 16:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-10 21:11 [binutils-gdb] Iterate by index in auto_load_safe_path_vec_update sergiodj+buildbot
2018-04-10 21:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-11 10:58 [binutils-gdb] C++ify fileio_fh_t, replace VEC with std::vector sergiodj+buildbot
2018-04-11 11:30 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-11 11:23 [binutils-gdb] File I/O file handles after target closes sergiodj+buildbot
2018-04-11 13:49 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-11 12:52 [binutils-gdb] Remove i860, i960, bout and aout-adobe targets sergiodj+buildbot
2018-04-11 16:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-11 14:46 [binutils-gdb] Add Rust test case for ".." struct initializer sergiodj+buildbot
2018-04-11 18:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-11 19:22 [binutils-gdb] Add test for following fork on position-independent executables sergiodj+buildbot
2018-04-11 20:45 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-11 20:14 [binutils-gdb] Enable Intel WAITPKG instructions sergiodj+buildbot
2018-04-11 23:45 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-12 16:59 [binutils-gdb] Eliminate target_has_exited sergiodj+buildbot
2018-04-12 17:28 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-12 17:40 [binutils-gdb] Fix Solaris build sergiodj+buildbot
2018-04-12 21:14 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-12 19:33 [binutils-gdb] Remove old univariant code from rust-lang.c sergiodj+buildbot
2018-04-13  0:06 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-12 20:34 [binutils-gdb] Fix -D_GLIBCXX_DEBUG gdb-add-index regression sergiodj+buildbot
2018-04-13  2:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-13  8:59 [binutils-gdb] infrun: step through indirect branch thunks sergiodj+buildbot
2018-04-13 10:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-13  9:59 [binutils-gdb] btrace: fix output of "set record btrace" sergiodj+buildbot
2018-04-13 12:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-13 10:09 [binutils-gdb] record: fix typo in "set record" output sergiodj+buildbot
2018-04-13 14:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-13 10:21 [binutils-gdb] btrace: set/show record btrace cpu sergiodj+buildbot
2018-04-13 17:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-13 17:44 [binutils-gdb] Show line numbers in output for "info var/func/type" sergiodj+buildbot
2018-04-13 19:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-14  8:58 [binutils-gdb] powerpc-lynxos and powerpc-windiss fixes sergiodj+buildbot
2018-04-14  9:42 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-14  9:08 [binutils-gdb] powerpc max-page-size vs __QNXTARGET__ sergiodj+buildbot
2018-04-14 12:54 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-14  9:25 [binutils-gdb] powerpc common-page-size sergiodj+buildbot
2018-04-14 15:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-15 15:56 [binutils-gdb] x86: Allow 32-bit registers for tpause and umwait sergiodj+buildbot
2018-04-15 16:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-15 20:05 [binutils-gdb] Add x86-tdep.o to i386/amd64 target build sergiodj+buildbot
2018-04-15 20:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-16  6:50 [binutils-gdb] Remove tahoe support sergiodj+buildbot
2018-04-16  7:14 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-16  7:26 [binutils-gdb] Remove netware support sergiodj+buildbot
2018-04-16  9:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-16  8:11 [binutils-gdb] Remove sony newsos3 support sergiodj+buildbot
2018-04-16 12:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-16  8:43 [binutils-gdb] Remove tandem support sergiodj+buildbot
2018-04-16 14:29 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-16  9:17 [binutils-gdb] Remove IEEE 695 object support sergiodj+buildbot
2018-04-16 16:48 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-16  9:50 [binutils-gdb] Remove h8300-coff support sergiodj+buildbot
2018-04-16 19:06 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-16 10:44 [binutils-gdb] Remove h8500 support sergiodj+buildbot
2018-04-16 21:15 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-16 10:56 [binutils-gdb] Remove i370 support sergiodj+buildbot
2018-04-16 23:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-16 14:17 [binutils-gdb] gdb: Remove support for SH-5/SH64 sergiodj+buildbot
2018-04-17  4:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-16 19:20 [binutils-gdb] Adjust more test cases to changed output of info var/func/type sergiodj+buildbot
2018-04-17  6:35 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-16 21:12 [binutils-gdb] linux_spu_make_corefile_notes: return note_data instead of nullptr sergiodj+buildbot
2018-04-17  9:05 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-17  3:38 [binutils-gdb] Reinstate readelf decoding of i860, i960 and i370 relocs sergiodj+buildbot
2018-04-17 11:45 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-17 10:18 [binutils-gdb] Enable Intel CLDEMOTE instruction sergiodj+buildbot
2018-04-17 13:55 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-17 13:19 [binutils-gdb] Resync libiberty sources with master version in GCC repository sergiodj+buildbot
2018-04-17 16:04 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-17 14:06 [binutils-gdb] Add a check for a NULL table pointer before attempting to compute a DWARF filename sergiodj+buildbot
2018-04-17 18:14 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-17 17:09 [binutils-gdb] Fix illegal memory accesses trigeered when linking corrupt input files sergiodj+buildbot
2018-04-17 20:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-17 17:52 [binutils-gdb] Don't print symbol declaration's line number in rbreak output sergiodj+buildbot
2018-04-17 22:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-17 20:03 [binutils-gdb] Fix crash in quirk_rust_enum sergiodj+buildbot
2018-04-18  0:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-17 20:26 [binutils-gdb] Conditionally drop the discriminant field in quirk_rust_enum sergiodj+buildbot
2018-04-18  2:49 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-17 22:07 [binutils-gdb] [MicroBlaze] PIC data text relative sergiodj+buildbot
2018-04-18  4:59 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-18  0:23 [binutils-gdb] various i386-aout and i386-coff target removal sergiodj+buildbot
2018-04-18  7:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-18  1:33 [binutils-gdb] x86: Use a normal input file with compatible relocation sergiodj+buildbot
2018-04-18  9:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-18  2:13 [binutils-gdb] elf32_bed/elf64_bed sergiodj+buildbot
2018-04-18 12:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-18  8:44 [binutils-gdb] Remove mips aout, coff, and pe support sergiodj+buildbot
2018-04-18 14:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-18 13:20 [binutils-gdb] Commonise tdesc_reg and makes use of it in gdbserver tdesc sergiodj+buildbot
2018-04-18 16:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-18 14:07 [binutils-gdb] Commonise tdesc_feature and makes use of it in gdbserver tdesc sergiodj+buildbot
2018-04-18 18:34 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-18 14:34 [binutils-gdb] Commonise tdesc types and makes use of them in gdbserver tdesc sergiodj+buildbot
2018-04-18 20:43 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-18 15:15 [binutils-gdb] Add tdesc osabi and architecture functions sergiodj+buildbot
2018-04-19  0:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-18 20:22 [binutils-gdb] Add feature reference in .dat files sergiodj+buildbot
2018-04-19  5:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-18 20:43 [binutils-gdb] Create xml from target descriptions sergiodj+buildbot
2018-04-19  7:30 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-18 21:02 [binutils-gdb] Remove xml file references from target descriptions sergiodj+buildbot
2018-04-19 11:53 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-18 21:46 [binutils-gdb] Remove xml files from gdbserver sergiodj+buildbot
2018-04-19 13:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-19  0:40 [binutils-gdb] Reinstate mips ecoff support sergiodj+buildbot
2018-04-19 15:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-19  6:29 [binutils-gdb] PR22537, Segmentation fault with static PIE sergiodj+buildbot
2018-04-19 17:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-19 17:40 [binutils-gdb] Fix dependency tracking in gdbserver subdirectories sergiodj+buildbot
2018-04-19 21:34 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-19 22:02 [binutils-gdb] [OB PATCH] Fix some comments in thread.c sergiodj+buildbot
2018-04-19 22:22 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-20  3:25 [binutils-gdb] Add test case for a known hang in infrun sergiodj+buildbot
2018-04-20  3:53 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-20 14:09 [binutils-gdb] PR22978, TLS local-dynamic incorrectly linked on hppa-linux sergiodj+buildbot
2018-04-20 14:39 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-20 21:47 [binutils-gdb] Improve on-line help for thread_apply_command and thread_apply_all_command sergiodj+buildbot
2018-04-20 22:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-21 18:17 [binutils-gdb] FreeBSD: Fix 'Couldn't get registers: Device busy' error (PR gdb/23077) sergiodj+buildbot
2018-04-21 18:58 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-22 22:41 [binutils-gdb] Fixed test case to compile & run on FreeBSD sergiodj+buildbot
2018-04-22 23:14 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-23  9:10 [binutils-gdb] Silence gcc-8 warnings sergiodj+buildbot
2018-04-23  9:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-23 12:15 [binutils-gdb] Prevent an illegal memory access in gprof by ensuring that string tables for aout format files are always zero-terminated sergiodj+buildbot
2018-04-23 12:43 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-23 14:42 [binutils-gdb] Revert bfd part of "Silence gcc-8 warnings" sergiodj+buildbot
2018-04-23 15:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-23 15:50 [binutils-gdb] Regenerate gdb/configure and gdbserver/configure sergiodj+buildbot
2018-04-24  0:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-24  0:19 [binutils-gdb] Remove a cleanup from scm-frame.c sergiodj+buildbot
2018-04-24  0:44 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-24 13:56 [binutils-gdb] Remove cli_ui_out::out_field_fmt sergiodj+buildbot
2018-04-24 14:28 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-24 14:45 [binutils-gdb] Reindent cli-out.h sergiodj+buildbot
2018-04-24 16:34 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-24 15:09 [binutils-gdb] info-shared.exp: Replace libs=-ldl with shlib_load sergiodj+buildbot
2018-04-24 19:14 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-24 16:07 [binutils-gdb] Fix an illegal memory access when copying a PE format file with corrupt debug information sergiodj+buildbot
2018-04-24 21:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-24 16:26 [binutils-gdb] Fix an illegal memory access when trying to copy an ELF binary with corrupt section symbols sergiodj+buildbot
2018-04-25  0:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-24 20:07 [binutils-gdb] Enable 'set print inferior-events' and improve detach/fork/kill/exit messages sergiodj+buildbot
2018-04-25  3:59 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-25  0:47 [binutils-gdb] Remove arm-aout and arm-coff support sergiodj+buildbot
2018-04-25  4:42 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-25  8:21 [binutils-gdb] Silence gcc-8 warnings sergiodj+buildbot
2018-04-25  9:18 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-25 12:59 [binutils-gdb] Fix the mask for the sqrdml(a|s)h instructions sergiodj+buildbot
2018-04-25 13:28 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-25 14:49 [binutils-gdb] x86: drop redundant AVX512VL shift templates sergiodj+buildbot
2018-04-25 16:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-25 18:28 [binutils-gdb] Fix new inferior events output sergiodj+buildbot
2018-04-25 19:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-25 21:40 [binutils-gdb] [ARM] Add armelf_linux_fdpiceabi and armelfb_linux_fdpiceabi BFD backends sergiodj+buildbot
2018-04-25 22:05 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-25 22:20 [binutils-gdb] [ARM] Add FDPIC OSABI flag support sergiodj+buildbot
2018-04-26  1:04 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-25 23:02 [binutils-gdb] [ARM] Add FDPIC relocations definitions sergiodj+buildbot
2018-04-26  3:22 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-25 23:36 [binutils-gdb] [ARM] Implement FDPIC relocations sergiodj+buildbot
2018-04-26  5:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26  0:03 [binutils-gdb] [ARM] Implement PLT for FDPIC sergiodj+buildbot
2018-04-26  7:28 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26  0:55 [binutils-gdb] [ARM] Add TLS relocations for FDPIC sergiodj+buildbot
2018-04-26 10:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26  1:29 [binutils-gdb] [ARM] FDPIC: Add stack segment sergiodj+buildbot
2018-04-26 13:05 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26  1:48 [binutils-gdb] [ARM] FDPIC: Translate R_ARM_TARGET2 relocation into R_ARM_GOT32 relocation for FDPIC platform sergiodj+buildbot
2018-04-26 15:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26  2:23 [binutils-gdb] [ARM] FDPIC: Make _GLOBAL_OFFSET_TABLE_ a relative symbol sergiodj+buildbot
2018-04-26 17:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26  2:55 [binutils-gdb] [ARM] FDPIC: Implement Thumb-only PLT for FDPIC sergiodj+buildbot
2018-04-26 20:39 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26  7:04 [binutils-gdb] x86: drop VexImmExt sergiodj+buildbot
2018-04-26 22:05 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26  8:13 [binutils-gdb] x86: drop CpuRegMMX, CpuReg[XYZ]MM, and CpuRegMask sergiodj+buildbot
2018-04-27  2:39 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26  8:36 [binutils-gdb] x86: CpuXSAVE is a prereq for various other features sergiodj+buildbot
2018-04-27  6:00 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26  9:03 [binutils-gdb] x86: fold various non-memory operand AVX512VL templates sergiodj+buildbot
2018-04-27  7:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 10:29 [binutils-gdb] x86: x87-related adjustments sergiodj+buildbot
2018-04-27  0:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 12:47 [binutils-gdb] Fix breakpoints in ifunc after inferior resolved it (@got.plt symbol creation) sergiodj+buildbot
2018-04-27 10:14 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 13:28 [binutils-gdb] Calling ifunc functions when target has no debug info but resolver has sergiodj+buildbot
2018-04-27 15:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 14:27 [binutils-gdb] Fix calling ifunc functions when resolver has debug info and different name sergiodj+buildbot
2018-04-27 13:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 14:27 [binutils-gdb] Fix elf_gnu_ifunc_resolve_by_got buglet sergiodj+buildbot
2018-04-27 19:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 14:33 [binutils-gdb] Calling ifunc functions when resolver has debug info, user symbol same name sergiodj+buildbot
2018-04-27 18:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 14:53 [binutils-gdb] Fix setting breakpoints on ifunc functions after they're already resolved sergiodj+buildbot
2018-04-27 22:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 15:18 [binutils-gdb] Breakpoints, don't skip prologue of ifunc resolvers with debug info sergiodj+buildbot
2018-04-28  1:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 15:43 [binutils-gdb] Eliminate find_pc_partial_function_gnu_ifunc sergiodj+buildbot
2018-04-28  2:48 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 16:07 [binutils-gdb] Factor out minsym_found/find_function_start_sal overload sergiodj+buildbot
2018-04-28  5:42 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 16:34 [binutils-gdb] For PPC64: elf_gnu_ifunc_record_cache: handle plt symbols in .text section sergiodj+buildbot
2018-04-28  8:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 17:15 [binutils-gdb] Fix stepping past GNU ifunc resolvers (introduce lookup_msym_prefer) sergiodj+buildbot
2018-04-28 11:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 17:37 [binutils-gdb] For PPC64/ELFv1: Introduce mst_data_gnu_ifunc sergiodj+buildbot
2018-04-28 14:35 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 18:05 [binutils-gdb] PPC64: always make synthetic .text symbols for GNU ifunc symbols sergiodj+buildbot
2018-04-28 17:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 18:42 [binutils-gdb] Extend GNU ifunc testcases sergiodj+buildbot
2018-04-28 20:36 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 19:45 [binutils-gdb] Fix resolving GNU ifunc bp locations when inferior runs resolver sergiodj+buildbot
2018-04-28 22:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 22:02 [binutils-gdb] Enable Intel MOVDIRI, MOVDIR64B instructions sergiodj+buildbot
2018-04-29  1:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-26 23:25 [binutils-gdb] Fix remote 'g' command error handling (PR remote/9665) sergiodj+buildbot
2018-04-29  3:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-27  9:52 [binutils-gdb] PR23123, PowerPC32 ifunc regression sergiodj+buildbot
2018-04-29  6:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-27 11:12 [binutils-gdb] Regenerate some files for recent ARM patches sergiodj+buildbot
2018-04-29  9:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-27 13:09 [binutils-gdb] Revert "Enable Intel MOVDIRI, MOVDIR64B instructions." sergiodj+buildbot
2018-04-29 13:54 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-27 19:21 [binutils-gdb] Enable -Wsuggest-override sergiodj+buildbot
2018-04-29 15:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-27 20:09 [binutils-gdb] Add inclusive range support for Rust sergiodj+buildbot
2018-04-29 17:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-27 20:40 [binutils-gdb] Add libcc1 v1 compatibility to C compile feature sergiodj+buildbot
2018-04-30  3:35 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-29 16:18 [binutils-gdb] Fix race when building ada-lex.c sergiodj+buildbot
2018-04-30  4:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-29 16:52 [binutils-gdb] proc-events.c: fix compilation on Solaris sergiodj+buildbot
2018-04-30  7:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-30 15:27 [binutils-gdb] Use bool in read_index_from_section sergiodj+buildbot
2018-04-30 15:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-30 16:10 [binutils-gdb] This patch adds support to objdump for disassembly of NFP (Netronome Flow Processor) ELF files (.nffw) as well as some basic readelf support sergiodj+buildbot
2018-04-30 18:49 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-30 17:32 [binutils-gdb] Add initial type alignment support sergiodj+buildbot
2018-04-30 21:05 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-30 18:19 [binutils-gdb] Handle alignof and _Alignof sergiodj+buildbot
2018-05-01  0:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-30 19:20 [binutils-gdb] Expose type alignment on gdb.Type sergiodj+buildbot
2018-05-01  2:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-30 20:28 [binutils-gdb] Remove rust_type_alignment sergiodj+buildbot
2018-05-01  6:04 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-30 20:51 [binutils-gdb] Remove long_long_align_bit gdbarch attribute sergiodj+buildbot
2018-05-01 10:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-30 21:37 [binutils-gdb] Remove new_bfd_ref sergiodj+buildbot
2018-05-01 15:30 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-30 21:46 [binutils-gdb] Introduce ref_ptr::new_reference sergiodj+buildbot
2018-05-01 12:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-30 21:56 [binutils-gdb] Use new_reference for struct value sergiodj+buildbot
2018-05-01 20:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-30 22:16 [binutils-gdb] Change Python code to use new_reference sergiodj+buildbot
2018-05-01 21:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-30 23:05 [binutils-gdb] Make do_is_mi_like_p const sergiodj+buildbot
2018-05-02  1:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-30 23:38 [binutils-gdb] Remove some uses of is_mi_like_p from py-framefilter.c sergiodj+buildbot
2018-05-02  2:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-04-30 23:58 [binutils-gdb] Remove some uses of is_mi_like_p from spu-tdep.c sergiodj+buildbot
2018-05-02  4:55 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-01  0:19 [binutils-gdb] Remove a use of is_mi_like_p from tracepoint.c sergiodj+buildbot
2018-05-02  6:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-01  0:38 [binutils-gdb] Remove some is_mi_like_p from breakpoint code sergiodj+buildbot
2018-05-02 10:05 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-01  1:23 [binutils-gdb] Remove a use of is_mi_like_p from darwin-nat-info.c sergiodj+buildbot
2018-05-02 10:49 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-01  1:43 [binutils-gdb] [Ada/ravenscar] error during "continue" after task/thread switch sergiodj+buildbot
2018-05-02 13:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-01  8:01 [binutils-gdb] rust: Fix null deref when casting (PR 23124) sergiodj+buildbot
2018-05-02 15:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-01 15:30 [binutils-gdb] Add the Netronome Flow Processor as a build target to the top-level configure.ac file sergiodj+buildbot
2018-05-02 16:34 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-01 16:18 [binutils-gdb] Bring in support for the NFP target in the config.sub file sergiodj+buildbot
2018-05-02 20:49 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-01 16:57 [binutils-gdb] Fix unintialized memory in aarch64 opcodes sergiodj+buildbot
2018-05-02 21:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-02 16:34 [binutils-gdb] Handle var_zuinteger and var_zuinteger_unlimited from Python sergiodj+buildbot
2018-05-02 23:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-02 22:57 [binutils-gdb] Set test message in py-parameter.exp sergiodj+buildbot
2018-05-03  1:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-02 23:59 [binutils-gdb] Eliminate procfs.c:procfs_use_watchpoints sergiodj+buildbot
2018-05-03  3:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-03  0:37 [binutils-gdb] More procfs.c simplification sergiodj+buildbot
2018-05-03  5:27 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-03  2:12 [binutils-gdb] Make inf_ptrace_trad Linux-only, move to separate file sergiodj+buildbot
2018-05-03  7:43 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-03  2:19 [binutils-gdb] make-target-delegates: line break between return type and function name sergiodj+buildbot
2018-05-03 16:14 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-03  2:19 [binutils-gdb] Convert struct target_ops to C++ sergiodj+buildbot
2018-05-03 12:04 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-03  2:21 [binutils-gdb] target_ops: Use bool throughout sergiodj+buildbot
2018-05-03 17:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-03  2:26 [binutils-gdb] linux_nat_target: More low methods sergiodj+buildbot
2018-05-03 18:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-03  2:31 [binutils-gdb] target factories, target open and multiple instances of targets sergiodj+buildbot
2018-05-03 20:48 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-03  2:54 [binutils-gdb] Eliminate target_ops::to_xclose sergiodj+buildbot
2018-05-03 11:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-03 11:31 [binutils-gdb] Fix s390 GNU/Linux build sergiodj+buildbot
2018-05-03 22:43 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-03 17:01 [binutils-gdb] BFD: Prevent writing the MIPS _gp_disp symbol into symbol tables sergiodj+buildbot
2018-05-04  1:34 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-03 21:34 [binutils-gdb] gdb/testsuite: Filter out some registers for riscv sergiodj+buildbot
2018-05-04  4:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-03 22:18 [binutils-gdb] Use flex's -t option instead of --stdout sergiodj+buildbot
2018-05-04  5:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-04  9:34 [binutils-gdb] ppc: Fix warning messages when IBM and IEEE long double are mixed sergiodj+buildbot
2018-05-04 10:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-04 10:22 [binutils-gdb] -Wstringop-truncation warnings sergiodj+buildbot
2018-05-04 13:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-04 11:04 [binutils-gdb] gdb/testsuite: Fix broken regexp in gdbstub case sergiodj+buildbot
2018-05-04 14:35 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-04 14:14 [binutils-gdb] configure uses incorrect link order when testing libpython sergiodj+buildbot
2018-05-04 17:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-04 15:01 [binutils-gdb] gdb/testsuite: Handle targets with lots of registers sergiodj+buildbot
2018-05-04 18:55 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-04 15:39 [binutils-gdb] Remove a cleanup from remote.c sergiodj+buildbot
2018-05-04 21:05 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-04 17:42 [binutils-gdb] [spu] Fix build break sergiodj+buildbot
2018-05-04 23:18 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-04 18:25 [binutils-gdb] Use gdb_bfd_ref_ptr in target_bfd sergiodj+buildbot
2018-05-05  1:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-04 19:03 [binutils-gdb] Remove cleanup from old_renaming_is_invisible sergiodj+buildbot
2018-05-05  3:39 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-04 19:36 [binutils-gdb] Return std::string from ada_exception_catchpoint_cond_string sergiodj+buildbot
2018-05-05  5:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-04 20:13 [binutils-gdb] Remove do_closedir_cleanup sergiodj+buildbot
2018-05-05 11:02 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-04 20:29 [binutils-gdb] Remove cleanup from print_mention_exception sergiodj+buildbot
2018-05-05  8:00 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-04 20:33 [binutils-gdb] Use previous count when 'x' command is repeated sergiodj+buildbot
2018-05-05 13:00 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-04 20:53 [binutils-gdb] Minor cleanups in printcmd.c sergiodj+buildbot
2018-05-05 15:22 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-04 21:12 [binutils-gdb] (SPARC/LEON) fix incorrect array return value printed by "finish" sergiodj+buildbot
2018-05-05 17:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-04 22:05 [binutils-gdb] gdb: Make test names unique in gdb.base/maint.exp sergiodj+buildbot
2018-05-05 20:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-04 22:30 [binutils-gdb] aarch64: PR 19806: watchpoints: false negatives + PR 20207 contiguous ones sergiodj+buildbot
2018-05-06  1:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-04 23:18 [binutils-gdb] Allocate cmd_list_element with new sergiodj+buildbot
2018-05-06 21:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-04 23:49 [binutils-gdb] Use counted_command_line everywhere sergiodj+buildbot
2018-05-07  3:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-05  1:14 [binutils-gdb] Use function_view in cli-script.c sergiodj+buildbot
2018-05-08 14:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-05  1:34 [binutils-gdb] Allow breakpoint commands to be set from Python sergiodj+buildbot
2018-05-09  5:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-05  1:36 [binutils-gdb] Make print_command_trace varargs sergiodj+buildbot
2018-05-07 14:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-05  1:57 [binutils-gdb] Let gdb.execute handle multi-line commands sergiodj+buildbot
2018-05-09 11:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-05  2:10 [binutils-gdb] Constify prompt argument to read_command_lines sergiodj+buildbot
2018-05-07 18:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-05  4:07 [binutils-gdb] Allow defining a user command inside a user command sergiodj+buildbot
2018-05-08 11:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-05  4:33 [binutils-gdb] Fix "fall through" comments sergiodj+buildbot
2018-05-10  4:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-05  6:03 [binutils-gdb] Add missing ATTRIBUTE_NORETURNs sergiodj+buildbot
2018-05-10  9:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-05  6:43 [binutils-gdb] Add a fall-through comment to stabsread.c sergiodj+buildbot
2018-05-11  5:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-05  7:03 [binutils-gdb] Add fall-through comment to i386-tdep.c sergiodj+buildbot
2018-05-11 15:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-05  7:16 [binutils-gdb] Fix "obvious" fall-through warnings sergiodj+buildbot
2018-05-10 18:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-05  7:23 [binutils-gdb] Add two fall-through comments in rs6000-tdep.c sergiodj+buildbot
2018-05-12  9:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-05  8:19 [binutils-gdb] Add a missing break in record_linux_system_call sergiodj+buildbot
2018-05-13 22:58 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-05  8:54 [binutils-gdb] Add -Wimplicit-fallthrough sergiodj+buildbot
2018-05-14 11:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-05 10:19 [binutils-gdb] Add missing "breaks" sergiodj+buildbot
2018-05-13  8:35 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-07  3:23 [binutils-gdb] Replace uses of strncmp with memcmp sergiodj+buildbot
2018-05-16 12:06 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-07 15:05 [binutils-gdb] Cleanup ppc code dealing with opcode dumps sergiodj+buildbot
2018-05-16 23:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-07 15:27 [binutils-gdb] Fix decoding of ARM VFP instructions sergiodj+buildbot
2018-05-18 13:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-07 16:17 [binutils-gdb] Add -Wduplicated-cond sergiodj+buildbot
2018-05-24  1:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-07 17:23 [binutils-gdb] x86: Replace AddrPrefixOp0 with AddrPrefixOpReg sergiodj+buildbot
2018-05-29  3:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-08  0:29 [binutils-gdb] Enable Intel MOVDIRI, MOVDIR64B instructions sergiodj+buildbot
2018-06-02 15:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-08  2:10 [binutils-gdb] Simplify VLE handling in print_insn_powerpc() sergiodj+buildbot
2018-06-03  6:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-08 12:20 [binutils-gdb] Prevent a memory exhaustion failure when running objdump on a fuzzed input file with corrupt string and attribute sections sergiodj+buildbot
2018-06-03 16:16 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-08 12:43 [binutils-gdb] [spu] Fix "info spu event" output formatting sergiodj+buildbot
2018-06-04  9:38 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-08 13:27 [binutils-gdb] watchpoint-unaligned.exp: Use skip_hw_watchpoint_tests sergiodj+buildbot
2018-06-05 18:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-08 14:08 [binutils-gdb] Correct powerpc spe opcode lookup sergiodj+buildbot
2018-06-08 14:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-08 17:40 [binutils-gdb] gdb/x86: Handle kernels using compact xsave format sergiodj+buildbot
2018-06-09 19:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-08 21:06 [binutils-gdb] Define GNULIB_NAMESPACE in unittests/string_view-selftests.c sergiodj+buildbot
2018-06-10  7:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-08 23:14 [binutils-gdb] RISC-V: Add missing hint instructions from RV128I sergiodj+buildbot
2018-06-10 17:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-09  5:28 [binutils-gdb] PR23147, Heap buffer overflow in pe_print_idata sergiodj+buildbot
2018-06-12 10:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-09  5:52 [binutils-gdb] PR23148, Heap buffer overflow in pe_print_edata sergiodj+buildbot
2018-06-12 20:37 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-09  7:01 [binutils-gdb] PR22069, Several instances of register accidentally spelled as regsiter sergiodj+buildbot
2018-06-13  7:18 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-09 11:03 [binutils-gdb] Fix binary compatibility between GCC and the TI compiler for the PRU target sergiodj+buildbot
2018-06-13 17:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-09 16:53 [binutils-gdb] gdb: xtensa: handle privileged registers sergiodj+buildbot
2018-06-14 10:27 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-09 18:41 [binutils-gdb] x86: Remove Disp<N> from movidir{i,64b} sergiodj+buildbot
2018-06-15 14:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-10 10:11 [binutils-gdb] Fix tagged pointer support sergiodj+buildbot
2018-06-16 11:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-10 12:28 [binutils-gdb] Add support for detecting Freescale S12Z binaries in readelf sergiodj+buildbot
2018-06-16 22:13 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-10 17:03 [binutils-gdb] [gdbserver/win32] fatal "glob could not process pattern '(null)'" error sergiodj+buildbot
2018-06-18  1:05 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-10 17:18 [binutils-gdb] gdbserver/Windows: Fix "no program to debug" error sergiodj+buildbot
2018-06-18  7:18 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-10 17:39 [binutils-gdb] gdbserver/Windows: crash during connection establishment phase sergiodj+buildbot
2018-06-18 20:42 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-10 20:09 [binutils-gdb] x86 LynxOS-178: Adjust floating-point context structure sergiodj+buildbot
2018-06-20 14:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-10 20:54 [binutils-gdb] Fix the clang build sergiodj+buildbot
2018-06-19 16:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-11 17:54 [binutils-gdb] Remove cleanups from mdebugread.c sergiodj+buildbot
2018-06-21  3:28 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-11 20:37 [binutils-gdb] Move core_bfd to program space sergiodj+buildbot
2018-06-21  9:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-11 21:20 [binutils-gdb] Eliminate the 'the_core_target' global sergiodj+buildbot
2018-06-21 19:36 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-11 21:45 [binutils-gdb] Heap-allocate core_target instances sergiodj+buildbot
2018-06-22 11:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-11 22:31 [binutils-gdb] gdb/x86: Fix write out of mxcsr register for xsave targets sergiodj+buildbot
2018-06-23 22:05 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-12  1:03 [binutils-gdb] gdb: xtensa: drop gdb_target definition sergiodj+buildbot
2018-06-22 16:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-12  7:32 [binutils-gdb] PR20659, Objcopy and change section lma failing sergiodj+buildbot
2018-06-24 17:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-14 12:32 [binutils-gdb] x86: Mark __bss_start, _end and _edata locally defined sergiodj+buildbot
2018-06-26 12:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-14 12:39 [binutils-gdb] x86; Allow IFUNC pointer defined in PDE sergiodj+buildbot
2018-06-26 14:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-14 16:38 [binutils-gdb] Clear rust_unions in rust_union_quirks sergiodj+buildbot
2018-06-27  3:44 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-15 13:22 [binutils-gdb] Add a new Portuguese translation for the bfd sub-directory sergiodj+buildbot
2018-06-27 15:11 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-15 13:56 [binutils-gdb] Fix error messages in the NFP sources when building for 32-bit targets sergiodj+buildbot
2018-06-27 21:14 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-15 14:05 [binutils-gdb] Fix uninitialised memory acccess in COFF bfd backend sergiodj+buildbot
2018-06-28  7:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-15 15:48 [binutils-gdb] testsuite: Fix a `server_pid' access crash in gdb.server/server-kill.exp sergiodj+buildbot
2018-06-28 17:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-15 16:51 [binutils-gdb] MIPS/Linux/native: Supply $zero for the !PTRACE_GETREGS case sergiodj+buildbot
2018-06-29 21:53 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-15 17:55 [binutils-gdb] MIPS: Make `mask_address_var' static sergiodj+buildbot
2018-06-29 11:45 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-15 21:45 [binutils-gdb] Implement Read/Write constraints on system registers on AArch64 sergiodj+buildbot
2018-07-01  4:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-16 12:21 [binutils-gdb] Fix disassembly mask for vector sdot on AArch64 sergiodj+buildbot
2018-07-01 14:39 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-16 13:10 [binutils-gdb] PR22458, failure to choose a matching ELF target sergiodj+buildbot
2018-07-02  0:58 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-16 17:23 [binutils-gdb] regcache.c: Remove unused typedefs sergiodj+buildbot
2018-07-02 11:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-16 18:44 [binutils-gdb] Use a distinguishing name for minidebug objfile sergiodj+buildbot
2018-07-03 10:55 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-16 19:34 [binutils-gdb] Make "cbfd" a gdb_bfd_ref_ptr sergiodj+buildbot
2018-07-05  6:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-16 20:38 [binutils-gdb] NDS32/BFD: Fix build error in `nds32_convert_32_to_16' sergiodj+buildbot
2018-07-05 19:42 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-16 20:39 [binutils-gdb] PR gdb/22286: linux-nat-trad: Support arbitrary register widths sergiodj+buildbot
2018-07-06  6:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-17 15:50 [binutils-gdb] value.c: Remove unused variables sergiodj+buildbot
2018-07-07  2:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-17 15:55 [binutils-gdb] Updated simplified Chinese translation for the opcodes directory sergiodj+buildbot
2018-07-07 13:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-17 17:06 [binutils-gdb] Fix for dwz-related crash sergiodj+buildbot
2018-07-07 23:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-17 17:59 [binutils-gdb] Make format_pieces recognize the \e escape sequence sergiodj+buildbot
2018-07-08  9:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-18  0:01 [binutils-gdb] Don't elide all inlined frames sergiodj+buildbot
2018-07-08 20:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-18  4:22 [binutils-gdb] opcodes sources should not include libbfd.h sergiodj+buildbot
2018-07-10 10:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-18  4:54 [binutils-gdb] libbfd.h and libcoff.h include guards sergiodj+buildbot
2018-07-11 15:49 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-18  6:58 [binutils-gdb] ATTRIBUTE_HIDDEN for libbfd.h sergiodj+buildbot
2018-07-13  3:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-18  9:45 [binutils-gdb] PR23199, Invalid SHT_GROUP entry leads to group confusion sergiodj+buildbot
2018-07-14  2:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-18 14:23 [binutils-gdb] x86: Don't set eh->local_ref to 1 for linker defined symbols sergiodj+buildbot
2018-07-14 13:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-18 15:27 [binutils-gdb] Add support for the Freescale s12z processor sergiodj+buildbot
2018-07-14 23:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-18 20:15 [binutils-gdb] Show padding in ptype/o output sergiodj+buildbot
2018-07-15  9:44 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-18 22:33 [binutils-gdb] format_pieces-selftests.c: Silence ARI warnings sergiodj+buildbot
2018-07-15 20:06 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-18 23:56 [binutils-gdb] Remove mapped_index::total_size sergiodj+buildbot
2018-07-17 10:30 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-19  1:31 [binutils-gdb] Use new to allocate mapped_index sergiodj+buildbot
2018-07-20  0:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-19  1:41 [binutils-gdb] Allocate dwp_file with new sergiodj+buildbot
2018-07-22  0:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-19  2:16 [binutils-gdb] RISC-V: Add RV32E support sergiodj+buildbot
2018-07-22 16:42 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-19  3:06 [binutils-gdb] Allocate dwz_file with new sergiodj+buildbot
2018-07-24 13:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-19  3:50 [binutils-gdb] x86: Don't set eh->local_ref to 1 for versioned symbol sergiodj+buildbot
2018-07-25 21:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-19  6:14 [binutils-gdb] RISC-V: Fix ld-elf/pr22269* testcases sergiodj+buildbot
2018-07-19 10:22 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-19  7:33 [binutils-gdb] Fix reference in comment: SRC_AND_LOC instead of LOC_AND_SRC sergiodj+buildbot
2018-07-26  8:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-20  0:37 [binutils-gdb] Remove useless variable int i in backtrace_command_1 sergiodj+buildbot
2018-07-26 18:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-21  1:51 [binutils-gdb] Introduce obstack_new, poison other "typed" obstack functions sergiodj+buildbot
2018-07-27  5:00 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-21  2:19 [binutils-gdb] Initialize py_type_printers in ext_lang_type_printers sergiodj+buildbot
2018-07-06 16:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-21  3:56 [binutils-gdb] Use XOBNEW/XOBNEWVEC/OBSTACK_ZALLOC when possible sergiodj+buildbot
2018-07-27 15:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-21  3:57 [binutils-gdb] Fix copy-pasto, allocate objfile_per_bfd_storage with obstack_new sergiodj+buildbot
2018-07-28  1:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-21 16:43 [binutils-gdb] Use std::unique_ptr in dwarf2_read_debug_names sergiodj+buildbot
2018-07-28 13:06 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-21 17:46 [binutils-gdb] Use std::string in reread_symbols sergiodj+buildbot
2018-07-28 23:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-21 18:16 [binutils-gdb] Remove a cleanup from trace_dump_actions sergiodj+buildbot
2018-07-29  9:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-21 18:22 [binutils-gdb] Remove cleanup from ada-lang.c sergiodj+buildbot
2018-07-29 20:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-21 18:46 [binutils-gdb] Remove cleanup from ada_collect_symbol_completion_matches sergiodj+buildbot
2018-07-30  6:27 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-21 20:19 [binutils-gdb] Change ada_catchpoint::excep_string to be a std::string sergiodj+buildbot
2018-07-30 16:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-21 20:25 [binutils-gdb] Remove output_command_const sergiodj+buildbot
2018-07-31 12:35 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-22  0:14 [binutils-gdb] Remove fake operand handling for extended mnemonics sergiodj+buildbot
2018-08-02  3:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-22  0:40 [binutils-gdb] MIPS/gdbserver: Fix issues with $zero register reads sergiodj+buildbot
2018-08-02 13:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-22  1:57 [binutils-gdb] MIPS/Linux: Disable n32 USR `ptrace' accesses to 64-bit registers sergiodj+buildbot
2018-08-03  3:22 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-22  4:05 [binutils-gdb] Mark section in a section group with SHF_GROUP sergiodj+buildbot
2018-08-03 20:00 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-22  4:46 [binutils-gdb] ld: Hide symbols defined by HIDDEN/PROVIDE_HIDDEN sergiodj+buildbot
2018-08-04  6:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-22  6:36 [binutils-gdb] PR23207, hppa ld SIGSEGVs on invalid object files sergiodj+buildbot
2018-08-04 16:43 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-22 11:00 [binutils-gdb] PR23207, hppa ld SIGSEGVs on invalid object files sergiodj+buildbot
2018-08-05  9:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-22 15:04 [binutils-gdb] fix "stale cleanup" internal-warning when using "catch assert" command sergiodj+buildbot
2018-08-05 22:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-22 15:57 [binutils-gdb] [PowerPC] Consolidate linux target description selection sergiodj+buildbot
2018-08-06  9:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-22 16:47 [binutils-gdb] [PowerPC] Disable regsets using zero sizes in gdbserver sergiodj+buildbot
2018-08-07  6:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-22 17:02 [binutils-gdb] [PowerPC] Consolidate linux vector regset sizes sergiodj+buildbot
2018-08-07 16:39 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-22 17:26 [binutils-gdb] [PowerPC] Consolidate wordsize getter between native and gdbserver sergiodj+buildbot
2018-08-06 19:42 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-22 17:34 [binutils-gdb] [PowerPC] Fix access to VSCR in linux targets sergiodj+buildbot
2018-08-08 21:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-22 18:22 [binutils-gdb] [PowerPC] Fix VSX registers in linux core files sergiodj+buildbot
2018-08-10  2:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-22 19:13 [binutils-gdb] [PowerPC] Fix inclusion of dfp pseudoregs in tdep sergiodj+buildbot
2018-08-10 13:13 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-22 19:25 [binutils-gdb] [PowerPC] Recognize isa205 in linux core files sergiodj+buildbot
2018-08-11  8:59 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-22 20:16 [binutils-gdb] Support UTF-8 identifiers in C/C++ expressions (PR gdb/22973) sergiodj+buildbot
2018-08-12 10:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-22 21:16 [binutils-gdb] remote: struct remote_state, use op new, fix leaks sergiodj+buildbot
2018-08-13  0:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-22 22:22 [binutils-gdb] remote: Eliminate remote_hostio_close_cleanup sergiodj+buildbot
2018-08-13 10:47 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-22 22:50 [binutils-gdb] remote: Make readahead_cache a C++ class sergiodj+buildbot
2018-08-13 21:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-22 22:55 [binutils-gdb] remote: multiple remote_arch_state instances per arch sergiodj+buildbot
2018-08-14  7:28 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-22 23:27 [binutils-gdb] remote: remote_arch_state pointers -> remote_arch_state objects sergiodj+buildbot
2018-08-14 18:10 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-22 23:57 [binutils-gdb] remote: Small cleanup in compare_section_command sergiodj+buildbot
2018-08-15  4:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-23  0:48 [binutils-gdb] Handle "show remote memory-write-packet-size" when not connected sergiodj+buildbot
2018-08-16  1:38 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-23  1:22 [binutils-gdb] remote: Move discard_pending_stop_replies call sergiodj+buildbot
2018-08-15 14:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-23  1:41 [binutils-gdb] remote: one struct remote_state per struct remote_target sergiodj+buildbot
2018-08-16 22:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-23  1:46 [binutils-gdb] MIPS/gdbserver: Correctly handle narrow big-endian register transfers sergiodj+buildbot
2018-08-17  8:40 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-23  2:03 [binutils-gdb] gdb/x86: Fix `-Wstrict-overflow' build error in `i387_collect_xsave' sergiodj+buildbot
2018-08-17 19:24 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-23  2:22 [binutils-gdb] remote: Make vcont_builder a class sergiodj+buildbot
2018-08-16 11:59 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-23  3:06 [binutils-gdb] Fix gdb.base/remote.exp with native-extended-gdbserver board sergiodj+buildbot
2018-08-18  5:44 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-23 13:32 [binutils-gdb] Improve File I/O overflow detection in gdbserver (PR server/23198) sergiodj+buildbot
2018-08-18 16:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-23 15:59 [binutils-gdb] Remove internal_complaint sergiodj+buildbot
2018-08-19 13:53 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-23 16:40 [binutils-gdb] Remove elements from complaint_series sergiodj+buildbot
2018-08-21  8:27 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-23 17:01 [binutils-gdb] Remove "noisy" parameter from clear_complaints sergiodj+buildbot
2018-08-22  0:34 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-23 17:33 [binutils-gdb] Remove symfile_complaints sergiodj+buildbot
2018-08-22 22:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-23 18:12 [binutils-gdb] Remove struct explanation sergiodj+buildbot
2018-08-23  8:42 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-23 18:49 [binutils-gdb] Remove vcomplaint sergiodj+buildbot
2018-08-23 19:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-23 19:22 [binutils-gdb] Remove file and line from struct complain sergiodj+buildbot
2018-08-24  6:59 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-23 19:44 [binutils-gdb] Remove struct complain sergiodj+buildbot
2018-08-24 22:28 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-23 20:13 [binutils-gdb] Remove struct complaints sergiodj+buildbot
2018-08-25  8:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-23 20:46 [binutils-gdb] Add ATTRIBUTE_NONSTRING to ppc64_elf_write_core_note sergiodj+buildbot
2018-08-27  2:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-24 13:02 [binutils-gdb] Fix macOS build, missing override sergiodj+buildbot
2018-08-31 18:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-24 15:23 [binutils-gdb] testsuite: Extend TLS core file testing with an OS-generated dump sergiodj+buildbot
2018-08-31 19:06 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-24 18:01 [binutils-gdb] gdb: Restore selected frame in print_frame_local_vars sergiodj+buildbot
2018-09-01  7:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-24 20:09 [binutils-gdb] Update help strings in skip.c sergiodj+buildbot
2018-09-03 16:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-24 20:12 [binutils-gdb] Update core-related help strings sergiodj+buildbot
2018-09-04 11:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-24 20:37 [binutils-gdb] Update memattr.c help strings sergiodj+buildbot
2018-09-04 17:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-24 21:10 [binutils-gdb] Update help strings in TUI sergiodj+buildbot
2018-09-04 18:03 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-24 21:16 [binutils-gdb] Update help text in dcache.c sergiodj+buildbot
2018-09-04 19:28 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-24 21:53 [binutils-gdb] Update help text for "jump" command sergiodj+buildbot
2018-09-05  0:13 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-24 22:04 [binutils-gdb] Update help text in disasm.c sergiodj+buildbot
2018-09-05  8:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-24 22:52 [binutils-gdb] Update help text in tracepoint.c sergiodj+buildbot
2018-09-06  4:52 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-24 23:52 [binutils-gdb] Update help text in record-btrace.c sergiodj+buildbot
2018-09-06 14:38 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-24 23:53 [binutils-gdb] Update help text in linux-fork.c sergiodj+buildbot
2018-09-07 21:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-25  0:21 [binutils-gdb] Update help text in record.c sergiodj+buildbot
2018-09-08  6:58 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-25  1:35 [binutils-gdb] PATCH (obvious): Fix a comment, and pass stream to cb_data sergiodj+buildbot
2018-09-08 22:22 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-25  3:02 [binutils-gdb] gdb: Split func_command into two parts sergiodj+buildbot
2018-09-09  1:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-25  7:02 [binutils-gdb] Fix hidden visibility compiler test sergiodj+buildbot
2018-09-09  3:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-25  7:27 [binutils-gdb] s12z regen sergiodj+buildbot
2018-09-09  3:55 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-25 11:59 [binutils-gdb] remote_target::m_remote_state, pointer -> object sergiodj+buildbot
2018-09-09  7:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-25 12:19 [binutils-gdb] Fix help and documentation for inferior commands sergiodj+buildbot
2018-09-03  9:53 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-25 12:40 [binutils-gdb] MIPS/Linux: Correct o32 core file FGR interpretation sergiodj+buildbot
2018-09-10  0:20 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-25 15:49 [binutils-gdb] Use TRY/CATCH in remove_prev_frame sergiodj+buildbot
2018-09-10 17:46 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-25 17:20 [binutils-gdb] Remove cleanups from coff-pe-read.c sergiodj+buildbot
2018-09-10 23:57 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-25 17:52 [binutils-gdb] Use gdb::byte_vector in remote.c sergiodj+buildbot
2018-09-11  2:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-25 19:42 [binutils-gdb] Use scoped_restore in a couple of interp-related places sergiodj+buildbot
2018-09-11 14:58 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-25 20:32 [binutils-gdb] Change the as_*_interp functions to use dynamic_cast sergiodj+buildbot
2018-09-13 10:02 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-25 20:59 [binutils-gdb] Remove interp_name sergiodj+buildbot
2018-09-13 14:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-25 22:57 [binutils-gdb] Clear entire "location" in value constructor sergiodj+buildbot
2018-09-13 21:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-26 17:55 [binutils-gdb] Remove interp_ui_out sergiodj+buildbot
2018-09-13 12:09 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-26 21:25 [binutils-gdb] Add "name" method to class interp sergiodj+buildbot
2018-09-13 15:19 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-26 21:47 [binutils-gdb] Remove cleanups from dbxread.c sergiodj+buildbot
2018-09-13 16:44 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-27  0:24 [binutils-gdb] ld: Add _bfd_elf_link_hide_sym_by_version sergiodj+buildbot
2018-09-14  1:01 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-27 22:16 [binutils-gdb] Remove last reference to REMOTE_OBS sergiodj+buildbot
2018-09-14 12:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-28 16:20 [binutils-gdb] ld: Unify STT_GNU_IFUNC handling sergiodj+buildbot
2018-09-14 23:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-28 19:57 [binutils-gdb] x86-64: Add TLSDESC fields to elf_x86_lazy_plt_layout sergiodj+buildbot
2018-09-15 18:23 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-29 16:07 [binutils-gdb] Remove const_char_ptr typedef sergiodj+buildbot
2018-09-16  8:36 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-29 16:25 [binutils-gdb] Remove tp_t typedef sergiodj+buildbot
2018-09-16 18:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-29 18:44 [binutils-gdb] Remove a VEC from type.c sergiodj+buildbot
2018-09-17  5:33 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-29 19:05 [binutils-gdb] Change program_space::added_solibs to a std::vector sergiodj+buildbot
2018-09-17 11:49 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-29 23:51 [binutils-gdb] Fix fall-through comment in windows-nat.c sergiodj+buildbot
2018-09-17 18:32 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-30  0:37 [binutils-gdb] Removing lookup_minimal_symbol_and_objfile sergiodj+buildbot
2018-09-18  3:39 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-30  1:23 [binutils-gdb] Remove "struct" keyword in range-based for loops sergiodj+buildbot
2018-09-18 16:54 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-30  8:52 [binutils-gdb] Add znver2 support sergiodj+buildbot
2018-09-19  2:27 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-30 15:56 [binutils-gdb] Mark END_CATCH as ATTRIBUTE_NORETURN (-Wmaybe-uninitialized warnings) sergiodj+buildbot
2018-09-19  9:37 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-30 16:17 [binutils-gdb] 2018-05-30 Amaan Cheval <amaan.cheval@gmail.com> sergiodj+buildbot
2018-09-20  9:59 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-30 16:57 [binutils-gdb] Add or1k target to --enable-targets=all sergiodj+buildbot
2018-09-20 18:26 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-30 20:01 [binutils-gdb] Remove regcache_get_ptid sergiodj+buildbot
2018-09-21 23:00 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-30 20:37 [binutils-gdb] Remove regcache_register_status sergiodj+buildbot
2018-09-23 19:13 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
2018-05-30 20:58 [binutils-gdb] Remove regcache_raw_update sergiodj+buildbot
2018-09-24 15:08 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).