public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb/gdb-8.0-branch] Fix dwarf2_string_attr for -gsplit-dwarf
@ 2017-10-27  0:15 sergiodj+buildbot
  2017-10-27  0:15 ` Failures on Fedora-s390x-m64, branch gdb-8.0-branch sergiodj+buildbot
                   ` (12 more replies)
  0 siblings, 13 replies; 63+ messages in thread
From: sergiodj+buildbot @ 2017-10-27  0:15 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 06848393c68c1b370cf2441756ed7413f4442515 ***

Author: Leszek Swirski <leszeks@google.com>
Branch: gdb-8.0-branch
Commit: 06848393c68c1b370cf2441756ed7413f4442515

Fix dwarf2_string_attr for -gsplit-dwarf

The dwarf2_string_attr did not allow DW_FORM_GNU_str_index as a form for
string types. This manifested as null strings in the namespace_name
lookup (replaced with "(anonymous namespace)") when debugging
Fission-compiled code.

(cherry picked from commits 16eb6b2db49e6cf2fdca56efd37689fcc170cd37 and
b33404388e5bbd8a1fddfde73cd4593ae2b557e8)

gdb/ChangeLog:

	PR symtab/20899
	* dwarf2read.c (dwarf2_string_attr): Allow DW_FORM_GNU_str_index.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Fix AArch64 debug trace build
@ 2018-05-21  9:58 sergiodj+buildbot
  2018-05-30 18:08 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2018-05-21  9:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 378272cef651024de67dc0e09d3f41ae2d66f8bd ***

Author: Tamar Christina <tamar.christina@arm.com>
Branch: gdb-8.0-branch
Commit: 378272cef651024de67dc0e09d3f41ae2d66f8bd

Fix AArch64 debug trace build

The build with debug tracing enabled (`-DDEBUG_AARCH64`)
is currently broken. A variable that no longer exists is being
referenced from the debug statement.

	* aarch64-opc.c (aarch64_logical_immediate_p): Update DEBUG_TRACE
	arguments.

(cherry picked from commit 957f6b39cab6cac0e4c54e650c7f75109544ac1d)


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Fix GCC PR83906 - [8 Regression] Random FAIL: libstdc++-prettyprinters/80276.cc whatis p4
@ 2018-01-24 19:40 sergiodj+buildbot
  2018-01-24 20:42 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2018-01-24 19:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 621a88c13ad39cccc8ba511ff3088cd623e9f335 ***

Author: Pedro Alves <palves@redhat.com>
Branch: gdb-8.0-branch
Commit: 621a88c13ad39cccc8ba511ff3088cd623e9f335

Fix GCC PR83906 - [8 Regression] Random FAIL: libstdc++-prettyprinters/80276.cc whatis p4

GCC PR83906 [1] is about a GCC/libstdc++ GDB/Python type printer
testcase failing randomly, as shown by running (in libstdc++'s
testsuite):

 make check RUNTESTFLAGS=prettyprinters.exp=80276.cc

in a loop.  Sometimes you get this:

 FAIL: libstdc++-prettyprinters/80276.cc whatis p4

I.e., this:
 type = std::unique_ptr<std::vector<std::unique_ptr<std::list<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >>[]>>[99]>

instead of this:
 type = std::unique_ptr<std::vector<std::unique_ptr<std::list<std::string>[]>>[99]>

Jonathan Wakely tracked it on the printer side to this bit in
libstdc++'s type printer:

            if self.type_obj == type_obj:
                return strip_inline_namespaces(self.name)

This assumes the two types resolve to the same gdb.Type but some times
the comparison unexpectedly fails.

Running the testcase manually under Valgrind finds the problem in GDB:

 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 ==6118== Conditional jump or move depends on uninitialised value(s)
 ==6118==    at 0x4C35CB0: bcmp (vg_replace_strmem.c:1100)
 ==6118==    by 0x6F773A: check_types_equal(type*, type*, VEC_type_equality_entry_d**) (gdbtypes.c:3515)
 ==6118==    by 0x6F7B00: check_types_worklist(VEC_type_equality_entry_d**, bcache*) (gdbtypes.c:3618)
 ==6118==    by 0x6F7C03: types_deeply_equal(type*, type*) (gdbtypes.c:3655)
 ==6118==    by 0x4D5B06: typy_richcompare(_object*, _object*, int) (py-type.c:1007)
 ==6118==    by 0x63D7E6C: PyObject_RichCompare (object.c:961)
 ==6118==    by 0x646EAEC: PyEval_EvalFrameEx (ceval.c:4960)
 ==6118==    by 0x646DC08: PyEval_EvalFrameEx (ceval.c:4519)
 ==6118==    by 0x646DC08: PyEval_EvalFrameEx (ceval.c:4519)
 ==6118==    by 0x646DC08: PyEval_EvalFrameEx (ceval.c:4519)
 ==6118==    by 0x646DC08: PyEval_EvalFrameEx (ceval.c:4519)
 ==6118==    by 0x646DC08: PyEval_EvalFrameEx (ceval.c:4519)
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~

That "bcmp" call is really a memcmp call in check_types_equal.  The
problem is that gdb is memcmp'ing two objects that are equal in value:

 (top-gdb) p *TYPE_RANGE_DATA (type1)
 $1 = {low = {kind = PROP_CONST, data = {const_val = 0, baton = 0x0}}, high = {kind = PROP_CONST, data = {const_val = 15, baton = 0xf}}, flag_upper_bound_is_count = 0,
   flag_bound_evaluated = 0}
 (top-gdb) p *TYPE_RANGE_DATA (type2)
 $2 = {low = {kind = PROP_CONST, data = {const_val = 0, baton = 0x0}}, high = {kind = PROP_CONST, data = {const_val = 15, baton = 0xf}}, flag_upper_bound_is_count = 0,
   flag_bound_evaluated = 0}

but differ in padding.  Notice the 4-byte hole:

  (top-gdb) ptype /o range_bounds
  /* offset    |  size */  type = struct range_bounds {
  /*    0      |    16 */    struct dynamic_prop {
  /*    0      |     4 */        dynamic_prop_kind kind;
  /* XXX  4-byte hole  */
  /*    8      |     8 */        union dynamic_prop_data {
  /*                 8 */            LONGEST const_val;
  /*                 8 */            void *baton;

				     /* total size (bytes):    8 */
				 } data;

which is filled with garbage:

  (top-gdb) x /40bx TYPE_RANGE_DATA (type1)
  0x2fa7ea0:      0x01    0x00    0x00    0x00    0x43    0x01    0x00    0x00
						  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  0x2fa7ea8:      0x00    0x00    0x00    0x00    0x00    0x00    0x00    0x00
  0x2fa7eb0:      0x01    0x00    0x00    0x00    0xfe    0x7f    0x00    0x00
  0x2fa7eb8:      0x0f    0x00    0x00    0x00    0x00    0x00    0x00    0x00
  0x2fa7ec0:      0x00    0x00    0x00    0x00    0x00    0x00    0x00    0x00
  (top-gdb) x /40bx TYPE_RANGE_DATA (type2)
  0x20379b0:      0x01    0x00    0x00    0x00    0xfe    0x7f    0x00    0x00
						  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  0x20379b8:      0x00    0x00    0x00    0x00    0x00    0x00    0x00    0x00
  0x20379c0:      0x01    0x00    0x00    0x00    0xfe    0x7f    0x00    0x00
  0x20379c8:      0x0f    0x00    0x00    0x00    0x00    0x00    0x00    0x00
  0x20379d0:      0x00    0x00    0x00    0x00    0x00    0x00    0x00    0x00

  (top-gdb) p memcmp (TYPE_RANGE_DATA (type1), TYPE_RANGE_DATA (type2), sizeof (*TYPE_RANGE_DATA (type1)))
  $3 = -187

In some cases objects of type range_bounds are memset when allocated,
but then their dynamic_prop low/high fields are copied over from some
template dynamic_prop object that wasn't memset.  E.g.,
create_static_range_type's low/high locals are left with garbage in
the padding, and then that padding is copied over to the range_bounds
object's low/high fields.

At first, I considered making sure to always memset range_bounds
objects, thinking that maybe type objects are being put in some bcache
instance somewhere.  But then I hacked bcache/bcache_full to poison
non-pod types, and made dynamic_prop a non-pod, and GDB still
compiled.

So given that, it seems safest to not assume padding will always be
memset, and instead treat them as regular value types, implementing
(in)equality operators and using those instead of memcmp.

This fixes the random FAILs in GCC's testcase.

[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83906

gdb/ChangeLog:
2018-01-24  Pedro Alves  <palves@redhat.com>

	GCC PR libstdc++/83906
	* gdbtypes.c (operator==(const dynamic_prop &,
	const dynamic_prop &)): New.
	(operator==(const range_bounds &, const range_bounds &)): New.
	(check_types_equal): Use them instead of memcmp.
	* gdbtypes.h (operator==(const dynamic_prop &,
	const dynamic_prop &)): Declare.
	(operator!=(const dynamic_prop &, const dynamic_prop &)): Declare.
	(operator==(const range_bounds &, const range_bounds &)): Declare.
	(operator!=(const range_bounds &, const range_bounds &)): Declare.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Fix scm-ports.exp regression
@ 2018-01-15 19:11 sergiodj+buildbot
  2018-01-15 19:38 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2018-01-15 19:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 92533dc55ed6aee88da718487f075692074b00dd ***

Author: Tom Tromey <tom@tromey.com>
Branch: gdb-8.0-branch
Commit: 92533dc55ed6aee88da718487f075692074b00dd

Fix scm-ports.exp regression

In https://sourceware.org/ml/gdb-patches/2017-12/msg00215.html, Jan
pointed out that the scalar printing patches caused a regression in
scm-ports.exp on x86.

What happens is that on x86, this:

	set sp_reg [get_integer_valueof "\$sp" 0]

... ends up setting sp_reg to a negative value, because
get_integer_valueof uses "print/d":

    print /d $sp
    $1 = -11496

Then later the test suite does:

    gdb_test "guile (print (seek rw-mem-port (value->integer sp-reg) SEEK_SET))" \
	"= $sp_reg" \
	"seek to \$sp"

... expecting this value to be identical to the saved $sp_reg value.
However it gets:

    guile (print (seek rw-mem-port (value->integer sp-reg) SEEK_SET))
    = 4294955800

"print" is just a wrapper for guile's format:

    gdb_test_no_output "guile (define (print x) (format #t \"= ~A\" x) (newline))"

The seek function returns a scm_t_off, the printing of which is
handled by guile, not by gdb.

Tested on x86-64 Fedora 26 using an ordinary build and also a -m32
build.

2018-01-15  Tom Tromey  <tom@tromey.com>

	* gdb.guile/scm-ports.exp (test_mem_port_rw): Use get_valueof to
	compute sp_reg.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Fix PR19061, gdb hangs/spins-on-cpu when debugging any program on Alpha
@ 2018-01-03 15:41 sergiodj+buildbot
  2018-01-03 15:41 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2018-01-03 15:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bd496067387a9c89a7e62bbba76e784634936932 ***

Author: Richard Henderson <rth@redhat.com>
Branch: gdb-8.0-branch
Commit: bd496067387a9c89a7e62bbba76e784634936932

Fix PR19061, gdb hangs/spins-on-cpu when debugging any program on Alpha

This fixes PR19061, where gdb hangs/spins-on-cpu when debugging any
program on Alpha.

(This patch is Uros' forward port of the patch from comment #5
of the PR [1].)

Patch was tested on alphaev68-linux-gnu, also tested with gcc's
testsuite, where it fixed all hangs in guality.exp and
simulate-thread.exp testcases.

[1] https://sourceware.org/bugzilla/show_bug.cgi?id=19061#c5

gdb/ChangeLog:
2018-01-03  Richard Henderson  <rth@redhat.com>
	    Uros Bizjak  <ubizjak@gmail.com>

	PR gdb/19061
	* alpha-tdep.c (alpha_deal_with_atomic_sequence): Change
	prototype.
	(alpha_software_single_step): Call alpha_deal_with_atomic_sequence
	here.
	(set_gdbarch_software_single_step): Set to
	alpha_software_single_step.
	* nat/linux-ptrace.h [__alpha__]: Define GDB_ARCH_IS_TRAP_BRKPT
	and GDB_ARCH_IS_TRAP_HWBKPT.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] PR22137: gdbserver crashes on host with pkru register.
@ 2017-10-16  8:26 sergiodj+buildbot
  2017-10-18  7:44 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-10-16  8:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f24b864960e61f9a91f8c168c1afe12a6676ad7a ***

Author: Walfred Tedeschi <walfred.tedeschi@intel.com>
Branch: gdb-8.0-branch
Commit: f24b864960e61f9a91f8c168c1afe12a6676ad7a

PR22137: gdbserver crashes on host with pkru register.

This patch adds missing backslash on a makefile and regenerate the
files created via the xml files.  Those were not in sync with the xml file.

gdb/ChangeLog:

2017-10-16  Walfred Tedeschi  <walfred.tedeschi@intel.com>

	* features/Makefile (i386-avx-mpx-avx512-pku.dat): Add backslash
	at the end of the line.
	* regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Regenerate.
	* regformats/i386/amd64-avx-mpx-avx512-pku.dat: Regenerate.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Bump GDB version number to 8.0.1.DATE-git.
@ 2017-09-07 16:12 sergiodj+buildbot
  2017-09-07 16:35 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-09-07 16:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 14c2ca3638ce928546f1aaf9eda752bcdae78d99 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: gdb-8.0-branch
Commit: 14c2ca3638ce928546f1aaf9eda752bcdae78d99

Bump GDB version number to 8.0.1.DATE-git.

gdb/ChangeLog:

	* version.in: Set GDB version number to 8.0.1.DATE-git.
	* PROBLEMS: Likewise.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Test different follow-exec-mode settings in gdb.multi/multi-arch-exec.exp
@ 2017-09-05 20:39 sergiodj+buildbot
  2017-09-05 22:28 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-09-05 20:39 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e8311673316b29c557dcc18a09e252de724dc910 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: gdb-8.0-branch
Commit: e8311673316b29c557dcc18a09e252de724dc910

Test different follow-exec-mode settings in gdb.multi/multi-arch-exec.exp

Using follow-exec-mode "new" takes a different code path than "same", so
it's interesting to test this path in combination with a change in
architecture of the inferior.  This test fails if you remove the
previous patch.

gdb/testsuite/ChangeLog:

	* gdb.multi/multi-arch-exec.exp: Test with different
	"follow-exec-mode" settings.
	(do_test): New procedure.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Add thread after updating gdbarch when exec'ing
@ 2017-09-05 20:09 sergiodj+buildbot
  2017-09-05 22:06 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-09-05 20:09 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 42f0d8218d9865d076a13a1a30e317232eae0721 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: gdb-8.0-branch
Commit: 42f0d8218d9865d076a13a1a30e317232eae0721

Add thread after updating gdbarch when exec'ing

As mentioned in the previous patch, we should avoid doing register reads
after a process does an exec and before we've updated that inferior's
gdbarch.  Otherwise, we may interpret the registers using the wrong
architecture.  When a process does an exec with "follow-exec-mode new",
a new inferior is added by follow_exec.  The gdbarch of that new
inferior is at first set to some default value, probably specific to the
gdb build (I get "i386" here), which may not be the right one.  It is
updated later by the call to target_find_description.  Before that
point, if we try to read the inferior's registers, we may not interpret
them correctly.  This has been exposed by a failure in
gdb.base/foll-exec-mode.exp after the previous patch, with:

  Remote 'g' packet reply is too long (expected 312 bytes, got 816 bytes)

The call to "add_thread" done just after adding the inferior is
problematic, because it ends up reading the registers (because the ptid
is re-used, we end up doing a switch_to_thread to it, which tries to
update stop_pc).  The registers returned by gdbserver are the x86-64
ones, while we try to interpret them using the "i386" gdbarch.

Postponing the call to add_thread to until the target
description/gdbarch has been updated seems to fix the issue.

As to why this issue was uncovered by the previous patch: what I think
happened before that patch is that since we were updating stop_pc before
switching to the new inferior, we were filling the regcache associated
to the ptid (this worked fine as long as the architectures of the
previous and new process images were the same).  The call to
switch_to_thread then worked, because the register read hit the
regcache.  Now, it triggers a register read, while the gdbarch is not
set correctly, leading to the "reply is too long" error.  If this is
right, it sounds wrong that we delete and re-add a thread with the same
ptid, and are able to access the registers from the deleted thread.
When we delete a thread, should we clear the regcache associated to that
ptid, so that the new thread starts with a fresh/empty regcache?

gdb/ChangeLog:

	* infrun.c (follow_exec): Call add_thread after
	target_find_description.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Read stop_pc after updating the gdbarch when exec'ing
@ 2017-09-05 19:23 sergiodj+buildbot
  2017-09-05 20:36 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-09-05 19:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 61bffb81d5ffdb7c6005b7b7fb6cfd8e9e6b19ce ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: gdb-8.0-branch
Commit: 61bffb81d5ffdb7c6005b7b7fb6cfd8e9e6b19ce

Read stop_pc after updating the gdbarch when exec'ing

When an inferior execs and changes architecture (e.g. 64 bits to 32
bits), the gdbarch associated to the inferior is updated by the
follow_exec call in handle_inferior_event_1.  We should avoid doing any
register read before that point, because the registers sent by the
remote side will be those of the new architecture, but we would
interpret them using the old architecture.  We do just that by setting
stop_pc during this window, which obviously requires reading the
registers.  This results in gdb.multi/multi-arch-exec.exp failing, GDB
outputting the following error:

  Truncated register 50 in remote 'g' packet

This patch fixes that by postponing the setting of stop_pc to after
we've updated the inferior gdbarch.

This bug was hiding another problem, and as such introduces some
failures in gdb.base/foll-exec-mode.exp.  The following patch takes care
of that.

gdb/ChangeLog:

	* infrun.c (handle_inferior_event_1): When exec'ing, read
	stop_pc after follow_exec.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Improve "'g' reply is is to long" error message
@ 2017-09-05 18:17 sergiodj+buildbot
  2017-09-05 19:53 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-09-05 18:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e72d662aba1bc92e141688ebb27f3948ec5d2997 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: gdb-8.0-branch
Commit: e72d662aba1bc92e141688ebb27f3948ec5d2997

Improve "'g' reply is is to long" error message

... by adding the expected size, and the received size.  I found this
useful when debugging gdbarch/remote issues, since it gives a hint of
what gdb expects and what the remote sent.

gdb/ChangeLog:

	* remote.c (process_g_packet): Update error message.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] PR gdb/22046: Fix T-stopped detach regression on old Linux kernels
@ 2017-09-01  5:50 sergiodj+buildbot
  2017-09-01  9:18 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-09-01  5:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c247e38d78a98f85066e4a61032ee742d08a0579 ***

Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Branch: gdb-8.0-branch
Commit: c247e38d78a98f85066e4a61032ee742d08a0579

PR gdb/22046: Fix T-stopped detach regression on old Linux kernels

On <=RHEL6 hosts Fedora/RHEL GDB started to 'kill -STOP' all processes it
detached.  Even those not originally T-stopped.  This is a Fedora-specific
patch which is based on upstream GDB's PROC_STATE_STOPPED state.

I believe (I did not verify) this patch did regress it:
commit d617208bb06bd461b52ce041d89f7127e3044762
Author: Pedro Alves <palves@redhat.com>
Date:   Mon Jul 25 12:42:17 2016 +0100
    linux-procfs: Introduce enum proc_state

As originally there was strstr() but now there is strcmp() and so the missing
trailing '\n' no longer matches.

The Bug was found by Michal Kolar.

Reproducibility:
$ gdb -p $PID
(gdb) quit
$ ...

Actual results:
===
RHEL6.9 x86_64 # scl enable devtoolset-7 bash
RHEL6.9 x86_64 # which gdb
/opt/rh/devtoolset-7/root/usr/bin/gdb
RHEL6.9 x86_64 # ./testcase.sh
24737 pts/0    S+     0:00 /bin/sleep 4
24737 pts/0    T+     0:00 /bin/sleep 4
RHEL6.9 x86_64 #
===

Expected results:
===
RHEL6.9 x86_64 # which gdb
/usr/bin/gdb
RHEL6.9 x86_64 # ./testcase.sh
24708 pts/0    S+     0:00 /bin/sleep 4
24708 pts/0    S+     0:00 /bin/sleep 4
./testcase.sh: line 20: kill: (24708) - No such process
RHEL6.9 x86_64 #
===

gdb/ChangeLog
2017-09-01  Jan Kratochvil  <jan.kratochvil@redhat.com>

	PR gdb/22046
	* nat/linux-procfs.c (parse_proc_status_state): Fix PROC_STATE_STOPPED
	detection.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] define_command: Don't convert command name to lower case
@ 2017-08-28 22:06 sergiodj+buildbot
  2017-08-28 23:04 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-08-28 22:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 95eeca3bccb6121c201183e21cb5fc39a6b711a2 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: gdb-8.0-branch
Commit: 95eeca3bccb6121c201183e21cb5fc39a6b711a2

define_command: Don't convert command name to lower case

Commit

  Command names: make them case sensitive
  3d7b173c29900879c9a5958dd6029fd36666e57c

made command name lookup case sensitive.  However, define_command, used
when creating a user-defined command, converts the command name to
lowercase, assuming that the command name lookup works in a case
insensitive way.  This causes user-defined commands with capital letters
in their name to only be callable with a lowercase version:

  (gdb) define Foo
  Type commands for definition of "Foo".
  End with a line saying just "end".
  >print 1
  >end
  (gdb) Foo
  Undefined command: "Foo".  Try "help".
  (gdb) foo
  $1 = 1

This patch removes that conversion to lowercase, so that the user can
call the command with the same name they provided.

gdb/ChangeLog:

	* cli/cli-script.c (define_command): Don't convert command name
	to lower case.

gdb/testsuite/ChangeLog:

	* gdb.base/commands.exp (user_defined_command_case_sensitivity):
	New proc, call it from toplevel.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] PR breakpoints/21886: mem-break: Fix breakpoint insertion location
@ 2017-08-11 13:36 sergiodj+buildbot
  2017-08-14 13:40 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-08-11 13:36 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b3e687f4c5e2bd847ea0608fd8960820f3efbda3 ***

Author: Maciej W. Rozycki <macro@imgtec.com>
Branch: gdb-8.0-branch
Commit: b3e687f4c5e2bd847ea0608fd8960820f3efbda3

PR breakpoints/21886: mem-break: Fix breakpoint insertion location

Fix a commit cd6c3b4ffc4e ("New gdbarch methods breakpoint_kind_from_pc
and sw_breakpoint_from_kind") regression and restore the use of
`->placed_address' rather than `->reqstd_address' as the location for a
memory breakpoint to be inserted at.  Previously
`gdbarch_breakpoint_from_pc' was used that made that adjustment in
`default_memory_insert_breakpoint' from the preinitialized value,
however with the said commit that call is gone, so the passed
`->placed_address' has to be used for the initialization.

The regression manifests itself as the inability to debug any MIPS/Linux
compressed ISA dynamic executable as GDB corrupts the dynamic loader
with one of its implicit breakpoints, causing the program to crash, as
seen for example with the `mips-linux-gnu' target, o32 ABI, MIPS16 code,
and the gdb.base/advance.exp test case:

(gdb) continue
Continuing.

Program received signal SIGBUS, Bus error.
_dl_debug_initialize (ldbase=0, ns=0) at dl-debug.c:51
51	    r = &_r_debug;
(gdb) FAIL: gdb.base/advance.exp: Can't run to main

	gdb/
	PR breakpoints/21886
	* mem-break.c (default_memory_insert_breakpoint): Use
	`->placed_address' rather than `->reqstd_address' for the
	breakpoint location.

(cherry picked from commit ba7b109b296feac8cf8cab74db5f824dfa631610)


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Catch exceptions thrown from gdbarch_skip_prologue
@ 2017-07-25 12:38 sergiodj+buildbot
  2017-07-25 17:09 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-07-25 12:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cd33a03d183a268b83ccbcae07f3788308e8d9f4 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: gdb-8.0-branch
Commit: cd33a03d183a268b83ccbcae07f3788308e8d9f4

Catch exceptions thrown from gdbarch_skip_prologue

PR 21555 is caused by the exception during the prologue analysis when re-set
a breakpoint.

(gdb) bt
 #0  memory_error_message (err=TARGET_XFER_E_IO, gdbarch=0x153db50, memaddr=93824992233232) at ../../binutils-gdb/gdb/corefile.c:192
 #1  0x00000000005718ed in memory_error (err=TARGET_XFER_E_IO, memaddr=memaddr@entry=93824992233232) at ../../binutils-gdb/gdb/corefile.c:220
 #2  0x00000000005719d6 in read_memory_object (object=object@entry=TARGET_OBJECT_CODE_MEMORY, memaddr=93824992233232, memaddr@entry=1, myaddr=myaddr@entry=0x7fffffffd0a0 "P\333S\001", len=len@entry=1) at ../../binutils-gdb/gdb/corefile.c:259
 #3  0x0000000000571c6e in read_code (len=1, myaddr=0x7fffffffd0a0 "P\333S\001", memaddr=<optimized out>) at ../../binutils-gdb/gdb/corefile.c:287
 #4  read_code_unsigned_integer (memaddr=memaddr@entry=93824992233232, len=len@entry=1, byte_order=byte_order@entry=BFD_ENDIAN_LITTLE)                          at ../../binutils-gdb/gdb/corefile.c:362
 #5  0x000000000041d4a0 in amd64_analyze_prologue (gdbarch=gdbarch@entry=0x153db50, pc=pc@entry=93824992233232, current_pc=current_pc@entry=18446744073709551615, cache=cache@entry=0x7fffffffd1e0) at ../../binutils-gdb/gdb/amd64-tdep.c:2310
 #6  0x000000000041e404 in amd64_skip_prologue (gdbarch=0x153db50, start_pc=93824992233232) at ../../binutils-gdb/gdb/amd64-tdep.c:2459
 #7  0x000000000067bfb0 in skip_prologue_sal (sal=sal@entry=0x7fffffffd4e0) at ../../binutils-gdb/gdb/symtab.c:3628
 #8  0x000000000067c4d8 in find_function_start_sal (sym=sym@entry=0x1549960, funfirstline=1) at ../../binutils-gdb/gdb/symtab.c:3501
 #9  0x000000000060999d in symbol_to_sal (result=result@entry=0x7fffffffd5f0, funfirstline=<optimized out>, sym=sym@entry=0x1549960) at ../../binutils-gdb/gdb/linespec.c:3860
....
 #16 0x000000000054b733 in location_to_sals (b=b@entry=0x15792d0, location=0x157c230, search_pspace=search_pspace@entry=0x1148120, found=found@entry=0x7fffffffdc64) at ../../binutils-gdb/gdb/breakpoint.c:14211
 #17 0x000000000054c1f5 in breakpoint_re_set_default (b=0x15792d0) at ../../binutils-gdb/gdb/breakpoint.c:14301
 #18 0x00000000005412a9 in breakpoint_re_set_one (bint=bint@entry=0x15792d0) at ../../binutils-gdb/gdb/breakpoint.c:14412

This problem can be fixed by

 - either each prologue analyzer doesn't throw exception,
 - or catch the exception thrown from gdbarch_skip_prologue,

I choose the latter because the former needs to fix *every* prologue
analyzer to not throw exception.

This error can be reproduced by changing reread.exp.  The test reread.exp
has already test that breakpoint can be reset correctly after the
executable is re-read.  This patch extends this test by compiling test c
file with and without -fPIE.

(gdb) run ^M
The program being debugged has been started already.^M
Start it from the beginning? (y or n) y^M
x86_64/gdb/testsuite/outputs/gdb.base/reread/reread' has changed; re-reading symbols.
Error in re-setting breakpoint 1: Cannot access memory at address 0x555555554790^M
Error in re-setting breakpoint 2: Cannot access memory at address 0x555555554790^M
Starting program: /scratch/yao/gdb/build-git/x86_64/gdb/testsuite/outputs/gdb.base/reread/reread ^M
This is foo^M
[Inferior 1 (process 27720) exited normally]^M
(gdb) FAIL: gdb.base/reread.exp: opts= "-fPIE" "ldflags=-pie" : run to foo() second time (the program exited)

This patch doesn't re-indent the code, to keep the patch simple.

gdb:

2017-07-25  Yao Qi  <yao.qi@linaro.org>

	PR gdb/21555
	* arch-utils.c (gdbarch_skip_prologue_noexcept): New function.
	* arch-utils.h (gdbarch_skip_prologue_noexcept): Declare.
	* infrun.c: Include arch-utils.h
	(handle_step_into_function): Call gdbarch_skip_prologue_noexcept.
	(handle_step_into_function_backward): Likewise.
	* symtab.c (skip_prologue_sal): Likewise.

gdb/testsuite:

2017-07-25  Yao Qi  <yao.qi@linaro.org>

	PR gdb/21555
	* gdb.base/reread.exp: Wrap the whole test with two kinds of
	compilation flags, with -fPIE and without -fPIE.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] [ARM] Access FPSCR on vfpv2
@ 2017-07-25 11:55 sergiodj+buildbot
  2017-07-25 14:35 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-07-25 11:55 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 50e64da58e648ff8708935add5b2a87b4e590edf ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: gdb-8.0-branch
Commit: 50e64da58e648ff8708935add5b2a87b4e590edf

[ARM] Access FPSCR on vfpv2

GDB can fetch or store FPSCR on vfpv3, which has 32 VFP registers, but
fail to do so on vfpv2, which has 16 VFP registers.  GDB code is incorrect
for vfpv2,

       else if (tdep->vfp_register_count > 0
 	       && regno >= ARM_D0_REGNUM
	       && regno <= ARM_D0_REGNUM + tdep->vfp_register_count)

while FPSCR register number is defined as ARM_D0_REGNUM + 32.

  ARM_D0_REGNUM,		/* VFP double-precision registers.  */
  ARM_D31_REGNUM = ARM_D0_REGNUM + 31,
  ARM_FPSCR_REGNUM,

The code above uses "<=" rather than "<", in order to put FPSCR in the
range, but it is only correct when tdep->vfp_register_count is 32.  On
vpfv2, it is 16, and FPSCR is out of the range, so fetch_vfp_regs or
store_vfp_regs are not called.

gdb:

2017-07-25  Yao Qi  <yao.qi@linaro.org>

	PR tdep/21717
	* arm-linux-nat.c (arm_linux_fetch_inferior_registers): Update
	condition for FPSCR.
	(arm_linux_store_inferior_registers): Likewise.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Bump GDB version number to 8.0.0.DATE-git.
@ 2017-06-04 17:35 sergiodj+buildbot
  2017-06-04 20:39 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-06-04 17:35 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ec8457a3b04f48c6f7750044f1145b002eebb281 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: gdb-8.0-branch
Commit: ec8457a3b04f48c6f7750044f1145b002eebb281

Bump GDB version number to 8.0.0.DATE-git.

gdb/ChangeLog:

	* version.in: Set GDB version number to 8.0.0.DATE-git.
	* PROBLEMS: Likewise.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Set GDB version number to 8.0.
@ 2017-06-04 16:16 sergiodj+buildbot
  2017-06-04 18:21 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-06-04 16:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1f1c02597cc199227226251a2ea51fe5f44b4d6d ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: gdb-8.0-branch
Commit: 1f1c02597cc199227226251a2ea51fe5f44b4d6d

Set GDB version number to 8.0.

gdb/ChangeLog:

	* version.in: Set GDB version number to 8.0.
	* PROBLEMS: Likewise.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Avoid compilation warning on MinGW in xstrndup
@ 2017-05-31  9:51 sergiodj+buildbot
  2017-06-01  9:35 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-05-31  9:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ce3dd59c3d6e677bb6bbed432205d3a75476f548 ***

Author: Eli Zaretskii <eliz@gnu.org>
Branch: gdb-8.0-branch
Commit: ce3dd59c3d6e677bb6bbed432205d3a75476f548

Avoid compilation warning on MinGW in xstrndup

libiberty/ChangeLog:

2017-05-31  DJ Delorie  <dj@redhat.com>

	* configure.ac (strnlen): Add to AC_CHECK_DECLS.
	* configure: Likewise.
	* config.in: Add HACE_DECL_STRNLEN.

(cherry picked from commit 5b4a1ff337973732ff9a5ad9b1cb84d74a7e6185)


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Make libiberty/waitpid.c compile without warnings on MinGW
@ 2017-05-31  9:00 sergiodj+buildbot
  2017-06-01  7:36 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-05-31  9:00 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 704f06fe081d9b17eb192c0db91d8367edcd6c9e ***

Author: Eli Zaretskii <eliz@gnu.org>
Branch: gdb-8.0-branch
Commit: 704f06fe081d9b17eb192c0db91d8367edcd6c9e

Make libiberty/waitpid.c compile without warnings on MinGW

libiberty/ChangeLog:

2017-05-31  Eli Zaretskii  <eliz@gnu.org>

	* waitpid.c (wait) [__MINGW32__]: Define as a macro
	that calls _cwait, so that this function works on MinGW.

(cherry picked from commit 90b4491842980d57a0e572167a168e04a476bca5)


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Fix MinGW compilation warnings due to environ.h
@ 2017-05-31  8:40 sergiodj+buildbot
  2017-06-01  6:47 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-05-31  8:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1e4004c976aaf2b9881f6044cefdb0941e38ddb9 ***

Author: Eli Zaretskii <eliz@gnu.org>
Branch: gdb-8.0-branch
Commit: 1e4004c976aaf2b9881f6044cefdb0941e38ddb9

Fix MinGW compilation warnings due to environ.h

include/ChangeLog:

2017-05-31  Eli Zaretskii <eliz@gnu.org>

	* environ.h: Add #ifndef guard.

(cherry picked from commit b9c6833008dfb3c45354f4e810e631a77f3c9cb3)


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Fix NEWS formatting in GDB 8.0 section
@ 2017-05-30 12:15 sergiodj+buildbot
  2017-05-30 20:01 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-05-30 12:15 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d65c730fcebc853250aee5e33693c9e13e9b26ed ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: gdb-8.0-branch
Commit: d65c730fcebc853250aee5e33693c9e13e9b26ed

Fix NEWS formatting in GDB 8.0 section

Change the GDB 8.0 section of the NEWS file to try to follow this order:

  * Functional changes
  * Added and removed configurations and targets
  * New commands
  * New options
  * MI changes

In particular, there were two "New commands" sections.

gdb/ChangeLog:

	* NEWS (Changes in GDB 8.0): Remove extra empty line.  Move
	"Removed targets and native configurations" up.  Merge duplicate
	"New commands" sub-sections.  Add "New options" sub-sections.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Fix compilation errors with mingw.org's MinGW runtime 3.X
@ 2017-05-26  8:02 sergiodj+buildbot
  2017-05-26  9:28 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-05-26  8:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fefc936892e3a1058a7b89fe5bb58366bf78fe74 ***

Author: Eli Zaretskii <eliz@gnu.org>
Branch: gdb-8.0-branch
Commit: fefc936892e3a1058a7b89fe5bb58366bf78fe74

Fix compilation errors with mingw.org's MinGW runtime 3.X

gdb/ChangeLog:

2017-05-26  Eli Zaretskii  <eliz@gnu.org>

	* cli/cli-script.c (user_args::insert_args): Call gdb::to_string.

	* common/common-utils.h (REPLACE_TO_STRING) [__MINGW32__]: Define
	to 1 if std::to_string is not available.
	(gdb::to_string) [REPLACE_TO_STRING]: Provide a replacement
	implementation for std::string.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Fix tui compilation with Solaris libcurses: clear define (PR tui/21482)
@ 2017-05-19 13:46 sergiodj+buildbot
  2017-05-19 19:12 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-05-19 13:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 814385bb257fec68e0e64d43f2ccc40e219342e7 ***

Author: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Branch: gdb-8.0-branch
Commit: 814385bb257fec68e0e64d43f2ccc40e219342e7

Fix tui compilation with Solaris libcurses: clear define (PR tui/21482)


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Fix tui compilation with Solaris libcurses: non-const last arg to mvwaddstr (PR tui/21482)
@ 2017-05-19 12:57 sergiodj+buildbot
  2017-05-19 16:44 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-05-19 12:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a1cc26f6c36117f7abbd1e7d347030c37ebb30b6 ***

Author: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Branch: gdb-8.0-branch
Commit: a1cc26f6c36117f7abbd1e7d347030c37ebb30b6

Fix tui compilation with Solaris libcurses: non-const last arg to mvwaddstr (PR tui/21482)


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Avoid MinGW compilation warning in readline/input.c
@ 2017-05-19  9:07 sergiodj+buildbot
  2017-05-19 11:28 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-05-19  9:07 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 958d57d02d936913a4f9d54810ee0fceb763aa35 ***

Author: Eli Zaretskii <eliz@gnu.org>
Branch: gdb-8.0-branch
Commit: 958d57d02d936913a4f9d54810ee0fceb763aa35

Avoid MinGW compilation warning in readline/input.c

This change was already accepted upstream in Readline.

readline/ChangeLog.gdb:

2017-05-19  Eli Zaretskii  <eliz@gnu.org>

	* input.c [_WIN32]: Include <conio.h> to avoid compiler warning on
	MinGW.

(cherry picked from commit 50e1d299ef1d21b0833c2fe1484d3cc374e6486f)


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Expect prompt after no FPU warning
@ 2017-05-18 16:36 sergiodj+buildbot
  2017-05-18 18:20 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-05-18 16:36 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f864c7e8536b0e3e860e99cd6b9188b0fbbd7912 ***

Author: Thomas Preud'homme <thomas.preudhomme@arm.com>
Branch: gdb-8.0-branch
Commit: f864c7e8536b0e3e860e99cd6b9188b0fbbd7912

Expect prompt after no FPU warning

2017-05-18  Thomas Preud'homme  <thomas.preudhomme@arm.com>

gdb/testsuite/
	* gdb.base/float.exp: Expect GDB prompt for targets without FPU.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Add alias command to cmd_list_element
@ 2017-05-17 15:54 sergiodj+buildbot
  2017-05-17 16:51 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-05-17 15:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT efaba6bc8fa1cb074bcaa16f48766164ccaa1005 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: gdb-8.0-branch
Commit: efaba6bc8fa1cb074bcaa16f48766164ccaa1005

Add alias command to cmd_list_element

When we add alias command, we call add_alias_cmd and pass the alias name
and command name.  This implicitly requires the command and its prefix
commands are already added to cmdlist.  This may not be true, for example,

  add_com_alias ("tty", "set inferior-tty", class_alias, 0);

"inferior-tty" command is added to setlist, but setlist may not be added
to cmdlist (It depends on the order of related _initialize_XXX functions
called) so that we can't find "set inferior-tty" from cmdlist.

This patch fixes this problem by passing cmd_list_element of "inferior-tty"
to add_alias_cmd, so that cmd_list_element of "inferior-tty" doesn't have
to be reachable from cmdlist at that moment.

gdb:

2017-05-17  Yao Qi  <yao.qi@linaro.org>

	* cli/cli-decode.c (add_alias_cmd): New function.
	* command.h (add_alias_cmd): Declare.
	* infcmd.c (_initialize_infcmd): Don't call add_com_alias,
	instead call add_alias_cmd.

gdb/testsuite:

2017-05-17  Simon Marchi  <simon.marchi@ericsson.com>

	* gdb.base/set-inferior-tty.exp (test_set_inferior_tty): Add
	argument command.
	(top-level): Invoke test_set_inferior_tty.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Avoid exponential behavior in rust_evaluate_subexp
@ 2017-05-17  6:09 sergiodj+buildbot
  2017-05-17 11:49 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-05-17  6:09 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 69e9e8a0d5ae31e9869658771a7d399a53ac7833 ***

Author: Tom Tromey <tom@tromey.com>
Branch: gdb-8.0-branch
Commit: 69e9e8a0d5ae31e9869658771a7d399a53ac7833

Avoid exponential behavior in rust_evaluate_subexp

The STRUCTOP_STRUCT case in rust_evaluate_subexp would evaluate its
LHS, and then, if it did not need Rust-specific treatment, it would
back up and re-evaluate the entire STRUCTOP_STRUCT part of the
expression using evaluate_subexp_standard.  This yields exponential
behavior and causes some expressions to evaluate extremely slowly.

The fix is to simply do the needed work inline.

This is PR rust/21483.

2017-05-12  Tom Tromey  <tom@tromey.com>

	PR rust/21483:
	* rust-lang.c (rust_evaluate_subexp) <STRUCTOP_STRUCT>: Don't
	recurse, just call value_struct_elt directly.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Fix rust_dump_subexp_body
@ 2017-05-17  5:53 sergiodj+buildbot
  2017-05-17 11:05 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-05-17  5:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b6486c1f82fab968ee119b0fbcfadfdbd0dad745 ***

Author: Tom Tromey <tom@tromey.com>
Branch: gdb-8.0-branch
Commit: b6486c1f82fab968ee119b0fbcfadfdbd0dad745

Fix rust_dump_subexp_body

rust_dump_subexp_body was not correct in a couple of cases.  While
debugging the bug I was really interested in, this caused a crash.
This patch fixes the problems.  No test case because, IIRC there
generally aren't tests for expression dumping.

2017-05-12  Tom Tromey  <tom@tromey.com>

	* rust-lang.c (rust_dump_subexp_body) <STRUCTOP_ANONYMOUS,
	OP_RUST_ARRAY>: Fix.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Replace "return" with "break"
@ 2017-05-17  5:31 sergiodj+buildbot
  2017-05-17  9:54 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-05-17  5:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d05228c1bb3b8f8b9e187c4b76d0c71a72ba15e8 ***

Author: Tom Tromey <tom@tromey.com>
Branch: gdb-8.0-branch
Commit: d05228c1bb3b8f8b9e187c4b76d0c71a72ba15e8

Replace "return" with "break"

This replaces a "return" with a "break" in rust_print_subexp, for
consistency.

2017-05-12  Tom Tromey  <tom@tromey.com>

	* rust-lang.c (rust_print_subexp): Replace "return" with "break".


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Fix gdb 8.0 procfs.c compilation on Solaris
@ 2017-05-15 12:58 sergiodj+buildbot
  2017-05-15 14:09 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-05-15 12:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 81aeac9bbd02fc80048e51a1bb67484eb58852dc ***

Author: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Branch: gdb-8.0-branch
Commit: 81aeac9bbd02fc80048e51a1bb67484eb58852dc

Fix gdb 8.0 procfs.c compilation on Solaris

Prompted by the creation of the gdb 8.0 branch, I tried to build it on
x86_64-pc-solaris2.12, but failed:

/vol/src/gnu/gdb/gdb-8.0-branch/local/gdb/procfs.c: In function `target_ops* procfs_target()':
/vol/src/gnu/gdb/gdb-8.0-branch/local/gdb/procfs.c:186:27: error: invalid conversion from `void (*)(target_ops*, char*, char*, char**, int)' to `void (*)(target_ops*, const char*, const string&, char**, int) {aka void (*)(target_ops*, const char*, const std::__cxx11::basic_string<char>&, char**, int)}' [-fpermissive]
   t->to_create_inferior = procfs_create_inferior;
                           ^~~~~~~~~~~~~~~~~~~~~~
/vol/src/gnu/gdb/gdb-8.0-branch/local/gdb/procfs.c: At global scope:
/vol/src/gnu/gdb/gdb-8.0-branch/local/gdb/procfs.c:125:13: warning: `void procfs_create_inferior(target_ops*, char*, char*, char**, int)' declared `static' but never defined [-Wunused-function]
 static void procfs_create_inferior (struct target_ops *, char *,
             ^~~~~~~~~~~~~~~~~~~~~~
/vol/src/gnu/gdb/gdb-8.0-branch/local/gdb/procfs.c:4529:1: warning: `void procfs_create_inferior(target_ops*, const char*, const string&, char**, int)' defined but not used [-Wunused-function]
 procfs_create_inferior (struct target_ops *ops, const char *exec_file,
 ^~~~~~~~~~~~~~~~~~~~~~

This can easily be fixed by the following patch.

	* procfs.c (procfs_create_inferior): Change prototype to match
	definition.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Bump GDB version number to 7.99.91.DATE-git.
@ 2017-05-04 20:47 sergiodj+buildbot
  2017-05-05  6:05 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-05-04 20:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 65ea01b5924c8ed220368def5dde3151d071d6df ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: gdb-8.0-branch
Commit: 65ea01b5924c8ed220368def5dde3151d071d6df

Bump GDB version number to 7.99.91.DATE-git.

gdb/ChangeLog:

	* version.in: Set GDB version number to 7.99.91.DATE-git.
	* PROBLEMS: Likewise.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Set GDB version number to 7.99.91.
@ 2017-05-04 20:26 sergiodj+buildbot
  2017-05-05  4:35 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-05-04 20:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 893df71e62f1ec3b3f2799a919db936e60adf820 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: gdb-8.0-branch
Commit: 893df71e62f1ec3b3f2799a919db936e60adf820

Set GDB version number to 7.99.91.

gdb/ChangeLog:

	* version.in: Set GDB version number to 7.99.91.
	* PROBLEMS: Likewise.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] gdb/NEWS: rewrite "since GDB 7.12" into "in GDB 8.0"
@ 2017-05-04 20:08 sergiodj+buildbot
  2017-05-05  2:59 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-05-04 20:08 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6261be561546d93adb47bbd354e290896444b149 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: gdb-8.0-branch
Commit: 6261be561546d93adb47bbd354e290896444b149

gdb/NEWS: rewrite "since GDB 7.12" into "in GDB 8.0"

gdb/ChangeLog:

        * NEWS: Rename the "Changes since GDB 7.12" section into
        "Changes in GDB 8.0".


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Fix gdb.python/py-record-btrace-threads.exp with Python 3
@ 2017-05-04 16:25 sergiodj+buildbot
  2017-05-05  1:25 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-05-04 16:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1332b4fa37e2b688533ef3eb86a7b1aaced90465 ***

Author: Pedro Alves <palves@redhat.com>
Branch: gdb-8.0-branch
Commit: 1332b4fa37e2b688533ef3eb86a7b1aaced90465

Fix gdb.python/py-record-btrace-threads.exp with Python 3

Fix several instances of:

 ...
 python print not f1calls
   File "<string>", line 1
     print not f1calls
		     ^
 SyntaxError: Missing parentheses in call to 'print'
 Error while executing Python code.
 (gdb) FAIL: gdb.python/py-record-btrace-threads.exp: thread=1: checking thread 1: python print not f1calls
 ...

gdb/testsuite/ChangeLog:
2017-05-04  Pedro Alves  <palves@redhat.com>

	* gdb.python/py-record-btrace-threads.exp (check_insn_for_thread):
	Add parens to print call for Python 3.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Python: Introduce gdb.Instruction class
@ 2017-05-04 12:07 sergiodj+buildbot
  2017-05-04 18:50 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-05-04 12:07 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ac7d85722af3e8a4db69940b77b82ca173ba3877 ***

Author: Tim Wiederhake <tim.wiederhake@intel.com>
Branch: gdb-8.0-branch
Commit: ac7d85722af3e8a4db69940b77b82ca173ba3877

Python: Introduce gdb.Instruction class

This adds a generic instruction class to Python and has gdb.RecordInstruction
inherit from it.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Python: Move and rename gdb.BtraceFunction
@ 2017-05-04 11:08 sergiodj+buildbot
  2017-05-04 17:49 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-05-04 11:08 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5b2f026c0dca5e25c98f2a8288365386ec5bdffc ***

Author: Tim Wiederhake <tim.wiederhake@intel.com>
Branch: gdb-8.0-branch
Commit: 5b2f026c0dca5e25c98f2a8288365386ec5bdffc

Python: Move and rename gdb.BtraceFunction

Remove gdb.BtraceFunctionCall and replace by gdb.FunctionSegment.  Additionally,
rename prev_segment and next_segment to prev and next.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Python: Move and rename gdb.BtraceInstruction
@ 2017-05-04 10:21 sergiodj+buildbot
  2017-05-04 16:29 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-05-04 10:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d76700e0a47cb2406da25c80f9c76c4c50424adc ***

Author: Tim Wiederhake <tim.wiederhake@intel.com>
Branch: gdb-8.0-branch
Commit: d76700e0a47cb2406da25c80f9c76c4c50424adc

Python: Move and rename gdb.BtraceInstruction

Remove gdb.BtraceInstruction and replace by gdb.RecordInstruction.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Python: Remove ptid from gdb.Record interface
@ 2017-05-04  9:09 sergiodj+buildbot
  2017-05-04 14:04 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-05-04  9:09 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 26597c93accd6121c7aba550dfc6b1f78dfbfe6f ***

Author: Tim Wiederhake <tim.wiederhake@intel.com>
Branch: gdb-8.0-branch
Commit: 26597c93accd6121c7aba550dfc6b1f78dfbfe6f

Python: Remove ptid from gdb.Record interface

As discussed here: https://sourceware.org/ml/gdb-patches/2017-04/msg00166.html


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Python: Fix indentation in py-record-btrace.c
@ 2017-05-04  7:31 sergiodj+buildbot
  2017-05-04 11:27 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-05-04  7:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d4c682630c6ff6c8e159b833e7a8f2915853369a ***

Author: Tim Wiederhake <tim.wiederhake@intel.com>
Branch: gdb-8.0-branch
Commit: d4c682630c6ff6c8e159b833e7a8f2915853369a

Python: Fix indentation in py-record-btrace.c


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Make sure malloc is linked into gdb.cp/oranking.cc.
@ 2017-05-03 19:59 sergiodj+buildbot
  2017-05-03 20:50 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-05-03 19:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c2449d01b73b19acaf5add85b64c584fca9da366 ***

Author: Keith Seitz <keiths@redhat.com>
Branch: gdb-8.0-branch
Commit: c2449d01b73b19acaf5add85b64c584fca9da366

Make sure malloc is linked into gdb.cp/oranking.cc.

On some platforms, e.g., arm-eabi-none, we need to make certain that
malloc is linked into the program because the test suite uses function
calls requiring malloc:

(gdb) p foo101("abc")
evaluation of this expression requires the program to have a function "malloc".

gdb/testsuite/ChangeLog

	* gdb.cp/oranking.cc (dummy): New function to grab malloc.
	(main): Call it.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Use ptid method lwp in mips_linux_new_thread
@ 2017-04-28 10:12 sergiodj+buildbot
  2017-04-28 16:43 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-04-28 10:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d41089194ff10dc538fce0bcd4c30fc4d94935d3 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: gdb-8.0-branch
Commit: d41089194ff10dc538fce0bcd4c30fc4d94935d3

Use ptid method lwp in mips_linux_new_thread

gdb:

2017-04-28  Yao Qi  <yao.qi@linaro.org>

	* mips-linux-nat.c (mips_linux_new_thread): Use ptid method
	lwp instead of ptid_get_lwp.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] [MIPS] Use lwpid from lwp_info instead of inferior_ptid
@ 2017-04-28  9:32 sergiodj+buildbot
  2017-04-28 13:27 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-04-28  9:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c6767e625c0fb73c9a12d991140670a00ad8284c ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: gdb-8.0-branch
Commit: c6767e625c0fb73c9a12d991140670a00ad8284c

[MIPS] Use lwpid from lwp_info instead of inferior_ptid

RAJESH reported that GDB gets "Couldn't write debug register: No such
process." on mips64 when GDB attaches to a multi threaded application.

Looks GDB nows PTRACE_GET_WATCH_REGS for inferior_ptid but
PTRACE_SET_WATCH_REGS for lwp->ptid, they may be different.

gdb:

2017-04-28  Yao Qi  <yao.qi@linaro.org>

	* mips-linux-nat.c (mips_linux_new_thread): Get lwpid from
	lwp_info instead of getting from inferior_ptid.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Fix overload resolution involving rvalue references and cv qualifiers.
@ 2017-04-28  0:50 sergiodj+buildbot
  2017-04-28  5:00 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-04-28  0:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 16de50a5e2c368fa8e1213697a15ed5b5bea574f ***

Author: Keith Seitz <keiths@redhat.com>
Branch: gdb-8.0-branch
Commit: 16de50a5e2c368fa8e1213697a15ed5b5bea574f

Fix overload resolution involving rvalue references and cv qualifiers.

The following patch fixes several outstanding overload resolution problems
with rvalue references and cv qualifiers in the test suite. The tests for
these problems typically passed with one compiler version and failed with
another. This behavior occurs because of the ordering of the overloaded
functions in the debug info. So the first best match "won out" over the
a subsequent better match.

One of the bugs addressed by this patch is the failure of rank_one_type to
account for type equality of two overloads based on CV qualifiers.  This was
leading directly to problems evaluating rvalue reference overload quality,
but it is also highlighted in gdb.cp/oranking.exp, where two test KFAIL as
a result of this shortcoming.

I found the overload resolution code committed with the rvalue reference
patch (f9aeb8d49) needlessly over-complicated, and I have greatly simplified
it. This fixes some KFAILing tests in gdb.exp/rvalue-ref-overload.exp.

gdb/ChangeLog

	* gdbtypes.c (LVALUE_REFERENCE_TO_RVALUE_BINDING_BADNESS)
	DIFFERENT_REFERENCE_TYPE_BADNESS): Remove.
	(CV_CONVERSION_BADNESS): Define.
	(rank_one_type): Remove overly restrictive rvalue reference
	rank checks.
	Add cv-qualifier checks and subranks for type equality.
	* gdbtypes.h (REFERENCE_CONVERSION_RVALUE,
	REFERENCE_CONVERSION_CONST_LVALUE, CV_CONVERSION_BADNESS,
	CV_CONVERSION_CONST, CV_CONVERSION_VOLATILE): Declare.

gdb/testsuite/ChangeLog

	* gdb.cp/oranking.cc (test15): New function.
	(main): Call test15 and declare additional variables for testing.
	* gdb.cp/oranking.exp: Remove kfail status for "p foo4(&a)" and
	"p foo101('abc')" tests.
	* gdb.cp/rvalue-ref-overloads.exp: Remove kfail status for
	"lvalue reference overload" test.
	* gdb.cp/rvalue-ref-params.exp: Remove kfail status for
	"print value of f1 on Child&& in f2" test.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Add missing incref when creating Inferior Python object
@ 2017-04-27 23:32 sergiodj+buildbot
  2017-04-28  1:56 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-04-27 23:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9b81aa9a8b1f488939b65ce59b6ba71477c4b8d4 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: gdb-8.0-branch
Commit: 9b81aa9a8b1f488939b65ce59b6ba71477c4b8d4

Add missing incref when creating Inferior Python object

The test py-inferior.exp fails when using a debug build of Python 3.6.  I don't
see it failing with my system's default Python, but it might be related to the
different memory allocation scheme used when doing a build with pydebug.

The issue is that we are missing a Py_INCREF in
inferior_to_inferior_object.  The PyObject_New function initializes the
object with a refcount of 1.  If we assume that this refcount
corresponds to the reference we are returning, then we are missing an
incref for the reference in the inferior data.

The counterpart for the incref that corresponds to the reference in the
inferior data is in py_free_inferior, in the form the gdbpy_ref instance.

Here's how I can get it to crash (with some debug output):

  $ ./gdb -nx -ex "set debug python 1"
  (gdb) add-inferior
  Added inferior 2
  (gdb) python infs = gdb.inferiors()
  Creating Python Inferior object inf = 1
  Creating Python Inferior object inf = 2
  (gdb) remove-inferiors 2
  py_free_inferior inf = 2
  infpy_dealloc inf = <unknown>
  (gdb) python infs = None
  Fatal Python error: Objects/tupleobject.c:243 object at 0x7f9cf1a568d8 has negative ref count -1

  Current thread 0x00007f9cf1b68780 (most recent call first):
    File "<string>", line 1 in <module>
  [1]    408 abort (core dumped)  ./gdb -nx -ex "set debug python 1"

After having created the inferiors object, their refcount is 1 (which
comes from PyObject_New), but it should be two.  The gdb inferior object
has a reference and the "infs" list has a reference.

When invoking remove-inferiors, py_free_inferior gets called.  It does
the decref that corresponds to the reference that the gdb inferior
object kept.  At this moment, the refcount drops to 0 and the object
gets deallocated, even though the "infs" list still has a reference.
When we set "infs" to None, Python tries to decref the already zero
refcount and the assert triggers.

With this patch, it looks better:

  (gdb) add-inferior
  Added inferior 2
  (gdb) python infs = gdb.inferiors()
  Creating Python Inferior object inf = 1
  Creating Python Inferior object inf = 2
  (gdb) remove-inferiors 2
  py_free_inferior inf = 2
  (gdb) python infs = None
  infpy_dealloc inf = <unknown>

gdb/ChangeLog:

	* python/py-inferior.c (inferior_to_inferior_object): Increment reference
	count when creating the object.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Change gdbarch_wchar_bit for AArch64 and ARM
@ 2017-04-25 14:57 sergiodj+buildbot
  2017-04-25 22:10 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-04-25 14:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f7cc213124f45b589c7b4bd9420252dc126282d9 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: gdb-8.0-branch
Commit: f7cc213124f45b589c7b4bd9420252dc126282d9

Change gdbarch_wchar_bit for AArch64 and ARM

The size of wchar_t on AArch64 and ARM is 4-byte, so we can use the
default value (4*TARGET_CHAR_BIT).

This patch fixes some fails in gdb.cp/wide_char_types.exp on
aarch64-linux.

gdb:

2017-04-25  Yao Qi  <yao.qi@linaro.org>

	* aarch64-tdep.c (aarch64_gdbarch_init): Don't call
	set_gdbarch_wchar_bit.
	* arm-tdep.c (arm_gdbarch_init): Likewise.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] release branch: Fix: --enable-werror
@ 2017-04-21 18:09 sergiodj+buildbot
  2017-04-21 18:07 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-04-21 18:09 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b2e445cf19788caa3640e8cfacab82995d2b1d13 ***

Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Branch: gdb-8.0-branch
Commit: b2e445cf19788caa3640e8cfacab82995d2b1d13

release branch: Fix: --enable-werror

gdb-8.0-branch
./configure --enable-werror --enable-targets=all
aarch64-tdep.c:3045:13: error: void selftests::aarch64_process_record_test() declared static but never defined [-Werror=unused-function]
arm-tdep.c:9601:13: error: void selftests::arm_record_test() declared static but never defined [-Werror=unused-function]

gdb/ChangeLog
2017-04-21  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* aarch64-tdep.c (selftests::aarch64_process_record_test): Make it #if
	GDB_SELF_TEST.
	* arm-tdep.c (selftests::arm_record_test): Likewise.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] PR threads/20743: Don't attempt to suspend or resume exited threads.
@ 2017-04-18 17:29 sergiodj+buildbot
  2017-04-18 19:15 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-04-18 17:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 24b03ea864424cf8482ba07fb074389aa759e592 ***

Author: John Baldwin <jhb@FreeBSD.org>
Branch: gdb-8.0-branch
Commit: 24b03ea864424cf8482ba07fb074389aa759e592

PR threads/20743: Don't attempt to suspend or resume exited threads.

When resuming a native FreeBSD process, ignore exited threads when
suspending/resuming individual threads prior to continuing the process.

gdb/ChangeLog:

	PR threads/20743
	* fbsd-nat.c (resume_one_thread_cb): Remove.
	(resume_all_threads_cb): Remove.
	(fbsd_resume): Use ALL_NON_EXITED_THREADS instead of
	iterate_over_threads.


^ permalink raw reply	[flat|nested] 63+ messages in thread
* [binutils-gdb/gdb-8.0-branch] Set development mode to "off" by default.
@ 2017-04-17 15:22 sergiodj+buildbot
  2017-04-17 19:32 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
  0 siblings, 1 reply; 63+ messages in thread
From: sergiodj+buildbot @ 2017-04-17 15:22 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2e341fefa9fb8e63c9ac930a1f2228a06d496706 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: gdb-8.0-branch
Commit: 2e341fefa9fb8e63c9ac930a1f2228a06d496706

Set development mode to "off" by default.

bfd/ChangeLog:

	* development.sh (development): Set to false.


^ permalink raw reply	[flat|nested] 63+ messages in thread
end of thread, other threads:[~2018-05-30 16:57 UTC | newest]

Thread overview: 63+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-27  0:15 [binutils-gdb/gdb-8.0-branch] Fix dwarf2_string_attr for -gsplit-dwarf sergiodj+buildbot
2017-10-27  0:15 ` Failures on Fedora-s390x-m64, branch gdb-8.0-branch sergiodj+buildbot
2017-10-27 15:01 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, " sergiodj+buildbot
2017-10-27 15:30 ` Failures on Ubuntu-AArch64-m64, " sergiodj+buildbot
2017-10-28  1:13 ` Failures on Ubuntu-AArch32-m32, " sergiodj+buildbot
2017-10-28  1:38 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, " sergiodj+buildbot
2017-10-28  2:50 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, " sergiodj+buildbot
2017-10-28  5:22 ` Failures on Fedora-x86_64-native-gdbserver-m32, " sergiodj+buildbot
2017-10-28  5:44 ` Failures on Fedora-x86_64-native-gdbserver-m64, " sergiodj+buildbot
2017-10-28  5:50 ` Failures on Fedora-x86_64-m64, " sergiodj+buildbot
2017-10-28  6:02 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " sergiodj+buildbot
2017-10-28  6:21 ` Failures on Fedora-x86_64-m32, " sergiodj+buildbot
2017-10-28  6:38 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " sergiodj+buildbot
2017-10-28  6:46 ` Failures on Fedora-i686, " sergiodj+buildbot
  -- strict thread matches above, loose matches on Subject: below --
2018-05-21  9:58 [binutils-gdb/gdb-8.0-branch] Fix AArch64 debug trace build sergiodj+buildbot
2018-05-30 18:08 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2018-01-24 19:40 [binutils-gdb/gdb-8.0-branch] Fix GCC PR83906 - [8 Regression] Random FAIL: libstdc++-prettyprinters/80276.cc whatis p4 sergiodj+buildbot
2018-01-24 20:42 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2018-01-15 19:11 [binutils-gdb/gdb-8.0-branch] Fix scm-ports.exp regression sergiodj+buildbot
2018-01-15 19:38 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2018-01-03 15:41 [binutils-gdb/gdb-8.0-branch] Fix PR19061, gdb hangs/spins-on-cpu when debugging any program on Alpha sergiodj+buildbot
2018-01-03 15:41 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-10-16  8:26 [binutils-gdb/gdb-8.0-branch] PR22137: gdbserver crashes on host with pkru register sergiodj+buildbot
2017-10-18  7:44 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-09-07 16:12 [binutils-gdb/gdb-8.0-branch] Bump GDB version number to 8.0.1.DATE-git sergiodj+buildbot
2017-09-07 16:35 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-09-05 20:39 [binutils-gdb/gdb-8.0-branch] Test different follow-exec-mode settings in gdb.multi/multi-arch-exec.exp sergiodj+buildbot
2017-09-05 22:28 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-09-05 20:09 [binutils-gdb/gdb-8.0-branch] Add thread after updating gdbarch when exec'ing sergiodj+buildbot
2017-09-05 22:06 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-09-05 19:23 [binutils-gdb/gdb-8.0-branch] Read stop_pc after updating the gdbarch when exec'ing sergiodj+buildbot
2017-09-05 20:36 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-09-05 18:17 [binutils-gdb/gdb-8.0-branch] Improve "'g' reply is is to long" error message sergiodj+buildbot
2017-09-05 19:53 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-09-01  5:50 [binutils-gdb/gdb-8.0-branch] PR gdb/22046: Fix T-stopped detach regression on old Linux kernels sergiodj+buildbot
2017-09-01  9:18 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-08-28 22:06 [binutils-gdb/gdb-8.0-branch] define_command: Don't convert command name to lower case sergiodj+buildbot
2017-08-28 23:04 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-08-11 13:36 [binutils-gdb/gdb-8.0-branch] PR breakpoints/21886: mem-break: Fix breakpoint insertion location sergiodj+buildbot
2017-08-14 13:40 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-07-25 12:38 [binutils-gdb/gdb-8.0-branch] Catch exceptions thrown from gdbarch_skip_prologue sergiodj+buildbot
2017-07-25 17:09 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-07-25 11:55 [binutils-gdb/gdb-8.0-branch] [ARM] Access FPSCR on vfpv2 sergiodj+buildbot
2017-07-25 14:35 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-06-04 17:35 [binutils-gdb/gdb-8.0-branch] Bump GDB version number to 8.0.0.DATE-git sergiodj+buildbot
2017-06-04 20:39 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-06-04 16:16 [binutils-gdb/gdb-8.0-branch] Set GDB version number to 8.0 sergiodj+buildbot
2017-06-04 18:21 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-05-31  9:51 [binutils-gdb/gdb-8.0-branch] Avoid compilation warning on MinGW in xstrndup sergiodj+buildbot
2017-06-01  9:35 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-05-31  9:00 [binutils-gdb/gdb-8.0-branch] Make libiberty/waitpid.c compile without warnings on MinGW sergiodj+buildbot
2017-06-01  7:36 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-05-31  8:40 [binutils-gdb/gdb-8.0-branch] Fix MinGW compilation warnings due to environ.h sergiodj+buildbot
2017-06-01  6:47 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-05-30 12:15 [binutils-gdb/gdb-8.0-branch] Fix NEWS formatting in GDB 8.0 section sergiodj+buildbot
2017-05-30 20:01 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-05-26  8:02 [binutils-gdb/gdb-8.0-branch] Fix compilation errors with mingw.org's MinGW runtime 3.X sergiodj+buildbot
2017-05-26  9:28 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-05-19 13:46 [binutils-gdb/gdb-8.0-branch] Fix tui compilation with Solaris libcurses: clear define (PR tui/21482) sergiodj+buildbot
2017-05-19 19:12 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-05-19 12:57 [binutils-gdb/gdb-8.0-branch] Fix tui compilation with Solaris libcurses: non-const last arg to mvwaddstr (PR tui/21482) sergiodj+buildbot
2017-05-19 16:44 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-05-19  9:07 [binutils-gdb/gdb-8.0-branch] Avoid MinGW compilation warning in readline/input.c sergiodj+buildbot
2017-05-19 11:28 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-05-18 16:36 [binutils-gdb/gdb-8.0-branch] Expect prompt after no FPU warning sergiodj+buildbot
2017-05-18 18:20 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-05-17 15:54 [binutils-gdb/gdb-8.0-branch] Add alias command to cmd_list_element sergiodj+buildbot
2017-05-17 16:51 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-05-17  6:09 [binutils-gdb/gdb-8.0-branch] Avoid exponential behavior in rust_evaluate_subexp sergiodj+buildbot
2017-05-17 11:49 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-05-17  5:53 [binutils-gdb/gdb-8.0-branch] Fix rust_dump_subexp_body sergiodj+buildbot
2017-05-17 11:05 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-05-17  5:31 [binutils-gdb/gdb-8.0-branch] Replace "return" with "break" sergiodj+buildbot
2017-05-17  9:54 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-05-15 12:58 [binutils-gdb/gdb-8.0-branch] Fix gdb 8.0 procfs.c compilation on Solaris sergiodj+buildbot
2017-05-15 14:09 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-05-04 20:47 [binutils-gdb/gdb-8.0-branch] Bump GDB version number to 7.99.91.DATE-git sergiodj+buildbot
2017-05-05  6:05 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-05-04 20:26 [binutils-gdb/gdb-8.0-branch] Set GDB version number to 7.99.91 sergiodj+buildbot
2017-05-05  4:35 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-05-04 20:08 [binutils-gdb/gdb-8.0-branch] gdb/NEWS: rewrite "since GDB 7.12" into "in GDB 8.0" sergiodj+buildbot
2017-05-05  2:59 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-05-04 16:25 [binutils-gdb/gdb-8.0-branch] Fix gdb.python/py-record-btrace-threads.exp with Python 3 sergiodj+buildbot
2017-05-05  1:25 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-05-04 12:07 [binutils-gdb/gdb-8.0-branch] Python: Introduce gdb.Instruction class sergiodj+buildbot
2017-05-04 18:50 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-05-04 11:08 [binutils-gdb/gdb-8.0-branch] Python: Move and rename gdb.BtraceFunction sergiodj+buildbot
2017-05-04 17:49 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-05-04 10:21 [binutils-gdb/gdb-8.0-branch] Python: Move and rename gdb.BtraceInstruction sergiodj+buildbot
2017-05-04 16:29 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-05-04  9:09 [binutils-gdb/gdb-8.0-branch] Python: Remove ptid from gdb.Record interface sergiodj+buildbot
2017-05-04 14:04 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-05-04  7:31 [binutils-gdb/gdb-8.0-branch] Python: Fix indentation in py-record-btrace.c sergiodj+buildbot
2017-05-04 11:27 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-05-03 19:59 [binutils-gdb/gdb-8.0-branch] Make sure malloc is linked into gdb.cp/oranking.cc sergiodj+buildbot
2017-05-03 20:50 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-04-28 10:12 [binutils-gdb/gdb-8.0-branch] Use ptid method lwp in mips_linux_new_thread sergiodj+buildbot
2017-04-28 16:43 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-04-28  9:32 [binutils-gdb/gdb-8.0-branch] [MIPS] Use lwpid from lwp_info instead of inferior_ptid sergiodj+buildbot
2017-04-28 13:27 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-04-28  0:50 [binutils-gdb/gdb-8.0-branch] Fix overload resolution involving rvalue references and cv qualifiers sergiodj+buildbot
2017-04-28  5:00 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-04-27 23:32 [binutils-gdb/gdb-8.0-branch] Add missing incref when creating Inferior Python object sergiodj+buildbot
2017-04-28  1:56 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-04-25 14:57 [binutils-gdb/gdb-8.0-branch] Change gdbarch_wchar_bit for AArch64 and ARM sergiodj+buildbot
2017-04-25 22:10 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-04-21 18:09 [binutils-gdb/gdb-8.0-branch] release branch: Fix: --enable-werror sergiodj+buildbot
2017-04-21 18:07 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-04-18 17:29 [binutils-gdb/gdb-8.0-branch] PR threads/20743: Don't attempt to suspend or resume exited threads sergiodj+buildbot
2017-04-18 19:15 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot
2017-04-17 15:22 [binutils-gdb/gdb-8.0-branch] Set development mode to "off" by default sergiodj+buildbot
2017-04-17 19:32 ` Failures on Fedora-i686, branch gdb-8.0-branch sergiodj+buildbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).