public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Fix decoding of ARM VFP instructions
@ 2018-05-07 15:27 sergiodj+buildbot
  2018-05-07 15:32 ` Failures on Fedora-s390x-m64, branch master sergiodj+buildbot
                   ` (12 more replies)
  0 siblings, 13 replies; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-07 15:27 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ce887586b48acd02080c36d5495891116f886e8e ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: ce887586b48acd02080c36d5495891116f886e8e

Fix decoding of ARM VFP instructions

-Wduplicated-cond pointed out that arm_record_vfp_data_proc_insn
checks "opc1 == 0x0b" twice.  I filed this a while ago as
PR tdep/20362.

Based on the ARM instruction manual at
https://www.scss.tcd.ie/~waldroj/3d1/arm_arm.pdf, I think the
instruction decoding in this function has two bugs.

First, opc1 is computed as:

  opc1 = bits (arm_insn_r->arm_insn, 20, 23);
[...]
  opc1 = opc1 & 0x04;

This means that tests like:

  else if (opc1 == 0x01)

can never be true.

In the ARM manual, "opc1" corresponds to these bits:

    name   bit
    r      20
    q      21
    D      22
    p      23

... where the D bit is not used for VFP instruction decoding.

So, I believe this code should use ~0x04 instead.

Second, VDIV is recognized by the bits "pqrs" being equal to "1000".
This tranlates to opc1 == 0x08 -- not 0x0b.  Note that pqrs==1001 is
an undefined encoding, which is probably why opc2 is not checked here;
this code doesn't seem to really deal with undefined encodings in
general, so I've left that as is.

I don't have an ARM machine or any reasonable way to test this.

ChangeLog
2018-05-07  Tom Tromey  <tom@tromey.com>

	PR tdep/20362:
	* arm-tdep.c (arm_record_vfp_data_proc_insn): Properly mask off D
	bit.  Use correct value for VDIV.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove regcache_register_status
@ 2018-05-30 20:37 sergiodj+buildbot
  2018-09-23 15:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-30 20:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0ec9f11447514a797ae13760825fa45f9deedd8c ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 0ec9f11447514a797ae13760825fa45f9deedd8c

Remove regcache_register_status

Remove regcache_register_status, change callers to use
reg_buffer::get_register_status directly.

gdb/ChangeLog:

	* regcache.h (regcache_register_status): Remove, update callers
	to use reg_buffer::get_register_status directly instead.
	* regcache.c (regcache_register_status): Remove.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] 2018-05-30  Amaan Cheval <amaan.cheval@gmail.com>
@ 2018-05-30 16:17 sergiodj+buildbot
  2018-09-19 22:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-30 16:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 421acf18739edb54111b64d2b328ea2e7bf19889 ***

Author: Amaan Cheval <amaan.cheval@gmail.com>
Branch: master
Commit: 421acf18739edb54111b64d2b328ea2e7bf19889

2018-05-30  Amaan Cheval <amaan.cheval@gmail.com>

	* config.bfd (x86_64-*-*): Add pei-x86-64 target to x86_64-*-rtems*
	This is needed to generate UEFI application image files from ELFs.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add znver2 support.
@ 2018-05-30  8:52 sergiodj+buildbot
  2018-09-18 23:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-30  8:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a9660a6f4063c7e1fb892ec709c954c56896ab8d ***

Author: Amit Pawar <Amit.Pawar@amd.com>
Branch: master
Commit: a9660a6f4063c7e1fb892ec709c954c56896ab8d

Add znver2 support.

	gas/
	* config/tc-i386.c (cpu_flag_init): Add CPU_ZNVER2_FLAGS.
	* doc/c-i386.texi : Document znver2.
	* gas/testsuite/gas/i386/arch-13.s: Updated for znver2.
	* gas/testsuite/gas/i386/arch-13.d: Updated.
	* gas/testsuite/gas/i386/arch-13-znver1.d: Updated.
	* gas/testsuite/gas/i386/arch-13-znver2.d: New file.
	* gas/testsuite/gas/i386/x86-64-arch-3.s: Updated for znver2.
	* gas/testsuite/gas/i386/x86-64-arch-3.d: Updated.
	* gas/testsuite/gas/i386/x86-64-arch-3-znver1.d: Updated.
	* gas/testsuite/gas/i386/x86-64-arch-3-znver2.d: New file.
	* gas/testsuite/gas/i386/i386.exp: Updated for new test.

	opcode/
	* i386-gen.c (cpu_flag_init): Add CPU_ZNVER2_FLAGS.
	* i386-init.h : Regenerated.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove interp_ui_out
@ 2018-05-26 17:55 sergiodj+buildbot
  2018-09-13 12:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-26 17:55 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 29f943408122a7cffa25abb41def99833436f097 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 29f943408122a7cffa25abb41def99833436f097

Remove interp_ui_out

The function interp_ui_out simply calls the interp_ui_out method.
However, if it is passed a NULL interpreter, it first finds the
current interpreter.  I believe, though, that NULL is never passed
here, and I think it's simpler to just remove this function and
require callers to be more explicit.

ChangeLog
2018-05-25  Tom Tromey	<tom@tromey.com>

	* utils.c (fputs_maybe_filtered): Update.
	* linespec.c (decode_line_full): Update.
	* mi/mi-interp.c (mi_on_normal_stop_1, mi_tsv_modified)
	(mi_print_breakpoint_for_event, mi_solib_loaded)
	(mi_solib_unloaded, mi_command_param_changed, mi_memory_changed)
	(mi_user_selected_context_changed): Update.
	* mi/mi-main.c (mi_execute_command): Update.
	* cli/cli-script.c (execute_control_command): Update.
	* python/python.c (execute_gdb_command): Update.
	* solib.c (info_sharedlibrary_command): Update.
	* interps.c (interp_ui_out): Remove.
	* interps.h (interp_ui_out): Remove.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove cleanups from coff-pe-read.c
@ 2018-05-25 17:20 sergiodj+buildbot
  2018-09-10 23:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-25 17:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3173aa2fc212389268f76433e70b35116a936a8d ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 3173aa2fc212389268f76433e70b35116a936a8d

Remove cleanups from coff-pe-read.c

This removes cleanups from coff-pe-read.c, using std::string,
std::vector, and gdb::def_vector.

Tested by the buildbot, though I'm not sure these code paths are
exercised there.

ChangeLog
2018-05-25  Tom Tromey  <tom@tromey.com>

	* coff-pe-read.c (struct read_pe_section_data) <section_name>: Now
	a std::string.
	(get_pe_section_index, add_pe_exported_sym): Update.
	(read_pe_exported_syms): Use gdb::def_vector.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] MIPS/Linux: Correct o32 core file FGR interpretation
@ 2018-05-25 12:40 sergiodj+buildbot
  2018-09-09 21:57 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-25 12:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d8dab6c3bbe6432ff20237e621f2f3a3d30d4d4b ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: d8dab6c3bbe6432ff20237e621f2f3a3d30d4d4b

MIPS/Linux: Correct o32 core file FGR interpretation

Our interpretation of the layout of floating-point general registers
(FGRs) in o32 MIPS/Linux core files is different from how the kernel
makes them, affecting the CP0 Status.FR=0 aka FP32 mode (we don't
currently support the CP0 Status.FR=1 aka FP64 mode with the o32 ABI).

In the FP32 mode pairs of consecutive even/odd-numbered 32-bit registers
are placed together as 64-bit values in even-indexed 64-bit slots
corresponding to the even index, leaving the odd-indexed 64-bit slots
unused.  These 64-bit values are stored according to the endianness in
effect, which is how the MIPS II SDC1 instruction would store them.

It has always been like that with the Linux kernel for MIPS II and
higher ISA processors, which are the vast majority ever supported, as it
is indeed SDC1 that the kernel uses to store FGRs in a floating-point
context.

With MIPS I processors, which lack the SDC1 instruction, a layout that
we expect used to be used long ago, but it was corrected for consistency
with newer processors back in 2002, with `linux-mips.org' (LMO) commit
42533948caac ("Major pile of FP emulator changes."), the fix corrected
with LMO commit 849fa7a50dff ("R3k FPU ptrace() handling fixes."), and
then broken and fixed over and over again, until last time fixed with
commit 80cbfad79096 ("MIPS: Correct MIPS I FP context layout").

Consequently the values we see in FP32 core files or produce with the
`gcore' command are different from those obtained from the same FP
context of a live process, e.g. with a big-endian configuration these
live values:

(gdb) info registers float
f0:  0x4b5c6d7e flt: 14445950          dbl: 1.7446153562345001e-274
f1:  0x0718293a flt: 1.14473244e-34
f2:  0xc3d4e5f6 flt: -425.79657        dbl: -1.046160437414959e-233
f3:  0x8f90a1b2 flt: -1.42617791e-29
f4:  0x4c5d6e7f flt: 58046972          dbl: 1.1908587841220294e-269
f5:  0x08192a3b flt: 4.60914044e-34
f6:  0xc4d5e6f7 flt: -1711.21765       dbl: -6.2784661835068965e-306
f7:  0x8091a2b3 flt: -1.33745124e-38
f8:  0x45566778 flt: 3430.4668         dbl: 1.6530355595710607e-303
f9:  0x01122334 flt: 2.68412219e-38
f10: 0xcddeeff0 flt: -467533312        dbl: -2.1174864564135575e-262
f11: 0x899aabbc flt: -3.72356497e-33
f12: 0x46576879 flt: 13786.1182        dbl: 1.143296486773654e-298
f13: 0x02132435 flt: 1.08102453e-37
f14: 0xcedfe0f1 flt: -1.87803046e+09   dbl: -1.4399511533369862e-257
f15: 0x8a9bacbd flt: -1.4990934e-32
f16: 0x4758697a flt: 55401.4766        dbl: 7.8856820439568725e-294
f17: 0x03142536 flt: 4.3536007e-37
f18: 0xcfd0e1f2 flt: -7.00893696e+09   dbl: -9.7791926757340559e-253
f19: 0x8b9cadbe flt: -6.03504325e-32
f20: 0x48596a7b flt: 222633.922        dbl: 5.4255001483306113e-289
f21: 0x04152637 flt: 1.75324132e-36
f22: 0xc0d1e2f3 flt: -6.55895376       dbl: -6.6332401002310683e-248
f23: 0x8c9daebf flt: -2.42948516e-31
f24: 0x495a6b7c flt: 894647.75         dbl: 3.7244369058749787e-284
f25: 0x05162738 flt: 7.06016945e-36
f26: 0xc1d2e3f4 flt: -26.3613052       dbl: -4.4941535759306202e-243
f27: 0x8d9eafb0 flt: -9.77979703e-31
f28: 0x4a5b6c7d flt: 3595039.25        dbl: 2.5514593711161396e-279
f29: 0x06172839 flt: 2.84294945e-35
f30: 0xc2d3e4f5 flt: -105.947182       dbl: -3.035646690850097e-238
f31: 0x8e9fa0b1 flt: -3.93512664e-30
fcsr: 0x0
fir: 0xf30000
(gdb)

show up in a core file as these:

(gdb) info registers float
f0:  0x0718293a flt: 1.14473244e-34    dbl: nan
f1:  0x7ff80000 flt: nan
f2:  0x8f90a1b2 flt: -1.42617791e-29   dbl: nan
f3:  0x7ff80000 flt: nan
f4:  0x08192a3b flt: 4.60914044e-34    dbl: nan
f5:  0x7ff80000 flt: nan
f6:  0x8091a2b3 flt: -1.33745124e-38   dbl: nan
f7:  0x7ff80000 flt: nan
f8:  0x01122334 flt: 2.68412219e-38    dbl: nan
f9:  0x7ff80000 flt: nan
f10: 0x899aabbc flt: -3.72356497e-33   dbl: nan
f11: 0x7ff80000 flt: nan
f12: 0x02132435 flt: 1.08102453e-37    dbl: nan
f13: 0x7ff80000 flt: nan
f14: 0x8a9bacbd flt: -1.4990934e-32    dbl: nan
f15: 0x7ff80000 flt: nan
f16: 0x03142536 flt: 4.3536007e-37     dbl: nan
f17: 0x7ff80000 flt: nan
f18: 0x8b9cadbe flt: -6.03504325e-32   dbl: nan
f19: 0x7ff80000 flt: nan
f20: 0x04152637 flt: 1.75324132e-36    dbl: nan
f21: 0x7ff80000 flt: nan
f22: 0x8c9daebf flt: -2.42948516e-31   dbl: nan
f23: 0x7ff80000 flt: nan
f24: 0x05162738 flt: 7.06016945e-36    dbl: nan
f25: 0x7ff80000 flt: nan
f26: 0x8d9eafb0 flt: -9.77979703e-31   dbl: nan
f27: 0x7ff80000 flt: nan
f28: 0x06172839 flt: 2.84294945e-35    dbl: nan
f29: 0x7ff80000 flt: nan
f30: 0x8e9fa0b1 flt: -3.93512664e-30   dbl: nan
f31: 0x7ff80000 flt: nan
(gdb)

Notice how values from odd-numbered registers are shown in corresponding
even-numbered registers and how dummy 0x7ff80000 NaN values, which the
kernel places in unused slots, are reported in odd-numbered registers.

Correct our intepretation then, to match the kernel's.  As it happens
the o32 FGR core file representation matches that used by the `ptrace'
PTRACE_GETFPREGS request, which means our 64-bit handlers can be readily
used, as they already correctly handle the differences between o32 FP32
mode vs n32/n64 representations.

Adjust comments accordingly throughout, in particular remove a reference
to the r3000/tx39 MIPS I processor peculiarity, long irrelevant.

Add a test case to verify correctness.  Avoid GCC bugs and limitations
in the test case where possible; the test case still fails to build with
GCC 8 and the o32 FP64 mode (i.e. with `-mips32r2 -mfp64' options)
giving:

mips-fpregset-core.c: In function 'main':
mips-fpregset-core.c:66:3: error: inconsistent operand constraints in an 'asm'
   asm (
   ^~~

(GCC PR target/85909), but that is not a concern for us as yet, because
as noted above we do not currently support the o32 FP64 mode anyway.

	gdb/
	* mips-linux-tdep.h (mips_supply_fpregset, mips_fill_fpregset):
	Remove prototypes.
	* mips-linux-nat.c (supply_fpregset): Always call
	`mips64_supply_fpregset' rather than `mips_supply_fpregset'.
	(fill_fpregset): Always call `mips64_fill_fpregset' rather than
	`mips_fill_fpregset'.
	* mips-linux-tdep.c (mips_supply_fpregset)
	(mips_supply_fpregset_wrapper, mips_fill_fpregset)
	(mips_fill_fpregset_wrapper): Remove functions.
	(mips64_supply_fpregset, mips64_fill_fpregset): Update comments.
	(mips_linux_fpregset): Remove variable.
	(mips_linux_iterate_over_regset_sections): Use
	`mips64_linux_fpregset' in place of `mips_linux_fpregset'.
	(mips_linux_o32_sigframe_init): Remove comment.

	gdb/testsuite/
	* gdb.arch/mips-fpregset-core.exp: New test.
	* gdb.arch/mips-fpregset-core.c: New test source.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix help and documentation for inferior commands
@ 2018-05-25 12:19 sergiodj+buildbot
  2018-09-02 20:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-25 12:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a3c25011e4b0519dca984d23a8a2843b92b9ce2c ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: a3c25011e4b0519dca984d23a8a2843b92b9ce2c

Fix help and documentation for inferior commands

This changes inferior.c to add Usage lines for all commands, and to
change how "metasyntactic variables" are written to conform to GNU
style.

While doing this I noticed that the manual doesn't document the
argument to "info inferiors", so I've added that as well.

ChangeLog
2018-04-27  Tom Tromey  <tom@tromey.com>

	* inferior.c (initialize_inferiors): Update help strings.

doc/ChangeLog
2018-04-27  Tom Tromey  <tom@tromey.com>

	* gdb.texinfo (Inferiors and Programs): Document argument to "info
	inferiors".


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Update help text in record.c
@ 2018-05-25  0:21 sergiodj+buildbot
  2018-09-08  0:38 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-25  0:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a974b5ec9a253d330290d132098065b77f29bd36 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: a974b5ec9a253d330290d132098065b77f29bd36

Update help text in record.c

This updates some help text in record.c to conform to GNU standards.
I also added a "Usage" line to "record save".

2018-04-29  Tom Tromey  <tom@tromey.com>

	* record.c (_initialize_record): Update help text.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Update help strings in TUI
@ 2018-05-24 21:10 sergiodj+buildbot
  2018-09-04 17:20 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-24 21:10 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bf212be198a7dd7700e08862f241ed85f88408e3 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: bf212be198a7dd7700e08862f241ed85f88408e3

Update help strings in TUI

This updates some help strings in the TUI to more closely follow GNU
standards.  In this case I chose to reuse some existing "usage" macros
in the help text.  Also, I found that XDBWIN_HEIGHT_USAGE is unused,
so I removed it.

ChangeLog
2018-04-29  Tom Tromey  <tom@tromey.com>

	* tui/tui-layout.c (_initialize_tui_layout): Update help text.
	* tui/tui-win.c (WIN_HEIGHT_USAGE, FOCUS_USAGE): Update
	(XDBWIN_HEIGHT_USAGE): Remove.
	(_initialize_tui_win): Use macros.  Update help text.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Update core-related help strings
@ 2018-05-24 20:12 sergiodj+buildbot
  2018-09-04 11:08 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-24 20:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0cab2f1e91f92130c5e0d89a99ce639ebd8ec1b0 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 0cab2f1e91f92130c5e0d89a99ce639ebd8ec1b0

Update core-related help strings

This updates some help strings in corefile.c and gcore.c.

2018-04-27  Tom Tromey  <tom@tromey.com>

	* corefile.c (_initialize_core): Update help string.
	* gcore.c (_initialize_gcore): Update help string.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove file and line from struct complain
@ 2018-05-23 19:22 sergiodj+buildbot
  2018-08-24  3:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-23 19:22 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7ff8817441fcebe3d32343dbd9d514366bfe8e23 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 7ff8817441fcebe3d32343dbd9d514366bfe8e23

Remove file and line from struct complain

The file and line handling in complaints.c wasn't used once
internal_complaint was removed.  This patch removes all the related
code.

gdb/ChangeLog
2018-05-23  Tom Tromey  <tom@tromey.com>

	* complaints.c (struct complain) <file, line>: Remove.
	(find_complaint): Remove file, line parameters.
	(complaint_internal): Update.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix gdb.base/remote.exp with native-extended-gdbserver board
@ 2018-05-23  3:06 sergiodj+buildbot
  2018-08-18  2:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-23  3:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 035522c0228be33b2124ada2f178187e7e53aa6c ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 035522c0228be33b2124ada2f178187e7e53aa6c

Fix gdb.base/remote.exp with native-extended-gdbserver board

This fixes gdb.base/remote.exp regressions caused by the previous
commit to the testcase, when tested with
--target_board=native-extended-gdbserver.  For example:

  ...
  show remote memory-write-packet-size
  The memory-write-packet-size is 0 (default). Packets are limited to 16383 bytes.
  (gdb) FAIL: gdb.base/remote.exp: write-packet default
  ...

With that board, GDB connects to GDBserver at gdb_start time, so GDB
is showing the actual remote/gdbserver packet size limits.

Fix it using the usual "disconnect" pattern.  While at it, there's no
need to start GDB before compiling the testcase.

gdb/testsuite/ChangeLog:
2018-05-22  Pedro Alves  <palves@redhat.com>

	* gdb.base/remote.exp: Only gdb_start after compiling the
	testcase.  Issue "disconnect" before testing "set remote" command
	defaults.  Issue clean_restart before running to main.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] remote: Make vcont_builder a class
@ 2018-05-23  2:22 sergiodj+buildbot
  2018-08-16  8:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-23  2:22 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f5db4863f51b83bc6b54504d61e1731011cfdec2 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: f5db4863f51b83bc6b54504d61e1731011cfdec2

remote: Make vcont_builder a class

gdb/ChangeLog:
2018-05-22  Pedro Alves  <palves@redhat.com>

	* remote.c (vcont_builder): Now a class.  Make all data members
	private.
	(vcont_builder) <vcont_builder, restart, flush, push_action>:
	Declare methods.
	(vcont_builder_restart): Rename to ...
	(vcont_builder::restart): ... this.
	(vcont_builder_flush): Rename to ...
	(vcont_builder::flush): ... this.
	(vcont_builder_push_action): Rename to ...
	(vcont_builder::push_action): ... this.
	(remote_target::commit_resume): Adjust.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdb/x86: Fix `-Wstrict-overflow' build error in `i387_collect_xsave'
@ 2018-05-23  2:03 sergiodj+buildbot
  2018-08-17 15:45 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-23  2:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 35f1fea3fcd44546a6cf074029c284c64ad25b3c ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 35f1fea3fcd44546a6cf074029c284c64ad25b3c

gdb/x86: Fix `-Wstrict-overflow' build error in `i387_collect_xsave'

Make `i' defined within `i387_collect_xsave' unsigned, removing a
`-Werror=strict-overflow' compilation error:

.../gdb/i387-tdep.c: In function 'void i387_collect_xsave(const regcache*, int, void*, int)':
.../gdb/i387-tdep.c:1348:1: error: assuming signed overflow does not occur when assuming that (X + c) < X is always false [-Werror=strict-overflow]
 i387_collect_xsave (const struct regcache *regcache, int regnum,
 ^
cc1plus: all warnings being treated as errors
Makefile:1610: recipe for target 'i387-tdep.o' failed
make: *** [i387-tdep.o] Error 1

seen with GCC 5.4.0, a commit 8ee22052f690 ("gdb/x86: Handle kernels
using compact xsave format") regression.  While `regnum' can be -1 on
entry to the function, to mean all registers, `i' is only used with
non-negative register numbers.

	gdb/
	* i387-tdep.c (i387_collect_xsave): Make `i' unsigned.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [PowerPC] Fix access to VSCR in linux targets
@ 2018-05-22 17:34 sergiodj+buildbot
  2018-08-08  8:54 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-22 17:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1d75a65809b49d41e97518b99c551a4bb2517500 ***

Author: Pedro Franco de Carvalho <pedromfc@linux.vnet.ibm.com>
Branch: master
Commit: 1d75a65809b49d41e97518b99c551a4bb2517500

[PowerPC] Fix access to VSCR in linux targets

The 4-byte VSCR register is found inside a 16-byte field in the regset
returned by ptrace and in core files. The position of VSCR depends on
the endianess of the target, which was previously assumed to be
big-endian for the purpose of getting VSCR. This patch removes this
assumption to fix access to VSCR in little-endian mode.

gdb/ChangeLog:
2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>

	* ppc-tdep.h (struct ppc_reg_offsets): Remove vector register
	offset fields.
	* ppc-fbsd-tdep.c (ppc32_fbsd_reg_offsets): Remove initializers
	for vector register offset fields.
	(ppc64_fbsd_reg_offsets): Likewise.
	* ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
	to vector register offset fields.
	* ppc-obsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
	to vector register offset fields.
	* ppc-obsd-nat.c (_initialize_ppcobsd_nat): Remove assignment to
	vector register offset fields.
	* rs6000-aix-tdep.c (rs6000_aix32_reg_offsets): Remove
	initializers for vector register offset fields.
	(rs6000_aix64_reg_offsets): Likewise.
	* rs6000-tdep.c (ppc_vrreg_offset): Remove.
	(ppc_supply_vrregset): Remove.
	(ppc_collect_vrregset): Remove.
	* ppc-linux-tdep.c (ppc_linux_collect_vrregset): New function.
	(ppc_linux_vrregset) : New function.
	(ppc32_le_linux_vrregmap, ppc32_be_linux_vrregmap)
	(ppc32_le_linux_vrregset, ppc32_be_linux_vrregset): New globals.
	(ppc32_linux_vrregset): Remove.
	(ppc_linux_iterate_over_regset_sections): Call ppc_linux_vrregset
	and use result instead of ppc32_linux_vrregset.
	(ppc32_linux_reg_offsets): Remove initializers for vector register
	offset fields.
	(ppc64_linux_reg_offsets): Likewise.
	* ppc-linux-tdep.h (ppc_linux_vrregset): New declaration.
	* ppc-linux-nat.c: Include regset.h.
	(gdb_vrregset_t): Adjust comment to account for little-endian
	mode.
	(supply_vrregset, fill_vrregset): Remove.
	(fetch_altivec_register, store_altivec_register): Remove.
	(fetch_altivec_registers): Add regno parameter. Get regset using
	ppc_linux_vrregset. Use regset to supply registers.
	(store_altivec_registers): Add regno parameter. Get regset using
	ppc_linux_vrregset. Use regset to collect registers.
	(fetch_register): Call fetch_altivec_registers instead of
	fetch_altivec_register.
	(store_register): Call store_altivec_registers instead of
	store_altivec_register.
	(fetch_ppc_registers): Call fetch_altivec_registers with -1 for
	the new regno parameter.
	(store_ppc_registers): Call store_altivec_registers with -1 for
	the new regno parameter.

gdb/gdbserver/ChangeLog:
2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>

	* linux-ppc-low.c (ppc_fill_vrregset): Add vscr_offset variable.
	Set vscr_offset to 0 in little-endian mode and 12 in big-endian
	mode. Call collect_register_by_name with vscr using
	vscr_offset. Zero-pad vscr and vrsave fields in collector buffer.
	(ppc_store_vrregset): Add and set vscr_offset variable as in
	ppc_fill_vrregset. Call supply_register_by_name with vscr using
	vscr_offset.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [PowerPC] Consolidate linux target description selection
@ 2018-05-22 15:57 sergiodj+buildbot
  2018-08-06  5:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-22 15:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bd64614eb737096f40b976fb505ddd42e7f1614c ***

Author: Pedro Franco de Carvalho <pedromfc@linux.vnet.ibm.com>
Branch: master
Commit: bd64614eb737096f40b976fb505ddd42e7f1614c

[PowerPC] Consolidate linux target description selection

Share target description declarations and selection among ppc linux
native targets, core files, gdbserver and IPA.

To avoid complicated define guards, gdbserver and IPA now have
declarations for all descriptions, including 64-bit generated
descriptions when compiled in 32-bit mode. These have always been
linked into the gdbserver and IPA binaries. Because they might be
uninitialized, the selection function checks that the selected
description is initialized.

gdb/ChangeLog:
2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>

	* arch/ppc-linux-common.c: New file.
	* arch/ppc-linux-common.h: New file.
	* arch/ppc-linux-tdesc.h: New file.
	* configure.tgt (powerpc*-*-linux*): Add arch/ppc-linux-common.o.
	* Makefile.in (ALL_TARGET_OBS): Add arch/ppc-linux-common.o.
	(HFILES_NO_SRCDIR): Add arch/ppc-linux-common.h and
	arch/ppc-linux-tdesc.h.
	* ppc-linux-nat.c: Include arch/ppc-linux-common.h and
	arch/ppc-linux-tdesc.h.
	(ppc_linux_nat_target::read_description): Remove target
	description matching code. Fill a ppc_linux_features struct and
	call ppc_linux_match_description with it. Move comment about ISA
	2.05 to ppc-linux-common.c.
	* ppc-linux-tdep.c: Include arch/ppc-linux-common.h and
	arch/ppc-linux-tdesc.h.
	(ppc_linux_core_read_description): Remove target description
	matching code. Fill a ppc_linux_features struct and call
	ppc_linux_match_description with it.
	* ppc-linux-tdep.h (tdesc_powerpc_32l, tdesc_powerpc_64l)
	(tdesc_powerpc_altivec32l, tdesc_powerpc_altivec64l)
	(tdesc_powerpc_cell32l, tdesc_powerpc_cell64l)
	(tdesc_powerpc_vsx32l, tdesc_powerpc_vsx64l)
	(tdesc_powerpc_isa205_32l, tdesc_powerpc_isa205_64l)
	(tdesc_powerpc_isa205_altivec32l, tdesc_powerpc_isa205_altivec64l)
	(tdesc_powerpc_isa205_vsx32l, tdesc_powerpc_isa205_vsx64l)
	(tdesc_powerpc_e500l): Remove.

gdb/gdbserver/ChangeLog:
2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>

	* configure.srv (srv_tgtobj): Add arch/ppc-linux-common.o.
	* Makefile.in (SFILES): Add arch/ppc-linux-common.c.
	* linux-ppc-tdesc.h: Rename to linux-ppc-tdesc-init.h.
	* linux-ppc-tdesc-init.h (tdesc_powerpc_32l, tdesc_powerpc_64l)
	(tdesc_powerpc_altivec32l, tdesc_powerpc_altivec64l)
	(tdesc_powerpc_cell32l, tdesc_powerpc_cell64l)
	(tdesc_powerpc_vsx32l, tdesc_powerpc_vsx64l)
	(tdesc_powerpc_isa205_32l, tdesc_powerpc_isa205_64l)
	(tdesc_powerpc_isa205_altivec32l, tdesc_powerpc_isa205_altivec64l)
	(tdesc_powerpc_isa205_vsx32l, tdesc_powerpc_isa205_vsx64l)
	(tdesc_powerpc_e500l): Remove.
	* linux-ppc-ipa.c: Include arch/ppc-linux-tdesc.h and
	linux-ppc-tdesc-init.h. Don't include linux-ppc-tdesc.h.
	* linux-ppc-low.c: Include arch/ppc-linux-common.h,
	arch/ppc-linux-tdesc.h, and linux-ppc-tdesc-init.h. Don't include
	linux-ppc-tdesc.h.
	(ppc_arch_setup): Remove target description matching code. Fill a
	ppc_linux_features struct and call ppc_linux_match_description
	with it.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR23207, hppa ld SIGSEGVs on invalid object files
@ 2018-05-22  6:36 sergiodj+buildbot
  2018-08-04 13:15 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-22  6:36 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7455c018e45766ab7193cbd45f98f781e0dc7d84 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 7455c018e45766ab7193cbd45f98f781e0dc7d84

PR23207, hppa ld SIGSEGVs on invalid object files

We don't create PLT call stubs for anything in non-alloc sections,
so it doesn't pay to go looking for them.  The problem is that
non-alloc sections aren't processed by group_sections and thus don't
get a link_sec set up for them.

	PR 23207
	* elf32-hppa.c (final_link_relocate): Don't look for plt call
	stubs in non-alloc sections.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Change ada_catchpoint::excep_string to be a std::string
@ 2018-05-21 20:19 sergiodj+buildbot
  2018-07-30 13:22 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-21 20:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bc18fbb575437dd10089ef4619e46c0b9a93097d ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: bc18fbb575437dd10089ef4619e46c0b9a93097d

Change ada_catchpoint::excep_string to be a std::string

This changes ada_catchpoint::excep_string to be a std::string and then
fixes up all t he users.

This found a memory leak in catch_ada_exception_command_split, where
"cond" was copied but never freed.

I changed the type of the "cond_string" argument to
catch_ada_exception_command_split to follow the rule that out
parameters should be pointers and not references.

This patch enables the removal of some cleanups and also the function
ada_get_next_arg.

ChangeLog
2018-05-21  Tom Tromey  <tom@tromey.com>

	* mi/mi-cmd-catch.c (mi_cmd_catch_assert)
	(mi_cmd_catch_exception, mi_cmd_catch_handlers): Update.
	* ada-lang.h (create_ada_exception_catchpoint): Update.
	* ada-lang.c (struct ada_catchpoint) <excep_string>: Now a
	std::string.
	(create_excep_cond_exprs, ~ada_catchpoint)
	(should_stop_exception, print_one_exception)
	(print_mention_exception, print_recreate_exception): Update.
	(ada_get_next_arg): Remove.
	(catch_ada_exception_command_split): Use std::string.  Change type
	of "excep_string", "cond_string".
	(catch_ada_exception_command): Update.
	(create_ada_exception_catchpoint): Change type of excep_string.
	(ada_exception_sal): Remove excep_string parameter.
	(~ada_catchpoint): Remove.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Use std::string in reread_symbols
@ 2018-05-21 17:46 sergiodj+buildbot
  2018-07-28 20:00 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-21 17:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c0c9f665d9d4cdcef59cc7951396d843a7ea6a48 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: c0c9f665d9d4cdcef59cc7951396d843a7ea6a48

Use std::string in reread_symbols

This removes a cleanup from reread_symbols by using std::string.  This
fixes a memory leak, because this cleanup is ordinarily discarded, not
run.

Tested by the buildbot.

ChangeLog
2018-05-21  Tom Tromey  <tom@tromey.com>

	* symfile.c (reread_symbols): Use std::string for original_name.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix copy-pasto, allocate objfile_per_bfd_storage with obstack_new
@ 2018-05-21  3:57 sergiodj+buildbot
  2018-07-27 22:14 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-21  3:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 184cde7552b5434196b8380be23b39ff4a5a17e6 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 184cde7552b5434196b8380be23b39ff4a5a17e6

Fix copy-pasto, allocate objfile_per_bfd_storage with obstack_new

I realized after pushing that I made a copy-pasto, I had:

  # define HAVE_IS_TRIVIALLY_COPYABLE 1

instead of

  # define HAVE_IS_TRIVIALLY_CONSTRUCTIBLE 1

with the consequence that IsMallocable was always std::true_type (and
was therefore not enforcing anything).  Fixing that mistake triggered a
build failure:

/home/simark/src/binutils-gdb/gdb/objfiles.c:150:12:   required from here
/home/simark/src/binutils-gdb/gdb/common/poison.h:228:3: error: static assertion failed: Trying to use XOBNEW with a non-POD data type.

I am not sure why I did not see this when I originally wrote the patch
(but I saw and fixed other failures).  In any case, I swapped XOBNEW
with obstack_new to get rid of it.

Regtested on the buildbot.

gdb/ChangeLog:

	* common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Rename the wrong
	instance to...
	(HAVE_IS_TRIVIALLY_CONSTRUCTIBLE): ... this.
	* objfiles.c (get_objfile_bfd_data): Allocate
	objfile_per_bfd_storage with obstack_new when allocating on
	obstack.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Introduce obstack_new, poison other "typed" obstack functions
@ 2018-05-21  1:51 sergiodj+buildbot
  2018-07-27  1:33 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-21  1:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 284a0e3cbffa92ee5c94065fcdd5a528482344fc ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 284a0e3cbffa92ee5c94065fcdd5a528482344fc

Introduce obstack_new, poison other "typed" obstack functions

Since we use obstacks with objects that are not default constructible,
we sometimes need to manually call the constructor by hand using
placement new:

  foo *f = obstack_alloc (obstack, sizeof (foo));
  f = new (f) foo;

It's possible to use allocate_on_obstack instead, but there are types
that we sometimes want to allocate on an obstack, and sometimes on the
regular heap.  This patch introduces a utility to make this pattern
simpler if allocate_on_obstack is not an option:

  foo *f = obstack_new<foo> (obstack);

Right now there's only one usage (in tdesc_data_init).

To help catch places where we would forget to call new when allocating
such an object on an obstack, this patch also poisons some other methods
of allocating an instance of a type on an obstack:

  - OBSTACK_ZALLOC/OBSTACK_CALLOC
  - XOBNEW/XOBNEW
  - GDBARCH_OBSTACK_ZALLOC/GDBARCH_OBSTACK_CALLOC

Unfortunately, there's no way to catch wrong usages of obstack_alloc.

By pulling on that string though, it tripped on allocating struct
template_symbol using OBSTACK_ZALLOC.  The criterion currently used to
know whether it's safe to "malloc" an instance of a struct is whether it
is a POD.  Because it inherits from struct symbol, template_symbol is
not a POD.  This criterion is a bit too strict however, it should still
safe to allocate memory for a template_symbol and memset it to 0.  We
didn't use is_trivially_constructible as the criterion in the first
place only because it is not available in gcc < 5.  So here I considered
two alternatives:

1. Relax that criterion to use std::is_trivially_constructible and add a
   bit more glue code to make it work with gcc < 5
2. Continue pulling on the string and change how the symbol structures
   are allocated and initialized

I managed to do both, but I decided to go with #1 to keep this patch
simpler and more focused.  When building with a compiler that does not
have is_trivially_constructible, the check will just not be enforced.

gdb/ChangeLog:

	* common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Define if
	compiler supports std::is_trivially_constructible.
	* common/poison.h: Include obstack.h.
	(IsMallocable): Define to is_trivially_constructible if the
	compiler supports it, define to true_type otherwise.
	(xobnew): New.
	(XOBNEW): Redefine.
	(xobnewvec): New.
	(XOBNEWVEC): Redefine.
	* gdb_obstack.h (obstack_zalloc): New.
	(OBSTACK_ZALLOC): Redefine.
	(obstack_calloc): New.
	(OBSTACK_CALLOC): Redefine.
	(obstack_new): New.
	* gdbarch.sh: Include gdb_obstack in gdbarch.h.
	(gdbarch_obstack): New declaration in gdbarch.h, definition in
	gdbarch.c.
	(GDBARCH_OBSTACK_CALLOC, GDBARCH_OBSTACK_ZALLOC): Use
	obstack_calloc/obstack_zalloc.
	(gdbarch_obstack_zalloc): Remove.
	* target-descriptions.c (tdesc_data_init): Use obstack_new.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix reference in comment: SRC_AND_LOC instead of LOC_AND_SRC
@ 2018-05-19  7:33 sergiodj+buildbot
  2018-07-26  4:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-19  7:33 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 50c65c2d60b371b8b85a804a5a71bf967ba9b355 ***

Author: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Branch: master
Commit: 50c65c2d60b371b8b85a804a5a71bf967ba9b355

Fix reference in comment: SRC_AND_LOC instead of LOC_AND_SRC

Pushed as obvious


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Show padding in ptype/o output
@ 2018-05-18 20:15 sergiodj+buildbot
  2018-07-15  6:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-18 20:15 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ce1e8424c69793139ec8d2a60c4a21ab136ae9e0 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: ce1e8424c69793139ec8d2a60c4a21ab136ae9e0

Show padding in ptype/o output

I was recently using ptype/o to look at the layout of some objects in
gdb.  I noticed that trailing padding was not shown -- but I wanted to
be able to look at that, too.

This patch changes ptype/o to also print trailing holes.

Tested on x86-64 Fedora 26.

gdb/ChangeLog
2018-05-18  Tom Tromey  <tom@tromey.com>

	* c-typeprint.c (maybe_print_hole): New function.
	(c_print_type_struct_field_offset): Update.
	(c_type_print_base_struct_union): Call maybe_print_hole.

gdb/testsuite/ChangeLog
2018-05-18  Tom Tromey  <tom@tromey.com>

	* gdb.base/ptype-offsets.exp: Update.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add support for the Freescale s12z processor.
@ 2018-05-18 15:27 sergiodj+buildbot
  2018-07-14 19:58 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-18 15:27 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7b4ae824289504c173a597e86a00ceab452095b7 ***

Author: John Darrington <john@darrington.wattle.id.au>
Branch: master
Commit: 7b4ae824289504c173a597e86a00ceab452095b7

Add support for the Freescale s12z processor.

bfd	* Makefile.am: Add s12z files.
	* Makefile.in: Regenerate.
	* archures.c: Add bfd_s12z_arch.
	* bfd-in.h: Add exports of bfd_putb24 and bfd_putl24.
	* bfd-in2.h: Regenerate.
	* config.bfd: Add s12z target.
	* configure.ac: Add s12z target.
	* configure: Regenerate.
	* cpu-s12z.c: New file.
	* elf32-s12z.c: New file.
	* libbfd.c (bfd_putb24): New function.
	(bfd_putl24): New function.
	* libbfd.h: Regenerate.
	* reloc.c: Add s12z relocations.
	(bfd_get_reloc_size): Handle size 5 relocs.
	* targets.c: Add s12z_elf32_vec.

opcodes	* Makefile.am: Add support for s12z architecture.
	* configure.ac: Likewise.
	* disassemble.c: Likewise.
	* disassemble.h: Likewise.
	* Makefile.in: Regenerate.
	* configure: Regenerate.
	* s12z-dis.c: New file.
	* s12z.h: New file.

include	* elf/s12z.h: New header.

ld	* Makefile.am: Add support for s12z architecture.
	* configure.tgt: Likewise.
	* Makefile.in: Regenerate.
	* emulparams/m9s12zelf.sh: New file.
	* scripttempl/elfm9s12z.sc: New file.
	* testsuite/ld-discard/static.d: Expect to fail for the s12z
	target.
	* testsuite/ld-elf/endsym.d: Likewise.
	* testsuite/ld-elf/merge.d: Likewise.
	* testsuite/ld-elf/pr14926.d: Skip for the s12z target.
	* testsuite/ld-elf/sec64k.exp: Likewise.
	* testsuite/ld-s12z: New directory.
	* testsuite/ld-s12z/opr-linking.d: New file.
	* testsuite/ld-s12z/opr-linking.s: New file.
	* testsuite/ld-s12z/relative-linking.d: New file.
	* testsuite/ld-s12z/relative-linking.s: New file.
	* testsuite/ld-s12z/z12s.exp: New file.

gas	* Makefile.am: Add support for s12z target.
	* Makefile.in: Regenerate.
	* NEWS: Mention the new support.
	* config/tc-s12z.c: New file.
	* config/tc-s12z.h: New file.
	* configure.tgt: Add  s12z support.
	* doc/Makefile.am: Likewise.
	* doc/Makefile.in: Regenerate.
	* doc/all.texi: Add s12z documentation.
	* doc/as.textinfo: Likewise.
	* doc/c-s12z.texi: New file.
	* testsuite/gas/s12z: New directory.
	* testsuite/gas/s12z/abs.d: New file.
	* testsuite/gas/s12z/abs.s: New file.
	* testsuite/gas/s12z/adc-imm.d: New file.
	* testsuite/gas/s12z/adc-imm.s: New file.
	* testsuite/gas/s12z/adc-opr.d: New file.
	* testsuite/gas/s12z/adc-opr.s: New file.
	* testsuite/gas/s12z/add-imm.d: New file.
	* testsuite/gas/s12z/add-imm.s: New file.
	* testsuite/gas/s12z/add-opr.d: New file.
	* testsuite/gas/s12z/add-opr.s: New file.
	* testsuite/gas/s12z/and-imm.d: New file.
	* testsuite/gas/s12z/and-imm.s: New file.
	* testsuite/gas/s12z/and-opr.d: New file.
	* testsuite/gas/s12z/and-opr.s: New file.
	* testsuite/gas/s12z/and-or-cc.d: New file.
	* testsuite/gas/s12z/and-or-cc.s: New file.
	* testsuite/gas/s12z/bfext-special.d: New file.
	* testsuite/gas/s12z/bfext-special.s: New file.
	* testsuite/gas/s12z/bfext.d: New file.
	* testsuite/gas/s12z/bfext.s: New file.
	* testsuite/gas/s12z/bit-manip.d: New file.
	* testsuite/gas/s12z/bit-manip.s: New file.
	* testsuite/gas/s12z/bit.d: New file.
	* testsuite/gas/s12z/bit.s: New file.
	* testsuite/gas/s12z/bra-expression-defined.d: New file.
	* testsuite/gas/s12z/bra-expression-defined.s: New file.
	* testsuite/gas/s12z/bra-expression-undef.d: New file.
	* testsuite/gas/s12z/bra-expression-undef.s: New file.
	* testsuite/gas/s12z/bra.d: New file.
	* testsuite/gas/s12z/bra.s: New file.
	* testsuite/gas/s12z/brclr-symbols.d: New file.
	* testsuite/gas/s12z/brclr-symbols.s: New file.
	* testsuite/gas/s12z/brset-clr-opr-imm-rel.d: New file.
	* testsuite/gas/s12z/brset-clr-opr-imm-rel.s: New file.
	* testsuite/gas/s12z/brset-clr-opr-reg-rel.d: New file.
	* testsuite/gas/s12z/brset-clr-opr-reg-rel.s: New file.
	* testsuite/gas/s12z/brset-clr-reg-imm-rel.d: New file.
	* testsuite/gas/s12z/brset-clr-reg-imm-rel.s: New file.
	* testsuite/gas/s12z/brset-clr-reg-reg-rel.d: New file.
	* testsuite/gas/s12z/brset-clr-reg-reg-rel.s: New file.
	* testsuite/gas/s12z/clb.d: New file.
	* testsuite/gas/s12z/clb.s: New file.
	* testsuite/gas/s12z/clr-opr.d: New file.
	* testsuite/gas/s12z/clr-opr.s: New file.
	* testsuite/gas/s12z/clr.d: New file.
	* testsuite/gas/s12z/clr.s: New file.
	* testsuite/gas/s12z/cmp-imm.d: New file.
	* testsuite/gas/s12z/cmp-imm.s: New file.
	* testsuite/gas/s12z/cmp-opr-inc.d: New file.
	* testsuite/gas/s12z/cmp-opr-inc.s: New file.
	* testsuite/gas/s12z/cmp-opr-rdirect.d: New file.
	* testsuite/gas/s12z/cmp-opr-rdirect.s: New file.
	* testsuite/gas/s12z/cmp-opr-reg.d: New file.
	* testsuite/gas/s12z/cmp-opr-reg.s: New file.
	* testsuite/gas/s12z/cmp-opr-rindirect.d: New file.
	* testsuite/gas/s12z/cmp-opr-rindirect.s: New file.
	* testsuite/gas/s12z/cmp-opr-sxe4.d: New file.
	* testsuite/gas/s12z/cmp-opr-sxe4.s: New file.
	* testsuite/gas/s12z/cmp-opr-xys.d: New file.
	* testsuite/gas/s12z/cmp-opr-xys.s: New file.
	* testsuite/gas/s12z/cmp-s-imm.d: New file.
	* testsuite/gas/s12z/cmp-s-imm.s: New file.
	* testsuite/gas/s12z/cmp-s-opr.d: New file.
	* testsuite/gas/s12z/cmp-s-opr.s: New file.
	* testsuite/gas/s12z/cmp-xy.d: New file.
	* testsuite/gas/s12z/cmp-xy.s: New file.
	* testsuite/gas/s12z/com-opr.d: New file.
	* testsuite/gas/s12z/com-opr.s: New file.
	* testsuite/gas/s12z/complex-shifts.d: New file.
	* testsuite/gas/s12z/complex-shifts.s: New file.
	* testsuite/gas/s12z/db-tb-cc-opr.d: New file.
	* testsuite/gas/s12z/db-tb-cc-opr.s: New file.
	* testsuite/gas/s12z/db-tb-cc-reg.d: New file.
	* testsuite/gas/s12z/db-tb-cc-reg.s: New file.
	* testsuite/gas/s12z/dbCC.d: New file.
	* testsuite/gas/s12z/dbCC.s: New file.
	* testsuite/gas/s12z/dec-opr.d: New file.
	* testsuite/gas/s12z/dec-opr.s: New file.
	* testsuite/gas/s12z/dec.d: New file.
	* testsuite/gas/s12z/dec.s: New file.
	* testsuite/gas/s12z/div.d: New file.
	* testsuite/gas/s12z/div.s: New file.
	* testsuite/gas/s12z/eor.d: New file.
	* testsuite/gas/s12z/eor.s: New file.
	* testsuite/gas/s12z/exg.d: New file.
	* testsuite/gas/s12z/exg.s: New file.
	* testsuite/gas/s12z/ext24-ld-xy.d: New file.
	* testsuite/gas/s12z/ext24-ld-xy.s: New file.
	* testsuite/gas/s12z/inc-opr.d: New file.
	* testsuite/gas/s12z/inc-opr.s: New file.
	* testsuite/gas/s12z/inc.d: New file.
	* testsuite/gas/s12z/inc.s: New file.
	* testsuite/gas/s12z/inh.d: New file.
	* testsuite/gas/s12z/inh.s: New file.
	* testsuite/gas/s12z/jmp.d: New file.
	* testsuite/gas/s12z/jmp.s: New file.
	* testsuite/gas/s12z/jsr.d: New file.
	* testsuite/gas/s12z/jsr.s: New file.
	* testsuite/gas/s12z/ld-imm-page2.d: New file.
	* testsuite/gas/s12z/ld-imm-page2.s: New file.
	* testsuite/gas/s12z/ld-imm.d: New file.
	* testsuite/gas/s12z/ld-imm.s: New file.
	* testsuite/gas/s12z/ld-immu18.d: New file.
	* testsuite/gas/s12z/ld-immu18.s: New file.
	* testsuite/gas/s12z/ld-large-direct.d: New file.
	* testsuite/gas/s12z/ld-large-direct.s: New file.
	* testsuite/gas/s12z/ld-opr.d: New file.
	* testsuite/gas/s12z/ld-opr.s: New file.
	* testsuite/gas/s12z/ld-s-opr.d: New file.
	* testsuite/gas/s12z/ld-s-opr.s: New file.
	* testsuite/gas/s12z/ld-small-direct.d: New file.
	* testsuite/gas/s12z/ld-small-direct.s: New file.
	* testsuite/gas/s12z/lea-immu18.d: New file.
	* testsuite/gas/s12z/lea-immu18.s: New file.
	* testsuite/gas/s12z/lea.d: New file.
	* testsuite/gas/s12z/lea.s: New file.
	* testsuite/gas/s12z/mac.d: New file.
	* testsuite/gas/s12z/mac.s: New file.
	* testsuite/gas/s12z/min-max.d: New file.
	* testsuite/gas/s12z/min-max.s: New file.
	* testsuite/gas/s12z/mod.d: New file.
	* testsuite/gas/s12z/mod.s: New file.
	* testsuite/gas/s12z/mov.d: New file.
	* testsuite/gas/s12z/mov.s: New file.
	* testsuite/gas/s12z/mul-imm.d: New file.
	* testsuite/gas/s12z/mul-imm.s: New file.
	* testsuite/gas/s12z/mul-opr-opr.d: New file.
	* testsuite/gas/s12z/mul-opr-opr.s: New file.
	* testsuite/gas/s12z/mul-opr.d: New file.
	* testsuite/gas/s12z/mul-opr.s: New file.
	* testsuite/gas/s12z/mul-reg.d: New file.
	* testsuite/gas/s12z/mul-reg.s: New file.
	* testsuite/gas/s12z/mul.d: New file.
	* testsuite/gas/s12z/mul.s: New file.
	* testsuite/gas/s12z/neg-opr.d: New file.
	* testsuite/gas/s12z/neg-opr.s: New file.
	* testsuite/gas/s12z/not-so-simple-shifts.d: New file.
	* testsuite/gas/s12z/not-so-simple-shifts.s: New file.
	* testsuite/gas/s12z/opr-18u.d: New file.
	* testsuite/gas/s12z/opr-18u.s: New file.
	* testsuite/gas/s12z/opr-expr.d: New file.
	* testsuite/gas/s12z/opr-expr.s: New file.
	* testsuite/gas/s12z/opr-ext-18.d: New file.
	* testsuite/gas/s12z/opr-ext-18.s: New file.
	* testsuite/gas/s12z/opr-idx-24-reg.d: New file.
	* testsuite/gas/s12z/opr-idx-24-reg.s: New file.
	* testsuite/gas/s12z/opr-idx3-reg.d: New file.
	* testsuite/gas/s12z/opr-idx3-reg.s: New file.
	* testsuite/gas/s12z/opr-idx3-xysp-24.d: New file.
	* testsuite/gas/s12z/opr-idx3-xysp-24.s: New file.
	* testsuite/gas/s12z/opr-indirect-expr.d: New file.
	* testsuite/gas/s12z/opr-indirect-expr.s: New file.
	* testsuite/gas/s12z/opr-symbol.d: New file.
	* testsuite/gas/s12z/opr-symbol.s: New file.
	* testsuite/gas/s12z/or-imm.d: New file.
	* testsuite/gas/s12z/or-imm.s: New file.
	* testsuite/gas/s12z/or-opr.d: New file.
	* testsuite/gas/s12z/or-opr.s: New file.
	* testsuite/gas/s12z/p2-mul.d: New file.
	* testsuite/gas/s12z/p2-mul.s: New file.
	* testsuite/gas/s12z/page2-inh.d: New file.
	* testsuite/gas/s12z/page2-inh.s: New file.
	* testsuite/gas/s12z/psh-pul.d: New file.
	* testsuite/gas/s12z/psh-pul.s: New file.
	* testsuite/gas/s12z/qmul.d: New file.
	* testsuite/gas/s12z/qmul.s: New file.
	* testsuite/gas/s12z/rotate.d: New file.
	* testsuite/gas/s12z/rotate.s: New file.
	* testsuite/gas/s12z/s12z.exp: New file.
	* testsuite/gas/s12z/sat.d: New file.
	* testsuite/gas/s12z/sat.s: New file.
	* testsuite/gas/s12z/sbc-imm.d: New file.
	* testsuite/gas/s12z/sbc-imm.s: New file.
	* testsuite/gas/s12z/sbc-opr.d: New file.
	* testsuite/gas/s12z/sbc-opr.s: New file.
	* testsuite/gas/s12z/shift.d: New file.
	* testsuite/gas/s12z/shift.s: New file.
	* testsuite/gas/s12z/simple-shift.d: New file.
	* testsuite/gas/s12z/simple-shift.s: New file.
	* testsuite/gas/s12z/single-ops.d: New file.
	* testsuite/gas/s12z/single-ops.s: New file.
	* testsuite/gas/s12z/specd6.d: New file.
	* testsuite/gas/s12z/specd6.s: New file.
	* testsuite/gas/s12z/st-large-direct.d: New file.
	* testsuite/gas/s12z/st-large-direct.s: New file.
	* testsuite/gas/s12z/st-opr.d: New file.
	* testsuite/gas/s12z/st-opr.s: New file.
	* testsuite/gas/s12z/st-s-opr.d: New file.
	* testsuite/gas/s12z/st-s-opr.s: New file.
	* testsuite/gas/s12z/st-small-direct.d: New file.
	* testsuite/gas/s12z/st-small-direct.s: New file.
	* testsuite/gas/s12z/st-xy.d: New file.
	* testsuite/gas/s12z/st-xy.s: New file.
	* testsuite/gas/s12z/sub-imm.d: New file.
	* testsuite/gas/s12z/sub-imm.s: New file.
	* testsuite/gas/s12z/sub-opr.d: New file.
	* testsuite/gas/s12z/sub-opr.s: New file.
	* testsuite/gas/s12z/tfr.d: New file.
	* testsuite/gas/s12z/tfr.s: New file.
	* testsuite/gas/s12z/trap.d: New file.
	* testsuite/gas/s12z/trap.s: New file.

binutils* readelf.c: Add support for s12z architecture.
	* testsuite/lib/binutils-common.exp (is_elf_format): Excluse s12z
	targets.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Updated simplified Chinese translation for the opcodes directory.
@ 2018-05-17 15:55 sergiodj+buildbot
  2018-07-07  9:46 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-17 15:55 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 809276d28ad0212dd5a3f9074090e1425e5e4d8e ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 809276d28ad0212dd5a3f9074090e1425e5e4d8e

Updated simplified Chinese translation for the opcodes directory.

opcodes	* po/zh_CN.po: Updated simplified Chinese translation.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] value.c: Remove unused variables
@ 2018-05-17 15:50 sergiodj+buildbot
  2018-07-06 23:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-17 15:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3e6188349fbf16e9da69837e5e1211537805e422 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 3e6188349fbf16e9da69837e5e1211537805e422

value.c: Remove unused variables

Obvious patch to remove unused local variables (found by adding
-Wunused).  I didn't touch this one in value_fetch_lazy, because
check_typedef could have a desired side-effect.

  3743  struct type *type = check_typedef (value_type (val));

gdb/ChangeLog:

	* value.c (release_value): Remove unused variable.
	(record_latest_value): Likewise.
	(access_value_history): Likewise.
	(preserve_values): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR22458, failure to choose a matching ELF target
@ 2018-05-16 13:10 sergiodj+buildbot
  2018-07-01 21:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-16 13:10 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7cf7fcc83ca9fb4c4b591b3142bcf12e6e8a2aa5 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 7cf7fcc83ca9fb4c4b591b3142bcf12e6e8a2aa5

PR22458, failure to choose a matching ELF target

https://sourceware.org/ml/binutils/2013-05/msg00271.html was supposed
to banish "file format is ambiguous" errors for ELF.  It didn't,
because the code supposedly detecting formats that implement
match_priority didn't work.  That was due to not placing all matching
targets into the vector of matching targets.  ELF objects should all
match the generic ELF target (priority 2), plus one or more machine
specific targets (priority 1), and perhaps a single machine specific
target with OS/ABI set (priority 0, best match).  So the armel object
in the testcase actually matches elf32-littlearm,
elf32-littlearm-symbian, and elf32-littlearm-vxworks (all priority 1),
and elf32-little (priority 2).  As the PR reported, elf32-little
wasn't seen as matching.  Fixing that part of the problem wasn't too
difficult but matching the generic ELF target as well as the ARM ELF
targets resulted in ARM testsuite failures.

These proved to be the annoying reordering of stubs that occurs from
time to time due to the stub names containing the section id.
Matching another target causes more sections to be created in
elf_object_p.  If section ids change, stub names change, which results
in different hashing and can therefore result in different hash table
traversal and stub creation order.  That particular problem is fixed
by resetting section_id to the initial state before attempting each
target match, and taking a snapshot of its value after a successful
match.

	PR 22458
	* format.c (struct bfd_preserve): Add section_id.
	(bfd_preserve_save, bfd_preserve_restore): Save and restore
	_bfd_section_id.
	(bfd_reinit): Set _bfd_section_id.
	(bfd_check_format_matches): Put all matches of any priority into
	matching_vector.  Save initial section id and start each attempted
	match at that section id.
	* libbfd-in.h (_bfd_section_id): Declare.
	* section.c (_bfd_section_id): Rename from section_id and make
	global.  Adjust uses.
	(bfd_get_next_section_id): Delete.
	* elf64-ppc.c (ppc64_elf_setup_section_lists): Replace use of
	bfd_get_section_id with _bfd_section_id.
	* libbfd.h: Regenerate.
	* bfd-in2.h: Regenerate.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] MIPS: Make `mask_address_var' static
@ 2018-05-15 17:55 sergiodj+buildbot
  2018-06-29 11:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-15 17:55 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ea33cd9290063d977fb2c31ea6a8567da585ab88 ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: ea33cd9290063d977fb2c31ea6a8567da585ab88

MIPS: Make `mask_address_var' static

Make the `mask_address_var' variable static, it is not used outside
mips-tdep.c and having no target name embedded within it causes a risk
of a namespace clash.

	gdb/
	* mips-tdep.c (mask_address_var): Make variable static.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] testsuite: Fix a `server_pid' access crash in gdb.server/server-kill.exp
@ 2018-05-15 15:48 sergiodj+buildbot
  2018-06-29  7:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-15 15:48 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0726fcc61a8b7c943de513ec598b2189c5f67715 ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 0726fcc61a8b7c943de513ec598b2189c5f67715

testsuite: Fix a `server_pid' access crash in gdb.server/server-kill.exp

Fix a commit f90183d7e31b ("Get GDBserver pid on remote target") bug and
correctly handle the case where the PID of `gdbserver' could not have
been retrieved.  If that happens, $server_pid is unset causing:

FAIL: gdb.server/server-kill.exp: p server_pid
ERROR: tcl error sourcing .../gdb/testsuite/gdb.server/server-kill.exp.
ERROR: can't read "server_pid": no such variable
    while executing
"if {$server_pid == "" } {
    return -1
}"
    (file ".../gdb/testsuite/gdb.server/server-kill.exp" line 49)
    invoked from within
"source .../gdb/testsuite/gdb.server/server-kill.exp"
    ("uplevel" body line 1)
    invoked from within
"uplevel #0 source .../gdb/testsuite/gdb.server/server-kill.exp"
    invoked from within
"catch "uplevel #0 source $test_file_name""

Verify that the variable exists then rather than trying to access it.

	gdb/testsuite/
	* gdb.server/server-kill.exp: Verify whether `server_pid' exists
	rather then trying to access it in determining whether the PID
	of `gdbserver' could have been retrieved.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Eliminate the 'the_core_target' global
@ 2018-05-11 21:20 sergiodj+buildbot
  2018-06-22  9:47 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-11 21:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 451953fa440aa0ade02b652159155fae689483a3 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 451953fa440aa0ade02b652159155fae689483a3

Eliminate the 'the_core_target' global

(previously called 'core_target', but since renamed because
'core_target' is the name of the target_ops class now.)

This eliminates the "the_core_target" global, as preparation for being
able to have more than one core loaded.  When we get there, we will
instantiate one core_target object per core instead.

Essentially, this replaces the reference to the_core_target in
core_file_command by a reference to core_bfd, which is per
program_space.

Currently, core_file_command calls 'the_core_target->detach()' even if
the core target is not open and pushed on the target stack.  If it is
indeed not open, then the practical effect is that
core_target::detach() prints "No core file now.".  That is preserved
by printing that directly from within core_file_command if not
debugging a core.

gdb/ChangeLog:
2018-05-11  Pedro Alves  <palves@redhat.com>

	* corefile.c (core_file_command): Move to corelow.c.
	* corelow.c (the_core_target): Delete.
	(core_file_command): Moved from corefile.c.  Check exec_bfd
	instead of the_core_target.  Use target_detach instead of calling
	into the_core_target directly.
	(maybe_say_no_core_file_now): New.
	(core_target::detach): Use it.
	(_initialize_corelow): Remove references to the_core_target.
	* gdbcore.h (the_core_target): Delete.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove cleanups from mdebugread.c
@ 2018-05-11 17:54 sergiodj+buildbot
  2018-06-21  8:59 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-11 17:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 633cf2548bcd3dafe297e21a1dd3574240280d48 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 633cf2548bcd3dafe297e21a1dd3574240280d48

Remove cleanups from mdebugread.c

This removes the remaining cleanups from mdebugread.c, replacing them
with gdb::def_vector.

Tested by the buildbot, though I doubt this exercises mdebugread.

gdb/ChangeLog
2018-05-11  Tom Tromey  <tom@tromey.com>

	* mdebugread.c (parse_partial_symbols, psymtab_to_symtab_1): Use
	gdb::def_vector.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix the clang build
@ 2018-05-10 20:54 sergiodj+buildbot
  2018-06-19 21:15 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-10 20:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1a34f210bb9389e58d93caf4384800934fc7113a ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 1a34f210bb9389e58d93caf4384800934fc7113a

Fix the clang build

Simon pointed out that gdb would not build with clang, due to the
addition of -Wimplicit-fallthrough.  This patch fixes the problem by
using -Wimplicit-fallthrough=3 -- this does not work with clang,
bypassing the issue.

Tested by rebuilding with both gcc and clang; and also by verifying
that -Wimplicit-fallthrough=3 is used in the gcc build.

I will file a follow-up bug to convert the fall-through comments to a
form that can be used by both clang and gcc.

gdb/ChangeLog
2018-05-10  Tom Tromey  <tom@tromey.com>

	* configure: Rebuild.
	* warning.m4 (AM_GDB_WARNINGS): Use -Wimplicit-fallthrough=3.

gdb/gdbserver/ChangeLog
2018-05-10  Tom Tromey  <tom@tromey.com>

	* configure: Rebuild.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdbserver/Windows: Fix "no program to debug" error
@ 2018-05-10 17:18 sergiodj+buildbot
  2018-06-18 14:18 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-10 17:18 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7dbac825b09f0847e608b50c80db816ef20d9315 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 7dbac825b09f0847e608b50c80db816ef20d9315

gdbserver/Windows: Fix "no program to debug" error

Trying to start a program with GDBserver on Windows yields
the following error:

    $ gdbserver.exe --once :4444 simple_main.exe
    Killing process(es): 5008
    No program to debug
    Exiting

The error itself comes from the following code shortly after
create_inferior gets called (in server.c::main):

    /* Wait till we are at first instruction in program.  */
    create_inferior (program_path.get (), program_args);
    [...]

    if (last_status.kind == TARGET_WAITKIND_EXITED
        || last_status.kind == TARGET_WAITKIND_SIGNALLED)
      was_running = 0;
    else
      was_running = 1;

    if (!was_running && !multi_mode)
      error ("No program to debug");

What happens is that the "last_status" global starts initialized
as zeroes, which means last_status.kind == TARGET_WAITKIND_EXITED,
and we expect create_inferior to be waiting for the inferior to
start until reaching the SIGTRAP, and to set the "last_status"
global to match that last event we received.

I suspect this is an unintended side-effect of the following change...

    commit 2090129c36c7e582943b7d300968d19b46160d84
    Date:   Thu Dec 22 21:11:11 2016 -0500
    Subject: Share fork_inferior et al with gdbserver

... which removes some code in server.c that was responsible for
starting the inferior in a functin that was named start_inferior,
and looked like this:

   signal_pid = create_inferior (new_argv[0], &new_argv[0]);
   [...]
   /* Wait till we are at 1st instruction in program, return new pid
      (assuming success).  */
   last_ptid = mywait (pid_to_ptid (signal_pid), &last_status, 0, 0);

The code has been transitioned to using fork_inferior, but sadly,
only for the targets that support it. On Windows, the calls to wait
setting "last_status" simply disappeared.

This patch adds it back in the Windows-specific implementation of
create_inferior.

gdb/gdbserver/ChangeLog:

        PR server/23158:
        * win32-low.c (win32_create_inferior): Add call to my_wait
        setting last_status global.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [gdbserver/win32] fatal "glob could not process pattern '(null)'" error
@ 2018-05-10 17:03 sergiodj+buildbot
  2018-06-18  7:18 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-10 17:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 906994d9d50eb40dc89a5bf0830e15ed10938641 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 906994d9d50eb40dc89a5bf0830e15ed10938641

[gdbserver/win32] fatal "glob could not process pattern '(null)'" error

Trying to start GDBserver on Windows currently yields the following
error...

    $ gdbserver.exe --once :4444 simple_main.exe
    glob could not process pattern '(null)'.
    Exiting

... after which GDB terminates with a nonzero status.

This is because create_process in win32-low.c calls gdb_tilde_expand
with the result of a call to get_inferior_cwd without verifying that
the returned directory is not NULL:

    | static BOOL
    | create_process (const char *program, char *args,
    |                 DWORD flags, PROCESS_INFORMATION *pi)
    | {
    |   const char *inferior_cwd = get_inferior_cwd ();
    |   std::string expanded_infcwd = gdb_tilde_expand (inferior_cwd);

This patch avoids this by only calling gdb_tilde_expand when
INFERIOR_CWD is not NULL, which is similar to what is done on
GNU/Linux for instance.

gdb/gdbserver/ChangeLog:

        PR server/23158:
        * win32-low.c (create_process): Only call gdb_tilde_expand if
        inferior_cwd is not NULL.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add support for detecting Freescale S12Z binaries in readelf.
@ 2018-05-10 12:28 sergiodj+buildbot
  2018-06-16 22:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-10 12:28 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 637b19704cf8325875de8df4f8b000197d261e3b ***

Author: John Darrington <john@darrington.wattle.id.au>
Branch: master
Commit: 637b19704cf8325875de8df4f8b000197d261e3b

Add support for detecting Freescale S12Z binaries in readelf.

* include/elf/common.h (EM_S12Z): New macro
* binutils/readelf.c (get_machine_name): EM_S12Z - handle new case.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix tagged pointer support
@ 2018-05-10 10:11 sergiodj+buildbot
  2018-06-16 21:50 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-10 10:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8727de56b0dbe25b7b4a3bd04f72ac41992463ed ***

Author: Omair Javaid <omair.javaid@linaro.org>
Branch: master
Commit: 8727de56b0dbe25b7b4a3bd04f72ac41992463ed

Fix tagged pointer support

This patch fixes tagged pointer support for AArch64 GDB. Linux kernel
debugging failure was reported after tagged pointer support was committed.

After a discussion around best path forward to manage tagged pointers
on GDB side we are going to disable tagged pointers support for
aarch64-none-elf-gdb because for non-linux applications we cant be
sure if tagged pointers will be used by MMU or not.

Also for aarch64-linux-gdb we are going to sign extend user-space
address after clearing tag bits. This will help debug both kernel
and user-space addresses based on information from linux kernel
documentation given below:

According to AArch64 memory map:
https://www.kernel.org/doc/Documentation/arm64/memory.txt

"User addresses have bits 63:48 set to 0 while the kernel addresses have
the same bits set to 1."

According to AArch64 tagged pointers document:
https://www.kernel.org/doc/Documentation/arm64/tagged-pointers.txt

The kernel configures the translation tables so that translations made
via TTBR0 (i.e. userspace mappings) have the top byte (bits 63:56) of
the virtual address ignored by the translation hardware. This frees up
this byte for application use.

Running gdb testsuite after applying this patch introduces no regressions
and tagged pointer test cases still pass.

gdb/ChangeLog:
2018-05-10  Omair Javaid  <omair.javaid@linaro.org>

	PR gdb/23127
	* aarch64-linux-tdep.c (aarch64_linux_init_abi): Add call to
	set_gdbarch_significant_addr_bit.
	* aarch64-tdep.c (aarch64_gdbarch_init): Remove call to
	set_gdbarch_significant_addr_bit.
	* utils.c (address_significant): Update to sign extend addr.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] RISC-V: Add missing hint instructions from RV128I.
@ 2018-05-08 23:14 sergiodj+buildbot
  2018-06-11 20:54 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-08 23:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e6f372ba661bb0d8eec1e22a6dc1ad9937336e4d ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: e6f372ba661bb0d8eec1e22a6dc1ad9937336e4d

RISC-V: Add missing hint instructions from RV128I.

	gas/
	* testsuite/gas/riscv/c-zero-imm.d: Add more tests.
	* testsuite/gas/riscv/c-zero-imm.s: Likewise.
	* testsuite/gas/riscv/c-zero-reg.d: Fix typo in test.  Add disabled
	future test for RV128 support.
	* testsuite/gas/riscv/c-zero-reg.s: Likewise.

	include/
	* opcode/riscv-opc.h (MATCH_C_SRLI64, MASK_C_SRLI64): New.
	(MATCH_C_SRAI64, MASK_C_SRAI64): New.
	(MATCH_C_SLLI64, MASK_C_SLLI64): New.

	opcodes/
	* riscv-opc.c (match_c_slli, match_slli_as_c_slli): New.
	(match_c_slli64, match_srxi_as_c_srxi): New.
	(riscv_opcodes) <slli, sll>: Use match_slli_as_c_slli.
	<srli, srl, srai, sra>: Use match_srxi_as_c_srxi.
	<c.slli, c.srli, c.srai>: Use match_s_slli.
	<c.slli64, c.srli64, c.srai64>: New.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdb/x86: Handle kernels using compact xsave format
@ 2018-05-08 17:40 sergiodj+buildbot
  2018-06-10  2:18 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-08 17:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8ee22052f690c007556b97eed59f49350ece5ca9 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 8ee22052f690c007556b97eed59f49350ece5ca9

gdb/x86: Handle kernels using compact xsave format

For GNU/Linux on x86-64, if the target is using the xsave format for
passing the floating-point information from the inferior then there
currently exists a bug relating to the x87 control registers, and the
mxcsr register.

The xsave format allows different floating-point features to be lazily
enabled, a bit in the xsave format tells GDB which floating-point
features have been enabled, and which have not.

Currently in GDB, when reading the floating point state, we check the
xsave bit flags, if the feature is enabled then we read the feature
from the xsave buffer, and if the feature is not enabled, then we
supply the default value from within GDB.

Within GDB, when writing the floating point state, we first fetch the
xsave state from the target and then, for any feature that is not yet
enabled, we write the default values into the xsave buffer.  Next we
compare the regcache value with the value in the xsave buffer, and, if
the value has changed we update the value in the xsave buffer, and
mark the feature enabled in the xsave bit flags.

The problem then, is that the x87 control registers were not following
this pattern.  We assumed that these registers were always written out
by the kernel, and we always wrote them out to the xsave buffer (but
didn't enabled the feature).  The result of this is that if the kernel
had not yet enabled the x87 feature then within GDB we would see
random values for the x87 floating point control registers, and if the
user tried to modify one of these register, that modification would be
lost.

Finally, the mxcsr register was also broken in the same way as the x87
control registers.  The added complexity with this case is that the
mxcsr register is part of both the avx and sse floating point feature
set.  When reading or writing this register we need to check that at
least one of these features is enabled.

This bug was present in native GDB, and within gdbserver.  Both are
fixed with this commit.

gdb/ChangeLog:

	* common/x86-xstate.h (I387_FCTRL_INIT_VAL): New constant.
	(I387_MXCSR_INIT_VAL): New constant.
	* amd64-tdep.c (amd64_supply_xsave): Only read state from xsave
	buffer if it was supplied by the inferior.
	* i387-tdep.c (i387_supply_fsave): Use I387_MXCSR_INIT_VAL.
	(i387_xsave_get_clear_bv): New function.
	(i387_supply_xsave): Only read x87 control registers from the
	xsave buffer if the feature is enabled, and the state will have
	been written, otherwise, provide a suitable default.
	(i387_collect_xsave): Pre-clear all registers in xsave buffer,
	including x87 control registers.  Update control registers if they
	have changed from the default value, and mark features as enabled
	as required.
	* i387-tdep.h (i387_xsave_get_clear_bv): Declare.

gdb/gdbserver/ChangeLog:

	* i387-fp.c (i387_cache_to_xsave): Only write x87 control
	registers to the cache if their values have changed.
	(i387_xsave_to_cache): Provide default values for x87 control
	registers when these features are available, but disabled.
	* regcache.c (supply_register_by_name_zeroed): New function.
	* regcache.h (supply_register_by_name_zeroed): Declare new
	function.

gdb/testsuite/ChangeLog:

	* gdb.arch/amd64-init-x87-values.S: New file.
	* gdb.arch/amd64-init-x87-values.exp: New file.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] watchpoint-unaligned.exp: Use skip_hw_watchpoint_tests
@ 2018-05-08 13:27 sergiodj+buildbot
  2018-06-07  9:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-08 13:27 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7785df4880f3828db8cf1715038127e6b858a670 ***

Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Branch: master
Commit: 7785df4880f3828db8cf1715038127e6b858a670

watchpoint-unaligned.exp: Use skip_hw_watchpoint_tests

gdb/testsuite/ChangeLog
2018-05-08  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* gdb.base/watchpoint-unaligned.exp: Use skip_hw_watchpoint_tests.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Prevent a memory exhaustion failure when running objdump on a fuzzed input file with corrupt string and attribute sections.
@ 2018-05-08 12:20 sergiodj+buildbot
  2018-06-03 22:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-08 12:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 95a6d23566165208853a68d9cd3c6eedca840ec6 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 95a6d23566165208853a68d9cd3c6eedca840ec6

Prevent a memory exhaustion failure when running objdump on a fuzzed input file with corrupt string and attribute sections.

	PR 22809
	* elf.c (bfd_elf_get_str_section): Check for an excessively large
	string section.
	* elf-attrs.c (_bfd_elf_parse_attributes): Issue an error if the
	attribute section is larger than the size of the file.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Simplify VLE handling in print_insn_powerpc().
@ 2018-05-08  2:10 sergiodj+buildbot
  2018-06-03 12:46 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-08  2:10 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a87a64780fde9dc8d1c3af8eda93fc1b878cd3cf ***

Author: Peter Bergner <bergner@vnet.ibm.com>
Branch: master
Commit: a87a64780fde9dc8d1c3af8eda93fc1b878cd3cf

Simplify VLE handling in print_insn_powerpc().

opcodes/
	* ppc-dis.c (print_insn_powerpc) <insn_is_short>: Replace this...
	<insn_length>: ...with this.  Update usage.
	Remove duplicate call to *info->memory_error_func.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add fall-through comment to i386-tdep.c
@ 2018-05-05  7:03 sergiodj+buildbot
  2018-05-11 22:22 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-05  7:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT da0e15638de59238ad811cdc3cc1d1a7803829c7 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: da0e15638de59238ad811cdc3cc1d1a7803829c7

Add fall-through comment to i386-tdep.c

This adds a fall-through comment in i386-tdep.c.  I was not sure what
to do here, so I elected to preserve the status quo.  In review, John
Baldwin pointed out that: "I believe this is correct based on the diff
that added the special cases for xgetbv and xsetbv as previously ldgt
and lidt were treated the same".

gdb/ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	* i386-tdep.c (i386_process_record): Add fall-through comment.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix "fall through" comments
@ 2018-05-05  4:33 sergiodj+buildbot
  2018-05-10  7:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-05  4:33 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 86a73007627a3c52d1c624ed430ac0e74fb8cc3e ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 86a73007627a3c52d1c624ed430ac0e74fb8cc3e

Fix "fall through" comments

This patch updates existing "fall through" comments so that they can
be recognized by gcc's -Wimplicit-fallthrough comment-parsing
heuristic.

ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	* s390-tdep.c (s390_process_record): Fix fall-through comments.
	* xcoffread.c (scan_xcoff_symtab): Move comment later.
	* symfile.c (section_is_mapped): Fix fall-through comment.
	* stabsread.c (define_symbol, read_member_functions): Fix
	fall-through comment.
	* s390-linux-tdep.c (s390_process_record): Fix fall-through
	comment.
	* remote.c (remote_wait_as): Fix fall-through comment.
	* p-exp.y (yylex): Fix fall-through comment.
	* nat/x86-dregs.c (x86_length_and_rw_bits): Fix fall-through
	comment.
	* msp430-tdep.c (msp430_gdbarch_init): Fix fall-through comment.
	* mdebugread.c (parse_partial_symbols): Fix fall-through comment.
	* jv-exp.y (yylex): Fix fall-through comment.
	* go-exp.y (lex_one_token): Fix fall-through comment.
	* gdbtypes.c (get_discrete_bounds, rank_one_type): Fix
	fall-through comment.
	* f-exp.y (yylex): Fix fall-through comment.
	* dwarf2read.c (process_die): Fix fall-through comments.
	* dbxread.c (process_one_symbol): Fix fall-through comment.
	* d-exp.y (lex_one_token): Fix fall-through comment.
	* cp-name-parser.y (yylex): Fix fall-through comment.
	* coffread.c (coff_symtab_read): Fix fall-through comment.
	* c-exp.y (lex_one_token): Fix fall-through comment.
	* arm-tdep.c (arm_decode_miscellaneous): Fix fall-through
	comment.
	* arch/arm.c (arm_instruction_changes_pc): Fix fall-through
	comment.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Use function_view in cli-script.c
@ 2018-05-05  1:14 sergiodj+buildbot
  2018-05-08 21:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-05  1:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 60b3cef2e49ba72dea55181a8ad0cb8dbf3f8a5b ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 60b3cef2e49ba72dea55181a8ad0cb8dbf3f8a5b

Use function_view in cli-script.c

This changes some functions in cli-script.c to use function_view
rather than a function pointer and closure argument.  This simplifies
the code a bit and is useful in a subsequent patch.

ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	* tracepoint.c (actions_command): Update.
	* mi/mi-cmd-break.c (mi_command_line_array)
	(mi_command_line_array_cnt, mi_command_line_array_ptr)
	(mi_read_next_line): Remove.
	(mi_cmd_break_commands): Update.
	* cli/cli-script.h (read_command_lines, read_command_lines_1): Use
	function_view.
	* cli/cli-script.c (get_command_line): Update.
	(process_next_line): Use function_view.  Constify.
	(recurse_read_control_structure, read_command_lines)
	(read_command_lines_1): Change argument types to function_view.
	(do_define_command, document_command): Update.
	* breakpoint.h (check_tracepoint_command): Don't declare.
	* breakpoint.c (check_tracepoint_command): Remove.
	(commands_command_1, create_tracepoint_from_upload): Update.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] aarch64: PR 19806: watchpoints: false negatives + PR 20207 contiguous ones
@ 2018-05-04 22:30 sergiodj+buildbot
  2018-05-06 21:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-04 22:30 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a3b60e4588606354b93508a0008a5ca04b68fad8 ***

Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Branch: master
Commit: a3b60e4588606354b93508a0008a5ca04b68fad8

aarch64: PR 19806: watchpoints: false negatives + PR 20207 contiguous ones

Some unaligned watchpoints were currently missed.

On old kernels as specified in
	kernel RFE: aarch64: ptrace: BAS: Support any contiguous range (edit)
	https://sourceware.org/bugzilla/show_bug.cgi?id=20207
after this patch some other unaligned watchpoints will get reported as false
positives.

With new kernels all the watchpoints should work exactly.

There may be a regresion that it now less merges watchpoints so that with
multiple overlapping watchpoints it may run out of the 4 hardware watchpoint
registers.  But as discussed in the original thread GDB needs some generic
watchpoints merging framework to be used by all the target specific code.
Even current FSF GDB code does not merge it perfectly.  Also with the more
precise watchpoints one can technically merge them less.  And I do not think
it matters too much to improve mergeability only for old kernels.
Still even on new kernels some better merging logic would make sense.

There remains one issue:
	kernel-4.15.14-300.fc27.armv7hl
	FAIL: gdb.base/watchpoint-unaligned.exp: continue
	FAIL: gdb.base/watchpoint-unaligned.exp: continue
	(gdb) continue
	Continuing.
	Unexpected error setting watchpoint: Invalid argument.
	(gdb) FAIL: gdb.base/watchpoint-unaligned.exp: continue
But that looks as a kernel bug to me.
(1) It is not a regression by this patch.
(2) It is unrelated to this patch.

gdb/ChangeLog
2018-05-04  Jan Kratochvil  <jan.kratochvil@redhat.com>
	    Pedro Alves <palves@redhat.com>

	PR breakpoints/19806 and support for PR external/20207.
	* NEWS: Mention Aarch64 watchpoint improvements.
	* aarch64-linux-nat.c (aarch64_linux_stopped_data_address): Fix missed
	watchpoints and PR external/20207 watchpoints.
	* nat/aarch64-linux-hw-point.c
	(kernel_supports_any_contiguous_range): New.
	(aarch64_watchpoint_offset): New.
	(aarch64_watchpoint_length): Support PR external/20207 watchpoints.
	(aarch64_point_encode_ctrl_reg): New parameter offset, new asserts.
	(aarch64_point_is_aligned): Support PR external/20207 watchpoints.
	(aarch64_align_watchpoint): New parameters aligned_offset_p and
	next_addr_orig_p.  Support PR external/20207 watchpoints.
	(aarch64_downgrade_regs): New.
	(aarch64_dr_state_insert_one_point): New parameters offset and
	addr_orig.
	(aarch64_dr_state_remove_one_point): Likewise.
	(aarch64_handle_breakpoint): Update caller.
	(aarch64_handle_aligned_watchpoint): Likewise.
	(aarch64_handle_unaligned_watchpoint): Support addr_orig and
	aligned_offset.
	(aarch64_linux_set_debug_regs): Remove const from state.  Call
	aarch64_downgrade_regs.
	(aarch64_show_debug_reg_state): Print also dr_addr_orig_wp.
	* nat/aarch64-linux-hw-point.h (DR_CONTROL_LENGTH): Rename to ...
	(DR_CONTROL_MASK): ... this.
	(struct aarch64_debug_reg_state): New field dr_addr_orig_wp.
	(unsigned int aarch64_watchpoint_offset): New prototype.
	(aarch64_linux_set_debug_regs): Remove const from state.
	* utils.c (align_up, align_down): Move to ...
	* common/common-utils.c (align_up, align_down): ... here.
	* utils.h (align_up, align_down): Move to ...
	* common/common-utils.h (align_up, align_down): ... here.

gdb/gdbserver/ChangeLog
2018-05-04  Jan Kratochvil  <jan.kratochvil@redhat.com>
	    Pedro Alves <palves@redhat.com>

	* linux-aarch64-low.c (aarch64_stopped_data_address):
	Likewise.

gdb/testsuite/ChangeLog
2018-05-04  Jan Kratochvil  <jan.kratochvil@redhat.com>
	    Pedro Alves <palves@redhat.com>

	PR breakpoints/19806 and support for PR external/20207.
	* gdb.base/watchpoint-unaligned.c: New file.
	* gdb.base/watchpoint-unaligned.exp: New file.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] (SPARC/LEON) fix incorrect array return value printed by "finish"
@ 2018-05-04 21:12 sergiodj+buildbot
  2018-05-05 19:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-04 21:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 05bc7456b872b81044d3b0e7c4d74c1de57217fd ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 05bc7456b872b81044d3b0e7c4d74c1de57217fd

(SPARC/LEON) fix incorrect array return value printed by "finish"

Consider the code in the gdb.ada/array_return.exp testcase, which
defines a function returning an array of 2 integers:

   type Data_Small is array (1 .. 2) of Integer;
   function Create_Small return Data_Small;

When doing a "finish" from inside function Create_Small, we expect
GDB to tell us that the return value was "(1, 1)". However, it currently
prints the wrong value:

    (gdb) finish
    Run till exit from #0  pck.create_small () at /[...]/pck.adb:5
    p () at /[...]/p.adb:10
    10         Large := Create_Large;
    Value returned is $1 = (0, 0)

This is a regression which I traced back to the following commit...

    | commit 1933fd8ee01ad2e74a9c6341bc40f54962a8f889
    | Date:   Fri May 19 03:06:19 2017 -0700
    | Subject: gdb: fix TYPE_CODE_ARRAY handling in sparc targets

... which, despite what the subject says, is not really about
TYPE_CODE_ARRAY handling, which is a bit of an implementation detail,
but about the GNU vectors extension.

The author of the patch equated TYPE_CODE_ARRAY with vectors, which
is not correct. Vectors are TYPE_CODE_ARRAY types with the TYPE_VECTOR
flag set. So at the very minimum, the patch should have been checking
for both TYPE_CODE_ARRAY and TYPE_VECTOR.

But, that's not the only thing that did not seem right to me. When
looking at the ABI, and at the summary of the implementation in GCC
of the calling conventions for that architecture:

                                size      argument     return value

      small integer              <4       int. reg.      int. reg.
      word                        4       int. reg.      int. reg.
      double word                 8       int. reg.      int. reg.

      _Complex small integer     <8       int. reg.      int. reg.
      _Complex word               8       int. reg.      int. reg.
      _Complex double word       16        memory        int. reg.

      vector integer            <=8       int. reg.       FP reg.
      vector integer             >8        memory         memory

      float                       4       int. reg.       FP reg.
      double                      8       int. reg.       FP reg.
      long double                16        memory         memory

      _Complex float              8        memory         FP reg.
      _Complex double            16        memory         FP reg.
      _Complex long double       32        memory         FP reg.

      vector float              any        memory         memory

      aggregate                 any        memory         memory

The nice thing about the patch above is that it nicely factorized
the code that determines how arguments are passed/returns. The bad
news is that the implementation, particularly for the handling of
arrays and vectors, doesn't seem to match the summary above. Hence,
the regression we observed.

So what I did was review and re-implement some of the predicate functions
according to the summary above. Because dejagnu crashes all our Solaris
machines real bad, I can't run the dejagnu testsuite there. So what I did
was test the patch with AdaCore's testsuite against leon3-elf, no
regression. I verified that this fixes the regression above while
at the same time still passing gdb.base/gnu_vector.exp (I transposed
that testcase to our testsuite), which is the testcase that was cited
in the commit above as seeing some FAIL->PASS improvements.

This patch also removes one assertion...

      gdb_assert (sparc_integral_or_pointer_p (type)
                  || (TYPE_CODE (type) == TYPE_CODE_ARRAY && len <= 8));

... because that assertion is really the "negative" of the other conditions
written in the same "if, else if, else [assert]" block in this function.
To me, this assertion forces us to maintain two versions of the same code,
and is an unnecessary burden. In particular, the above is not the
correct condition, and the ABI summary table above shows that we need
a more complex condition to describe the situations where we expect
arguments to be passed by register.

gdb/ChangeLog:

        * sparc-tdep.c (sparc_structure_return_p): Re-implement to
        match the ABI as summarized in GCC's gcc/config/sparc/sparc.c.
        (sparc_arg_by_memory_p): Renamed from sparc_arg_on_registers_p.
        Re-implement to match the ABI as summarized in GCC's
        gcc/config/sparc/sparc.c.  All callers updated.
        (sparc32_store_arguments): Remove assertion.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove do_closedir_cleanup
@ 2018-05-04 20:13 sergiodj+buildbot
  2018-05-05 12:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-04 20:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f0b3976bdcd29e308bed185630a24806037a717c ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: f0b3976bdcd29e308bed185630a24806037a717c

Remove do_closedir_cleanup

This removes both copies of do_closedir_cleanup in favor of a new
unique_ptr specialization.

Tested by the buildbot, though I'm not sure that these code paths are
exercised there.

ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	* nto-procfs.c (do_closedir_cleanup): Remove.
	(procfs_pidlist): Use gdb_dir_up.
	* procfs.c (do_closedir_cleanup): Remove.
	(proc_update_threads): Use gdb_dir_up.
	* common/filestuff.h (struct gdb_dir_deleter): New.
	(gdb_dir_up): New typedef.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] configure uses incorrect link order when testing libpython
@ 2018-05-04 14:14 sergiodj+buildbot
  2018-05-04 18:20 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-04 14:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bf27f0e2c76839af8524e053cca271934150a90c ***

Author: Paul Pluzhnikov <ppluzhnikov@google.com>
Branch: master
Commit: bf27f0e2c76839af8524e053cca271934150a90c

configure uses incorrect link order when testing libpython

References:

https://stackoverflow.com/a/49868387
https://sourceware.org/bugzilla/show_bug.cgi?id=11420

Configure uses "gcc -o conftest -g ... conftest.c -ldl -lncurses -lm -ldl
... -lpthread ... -lpython2.7" when deciding whether give libpython is
usable.

That of course is the wrong link order, and only works for shared libraries
(mostly by accident), and only on some systems.

gdb/ChangeLog:

	PR gdb/11420
	* configure.ac: Prepend libpython.
	* python/python-config.py: Likewise.
	* configure: Regenerate.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdb/testsuite: Filter out some registers for riscv
@ 2018-05-03 21:34 sergiodj+buildbot
  2018-05-04  5:08 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-03 21:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9b0797e268d96e8b46c328792aec3d6289585aa2 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 9b0797e268d96e8b46c328792aec3d6289585aa2

gdb/testsuite: Filter out some registers for riscv

On riscv the cycle counter, and instructions retired counter CSRs are
read only, this causes problems in the gdb.base/callfuncs.exp test, as
the values in these CSRs change after an inferior call, the check that
no target registers have been modified then fails.

Luckily the test already has a mechanism in place for filtering out
registers that are modified (and can't be restored) by an inferior call,
so this commit adds the problem registers into this list for riscv.

In the future we may end up needing to filter out more CSRs, but right
now, for the targets I have access too, these are the only ones causing
problems.

gdb/testsuite/ChangeLog:

	* gdb.base/callfuncs.exp (fetch_all_registers): Add riscv register
	filter pattern.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Eliminate target_ops::to_xclose
@ 2018-05-03  2:54 sergiodj+buildbot
  2018-05-03 11:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-03  2:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3fffc0701a26bc0baa563fdc793cafb3d3f02a93 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 3fffc0701a26bc0baa563fdc793cafb3d3f02a93

Eliminate target_ops::to_xclose

In the multi-target branch, I found no need for the target_close vs
target_xclose distinction.  Heap-allocated targets simply delete
themselves in their target_close implementation, while
singleton/static targets don't.

The target_ops C++ification patches will add more commentary around
target_ops's destructor, but there's no destructor yet...

gdb/ChangeLog:
2018-05-02  Pedro Alves  <palves@redhat.com>

	* bfd-target.c (target_bfd_xclose): Rename to ...
	(target_bfd_close): ... this.
	(target_bfd_reopen): Adjust.
	* target.c (target_close): Remove references to to_xclose.
	* target.h (target_ops::to_xclose): Delete.
	(target_ops::to_close): Update comments.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make inf_ptrace_trad Linux-only, move to separate file
@ 2018-05-03  2:12 sergiodj+buildbot
  2018-05-03  9:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-03  2:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6798487f5bc66ab9c34ad81fa28ba25d32a00bd9 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 6798487f5bc66ab9c34ad81fa28ba25d32a00bd9

Make inf_ptrace_trad Linux-only, move to separate file

There are only two inf_ptrace_trad_target users, MIPS GNU/Linux and
Alpha GNU/Linux.  They both call it via linux_trad_target.

Move this code out of inf-ptrace.c to a GNU/Linux-specific new file.

Making this code be GNU/Linux-specific simplifies C++ification of
target_ops, because we can make the trad target inherit linux_nat
instead of inheriting inf_ptrace.  That'll be visible in a later patch.

Note this makes linux_target_install_ops an extern function, but that
is temporary -- the function will disappear once target_ops is made a
C++ class with virtual methods, later in the series.  Also, I did not
rename the functions in the new file for a similar reason.  They'll be
renamed again anyway in a couple of patches.

gdb/ChangeLog:
2018-05-02  Pedro Alves  <palves@redhat.com>

	* alpha-linux-nat.c: Include "linux-nat-trad.h" instead of
	"linux-nat.h".
	* configure.nat (alpha-linux, linux-mips): Add linux-nat-trad.o.
	* inf-ptrace.c (inf_ptrace_register_u_offset)
	(inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
	(inf_ptrace_store_register, inf_ptrace_store_registers)
	(inf_ptrace_trad_target): Move to ...
	* linux-nat-trad.c: ... this new file.
	* linux-nat-trad.h: New file.
	* linux-nat.c (linux_target_install_ops): Make extern.
	(linux_trad_target): Delete.
	* linux-nat.h (linux_trad_target): Delete declaration.
	(linux_target_install_ops): Declare.
	* mips-linux-nat.c: Include "linux-nat-trad.h" instead of
	"linux-nat.h".


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] More procfs.c simplification
@ 2018-05-03  0:37 sergiodj+buildbot
  2018-05-03  6:56 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-03  0:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c1955e179201e76330a10c400bfa92cab2afbee0 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: c1955e179201e76330a10c400bfa92cab2afbee0

More procfs.c simplification

There are only two architectures using procfs.c (i386/SPARC), and none
of their corresponding nat files overrides any target method.  Move
the add_target calls to procfs.c directly.

gdb/ChangeLog:
2018-05-02  Pedro Alves  <palves@redhat.com>

	* i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
	procfs_target/add_target here.
	* procfs.c (procfs_target): Make static.
	(_initialize_procfs): Call add_target here.
	* procfs.h (struct target_ops): Remove forward declaration.
	(procfs_target): Remove declaration.
	* sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Delete.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove a use of is_mi_like_p from darwin-nat-info.c
@ 2018-05-01  1:23 sergiodj+buildbot
  2018-05-02 12:15 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-05-01  1:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 767619365467fd825c6f3906a49d97a7a6afafd6 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 767619365467fd825c6f3906a49d97a7a6afafd6

Remove a use of is_mi_like_p from darwin-nat-info.c

This removes a use of is_mi_like_p from darwin-nat-info.c.
This is not needed because MI already ignores ui_out::text.

ChangeLog
2018-04-30  Tom Tromey  <tom@tromey.com>

	* darwin-nat-info.c (darwin_debug_regions_recurse): Remove use of
	is_mi_like_p.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove some uses of is_mi_like_p from spu-tdep.c
@ 2018-04-30 23:58 sergiodj+buildbot
  2018-05-02  5:38 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-30 23:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 40c03530b197d8d6ef550283ecd6684e8d49301b ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 40c03530b197d8d6ef550283ecd6684e8d49301b

Remove some uses of is_mi_like_p from spu-tdep.c

There were a few spots in spu-tdep.c where a use of is_mi_like_p was
not needed.

ChangeLog
2018-04-30  Tom Tromey  <tom@tromey.com>

	* spu-tdep.c (info_spu_mailbox_list, info_spu_dma_cmdlist)
	(info_spu_event_command): Remove some uses of is_mi_like_p.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove some uses of is_mi_like_p from py-framefilter.c
@ 2018-04-30 23:38 sergiodj+buildbot
  2018-05-02  3:29 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-30 23:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2038b7fdf30c39bc4d528cc2e5fbf5403e0ba79e ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 2038b7fdf30c39bc4d528cc2e5fbf5403e0ba79e

Remove some uses of is_mi_like_p from py-framefilter.c

Some uses of is_mi_like_p in py-framefilter.c were not needed.  In
general a call to ui_out::text, ui_out::message, or ui_out::spaces
does not need to be guarded -- these are already ignored by MI.

ChangeLog
2018-04-30  Tom Tromey  <tom@tromey.com>

	* python/py-framefilter.c (py_print_single_arg)
	(enumerate_locals, py_print_args, py_print_frame): Remove some
	uses of is_mi_like_p.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Change Python code to use new_reference
@ 2018-04-30 22:16 sergiodj+buildbot
  2018-05-01 22:33 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-30 22:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7c66fffc1f3dae0b921ae3cf8139824804cf0705 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 7c66fffc1f3dae0b921ae3cf8139824804cf0705

Change Python code to use new_reference

This changes a few spots in the Python code to use new_reference
rather than the manual incref+constructor that was previously being
done.

ChangeLog
2018-04-30  Tom Tromey  <tom@tromey.com>

	* varobj.c (varobj_set_visualizer): Use new_reference.
	* python/python.c (gdbpy_decode_line): Use new_reference.
	* python/py-cmd.c (cmdpy_function, cmdpy_completer_helper): Use
	new_reference.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Introduce ref_ptr::new_reference
@ 2018-04-30 21:46 sergiodj+buildbot
  2018-05-01 14:54 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-30 21:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7c1b5f3db73d7ecab03dc4e866e291582935fb04 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 7c1b5f3db73d7ecab03dc4e866e291582935fb04

Introduce ref_ptr::new_reference

I noticed a common pattern with gdb::ref_ptr, where callers would
"incref" and then create a new wrapper object, like:

    Py_INCREF (obj);
    gdbpy_ref<> ref (obj);

The ref_ptr constructor intentionally does not acquire a new
reference, but it seemed to me that it would be reasonable to add a
static member function that does so.

In this patch I chose to call the function "new_reference".  I
considered "acquire_reference" as well, but "new" seemed less
ambiguous than "acquire" to me.

ChangeLog
2018-04-30  Tom Tromey  <tom@tromey.com>

	* common/gdb_ref_ptr.h (ref_ptr::new_reference): New static
	method.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove new_bfd_ref
@ 2018-04-30 21:37 sergiodj+buildbot
  2018-05-01 17:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-30 21:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1831a9f9d3346dbf61202d2aba6935f0093487dd ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 1831a9f9d3346dbf61202d2aba6935f0093487dd

Remove new_bfd_ref

For gdb_bfd_ref_ptr, gdb already had a convenience function like the
new gdb_ref_ptr::new_reference -- called new_bfd_ref.  This patch
removes it in favor of the new common function.

While doing this I also noticed that the comment for gdb_bfd_open was
incorrect (in a way related to reference counting), so this patch
updates the comment as well.

ChangeLog
2018-04-30  Tom Tromey  <tom@tromey.com>

	* symfile-mem.c (symbol_file_add_from_memory): Use new_reference.
	* gdb_bfd.h (new_bfd_ref): Remove.
	(gdb_bfd_open): Update comment.
	* gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
	(gdb_bfd_openw, gdb_bfd_openr_iovec, gdb_bfd_record_inclusion)
	(gdb_bfd_fdopenr): Use new_reference.
	* exec.c (exec_file_attach): Use new_reference.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Expose type alignment on gdb.Type
@ 2018-04-30 19:20 sergiodj+buildbot
  2018-05-01  4:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-30 19:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6d7bb8246b3beaf60ea9c2abe183705e876519cd ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 6d7bb8246b3beaf60ea9c2abe183705e876519cd

Expose type alignment on gdb.Type

This adds an "alignof" attribute to gdb.Type in the Python API.

2018-04-30  Tom Tromey  <tom@tromey.com>

	* NEWS: Mention Type.align.
	* python/py-type.c (typy_get_alignof): New function.
	(type_object_getset): Add "alignof".

2018-04-30  Tom Tromey  <tom@tromey.com>

	* python.texi (Types In Python): Document Type.align.

2018-04-30  Tom Tromey  <tom@tromey.com>

	* gdb.python/py-type.exp: Check align attribute.
	* gdb.python/py-type.c: New "aligncheck" global.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Handle alignof and _Alignof
@ 2018-04-30 18:19 sergiodj+buildbot
  2018-05-01  1:33 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-30 18:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 007e1530347330d4dbba387c4e35aae05bc06498 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 007e1530347330d4dbba387c4e35aae05bc06498

Handle alignof and _Alignof

This adds alignof and _Alignof to the C/C++ expression parser, and
adds new tests to test the features.  The tests are written to try to
ensure that gdb's knowledge of alignment rules stays in sync with the
compiler's.

2018-04-30  Tom Tromey  <tom@tromey.com>

	PR exp/17095:
	* NEWS: Update.
	* std-operator.def (UNOP_ALIGNOF): New operator.
	* expprint.c (dump_subexp_body_standard) <case UNOP_ALIGNOF>:
	New.
	* eval.c (evaluate_subexp_standard) <case UNOP_ALIGNOF>: New.
	* c-lang.c (c_op_print_tab): Add alignof.
	* c-exp.y (ALIGNOF): New token.
	(exp): Add "ALIGNOF" production.
	(ident_tokens): Add _Alignof and alignof.

2018-04-30  Tom Tromey  <tom@tromey.com>

	PR exp/17095:
	* gdb.dwarf2/dw2-align.exp: New file.
	* gdb.cp/align.exp: New file.
	* gdb.base/align.exp: New file.
	* lib/gdb.exp (gdb_int128_helper): New proc.
	(has_int128_c, has_int128_cxx): New caching procs.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add initial type alignment support
@ 2018-04-30 17:32 sergiodj+buildbot
  2018-04-30 23:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-30 17:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2b4424c35b9ebabaab8588b2ba6c38935a48efec ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 2b4424c35b9ebabaab8588b2ba6c38935a48efec

Add initial type alignment support

This adds some basic type alignment support to gdb.  It changes struct
type to store the alignment, and updates dwarf2read.c to handle
DW_AT_alignment.  It also adds a new gdbarch method and updates
i386-tdep.c.

None of this new functionality is used anywhere yet, so tests will
wait until the next patch.

2018-04-30  Tom Tromey  <tom@tromey.com>

	* i386-tdep.c (i386_type_align): New function.
	(i386_gdbarch_init): Update.
	* gdbarch.sh (type_align): New method.
	* gdbarch.c, gdbarch.h: Rebuild.
	* arch-utils.h (default_type_align): Declare.
	* arch-utils.c (default_type_align): New function.
	* gdbtypes.h (TYPE_ALIGN_BITS): New define.
	(struct type) <align_log2>: New field.
	<instance_flags>: Now a bitfield.
	(TYPE_RAW_ALIGN): New macro.
	(type_align, type_raw_align, set_type_align): Declare.
	* gdbtypes.c (type_align, type_raw_align, set_type_align): New
	functions.
	* dwarf2read.c (quirk_rust_enum): Set type alignment.
	(get_alignment, maybe_set_alignment): New functions.
	(read_structure_type, read_enumeration_type, read_array_type)
	(read_set_type, read_tag_pointer_type, read_tag_reference_type)
	(read_subrange_type, read_base_type): Set type alignment.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Use bool in read_index_from_section
@ 2018-04-30 15:27 sergiodj+buildbot
  2018-04-30 18:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-30 15:27 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d33bc52e51fdb6c464c1c8e8fdf9b2007b522b57 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: d33bc52e51fdb6c464c1c8e8fdf9b2007b522b57

Use bool in read_index_from_section

gdb/ChangeLog:

	* dwarf2read.c (read_index_from_section): Use bool.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] proc-events.c: fix compilation on Solaris
@ 2018-04-29 16:52 sergiodj+buildbot
  2018-04-30 12:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-29 16:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e28b63a989caffa4a6fba1aaf0d8992b37d13da8 ***

Author: Fabian Groffen <grobian@gentoo.org>
Branch: master
Commit: e28b63a989caffa4a6fba1aaf0d8992b37d13da8

proc-events.c: fix compilation on Solaris

This patch adds a guard around the usage of SYS_uuidsys, which is
not available on (at least) Solaris 10 and OpenIndiana.

gdb/ChangeLog:

	PR gdb/22950
	* proc-events.c (init_syscall_table): Guard usage os SYS_uuidsys
	with #ifdef.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix race when building ada-lex.c
@ 2018-04-29 16:18 sergiodj+buildbot
  2018-04-30  6:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-29 16:18 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cd8c76e410a5f16a170cc680be1ae2ecb5528821 ***

Author: John Reiser <jreiser@BitWagon.com>
Branch: master
Commit: cd8c76e410a5f16a170cc680be1ae2ecb5528821

Fix race when building ada-lex.c

Prevent a race when building ada-lex.c, and any target of rules .c:.l or
.c:.y.  The target should be written only at the last step, else SIGINT
(^C) can leave an inconsistent state.  Being .PRECIOUS makes it even
worse.

gdb/ChangeLog:

	PR build/22873
	* gdb/Makefile.in: (.c:.l, .c:.y): Write the target only in the
	last step, and do it atomically.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add inclusive range support for Rust
@ 2018-04-27 20:09 sergiodj+buildbot
  2018-04-29 20:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-27 20:09 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6873858b7e464e114f9a877e216949ad8350b4cf ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 6873858b7e464e114f9a877e216949ad8350b4cf

Add inclusive range support for Rust

This is version 2 of the patch to add inclusive range support for
Rust.  I believe it addresses all review comments.

Rust recently stabilized the inclusive range feature:

    https://github.com/rust-lang/rust/issues/28237

An inclusive range is an expression like "..= EXPR" or "EXPR ..=
EXPR".  It is like an ordinary range, except the upper bound is
inclusive, not exclusive.

This patch adds support for this feature to gdb.

Regression tested on x86-64 Fedora 27.

2018-04-27  Tom Tromey  <tom@tromey.com>

	PR rust/22545:
	* rust-lang.c (rust_inclusive_range_type_p): New function.
	(rust_range): Handle inclusive ranges.
	(rust_compute_range): Likewise.
	* rust-exp.y (struct rust_op) <inclusive>: New field.
	(DOTDOTEQ): New constant.
	(range_expr): Add "..=" productions.
	(operator_tokens): Add "..=" token.
	(ast_range): Add "inclusive" parameter.
	(convert_ast_to_expression) <case OP_RANGE>: Handle inclusive
	ranges.
	* parse.c (operator_length_standard) <case OP_RANGE>: Handle new
	bounds values.
	* expression.h (enum range_type) <NONE_BOUND_DEFAULT_EXCLUSIVE,
	LOW_BOUND_DEFAULT_EXCLUSIVE>: New constants.
	Update comments.
	* expprint.c (print_subexp_standard): Handle new bounds values.
	(dump_subexp_body_standard): Likewise.

2018-04-27  Tom Tromey  <tom@tromey.com>

	PR rust/22545:
	* gdb.rust/simple.exp: Add inclusive range tests.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Enable -Wsuggest-override
@ 2018-04-27 19:21 sergiodj+buildbot
  2018-04-29 16:18 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-27 19:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 632e107b32c0fe8aede62e070b00756e9fdd2c01 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 632e107b32c0fe8aede62e070b00756e9fdd2c01

Enable -Wsuggest-override

I noticed the existence of -Wsuggest-override and so this patch
enables it for gdb.  It found a few spots that could use "override".
Also I went ahead and removed all uses of the "OVERRIDE" macro.

Using override is beneficial because it makes it harder to change a
base class and then forget to change a derived class.

Tested by the buildbot.

ChangeLog
2018-04-27  Tom Tromey  <tom@tromey.com>

	* configure: Rebuild.
	* warning.m4 (AM_GDB_WARNINGS): Add -Wsuggest-override.
	* dwarf2loc.c (class dwarf_evaluate_loc_desc): Use "override", not
	"OVERRIDE".
	(class symbol_needs_eval_context): Likewise.
	* dwarf2read.c (mock_mapped_index::symbol_name_count)
	(mock_mapped_index::symbol_name_at): Use "override".  Remove
	"virtual".
	* dwarf2-frame.c (dwarf_expr_executor::get_addr_index): Use
	"override".
	(class dwarf_expr_executor): Use "override", not "OVERRIDE".
	* aarch64-tdep.c (instruction_reader::read): Use "override".
	(instruction_reader_test::read): Likewise.
	* arm-tdep.c (instruction_reader::read): Use "override".
	(instruction_reader_thumb::read): Likewise.

gdbserver/ChangeLog
2018-04-27  Tom Tromey  <tom@tromey.com>

	* configure: Rebuild.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Revert "Enable Intel MOVDIRI, MOVDIR64B instructions."
@ 2018-04-27 13:09 sergiodj+buildbot
  2018-04-29 14:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-27 13:09 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT aa178437393fd97f706c3f8bdf60ab2cc53a8cb4 ***

Author: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
Branch: master
Commit: aa178437393fd97f706c3f8bdf60ab2cc53a8cb4

Revert "Enable Intel MOVDIRI, MOVDIR64B instructions."

This reverts commit a914a7c95895161c99533d5919b8504b37ea54a0.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Regenerate some files for recent ARM patches
@ 2018-04-27 11:12 sergiodj+buildbot
  2018-04-29 11:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-27 11:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ffa389a39655f4b35d583783e49fa5b31c288e8f ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: ffa389a39655f4b35d583783e49fa5b31c288e8f

Regenerate some files for recent ARM patches

bfd/
	* bfd-in2.h: Regenerate.
	* libbfd.h: Regenerate.
ld/
	* po/BLD-POTFILES.in: Regenerate.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix remote 'g' command error handling (PR remote/9665)
@ 2018-04-26 23:25 sergiodj+buildbot
  2018-04-29  5:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 23:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b75abf5bb636869fd893ecf98414b8b2fe0d4a12 ***

Author: Andrzej Kaczmarek <andrzej.kaczmarek@codecoup.pl>
Branch: master
Commit: b75abf5bb636869fd893ecf98414b8b2fe0d4a12

Fix remote 'g' command error handling (PR remote/9665)

'g' command returns hex-string as response so simply checking for 'E'
to determine if it failed is not enough and can trigger spurious error
messages.  For example, invalid behaviour can be easily triggered on
Cortex-M as follows:

  (gdb) set $r0 = 0xe0
  Sending packet: $P0=e0000000#72...Packet received: OK
  Packet P (set-register) is supported
  Sending packet: $g#67...Packet received: E0000000849A0020...
  Remote failure reply: E0000000849A0020...

This patch fixes the problem by calling putpkt()/getpkt() directly and
checking result with packet_check_result().  This works fine since Enn
response has odd number of bytes while proper response has even number
of bytes.

Also, remote_send() is now not used anywhere so it can be removed.

gdb/Changelog:
2018-04-26  Andrzej Kaczmarek  <andrzej.kaczmarek@codecoup.pl>

	PR remote/9665
	* remote.c (send_g_packet): Use putpkt/getpkt/packet_check_result
	instead of remote_send.
	(remote_send): Remove.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Enable Intel MOVDIRI, MOVDIR64B instructions.
@ 2018-04-26 22:02 sergiodj+buildbot
  2018-04-29  2:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 22:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a914a7c95895161c99533d5919b8504b37ea54a0 ***

Author: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
Branch: master
Commit: a914a7c95895161c99533d5919b8504b37ea54a0

Enable Intel MOVDIRI, MOVDIR64B instructions.

gas/
	* config/tc-i386.c (cpu_arch): Add .movdir, .movdir64b.
	(cpu_noarch): Likewise.
	(process_suffix): Add check for register size.
	* doc/c-i386.texi: Document movdiri, movdir64b.
	* testsuite/gas/i386/i386.exp: Run MOVDIR{I,64B} tests.
	* testsuite/gas/i386/movdir-intel.d: New test.
	* testsuite/gas/i386/movdir.d: Likewise.
	* testsuite/gas/i386/movdir.s: Likewise.
	* testsuite/gas/i386/movdir64b-reg.s: Likewise.
	* testsuite/gas/i386/movdir64b-reg.l: Likewise.
	* testsuite/gas/i386/x86-64-movdir-intel.d: Likewise.
	* testsuite/gas/i386/x86-64-movdir.d: Likewise.
	* testsuite/gas/i386/x86-64-movdir.s: Likewise.
	* testsuite/gas/i386/x86-64-movdir64b-reg.s: Likewise.
	* testsuite/gas/i386/x86-64-movdir64b-reg.l: Likewise.

opcodes/
	* i386-dis.c (enum): Add PREFIX_0F38F8, PREFIX_0F38F9.
	(prefix_table): New instructions (see prefix above).
	Add Gva macro and handling in OP_G.
	* i386-gen.c (cpu_flag_init): Add CPU_MOVDIRI_FLAGS,
	CPU_MOVDIR64B_FLAGS.
	(cpu_flags): Likewise.
	(opcode_modifiers): Add AddrPrefixOpReg.
	(i386_opcode_modifier): Likewise.
	* i386-opc.h (enum): Add CpuMOVDIRI, CpuMOVDIR64B.
	(i386_cpu_flags): Likewise.
	* i386-opc.tbl: Add movidir{i,64b}.
	* i386-init.h: Regenerate.
	* i386-tbl.h: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix resolving GNU ifunc bp locations when inferior runs resolver
@ 2018-04-26 19:45 sergiodj+buildbot
  2018-04-29  0:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 19:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 79188d8d27a8885aee2ca4ff55238219a6aa7228 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 79188d8d27a8885aee2ca4ff55238219a6aa7228

Fix resolving GNU ifunc bp locations when inferior runs resolver

I noticed that if you set a breakpoint on an ifunc before the ifunc is
resolved, and then let the program call the ifunc, thus resolving it,
GDB end up with a location for that original breakpoint that is
pointing to the ifunc target, but it is left pointing to the first
address of the function, instead of after its prologue.  After
prologue is what you get if you create a new breakpoint at that point.

1) With no debug info for the target function:

  1.a) Set before resolving, and then program continued passed resolving:

    Num     Type           Disp Enb Address            What
    1       breakpoint     keep y   0x0000000000400753 <final>

  1.b) Breakpoint set after inferior resolved ifunc:

    Num     Type           Disp Enb Address            What
    2       breakpoint     keep y   0x0000000000400757 <final+4>


2) With debug info for the target function:

   1.a) Set before resolving, and then program continued passed resolving:

     Num     Type           Disp Enb Address            What
     1       breakpoint     keep y   0x0000000000400753 in final at gdb/testsuite/gdb.base/gnu-ifunc-final.c:20

   1.b) Breakpoint set after inferior resolved ifunc:

     Num     Type           Disp Enb Address            What
     2       breakpoint     keep y   0x000000000040075a in final at gdb/testsuite/gdb.base/gnu-ifunc-final.c:21

The problem is that elf_gnu_ifunc_resolver_return_stop (called by the
internal breakpoint that traps the resolver returning) does not agree
with linespec.c:minsym_found.  It does not skip to the function's
start line (i.e., past the prologue).  We can now use the
find_function_start_sal overload added by the previous commmit to fix
this.

New tests included, which fail before the patch, and pass afterwards.

gdb/ChangeLog:
2018-04-26  Pedro Alves  <palves@redhat.com>

	* elfread.c (elf_gnu_ifunc_resolver_return_stop): Use
	find_function_start_sal instead of find_pc_line.

gdb/testsuite/ChangeLog:
2018-04-26  Pedro Alves  <palves@redhat.com>

	* gdb.base/gnu-ifunc.exp (set-break): Test that GDB resolves
	ifunc breakpoint locations correctly of ifunc breakpoints set
	while the program resolves the ifunc.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Extend GNU ifunc testcases
@ 2018-04-26 18:42 sergiodj+buildbot
  2018-04-28 22:06 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 18:42 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c7075ad5030c4c2e79a04f3517689b751ff41860 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: c7075ad5030c4c2e79a04f3517689b751ff41860

Extend GNU ifunc testcases

This patch extends/rewrites the gdb.base/gnu-ifunc.exp testcase to
cover the many different fixes in earlier patches.  (This was actually
what encovered most of the problems.)

The current testcase uses an ifunc symbol with the same name as the
ifunc resolver symbol and makes sure to compile the ifunc resolver
without debug info.  That does not model how ifuncs are implemented in
gcc/ifunc nowadays.  Instead, what we have is that the glibc ifunc
resolvers nowadays are written in C and end up with debug info.

Also, in some cases the ifunc target is written in assembly, but in
other cases it's written in C.  In the case of target function written
in C, if the target function has debug info, when we set a break on
the ifunc, we want to set it past the prologue of the target function.
Currently GDB gets that wrong.

To make sure we cover all the different scenarios, the testcase is
tweaked to cover all the different combinations of

 - An ifunc resolver with the same name as the user-visible symbol vs
   an ifunc resolver with a different name as the user-visible symbol.

 - ifunc resolver compiled with and without debug info.

 - ifunc target function compiled with and without debug info.

The testcase currently sets breakpoints on ifuncs, calls ifunc
functions, steps into ifunc functions, etc.  After this series, this
all works and the testcase passes cleanly.

While working on this, I noticed that "b gnu_ifunc" before and after
the inferior resolved the ifunc would end up with a breakpoint with
different locations.  That's now covered by new tests inside the new
"set-break" procedure.

It also tests other things like making sure we can't call an ifunc
without a return-type case if we don't know the type of the target.
And making sure that we pass enough arguments when we do know the
type.

gdb/testsuite/ChangeLog:
2018-04-26  Pedro Alves  <palves@redhat.com>

	* gdb.base/gnu-ifunc-final.c: New file.
	* gdb.base/gnu-ifunc.c (final): Delete, moved to gnu-ifunc-final.c.
	* gdb.base/gnu-ifunc.exp (executable): Delete.
	(staticexecutable): Adjust.
	(lib_opts, exec_opts): Delete.
	(make_binsuffix, build, set-break): New procedures.
	(misc_tests): New, with tests factored out from the top level.
	(top level): Test different combinations of ifunc resolver name,
	resolver with and with debug info, and ifunc target with and
	without debug info.  Wrap static tests with with_target_prefix.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PPC64: always make synthetic .text symbols for GNU ifunc symbols
@ 2018-04-26 18:05 sergiodj+buildbot
  2018-04-28 19:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 18:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bfa5bd2ab31a8abb23cb442d51fe6c3836028880 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: bfa5bd2ab31a8abb23cb442d51fe6c3836028880

PPC64: always make synthetic .text symbols for GNU ifunc symbols

If you create an ifunc using GCC's __attribute__ ifunc, like:

 extern int gnu_ifunc (int arg);
 static int gnu_ifunc_target (int arg) { return 0; }
 __typeof (gnu_ifunc) *gnu_ifunc_resolver (unsigned long hwcap) { return gnu_ifunc_target; }
 __typeof (gnu_ifunc) gnu_ifunc __attribute__ ((ifunc ("gnu_ifunc_resolver")));

then you end up with two (function descriptor) symbols, one for the
ifunc itself, and another for the resolver:

   (...)
   12: 0000000000020060    104 FUNC    GLOBAL DEFAULT       18 gnu_ifunc_resolver
   (...)
   16: 0000000000020060    104 GNU_IFUNC GLOBAL DEFAULT       18 gnu_ifunc
   (...)

Both ifunc and resolver symbols have the same address/value, so
ppc64_elf_get_synthetic_symtab only creates a synthetic text symbol
for one of them.  In the case above, it ends up being created for the
resolver, only:

  (gdb) maint print msymbols
  (...)
  [ 7] t 0x980 .frame_dummy section .text
  [ 8] T 0x9e4 .gnu_ifunc_resolver section .text
  [ 9] T 0xa58 __glink_PLTresolve section .text
  (...)

GDB needs to know when a program stepped into an ifunc resolver, so
that it can know whether to step past the resolver into the target
function without the user noticing.  The way GDB does it is my
checking whether the current PC points to an ifunc symbol (since
resolver and ifunc have the same address by design).

The problem is then that ppc64_elf_get_synthetic_symtab never creates
the synchetic symbol for the ifunc, so GDB stops stepping at the
resolver (in a test added by the following patch):

  (gdb) step
  gnu_ifunc_resolver (hwcap=21) at gdb/testsuite/gdb.base/gnu-ifunc-lib.c:33
  33      {
  (gdb) FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=1: resolver_debug=1: final_debug=0: step

After this commit, we get:

  [ 8] i 0x9e4 .gnu_ifunc section .text
  [ 9] T 0x9e4 .gnu_ifunc_resolver section .text

And stepping an ifunc call takes to the final function:
  (gdb) step
  0x00000000100009e8 in .final ()
  (gdb) PASS: gdb.base/gnu-ifunc.exp: resolver_attr=1: resolver_debug=1: final_debug=0: step

An alternative to touching bfd I considered was for GDB to check
whether there's an ifunc data symbol / function descriptor that points
to the current PC, whenever the program stops, but discarded it
because we'd have to do a linear scan over .opd over an over to find a
matching function descriptor for the current PC.  At that point I
considered caching that info, but quickly dismissed it as then that
has no advantage (memory or performance) over just creating the
synthetic ifunc text symbol in the first place.

I ran the binutils and ld testsuites on PPC64 ELFv1 (machine gcc110 on
the GCC compile farm), and saw no regressions.  This commit is part of
a GDB patch series that includes GDB tests that fail without this fix.

bfd/ChangeLog:
2018-04-26  Pedro Alves  <palves@redhat.com>

	* elf64-ppc.c (ppc64_elf_get_synthetic_symtab): Don't consider
	ifunc and non-ifunc symbols duplicates.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] For PPC64: elf_gnu_ifunc_record_cache: handle plt symbols in .text section
@ 2018-04-26 16:34 sergiodj+buildbot
  2018-04-28 10:49 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 16:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1adeb822668d3bd7182ca9b8cf42a7261deb3c7f ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 1adeb822668d3bd7182ca9b8cf42a7261deb3c7f

For PPC64: elf_gnu_ifunc_record_cache: handle plt symbols in .text section

elf_gnu_ifunc_record_cache doesn't ever record anything on PPC64
(tested on gcc110 on the compile farm, CentOS 7.4, ELFv1), because
that expects to find PLT symbols in the .plt section, while there we
get:

  (gdb) info symbol 'gnu_ifunc@plt'
  gnu_ifunc@plt in section .text
                           ^^^^^

I guess that may be related to the comment in ppc-linux-tdep.c that
says "For secure PLT, stub is in .text".

In any case, this commit fixes the issue by making the function look
at the symbol name instead of at the section.

gdb/ChangeLog:
2018-04-26  Pedro Alves  <palves@redhat.com>

	* elfread.c (elf_gnu_ifunc_record_cache): Check if the symbol name
	ends in "@plt" instead of looking at the symbol's section.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Eliminate find_pc_partial_function_gnu_ifunc
@ 2018-04-26 15:43 sergiodj+buildbot
  2018-04-28  4:57 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 15:43 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a0aca7b0e13d884f43ba77c4c6d752d9140cb54b ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: a0aca7b0e13d884f43ba77c4c6d752d9140cb54b

Eliminate find_pc_partial_function_gnu_ifunc

Not used anywhere any longer.

If this is ever reinstated, note that this case:

	  cache_pc_function_is_gnu_ifunc = TYPE_GNU_IFUNC (SYMBOL_TYPE (f));

was incorrect in that regular symbols never have type marked as GNU
ifunc type, only minimal symbols.  At some point I had some fix that
checking the matching minsym here.  But in the end I ended up just
eliminating need for this function, so that fix was not necessary.

gdb/ChangeLog:
2018-04-26  Pedro Alves  <palves@redhat.com>

	* blockframe.c (cache_pc_function_is_gnu_ifunc): Delete.  Remove
	all references.
	(find_pc_partial_function_gnu_ifunc): Rename to ...
	(find_pc_partial_function): ... this, and remove references to
	'is_gnu_ifunc_p'.
	(find_pc_partial_function): Delete old implementation.
	* symtab.h (find_pc_partial_function_gnu_ifunc): Delete.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Breakpoints, don't skip prologue of ifunc resolvers with debug info
@ 2018-04-26 15:18 sergiodj+buildbot
  2018-04-28  2:15 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 15:18 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 76af0f26356580771a18c37de4ebccdfbc449356 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 76af0f26356580771a18c37de4ebccdfbc449356

Breakpoints, don't skip prologue of ifunc resolvers with debug info

Without this patch, some of the tests added to gdb.base/gnu-ifunc.exp
by a following patch fail like so:

  FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=1: resolved_debug=0: set-break: before resolving: break gnu_ifunc
  FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=1: resolved_debug=0: set-break: before resolving: info breakpoints
  FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=1: resolved_debug=0: set-break: after resolving: break gnu_ifunc
  FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=1: resolved_debug=0: set-break: after resolving: info breakpoints
  FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=1: resolved_debug=1: set-break: before resolving: break gnu_ifunc
  FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=1: resolved_debug=1: set-break: before resolving: info breakpoints
  FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=1: resolved_debug=1: set-break: after resolving: break gnu_ifunc
  FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=1: resolved_debug=1: set-break: after resolving: info breakpoints

All of them trigger iff:

 - you have debug info for the ifunc resolver.
 - the resolver and the user-visible symbol have the same name.

If you have an ifunc that has a resolver with the same name as the
user visible symbol, debug info for the resolver masks out the ifunc
minsym.  When you set a breakpoint by name on the user visible symbol,
GDB finds the DWARF symbol for the resolver, and thinking that it's a
regular function, sets a breakpoint location past its prologue.

Like so, location 1.2, before the ifunc is resolved by the inferior:

  (gdb) break gnu_ifunc
  Breakpoint 2 at 0x7ffff7bd36ea (2 locations)
  (gdb) info breakpoints
  Num     Type           Disp Enb Address            What
  1       breakpoint     keep y   <MULTIPLE>
  1.1                         y     0x00007ffff7bd36ea <gnu_ifunc>
  1.2                         y     0x00007ffff7bd36f2 in gnu_ifunc at src/gdb/testsuite/gdb.base/gnu-ifunc-lib.c:34
  (gdb)

And like so, location 2.2, if you set the breakpoint after the ifunc
is resolved by the inferior (to "final"):

  (gdb) break gnu_ifunc
  Breakpoint 5 at 0x400757 (2 locations)
  (gdb) info breakpoints
  Num     Type           Disp Enb Address            What
  2       breakpoint     keep y   <MULTIPLE>
  2.1                         y     0x000000000040075a in final at src/gdb/testsuite/gdb.base/gnu-ifunc-resd.c:21
  2.2                         y     0x00007ffff7bd36f2 in gnu_ifunc at src/gdb/testsuite/gdb.base/gnu-ifunc-lib.c:34
  (gdb)

I don't think this is right because when users set a breakpoint at an
ifunc, they don't care about debugging the resolver.  Instead what you
should is a single location for the ifunc in the first case, and a
single location of the ifunc target in the second case.

gdb/ChangeLog:
2018-04-26  Pedro Alves  <palves@redhat.com>

	* linespec.c (struct bound_minimal_symbol_search_key): New.
	(convert_linespec_to_sals): Sort minimal symbols earlier.  Don't
	skip first line if we found a GNU ifunc minimal symbol by name.
	(compare_msymbols): Change parameters to work with a destructured
	lhs minsym.
	(compare_msymbols_for_qsort, compare_msymbols_for_bsearch): New
	functions.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix setting breakpoints on ifunc functions after they're already resolved
@ 2018-04-26 14:53 sergiodj+buildbot
  2018-04-28  0:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 14:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3467ec66bc1f30cf3ed7f9fe75234c96fc9c92d5 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 3467ec66bc1f30cf3ed7f9fe75234c96fc9c92d5

Fix setting breakpoints on ifunc functions after they're already resolved

This fixes setting breakpoints on ifunc functions by name after the
ifunc has already been resolved.

In that case, if you have debug info for the ifunc resolver, without
the fix, then gdb puts a breakpoint past the prologue of the resolver,
instead of setting a breakpoint at the ifunc target:

  break gnu_ifunc
  Breakpoint 4 at 0x7ffff7bd36f2: file src/gdb/testsuite/gdb.base/gnu-ifunc-lib.c, line 34.
  (gdb) continue
  Continuing.
  [Inferior 1 (process 13300) exited normally]
  (gdb)

above we should have stopped at "final", but didn't because we never
resolved the ifunc to the final location.

If you don't have debug info for the resolver, GDB manages to resolve
the ifunc target, but, it should be setting a breakpoint after the
prologue of the final function, and instead what you get is that GDB
sets a breakpoint on the first address of the target function.  With
the gnu-ifunc.exp tests added by a later patch, we get, without the
fix:

  (gdb) break gnu_ifunc
  Breakpoint 4 at 0x400753
  (gdb) continue
  Continuing.

  Breakpoint 4, final (arg=1) at src/gdb/testsuite/gdb.base/gnu-ifunc-final.c:20
  20	{

vs, fixed:

  (gdb) break gnu_ifunc
  Breakpoint 4 at 0x40075a: file src/gdb/testsuite/gdb.base/gnu-ifunc-final.c, line 21.
  (gdb) continue
  Continuing.

  Breakpoint 4, final (arg=2) at src/gdb/testsuite/gdb.base/gnu-ifunc-final.c:21
  21	  return arg + 1;
  (gdb)

Fix the problems above by moving the ifunc target resolving to
linespec.c, before we skip a function's prologue.  We need to save
something in the sal, so that set_breakpoint_location_function knows
that it needs to create a bp_gnu_ifunc_resolver bp_location.  Might as
well just save a pointer to the minsym.

gdb/ChangeLog:
2018-04-26  Pedro Alves  <palves@redhat.com>

	* breakpoint.c (set_breakpoint_location_function): Don't resolve
	ifunc targets here.  Instead, if we have an ifunc minsym, use its
	address/name.
	(add_location_to_breakpoint): Store the minsym and the objfile in
	the breakpoint location.
	* breakpoint.h (bp_location) <msymbol, objfile>: New fields.
	* linespec.c (minsym_found): Resolve GNU ifunc targets here.
	Record the minsym in the sal.
	* symtab.h (symtab_and_line) <msymbol>: New field.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Calling ifunc functions when resolver has debug info, user symbol same name
@ 2018-04-26 14:33 sergiodj+buildbot
  2018-04-27 19:20 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 14:33 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ca31ab1d675c1e20cee5f8cb213c52e3d7352496 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: ca31ab1d675c1e20cee5f8cb213c52e3d7352496

Calling ifunc functions when resolver has debug info, user symbol same name

If the GNU ifunc resolver has the same name as the user visible
symbol, and the resolver has debug info, then the DWARF info for the
resolver masks the ifunc minsym.  In that scenario, if you try calling
the ifunc from GDB, you call the resolver instead.  With the
gnu-ifunc.exp testcase added in a following patch, you'd see:

  (gdb) p gnu_ifunc (3)
  $1 = (int (*)(int)) 0x400753 <final>
  (gdb) FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=1: resolved_debug=0: p gnu_ifunc (3)
                                                       ^^^^^^^^^^^^^^^^

That is, we called the ifunc resolver manually, which returned a
pointer to the ifunc target function ("final").  The "final" symbol is
the function that GDB should have called automatically,

  ~~~~~~~~~~~~
  int
  final (int arg)
  {
    return arg + 1;
  }
  ~~~~~~~~~

which is what happens if you don't have debug info for the resolver:

  (gdb) p gnu_ifunc (3)
  $1 = 4
  (gdb) PASS: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=0: resolved_debug=1: p gnu_ifunc (3)
                                                       ^^^^^^^^^^^^^^^^

or if the resolver's symbol has a different name from the ifunc (as is
the case with modern uses of ifunc via __attribute__ ifunc, such as
glibc uses):

  (gdb) p gnu_ifunc (3)
  $1 = 4
  (gdb) PASS: gdb.base/gnu-ifunc.exp: resolver_attr=1: resolver_debug=1: resolved_debug=0: p gnu_ifunc (3)
                                      ^^^^^^^^^^^^^^^

in which case after this patch, you can still call the resolver
directly if you want:

  (gdb) p gnu_ifunc_resolver (3)
  $1 = (int (*)(int)) 0x400753 <final>

gdb/ChangeLog:
2018-04-26  Pedro Alves  <palves@redhat.com>

	* c-exp.y (variable production): Prefer ifunc minsyms over
	regular function symbols.
	* symtab.c (find_gnu_ifunc): New function.
	* minsyms.h (lookup_msym_prefer): New enum.
	(lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
	parameter by a lookup_msym_prefer parameter.
	* symtab.h (find_gnu_ifunc): New declaration.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix calling ifunc functions when resolver has debug info and different name
@ 2018-04-26 14:27 sergiodj+buildbot
  2018-04-27 14:50 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 14:27 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a376e11d84ba7ea8cc7333c77043e20c7b0cfc91 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: a376e11d84ba7ea8cc7333c77043e20c7b0cfc91

Fix calling ifunc functions when resolver has debug info and different name

Currently, on Fedora 27 (glibc 2.26), if you try to call strlen in the
inferior you get:

 (gdb) p strlen ("hello")
 $1 = (size_t (*)(const char *)) 0x7ffff554aac0 <__strlen_avx2>

strlen is an ifunc function, and what we see above is the result of
calling the ifunc resolver in the inferior.  That returns a pointer to
the actual target function that implements strlen on my machine.  GDB
should have turned around and called the resolver automatically
without the user noticing.

This is was caused by commit:

  commit bf223d3e808e6fec9ee165d3d48beb74837796de
  Date: Mon Aug 21 11:34:32 2017 +0100

      Handle function aliases better (PR gdb/19487, errno printing)

which added the find_function_alias_target call to c-exp.y, to try to
find an alias with debug info for a minsym.  For ifunc symbols, that
finds the ifunc's resolver if it has debug info (in the example it's
called "strlen_ifunc"), with the result that GDB calls that as a
regular function.

After this commit, we get now get:

  (top-gdb) p strlen ("hello")
  '__strlen_avx2' has unknown return type; cast the call to its declared return type

Which is correct, because __strlen_avx2 is written in assembly.
That'll be improved in a following patch, though.

gdb/ChangeLog:
2018-04-26  Pedro Alves  <palves@redhat.com>

	* c-exp.y (variable production): Skip finding an alias for ifunc
	symbols.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Calling ifunc functions when target has no debug info but resolver has
@ 2018-04-26 13:28 sergiodj+buildbot
  2018-04-27 17:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 13:28 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8388016d7ff8b88d29f2427963f26a6b8bbb03b1 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 8388016d7ff8b88d29f2427963f26a6b8bbb03b1

Calling ifunc functions when target has no debug info but resolver has

After the previous patch, on Fedora 27 (glibc 2.26), if you try
calling strlen in the inferior, you now get:

  (top-gdb) p strlen ("hello")
  '__strlen_avx2' has unknown return type; cast the call to its declared return type

This is correct, because __strlen_avx2 is written in assembly.

We can improve on this though -- if the final ifunc resolved/target
function has no debug info, but the ifunc _resolver_ does have debug
info, we can try extracting the final function's type from the type
that the resolver returns.  E.g.,:

  typedef size_t (*strlen_t) (const char*);

  size_t my_strlen (const char *) { /* some implementation */ }
  strlen_t strlen_resolver (unsigned long hwcap) { return my_strlen; }

  extern size_t strlen (const char *s);
  __typeof (strlen) strlen __attribute__ ((ifunc ("strlen_resolver")));

In the strlen example above, the resolver returns strlen_t, which is a
typedef for pointer to a function that returns size_t.  "strlen_t" is
the type of both the user-visible "strlen", and of the the target
function that implements it.

This patch teaches GDB to extract that type.

This is done for actual inferior function calls (in infcall.c), and
for ptype (in eval_call).  By the time we get to either of these
places, we've already lost the original symbol/minsym, and only have
values and types to work with.  Hence the changes to c-exp.y and
evaluate_var_msym_value, to ensure that we propagate the ifunc
minsymbol's info.

The change to make ifunc symbols have no/unknown return type exposes a
latent problem -- gdb.compile/compile-ifunc.exp calls a no-debug-info
function, but we did not warn about it.  The test is fixed by this
commit too.

gdb/ChangeLog:
2018-04-26  Pedro Alves  <palves@redhat.com>

	* blockframe.c (find_gnu_ifunc_target_type): New function.
	(find_function_type): New.
	* eval.c (evaluate_var_msym_value): For GNU ifunc types, always
	return a value with a memory address.
	(eval_call): For calls to GNU ifunc functions, try to find the
	type of the target function from the type that the resolver
	returns.
	* gdbtypes.c (objfile_type): Don't install a return type for ifunc
	symbols.
	* infcall.c (find_function_return_type): Delete.
	(find_function_addr): Add 'function_type' parameter.  For calls to
	GNU ifunc functions, try to find the type of the target function
	from the type that the resolver returns, and return it via
	FUNCTION_TYPE.
	(call_function_by_hand_dummy): Adjust to use the function type
	returned by find_function_addr.
	(find_function_addr): Add 'function_type' parameter and move
	description here.
	* symtab.h (find_function_type, find_gnu_ifunc_target_type): New
	declarations.

gdb/testsuite/ChangeLog:
2018-04-26  Pedro Alves  <palves@redhat.com>

	* gdb.compile/compile-ifunc.exp: Also expect "function has unknown
	return type" warnings.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix breakpoints in ifunc after inferior resolved it (@got.plt symbol creation)
@ 2018-04-26 12:47 sergiodj+buildbot
  2018-04-27 12:15 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 12:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 02e169e2dac9b0354162eb0e7ee3fc95134b232d ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 02e169e2dac9b0354162eb0e7ee3fc95134b232d

Fix breakpoints in ifunc after inferior resolved it (@got.plt symbol creation)

Setting a breakpoint on an ifunc symbol after the ifunc has already
been resolved by the inferior should result in creating a breakpoint
location at the ifunc target.  However, that's not what happens on
current Fedora:

  (gdb) n
  53        i = gnu_ifunc (1);    /* break-at-call */
  (gdb)
  54        assert (i == 2);
  (gdb) b gnu_ifunc
  Breakpoint 2 at gnu-indirect-function resolver at 0x7ffff7bd36ee
  (gdb) info breakpoints
  Num     Type                   Disp Enb Address            What
  2       STT_GNU_IFUNC resolver keep y   0x00007ffff7bd36ee <gnu_ifunc+4>

The problem is that elf_gnu_ifunc_resolve_by_got never manages to
resolve an ifunc target.  The reason is that GDB never actually
creates the internal got.plt symbols:

 (gdb) p 'gnu_ifunc@got.plt'
 No symbol "gnu_ifunc@got.plt" in current context.

and this is because GDB expects that rela.plt has relocations for
.plt, while it actually has relocations for .got.plt:

 Relocation section [10] '.rela.plt' for section [22] '.got.plt' at offset 0x570 contains 2 entries:
   Offset              Type            Value               Addend Name
   0x0000000000601018  X86_64_JUMP_SLOT 000000000000000000      +0 __assert_fail
   0x0000000000601020  X86_64_JUMP_SLOT 000000000000000000      +0 gnu_ifunc


Using an older system on the GCC compile farm (machine gcc15, an
x86-64 running Debian 6.0.8, with GNU ld 2.20.1), we see that it used
to be that we'd get a .rela.plt section for .plt:

 Relocation section [ 9] '.rela.plt' for section [11] '.plt' at offset 0x578 contains 3 entries:
   Offset              Type            Value               Addend Name
   0x0000000000600cc0  X86_64_JUMP_SLOT 000000000000000000      +0 __assert_fail
   0x0000000000600cc8  X86_64_JUMP_SLOT 000000000000000000      +0 __libc_start_main
   0x0000000000600cd0  X86_64_JUMP_SLOT 000000000000000000      +0 gnu_ifunc

Those offsets did point into .got.plt, as seen with objdump -h:

  20 .got.plt      00000030  0000000000600ca8  0000000000600ca8  00000ca8  2**3
     		   CONTENTS, ALLOC, LOAD, DATA

I also tested on gcc110 on the compile farm (PPC64 running CentOS
7.4.1708, with GNU ld 2.25.1), and there we see instead:

 Relocation section [ 9] '.rela.plt' for section [23] '.plt' at offset 0x5d0 contains 4 entries:
   Offset              Type            Value               Addend Name
   0x0000000010020148  PPC64_JMP_SLOT  000000000000000000      +0 __libc_start_main
   0x0000000010020160  PPC64_JMP_SLOT  000000000000000000      +0 __gmon_start__
   0x0000000010020178  PPC64_JMP_SLOT  000000000000000000      +0 __assert_fail
   0x0000000010020190  PPC64_JMP_SLOT  000000000000000000      +0 gnu_ifunc

But note that those offsets point into .plt, not .got.plt, as seen
with objdump -h:

 22 .plt          00000078  0000000010020130  0000000010020130  00010130  2**3
                  ALLOC

This commit makes us support all the different combinations above.

With that addressed, we now get:

 (gdb) p 'gnu_ifunc@got.plt'
 $1 = (<text from jump slot in .got.plt, no debug info>) 0x400753 <final>

And setting a breakpoint on the ifunc finds the ifunc target:

 (gdb) b gnu_ifunc
 Breakpoint 2 at 0x400753
 (gdb) info breakpoints
 Num     Type           Disp Enb Address            What
 2       breakpoint     keep y   0x0000000000400753 <final>

gdb/ChangeLog:
2018-04-26  Pedro Alves  <palves@redhat.com>

	* elfread.c (elf_rel_plt_read): Look for relocations for .got.plt too.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: x87-related adjustments
@ 2018-04-26 10:29 sergiodj+buildbot
  2018-04-27  1:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-26 10:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0e0eea782025d92f894f6d132aae2507c6a90a7b ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 0e0eea782025d92f894f6d132aae2507c6a90a7b

x86: x87-related adjustments

Neither 287 wrt 8087 nor 387 wrt 287 are proper supersets - in each case
some insns get removed from the ISA (they become NOPs, but code intended
for newer co-processors should not use them).

Furthermore with .no87, ST should not be recognized as a register name.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: fold various non-memory operand AVX512VL templates
@ 2018-04-26  9:03 sergiodj+buildbot
  2018-04-27  9:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-26  9:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e2195274d4a0752459ea89ffbf50b2704fb0c0b4 ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: e2195274d4a0752459ea89ffbf50b2704fb0c0b4

x86: fold various non-memory operand AVX512VL templates

There's little point carrying up to three templates per insn flavor
when the sole difference is operand size and the dependency on AVX512VL
being enabled. Instead the need for AVX512VL can be derived from an
operand allowing for ZMMword as well as one or both or XMMword and
YMMword (irrespective of whether this is a register or memory operand).
Without further abstraction to deal with the different Disp8MemShift
values between the templates, only a limited set (mostly ones only
allowing for non-memory operands) can be folded, which is being done
here.

Also drop IgnoreSize wherever possible from anything that's being
touched anyway.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: CpuXSAVE is a prereq for various other features
@ 2018-04-26  8:36 sergiodj+buildbot
  2018-04-27  7:11 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-26  8:36 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 59ef5df41e8a2addac4c74bb838fe8295cc79ebf ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 59ef5df41e8a2addac4c74bb838fe8295cc79ebf

x86: CpuXSAVE is a prereq for various other features

All of AVX, LWP, MPX, and PKU require XSAVE, and hence it as well as
XRSTOR should be enabled when enabling these ISA extensions. Leverage
these implications to shorten some of the cpu_flag_init[] entries.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: drop CpuRegMMX, CpuReg[XYZ]MM, and CpuRegMask
@ 2018-04-26  8:13 sergiodj+buildbot
  2018-04-27  4:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-26  8:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6e041cf4b0b00e85bee85bee98c411f16bd15747 ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 6e041cf4b0b00e85bee85bee98c411f16bd15747

x86: drop CpuRegMMX, CpuReg[XYZ]MM, and CpuRegMask

It's not clear to me why they had been introduced - the respective
comments in opcodes/i386-gen.c are certainly wrong: ymm<N> registers
are very well supported (and necessary) with just AVX512F.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: drop VexImmExt
@ 2018-04-26  7:04 sergiodj+buildbot
  2018-04-26 23:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-26  7:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2f1bada2dc2e7215cd633b6c39a6c31dbd875bc0 ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 2f1bada2dc2e7215cd633b6c39a6c31dbd875bc0

x86: drop VexImmExt

It's only used in assertions, and hence not really needed for correct
code generation.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [ARM] FDPIC: Make _GLOBAL_OFFSET_TABLE_ a relative symbol
@ 2018-04-26  2:23 sergiodj+buildbot
  2018-04-26 19:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-26  2:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fac7bd6475c4058e7c1e0df29dac50579e427b34 ***

Author: Christophe Lyon <christophe.lyon@st.com>
Branch: master
Commit: fac7bd6475c4058e7c1e0df29dac50579e427b34

[ARM] FDPIC: Make _GLOBAL_OFFSET_TABLE_ a relative symbol

2018-04-25  Christophe Lyon  <christophe.lyon@st.com>
	Mickal Gun  <mickael.guene@st.com>

	bfd/
	* elf32-arm.c (elf32_arm_finish_dynamic_symbol): Handle
	_GLOBAL_OFFSET_TABLE_ in FDPIC mode.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [ARM] FDPIC: Translate R_ARM_TARGET2 relocation into R_ARM_GOT32 relocation for FDPIC platform
@ 2018-04-26  1:48 sergiodj+buildbot
  2018-04-26 16:59 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-26  1:48 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 29e9b073e3b356aae4c249bf3e265b2a608aea6c ***

Author: Christophe Lyon <christophe.lyon@st.com>
Branch: master
Commit: 29e9b073e3b356aae4c249bf3e265b2a608aea6c

[ARM] FDPIC: Translate R_ARM_TARGET2 relocation into R_ARM_GOT32 relocation for FDPIC platform

2018-04-25  Christophe Lyon  <christophe.lyon@st.com>
	Mickal Gun  <mickael.guene@st.com>

	bfd/
	* elf32-arm.c (bfd_elf32_arm_set_target_params): Handle FDPIC case
	for R_ARM_TARGET2.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [ARM] FDPIC: Add stack segment
@ 2018-04-26  1:29 sergiodj+buildbot
  2018-04-26 14:33 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-26  1:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cb10292c2a6c26349c02ec275e4087147fd1cdf0 ***

Author: Christophe Lyon <christophe.lyon@st.com>
Branch: master
Commit: cb10292c2a6c26349c02ec275e4087147fd1cdf0

[ARM] FDPIC: Add stack segment

The size of the stack segment defaults to 32KB, and can be overridden
by defining the __stacksize symbol.

2018-04-25  Christophe Lyon  <christophe.lyon@st.com>
	Mickal Gun  <mickael.guene@st.com>

	bfd/
	* elf32-arm.c (DEFAULT_STACK_SIZE): New.
	(elf32_arm_always_size_sections): Create stack segment.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [ARM] Add TLS relocations for FDPIC.
@ 2018-04-26  0:55 sergiodj+buildbot
  2018-04-26 12:20 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-26  0:55 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5c5a4843ec385a60954fbbc4bcf5b64763639bd3 ***

Author: Christophe Lyon <christophe.lyon@st.com>
Branch: master
Commit: 5c5a4843ec385a60954fbbc4bcf5b64763639bd3

[ARM] Add TLS relocations for FDPIC.

Define and handle TLS relocations for FDPIC in BFD and gas.

In gas, the new relocations are rejected if the --fdpic option was not
specified.

We also define the __tdata_start symbol to mark the start of the
.tdata section. This allows FDPIC static binaries to find the start of
.tdata section, since phdr->p_vaddr of TLS segment is not a valid
value for FDPIC.

2018-04-25  Christophe Lyon  <christophe.lyon@st.com>
	Mickal Gun  <mickael.guene@st.com>

	bfd/:
	* bfd-in2.h (BFD_RELOC_ARM_TLS_GD32_FDPIC)
	(BFD_RELOC_ARM_TLS_LDM32_FDPIC, BFD_RELOC_ARM_TLS_IE32_FDPIC): New
	relocations.
	* elf32-arm.c (elf32_arm_howto_table_2): Add R_ARM_TLS_GD32_FDPIC,
	R_ARM_TLS_LDM32_FDPIC, R_ARM_TLS_IE32_FDPIC relocations.
	(elf32_arm_reloc_map): Add R_ARM_TLS_GD32_FDPIC,
	R_ARM_TLS_LDM32_FDPIC, R_ARM_TLS_IE32_FDPIC.
	(struct elf32_arm_link_hash_table): Update comment.
	(elf32_arm_final_link_relocate): Handle TLS FDPIC relocations.
	(IS_ARM_TLS_RELOC): Likewise.
	(elf32_arm_check_relocs): Likewise.
	(allocate_dynrelocs_for_symbol): Likewise.
	(elf32_arm_size_dynamic_sections): Update comment.
	* reloc.c: Add BFD_RELOC_ARM_TLS_GD32_FDPIC,
	BFD_RELOC_ARM_TLS_LDM32_FDPIC, BFD_RELOC_ARM_TLS_IE32_FDPIC.

	gas/
	* config/tc-arm.c (reloc_names): Add TLSGD_FDPIC, TLSLDM_FDPIC,
	GOTTPOFF_FDIC relocations.
	(md_apply_fix): Handle the new TLS FDPIC relocations.
	(tc_gen_reloc): Likewise.
	(arm_fix_adjustable): Likewise.

	include/
	* elf/arm.h: Add R_ARM_TLS_GD32_FDPIC, R_ARM_TLS_LDM32_FDPIC,
	R_ARM_TLS_IE32_FDPIC.

	ld/
	* scripttempl/elf.sc: Define __tdata_start for .tdata section.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [ARM] Implement PLT for FDPIC.
@ 2018-04-26  0:03 sergiodj+buildbot
  2018-04-26  9:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-26  0:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7801f98f84fefa495941c86e2a859ea8c6c37770 ***

Author: Christophe Lyon <christophe.lyon@st.com>
Branch: master
Commit: 7801f98f84fefa495941c86e2a859ea8c6c37770

[ARM] Implement PLT for FDPIC.

FDPIC requires special PLT entries, defined in this patch.

Note that lazy binding is not supported because of a race condition
for lack of an atomic 64-bits load instruction.

2018-04-25  Christophe Lyon  <christophe.lyon@st.com>
	Mickal Gun  <mickael.guene@st.com>

	bfd/
	* elf32-arm.c (elf32_arm_fdpic_plt_entry): New.
	(elf32_arm_create_dynamic_sections): Handle FDPIC.
	(elf32_arm_allocate_plt_entry): Likewise.
	(elf32_arm_populate_plt_entry): Likewise.
	(elf32_arm_output_plt_map_1): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [ARM] Add FDPIC relocations definitions
@ 2018-04-25 23:02 sergiodj+buildbot
  2018-04-26  4:33 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-25 23:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 188fd7aea619d9f66a822bad881d8f56892b60aa ***

Author: Christophe Lyon <christophe.lyon@st.com>
Branch: master
Commit: 188fd7aea619d9f66a822bad881d8f56892b60aa

[ARM] Add FDPIC relocations definitions

Add FDPIC relocation definitions in BFD and gas.
Gas rejects them if the --fdpic option was not specified.

2018-04-25  Christophe Lyon  <christophe.lyon@st.com>
	Mickal Gun  <mickael.guene@st.com>

	bfd/
	* bfd-in2.c (BFD_RELOC_ARM_GOTFUNCDESC)
	(BFD_RELOC_ARM_GOTOFFFUNCDESC, BFD_RELOC_ARM_FUNCDESC)
	(BFD_RELOC_ARM_FUNCDESC_VALUE): New.
	* elf32-arm.c (elf32_arm_howto_table_2): Add R_ARM_GOTFUNCDESC,
	R_ARM_GOTOFFFUNCDESC, R_ARM_FUNCDESC, R_ARM_FUNCDESC_VALUE.
	(elf32_arm_howto_from_type): Take new members of
	elf32_arm_howto_table_2 into account.
	(elf32_arm_reloc_map): Add BFD_RELOC_ARM_GOTFUNCDESC,
	BFD_RELOC_ARM_GOTOFFFUNCDESC, BFD_RELOC_ARM_FUNCDESC,
	BFD_RELOC_ARM_FUNCDESC_VALUE.
	* reloc.c: Add BFD_RELOC_ARM_GOTFUNCDESC,
	BFD_RELOC_ARM_GOTOFFFUNCDESC, BFD_RELOC_ARM_FUNCDESC,
	BFD_RELOC_ARM_FUNCDESC_VALUE.

	gas/
	* config/tc-arm.c (reloc_names): Add gotfuncdesc, gotofffuncdesc,
	funcdesc.
	(md_apply_fix): Support the new relocations.
	(tc_gen_reloc): Likewise.
	* testsuite/gas/arm/reloc-fdpic.d: New.
	* testsuite/gas/arm/reloc-fdpic.s: New.

	include/
	* elf/arm.h (R_ARM_GOTFUNCDESC, R_ARM_GOTOFFFUNCDESC)
	(R_ARM_FUNCDESC)
	(R_ARM_FUNCDESC_VALUE): Define new relocations.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [ARM] Add FDPIC OSABI flag support.
@ 2018-04-25 22:20 sergiodj+buildbot
  2018-04-26  2:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-25 22:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 18a203380502fb3ee75633fd464faa3c83cec710 ***

Author: Christophe Lyon <christophe.lyon@st.com>
Branch: master
Commit: 18a203380502fb3ee75633fd464faa3c83cec710

[ARM] Add FDPIC OSABI flag support.

ELF files targetting ARM FDPIC use the ELFOSABI_ARM_FDPIC flag.
Set it appropriately in file generators (eg. gas), and handle it in
readers (eg. readelf).

2018-04-25  Christophe Lyon  <christophe.lyon@st.com>
	Mickal Gun  <mickael.guene@st.com>

	bfd/
	* elf32-arm.c (elf32_arm_print_private_bfd_data): Support
	EF_ARM_PIC and ELFOSABI_ARM_FDPIC.
	(elf32_arm_post_process_headers): Support ELFOSABI_ARM_FDPIC.
	(ELF_OSABI): Define to ELFOSABI_ARM_FDPIC.

	binutils/
	* readelf.c (decode_ARM_machine_flags): Support EF_ARM_PIC.
	(get_osabi_name): Support ELFOSABI_ARM_FDPIC.

	gas/
	* config/tc-arm.c (arm_fdpic): New.
	(elf32_arm_target_format): Support FDPIC.
	(OPTION_FDPIC): New.
	(md_longopts): Support FDPIC.
	(md_parse_option): Likewise.
	(md_show_usage): Likewise.

	include/
	* elf/arm.h (EF_ARM_FDPIC): New.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [ARM] Add armelf_linux_fdpiceabi and armelfb_linux_fdpiceabi BFD backends
@ 2018-04-25 21:40 sergiodj+buildbot
  2018-04-25 23:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-25 21:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 617a5ada88c7d4b6aae201ad5b295f3d2ef07c10 ***

Author: Christophe Lyon <christophe.lyon@st.com>
Branch: master
Commit: 617a5ada88c7d4b6aae201ad5b295f3d2ef07c10

[ARM] Add armelf_linux_fdpiceabi and armelfb_linux_fdpiceabi BFD backends

Initial definition of these new backends.

2018-04-25  Christophe Lyon  <christophe.lyon@st.com>
	Mickal Gun  <mickael.guene@st.com>

	bfd/
	* config.bfd (arm*-*-linux-*): Add arm_elf32_fdpic_be_vec and
	arm_elf32_fdpic_le_vec to targ_selvecs. Accept
	arm*-*-uclinuxfdpiceabi.
	* configure.ac: Add support for arm_elf32_fdpic_be_vec and
	arm_elf32_fdpic_le_vec.
	* configure: Regenerate.
	* elf32-arm.c (struct elf32_arm_link_hash_table): Add fdpic_p.
	(elf32_arm_link_hash_table_create): Initialize fdpic_p.
	(TARGET_LITTLE_SYM, TARGET_LITTLE_NAME, TARGET_BIG_SYM)
	(TARGET_BIG_NAME, elf_match_priority): Define for FDPIC targets.
	(elf32_arm_fdpic_link_hash_table_create): New.
	* targets.c (_bfd_target_vector): Add arm_elf32_fdpic_be_vec and
	arm_elf32_fdpic_le_vec.

	ld/
	* Makefile.am (ALL_EMULATION_SOURCES): Add
	earmelf_linux_fdpiceabi.c and earmelfb_linux_fdpiceabi.c.
	(earmelf_linux_fdpiceabi.c, earmelfb_linux_fdpiceabi.c): New rules.
	* Makefile.in: Regenerate.
	* configure.tgt (arm*-*-uclinuxfdpiceabi): Handle new target.
	* emulparams/armelf_linux_fdpiceabi.sh: New.
	* emulparams/armelfb_linux_fdpiceabi.sh: New.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix new inferior events output
@ 2018-04-25 18:28 sergiodj+buildbot
  2018-04-25 20:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-25 18:28 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 249b57335279b1051456884f1a908cdec907f43a ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 249b57335279b1051456884f1a908cdec907f43a

Fix new inferior events output

Since f67c0c917150 ("Enable 'set print inferior-events' and improve
detach/fork/kill/exit messages"), when detaching a remote process, we
get, for detach against a remote target:

 (gdb) detach
 Detaching from program: ...., process 5388
 Ending remote debugging.
 [Inferior 1 (Thread 5388.5388) detached]
              ^^^^^^^^^^^^^^^^

That is incorrect, for it is printing a thread id as string while we
should be printing the process id instead.  I.e., either one of:

 [Inferior 1 (process 5388) detached]
 [Inferior 1 (Remote target) detached]

depending on remote stub support for the multi-process extensions.


Similarly, after killing a process, we're printing thread ids while we
should be printing process ids.  E.g., on native GNU/Linux:

 (gdb) k
 Kill the program being debugged? (y or n) y
 [Inferior 1 (Thread 0x7ffff7faa8c0 (LWP 30721)) has been killed]
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

while it should have been:

 Kill the program being debugged? (y or n) y
 [Inferior 1 (process 30721) has been killed]
              ^^^^^^^^^^^^^

There's a wording inconsistency between detach and kill:

 [Inferior 1 (process 30721) has been killed]
 [Inferior 1 (process 30721) detached]

Given we were already saying "detached" instead of "has been
detached", and we used to say just "exited", and given that the "has
been" doesn't really add any information, this commit changes the
message to just "killed":

 [Inferior 1 (process 30721) killed]

gdb/ChangeLog:
2018-04-25  Pedro Alves  <palves@redhat.com>

	* infcmd.c (kill_command): Print the pid as string, not the whole
	thread's ptid.  Add comment.  s/has been killed/killed/ in output
	message.
	* remote.c (remote_detach_1): Print the pid as string, not the
	whole thread's ptid.

gdb/testsuite/ChangeLog:
2018-04-25  Pedro Alves  <palves@redhat.com>

	* gdb.base/hook-stop.exp: Expect "killed" instead of "has been
	killed".
	* gdb.base/kill-after-signal.exp: Likewise.
	* gdb.threads/kill.exp: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: drop redundant AVX512VL shift templates
@ 2018-04-25 14:49 sergiodj+buildbot
  2018-04-25 18:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-25 14:49 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bacd145775e3ca1a9d1a6d0b65c4ba10b307e167 ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: bacd145775e3ca1a9d1a6d0b65c4ba10b307e167

x86: drop redundant AVX512VL shift templates

These were wrongly left in place by commit ed438a93f1 ("x86: fold
certain AVX512 rotate and shift templates").


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove arm-aout and arm-coff support
@ 2018-04-25  0:47 sergiodj+buildbot
  2018-04-25  8:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-25  0:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2ac93be706418f3b2aebeb22159a328023faed52 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 2ac93be706418f3b2aebeb22159a328023faed52

Remove arm-aout and arm-coff support

This also removes arm-netbsd (not arm-netbsdelf!), arm-openbsd, and
arm-riscix.  Those targets weren't on the obsolete list but they are
all aout, and it doesn't make all that much sense to remove arm-aout
without removing them too.

bfd/
	* Makefile.am: Remove arm-aout and arm-coff support.
	* config.bfd: Likewise.
	* configure.ac: Likewise.
	* targets.c: Likewise.
	* aout-arm.c: Delete.
	* armnetbsd.c: Delete.
	* riscix.c: Delete.
	* Makefile.in: Regenerate.
	* configure: Regenerate.
	* po/SRC-POTFILES.in: Regenerate.
binutils/
	* testsuite/binutils-all/arm/objdump.exp: Remove arm-aout and
	arm-coff support.
	* testsuite/binutils-all/objcopy.exp: Likewise.
	* testsuite/lib/binutils-common.exp: Likewise.
gas/
	* Makefile.am: Remove arm-aout and arm-coff support.
	* config/tc-arm.c: Likewise.
	* config/tc-arm.h: Likewise.
	* configure.tgt: Likewise.
	* testsuite/gas/aarch64/codealign.d: Likewise.
	* testsuite/gas/aarch64/mapping.d: Likewise.
	* testsuite/gas/aarch64/mapping2.d: Likewise.
	* testsuite/gas/arm/adds-thumb1-reloc-local-armv7-m.d: Likewise.
	* testsuite/gas/arm/adds-thumb1-reloc-local.d: Likewise.
	* testsuite/gas/arm/addsw-bad.d: Likewise.
	* testsuite/gas/arm/align.d: Likewise.
	* testsuite/gas/arm/align64.d: Likewise.
	* testsuite/gas/arm/arch7.d: Likewise.
	* testsuite/gas/arm/arch7a-mp.d: Likewise.
	* testsuite/gas/arm/arch7em.d: Likewise.
	* testsuite/gas/arm/archv8m-main-dsp-5.d: Likewise.
	* testsuite/gas/arm/arm-it-auto-2.d: Likewise.
	* testsuite/gas/arm/arm-it-auto-3.d: Likewise.
	* testsuite/gas/arm/arm-it-auto.d: Likewise.
	* testsuite/gas/arm/arm-it-bad-2.d: Likewise.
	* testsuite/gas/arm/arm-it.d: Likewise.
	* testsuite/gas/arm/armv7e-m+fpv5-d16.d: Likewise.
	* testsuite/gas/arm/armv7e-m+fpv5-sp-d16.d: Likewise.
	* testsuite/gas/arm/armv8-2-fp16-scalar-thumb.d: Likewise.
	* testsuite/gas/arm/armv8-2-fp16-scalar.d: Likewise.
	* testsuite/gas/arm/armv8-2-fp16-simd-thumb.d: Likewise.
	* testsuite/gas/arm/armv8-2-fp16-simd.d: Likewise.
	* testsuite/gas/arm/armv8-a+crypto.d: Likewise.
	* testsuite/gas/arm/armv8-a+fp.d: Likewise.
	* testsuite/gas/arm/armv8-a+ras.d: Likewise.
	* testsuite/gas/arm/armv8-a+rdma-warning.d: Likewise.
	* testsuite/gas/arm/armv8-a+rdma.d: Likewise.
	* testsuite/gas/arm/armv8-a+simd.d: Likewise.
	* testsuite/gas/arm/armv8-a-barrier-thumb.d: Likewise.
	* testsuite/gas/arm/armv8-r+fp.d: Likewise.
	* testsuite/gas/arm/armv8-r+simd.d: Likewise.
	* testsuite/gas/arm/armv8-r-barrier-thumb.d: Likewise.
	* testsuite/gas/arm/armv8_1-a+simd.d: Likewise.
	* testsuite/gas/arm/armv8_2+rdma.d: Likewise.
	* testsuite/gas/arm/armv8_2-a.d: Likewise.
	* testsuite/gas/arm/armv8_3-a-fp.d: Likewise.
	* testsuite/gas/arm/armv8_3-a-simd.d: Likewise.
	* testsuite/gas/arm/armv8a-automatic-hlt.d: Likewise.
	* testsuite/gas/arm/armv8a-automatic-lda.d: Likewise.
	* testsuite/gas/arm/attr-syntax.d: Likewise.
	* testsuite/gas/arm/automatic-bw.d: Likewise.
	* testsuite/gas/arm/automatic-cbz.d: Likewise.
	* testsuite/gas/arm/automatic-clrex.d: Likewise.
	* testsuite/gas/arm/automatic-lda.d: Likewise.
	* testsuite/gas/arm/automatic-ldaex.d: Likewise.
	* testsuite/gas/arm/automatic-ldaexb.d: Likewise.
	* testsuite/gas/arm/automatic-ldrex.d: Likewise.
	* testsuite/gas/arm/automatic-ldrexd.d: Likewise.
	* testsuite/gas/arm/automatic-movw.d: Likewise.
	* testsuite/gas/arm/automatic-sdiv.d: Likewise.
	* testsuite/gas/arm/automatic-strexb.d: Likewise.
	* testsuite/gas/arm/barrier-bad-thumb.d: Likewise.
	* testsuite/gas/arm/barrier-bad.d: Likewise.
	* testsuite/gas/arm/barrier-thumb.d: Likewise.
	* testsuite/gas/arm/barrier.d: Likewise.
	* testsuite/gas/arm/bignum1.d: Likewise.
	* testsuite/gas/arm/blx-bad.d: Likewise.
	* testsuite/gas/arm/blx-bl-convert.d: Likewise.
	* testsuite/gas/arm/blx-local.s: Likewise.
	* testsuite/gas/arm/crc32-armv8-a-bad.d: Likewise.
	* testsuite/gas/arm/crc32-armv8-a.d: Likewise.
	* testsuite/gas/arm/crc32-armv8-r-bad.d: Likewise.
	* testsuite/gas/arm/crc32-armv8-r.d: Likewise.
	* testsuite/gas/arm/dis-data.d: Likewise.
	* testsuite/gas/arm/dis-data2.d: Likewise.
	* testsuite/gas/arm/dis-data3.d: Likewise.
	* testsuite/gas/arm/eabi_attr_1.d: Likewise.
	* testsuite/gas/arm/fp-save.d: Likewise.
	* testsuite/gas/arm/group-reloc-alu-encoding-bad.d: Likewise.
	* testsuite/gas/arm/group-reloc-alu-parsing-bad.d: Likewise.
	* testsuite/gas/arm/group-reloc-alu.d: Likewise.
	* testsuite/gas/arm/group-reloc-ldc-encoding-bad.d: Likewise.
	* testsuite/gas/arm/group-reloc-ldc-parsing-bad.d: Likewise.
	* testsuite/gas/arm/group-reloc-ldc.d: Likewise.
	* testsuite/gas/arm/group-reloc-ldr-encoding-bad.d: Likewise.
	* testsuite/gas/arm/group-reloc-ldr-parsing-bad.d: Likewise.
	* testsuite/gas/arm/group-reloc-ldr.d: Likewise.
	* testsuite/gas/arm/group-reloc-ldrs-encoding-bad.d: Likewise.
	* testsuite/gas/arm/group-reloc-ldrs-parsing-bad.d: Likewise.
	* testsuite/gas/arm/group-reloc-ldrs.d: Likewise.
	* testsuite/gas/arm/insn-error-a.d: Likewise.
	* testsuite/gas/arm/insn-error-t.d: Likewise.
	* testsuite/gas/arm/inst-po-2.d: Likewise.
	* testsuite/gas/arm/inst-po-3.d: Likewise.
	* testsuite/gas/arm/inst-po-be.d: Likewise.
	* testsuite/gas/arm/inst-po.d: Likewise.
	* testsuite/gas/arm/ldconst.d: Likewise.
	* testsuite/gas/arm/ldgesb-bad.d: Likewise.
	* testsuite/gas/arm/ldgesh-bad.d: Likewise.
	* testsuite/gas/arm/ldst-offset0.d: Likewise.
	* testsuite/gas/arm/local_function.d: Likewise.
	* testsuite/gas/arm/local_label_coff.d: Likewise.
	* testsuite/gas/arm/local_label_elf.d: Likewise.
	* testsuite/gas/arm/mapping.d: Likewise.
	* testsuite/gas/arm/mapping2.d: Likewise.
	* testsuite/gas/arm/mapping3.d: Likewise.
	* testsuite/gas/arm/mapping4.d: Likewise.
	* testsuite/gas/arm/mapshort-elf.d: Likewise.
	* testsuite/gas/arm/mask_1-armv8-a.d: Likewise.
	* testsuite/gas/arm/mask_1-armv8-r.d: Likewise.
	* testsuite/gas/arm/movs-thumb1-reloc-local-armv7-m.d: Likewise.
	* testsuite/gas/arm/movs-thumb1-reloc-local.d: Likewise.
	* testsuite/gas/arm/movw-local.d: Likewise.
	* testsuite/gas/arm/mrs-msr-thumb-v6t2.d: Likewise.
	* testsuite/gas/arm/mrs-msr-thumb-v7-m.d: Likewise.
	* testsuite/gas/arm/mrs-msr-thumb-v7e-m.d: Likewise.
	* testsuite/gas/arm/msr-imm-bad.d: Likewise.
	* testsuite/gas/arm/msr-reg-bad.d: Likewise.
	* testsuite/gas/arm/msr-reg-thumb.d: Likewise.
	* testsuite/gas/arm/nomapping.d: Likewise.
	* testsuite/gas/arm/nops.d: Likewise.
	* testsuite/gas/arm/pic.d: Likewise.
	* testsuite/gas/arm/pinsn.d: Likewise.
	* testsuite/gas/arm/plt-1.d: Likewise.
	* testsuite/gas/arm/pr21458.d: Likewise.
	* testsuite/gas/arm/pr9722.d: Likewise.
	* testsuite/gas/arm/strex-t.d: Likewise.
	* testsuite/gas/arm/t2-branch-global.d: Likewise.
	* testsuite/gas/arm/target-reloc-1.d: Likewise.
	* testsuite/gas/arm/thumb-b-bad.d: Likewise.
	* testsuite/gas/arm/thumb-w-bad.d: Likewise.
	* testsuite/gas/arm/thumb-w-good.d: Likewise.
	* testsuite/gas/arm/thumb.d: Likewise.
	* testsuite/gas/arm/thumb2_it.d: Likewise.
	* testsuite/gas/arm/thumb2_it_auto.d: Likewise.
	* testsuite/gas/arm/thumb2_it_search.d: Likewise.
	* testsuite/gas/arm/thumb2_ldmstm.d: Likewise.
	* testsuite/gas/arm/thumb2_ldr_immediate_armv6.d: Likewise.
	* testsuite/gas/arm/thumb2_ldr_immediate_armv6t2.d: Likewise.
	* testsuite/gas/arm/thumb2_ldr_immediate_highregs_armv6t2.d: Likewise.
	* testsuite/gas/arm/thumb2_pool.d: Likewise.
	* testsuite/gas/arm/thumb2_vpool.d: Likewise.
	* testsuite/gas/arm/thumb2_vpool_be.d: Likewise.
	* testsuite/gas/arm/thumb32.d: Likewise.
	* testsuite/gas/arm/thumbver.d: Likewise.
	* testsuite/gas/arm/tls.d: Likewise.
	* testsuite/gas/arm/tls_vxworks.d: Likewise.
	* testsuite/gas/arm/undefined.d: Likewise.
	* testsuite/gas/arm/undefined_coff.d: Likewise.
	* testsuite/gas/arm/unwind.d: Likewise.
	* testsuite/gas/arm/v4bx.d: Likewise.
	* testsuite/gas/arm/vcmp-noprefix-imm.d: Likewise.
	* testsuite/gas/arm/vcvt-bad.d: Likewise.
	* testsuite/gas/arm/vfma1.d: Likewise.
	* testsuite/gas/arm/vldconst.d: Likewise.
	* testsuite/gas/arm/vldconst_be.d: Likewise.
	* testsuite/gas/arm/vldm-arm.d: Likewise.
	* testsuite/gas/arm/vldr.d: Likewise.
	* testsuite/gas/arm/weakdef-1.d: Likewise.
	* testsuite/gas/arm/weakdef-2.d: Likewise.
	* config/te-riscix.h: Delete.
	* Makefile.in: Regenerate.
	* po/POTFILES.in: Regenerate.
ld/
	* Makefile.am: Remove arm-aout and arm-coff support.
	* configure.tgt: Likewise.
	* testsuite/ld-arm/attr-merge-div-00.d: Likewise.
	* testsuite/ld-arm/attr-merge-div-01-m3.d: Likewise.
	* testsuite/ld-arm/attr-merge-div-01.d: Likewise.
	* testsuite/ld-arm/attr-merge-div-02.d: Likewise.
	* testsuite/ld-arm/attr-merge-div-10-m3.d: Likewise.
	* testsuite/ld-arm/attr-merge-div-10.d: Likewise.
	* testsuite/ld-arm/attr-merge-div-11.d: Likewise.
	* testsuite/ld-arm/attr-merge-div-12.d: Likewise.
	* testsuite/ld-arm/attr-merge-div-120.d: Likewise.
	* testsuite/ld-arm/attr-merge-div-20.d: Likewise.
	* testsuite/ld-arm/attr-merge-div-21.d: Likewise.
	* testsuite/ld-arm/attr-merge-div-22.d: Likewise.
	* testsuite/ld-arm/attr-merge-hardfp-use-1.d: Likewise.
	* testsuite/ld-arm/attr-merge-hardfp-use-2.d: Likewise.
	* testsuite/ld-arm/attr-merge-nosection-1.d: Likewise.
	* testsuite/ld-arm/attr-merge-unknown-2.d: Likewise.
	* testsuite/ld-arm/attr-merge-unknown-2r.d: Likewise.
	* testsuite/ld-arm/attr-merge-unknown-3.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-1.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-10.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-10r.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-11.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-11r.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-12.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-12r.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-13.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-13r.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-14.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-14r.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-1r.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-2.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-2r.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-3.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-3r.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-4.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-4r.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-5.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-5r.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-6.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-6r.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-7.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-7r.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-8.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-8r.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-9.d: Likewise.
	* testsuite/ld-arm/attr-merge-vfp-9r.d: Likewise.
	* testsuite/ld-arm/attr-merge-wchar-00-nowarn.d: Likewise.
	* testsuite/ld-arm/attr-merge-wchar-00.d: Likewise.
	* testsuite/ld-arm/attr-merge-wchar-02-nowarn.d: Likewise.
	* testsuite/ld-arm/attr-merge-wchar-02.d: Likewise.
	* testsuite/ld-arm/attr-merge-wchar-04-nowarn.d: Likewise.
	* testsuite/ld-arm/attr-merge-wchar-04.d: Likewise.
	* testsuite/ld-arm/attr-merge-wchar-20-nowarn.d: Likewise.
	* testsuite/ld-arm/attr-merge-wchar-20.d: Likewise.
	* testsuite/ld-arm/attr-merge-wchar-22-nowarn.d: Likewise.
	* testsuite/ld-arm/attr-merge-wchar-22.d: Likewise.
	* testsuite/ld-arm/attr-merge-wchar-24-nowarn.d: Likewise.
	* testsuite/ld-arm/attr-merge-wchar-40-nowarn.d: Likewise.
	* testsuite/ld-arm/attr-merge-wchar-40.d: Likewise.
	* testsuite/ld-arm/attr-merge-wchar-42-nowarn.d: Likewise.
	* testsuite/ld-arm/attr-merge-wchar-44-nowarn.d: Likewise.
	* testsuite/ld-arm/attr-merge-wchar-44.d: Likewise.
	* testsuite/ld-arm/eabi-hard-float.d: Likewise.
	* testsuite/ld-arm/eabi-soft-float-ABI4.d: Likewise.
	* testsuite/ld-arm/eabi-soft-float-r.d: Likewise.
	* testsuite/ld-arm/eabi-soft-float.d: Likewise.
	* testsuite/ld-arm/gc-hidden-1.d: Likewise.
	* emulparams/armaoutb.sh: Delete.
	* emulparams/armaoutl.sh: Delete.
	* emulparams/armcoff.sh: Delete.
	* emulparams/armnbsd.sh: Delete.
	* emulparams/riscix.sh: Delete.
	* scripttempl/armaout.sc: Delete.
	* scripttempl/armcoff.sc: Delete.
	* scripttempl/riscix.sc: Delete.
	* Makefile.in: Regenerate.
	* po/BLD-POTFILES.in: Regenerate.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix an illegal memory access when copying a PE format file with corrupt debug information.
@ 2018-04-24 16:07 sergiodj+buildbot
  2018-04-24 23:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-24 16:07 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT aa4a8c2a2a67545e90c877162c53cc9de42dc8b4 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: aa4a8c2a2a67545e90c877162c53cc9de42dc8b4

Fix an illegal memory access when copying a PE format file with corrupt debug information.

	PR 23110
	* peXXigen.c (_bfd_XX_bfd_copy_private_bfd_data_common): Check for
	a negative PE_DEBUG_DATA size before iterating over the debug data.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Prevent an illegal memory access in gprof by ensuring that string tables for aout format files are always zero-terminated.
@ 2018-04-23 12:15 sergiodj+buildbot
  2018-04-23 14:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-23 12:15 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bf82069dce1b1a88560e5d7320342c78372b627e ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: bf82069dce1b1a88560e5d7320342c78372b627e

Prevent an illegal memory access in gprof by ensuring that string tables for aout format files are always zero-terminated.

	PR 23056
	* aoutx.h (aout_get_external_symbols): Allocate an extra byte at
	the end of the string table, and zero it.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Silence gcc-8 warnings
@ 2018-04-23  9:10 sergiodj+buildbot
  2018-04-23 12:14 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-23  9:10 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5a6312e8c015d4a98020038f3b6e144db230f3ca ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 5a6312e8c015d4a98020038f3b6e144db230f3ca

Silence gcc-8 warnings

All of these warnings were false positives.  -Wstringop-truncation is
particularly annoying when it warns about strncpy used quite correctly.

bfd/
	* elf-linux-core.h (swap_linux_prpsinfo32_ugid32_out): Disable
	gcc-8 string truncation warning.
	(swap_linux_prpsinfo32_ugid16_out): Likewise.
	(swap_linux_prpsinfo64_ugid32_out): Likewise.
	(swap_linux_prpsinfo64_ugid16_out): Likewise.
	* elf.c (elfcore_write_prpsinfo): Likewise.
gas/
	* stabs.c (generate_asm_file): Use memcpy rather than strncpy.
	Remove call to strlen inside loop.
	* config/tc-cr16.c (getreg_image): Warning fix.
	* config/tc-crx.c (getreg_image): Warning fix.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Improve on-line help for thread_apply_command and thread_apply_all_command.
@ 2018-04-20 21:47 sergiodj+buildbot
  2018-04-21  9:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-20 21:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5c8f23cdab2a7cde2dae6fcd5f9b18d089efecaf ***

Author: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Branch: master
Commit: 5c8f23cdab2a7cde2dae6fcd5f9b18d089efecaf

Improve on-line help for thread_apply_command and thread_apply_all_command.

Add a Usage: line for thread_apply_command, in particular to mention
the thread ID list.

In thread_apply_command and thread_apply_all_command help, use
uppercase for arg names, as this style seems to be more standard.

2018-04-20  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

	* thread.c (_initialize_thread): improve on-line help for
	thread_apply_command and thread_apply_all_command.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR22978, TLS local-dynamic incorrectly linked on hppa-linux
@ 2018-04-20 14:09 sergiodj+buildbot
  2018-04-20 21:47 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-20 14:09 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4352556b36ab4f1c6f81a0ac3daf4619a419558d ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 4352556b36ab4f1c6f81a0ac3daf4619a419558d

PR22978, TLS local-dynamic incorrectly linked on hppa-linux

We were emitting dynamic relocs on the second word of a TLS GD GOT
entry pair (the dtprel offset), without the addend necessary when no
symbol is present on the dynamic reloc.  Unfortunately the simple
solution of providing the proper addend doesn't work due to an hppa
glibc ld.so bug that ignores such addends.  So instead optimize the
relocs.  The dtprel offset is known at link time for locally defined
symbols (the only case where we'll end up with no symbol on a dynamic
reloc) so we can omit the dynamic reloc in that case.

Furthermore, we can omit a dynamic reloc on the first word of a TLS GD
GOT entry pair (the module id) if the symbol is local and we are
producing an executable.  Similarly, a tprel reloc on a TLS IE GOT
entry is not needed for local symbols in an executable.  So the
condition for TLS GOT relocs can become bfd_link_dll(info) rather than
bfd_link_pic(info) as needed for normal GOT relocs.

This all presumes hppa ld.so doesn't need to differentiate TLS GD GOT
pairs from TLS LD GOT pairs, which is currently true.

	PR 22978
	* elf32-hppa.c (got_relocs_needed): Add extra param to special
	case both dtprel and tprel relocs.
	(allocate_dynrelocs): Adjust conditions for got relocs.
	(elf32_hppa_relocate_section): Likewise for local sym got relocs.
	Emit dynamic relocs on TLS GOT entries for shared libraries,
	not when pic.  Omit dynamic reloc on dtprel entry when local,
	and on tprel entry when local and executable.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix dependency tracking in gdbserver subdirectories
@ 2018-04-19 17:40 sergiodj+buildbot
  2018-04-19 22:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-19 17:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f31c089e788f7b45c9030ac399cd34eb3ccdb9c1 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: f31c089e788f7b45c9030ac399cd34eb3ccdb9c1

Fix dependency tracking in gdbserver subdirectories

The dependency tracking (the thing that knows which source file included
which other source file during last build to know what to rebuild when
an included file changes) is broken for gdbserver subdirectories (arch
and common).

The dependency tracking files are created in the form

  arch/.deps/i386.Po

but we try to include

  .deps/arch/i386.Po

An easy smoke test is too "touch" the gdb/features/i386/32bit-core.c
file in the source directory and try to rebuild gdbserver.  This file is
included by gdb/arch/i386.c, so it should cause
gdb/gdbserver/arch/i386.o in the build directory to be rebuilt.  It
currently isn't rebuilt, but is with this patch applied.

This patch copies the technique used in GDB to transform the dep file
paths to the proper form.

Also, while testing using the depcomp method of dependency tracking (by
just hacking the condition), I noticed that depcomp was not found.  The
path to depcomp seems to be missing a "..".

gdb/gdbserver/ChangeLog:

	* Makefile.in (depcomp): Add "..".
	(all_deps_files): New and use it.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove xml file references from target descriptions
@ 2018-04-18 21:02 sergiodj+buildbot
  2018-04-19 12:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-18 21:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3b74854b8db5836707af828b256c1322a71241b3 ***

Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: 3b74854b8db5836707af828b256c1322a71241b3

Remove xml file references from target descriptions

gdb/
	* common/tdesc.h (tdesc_create_feature): Remove xml filename
	parameter.
	* features/aarch64-core.c (create_feature_aarch64_core):
	Regenerate.
	* features/aarch64-fpu.c (create_feature_aarch64_fpu):
	Likewise.
	* features/i386/32bit-avx.c (create_feature_i386_32bit_avx):
	Likewise.
	* features/i386/32bit-avx512.c
	(create_feature_i386_32bit_avx512): Likewise.
	* features/i386/32bit-core.c (create_feature_i386_32bit_core):
	Likewise.
	* features/i386/32bit-linux.c (create_feature_i386_32bit_linux):
	Likewise.
	* features/i386/32bit-mpx.c (create_feature_i386_32bit_mpx):
	Likewise.
	* features/i386/32bit-pkeys.c (create_feature_i386_32bit_pkeys):
	Likewise.
	* features/i386/32bit-sse.c (create_feature_i386_32bit_sse):
	Likewise.
	* features/i386/64bit-avx.c (create_feature_i386_64bit_avx):
	Likewise.
	* features/i386/64bit-avx512.c
	(create_feature_i386_64bit_avx512): Likewise.
	* features/i386/64bit-core.c (create_feature_i386_64bit_core):
	Likewise.
	* features/i386/64bit-linux.c (create_feature_i386_64bit_linux):
	Likewise.
	* features/i386/64bit-mpx.c (create_feature_i386_64bit_mpx):
	Likewise.
	* features/i386/64bit-pkeys.c (create_feature_i386_64bit_pkeys):
	Likewise.
	* features/i386/64bit-segments.c
	(create_feature_i386_64bit_segments): Likewise.
	* features/i386/64bit-sse.c (create_feature_i386_64bit_sse):
	Likewise.
	* features/i386/x32-core.c
	(create_feature_i386_x32_core): Likewise.
	* features/tic6x-c6xp.c (create_feature_tic6x_c6xp): Likewise.
	* features/tic6x-core.c (create_feature_tic6x_core): Likewise.
	* features/tic6x-gp.c (create_feature_tic6x_gp): Likewise.
	* target-descriptions.c: In generated code, don't pass xml
	filename.

gdbserver/
	* tdesc.c: Remove xml parameter.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add feature reference in .dat files
@ 2018-04-18 20:22 sergiodj+buildbot
  2018-04-19  6:46 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-18 20:22 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ad7fc756d12a841d4b8dd707568426d875e26755 ***

Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: ad7fc756d12a841d4b8dd707568426d875e26755

Add feature reference in .dat files

For all targets which use the newer style target descriptions, add a
"feature" marker in the dat files.
Update regdat.sh to parse feature, but do not use it (yet).

gdb/
	* features/Makefile: Add feature marker to targets with new style
	target descriptions.
	* regformats/aarch64.dat: Regenerate.
	* regformats/i386/amd64-avx-avx512-linux.dat: Likewise.
	* regformats/i386/amd64-avx-linux.dat: Likewise.
	* regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Likewise.
	* regformats/i386/amd64-avx-mpx-linux.dat: Likewise.
	* regformats/i386/amd64-linux.dat: Likewise.
	* regformats/i386/amd64-mpx-linux.dat: Likewise.
	* regformats/i386/amd64.dat: Likewise.
	* regformats/i386/i386-avx-avx512-linux.dat: Likewise.
	* regformats/i386/i386-avx-linux.dat: Likewise.
	* regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Likewise.
	* regformats/i386/i386-avx-mpx-linux.dat: Likewise.
	* regformats/i386/i386-linux.dat: Likewise.
	* regformats/i386/i386-mmx-linux.dat: Likewise.
	* regformats/i386/i386-mpx-linux.dat: Likewise.
	* regformats/i386/i386.dat: Likewise.
	* regformats/i386/x32-avx-avx512-linux.dat: Likewise.
	* regformats/i386/x32-avx-linux.dat: Likewise.
	* regformats/i386/x32-linux.dat: Likewise.
	* regformats/tic6x-c62x-linux.dat: Likewise.
	* regformats/tic6x-c64x-linux.dat: Likewise.
	* regformats/tic6x-c64xp-linux.dat: Likewise.
	* regformats/regdat.sh: Parse feature marker.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Commonise tdesc_feature and makes use of it in gdbserver tdesc
@ 2018-04-18 14:07 sergiodj+buildbot
  2018-04-18 20:00 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-18 14:07 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 82ec9bc7055ca76f1f7dd344f3f58bf6aecec7c8 ***

Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: 82ec9bc7055ca76f1f7dd344f3f58bf6aecec7c8

Commonise tdesc_feature and makes use of it in gdbserver tdesc

gdb/
	* common/tdesc.c (tdesc_feature::accept): Move to here.
	(tdesc_feature::operator==): Likewise.
	(tdesc_create_reg): Likewise.
	* common/tdesc.h (tdesc_type_kind): Likewise.
	(struct tdesc_type): Likewise.
	(struct tdesc_feature): Likewise.
	* regformats/regdat.sh: Create a feature.
	* target-descriptions.c (tdesc_type_kind): Move from here.
	(tdesc_type): Likewise.
	(tdesc_type_up): Likewise.
	(tdesc_feature): Likewise.
	(tdesc_create_reg): Likewise.

gdbserver/
	* tdesc.c (~target_desc): Remove implictly deleted items.
	(init_target_desc): Iterate all features.
	(tdesc_get_features_xml): Use vector.
	(tdesc_create_feature): Create feature.
	* tdesc.h (tdesc_feature) Remove
	(target_desc): Add features.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove mips aout, coff, and pe support
@ 2018-04-18  8:44 sergiodj+buildbot
  2018-04-18 15:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-18  8:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3596d8ceb2cdc35b4fd702ee9daace5a2d880174 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 3596d8ceb2cdc35b4fd702ee9daace5a2d880174

Remove mips aout, coff, and pe support

include/coff/mips.h needs to stay for ecoff debug support.

include/
	* coff/mipspe.h: Delete.
bfd/
	* Makefile.am: Remove mips aout, coff, and pe support.
	* config.bfd: Likewise.
	* configure.ac: Likewise.
	* targets.c: Likewise.
	* coff-mips.c: Delete
	* mipsbsd.c: Delete
	* pe-mips.c: Delete
	* pei-mips.c: Delete
	* Makefile.in: Regenerate.
	* configure: Regenerate.
	* po/SRC-POTFILES.in: Regenerate.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] elf32_bed/elf64_bed
@ 2018-04-18  2:13 sergiodj+buildbot
  2018-04-18 13:33 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-18  2:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8f56f7a23911b6a48b372c8f0893343bfe7ed2e9 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 8f56f7a23911b6a48b372c8f0893343bfe7ed2e9

elf32_bed/elf64_bed


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: Use a normal input file with compatible relocation
@ 2018-04-18  1:33 sergiodj+buildbot
  2018-04-18 11:24 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-18  1:33 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e4e6a73d26ef82622d3bd190749aad508534abe6 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: e4e6a73d26ef82622d3bd190749aad508534abe6

x86: Use a normal input file with compatible relocation

Use a normal input file with compatible relocation to hold linker
created sections,

	PR ld/23055
	* elfxx-x86.c (_bfd_x86_elf_link_setup_gnu_properties): Use a
	normal input file with compatible relocation.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] various i386-aout and i386-coff target removal
@ 2018-04-18  0:23 sergiodj+buildbot
  2018-04-18  8:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-18  0:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c65c21e1ffd1e02d9970a4bca0b7e384788a50f0 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: c65c21e1ffd1e02d9970a4bca0b7e384788a50f0

various i386-aout and i386-coff target removal

Also tidies some other aout leftovers in binutils-common.exp.

bfd/
	* Makefile.am: Remove support for assorted i386 aout and coff targets.
	* config.bfd: Likewise.
	* configure.ac: Likewise.
	* doc/bfdint.texi: Likewise.
	* targets.c: Likewise.
	* freebsd.h: Delete.
	* i386dynix.c: Delete.
	* i386freebsd.c: Delete.
	* i386linux.c: Delete.
	* i386mach3.c: Delete.
	* i386netbsd.c: Delete.
	* i386os9k.c: Delete.
	* Makefile.in: Regenerate.
	* configure: Regenerate.
	* po/SRC-POTFILES.in: Regenerate.
binutils/
	* testsuite/lib/binutils-common.exp: Remove support for assorted
	aout targets.
gas/
	* Makefile.am: Remove support for assorted i386 aout and coff targets.
	* config/obj-elf.c: Likewise.
	* config/tc-i386.h: Likewise.
	* configure.ac: Likewise.
	* configure.tgt: Likewise.
	* config/te-dynix.h: Delete.
	* config/te-i386aix.h: Delete.
	* config/te-mach.h: Delete.
	* Makefile.in: Regenerate.
	* config.in: Regenerate.
	* configure: Regenerate.
	* po/POTFILES.in: Regenerate.
include/
	* aout/dynix3.h: Delete.
ld/
	* Makefile.am: Remove support for assorted i386 aout and coff targets.
	* configure.tgt: Likewise.
	* testsuite/ld-discard/discard.exp: Likewise.
	* testsuite/ld-elf/binutils.exp: Likewise.
	* testsuite/ld-elf/tls.exp: Likewise.
	* testsuite/ld-elf/tls_common.exp: Likewise.
	* testsuite/ld-elfvers/vers.exp: Likewise.
	* testsuite/ld-elfvsb/elfvsb.exp: Likewise.
	* testsuite/ld-elfweak/elfweak.exp: Likewise.
	* testsuite/ld-gc/abi-note.d: Likewise.
	* testsuite/ld-gc/pr19167.d: Likewise.
	* testsuite/ld-gc/pr20022.d: Likewise.
	* testsuite/ld-gc/start.d: Likewise.
	* testsuite/ld-gc/stop.d: Likewise.
	* testsuite/ld-i386/i386.exp: Likewise.
	* testsuite/ld-ifunc/binutils.exp: Likewise.
	* testsuite/ld-ifunc/ifunc.exp: Likewise.
	* testsuite/ld-linkonce/linkonce.exp: Likewise.
	* testsuite/ld-plugin/lto.exp: Likewise.
	* testsuite/ld-scripts/empty-address-2a.d: Likewise.
	* testsuite/ld-scripts/empty-address-2b.d: Likewise.
	* testsuite/ld-scripts/phdrs2.exp: Likewise.
	* testsuite/ld-scripts/section-match-1.d: Likewise.
	* testsuite/ld-shared/shared.exp: Likewise.
	* testsuite/ld-size/size.exp: Likewise.
	* testsuite/ld-sparc/sparc.exp: Likewise.
	* emulparams/i386coff.sh: Delete.
	* emulparams/i386linux.sh: Delete.
	* emulparams/i386mach.sh: Delete.
	* emulparams/i386nbsd.sh: Delete.
	* emulparams/vsta.sh: Delete.
	* scripttempl/i386coff.sc: Delete.
	* Makefile.in: Regenerate.
	* po/BLD-POTFILES.in: Regenerate.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Conditionally drop the discriminant field in quirk_rust_enum
@ 2018-04-17 20:26 sergiodj+buildbot
  2018-04-18  4:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-17 20:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bedda9aced2b3a8ab05e0fbf1372e394e32afbde ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: bedda9aced2b3a8ab05e0fbf1372e394e32afbde

Conditionally drop the discriminant field in quirk_rust_enum

While debugging the crash that Jan reported, I noticed that in some
situations we could end up with a situation where one branch of a Rust
enum type ended up with a field count of -1.

The fix is simple: only conditionally drop the discriminant field when
rewriting the enum variants.

I couldn't find a way to test this; I only noticed it while debugging
the DWARF reader.

2018-04-17  Tom Tromey  <tom@tromey.com>

	* dwarf2read.c (quirk_rust_enum): Conditionally drop the
	discriminant field.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Don't print symbol declaration's line number in rbreak output
@ 2018-04-17 17:52 sergiodj+buildbot
  2018-04-17 23:57 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-17 17:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c7dcbf88c6557f35d9e75ae6223a3e61e1f70578 ***

Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: c7dcbf88c6557f35d9e75ae6223a3e61e1f70578

Don't print symbol declaration's line number in rbreak output

This commit:

  b744723f57 -- Show line numbers in output for "info var/func/type"

adds the symbol declaration's line number to the output of certain GDB
commands.  It also (inadvertently) changes the `rbreak' command's output,
like this:

  (gdb) rbreak foo
  Breakpoint 1 at 0x40049b: file rbreak.c, line 6.
  4:      static int foo1(void);
  Breakpoint 2 at 0x4004b1: file rbreak.c, line 12.
  10:     static int foo2(void);
  (gdb)

where the function declaration is now prefixed by its source line number,
followed by a colon.  But without showing the declaration's file name, the
line number is useless and can possibly cause severe confusion.

No declaration line number was shown before.  Instead, the function
declaration started at the first column:

  (gdb) rbreak foo
  Breakpoint 1 at 0x40049b: file rbreak.c, line 6.
  static int foo1(void);
  Breakpoint 2 at 0x4004b1: file rbreak.c, line 12.
  static int foo2(void);
  (gdb)

This old behavior is restored, fixing some FAILs in fullpath-expand.exp,
realname-expand.exp, and pr10179.exp.

In order to distinguish when to print location information, the meaning of
print_symbol_info()'s parameter `last' is changed.  Now NULL means to skip
any filename or line number information.  Previously NULL meant to always
print the filename.

gdb/ChangeLog:

	* symtab.c (print_symbol_info): Skip printing filename and line
	number when `last' is NULL.
	(symtab_symbol_info): Use empty string instead of NULL for first
	invocation of print_symbol_info.
	(rbreak_command): Pass NULL to `last' parameter of
	print_symbol_info.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Resync libiberty sources with master version in GCC repository.
@ 2018-04-17 13:19 sergiodj+buildbot
  2018-04-17 17:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-17 13:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e9301e762ab6d533f7110d6c9c1dbe8e68e875d7 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: e9301e762ab6d533f7110d6c9c1dbe8e68e875d7

Resync libiberty sources with master version in GCC repository.

2018-04-13  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	PR lto/81968
	* simple-object.c (handle_lto_debug_sections): Keep .comment
	section.

2018-03-02  David Malcolm  <dmalcolm@redhat.com>

	* cp-demangle.c: Update URL for g++ V3 ABI.

2018-01-20  Eli Zaretskii  <eliz@gnu.org>

	* simple-object-xcoff.c (simple_object_xcoff_find_sections): Use
	ulong_type to avoid warning about 32-bit shift.

2018-01-11  Richard Biener  <rguenther@suse.de>
	Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	PR lto/81968
	* simple-object-common.h (struct simple_object_functions):
	Change copy_lto_debug_sections callback signature.
	* simple-object-elf.c (SHN_HIRESERVE, SHT_SYMTAB_SHNDX,
	SHF_INFO_LINK): Add defines.
	(simple_object_elf_copy_lto_debug_sections): Instead of
	leaving not to be copied sections empty unnamed SHT_NULL
	remove them from the target section headers and adjust section
	reference everywhere.  Handle SHN_XINDEX in the symbol table
	processing properly.
	* simple-object.c (handle_lto_debug_sections): Change
	interface to return a modified string and handle renaming
	of relocation sections.

2018-01-10  Daniel van Gerpen  <daniel@vangerpen.de>

	* argv.c (expandargv): Correct check for dynamically
	allocated argv.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Reinstate readelf decoding of i860, i960 and i370 relocs
@ 2018-04-17  3:38 sergiodj+buildbot
  2018-04-17 13:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-17  3:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f954747f10467071b0acde07ee5f5e268ab606a6 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: f954747f10467071b0acde07ee5f5e268ab606a6

Reinstate readelf decoding of i860, i960 and i370 relocs

include/
	* elf/i370.h: Revert removal.
	* elf/i860.h: Likewise.
	* elf/i960.h: Likewise.
binutils
	* readelf.c: Revert 2018-04-16 and 2018-04-11 changes.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] linux_spu_make_corefile_notes: return note_data instead of nullptr
@ 2018-04-16 21:12 sergiodj+buildbot
  2018-04-17 11:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-16 21:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 07d28c777757148d13e429c4463da52cbb50d297 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 07d28c777757148d13e429c4463da52cbb50d297

linux_spu_make_corefile_notes: return note_data instead of nullptr

Since commit

  9018be2 ("Make target_read_alloc & al return vectors")

the test gdb.threads/gcore-stale-thread.exp test results in UNSUPPORTED:

  UNSUPPORTED: gdb.threads/gcore-stale-thread.exp: save a corefile

The problem is that the linux_spu_make_corefile_notes started returning
nullptr when reading TARGET_OBJECT_SPU fails.  The previous (and proper)
behaviour is to return the note_data received as a parameter, so that
other functions may continue to append to this buffer.

With this patch, the test goes back to PASS.

gdb/ChangeLog:

	* linux-tdep.c (linux_spu_make_corefile_notes): Return note_data
	instead of nullptr.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Adjust more test cases to changed output of info var/func/type
@ 2018-04-16 19:20 sergiodj+buildbot
  2018-04-17  8:05 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-16 19:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e3a91079b5e5669567424d3b2f31b48b7b89ef72 ***

Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: e3a91079b5e5669567424d3b2f31b48b7b89ef72

Adjust more test cases to changed output of info var/func/type

After this commit:

  b744723f57 -- Show line numbers in output for "info var/func/type"

the test cases dbx.exp and info-fun.exp yield new FAILs because two
regular expressions have not been adjusted to the changed output yet.
This is fixed.

gdb/testsuite/ChangeLog:

	* gdb.base/dbx.exp (test_whereis): Adjust regexp to added line
	number information in output of "whereis" command.
	* gdb.base/info-fun.exp: Likewise, for "info fun" command.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove h8300-coff support
@ 2018-04-16  9:50 sergiodj+buildbot
  2018-04-16 20:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-16  9:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fe0bf0fd57ea3ef8458d2e8661b428110fc026e2 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: fe0bf0fd57ea3ef8458d2e8661b428110fc026e2

Remove h8300-coff support

include/
	* coff/h8300.h: Delete.
bfd/
	* Makefile.am: Remove h8300-coff support.
	* coffcode.h: Likewise.
	* config.bfd: Likewise.
	* configure.ac: Likewise.
	* reloc16.c: Likewise.
	* targets.c: Likewise.
	* coff-h8300.c: Delete.
	* Makefile.in: Regenerate.
	* configure: Regenerate.
	* po/SRC-POTFILES.in: Regenerate.
binutils/
	* testsuite/binutils-all/objcopy.exp: Remove h8300-coff support.
gas/
	* config/obj-coff.h: Remove h8300-coff support.
	* config/tc-h8300.c: Likewise.
	* config/tc-h8300.h: Likewise.
	* testsuite/gas/h8300/h8300.exp: Likewise.
	* testsuite/gas/h8300/branch-coff.s: Delete.
	* testsuite/gas/h8300/branchh-coff.s: Delete.
	* testsuite/gas/h8300/branchs-coff.s: Delete.
	* testsuite/gas/h8300/ffxx1-coff.d: Delete.
	* testsuite/gas/h8300/ffxx1-coff.s: Delete.
	* testsuite/gas/h8300/h8300-coff.exp: Delete.
ld/
	* Makefile.am: Remove h8300-coff support.
	* configure.tgt: Likewise.
	* testsuite/ld-h8300/h8300.exp: Likewise.
	* emulparams/h8300.sh: Delete.
	* emulparams/h8300h.sh: Delete.
	* emulparams/h8300hn.sh: Delete.
	* emulparams/h8300s.sh: Delete.
	* emulparams/h8300sn.sh: Delete.
	* emulparams/h8300sx.sh: Delete.
	* emulparams/h8300sxn.sh: Delete.
	* scripttempl/h8300.sc: Delete.
	* scripttempl/h8300h.sc: Delete.
	* scripttempl/h8300hn.sc: Delete.
	* scripttempl/h8300s.sc: Delete.
	* scripttempl/h8300sn.sc: Delete.
	* scripttempl/h8300sx.sc: Delete.
	* scripttempl/h8300sxn.sc: Delete.
	* testsuite/ld-h8300/relax-3-coff.d: Delete.
	* testsuite/ld-h8300/relax-4-coff.d: Delete.
	* testsuite/ld-h8300/relax-5-coff.d: Delete.
	* testsuite/ld-h8300/relax-6-coff.d: Delete.
	* Makefile.in: Regenerate.
	* po/BLD-POTFILES.in: Regenerate.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove IEEE 695 object support
@ 2018-04-16  9:17 sergiodj+buildbot
  2018-04-16 18:22 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-16  9:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fdef3943443987525aea4f3ebe1f569f7070fcc8 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: fdef3943443987525aea4f3ebe1f569f7070fcc8

Remove IEEE 695 object support

include/
	* ieee.h: Delete.
bfd/
	* Makefile.am: Remove IEEE 695 support.
	* archures.c: Likewise.
	* bfd.c: Likewise.
	* config.bfd: Likewise.
	* configure.ac: Likewise.
	* doc/bfd.texinfo: Likewise.
	* doc/bfdint.texi: Likewise.
	* doc/bfdsumm.texi: Likewise.
	* section.c: Likewise.
	* targets.c: Likewise.
	* ieee.c: Delete.
	* libieee.h: Delete.
	* Makefile.in: Regenerate.
	* bfd-in2.h: Regenerate.
	* configure: Regenerate.
	* po/SRC-POTFILES.in: Regenerate.
binutils/
	* Makefile.am: Remove IEEE 695 support.
	* budbg.h: Likewise.
	* doc/binutils.texi: Likewise.
	* makefile.vms: Likewise.
	* objcopy.c: Likewise.
	* objdump.c: Likewise.
	* rddbg.c: Likewise.
	* ieee.c: Delete.
	* Makefile.in: Regenerate.
	* po/POTFILES.in: Regenerate.
gas/
	* app.c: Remove IEEE 695 support.
	* symbols.c: Likewise.
ld/
	* ld.texinfo: Remove IEEE 695 support.
	* mri.c: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove tandem support
@ 2018-04-16  8:43 sergiodj+buildbot
  2018-04-16 16:00 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-16  8:43 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT de96689e03235bfd65a33704a9d398cb666140f4 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: de96689e03235bfd65a33704a9d398cb666140f4

Remove tandem support

bfd/
	* config.bfd: Remove tandem support.
ld/
	* Makefile.am: Remove tandem support.
	* configure.tgt: Likewise.
	* emulparams/st2000.sh: Delete.
	* scripttempl/st2000.sc: Delete.
	* Makefile.in: Regenerate.
	* po/BLD-POTFILES.in: Regenerate.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] powerpc common-page-size
@ 2018-04-14  9:25 sergiodj+buildbot
  2018-04-14 16:29 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-14  9:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 702d167134149f420ea3bcbc194d63a2653a0c27 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 702d167134149f420ea3bcbc194d63a2653a0c27

powerpc common-page-size

max-page-size only matters for demand paged executables or shared
libraries, and the ideal size is the largest value used by your
operating system.  Values larger than necessary just waste file space
and memory.  common-page-size also affects file and memory size,
trading a possible small increase in file size for a decrease in
memory size when the operating system is using a common-page-size
page.  With a powerpc max-page-size of 64k and common-page-size of 4k
many executables will use no more memory pages when the system page
size is 4k than an executable linked with -z max-page-size=0x1000,
yet will still run on a system using 64k pages.  However, when running
on a system using 64k pages relro protection will not be completely
effective.

Due to the relro problem, powerpc binutils has been using a default
common-page-size of 64k since 2014-12-18 (git commit 04c6a44c7),
leading to complaints about increased file and memory sizes.  People
not using relro do have a valid reason to complain..

So this patch introduces an extra back-end value to use as the default
for common-page-size when generating relro executables, and enables
the support for powerpc.  Non relro executables will now be generated
with a default common-page-size of 4k.

bfd/
	* elf-bfd.h (struct elf_backend_data): Add relropagesize.
	* elfxx-target.h (ELF_RELROPAGESIZE): Provide default and
	sanity test.
	(elfNN_bed): Init relropagesize.
	* bfd.c (bfd_emul_get_commonpagesize): Add boolean param to
	select relropagesize.
	* elf32-ppc.c (ELF_COMMONPAGESIZE): Define as 0x1000.
	(ELF_RELROPAGESIZE): Define as ELF_MAXPAGESIZE.
	(ELF_MINPAGESIZE): Don't define.
	* elf64-ppc.c (ELF_COMMONPAGESIZE): Define as 0x1000.
	(ELF_RELROPAGESIZE): Define as ELF_MAXPAGESIZE.
	* bfd-in2.h: Regenerate.
ld/
	* ldmain.c (main): Move config.maxpagesize and
	config.commonpagesize initialization to..
	* ldemul.c (after_parse_default): ..here.
	* testsuite/ld-powerpc/ppc476-shared.d: Pass -z common-page-size.
	* testsuite/ld-powerpc/ppc476-shared2.d: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] powerpc max-page-size vs __QNXTARGET__
@ 2018-04-14  9:08 sergiodj+buildbot
  2018-04-14 14:20 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-14  9:08 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 03aa968462e0345b2d846ca240b8c723d713761a ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 03aa968462e0345b2d846ca240b8c723d713761a

powerpc max-page-size vs __QNXTARGET__

The default max-page-size on ppc32 has been 64k since 1995-02-15 (git
commit bcbe2c71).  There was a change committed 2003-07-12 to chose a
4k page if __QNXTARGET__ is defined, but that particular commit was
from an earlier posted patch
https://sourceware.org/ml/binutils/2003-07/msg00211.html that only
made the change effective for arm, rather than the later one
https://sourceware.org/ml/binutils/2003-07/msg00220.html that also
changed powerpc and sh..

Since the __QNXTARGET__ #ifdef in elf32-ppc.c is ineffective unless
the user defines it in his or her CFLAGS, I'm removing that code.

	* elf32-ppc.c (ELF_MAXPAGESIZE, ELF_COMMONPAGESIZE): Don't depend
	on __QNXTARGET__ define.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] powerpc-lynxos and powerpc-windiss fixes
@ 2018-04-14  8:58 sergiodj+buildbot
  2018-04-14 11:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-14  8:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 24acfe5e2b7d4e6c0ccb72ffffc349d7fa88838d ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 24acfe5e2b7d4e6c0ccb72ffffc349d7fa88838d

powerpc-lynxos and powerpc-windiss fixes

Enabling shared lib tests showed the powerpc-lynxos target is broken,
and has been for a long time.  The breakage happened in a 2005-05-07
patch of mine, git commit 3b36f7e62, I think.  There have been no bug
reports I recall so it seems the target is dead.  powerpc-windiss is
similarly broken.

This patch fixes the breakage, and puts the targets on the obsolete
list.

bfd/
	* config.bfd: Add powerpc-*-lynxos* and powerpc-*-windiss*
	to obsolete list.
ld/
	* emulparams/elf32ppcwindiss.sh: Rewrite to use elf32ppc.sh.
	* emulparams/ppclynx.sh: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Show line numbers in output for "info var/func/type"
@ 2018-04-13 17:44 sergiodj+buildbot
  2018-04-13 21:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-13 17:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b744723f571815e6cee43df371c8e733e34e1edf ***

Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: b744723f571815e6cee43df371c8e733e34e1edf

Show line numbers in output for "info var/func/type"

The GDB commands "info variables", "info functions", and "info types" show
the appropriate list of definitions matching the given pattern.  They also
group them by source files.  But no line numbers within these source files
are shown.

The line number information is particularly useful to the user when a
simple "grep" doesn't readily point to a definition.  This is often the
case when the definition involves a macro, occurs within a namespace, or
when the identifier appears very frequently in the source file.

This patch enriches the printout of these commands by the line numbers and
adjusts affected test cases to the changed output where necessary.  The
new output looks like this:

  (gdb) i variables
  All defined variables:

  File foo.c:
  3:	const char * const foo;
  1:	int x;

The line number is followed by a colon and a tab character, which is then
followed by the symbol definition.  If no line number is available, the
tab is printed out anyhow, so definitions line up.

gdb/ChangeLog:

	* symtab.c (print_symbol_info): Precede the symbol definition by
	the line number when available.
	* NEWS: Advertise this enhancement.

gdb/doc/ChangeLog:

	* gdb.texinfo (Symbols): Mention the fact that "info
	variables/functions/types" show source files and line numbers.

gdb/testsuite/ChangeLog:

	* gdb.ada/info_types.exp: Adjust expected output to the line
	numbers now printed by "info var/func/type".
	* gdb.base/completion.exp: Likewise.
	* gdb.base/included.exp: Likewise.
	* gdb.cp/cp-relocate.exp: Likewise.
	* gdb.cp/cplusfuncs.exp: Likewise.
	* gdb.cp/namespace.exp: Likewise.
	* gdb.dwarf2/dw2-case-insensitive.exp: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] btrace: set/show record btrace cpu
@ 2018-04-13 10:21 sergiodj+buildbot
  2018-04-13 19:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-13 10:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4a4495d62d185bdae17ed6aae6ea8249ad07c799 ***

Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: 4a4495d62d185bdae17ed6aae6ea8249ad07c799

btrace: set/show record btrace cpu

Add new set/show commands to set the processor that is used for enabling
errata workarounds when decoding branch trace.

The general format is "<vendor>:<identifier>" but we also allow two
special values "auto" and "none".

The default is "auto", which is the current behaviour of having GDB
determine the processor on which the trace was recorded.

If that cpu is not known to the trace decoder, e.g. when using an old
decoder on a new system, decode may fail with "unknown cpu".  In most
cases it should suffice to 'downgrade' decode to assume an older cpu.
Unfortunately, we can't do this automatically.

The other special value, "none", disables errata workarounds.

gdb/
	* NEWS (New options): announce set/show record btrace cpu.
	* btrace.c: Include record-btrace.h.
	(btrace_compute_ftrace_pt): Skip enabling errata workarounds if
	the vendor is unknown.
	(btrace_compute_ftrace_1): Add cpu parameter.  Update callers.
	Maybe overwrite the btrace configuration's cpu.
	(btrace_compute_ftrace): Add cpu parameter.  Update callers.
	(btrace_fetch): Add cpu parameter.  Update callers.
	(btrace_maint_update_pt_packets): Call record_btrace_get_cpu.
	Maybe overwrite the btrace configuration's cpu.  Skip enabling
	errata workarounds if the vendor is unknown.
	* python/py-record-btrace.c: Include record-btrace.h.
	(recpy_bt_begin, recpy_bt_end, recpy_bt_instruction_history)
	(recpy_bt_function_call_history): Call record_btrace_get_cpu.
	* record-btrace.c (record_btrace_cpu_state_kind): New.
	(record_btrace_cpu): New.
	(set_record_btrace_cpu_cmdlist): New.
	(record_btrace_get_cpu): New.
	(require_btrace_thread, record_btrace_info)
	(record_btrace_resume_thread): Call record_btrace_get_cpu.
	(cmd_set_record_btrace_cpu_none): New.
	(cmd_set_record_btrace_cpu_auto): New.
	(cmd_set_record_btrace_cpu): New.
	(cmd_show_record_btrace_cpu): New.
	(_initialize_record_btrace): Initialize set/show record btrace cpu
	commands.
	* record-btrace.h (record_btrace_get_cpu): New.

testsuite/
	* gdb.btrace/cpu.exp: New.

doc/
	* gdb.texinfo: Document set/show record btrace cpu.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] btrace: fix output of "set record btrace"
@ 2018-04-13  9:59 sergiodj+buildbot
  2018-04-13 14:13 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-13  9:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b85310e1ec0419c4e1ca091cdd48f7597ebbefd3 ***

Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: b85310e1ec0419c4e1ca091cdd48f7597ebbefd3

btrace: fix output of "set record btrace"

Instead of giving a message that "set record btrace" needs a sub-command,
GDB crashed.  Fix it.  A regression test comes with the next patch.

gdb/
	* record-btrace.c (cmd_set_record_btrace): Print sub-commands.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix -D_GLIBCXX_DEBUG gdb-add-index regression
@ 2018-04-12 20:34 sergiodj+buildbot
  2018-04-13  3:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-12 20:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b4be9bfdabb57f40656e72a50a8466af4f7bd37d ***

Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Branch: master
Commit: b4be9bfdabb57f40656e72a50a8466af4f7bd37d

Fix -D_GLIBCXX_DEBUG gdb-add-index regression

Fedora Rawhide started to use -D_GLIBCXX_DEBUG which made gdb-add-index
failing:
	gdb: Out-of-bounds vector access while running gdb-add-index
	https://bugzilla.redhat.com/show_bug.cgi?id=1540559

/usr/include/c++/7/debug/safe_iterator.h:270:
Error: attempt to dereference a past-the-end iterator.
Objects involved in the operation:
    iterator "this" @ 0x0x7fffffffcb90 {
      type = __gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<unsigned char*, std::__cxx1998::vector<unsigned char, gdb::default_init_allocator<unsigned char, std::allocator<unsigned char> > > >, std::__debug::vector<unsigned char, gdb::default_init_allocator<unsigned char, std::allocator<unsigned char> > > > (mutable iterator);
      state = past-the-end;
      references sequence with type 'std::__debug::vector<unsigned char, gdb::default_init_allocator<unsigned char, std::allocator<unsigned char> > >' @ 0x0x7fffffffcc50
    }

/usr/include/c++/7/debug/vector:417:
Error: attempt to subscript container with out-of-bounds index 556, but
container only holds 556 elements.
Objects involved in the operation:
    sequence "this" @ 0x0x2e87af8 {
      type = std::__debug::vector<partial_symbol*, std::allocator<partial_symbol*> >;
    }

The two -D_GLIBCXX_DEBUG regressions were made by:

commit bc8f2430e08cc2a520db49a42686e0529be4a3bc
Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Date:   Mon Jun 12 16:29:53 2017 +0100
    Code cleanup: C++ify .gdb_index producer

commit af5bf4ada48ff65b6658be1fab8f9c8f8ab5f319
Author: Simon Marchi <simon.marchi@ericsson.com>
Date:   Sat Oct 14 08:06:29 2017 -0400
    Replace psymbol_allocation_list with std::vector

gdb/ChangeLog
2018-04-12  Jan Kratochvil  <jan.kratochvil@redhat.com>

	PR gdb/23053
	* dwarf-index-write.c (data_buf::grow) (write_one_signatured_type)
	(recursively_write_psymbols) (debug_names::recursively_write_psymbols)
	(debug_names::write_one_signatured_type): Fix -D_GLIBCXX_DEBUG
	regression.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove old univariant code from rust-lang.c
@ 2018-04-12 19:33 sergiodj+buildbot
  2018-04-13  1:33 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-12 19:33 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 53d7df28bcbaecaf2dca7f8a4bf829e3dd786693 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 53d7df28bcbaecaf2dca7f8a4bf829e3dd786693

Remove old univariant code from rust-lang.c

Since moving Rust enum handling into dwarf2read.c, some old code for
handling univariant enums in rust-lang.c has been obsolete.  This
patch removes this code.

Tested on x86-64 Fedora 26, using rustc 1.23 (1.24 emits incorrect
DWARF for enums and so can't be used for this test).

2018-04-12  Tom Tromey  <tom@tromey.com>

	* rust-lang.c (rust_print_struct_def): Remove univariant code.
	(rust_evaluate_subexp): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix Solaris build
@ 2018-04-12 17:40 sergiodj+buildbot
  2018-04-12 23:24 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-12 17:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 70b33f195b0d76e140921db40c0bea5a7c9abc42 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 70b33f195b0d76e140921db40c0bea5a7c9abc42

Fix Solaris build

This commit fixes a bit of rot in procfs.c caused by recent changes.

Specifically, the target_ops::to_detach change to pass down 'inferior
*' missed updating a forward declation, and the change to use
scoped_fd in more places missed removing one do_cleanups call.

  src/gdb/procfs.c: In function target_ops* procfs_target():
  src/gdb/procfs.c:167:16: error: invalid conversion from void (*)(target_ops*, const char*, int) to void (*)(target_ops*, inferior*, int) [-fpermissive]
     t->to_detach = procfs_detach;
		  ^
  src/gdb/procfs.c: In function ssd* proc_get_LDT_entry(procinfo*, int):
  src/gdb/procfs.c:1624:17: error: old_chain was not declared in this scope
      do_cleanups (old_chain);
		   ^
  src/gdb/procfs.c: At global scope:
  src/gdb/procfs.c:90:13: error: void procfs_detach(target_ops*, const char*, int) declared static but never defined [-Werror=unused-function]
   static void procfs_detach (struct target_ops *, const char *, int);
	       ^
  src/gdb/procfs.c:1923:1: error: void procfs_detach(target_ops*, inferior*, int) defined but not used [-Werror=unused-function]
   procfs_detach (struct target_ops *ops, inferior *inf, int from_tty)
   ^

gdb/ChangeLog:
2018-04-12  Pedro Alves  <palves@redhat.com>

	* procfs.c (procfs_detach): Make forward declaration's prototype
	match definition's protototype.
	(proc_get_LDT_entry): Remove stale do_cleanups call.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] File I/O file handles after target closes
@ 2018-04-11 11:23 sergiodj+buildbot
  2018-04-11 15:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-11 11:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 20db9c52a2073246a5c46a0274569e10b317866f ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 20db9c52a2073246a5c46a0274569e10b317866f

File I/O file handles after target closes

A future patch will propose making the remote target's target_ops be
heap-allocated (to make it possible to have multiple instances of
remote targets, for multiple simultaneous connections), and will
delete/destroy the remote target at target_close time.

That change trips on a latent problem, though.  File I/O handles
remain open even after the target is gone, with a dangling pointer to
a target that no longer exists.  This results in GDB crashing when it
calls the target_ops backend associated with the file handle:

 (gdb) Disconnect
 Ending remote debugging.
 * GDB crashes deferencing a dangling pointer

Backtrace:

   #0  0x00007f79338570a0 in main_arena () at /lib64/libc.so.6
   #1  0x0000000000858bfe in target_fileio_close(int, int*) (fd=1, target_errno=0x7ffe0499a4c8)
       at src/gdb/target.c:2980
   #2  0x00000000007088bd in gdb_bfd_iovec_fileio_close(bfd*, void*) (abfd=0x1a631b0, stream=0x223c9d0)
       at src/gdb/gdb_bfd.c:353
   #3  0x0000000000930906 in opncls_bclose (abfd=0x1a631b0) at src/bfd/opncls.c:528
   #4  0x0000000000930cf9 in bfd_close_all_done (abfd=0x1a631b0) at src/bfd/opncls.c:768
   #5  0x0000000000930cb3 in bfd_close (abfd=0x1a631b0) at src/bfd/opncls.c:735
   #6  0x0000000000708dc5 in gdb_bfd_close_or_warn(bfd*) (abfd=0x1a631b0) at src/gdb/gdb_bfd.c:511
   #7  0x00000000007091a2 in gdb_bfd_unref(bfd*) (abfd=0x1a631b0) at src/gdb/gdb_bfd.c:615
   #8  0x000000000079ed8e in objfile::~objfile() (this=0x2154730, __in_chrg=<optimized out>)
       at src/gdb/objfiles.c:682
   #9  0x000000000079fd1a in objfile_purge_solibs() () at src/gdb/objfiles.c:1065
   #10 0x00000000008162ca in no_shared_libraries(char const*, int) (ignored=0x0, from_tty=1)
       at src/gdb/solib.c:1251
   #11 0x000000000073b89b in disconnect_command(char const*, int) (args=0x0, from_tty=1)
       at src/gdb/infcmd.c:3035

This goes unnoticed in current master, because the current remote
target's target_ops is never destroyed nowadays, so we end up calling:

  remote_hostio_close -> remote_hostio_send_command

which gracefully fails with FILEIO_ENOSYS if remote_desc is NULL
(because the target is closed).

Fix this by invalidating a target's file I/O handles when the target
is closed.

With this change, remote_hostio_send_command no longer needs to handle the
case of being called with a closed remote target, originally added here:
<https://sourceware.org/ml/gdb-patches/2008-08/msg00359.html>.

gdb/ChangeLog:
2018-04-11  Pedro Alves  <palves@redhat.com>

	* target.c (fileio_fh_t::t): Add comment.
	(target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
	(target_fileio_close): Handle a NULL target.
	(invalidate_fileio_fh): New.
	(target_close): Call it.
	* remote.c (remote_hostio_send_command): No longer check whether
	remote_desc is open.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Iterate by index in auto_load_safe_path_vec_update
@ 2018-04-10 21:11 sergiodj+buildbot
  2018-04-10 23:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-10 21:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6e22e10d63addd60f39114cef81ade290b15b2c8 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 6e22e10d63addd60f39114cef81ade290b15b2c8

Iterate by index in auto_load_safe_path_vec_update

As reported by Jan, we get this error when building with -D_GLIBCXX_DEBUG:

/usr/include/c++/7/debug/safe_iterator.h:297:
Error: attempt to increment a singular iterator.
Objects involved in the operation:
    iterator "this" @ 0x0x7fffffffd140 {
      type = __gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<std::unique_ptr<char, gdb::xfree_deleter<char> >*, std::__cxx1998::vector<std::unique_ptr<char, gdb::xfree_deleter<char> >, std::allocator<std::unique_ptr<char, gdb::xfree_deleter<char> > > > >, std::__debug::vector<std::unique_ptr<char, gdb::xfree_deleter<char> >, std::allocator<std::unique_ptr<char, gdb::xfree_deleter<char> > > > > (mutable iterator);
      state = singular;
      references sequence with type 'std::__debug::vector<std::unique_ptr<char, gdb::xfree_deleter<char> >, std::allocator<std::unique_ptr<char, gdb::xfree_deleter<char> > > >' @ 0x0x265db40
    }

The bug was introduced by commit

commit e80aaf6183c6692ecc167bf26cbdc53f8f1a55f0
Author: Simon Marchi <simon.marchi@polymtl.ca>
Date:   Fri Mar 2 23:22:06 2018 -0500
Make delim_string_to_char_ptr_vec return an std::vector

The problem is that we iterate using a range-based for on a vector to
which we push in the loop.  Pushing to the vector invalidates the
iterator used in the loop.  Instead, change the code to iterate by index
as was done in the previous code.

gdb/ChangeLog:

	* auto-load.c (auto_load_safe_path_vec_update): Iterate by
	index.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Adapt and integrate string_view tests
@ 2018-04-09 20:19 sergiodj+buildbot
  2018-04-10  8:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-09 20:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c9638d2669ced9348eac869dadc7be24df85a9a8 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: c9638d2669ced9348eac869dadc7be24df85a9a8

Adapt and integrate string_view tests

The previous patch copied the string_view tests from libstdc++.  This
patch adjusts them in a similar way that the libstdc++ optional tests
are integrated in our unit test suite.

Not all tests are used, some of them require language features not
present in c++11.  For example, we can't use a string_view constructor
where the length is not explicit in a constexpr, because
std::char_traits::length is not a constexpr itself (it is in c++17
though).  Nevertheless, a good number of tests are integrated, which
covers pretty well the string_view features.

gdb/ChangeLog:

	* Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
	string_view-selftests.c.
	* unittests/basic_string_view/capacity/1.cc: Adapt to GDB
	testsuite.
	* unittests/basic_string_view/cons/char/1.cc: Likewise.
	* unittests/basic_string_view/cons/char/2.cc: Likewise.
	* unittests/basic_string_view/cons/char/3.cc: Likewise.
	* unittests/basic_string_view/element_access/char/1.cc:
	Likewise.
	* unittests/basic_string_view/element_access/char/empty.cc:
	Likewise.
	* unittests/basic_string_view/element_access/char/front_back.cc:
	Likewise.
	* unittests/basic_string_view/inserters/char/2.cc: Likewise.
	* unittests/basic_string_view/modifiers/remove_prefix/char/1.cc:
	Likewise.
	* unittests/basic_string_view/modifiers/remove_suffix/char/1.cc:
	Likewise.
	* unittests/basic_string_view/modifiers/swap/char/1.cc:
	Likewise.
	* unittests/basic_string_view/operations/compare/char/1.cc:
	Likewise.
	* unittests/basic_string_view/operations/compare/char/13650.cc:
	Likewise.
	* unittests/basic_string_view/operations/copy/char/1.cc:
	Likewise.
	* unittests/basic_string_view/operations/data/char/1.cc:
	Likewise.
	* unittests/basic_string_view/operations/find/char/1.cc:
	Likewise.
	* unittests/basic_string_view/operations/find/char/2.cc:
	Likewise.
	* unittests/basic_string_view/operations/find/char/3.cc:
	Likewise.
	* unittests/basic_string_view/operations/find/char/4.cc:
	Likewise.
	* unittests/basic_string_view/operations/rfind/char/1.cc:
	Likewise.
	* unittests/basic_string_view/operations/rfind/char/2.cc:
	Likewise.
	* unittests/basic_string_view/operations/rfind/char/3.cc:
	Likewise.
	* unittests/basic_string_view/operations/substr/char/1.cc:
	Likewise.
	* unittests/basic_string_view/operators/char/2.cc: Likewise.
	* unittests/string_view-selftests.c: New file.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Use an std::vector for inline_states
@ 2018-04-09 20:08 sergiodj+buildbot
  2018-04-10 12:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-09 20:08 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b24531ed171b5751a3a64c461728c9ad62092c8a ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: b24531ed171b5751a3a64c461728c9ad62092c8a

Use an std::vector for inline_states

This patch replaces VEC(inline_state) with std::vector<inline_state> and
adjusts the code that uses it.

gdb/ChangeLog:

	* common/gdb_vecs.h (unordered_remove): Add overload that takes
	an iterator.
	* inline-frame.c: Include <algorithm>.
	(struct inline_state): Add constructor.
	(inline_state_s): Remove.
	(DEF_VEC_O(inline_state_s)): Remove.
	(inline_states): Change type to std::vector.
	(find_inline_frame_state): Adjust to std::vector.
	(allocate_inline_frame_state): Remove.
	(clear_inline_frame_state): Adjust to std::vector.
	(skip_inline_frames): Adjust to std::vector.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove VEC(tsv_s), use std::vector instead
@ 2018-04-09 19:54 sergiodj+buildbot
  2018-04-10  9:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-09 19:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c252925ccc8c3c2ce2a65d12a50acfee53914ce3 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: c252925ccc8c3c2ce2a65d12a50acfee53914ce3

Remove VEC(tsv_s), use std::vector instead

This patch removes VEC(tsv_s), using an std::vector instead.  I C++ified
trace_state_variable a bit in the process, using std::string for the
name.  I also thought it would be nicer to pass a const reference to
target_download_trace_state_variable, since we know it will never be
NULL.  This highlighted that the make-target-delegates script didn't
handle references well, so I adjusted this as well.  It will surely be
useful in the future.

gdb/ChangeLog:

	* tracepoint.h (struct trace_state_variable): Add constructor.
	<name>: Change type to std::string.
	* tracepoint.c (tsv_s): Remove.
	(DEF_VEC_O(tsv_s)): Remove.
	(tvariables): Change to std::vector.
	(create_trace_state_variable): Adjust to std::vector.
	(find_trace_state_variable): Likewise.
	(find_trace_state_variable_by_number): Likewise.
	(delete_trace_state_variable): Likewise.
	(trace_variable_command): Adjust to std::string.
	(delete_trace_variable_command): Likewise.
	(tvariables_info_1): Adjust to std::vector.
	(save_trace_state_variables): Likewise.
	(start_tracing): Likewise.
	(merge_uploaded_trace_state_variables): Adjust to std::vector
	and std::string.
	* target.h (struct target_ops)
	<to_download_trace_state_variable>: Pass reference to
	trace_state_variable.
	* target-debug.h (target_debug_print_const_trace_state_variable_r): New.
	* target-delegates.c: Re-generate.
	* mi/mi-interp.c (mi_tsv_created): Adjust to std::string.
	(mi_tsv_deleted): Likewise.
	* mi/mi-main.c (mi_cmd_trace_frame_collected): Likewise.
	* remote.c (remote_download_trace_state_variable): Change
	pointer to reference and adjust.
	* make-target-delegates (parse_argtypes): Handle references.
	(write_function_header): Likewise.
	(munge_type): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add gdb::string_view
@ 2018-04-09 19:11 sergiodj+buildbot
  2018-04-10  5:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-09 19:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8345c4a2670711eafd41c8b6a8726cf8b0771d6e ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 8345c4a2670711eafd41c8b6a8726cf8b0771d6e

Add gdb::string_view

We had a few times the need for a data structure that does essentially
what C++17's std::string_view does, which is to give an std::string-like
interface (only the read-only operations) to an arbitrary character
buffer.

This patch adapts the files copied from libstdc++ by the previous patch
to integrate them with GDB.  Here's a summary of the changes:

  * Remove things related to wstring_view, u16string_view and
  u32string_view (I don't think we need them, but we can always add them
  later).

  * Remove usages of _GLIBCXX_BEGIN_NAMESPACE_VERSION and
  _GLIBCXX_END_NAMESPACE_VERSION.

  * Put the code in the gdb namespace.  I had to add a few "std::" in
  front of std type usages.

  * Change __throw_out_of_range_fmt() for error().

  * Make gdb::string_view an alias of std::string_view when building
  with >= c++17.

  * Remove a bunch of constexpr, because they are not valid in c++11
  (e.g. they are not a single return line).

  * Use std::common_type<_Tp>::type instead of std::common_type_t<_Tp>,
  because c++11 doesn't have the later.

  * Remove the #pragma GCC system_header, since that silences some
  warnings that we might want to have if we're doing something not
  correctly.

  * Remove operator ""sv.  It would need a lot of work to make all
  supported compilers happy, and we can easily live without it.

  * Remove operator<<.  It is implemented using __ostream_insert (a
  libstdc++ internal).  Bringing it in might be possible, but I don't
  think that would be worth the effort, since we don't really use
  streams at the moment.

  * Replace internal libstdc++ asserts ( __glibcxx_assert and
  __glibcxx_requires_string_len) with gdb_assert.

  * Remove hash helpers, because they use libstdc++ internal functions.
  If we need them we always import them later.

The string_view class in cli/cli-script.c is removed and its usage
replaced with the new gdb::string_view.

gdb/ChangeLog:

	* common/gdb_string_view.h: Remove libstdc++ implementation
	details, adjust to gdb reality.
	* common/gdb_string_view.tcc: Likewise.
	* cli/cli-script.c (struct string_view): Remove.
	(user_args) <m_args>: Change element type to gdb::string_view.
	(user_args::insert_args): Adjust.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Update ax_cv_cxx_compile_cxx.m4
@ 2018-04-09 18:41 sergiodj+buildbot
  2018-04-10  2:45 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-09 18:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 41260ac25d541d9bdd039a0ce82c9ad31fceed35 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 41260ac25d541d9bdd039a0ce82c9ad31fceed35

Update ax_cv_cxx_compile_cxx.m4

This file provides the AX_CXX_COMPILE_STDCXX macro.  In the context of
the following patch, I wanted to build and test GDB in c++17 mode.  The
version of the macro we have in the repo does not support detecting
c++17 compilers, but the upstream version has been updated to do so.

Since we have local modifications to the file, I had to reconcile our
modifications and the updated upstream version (which was relatively
straightforward).

gdb/ChangeLog:

	* ax_cxx_compile_stdcxx.m4: Sync with upstream.
	* configure: Re-generate.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Apply "Convert observers to C++" edit to gdbarch.sh
@ 2018-04-09 15:13 sergiodj+buildbot
  2018-04-10  1:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-09 15:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0bee6dd4aa42b928c2a7a496596490b694e5722b ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 0bee6dd4aa42b928c2a7a496596490b694e5722b

Apply "Convert observers to C++" edit to gdbarch.sh

Regenerating gdbarch.c results in:

  --- gdbarch.c   2018-03-26 23:18:52.905548891 +0100
  +++ new-gdbarch.c       2018-04-09 15:32:30.006712207 +0100
  @@ -44,7 +44,7 @@
   #include "reggroups.h"
   #include "osabi.h"
   #include "gdb_obstack.h"
  -#include "observable.h"
  +#include "observer.h"
   #include "regcache.h"
   #include "objfiles.h"
   #include "auxv.h"
  @@ -5457,7 +5457,7 @@
     gdb_assert (new_gdbarch != NULL);
     gdb_assert (new_gdbarch->initialized_p);
     current_inferior ()->gdbarch = new_gdbarch;
  -  gdb::observers::architecture_changed.notify (new_gdbarch);
  +  observer_notify_architecture_changed (new_gdbarch);
     registers_changed ();
   }


Clearly commit 76727919ceb5 ("Convert observers to C++") edited
gdbarch.c directly instead of gdbarch.sh.  This fixes it.

gdb/ChangeLog:
2018-04-09  Pedro Alves  <palves@redhat.com>

	* gdbarch.sh: Include "observable.h" instead of "observer.h".
	(set_target_gdbarch): Call
	gdb::observers::architecture_changed.notify instead of
	observer_notify_architecture_changed.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] MIPS64/BFD: Fix a crash with STN_UNDEF in relocation
@ 2018-04-09 13:12 sergiodj+buildbot
  2018-04-09 23:54 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-09 13:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT aec2e0d252342aa7575aff608e999a36f27a9147 ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: aec2e0d252342aa7575aff608e999a36f27a9147

MIPS64/BFD: Fix a crash with STN_UNDEF in relocation

Prevent a null BFD pointer dereference and a resulting segmentation
fault in `mips_elf64_write_rel' or `mips_elf64_write_rela':

Program received signal SIGSEGV, Segmentation fault.
0x0000000000437690 in mips_elf64_write_rela (abfd=0x71e130, sec=0x720700,
    rela_hdr=0x721ff8, count=0x7fffffffb82c, data=0x7fffffffb88c)
    at .../bfd/elf64-mips.c:4123
4123	      if ((*ptr->sym_ptr_ptr)->the_bfd->xvec != abfd->xvec
4124		  && ! _bfd_elf_validate_reloc (abfd, ptr))

in the MIPS64 (n64 MIPS) ELF backend whenever the STN_UNDEF symbol index
is retrieved from the `r_sym' field of a relocation seen in input while
running `objcopy' or `strip'.  The reason for the null BFD pointer is
that internally in BFD an STN_UNDEF symbol reference resolves to an
absolute zero symbol that does not have a BFD associated.  Check the
pointer then before using it, like the generic ELF backend does in
`elf_write_relocs'.

This complements the same change made for generic ELF bundled with:

commit e35765a9a2eaff0df62757f3e6480c8ba5ab8ee8
Author: Ian Lance Taylor <ian@airs.com>
Date:   Sun Dec 15 19:59:18 1996 +0000

which (obviously due to a CVS -> GIT repository conversion inaccuracy)
seems to be one corresponding to this ChangeLog entry:

	* elfcode.h (write_relocs): Handle absolute symbol.

from:

commit c86158e591edd8450f49f8cd75f82e4313d4b6d8
Author: Ian Lance Taylor <ian@airs.com>
Date:   Fri Aug 30 22:09:51 1996 +0000

("Add SH ELF support."), which also updated RELA only and not REL (which
has been since fixed with: commit 947216bf8f34 ("ELF reloc code tidy"),
<https://sourceware.org/ml/binutils/2002-11/msg00727.html>).

	bfd/
	* elf64-mips.c (mips_elf64_write_rel): Handle a NULL BFD pointer
	in the BFD symbol referred by the relocation.
	(mips_elf64_write_rela): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PowerPC inline PLT call support
@ 2018-04-09 11:16 sergiodj+buildbot
  2018-04-09 19:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-09 11:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 23cedd1dc90d05c4b80d4a4b000ed5f37b9c3268 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 23cedd1dc90d05c4b80d4a4b000ed5f37b9c3268

PowerPC inline PLT call support

In addition to the existing relocs we need two more to mark all
instructions in the call sequence, PLTCALL on the call itself (plus
the toc restore insn for ppc64), and PLTSEQ on others.  All
relocations in a particular sequence have the same symbol.

Example ppc64 ELFv2 assembly:
 .reloc .,R_PPC64_PLTSEQ,puts
	std 2,24(1)
	addis 12,2,puts@plt@ha	# .reloc .,R_PPC64_PLT16_HA,puts
	ld 12,puts@plt@l(12)	# .reloc .,R_PPC64_PLT16_LO_DS,puts
 .reloc .,R_PPC64_PLTSEQ,puts
	mtctr 12
 .reloc .,R_PPC64_PLTCALL,puts
	bctrl
	ld 2,24(1)

Example ppc32 -fPIC assembly:
	addis 12,30,puts+32768@plt@ha # .reloc .,R_PPC_PLT16_HA,puts+0x8000
	lwz 12,12,puts+32768@plt@l    # .reloc .,R_PPC_PLT16_LO,puts+0x8000
 .reloc .,R_PPC_PLTSEQ,puts+32768
	mtctr 12
 .reloc .,R_PPC_PLTCALL,puts+32768
	bctrl

Marking sequences like this allows the linker to convert them to nops
and a direct call if the target symbol turns out to be local.

When the call is __tls_get_addr, each relocation shown above is paired
with an R_PPC*_TLSLD or R_PPC*_TLSGD reloc to additionally mark the
sequence for possible TLS optimization.  The TLSLD or TLSGD relocs are
emitted first.

include/
	* elf/ppc.h (R_PPC_PLTSEQ, R_PPC_PLTCALL): Define.
	* elf/ppc64.h (R_PPC64_PLTSEQ, R_PPC64_PLTCALL): Define.
bfd/
	* elf32-ppc.c (ppc_elf_howto_raw): Add PLTSEQ and PLTCALL howtos.
	(is_plt_seq_reloc): New function.
	(ppc_elf_check_relocs): Handle PLTSEQ and PLTCALL relocs.
	(ppc_elf_tls_optimize): Handle inline plt call sequence.
	(ppc_elf_relax_section): Handle PLTCALL reloc.
	(ppc_elf_relocate_section): Nop out inline plt call sequence when
	resolving locally.
	* elf64-ppc.c (ppc64_elf_howto_raw): Add R_PPC64_PLTSEQ and
	R_PPC64_PLTCALL entries.  Comment R_PPC64_TOCSAVE.
	(has_tls_get_addr_call): Correct comment.
	(is_branch_reloc): Add PLTCALL.
	(is_plt_seq_reloc): New function.
	(ppc64_elf_check_relocs): Handle PLT16_LO_DS reloc.  Set
	has_tls_reloc for R_PPC64_TLSGD and R_PPC64_TLSLD.  Create plt
	entry for R_PPC64_PLTCALL.
	(ppc64_elf_tls_optimize): Handle inline plt call sequence.
	(ppc_type_of_stub): Handle PLTCALL reloc.
	(toc_adjusting_stub_needed): Likewise.
	(ppc64_elf_relocate_section): Set "can_plt_call" for PLTCALL
	reloc insn.  Nop out inline plt call sequence when resolving
	locally.  Handle __tls_get_addr inline plt call optimization.
elfcpp/
	* powerpc.h (R_POWERPC_PLTSEQ, R_POWERPC_PLTCALL): Define.
gold/
	* powerpc.cc (Target_powerpc::Track_tls::maybe_skip_tls_get_addr_call):
	Handle inline plt sequence relocs.
	(Stub_table::Plt_stub_key::Plt_stub_key): Likewise.
	(Target_powerpc::Scan::reloc_needs_plt_for_ifunc): Likewise.
	(Target_powerpc::Relocate::relocate): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Support PLT16 relocs against local symbols
@ 2018-04-09  9:17 sergiodj+buildbot
  2018-04-09 17:03 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-09  9:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2d7ad24e8726ba4c45c9e67be08223a146a837ce ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 2d7ad24e8726ba4c45c9e67be08223a146a837ce

Support PLT16 relocs against local symbols

Necessary if gcc is to use PLT16 relocs to implement -mlongcall, and
there isn't a good technical reason why local symbols should be
excluded from PLT16 support.  Non-ifunc local symbol PLT entries go in
a separate section to other PLT entries.  In a fixed position
executable they won't need to be relocated, and in a PIE or shared
library I chose to not implement lazy relocation.

bfd/
	* elf64-ppc.c (LOCAL_PLT_ENTRY_SIZE): Define.
	(struct ppc_stub_hash_entry): Add symtype field.
	(PLT_KEEP): Define.
	(struct ppc_link_hash_table): Add pltlocal and relpltlocal.
	(create_linkage_sections): Create pltlocal and relpltlocal.
	(ppc64_elf_check_relocs): Allow PLT relocs on local symbols.
	Set PLT_KEEP.
	(ppc64_elf_adjust_dynamic_symbol): Keep PLT entries for inline calls.
	(allocate_dynrelocs): Allocate pltlocal and relpltlocal.
	(ppc64_elf_size_dynamic_sections): Size pltlocal and relpltlocal.
	Keep PLT entries for inline calls against locals.
	(ppc_build_one_stub): Use pltlocal as appropriate.
	(ppc_size_one_stub): Likewise.
	(ppc64_elf_size_stubs): Set symtype.
	(build_global_entry_stubs_and_plt): Init pltlocal and write
	relpltlocal for globals.
	(write_plt_relocs_for_local_syms): Likewise for local syms.
	(ppc64_elf_relocate_section): Support PLT for local syms.
	* elf32-ppc.c (PLT_KEEP): Define.
	(struct ppc_elf_link_hash_table): Add pltlocal and relpltlocal.
	(ppc_elf_create_glink): Create pltlocal and relpltlocal.
	(ppc_elf_check_relocs): Allow PLT relocs on local symbols.
	Set PLT_KEEP.  Adjust update_local_sym_info call.
	(ppc_elf_adjust_dynamic_symbol): Keep PLT entries for inline calls.
	(allocate_dynrelocs): Allocate pltlocal and relpltlocal.
	(ppc_elf_size_dynamic_sections): Size pltlocal and relpltlocal.
	(ppc_elf_relocate_section): Support PLT16 relocs for local syms.
	(write_global_sym_plt): Init pltlocal and write relpltlocal.
	(ppc_finish_symbols): Likewise for locals.
ld/
	* emulparams/elf32ppc.sh (OTHER_RELRO_SECTIONS_2): Add .branch_lt.
	(OTHER_GOT_RELOC_SECTIONS): Add .rela.branch_lt.
	* testsuite/ld-powerpc/elfv2so.d: Update for symbol/stub reordering.
	* testsuite/ld-powerpc/relbrlt.d: Likewise.
	* testsuite/ld-powerpc/relbrlt.s: Likewise.
	* testsuite/ld-powerpc/tlsso.r: Likewise.
	* testsuite/ld-powerpc/tlstocso.r: Likewise.
gold/
	* powerpc.cc (Target_powerpc::lplt_): New variable.
	(Target_powerpc::lplt_section): Associated accessor.
	(Target_powerpc::plt_off): Handle local non-ifunc symbols.
	(Target_powerpc::make_lplt_section): New function.
	(Target_powerpc::make_local_plt_entry): New function.
	(Powerpc_relobj::do_relocate_sections): Write out lplt.
	(Output_data_plt_powerpc::first_plt_entry_offset): Zero for lplt.
	(Output_data_plt_powerpc::add_local_entry): New function.
	(Output_data_plt_powerpc::do_write): Ignore lplt.
	(Target_powerpc::make_iplt_section): Make lplt first.
	(Target_powerpc::make_brlt_section): Make .branch_lt relro.
	(Target_powerpc::Scan::local): Handle PLT16 relocs.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Rearrange PLT reloc output on powerpc
@ 2018-04-09  9:03 sergiodj+buildbot
  2018-04-09 14:29 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-09  9:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 49c09209d06885dc8350042ce77e442bfbb5bf27 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 49c09209d06885dc8350042ce77e442bfbb5bf27

Rearrange PLT reloc output on powerpc

The current scheme where we output PLT relocs for global symbols in
finish_dynamic_symbol, and PLT relocs for local symbols when
outputting stubs does not work if PLT entries are to be used for
inline PLT sequences against non-dynamic globals or local symbols.

bfd/
	* elf64-ppc.c (ppc_build_one_stub): Move output of PLT relocs
	for local symbols to..
	(write_plt_relocs_for_local_syms): ..here.  New function.
	(ppc64_elf_finish_dynamic_symbol): Move output of PLT relocs for
	global symbols to..
	(build_global_entry_stubs_and_plt): ..here.  Rename from
	build_global_entry_stubs.
	(ppc64_elf_build_stubs): Always call build_global_entry_stubs_and_plt.
	Call write_plt_relocs_for_local_syms.
	* elf32-ppc.c (get_sym_h): New function.
	(ppc_elf_relax_section): Use get_sym_h.
	(ppc_elf_relocate_section): Move output of PLT relocs and glink
	stubs for local symbols to..
	(ppc_finish_symbols): ..here.  New function.
	(ppc_elf_finish_dynamic_symbol): Move output of PLT relocs for
	global syms to..
	(write_global_sym_plt): ..here.  New function.
	* elf32-ppc.h (ppc_elf_modify_segment_map): Delete attribute.
	(ppc_finish_symbols): Declare.
ld/
	* ppc32elf.em (ppc_finish): Call ppc_finish_symbols.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Replace dw2_get_cu/dw2_get_cutu with methods of dwarf2_per_objfile
@ 2018-04-07 20:50 sergiodj+buildbot
  2018-04-08  3:59 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 20:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ff4c9fec8413fa4e0b11ef092a86669305894a7a ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: ff4c9fec8413fa4e0b11ef092a86669305894a7a

Replace dw2_get_cu/dw2_get_cutu with methods of dwarf2_per_objfile

Those two functions look like good candidates to become methods of
dwarf2_per_objfile.  I did that, and added get_tu as well.  When
replacing usages of dw2_get_cutu, I changed some instances to get_cutu
and others to get_cu, when appropriate (when we know we want a CU and
not a TU).

gdb/ChangeLog:

	* dwarf2read.h (struct signatured_type): Forward declare.
	(struct dwarf2_per_objfile) <get_cutu, get_cu, get_tu>:
	New methods.
	* dwarf2read.c (dwarf2_per_objfile::get_cutu): Rename from...
	(dw2_get_cutu): ...this.
	(dwarf2_per_objfile::get_cu): Rename from...
	(dw2_get_cu): ...this.
	(dwarf2_per_objfile::get_tu): New.
	(create_addrmap_from_index): Adjust.
	(create_addrmap_from_aranges): Adjust.
	(dw2_find_last_source_symtab): Adjust.
	(dw2_map_symtabs_matching_filename): Adjust.
	(dw2_symtab_iter_next): Adjust.
	(dw2_print_stats): Adjust.
	(dw2_expand_all_symtabs): Adjust.
	(dw2_expand_symtabs_with_fullname): Adjust.
	(dw2_expand_marked_cus): Adjust.
	(dw_expand_symtabs_matching_file_matcher): Adjust.
	(dw2_map_symbol_filenames): Adjust.
	(dw2_debug_names_iterator::next): Adjust.
	(dwarf2_initialize_objfile): Adjust.
	(set_partial_user): Adjust.
	(dwarf2_build_psymtabs_hard): Adjust.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix gdb.mi/mi-stack.exp when gcc generates a stack protector
@ 2018-04-07 20:40 sergiodj+buildbot
  2018-04-08 13:45 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 20:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a0be7a3671e6252c0f3353d128f84c641005fa06 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: a0be7a3671e6252c0f3353d128f84c641005fa06

Fix gdb.mi/mi-stack.exp when gcc generates a stack protector

I see some failures in the gdb.mi/mi-stack.exp test.  The test runs to
the callee4 function:

  int callee4 (void)
  {
    int A=1;
    int B=2;
    int C;
    int D[3] = {0, 1, 2};

    C = A + B;
    return 0;
  }

and expects to be stopped at the A=1 line.  However, when gcc generates
some stack protection code, it will stop at the { instead, as shown by
this disassembly (after I did "break callee4" and "run"):

  (gdb) disassemble /s
  Dump of assembler code for function callee4:
  /home/simark/src/binutils-gdb/gdb/testsuite/gdb.mi/mi-stack.c:
  26	{
     0x00005555555546ca <+0>:	push   %rbp
     0x00005555555546cb <+1>:	mov    %rsp,%rbp
     0x00005555555546ce <+4>:	sub    $0x20,%rsp
  => 0x00005555555546d2 <+8>:	mov    %fs:0x28,%rax
     0x00005555555546db <+17>:	mov    %rax,-0x8(%rbp)
     0x00005555555546df <+21>:	xor    %eax,%eax

  27	  int A=1; /* callee4 begin */
     0x00005555555546e1 <+23>:	movl   $0x1,-0x20(%rbp)

  28	  int B=2;
     0x00005555555546e8 <+30>:	movl   $0x2,-0x1c(%rbp)

The rest of the test relies on execution stopping on the A=1, so many things
fail after that.  This patch uses mi_continue_to_line instead, to stop at the
A=1 line precisely.

gdb/testsuite/ChangeLog:

	* gdb.mi/mi-stack.exp (test_stack_frame_listing): Use
	mi_continue_to_line.
	* gdb.mi/mi-stack.c (callee4): Add comment.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove stale file i386-avx.dat
@ 2018-04-07 20:17 sergiodj+buildbot
  2018-04-07 22:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 20:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5dc026d3f04ac657378308202ff7d43a1613f14c ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 5dc026d3f04ac657378308202ff7d43a1613f14c

Remove stale file i386-avx.dat

I noticed that regformats/i386/i386-avx.dat did not get re-generated
when doing "make" in the features directory.  I think it's a leftover
from commit

  f5a29eb0a663 ("Clean up x86 non-linux GDBserver target descriptions")

I build-tested gdbserver with amd64 and i386.

gdb/ChangeLog:

	* regformats/i386/i386-avx.dat: Remove.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Replace make_cleanup_restore_current_traceframe with RAII class
@ 2018-04-07 20:11 sergiodj+buildbot
  2018-04-08 10:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 20:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6f14adc55864818ec3754460f5df4150c2addf42 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 6f14adc55864818ec3754460f5df4150c2addf42

Replace make_cleanup_restore_current_traceframe with RAII class

I put the constructor in tracepoint.c because it needs to read
traceframe_number, and I prefer to do that than to expose
traceframe_number.

gdb/ChangeLog:

	* tracepoint.c (struct current_traceframe_cleanup): Remove.
	(do_restore_current_traceframe_cleanup): Remove.
	(restore_current_traceframe_cleanup_dtor): Remove.
	(make_cleanup_restore_current_traceframe): Remove.
	(scoped_restore_current_traceframe::scoped_restore_current_traceframe):
	New.
	* tracepoint.h (struct scoped_restore_current_traceframe): New.
	* infrun.c (fetch_inferior_event): Use
	scoped_restore_current_traceframe.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove some usages of get_dwarf2_per_objfile
@ 2018-04-07 19:29 sergiodj+buildbot
  2018-04-08  5:18 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 19:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 12359b5e8f2a4034e1e4cd7f0b454fb03151df4c ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 12359b5e8f2a4034e1e4cd7f0b454fb03151df4c

Remove some usages of get_dwarf2_per_objfile

This patch removes some usages of get_dwarf2_per_objfile, where we can
get hold of the dwarf2_per_objfile object in a simpler way.  For
example, it's simpler (and slightly less work) to pass
dwarf2_per_objfile and get the objfile from it than to pass the objfile
and call get_dwarf2_per_objfile.

Ideally, get_dwarf2_per_objfile should only be used in the entry points
of the dwarf2 code, where we receive an objfile.

gdb/ChangeLog:

	* dwarf2read.c (create_cus_from_index_list): Replace objfile arg
	with dwarf2_per_objfile.
	(create_cus_from_index): Likewise.
	(create_signatured_type_table_from_index): Likewise.
	(dwarf2_read_index): Likewise.
	(dwarf2_initialize_objfile): Likewise.
	(dwarf2_fetch_die_loc_sect_off):  Get dwarf2_per_objfile from
	per_cu rather than get_dwarf2_per_objfile.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove some unused variables in dwarf2read.c
@ 2018-04-07 19:01 sergiodj+buildbot
  2018-04-08  2:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 19:01 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5ca3fcb669bc655e2e79866be086e8ac564e472b ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 5ca3fcb669bc655e2e79866be086e8ac564e472b

Remove some unused variables in dwarf2read.c

Most of them are obvious.  The ones in dwarf2_record_block_ranges are
less obvious, because it is a bit suspicious to have that many
variables unused.  But after inspection, it seems like it dates from
commit 5f46c5a54825 ("Code cleanup: Split dwarf2_ranges_read to a
callback"), where dwarf2_record_block_ranges was made to use
dwarf2_ranges_process, which contains the same functionality.

gdb/ChangeLog:

	* dwarf2read.c (create_signatured_type_table_from_debug_names):
	Remove unused variables.
	(dw2_map_symtabs_matching_filename): Likewise.
	(dwarf2_record_block_ranges): Likewise.
	(dwarf2_read_addr_index): Likewise.
	(follow_die_offset): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Defer breakpoint reset when cloning progspace for fork child
@ 2018-04-07 18:47 sergiodj+buildbot
  2018-04-08  1:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 18:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b2e586e850dbf1dafc10beea3250d22e70add4b5 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: b2e586e850dbf1dafc10beea3250d22e70add4b5

Defer breakpoint reset when cloning progspace for fork child

Using this simple test:

  static void
  break_here ()
  {
  }

  int
  main (int argc, char *argv[])
  {
    fork ();
    break_here();
    return 0;
  }

compiled as a PIE:

  $ gcc test.c -g3 -O0 -o test -pie

and running this:

  $ ./gdb -nx -q --data-directory=data-directory ./test -ex "b break_here" -ex "set detach-on-fork off" -ex r

gives:

  Warning:
  Cannot insert breakpoint 1.
  Cannot access memory at address 0x64a

Note that GDB might get stopped by SIGTTOU because of this issue:

  https://sourceware.org/bugzilla/show_bug.cgi?id=23020

In that case, just use "fg" to continue.

This issue happens only with position-independent executables.  Adding
the main objfile for the new inferior (the fork child) causes GDB to try
to reset the breakpoints.  However, that new objfile has not been
relocated yet.  So the breakpoint on "break_here" resolves to an
unrelocated address, from which we are trying to read/write to set a
breakpoint.  Passing SYMFILE_DEFER_BP_RESET avoids that problem.  The
executable is relocated just after, in the follow_fork_inferior
function.

The buildbot seems happy with this patch.  I don't think it's necessary
to add a new test.  Just changing this made many tests go from FAIL to
PASS on my machine, where gcc produces PIE executables by default.  If
anything, I think we would need to add a board file that produces
position-independent executables, so that we can run all the tests with
PIE, even on machines where that is not the default.

gdb/ChangeLog:

	* progspace.c (clone_program_space): Pass SYMFILE_DEFER_BP_RESET
	to symbol_file_add_main.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Implement write_async_safe for mi_console_file (PR 22299)
@ 2018-04-07 18:34 sergiodj+buildbot
  2018-04-08  0:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 18:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7c4e78cf63f6436ae43e8289badba78d81e2eb2c ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 7c4e78cf63f6436ae43e8289badba78d81e2eb2c

Implement write_async_safe for mi_console_file (PR 22299)

Enabling "set debug lin-lwp 1" with the MI interpreter doesn't work.
When the sigchld_handler function wants to print a debug output
("sigchld\n"), it uses ui_file_write_async_safe.  This ends up in the
default implementation of ui_file::write_async_safe, which aborts GDB.

This patch implements the write_async_safe method for mi_console_file.
The "normal" MI output is line buffered, which means the output
accumulates in m_buffer until a \n is written, at which point it's
flushed in m_raw.  The implementation of write_async_safe provided by
this patch bypasses this buffer and writes directly to m_raw.  There are
two reasons for this:

(1) Appending to m_buffer (therefore to an std::string) is probably not
    async-safe, as it may allocate memory.
(2) We may have a partial output already in m_buffer, so that would lead
    to some nested MI output, not so great.

There is probably still a chance to have bad MI output, if
sigchld_handler is invoked in the middle of mi_console_file's flush, and
the line being flushed is only partially sent to m_raw.  The solution
would probably be to block signals during flushing.  Since this is only
used for debug output, I don't know if it's worth the effort to do that.

To implement write_async_safe, I needed to use the fputstrn_unfiltered,
which does the necessary escaping (e.g. replace \n with \\n).  I started
by adding printchar's callback parameters to fputstrn_unfiltered, to be
able to pass async-safe versions of them.  It's not easy to provide an
async-safe version of do_fprintf, but it turns out that we can easily
replace printchar's callbacks with a single do_fputc quite easily.  The
async-safe version of do_fputc simply calls the underlying ui_file's
write_async_safe method.

gdb/ChangeLog:

	PR mi/22299
	* mi/mi-console.c (do_fputc_async_safe): New.
	(mi_console_file::write_async_safe): New.
	(mi_console_file::flush): Adjust calls to fputstrn_unfiltered.
	* mi/mi-console.h (class mi_console_file) <write_async_safe>:
	New.
	* ui-file.c (ui_file::putstrn): Adjust call to
	fputstrn_unfiltered.
	* utils.c (printchar): Replace do_fputs and do_fprintf
	parameters by do_fputc.
	(fputstr_filtered): Adjust call to printchar.
	(fputstr_unfiltered): Likewise.
	(fputstrn_filtered): Likewise.
	(fputstrn_unfiltered): Add do_fputc parameter, pass to
	printchar.
	* utils.h (do_fputc_ftype): New typedef.
	(fputstrn_unfiltered): Add do_fputc parameter.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix generation of x86-64 gdbarch with osabi none (PR 22979)
@ 2018-04-07 18:05 sergiodj+buildbot
  2018-04-07 21:22 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 18:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c912f608be7bc2598b919da2b11721b3c262d154 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: c912f608be7bc2598b919da2b11721b3c262d154

Fix generation of x86-64 gdbarch with osabi none (PR 22979)

When a 64-bits (x86-64) gdbarch is created, it is first born as a
32-bits gdbarch in i386_gdbarch_init.  The call gdbarch_init_osabi will
call the handler register for the selected (arch, osabi) pair, such as
amd64_linux_init_abi.  The various amd64 handlers call amd64_init_abi,
which turns the gdbarch into a 64-bits one.

When selecting the i386:x86-64 architecture with no osabi, no such
handler is ever called, so the gdbarch stays (wrongfully) a 32-bits one.

My first idea was to manually call amd64_init_abi & al in
i386_gdbarch_init when the osabi is GDB_OSABI_NONE.  However, this
doesn't work in a build of GDB where i386 is included as a target but
not amd64.  My next option (implemented in this patch), is to allow
registering handlers for GDB_OSABI_NONE.  I added two such handlers in
amd64-tdep.c, so now it works the same as for the "normal" osabis.  It
required re-ordering things in gdbarch_init_osabi to allow running
handlers for GDB_OSABI_NONE.

Without this patch applied (but with the previous one*) :

  (gdb) set osabi none
  (gdb) set architecture i386:x86-64
  The target architecture is assumed to be i386:x86-64
  (gdb) p sizeof(void*)
  $1 = 4

and now:

  (gdb) set osabi none
  (gdb) set architecture i386:x86-64
  The target architecture is assumed to be i386:x86-64
  (gdb) p sizeof(void*)
  $1 = 8

* Before the previous patch, which fixed "set osabi none", this bug was
  hidden because we didn't actually try to generate a gdbarch for no
  osabi, it would always fall back on Linux.  Generating the gdbarch for
  amd64/linux did work.

gdb/ChangeLog:

	PR gdb/22979
	* amd64-tdep.c (amd64_none_init_abi): New function.
	(amd64_x32_none_init_abi): New function.
	(_initialize_amd64_tdep): Register handlers for x86-64 and
	x64_32 with GDB_OSABI_NONE.
	* osabi.c (gdbarch_init_osabi): Allow running handlers for the
	GDB_OSABI_NONE osabi.

gdb/testsuite/ChangeLog:

	PR gdb/22979
	* gdb.arch/amd64-osabi.exp: New file.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make target_read_alloc & al return vectors
@ 2018-04-07 17:38 sergiodj+buildbot
  2018-04-07 18:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-07 17:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9018be22e022e6db2ba07c4e407c7244022bc69a ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 9018be22e022e6db2ba07c4e407c7244022bc69a

Make target_read_alloc & al return vectors

This patch started by changing target_read_alloc_1 to return a
byte_vector, to avoid manual memory management (in target_read_alloc_1
and in the callers).  To communicate failures to the callers, it
actually returns a gdb::optional<gdb::byte_vector>.

Adjusting target_read_stralloc was a bit more tricky, since it wants to
return a buffer of char, and not gdb_byte.  Since you can't just cast a
gdb::byte_vector into a gdb::def_vector<char>, I made
target_read_alloc_1 templated, so both versions (that return vectors of
gdb_byte and char) are generated.  Since target_read_stralloc now
returns a gdb::char_vector instead of a gdb::unique_xmalloc_ptr<char>, a
few callers need to be adjusted.

gdb/ChangeLog:

	* common/byte-vector.h (char_vector): New type.
	* target.h (target_read_alloc): Return
	gdb::optional<byte_vector>.
	(target_read_stralloc): Return gdb::optional<char_vector>.
	(target_get_osdata): Return gdb::optional<char_vector>.
	* target.c (target_read_alloc_1): Templatize.  Replacement
	manual memory management with vector.
	(target_read_alloc): Change return type, adjust.
	(target_read_stralloc): Change return type, adjust.
	(target_get_osdata): Change return type, adjust.
	* auxv.c (struct auxv_info) <length>: Remove.
	<data>: Change type to gdb::optional<byte_vector>.
	(auxv_inferior_data_cleanup): Free auxv_info with delete.
	(get_auxv_inferior_data): Allocate auxv_info with new, adjust.
	(target_auxv_search): Adjust.
	(fprint_target_auxv): Adjust.
	* avr-tdep.c (avr_io_reg_read_command): Adjust.
	* linux-tdep.c (linux_spu_make_corefile_notes): Adjust.
	(linux_make_corefile_notes): Adjust.
	* osdata.c (get_osdata): Adjust.
	* remote.c (remote_get_threads_with_qxfer): Adjust.
	(remote_memory_map): Adjust.
	(remote_traceframe_info): Adjust.
	(btrace_read_config): Adjust.
	(remote_read_btrace): Adjust.
	(remote_pid_to_exec_file): Adjust.
	* solib-aix.c (solib_aix_get_library_list): Adjust.
	* solib-dsbt.c (decode_loadmap): Don't free buf.
	(dsbt_get_initial_loadmaps): Adjust.
	* solib-svr4.c (svr4_current_sos_via_xfer_libraries): Adjust.
	* solib-target.c (solib_target_current_sos): Adjust.
	* tracepoint.c (sdata_make_value): Adjust.
	* xml-support.c (xinclude_start_include): Adjust.
	(xml_fetch_content_from_file): Adjust.
	* xml-support.h (xml_fetch_another): Change return type.
	(xml_fetch_content_from_file): Change return type.
	* xml-syscall.c (xml_init_syscalls_info): Adjust.
	* xml-tdesc.c (file_read_description_xml): Adjust.
	(fetch_available_features_from_target): Change return type.
	(target_fetch_description_xml): Adjust.
	(target_read_description_xml): Adjust.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove value::next and value::released
@ 2018-04-07  4:04 sergiodj+buildbot
  2018-04-07  8:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-07  4:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 062d818d2535d4bc9ccd5dbf3c6702b9f3e763cc ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 062d818d2535d4bc9ccd5dbf3c6702b9f3e763cc

Remove value::next and value::released

This patch converts all_values to simply hold a list of references to
values.  Now, there's no need to have a value record whether or not it
is released -- there is only a single reference-counting mechanism for
values.  So, this also removes value::next, value::released, and
value_next.

gdb/ChangeLog
2018-04-06  Tom Tromey  <tom@tromey.com>

	* value.c (struct value) <released, next>: Remove.
	(all_values): Now a std::vector.
	(allocate_value_lazy): Update.
	(value_next): Remove.
	(value_mark, value_free_to_mark, release_value)
	(value_release_to_mark): Update.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove free_all_values
@ 2018-04-07  2:23 sergiodj+buildbot
  2018-04-07  5:50 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-07  2:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b562120198d9fa2c191823508813daa3b62a3a37 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: b562120198d9fa2c191823508813daa3b62a3a37

Remove free_all_values

free_all_values is unused, so this removes it.

gdb/ChangeLog
2018-04-06  Tom Tromey  <tom@tromey.com>

	* value.h (free_all_values): Remove.
	* value.c (free_all_values): Remove.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Change varobj to use value_ref_ptr
@ 2018-04-07  0:41 sergiodj+buildbot
  2018-04-07  3:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-07  0:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b4d61099ba840824fd0aac9800403f6278476347 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: b4d61099ba840824fd0aac9800403f6278476347

Change varobj to use value_ref_ptr

This changes varobj to use value_ref_ptr, allowing the removal of some
manual reference count management.

gdb/ChangeLog
2018-04-06  Tom Tromey  <tom@tromey.com>

	* varobj.h (struct varobj) <value>: Now a value_ref_ptr.
	* varobj.c (varobj_set_display_format, varobj_set_value)
	(install_default_visualizer, construct_visualizer)
	(install_new_value, ~varobj, varobj_get_value_type)
	(my_value_of_variable, varobj_editable_p): Update.
	* c-varobj.c (c_describe_child, c_value_of_variable)
	(cplus_number_of_children, cplus_describe_child): Update.
	* ada-varobj.c (ada_number_of_children, ada_name_of_child)
	(ada_path_expr_of_child, ada_value_of_child, ada_type_of_child)
	(ada_value_of_variable, ada_value_is_changeable_p): Update.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove range_s VEC
@ 2018-04-07  0:26 sergiodj+buildbot
  2018-04-07 13:44 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-07  0:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0c7e6dd852f01b3ea38b98c39a2bb36280b02b55 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 0c7e6dd852f01b3ea38b98c39a2bb36280b02b55

Remove range_s VEC

This changes the "optimized_out" and "unavailable" VECs in struct
value to be std::vectors, and then fixes up all the uses.

gdb/ChangeLog
2018-04-06  Tom Tromey  <tom@tromey.com>

	* value.c (range_s): Remove typedef, VEC.
	(struct range): Add operator<.
	(range_lessthan): Remove.
	(ranges_contain): Change type.
	(~value): Update.
	(struct value) <unavailable, optimized_out>: Now std::vector.
	(value_entirely_available)
	(value_entirely_covered_by_range_vector)
	(value_entirely_unavailable, value_entirely_optimized_out):
	Update.
	(insert_into_bit_range_vector): Change argument type.
	(find_first_range_overlap): Likewise.
	(struct ranges_and_idx, value_contents_bits_eq)
	(require_not_optimized_out, require_available): Update.
	(ranges_copy_adjusted): Change argument types.
	(value_optimized_out, value_copy, value_fetch_lazy): Update.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Use new and delete for values
@ 2018-04-06 23:57 sergiodj+buildbot
  2018-04-07 11:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-06 23:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 466ce3aea9cec006b8b0e348c9021ac2c8106022 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 466ce3aea9cec006b8b0e348c9021ac2c8106022

Use new and delete for values

This adds a constructor and destructor to struct value, and then
changes value.c to use "new" and "delete".

While doing this I noticed a memory leak -- value_decref was not
freeing value::optimized_out.  This patch fixes this leak.

gdb/ChangeLog
2018-04-06  Tom Tromey  <tom@tromey.com>

	* value.c (struct value): Add constructor, destructor, and member
	initializers.
	(allocate_value_lazy, value_decref): Update.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove free_value_chain
@ 2018-04-06 23:29 sergiodj+buildbot
  2018-04-07  7:10 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-06 23:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a6535de1903d9caad8c10c1d81c51a29612456a6 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: a6535de1903d9caad8c10c1d81c51a29612456a6

Remove free_value_chain

This patch changes value_release_to_mark and fetch_subexp_value to
return a std::vector of value references, rather than relying on the
"next" field that is contained in a struct value.  This makes it
simpler to reason about the returned values, and also allows for the
removal of free_value_chain.

gdb/ChangeLog
2018-04-06  Tom Tromey  <tom@tromey.com>

	* value.h (fetch_subexp_value, value_release_to_mark): Update.
	(free_value_chain): Remove.
	* value.c (free_value_chain): Remove.
	(value_release_to_mark): Return a std::vector.
	* ppc-linux-nat.c (num_memory_accesses): Change "chain" to a
	std::vector.
	(check_condition): Update.
	* eval.c (fetch_subexp_value): Change "val_chain" to a
	std::vector.
	* breakpoint.c (update_watchpoint): Update.
	(can_use_hardware_watchpoint): Change "vals" to a std::vector.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Change value history to use value_ref_ptr
@ 2018-04-06 23:00 sergiodj+buildbot
  2018-04-07  4:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-06 23:00 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4d0266a0e0d9e9b615b04ff209a73d3725495835 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 4d0266a0e0d9e9b615b04ff209a73d3725495835

Change value history to use value_ref_ptr

This simplifies the value history implementation by replacing the
current data structure with a std::vector, and by making the value
history simply hold a reference to each value.

gdb/ChangeLog
2018-04-06  Tom Tromey  <tom@tromey.com>

	* value.c (VALUE_HISTORY_CHUNK, struct value_history_chunk)
	(value_history_chain, value_history_count): Remove.
	(value_history): New global.
	(record_latest_value, access_value_history, show_values)
	(preserve_values): Update.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Change last_examine_value to value_ref_ptr
@ 2018-04-06 22:31 sergiodj+buildbot
  2018-04-07  1:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-06 22:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9b5587295bbc57e5e0453b659e24d7c2b504b894 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 9b5587295bbc57e5e0453b659e24d7c2b504b894

Change last_examine_value to value_ref_ptr

This patch removes some manual reference count manipulation by
changing last_examine_value to be a value_ref_ptr and then updating
the users.

gdb/ChangeLog
2018-04-06  Tom Tromey  <tom@tromey.com>

	* printcmd.c (last_examine_address): Change type to
	value_ref_ptr.
	(do_examine, x_command): Update.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add -Wno-error=deprecated-register to gdb build flags
@ 2018-04-06 20:32 sergiodj+buildbot
  2018-04-06 21:53 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-06 20:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7f8a5d38ed00ad4ecc920322c4b852f3cf905a94 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 7f8a5d38ed00ad4ecc920322c4b852f3cf905a94

Add -Wno-error=deprecated-register to gdb build flags

As shown in PR 23022, building with clang-6 and Python 2 trips on the
fact that the Python 2 headers use the "register" keyword:

/usr/include/python2.7/unicodeobject.h:534:5: error: 'register' storage class specifier is deprecated and incompatible with C++17 [-Werror,-Wdeprecated-register]
    register PyObject *obj,     /* Object */
    ^~~~~~~~~

This patch adds -Wno-error=deprecated-register to our flags, so that we can
still see this class of warnings, but they don't cause a build failure.

gdb/ChangeLog:

	PR gdb/23022
	* warning.m4: Add -Wno-error=deprecated-register.
	* configure: Re-generate.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Use dlsym to check if libdl is needed for plugin
@ 2018-04-05 22:53 sergiodj+buildbot
  2018-04-06 11:24 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-05 22:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3cba8b6c93ab8c573ba4678255df11486de61c54 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 3cba8b6c93ab8c573ba4678255df11486de61c54

Use dlsym to check if libdl is needed for plugin

config/plugins.m4 has

 if test "$plugins" = "yes"; then
    AC_SEARCH_LIBS([dlopen], [dl])
  fi

Plugin uses dlsym, but libasan.so only intercepts dlopen, not dlsym:

[hjl@gnu-tools-1 binutils-text]$ nm -D /lib64/libasan.so.4| grep " dl"
0000000000038580 W dlclose
                 U dl_iterate_phdr
000000000004dc50 W dlopen
                 U dlsym
                 U dlvsym
[hjl@gnu-tools-1 binutils-text]$

Testing dlopen for libdl leads to false negative when -fsanitize=address
is used.  It results in link failure:

../bfd/.libs/libbfd.a(plugin.o): undefined reference to symbol 'dlsym@@GLIBC_2.16'

dlsym should be used to check if libdl is needed for plugin.

bfd/

	PR gas/22318
	* configure: Regenerated.

binutils/

	PR gas/22318
	* configure: Regenerated.

gas/

	PR gas/22318
	* configure: Regenerated.

gprof/

	PR gas/22318
	* configure: Regenerated.

ld/

	PR gas/22318
	* configure: Regenerated.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] config: Sync with GCC
@ 2018-04-05 22:49 sergiodj+buildbot
  2018-04-06  9:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-05 22:49 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 552d4da4178cc5e8d567ee150462a28d51f08fc0 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 552d4da4178cc5e8d567ee150462a28d51f08fc0

config: Sync with GCC

	Sync with GCC
	2018-04-05  H.J. Lu  <hongjiu.lu@intel.com>

	PR gas/22318
	* plugins.m4 (AC_PLUGINS): Use dlsym to check if libdl is needed.

	2018-02-14  Igor Tsimbalist  <igor.v.tsimbalist@intel.com>

	PR target/84148
	* cet.m4: Check if target support multi-byte NOPS (SSE).


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Change streq to return bool
@ 2018-04-05 18:17 sergiodj+buildbot
  2018-04-06  3:13 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-05 18:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 459a2e4ccf9aadfba9819facba1c9be5297c1625 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 459a2e4ccf9aadfba9819facba1c9be5297c1625

Change streq to return bool

I wanted to use streq with std::unique in another (upcoming) patch in
this seres, so I changed it to return bool.  To my surprise, this lead
to regressions.  The cause turned out to be that streq was used as an
htab callback -- by casting it to the correct function type.  This
sort of cast is invalid, so this patch adds a variant which is
directly suitable for use by htab.  (Note that I did not add an
overload, as I could not get that to work with template deduction in
the other patch.)

ChangeLog
2018-04-05  Tom Tromey  <tom@tromey.com>

	* completer.c (completion_tracker::completion_tracker): Remove
	cast.
	(completion_tracker::discard_completions): Likewise.
	* breakpoint.c (ambiguous_names_p): Remove cast.
	* ada-lang.c (_initialize_ada_language): Remove cast.
	* utils.h (streq): Update.
	(streq_hash): Add new declaration.
	* utils.c (streq): Return bool.
	(streq_hash): New function.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove a string copy from event_location_to_sals
@ 2018-04-05 15:05 sergiodj+buildbot
  2018-04-06  1:54 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-05 15:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9be2c17a900178df75a2208fd112ceb4325a70c1 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 9be2c17a900178df75a2208fd112ceb4325a70c1

Remove a string copy from event_location_to_sals

The use of "const" showed that a string copy in event_location_to_sals
was unnecessary.  This patch removes it.

ChangeLog
2018-04-05  Tom Tromey  <tom@tromey.com>

	* linespec.c (event_location_to_sals) <case ADDRESS_LOCATION>:
	Remove a string copy.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Have filter_results take a std::vector
@ 2018-04-05 14:52 sergiodj+buildbot
  2018-04-05 22:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-05 14:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f73c6ece7888af880d3b03b2d57ee7782f2a539b ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: f73c6ece7888af880d3b03b2d57ee7782f2a539b

Have filter_results take a std::vector

This chagnes filter_results to take a std::vector, allowing the
removal of some cleanups in its callers.

ChangeLog
2018-04-05  Tom Tromey  <tom@tromey.com>

	* linespec.c (filter_results): Use std::vector.
	(decode_line_2, decode_line_full): Update.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Return std::string from canonical_to_fullform
@ 2018-04-05 14:37 sergiodj+buildbot
  2018-04-05 19:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-05 14:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 53a0f8a250199af97ff8708e3899835086c7a24d ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 53a0f8a250199af97ff8708e3899835086c7a24d

Return std::string from canonical_to_fullform

This changes canonical_to_fullform to return a std::string, and
changes decode_line_2 to use std::vector.  This allows for the removal
of some cleanups.

ChangeLog
2018-04-05  Tom Tromey  <tom@tromey.com>

	* linespec.c (canonical_to_fullform): Return std::string.
	(filter_results): Update.
	(struct decode_line_2_item): Add constructor.
	<fullform, displayform>: Now std::string.
	(decode_line_2_compare_items): Now a std::sort comparator.
	(decode_line_2): Update.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make copy_token_string return unique_xmalloc_ptr
@ 2018-04-05 14:24 sergiodj+buildbot
  2018-04-05 18:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-05 14:24 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a5b5adf529fa64391bc1ef733b3e78f15d94c4b9 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: a5b5adf529fa64391bc1ef733b3e78f15d94c4b9

Make copy_token_string return unique_xmalloc_ptr

This changes copy_token_string to return a unique_xmalloc_ptr, which
allows the removal of some cleanups.

ChangeLog
2018-04-05  Tom Tromey  <tom@tromey.com>

	* linespec.c (copy_token_string): Return a unique_xmalloc_ptr.
	(unexpected_linespec_error): Update.
	(linespec_parse_basic, parse_linespec): Update.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove some cleanups from search_minsyms_for_name
@ 2018-04-05 13:56 sergiodj+buildbot
  2018-04-05 15:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-05 13:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 41c1efc614472cdc74397e734f5a66018362a80a ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 41c1efc614472cdc74397e734f5a66018362a80a

Remove some cleanups from search_minsyms_for_name

This changes struct collect_minsyms to use a std::vector, which
enables the removal of a cleanup from search_minsyms_for_name.  This
also changes iterate_over_minimal_symbols to take a
gdb::function_view, which makes a function in linespec.c more
type-safe.

ChangeLog
2018-04-05  Tom Tromey  <tom@tromey.com>

	* minsyms.h (iterate_over_minimal_symbols): Update.
	* minsyms.c (iterate_over_minimal_symbols): Take a
	gdb::function_view.
	* linespec.c (struct collect_minsyms): Remove.
	(compare_msyms): Now a std::sort comparator.
	(add_minsym): Add parameters.
	(search_minsyms_for_name): Update.  Use std::vector.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] i386: Clear vex instead of vex.evex
@ 2018-04-04 11:58 sergiodj+buildbot
  2018-04-04 14:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-04 11:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT caf0678c84b5b55fbc4bcc853954745a4ad8b658 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: caf0678c84b5b55fbc4bcc853954745a4ad8b658

i386: Clear vex instead of vex.evex

"vex" has many fields to control how to decode an instruction.  Clear
all fields in "vex" before decoding an instruction to avoid using values
left from the previous instruction.

gas/

	PR binutils/23025
	* testsuite/gas/i386/prefix.s: Add tests for vcvtpd2dq with
	VEX and EVEX prefixes.
	* testsuite/gas/i386/prefix.d: Updated.

opcodes/

	PR binutils/23025
	* i386-dis.c (get_valid_dis386): Don't set vex.prefix nor vex.w
	to 0.
	(print_insn): Clear vex instead of vex.evex.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Update Spanish translations for ld/ opcodes/ and gold/ sub-directories
@ 2018-04-04  8:16 sergiodj+buildbot
  2018-04-04 12:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-04  8:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4fb0d2b912ad079263ed98a3c4d78e5a7ccc93b0 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 4fb0d2b912ad079263ed98a3c4d78e5a7ccc93b0

Update Spanish translations for ld/ opcodes/ and gold/ sub-directories


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR binutils/22875: HPPA/ELF: Also fail with relocation placeholders
@ 2018-04-04  2:44 sergiodj+buildbot
  2018-04-04 10:45 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-04  2:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8ee55178c22326c3624ad5872dc5382341ddcd2c ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 8ee55178c22326c3624ad5872dc5382341ddcd2c

PR binutils/22875: HPPA/ELF: Also fail with relocation placeholders

Do not consider R_PARISC_UNIMPLEMENTED placeholder relocation entries of
the `elf_hppa_howto_table' table valid in `info_to_howto' HPPA handlers.
Instead issue an unsupported relocation type error and return a NULL
howto as with relocations whose number is R_PARISC_UNIMPLEMENTED or
beyond.

	bfd/
	* elf-hppa.h (elf_hppa_info_to_howto): Also return
	unsuccessfully for unimplemented relocations.
	(elf_hppa_info_to_howto_rel): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR binutils/22875: i860/ELF: Report unsupported relocation types
@ 2018-04-04  2:30 sergiodj+buildbot
  2018-04-04  8:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-04  2:30 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5d7c8b80485d75242e7c78e79b3ecb4c71abaee3 ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 5d7c8b80485d75242e7c78e79b3ecb4c71abaee3

PR binutils/22875: i860/ELF: Report unsupported relocation types

Complement commit f3185997ac09 ("PR 22875: Stop strip corrupting unknown
relocs"), <https://sourceware.org/ml/binutils/2018-02/msg00445.html>,
and also set the `bfd_error_bad_value' error and report an unsupported
relocation type if a howto lookup fails with the i860 backend, fixing a
confusing `no error' error message and removing a binutils test failure:

failed with: <.../binutils/strip-new: tmpdir/bintest.o: no error>, expected: <.* bad value>
.../binutils/strip-new: tmpdir/bintest.o: no error
FAIL: binutils-all/strip-13

with the `i860-stardent-elf' target.

	bfd/
	* elf32-i860.c (lookup_howto): Add `abfd' parameter.  Set the
	`bfd_error_bad_value' error and call `_bfd_error_handler' on a
	howto lookup failure.
	(elf32_i860_reloc_type_lookup): Adjust `lookup_howto' call
	accordingly.
	(elf32_i860_info_to_howto_rela): Likewise.
	(elf32_i860_relocate_splitn): Likewise.
	(elf32_i860_relocate_pc16): Likewise.
	(elf32_i860_relocate_pc26): Likewise.
	(elf32_i860_relocate_section): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR binutils/22875: Visium/ELF: Prevent an out-of-bounds howto table access
@ 2018-04-04  2:16 sergiodj+buildbot
  2018-04-04  6:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-04  2:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 707bad1b21c18cf8e570fb8df8f7c5961fb0f3a5 ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 707bad1b21c18cf8e570fb8df8f7c5961fb0f3a5

PR binutils/22875: Visium/ELF: Prevent an out-of-bounds howto table access

Prevent an out-of-bounds `visium_elf_howto_table' table access in
`visium_info_to_howto_rela' by using the size of the table rather than
R_VISIUM_max to determine the number of entries in the contiguous
regular Visium relocation range defined and described in the table.

	bfd/
	* elf32-visium.c (visium_info_to_howto_rela): Correct the range
	check for `visium_elf_howto_table' table access.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR binutils/22875: FRV/ELF: Prevent an out-of-bounds howto table access
@ 2018-04-04  2:02 sergiodj+buildbot
  2018-04-04  3:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-04  2:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f428698edfd845a21639f5145cba3772eb92abc2 ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: f428698edfd845a21639f5145cba3772eb92abc2

PR binutils/22875: FRV/ELF: Prevent an out-of-bounds howto table access

Prevent an out-of-bounds `elf32_frv_howto_table' table access in
`frv_info_to_howto_rela' by using the size of the table rather than
R_FRV_max to determine the number of entries in the contiguous regular
FRV relocation range defined and described in the table.

	bfd/
	* elf32-frv.c (frv_info_to_howto_rela): Correct the range check
	for `elf32_frv_howto_table' table access.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR binutils/22875: IQ2000/ELF: Prevent an out-of-bounds howto table access
@ 2018-04-04  1:44 sergiodj+buildbot
  2018-04-04  5:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-04  1:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0cc919dc6abede5e61b9d8234028fba879166088 ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 0cc919dc6abede5e61b9d8234028fba879166088

PR binutils/22875: IQ2000/ELF: Prevent an out-of-bounds howto table access

Prevent an out-of-bounds `iq2000_elf_howto_table' table access in
`iq2000_info_to_howto_rela' by using the size of the table rather than
R_IQ2000_max to determine the number of entries in the contiguous
regular IQ2000 relocation range defined and described in the table.

	bfd/
	* elf32-iq2000.c (iq2000_info_to_howto_rela): Correct the range
	check for `iq2000_elf_howto_table' table access.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR binutils/22875: MIPS/ELF: Also fail with relocation placeholders
@ 2018-04-04  1:17 sergiodj+buildbot
  2018-04-04  2:22 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-04  1:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7ed6f92aaffdcc0995b0247379fb8ea621854dce ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 7ed6f92aaffdcc0995b0247379fb8ea621854dce

PR binutils/22875: MIPS/ELF: Also fail with relocation placeholders

Do not consider placeholder EMPTY_HOWTO relocation entries valid in
`rtype_to_howto' MIPS handlers.  Instead issue an unsupported relocation
type error and return a NULL howto as with relocations outside the three
ISA-specific min-max ranges.

	bfd/
	* elf32-mips.c (mips_elf32_rtype_to_howto): Also return
	unsuccessfully for placeholder howtos.
	* elf64-mips.c (mips_elf64_rtype_to_howto): Likewise.
	* elfn32-mips.c (mips_elf_n32_rtype_to_howto): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Change read_alphacoff_dynamic_symtab to use gdb::byte_vector
@ 2018-04-03 18:20 sergiodj+buildbot
  2018-04-03 19:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-03 18:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c5edbf3d1c58d59135788f084a3bf681a49e0f9a ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: c5edbf3d1c58d59135788f084a3bf681a49e0f9a

Change read_alphacoff_dynamic_symtab to use gdb::byte_vector

This changes read_alphacoff_dynamic_symtab to use gdb::byte_vector.
This allows for the removal of some cleanups.

Tested by the buildbot; though I don't know whether this code path is
ever actually run.

gdb/ChangeLog
2018-04-03  Tom Tromey  <tom@tromey.com>

	* mipsread.c (read_alphacoff_dynamic_symtab): Use
	gdb::byte_vector.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Change rs6000_ptrace_ldinfo to return a byte_vector
@ 2018-04-02  2:44 sergiodj+buildbot
  2018-04-02  3:49 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-04-02  2:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 09473be85c13eab0d794e363d898b74d66431d72 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 09473be85c13eab0d794e363d898b74d66431d72

Change rs6000_ptrace_ldinfo to return a byte_vector

This changes rs6000_ptrace_ldinfo to return a byte_vector.  I think
this points out an existing double-free in
rs6000_xfer_shared_libraries.

Tested by the buildbot.

gdb/ChangeLog
2018-04-01  Tom Tromey  <tom@tromey.com>

	* rs6000-nat.c (rs6000_ptrace_ldinfo): Return a byte_vector.
	(rs6000_xfer_shared_libraries): Update.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Use std::vector and std::string instead of VEC(char_ptr) in gdbserver tdesc
@ 2018-03-31  1:27 sergiodj+buildbot
  2018-03-31  7:10 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-31  1:27 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 17d08cd4137063dbc43d9989b9a5cb315171174f ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 17d08cd4137063dbc43d9989b9a5cb315171174f

Use std::vector and std::string instead of VEC(char_ptr) in gdbserver tdesc

This is a straightforward replacement, no change in behavior are
intended/expected.

gdb/gdbserver/ChangeLog:

	* tdesc.h (struct target_desc) <features>: Change type to
	std::vector<std::string>.
	* tdesc.c (target_desc::~target_desc): Adjust to std::vector
	changes.
	(tdesc_get_features_xml): Likewise.
	(tdesc_create_feature): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Use std::vector in uploaded_tp
@ 2018-03-30 22:45 sergiodj+buildbot
  2018-03-31  5:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-30 22:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a18ba4e4c9d64eeb2ea65e5315fbd8b4261a1756 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: a18ba4e4c9d64eeb2ea65e5315fbd8b4261a1756

Use std::vector in uploaded_tp

This patch changes the VEC(char_ptr) fields in uploaded_tp to use
std::vector<char *>.  At first, I wanted to creep in more changes, like
using std::string, but it was making the patch too big and less focused,
so I decided to keep it to just that.

It also looks like the strings in those vectors are never free'd.  If
so, we can fix that in another patch.

gdb/ChangeLog:

	* tracepoint.h (struct uploaded_tp): Initialize fields.
	<actions, step_actions, cmd_strings>: Change type to
	std::vector<char *>.
	* tracepoint.c (get_uploaded_tp): Allocate with new.
	(free_uploaded_tps): Free with delete.
	(parse_tracepoint_definition): Adjust to std::vector change.
	* breakpoint.c (read_uploaded_action): Likewise.
	(create_tracepoint_from_upload): Likewise.
	* ctf.c (ctf_write_uploaded_tp): Likewise.
	(SET_ARRAY_FIELD): Likewise.
	* tracefile-tfile.c (tfile_write_uploaded_tp): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove usage of VEC(char_ptr) in gdbscm_parse_function_args
@ 2018-03-30 22:03 sergiodj+buildbot
  2018-03-31  9:24 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-30 22:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d8611974cf819e5f8cb9eb36907251f3e2d721c6 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: d8611974cf819e5f8cb9eb36907251f3e2d721c6

Remove usage of VEC(char_ptr) in gdbscm_parse_function_args

This is a straightforward replacement, no change in behavior are
intended/expected.

This is the last usage of VEC(char_ptr), so it can now be removed.

gdb/ChangeLog:

	* guile/scm-utils.c (gdbscm_parse_function_args): Replace VEC
	with std::vector.
	* common/gdb_vecs.h (DEF_VEC_P (char_ptr)): Remove.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove some cleanups from solib-svr4.c
@ 2018-03-30 20:35 sergiodj+buildbot
  2018-03-31  4:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-30 20:35 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a7961323e2fce4f831e117cc43e20e5144192240 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: a7961323e2fce4f831e117cc43e20e5144192240

Remove some cleanups from solib-svr4.c

This removes a few cleanups from solib-svr4.c in a straightforward
way.

gdb/ChangeLog
2018-03-30  Tom Tromey  <tom@tromey.com>

	* solib-svr4.c (lm_info_read): Use gdb::byte_vector.  Return
	std::unique_ptr.
	(svr4_keep_data_in_core): Update.
	(svr4_read_so_list): Update.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove free_cached_comp_units cleanups
@ 2018-03-30 20:03 sergiodj+buildbot
  2018-03-30 22:33 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-30 20:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 11ed8cada64e717900117364c2fee0132c1eb099 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 11ed8cada64e717900117364c2fee0132c1eb099

Remove free_cached_comp_units cleanups

This changes free_cached_comp_units from a cleanup function to an RAII
class.

gdb/ChangeLog
2018-03-30  Tom Tromey  <tom@tromey.com>

	* dwarf2read.c (class free_cached_comp_units): New class.
	(dw2_instantiate_symtab, dwarf2_build_psymtabs_hard): Use it.
	(free_cached_comp_units): Remove function.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove parameter from free_dwo_file
@ 2018-03-30 19:55 sergiodj+buildbot
  2018-03-31  0:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-30 19:55 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5dafb3d176ab8d9b9f0a46111d7040bb51ad8f8e ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 5dafb3d176ab8d9b9f0a46111d7040bb51ad8f8e

Remove parameter from free_dwo_file

The objfile parameter to free_dwo_file is unused, so remove it.

gdb/ChangeLog
2018-03-30  Tom Tromey  <tom@tromey.com>

	* dwarf2read.c (free_dwo_file): Remove "objfile" parameter.
	(free_dwo_file_cleanup, free_dwo_file_from_slot): Update.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR binutils/22875: MIPS: Remove duplicate unsupported relocation processing
@ 2018-03-29 13:26 sergiodj+buildbot
  2018-03-29 14:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-29 13:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 75def2abc3dafb52418405905cd49e9c107c2640 ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 75def2abc3dafb52418405905cd49e9c107c2640

PR binutils/22875: MIPS: Remove duplicate unsupported relocation processing

Remove a duplicate `unsupported relocation type' message and the setting
of the `bfd_error_bad_value' error from `mips_elf32_rtype_to_howto',
added with commit f3185997ac09 ("PR 22875: Stop strip corrupting unknown
relocs"), <https://sourceware.org/ml/binutils/2018-02/msg00445.html>.
This message is already produced and the `bfd_error_bad_value' error set
by `mips_elf32_rtype_to_howto' before a NULL howto is returned, so there
is no need to repeat these actions here.

	bfd/
	* elf32-mips.c (mips_info_to_howto_rel): Remove the calls to
	`_bfd_error_handler' and to set the `bfd_error_bad_value' error.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] MIPS/BFD: Call `mips_elf32_rtype_to_howto' directly with o32
@ 2018-03-28 20:56 sergiodj+buildbot
  2018-03-29  0:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-28 20:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8205a328f8b852086652841dfc2aff4ca0b16d45 ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 8205a328f8b852086652841dfc2aff4ca0b16d45

MIPS/BFD: Call `mips_elf32_rtype_to_howto' directly with o32

Call `mips_elf32_rtype_to_howto' directly rather than via the
`->elf_backend_mips_rtype_to_howto' method in the o32 backend,
complementing commit 861fb55ab50a ("Defer allocation of R_MIPS_REL32 GOT
slots"), <https://sourceware.org/ml/binutils/2008-08/msg00096.html>, and
reverting the change to `mips_info_to_howto_rel' originally made with
commit 0a44bf6950b3 ("mips-vxworks support"),
<https://sourceware.org/ml/binutils/2006-03/msg00179.html>.

With `mips_vxworks_rtype_to_howto' gone there is a single backend method
used across all o32 targets, so there in no need for the indirection and
the associated extra cost.  This also makes the o32 backend consistent
with the n32 and n64 backends.

	bfd/
	* elf32-mips.c (mips_info_to_howto_rel): Call
	`mips_elf32_rtype_to_howto' directly rather than via
	`->elf_backend_mips_rtype_to_howto'.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [1/2][GAS][AARCH64]Add BFD_RELOC_AARCH64_TLSLE_LDST8/16/32/64_TPREL_LO12 support in GAS.
@ 2018-03-28 17:35 sergiodj+buildbot
  2018-03-28 21:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-28 17:35 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 84f1b9fb081372a726fd70dfd8258a707833caef ***

Author: Renlin Li <renlin.li@arm.com>
Branch: master
Commit: 84f1b9fb081372a726fd70dfd8258a707833caef

[1/2][GAS][AARCH64]Add BFD_RELOC_AARCH64_TLSLE_LDST8/16/32/64_TPREL_LO12 support in GAS.

This patch adds the following relocation support into binutils gas.
BFD_RELOC_AARCH64_TLSLE_LDST16_TPREL_LO12,
BFD_RELOC_AARCH64_TLSLE_LDST16_TPREL_LO12_NC,
BFD_RELOC_AARCH64_TLSLE_LDST32_TPREL_LO12,
BFD_RELOC_AARCH64_TLSLE_LDST32_TPREL_LO12_NC,
BFD_RELOC_AARCH64_TLSLE_LDST64_TPREL_LO12,
BFD_RELOC_AARCH64_TLSLE_LDST64_TPREL_LO12_NC,
BFD_RELOC_AARCH64_TLSLE_LDST8_TPREL_LO12,
BFD_RELOC_AARCH64_TLSLE_LDST8_TPREL_LO12_NC.

Those relocations includes both ip64 and ilp32 variant.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: convert broadcast insn attribute to boolean
@ 2018-03-28 13:10 sergiodj+buildbot
  2018-03-28 18:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-28 13:10 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8e6e0792d17be5d4321def520d12c1764dc0ba2a ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 8e6e0792d17be5d4321def520d12c1764dc0ba2a

x86: convert broadcast insn attribute to boolean

The (only) valid broadcast type for an insn can be inferred from other
information.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: don't show suffixes for to-scalar-int conversion insns
@ 2018-03-28 12:42 sergiodj+buildbot
  2018-03-28 14:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-28 12:42 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9646c87b5a6c0462e8a9b6305d9e449bd099f19d ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 9646c87b5a6c0462e8a9b6305d9e449bd099f19d

x86: don't show suffixes for to-scalar-int conversion insns

In the course of folding their patterns (possible now that the pointless
and partly even bogus VecESize are no longer in the way) I've noticed
that vcvt*2usi, other than their vcvt*2si counterparts, don't allow for
any suffixes. As that is supposedly intentional, make the disassembler
consistently omit suffixes for all to-scalar-int conversion insns.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR ld/22972 on SPARC.
@ 2018-03-28 10:35 sergiodj+buildbot
  2018-03-28 13:06 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-28 10:35 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f8745e1cd139b5c6a5bd8a30ea84ccbd45dec81c ***

Author: Eric Botcazou <ebotcazou@gcc.gnu.org>
Branch: master
Commit: f8745e1cd139b5c6a5bd8a30ea84ccbd45dec81c

PR ld/22972 on SPARC.

This is a regression for the corner case of a hidden symbol in a PIC/PIE
binary which is subject to both a new-style GOTDATA relocation and an
old-style GOT relocation.  In this case, depending  on the link order,
the R_SPARC_RELATIVE dynamic relocation for the GOT slot needed because
of the old-style relocation can be replaced with R_SPARC_NONE coming
from the GOTDATA relocation.

The fix simply records whether an old-style GOT relocation is seen for a
symbol and prevents the R_SPARC_NONE from being generated in this case.

bfd/
	* elfxx-sparc.c (struct _bfd_sparc_elf_link_hash_entry): Add new flag
	has_old_style_got_reloc.
	(_bfd_sparc_elf_check_relocs) <GOT relocations>: Set it for old-style
	relocations.  Fix a couple of long lines.
	(_bfd_sparc_elf_relocate_section) <R_SPARC_GOTDATA_OP>: Do not generate
	a R_SPARC_NONE for the GOT slot if the symbol is also subject to
	old-style GOT relocations.
ld/
	* testsuite/ld-sparc/sparc.exp: Add test for mixed GOTDATA/GOT relocs.
	* testsuite/ld-sparc/gotop-hidden.c: New file.
	* testsuite/ld-sparc/got-hidden32.s: Likewise.
	* testsuite/ld-sparc/got-hidden64.s: Likewise.
	* testsuite/ld-sparc/pass.out: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Enhance the AARCH64 assembler to support LDFF1xx instructions which use REG+REG addressing with an assumed offset register.
@ 2018-03-28  9:04 sergiodj+buildbot
  2018-03-28 11:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-28  9:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c8d59609b1cf66eaff3c486e483f5e3d647c66ff ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: c8d59609b1cf66eaff3c486e483f5e3d647c66ff

Enhance the AARCH64 assembler to support LDFF1xx instructions which use REG+REG addressing with an assumed offset register.

	PR 22988
opcode	* opcode/aarch64.h (enum aarch64_opnd): Add
	AARCH64_OPND_SVE_ADDR_R.

opcodes	* aarch64-tbl.h (aarch64_opcode_table): Add entries for LDFF1xx
	instructions with only a base address register.
	* aarch64-opc.c (operand_general_constraint_met_p): Add code to
	handle AARHC64_OPND_SVE_ADDR_R.
	(aarch64_print_operand): Likewise.
	* aarch64-asm-2.c: Regenerate.
	* aarch64_dis-2.c: Regenerate.
	* aarch64-opc-2.c: Regenerate.

gas	* config/tc-aarch64.c (parse_operands): Add code to handle
	AARCH64_OPN_SVE_ADDR_R.
	* testsuite/gas/aarch64/sve.s: Add tests for LDFF1xx instructions
	with an assumed XZR offset address register.
	* testsuite/gas/aarch64/sve.d: Update expected disassembly.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove cleanups from gdb_readline_wrapper
@ 2018-03-27 17:14 sergiodj+buildbot
  2018-03-28  7:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-27 17:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1dbeed45b6a81ddcb725b68ff12236e7c8386a47 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 1dbeed45b6a81ddcb725b68ff12236e7c8386a47

Remove cleanups from gdb_readline_wrapper

This removes some cleanups from gdb_readline_wrapper by changing the
existing gdb_readline_wrapper_cleanup struct to have a constructor and
destructor, and then changing gdb_readline_wrapper to simply
instantiate it on the stack.

gdb/ChangeLog
2018-03-27  Pedro Alves  <palves@redhat.com>
	    Tom Tromey  <tom@tromey.com>

	* top.c (class gdb_readline_wrapper_cleanup): Add constructor,
	destructor.  Now a class.
	(gdb_readline_wrapper_cleanup): Remove function.
	(gdb_readline_wrapper): Remove cleanups.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Include <cmath> in dwarf-index-write.c
@ 2018-03-27 15:13 sergiodj+buildbot
  2018-03-28  4:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-27 15:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 608219fb2917d407058952adf164eb616880662b ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 608219fb2917d407058952adf164eb616880662b

Include <cmath> in dwarf-index-write.c

On x86-64 Fedora 26, when building with the system gcc, I get:

../../binutils-gdb/gdb/dwarf-index-write.c: In member function void debug_names::build():
../../binutils-gdb/gdb/dwarf-index-write.c:705:13: error: pow is not a member of std

There are actually more messages, but this is sufficient to show the
problem.

The fix is to include <cmath>.

I'm checking this in as obvious.  Tested by building.

gdb/ChangeLog
2018-03-27  Tom Tromey  <tom@tromey.com>

	* dwarf-index-write.c: Include <cmath>.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Move DWARF index-related things to a separate file
@ 2018-03-27 14:24 sergiodj+buildbot
  2018-03-28  2:14 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-27 14:24 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cd4fb1b2ffc88911e4109444ff729e31920d01ec ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: cd4fb1b2ffc88911e4109444ff729e31920d01ec

Move DWARF index-related things to a separate file

I want to add a DWARF index-related feature (automatically produce index
files when loading objfiles in GDB), but I don't want to add many
hundred lines to the already too big dwarf2read.c.  I thought it would
be a logical split to move everything related to the DWARF index to its
own file.

I first tried to move everything that reads and writes DWARF indices to
a separate file, but found that the "read" part is a little bit
entangled with the rest of dwarf2read.c, so the line is hard to draw
about where to split.  The write part is quite isolated though, so I
moved this part to a new file, dwarf-index-write.c.  Some things are
necessary to both reading and writing indices, so I placed them in
dwarf-index-common.{c,h}.  The idea would be to have a
dwarf-index-read.c eventually that would use it too (for now that code
is still in dwarf2read.c).

This required moving some things to a new dwarf2read.h header, so they
can be read by the code that writes the index.

The patch is big in number of lines, but it's all existing code being
moved around.  The only changes are that some functions are not static
anymore, a declaration is added in a .h file, and therefore the comment
is moved there.

I built-tested it with a little and big endian target.

This patch is also available on the users/simark/split-dwarf2read
branch.

gdb/ChangeLog:

	* Makefile.in (COMMON_SFILES): Add dwarf-index-common.c and
	dwarf-index-write.c
	(HFILES_NO_SRCDIR): Add dwarf-index-common.h and dwarf2read.h.
	* dwarf-index-common.c: New file.
	* dwarf-index-common.h: New file.
	* dwarf-index-write.c: New file.
	* dwarf2read.c: Include dwarf2read.h and dwarf-index-common.h.
	(struct dwarf2_section_info): Move from here.
	(dwarf2_section_info_def): Likewise.
	(DEF_VEC_O (dwarf2_section_info_def)): Likewise.
	(offset_type): Likewise.
	(DW2_GDB_INDEX_SYMBOL_STATIC_SET_VALUE): Likewise.
	(DW2_GDB_INDEX_SYMBOL_KIND_SET_VALUE): Likewise.
	(DW2_GDB_INDEX_CU_SET_VALUE): Likewise.
	(byte_swap): Likewise.
	(MAYBE_SWAP): Likewise.
	(dwarf2_per_cu_ptr): Likewise.
	(DEF_VEC_P (dwarf2_per_cu_ptr)): Likewise.
	(struct tu_stats): Likewise.
	(struct dwarf2_per_objfile): Likewise.
	(struct dwarf2_per_cu_data): Likewise.
	(struct signatured_type): Likewise.
	(sig_type_ptr): Likewise.
	(DEF_VEC_P (sig_type_ptr)): Likewise.
	(INDEX4_SUFFIX): Likewise.
	(INDEX5_SUFFIX): Likewise.
	(DEBUG_STR_SUFFIX): Likewise.
	(dwarf2_read_section): Make non-static.
	(mapped_index_string_hash): Move from here.
	(dwarf5_djb_hash): Likewise.
	(file_write): Likewise.
	(class data_buf): Likewise.
	(struct symtab_index_entry): Likewise.
	(struct mapped_symtab): Likewise.
	(find_slot): Likewise.
	(hash_expand): Likewise.
	(add_index_entry): Likewise.
	(uniquify_cu_indices): Likewise.
	(class c_str_view): Likewise.
	(class c_str_view_hasher): Likewise.
	(class vector_hasher): Likewise.
	(write_hash_table): Likewise.
	(psym_index_map): Likewise.
	(struct addrmap_index_data): Likewise.
	(add_address_entry): Likewise.
	(add_address_entry_worker): Likewise.
	(write_address_map): Likewise.
	(symbol_kind): Likewise.
	(write_psymbols): Likewise.
	(struct signatured_type_index_data): Likewise.
	(write_one_signatured_type): Likewise.
	(recursively_count_psymbols): Likewise.
	(recursively_write_psymbols): Likewise.
	(class debug_names): Likewise.
	(check_dwarf64_offsets): Likewise.
	(psyms_seen_size): Likewise.
	(write_gdbindex): Likewise.
	(write_debug_names): Likewise.
	(assert_file_size): Likewise.
	(write_psymtabs_to_index): Likewise.
	(save_gdb_index_command): Likewise.
	(_initialize_dwarf2_read): Don't register the "save gdb-index"
	command.
	* dwarf2read.h: New file.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] problem looking up some symbols when they have a linkage name
@ 2018-03-27 14:13 sergiodj+buildbot
  2018-03-28  0:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-27 14:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 59cc4834e53565da1de4a7b615ed8890ed55c7da ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 59cc4834e53565da1de4a7b615ed8890ed55c7da

problem looking up some symbols when they have a linkage name

This patch fixes a known failure in gdb.ada/maint_with_ada.exp
(maintenance check-psymtabs). Another way to witness the same
issue is by considering the following Ada declarations...

   type Wrapper is record
      A : Integer;
   end record;
   u00045 : constant Wrapper := (A => 16#060287af#);
   pragma Export (C, u00045, "symada__cS");

... which declares a variable name "u00045" but with a linkage
name which is "symada__cS". This variable is a record with one
component, the Ada equivalent of a struct with one field in C.
Trying to print that variable's value currently yields:

    (gdb) p /x <symada__cS>
    'symada(char, signed)' has unknown type; cast it to its declared type

This indicates that GDB was only able to find the minimal symbol,
but not the full symbol. The expected output is:

    (gdb) print /x <symada__cS>
    $1 = (a => 0x60287af)

The error message gives a hint about what's happening: We processed
the symbol through gdb_demangle, which in the case of this particular
symbol name, ends up matching the C++ naming scheme. As a result,
the demangler transforms our symbol name into 'symada(char, signed)',
thus breaking Ada lookups.

This patch fixes the issue by first introducing a new language_defn
attribute called la_store_sym_names_in_linkage_form_p, which is a boolean
to be set to true for the few languages that do not want their symbols
to have their names stored in demangled form, and false otherwise.
We then use this language attribute to skip the call to gdb_demangle
for all languages whose la_store_sym_names_in_linkage_form_p is true.

In terms of the selection of languages for which the new attribute
is set to true, the selection errs on the side of preserving the
existing behavior, and only changes the behavior for the languages
where we are certain storing symbol names in demangling form is not
needed. It is conceivable that other languages might be in the same
situation, but I not knowing in detail the symbol name enconding
strategy, I decided to play it safe and let other language maintainers
potentially adjust their language if it makes sense to do so.

gdb/ChangeLog:

        PR gdb/22670
        * dwarf2read.c (dwarf2_physname): Do not return the demangled
        symbol name if the CU's language stores symbol names in linkage
        format.
        * language.h (struct language_defn)
        <la_store_sym_names_in_linkage_form_p>: New field.  Adjust
        all instances of this struct.

gdb/testsuite/ChangeLog:

        * gdb.ada/maint_with_ada.exp: Remove PR gdb/22670 setup_kfail.

        * gdb.ada/notcplusplus: New testcase.

        * gdb.base/c-linkage-name.c: New file.
        * gdb.base/c-linkage-name.exp: New testcase.

Tested on x86_64-linux.
This also passes AdaCore's internal GDB testsuite.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Simplify exception handling in py-framefilter.c
@ 2018-03-27  7:12 sergiodj+buildbot
  2018-03-27 22:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-27  7:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 76c939acfd21928957b45816bf78935363438b0a ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 76c939acfd21928957b45816bf78935363438b0a

Simplify exception handling in py-framefilter.c

This patch changes py-framefilter.c as suggested by Pedro in:
https://sourceware.org/ml/gdb-patches/2017-06/msg00748.html

In particular, gdb exceptions are now caught at the outermost layer,
rather than in each particular function.  This simplifies much of the
code.

gdb/ChangeLog
2018-03-26  Tom Tromey  <tom@tromey.com>

	* python/py-framefilter.c (py_print_type): Don't catch
	exceptions.  Return void.
	(py_print_value): Likewise.
	(py_print_single_arg): Likewise.
	(enumerate_args): Don't catch exceptions.
	(py_print_args): Likewise.
	(py_print_frame): Likewise.
	(gdbpy_apply_frame_filter): Catch exceptions here.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Improve "backtrace" help text
@ 2018-03-27  6:58 sergiodj+buildbot
  2018-03-27 20:57 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-27  6:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9507b29c0a00fb62f015fe69f82aaf8f5377ab35 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 9507b29c0a00fb62f015fe69f82aaf8f5377ab35

Improve "backtrace" help text

This improves help text in stack.c in two ways.  First, it removes
trailing newlines from various help strings.  I think these are never
needed.  Second, it adds a "Usage" line to the "backtrace" text, as
suggested by Pedro.

gdb/ChangeLog
2018-03-26  Tom Tromey  <tom@tromey.com>

	* stack.c (_initialize_stack): Remove trailing newlines from help
	text.  Add "Usage" line to "backtrace" help.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Call wrap_hint in one more spot in py-framefilter.c
@ 2018-03-27  6:44 sergiodj+buildbot
  2018-03-27 19:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-27  6:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT eb68e48764d4b038858dd4255ed248dbee6c4c0e ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: eb68e48764d4b038858dd4255ed248dbee6c4c0e

Call wrap_hint in one more spot in py-framefilter.c

PR python/16486 notes that "bt" output is still wrapped differently
when a frame filter is in use.  This patch brings it a bit closer by
adding one more wrap_hint call, in a place where stack.c does this as
well.

gdb/ChangeLog
2018-03-26  Tom Tromey  <tom@tromey.com>

	PR python/16486:
	* python/py-framefilter.c (py_print_args): Call wrap_hint.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Move some code later in backtrace_command_1
@ 2018-03-27  6:17 sergiodj+buildbot
  2018-03-27 16:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-27  6:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fb7eb8b5826f059e2b7a18e42ff9c20972e626bc ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: fb7eb8b5826f059e2b7a18e42ff9c20972e626bc

Move some code later in backtrace_command_1

PR backtrace/15584 notes that some code in backtrace_command_1 is not
useful when frame filters are in use.  This patch moves this code into
the no-frame-filters "if".  This also removes the unused local
"trailing_level", which I noticed while moving the code around.

gdb/ChangeLog
2018-03-26  Tom Tromey  <tom@tromey.com>

	PR backtrace/15584:
	* stack.c (backtrace_command_1): Move some code into no-filters
	"if".


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Avoid manual resource management in py-framefilter.c
@ 2018-03-27  5:17 sergiodj+buildbot
  2018-03-27 11:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-27  5:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7a630bc2f99fcd55ddd83274574531d526ca1925 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 7a630bc2f99fcd55ddd83274574531d526ca1925

Avoid manual resource management in py-framefilter.c

This patch removes the last bit of manual resource management from
py-framefilter.c.  This will be useful in the next patch.

gdb/ChangeLog
2018-03-26  Tom Tromey  <tom@tromey.com>

	* python/py-framefilter.c (enumerate_args): Use
	gdb::unique_xmalloc_ptr.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Allow hiding of some filtered frames
@ 2018-03-27  4:49 sergiodj+buildbot
  2018-03-27  8:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-27  4:49 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 978d6c756fcb0332ddf12e19305dd0e53b98a93d ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 978d6c756fcb0332ddf12e19305dd0e53b98a93d

Allow hiding of some filtered frames

When a frame filter elides some frames, they are still printed by
"bt", indented a few spaces.  PR backtrace/15582 notes that it would
be nice for users if elided frames could simply be dropped.  This
patch adds this capability.

gdb/ChangeLog
2018-03-26  Tom Tromey  <tom@tromey.com>

	PR backtrace/15582:
	* stack.c (backtrace_command): Parse "hide" argument.
	* python/py-framefilter.c (py_print_frame): Handle PRINT_HIDE.
	* extension.h (enum frame_filter_flags) <PRINT_HIDE>: New
	constant.

gdb/doc/ChangeLog
2018-03-26  Tom Tromey  <tom@tromey.com>

	PR backtrace/15582:
	* gdb.texinfo (Backtrace): Mention "hide" argument.

gdb/testsuite/ChangeLog
2018-03-26  Tom Tromey  <tom@tromey.com>

	PR backtrace/15582:
	* gdb.python/py-framefilter.exp: Add "bt hide" test.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Change backtrace_command_1 calling to use flags
@ 2018-03-27  4:34 sergiodj+buildbot
  2018-03-27  6:46 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-27  4:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1cf7e64086d1490649dc56e1c0505be91c600218 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 1cf7e64086d1490649dc56e1c0505be91c600218

Change backtrace_command_1 calling to use flags

The next patch will add more flags to backtrace_command_1; and rather
than add another boolean argument, this patch changes it to accept a
flags value.

gdb/ChangeLog
2018-03-26  Tom Tromey  <tom@tromey.com>

	* stack.c (backtrace_command_1): Remove "show_locals" parameter,
	add "flags".
	(backtrace_command): Remove "fulltrace", add "flags".


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Rationalize "backtrace" command line parsing
@ 2018-03-27  4:21 sergiodj+buildbot
  2018-03-27  5:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-27  4:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ea3b06874c8a1037bad4fd5b9396d196e6963ac6 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: ea3b06874c8a1037bad4fd5b9396d196e6963ac6

Rationalize "backtrace" command line parsing

The backtrace command has peculiar command-line parsing.  In
particular, it splits the command line, then loops over the arguments.
If it sees a word it recognizes, like "full", it effectively drops
this word from the argument vector.  Then, it pastes together the
remaining arguments, passing them on to backtrace_command_1, which in
turn passes the resulting string to parse_and_eval_long.

The documentation doesn't mention the parse_and_eval_long at all, so
it is a bit of a hidden feature that you can "bt 3*2".  The strange
algorithm above also means you can "bt 3 * no-filters 2" and get 6
frames...

This patch changes backtrace's command line parsing to be a bit more
rational.  Now, special words like "full" are only recognized at the
start of the command.

This also updates the documentation to describe the various bt options
individually.

gdb/ChangeLog
2018-03-26  Tom Tromey  <tom@tromey.com>

	* stack.c (backtrace_command): Rewrite command line parsing.

gdb/doc/ChangeLog
2018-03-26  Tom Tromey  <tom@tromey.com>

	* gdb.texinfo (Backtrace): Describe options individually.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make gdbserver reg_defs a vector of objects
@ 2018-03-26 11:05 sergiodj+buildbot
  2018-03-26 12:13 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-26 11:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5cd3e386e0ac84b0ba1e0737853f4504ba24f677 ***

Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: 5cd3e386e0ac84b0ba1e0737853f4504ba24f677

Make gdbserver reg_defs a vector of objects

gdb/
	* regformats/regdef.h (reg): Add constructors.

gdb/gdbserver/
	* regcache.c (find_register_by_number): Return a ref.
	(find_regno): Use references.
	(register_size): Likewise.
	(register_data): Likewise.
	* tdesc.c (target_desc::~target_desc): Remove free calls.
	(target_desc::operator==): Use std::vector compare.
	(init_target_desc): Use reference.
	(tdesc_create_reg): Use reg constructors.
	* tdesc.h (struct target_desc): Replace pointer with object.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] aarch64: Make "info address" resolve TLS variables
@ 2018-03-24  3:23 sergiodj+buildbot
  2018-03-24  4:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-24  3:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bce02d8884d6baa72c537d0d7c59f924cb290799 ***

Author: Weimin Pan <weimin.pan@oracle.com>
Branch: master
Commit: bce02d8884d6baa72c537d0d7c59f924cb290799

aarch64: Make "info address" resolve TLS variables

TLS variables can't be resolved on aarch64-linux-gnu

Running the test case with upstream gdb shows two failures:

(1) Receiving different error messages when printing TLS variable before
    program runs - because the ARM compiler does not emit dwarf attribute
    DW_AT_location for TLS, the result is expected and the baseline may
    need to be changed for aarch64.

(2) Using "info address" command on C++ static TLS object resulted in
    "symbol unresolved" error - below is a snippet from the test case:

class K {
 public:
  static __thread int another_thread_local;
};

__thread int K::another_thread_local;

(gdb) info address K::another_thread_local
Symbol "K::another_thread_local" is unresolved.

This patch contains fix for (2).

Function info_address_command() handles the "info address" command and
calls lookup_minimal_symbol_and_objfile() to find sym's symbol entry in
mininal symbol table if SYMBOL_COMPUTED_OPS (sym) is false. Problem is
that function lookup_minimal_symbol_and_objfile() only looked up an
objfile's minsym ordinary hash table, not its demangled hash table, which
was the reason why the C++ name was not found.

The fix is to call lookup_minimal_symbol(), which already looks up entries
in both minsym's hash tables, to find names when traversing the object file
list in lookup_minimal_symbol_and_objfile().

Tested in both aarch64-linux-gnu and amd64-linux-gnu. No regressions.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdb: Fix testsuite issue in gdb.arch/amd64-disp-step-avx.exp
@ 2018-03-23 13:00 sergiodj+buildbot
  2018-03-23 15:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-23 13:00 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 376be529a7c99a70050bc48c51d891f1bea9777f ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 376be529a7c99a70050bc48c51d891f1bea9777f

gdb: Fix testsuite issue in gdb.arch/amd64-disp-step-avx.exp

This test starts up and confirms that $xmm0 has the value 0, it then
modifies $xmm0 (in the inferior) and confirms that the new value can
be read (in GDB).

On some machines I was noticing that this test would occasionally
fail, and on investigation I believe that the reason for this is that
the test is linked as a dynamically linked executable and makes use of
the system libraries during startup.  The reason that this causes
problems is that both the runtime linker and the startup code run
before main can, and do (on at least some platforms) make use of the
XMM registers.

In this commit I modify the test program slightly to allow it to be
linked statically, without using the startup libraries.  Now by the
time GDB reaches the symbol main we have only executed one 'nop'
instruction, and the XMM registers should all have the value 0.  I've
extended the test script to confirm that $xmm0 to $xmm15 are all
initially 0, and I also check that at the point after $xmm0 has been
modified, all the other XMM registers ($xmm1 to $xmm15) are still 0.

The test program is still linked against libc in order that we can
call the exit function, however, we now call _exit rather than exit in
order to avoid all of the usual cleanup that exit does.  This clean up
tries to tear down things that are usually setup during the startup
code, but now this isn't called calling exit will just result in a
crash.

gdb/testsuite/ChangeLog:

	* gdb.arch/amd64-disp-step-avx.S: Add '_start' label.
	(done): Call '_exit' not 'exit' to avoid atexit handlers.
	* gdb.arch/amd64-disp-step-avx.exp: Pass -static, and
	-nostartfiles when compiling the test.  Confirm that all registers
	xmm0 to xmm15 are initially 0, and that xmm1 to xmm15 are 0 after.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdb: Minor cleanup in some gdb.arch/* tests
@ 2018-03-23 12:14 sergiodj+buildbot
  2018-03-23 14:05 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-23 12:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 066cfa988ddf88ad32b7a114f2e984a13a3848c8 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 066cfa988ddf88ad32b7a114f2e984a13a3848c8

gdb: Minor cleanup in some gdb.arch/* tests

A small number of tests incorrectly tried to pass -Wa,-g through to
GCC as an extra compile time flag, either to gdb_compile or
prepare_for_testing.

The problem is that the syntax used for passing the flags was
incorrect, and as a result these extra flags were being ignored.
Luckily, the 'debug' flag was being passed in each case anyway, which
means that the '-g' flag would already be added.

Given that all these tests pass 'debug', and the invalid flag has been
ignored for some time, I'm just removing the flags in this commit.

I've also changed the tests from using gdb_compile to
prepare_for_testing, which allows some extra code to be removed from a
couple of tests scripts.

There should be no change in the test results after this commit.

gdb/testsuite/ChangeLog:

	* gdb.arch/amd64-disp-step-avx.exp: Remove unneeded assembler flag
	option, syntax was wrong anyway.
	* gdb.arch/arm-disp-step.exp: Likewise.
	* gdb.arch/sparc64-regs.exp: Likewise.
	* gdb.arch/amd64-disp-step.exp: Remove unneeded assembler flag
	option, syntax was wrong anyway, switch to use
	prepare_for_testing.
	* gdb.arch/i386-disp-step.exp: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Testsuite: fully migrate to use_gdb_stub convenience func
@ 2018-03-23  9:56 sergiodj+buildbot
  2018-03-23 11:05 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-23  9:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 079670b94ade4b5792fa74b29a6b5b4626f27185 ***

Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: 079670b94ade4b5792fa74b29a6b5b4626f27185

Testsuite: fully migrate to use_gdb_stub convenience func

In the GDB test suite, there are still multiple invocations of
"target_info exists use_gdb_stub".  However, the recommended way of
checking for use_gdb_stub is to call the convenience function of the same
name.

Replace these occurrences and just call "use_gdb_stub" instead.

gdb/testsuite/ChangeLog:

	* gdb.ada/exec_changed.exp: Replace "target_info exists
	use_gdb_stub" by "use_gdb_stub".
	* gdb.ada/start.exp: Likewise.
	* gdb.base/async-shell.exp: Likewise.
	* gdb.base/attach-pie-misread.exp: Likewise.
	* gdb.base/attach-wait-input.exp: Likewise.
	* gdb.base/break-entry.exp: Likewise.
	* gdb.base/break-interp.exp: Likewise.
	* gdb.base/dprintf-detach.exp: Likewise.
	* gdb.base/nostdlib.exp: Likewise.
	* gdb.base/solib-nodir.exp: Likewise.
	* gdb.base/statistics.exp: Likewise.
	* gdb.base/testenv.exp: Likewise.
	* gdb.mi/mi-exec-run.exp: Likewise.
	* gdb.mi/mi-start.exp: Likewise.
	* gdb.multi/dummy-frame-restore.exp: Likewise.
	* gdb.multi/multi-arch-exec.exp: Likewise.
	* gdb.multi/multi-arch.exp: Likewise.
	* gdb.multi/tids.exp: Likewise.
	* gdb.multi/watchpoint-multi.exp: Likewise.
	* gdb.python/py-events.exp: Likewise.
	* gdb.threads/attach-into-signal.exp: Likewise.
	* gdb.threads/attach-stopped.exp: Likewise.
	* gdb.threads/threadapply.exp: Likewise.
	* lib/selftest-support.exp: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove some cleanups from record-full.c
@ 2018-03-23  3:37 sergiodj+buildbot
  2018-03-23  4:46 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-23  3:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a2b2bc12af45f48617729c1413a1a01c0ee957ca ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: a2b2bc12af45f48617729c1413a1a01c0ee957ca

Remove some cleanups from record-full.c

This removes some cleanups from record-full.c in a straightforward
way.

Tested by the buildbot.

gdb/ChangeLog
2018-03-22  Tom Tromey  <tom@tromey.com>

	* record-full.c (record_full_exec_insn): Use gdb::byte_vector.
	(record_full_goto_bookmark): Use std::string.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] ppc: Fix stwux and stdux masks in skip_prologue
@ 2018-03-22 13:54 sergiodj+buildbot
  2018-03-22 20:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-22 13:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7a8f494c7b171f6cbad20a14ef03a5d7acaa6ccb ***

Author: Pedro Franco de Carvalho <pedromfc@linux.vnet.ibm.com>
Branch: master
Commit: 7a8f494c7b171f6cbad20a14ef03a5d7acaa6ccb

ppc: Fix stwux and stdux masks in skip_prologue

This patch merges the masks for matching the stwux and stdux
instructions in rs6000-tdep.c:skip_prologue into a single mask that
only matches these two instructions.

Commit 72dd273062 fixed the warning described in PR tdep/18295, this
patch addresses the comment in the same PR indicating that the mask
was too permissive.

gdb/Changelog:

	PR tdep/18295
	* rs6000-tdep.c (skip_prologue): Match both stwux and stdux
	a single mask.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] ppc: Detect when LR is saved through frame pointer
@ 2018-03-22 13:41 sergiodj+buildbot
  2018-03-22 19:20 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-22 13:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT dd6d677f0b06341dce90d259785c9d513d2e3935 ***

Author: Pedro Franco de Carvalho <pedromfc@linux.vnet.ibm.com>
Branch: master
Commit: dd6d677f0b06341dce90d259785c9d513d2e3935

ppc: Detect when LR is saved through frame pointer

This patch extends rs6000-tdep.c:skip_prologue so that it can detect
when the Link Register is saved using the frame pointer (usually r31)
in adition to the stack pointer (r1).

The frame pointer offset from the frame base is tracked separately
from the stack pointer offset for cases when the frame pointer is not
in synch with the stack pointer at the moment of the LR save.

Previously, "stq" could also be detected as an instruction that saves
LR or CR. Because this was likely unintentional, this patch also
restricts the matches to stw/stwu/std/stdu.

gdb/ChangeLog:

	* rs6000-tdep.c (store_insn_p): New function.
	(skip_prologue): New variable alloca_reg_offset. Set lr_reg
	and cr_reg to their unshifted values. Use store_insn_p to
	match LR saves using either R1 or fdata->alloca_reg. Use
	store_insn_p to match CR saves. Set alloca_reg_offset
	when alloca_reg and framep are set. Remove lr_reg shift
	when assigning to fdata->lr_register.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] S390: Correct brace style in s390_get_wordsize
@ 2018-03-22  9:20 sergiodj+buildbot
  2018-03-22 16:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-22  9:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f69c5afb18871a773af88484a24d7da12c3a104c ***

Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: f69c5afb18871a773af88484a24d7da12c3a104c

S390: Correct brace style in s390_get_wordsize

This corrects bad formatting in the newly introduced function
s390_get_wordsize.

gdb/gdbserver/ChangeLog:

	* linux-s390-low.c (s390_get_wordsize): Correct brace style.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: drop remaining redundant DispN
@ 2018-03-22  8:31 sergiodj+buildbot
  2018-03-22 13:47 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-22  8:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 96bc132a736fe44cc021d5d4e8ed6780b9520f22 ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 96bc132a736fe44cc021d5d4e8ed6780b9520f22

x86: drop remaining redundant DispN

A few of them were missed in commit 7ac2002247 ("x86: derive DispN
from BaseIndex") and also couldn't be removed by subsequent commits
touching certain templates anyway.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: fix swapped operand handling for BNDMOV
@ 2018-03-22  8:17 sergiodj+buildbot
  2018-03-22 12:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-22  8:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9f79e88693dae859f838bcf684158e6e6f8f3b6b ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 9f79e88693dae859f838bcf684158e6e6f8f3b6b

x86: fix swapped operand handling for BNDMOV

The wrong placement of the Load attribute in the templates prevented
this from working. The disassembler also didn't handle this consistently
with other similar dual-encoding insns.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86/Intel: fix fallout from earlier template folding
@ 2018-03-22  8:02 sergiodj+buildbot
  2018-03-22 11:05 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-22  8:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d6793fa1acf384a93c83db6eb916e3b9eedd9ef4 ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: d6793fa1acf384a93c83db6eb916e3b9eedd9ef4

x86/Intel: fix fallout from earlier template folding

While many templates allowing multiple suitably matching XMM/YMM/ZMM
operand sizes can be folded, a few need to be split in order to not
wrongly accept "xmmword ptr" operands when only XMM registers are
permitted (and memory operands are more narrow). Add a test case
validating this.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make parse_static_tracepoint_marker_definition work with multiple static tracepoint definitions
@ 2018-03-22  4:50 sergiodj+buildbot
  2018-03-22  5:54 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-22  4:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 62c222b6d9fcce8adf65f48fca2e528f777afeeb ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 62c222b6d9fcce8adf65f48fca2e528f777afeeb

Make parse_static_tracepoint_marker_definition work with multiple static tracepoint definitions

Since I modify the parse_static_tracepoint_marker_definition function in
the next patch, I wanted to write a unit test for it.  Doing so showed
that it doesn't handle multiple consecutive static tracepoint
definitions separated by commas.  However, the RSP documentation [1]
states that servers may return multiple definitions, like:

  1234:6d61726b657231:6578747261207374756666,abba:6d61726b657232:

The problem is that the function uses strlen to compute the length of
the last field (the extra field).  If there are additional definitions
in addition to the one we are currently parsing, the returned length
will include those definitions, and we'll try to hex-decode past the
extra field.

This patch changes parse_static_tracepoint_marker_definition to consider
the case where the current definition is followed by a comma and more
definitions.  It also adds the unit test that found the issue in the
first place.

I don't think this causes any backwards compatibility issues, because
the previous code only handled single static tracepoint definitions, and
the new code handles that correctly.

gdb/ChangeLog:

	* tracepoint.c (parse_static_tracepoint_marker_definition):
	Consider case where the definition is followed by more
	definitions.
	* Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
	tracepoint-selftests.c.
	* unittests/tracepoint-selftests.c: New.

[1] https://sourceware.org/gdb/onlinedocs/gdb/Tracepoint-Packets.html#qTfSTM


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add myself as a write-after-approval GDB maintainer.
@ 2018-03-21 20:49 sergiodj+buildbot
  2018-03-22  0:56 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-21 20:49 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7eb2418fa4641c60f6713986de7d3a50fd7a22c0 ***

Author: Pedro Franco de Carvalho <pedromfc@linux.vnet.ibm.com>
Branch: master
Commit: 7eb2418fa4641c60f6713986de7d3a50fd7a22c0

Add myself as a write-after-approval GDB maintainer.

gdb/ChangeLog:

2018-03-21  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>

	* MAINTAINERS (Write After Approval): Add Pedro Franco de
	Carvalho.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] DT_FLAGS_1: Add Solaris bits
@ 2018-03-21 20:10 sergiodj+buildbot
  2018-03-21 23:38 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-21 20:10 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b1202ffa53484b65d95787fddef1bc6175e05ca9 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: b1202ffa53484b65d95787fddef1bc6175e05ca9

DT_FLAGS_1: Add Solaris bits

The following bits in DT_FLAGS_1 are used by Solaris:

 #define DF_1_KMOD       0x10000000 /* kernel module */
 #define DF_1_WEAKFILTER 0x20000000 /* apply weak binding to DT_FILTER */
 #define DF_1_NOCOMMON   0x40000000 /* no COMMON symbols exist */

binutils/

	* readelf.c (process_dynamic_section): Also dump DF_1_KMOD,
	DF_1_WEAKFILTER and DF_1_NOCOMMON.

include/

	* elf/common.h (DF_1_KMOD): New.
	(DF_1_WEAKFILTER): Likewise.
	(DF_1_NOCOMMON): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PowerPC64 synthetic symbols
@ 2018-03-21 12:27 sergiodj+buildbot
  2018-03-21 18:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-21 12:27 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0ccf57bd817a73e7d7cef714039f1302fa5298ec ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 0ccf57bd817a73e7d7cef714039f1302fa5298ec

PowerPC64 synthetic symbols

STT_FILE and a bunch of other symbol types aren't proper symbols to
mark the start of a function's code.

	* elf64-ppc.c (ppc64_elf_get_synthetic_symtab): Trim uninteresting
	symbols.  Use size_t counts.  Delete redundant opd test.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make tls_mask unsigned in elf32-ppc.c
@ 2018-03-21 11:59 sergiodj+buildbot
  2018-03-21 15:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-21 11:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bac3c8c5e7fb88ddb3615b895ad57847b9842171 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: bac3c8c5e7fb88ddb3615b895ad57847b9842171

Make tls_mask unsigned in elf32-ppc.c

	* elf32-ppc.c (struct ppc_elf_link_hash_entry): Make tls_mask
	field unsigned.
	(update_local_sym_info): Likewise for local_got_tls_masks.
	(ppc_elf_tls_optimize): Likewise for lgot_masks.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Don't exceed reloc array bounds
@ 2018-03-21 11:32 sergiodj+buildbot
  2018-03-21 12:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-21 11:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 675e28092f9d92c56c38d40d13ad5b766bdede05 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 675e28092f9d92c56c38d40d13ad5b766bdede05

Don't exceed reloc array bounds

	* elf64-ppc.c (ppc64_elf_relocate_section): Don't access rel[1]
	without first checking array bounds.
	* elf32-ppc.c (ppc_elf_relocate_section): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Replace the linear search in find_pc_sect_line with a binary search.
@ 2018-03-20 14:14 sergiodj+buildbot
  2018-03-20 15:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-20 14:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4ee89e903de920496a69c01df70db13a70a2a0be ***

Author: Stephen Roberts <stephen.roberts@arm.com>
Branch: master
Commit: 4ee89e903de920496a69c01df70db13a70a2a0be

Replace the linear search in find_pc_sect_line with a binary search.

This patch addresses slowness when setting breakpoints, especially in
heavily templatized code. Profiling showed that find_pc_sect_line in
symtab.c was the performance bottleneck.  The original logic performed a
linear search over ordered data. This patch uses a binary search, as
suggested by comments around the function.  There are no behavioural
changes, but gdb is now faster at setting breakpoints in template code.
Tested using on make check on an x86 target. The optimisation speeds up
the included template-breakpoints.py performance test by a factor of 7
on my machine.

ChangeLog:

2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>

        * gdb/symtab.c (find_pc_sect_line): now uses binary search.

gdb/testsuite/

        * gdb.perf/template-breakpoints.cc: New file.
        * gdb.perf/template-breakpoints.exp: New file.
        * gdb.perf/template-breakpoints.py: New file.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Support bare-identifier field initializers in Rust
@ 2018-03-19 17:31 sergiodj+buildbot
  2018-03-19 18:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-19 17:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 926300415b642367cdc2febac6619f8cb8a80b46 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 926300415b642367cdc2febac6619f8cb8a80b46

Support bare-identifier field initializers in Rust

In Rust one can initialize a struct member from an identically-named
local variable by simply mentioning the member name in the
initializer, like:

    let x = 0;
    let y = Struct { x };

This initializes "Struct::x" from "x".

This patch adds this form of initializer to the Rust expression parser
and adds a test.

Tested on x86-64 Fedora 26 using rustc 1.23.

2018-03-19  Tom Tromey  <tom@tromey.com>

	* rust-exp.y (struct_expr_tail, struct_expr_list): Add plain
	"IDENT" production.

2018-03-19  Tom Tromey  <tom@tromey.com>

	* gdb.rust/simple.rs (main): Add local variables field1, field2,
	y0.
	* gdb.rust/simple.exp: Test bare identifier form of struct
	initializer.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Updated Spanish translation for the bfd/ sub-directory, and updated Ukranian translation for the gas/ sub-directory.
@ 2018-03-19 11:10 sergiodj+buildbot
  2018-03-19 12:11 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-19 11:10 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 315aa1cf834a3d78a567263fa3fbda9b2027457e ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 315aa1cf834a3d78a567263fa3fbda9b2027457e

Updated Spanish translation for the bfd/ sub-directory, and updated Ukranian translation for the gas/ sub-directory.

bfd	* po/es.po: Updated Spanish translation.
gas	* po/uk.po: Updated Ukranian translation.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove some cleanups from solib.c
@ 2018-03-19  4:11 sergiodj+buildbot
  2018-03-19  5:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-19  4:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1cb1f3dae747fef1a576fe38078891e545fa92e5 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 1cb1f3dae747fef1a576fe38078891e545fa92e5

Remove some cleanups from solib.c

This removes some cleanups from solib.c, replacing them with
gdb::def_vector.

Regression tested by the buildbot.

gdb/ChangeLog
2018-03-18  Tom Tromey  <tom@tromey.com>

	* solib.c (gdb_bfd_lookup_symbol_from_symtab): Use
	gdb::def_vector.
	(bfd_lookup_symbol_from_dyn_symtab): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add silent Makefile rules
@ 2018-03-16 21:30 sergiodj+buildbot
  2018-03-16 23:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-16 21:30 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 39be3c7e98728df57cfddd37fb7747f1339a319b ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 39be3c7e98728df57cfddd37fb7747f1339a319b

Add silent Makefile rules

Many projects (e.g. the Linux kernel) and build systems use "silent"
rules, which means that they'll only print a summary of what's being
done instead of printing all the detailed command lines.  While chatting
on the #gdb IRC channel, I realized a few people (including me) thought
it would be nice to have it in GDB too.

The idea is that too much text is not useful, the important information
gets lost.  If there's only the essential information, it's more likely
to be useful.  Most of the time, when I look at the build output, it's
to see how it's progressing.  By just printing a brief summary of each
operation, I can easily spot what's currently being compiled and
therefore how the build progresses (with time you know the order in
which files are compiled almost by heart).

As with other projects (Linux, automake-based things, probably others),
it's possible to print the complete command lines by passing V=1 to make
(or any other non-zero value).

I had one hesitation about this: when people report build failures, we
are more likely to miss the full compile command line.  We'll probably
sometimes need to ask people to include the build log with "make V=1".
I don't think it's a big downside, if other projects the size of the
Linux kernel can live with it, I'm sure we can too.

gdb/ChangeLog:

	* silent-rules.mk: New.
	* Makefile.in: Include silent-rules.mk
	(srcdir, VPATH, top_srcdir): Move up.
	(COMPILE): Add ECHO_CXX.
	(test-cp-name-parser$(EXEEXT)): Add ECHO_CXXLD.
	(init.c): Add ECHO_INIT_C.
	(gdb$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
	(version.c): Add ECHO_GEN.
	(printcmd.o): Add ECHO_CXX.
	(target-float.o): Add ECHO_CXX.
	(ada-exp.o): Add ECHO_CXX.
	(stamp-xml): Add SILENCE and ECHO_GEN_XML_BUILTIN.
	(insight$(EXEEXT)): Add ECHO_CXXLD.
	* gnulib/configure.ac: Add AM_SILENT_RULES.
	* gnulib/aclocal.m4: Re-generate.
	* gnulib/configure: Re-generate.
	* gnulib/import/Makefile.in: Re-generate.

gdb/gdbserver/ChangeLog:

	* Makefile.in: Include silent-rules.mk.
	(srcdir, abs_top_srcdir, abs_srcdir, VPATH): Move up.
	(COMPILE): Add ECHO_CXX.
	(gdbserver$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
	(gdbreplay$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
	($(IPA_LIB)): Add SILENCE and ECHO_CXXLD.
	(version-generated.c): Add ECHO_GEN.
	(stamp-xml): Add SILENCE and ECHO_GEN_XML_BUILTIN_GENERATED.
	(IPAGENT_COMPILE): Add ECHO_CXX.
	(%-generated.c): Add ECHO_REGDAT.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add selftest for substitute_path_component
@ 2018-03-16  2:19 sergiodj+buildbot
  2018-03-16  3:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-16  2:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 03afa6ef8ac9e5acfa68b1005aec6756eaa1d093 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 03afa6ef8ac9e5acfa68b1005aec6756eaa1d093

Add selftest for substitute_path_component

This patch add some unit tests for the substitute_path_component
function.

gdb/ChangeLog:

	* Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
	unittests/utils-selftests.c.
	* unittests/utils-selftests.c: New file.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] nds32: Remove the unsupported target feature.
@ 2018-03-15  8:04 sergiodj+buildbot
  2018-03-15  9:11 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-15  8:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f9671640954362a918c669700bcc9a57be25782d ***

Author: Kuan-Lin Chen <kuanlinchentw@gmail.com>
Branch: master
Commit: f9671640954362a918c669700bcc9a57be25782d

nds32: Remove the unsupported target feature.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Allow - in %p for printf
@ 2018-03-14 17:26 sergiodj+buildbot
  2018-03-14 18:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-14 17:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b8c2339b2f46d4885b933b832fc5b37c7ca101a6 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: b8c2339b2f46d4885b933b832fc5b37c7ca101a6

Allow - in %p for printf

PR cli/19918 points out that a printf format like "%-5p" will cause a
gdb crash.  The bug is problem is that printf_pointer doesn't take the
"-" flag into account.

gdb/ChangeLog
2018-03-14  Tom Tromey  <tom@tromey.com>

	PR cli/19918:
	* printcmd.c (printf_pointer): Allow "-" in format.

gdb/testsuite/ChangeLog
2018-03-14  Tom Tromey  <tom@tromey.com>

	PR cli/19918:
	* gdb.base/printcmds.exp (test_printf): Add printf test using '-'
	flag.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Special case NULL when using printf's %s format
@ 2018-03-14 16:46 sergiodj+buildbot
  2018-03-14 19:57 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-14 16:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3ae9ce5dd7d1119ca2c94c63a07b04921048ebe3 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 3ae9ce5dd7d1119ca2c94c63a07b04921048ebe3

Special case NULL when using printf's %s format

This changes the printf command's %s and %ls formats to special-case
NULL, and print "(null)" for these.  This is PR cli/14977.  This
behavior seems a bit friendlier; I was undecided on whether other
invalid pointers should be handled specially somehow, so for the time
being I've left those out.

gdb/ChangeLog
2018-03-14  Tom Tromey  <tom@tromey.com>

	PR cli/14977:
	* printcmd.c (printf_c_string, printf_wide_c_string): Special case
	for NULL.

gdb/gdbserver/ChangeLog
2018-03-14  Tom Tromey  <tom@tromey.com>

	PR cli/14977:
	* ax.c (ax_printf): Special case for NULL.

gdb/testsuite/ChangeLog
2018-03-14  Tom Tromey  <tom@tromey.com>

	PR cli/14977:
	* gdb.base/printcmds.exp (test_printf): Add printf test of %s with
	a null pointer.
	* gdb.base/wchar.exp: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add usage to printf command
@ 2018-03-14 16:04 sergiodj+buildbot
  2018-03-14 17:18 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-14 16:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 80ae639d3cc4f1e83f1ad48686f87417c06ca6dc ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 80ae639d3cc4f1e83f1ad48686f87417c06ca6dc

Add usage to printf command

This patch adds the "Usage:" text to the printf command's help text,
and tries to improve the text a tiny bit.

gdb/ChangeLog
2018-03-14  Tom Tromey  <tom@tromey.com>

	* printcmd.c (_initialize_printcmd): Add usage to printf.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Update my email address
@ 2018-03-14 13:59 sergiodj+buildbot
  2018-03-14 15:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-14 13:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0d671d99a6125e8406e4d06efb58542d3f0aa955 ***

Author: Yao Qi <qiyao@sourceware.org>
Branch: master
Commit: 0d671d99a6125e8406e4d06efb58542d3f0aa955

Update my email address

gdb:

2018-03-14  Yao Qi  <qiyao@sourceware.org>

	* MAINTAINERS: Update my email address.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PowerPC64 debian bug 886264, out-of-line save/restore functions
@ 2018-03-14 12:19 sergiodj+buildbot
  2018-03-14 14:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-14 12:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7dda8d3cf3b089bb7e03c4cdbec827fc6a188c88 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 7dda8d3cf3b089bb7e03c4cdbec827fc6a188c88

PowerPC64 debian bug 886264, out-of-line save/restore functions

This calculation in relocate_section

	      if (stub_entry->stub_type == ppc_stub_save_res)
		relocation += (stub_sec->output_offset
			       + stub_sec->output_section->vma
			       + stub_sec->size - htab->sfpr->size
			       - htab->sfpr->output_offset
			       - htab->sfpr->output_section->vma);

to adjust from the original out-of-line save/restore function address
in sfpr to a copy at the end of stub_sec goes wrong when stub_sec is
padded, because the copy is no longer at the end of stub_sec.  The
solution is to pad before copying sfpr, so the copy is always at the
end of stub_sec.

	* elf64-ppc.c (sfpr_define): Adjust for stub_sec size having
	sfpr size added before defining alias symbols.
	(ppc64_elf_build_stubs): Add stub section padding before
	copying sfpr contents and defining save/restore alias symbols.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove two cleanups using std::string
@ 2018-03-13 23:55 sergiodj+buildbot
  2018-03-14  0:59 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-13 23:55 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b577b6af8e7f4cc53e73ee01188d1700fb8d3b82 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: b577b6af8e7f4cc53e73ee01188d1700fb8d3b82

Remove two cleanups using std::string

This patches removes cleanups from a couple of spots by using
std::string rather than manual memory management.

Regression tested by the buildbot, though note that I don't believe
the buildbot actually exercises the machoread code.

gdb/ChangeLog
2018-03-13  Tom Tromey  <tom@tromey.com>

	* machoread.c (macho_check_dsym): Change filenamep to a
	std::string*.
	(macho_symfile_read): Update.
	* symfile.c (load_command): Use std::string.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Prevent memory access violations when attempting to parse an x86_64 PE binary containing corrupt unwind information.
@ 2018-03-13 14:19 sergiodj+buildbot
  2018-03-13 16:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-13 14:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3e33b239450771394fa6c83b67b9de80169f35e8 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 3e33b239450771394fa6c83b67b9de80169f35e8

Prevent memory access violations when attempting to parse an x86_64 PE binary containing corrupt unwind information.

	PR 22113
incldue	* coff/pe.h (struct pex64_unwind_info): Add a rawUnwindCodesEnd
	field.

bfd	* pei-x86_64.c (pex64_get_unwind_info): Change to a boolean
	function.  Add an end address parameter.  Check access of the data
	pointer to make sure that they do not extend beyond the end
	address.  Return FALSE if any check fails.  Add the end address
	pointer to the ui structure.
	(pex64_xdata_print_uwd_codes): Check accesses of the raw unwind
	codes to make sure that they do not extend beyond the end address
	pointer.  Print an error message and return immediately if any
	check fails.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdb/riscv: Fix some ARI issues
@ 2018-03-12 22:14 sergiodj+buildbot
  2018-03-12 23:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-12 22:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 89a3b63e52be3e9bcf4b3d15e210652a5cb839c5 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 89a3b63e52be3e9bcf4b3d15e210652a5cb839c5

gdb/riscv: Fix some ARI issues

Fix some ARI issues in recently added riscv code, the ARI email is:

  https://sourceware.org/ml/gdb-patches/2018-03/msg00156.html

gdb/ChangeLog:

	* riscv-tdep.c (riscv_sw_breakpoint_from_kind): Add localization
	to error message string.
	(riscv_register_name): Use xsnprintf instead of sprintf.
	(riscv_insn::fetch_instruction): Use gdb_assert instead of
	internal_error.
	(riscv_print_arg_location): Use gdb_assert_not_reached instead of
	error.
	(riscv_push_dummy_call): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Use gdb::byte_vector when reading section data
@ 2018-03-12 14:44 sergiodj+buildbot
  2018-03-12 15:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-12 14:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 984c72381ccd9f950a87d4d7edecc6fa30db8b41 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 984c72381ccd9f950a87d4d7edecc6fa30db8b41

Use gdb::byte_vector when reading section data

This changes a couple of spots that read section data to use
gdb::byte_vector rather than a cleanup.

Regression tested by the buildbot.  I am not certain that the buildbot
actually tests the code in question, so I recommend careful review.

gdb/ChangeLog
2018-03-12  Tom Tromey  <tom@tromey.com>

	* rs6000-aix-tdep.c (rs6000_aix_core_xfer_shared_libraries_aix):
	Use gdb::byte_vector.
	* arm-tdep.c (arm_exidx_new_objfile): Use gdb::byte_vector.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove cleanup from build_type_psymtabs_1
@ 2018-03-12  3:22 sergiodj+buildbot
  2018-03-12  4:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-12  3:22 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 484cf504af0e9403e3437a5d2c5fb361c73daa90 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 484cf504af0e9403e3437a5d2c5fb361c73daa90

Remove cleanup from build_type_psymtabs_1

This removes a cleanup from build_type_psymtabs_1, by using
std::vector rather than manual memory management.

gdb/ChangeLog
2018-03-11  Tom Tromey  <tom@tromey.com>

	* dwarf2read.c (sort_tu_by_abbrev_offset): Change to be suitable
	for use by std::sort.
	(build_type_psymtabs_1): Use std::vector.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Use scoped_fd in more places
@ 2018-03-09  5:23 sergiodj+buildbot
  2018-03-09 23:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-09  5:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5dc1a7047a77f86de7518a99805af64891d4e22a ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 5dc1a7047a77f86de7518a99805af64891d4e22a

Use scoped_fd in more places

This changes a few more places to use scoped_fd.  This allows the
removal of some cleanups.

Regression tested by the buildbot, though note that I'm not sure
whether the buildbot actually builds anything using all of these
files.

gdb/ChangeLog
2018-03-08  Tom Tromey  <tom@tromey.com>

	* source.c (get_filename_and_charpos): Use scoped_fd.
	* nto-procfs.c (procfs_open_1): Use scoped_fd.
	(procfs_pidlist): Likewise.
	* procfs.c (proc_get_LDT_entry): Use scoped_fd.
	(iterate_over_mappings): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make find_separate_debug_file* return std::string
@ 2018-03-09  0:12 sergiodj+buildbot
  2018-03-09 18:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-09  0:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a8dbfd5853e3a5f7f2a3ca817e96d9e0759061a2 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: a8dbfd5853e3a5f7f2a3ca817e96d9e0759061a2

Make find_separate_debug_file* return std::string

This patch makes the find_separate_debug_file* functions return
std::string, which allows to get rid of some manual memory management
and one cleanup.

gdb/ChangeLog:

	* build-id.c (find_separate_debug_file_by_buildid): Return
	std::string.
	* build-id.h (find_separate_debug_file_by_buildid): Return
	std::string.
	* coffread.c (coff_symfile_read): Adjust to std::string.
	* elfread.c (elf_symfile_read): Adjust to std::string.
	* symfile.c (separate_debug_file_exists): Change parameter to
	std::string.
	(find_separate_debug_file): Return std::string.
	(find_separate_debug_file_by_debuglink): Return std::string.
	* symfile.h (find_separate_debug_file_by_debuglink): Return
	std::string.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86-64: Also optimize "clr reg64"
@ 2018-03-08 20:05 sergiodj+buildbot
  2018-03-09 12:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-08 20:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d3d50934a9101416c3106497d6ea9ce548760253 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: d3d50934a9101416c3106497d6ea9ce548760253

x86-64: Also optimize "clr reg64"

"clr reg" is an alias of "xor reg, reg".  We can encode "clr reg64" as
"xor reg32, reg32".

gas/

	* config/tc-i386.c (optimize_encoding): Also encode "clr reg64"
	as "xor reg32, reg32".
	* testsuite/gas/i386/x86-64-optimize-1.s: Add "clr reg64" tests.
	* testsuite/gas/i386/x86-64-optimize-1.d: Updated.

opcodes/

	* i386-opc.tbl: Add Optimize to clr.
	* i386-tbl.h: Regenerated.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: fold LWP templates
@ 2018-03-08 13:06 sergiodj+buildbot
  2018-03-08 21:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-08 13:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e7f5c0a99ec597c097cf65e0c8503b7075e32d16 ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: e7f5c0a99ec597c097cf65e0c8503b7075e32d16

x86: fold LWP templates

Also drop the no longer necessary explicit Disp<N> from them.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: fold VEX-encoded GFNI templates
@ 2018-03-08  9:44 sergiodj+buildbot
  2018-03-09  2:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-08  9:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 454172a99e4aebafa2cd42d389cd63a8733a046a ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 454172a99e4aebafa2cd42d389cd63a8733a046a

x86: fold VEX-encoded GFNI templates


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: fold FMA and FMA4 templates
@ 2018-03-08  9:07 sergiodj+buildbot
  2018-03-08 19:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-08  9:07 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 25a4277fec9efb37b107f6bb6c9246f05cd3c348 ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 25a4277fec9efb37b107f6bb6c9246f05cd3c348

x86: fold FMA and FMA4 templates


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: drop bogus NoAVX
@ 2018-03-08  8:43 sergiodj+buildbot
  2018-03-08 15:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-08  8:43 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1b193f0b1263a677f630fb419d13fc14a1d99981 ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 1b193f0b1263a677f630fb419d13fc14a1d99981

x86: drop bogus NoAVX

These are meaningful only for insns with CpuSSE* (and a few other Cpu*)
attribute.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: bogus VMOVD with 64-bit operands should only allow for registers
@ 2018-03-08  8:27 sergiodj+buildbot
  2018-03-08 10:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-08  8:27 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2907c2f55555de6b1df9a0262629003f4856807d ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 2907c2f55555de6b1df9a0262629003f4856807d

x86: bogus VMOVD with 64-bit operands should only allow for registers

These templates exist solely to satisfy gcc's needs, and gcc only
produces these with register operands.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: drop FloatD
@ 2018-03-08  8:19 sergiodj+buildbot
  2018-03-08 12:50 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-08  8:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 38e314eb064ae94318deaa9544c2da3f46f5d319 ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 38e314eb064ae94318deaa9544c2da3f46f5d319

x86: drop FloatD

It can be expressed by D, when making the consumer look at operand size
to tell apart both uses.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Return gdb::optional<std::string> from target_fileio_readlink
@ 2018-03-07 23:02 sergiodj+buildbot
  2018-03-08  0:05 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-07 23:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e0d3522b888033febd153a4a7d3b7c5c13641f09 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: e0d3522b888033febd153a4a7d3b7c5c13641f09

Return gdb::optional<std::string> from target_fileio_readlink

This changes to_fileio_readlink and target_fileio_readlink to return a
gdb::optional<std::sring>, and then fixes up the callers and
implementations.  This allows the removal of some cleanups.

Regression tested by the buildbot.

gdb/ChangeLog
2018-03-07  Tom Tromey  <tom@tromey.com>

	* linux-tdep.c (linux_info_proc): Update.
	* target.h (struct target_ops) <to_fileio_readlink>: Return
	optional<string>.
	(target_fileio_readlink): Return optional<string>.
	* remote.c (remote_hostio_readlink): Return optional<string>.
	* inf-child.c (inf_child_fileio_readlink): Return
	optional<string>.
	* target.c (target_fileio_readlink): Return optional<string>.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdb: Add riscv to list of architectures with a save_reggroup
@ 2018-03-07 17:55 sergiodj+buildbot
  2018-03-07 19:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-07 17:55 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ea005f31ca7a823680c70a75ae073bee52487859 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: ea005f31ca7a823680c70a75ae073bee52487859

gdb: Add riscv to list of architectures with a save_reggroup

The regcache cooked_read test needs to know which architectures have a
save_reggroup, riscv does and needs adding to the list.

gdb/ChangeLog:

	* regcache.c (cooked_read_test): Add riscv to the list of
	architectures that have a save_reggroup.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [PR20402][LD][AARCH64]Don't emit RELATIVE relocation for absolute symbols which are resolved at static linking time.
@ 2018-03-07 17:03 sergiodj+buildbot
  2018-03-07 18:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-07 17:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0c1ded8dc0be9c61975e04a0b416b064223f7bda ***

Author: Renlin Li <renlin.li@arm.com>
Branch: master
Commit: 0c1ded8dc0be9c61975e04a0b416b064223f7bda

[PR20402][LD][AARCH64]Don't emit RELATIVE relocation for absolute symbols which are resolved at static linking time.

For absolute symbols which are forced local or not dynamic, the ABS relocation
should be resolved at static linking time.

Originally, an RELATIVE/ABS relocation will be generated even for absolution
symbols for the dynamic linker to resolve.

bfd/

2018-03-07  Renlin Li  <renlin.li@arm.com>

	PR ld/20402
	* elfnn-aarch64.c (elfNN_aarch64_final_link_relocate): Check absolute symbol,
	and don't emit relocation in specific case.

ld/

2018-03-07  Renlin Li  <renlin.li@arm.com>

	PR ld/20402
	* testsuite/ld-aarch64/aarch64-elf.exp: Run new test.
	* testsuite/ld-aarch64/pr20402.s: New.
	* testsuite/ld-aarch64/pr20402.d: New.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] XCOFF disassembler
@ 2018-03-07  7:12 sergiodj+buildbot
  2018-03-07  9:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-07  7:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 52fe4420b771a0f3b4fc7c6535bbd6e9b279f775 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 52fe4420b771a0f3b4fc7c6535bbd6e9b279f775

XCOFF disassembler

xcoff (32-bit) objdump accepted but ignored -M options unless
-mpowerpc was also given.  This patch fixes that, leaving the default
as -Mpwr for xcoff.  I've also enabled more tests for xcoff targets.

binutils/
	* configure.ac: Add objdump_private_desc_xcoff for rs6000.
	* configure: Regenerate.
gas/
	* testsuite/gas/ppc/aix.exp: Run for rs6000 too.
	* testsuite/gas/ppc/ppc.exp: Run more tests for non-ELF targets.
	* testsuite/gas/ppc/machine.d: Don't run for PE targets.
opcodes/
	* disassemble.c (disassembler): Use bfd_arch_powerpc entry for
	bfd_arch_rs6000.
	* disassemble.h (print_insn_rs6000): Delete.
	* ppc-dis.c (powerpc_init_dialect): Handle rs6000.
	(disassemble_init_powerpc): Call powerpc_init_dialect for rs6000.
	(print_insn_rs6000): Delete.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] mips64 rtype_to_howto error status
@ 2018-03-07  7:01 sergiodj+buildbot
  2018-03-07  8:05 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-07  7:01 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0118219e1850a05ceb181a4f47a6906c01c17c83 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 0118219e1850a05ceb181a4f47a6906c01c17c83

mips64 rtype_to_howto error status

	* elf64-mips.c (mips_elf64_rtype_to_howto): Return NULL on error.
	(mips_elf64_slurp_one_reloc_table): Pass on error.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Formatting fixes in rust-exp.y
@ 2018-03-06 21:53 sergiodj+buildbot
  2018-03-07  3:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-06 21:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d8344f3d05565ae24a39a8f02533c396b544a780 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: d8344f3d05565ae24a39a8f02533c396b544a780

Formatting fixes in rust-exp.y

I noticed a few formatting buglets in rust-exp.y: A couple of lines
were too long, and a couple of parser rules did not follow the same
formatting as the rest of the code.

I'm checking this in as obvious.  Tested by rebuilding.

2018-03-06  Tom Tromey  <tom@tromey.com>

	* rust-exp.y: Formatting fixes.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdb/riscv: Remove use of pseudo registers
@ 2018-03-06 19:45 sergiodj+buildbot
  2018-03-06 22:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-06 19:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d74aff3d95928db6647a11865c396204c50bc157 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: d74aff3d95928db6647a11865c396204c50bc157

gdb/riscv: Remove use of pseudo registers

The code making use of pseudo registers was initially intended to
support running 32-bit ABI files on 64-bit riscv targets.  However, the
implementation was incomplete, and broken.

For now I've removed all reference to pseudo registers from the riscv
target, we've not lost any functionality, and this cleans up failures in
the selftests.

Once the riscv target has matured a little we'll probably end up
bringing back some of the use of pseudo registers in order to better
support running 32-bit executables on a 64-bit target.

gdb/ChangeLog:

	* riscv-tdep.c (riscv_pseudo_register_read): Delete.
	(riscv_pseudo_register_write): Delete.
	(riscv_gdbarch_init): Remove all use of pseudo registers.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdb/riscv: Fix type when reading register from regcache
@ 2018-03-06 15:28 sergiodj+buildbot
  2018-03-06 17:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-06 15:28 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b2970c238e24e6239760b72c924ee7dd2df9ccd1 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: b2970c238e24e6239760b72c924ee7dd2df9ccd1

gdb/riscv: Fix type when reading register from regcache

Should use a ULONGEST when reading from the regcache.

gdb/ChangeLog:

	* riscv-tdep.c (riscv_return_value): Change type to ULONGEST for
	reading values from registers.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdb/amd64: Ignore zero sized fields when calling functions
@ 2018-03-06 10:29 sergiodj+buildbot
  2018-03-06 11:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-06 10:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5dc4391345f6e86906a57af1434025cfb47b4100 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 5dc4391345f6e86906a57af1434025cfb47b4100

gdb/amd64: Ignore zero sized fields when calling functions

In some cases passing an argument to a function on amd64, or attempting
to fetch the return value, can trigger an assertion failure within GDB.
An example of a type that would trigger such an error is:

  struct foo_t
  {
    long double a;
    struct {
      struct {
        /* Empty.  */
      } es1;
    } s1;
  };

GCC does permit empty structures, so we should probably support this.

The test that exposes this bug is in the next commit along with the
RiscV support.

gdb/ChangeLog:

	* amd64-tdep.c (amd64_classify_aggregate): Ignore zero sized
	fields within aggregates.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Propagate gdb_disassembly_flags to btrace_print_lines
@ 2018-03-05  1:19 sergiodj+buildbot
  2018-03-05  2:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-05  1:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3dea1ef72c646d808e5b287e98253f3b8670c450 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 3dea1ef72c646d808e5b287e98253f3b8670c450

Propagate gdb_disassembly_flags to btrace_print_lines

This function can take the flags as the gdb_disassembly_flags type
instead of int.

gdb/ChangeLog:

	* record-btrace.c (btrace_print_lines): Change type of flags to
	gdb_disassembly_flags.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Use signal information to determine SIGTRAP type for FreeBSD.
@ 2018-03-04  6:38 sergiodj+buildbot
  2018-03-04 10:11 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-04  6:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7efba073e2b83803a47fd89e701fe60b98f2debc ***

Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: 7efba073e2b83803a47fd89e701fe60b98f2debc

Use signal information to determine SIGTRAP type for FreeBSD.

Use the signal code from siginfo_t to distinguish SIGTRAP events due
to trace traps (TRAP_TRACE) and software breakpoints (TRAP_BRKPT).
For software breakpoints, adjust the PC when the event is reported as
part of the API when supplying "stopped_by_sw_breakpoint".  Currently
FreeBSD only supports hardware watchpoints and breakpoints on x86
which are reported as trace traps.  Signal information is not used on
MIPS and sparc64 kernels which do not reliably report TRAP_BRKPT for
software breakpoints.

gdb/ChangeLog:

	* fbsd-nat.c: Include "inf-ptrace.h".
	(USE_SIGTRAP_SIGINFO): Conditionally define.
	[USE_SIGTRAP_SIGINFO] (fbsd_handle_debug_trap): New function.
	(fbsd_wait) [USE_SIGTRAP_SIGINFO]: Call "fbsd_handle_debug_trap".
	[USE_SIGTRAP_SIGINFO] (fbsd_stopped_by_sw_breakpoint): New
	function.
	[USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_sw_breakpoint):
	Likewise.
	[USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_hw_breakpoint):
	Likewise.
	(fbsd_nat_add_target) [USE_SIGTRAP_SIGINFO]: Set
	"stopped_by_sw_breakpoint", "supports_stopped_by_sw_breakpoint",
	"supports_stopped_by_hw_breakpoint" target methods.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Implement "to_stopped_by_hw_breakpoint" for x86 debug registers.
@ 2018-03-04  5:54 sergiodj+buildbot
  2018-03-04  6:56 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-04  5:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 12279366d71627bfbdd74d1a6675dca825d8feca ***

Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: 12279366d71627bfbdd74d1a6675dca825d8feca

Implement "to_stopped_by_hw_breakpoint" for x86 debug registers.

Report that a thread is stopped by a hardware breakpoint if a non-data
watchpoint is set in DR6.  This change should be a no-op since a target
still needs to implement the "to_supports_stopped_by_hw_breakpoint"
method before this function is used.

gdb/ChangeLog:

	* nat/x86-dregs.c (x86_dr_stopped_by_hw_breakpoint): New function.
	* nat/x86-dregs.h (x86_dr_stopped_by_hw_breakpoint): New
	prototype.
	* x86-nat.c (x86_stopped_by_hw_breakpoint): New function.
	(x86_use_watchpoints): Set "stopped_by_hw_breakpoint" target
	method.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove free_char_ptr_vec
@ 2018-03-03  8:16 sergiodj+buildbot
  2018-03-03 11:44 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-03  8:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 54693cf5f11bf292ae308604caf6e866dbb03e6f ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 54693cf5f11bf292ae308604caf6e866dbb03e6f

Remove free_char_ptr_vec

Nothing is using it anymore.

gdb/ChangeLog:

	* common/gdb_vecs.c (free_char_ptr_vec): Remove.
	* common/gdb_vecs.h (free_char_ptr_vec): Remove.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] handle_general_set: Remove useless xstrdup
@ 2018-03-03  5:54 sergiodj+buildbot
  2018-03-03 13:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-03  5:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b9671caf8fe1abd737846edf7dcd627870f986cc ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: b9671caf8fe1abd737846edf7dcd627870f986cc

handle_general_set: Remove useless xstrdup

Unless I'm missing something very obvious, this xstrdup seems
unnecessary to me.  We can pass "mode" directly to sprintf.

gdb/gdbserver/ChangeLog:

	* server.c (handle_general_set): Remove unnecessary xstrdup.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make program_space::deleted_solibs a vector of std::string
@ 2018-03-03  5:05 sergiodj+buildbot
  2018-03-03  8:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-03  5:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6fb16ce6eaba92b86a22eac58eb0eb61b3fd8804 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 6fb16ce6eaba92b86a22eac58eb0eb61b3fd8804

Make program_space::deleted_solibs a vector of std::string

This allows removing a usage of free_char_ptr_vec.

gdb/ChangeLog:

	* progspace.h (struct program_space) <deleted_solibs>: Change
	type to std::vector<std::string>.
	* progspace.c (clear_program_space_solib_cache): Adjust.
	* breakpoint.c (print_solib_event): Adjust.
	(check_status_catch_solib): Adjust.
	* solib.c (update_solib_list): Adjust.
	* ui-out.h (class ui_out) <field_string>: New overload.
	* ui-out.c (ui_out::field_string): New overload.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] opcodes error messages
@ 2018-03-03  1:20 sergiodj+buildbot
  2018-03-03  2:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-03  1:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a6743a5420aa02a0550b0f7be004f6c06e90ce21 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: a6743a5420aa02a0550b0f7be004f6c06e90ce21

opcodes error messages

Another patch aimed at making binutils comply with the GNU coding
standard.  The generated files require
https://sourceware.org/ml/cgen/2018-q1/msg00004.html

cpu/
	* frv.opc: Include opintl.h.
	(add_next_to_vliw): Use opcodes_error_handler to print error.
	Standardize error message.
	(fr500_check_insn_major_constraints, frv_vliw_add_insn): Likewise.
opcodes/
	* sysdep.h (opcodes_error_handler): Define.
	(_bfd_error_handler): Declare.
	* Makefile.am: Remove stray #.
	* opc2c.c (main): Remove bogus -l arg handling.  Print "DO NOT
	EDIT" comment.
	* aarch64-dis.c, * arc-dis.c, * arm-dis.c, * avr-dis.c,
	* d30v-dis.c, * h8300-dis.c, * mmix-dis.c, * ppc-dis.c,
	* riscv-dis.c, * s390-dis.c, * sparc-dis.c, * v850-dis.c: Use
	opcodes_error_handler to print errors.  Standardize error messages.
	* msp430-decode.opc, * nios2-dis.c, * rl78-decode.opc: Likewise,
	and include opintl.h.
	* nds32-asm.c: Likewise, and include sysdep.h and opintl.h.
	* i386-gen.c: Standardize error messages.
	* msp430-decode.c, * rl78-decode.c, rx-decode.c: Regenerate.
	* Makefile.in: Regenerate.
	* epiphany-asm.c, * epiphany-desc.c, * epiphany-dis.c,
	* epiphany-ibld.c, * fr30-asm.c, * fr30-desc.c, * fr30-dis.c,
	* fr30-ibld.c, * frv-asm.c, * frv-desc.c, * frv-dis.c, * frv-ibld.c,
	* frv-opc.c, * ip2k-asm.c, * ip2k-desc.c, * ip2k-dis.c, * ip2k-ibld.c,
	* iq2000-asm.c, * iq2000-desc.c, * iq2000-dis.c, * iq2000-ibld.c,
	* lm32-asm.c, * lm32-desc.c, * lm32-dis.c, * lm32-ibld.c,
	* m32c-asm.c, * m32c-desc.c, * m32c-dis.c, * m32c-ibld.c,
	* m32r-asm.c, * m32r-desc.c, * m32r-dis.c, * m32r-ibld.c,
	* mep-asm.c, * mep-desc.c, * mep-dis.c, * mep-ibld.c, * mt-asm.c,
	* mt-desc.c, * mt-dis.c, * mt-ibld.c, * or1k-asm.c, * or1k-desc.c,
	* or1k-dis.c, * or1k-ibld.c, * xc16x-asm.c, * xc16x-desc.c,
	* xc16x-dis.c, * xc16x-ibld.c, * xstormy16-asm.c, * xstormy16-desc.c,
	* xstormy16-dis.c, * xstormy16-ibld.c: Regenerate.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [GDB/testsuite] Use %progbits in watch-loc.c
@ 2018-03-02 12:07 sergiodj+buildbot
  2018-03-02 13:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-02 12:07 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ecc054c097e7ced281d02ef9632eb0261a410b96 ***

Author: Thomas Preud'homme <thomas.preudhomme@arm.com>
Branch: master
Commit: ecc054c097e7ced281d02ef9632eb0261a410b96

[GDB/testsuite] Use %progbits in watch-loc.c

While using @progbits in .pushsection work on some targets, it does not
work on arm target where this introduces a comment. This patch replaces
its use in gdb.dlang/watch-loc.c and gdb.mi/dw2-ref-missing-frame-func.c
by %progbits which should work on all targets since it is used in
target-independent elf/section7.s GAS test.

2018-03-02  Thomas Preud'homme  <thomas.preudhomme@arm.com>

gdb/testsuite/
	* gdb.dlang/watch-loc.c: Use %progbits instead of @progbits.
	* gdb.mi/dw2-ref-missing-frame-func.c: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Ensure 8-byte alignment for AArch64 stubs.
@ 2018-03-02 11:03 sergiodj+buildbot
  2018-03-02 12:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-02 11:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9a2ebffd4dd9cffac395177e997f6f47408b4782 ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 9a2ebffd4dd9cffac395177e997f6f47408b4782

Ensure 8-byte alignment for AArch64 stubs.

	PR 22903
bfd	* elfnn-aarch64.c (_bfd_aarch64_resize_stubs): Add 8 bytes for branch
	and nop instead of 4.
	(elfNN_arch64_build_stubs): Add nop after branch.  Increase size by
	8 instead of 4.

ld	* emultempl/aarch64elf.em (elf${ELFSIZE}_aarch64_add_stub_section):
	Give stub_sec 8 byte alignment.
	* emulparams/aarch64cloudabi.sh (NOP): Set to 0x1f2003d5.
	* emulparams/aarch64elf.sh (NOP): Likewise.
	* emulparams/aarch64elf32.sh (NOP): Likewise.
	* emulparams/aarch64fbsd.sh (NOP): Likewise.
	* emulparams/aarch64linux.sh (NOP): Likewise.
	* emulparams/aarch64linux32.sh (NOP): Likewise.
	* testsuite/ld-aarch64/erratum835769.d: Adjust for added nop.
	* testsuite/ld-aarch64/erratum843419.d: Likewise.
	* testsuite/ld-aarch64/farcall-b-defsym.d: Likewise.
	* testsuite/ld-aarch64/farcall-b-none-function.d: Likewise.
	* testsuite/ld-aarch64/farcall-b-plt.d: Likewise.
	* testsuite/ld-aarch64/farcall-b-section.d: Likewise.
	* testsuite/ld-aarch64/farcall-b.d: Likewise.
	* testsuite/ld-aarch64/farcall-back.d: Likewise.
	* testsuite/ld-aarch64/farcall-bl-defsym.d: Likewise.
	* testsuite/ld-aarch64/farcall-bl-none-function.d: Likewise.
	* testsuite/ld-aarch64/farcall-bl-plt.d: Likewise.
	* testsuite/ld-aarch64/farcall-bl-section.d: Likewise.
	* testsuite/ld-aarch64/farcall-bl.d: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] RISC-V: Fix symbol size bug when relaxation deletes bytes.
@ 2018-03-01 22:37 sergiodj+buildbot
  2018-03-02  0:18 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-01 22:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 788af978df01c3667be99a1607b774f5fa844113 ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 788af978df01c3667be99a1607b774f5fa844113

RISC-V: Fix symbol size bug when relaxation deletes bytes.

	bfd/
	PR 22756
	* elfnn-riscv.c (riscv_relax_delete_bytes): When adjust st_size, use
	else if instead of if.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix Rust enum test failures
@ 2018-03-01 16:51 sergiodj+buildbot
  2018-03-01 18:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-01 16:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c7b15a66dc9ef2285f0983759d41baf5b9933505 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: c7b15a66dc9ef2285f0983759d41baf5b9933505

Fix Rust enum test failures

Pedro pointed out that some Rust tests were failing after the recent
enum change.  I was able to reproduce this even with the most current
Rust compiler -- no test was failing, but rather the gdb internal
error was causing an "untested" result, which I didn't notice.

The internal error is caused by a bad assertion in
alloc_discriminant_info.  This happened because, in an earlier version
of the patch, the discriminant could only appear at index 0.  However,
it can now appear anywhere.  This patch fixes the assertion in the
obvious way, and adds a second assertion to ensure that the
discriminant is also correct.

Fixing this revealed a real failure, which was caused by using the
wrong base name when computing the name of a univariant enum's sole
member.  This is also fixed here.

Tested by running the gdb.rust tests with rustc 1.23 and
double-checking the summary:

    # of expected passes		276

Note that if you try this yourself, it is still possible to get an
"untested" result from traits.exp if your Rust compiler is old enough.

2018-03-01  Tom Tromey  <tom@tromey.com>

	* dwarf2read.c (alloc_discriminant_info): Fix default_index
	assertion.  Add assertion for discriminant_index.
	(quirk_rust_enum): Use correct base type name in univariant case.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: Encode AVX256/AVX512 vpsub[bwdq] with VEX128/EVEX128
@ 2018-03-01 14:29 sergiodj+buildbot
  2018-03-01 15:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-03-01 14:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8305403a1ffa8e551fd1c7bd88af1a65c0ba747c ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 8305403a1ffa8e551fd1c7bd88af1a65c0ba747c

x86: Encode AVX256/AVX512 vpsub[bwdq] with VEX128/EVEX128

When 2 source registers are identical, AVX256 and AVX512 vpsub[bwdq]
instructions can be encoded with VEX128 or EVEX128 encodings.

gas/

	* config/tc-i386.c (optimize_encoding): Optimize AVX256 and
	AVX512 vpsub[bwdq] instructions.
	* testsuite/gas/i386/optimize-1.s: Add tests for AVX256 and
	AVX512 vpsub[bwdq] instructions.
	* testsuite/gas/i386/x86-64-optimize-2.s: Likewise.
	* testsuite/gas/i386/optimize-1.d: Updated.
	* testsuite/gas/i386/x86-64-optimize-2.d: Likewise.

opcodes/

	* * i386-opc.tbl: Add "Optimize" to AVX256 and AVX512
	vpsub[bwdq] instructions.
	* i386-tbl.h: Regenerated.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] correct ft32 reloc range test
@ 2018-02-28 23:16 sergiodj+buildbot
  2018-03-01  7:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-28 23:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5224fa039966557e869338d2591e7945cdcecb74 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 5224fa039966557e869338d2591e7945cdcecb74

correct ft32 reloc range test

	* elf32-ft32.c (ft32_info_to_howto_rela): Correct range test.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make gdbserver work with filename-only binaries
@ 2018-02-28 17:06 sergiodj+buildbot
  2018-03-01  4:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-28 17:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 25e3c82c0e927398e759e2d5e35623012b8683f7 ***

Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: 25e3c82c0e927398e759e2d5e35623012b8683f7

Make gdbserver work with filename-only binaries

Simon mentioned on IRC that, after the startup-with-shell feature has
been implemented on gdbserver, it is not possible to specify a
filename-only binary, like:

  $ gdbserver :1234 a.out
  /bin/bash: line 0: exec: a.out: not found
  During startup program exited with code 127.
  Exiting

This happens on systems where the current directory "." is not listed
in the PATH environment variable.  Although including "." in the PATH
variable is a possible workaround, this can be considered a regression
because before startup-with-shell it was possible to use only the
filename (due to reason that gdbserver used "exec*" directly).

The idea of the patch is to verify if the program path provided by the
user (or by the remote protocol) contains a directory separator
character.  If it doesn't, it means we're dealing with a filename-only
binary, so we call "gdb_abspath" to properly expand it and transform
it into a full path.  Otherwise, we leave the program path untouched.
This mimicks the behaviour seen on GDB (look at "openp" and
"attach_inferior", for example).

I am also submitting a testcase which exercises the scenario described
above.  This test requires gdbserver to be executed in a different CWD
than the original, so I also created a helper function, "with_cwd" (on
testsuite/lib/gdb.exp), which takes care of cd'ing into and out of the
specified dir.

Built and regtested on BuildBot, without regressions.

gdb/ChangeLog:
2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
	    Simon Marchi  <simon.marchi@polymtl.ca>

	* common/common-utils.c: Include "sys/stat.h".
	(is_regular_file): Move here from "source.c"; change return
	type to "bool".
	* common/common-utils.h (is_regular_file): New prototype.
	* common/pathstuff.c (contains_dir_separator): New function.
	* common/pathstuff.h (contains_dir_separator): New prototype.
	* source.c: Don't include "sys/stat.h".
	(is_regular_file): Move to "common/common-utils.c".

gdb/gdbserver/ChangeLog:
2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>

	* server.c: Include "filenames.h" and "pathstuff.h".
	(program_name): Delete variable.
	(program_path): New anonymous class.
	(get_exec_wrapper): Use "program_path" instead of
	"program_name".
	(handle_v_run): Likewise.
	(captured_main): Likewise.
	(process_serial_event): Likewise.

gdb/testsuite/ChangeLog:
2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>

	* gdb.server/abspath.exp: New file.
	* lib/gdb.exp (with_cwd): New procedure.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Create new common/pathstuff.[ch]
@ 2018-02-28 17:02 sergiodj+buildbot
  2018-03-01  3:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-28 17:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b4987c956dfa44ca9fd8552f63e15f5fa094b2a4 ***

Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: b4987c956dfa44ca9fd8552f63e15f5fa094b2a4

Create new common/pathstuff.[ch]

This commit moves the path manipulation routines found on utils.c to a
new common/pathstuff.c, and updates the Makefile.in's accordingly.
The routines moved are "gdb_realpath", "gdb_realpath_keepfile" and
"gdb_abspath".

This will be needed because gdbserver will have to call "gdb_abspath"
on my next patch, which implements a way to expand the path of the
inferior provided by the user in order to allow specifying just the
binary name when starting gdbserver, like:

  $ gdbserver :1234 a.out

With the recent addition of the startup-with-shell feature on
gdbserver, this scenario doesn't work anymore if the user doesn't have
the current directory listed in the PATH variable.

I had to do a minor adjustment on "gdb_abspath" because we don't have
access to "tilde_expand" on gdbserver, so now the function is using
"gdb_tilde_expand" instead.  Otherwise, the code is the same.

Regression tested on the BuildBot, without regressions.

gdb/ChangeLog:
2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>

	* Makefile.in (COMMON_SFILES): Add "common/pathstuff.c".
	(HFILES_NO_SRCDIR): Add "common/pathstuff.h".
	* auto-load.c: Include "common/pathstuff.h".
	* common/common-def.h (current_directory): Move here.
	* common/gdb_tilde_expand.c (gdb_tilde_expand_up): New
	function.
	* common/gdb_tilde_expand.h (gdb_tilde_expand_up): New
	prototype.
	* common/pathstuff.c: New file.
	* common/pathstuff.h: New file.
	* compile/compile.c: Include "common/pathstuff.h".
	* defs.h (current_directory): Move to "common/common-defs.h".
	* dwarf2read.c: Include "common/pathstuff.h".
	* exec.c: Likewise.
	* guile/scm-safe-call.c: Likewise.
	* linux-thread-db.c: Likewise.
	* main.c: Likewise.
	* nto-tdep.c: Likewise.
	* objfiles.c: Likewise.
	* source.c: Likewise.
	* symtab.c: Likewise.
	* utils.c: Include "common/pathstuff.h".
	(gdb_realpath): Move to "common/pathstuff.c".
	(gdb_realpath_keepfile): Likewise.
	(gdb_abspath): Likewise.
	* utils.h (gdb_realpath): Move to "common/pathstuff.h".
	(gdb_realpath_keepfile): Likewise.
	(gdb_abspath): Likewise.

gdb/gdbserver/ChangeLog:
2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>

	* Makefile.in (SFILES): Add "$(srcdir)/common/pathstuff.c".
	(OBJS): Add "pathstuff.o".
	* server.c (current_directory): New global variable.
	(captured_main): Initialize "current_directory".


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Catch integer overflows/underflows when parsing corrupt DWARF FORM blocks.
@ 2018-02-28 12:18 sergiodj+buildbot
  2018-03-01  0:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-28 12:18 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 12c963421d045a127c413a0722062b9932c50aa9 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 12c963421d045a127c413a0722062b9932c50aa9

Catch integer overflows/underflows when parsing corrupt DWARF FORM blocks.

	PR 22895
	PR 22893
	* dwarf2.c (read_n_bytes): Replace size parameter with dwarf_block
	pointer.  Drop unused abfd parameter.  Check the size of the block
	before initialising the data field.  Return the end pointer if the
	size is invalid.
	(read_attribute_value): Adjust invocations of read_n_bytes.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR22887, null pointer dereference in aout_32_swap_std_reloc_out
@ 2018-02-28 12:05 sergiodj+buildbot
  2018-02-28 23:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-28 12:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 116acb2c268c89c89186673a7c92620d21825b25 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 116acb2c268c89c89186673a7c92620d21825b25

PR22887, null pointer dereference in aout_32_swap_std_reloc_out

	PR 22887
	* aoutx.h (swap_std_reloc_in): Correct r_index bound check.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Nonsense error messages on invalid aout string offset
@ 2018-02-28  7:57 sergiodj+buildbot
  2018-02-28 21:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-28  7:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0d329c0a83a23cebb86fbe0ebddd780dc0df2424 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 0d329c0a83a23cebb86fbe0ebddd780dc0df2424

Nonsense error messages on invalid aout string offset

translate_symbol_table returns false on detecting an out of range name
string offset, hooray for error checking, but doesn't set bfd_error or
print a useful error.  bfd_error therefore contains whatever it had
previously, in my testing, bfd_error_system_call.  So the error
printed depended on errno.

	PR 22887
	* aoutx.h (translate_symbol_table): Print an error message and set
	bfd_error on finding an invalid name string offset.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Change target_write_memory_blocks to use std::vector
@ 2018-02-27 19:20 sergiodj+buildbot
  2018-02-28 15:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-27 19:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 55089490f79ce1ddb9610fd6abeeaf896825fb71 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 55089490f79ce1ddb9610fd6abeeaf896825fb71

Change target_write_memory_blocks to use std::vector

This changes target_write_memory_blocks to use std::vector, rather
than VEC.  This allows the removal of some cleanups.

This version incorporates the additions that Simon made.

Regression tested by the buildbot.

ChangeLog
2018-02-27  Simon Marchi  <simon.marchi@polymtl.ca>
	    Tom Tromey  <tom@tromey.com>

	* target.h (memory_write_request_s): Remove typedef.  Don't define
	VEC.
	(target_write_memory_blocks): Change argument to std::vector.
	(struct memory_write_request): Add constructor.
	* target-memory.c (compare_block_starting_address): Return bool.
	Change argument types.
	(claim_memory): Change arguments to use std::vector.
	(split_regular_and_flash_blocks, blocks_to_erase)
	(compute_garbled_blocks): Likewise.
	(cleanup_request_data, cleanup_write_requests_vector): Remove.
	(target_write_memory_blocks): Change argument to std::vector.
	* symfile.c (struct load_section_data): Add constructor and
	destructor.  Use std::vector for "requests".
	(struct load_progress_data): Add initializers.
	(load_section_callback): Update.  Use "new".
	(clear_memory_write_data): Remove.
	(generic_load): Update.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Explicitly specify common tdesc.h for use with aarch64.h
@ 2018-02-27 16:46 sergiodj+buildbot
  2018-02-28 13:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-27 16:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0c305b6176408347afd8452abb8fe974a7e3f999 ***

Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: 0c305b6176408347afd8452abb8fe974a7e3f999

Explicitly specify common tdesc.h for use with aarch64.h

gdb/
	* arch/aarch64.h: Use common/tdesc.h.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Use standardized error message for unrecognized relocs.
@ 2018-02-27 12:32 sergiodj+buildbot
  2018-02-28  9:53 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-27 12:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e8f5af786c7665141f6644998b8c427ad466d474 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: e8f5af786c7665141f6644998b8c427ad466d474

Use standardized error message for unrecognized relocs.

bfd	* aout-cris.c (swap_ext_reloc_out): Standadize error/warning
	message.
	* elf-hppa.h (elf_hppa_info_to_howto_rel): Likewise.
	* elf32-i386.c (elf_i386_reloc_type_lookup): Likewise.
	* elf32-xtensa.c (elf_xtensa_reloc_type_lookup): Likewise.
	* elf64-ppc.c (ppc64_elf_reloc_type_lookup): Likewise.
	* elf64-s390.c (elf_s390_reloc_type_lookup): Likewise.
	* elf64-sh64.c (sh_elf64_info_to_howto): Likewise.
	* elfxx-ia64.c (ia64_elf_reloc_type_lookup): Likewise.
	* elfxx-sparc.c (_bfd_sparc_elf_reloc_type_lookup): Likewise.
	* elfxx-tilegx.c (tilegx_reloc_type_lookup): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Have info_to_howto functions return a success/fail status. Check this result. Stop strip from completeing if one of these functions fails.
@ 2018-02-27 10:41 sergiodj+buildbot
  2018-02-28  8:14 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-27 10:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f3185997ac0951edac802e29df03dfc0844fda34 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: f3185997ac0951edac802e29df03dfc0844fda34

Have info_to_howto functions return a success/fail status.  Check this result.  Stop strip from completeing if one of these functions fails.

bfd	PR 22875
	* elf-bfd.h (struct elf_backend_data): Change the return type of
	the elf_info_to_howto and elf_info_to_howto_rel function pointers
	to bfd_boolean.
	* elfcode.h (elf_slurp_reloc_table_from_section): Check the return value from the info_to_howto function and fail if that function failed.
	* elf32-h8300.c (elf32_h8_relocate_section): Check return value from the info_to_howto function.
	(elf32_h8_relax_section): Likewise.
	* elf32-lm32.c (lm32_elf_relocate_section): Likewise.
	* elf32-m68hc1x.c (elf32_m68hc11_relocate_section): Likewise.
	* elf32-score.c (s3_bfd_score_elf_relocate_section): Likewise.
	* elf32-score7.c (s7_bfd_score_elf_relocate_section): Likewise.
	* elf32-tic6x.c (elf32_tic6x_relocate_section): Likewise.
	* elf64-ia64-vms.c (elf64_ia64_relocate_section): Likewise.
	* elf64-sparc.c (elf64_sparc_slurp_one_reloc_table): Likewise.
	* elf64-x86-64.c (elf_x86_64_tls_transition): Likewise.
	* elfnn-ia64.c (elfNN_ia64_relocate_section): Likewise.
	* elfnn-riscv.c (riscv_elf_check_relocs): Likewise.
	(riscv_elf_relocate_section): Likewise.
	* elf-hppa.h (elf_hppa_info_to_howto): Change return type to
	bfd_boolean.  Issue an error message, set an error value and
	return FALSE if the reloc is not recognized.
	(elf_hppa_info_to_howto_rel): Likewise.
	* elf-m10200.c (mn10200_info_to_howto): Likewise.
	* elf-m10300.c (mn10300_info_to_howto): Likewise.
	* elf.c (_bfd_elf_no_info_to_howto): Likewise.
	* elf32-arc.c (arc_info_to_howto_rel): Likewise.
	* elf32-arm.c (elf32_arm_info_to_howto): Likewise.
	* elf32-avr.c (avr_info_to_howto_rela): Likewise.
	* elf32-bfin.c (bfin_info_to_howto): Likewise.
	* elf32-cr16.c (elf_cr16_info_to_howto): Likewise.
	* elf32-cr16c.c (elf_cr16c_info_to_howto): Likewise.
	* elf32-cris.c (elf_cr16c_info_to_howto_rel, cris_info_to_howto_rela): Likewise.
	* elf32-crx.c (elf_crx_info_to_howto): Likewise.
	* elf32-d10v.c (d10v_info_to_howto_rel): Likewise.
	* elf32-d30v.c (d30v_info_to_howto_rel, d30v_info_to_howto_rela): Likewise.
	* elf32-dlx.c (dlx_rtype_to_howto, elf32_dlx_info_to_howto, elf32_dlx_info_to_howto_rel): Likewise.
	* elf32-epiphany.c (epiphany_info_to_howto_rela): Likewise.
	* elf32-fr30.c (fr30_info_to_howto_rela): Likewise.
	* elf32-frv.c (frv_info_to_howto_rela, 	frvfdpic_info_to_howto_rel): Likewise.
	* elf32-ft32.c (ft32_info_to_howto_rela): Likewise.
	* elf32-gen.c (elf_generic_info_to_howto, elf_generic_info_to_howto_rel): Likewise.
	* elf32-h8300.c (elf32_h8_info_to_howto, elf32_h8_info_to_howto_rel): Likewise.
	* elf32-i370.c (i370_elf_info_to_howto): Likewise.
	* elf32-i386.c (elf_i386_reloc_type_lookup, elf_i386_rtype_to_howto, elf_i386_info_to_howto_rel): Likewise.
	* elf32-i860.c (lookup_howto, elf32_i860_info_to_howto_rela): Likewise.
	* elf32-i960.c (elf32_i960_info_to_howto_rel): Likewise.
	* elf32-ip2k.c (ip2k_info_to_howto_rela): Likewise.
	* elf32-iq2000.c (iq2000_info_to_howto_rela): Likewise.
	* elf32-lm32.c (lm32_info_to_howto_rela): Likewise.
	* elf32-m32c.c (m32c_info_to_howto_rela): Likewise.
	* elf32-m32r.c (m32r_info_to_howto_rel, m32r_info_to_howto): Likewise.
	* elf32-m68hc11.c (m68hc11_info_to_howto_rel): Likewise.
	* elf32-m68hc12.c (m68hc11_info_to_howto_rel): Likewise.
	* elf32-m68k.c (rtype_to_howto): Likewise.
	* elf32-mcore.c (mcore_elf_info_to_howto): Likewise.
	* elf32-mep.c (mep_info_to_howto_rela): Likewise.
	* elf32-metag.c (metag_info_to_howto_rela): Likewise.
	* elf32-microblaze.c (microblaze_elf_info_to_howto): Likewise.
	* elf32-mips.c (mips_info_to_howto_rel, mips_info_to_howto_rela): Likewise.
	* elf32-moxie.c (moxie_info_to_howto_rela): Likewise.
	* elf32-msp430.c (msp430_info_to_howto_rela): Likewise.
	* elf32-mt.c (mt_info_to_howto_rela): Likewise.
	* elf32-nds32.c (nds32_info_to_howto_rel, nds32_info_to_howto): Likewise.
	* elf32-nios2.c (nios2_elf32_info_to_howto): Likewise.
	* elf32-or1k.c (or1k_info_to_howto_rela): Likewise.
	* elf32-pj.c (pj_elf_info_to_howto): Likewise.
	* elf32-ppc.c (ppc_elf_info_to_howto): Likewise.
	* elf32-pru.c (pru_elf32_info_to_howto): Likewise.
	* elf32-rl78.c (rl78_info_to_howto_rela): Likewise.
	* elf32-rx.c (rx_info_to_howto_rela): Likewise.
	* elf32-s390.c (elf_s390_info_to_howto): Likewise.
	* elf32-score.c (s3_bfd_score_info_to_howto, _bfd_score_info_to_howto): Likewise.
	* elf32-score7.c (s7_bfd_score_info_to_howto): Likewise.
	* elf32-sh.c (sh_elf_info_to_howto): Likewise.
	* elf32-spu.c (spu_elf_info_to_howto): Likewise.
	* elf32-tic6x.c (elf32_tic6x_info_to_howto, elf32_tic6x_info_to_howto_rel): Likewise.
	* elf32-tilepro.c (tilepro_info_to_howto_rela): Likewise.
	* elf32-v850.c (v850_elf_info_to_howto_rel, v850_elf_info_to_howto_rela, v800_elf_info_to_howto): Likewise.
	* elf32-vax.c (rtype_to_howto): Likewise.
	* elf32-visium.c (visium_info_to_howto_rela): Likewise.
	* elf32-wasm32.c (elf32_wasm32_rtype_to_howto, elf32_wasm32_info_to_howto_rela): Likewise.
	* elf32-xc16x.c (elf32_xc16x_info_to_howto): Likewise.
	* elf32-xgate.c (xgate_info_to_howto_rel): Likewise.
	* elf32-xstormy16.c (xstormy16_info_to_howto_rela): Likewise.
	* elf32-xtensa.c (elf_xtensa_info_to_howto_rela): Likewise.
	* elf64-alpha.c (elf64_alpha_info_to_howto): Likewise.
	* elf64-gen.c (elf_generic_info_to_howto, elf_generic_info_to_howto_rel): Likewise.
	* elf64-ia64-vms.c (elf64_ia64_info_to_howto): Likewise.
	* elf64-mips.c (mips_elf64_info_to_howto_rela): Likewise.
	* elf64-mmix.c (mmix_info_to_howto_rela): Likewise.
	* elf64-ppc.c (ppc64_elf_info_to_howto): Likewise.
	* elf64-s390.c (elf_s390_reloc_type_lookup): Likewise.
	* elf64-sh64.c (elf_s390_info_to_howto, sh_elf64_info_to_howto): Likewise.
	* elf64-x86-64.c (elf_x86_64_info_to_howto): Likewise.
	* elfn32-mips.c (mips_info_to_howto_rel, mips_info_to_howto_rela): Likewise.
	* elfnn-aarch64.c (elfNN_aarch64_info_to_howto): Likewise.
	* elfnn-ia64.c (elfNN_ia64_info_to_howto): Likewise.
	* elfnn-riscv.c (riscv_info_to_howto_rela): Likewise.
	* elfxx-ia64.c (ia64_elf_reloc_type_lookup): Likewise.
	* elfxx-sparc.c (_bfd_sparc_elf_info_to_howto): Likewise.
	* elfxx-tilegx.c (tilegx_info_to_howto_rela): Likewise.
	* elf32-score.h (s7_bfd_score_info_to_howto): Update prototype.
	* elfxx-sparc.h (_bfd_sparc_elf_info_to_howto): Update prototype.
	* elfxx-tilegx.h (tilegx_info_to_howto_rela): Update prototype.
	* elfxx-target.h (elf_info_to_howto, elf_info_to_howto_rel): Default to NULL.

binutils PR 22875
	* objcopy.c (copy_object): Check the error status after marking symbols used in relocations.
	* testsuite/binutils-all/strip-13.s: New test source file.
	* testsuite/binutils-all/strip-13.s: New test driver file.
	* testsuite/binutils-all/objcopy.exp: Run the new test.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Handle DW_TAG_variant_part and DW_TAG_variant
@ 2018-02-27  0:14 sergiodj+buildbot
  2018-02-27 19:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-27  0:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2ddeaf8a7d64094f4caf6cdc412d8162f49f73a1 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 2ddeaf8a7d64094f4caf6cdc412d8162f49f73a1

Handle DW_TAG_variant_part and DW_TAG_variant

This changes dwarf2read to understand DW_TAG_variant_part and
DW_TAG_variant.

Note that DW_AT_discr_list is not handled.  I did not need this for
Rust.  I imagine this should not be too hard to add later, should
someone need it.  Meanwhile I have gdb emit a complaint if it is seen.

There is a lurking issue concerning the placement of the discriminant
in the DWARF.  For Rust, I ended up following the letter of the
standard and having the discriminant be a child of the
DW_TAG_variant_part.  However, GCC's Ada support does not do this.
Pierre-Marie filed this with the DWARF committee:

    http://dwarfstd.org/ShowIssue.php?issue=180123.1

However as that is read-only, if you have comments you might consider
adding them to the GCC bug:

    https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83935

Finally, there is a DWARF extension lurking in here.  In Rust, a
univariant enum will not have a discriminant.  However, in order to
unify the representation of all data-carrying enums, I've made LLVM
(and my forthcoming rustc patch) emit a univariant enum using a
DW_TAG_variant with a single variant part and without DW_AT_discr.
The lack of this DW_AT_discr is the extension.  I will submit an issue
on dwarfstd.org about this.

2018-02-26  Tom Tromey  <tom@tromey.com>

	* dwarf2read.c (struct variant_field): New.
	(struct nextfield) <variant>: New field.
	(dwarf2_add_field): Handle DW_TAG_variant_part.
	(dwarf2_attach_fields_to_type): Attach a discriminant_info to a
	discriminated union.
	(read_structure_type): Handle DW_TAG_variant_part.
	(handle_struct_member_die): New function, extracted from
	process_structure_scope.  Handle DW_TAG_variant.
	(process_structure_scope): Handle discriminated unions.  Call
	handle_struct_member_die.

2018-02-26  Tom Tromey  <tom@tromey.com>

	* gdb.dwarf2/variant.c: New file.
	* gdb.dwarf2/variant.exp: New file.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Convert Rust to use discriminated unions
@ 2018-02-26 21:31 sergiodj+buildbot
  2018-02-27 17:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 21:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c9317f214b274b805190b8e878c79f4181d93bb4 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: c9317f214b274b805190b8e878c79f4181d93bb4

Convert Rust to use discriminated unions

A Rust enum is, essentially, a discriminated union.  Currently the
Rust language support handles Rust enums locally, in rust-lang.c.
However, because I am changing the Rust compiler to use
DW_TAG_variant* to represent enums, it seemed better to have a single
internal representation for Rust enums in gdb.

This patch implements this idea by moving the current Rust enum
handling code to dwarf2read.  This allows the simplification of some
parts of rust-lang.c as well.

2018-02-26  Tom Tromey  <tom@tromey.com>

	* rust-lang.h (rust_last_path_segment): Declare.
	* rust-lang.c (rust_last_path_segment): Now public.  Change
	contract.
	(struct disr_info): Remove.
	(RUST_ENUM_PREFIX, RUST_ENCODED_ENUM_REAL)
	(RUST_ENCODED_ENUM_HIDDEN, rust_union_is_untagged)
	(rust_get_disr_info, rust_tuple_variant_type_p): Remove.
	(rust_enum_p, rust_enum_variant): New function.
	(rust_underscore_fields): Remove "offset" parameter.
	(rust_print_enum): New function.
	(rust_val_print) <TYPE_CODE_UNION>: Remove enum code.
	<TYPE_CODE_STRUCT>: Call rust_print_enum when appropriate.
	(rust_print_struct_def): Add "for_rust_enum" parameter.  Handle
	enums.
	(rust_internal_print_type): New function, from rust_print_type.
	Remove enum code.
	(rust_print_type): Call rust_internal_print_type.
	(rust_evaluate_subexp) <STRUCTOP_ANONYMOUS, STRUCTOP_STRUCT>:
	Update enum handling.
	* dwarf2read.c (struct dwarf2_cu) <rust_unions>: New field.
	(rust_fully_qualify, alloc_discriminant_info, quirk_rust_enum)
	(rust_union_quirks): New functions.
	(process_full_comp_unit, process_full_type_unit): Call
	rust_union_quirks.
	(process_structure_scope): Update rust_unions if necessary.

2018-02-26  Tom Tromey  <tom@tromey.com>

	* gdb.rust/simple.exp: Accept more possible results in enum test.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] MIPS: Don't use a 32-bit BFD architecture with a 64-bit ABI
@ 2018-02-26 20:30 sergiodj+buildbot
  2018-02-28  3:03 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 20:30 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c5196c9298b7df29652c0ebe24a43ac6c9c76b0d ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: c5196c9298b7df29652c0ebe24a43ac6c9c76b0d

MIPS: Don't use a 32-bit BFD architecture with a 64-bit ABI

Select `bfd_mach_mips4000', which corresponds to the MIPS III ISA, the
earlies with 64-bit support, whenever a 32-bit BFD architecture has been
chosen to use with a 64-bit ABI.  The situation can happen in a few
cases:

1. When the user has used `set architecture' or `set mips abi' commands
   to override automatic selection and then starts a debug session by
   requesting to run, attach or connect to a target.

2. In native debugging when reattaching to a previously debugged process
   where the program to be debugged has been since discarded, as
   observed with:

FAIL: gdb.base/attach.exp: attach2, with no file (GDB internal error)

   in n32 and n64 regression testing.

3. In remote debugging with a non-XML debug stub when discarding the
   program to be debugged while connected to the remote target, as
   observed with:

FAIL: gdb.base/break-unload-file.exp: cmdline: always-inserted on: break: file (GDB internal error)

   in n32 and n64 regression testing.

In the latter two cases the ABI, quite rightfully, is retained while the
program to be debugged is discarded.  This is because in that case the
ABI previously determined is carried over along with `gdbarch' in use,
which is retained.  The BFD architecture is however discarded and the
default then applies, because it is not attached to `gdbarch'.

In all these cases we trip with an internal error message as follows:

.../gdb/mips-tdep.c:766: internal-error: bad register size
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Quit this debugging session? (y or n) n

This is a bug, please report it.  For instructions, see:
<http://www.gnu.org/software/gdb/bugs/>.

coming from `mips_pseudo_register_read', because the raw register width
inferred from the BFD architecture turns out to be 4 for the general
registers while the cooked register width inferred from the ABI in
effect is 8.

We do not hit this internal error in remote debugging with an XML debug
stub, because in that case raw register width information is passed by
the stub along with the XML target description.

Ultimately I think we ought to make the BFD architecture sticky like the
ABI, however in the interim this simple fix will do, removing the error
across all three cases.  The case where the user has used `set mips abi'
or `set architecture' commands has to be handled anyway, and although a
more sophisticated solution could be envisaged, such as reporting an
error with the respective `set' command, I think this is too much of a
corner case to bother.

	gdb/
	* mips-tdep.c (mips_gdbarch_init): Don't use a 32-bit BFD
	architecture with a 64-bit ABI.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Move read_partial_die to partial_die_info::read
@ 2018-02-26 18:41 sergiodj+buildbot
  2018-02-27 11:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 18:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 48fbe735fb8f0e65976d2b9dd345bf2f947ad258 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 48fbe735fb8f0e65976d2b9dd345bf2f947ad258

Move read_partial_die to partial_die_info::read

gdb:

2018-02-26  Yao Qi  <yao.qi@linaro.org>

	* dwarf2read.c (struct partial_die_info) <read>: New method.
	(read_partial_die): Remove the declaration.
	(load_partial_dies): Update.
	(partial_die_info::partial_die_info):
	(read_partial_die): Change it to partial_die_info::read.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Change frame_filter_flags to use DEF_ENUM_FLAGS_TYPE
@ 2018-02-26 18:06 sergiodj+buildbot
  2018-02-28  0:29 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 18:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d4dd32824a1194718c81773804017ab546cb3aab ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: d4dd32824a1194718c81773804017ab546cb3aab

Change frame_filter_flags to use DEF_ENUM_FLAGS_TYPE

This changes frame_filter_flags to use DEF_ENUM_FLAGS_TYPE, and
updates all the uses.  It also changes the enum constants to use <<,
as suggested by Sergio.

ChangeLog
2018-02-26  Tom Tromey  <tom@tromey.com>

	* stack.c (backtrace_command_1): Update.
	* python/python-internal.h (gdbpy_apply_frame_filter): Change type
	of "flags".
	* python/py-framefilter.c (py_print_frame)
	(gdbpy_apply_frame_filter): Change type of "flags".
	* mi/mi-cmd-stack.c (mi_apply_ext_lang_frame_filter): Change type
	of "flags".
	(mi_cmd_stack_list_frames, mi_cmd_stack_list_locals)
	(mi_cmd_stack_list_args, mi_cmd_stack_list_variables): Update.
	* extension.h (enum frame_filter_flag): Rename from
	frame_filter_flags.
	(frame_filter_flags): Define using DEF_ENUM_FLAGS_TYPE.
	(apply_ext_lang_frame_filter): Change type of "flags".
	* extension.c (apply_ext_lang_frame_filter): Change type of
	"flags".
	* extension-priv.h (struct extension_language_ops)
	<apply_frame_filter>: Change type of "flags".


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make "bt N" print correct number of frames when using a frame filter
@ 2018-02-26 17:54 sergiodj+buildbot
  2018-02-27 21:45 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 17:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6893c19a8b81a399953edbf26aaef6e714a7ab0e ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 6893c19a8b81a399953edbf26aaef6e714a7ab0e

Make "bt N" print correct number of frames when using a frame filter

PR python/16497 notes that using "bt" with a positive argument prints
the wrong number of frames when a frame filter is in use.  Also, in this
case, the non-frame-filter path will print a message about "More stack
frames" when there are more; but this is not done in the frame-filter
case.

The first problem is that backtrace_command_1 passes the wrong value
to apply_ext_lang_frame_filter -- that function takes the final
frame's number as an argument, but backtrace_command_1 passes the
count, which is off by one.

The solution to the second problem is to have the C stack-printing
code stop at the correct number of frames and then print the message.

Tested using the buildbot.

ChangeLog
2018-02-26  Tom Tromey  <tom@tromey.com>

	PR python/16497:
	* stack.c (backtrace_command_1): Set PRINT_MORE_FRAMES flag.  Fix
	off-by-one in py_end computation.
	* python/py-framefilter.c (gdbpy_apply_frame_filter): Handle
	PRINT_MORE_FRAMES.
	* extension.h (enum frame_filter_flags) <PRINT_MORE_FRAMES>: New
	constant.

2018-02-26  Tom Tromey  <tom@tromey.com>

	PR python/16497:
	* gdb.python/py-framefilter.exp: Update test.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Initial support for variant parts
@ 2018-02-26 17:16 sergiodj+buildbot
  2018-02-27 15:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 17:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7c22600aabfd10e190e98fff0b7c2d69cd191325 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 7c22600aabfd10e190e98fff0b7c2d69cd191325

Initial support for variant parts

This adds some initial support for variant parts to gdbtypes.h.  A
variant part is represented as a union.  The union has a flag
indicating that it has a discriminant, and information about the
discriminant is attached using the dynamic property system.

2018-02-26  Tom Tromey  <tom@tromey.com>

	* value.h (value_union_variant): Declare.
	* valops.c (value_union_variant): New function.
	* gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): New macro.
	(struct discriminant_info): New.
	(enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: New
	enumerator.
	(struct main_type) <flag_discriminated_union>: New field.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Move arch/tdesc.h to common/tdesc.h
@ 2018-02-26 12:02 sergiodj+buildbot
  2018-02-26 23:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-26 12:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f46cd62a69b8050c7c30a53b29a781a9b5e9f062 ***

Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: f46cd62a69b8050c7c30a53b29a781a9b5e9f062

Move arch/tdesc.h to common/tdesc.h

gdb/
	* arch/amd64.h: Use common/tdesc.h.
	* arch/i386.c: Likewise.
	* arch/i386.h: Likewise.
	* arch/tic6x.c: Likewise.
	* arch/tdesc.h: Move file from here...
	* common/tdesc.h: ...to here.
	* features/aarch64-core.c: Regenerate.
	* features/aarch64-fpu.c: Regenerate.
	* features/i386/32bit-avx.c: Regenerate.
	* features/i386/32bit-avx512.c: Regenerate.
	* features/i386/32bit-core.c: Regenerate.
	* features/i386/32bit-linux.c: Regenerate.
	* features/i386/32bit-mpx.c: Regenerate.
	* features/i386/32bit-pkeys.c: Regenerate.
	* features/i386/32bit-sse.c: Regenerate.
	* features/i386/64bit-avx.c: Regenerate.
	* features/i386/64bit-avx512.c: Regenerate.
	* features/i386/64bit-core.c: Regenerate.
	* features/i386/64bit-linux.c: Regenerate.
	* features/i386/64bit-mpx.c: Regenerate.
	* features/i386/64bit-pkeys.c: Regenerate.
	* features/i386/64bit-segments.c: Regenerate.
	* features/i386/64bit-sse.c: Regenerate.
	* features/i386/x32-core.c: Regenerate.
	* features/tic6x-c6xp.c: Regenerate.
	* features/tic6x-core.c: Regenerate.
	* features/tic6x-gp.c: Regenerate.
	* target-descriptions.c: Use common/tdesc.h.
	* target-descriptions.h: Likewise.

gdbserver/
	* tdesc.c: Use common/tdesc.h.
	* tdesc.h: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Segfault on phdrs allocated but not created
@ 2018-02-26  1:53 sergiodj+buildbot
  2018-02-26 21:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-26  1:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6838f2bed6459514c1b0c549e6aa3fc7dbb1d7ec ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 6838f2bed6459514c1b0c549e6aa3fc7dbb1d7ec

Segfault on phdrs allocated but not created

A number of ARM tests show results like:
ld-new: no address assigned to the veneers output section .gnu.sgstubs
ld-new: can not size stub section: invalid operation
ld-new: warning: cannot find entry symbol _start; defaulting to 0000000000010074
ld-new: tmpdir/cmse-veneers-no-gnu_sgstubs: warning: allocated section `.text' not in segment
Segmentation fault
PASS: Secure gateway veneers: no .gnu.sgstubs section

The PASS despite the segv shows the danger of using "#..." to match
error output.  This patch doesn't try to fix the testuite, but does
prevent the segfault.

	* elf.c (assign_file_positions_except_relocs): Don't segfault
	when actual number of phdrs is less than allocated.  Delete
	outdated comment.  Formatting.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] crx string overflow warning
@ 2018-02-26  1:40 sergiodj+buildbot
  2018-02-26 19:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-26  1:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e95b887f85a192eb1597cd5d358673520029ad14 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: e95b887f85a192eb1597cd5d358673520029ad14

crx string overflow warning

gcc8 complains wrongly about the buffer not being large enough, at
least at -Og optimization.

	* crx-dis.c (getregliststring): Allocate a large enough buffer
	to silence false positive gcc8 warning.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] assorted target messages
@ 2018-02-26  1:28 sergiodj+buildbot
  2018-02-26 16:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-26  1:28 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 38f14ab8fcfa4eab8bab417a5a165b7403ef9b0e ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 38f14ab8fcfa4eab8bab417a5a165b7403ef9b0e

assorted target messages

bfd/
	* elf-m10300.c, * elf-s390-common.c, * elf32-arc.c, * elf32-cris.c,
	* elf32-dlx.c, * elf32-frv.c, * elf32-i370.c, * elf32-lm32.c,
	* elf32-m32r.c, * elf32-m68hc1x.c, * elf32-m68k.c,
	* elf32-microblaze.c, * elf32-msp430.c, * elf32-nds32.c,
	* elf32-nios2.c, * elf32-or1k.c, * elf32-rl78.c, * elf32-rx.c,
	* elf32-score.c, * elf32-score7.c, * elf32-sh-symbian.c,
	* elf32-sh.c, * elf32-spu.c, * elf32-v850.c, * elf32-xtensa.c,
	* elf64-alpha.c, * elf64-ia64-vms.c, * elf64-mmix.c,
	* elf64-sh64.c, * elf64-sparc.c, * elfnn-ia64.c, * elfxx-tilegx.c,
	* mmo.c, * osf-core.c, * srec.c, * vms-alpha.c: Standardize
	error/warning messages.
ld/
	* testsuite/ld-cris/pcrelcp-1.d,
	* testsuite/ld-mmix/start-2.d: Update.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] BFD messages
@ 2018-02-26  1:16 sergiodj+buildbot
  2018-02-26 14:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-26  1:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6e05870c978aaa057b5ae0f525a2e9b803047ac8 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 6e05870c978aaa057b5ae0f525a2e9b803047ac8

BFD messages

bfd/
	* archive.c, * bfd.c, * linker.c, * reloc.c, * stabs.c,
	* syms.c: Standardize error/warning messages.
binutils/
	* testsuite/binutils-all/mips/mips-reginfo-n32.d,
	* testsuite/binutils-all/mips/mips-reginfo.d: Update.
gas/
	* testsuite/gas/mips/reginfo-2.l: Update.
ld/
	* testsuite/ld-arm/cmse-implib-errors.out,
	* testsuite/ld-arm/cmse-new-earlier-later-implib.out,
	* testsuite/ld-arm/cmse-new-implib-not-sg-in-implib.out,
	* testsuite/ld-arm/cmse-new-wrong-implib.out,
	* testsuite/ld-arm/cmse-veneers-no-gnu_sgstubs.out,
	* testsuite/ld-arm/cmse-veneers-wrong-entryfct.out,
	* testsuite/ld-cris/badgotr1.d,
	* testsuite/ld-cris/tls-err-24.d,
	* testsuite/ld-cris/tls-err-25.d,
	* testsuite/ld-cris/tls-err-26.d,
	* testsuite/ld-cris/tls-err-27.d,
	* testsuite/ld-cris/tls-err-28.d,
	* testsuite/ld-cris/tls-err-40.d,
	* testsuite/ld-cris/tls-err-44.d,
	* testsuite/ld-cris/tls-err-48.d,
	* testsuite/ld-cris/tls-err-52.d,
	* testsuite/ld-cris/tls-err-53.d,
	* testsuite/ld-cris/tls-err-55.d,
	* testsuite/ld-cris/tls-err-56.d,
	* testsuite/ld-cris/tls-err-62.d,
	* testsuite/ld-cris/tls-err-65.d,
	* testsuite/ld-cris/tls-err-77.d,
	* testsuite/ld-elf/empty-implib.out,
	* testsuite/ld-elf/indirect.exp: Update.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] AOUT/COFF/PE messages
@ 2018-02-26  1:03 sergiodj+buildbot
  2018-02-26 12:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-26  1:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 59d08d6ce8cb6c41691266e133304c961c270e85 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 59d08d6ce8cb6c41691266e133304c961c270e85

AOUT/COFF/PE messages

Capitalization, full-stops and unnecessary trailing \n fixes.

	* aout-adobe.c, * aout-cris.c, * i386linux.c, * m68klinux.c,
	* sparclinux.c, * coff-alpha.c, * coff-arm.c, * coff-mcore.c,
	* coffcode.h, * coffgen.c, * cofflink.c, * ecoff.c, * pe-mips.c,
	* peXXigen.c, * peicode.h: Standardize error/warning messages.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] MIPS messages
@ 2018-02-26  0:38 sergiodj+buildbot
  2018-02-26  7:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-26  0:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2c1c96795601a19554fa3a86700a1b9e9d57c931 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 2c1c96795601a19554fa3a86700a1b9e9d57c931

MIPS messages

More standardization of messages.

bfd/
	* elfxx-mips.c: Standardize error/warning messages.
binutils/
	* testsuite/binutils-all/mips/mips-reginfo-n32.d,
	* testsuite/binutils-all/mips/mips-reginfo.d: Update.
gas/
	* testsuite/gas/mips/reginfo-2.l: Update.
ld/
	* testsuite/ld-mips-elf/attr-gnu-4-12.d,
	* testsuite/ld-mips-elf/attr-gnu-4-13.d,
	* testsuite/ld-mips-elf/attr-gnu-4-14.d,
	* testsuite/ld-mips-elf/attr-gnu-4-16.d,
	* testsuite/ld-mips-elf/attr-gnu-4-17.d,
	* testsuite/ld-mips-elf/attr-gnu-4-18.d,
	* testsuite/ld-mips-elf/attr-gnu-4-19.d,
	* testsuite/ld-mips-elf/attr-gnu-4-21.d,
	* testsuite/ld-mips-elf/attr-gnu-4-23.d,
	* testsuite/ld-mips-elf/attr-gnu-4-24.d,
	* testsuite/ld-mips-elf/attr-gnu-4-25.d,
	* testsuite/ld-mips-elf/attr-gnu-4-26.d,
	* testsuite/ld-mips-elf/attr-gnu-4-27.d,
	* testsuite/ld-mips-elf/attr-gnu-4-28.d,
	* testsuite/ld-mips-elf/attr-gnu-4-29.d,
	* testsuite/ld-mips-elf/attr-gnu-4-31.d,
	* testsuite/ld-mips-elf/attr-gnu-4-32.d,
	* testsuite/ld-mips-elf/attr-gnu-4-34.d,
	* testsuite/ld-mips-elf/attr-gnu-4-35.d,
	* testsuite/ld-mips-elf/attr-gnu-4-36.d,
	* testsuite/ld-mips-elf/attr-gnu-4-37.d,
	* testsuite/ld-mips-elf/attr-gnu-4-38.d,
	* testsuite/ld-mips-elf/attr-gnu-4-39.d,
	* testsuite/ld-mips-elf/attr-gnu-4-41.d,
	* testsuite/ld-mips-elf/attr-gnu-4-42.d,
	* testsuite/ld-mips-elf/attr-gnu-4-43.d,
	* testsuite/ld-mips-elf/attr-gnu-4-45.d,
	* testsuite/ld-mips-elf/attr-gnu-4-46.d,
	* testsuite/ld-mips-elf/attr-gnu-4-47.d,
	* testsuite/ld-mips-elf/attr-gnu-4-48.d,
	* testsuite/ld-mips-elf/attr-gnu-4-49.d,
	* testsuite/ld-mips-elf/attr-gnu-4-52.d,
	* testsuite/ld-mips-elf/attr-gnu-4-53.d,
	* testsuite/ld-mips-elf/attr-gnu-4-54.d,
	* testsuite/ld-mips-elf/attr-gnu-4-58.d,
	* testsuite/ld-mips-elf/attr-gnu-4-59.d,
	* testsuite/ld-mips-elf/attr-gnu-4-61.d,
	* testsuite/ld-mips-elf/attr-gnu-4-62.d,
	* testsuite/ld-mips-elf/attr-gnu-4-63.d,
	* testsuite/ld-mips-elf/attr-gnu-4-64.d,
	* testsuite/ld-mips-elf/attr-gnu-4-68.d,
	* testsuite/ld-mips-elf/attr-gnu-4-69.d,
	* testsuite/ld-mips-elf/attr-gnu-4-71.d,
	* testsuite/ld-mips-elf/attr-gnu-4-72.d,
	* testsuite/ld-mips-elf/attr-gnu-4-73.d,
	* testsuite/ld-mips-elf/attr-gnu-4-74.d,
	* testsuite/ld-mips-elf/attr-gnu-4-78.d,
	* testsuite/ld-mips-elf/attr-gnu-4-79.d,
	* testsuite/ld-mips-elf/attr-gnu-4-81.d,
	* testsuite/ld-mips-elf/attr-gnu-4-89.d,
	* testsuite/ld-mips-elf/attr-gnu-8-12.d,
	* testsuite/ld-mips-elf/attr-gnu-8-21.d,
	* testsuite/ld-mips-elf/bal-jalx-pic-micromips-n32.d,
	* testsuite/ld-mips-elf/bal-jalx-pic-micromips-n64.d,
	* testsuite/ld-mips-elf/bal-jalx-pic-micromips.d,
	* testsuite/ld-mips-elf/bal-jalx-pic-n32.d,
	* testsuite/ld-mips-elf/bal-jalx-pic-n64.d,
	* testsuite/ld-mips-elf/bal-jalx-pic.d,
	* testsuite/ld-mips-elf/mode-change-error-1.d,
	* testsuite/ld-mips-elf/unaligned-branch-2.d,
	* testsuite/ld-mips-elf/unaligned-branch-ignore-2.d,
	* testsuite/ld-mips-elf/unaligned-branch-ignore-micromips.d,
	* testsuite/ld-mips-elf/unaligned-branch-ignore-mips16.d,
	* testsuite/ld-mips-elf/unaligned-branch-ignore-r6-1.d,
	* testsuite/ld-mips-elf/unaligned-branch-micromips.d,
	* testsuite/ld-mips-elf/unaligned-branch-mips16.d,
	* testsuite/ld-mips-elf/unaligned-branch-r6-1.d,
	* testsuite/ld-mips-elf/unaligned-branch-r6-2.d,
	* testsuite/ld-mips-elf/unaligned-branch.d,
	* testsuite/ld-mips-elf/unaligned-jalx-1.d,
	* testsuite/ld-mips-elf/unaligned-jalx-3.d,
	* testsuite/ld-mips-elf/unaligned-jalx-addend-1.d,
	* testsuite/ld-mips-elf/unaligned-jalx-addend-3.d,
	* testsuite/ld-mips-elf/unaligned-jalx-addend-micromips-1.d,
	* testsuite/ld-mips-elf/unaligned-jalx-addend-mips16-1.d,
	* testsuite/ld-mips-elf/unaligned-jalx-micromips-1.d,
	* testsuite/ld-mips-elf/unaligned-jalx-mips16-1.d,
	* testsuite/ld-mips-elf/unaligned-jump-micromips.d,
	* testsuite/ld-mips-elf/unaligned-jump-mips16.d,
	* testsuite/ld-mips-elf/unaligned-jump.d: Update.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] ELF linker messages
@ 2018-02-26  0:14 sergiodj+buildbot
  2018-02-26  5:49 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-26  0:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9793eb77929a4ab2c0192d9bf5d3f8d20dd17394 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 9793eb77929a4ab2c0192d9bf5d3f8d20dd17394

ELF linker messages

This fixes a number of cases where we capitalized error messages or
printed a full-stop, and corrects "Dwarf" to "DWARF".

bfd/
	* dwarf2.c, * elf-attrs.c, * elf-eh-frame.c, * elf.c, * elf32-gen.c,
	* elflink.c: Standardize error/warning messages.  Replace use of
	linker callback einfo with _bfd_error_handler when possible.
ld/
	* testsuite/ld-elf/indirect.exp,
	* testsuite/ld-elf/pr22649-2ab-mips.msg,
	* testsuite/ld-elf/pr22649-2cd-mips.msg,
	* testsuite/ld-elf/pr22649.msg,
	* testsuite/ld-elf/tls_common.exp,
	* testsuite/ld-elfcomm/elfcomm.exp,
	* testsuite/ld-arm/attr-merge-incompatible.d,
	* testsuite/ld-tic6x/attr-compatibility-gnu-other.d,
	* testsuite/ld-tic6x/attr-compatibility-other-gnu.d,
	* testsuite/ld-tic6x/attr-compatibility-other-other.d,
	* testsuite/ld-i386/warn1.d: Update expected error/warning messages.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] unrecognized/unsupported reloc message
@ 2018-02-26  0:13 sergiodj+buildbot
  2018-02-26  3:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-26  0:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0aa13feeeb78fc9323bee329c4d91c30f25de121 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 0aa13feeeb78fc9323bee329c4d91c30f25de121

unrecognized/unsupported reloc message

It must get boring translating all the variants we have of
unrecognized/unsupported/invalid/unexpected reloc number.  This patch
cuts down on the number of variations.

	* aoutx.h, * coff-alpha.c, * coff-i860.c, * coff-m68k.c,
	* coff-mcore.c, * coff-ppc.c, * coff-rs6000.c, * coff-sh.c,
	* coff-tic4x.c, * coff-tic54x.c, * coff-tic80.c, * coff-w65.c,
	* elf-bfd.h, * elf-m10300.c, * elf.c, * elf32-avr.c, * elf32-bfin.c,
	* elf32-cr16.c, * elf32-cr16c.c, * elf32-cris.c, * elf32-crx.c,
	* elf32-d10v.c, * elf32-d30v.c, * elf32-dlx.c, * elf32-epiphany.c,
	* elf32-fr30.c, * elf32-frv.c, * elf32-i370.c, * elf32-i386.c,
	* elf32-i960.c, * elf32-ip2k.c, * elf32-iq2000.c, * elf32-lm32.c,
	* elf32-m32c.c, * elf32-m32r.c, * elf32-m68hc11.c, * elf32-m68hc12.c,
	* elf32-m68k.c, * elf32-mcore.c, * elf32-mep.c, * elf32-metag.c,
	* elf32-microblaze.c, * elf32-mips.c, * elf32-moxie.c,
	* elf32-msp430.c, * elf32-mt.c, * elf32-nds32.c, * elf32-or1k.c,
	* elf32-pj.c, * elf32-ppc.c, * elf32-rl78.c, * elf32-rx.c,
	* elf32-s390.c, * elf32-sh.c, * elf32-spu.c, * elf32-tic6x.c,
	* elf32-v850.c, * elf32-vax.c, * elf32-visium.c, * elf32-wasm32.c,
	* elf32-xgate.c, * elf32-xtensa.c, * elf64-alpha.c,
	* elf64-ia64-vms.c, * elf64-mips.c, * elf64-mmix.c,
	* elf64-ppc.c, * elf64-s390.c, * elf64-sparc.c, * elf64-x86-64.c,
	* elfn32-mips.c, * elfnn-aarch64.c, * elfnn-ia64.c,
	* elfnn-riscv.c, * elfxx-mips.c, * elfxx-riscv.c, * elfxx-riscv.h,
	* elfxx-sparc.c, * elfxx-sparc.h, * reloc.c: Standardize
	unrecognized/unsupported reloc message.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix double space expected in cp_test_ptype_class
@ 2018-02-25 20:37 sergiodj+buildbot
  2018-02-25 22:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-25 20:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6f6d0c269ecdc11aca9166940534ec61b6dbc39d ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 6f6d0c269ecdc11aca9166940534ec61b6dbc39d

Fix double space expected in cp_test_ptype_class

I noticed some failures of some buildbot slaves, e.g.:

FAIL: gdb.cp/nested-types.exp: ptype S10 (limit = 1) // wrong nested type enum definition: enum S10::E10 {S10::A10, S10::B10, S10::C10};

The issue is that they have an older gcc (not c++11 by default?) that
doesn't emit the enum underlying type information.  When the
enum type is printed by ptype, it looks like this:

  enum S10::E10 {S10::A10, S10::B10, S10::C10};

instead of this on older gccs:

  enum S10::E10 : unsigned int {S10::A10, S10::B10, S10::C10};

The regex that matches this is in cp_test_ptype_class, and is

  enum $nested_name (: (unsigned )?int)? \{

If the "unsigned int" portion is not present, then it requires the
string to have two spaces between the enum name and opening bracket.
The fix is simply to move the trailing space inside the ? group.

gdb/testsuite/ChangeLog:

	* lib/cp-support.exp (cp_test_ptype_class): Move space inside
	parentheses.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove most cleanups from linux-thread-db.c
@ 2018-02-24 17:31 sergiodj+buildbot
  2018-02-24 21:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-24 17:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9b292f68805700c7ae46fc149231fdb79554bd17 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 9b292f68805700c7ae46fc149231fdb79554bd17

Remove most cleanups from linux-thread-db.c

This removes most (but not all) cleanups from linux-thread-db.c.
std::string and std::vector are used in place of manual memory
management.

The remaining cleanup in linux-thread-db.c uses
make_cleanup_free_char_ptr_vec, which requires a somewhat bigger
change.

Regression tested by the buildbot.

ChangeLog
2018-02-24  Tom Tromey  <tom@tromey.com>

	* linux-thread-db.c (try_thread_db_load_from_pdir_1)
	(try_thread_db_load_from_dir, thread_db_load_search): Use
	std::string.
	(info_auto_load_libthread_db_compare): Return bool.  Change
	argument types.
	(info_auto_load_libthread_db): Use std::vector, std::string.
	Remove cleanups.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove cleanups from check_fast_tracepoint_sals
@ 2018-02-24 17:19 sergiodj+buildbot
  2018-02-24 18:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-24 17:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 281d762b1a56317171e462666b98d50bfa31a08a ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 281d762b1a56317171e462666b98d50bfa31a08a

Remove cleanups from check_fast_tracepoint_sals

This changes the gdbarch fast_tracepoint_valid_at method to use a
std::string as its out parameter, and then updates all the uses.  This
allows removing a cleanup from breakpoint.c.

Regression tested by the buildbot.

ChangeLog
2018-02-24  Tom Tromey  <tom@tromey.com>

	* i386-tdep.c (i386_fast_tracepoint_valid_at): "msg" now a
	std::string.
	* gdbarch.sh (fast_tracepoint_valid_at): Change "msg" to a
	std::string*.
	* gdbarch.c: Rebuild.
	* gdbarch.h: Rebuild.
	* breakpoint.c (check_fast_tracepoint_sals): Use std::string.
	* arch-utils.h (default_fast_tracepoint_valid_at): Update.
	* arch-utils.c (default_fast_tracepoint_valid_at): "msg" now a
	std::string*.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] GDB/testsuite: Fix a typo in $actual_line
@ 2018-02-23 20:31 sergiodj+buildbot
  2018-02-23 23:10 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-23 20:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 11b031457e89d5739922ddd0bc65c9d781b6db35 ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 11b031457e89d5739922ddd0bc65c9d781b6db35

GDB/testsuite: Fix a typo in $actual_line

Fix a commit 883fd55ab104 ("Record nested types") issue:

ERROR: tcl error sourcing .../gdb/testsuite/gdb.cp/nested-types.exp.
ERROR: can't read "actual_linejj": no such variable
    while executing
"append txt " definition: $actual_linejj""
    (procedure "cp_test_ptype_class" line 324)
    invoked from within
"cp_test_ptype_class $name "ptype $name (limit = $limit)" $key  $name $children"    (procedure "test_nested_limit" line 28)
    invoked from within
"test_nested_limit -1 false"
    (file ".../gdb/testsuite/gdb.cp/nested-types.exp" line 310)
    invoked from within
"source .../gdb/testsuite/gdb.cp/nested-types.exp"
    ("uplevel" body line 1)
    invoked from within
"uplevel #0 source .../gdb/testsuite/gdb.cp/nested-types.exp"
    invoked from within
"catch "uplevel #0 source $test_file_name""
testcase .../gdb/testsuite/gdb.cp/nested-types.exp completed in 9 seconds

caused by $actual_line having been accidentally referred to as
$actual_linejj in one place.

	gdb/testsuite/
	* lib/cp-support.exp (cp_test_ptype_class): Fix a typo in the
	name of a variable: $actual_linejj -> $actual_line.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR22881, null pointer dereference in assign_file_positions_for_non_load_sections
@ 2018-02-23 11:31 sergiodj+buildbot
  2018-02-23 13:47 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-23 11:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 01f7e10cf2dcf403462b2feed06c43135651556d ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 01f7e10cf2dcf403462b2feed06c43135651556d

PR22881, null pointer dereference in assign_file_positions_for_non_load_sections

	PR 22881
	* elf.c (assign_file_positions_for_non_load_sections): Remove RELRO
	segment if no matching LOAD segment.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] nds32: Support target directive .ict_model.
@ 2018-02-23  7:38 sergiodj+buildbot
  2018-02-23  9:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-23  7:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e859f6558cc027261fb733e4e86938e1d31c13ca ***

Author: Kuan-Lin Chen <kuanlinchentw@gmail.com>
Branch: master
Commit: e859f6558cc027261fb733e4e86938e1d31c13ca

nds32: Support target directive .ict_model.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] New plugin interface to get list of symbols wrapped with --wrap option.
@ 2018-02-22 22:16 sergiodj+buildbot
  2018-02-23  2:50 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-22 22:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0b65c07b97c43e8891c2e14061270878a85222c8 ***

Author: Sriraman Tallam <tmsriram@google.com>
Branch: master
Commit: 0b65c07b97c43e8891c2e14061270878a85222c8

New plugin interface to get list of symbols wrapped with --wrap option.

2018-02-22  Sriraman Tallam  <tmsriram@google.com>

	* plugin.cc (get_wrap_symbols): New plugin interface.
	(load): Add get_wrap_symbols to transfer vector.
	* plugin-api.h (ld_plugin_get_wrap_symbols): New plugin interface.
	* testsuite/plugin_test.c (onload): Call and check get_wrap_symbols
	interface.
	* testsuite/plugin_test_wrap_symbols.sh: New test script.
	* testsuite/plugin_test_wrap_symbols_1.cc: New file.
	* testsuite/plugin_test_wrap_symbols_2.cc: New file.
	* testsuite/Makefile.am (plugin_test_wrap_symbols): New test.
	* testsuite/Makefile.in: Regenerate.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: Add {rex} pseudo prefix
@ 2018-02-22 14:40 sergiodj+buildbot
  2018-02-22 23:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-22 14:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6b6b680700699c15e22b6c36975729035676eef1 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 6b6b680700699c15e22b6c36975729035676eef1

x86: Add {rex} pseudo prefix

Add {rex} pseudo prefix to generate a REX byte for integer and legacy
vector instructions if possible.  Note that this differs from the rex
prefix which generates REX prefix unconditionally.

gas/

	* config/tc-i386.c (_i386_insn): Add rex_encoding.
	(md_assemble): When i.rex_encoding is true, generate a REX byte
	if possible.
	(parse_insn): Set i.rex_encoding for {rex}.
	* doc/c-i386.texi: Document {rex}.
	* testsuite/gas/i386/x86-64-pseudos.s: Add {rex} tests.
	* testsuite/gas/i386/x86-64-pseudos.d: Updated.

opcodes/

	* i386-opc.tbl: Add {rex},
	* i386-tbl.h: Regenerated.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add "common-defs.h" include to files in arch/ subdir not yet including it.
@ 2018-02-21 19:23 sergiodj+buildbot
  2018-02-22 18:20 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 19:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8ec57239e91f22f427f8065eb742e6c8bfa223f1 ***

Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: 8ec57239e91f22f427f8065eb742e6c8bfa223f1

Add "common-defs.h" include to files in arch/ subdir not yet including it.

This fixes a build breakage on FreeBSD hosts.

gdb/ChangeLog:

	* arch/aarch64.c: Include "common-defs.h".
	* arch/amd64.c: Likewise.
	* arch/i386.c: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove a cleanup from call_function_by_hand_dummy
@ 2018-02-21 17:11 sergiodj+buildbot
  2018-02-22 13:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 17:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6ccb583f751e020a6db768d517c2dd3ba6d93cc4 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 6ccb583f751e020a6db768d517c2dd3ba6d93cc4

Remove a cleanup from call_function_by_hand_dummy

This removes a cleanup from call_function_by_hand_dummy, replacing
manual allocation with std::vector.

Regression tested by the buildbot.

gdb/ChangeLog
2018-02-21  Tom Tromey  <tom@tromey.com>

	* infcall.c (call_function_by_hand_dummy): Use std::vector.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove a cleanup from parse_expression_for_completion
@ 2018-02-21 16:31 sergiodj+buildbot
  2018-02-22 16:00 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 16:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3eac2b654808f9e233885f910045eea9d2ca0aa0 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 3eac2b654808f9e233885f910045eea9d2ca0aa0

Remove a cleanup from parse_expression_for_completion

This removes a cleanup from parse_expression_for_completion, by
changing various expression-completion functions to use
gdb::unique_xmalloc_ptry rather than explicit malloc+free.

Regression tested by the buildbot.

gdb/ChangeLog
2018-02-21  Tom Tromey  <tom@tromey.com>

	* value.h: (extract_field_op): Update.
	* eval.c (extract_field_op): Return a const char *.
	* expression.h (parse_expression_for_completion): Update.
	* completer.c (complete_expression): Update.
	(add_struct_fields): Make fieldname const.
	* parse.c (expout_completion_name): Now a unique_xmalloc_ptr.
	(mark_completion_tag, parse_exp_in_context_1): Update.
	(parse_expression_for_completion): Change "name" to
	unique_xmalloc_ptr*.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Move register_dump to regcache-dump.c
@ 2018-02-21 15:39 sergiodj+buildbot
  2018-02-22  8:18 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 15:39 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4c74fe6b84d82066eb3f004bacd4a376cd82d140 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 4c74fe6b84d82066eb3f004bacd4a376cd82d140

Move register_dump to regcache-dump.c

gdb:

2018-02-21  Yao Qi  <yao.qi@linaro.org>

	* Makefile.in (COMMON_SFILES): Add regcache-dump.c
	* regcache-dump.c: New file.
	* regcache.c: Move register_dump to regcache-dump.c.
	(maintenance_print_registers): Likewise.
	(maintenance_print_raw_registers): Likewise.
	(maintenance_print_cooked_registers): Likewise.
	(maintenance_print_register_groups): Likewise.
	(maintenance_print_remote_registers): Likewise.
	(_initialize_regcache): Likewise.
	* regcache.h (register_dump): Moved from regcache.c.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Pass readable_regcache to gdbarch method read_pc
@ 2018-02-21 13:27 sergiodj+buildbot
  2018-02-22 10:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 13:27 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c113ed0ca238bbcbc161f059ffe9b064e3ece333 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: c113ed0ca238bbcbc161f059ffe9b064e3ece333

Pass readable_regcache to gdbarch method read_pc

We can pass readable_regcache to gdbarch method read_pc where it is
allowed to do read from regcache.

gdb:

2018-02-21  Yao Qi  <yao.qi@linaro.org>

	* avr-tdep.c (avr_read_pc): Change parameter type to
	readable_regcache.
	* gdbarch.sh (read_pc): Likewise.
	* gdbarch.c: Re-generated.
	* gdbarch.h: Re-generated.
	* hppa-tdep.c (hppa_read_pc): Change parameter type to
	readable_regcache.
	* ia64-tdep.c (ia64_read_pc): Likewise.
	* mips-tdep.c (mips_read_pc): Likewise.
	* spu-tdep.c (spu_read_pc): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] No longer create readonly regcache
@ 2018-02-21 12:50 sergiodj+buildbot
  2018-02-22  4:57 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 12:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 215c69dc9a7d8f868198b5523abcf41458fb6e4a ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 215c69dc9a7d8f868198b5523abcf41458fb6e4a

No longer create readonly regcache

Nowadays, we create a readonly regcache in get_return_value, and pass it
to gdbarch_return_value to get the return value.  In theory, we can pass a
readable_regcache instance and get the return value, because we don't need
to modify the regcache.  Unfortunately, gdbarch_return_value is designed
to multiplex regcache, according to READBUF and WRITEBUF.

 # If READBUF is not NULL, extract the return value and save it in this
 # buffer.
 #
 # If WRITEBUF is not NULL, it contains a return value which will be
 # stored into the appropriate register.

In fact, gdbarch_return_value should be split to three functions, 1) only
return return_value_convention, 2) pass regcache_readonly and readbuf, 3)
pass regcache and writebuf.  These changes are out of the scope of this
patch series, so I pass regcache to gdbarch_return_value even for read,
and trust each gdbarch backend doesn't modify regcache.

gdb:

2018-02-21  Yao Qi  <yao.qi@linaro.org>

	* infcmd.c (get_return_value): Let stop_regs point to
	get_current_regcache.
	* regcache.c (regcache::regcache): Remove.
	(register_dump_reg_buffer): New class.
	(regcache_print): Adjust.
	* regcache.h (regcache): Remove constructors.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Class detached_regcache
@ 2018-02-21 12:25 sergiodj+buildbot
  2018-02-22  0:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 12:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c8ec2f334c3751c28d5f952d07dea9c0558ca0a0 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: c8ec2f334c3751c28d5f952d07dea9c0558ca0a0

Class detached_regcache

jit.c uses the regcache in a slightly different way, the regcache dosen't
write through to target, but it has read and write methods.  If I apply
regcache in record-full.c, it has the similar use pattern.  This patch
adds a new class detached_regcache, a register buffer, but can be
read and written.

Since jit.c doesn't want to write registers through to target, it uses
regcache as a readonly regcache (because only readonly regcache
disconnects from the target), but it adds a hole in regcache
(raw_set_cached_value) in order to modify a readonly regcache.  This patch
fixes this hole completely.

regcache inherits detached_regcache, and detached_regcache inherits
readable_regcache.  The ideal design is that both detached_regcache and
readable_regcache inherit reg_buffer, and regcache inherit
detached_regcache and regcache_read (virtual inheritance).  I concern
about the performance overhead of virtual inheritance, so I don't do it in
the patch.

gdb:

2018-02-21  Yao Qi  <yao.qi@linaro.org>

	* jit.c (struct jit_unwind_private) <regcache>: Change its type to
	 reg_buffer_rw *.
	(jit_unwind_reg_set_impl): Call raw_supply.
	(jit_frame_sniffer): Use reg_buffer_rw.
	* record-full.c (record_full_core_regbuf): Change its type.
	(record_full_core_open_1): Use reg_buffer_rw.
	(record_full_close): Likewise.
	(record_full_core_fetch_registers): Use regcache->raw_supply.
	(record_full_core_store_registers): Likewise.
	* regcache.c (regcache::get_register_status): Move it to
	reg_buffer.
	(regcache_raw_set_cached_value): Remove.
	(regcache::raw_set_cached_value): Remove.
	(regcache::raw_write): Call raw_supply.
	(regcache::raw_supply): Move it to reg_buffer_rw.
	* regcache.h (regcache_raw_set_cached_value): Remove.
	(reg_buffer_rw): New class.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Class readonly_detached_regcache
@ 2018-02-21 12:12 sergiodj+buildbot
  2018-02-21 21:45 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 12:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT daf6667d1f94c7e74df4076daf021cd28a2797b6 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: daf6667d1f94c7e74df4076daf021cd28a2797b6

Class readonly_detached_regcache

This patch adds a new class (type) for readonly regcache, which is
created via regcache::save.  readonly_detached_regcache inherits
readable_regcache.

gdb:

2018-02-21  Yao Qi  <yao.qi@linaro.org>

	* dummy-frame.c (dummy_frame_cache) <prev_regcache>: Use
	readonly_detached_regcache.
	(dummy_frame_prev_register): Use regcache->cooked_read.
	* frame.c (frame_save_as_regcache): Change return type.
	(frame_pop): Update.
	* frame.h (frame_save_as_regcache): Update declaration.
	* inferior.h (get_infcall_suspend_state_regcache): Update
	declaration.
	* infrun.c (infcall_suspend_state) <registers>: use
	readonly_detached_regcache.
	(save_infcall_suspend_state): Don't use regcache_dup.
	(get_infcall_suspend_state_regcache): Change return type.
	* linux-fork.c (struct fork_info) <savedregs>: Change to
	readonly_detached_regcache.
	<pc>: New field.
	(fork_save_infrun_state): Don't use regcache_dup.
	(info_checkpoints_command): Adjust.
	* mi/mi-main.c (register_changed_p): Update declaration.
	(mi_cmd_data_list_changed_registers): Use
	readonly_detached_regcache.
	(register_changed_p): Change parameter type to
	readonly_detached_regcache.
	* ppc-linux-tdep.c (ppu2spu_cache) <regcache>: Use
	readonly_detached_regcache.
	(ppu2spu_sniffer): Construct a new readonly_detached_regcache.
	* regcache.c (readonly_detached_regcache::readonly_detached_regcache):
	New.
	(regcache::save): Move it to reg_buffer.
	(regcache::restore): Change parameter type.
	(regcache_dup): Remove.
	* regcache.h (reg_buffer) <save>: New method.
	(readonly_detached_regcache): New class.
	* spu-tdep.c (spu2ppu_cache) <regcache>: Use
	readonly_detached_regcache.
	(spu2ppu_sniffer): Construct a new readonly_detached_regcache.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove regcache_save and regcache_cpy
@ 2018-02-21 12:00 sergiodj+buildbot
  2018-02-21 19:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 12:00 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fc5b87361580d915e28ae5f3cc4794b75b671b5a ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: fc5b87361580d915e28ae5f3cc4794b75b671b5a

Remove regcache_save and regcache_cpy

... instead we start to use regcache methods save and restore.  It is
quite straightforward to replace regcache_save with regcache->save.

regcache_cpy has some asserts, some of them not necessary, like

 gdb_assert (src != dst);

because we already assert !m_readonly_p and src->m_readonly_p, so
src isn't dst.  Some of the asserts are moved to ::restore.

gdb:

2018-02-21  Yao Qi  <yao.qi@linaro.org>

	* frame.c (frame_save_as_regcache): Use regcache method save.
	(frame_pop): Use regcache method restore.
	* infrun.c (restore_infcall_suspend_state): Likewise.
	* linux-fork.c (fork_load_infrun_state): Likewise.
	* ppc-linux-tdep.c (ppu2spu_sniffer): User regcache method
	save.
	* regcache.c (regcache_save): Remove.
	(regcache::restore): More asserts.
	(regcache_cpy): Remove.
	* regcache.h (regcache_save): Remove the declaration.
	(regcache::restore): Move from private to public.
	Remove the friend declaration of regcache_cpy.
	(regcache_cpy): Remove declaration.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] class readable_regcache and pass readable_regcache to gdbarch pseudo_register_read and pseudo_register_read_value
@ 2018-02-21 11:47 sergiodj+buildbot
  2018-02-21 16:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 11:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 849d0ba802323fe05e3039ed5b22957db2c85a67 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 849d0ba802323fe05e3039ed5b22957db2c85a67

class readable_regcache and pass readable_regcache to gdbarch pseudo_register_read and pseudo_register_read_value

pseudo registers are either from raw registers or memory, so
gdbarch methods pseudo_register_read and pseudo_register_read_value
should have regcache object which only have read methods.  In other
words, we should disallow writing to regcache in these two gdbarch
methods.  In order to apply this restriction, this patch adds a new
class readable_regcache, derived from reg_buffer, and it only has
raw_read and cooked_read methods.  regcache is derived from
readable_regcache.  This patch also passes readable_regcache instead of
regcache to gdbarch methods pseudo_register_read and
pseudo_register_read_value.

This patch moves raw_read* and cooked_read* methods to readable_regcache,
which is straightforward.  One thing not straightforward is that I split
regcache::xfer_part to readable_regcache::read_part and regcache::write_part,
because readable_regcache can only have methods to read.

readable_regcache is an abstract base class, and it has a pure virtual
function raw_update, because I don't want readable_regcache know where
these raw registers are from.  They can be from either the target
(readwrite regcache) or the regcache itself (readonly regcache).

gdb:

2018-02-21  Yao Qi  <yao.qi@linaro.org>

	* aarch64-tdep.c (aarch64_pseudo_register_read_value): Change
	parameter type to 'readable_regcache *'.
	* amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
	* arm-tdep.c (arm_neon_quad_read): Likewise.
	(arm_pseudo_read): Likewise.
	* avr-tdep.c (avr_pseudo_register_read): Likewise.
	* bfin-tdep.c (bfin_pseudo_register_read): Likewise.
	* frv-tdep.c (frv_pseudo_register_read): Likewise.
	* gdbarch.c: Re-generated.
	* gdbarch.h: Re-generated.
	* gdbarch.sh (pseudo_register_read): Change parameter type to
	'readable_regcache *'.
	(pseudo_register_read_value): Likewise.
	* h8300-tdep.c (pseudo_from_raw_register): Likewise.
	(h8300_pseudo_register_read): Likewise.
	* hppa-tdep.c (hppa_pseudo_register_read): Likewise.
	* i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
	(i386_pseudo_register_read_into_value): Likewise.
	(i386_pseudo_register_read_value): Likewise.
	* i386-tdep.h (i386_pseudo_register_read_into_value): Update
	declaration.
	* ia64-tdep.c (ia64_pseudo_register_read): Likewise.
	* m32c-tdep.c (m32c_raw_read): Likewise.
	(m32c_read_flg): Likewise.
	(m32c_banked_register): Likewise.
	(m32c_banked_read): Likewise.
	(m32c_sb_read): Likewise.
	(m32c_part_read): Likewise.
	(m32c_cat_read): Likewise.
	(m32c_r3r2r1r0_read): Likewise.
	(m32c_pseudo_register_read): Likewise.
	* m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
	* mep-tdep.c (mep_pseudo_cr32_read): Likewise.
	(mep_pseudo_cr64_read): Likewise.
	(mep_pseudo_register_read): Likewise.
	* mips-tdep.c (mips_pseudo_register_read): Likewise.
	* msp430-tdep.c (msp430_pseudo_register_read): Likewise.
	* nds32-tdep.c (nds32_pseudo_register_read): Likewise.
	* regcache.c (regcache::raw_read): Move it to readable_regcache.
	(regcache::cooked_read): Likewise.
	(regcache::cooked_read_value): Likewise.
	(regcache_cooked_read_signed):
	(regcache::cooked_read): Likewise.
	* regcache.h (readable_regcache): New class.
	(regcache): Inherit readable_regcache.  Move some methods to
	readable_regcache.
	* rl78-tdep.c (rl78_pseudo_register_read): Change
	parameter type to 'readable_regcache *'.
	* rs6000-tdep.c (do_regcache_raw_read): Remove.
	(e500_pseudo_register_read): Change parameter type to
	'readable_regcache *'.
	(dfp_pseudo_register_read): Likewise.
	(vsx_pseudo_register_read): Likewise.
	(efpr_pseudo_register_read): Likewise.
	* s390-tdep.c (s390_pseudo_register_read): Likewise.
	* sh-tdep.c (sh_pseudo_register_read): Likewise.
	* sh64-tdep.c (pseudo_register_read_portions): Likewise.
	(sh64_pseudo_register_read): Likewise.
	* sparc-tdep.c (sparc32_pseudo_register_read): Likewise.
	* sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
	* spu-tdep.c (spu_pseudo_register_read_spu): Likewise.
	(spu_pseudo_register_read): Likewise.
	* xtensa-tdep.c	(xtensa_register_read_masked): Likewise.
	(xtensa_pseudo_register_read): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Class reg_buffer
@ 2018-02-21 11:39 sergiodj+buildbot
  2018-02-21 13:53 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-21 11:39 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 31716595b5bda8524fc841378468fd1c47510dd3 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 31716595b5bda8524fc841378468fd1c47510dd3

Class reg_buffer

This patch adds a new class reg_buffer, and regcache inherits it.  Class
reg_buffer is a very simple class, which has the buffer for register
contents and status only.  It doesn't have any methods to set contents and
status, and it is expected that its children classes can inherit it and
add different access methods.

Another reason I keep class reg_buffer so simple is that I think
reg_buffer can be even reused in other classes which need to record the
registers contents and status, like frame cache for example.

gdb:

2018-02-21  Yao Qi  <yao.qi@linaro.org>

	* regcache.c (regcache::regcache): Call reg_buffer ctor.
	(regcache::arch): Move it to reg_buffer::arch.
	(regcache::register_buffer): Likewise.
	(regcache::assert_regnum): Likewise.
	(regcache::num_raw_registers): Likewise.
	* regcache.h (reg_buffer): New class.
	(regcache): Inherit reg_buffer.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] MIPS16/opcodes: Free up `M' operand code
@ 2018-02-20 21:11 sergiodj+buildbot
  2018-02-20 23:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-20 21:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 75f31665204bf965cc5b3dd699636be12fb6bcfa ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 75f31665204bf965cc5b3dd699636be12fb6bcfa

MIPS16/opcodes: Free up `M' operand code

The `M' and `m' MIPS16 operand codes are functionally the same, denoting
a 7-bit register list that is encoded the same way for both SAVE and
RESTORE.  Use `m' for both instructions then, making `M' available for a
different use.

	opcodes/
	* mips16-opc.c (decode_mips16_operand) <'M'>: Remove case.
	(mips16_opcodes): Replace `M' with `m' for "restore".

	include/
	* opcode/mips.h: Remove `M' operand code.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] remote-sim: Add missing ATTRIBUTE_PRINTF
@ 2018-02-20 16:58 sergiodj+buildbot
  2018-02-20 20:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-20 16:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7104e59bece90e387d70f617eb7ed4c34087283d ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 7104e59bece90e387d70f617eb7ed4c34087283d

remote-sim: Add missing ATTRIBUTE_PRINTF

Fixes:

/home/emaisin/src/binutils-gdb/gdb/remote-sim.c:385:34: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
  vfprintf_filtered (gdb_stdout, format, args);
                                 ^~~~~~
/home/emaisin/src/binutils-gdb/gdb/remote-sim.c:394:34: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
  vfprintf_filtered (gdb_stdout, format, ap);
                                 ^~~~~~
/home/emaisin/src/binutils-gdb/gdb/remote-sim.c:402:34: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
  vfprintf_filtered (gdb_stderr, format, ap);
                                 ^~~~~~
/home/emaisin/src/binutils-gdb/gdb/remote-sim.c:413:11: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
  verror (format, args);
          ^~~~~~
4 errors generated.

gdb/ChangeLog:

	* remote-sim.c (gdb_os_printf_filtered, gdb_os_vprintf_filtered,
	gdb_os_evprintf_filtered, gdb_os_error): Add ATTRIBUTE_PRINTF.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Enable link time garbage collection support for the IA64 target.
@ 2018-02-20 14:56 sergiodj+buildbot
  2018-02-20 19:00 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-20 14:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6e8d06db1a6e63e0da80035114dbfefeabf63d87 ***

Author: Jason Duerstock <jason.duerstock@gmail.com>
Branch: master
Commit: 6e8d06db1a6e63e0da80035114dbfefeabf63d87

Enable link time garbage collection support for the IA64 target.

As suggested in long ago in a galaxy far, far away [1], I tried
turning it on and it seems to work, as is evidenced by the Mesa
package in Debian/ia64.  Please enable it with the following patch.
[1] https://sourceware.org/ml/binutils/2007-07/msg00241.html

bfd	* elfnn-ia64.c (elf_backend_can_gc_sections): Enable.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix make 3.81 build errors
@ 2018-02-20 11:13 sergiodj+buildbot
  2018-02-20 13:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-20 11:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a543c5ca7c1285548726e6d92ca6044dc1963340 ***

Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: a543c5ca7c1285548726e6d92ca6044dc1963340

Fix make 3.81 build errors

gdbserver/
	* Makefile.in: Switch order of make rules.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PT_LOAD and PT_GNU_RELRO segment overlap
@ 2018-02-19  3:38 sergiodj+buildbot
  2018-02-19  5:03 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-19  3:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT dbc88fc14992c556b94e77de563a8f7abcb0b653 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: dbc88fc14992c556b94e77de563a8f7abcb0b653

PT_LOAD and PT_GNU_RELRO segment overlap

Commit 325ba6fb34 excluded degenerate zero length PT_LOAD segments,
but that only fixed part of the problem, which was that the load
segment limits were not calculated properly.

	PR 22845
	* elf.c (IS_TBSS): Define.
	(_bfd_elf_map_sections_to_segments): Use IS_TBSS.
	(assign_file_positions_for_non_load_sections): Revert last change.
	Properly calculate load segment limits to compare against relro limits.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] New class allocate_on_obstack
@ 2018-02-16 16:34 sergiodj+buildbot
  2018-02-16 18:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-16 16:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fd90ace4c1e77c94e90d2942cebe84e9a2019c0f ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: fd90ace4c1e77c94e90d2942cebe84e9a2019c0f

New class allocate_on_obstack

This patch adds a new class allocate_on_obstack, and let dwarf2_per_objfile
inherit it, so that dwarf2_per_objfile is automatically allocated on
obstack, and "delete dwarf2_per_objfile" doesn't de-allocate any space.

gdb:

2018-02-16  Yao Qi  <yao.qi@linaro.org>

	* block.c (block_namespace_info): Inherit allocate_on_obstack.
	(block_initialize_namespace): Use new.
	* dwarf2read.c (dwarf2_per_objfile): Inherit allocate_on_obstack.
	(dwarf2_free_objfile): Use delete.
	* gdbtypes.c (type_pair): Inherit allocate_on_obstack.
	(copy_type_recursive): Use new.
	* gdb_obstack.h (allocate_on_obstack): New.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] RISC-V: Fix relocation failure with zero address sections.
@ 2018-02-15 22:04 sergiodj+buildbot
  2018-02-16  0:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-15 22:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 09ca4b9d9bd61ecb779386a6cc7796cb05dde1af ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 09ca4b9d9bd61ecb779386a6cc7796cb05dde1af

RISC-V: Fix relocation failure with zero address sections.

	bfd/
	* elfnn-riscv.c (_bfd_riscv_relax_section): Ifdef out check to ignore
	symbols whose section address is zero.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] RISC-V: Give error for ignored pcrel_lo addend.
@ 2018-02-15 19:14 sergiodj+buildbot
  2018-02-15 21:59 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-15 19:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2a0d98534964649bc6884b7833c6c4089159a6df ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 2a0d98534964649bc6884b7833c6c4089159a6df

RISC-V: Give error for ignored pcrel_lo addend.

	bfd/
	* elfnn-riscv.c (riscv_elf_relocate_section): Use bfd_reloc_dangerous
	when pcrel_lo reloc has an addend.  Use reloc_dangerous callback for
	bfd_reloc_dangerous.  Use einfo instead of warning callback for errors.
	Add %X%P to error messages.

	ld/
	* testsuite/ld-riscv-elf/ld-riscv-elf.exp: Run pcrel-lo-addend test.
	* testsuite/ld-riscv-elf/pcrel-lo-addend.d: New.
	* testsuite/ld-riscv-elf/pcrel-lo-addend.s: New.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR ld/22832 on SPARC.
@ 2018-02-15 15:29 sergiodj+buildbot
  2018-02-15 20:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-15 15:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e513bd38a6b91401947d90ba5f301f01d3991b8e ***

Author: Eric Botcazou <ebotcazou@gcc.gnu.org>
Branch: master
Commit: e513bd38a6b91401947d90ba5f301f01d3991b8e

PR ld/22832 on SPARC.

The fix for PR ld/22727 on SPARC passed TRUE as the 'create' argument
in the call to bfd_link_hash_lookup.  It turns out this was a bad idea
because, if the symbol is created at this point, the link will abort
later in elf_link_output_extsym.  This changes the TRUE into a FALSE
and puts an assertion on the result of the call, making it easier to
debug the issue; that's exactly in keeping with what Gold does.

bfd/
	* elfxx-sparc.c (_bfd_sparc_elf_check_relocs) <R_SPARC_TLS_GD_CALL>:
	Pass FALSE instead of TRUE as 'create' argument to bfd_link_hash_lookup
	and assert that the result of the call is not NULL.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] delete ada-lang.c::ada_to_fixed_value_create advance declaration
@ 2018-02-15  4:34 sergiodj+buildbot
  2018-02-15  5:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-15  4:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 355c559b74518b67eb113e635363cc890058746c ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 355c559b74518b67eb113e635363cc890058746c

delete ada-lang.c::ada_to_fixed_value_create advance declaration

This advance declaration really isn't necesary, since the implementation
of this function comes before the first reference to it.

gdb/ChangeLog:

        * ada-lang.c (ada_to_fixed_value_create): Delete advance
        declaration.

Tested by rebuilding GDB.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix GDB crash after Quit thrown from unwinder sniffer
@ 2018-02-14 19:26 sergiodj+buildbot
  2018-02-15  4:00 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-14 19:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 980548fd880338d2cdf4ce641ca39632dc040426 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 980548fd880338d2cdf4ce641ca39632dc040426

Fix GDB crash after Quit thrown from unwinder sniffer

I ran into a GDB crash in gdb.base/bp-cmds-continue-ctrl-c.exp in my
multi-target branch, which turns out exposed a bug that exists in
master too.

That testcase has a breakpoint with a "continue" command associated.
Then the breakpoint is constantly being hit.  At the same time, the
testcase is continualy interrupting the program with Ctrl-C, and
re-resuming it, in a loop.

Running that testcase manually under Valgrind, after a few sequences
of 'Ctrl-C' + 'continue', I got:

 Breakpoint 1, Quit
 (gdb) ==21270== Invalid read of size 8
 ==21270==    at 0x4D8185: pyuw_this_id(frame_info*, void**, frame_id*) (py-unwind.c:461)
 ==21270==    by 0x6D426A: compute_frame_id(frame_info*) (frame.c:505)
 ==21270==    by 0x6D43B7: get_frame_id(frame_info*) (frame.c:537)
 ==21270==    by 0x84F3B8: scoped_restore_current_thread::scoped_restore_current_thread() (thread.c:1678)
 ==21270==    by 0x718E3D: fetch_inferior_event(void*) (infrun.c:4076)
 ==21270==    by 0x7067C9: inferior_event_handler(inferior_event_type, void*) (inf-loop.c:43)
 ==21270==    by 0x45BEF9: handle_target_event(int, void*) (linux-nat.c:4419)
 ==21270==    by 0x6C4255: handle_file_event(file_handler*, int) (event-loop.c:733)
 ==21270==    by 0x6C47F8: gdb_wait_for_event(int) (event-loop.c:859)
 ==21270==    by 0x6C3666: gdb_do_one_event() (event-loop.c:322)
 ==21270==    by 0x6C3712: start_event_loop() (event-loop.c:371)
 ==21270==    by 0x746801: captured_command_loop() (main.c:329)
 ==21270==  Address 0x0 is not stack'd, malloc'd or (recently) free'd
 ==21270==
 ==21270==
 ==21270== Process terminating with default action of signal 11 (SIGSEGV): dumping core
 ==21270==  Access not within mapped region at address 0x0
 ==21270==    at 0x4D8185: pyuw_this_id(frame_info*, void**, frame_id*) (py-unwind.c:461)
 ==21270==    by 0x6D426A: compute_frame_id(frame_info*) (frame.c:505)
 ==21270==    by 0x6D43B7: get_frame_id(frame_info*) (frame.c:537)
 ==21270==    by 0x84F3B8: scoped_restore_current_thread::scoped_restore_current_thread() (thread.c:1678)
 ==21270==    by 0x718E3D: fetch_inferior_event(void*) (infrun.c:4076)
 ==21270==    by 0x7067C9: inferior_event_handler(inferior_event_type, void*) (inf-loop.c:43)
 ==21270==    by 0x45BEF9: handle_target_event(int, void*) (linux-nat.c:4419)
 ==21270==    by 0x6C4255: handle_file_event(file_handler*, int) (event-loop.c:733)
 ==21270==    by 0x6C47F8: gdb_wait_for_event(int) (event-loop.c:859)
 ==21270==    by 0x6C3666: gdb_do_one_event() (event-loop.c:322)
 ==21270==    by 0x6C3712: start_event_loop() (event-loop.c:371)
 ==21270==    by 0x746801: captured_command_loop() (main.c:329)
 ==21270==  If you believe this happened as a result of a stack
 ==21270==  overflow in your program's main thread (unlikely but
 ==21270==  possible), you can try to increase the size of the
 ==21270==  main thread stack using the --main-stacksize= flag.
 ==21270==  The main thread stack size used in this run was 8388608.
 ==21270==

Above, when we get to compute_frame_id, fi->unwind is non-NULL,
meaning, we found an unwinder, in this case the Python unwinder, but
somehow, fi->prologue_cache is left NULL.  pyuw_this_id then crashes
because it assumes fi->prologue_cache is non-NULL:

  static void
  pyuw_this_id (struct frame_info *this_frame, void **cache_ptr,
		struct frame_id *this_id)
  {
    *this_id = ((cached_frame_info *) *cache_ptr)->frame_id;
                                      ^^^^^^^^^^

'*cache_ptr' here is 'fi->prologue_cache'.

There's a quit() call in pyuw_sniffer that I believe is the one that
sometimes triggers the crash above.  The crash can be reproduced
easily with this hack to force a quit out of the python unwinder:

 --- a/gdb/python/py-unwind.c
 +++ b/gdb/python/py-unwind.c
 @@ -497,6 +497,8 @@ pyuw_sniffer (const struct frame_unwind *self, struct frame_info *this_frame,
    struct gdbarch *gdbarch = (struct gdbarch *) (self->unwind_data);
    cached_frame_info *cached_frame;

 +  quit ();
 +
    gdbpy_enter enter_py (gdbarch, current_language);

    TRACE_PY_UNWIND (3, "%s (SP=%s, PC=%s)\n", __FUNCTION__,

After that quit is thrown, any subsequent operation that involves
unwinding results in GDB crashing with SIGSEGV like above.

The problem is that this commit:

  commit 30a9c02feff56bd58a276c2a7262f364baa558ac
  CommitDate: Sun Oct 8 23:16:42 2017 -0600
  Subject: Remove cleanup from frame_prepare_for_sniffer

missed that we need to call frame_cleanup_after_sniffer before
rethrowing the exception too.

Without the fix, the "bt" added to
gdb.base/bp-cmds-continue-ctrl-c.exp in this commit makes GDB crash:

  Running src/gdb/testsuite/gdb.base/bp-cmds-continue-ctrl-c.exp ...
  ERROR: Process no longer exists

gdb/ChangeLog:
2018-02-14  Pedro Alves  <palves@redhat.com>

	* frame-unwind.c (frame_unwind_try_unwinder): Always call
	frame_cleanup_after_sniffer on exception.

gdb/testsuite/ChangeLog:
2018-02-14  Pedro Alves  <palves@redhat.com>

	* gdb.base/bp-cmds-continue-ctrl-c.exp (do_test): Test "bt" after
	getting a "Quit".


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Constify target_so_ops::bfd_open
@ 2018-02-14 16:14 sergiodj+buildbot
  2018-02-15  2:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-14 16:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 692d6f9760bc67b68a5c96baac47067fd7dfa711 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 692d6f9760bc67b68a5c96baac47067fd7dfa711

Constify target_so_ops::bfd_open

This constifies the bfd_open method of struct target_so_ops.

gdb/ChangeLog
2018-02-14  Tom Tromey  <tom@tromey.com>

	* solist.h (struct target_so_ops) <bfd_open>: Make pathname
	const.
	(solib_bfd_open): Make pathname const.
	* solib.c (solib_bfd_open): Make pathname const.
	* solib-spu.c (spu_bfd_fopen): Make name const.
	(spu_bfd_open): Make pathname const.
	* solib-darwin.c (darwin_bfd_open): Make pathname const.
	* solib-aix.c (solib_aix_bfd_open): Make pathname const.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Move some declarations to source.h
@ 2018-02-14 15:50 sergiodj+buildbot
  2018-02-14 22:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-14 15:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b46a8d7c1d50c06e641af99b58301db0499111b9 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: b46a8d7c1d50c06e641af99b58301db0499111b9

Move some declarations to source.h

I noticed a few declarations in defs.h that really could be put into
source.h.  I think it's generally preferable to something out of
defs.h unless it is needed by most of the files in gdb.

gdb/ChangeLog
2018-02-14  Tom Tromey  <tom@tromey.com>

	* solib.c: Include source.h.
	* nto-tdep.c: Include source.h.
	* mi/mi-cmd-env.c: Include source.h.
	* infcmd.c: Include source.h.
	* exec.c: Include source.h.
	* defs.h (enum openp_flag, openp, source_full_path_of, mod_path)
	(add_path, directory_switch, source_path, init_source_path): Move
	declarations...
	* source.h (enum openp_flag, openp, source_full_path_of, mod_path)
	(add_path, directory_switch, source_path, init_source_path):
	...here.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Return unique_xmalloc_ptr from some solib.c functions
@ 2018-02-14 15:37 sergiodj+buildbot
  2018-02-14 19:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-14 15:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 797bc1cb25b9dbdbc663cf711aecb0acc2450276 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 797bc1cb25b9dbdbc663cf711aecb0acc2450276

Return unique_xmalloc_ptr from some solib.c functions

This changes a couple of solib.c functions -- exec_file_find and
solib_find -- to return a unique_xmalloc_ptr, and then fixes up the
users.  This allows the removal of some cleanups.

This also changes solib_bfd_open to not take ownership of its
argument.  I think this change is somewhat cleaner.

gdb/ChangeLog
2018-02-14  Tom Tromey  <tom@tromey.com>

	* solist.h (exec_file_find, solib_find): Return
	unique_xmalloc_ptr.
	(solib_bfd_fopen): Take a const char *.
	* solib.c (solib_find_1): Return unique_xmalloc_ptr.
	(exec_file_find, solib_find): Likewise.
	(solib_bfd_fopen): Do not take ownership of "pathname".
	(solib_bfd_open): Use unique_xmalloc_ptr.
	* solib-darwin.c (darwin_bfd_open): Use unique_xmalloc_ptr.
	* solib-aix.c (solib_aix_bfd_open): Use unique_xmalloc_ptr.
	* infrun.c (follow_exec): Use unique_xmalloc_ptr.
	* exec.c (exec_file_locate_attach): Use unique_xmalloc_ptr.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix compilation of the BFD sub-directory with a gcc v8 compiler by adding extra casts.
@ 2018-02-14 15:16 sergiodj+buildbot
  2018-02-14 17:45 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-14 15:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 12ef3f5a7c5a6b89964842fd3da047b8d07dec91 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 12ef3f5a7c5a6b89964842fd3da047b8d07dec91

Fix compilation of the BFD sub-directory with a gcc v8 compiler by adding extra casts.

GCC v8 issues warnings about mis-matching casts of function pointers.
A previous patch tried to fix this problem by adding new dummy functions
which accepted a variable number of arguments.  But this introduces serious
problems when compiled with other versions of gcc, (notably gcc 4.4).  This
patch reverts that previous solution and instead adds extra casts (to
function types without a parameter list).

For more details see: https://sourceware.org/ml/binutils/2018-02/msg00198.html

	PR 22823
	Revert previous delta.  Add extra casts to avoid compile time
	warnings instead.
	* libbfd-in.h (_bfd_generic_bfd_copy_private_bfd_data): Add extra
	cast to avoid warning from gcc v8 compiler.
	(_bfd_generic_bfd_merge_private_bfd_data): Likewise.
	(_bfd_generic_bfd_set_private_flags): Likewise.
	(_bfd_generic_bfd_copy_private_section_data): Likewise.
	(_bfd_generic_bfd_copy_private_symbol_data): Likewise.
	(_bfd_generic_bfd_copy_private_header_data): Likewise.
	(_bfd_generic_bfd_print_private_bfd_data): Likewise.
	(_bfd_noarchive_construct_extended_name_table): Likewise.
	(_bfd_noarchive_truncate_arname): Likewise.
	(_bfd_noarchive_write_ar_hdr): Likewise.
	(_bfd_noarchive_get_elt_at_index): Likewise.
	(_bfd_nosymbols_canonicalize_symtab): Likewise.
	(_bfd_nosymbols_print_symbol): Likewise.
	(_bfd_nosymbols_get_symbol_info): Likewise.
	(_bfd_nosymbols_get_symbol_version_string): Likewise.
	(_bfd_nosymbols_bfd_is_local_label_name): Likewise.
	(_bfd_nosymbols_bfd_is_target_special_symbol): Likewise.
	(_bfd_nosymbols_get_lineno): Likewise.
	(_bfd_nosymbols_find_nearest_line): Likewise.
	(_bfd_nosymbols_find_line): Likewise.
	(_bfd_nosymbols_find_inliner_info): Likewise.
	(_bfd_nosymbols_bfd_make_debug_symbol): Likewise.
	(_bfd_nosymbols_read_minisymbols): Likewise.
	(_bfd_nosymbols_minisymbol_to_symbol): Likewise.
	(_bfd_norelocs_bfd_reloc_type_lookup): Likewise.
	(_bfd_norelocs_bfd_reloc_name_lookup): Likewise.
	(_bfd_nowrite_set_arch_mach): Likewise.
	(_bfd_nowrite_set_section_contents): Likewise.
	(_bfd_nolink_sizeof_headers): Likewise.
	(_bfd_nolink_bfd_get_relocated_section_contents): Likewise.
	(_bfd_nolink_bfd_relax_section): Likewise.
	(_bfd_nolink_bfd_gc_sections): Likewise.
	(_bfd_nolink_bfd_lookup_section_flags): Likewise.
	(_bfd_nolink_bfd_merge_sections): Likewise.
	(_bfd_nolink_bfd_is_group_section): Likewise.
	(_bfd_nolink_bfd_discard_group): Likewise.
	(_bfd_nolink_bfd_link_hash_table_create): Likewise.
	(_bfd_nolink_bfd_link_add_symbols): Likewise.
	(_bfd_nolink_bfd_link_just_syms): Likewise.
	(_bfd_nolink_bfd_copy_link_hash_symbol_type): Likewise.
	(_bfd_nolink_bfd_final_link): Likewise.
	(_bfd_nolink_bfd_link_split_section): Likewise.
	(_bfd_nolink_section_already_linked): Likewise.
	(_bfd_nolink_bfd_define_common_symbol): Likewise.
	(_bfd_nolink_bfd_define_start_stop): Likewise.
	(_bfd_nodynamic_canonicalize_dynamic_symtab): Likewise.
	(_bfd_nodynamic_get_synthetic_symtab): Likewise.
	(_bfd_nodynamic_get_dynamic_reloc_upper_bound _bfd_): Likewise.
	(_bfd_nodynamic_canonicalize_dynamic_reloc): Likewise.
	* libbfd.c (bfd_false_any): Delete.
	(bfd_true_any, bfd_nullvoidptr_any, bfd_0_any): Delete.
	(bfd_0u_any, bfd_0l_any, _bfd_n1_any, bfd_void_any): Delete.
	* libbfd.h (extern): Regenerate
	* aout-target.h (MY_bfd_is_target_special_symbol): Add extra
	cast to avoid warning from gcc v8 compiler.
	* aout-tic30.c (tic30_aout_set_arch_mach): Likewise.
	* binary.c (binary_get_symbol_info): Likewise.
	* coff-alpha.c (alpha_ecoff_backend_data): Likewise.
	* coff-mips.c (mips_ecoff_backend_data): Likewise.
	* coffcode.h (coff_set_alignment_hook): Likewise.
	(symname_in_debug_hook): Likewise.
	(bfd_coff_backend_data bigobj_swap_table): Likewise.
	* elf-m10300.c (elf_backend_omit_section_dynsym): Likewise.
	* elf32-cr16.c (elf_backend_omit_section_dynsym): Likewise.
	* elf32-lm32.c (elf_backend_omit_section_dynsym): Likewise.
	* elf32-m32r.c (elf_backend_omit_section_dynsym): Likewise.
	* elf32-metag.c (elf_backend_omit_section_dynsym): Likewise.
	* elf32-score.c (elf_backend_omit_section_dynsym): Likewise.
	* elf32-score7.c (elf_backend_omit_section_dynsym): Likewise.
	* elf32-xstormy16.c (elf_backend_omit_section_dynsym): Likewise.
	* elf32-xtensa.c (elf_backend_omit_section_dynsym): Likewise.
	* elf64-alpha.c (elf_backend_omit_section_dynsym): Likewise.
	* elf64-hppa.c (elf_backend_omit_section_dynsym): Likewise.
	* elf64-ia64-vms.c (elf_backend_omit_section_dynsym): Likewise.
	* elf64-mmix.c (elf_backend_omit_section_dynsym): Likewise.
	* elf64-sh64.c (elf_backend_omit_section_dynsym): Likewise.
	* elfnn-ia64.c (elf_backend_omit_section_dynsym): Likewise.
	* elfxx-target.h (bfd_elfNN_bfd_debug_info_accumulate): Likewise.
	(bfd_elfNN_bfd_make_debug_symbol): Likewise.
	(bfd_elfNN_bfd_merge_private_bfd_data): Likewise.
	(bfd_elfNN_bfd_set_private_flags): Likewise.
	(bfd_elfNN_bfd_is_target_special_symbol): Likewise.
	(elf_backend_init_index_section): Likewise.
	(elf_backend_allow_non_load_phdr): Likewise.
	* elfxx-x86.h (elf_backend_omit_section_dynsym): Likewise.
	* i386msdos.c (msdos_bfd_is_target_special_symbol): Likewise.
	* ieee.c (ieee_construct_extended_name_table): Likewise.
	(ieee_write_armap): Likewise.
	(ieee_write_ar_hdr): Likewise.
	(ieee_bfd_is_target_special_symbol): Likewise.
	* ihex.c (ihex_canonicalize_symtab): Likewise.
	(ihex_bfd_is_target_special_symbol): Likewise.
	* libaout.h (aout_32_bfd_is_target_special_symbol): Likewise.
	* libecoff.h (_bfd_ecoff_bfd_is_target_special_symbol): Likewise.
	(_bfd_ecoff_set_alignment_hook): Likewise.
	* mach-o-target.c (bfd_mach_o_bfd_is_target_special_symbol): Likewise.
	* mmo.c (mmo_bfd_is_target_special_symbol): Likewise.
	* nlm-target.h (nlm_bfd_is_target_special_symbol): Likewise.
	* oasys.c (oasys_construct_extended_name_table): Likewise.
	(oasys_write_armap): Likewise.
	(oasys_write_ar_hdr): Likewise.
	(oasys_bfd_is_target_special_symbol): Likewise.
	* pef.c (bfd_pef_bfd_is_target_special_symbol): Likewise.
	* plugin.c (bfd_plugin_bfd_is_target_special_symbol): Likewise.
	* ppcboot.c (ppcboot_bfd_is_target_special_symbol): Likewise.
	* som.c (som_bfd_is_target_special_symbol): Likewise.
	* srec.c (srec_bfd_is_target_special_symbol): Likewise.
	* tekhex.c (tekhex_bfd_is_target_special_symbol): Likewise.
	* verilog.c (verilog_bfd_is_target_special_symbol): Likewise.
	* versados.c (versados_bfd_is_target_special_symbol): Likewise.
	(versados_bfd_reloc_name_lookup): Likewise.
	* vms-alpha.c (vms_bfd_is_target_special_symbol): Likewise.
	(vms_bfd_define_start_stop): Likewise.
	(alpha_vms_bfd_is_target_special_symbol): Likewise.
	* wasm-module.c (wasm_bfd_is_target_special_symbol): Likewise.
	* xsym.c (bfd_sym_bfd_is_target_special_symbol): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: Properly check building shared library
@ 2018-02-13 22:52 sergiodj+buildbot
  2018-02-14  3:48 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-13 22:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1031c264fd23641111df1e12a35d0a8f7e82fb80 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 1031c264fd23641111df1e12a35d0a8f7e82fb80

x86: Properly check building shared library

If a symbol is not defined in a regular file, and we are not generating
a shared library, then set the symbol to its location in the .plt.  This
is required to make function pointers compare as equal between the normal
executable and the shared library.

	* elfxx-x86.c (elf_x86_allocate_dynrelocs): Check bfd_link_dll,
	instead of bfd_link_pic, for building shared library.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Use enum flags for flags passed to openp
@ 2018-02-13 17:36 sergiodj+buildbot
  2018-02-14  2:10 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-13 17:36 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 24b9144d4ba83d37751786b08b48ad62fb7aef26 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 24b9144d4ba83d37751786b08b48ad62fb7aef26

Use enum flags for flags passed to openp

gdb/ChangeLog:

	* defs.h (enum openp_flags): New enum.
	(OPF_TRY_CWD_FIRST, OPF_SEARCH_IN_PATH, OPF_RETURN_REALPATH):
	Move to enum openp_flags.
	(openp_flags): New enum flags.
	(openp): Change parameter type to openp_flags.
	* source.c (openp): Change parameter type to openp_flags.
	* cli/cli-cmds.c (find_and_open_script): Use openp_flags.
	* dwarf2read.c (try_open_dwop_file): Use openp_flags.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86-64: Generate branch with PLT32 relocation
@ 2018-02-13 15:51 sergiodj+buildbot
  2018-02-14  0:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-13 15:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bd7ab16b4537788ad53521c45469a1bdae84ad4a ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: bd7ab16b4537788ad53521c45469a1bdae84ad4a

x86-64: Generate branch with PLT32 relocation

Since there is no need to prepare for PLT branch on x86-64, generate
R_X86_64_PLT32, instead of R_X86_64_PC32, if possible, which can be
used as a marker for 32-bit PC-relative branches.

To compile Linux kernel, this patch:

From: "H.J. Lu" <hjl.tools@gmail.com>
Subject: [PATCH] x86: Treat R_X86_64_PLT32 as R_X86_64_PC32

On i386, there are 2 types of PLTs, PIC and non-PIC.  PIE and shared
objects must use PIC PLT.  To use PIC PLT, you need to load
_GLOBAL_OFFSET_TABLE_ into EBX first.  There is no need for that on
x86-64 since x86-64 uses PC-relative PLT.

On x86-64, for 32-bit PC-relative branches, we can generate PLT32
relocation, instead of PC32 relocation, which can also be used as
a marker for 32-bit PC-relative branches.  Linker can always reduce
PLT32 relocation to PC32 if function is defined locally.   Local
functions should use PC32 relocation.  As far as Linux kernel is
concerned, R_X86_64_PLT32 can be treated the same as R_X86_64_PC32
since Linux kernel doesn't use PLT.

is needed.  It is available on hjl/plt32/master branch at

https://github.com/hjl-tools/linux

bfd/

	PR gas/22791
	* elf64-x86-64.c (is_32bit_relative_branch): Removed.
	(elf_x86_64_relocate_section): Check PIC relocations in PIE.
	Remove is_32bit_relative_branch usage.  Disallow PC32 reloc
	against protected function in shared object.

gas/

	PR gas/22791
	* config/tc-i386.c (need_plt32_p): New function.
	(output_jump): Generate BFD_RELOC_X86_64_PLT32 if possible.
	(md_estimate_size_before_relax): Likewise.
	* testsuite/gas/i386/reloc64.d: Updated.
	* testsuite/gas/i386/x86-64-jump.d: Likewise.
	* testsuite/gas/i386/x86-64-mpx-branch-1.d: Likewise.
	* testsuite/gas/i386/x86-64-mpx-branch-2.d: Likewise.
	* testsuite/gas/i386/x86-64-relax-2.d: Likewise.
	* testsuite/gas/i386/x86-64-relax-3.d: Likewise.
	* testsuite/gas/i386/ilp32/reloc64.d: Likewise.
	* testsuite/gas/i386/ilp32/x86-64-branch.d: Likewise.

ld/

	PR gas/22791
	* testsuite/ld-x86-64/mpx1c.rd: Updated.
	* testsuite/ld-x86-64/pr22791-1.err: New file.
	* testsuite/ld-x86-64/pr22791-1a.c: Likewise.
	* testsuite/ld-x86-64/pr22791-1b.s: Likewise.
	* testsuite/ld-x86-64/pr22791-2.rd: Likewise.
	* testsuite/ld-x86-64/pr22791-2a.s: Likewise.
	* testsuite/ld-x86-64/pr22791-2b.c: Likewise.
	* testsuite/ld-x86-64/pr22791-2c.s: Likewise.
	* testsuite/ld-x86-64/x86-64.exp: Run PR ld/22791 tests.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix compile time warning messages from gcc version 8 about cast between incompatible function types.
@ 2018-02-13 13:43 sergiodj+buildbot
  2018-02-13 20:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-13 13:43 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 68d206766637a041bbbeb89c8a1bfdd76317e192 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 68d206766637a041bbbeb89c8a1bfdd76317e192

Fix compile time warning messages from gcc version 8 about cast between incompatible function types.

	PR 22823
bfd	Fix compile time warnings generated by gcc version 8.
	* libbfd-in.h: Remove extraneous text from prototypes.
	Add prototypes for bfd_false_any, bfd_true_any,
	bfd_nullvoidptr_any, bfd_0_any, bfd_0u_any, bfd_0l_any,
	bfd_n1_any, bfd_void_any.
	(_bfd_generic_bfd_copy_private_bfd_data): Use vararg based dummy
	function.
	(_bfd_generic_bfd_merge_private_bfd_data): Likewise.
	(_bfd_generic_bfd_set_private_flags): Likewise.
	(_bfd_generic_bfd_copy_private_section_data): Likewise.
	(_bfd_generic_bfd_copy_private_symbol_data): Likewise.
	(_bfd_generic_bfd_copy_private_header_data): Likewise.
	(_bfd_generic_bfd_print_private_bfd_data): Likewise.
	(_bfd_noarchive_construct_extended_name_table): Likewise.
	(_bfd_noarchive_truncate_arname): Likewise.
	(_bfd_noarchive_write_ar_hdr): Likewise.
	(_bfd_noarchive_get_elt_at_index): Likewise.
	(_bfd_nosymbols_canonicalize_symtab): Likewise.
	(_bfd_nosymbols_print_symbol): Likewise.
	(_bfd_nosymbols_get_symbol_info): Likewise.
	(_bfd_nosymbols_get_symbol_version_string): Likewise.
	(_bfd_nosymbols_bfd_is_local_label_name): Likewise.
	(_bfd_nosymbols_bfd_is_target_special_symbol): Likewise.
	(_bfd_nosymbols_get_lineno): Likewise.
	(_bfd_nosymbols_find_nearest_line): Likewise.
	(_bfd_nosymbols_find_line): Likewise.
	(_bfd_nosymbols_find_inliner_info): Likewise.
	(_bfd_nosymbols_bfd_make_debug_symbol): Likewise.
	(_bfd_nosymbols_read_minisymbols): Likewise.
	(_bfd_nosymbols_minisymbol_to_symbol): Likewise.
	(_bfd_norelocs_bfd_reloc_type_lookup): Likewise.
	(_bfd_norelocs_bfd_reloc_name_lookup): Likewise.
	(_bfd_nowrite_set_arch_mach): Likewise.
	(_bfd_nowrite_set_section_contents): Likewise.
	(_bfd_nolink_sizeof_headers): Likewise.
	(_bfd_nolink_bfd_get_relocated_section_contents): Likewise.
	(_bfd_nolink_bfd_relax_section): Likewise.
	(_bfd_nolink_bfd_gc_sections): Likewise.
	(_bfd_nolink_bfd_lookup_section_flags): Likewise.
	(_bfd_nolink_bfd_merge_sections): Likewise.
	(_bfd_nolink_bfd_is_group_section): Likewise.
	(_bfd_nolink_bfd_discard_group): Likewise.
	(_bfd_nolink_bfd_link_hash_table_create): Likewise.
	(_bfd_nolink_bfd_link_add_symbols): Likewise.
	(_bfd_nolink_bfd_link_just_syms): Likewise.
	(_bfd_nolink_bfd_copy_link_hash_symbol_type): Likewise.
	(_bfd_nolink_bfd_final_link): Likewise.
	(_bfd_nolink_bfd_link_split_section): Likewise.
	(_bfd_nolink_section_already_linked): Likewise.
	(_bfd_nolink_bfd_define_common_symbol): Likewise.
	(_bfd_nolink_bfd_define_start_stop): Likewise.
	(_bfd_nodynamic_canonicalize_dynamic_symtab): Likewise.
	(_bfd_nodynamic_get_synthetic_symtab): Likewise.
	(_bfd_nodynamic_get_dynamic_reloc_upper_bound _bfd_): Likewise.
	(_bfd_nodynamic_canonicalize_dynamic_reloc): Likewise.
	* libbfd.c (bfd_false_any): New function.  Like bfd_false but
	accepts one or more arguments.
	(bfd_true_any): Likewise.
	(bfd_nullvoidptr_any): Likewise.
	(bfd_0_any): Likewise.
	(bfd_0u_any): Likewise.
	(bfd_0l_any): Likewise.
	(_bfd_n1_any): Likewise.
	(bfd_void_any): Likewise.
	* libbfd.h (extern): Regenerate
	* aout-target.h (MY_bfd_is_target_special_symbol): Use vararg
	based dummy function.
	* aout-tic30.c (tic30_aout_set_arch_mach): Likewise.
	* binary.c (binary_get_symbol_info): Likewise.
	* coff-alpha.c (alpha_ecoff_backend_data): Likewise.
	* coff-mips.c (mips_ecoff_backend_data): Likewise.
	* coffcode.h (coff_set_alignment_hook): Likewise.
	(symname_in_debug_hook): Likewise.
	(bfd_coff_backend_data bigobj_swap_table): Likewise.
	* elf-m10300.c (elf_backend_omit_section_dynsym): Likewise.
	* elf32-cr16.c (elf_backend_omit_section_dynsym): Likewise.
	* elf32-lm32.c (elf_backend_omit_section_dynsym): Likewise.
	* elf32-m32r.c (elf_backend_omit_section_dynsym): Likewise.
	* elf32-metag.c (elf_backend_omit_section_dynsym): Likewise.
	* elf32-score.c (elf_backend_omit_section_dynsym): Likewise.
	* elf32-score7.c (elf_backend_omit_section_dynsym): Likewise.
	* elf32-xstormy16.c (elf_backend_omit_section_dynsym): Likewise.
	* elf32-xtensa.c (elf_backend_omit_section_dynsym): Likewise.
	* elf64-alpha.c (elf_backend_omit_section_dynsym): Likewise.
	* elf64-hppa.c (elf_backend_omit_section_dynsym): Likewise.
	* elf64-ia64-vms.c (elf_backend_omit_section_dynsym): Likewise.
	* elf64-mmix.c (elf_backend_omit_section_dynsym): Likewise.
	* elf64-sh64.c (elf_backend_omit_section_dynsym): Likewise.
	* elfnn-ia64.c (elf_backend_omit_section_dynsym): Likewise.
	* elfxx-target.h (bfd_elfNN_bfd_debug_info_accumulate): Likewise.
	(bfd_elfNN_bfd_make_debug_symbol): Likewise.
	(bfd_elfNN_bfd_merge_private_bfd_data): Likewise.
	(bfd_elfNN_bfd_set_private_flags): Likewise.
	(bfd_elfNN_bfd_is_target_special_symbol): Likewise.
	(elf_backend_init_index_section): Likewise.
	(elf_backend_allow_non_load_phdr): Likewise.
	* elfxx-x86.h (elf_backend_omit_section_dynsym): Likewise.
	* i386msdos.c (msdos_bfd_is_target_special_symbol): Likewise.
	* ieee.c (ieee_construct_extended_name_table): Likewise.
	(ieee_write_armap): Likewise.
	(ieee_write_ar_hdr): Likewise.
	(ieee_bfd_is_target_special_symbol): Likewise.
	* ihex.c (ihex_canonicalize_symtab): Likewise.
	(ihex_bfd_is_target_special_symbol): Likewise.
	* libaout.h (aout_32_bfd_is_target_special_symbol): Likewise.
	* libecoff.h (_bfd_ecoff_bfd_is_target_special_symbol): Likewise.
	(_bfd_ecoff_set_alignment_hook): Likewise.
	* mach-o-target.c (bfd_mach_o_bfd_is_target_special_symbol): Likewise.
	* mmo.c (mmo_bfd_is_target_special_symbol): Likewise.
	* nlm-target.h (nlm_bfd_is_target_special_symbol): Likewise.
	* oasys.c (oasys_construct_extended_name_table): Likewise.
	(oasys_write_armap): Likewise.
	(oasys_write_ar_hdr): Likewise.
	(oasys_bfd_is_target_special_symbol): Likewise.
	* pef.c (bfd_pef_bfd_is_target_special_symbol): Likewise.
	* plugin.c (bfd_plugin_bfd_is_target_special_symbol): Likewise.
	* ppcboot.c (ppcboot_bfd_is_target_special_symbol): Likewise.
	* som.c (som_bfd_is_target_special_symbol): Likewise.
	* srec.c (srec_bfd_is_target_special_symbol): Likewise.
	* tekhex.c (tekhex_bfd_is_target_special_symbol): Likewise.
	* verilog.c (verilog_bfd_is_target_special_symbol): Likewise.
	* versados.c (versados_bfd_is_target_special_symbol): Likewise.
	(versados_bfd_reloc_name_lookup): Likewise.
	* vms-alpha.c (vms_bfd_is_target_special_symbol): Likewise.
	(vms_bfd_define_start_stop): Likewise.
	(alpha_vms_bfd_is_target_special_symbol): Likewise.
	* wasm-module.c (wasm_bfd_is_target_special_symbol): Likewise.
	* xsym.c (bfd_sym_bfd_is_target_special_symbol): Likewise.
	* elf32-arc.c (get_replace_function): Assign replacement function
	to func pointer.
	* elf32-i370.c (i370_noop): Update prototype.

gas	* config/obj-elf.c (elf_pseudo_table): Remove now redundant
	casts.
	(obj_elf_vtable_inherit): Rename to obj_elf_get_vtable_inherit.
	(obj_elf_vtable_inherit): New stub function that calls
	obj_elf_get_vtable_inherit.
	(obj_elf_vtable_entry): Rename to obj_elf_get_vtable_entry.
	(obj_elf_vtable_entry): New stub function that calls
	obj_elf_get_vtable_entry.
	* config/obj-elf.h (obj_elf_vtable_inherit): Update prototype.
	(obj_elf_vtable_entry) Likewise.
	(obj_elf_get_vtable_inherit) Likewise.
	(obj_elf_get_vtable_entry) Likewise.
	* config/tc-arm.c (md_pseudo_table): Remove now redundant cast.
	* config/tc-i386c (md_pseudo_table): Likewise.
	* config/tc-hppa.c (pa_vtable_entry): Call
	obj_elf_get_vtable_entry.
	(pa_vtable_inherit): Call obj_elf_get_vtable_inherit.
	* config/tc-mips.c (s_mips_file): Replace call to dwarf2_get_file
	with call to dwarf2_get_filename.
	* dwarf2dbg.c (dwarf2_directive_file): Rename to
	dwarf2_directive_filename.
	(dwarf2_directive_file): New stub function that calls
	dwarf2_directive_filename.
	* dwarf2dbg.h: Prototype dwarf2_directive_filename.

opcodes	* metag-dis.c (print_fmmov): Double buffer size to avoid warning
	about truncation of printing.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] WebAssembly: Disable subdirectory configuration for unsupported LD
@ 2018-02-13 13:31 sergiodj+buildbot
  2018-02-13 19:13 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-13 13:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b29d26411c62fef6b1401aff4f2c6a157053de4d ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: b29d26411c62fef6b1401aff4f2c6a157053de4d

WebAssembly: Disable subdirectory configuration for unsupported LD

Remove an LD subdirectory configuration error:

*** ld does not support target wasm32-unknown-none
*** see ld/configure.tgt for supported targets
make[1]: *** [configure-ld] Error 1

which prevents binutils for the WebAssembly target from being built
unless an explicit `--disable-ld' configuration option has been given.
Users must not have to disable features selected by default to get a
working configuration.

	/
	* configure.ac <wasm32-*-*> (noconfigdirs): Add `ld'.
	* configure: Regenerate.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] WebAssembly: Correct an `index' global shadowing error for pre-4.8 GCC
@ 2018-02-13 13:28 sergiodj+buildbot
  2018-02-13 16:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-13 13:28 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 87993319a56af838d3ab7e251fa4902476ca63c8 ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 87993319a56af838d3ab7e251fa4902476ca63c8

WebAssembly: Correct an `index' global shadowing error for pre-4.8 GCC

Remove `-Wshadow' compilation errors:

cc1: warnings being treated as errors
.../bfd/wasm-module.c: In function 'wasm_scan_name_function_section':
.../bfd/wasm-module.c:312: error: declaration of 'index' shadows a global declaration
/usr/include/string.h:303: error: shadowed declaration is here
.../bfd/wasm-module.c: In function 'wasm_register_section':
.../bfd/wasm-module.c:494: error: declaration of 'index' shadows a global declaration
/usr/include/string.h:303: error: shadowed declaration is here
.../bfd/wasm-module.c: In function 'wasm_compute_custom_section_file_position':
.../bfd/wasm-module.c:523: error: declaration of 'index' shadows a global declaration
/usr/include/string.h:303: error: shadowed declaration is here

and:

cc1: warnings being treated as errors
.../opcodes/wasm32-dis.c: In function 'print_insn_wasm32':
.../opcodes/wasm32-dis.c:272: error: declaration of 'index' shadows a global declaration
/usr/include/string.h:303: error: shadowed declaration is here
make[4]: *** [wasm32-dis.lo] Error 1

which for versions of GCC before 4.8 prevent support for the WebAssembly
target from being built.  See also GCC PR c/53066.

	bfd/
	* wasm-module.c (wasm_scan_name_function_section): Rename
	`index' local variable to `idx'.

	opcodes/
	* wasm32-dis.c (print_insn_wasm32): Rename `index' local
	variable to `function_index'.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix prefix of maint set/show per-command
@ 2018-02-13  6:47 sergiodj+buildbot
  2018-02-13  7:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-13  6:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 387cd15b93fdca3a66bbda427c4e1d9340bfb532 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 387cd15b93fdca3a66bbda427c4e1d9340bfb532

Fix prefix of maint set/show per-command

I noticed this:

(gdb) apropos per-command
maintenance set per-command -- Per-command statistics settings
set per-command space -- Set whether to display per-command space usage
set per-command symtab -- Set whether to display per-command symtab statistics
set per-command time -- Set whether to display per-command execution time
maintenance show per-command -- Show per-command statistics settings
show per-command space -- Show whether to display per-command space usage
show per-command symtab -- Show whether to display per-command symtab statistics
show per-command time -- Show whether to display per-command execution time

The subcommands of "maintenance set per-command" are missing the
maintenance keyword.  This is because that command is registered with
the wrong prefix.  This patch fixes that.

gdb/ChangeLog:

	* maint.c (_initialize_maint_cmds): Fix prefix of maint set/show
	per-command.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdb: Remove cleanup from dw2_do_instantiate_symtab
@ 2018-02-13  0:11 sergiodj+buildbot
  2018-02-13  2:18 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-13  0:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b303c6f688c6cd1ffd986ae65ac3f2dc11f27b93 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: b303c6f688c6cd1ffd986ae65ac3f2dc11f27b93

gdb: Remove cleanup from dw2_do_instantiate_symtab

When running the test gdb.dwarf2/dw2-bad-parameter-type.exp under
valgrind, I see the following issue reported (on x86-64 Fedora):

  (gdb) ptype f
  ==5203== Invalid read of size 1
  ==5203==    at 0x6931FE: process_die_scope::~process_die_scope() (dwarf2read.c:10642)
  ==5203==    by 0x66818F: process_die(die_info*, dwarf2_cu*) (dwarf2read.c:10664)
  ==5203==    by 0x66A01F: read_file_scope(die_info*, dwarf2_cu*) (dwarf2read.c:11650)
  ==5203==    by 0x667F2D: process_die(die_info*, dwarf2_cu*) (dwarf2read.c:10672)
  ==5203==    by 0x6677B6: process_full_comp_unit(dwarf2_per_cu_data*, language) (dwarf2read.c:10445)
  ==5203==    by 0x66657A: process_queue(dwarf2_per_objfile*) (dwarf2read.c:9945)
  ==5203==    by 0x6559B4: dw2_do_instantiate_symtab(dwarf2_per_cu_data*) (dwarf2read.c:3163)
  ==5203==    by 0x66683D: psymtab_to_symtab_1(partial_symtab*) (dwarf2read.c:10034)
  ==5203==    by 0x66622A: dwarf2_read_symtab(partial_symtab*, objfile*) (dwarf2read.c:9811)
  ==5203==    by 0x787984: psymtab_to_symtab(objfile*, partial_symtab*) (psymtab.c:792)
  ==5203==    by 0x786E3E: psym_lookup_symbol(objfile*, int, char const*, domain_enum_tag) (psymtab.c:522)
  ==5203==    by 0x804BD0: lookup_symbol_via_quick_fns(objfile*, int, char const*, domain_enum_tag) (symtab.c:2383)
  ==5203==  Address 0x147ed063 is 291 bytes inside a block of size 4,064 free'd
  ==5203==    at 0x4C2CD5A: free (vg_replace_malloc.c:530)
  ==5203==    by 0x444415: void xfree<void>(void*) (common-utils.h:60)
  ==5203==    by 0x9DA8C2: call_freefun (obstack.c:103)
  ==5203==    by 0x9DAD35: _obstack_free (obstack.c:280)
  ==5203==    by 0x44464C: auto_obstack::~auto_obstack() (gdb_obstack.h:73)
  ==5203==    by 0x68AFB0: dwarf2_cu::~dwarf2_cu() (dwarf2read.c:25080)
  ==5203==    by 0x68B204: free_one_cached_comp_unit(dwarf2_per_cu_data*) (dwarf2read.c:25174)
  ==5203==    by 0x66668C: dwarf2_release_queue(void*) (dwarf2read.c:9982)
  ==5203==    by 0x563A4C: do_my_cleanups(cleanup**, cleanup*) (cleanups.c:154)
  ==5203==    by 0x563AA7: do_cleanups(cleanup*) (cleanups.c:176)
  ==5203==    by 0x5646CE: throw_exception_cxx(gdb_exception) (common-exceptions.c:289)
  ==5203==    by 0x5647B7: throw_exception(gdb_exception) (common-exceptions.c:317)
  ==5203==  Block was alloc'd at
  ==5203==    at 0x4C2BBAD: malloc (vg_replace_malloc.c:299)
  ==5203==    by 0x564BE8: xmalloc (common-utils.c:44)
  ==5203==    by 0x9DA872: call_chunkfun (obstack.c:94)
  ==5203==    by 0x9DA935: _obstack_begin_worker (obstack.c:141)
  ==5203==    by 0x9DAA3C: _obstack_begin (obstack.c:164)
  ==5203==    by 0x4445E0: auto_obstack::auto_obstack() (gdb_obstack.h:70)
  ==5203==    by 0x68AE07: dwarf2_cu::dwarf2_cu(dwarf2_per_cu_data*) (dwarf2read.c:25073)
  ==5203==    by 0x661A8A: init_cutu_and_read_dies(dwarf2_per_cu_data*, abbrev_table*, int, int, void (*)(die_reader_specs const*, unsigned char const*, die_info*, int, void*), void*) (dwarf2read.c:7869)
  ==5203==    by 0x666A29: load_full_comp_unit(dwarf2_per_cu_data*, language) (dwarf2read.c:10108)
  ==5203==    by 0x655847: load_cu(dwarf2_per_cu_data*) (dwarf2read.c:3120)
  ==5203==    by 0x655928: dw2_do_instantiate_symtab(dwarf2_per_cu_data*) (dwarf2read.c:3148)
  ==5203==    by 0x66683D: psymtab_to_symtab_1(partial_symtab*) (dwarf2read.c:10034)

There's actually a series of three issues reported, but it turns out
they're all related, so we can consider on the first one.

The invalid read is triggered from a destructor which is being invoked
as part of a stack unwind after throwing an error.  At the time the
error is thrown, the stack looks like this:

    #0  0x00000000009f4ecd in __cxa_throw ()
    #1  0x0000000000564761 in throw_exception_cxx (exception=...) at ../../src/gdb/common/common-exceptions.c:303
    #2  0x00000000005647b8 in throw_exception (exception=...) at ../../src/gdb/common/common-exceptions.c:317
    #3  0x00000000005648ff in throw_it(return_reason, errors, const char *, typedef __va_list_tag __va_list_tag *) (reason=RETURN_ERROR,
        error=GENERIC_ERROR, fmt=0xb33020 "Dwarf Error: Cannot find DIE at 0x%x referenced from DIE at 0x%x [in module %s]",
        ap=0x7fff387f2d68) at ../../src/gdb/common/common-exceptions.c:373
    #4  0x0000000000564929 in throw_verror (error=GENERIC_ERROR,
        fmt=0xb33020 "Dwarf Error: Cannot find DIE at 0x%x referenced from DIE at 0x%x [in module %s]", ap=0x7fff387f2d68)
        at ../../src/gdb/common/common-exceptions.c:379
    #5  0x0000000000867be4 in verror (string=0xb33020 "Dwarf Error: Cannot find DIE at 0x%x referenced from DIE at 0x%x [in module %s]",
        args=0x7fff387f2d68) at ../../src/gdb/utils.c:251
    #6  0x000000000056879d in error (fmt=0xb33020 "Dwarf Error: Cannot find DIE at 0x%x referenced from DIE at 0x%x [in module %s]")
        at ../../src/gdb/common/errors.c:43
    #7  0x0000000000686875 in follow_die_ref (src_die=0x30bc8a0, attr=0x30bc8c8, ref_cu=0x7fff387f2ed0) at ../../src/gdb/dwarf2read.c:22969
    #8  0x00000000006844cd in lookup_die_type (die=0x30bc8a0, attr=0x30bc8c8, cu=0x30bc5d0) at ../../src/gdb/dwarf2read.c:21976
    #9  0x0000000000683f27 in die_type (die=0x30bc8a0, cu=0x30bc5d0) at ../../src/gdb/dwarf2read.c:21832
    #10 0x0000000000679b39 in read_subroutine_type (die=0x30bc830, cu=0x30bc5d0) at ../../src/gdb/dwarf2read.c:17343
    #11 0x00000000006845fb in read_type_die_1 (die=0x30bc830, cu=0x30bc5d0) at ../../src/gdb/dwarf2read.c:22035
    #12 0x0000000000684576 in read_type_die (die=0x30bc830, cu=0x30bc5d0) at ../../src/gdb/dwarf2read.c:22010
    #13 0x000000000067003f in read_func_scope (die=0x30bc830, cu=0x30bc5d0) at ../../src/gdb/dwarf2read.c:13822
    #14 0x0000000000667f5e in process_die (die=0x30bc830, cu=0x30bc5d0) at ../../src/gdb/dwarf2read.c:10679
    #15 0x000000000066a020 in read_file_scope (die=0x30bc720, cu=0x30bc5d0) at ../../src/gdb/dwarf2read.c:11650
    #16 0x0000000000667f2e in process_die (die=0x30bc720, cu=0x30bc5d0) at ../../src/gdb/dwarf2read.c:10672
    #17 0x00000000006677b7 in process_full_comp_unit (per_cu=0x3089b80, pretend_language=language_minimal)
        at ../../src/gdb/dwarf2read.c:10445
    #18 0x000000000066657b in process_queue (dwarf2_per_objfile=0x30897d0) at ../../src/gdb/dwarf2read.c:9945
    #19 0x00000000006559b5 in dw2_do_instantiate_symtab (per_cu=0x3089b80) at ../../src/gdb/dwarf2read.c:3163
    #20 0x000000000066683e in psymtab_to_symtab_1 (pst=0x3089bd0) at ../../src/gdb/dwarf2read.c:10034
    #21 0x000000000066622b in dwarf2_read_symtab (self=0x3089bd0, objfile=0x3073f40) at ../../src/gdb/dwarf2read.c:9811
    #22 0x0000000000787985 in psymtab_to_symtab (objfile=0x3073f40, pst=0x3089bd0) at ../../src/gdb/psymtab.c:792
    #23 0x0000000000786e3f in psym_lookup_symbol (objfile=0x3073f40, block_index=1, name=0x30b2e30 "f", domain=VAR_DOMAIN)
        at ../../src/gdb/psymtab.c:522
    #24 0x0000000000804bd1 in lookup_symbol_via_quick_fns (objfile=0x3073f40, block_index=1, name=0x30b2e30 "f", domain=VAR_DOMAIN)
        at ../../src/gdb/symtab.c:2383
    #25 0x0000000000804fe4 in lookup_symbol_in_objfile (objfile=0x3073f40, block_index=1, name=0x30b2e30 "f", domain=VAR_DOMAIN)
        at ../../src/gdb/symtab.c:2558
    #26 0x0000000000805125 in lookup_static_symbol (name=0x30b2e30 "f", domain=VAR_DOMAIN) at ../../src/gdb/symtab.c:2595
    #27 0x0000000000804357 in lookup_symbol_aux (name=0x30b2e30 "f", match_type=symbol_name_match_type::FULL, block=0x0,
        domain=VAR_DOMAIN, language=language_c, is_a_field_of_this=0x0) at ../../src/gdb/symtab.c:2105
    #28 0x0000000000803ad9 in lookup_symbol_in_language (name=0x30b2e30 "f", block=0x0, domain=VAR_DOMAIN, lang=language_c,
        is_a_field_of_this=0x0) at ../../src/gdb/symtab.c:1887
    #29 0x0000000000803b53 in lookup_symbol (name=0x30b2e30 "f", block=0x0, domain=VAR_DOMAIN, is_a_field_of_this=0x0)
        at ../../src/gdb/symtab.c:1899
    #30 0x000000000053b246 in classify_name (par_state=0x7fff387f6090, block=0x0, is_quoted_name=false, is_after_structop=false)
        at ../../src/gdb/c-exp.y:2879
    #31 0x000000000053b7e9 in c_yylex () at ../../src/gdb/c-exp.y:3083
    #32 0x000000000053414a in c_yyparse () at c-exp.c:1903
    #33 0x000000000053c2e7 in c_parse (par_state=0x7fff387f6090) at ../../src/gdb/c-exp.y:3255
    #34 0x0000000000774a02 in parse_exp_in_context_1 (stringptr=0x7fff387f61c0, pc=0, block=0x0, comma=0, void_context_p=0, out_subexp=0x0)
        at ../../src/gdb/parse.c:1213
    #35 0x000000000077476a in parse_exp_in_context (stringptr=0x7fff387f61c0, pc=0, block=0x0, comma=0, void_context_p=0, out_subexp=0x0)
        at ../../src/gdb/parse.c:1115
    #36 0x0000000000774714 in parse_exp_1 (stringptr=0x7fff387f61c0, pc=0, block=0x0, comma=0) at ../../src/gdb/parse.c:1106
    #37 0x0000000000774c53 in parse_expression (string=0x27ff996 "f") at ../../src/gdb/parse.c:1253
    #38 0x0000000000861dc4 in whatis_exp (exp=0x27ff996 "f", show=1) at ../../src/gdb/typeprint.c:472
    #39 0x00000000008620d8 in ptype_command (type_name=0x27ff996 "f", from_tty=1) at ../../src/gdb/typeprint.c:561
    #40 0x000000000047430b in do_const_cfunc (c=0x3012010, args=0x27ff996 "f", from_tty=1) at ../../src/gdb/cli/cli-decode.c:106
    #41 0x000000000047715e in cmd_func (cmd=0x3012010, args=0x27ff996 "f", from_tty=1) at ../../src/gdb/cli/cli-decode.c:1886
    #42 0x00000000008431bb in execute_command (p=0x27ff996 "f", from_tty=1) at ../../src/gdb/top.c:630
    #43 0x00000000006bf946 in command_handler (command=0x27ff990 "ptype f") at ../../src/gdb/event-top.c:583
    #44 0x00000000006bfd12 in command_line_handler (rl=0x30bb3a0 "\240\305\v\003") at ../../src/gdb/event-top.c:774

The problem is that in `process_die` (frames 14 and 16) we create a
`process_die_scope` object, that takes a copy of the `struct
dwarf2_cu *` passed into the frame.  The destructor of the
`process_die_scope` dereferences the stored pointer.  This wouldn't be
an issue, except...

... in dw2_do_instantiate_symtab (frame 19) a clean up was registered that
clears the dwarf2_queue in case of an error.  Part of this clean up
involves deleting the `struct dwarf2_cu`s referenced from the queue..

The problem then, is that cleanups are processed at the site of the
throw, while, class destructors are invoked as we unwind their frame.
The result is that we process the frame 19 cleanup (and delete the
struct dwarf2_cu) before we process the destructors in frames 14 and 16.
When we do get back to frames 14 and 16 the objects being references
have already been deleted.

The solution is to remove the cleanup from dw2_do_instantiate_symtab, and
instead use a destructor to release the dwarf2_queue instead.  With this
patch in place, the valgrind errors are now resolved.

gdb/ChangeLog:

	* dwarf2read.c (dwarf2_release_queue): Delete function, move body
	into...
	(class dwarf2_queue_guard): ...the destructor of this new class.
	(dw2_do_instantiate_symtab): Create instance of the new class
	dwarf2_queue_guard, remove cleanup.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] MIPS: Fix encoding for MIPSr6 sigrie instruction.
@ 2018-02-12 15:14 sergiodj+buildbot
  2018-02-12 22:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-12 15:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d2159fdc0f0ac1d0aaafab725b930e78a8793494 ***

Author: Henry Wong <henry@stuffedcow.net>
Branch: master
Commit: d2159fdc0f0ac1d0aaafab725b930e78a8793494

MIPS: Fix encoding for MIPSr6 sigrie instruction.

The instruction encoding for the MIPS r6 sigrie instruction seems to be
incorrect.  It's currently 0x4170xxxx (which overlaps with ei, di, evp,
and dvp), but should be 0x0417xxxx.  See ISA reference[1][2].

References:

[1] "MIPS Architecture for Programmers Volume II-A: The MIPS32
    Instruction Set Manual", Imagination Technologies, Inc., Document
    Number: MD00086, Revision 6.06, December 15, 2016, Table A.4 "MIPS32
    REGIMM Encoding of rt Field", p. 452

[2] "MIPS Architecture For Programmers Volume II-A: The MIPS64
    Instruction Set Reference Manual", Imagination Technologies, Inc.,
    Document Number: MD00087, Revision 6.06, December 15, 2016, Table
    A.4 "MIPS64 REGIMM Encoding of rt Field", p. 581

	opcodes/
	* mips-opc.c (mips_builtin_opcodes): Correct "sigrie" encoding.

	gas/
	* testsuite/gas/mips/r6.d: Update for "sigrie" encoding fix.
	* testsuite/gas/mips/r6-n32.d: Likewise.
	* testsuite/gas/mips/r6-n64.d: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add support for reading msdos MZ executables.
@ 2018-02-12 13:36 sergiodj+buildbot
  2018-02-12 19:59 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-12 13:36 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 830db0485e19000985ccfdbacda4d4d5d62583bb ***

Author: Zebediah Figura <z.figura12@gmail.com>
Branch: master
Commit: 830db0485e19000985ccfdbacda4d4d5d62583bb

Add support for reading msdos MZ executables.

See email thread starting here:  https://www.sourceware.org/ml/binutils/2018-01/msg00001.html

include	* coff/msdos.h: New header.
	* coff/pe.h: Move common defines to msdos.h.
	* coff/powerpc.h: Likewise.

bfd	* i386msdos.c (msdos_mkobject); New function.
	(msdos_object_p): New function.
	(i386_msdos_vec): Use msdos_object_p as the check_format
	function.
	* peicode.h: Rename external_PEI_DOS_hdr, DOSMAGIC, and
	NT_SIGNATURE to external_DOS_hdr, IMAGE_DOS_SIGNATURE, and
	IMAGE_NT_SIGNATURE.
	* peXXigen.c: Likewise.
	* coff-ia64.c: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] oops - actually remove the assignment this time: bfd/elf32-nds32.c:9693]: (warning) Redundant assignment of 'irel->r_addend' to itself.
@ 2018-02-12 12:16 sergiodj+buildbot
  2018-02-12 15:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-12 12:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6444b19b244d7c84537fc796005ef756917135ae ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 6444b19b244d7c84537fc796005ef756917135ae

oops - actually remove the assignment this time: bfd/elf32-nds32.c:9693]: (warning) Redundant assignment of 'irel->r_addend' to itself.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Don't reference past the end of the vector
@ 2018-02-09 19:26 sergiodj+buildbot
  2018-02-11  2:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-09 19:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9c3630e983df43e68006b526a92c2a9a2b64dfd9 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 9c3630e983df43e68006b526a92c2a9a2b64dfd9

Don't reference past the end of the vector

An earlier change made find_source_lines read:

    end = &data[size];

However, since 'size' is the size of the vector, this seems fishy.
More obviously ok is to compute the end of the data directly:

    end = data.data () + size;

2018-02-09  Tom Tromey  <tom@tromey.com>

	* source.c (find_source_lines): Don't reference past the end of
	the vector.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: Add is_solaris to elf_x86_target_os
@ 2018-02-09 17:02 sergiodj+buildbot
  2018-02-11  4:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-09 17:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3b4c384407ebbdd9ed4ad5057080b3be038b8748 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 3b4c384407ebbdd9ed4ad5057080b3be038b8748

x86: Add is_solaris to elf_x86_target_os

Add is_solaris to elf_x86_target_os since Solaris is quite different.

	* elf32-i386.c (elf_i386_get_synthetic_symtab): Also handle
	is_solaris.
	(i386_elf32_sol2_vec): Don't declare.
	(elf_i386_link_setup_gnu_properties): Also handle is_solaris.
	Don't set need_global_offset_table.
	(elf_i386_solaris_arch_bed): New.
	(elf_backend_arch_data): Set to elf_i386_solaris_arch_bed for
	Solaris.
	* elf64-x86-64.c (elf_x86_64_get_synthetic_symtab): Check
	target_os != is_nacl instead of target_os == is_normal.
	(x86_64_elf64_sol2_vec): Don't declare.
	(elf_x86_64_link_setup_gnu_properties): Check target_os !=
	is_nacl instead of target_os == is_normal.  Don't set
	need_global_offset_table.
	(elf_x86_64_solaris_arch_bed): New.
	(elf_backend_arch_data): Set to elf_x86_64_solaris_arch_bed for
	Solaris.
	* elfxx-x86.c (_bfd_x86_elf_size_dynamic_sections): Keep
	_GLOBAL_OFFSET_TABLE_ for Solaris.
	(_bfd_x86_elf_link_setup_gnu_properties): Don't copy
	need_global_offset_table.
	* elfxx-x86.h (elf_x86_target_os): Add is_solaris.
	(elf_x86_link_hash_table): Remove need_global_offset_table.
	(elf_x86_init_table): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] btrace: reword error messages
@ 2018-02-09 15:25 sergiodj+buildbot
  2018-02-10 23:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-09 15:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c4e126313219ecde255a644a2c74008831edff5a ***

Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: c4e126313219ecde255a644a2c74008831edff5a

btrace: reword error messages

Reword some btrace error messages to align with the format discussed in
https://sourceware.org/ml/gdb-patches/2018-02/msg00135.html.

gdb/
	* remote.c (remote_btrace_maybe_reopen): Change error message.
	* btrace.c (btrace_enable): Likewise.
	(parse_xml_btrace): Likewise.
	(parse_xml_btrace_conf): Likewise.

testsuite/
	* lib/gdb.exp (skip_btrace_pt_tests): Update expected error message.
	Fix test name.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] btrace: check perf_event_paranoid
@ 2018-02-09 15:12 sergiodj+buildbot
  2018-02-10 21:49 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-09 15:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 88711fbfeadd6e4663d986962dfcd7ab660c61d1 ***

Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: 88711fbfeadd6e4663d986962dfcd7ab660c61d1

btrace: check perf_event_paranoid

One recurring error on Debian systems is that the default perf_event_paranoid
setting disables the perf_event interface for user-space.

Check the current level and point the user to the file.

gdb/
	* nat/linux-btrace.c (diagnose_perf_event_open_fail): New.
	(linux_enable_pt, linux_enable_bts): Call
	diagnose_perf_event_open_fail.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] btrace: improve enable error messages
@ 2018-02-09 15:00 sergiodj+buildbot
  2018-02-10 19:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-09 15:00 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 17ad2a4f466f22b7a75b5ebf8a68446bb328c40c ***

Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: 17ad2a4f466f22b7a75b5ebf8a68446bb328c40c

btrace: improve enable error messages

Improve the error message when GDB fails to start recording branch trace.

This patch also removes a zero buffer size check for PT to align with BTS.  The
buffer size can not be configured to be zero.

gdb/
	* nat/linux-btrace.c (perf_event_pt_event_type): Improve error message.
	Remove parameter and change return type.  Update callers.  Move it.
	(linux_enable_bts, linux_enable_pt): Improve error message.
	(linux_enable_pt): Remove zero buffer size check.
	(linux_enable_btrace): Improve error messages.  Remove NULL return
	check.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] btrace: prepare for throwing exceptions when enabling btrace
@ 2018-02-09 14:22 sergiodj+buildbot
  2018-02-10 11:59 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-09 14:22 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5c3284c1ec2edc28b0697532fd094d93d5ecf31b ***

Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: 5c3284c1ec2edc28b0697532fd094d93d5ecf31b

btrace: prepare for throwing exceptions when enabling btrace

We indicate success or failure for enabling branch tracing via the pointer
return value.  Depending on the type of error, errno may provide additional
information.

Prepare for using exceptions with more descriptive error messages by using smart
pointers and objects with automatic destruction to hold intermediate results.

gdb/
	* nat/linux-btrace.c: Include scoped_fd.h and scoped_mmap.h.
	(perf_event_pt_event_type): Use gdb_file_up.
	(linux_enable_bts, linux_enable_pt): Use gdb::unique_xmalloc_ptr,
	scoped_fd, and scoped_mmap.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdb/NEWS: Clarify the news entry for "rbreak" in GDB 8.1
@ 2018-02-09 12:24 sergiodj+buildbot
  2018-02-09 20:49 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-09 12:24 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4e7253479941cd6d59a0c8efbb1113d3734b7f56 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 4e7253479941cd6d59a0c8efbb1113d3734b7f56

gdb/NEWS: Clarify the news entry for "rbreak" in GDB 8.1

gdb/ChangeLog:

        * NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
        Python function, rather than a new command.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove cleanups from solib.c
@ 2018-02-08 23:17 sergiodj+buildbot
  2018-02-09 12:58 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-08 23:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9a897d43f034544cd09292d0fb6fded7eb64ae8d ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 9a897d43f034544cd09292d0fb6fded7eb64ae8d

Remove cleanups from solib.c

This removes a couple of cleanups from solib.c, replacing one with
std::string and another with unique_xmalloc_ptr.

2018-02-08  Tom Tromey  <tom@tromey.com>

	* solib.c (solib_find_1): Use std::string.
	(solib_bfd_fopen): Use unique_xmalloc_ptr.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Use std::string in maybe_expand
@ 2018-02-08 22:04 sergiodj+buildbot
  2018-02-09  5:14 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-08 22:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0354904bdacb9bf1ebdf3ebdf3723f8a550bcdab ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 0354904bdacb9bf1ebdf3ebdf3723f8a550bcdab

Use std::string in maybe_expand

This patch changes maybe_expand to use std::string rather than an
explicit malloc and a cleanup.

2018-02-08  Tom Tromey  <tom@tromey.com>

	* macroexp.c (maybe_expand): Use std::string.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Class-ify macro_buffer
@ 2018-02-08 20:47 sergiodj+buildbot
  2018-02-09  3:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-08 20:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1739cf248ff21b21271d1e9d5f77a12589c3856c ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 1739cf248ff21b21271d1e9d5f77a12589c3856c

Class-ify macro_buffer

This patch changes macro_buffer to be a bit more of a C++ class,
adding constructors, a destructor, and some members.  Then this is
used to remove various cleanups in macroexp.c.

2018-02-08  Tom Tromey  <tom@tromey.com>

	* macroexp.c (struct macro_buffer): Add initializers for some
	members.
	(init_buffer, init_shared_buffer, free_buffer)
	(free_buffer_return_text): Remove.
	(macro_buffer): New constructors.
	(~macro_buffer): New destructor.
	(macro_buffer::set_shared): New method.
	(macro_buffer::resize_buffer, macro_buffer::appendc)
	(macro_buffer::appendmem): Now methods, not free functions.
	(set_token, append_tokens_without_splicing, stringify)
	(macro_stringify): Update.
	(gather_arguments): Change return type.  Remove argc_p argument,
	add args_ptr argument.  Use std::vector.
	(substitute_args): Remove argc argument.  Accept std::vector.
	(expand): Update.  Use std::vector.
	(scan, macro_expand, macro_expand_next): Update.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove cleanups from macro_define_command
@ 2018-02-08 20:13 sergiodj+buildbot
  2018-02-09  6:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-08 20:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 84f27c6fcbbf580434c7d56e68fa42fe7cf7ccb9 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 84f27c6fcbbf580434c7d56e68fa42fe7cf7ccb9

Remove cleanups from macro_define_command

This removes cleanups from macro_define_command, by introducing a new
struct temporary_macro_definition that cleans up after itself.

2018-02-08  Tom Tromey  <tom@tromey.com>

	* macrocmd.c (struct temporary_macro_definition): New.
	(macro_define_command): Use temporary_macro_definition.  Remove
	cleanups.
	(free_macro_definition_ptr): Remove.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Return unique_xmalloc_ptr from macro scope functions
@ 2018-02-08 19:32 sergiodj+buildbot
  2018-02-09  1:24 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-08 19:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f6c2623eb8ac7296b6d7a76657394272a71f5aee ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: f6c2623eb8ac7296b6d7a76657394272a71f5aee

Return unique_xmalloc_ptr from macro scope functions

This changes the macro scope functions (sal_macro_scope,
user_macro_scope, and default_macro_scope) to return a
unique_xmalloc_ptr, then fixes up the users.  This allowed for the
removal of several cleanups.

2018-02-08  Tom Tromey  <tom@tromey.com>

	* symtab.c (default_collect_symbol_completion_matches_break_on):
	Use unique_xmalloc_ptr.
	* macroscope.h: (sal_macro_scope, user_macro_scope)
	(default_macro_scope): Return unique_xmalloc_ptr.
	* macroscope.c (sal_macro_scope, user_macro_scope)
	(default_macro_scope): Return unique_xmalloc_ptr.
	* macroexp.h (macro_expand, macro_expand_once): Return
	unique_xmalloc_ptr.
	* macroexp.c (macro_expand, macro_expand_once): Return
	unique_xmalloc_ptr.
	* macrocmd.c (macro_expand_command, macro_expand_once_command)
	(info_macro_command, info_macros_command): Use
	unique_xmalloc_ptr.
	* compile/compile-c-support.c (write_macro_definitions): Use
	unique_xmalloc_ptr.
	* c-exp.y (c_parse): Use unique_xmalloc_ptr.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove a cleanup from gdbserver
@ 2018-02-08 19:05 sergiodj+buildbot
  2018-02-08 20:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-08 19:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 45dd3607e24aaf515b5d75c666b351575410392b ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 45dd3607e24aaf515b5d75c666b351575410392b

Remove a cleanup from gdbserver

This removes a cleanup from gdbserver's set_raw_breakpoint_at,
replacing it with unique_xmalloc_ptr.

2018-02-08  Tom Tromey  <tom@tromey.com>

	* mem-break.c (set_raw_breakpoint_at): Use
	gdb::unique_xmalloc_ptr.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix type of values representing optimized out static members
@ 2018-02-07 14:04 sergiodj+buildbot
  2018-02-07 15:30 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-07 14:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c2e0e465f9488970c7e460a41e3fb7c366530619 ***

Author: Simon Marchi <simark@simark.ca>
Branch: master
Commit: c2e0e465f9488970c7e460a41e3fb7c366530619

Fix type of values representing optimized out static members

As reported here:

  https://sourceware.org/ml/gdb/2018-02/msg00019.html

the type of values representing static members that are optimized out is
wrong.  It currently assigns the type of the containing class rather
than the type of the field.  This patch fixes that.

I found a place in m-static.exp already dealing with optimized out
static members, so I just added some gdb_test there.

gdb/ChangeLog:

	* value.c (value_static_field): Assign field type instead of
	containing type when returning an optimized out value.

gdb/testsuite/ChangeLog:

	* gdb.cp/m-static.exp: Check type of optimized out static
	member.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Revert "PowerPC PLT speculative execution barriers"
@ 2018-02-07  4:11 sergiodj+buildbot
  2018-02-07 12:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-07  4:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 407aa07cee4d075c8e7996a5e994c02e76f19276 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 407aa07cee4d075c8e7996a5e994c02e76f19276

Revert "PowerPC PLT speculative execution barriers"

This reverts most of commit 1be5d8d3bb.
Left in place are addition of --no-plt-align to some ppc32 ld tests
and the ld.texinfo --no-plt-thread-safe fix.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] RISC-V: Eliminate spurious error w/ reloc truncated message
@ 2018-02-07  1:08 sergiodj+buildbot
  2018-02-07  9:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-07  1:08 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ed01220cc81fac2f65abde945d9b77b11d004361 ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: ed01220cc81fac2f65abde945d9b77b11d004361

RISC-V: Eliminate spurious error w/ reloc truncated message

	bfd/
	* elfnn-riscv.c (riscv_elf_relocate_section): Return TRUE if used
	callback to report an error.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove some $ARCH_read_pc and $ARCH_write_pc
@ 2018-02-06 20:29 sergiodj+buildbot
  2018-02-07  7:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-06 20:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3f8c94b478c8f2e5c82a1425fd49e977ed969a7f ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 3f8c94b478c8f2e5c82a1425fd49e977ed969a7f

Remove some $ARCH_read_pc and $ARCH_write_pc

Nowadays, gdbarch_read_pc is called in this way,

  if (gdbarch_read_pc_p (gdbarch))
    pc_val = gdbarch_read_pc (gdbarch, regcache);
  /* Else use per-frame method on get_current_frame.  */
  else if (gdbarch_pc_regnum (gdbarch) >= 0)
    {
      ULONGEST raw_val;

      if (regcache_cooked_read_unsigned (regcache,
					 gdbarch_pc_regnum (gdbarch),
					 &raw_val) == REG_UNAVAILABLE)

some ports don't have to define its own gdbarch read_pc method if the
pc value is simply a unsigned value from "pc" register.  The same rule
applies to regcache_write_pc.  This patch removes these $ARCH_read_pc
and $ARCH_write_pc functions.

gdb:

2018-02-06  Yao Qi  <yao.qi@linaro.org>

	* ft32-tdep.c (ft32_read_pc): Remove.
	(ft32_write_pc): Remove.
	(ft32_gdbarch_init): Update.
	* m32r-tdep.c (m32r_read_pc): Remove.
	(m32r_gdbarch_init): Update.
	* mep-tdep.c (mep_read_pc): Remove.
	(mep_gdbarch_init): Update.
	* microblaze-tdep.c (microblaze_write_pc): Remove.
	(microblaze_gdbarch_init): Update.
	* mn10300-tdep.c (mn10300_read_pc): Remove.
	(mn10300_write_pc): Remove.
	(mn10300_gdbarch_init): Update.
	* moxie-tdep.c (moxie_read_pc): Remove.
	(moxie_write_pc): Remove.
	(moxie_gdbarch_init): Update.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix PR ld/22263 on SPARC.
@ 2018-02-06 17:43 sergiodj+buildbot
  2018-02-07  5:06 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-06 17:43 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c20c30f615756ddfccc4bb75c65ccfc1a399466e ***

Author: Eric Botcazou <ebotcazou@gcc.gnu.org>
Branch: master
Commit: c20c30f615756ddfccc4bb75c65ccfc1a399466e

Fix PR ld/22263 on SPARC.

This is -fpie -pie generating dynamic relocations in the text section,
simply because no TLS transitions are applied in PIE mode.  The meat
of the patch is to turn calls to bfd_link_pic (info) in TLS-related code
into !bfd_link_executable (info) and there are quite a lot of them...

bfd/
	* elfxx-sparc.c (sparc_elf_tls_transition): Turn call to bfd_link_pic
	into call to !bfd_link_executable and tidy up.
	(_bfd_sparc_elf_check_relocs): Fix formatting and tidy up.
	<R_SPARC_TLS_LE_HIX22>: Turn call to bfd_link_pic into call to
	!bfd_link_executable.
	<R_SPARC_TLS_IE_HI22>: Likewise.
	<GOT relocations>: Remove useless code, tidy and merge blocks.
	<R_SPARC_TLS_GD_CALL>: Turn call to bfd_link_pic into call to
	!bfd_link_executable.
	<R_SPARC_WPLT30>: Tidy up.
	(_bfd_sparc_elf_gc_mark_hook): Turn call to bfd_link_pic into call
	to !bfd_link_executable.
	(allocate_dynrelocs): Likewise.
	(_bfd_sparc_elf_relocate_section): Fix formatting and tidy up.
	<R_SPARC_TLS_GD_HI22>: Merge into...
	<R_SPARC_TLS_GD_LO10>: ...this.  Adjust 4th argument in call to
	sparc_elf_tls_transition and remove redundant code.
	<R_SPARC_TLS_LDM_HI22>: Turn call to bfd_link_pic into call to
	!bfd_link_executable.
	<R_SPARC_TLS_LDO_HIX22>: Likewise.
	<R_SPARC_TLS_LE_HIX22>: Likewise.  Tidy up.
	<R_SPARC_TLS_LDM_CALL>: Likewise.
	<R_SPARC_TLS_GD_CALL>: Likewise.  Tidy up.
	<R_SPARC_TLS_GD_ADD>: Likewise.
	<R_SPARC_TLS_LDM_ADD>: Likewise.
	<R_SPARC_TLS_LDO_ADD>: Likewise.
	<R_SPARC_TLS_IE_LD>: Likewise.
ld/
	* testsuite/ld-elf/tls.exp (AFLAGS_PIC): Define on SPARC.
	(pr22263-1): Pass AFLAGS_PIC to the assembler.
	* testsuite/ld-sparc/tlspie32.s: Add test for other 3 transitions.
	* testsuite/ld-sparc/tlspie32.dd: Adjust to above.
	* testsuite/ld-sparc/tlspie64.s: Add test for other 3 transitions.
	* testsuite/ld-sparc/tlspie64.dd: Adjust to above.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Improve the find_nearest_line function for the MIPS target so that it tries harder to find a function name.
@ 2018-02-06 17:17 sergiodj+buildbot
  2018-02-07  0:59 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-06 17:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 46d09186d340407fdcf066fea25444682e989512 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 46d09186d340407fdcf066fea25444682e989512

Improve the find_nearest_line function for the MIPS target so that it tries harder to find a function name.

	PR 22789
	* elfxx-mips.c (_bfd_mips_elf_find_nearest_line): If the dwarf
	functions failed to find the function name, try the generic elf
	find function instead.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Prevent attempts to call strncpy with a zero-length field by chacking the size of debuglink sections.
@ 2018-02-06 16:48 sergiodj+buildbot
  2018-02-06 21:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-06 16:48 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 64e234d417d5685a4aec0edc618114d9991c031b ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 64e234d417d5685a4aec0edc618114d9991c031b

Prevent attempts to call strncpy with a zero-length field by chacking the size of debuglink sections.

	PR 22794
	* opncls.c (bfd_get_debug_link_info_1): Check the size of the
	section before attempting to read it in.
	(bfd_get_alt_debug_link_info): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Allow the find_abstract_instance_name() function in the BFD library to also return file and line number information.
@ 2018-02-06 16:04 sergiodj+buildbot
  2018-02-06 18:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-06 16:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 422f3d3d6d5713bf9235b7b7696818a70b3b578d ***

Author: Paul Carroll <pcarroll@codesourcery.com>
Branch: master
Commit: 422f3d3d6d5713bf9235b7b7696818a70b3b578d

Allow the find_abstract_instance_name() function in the BFD library to also return file and line number information.

The nm utility supports -l for using debug information to obtain file and line information for each symbol, if available.
We have a tool that consumes this information and displays it.
This identified a problem with the 'nm' utility.

When a source is compiled with -O2, functions can be inlined.  The compiler also produces an uninlined copy of the function, normally for linking to other object files.
In the case of DWARF2 debug information, the compiler generates debug information to describe a function.  If that function is inlined, the compiler then references that debug information from the inlined and uninlined copies of the routine through the use of the DW_AT_abstract_origin reference.
When nm is used on such a file, it is not able to find file and line information because that information is present in the common debug information and not at each actual implementation of the function.
The 'nm' utility only retrieves the name of the function from the abstract origin debug information and no more.

What I am proposing is to modify the find_abstract_instance_name() function (which I renamed to find_abstract_instance() ) to return the name of the function as well as any file and line information.  The routine is already parsing all of the debug information in the abstract instance, so it is easy to pick up the file and line information at that time. If, for some reason, the file and line information is not present, the routine behaves as before.

For example, if I have a simple test case:

int foo(int j)
{
        if (j < 15)
                j += j << 2;
        else
                j += j << 6;
        return j;
}

int main (int argc,char **argv)
{
        int i = argc;
        i += foo(i);
        return i;
}

If that test case is compiled with -O2 and then 'nm -l' reads that executable, it currently produces this symbol output (ignoring a lot of library symbols):

8048400 T foo
080482e0 T main /scratch/pcarroll/its254/test/mytest.c:12

If I modify 'nm' to return file and line information for abstract instances, it produces the following output:

08048400 T foo  /scratch/pcarroll/its254/test/mytest.c:1
080482e0 T main /scratch/pcarroll/its254/test/mytest.c:12
--------------------------------------------------------------------------
bfd	* bfd/dwarf2.c (find_abstract_name): Modified to return file and
	line information in addition to name, if they can be found.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] ppc64: Fix stwux encoding
@ 2018-02-05 19:45 sergiodj+buildbot
  2018-02-06  8:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-05 19:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 72dd27306224497c8ba97f391d30b774d4d973fb ***

Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Branch: master
Commit: 72dd27306224497c8ba97f391d30b774d4d973fb

ppc64: Fix stwux encoding

With gcc-8.0.1-0.9.fc28.x86_64 I get:

../../gdb/rs6000-tdep.c: In function 'CORE_ADDR skip_prologue(gdbarch*, CORE_ADDR, CORE_ADDR, rs6000_framedata*)':
../../gdb/rs6000-tdep.c:1911:34: error: bitwise comparison always evaluates to false [-Werror=tautological-compare]
       else if ((op & 0xfc1f016a) == 0x7c01016e)
                ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~

https://www.ibm.com/support/knowledgecenter/en/ssw_aix_72/com.ibm.aix.alangref/idalangref_stwux_stux_instrs.htm
says
	bit 21 - 30 = 183
	Those are bits 1..10 in normal bit order: 183<<1 = 0x16e

gdb/ChangeLog
2018-02-04  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* rs6000-tdep.c (skip_prologue): Fix stwux encoding.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [PR22764][LD][AARCH64]Allow R_AARCH64_ABS16 and R_AARCH64_ABS32 against absolution symbol or undefine symbol in shared object.
@ 2018-02-05 18:56 sergiodj+buildbot
  2018-02-06  7:08 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-05 18:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 279b2f94168ee91e02ccd070d27c983fc001fe12 ***

Author: Renlin Li <renlin.li@arm.com>
Branch: master
Commit: 279b2f94168ee91e02ccd070d27c983fc001fe12

[PR22764][LD][AARCH64]Allow R_AARCH64_ABS16 and R_AARCH64_ABS32 against absolution symbol or undefine symbol in shared object.

The assumption that R_AARCH64_ABS16 and R_AARCH64_ABS32 relocation in LP64 abi
will be used to generate an address does not hold for absolute symbol.
In this case, it is a value fixed at static linking time.

The condition to check the relocations is relax to allow absolute symbol and
undefined symbol case.

bfd/

2018-02-05  Renlin Li  <renlin.li@arm.com>

	PR ld/22764
	* elfnn-aarch64.c (elfNN_aarch64_check_relocs): Relax the
	R_AARCH64_ABS32 and R_AARCH64_ABS16 for absolute symbol. Apply the
	check for writeable section as well.

ld/

2018-02-05  Renlin Li  <renlin.li@arm.com>

	PR ld/22764
	* testsuite/ld-aarch64/emit-relocs-258.s: Define symbol as an address.
	* testsuite/ld-aarch64/emit-relocs-259.s: Likewise.
	* testsuite/ld-aarch64/aarch64-elf.exp: Run new test.
	* testsuite/ld-aarch64/pr22764.s: New.
	* testsuite/ld-aarch64/pr22764.d: New.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove myself as a write-after-approval GDB maintainer.
@ 2018-02-05 18:11 sergiodj+buildbot
  2018-02-06  5:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-05 18:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f3b91ed8f96a4d41eef1c64a7e77c406ec763612 ***

Author: Antoine Tremblay <antoine.tremblay@ericsson.com>
Branch: master
Commit: f3b91ed8f96a4d41eef1c64a7e77c406ec763612

Remove myself as a write-after-approval GDB maintainer.

Since I'll be leaving Ericsson.

gdb/
	* MAINTAINERS (Write After Approval): Remove Antoine Tremblay.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: Remove the unused _GLOBAL_OFFSET_TABLE_
@ 2018-02-05 17:05 sergiodj+buildbot
  2018-02-06  3:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-05 17:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cd04836359da82ae1dc67e5a05565536f4427b51 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: cd04836359da82ae1dc67e5a05565536f4427b51

x86: Remove the unused _GLOBAL_OFFSET_TABLE_

Since _GLOBAL_OFFSET_TABLE_ may be referenced implicitly on x86,
checking ref_regular_nonweak leaves the unused _GLOBAL_OFFSET_TABLE_
in output.  This patch checks explicit GOT references instead.

ld-i386/discarded1.s and ld-x86-64/discarded1.s are updated to avoid
linker optimization which removes GOT references.

bfd/

	PR ld/22782
	* elf32-i386.c (elf_i386_check_relocs): Set got_referenced if
	_GLOBAL_OFFSET_TABLE_ is referenced or GOT is needed to resolve
	undefined weak symbol to 0.
	* elf64-x86-64.c (elf_x86_64_check_relocs): Set got_referenced
	if _GLOBAL_OFFSET_TABLE_ is referenced.
	* elfxx-x86.c (_bfd_x86_elf_size_dynamic_sections): Check
	got_referenced instead of ref_regular_nonweak.  Remove the
	unused _GLOBAL_OFFSET_TABLE_ from symbol table.
	* elfxx-x86.h (elf_x86_link_hash_table): Add got_referenced.

ld/

	PR ld/22782
	* testsuite/ld-i386/discarded1.s: Replace mov with div.
	* testsuite/ld-x86-64/discarded1.s: Likewise.
	* testsuite/ld-i386/i386.exp: Run pr22782.
	* testsuite/ld-i386/load1-nacl.d: Updated for removing
	_GLOBAL_OFFSET_TABLE_ from output.
	* testsuite/ld-i386/load1.d: Likewise.
	* testsuite/ld-x86-64/load1a-nacl.d: Likewise.
	* testsuite/ld-x86-64/load1a.d: Likewise.
	* testsuite/ld-x86-64/load1b-nacl.d: Likewise.
	* testsuite/ld-x86-64/load1b.d: Likewise.
	* testsuite/ld-i386/pr22782.d: New file.
	* testsuite/ld-i386/pr22782.s: Likewise.
	* testsuite/ld-x86-64/pr22782.s: Likewise.
	* testsuite/ld-x86-64/pr22782a.d: Likewise.
	* testsuite/ld-x86-64/pr22782b.d: Likewise.
	* testsuite/ld-x86-64/x86-64.exp: Run pr22782a and pr22782b.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] RISC-V/BFD: Correct a missing initializer error with pre-4.7 GCC
@ 2018-02-05 14:42 sergiodj+buildbot
  2018-02-05 23:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-05 14:42 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e65b1a78686f840ab46fe97355d674919185adc8 ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: e65b1a78686f840ab46fe97355d674919185adc8

RISC-V/BFD: Correct a missing initializer error with pre-4.7 GCC

Correct a commit 9d06997adb88 ("RISC-V: Relax RISCV_PCREL_* to
RISCV_GPREL_*") regression and remove a `-Wmissing-field-initializers'
compilation error:

cc1: warnings being treated as errors
.../bfd/elfnn-riscv.c: In function '_bfd_riscv_relax_pc':
.../bfd/elfnn-riscv.c:3117: error: missing initializer
.../bfd/elfnn-riscv.c:3117: error: (near initialization for 'hi_reloc.hi_addend')
make[4]: *** [elf64-riscv.lo] Error 1

which for versions of GCC before 4.7 prevents support for RISC-V targets
from being built.  See also GCC PR c/36750.

	bfd/
	* elfnn-riscv.c (_bfd_riscv_relax_pc): Use `memset' to
	initialize `hi_reloc'.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] MIPS/BFD: Correctly report unsupported `.reginfo' section size
@ 2018-02-05 14:29 sergiodj+buildbot
  2018-02-05 21:57 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-05 14:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2d6dda71611ba6cc16fe2bd21ac816d5f7d1e74d ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 2d6dda71611ba6cc16fe2bd21ac816d5f7d1e74d

MIPS/BFD: Correctly report unsupported `.reginfo' section size

Report an error when an unsupported `.reginfo' section size is found in
`_bfd_mips_elf_section_processing', removing an assertion that triggers
at elfxx-mips.c:7105 in GAS when assembling input like:

	.section	.reginfo
	.word		0xdeadbeef

and in `objcopy --rename-section' when renaming an incorrectly sized
section to `.reginfo'.

	bfd/
	* elfxx-mips.c (_bfd_mips_elf_section_processing): For
	SHT_MIPS_REGINFO sections don't assert the correct size and
	report an error instead.

	binutils/
	* testsuite/binutils-all/mips/mips-reginfo.d: New test.
	* testsuite/binutils-all/mips/mips-reginfo-n32.d: New test.
	* testsuite/binutils-all/mips/mips-reginfo.s: New test source.
	* testsuite/binutils-all/mips/mips.exp: Run the new tests.

	gas/
	* testsuite/gas/mips/reginfo-2.d: New test.
	* testsuite/gas/mips/reginfo-2-n32.d: New test.
	* testsuite/gas/mips/reginfo-2.l: New test stderr output.
	* testsuite/gas/mips/reginfo-2.s: New test source.
	* testsuite/gas/mips/mips.exp: Run the new tests.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Align natural-format register values to the same column
@ 2018-02-05  8:46 sergiodj+buildbot
  2018-02-05 11:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-05  8:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e813d34aaabee0ca034fa5ddd50e76ade80318bc ***

Author: Ruslan Kabatsayev <b7.10110111@gmail.com>
Branch: master
Commit: e813d34aaabee0ca034fa5ddd50e76ade80318bc

Align natural-format register values to the same column

Currently, commands such as "info reg", "info all-reg", as well as register
window in the TUI print badly aligned columns, like here:

eax            0x1      1
ecx            0xffffd3e0       -11296
edx            0xffffd404       -11260
ebx            0xf7fa5ff4       -134586380
esp            0xffffd390       0xffffd390
ebp            0xffffd3c8       0xffffd3c8
esi            0x0      0
edi            0x0      0
eip            0x8048b60        0x8048b60 <main+16>
eflags         0x286    [ PF SF IF ]
cs             0x23     35
ss             0x2b     43
ds             0x2b     43
es             0x2b     43
fs             0x0      0
gs             0x63     99

After this patch, these commands print the third column values consistently
aligned one under another, provided the second column is not too long.
Originally, the third column was (attempted to be) aligned using a simple tab
character. This patch changes the alignment to spaces only. The tests checking
the output and expecting the single tab have been fixed in a previous patch, so
this change doesn't break any.

gdb/ChangeLog:

	* infcmd.c (default_print_one_register_info): Align natural-format
	column values consistently one under another.
	(pad_to_column): New function.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Move comment in gdb/dwarf2read.c::dwarf2_physname
@ 2018-02-05  5:03 sergiodj+buildbot
  2018-02-05  6:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-05  5:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0eb876f52f348ff08be24bca6cbca00e302839b2 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 0eb876f52f348ff08be24bca6cbca00e302839b2

Move comment in gdb/dwarf2read.c::dwarf2_physname

This commit just moves a comment right next to where it is actually
relevant. No actual code change.

gdb/ChangeLog:

        * dwarf2read.c (dwarf2_physname): Move commment.

Tested by rebuilding GDB.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdb/testsuite: Remove use of dejagnu cleanup proc
@ 2018-02-03 17:11 sergiodj+buildbot
  2018-02-03 19:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-03 17:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f721678315fc6bbec25341bd616a906976d72693 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: f721678315fc6bbec25341bd616a906976d72693

gdb/testsuite: Remove use of dejagnu cleanup proc

The 'cleanup' proc has been removed from dejagnu (Feb 15 2016).  The
proc has not done anything useful since at least 2001 so removing
these calls should be harmless.

gdb/testsuite/ChangeLog:

	* config/sid.exp (gdb_target_sid): Remove use of cleanup.
	* config/sim.exp (gdb_target_sim): Remove use of cleanup.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] RISC-V: Fix --wrap and relaxation conflict.
@ 2018-02-02 20:58 sergiodj+buildbot
  2018-02-02 22:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-02 20:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7f02625eb48105e100d2da58091d56978ed041ef ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 7f02625eb48105e100d2da58091d56978ed041ef

RISC-V: Fix --wrap and relaxation conflict.

	bfd/
	PR ld/22756
	* elfnn-riscv.c (riscv_relax_delete_bytes): New parameter link_info.
	If link_info->wrap_hash, check for a duplicate symbol and ignore.
	(_bfd_riscv_relax_call, bfd_riscv_relax_lui, _bfd_riscv_relax_tls_le):
	Pass new argument to riscv_relax_delete_bytes.
	(_bfd_riscv_relax_align, _bfd_riscv_relax_delete): Likewise.  Remove
	ATTRIBUTE_UNUSED from link_info parameter.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] MI: Allow non-raw varobj evaluation
@ 2018-02-02 19:21 sergiodj+buildbot
  2018-02-02 20:50 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-02 19:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0625771b9e29116dc1fb0b597501f18e4bb0e18c ***

Author: Leszek Swirski via gdb-patches <gdb-patches@sourceware.org>
Branch: master
Commit: 0625771b9e29116dc1fb0b597501f18e4bb0e18c

MI: Allow non-raw varobj evaluation

Make the MI variable object expression evaluation, with the
-var-evaluate-expression command, recursively call pretty printers, to
match the output of normal expression printing.

Consider the following code:

        struct Foo { int val; };
        struct Wrapper { Foo foo; };

        int main() {
                Wrapper w;
                w.foo.val = 23;
        }

and this pretty printer file:

        import gdb.printing

        class FooPrinter:
          def __init__(self, val):
            self.val = val
          def to_string(self):
            return "Foo" + str(self.val["val"])

        class WrapperPrinter:
          def __init__(self, val):
            self.val = val
          def to_string(self):
            return self.val["foo"]

        test_printer = gdb.printing.RegexpCollectionPrettyPrinter("test")
        test_printer.add_printer('Foo', '^Foo$', FooPrinter)
        test_printer.add_printer('Wrapper', '^Wrapper$', WrapperPrinter)

        gdb.printing.register_pretty_printer(None, test_printer)

Setting a breakpoint at the end of the function, we call the following commands:

        -enable-pretty-printing
        ^done

        -var-create var_w @ w
        ^done,name="var_w",numchild="0",value="{val = 23}",type="Wrapper",dynamic="1",has_more="0"
        -var-create var_w_foo @ w.foo
        ^done,name="var_w_foo",numchild="0",value="Foo23",type="Foo",dynamic="1",has_more="0"

        -var-evaluate-expression var_w
        ^done,value="{val = 23}"
        -var-evaluate-expression var_w_foo
        ^done,value="Foo23"

        -data-evaluate-expression w
        ^done,value="Foo23"
        -data-evaluate-expression w.foo
        ^done,value="Foo23"

So, in the -var-evaluate-expression var_w case, we print the "raw" value
of w.foo, while in the -data-evaluate-expression w case, we print the
pretty printed w.foo value. After this patch, all of the above print
"Foo23".

gdb/ChangeLog:

	* varobj.c (varobj_formatted_print_options): Allow recursive
	pretty printing if pretty printing is enabled.

gdb/testsuite/ChangeLog:

	* gdb.python/py-prettyprint.c
	(struct to_string_returns_value_inner,
	struct to_string_returns_value_wrapper): New.
	(main): Add tsrvw variable.
	* gdb.python/py-prettyprint.py (ToStringReturnsValueInner,
	ToStringReturnsValueWrapper): New classes.
	(register_pretty_printers): Register new pretty-printers.
	* gdb.python/py-prettyprint.exp (run_lang_tests): Test printing
	recursive pretty printer.
	* gdb.python/py-mi.exp: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Do not classify C struct members as a filename
@ 2018-02-02  3:50 sergiodj+buildbot
  2018-02-02  5:13 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-02  3:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 59498c305e6f1db2a1ed8d44cb58f0d24ec092fe ***

Author: Leszek Swirski <leszeks@google.com>
Branch: master
Commit: 59498c305e6f1db2a1ed8d44cb58f0d24ec092fe

Do not classify C struct members as a filename

There is existing logic in C/C++ expression parsing to avoid classifying
names as a filename when they are a field on the this object. This
change extends this logic to also avoid classifying names after a
struct-op (-> or .) as a filename, which otherwise causes a syntax
error.

Thus, it is now possible in the file

    #include <map>
    struct D {
        void map();
    }
    D d;

to call

    (gdb) print d.map()

where previously this would have been a syntax error.

Tested on gdb.cp/*.exp

gdb/ChangeLog:

        * c-exp.y (lex_one_token, classify_name, yylex): Don't classify
        names after a structop as a filename

gdb/testsuite/ChangeLog:

        * gdb.cp/filename.cc, gdb.cp/filename.exp: Test that member
        functions with the same name as an include file are parsed
        correctly.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Rewrite arm_record_coproc_data_proc and arm_record_data_proc_misc_ld_str
@ 2018-02-01 16:11 sergiodj+buildbot
  2018-02-01 21:08 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-01 16:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2d9e6acbdbc528563a9df5445584a8a150a86527 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 2d9e6acbdbc528563a9df5445584a8a150a86527

Rewrite arm_record_coproc_data_proc and arm_record_data_proc_misc_ld_str

When I triage some reverse debugging test fails on arm-linux, I find
arm_record_coproc_data_proc and arm_record_data_proc_misc_ld_str is not
friendly to instruction encoding on ARM ARM.  This patch rewrites them, in
a way match more closely to the manual.

gdb:

2018-02-01  Yao Qi  <yao.qi@linaro.org>

	* arm-tdep.c (arm_record_data_proc_misc_ld_str): Rewrite it.
	(arm_record_coproc_data_proc): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] set ret signed in arm_record_extension_space
@ 2018-02-01 15:47 sergiodj+buildbot
  2018-02-01 19:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-01 15:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT df95a9cf09867c237ddf9b4eb65a990e86de1e17 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: df95a9cf09867c237ddf9b4eb65a990e86de1e17

set ret signed in arm_record_extension_space

Variable 'ret' should be int rather than unsigned, as it can be -1.

gdb:

2018-02-01  Yao Qi  <yao.qi@linaro.org>

	* arm-tdep.c (arm_record_extension_space): Change ret to signed.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix gdb.base/attach.exp fails when gdb is configured --with-sysroot=/
@ 2018-02-01 15:05 sergiodj+buildbot
  2018-02-01 17:18 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-02-01 15:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d4d38844faaff1576b021558d0835dedbd415e8d ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: d4d38844faaff1576b021558d0835dedbd415e8d

Fix gdb.base/attach.exp fails when gdb is configured --with-sysroot=/

I see some test fails in gdb.base/attach.exp when gdb is configured
--with-sysroot=/.

FAIL: gdb.base/attach.exp: attach2, with no file
FAIL: gdb.base/attach.exp: load file manually, after attach2 (re-read) (got interactive prompt)
FAIL: gdb.base/attach.exp: attach when process' a.out not in cwd

If gdb is configured this way, sysroot is "/" in default, and if binfile
is a absolute path, the regexp pattern $sysroot$escapedbinfile is
incorrect.

There are different ways to fix it, but I don't want to complicate the
test, so I choose this naive way.

gdb/testsuite:

2018-02-01  Yao Qi  <yao.qi@linaro.org>

	* gdb.base/attach.exp (do_attach_tests): Set sysroot to
	"\[^\r\n\]*".


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdb: Fix remote-sim/MinGW/Darwin builds
@ 2018-01-31 15:21 sergiodj+buildbot
  2018-02-01  4:15 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-31 15:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f6cfb42730ed37bfb32cb27ef627df930f437f08 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: f6cfb42730ed37bfb32cb27ef627df930f437f08

gdb: Fix remote-sim/MinGW/Darwin builds

The recent commit e671cd59 ("Per-inferior target_terminal state, fix
PR gdb/13211, more") missed adjusting a few targets to the new
target_ops->to_interrupt interface, breaking the build for those
targets.  This fixes it.

Note: remote-sim doesn't really support async execution, so I don't
think gdbsim_interrupt is ever reached via target_interrupt.  (It is
reached via gdbsim_cntrl_c though).

The inflow.c changes are a bit ugly, but they're just doing what other
parts of the file already do to handle the same missing functions.
Targets that don't have 'kill', like mingw have their own
target_ops->to_interrupt implementation, so it's fine to make
child_interrupt be a nop.

gdb/ChangeLog:
2018-01-31  Pedro Alves  <palves@redhat.com>

	* darwin-nat.c (darwin_interrupt): Remove ptid_t parameter.
	* inflow.c (child_terminal_save_inferior): Wrap reference to
	tcgetpgrp in HAVE_TERMIOS_H.
	(child_interrupt, child_pass_ctrlc): Wrap references to signal in
	_WIN32.
	* remote-sim.c (gdbsim_interrupt): Remove ptid_t parameter and
	always iterate over all inferiors.
	(gdbsim_cntrl_c): Adjust.
	* windows-nat.c (windows_interrupt): Remove 'ptid_t' parameter.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] (Ada) C++fy conditional string when catching exception.
@ 2018-01-31 13:56 sergiodj+buildbot
  2018-01-31 19:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-31 13:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 56ecd069f031d6bcdaa46664c68a16cb27b379c3 ***

Author: Xavier Roirand <roirand@adacore.com>
Branch: master
Commit: 56ecd069f031d6bcdaa46664c68a16cb27b379c3

(Ada) C++fy conditional string when catching exception.

This commit C++fy the conditional string used when catching Ada exception.

gdb/ChangeLog:

        * ada-lang.c (catch_ada_exception_command_split)
        (create_ada_exception_catchpoint) <cond_string>: Change parameter
        type.  Update code accordingly.
        (catch_ada_exception_command, catch_ada_handlers_command): Use
        C++ string instead of char* for conditional var.
        (catch_ada_assert_command_split) <cond_string>: Change parameter
        type.  Update code accordingly.
        (catch_assert_command): Use C++ string instead of char* for
        conditional var.
        * ada-lang.h (create_ada_exception_catchpoint) <cond_string>:
        Update declaration.
        * mi/mi-cmd-catch.c (mi_cmd_catch_assert, mi_cmd_catch_exception):
        Use std::string instead of char* for condition string.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Check if __start/__stop symbols are referenced by shared objects
@ 2018-01-31 13:56 sergiodj+buildbot
  2018-01-31 23:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-31 13:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 823143c6ca8ef4267e67ba03771991e08d09fabd ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 823143c6ca8ef4267e67ba03771991e08d09fabd

Check if __start/__stop symbols are referenced by shared objects

Define  __start/__stop symbols if they are referenced by shared objects,
not if they are also defined in shared objects.

bfd/

	PR ld/21964
	* elflink.c (bfd_elf_define_start_stop): Check if __start and
	__stop symbols are referenced by shared objects.

ld/

	PR ld/21964
	* testsuite/ld-elf/pr21964-4.c: New file.
	* testsuite/ld-elf/shared.exp: Run pr21964-4 test on Linux.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] (Ada) Add gdb-mi support for stopping at start of exception handler.
@ 2018-01-31 13:41 sergiodj+buildbot
  2018-01-31 21:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-31 13:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bea298f9547372e6cb7854fabc2c0646e1d3d9be ***

Author: Xavier Roirand <roirand@adacore.com>
Branch: master
Commit: bea298f9547372e6cb7854fabc2c0646e1d3d9be

(Ada) Add gdb-mi support for stopping at start of exception handler.

Following my previous commit which add support for stopping at start of
exception handler, this commit adds required gdb-mi support for this
feature.

gdb/ChangeLog:

    * mi/mi-cmd-catch.c (mi_cmd_catch_handlers): New function.
    * mi/mi-cmds.c (mi_cmds): Add catch-handlers command.
    * mi/mi-cmds.h (mi_cmd_catch_handlers): Add external declaration.
    * NEWS: Document "-catch-handlers" command.

gdb/doc/ChangeLog:

    * gdb.texinfo (Ada Exception gdb/mi Catchpoints): Add
    documentation for new "-catch-handlers" command.

gdb/testsuite/ChangeLog:

    * gdb.ada/mi_catch_ex_hand.exp: New testcase.
    * gdb.ada/mi_catch_ex_hand/foo.adb: New file.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] (Ada) Add testcase for catch assert with condition
@ 2018-01-31 13:03 sergiodj+buildbot
  2018-01-31 14:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-31 13:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 395507f62b98a6a1f6778295a5667110b0fc4b57 ***

Author: Xavier Roirand <roirand@adacore.com>
Branch: master
Commit: 395507f62b98a6a1f6778295a5667110b0fc4b57

(Ada) Add testcase for catch assert with condition

gdb/testsuite/ChangeLog:

    * gdb.ada/catch_assert_if.exp: New testcase.
    * gdb.ada/catch_assert_if/bla.adb: New file.
    * gdb.ada/catch_assert_if/pck.ads: New file.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] internal-error using '@' (repeat) operator on array of dynamic objects
@ 2018-01-31  7:35 sergiodj+buildbot
  2018-01-31  9:59 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-31  7:35 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 929b5ad40f70fbd5bdf37d30281a761d56c87b59 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 929b5ad40f70fbd5bdf37d30281a761d56c87b59

internal-error using '@' (repeat) operator on array of dynamic objects

Using the following Ada declarations (the same as in
gdb.ada/dyn_stride.exp)...

      subtype Small_Type is Integer range L .. U;
      type Record_Type (I : Small_Type := L) is record
         S : String (1 .. I);
      end record;
      type Array_Type is array (Integer range <>) of Record_Type;

      A1 : Array_Type :=
        (1 => (I => U, S => (others => ASCII.NUL)),
         2 => (I => 1, S => "A"),
         3 => (I => 2, S => "AB"));

... where "L" and "U" are variables, trying to apply the repeat
operator to "A1(1)" yields to an internal error:

  | (gdb) print a1(1)@3
  | $5 = /[...]/gdbtypes.c:4883: internal-error: type* copy_type(const type*):
  | Assertion `TYPE_OBJFILE_OWNED (type)' failed.

What happens first is that the ada-lang module evaluated the "A1(1)"
sub-expression returning a structure where "I" (one of the fields
in that structure) has a type which is dynamic, because it is
a range type whose bounds are not statically known.

Next, we apply the repeat ('@') operator, which is done via
allocate_repeat_value, which creates an array type with the correct
bounds to associate to our value, by calling lookup_array_range_type:

  | struct type *
  | lookup_array_range_type (struct type *element_type,
  |                          LONGEST low_bound, LONGEST high_bound)
  | {
  |   struct gdbarch *gdbarch = get_type_arch (element_type);
  |   struct type *index_type = builtin_type (gdbarch)->builtin_int;
  |   struct type *range_type
  |     = create_static_range_type (NULL, index_type, low_bound, high_bound);
  |
  |   return create_array_type (NULL, element_type, range_type);
  | }

As we can see, this creates an array type whose index type is
always owned by the gdbarch. This is where the problem lies.

Next, we use that type to construct a struct value. That value
then gets passed to the valprint module, which then checks
whether our object is dynamic or not. And because field "I" above
had a dynamic range type, we end up determining by association
that the artificial repeat array itself is also dynamic. So
we attempt to resolve the type, which leads to trying to copying
that type. And because the artifical array created by
lookup_array_range_type has an index which is not objfile-owned,
we trip the assertion.

This patch fixes the issue by enhancing lookup_array_range_type
to create an index type which has the same owner as the element
type.

gdb/ChangeLog:

        * gdbtypes.c (lookup_array_range_type): Make sure the array's
        index type is objfile-owned if the element type is as well.

gdb/testsuite/ChangeLog:

        * testsuite/gdb.ada/dyn_stride.exp: Add "print a1(1)@3" test.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Improve junk file removal in source tarball creation script.
@ 2018-01-30 18:05 sergiodj+buildbot
  2018-01-30 23:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-30 18:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 52b2f30022323367b2cd727f402c9876bdc53b0d ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 52b2f30022323367b2cd727f402c9876bdc53b0d

Improve junk file removal in source tarball creation script.

	* src-release.sh (do_proto_toplev): Add patterns for more junk files
	to delete before creating the tarball.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Per-inferior target_terminal state, fix PR gdb/13211, more
@ 2018-01-30 16:06 sergiodj+buildbot
  2018-01-30 19:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-30 16:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e671cd59d74cec9f53e110ce887128d1eeadb7f2 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: e671cd59d74cec9f53e110ce887128d1eeadb7f2

Per-inferior target_terminal state, fix PR gdb/13211, more

In my multi-target branch I ran into problems with GDB's terminal
handling that exist in master as well, with multi-inferior debugging.

This patch adds a testcase for said problems
(gdb.multi/multi-term-settings.exp), fixes the problems, fixes PR
gdb/13211 as well (and adds a testcase for that too,
gdb.base/interrupt-daemon.exp).

The basis of the problem I ran into is the following.  Consider a
scenario where you have:

 - inferior 1 - started with "attach", process is running on some
   other terminal.

 - inferior 2 - started with "run", process is sharing gdb's terminal.

In this scenario, when you stop/resume both inferiors, you want GDB to
save/restore the terminal settings of inferior 2, the one that is
sharing GDB's terminal.  I.e., you want inferior 2 to "own" the
terminal (in target_terminal::is_ours/target_terminal::is_inferior
sense).

Unfortunately, that's not what you get currently.  Because GDB doesn't
know whether an attached inferior is actually sharing GDB's terminal,
it tries to save/restore its settings anyway, ignoring errors.  In
this case, this is pointless, because inferior 1 is running on a
different terminal, but GDB doesn't know better.

And then, because it is only possible to have the terminal settings of
a single inferior be in effect at a time, or make one inferior/pgrp be
the terminal's foreground pgrp (aka, only one inferior can "own" the
terminal, ignoring fork children here), if GDB happens to try to
restore the terminal settings of inferior 1 first, then GDB never
restores the terminal settings of inferior 2.

This patch fixes that and a few things more along the way:

 - Moves enum target_terminal::terminal_state out of the
   target_terminal class (it's currently private) and makes it a
   scoped enum so that it can be easily used elsewhere.

 - Replaces the inflow.c:terminal_is_ours boolean with a
   target_terminal_state variable.  This allows distinguishing is_ours
   and is_ours_for_output states.  This allows finally making
   child_terminal_ours_1 do something with its "output_only"
   parameter.

 - Makes each inferior have its own copy of the
   is_ours/is_ours_for_output/is_inferior state.

 - Adds a way for GDB to tell whether the inferior is sharing GDB's
   terminal.  Works best on Linux and Solaris; the fallback works just
   as well as currently.

 - With that, we can remove the inf->attach_flag tests from
   child_terminal_inferior/child_terminal_ours.

 - Currently target_ops.to_ours is responsible for both saving the
   current inferior's terminal state, and restoring gdb's state.
   Because each inferior has its own terminal state (possibly handled
   by different targets in a multi-target world, even), we need to
   split the inferior-saving part from the gdb-restoring part.  The
   patch adds a new target_ops.to_save_inferior target method for
   that.

 - Adds a new target_terminal::save_inferior() function, so that
   sequences like:

     scoped_restore_terminal_state save_state;
     target_terminal::ours_for_output ();

   ... restore back inferiors that were
   target_terminal_state::is_inferior before back to is_inferior, and
   leaves inferiors that were is_ours alone.

 - Along the way, this adds a default implementation of
   target_pass_ctrlc to inflow.c (for inf-child.c), that handles
   passing the Ctrl-C to a process running on GDB's terminal or to
   some other process otherwise.

 - Similarly, adds a new target default implementation of
   target_interrupt, for the "interrupt" command.  The current
   implementation of this hook in inf-ptrace.c kills the whole process
   group, but that's incorrect/undesirable because we may not be
   attached to all processes in the process group.  And also, it's
   incorrect because inferior_process_group() doesn't really return
   the inferior's real process group id if the inferior is not a
   process group leader...  This is the cause of PR gdb/13211 [1],
   which this patch fixes.  While at it, that target method's "ptid"
   parameter is eliminated, because it's not really used.

 - A new test is included that exercises and fixes PR gdb/13211, and
   also fixes a GDB issue reported on stackoverflow that I ran into
   while working on this [2].  The problem is similar to PR gdb/13211,
   except that it also triggers with Ctrl-C.  When debugging a daemon
   (i.e., a process that disconnects from the controlling terminal and
   is not a process group leader, then Ctrl-C doesn't work, you just
   can't interrupt the inferior at all, resulting in a hung debug
   session.  The problem is that since the inferior is no longer
   associated with gdb's session / controlling terminal, then trying
   to put the inferior in the foreground fails.  And so Ctrl-C never
   reaches the inferior directly.  pass_signal is only used when the
   inferior is attached, but that is not the case here.  This is fixed
   by the new child_pass_ctrlc.  Without the fix, the new
   interrupt-daemon.exp testcase fails with timeout waiting for a
   SIGINT that never arrives.

[1] PR gdb/13211 - Async / Process group and interrupt not working
https://sourceware.org/bugzilla/show_bug.cgi?id=13211

[2] GDB not reacting Ctrl-C when after fork() and setsid()
https://stackoverflow.com/questions/46101292/gdb-not-reacting-ctrl-c-when-after-fork-and-setsid

Note this patch does _not_ fix:

 - PR gdb/14559 - The 'interrupt' command does not work if sigwait is in use
   https://sourceware.org/bugzilla/show_bug.cgi?id=14559

 - PR gdb/9425 - When using "sigwait" GDB doesn't trap SIGINT. Ctrl+C terminates program when should break gdb.
   https://sourceware.org/bugzilla/show_bug.cgi?id=9425

The only way to fix that that I know of (without changing the kernel)
is to make GDB put inferiors in a separate session (create a
pseudo-tty master/slave pair, make the inferior run with the slave as
its terminal, and have gdb pump output/input on the master end).

gdb/ChangeLog:
2018-01-30  Pedro Alves  <palves@redhat.com>

	PR gdb/13211
	* config.in, configure: Regenerate.
	* configure.ac: Check for getpgid.
	* go32-nat.c (go32_pass_ctrlc): New.
	(go32_target): Install it.
	* inf-child.c (inf_child_target): Install
	child_terminal_save_inferior, child_pass_ctrlc and
	child_interrupt.
	* inf-ptrace.c (inf_ptrace_interrupt): Delete.
	(inf_ptrace_target): No longer install it.
	* infcmd.c (interrupt_target_1): Adjust.
	* inferior.h (child_terminal_save_inferior, child_pass_ctrlc)
	(child_interrupt): Declare.
	(inferior::terminal_state): New.
	* inflow.c (struct terminal_info): Update comments.
	(inferior_process_group): Delete.
	(terminal_is_ours): Delete.
	(gdb_tty_state): New.
	(child_terminal_init): Adjust.
	(is_gdb_terminal, sharing_input_terminal_1)
	(sharing_input_terminal): New functions.
	(child_terminal_inferior): Adjust.  Use sharing_input_terminal.
	Set the process's actual process group in the foreground if
	possible.  Handle is_ours_for_output/is_ours distinction.  Don't
	mark terminal as the inferior's if not sharing GDB's terminal.
	Don't check attach_flag.
	(child_terminal_ours_for_output, child_terminal_ours): Adjust to
	pass down a target_terminal_state.
	(child_terminal_save_inferior): New, factored out from ...
	(child_terminal_ours_1): ... this.  Handle
	target_terminal_state::is_ours_for_output.
	(child_interrupt, child_pass_ctrlc): New.
	(inflow_inferior_exit): Clear the inferior's terminal_state.
	(copy_terminal_info): Copy the inferior's terminal state.
	(_initialize_inflow): Remove reference to terminal_is_ours.
	* inflow.h (inferior_process_group): Delete.
	* nto-procfs.c (nto_handle_sigint, procfs_interrupt): Adjust.
	* procfs.c (procfs_target): Don't install procfs_interrupt.
	(procfs_interrupt): Delete.
	* remote.c (remote_serial_quit_handler): Adjust.
	(remote_interrupt): Remove ptid parameter.  Adjust.
	* target-delegates.c: Regenerate.
	* target.c: Include "terminal.h".
	(target_terminal::terminal_state): Rename to ...
	(target_terminal::m_terminal_state): ... this.
	(target_terminal::init): Adjust.
	(target_terminal::inferior): Adjust to per-inferior
	terminal_state.
	(target_terminal::restore_inferior, target_terminal_is_ours_kind): New.
	(target_terminal::ours, target_terminal::ours_for_output): Use
	target_terminal_is_ours_kind.
	(target_interrupt): Remove ptid parameter.  Adjust.
	(default_target_pass_ctrlc): Adjust.
	* target.h (target_ops::to_terminal_save_inferior): New field.
	(target_ops::to_interrupt): Remove ptid_t parameter.
	(target_interrupt): Remove ptid_t parameter.  Update comment.
	(target_pass_ctrlc): Update comment.
	* target/target.h (target_terminal_state): New scoped enum,
	factored out of ...
	(target_terminal::terminal_state): ... here.
	(target_terminal::inferior): Update comments.
	(target_terminal::restore_inferior): New.
	(target_terminal::is_inferior, target_terminal::is_ours)
	(target_terminal::is_ours_for_output): Adjust.
	(target_terminal::scoped_restore_terminal_state): Adjust to
	rename, and call restore_inferior() instead of inferior().
	(target_terminal::scoped_restore_terminal_state::m_state): Change
	type.
	(target_terminal::terminal_state): Rename to ...
	(target_terminal::m_terminal_state): ... this and change type.

gdb/gdbserver/ChangeLog:
2018-01-30  Pedro Alves  <palves@redhat.com>

	PR gdb/13211
	* target.c (target_terminal::terminal_state): Rename to ...
	(target_terminal::m_terminal_state): ... this.

gdb/testsuite/ChangeLog:
2018-01-30  Pedro Alves  <palves@redhat.com>

	PR gdb/13211
	* gdb.base/interrupt-daemon.c: New.
	* gdb.base/interrupt-daemon.exp: New.
	* gdb.multi/multi-term-settings.c: New.
	* gdb.multi/multi-term-settings.exp: New.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] linux-nat: Eliminate custom target_terminal_{inferior, ours}, stop using set_sigint_trap
@ 2018-01-30 15:53 sergiodj+buildbot
  2018-01-30 17:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-30 15:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9c3a5d9319648db16b30a91253ad02d41d242cef ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 9c3a5d9319648db16b30a91253ad02d41d242cef

linux-nat: Eliminate custom target_terminal_{inferior,ours}, stop using set_sigint_trap

This patch gets rid of linux-nat.c's custom
target_terminal_inferior/target_terminal_ours implementations.

The only remaining reason those overrides exist is to install
clear_sigint_trap in order to pass Ctrl-C/SIGINT to the inferior
process in case the inferior is not sharing GDB's terminal (and
target_wait was called without TARGET_WNOHANG).

However, I think that's better handled by QUIT / target_pass_ctrlc
nowadays.  Going that route avoids the issue with set_sigint_trap only
looking at the current inferior to know whether to override SIGINT or
not, which doesn't really work correctly with multi-inferior in the
picture.  Also centralizing on a single SIGINT handler as much as
possible seems better considering a future multi-target world.

Tested on x86-64 GNU/Linux.

gdb/ChangeLog:
2018-01-30  Pedro Alves  <palves@redhat.com>

	* linux-nat.c (wait_for_signal): New function.
	(wait_lwp, linux_nat_wait_1): Use it instead of calling sigsuspend
	directly.
	(async_terminal_is_ours)
	(linux_nat_terminal_inferior, linux_nat_terminal_ours): Delete.
	(linux_nat_add_target): Don't override
	to_terminal_inferior/to_terminal_ours.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR22758, FAIL: Run pr22393-2
@ 2018-01-30  8:44 sergiodj+buildbot
  2018-01-30 11:29 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-30  8:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 76cb3a89a6615cf3418fa1efe8268bf6673a5c8a ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 76cb3a89a6615cf3418fa1efe8268bf6673a5c8a

PR22758, FAIL: Run pr22393-2

We can't map different disk pages into the same memory page; The last
page mapped will simply overwrite any previous pages.  The
executable/non-executable new_segment test ignored this fact, leading
to a ld.so segfault on hppa when .dynamic is overwritten with zeros.

This patch moves existing tests for demand paging with lma on the same
memory page, to a new test performed before any case where we want a
new segment due to protection or loadable conflicts.

	PR 22758
	* elf.c (_bfd_elf_map_sections_to_segments): Don't start a new
	segment when demand paged with lma on the same page.  Test this
	before load/non-load, executable/non-executable,
	writable/non-writable tests and simplify.  Delete bogus relro
	condition in writable/non-writable test.  Delete outdated
	comment.  Formatting.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Don't call "detach_inferior" on "remote_follow_fork"
@ 2018-01-29 18:21 sergiodj+buildbot
  2018-01-29 20:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-29 18:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 69ab5edb4d601611ba7b4d05e56689d4b60ca3b1 ***

Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: 69ab5edb4d601611ba7b4d05e56689d4b60ca3b1

Don't call "detach_inferior" on "remote_follow_fork"

This patch fixes a regression that has been introduced by:

  commit bc09b0c14fb713a9aec25e09b78499f3bc2441b5
  Date:   Fri Jan 19 11:48:11 2018 -0500

      Make linux_nat_detach/thread_db_detach use the inferior parameter

It is possible to trigger this failure with gdb.base/foll-fork.exp (in
which case a bunch of ERROR's will be printed), but one can also use
the test below.

Consider the following example program:

  #include <unistd.h>

  int
  main (int argc, char *argv[])
  {
    fork ();

    return 0;
  }

When running it under gdbserver:

  # ./gdb/gdbserver/gdbserver --multi --once :2345

And debugging it under GDB, we see a segmentation fault:

  # ./gdb/gdb -q -batch -ex 'set remote exec-file ./a.out' -ex 'tar extended-remote :2345' -ex r ./a.out
  Starting program:
  ...
  [Detaching after fork from child process 16102.]
  Segmentation fault (core dumped)

The problem happens on inferior.c:detach_inferior:

  void
  detach_inferior (inferior *inf)
  {
    /* Save the pid, since exit_inferior_1 will reset it.  */
    int pid = inf->pid;
              ^^^^^^^^^

    exit_inferior_1 (inf, 0);

    if (print_inferior_events)
      printf_unfiltered (_("[Inferior %d detached]\n"), pid);
  }

When this code is called from remote.c:remote_follow_fork, the PID is
valid but there is no 'inferior' associated with it, which means that
'inf == NULL'.

The proper fix here is to not call "detach_inferior" when doing remote
follow-fork, because we don't have an inferior to detach on the host
side.

Before bc09b0c1, that call was already a nop (exit_inferior_1 bails
out early if you pass it a NULL inferior), except that it printed
"Inferior PID detached" when "set print inferior-events" is on.  Since
native debugging doesn't call detach_inferior in this case, removing
the call from remote aligns remote debugging output with native
debugging output further.

This has been regtested using BuildBot and no regressions were found.

gdb/ChangeLog:
2018-01-29  Sergio Durigan Junior  <sergiodj@redhat.com>

	* remote.c (remote_follow_fork): Don't call "detach_inferior".


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Prevent patch remnants from being included in release tarballs.
@ 2018-01-29 13:45 sergiodj+buildbot
  2018-01-29 15:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-29 13:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b431b4ea88c8cc1b75edc4aeaa592942a905c18f ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: b431b4ea88c8cc1b75edc4aeaa592942a905c18f

Prevent patch remnants from being included in release tarballs.

	* src-release.sh (do_proto_toplev): Strip patch remnant files from
	the sources before creating the tarball.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove dwarf2_per_objfile_free and use after free of dwarf2_per_objfile
@ 2018-01-28 17:24 sergiodj+buildbot
  2018-01-28 18:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-28 17:24 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fc8e7e75c2be02237a7961688b06869814f36a18 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: fc8e7e75c2be02237a7961688b06869814f36a18

Remove dwarf2_per_objfile_free and use after free of dwarf2_per_objfile

I got some crashes while doing some work with dwarf2_per_objfile.  It
turns out that dwarf2_per_objfile_free is using the dwarf2_per_objfile
objects after their destructor has ran.

The easiest way to reproduce this is to run the inferior twice (do
"start" twice).  Currently, it goes unnoticed, but when I tried to
change all_comp_units and all_type_units to std::vectors, things started
crashing.

The dwarf2_per_objfile objects get destroyed here:

 #0  dwarf2_per_objfile::~dwarf2_per_objfile (this=0x35afe70, __in_chrg=<optimized out>) at /home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:2422
 #1  0x0000000000833282 in dwarf2_free_objfile (objfile=0x356cff0) at /home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:25363
 #2  0x0000000000699255 in elf_symfile_finish (objfile=0x356cff0) at /home/emaisin/src/binutils-gdb/gdb/elfread.c:1309
 #3  0x0000000000911ed3 in objfile::~objfile (this=0x356cff0, __in_chrg=<optimized out>) at /home/emaisin/src/binutils-gdb/gdb/objfiles.c:674

and just after that the dwarf2read per-objfile registry cleanup function
gets called:

 #0  dwarf2_per_objfile_free (objfile=0x356cff0, d=0x35afe70) at /home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:25667
 ... registry boilerplate ...
 #4  0x00000000009103ea in objfile_free_data (container=0x356cff0) at /home/emaisin/src/binutils-gdb/gdb/objfiles.c:61
 #5  0x0000000000911ee2 in objfile::~objfile (this=0x356cff0, __in_chrg=<optimized out>) at /home/emaisin/src/binutils-gdb/gdb/objfiles.c:678

In dwarf2_per_objfile_free, we access fields of the dwarf2_per_objfile
object, which is invalid since its destructor has been executed.

This patch moves the content of dwarf2_per_objfile_free to the
destructor of dwarf2_per_objfile.  The call to
register_objfile_data_with_cleanup in _initialize_dwarf2_read can be
changed to the simpler register_objfile_data.

gdb/ChangeLog:

	* dwarf2read.c (free_dwo_files): Add forward-declaration.
	(dwarf2_per_objfile::~dwarf2_per_objfile): Move content from
	dwarf2_per_objfile_free here.
	(dwarf2_per_objfile_free): Remove.
	(_initialize_dwarf2_read): Don't register
	dwarf2_per_objfile_free as a registry cleanup.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Avoid compilation errors in MinGW native builds of GDB
@ 2018-01-27 17:07 sergiodj+buildbot
  2018-01-27 21:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-27 17:07 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b2a426e2c5632644b6b8bc0dde4cd32d42d548e2 ***

Author: Eli Zaretskii <eliz@gnu.org>
Branch: master
Commit: b2a426e2c5632644b6b8bc0dde4cd32d42d548e2

Avoid compilation errors in MinGW native builds of GDB

The error is triggered by including python-internal.h, and the
error message is:

     In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0,
	      from build-gnulib/import/math.h:27,
	      from d:/usr/Python26/include/pyport.h:235,
	      from d:/usr/Python26/include/Python.h:58,
	      from python/python-internal.h:94,
	      from python/py-arch.c:24:
     d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared
        using ::hypot;
	        ^~~~~

This happens because Python headers define 'hypot' to expand to
'_hypot' in the Windows builds.

gdb/ChangeLog:
2018-01-27  Eli Zaretskii  <eliz@gnu.org>

	* python/python-internal.h (_hypot) [__MINGW32__]: Define back to
	'hypoth'.  This avoids a compilation error.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add myself as a write-after-approval GDB maintainer.
@ 2018-01-26 15:05 sergiodj+buildbot
  2018-01-26 16:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-26 15:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 56ae9dc397bdf08c4e8f1ef0b64f4320bf88ba3e ***

Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: 56ae9dc397bdf08c4e8f1ef0b64f4320bf88ba3e

Add myself as a write-after-approval GDB maintainer.

gdb/
    * MAINTAINERS (Write After Approval): Add Alan Hayward.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Define __start/__stop symbols when there is only a dynamic def
@ 2018-01-26  6:02 sergiodj+buildbot
  2018-01-26  9:03 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-26  6:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 32253bb7963ac7caa166ec41e336372f2ffc03d4 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 32253bb7963ac7caa166ec41e336372f2ffc03d4

Define __start/__stop symbols when there is only a dynamic def

This patch fixes a case where a user had a C-representable named
section in both the executable and shared libraries, and of course
wanted the size of the local section in the executable, not the
dynamic section.  It does mean that __start and __stop symbols don't
behave exactly like PROVIDEd symbols, but I think that's a reasonable
difference particularly since this is the way they used to behave.

	* elflink.c (bfd_elf_define_start_stop): Override symbols when
	they are defined dynamically.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PowerPC64 .branch_lt size change leads to "stubs don't match calculated size"
@ 2018-01-26  5:34 sergiodj+buildbot
  2018-01-26  6:58 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-26  5:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ba21f5646454c418e75eb06f6bf1a00a173641ca ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: ba21f5646454c418e75eb06f6bf1a00a173641ca

PowerPC64 .branch_lt size change leads to "stubs don't match calculated size"

https://bugzilla.redhat.com/show_bug.cgi?id=1523457

I haven't analyzed this myself, I'm relying on Nick's excellent
analysis.  What I believe is happening is that after some number of
stub sizing iterations, a long-branch stub needs to be converted to a
plt-branch, but either due to stub alignment or other stubs shrinking
in size, the stub group section size doesn't change.

That means we exit from ppc64_elf_size_stubs after sizing with an
incorrect layout, in fact the additional .branch_lt entry overlays
.got!  Since .TOC. is normally set to .got + 0x8000 the stub sizing
code decides that entry is within +/-32k of the TOC pointer and so a
three insn stub is sufficient.  When we come to build the stubs using
a correct non-overlaying layout, a four insn plt-branch stub is
generated and the stub group size doesn't match that calculated
earlier.

	* elf64-ppc.c (ppc64_elf_size_stubs): Iterate sizing when
	.branch_lt changes size.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR22746, crash when running 32-bit objdump on corrupted file
@ 2018-01-25 11:50 sergiodj+buildbot
  2018-01-25 15:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-25 11:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 38e64b0ecc7f4ee64a02514b8d532782ac057fa2 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 38e64b0ecc7f4ee64a02514b8d532782ac057fa2

PR22746, crash when running 32-bit objdump on corrupted file

Avoid unsigned int overflow by performing bfd_size_type multiplication.

	PR 22746
	* elfcode.h (elf_object_p): Avoid integer overflow.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix PR ld/22727 (TLS breakage in PIC/PIE mode on SPARC).
@ 2018-01-25 11:35 sergiodj+buildbot
  2018-01-25 13:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-25 11:35 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bb363086e7743506d78bc6b1e56face0fb1fc93f ***

Author: Eric Botcazou <ebotcazou@gcc.gnu.org>
Branch: master
Commit: bb363086e7743506d78bc6b1e56face0fb1fc93f

Fix PR ld/22727 (TLS breakage in PIC/PIE mode on SPARC).

There are actually 2 different bugs:
 1. TLS transition is broken in PIE mode.
 2. TLS is broken in PIC/PIE mode when the __tls_get_addr symbol
    is versioned  (as is the case on Linux and Solaris at least).

The 1st bug is fixed by reverting the problematic change for now
(note that the associated test doesn't pass on SPARC because of another
issue so there is  no formal regression in the testsuite). The 2nd bug
is fixed by changing the  call to _bfd_generic_link_add_one_symbol
on __tls_get_addr into a mere lookup in _bfd_sparc_elf_check_relocs.

bfd/
	* elfxx-sparc.c (_bfd_sparc_elf_check_relocs) <R_SPARC_TLS_GD_CALL>:
	Do a mere lookup of the __tls_get_addr symbol instead of adding it.

	Revert
	2017-10-19  H.J. Lu  <hongjiu.lu@intel.com>

	PR ld/22263
	* elfxx-sparc.c (sparc_elf_tls_transition): Replace
	bfd_link_pic with !bfd_link_executable, !bfd_link_pic with
	bfd_link_executable for TLS check.
	(_bfd_sparc_elf_check_relocs): Likewise.
	(allocate_dynrelocs): Likewise.
	(_bfd_sparc_elf_relocate_section): Likewise.
ld/
	* testsuite/ld-sparc/sparc.exp (32-bit: Helper shared library):
	Link with a version script.
	(32-bit: TLS -fpie): New test.
	(64-bit: Helper shared library): Link with a version script.
	(64-bit: TLS -fpie): New test.
	(64-bit: GOTDATA relocations): Pass -Av9 to the assembler.
	* testsuite/ld-sparc/tlslib.ver: New file.
	* testsuite/ld-sparc/tlspie32.dd: Likewise.
	* testsuite/ld-sparc/tlspie32.s: Likewise.
	* testsuite/ld-sparc/tlspie64.dd: Likewise.
	* testsuite/ld-sparc/tlspie64.s: Likewise.
	* testsuite/ld-sparc/tlssunbin32.dd: Adjust for versioned symbol.
	* testsuite/ld-sparc/tlssunbin32.rd: Likewise.
	* testsuite/ld-sparc/tlssunbin32.sd: Likewise.
	* testsuite/ld-sparc/tlssunbin64.dd: Likewise.
	* testsuite/ld-sparc/tlssunbin64.rd: Likewise.
	* testsuite/ld-sparc/tlssunbin64.sd: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix GCC PR83906 - [8 Regression] Random FAIL: libstdc++-prettyprinters/80276.cc whatis p4
@ 2018-01-24 18:49 sergiodj+buildbot
  2018-01-25  1:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-24 18:49 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0f59d5fc1ce646348dfae3ca90b32f9228d1d514 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 0f59d5fc1ce646348dfae3ca90b32f9228d1d514

Fix GCC PR83906 - [8 Regression] Random FAIL: libstdc++-prettyprinters/80276.cc whatis p4

GCC PR83906 [1] is about a GCC/libstdc++ GDB/Python type printer
testcase failing randomly, as shown by running (in libstdc++'s
testsuite):

 make check RUNTESTFLAGS=prettyprinters.exp=80276.cc

in a loop.  Sometimes you get this:

 FAIL: libstdc++-prettyprinters/80276.cc whatis p4

I.e., this:
 type = std::unique_ptr<std::vector<std::unique_ptr<std::list<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >>[]>>[99]>

instead of this:
 type = std::unique_ptr<std::vector<std::unique_ptr<std::list<std::string>[]>>[99]>

Jonathan Wakely tracked it on the printer side to this bit in
libstdc++'s type printer:

            if self.type_obj == type_obj:
                return strip_inline_namespaces(self.name)

This assumes the two types resolve to the same gdb.Type but some times
the comparison unexpectedly fails.

Running the testcase manually under Valgrind finds the problem in GDB:

 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 ==6118== Conditional jump or move depends on uninitialised value(s)
 ==6118==    at 0x4C35CB0: bcmp (vg_replace_strmem.c:1100)
 ==6118==    by 0x6F773A: check_types_equal(type*, type*, VEC_type_equality_entry_d**) (gdbtypes.c:3515)
 ==6118==    by 0x6F7B00: check_types_worklist(VEC_type_equality_entry_d**, bcache*) (gdbtypes.c:3618)
 ==6118==    by 0x6F7C03: types_deeply_equal(type*, type*) (gdbtypes.c:3655)
 ==6118==    by 0x4D5B06: typy_richcompare(_object*, _object*, int) (py-type.c:1007)
 ==6118==    by 0x63D7E6C: PyObject_RichCompare (object.c:961)
 ==6118==    by 0x646EAEC: PyEval_EvalFrameEx (ceval.c:4960)
 ==6118==    by 0x646DC08: PyEval_EvalFrameEx (ceval.c:4519)
 ==6118==    by 0x646DC08: PyEval_EvalFrameEx (ceval.c:4519)
 ==6118==    by 0x646DC08: PyEval_EvalFrameEx (ceval.c:4519)
 ==6118==    by 0x646DC08: PyEval_EvalFrameEx (ceval.c:4519)
 ==6118==    by 0x646DC08: PyEval_EvalFrameEx (ceval.c:4519)
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~

That "bcmp" call is really a memcmp call in check_types_equal.  The
problem is that gdb is memcmp'ing two objects that are equal in value:

 (top-gdb) p *TYPE_RANGE_DATA (type1)
 $1 = {low = {kind = PROP_CONST, data = {const_val = 0, baton = 0x0}}, high = {kind = PROP_CONST, data = {const_val = 15, baton = 0xf}}, flag_upper_bound_is_count = 0,
   flag_bound_evaluated = 0}
 (top-gdb) p *TYPE_RANGE_DATA (type2)
 $2 = {low = {kind = PROP_CONST, data = {const_val = 0, baton = 0x0}}, high = {kind = PROP_CONST, data = {const_val = 15, baton = 0xf}}, flag_upper_bound_is_count = 0,
   flag_bound_evaluated = 0}

but differ in padding.  Notice the 4-byte hole:

  (top-gdb) ptype /o range_bounds
  /* offset    |  size */  type = struct range_bounds {
  /*    0      |    16 */    struct dynamic_prop {
  /*    0      |     4 */        dynamic_prop_kind kind;
  /* XXX  4-byte hole  */
  /*    8      |     8 */        union dynamic_prop_data {
  /*                 8 */            LONGEST const_val;
  /*                 8 */            void *baton;

				     /* total size (bytes):    8 */
				 } data;

which is filled with garbage:

  (top-gdb) x /40bx TYPE_RANGE_DATA (type1)
  0x2fa7ea0:      0x01    0x00    0x00    0x00    0x43    0x01    0x00    0x00
						  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  0x2fa7ea8:      0x00    0x00    0x00    0x00    0x00    0x00    0x00    0x00
  0x2fa7eb0:      0x01    0x00    0x00    0x00    0xfe    0x7f    0x00    0x00
  0x2fa7eb8:      0x0f    0x00    0x00    0x00    0x00    0x00    0x00    0x00
  0x2fa7ec0:      0x00    0x00    0x00    0x00    0x00    0x00    0x00    0x00
  (top-gdb) x /40bx TYPE_RANGE_DATA (type2)
  0x20379b0:      0x01    0x00    0x00    0x00    0xfe    0x7f    0x00    0x00
						  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  0x20379b8:      0x00    0x00    0x00    0x00    0x00    0x00    0x00    0x00
  0x20379c0:      0x01    0x00    0x00    0x00    0xfe    0x7f    0x00    0x00
  0x20379c8:      0x0f    0x00    0x00    0x00    0x00    0x00    0x00    0x00
  0x20379d0:      0x00    0x00    0x00    0x00    0x00    0x00    0x00    0x00

  (top-gdb) p memcmp (TYPE_RANGE_DATA (type1), TYPE_RANGE_DATA (type2), sizeof (*TYPE_RANGE_DATA (type1)))
  $3 = -187

In some cases objects of type range_bounds are memset when allocated,
but then their dynamic_prop low/high fields are copied over from some
template dynamic_prop object that wasn't memset.  E.g.,
create_static_range_type's low/high locals are left with garbage in
the padding, and then that padding is copied over to the range_bounds
object's low/high fields.

At first, I considered making sure to always memset range_bounds
objects, thinking that maybe type objects are being put in some bcache
instance somewhere.  But then I hacked bcache/bcache_full to poison
non-pod types, and made dynamic_prop a non-pod, and GDB still
compiled.

So given that, it seems safest to not assume padding will always be
memset, and instead treat them as regular value types, implementing
(in)equality operators and using those instead of memcmp.

This fixes the random FAILs in GCC's testcase.

[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83906

gdb/ChangeLog:
2018-01-24  Pedro Alves  <palves@redhat.com>

	GCC PR libstdc++/83906
	* gdbtypes.c (operator==(const dynamic_prop &,
	const dynamic_prop &)): New.
	(operator==(const range_bounds &, const range_bounds &)): New.
	(check_types_equal): Use them instead of memcmp.
	* gdbtypes.h (operator==(const dynamic_prop &,
	const dynamic_prop &)): Declare.
	(operator!=(const dynamic_prop &, const dynamic_prop &)): Declare.
	(operator==(const range_bounds &, const range_bounds &)): Declare.
	(operator!=(const range_bounds &, const range_bounds &)): Declare.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [LD][AARCH64]Add group relocations to create PC-relative offset.
@ 2018-01-24 16:51 sergiodj+buildbot
  2018-01-24 23:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-24 16:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1daf502a16e052b55a28bd52b4fde185ccc3b27b ***

Author: Renlin Li <renlin.li@arm.com>
Branch: master
Commit: 1daf502a16e052b55a28bd52b4fde185ccc3b27b

[LD][AARCH64]Add group relocations to create PC-relative offset.

This is a patch to add linker support for group relocations to create a
16, 32, 48, or 64 bit PC-relative offset inline.

The following relocations are added along with the test cases:
BFD_RELOC_AARCH64_MOVW_PREL_G0, BFD_RELOC_AARCH64_MOVW_PREL_G0_NC,
BFD_RELOC_AARCH64_MOVW_PREL_G1, BFD_RELOC_AARCH64_MOVW_PREL_G1_NC,
BFD_RELOC_AARCH64_MOVW_PREL_G2, BFD_RELOC_AARCH64_MOVW_PREL_G2_NC,
BFD_RELOC_AARCH64_MOVW_PREL_G3.

bfd/

2018-01-24  Renlin Li  <renlin.li@arm.com>

	* elfnn-aarch64.c (elfNN_aarch64_final_link_relocate): Add support for
	BFD_RELOC_AARCH64_MOVW_PREL_G0, BFD_RELOC_AARCH64_MOVW_PREL_G0_NC,
	BFD_RELOC_AARCH64_MOVW_PREL_G1, BFD_RELOC_AARCH64_MOVW_PREL_G1_NC,
	BFD_RELOC_AARCH64_MOVW_PREL_G2, BFD_RELOC_AARCH64_MOVW_PREL_G2_NC,
	BFD_RELOC_AARCH64_MOVW_PREL_G3.
	* elfxx-aarch64.c (_bfd_aarch64_elf_put_addend): Likewise.
	(_bfd_aarch64_elf_resolve_relocation): Likewise.

ld/

2018-01-24  Renlin Li  <renlin.li@arm.com>

	* testsuite/ld-aarch64/aarch64-elf.exp: Run new testes.
	* testsuite/ld-aarch64/emit-relocs-287.s: Fix test case.
	* testsuite/ld-aarch64/emit-relocs-287.d: Fix expected output.
	* testsuite/ld-aarch64/emit-relocs-287-overflow.s: New.
	* testsuite/ld-aarch64/emit-relocs-287-overflow.d: New.
	* testsuite/ld-aarch64/emit-relocs-288.d: New.
	* testsuite/ld-aarch64/emit-relocs-288.s: New.
	* testsuite/ld-aarch64/emit-relocs-289.d: New.
	* testsuite/ld-aarch64/emit-relocs-289.s: New.
	* testsuite/ld-aarch64/emit-relocs-289-overflow.s: New.
	* testsuite/ld-aarch64/emit-relocs-289-overflow.d: New.
	* testsuite/ld-aarch64/emit-relocs-290.d: New.
	* testsuite/ld-aarch64/emit-relocs-290.s: New.
	* testsuite/ld-aarch64/emit-relocs-291.d: New.
	* testsuite/ld-aarch64/emit-relocs-291.s: New.
	* testsuite/ld-aarch64/emit-relocs-291-overflow.s: New.
	* testsuite/ld-aarch64/emit-relocs-291-overflow.d: New.
	* testsuite/ld-aarch64/emit-relocs-292.d: New.
	* testsuite/ld-aarch64/emit-relocs-292.s: New.
	* testsuite/ld-aarch64/emit-relocs-293.d: New.
	* testsuite/ld-aarch64/emit-relocs-293.s: New.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [GAS][AARCH64]Add group relocations to create PC-relative offset.
@ 2018-01-24 16:36 sergiodj+buildbot
  2018-01-24 20:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-24 16:36 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 322474019df79a1305e83ff7620a72f31a5c7b55 ***

Author: Renlin Li <renlin.li@arm.com>
Branch: master
Commit: 322474019df79a1305e83ff7620a72f31a5c7b55

[GAS][AARCH64]Add group relocations to create PC-relative offset.

This is a patch to add the gas support for group relocations to create a
16, 32, 48, or 64 bit PC-relative offset inline.

The following relocations are added along with the test cases:
BFD_RELOC_AARCH64_MOVW_PREL_G0, BFD_RELOC_AARCH64_MOVW_PREL_G0_NC,
BFD_RELOC_AARCH64_MOVW_PREL_G1, BFD_RELOC_AARCH64_MOVW_PREL_G1_NC,
BFD_RELOC_AARCH64_MOVW_PREL_G2, BFD_RELOC_AARCH64_MOVW_PREL_G2_NC,
BFD_RELOC_AARCH64_MOVW_PREL_G3.

bfd/

2018-01-24  Renlin Li  <renlin.li@arm.com>

	* reloc.c: Add BFD_RELOC_AARCH64_MOVW_PREL_G0,
	BFD_RELOC_AARCH64_MOVW_PREL_G0_NC, BFD_RELOC_AARCH64_MOVW_PREL_G1,
	BFD_RELOC_AARCH64_MOVW_PREL_G1_NC, BFD_RELOC_AARCH64_MOVW_PREL_G2,
	BFD_RELOC_AARCH64_MOVW_PREL_G2_NC, BFD_RELOC_AARCH64_MOVW_PREL_G3.
	* bfd-in2.h: Regenerate.
	* libbfd.h: Regenerate.
	* elfnn-aarch64.c (elfNN_aarch64_howto_table): Add entries for
	BFD_RELOC_AARCH64_MOVW_PREL_G0, BFD_RELOC_AARCH64_MOVW_PREL_G0_NC,
	BFD_RELOC_AARCH64_MOVW_PREL_G1, BFD_RELOC_AARCH64_MOVW_PREL_G1_NC,
	BFD_RELOC_AARCH64_MOVW_PREL_G2, BFD_RELOC_AARCH64_MOVW_PREL_G2_NC,
	BFD_RELOC_AARCH64_MOVW_PREL_G3.

gas/

2018-01-24  Renlin Li  <renlin.li@arm.com>

	* config/tc-aarch64.c (reloc_table): add entries for
	BFD_RELOC_AARCH64_MOVW_PREL_G0, BFD_RELOC_AARCH64_MOVW_PREL_G0_NC,
	BFD_RELOC_AARCH64_MOVW_PREL_G1, BFD_RELOC_AARCH64_MOVW_PREL_G1_NC,
	BFD_RELOC_AARCH64_MOVW_PREL_G2, BFD_RELOC_AARCH64_MOVW_PREL_G2_NC,
	BFD_RELOC_AARCH64_MOVW_PREL_G3.
	(process_movw_reloc_info): Supports newly added MOVW_PREL relocations.
	(md_apply_fix): Likewise
	* testsuite/gas/aarch64/prel_g0.s: New.
	* testsuite/gas/aarch64/prel_g0.d: New.
	* testsuite/gas/aarch64/prel_g0_nc.s: New.
	* testsuite/gas/aarch64/prel_g0_nc.d: New.
	* testsuite/gas/aarch64/prel_g1.s: New.
	* testsuite/gas/aarch64/prel_g1.d: New.
	* testsuite/gas/aarch64/prel_g1_nc.s: New.
	* testsuite/gas/aarch64/prel_g1_nc.d: New.
	* testsuite/gas/aarch64/prel_g2.s: New.
	* testsuite/gas/aarch64/prel_g2.d: New.
	* testsuite/gas/aarch64/prel_g2_nc.s: New.
	* testsuite/gas/aarch64/prel_g2_nc.d: New.
	* testsuite/gas/aarch64/prel_g3.s: New.
	* testsuite/gas/aarch64/prel_g3.d: New.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] MIPS/BFD: Update a stale `mips_elf32_section_processing' reference
@ 2018-01-23 19:18 sergiodj+buildbot
  2018-01-24 17:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 19:18 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1c5e4ee9ab4c173aca017d488cc074ef66562a12 ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: 1c5e4ee9ab4c173aca017d488cc074ef66562a12

MIPS/BFD: Update a stale `mips_elf32_section_processing' reference

Update a stale reference to `mips_elf32_section_processing', following a
merge of the function into `_bfd_mips_elf_section_processing' made with
commit 103186c62b99 ("PATCH for MIPS 64-bit ABI suport"),
<https://sourceware.org/ml/binutils/1999-q3/msg00072.html>.

	bfd/
	* elfxx-mips.c (_bfd_mips_elf_final_link): Update a stale
	`mips_elf32_section_processing' comment reference.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Enable Intel PCONFIG instruction.
@ 2018-01-23 17:39 sergiodj+buildbot
  2018-01-24 14:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 17:39 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT be3a8dca2d7241878302ca55f45129d532b6f746 ***

Author: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
Branch: master
Commit: be3a8dca2d7241878302ca55f45129d532b6f746

Enable Intel PCONFIG instruction.

Intel has disclosed a set of new instructions for Icelake processor.
The spec is
https://software.intel.com/sites/default/files/managed/c5/15/architecture-instruction-set-extensions-programming-reference.pdf

This patch enables Intel PCONFIG instruction.

gas/
	* config/tc-i386.c (cpu_arch): Add .pconfig.
	* doc/c-i386.texi: Document .pconfig.
	* testsuite/gas/i386/i386.exp: Add PCONFIG tests.
	* testsuite/gas/i386/pconfig-intel.d: New test.
	* testsuite/gas/i386/pconfig.d: Likewise.
	* testsuite/gas/i386/pconfig.s: Likewise.
	* testsuite/gas/i386/x86-64-pconfig-intel.d: Likewise.
	* testsuite/gas/i386/x86-64-pconfig.d: Likewise.
	* testsuite/gas/i386/x86-64-pconfig.s: Likewise.
opcodes/
	* i386-dis.c (enum): Add pconfig.
	* i386-gen.c (cpu_flag_init): Add CPU_PCONFIG_FLAGS.
	(cpu_flags): Add CpuPCONFIG.
	* i386-opc.h (enum): Add CpuPCONFIG.
	(i386_cpu_flags): Add cpupconfig.
	* i386-opc.tbl: Add PCONFIG instruction.
	* i386-init.h: Regenerate.
	* i386-tbl.h: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Enable Intel WBNOINVD instruction.
@ 2018-01-23 17:26 sergiodj+buildbot
  2018-01-24 12:11 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 17:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3233d7d074e59b83f68a22071cff597f00d5ae81 ***

Author: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
Branch: master
Commit: 3233d7d074e59b83f68a22071cff597f00d5ae81

Enable Intel WBNOINVD instruction.

Intel has disclosed a set of new instructions for Icelake processor.
The spec is
https://software.intel.com/sites/default/files/managed/c5/15/architecture-instruction-set-extensions-programming-reference.pdf

This patch enables Intel WBNOINVD instruction.

gas/
	* config/tc-i386.c (cpu_arch): Add .wbnoinvd.
	* doc/c-i386.texi: Document .wbnoinvd.
	* testsuite/gas/i386/i386.exp: Add WBNOINVD tests.
	* testsuite/gas/i386/wbnoinvd-intel.d: New test.
	* testsuite/gas/i386/wbnoinvd.d: Likewise.
	* testsuite/gas/i386/wbnoinvd.s: Likewise.
	* testsuite/gas/i386/x86-64-wbnoinvd-intel.d: Likewise.
	* testsuite/gas/i386/x86-64-wbnoinvd.d: Likewise.
	* testsuite/gas/i386/x86-64-wbnoinvd.s: Likewise.
opcodes/
	* i386-dis.c (enum): Add PREFIX_0F09.
	* i386-gen.c (cpu_flag_init): Add CPU_WBNOINVD_FLAGS.
	(cpu_flags): Add CpuWBNOINVD.
	* i386-opc.h (enum): Add CpuWBNOINVD.
	(i386_cpu_flags): Add cpuwbnoinvd.
	* i386-opc.tbl: Add WBNOINVD instruction.
	* i386-init.h: Regenerate.
	* i386-tbl.h: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] s390: if -> gdb_assert for tdesc_has_registers check
@ 2018-01-23 17:23 sergiodj+buildbot
  2018-01-23 23:59 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 17:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 650f5e137006fb7aea98e33d2ca9c6ac6712334c ***

Author: Philipp Rudo <prudo@linux.vnet.ibm.com>
Branch: master
Commit: 650f5e137006fb7aea98e33d2ca9c6ac6712334c

s390: if -> gdb_assert for tdesc_has_registers check

Before doing the tdesc validation there is a check whether the tdesc has
registers or not.  This check is not only unnecessary but wrong.

First the check is done after a default tdesc is assigned if the original
tdesc has no registers.  These default tdescs always have registers so the
check alway returns true.

Second if the default tdesc would not have registers the check only skips
the tdesc validation instead of returning an error.  This would trigger a
gdb_assert later on in tdesc_use_registers.

gdb/ChangeLog:

	* s390-linux-tdep.c (s390_gdbarch_init): Use gdb_assert for
	tdesc_has_registers check


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] s390: Move tdesc validation to separate function
@ 2018-01-23 16:25 sergiodj+buildbot
  2018-01-23 22:11 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 16:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 47c9317e71768ba9788c6dc055fb6932d0f0923a ***

Author: Philipp Rudo <prudo@linux.vnet.ibm.com>
Branch: master
Commit: 47c9317e71768ba9788c6dc055fb6932d0f0923a

s390: Move tdesc validation to separate function

Simplify s390_gdbarch_init by moving the target description validation to
a separate function.

gdb/ChangeLog:

	* s390-linux-tdep.c (s390_tdesc_valid): New function.
	(s390_validate_reg_range): New macro.
	(s390_gdbarch_init): Adjust.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] s390: Move record-replay to s390-tdep.c
@ 2018-01-23 15:13 sergiodj+buildbot
  2018-01-24  7:13 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 15:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ef8914a4d7d231fe3590f3e004316613e25f3617 ***

Author: Philipp Rudo <prudo@linux.vnet.ibm.com>
Branch: master
Commit: ef8914a4d7d231fe3590f3e004316613e25f3617

s390: Move record-replay to s390-tdep.c

Record-replay is independent of the OS.  So it can be moved to the common
s390 code without problem.

gdb/ChangeLog:

	* s390-linux-tdep.c (s390_record_address_mask)
	(s390_record_calc_disp_common, s390_record_calc_disp)
	(s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
	(s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
	(s390_process_record): Move to s390-tdep.c.
	(s390_linux_init_abi_any): Adjust.
	* s390-tdep.c (s390_record_address_mask)
	(s390_record_calc_disp_common, s390_record_calc_disp)
	(s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
	(s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
	(s390_process_record): Moved from s390-linux-tdep.c
	(s390_gdbarch_init): Adjust.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] s390: gdbarch_tdep add hook for syscall record
@ 2018-01-23 14:44 sergiodj+buildbot
  2018-01-24  3:48 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 14:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9c0b896ee1d4edfe30c783b027ed5c081845a63d ***

Author: Philipp Rudo <prudo@linux.vnet.ibm.com>
Branch: master
Commit: 9c0b896ee1d4edfe30c783b027ed5c081845a63d

s390: gdbarch_tdep add hook for syscall record

Most parts of s390_process_record are common for the architecture.  Only
the system call handling differs between the OSes.  In order to be able to
move s390_process_record to a common code file add a hook to record
syscalls to gdbarch_tdep.  So every OS can implement their own handling.

gdb/ChangeLog:

	* s390-linux-tdep.c (gdbarch_tdep.s390_syscall_record): New hook.
	(s390_process_record, s390_gdbarch_tdep_alloc)
	(s390_linux_init_abi_any): Use/set new hook.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] s390: gdbarch_tdep.have_* int -> bool
@ 2018-01-23 14:44 sergiodj+buildbot
  2018-01-23 18:57 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 14:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ab9bcc67975f2a04dfa0e670096fc8161d7840b9 ***

Author: Philipp Rudo <prudo@linux.vnet.ibm.com>
Branch: master
Commit: ab9bcc67975f2a04dfa0e670096fc8161d7840b9

s390: gdbarch_tdep.have_* int -> bool

Currently the gdbarch_tdep.have_* flags are a mix of int and bool.  Clean
this up by making them all bool.

gdb/ChangeLog:

	* s390-linux-tdep.c (gdbarch_tdep) <have_linux_v1, have_linux_v2>
	<have_tdb>: Change type to bool.
	(s390_gdbarch_tdep_alloc): Adjust.
	(s390_gdbarch_init): Adjust.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] s390: Hook s390 into OSABI mechanism
@ 2018-01-23 14:30 sergiodj+buildbot
  2018-01-24  1:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 14:30 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7042632bf7976d29889ba89fe4867654c5f38e2d ***

Author: Philipp Rudo <prudo@linux.vnet.ibm.com>
Branch: master
Commit: 7042632bf7976d29889ba89fe4867654c5f38e2d

s390: Hook s390 into OSABI mechanism

Do what the title says and distinguish between 31- and 64-bit systems.
The goal is to init the OSABI as late as possible in gdbarch_init so the
OSABI has the chance to overwrite the defaults.

There are two pitfalls to be aware of:

First, the dwarf2 unwinder must be appended before the OSABI is
initialized.  Otherwise the OS could add a default unwinder which always
takes control before the dwarf unwinder even gets a chance.

Second, tdesc_use_registers has to be handled with extra care.  It sets
several gdbarch hooks, especially gdbarch_register_name, which has to be
overwritten again after the call.  Furthermore it deletes the tdesc_data
without checking.  Therefore there must not be a call to
tdesc_data_cleanup afterwards or GDB will crash with a double free.

gdb/ChangeLog:

	* s390-linux-tdep.c (osabi.h): New include.
	(s390_linux_init_abi_31, s390_linux_init_abi_64)
	(s390_linux_init_abi_any): New functions.
	(s390_gdbarch_init, _initialize_s390_tdep): Adjust.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] s390: Allocate gdbarch & tdep at start of gdbarch_init
@ 2018-01-23 13:15 sergiodj+buildbot
  2018-01-23 16:22 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-23 13:15 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 21f6f5ffc652e116e518fee29ebdc8fbfeeaa734 ***

Author: Philipp Rudo <prudo@linux.vnet.ibm.com>
Branch: master
Commit: 21f6f5ffc652e116e518fee29ebdc8fbfeeaa734

s390: Allocate gdbarch & tdep at start of gdbarch_init

Moving the allocation of gdbarch_tdep to the start of s390_gdbarch_init
allows us to use its fields for tracking the different features instead of
using separate variables.  To make the code a little nicer move the actual
allocation and initialization to a separate function.  Also move the
allocation of gdbarch to keep the two together.

gdb/ChangeLog:

	* s390-linux-tdep (s390_abi_kind) <ABI_NONE>: New default field.
	(gdbarch_tdep) <have_upper, have_vx>: New fields.
	(s390_gdbarch_tdep_alloc): New function.
	(s390_gdbarch_init): Allocate tdep at start and use its fields
	instead of separate variables.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] MAINTAINERS: Update my company e-mail address
@ 2018-01-22 15:56 sergiodj+buildbot
  2018-01-23  2:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-22 15:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d65ce302abcb260e14ca5f201b78e8e6d4a2e720 ***

Author: Maciej W. Rozycki <macro@mips.com>
Branch: master
Commit: d65ce302abcb260e14ca5f201b78e8e6d4a2e720

MAINTAINERS: Update my company e-mail address

Following my recent transition from Imagination Technologies to the
reincarnated MIPS company update MAINTAINERS entries accordingly.

	binutils/
	* MAINTAINERS: Update my company e-mail address.

	gdb/
	* MAINTAINERS: Update my company e-mail address.

	sim/
	* MAINTAINERS: Update my company e-mail address.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] regcache_cooked_read -> regcache->cooked_read
@ 2018-01-22 13:34 sergiodj+buildbot
  2018-01-22 22:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-22 13:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 11f57cb67ecf5c69911eff21b54e05e93bbf2734 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 11f57cb67ecf5c69911eff21b54e05e93bbf2734

regcache_cooked_read -> regcache->cooked_read

Similarly, this patch replaces regcache_cooked_read with
regcache->cooked_read.

gdb:

2018-01-22  Yao Qi  <yao.qi@linaro.org>

	* ia64-tdep.c (ia64_pseudo_register_read): Call
	regcache->cooked_read instead of regcache_cooked_read_unsigned.
	* m32c-tdep.c (m32c_cat_read): Likewise.
	(m32c_r3r2r1r0_read): Likewise.
	* m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
	* xtensa-tdep.c (xtensa_register_read_masked): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove mt port
@ 2018-01-22 12:07 sergiodj+buildbot
  2018-01-22 16:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-22 12:07 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT dc71152484248c0d8075618ec2146db4ea173b12 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: dc71152484248c0d8075618ec2146db4ea173b12

Remove mt port

This patch removes the MT port.  The removal was annoucned
https://sourceware.org/ml/gdb-announce/2017/msg00006.html
I'll remove MT from the top-level configure later.

gdb:

2018-01-22  Yao Qi  <yao.qi@linaro.org>

	* Makefile.in (ALL_TARGET_OBS): Remove mt-tdep.o.
	* configure.tgt: Remove target mt.
	* mt-tdep.c: Remove.
	* regcache.c (cooked_read_test): Remove the check for mt.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Replace regcache_raw_read with regcache->raw_read
@ 2018-01-22 11:47 sergiodj+buildbot
  2018-01-22 18:58 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-22 11:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 03f50fc878f75fcdebf0e3273f201fb4b62b0bae ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 03f50fc878f75fcdebf0e3273f201fb4b62b0bae

Replace regcache_raw_read with regcache->raw_read

The patch later in this series will move regcache's raw_read and
cooked_read methods to a new class regcache_read, and regcache is
dervied from it.  Also pass regcache_read instead of regcache to gdbarch
methods pseudo_register_read and pseudo_register_read_value.  In order
to prepare for this change, this patch changes regcache_raw_read to
regcache->raw_read.  On the other hand, since we are in C++, I prefer
using class method (regcache->raw_read).

gdb:

2018-01-22  Yao Qi  <yao.qi@linaro.org>

	* aarch64-tdep.c (aarch64_pseudo_read_value): Call regcache
	method raw_read instead of regcache_raw_read.
	* amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
	* arm-tdep.c (arm_neon_quad_read): Likewise.
	* avr-tdep.c (avr_pseudo_register_read): Likewise.
	* bfin-tdep.c (bfin_pseudo_register_read): Likewise.
	* frv-tdep.c (frv_pseudo_register_read): Likewise.
	* h8300-tdep.c (h8300_pseudo_register_read): Likewise.
	* i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
	(i386_pseudo_register_read_into_value): Likewise.
	* mep-tdep.c (mep_pseudo_cr32_read): Likewise.
	* msp430-tdep.c (msp430_pseudo_register_read): Likewise.
	* nds32-tdep.c (nds32_pseudo_register_read): Likewise.
	* rl78-tdep.c (rl78_pseudo_register_read): Likewise.
	* s390-linux-tdep.c (s390_pseudo_register_read): Likewise.
	* sparc-tdep.c (sparc32_pseudo_register_read):  Likewise.
	* sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
	* spu-tdep.c (spu_pseudo_register_read_spu):  Likewise.
	* xtensa-tdep.c (xtensa_pseudo_register_read): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Ada/DWARF: Assume the Ada compiler produces descriptive type attributes
@ 2018-01-22  5:10 sergiodj+buildbot
  2018-01-22  8:20 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-22  5:10 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT de4cb04a20782b817fc80b49bba83b43cf1cb85d ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: de4cb04a20782b817fc80b49bba83b43cf1cb85d

Ada/DWARF: Assume the Ada compiler produces descriptive type attributes

GCC was enhanced in 2011 to generate this attribute, so I think we can
now assume that it is available when using that compiler. Doing so
allows us to speed up what we call "parallel type" lookups when
processing certain types encoded using the GNAT encoding.

This patch changes need_gnat_info to always expect those attributes
to be generated when the language is Ada. This is an assumption
that on the surfcace looks like it might be a bit on the edge; but
in practice, it should be OK because this is only useful in the
context of handling GNAT-specific encodings. Other Ada compilers
would presumably produce debugging information using pure DWARF
constructs, so would not be impacted by this.

gdb/ChangeLog:

        * dwarf2read.c (need_gnat_info): Return nonzero if the cu's
        language is Ada.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] wrong line number in breakpoint location
@ 2018-01-22  4:32 sergiodj+buildbot
  2018-01-22  6:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-22  4:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a9e408182d2faaed5c2457b68ea3276c719a590f ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: a9e408182d2faaed5c2457b68ea3276c719a590f

wrong line number in breakpoint location

Consider the following situation, where we have one file containing...

    $ cat -n body.inc
         1  i = i + 1;

... we include that file from some code, like so:

    $ cat -n cat -n small.c
        [...]
        17  int
        18  next (int i)
        19  {
        20  #include "body.inc"
        21    return i;
        22  }

When trying to insert a breakpoint on line 18, for instance:

    (gdb) b small.c:18
    Breakpoint 1 at 0x40049f: file body.inc, line 18.
                                                  ^^
                                                  ||

Here, the issue is that GDB reports the breakpoint to be in file
body.inc, which is true, but with the line number that corresponding
to the user-requested location, which is not correct.

Although the simple reproducer may look slightly artificial,
the above is simply one way to reproduce the same issue observed
when trying to insert a breakpoint on a function provided in
a .h files and then subsequently inlined in a C file.

What happens is the following:

  1. We resolve the small.c:18 linespec into a symtab_and_line which
     has "small.c" and 18 as the symtab and line number.

  2. Next, we call skip_prologue_sal, which calculates the PC
     past the prologue, and updates the symtab_and_line: PC,
     but also symtab (now body.inc) and the new line (now 1).

  3. However, right after that, we do:

            /* Make sure the line matches the request, not what was
               found.  */
            intermediate_results.sals[i].line = val.line;

We should either restore both symtab and line, or leave the actual
line to match the actual symtab.  This patch chose the latter.
This introduces a few changes in a few tests, which required some
updates, but looking at those change, I believe them to be expected.

gdb/ChangeLog:

        * linespec.c (create_sals_line_offset): Remove code that preserved
        the symtab_and_line's line number.

gdb/testsuite/ChangeLog:

        * gdb.base/break-include.c, gdb.base/break-include.inc,
        gdb.base/break-include.exp: New files.
        * gdb.base/ending-run.exp: Minor adaptations due to the breakpoint's
        line number now being the actual line number where the breakpoint
        was inserted.
        * gdb.mi/mi-break.exp: Likewise.
        * gdb.mi/mi-reverse.exp: Likewise.
        * gdb.mi/mi-simplerun.exp: Ditto.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdb: Don't store a thread-id for floating varobj
@ 2018-01-21 19:13 sergiodj+buildbot
  2018-01-22  3:30 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-21 19:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e707fc445e68ccfa136a52cd4989b0cb778d1ca7 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: e707fc445e68ccfa136a52cd4989b0cb778d1ca7

gdb: Don't store a thread-id for floating varobj

When creating a varobj with -var-create a user can create either fixed
varobj, or floating varobj.

A fixed varobj will always be evaluated within the thread/frame/block in
which the varobj was created, if that thread/frame/block is no longer
available then the varobj is considered out of scope.

A floating varobj will always be evaluated within the current
thread/frame/block.

Despite never using them GDB was storing the thread/frame/block into a
floating varobj, and the thread-id would then be displayed when GDB
reported on the state of the varobj, this could confuse a user into
thinking that the thread-id was relevant.

This commit prevents GDB storing the thread/frame/block onto floating
varobj, and updates the few tests where this impacts the results.

gdb/ChangeLog:

	* varobj.c (varobj_create): Don't set valid_block when creating a
	floating varobj.

gdb/testsuite/ChangeLog:

	* gdb.python/py-mi.exp: Don't expect a thread-id for floating
	varobj.
	* gdb.mi/mi-var-create-rtti.exp: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdb: PR mi/20395: Fix -var-update for registers in frames 1 and up
@ 2018-01-21 17:01 sergiodj+buildbot
  2018-01-21 22:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-21 17:01 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ae45162705fb76ee534336474a67b11373209c62 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: ae45162705fb76ee534336474a67b11373209c62

gdb: PR mi/20395: Fix -var-update for registers in frames 1 and up

This patch fixes a problem with using the MI -var-update command
to access the values of registers in frames other than the current
frame.  The patch includes a test that demonstrates the problem:

* run so there are several frames on the stack
* create a fixed varobj for $pc in each frame, #'s 1 and above
* step one instruction, to modify the value of $pc
* call -var-update for each of the previously created varobjs
  to verify that they are not reported as having changed.

Without the patch, the -var-update command reported that $pc for all
frames 1 and above had changed to the value of $pc in frame 0.

A varobj is created as either fixed, the expression is evaluated within
the context of a specific frame, or floating, the expression is
evaluated within the current frame, whatever that may be.

When a varobj is created by -var-create we set two fields of the varobj
to track the context in which the varobj was created, these two fields
are varobj->root->frame and var->root->valid_block.

If a varobj is of type fixed, then, when we subsequently try to
reevaluate the expression associated with the varobj we must determine
if the original frame (and block) is still available, if it is not then
the varobj can no longer be evaluated.

The problem is that for register expressions varobj->root->valid_block
is not set correctly.  This block tracking is done using the global
'innermost_block' which is set in the various parser files (for example
c-exp.y).  However, this is not set for register expressions.

The fix then seems like it should be to just update the innermost block
when parsing register expressions, however, that solution causes several
test regressions.

The problem is that in some cases we rely on the expression parsing
code not updating the innermost block for registers, one example is
when we parse the expression for a 'display' command.  The display
commands treats registers like floating varobjs, but symbols are
treated like fixed varobjs.  So 'display $reg_name' will always show
the value of '$reg_name' even as the user moves from frame to frame,
while 'display my_variable' will only show 'my_variable' while it is
in the current frame and/or block, when the user moves to a new frame
and/or block (even one with a different 'my_variable' in) then the
display of 'my_variable' stops.  For the case of 'display', without
the option to force fixed or floating expressions, the current
behaviour is probably the best choice.  For the varobj system though,
we can choose between floating and fixed, and we should try to make
this work for registers.

There's only one existing test case that needs to be updated, in that
test a fixed varobj is created using a register, the MI output now
include the thread-id in which the varobj should be evaluated, which I
believe is correct behaviour.  I also added a new floating test case
into the same test script, however, right now this also includes the
thread-id in the expected output, which I believe is an existing gdb
bug, which I plan to fix next.

Tested on x86_64 Linux native and native-gdbserver, no regressions.

gdb/ChangeLog:

	PR mi/20395
	* ada-exp.y (write_var_from_sym): Pass extra parameter when
	updating innermost block.
	* parse.c (innermost_block_tracker::update): Take extra type
	parameter, and check types match before updating innermost block.
	(write_dollar_variable): Update innermost block for registers.
	* parser-defs.h (enum innermost_block_tracker_type): New enum.
	(innermost_block_tracker::innermost_block_tracker): Initialise
	m_types member.
	(innermost_block_tracker::reset): Take type parameter.
	(innermost_block_tracker::update): Take type parameter, and pass
	type through as needed.
	(innermost_block_tracker::m_types): New member.
	* varobj.c (varobj_create): Pass type when reseting innermost
	block.

gdb/testsuite/ChangeLog:

	* gdb.mi/basics.c: Add new global.
	* gdb.mi/mi-frame-regs.exp: New file.
	* gdb.mi/mi-var-create-rtti.exp: Update expected results, add new
	case.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdb: New API for tracking innermost block
@ 2018-01-21 16:50 sergiodj+buildbot
  2018-01-21 20:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-21 16:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT aee1fcdf979d65c7623533ddd6d871767be9de13 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: aee1fcdf979d65c7623533ddd6d871767be9de13

gdb: New API for tracking innermost block

This commit is preparation for a later change, at this point there
should be no user visible change.

We currently maintain a global innermost_block which tracks the most
inner block encountered when parsing an expression.

This commit wraps the innermost_block into a new class, and switches all
direct accesses to the variable to use the class API.

gdb/ChangeLog:

	* ada-exp.y (write_var_from_sym): Switch to innermost_block API.
	* ada-lang.c (resolve_subexp): Likewise.
	* breakpoint.c (set_breakpoint_condition) Likewise.
	(watch_command_1) Likewise.
	* c-exp.y (variable): Likewise.
	* d-exp.y (PrimaryExpression): Likewise.
	* f-exp.y (variable): Likewise.
	* go-exp.y (variable): Likewise.
	* m2-exp.y (variable): Likewise.
	* objfiles.c (objfile::~objfile): Likewise.
	* p-exp.y (variable): Likewise.
	* parse.c (innermost_block): Change type.
	* parser-defs.h (class innermost_block_tracker): New.
	(innermost_block): Change to innermost_block_tracker.
	* printcmd.c (display_command): Switch to innermost_block API.
	(do_one_display): Likewise.
	* rust-exp.y (do_one_display): Likewise.
	* symfile.c (clear_symtab_users): Likewise.
	* varobj.c (varobj_create): Switch to innermost_block API, replace
	use of innermost_block with block stored on varobj object.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdb: Remove out of date comment
@ 2018-01-21 16:42 sergiodj+buildbot
  2018-01-22  0:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-21 16:42 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 03d0bf7b78b142a5e03dfa1c80100893753d0022 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 03d0bf7b78b142a5e03dfa1c80100893753d0022

gdb: Remove out of date comment

Comment clean up.

gdb/ChangeLog:

	* varobj.c (varobj_create): Remove out of date comment.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdb: Remove duplicate declaration of global innermost_block
@ 2018-01-21 16:05 sergiodj+buildbot
  2018-01-21 18:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-21 16:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 396af9a1527b396c251e70b5c79b5fc83fd1d7ff ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 396af9a1527b396c251e70b5c79b5fc83fd1d7ff

gdb: Remove duplicate declaration of global innermost_block

The global 'innermost_block' is declared in two header files.  Remove
one of the declarations, and add an include of the other header into
the one source file that could no longer see a declaration of
'innermost_block'.

gdb/ChangeLog:

	* expression.h (innermost_block): Remove declaration.
	* varobj.c: Add 'parser-defs.h' include.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: Check the versioned __tls_get_addr symbol
@ 2018-01-20 22:46 sergiodj+buildbot
  2018-01-21  1:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-20 22:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8a1b824af786989f879ab1421a4279f60bba141a ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 8a1b824af786989f879ab1421a4279f60bba141a

x86: Check the versioned __tls_get_addr symbol

We need to check the versioned __tls_get_addr symbol when looking up
"__tls_get_addr".

bfd/

	PR ld/22721
	* elfxx-x86.c (_bfd_x86_elf_link_check_relocs): Check the
	versioned __tls_get_addr symbol.

ld/

	PR ld/22721
	* testsuite/ld-plugin/lto.exp: Run PR ld/22721 tests.
	* testsuite/ld-plugin/pr22721.t: New file.
	* testsuite/ld-plugin/pr22721a.s: Likewise.
	* testsuite/ld-plugin/pr22721b.c: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix qualified name lookup for Rust
@ 2018-01-19 22:47 sergiodj+buildbot
  2018-01-20 22:46 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-19 22:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fcfcc376969c4d7a6d20827c47b584db389a32b9 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: fcfcc376969c4d7a6d20827c47b584db389a32b9

Fix qualified name lookup for Rust

In https://github.com/rust-lang/rust/pull/46457, "m4b" pointed out
that the Rust support in gdb doesn't properly handle the lookup of
qualified names.

In particular, as shown in the test case in this patch, something like
"::NAME" should be found in the global scope, but is not.

This turns out to happen because rust_lookup_symbol_nonlocal does not
search the global scope unless the name in question is unqualified.
However, lookup_symbol_aux does not search the global scope, and
appears to search the static scope only as a fallback (I wonder if
this is needed?).

This patch fixes the problem by changing rust_lookup_symbol_nonlocal
to search the static and global blocks in more cases.

Regression tested against various versions of the rust compiler on
Fedora 26 x86-64.  (Note that there are unrelated failures with newer
versions of rustc; I will be addressing those separately.)

2018-01-19  Tom Tromey  <tom@tromey.com>

	* rust-lang.c (rust_lookup_symbol_nonlocal): Look up qualified
	symbols in the static and global blocks.

2018-01-19  Tom Tromey  <tom@tromey.com>

	* gdb.rust/modules.rs (TWENTY_THREE): New global.
	* gdb.rust/modules.exp: Add ::-qualified lookup test.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] S390: Fix infcalls in s390-vregs test case
@ 2018-01-19 19:19 sergiodj+buildbot
  2018-01-20 20:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-19 19:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 634c1c3109a2ffdf43ef9dab839c88108d9980f3 ***

Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: 634c1c3109a2ffdf43ef9dab839c88108d9980f3

S390: Fix infcalls in s390-vregs test case

GDB used to assume that functions without debug info return int.  It
accepted an expression containing such a function call and silently
interpreted the function's return value as int.  But nowadays GDB yields
an error message instead, see

  https://sourceware.org/ml/gdb-patches/2017-07/msg00139.html

This affects the s390-vregs test case, because it contains calls to
setrlimit64 and chdir.  When no glibc debug info is installed, these lead
to unnecessary FAILs.  Fix this by adding appropriate casts to the
inferior function calls.

gdb/testsuite/ChangeLog:

	* gdb.arch/s390-vregs.exp: Explicitly cast the return values of
	setrlimit and chdir to int.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdb: Fix ia64 defining TRAP_HWBKPT before including gdb_wait.h
@ 2018-01-19 19:04 sergiodj+buildbot
  2018-01-20 15:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-19 19:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5a6c3296a7a90694ad4042f6256f3da6d4fa4ee8 ***

Author: James Clarke <jrtc27@jrtc27.com>
Branch: master
Commit: 5a6c3296a7a90694ad4042f6256f3da6d4fa4ee8

gdb: Fix ia64 defining TRAP_HWBKPT before including gdb_wait.h

On ia64, gdb_wait.h eventually includes siginfo-consts-arch.h, which
contains an enum with TRAP_HWBKPT, along with a #define. Thus we cannot
define TRAP_HWBKPT to 4 beforehand, and so gdb_wait.h must be included
earlier; include it from linux-ptrace.h so it can never come afterwards.

gdb/ChangeLog:

	* nat/linux-ptrace.c: Remove unnecessary reinclusion of
	gdb_ptrace.h, and move including gdb_wait.h ...
	* nat/linux-ptrace.h: ... to here.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make linux_nat_detach/thread_db_detach use the inferior parameter
@ 2018-01-19 17:48 sergiodj+buildbot
  2018-01-20 13:18 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-19 17:48 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bc09b0c14fb713a9aec25e09b78499f3bc2441b5 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: bc09b0c14fb713a9aec25e09b78499f3bc2441b5

Make linux_nat_detach/thread_db_detach use the inferior parameter

This patch makes these two functions actually use the inferior parameter
added by the previous patch, instead of reading inferior_ptid.  I chose
these two, because they are the one actually used when I detach on my
GNU/Linux system, so they were easy to test.

I took the opportunity to pass the inferior being detached to
inf_ptrace_detach_success, so it could use it too.  From there, it made
sense to add an overload of detach_inferior that takes the inferior
directly rather than the pid, to avoid having to pass inf->pid only for
the callee to look up the inferior structure by pid.

gdb/ChangeLog:

	* inf-ptrace.c (inf_ptrace_detach): Adjust call to
	inf_ptrace_detach_success.
	(inf_ptrace_detach_success): Add inferior parameter, use it
	instead of inferior_ptid, pass it to detach_inferior.
	* inf-ptrace.h (inf_ptrace_detach_success): Add inferior
	parameter.
	* inferior.c (detach_inferior): Add overload that takes an
	inferior object.
	* inferior.h (detach_inferior): Likewise.
	* linux-nat.c (linux_nat_detach): Use the inf parameter, don't
	use inferior_ptid, adjust call to inf_ptrace_detach_success.
	* linux-thread-db.c (thread_db_detach): Use inf parameter.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Pass inferior down to target_detach and to_detach
@ 2018-01-19 17:34 sergiodj+buildbot
  2018-01-20 11:03 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-19 17:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6e1e1966bac965c5a26b5e5cae69cb0ed21be4cc ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 6e1e1966bac965c5a26b5e5cae69cb0ed21be4cc

Pass inferior down to target_detach and to_detach

The to_detach target_ops method implementations are currently expected
to work on current_inferior/inferior_ptid.  In order to make things more
explicit, and remove some "shadow" parameter passing through globals,
this patch adds an "inferior" parameter to to_detach.  Implementations
will be expected to use this instead of relying on the global.  However,
to keep things simple, this patch only does the minimum that is
necessary to add the parameter.  The following patch gives an example of
how one such implementation would be adapted.  If the approach is deemed
good, we can then look into adapting more implementations.  Until then,
they'll continue to work as they do currently.

gdb/ChangeLog:

	* target.h (struct target_ops) <to_detach>: Add inferior
	parameter.
	(target_detach): Likewise.
	* target.c (dispose_inferior): Pass inferior down.
	(target_detach): Pass inferior down.  Assert that it is equal to
	the current inferior.
	* aix-thread.c (aix_thread_detach): Pass inferior down.
	* corefile.c (core_file_command): Pass current_inferior() down.
	* corelow.c (core_detach): Add inferior parameter.
	* darwin-nat.c (darwin_detach): Likewise.
	* gnu-nat.c (gnu_detach): Likewise.
	* inf-ptrace.c (inf_ptrace_detach): Likewise.
	* infcmd.c (detach_command): Pass current_inferior() down to
	target_detach.
	* infrun.c (follow_fork_inferior): Pass parent_inf to
	target_detach.
	(handle_vfork_child_exec_or_exit): Pass inf->vfork_parent to
	target_detach.
	* linux-nat.c (linux_nat_detach): Add inferior parameter.
	* linux-thread-db.c (thread_db_detach): Likewise.
	* nto-procfs.c (procfs_detach): Likewise.
	* procfs.c (procfs_detach): Likewise.
	* record.c (record_detach): Likewise.
	* record.h (struct inferior): Forward-declare.
	(record_detach): Add inferior parameter.
	* remote-sim.c (gdbsim_detach): Likewise.
	* remote.c (remote_detach_1): Likewise.
	(remote_detach): Likewise.
	(extended_remote_detach): Likewise.
	* sol-thread.c (sol_thread_detach): Likewise.
	* target-debug.h (target_debug_print_inferior_p): New macro.
	* target-delegates.c: Re-generate.
	* top.c (kill_or_detach): Pass inferior down to target_detach.
	* windows-nat.c (windows_detach): Add inferior parameter.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] S390: Improve comments for s390-tdbregs test case
@ 2018-01-19 13:35 sergiodj+buildbot
  2018-01-20  6:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-19 13:35 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d6ad07fdef94777bb512f072361706bcc743d51c ***

Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: d6ad07fdef94777bb512f072361706bcc743d51c

S390: Improve comments for s390-tdbregs test case

This adds more explanation as to why the test case must be compiled with
the -msoft-float option.  It also documents the my_tbegin and my_tend
functions.

gdb/testsuite/ChangeLog:

	* gdb.arch/s390-tdbregs.c (my_tbegin): Add comment documenting the
	function.
	(my_tend): Likewise.
	* gdb.arch/s390-tdbregs.exp: Enhance comment; explain the
	rationale of avoiding FP- and vector instructions.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Update French translation in bfd sub-directory
@ 2018-01-19 11:05 sergiodj+buildbot
  2018-01-20  4:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-19 11:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ee3fbc1ebb0cdd0785f4c328c5daaa4a4cdf3f91 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: ee3fbc1ebb0cdd0785f4c328c5daaa4a4cdf3f91

Update French translation in bfd sub-directory


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Don't pass -m32 to libcc1 on arm-linux
@ 2018-01-19 10:00 sergiodj+buildbot
  2018-01-20  0:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-19 10:00 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 88af8ea80b9732f951e61a4ed8868e722f337c8e ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 88af8ea80b9732f951e61a4ed8868e722f337c8e

Don't pass -m32 to libcc1 on arm-linux

When I run gdb.compile/ tests on arm-linux, I get the following fails,

(gdb) compile code -- ;^M
arm-none-linux-gnueabihf-gcc: error: unrecognized command line option '-m32'; did you mean '-mbe32'?^M
Compilation failed.^M
(gdb) compile code (void) param^M
arm-none-linux-gnueabihf-gcc: error: unrecognized command line option '-m32'; did you mean '-mbe32'?^M
Compilation failed.^M
(gdb) FAIL: gdb.compile/compile-ops.exp: compile code (void) param

This patch fixes it by implementing gcc_target_options gdbarch method
for arm-linux to override option "-m32".

gdb:

2018-01-19  Yao Qi  <yao.qi@linaro.org>

	* arm-linux-tdep.c (arm_linux_gcc_target_options): New function.
	(arm_linux_init_abi): Install it.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Find arm-linux-gnueabi(hf)?-gcc in compile
@ 2018-01-19  9:33 sergiodj+buildbot
  2018-01-19 23:00 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-19  9:33 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT dea445b940545f9564972c5410ac8792b72cc9c3 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: dea445b940545f9564972c5410ac8792b72cc9c3

Find arm-linux-gnueabi(hf)?-gcc in compile

GCC for arm-linux has different names on different distros.  It is
arm-linux-gnu-gcc on fedora.  Debian/Ubuntu has arm-linux-gnueabihf-gcc
and arm-linux-gnueabi-gcc.  So when I run gdb.compile/ tests on arm-linux,
I get,

(gdb) compile code -- ;
Could not find a compiler matching "^arm(-[^-]*)?-linux(-gnu)?-gcc$"

This patch extend the regexp to match both arm-linux-gnu-gcc and
arm-linux-gnueabihf-gcc.

gdb:

2018-01-19  Yao Qi  <yao.qi@linaro.org>

	* osabi.c (gdb_osabi_names): Extend the regexp for
	arm-linux-gnueabihf and arm-linux-gnueabi.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] GDB testsuite: Re-enable -fdiagnostics-color=never
@ 2018-01-18 19:09 sergiodj+buildbot
  2018-01-19 19:44 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-18 19:09 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT dcc069254040954ee72b3ed65b772d48cdff93df ***

Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: dcc069254040954ee72b3ed65b772d48cdff93df

GDB testsuite: Re-enable -fdiagnostics-color=never

In August 2017 the GDB test suite was changed to always add the compile
option "-fdiagnostics-color=never", see:

  https://sourceware.org/ml/gdb-patches/2017-08/msg00150.html

Since this option is not understood by rustc, a commit from 09/2017
dropped its use in that case:

  https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=5eb5f850
  ("Don't use -fdiagnostics-color=never for rustc")

But that change goes overboard and stops using the option for other
languages as well.  Thus compiler diagnostics written into gdb.log may
contain colored output again.  This is fixed.

gdb/testsuite/ChangeLog:

	* lib/gdb.exp (gdb_compile): Re-enable use of
	universal_compile_options for languages other than Rust.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make abbrev_table::abbrevs private
@ 2018-01-18 15:43 sergiodj+buildbot
  2018-01-19 15:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-18 15:43 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4a17f7688fbab8f170144fa13ffcd06bc749e6ec ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 4a17f7688fbab8f170144fa13ffcd06bc749e6ec

Make abbrev_table::abbrevs private

abbrev_table::abbrevs is only access within abbrev_table's methods, so
it can be private.  Add "m_" prefix.

gdb:

2018-01-18  Yao Qi  <yao.qi@linaro.org>

	* dwarf2read.c (abbrev_table) <abbrevs>: Rename it to
	m_abbrevs.
	(abbrev_table::add_abbrev): Update.
	(abbrev_table::lookup_abbrev): Update.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Call cooked_read in ppu2spu_prev_register
@ 2018-01-18 12:35 sergiodj+buildbot
  2018-01-19 12:49 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-18 12:35 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d679c21a43852305c5eeae957854f6e13d6f884c ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: d679c21a43852305c5eeae957854f6e13d6f884c

Call cooked_read in ppu2spu_prev_register

The code in ppu2spu_prev_register is in fact regcache_cooked_read,
because spu doesn't have gdbarch method pseudo_register_read_value.

gdb:

2018-01-18  Yao Qi  <yao.qi@linaro.org>

	* ppc-linux-tdep.c (ppu2spu_prev_register): Call cooked_read.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PowerPC PLT stub alignment fixes
@ 2018-01-18 12:14 sergiodj+buildbot
  2018-01-19 10:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-18 12:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 691d2e9af211ff8dd5fa8c96cb961b73a78394d7 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 691d2e9af211ff8dd5fa8c96cb961b73a78394d7

PowerPC PLT stub alignment fixes

Asking for ppc32 plt call stubs to be aligned at 32 byte boundaries
didn't quite work.  For ld.bfd they were spaced 32 bytes apart, but
only started on a 16 byte boundary.  ld.gold also didn't get it right.

Finding that bug made me check over the ppc64 plt stub alignment,
where I found that negative values for alignment (meaning align to
minimize boundary crossing) were not accepted.  Since no one has
complained about that, I guess I could have removed the feature from
ld.bfd documentation, but I've opted instead to correct the code.

I've also added an optional alignment paramenter for ppc32
--plt-align, for some consistency with gold and ppc64 ld.bfd.

bfd/
	* elf32-ppc.c (ppc_elf_create_glink): Correct alignment of .glink.
	* elf64-ppc.c (ppc64_elf_size_stubs): Handle negative plt_stub_align.
	(ppc64_elf_build_stubs): Likewise.
gold/
	* powerpc.cc (param_plt_align): New function supplying default
	--plt-align values.  Use it..
	(Stub_table::plt_call_align): ..here, and..
	(Output_data_glink::global_entry_align): ..here.
	(Stub_table::stub_align): Correct 32-bit minimum alignment.
ld/
	* emultempl/ppc32elf.em: Support optional --plt-align arg.
	* emultempl/ppc64elf.em: Support negative --plt-align arg.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix warning on gdb/compile/compile.c (C++-ify "triplet_rx")
@ 2018-01-17 23:20 sergiodj+buildbot
  2018-01-19  4:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 23:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7d937cad0acdccd0ff485435fbe16f005e994c66 ***

Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: 7d937cad0acdccd0ff485435fbe16f005e994c66

Fix warning on gdb/compile/compile.c (C++-ify "triplet_rx")

This fixes a GCC warning that happens when compiling
gdb/compile/compile.c on some GCC versions (e.g., "gcc (GCC) 7.2.1
20180104 (Red Hat 7.2.1-6)"):

../../gdb/compile/compile.c: In function 'void eval_compile_command(command_line*, const char*, compile_i_scope_types, void*)':
../../gdb/compile/compile.c:548:19: warning: 'triplet_rx' may be used uninitialized in this function [-Wmaybe-uninitialized]
     error_message = compiler->fe->ops->set_arguments_v0 (compiler->fe, triplet_rx,
     ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         argc, argv);
         ~~~~~~~~~~~
../../gdb/compile/compile.c:466:9: note: 'triplet_rx' was declared here
   char *triplet_rx;
         ^~~~~~~~~~

It's a simple patch that converts "triplet_rx" from "char *" to
"std::string", thus guaranteeing that it will be always initialized.

I've regtested this patch and did not find any regressions.  OK to
apply on both master and 8.1 (after creating a bug for it)?

gdb/ChangeLog:
2018-01-17  Sergio Durigan Junior  <sergiodj@redhat.com>

	* compile/compile.c (compile_to_object): Convert "triplet_rx"
	to "std::string".


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] RISC-V: Fix bug in prior addi/c.nop patch.
@ 2018-01-17 22:21 sergiodj+buildbot
  2018-01-19  2:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 22:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e925c834ecdb4a0ce595ad8d3da9c7d4f499ede0 ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: e925c834ecdb4a0ce595ad8d3da9c7d4f499ede0

RISC-V: Fix bug in prior addi/c.nop patch.

	gas/
	* config/tc-riscv.c (validate_riscv_insn) <'z'>: New.
	(riscv_ip) <'z'>: New.
	opcodes/
	* riscv-opc.c (riscv_opcodes) <addi>: Use z instead of 0.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove symbolp typedef
@ 2018-01-17 20:21 sergiodj+buildbot
  2018-01-18 23:54 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 20:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9e14690d06ac55136b7f051a2d2b8e173fa3bbdf ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 9e14690d06ac55136b7f051a2d2b8e173fa3bbdf

Remove symbolp typedef

This removes the symbolp typedef from dwarf2read.c.  It is no longer
used.

2018-01-17  Tom Tromey  <tom@tromey.com>

	* dwarf2read.c (symbolp): Remove typedef.  Don't instantiate VEC.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Allocate abbrev_table with new
@ 2018-01-17 20:16 sergiodj+buildbot
  2018-01-18 15:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 20:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 685af9cd2283b07a222157723e239f09d6ea2682 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 685af9cd2283b07a222157723e239f09d6ea2682

Allocate abbrev_table with new

This changes dwarf2read.c to allocate abbrev tables using "new", and
then updates the users.

This version of the patch incorporates the changes that Simon
implemented.  These changes simplify the ownership rules for abbrev
tables.

2018-01-17  Tom Tromey  <tom@tromey.com>
	    Simon Marchi  <simon.marchi@ericsson.com>

	* dwarf2read.c (struct dwarf2_cu) <abbrev_table>: Remove.
	(struct die_reader_specs) <abbrev_table>: New member.
	(struct abbrev_table): Add constructor.
	<alloc_abbrev, add_abbrev, lookup_abbrev>: Declare.
	<abbrev_obstack>: Now an auto_obstack.
	(abbrev_table_up): New typedef.
	(init_cu_die_reader): Add abbrev_table parameter.
	(read_cutu_die_from_dwo): Remove abbrev_table_provided parameter.
	Add result_dwo_abbrev_table.
	(init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
	(init_cutu_and_read_dies_no_follow, build_type_psymtabs_1):
	Update.
	(peek_die_abbrev): Take die_reader_specs, not dwarf_cu as
	parameter.
	(skip_children): Update.
	(abbrev_table::alloc_abbrev): Rename from
	abbrev_table_alloc_abbrev.
	(abbrev_table::add_abbrev): Rename from abbrev_table_add_abbrev.
	(abbrev_table::lookup_abbrev): Rename from
	abbrev_table_lookup_abbrev.
	(abbrev_table_read_table): Return abbrev_table_up.
	(abbrev_table_free, abbrev_table_free_cleanup)
	(dwarf2_read_abbrevs, dwarf2_free_abbrev_table): Remove.
	(load_partial_dies): Update.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Change dwarf2_cu::method_info to be a std::vector
@ 2018-01-17 19:57 sergiodj+buildbot
  2018-01-18 19:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 19:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c89b44cdc52b6a9c0848a795689895e292ad1f46 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: c89b44cdc52b6a9c0848a795689895e292ad1f46

Change dwarf2_cu::method_info to be a std::vector

This changes the type of dwarf2_cu::method_info and fixes up the uses.
In order to remove cleanups from process_full_comp_unit and
process_full_type_unit, psymtab_include_file_name also had to be
changed to avoid leaving dangling cleanups.

2018-01-17  Tom Tromey  <tom@tromey.com>

	* dwarf2read.c (delayed_method_info): Remove typedef.
	(dwarf2_cu::method_info): Now a std::vector.
	(add_to_method_list): Update.
	(free_delayed_list): Remove.
	(compute_delayed_physnames): Update.
	(process_full_comp_unit, process_full_type_unit): Clear the method
	list.  Remove cleanups.
	(psymtab_include_file_name): Add name_holder parameter.  Use
	unique_xmalloc_ptr.
	(dwarf_decode_lines): Update.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Allocate dwarf2_cu with new
@ 2018-01-17 19:45 sergiodj+buildbot
  2018-01-18 17:11 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 19:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fcd3b13d80a2d0e5fc31ef6a245be62db6a11420 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: fcd3b13d80a2d0e5fc31ef6a245be62db6a11420

Allocate dwarf2_cu with new

This changes dwarf2_cu to be allocated with new, and fixes up the
users.

2018-01-17  Tom Tromey  <tom@tromey.com>
	    Simon Marchi  <simon.marchi@ericsson.com>

	* dwarf2read.c (struct dwarf2_cu): Add constructor, destructor.
	(dwarf2_per_objfile::free_cached_comp_units)
	(init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
	(init_cutu_and_read_dies_no_follow): Update.
	(dwarf2_cu::dwarf2_cu): Rename from init_one_comp_unit.
	(dwarf2_cu::~dwarf2_cu): New.
	(free_heap_comp_unit, free_stack_comp_unit): Remove.
	(age_cached_comp_units, free_one_cached_comp_unit): Update.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Unify new_symbol and new_symbol_full
@ 2018-01-17 19:20 sergiodj+buildbot
  2018-01-18 13:50 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 19:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5e2db402c8e665b0c6ac81047a10cbf4e26329f2 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 5e2db402c8e665b0c6ac81047a10cbf4e26329f2

Unify new_symbol and new_symbol_full

This patch unifies new_symbol with new_symbol_full, replacing a
wrapper function with a default parameter.

2018-01-17  Tom Tromey  <tom@tromey.com>

	* dwarf2read.c (dwarf2_compute_name): Update comment.
	(read_func_scope, read_variable): Update.
	(new_symbol): Remove.
	(new_symbol_full): Rename to new_symbol.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix gdb segv when objfile can't be opened
@ 2018-01-17 18:49 sergiodj+buildbot
  2018-01-18 11:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 18:49 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 416675305692976aca45860e24b963982a2e682a ***

Author: Mike Gulick <mike.gulick@mathworks.com>
Branch: master
Commit: 416675305692976aca45860e24b963982a2e682a

Fix gdb segv when objfile can't be opened

This fixes PR 16577.

This patch changes gdb_bfd_map_section to issue a warning rather than an error
if it is unable to read the object file, and sets the size of the section/frame
that it attempted to read to 0 on error.

The description of gdb_bfd_map_section states that it will try to read or map
the contents of the section SECT, and if successful, the section data is
returned and *SIZE is set to the size of the section data.  This function was
throwing an error and leaving *SIZE as-is.  Setting the section size to 0
indicates to dwarf2_build_frame_info that there is no data to read, otherwise
it will try to read from an invalid frame pointer.

Changing the error to a warning allows this to be handled gracefully.
Additionally, the error was clobbering the breakpoint output indicating the
current frame (function name, arguments, source file, and line number).  E.g.

Thread 3 "foo" hit Breakpoint 1, BFD: reopening /tmp/jna-1013829440/jna2973250704389291330.tmp: No such file or directory
BFD: reopening /tmp/jna-1013829440/jna2973250704389291330.tmp: No such file or directory
(gdb)

While the "BFD: reopening ..." messages will still appear interspersed in the
breakpoint output, the current frame info is now displayed:

Thread 3 "foo" hit Breakpoint 1, BFD: reopening /tmp/jna-1013829440/jna1875755897659885075.tmp: No such file or directory
BFD: reopening /tmp/jna-1013829440/jna1875755897659885075.tmp: No such file or directory
warning: Can't read data for section '.eh_frame' in file '/tmp/jna-1013829440/jna1875755897659885075.tmp'
do_something () at file.cpp:80
80	{
(gdb)


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make linux_ptrace_attach_fail_reason return an std::string
@ 2018-01-17 17:59 sergiodj+buildbot
  2018-01-18  9:05 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 17:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4d9b86e17505063c96a01d40cdf5b4fc2080a798 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 4d9b86e17505063c96a01d40cdf5b4fc2080a798

Make linux_ptrace_attach_fail_reason return an std::string

This patch makes linux_ptrace_attach_fail_reason and
linux_ptrace_attach_fail_reason_string return std::string.  It also
replaces usages of struct buffer with std::string.  This allows getting
rid of a cleanup in in linux_ptrace_attach_fail_reason_string and
simplifies the code in general.

Something that looks odd to me is that in
linux_ptrace_attach_fail_reason, if the two messages are appended, there
is no separating space or \n, so the result won't be very nice.  I left
it as-is for now though.

gdb/ChangeLog:

	* nat/linux-ptrace.h (linux_ptrace_attach_fail_reason): Return
	std::string.
	(linux_ptrace_attach_fail_reason_string): Likewise.
	* nat/linux-ptrace.c (linux_ptrace_attach_fail_reason):
	Likewise.
	(linux_ptrace_attach_fail_reason_string): Likewise.
	* linux-nat.c (attach_proc_task_lwp_callback): Adjust.

gdb/gdbserver/ChangeLog:

	* linux-low.c (attach_proc_task_lwp_callback): Adjust to
	linux_ptrace_attach_fail_reason_string now returning an
	std::string.
	(linux_attach): Likewise.
	* thread-db.c (attach_thread): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Replace CET bit with IBT and SHSTK bits.
@ 2018-01-17 17:04 sergiodj+buildbot
  2018-01-18  5:20 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 17:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d777820bf5abea433c36e956b53b299502e0f708 ***

Author: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
Branch: master
Commit: d777820bf5abea433c36e956b53b299502e0f708

Replace CET bit with IBT and SHSTK bits.

The latest specification for Intel CET technology defined two
new bits instead of previously used CET bit. These are IBT and
SHSTK bits. The patch replaces CET bit with IBT and SHSTK bits.

gas/
	* config/tc-i386.c (cpu_arch): Delete .cet. Add .ibt, .shstk.
	(cpu_noarch): Add noibt, noshstk.
	(parse_insn): Change cpucet to cpuibt.
	* doc/c-i386.texi: Delete .cet. Add .ibt, .shstk.
	* testsuite/gas/i386/cet-ibt-inval.l: New test.
	* testsuite/gas/i386/cet-ibt-inval.s: Likewise.
	* testsuite/gas/i386/cet-shstk-inval.l: Likewise.
	* testsuite/gas/i386/cet-shstk-inval.s: Likewise.
	* testsuite/gas/i386/x86-64-cet-ibt-inval.l: Likewise.
	* testsuite/gas/i386/x86-64-cet-ibt-inval.s: Likewise.
	* testsuite/gas/i386/x86-64-cet-shstk-inval.l: Likewise.
	* testsuite/gas/i386/x86-64-cet-shstk-inval.s: Likewise.

opcodes/
	* i386-gen.c (cpu_flag_init): Delete CPU_CET_FLAGS,
	CpuCET. Add CPU_IBT_FLAGS, CPU_SHSTK_FLAGS, CPY_ANY_IBT_FLAGS,
	CPU_ANY_SHSTK_FLAGS, CpuIBT, CpuSHSTK.
	(cpu_flags): Add CpuIBT, CpuSHSTK.
	* i386-opc.h (enum): Add CpuIBT, CpuSHSTK.
	(i386_cpu_flags): Add cpuibt, cpushstk.
	* i386-opc.tbl: Change CpuCET to CpuSHSTK and CpuIBT.
	* i386-init.h: Regenerate.
	* i386-tbl.h: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] configure: Fix test for fs_base/gs_base in <sys/user.h>
@ 2018-01-17 13:48 sergiodj+buildbot
  2018-01-17 23:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 13:48 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f517c1805ac50c64c2dbb086c16b3bcf33b15a89 ***

Author: Eldar Abusalimov <eldar.abusalimov@jetbrains.com>
Branch: master
Commit: f517c1805ac50c64c2dbb086c16b3bcf33b15a89

configure: Fix test for fs_base/gs_base in <sys/user.h>

Make <sys/types.h> be included prior to including <sys/user.h>.

glibc versions older than 2.14 use __uintNN_t types within certain
structures defined in <sys/user.h> probably assuming these types are
defined prior to including the header. This results in the following
`configure` feature test compilation error that makes it think that
`struct user_regs_struct` doesn't have `fs_base`/`gs_base` fields,
althouh it does.

    configure:13617: checking for struct user_regs_struct.fs_base
    configure:13617: gcc -c -g -O2 -I/linux/include conftest.c >&5
    In file included from conftest.c:158:0:
    /usr/include/sys/user.h:32:3: error: unknown type name '__uint16_t'
       __uint16_t  cwd;
       ^
    /usr/include/sys/user.h:33:3: error: unknown type name '__uint16_t'
       __uint16_t  swd;
       ^
    /usr/include/sys/user.h:34:3: error: unknown type name '__uint16_t'
       __uint16_t  ftw;
       ^
    /usr/include/sys/user.h:35:3: error: unknown type name '__uint16_t'
       __uint16_t  fop;
       ^
    /usr/include/sys/user.h:36:3: error: unknown type name '__uint64_t'
       __uint64_t  rip;
       ^
    /usr/include/sys/user.h:37:3: error: unknown type name '__uint64_t'
       __uint64_t  rdp;
       ^
    /usr/include/sys/user.h:38:3: error: unknown type name '__uint32_t'
       __uint32_t  mxcsr;
       ^
    /usr/include/sys/user.h:39:3: error: unknown type name '__uint32_t'
       __uint32_t  mxcr_mask;
       ^
    /usr/include/sys/user.h:40:3: error: unknown type name '__uint32_t'
       __uint32_t  st_space[32];   /* 8*16 bytes for each FP-reg = 128 bytes */
       ^
    /usr/include/sys/user.h:41:3: error: unknown type name '__uint32_t'
       __uint32_t  xmm_space[64];  /* 16*16 bytes for each XMM-reg = 256 bytes */
       ^
    /usr/include/sys/user.h:42:3: error: unknown type name '__uint32_t'
       __uint32_t  padding[24];
       ^
    configure:13617: $? = 1
    configure: failed program was:
    | /* confdefs.h */
    ...
    | /* end confdefs.h.  */
    | #include <sys/user.h>
    |
    | int
    | main ()
    | {
    | static struct user_regs_struct ac_aggr;
    | if (ac_aggr.fs_base)
    | return 0;
    |   ;
    |   return 0;
    | }

Recent glibc versions don't use typedef'ed int types in <sys/user.h>,
thus allowing it to be included as is
(glibc commit d79a9c949c84e7f0ba33e87447c47af833e9f11a).
However there're still some distros alive that use older glibc,
for instance, RHEL/CentOS 6 package glibc 2.12.

Also affects PR gdb/21559:

    ../../gdb/regcache.c:1087: internal-error: void regcache_raw_supply(regcache, int, const void): Assertion `regnum >= 0 && regnum < regcache->descr->nr_raw_registers' failed.

As noted by Andrew Paprocki, who submitted the PR
(https://sourceware.org/bugzilla/show_bug.cgi?id=21559#c3):

    > It should be noted that modifying `configure` to force on
    > `HAVE_STRUCT_USER_REGS_STRUCT_FS_BASE` and
    > `HAVE_STRUCT_USER_REGS_STRUCT_GS_BASE` fixes this issue. For some
    > reason the `configure` tests for `fs_base` and `gs_base` fail
    > even though `sys/user.h` on RHEL5 has the fields defined in
    > `user_regs_struct`.

Note that this patch does NOT fix the root cause of PR gdb/21559,
although now that `configure` properly detects the presence of the
fields and sets HAVE_XXX accordingly, the execution takes another
path, which doesn't lead to the assertion failure in question.

gdb/ChangeLog:
2018-01-17  Eldar Abusalimov  <eldar.abusalimov@jetbrains.com>

	PR gdb/21559
	* configure.ac: Include <sys/types.h> prior to <sys/user.h> when
	checking for fs_base/gs_base fields in struct user_regs_struct.
	* configure: Regenerate.

gdb/gdbserver/ChangeLog:
2018-01-17  Eldar Abusalimov  <eldar.abusalimov@jetbrains.com>

	PR gdb/21559
	* configure.ac: Include <sys/types.h> prior to <sys/user.h> when
	checking for fs_base/gs_base fields in struct user_regs_struct.
	* configure: Regenerate.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Relax gdb.compile/compile.exp to match the address printed for frame
@ 2018-01-17 11:56 sergiodj+buildbot
  2018-01-17 15:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 11:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d8447b6b9fd288ebd35620178ba720b1f0ce7ebf ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: d8447b6b9fd288ebd35620178ba720b1f0ce7ebf

Relax gdb.compile/compile.exp to match the address printed for frame

One test in gdb.compile/compile.exp passes on one fedora builder,

 bt
 #0  0x00007ffff7ff43f6 in _gdb_expr (__regs=0x7ffff7ff2000) at gdb
 command line:1^M
 #1  <function called from gdb>^M
 #2  main () at /home/gdb-buildbot/fedora-x86-64-1/fedora-x86-64/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.compile/compile.c:106^M
 (gdb) PASS: gdb.compile/compile.exp: bt

but fails on my machine with gcc trunk,

 bt^M
 #0  _gdb_expr (__regs=0x7ffff7ff3000) at gdb command line:1^M
 #1  <function called from gdb>^M
 #2  main () at gdb/testsuite/gdb.compile/compile.c:106^M
 (gdb) FAIL: gdb.compile/compile.exp: bt

The test should be tweaked to match both cases (pc in the start of line
vs pc in the middle of line).  Note that I am not clear that why libcc1
emits debug info this way so that the address is in the middle of line.

gdb/testsuite:

2018-01-17  Yao Qi  <yao.qi@linaro.org>

	* gdb.compile/compile.exp: Match the address printed for
	frame in the output of command "bt".


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Warning fix
@ 2018-01-17 11:10 sergiodj+buildbot
  2018-01-17 12:56 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-17 11:10 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c75bc4f76fe456c57ef1e446db5378182692c429 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: c75bc4f76fe456c57ef1e446db5378182692c429

Warning fix

	* elf64-ppc.c (ppc64_elf_build_stubs): Silence gcc warning.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Update translations for various binutils components.
@ 2018-01-16 13:03 sergiodj+buildbot
  2018-01-16 14:45 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-16 13:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f6efed019b4e49a4c27b518afbdf2d9bf0652843 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: f6efed019b4e49a4c27b518afbdf2d9bf0652843

Update translations for various binutils components.

ld      * po/pt_BR.po: Updated Brazilian Portugese translation.

opcodes * po/pt_BR.po: Updated Brazilian Portugese translation.
        * po/de.po: Updated German translation.

gas     * po/fr.po: Updated French translation.

binutils* po/fr.po: Updated French translation.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Mark register unavailable when PTRACE_PEEKUSER fails
@ 2018-01-16  9:25 sergiodj+buildbot
  2018-01-16 11:44 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-16  9:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9a70f35c8d872bb5542e98e34b8b044228dcb844 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 9a70f35c8d872bb5542e98e34b8b044228dcb844

Mark register unavailable when PTRACE_PEEKUSER fails

As described in PR 18749, GDB/GDBserver may get an error on accessing
memory or register because the thread may disappear.  However, some
path doesn't expect the error.  This patch fixes this problem by
marking the register unavailable when PTRACE_PEEKUSER fails instead
of throwing error.

gdb/gdbserver:

2018-01-16  Yao Qi  <yao.qi@linaro.org>

	PR gdb/18749
	* linux-low.c (fetch_register): Call supply_register instead of
	error.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdb/common/signals-state-save-restore.c: Fix typos
@ 2018-01-15 23:14 sergiodj+buildbot
  2018-01-16  2:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-15 23:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT db422fb2120e311318657d9c7dd0e7b0b5a5eac9 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: db422fb2120e311318657d9c7dd0e7b0b5a5eac9

gdb/common/signals-state-save-restore.c: Fix typos

gdb/ChangeLog:
2018-01-15  Pedro Alves  <palves@redhat.com>

	* common/signals-state-save-restore.c
	(save_original_signals_state): Fix typos.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Update Ukranian translations for bfd, binutils, gas, gold, ld and opcodes
@ 2018-01-15 12:32 sergiodj+buildbot
  2018-01-15 13:53 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-15 12:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 616dcb87abe148edf7278581e04cf23aff97411e ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 616dcb87abe148edf7278581e04cf23aff97411e

Update Ukranian translations for bfd, binutils, gas, gold, ld and opcodes


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Update notes on how to make a release
@ 2018-01-13 16:17 sergiodj+buildbot
  2018-01-14  4:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-13 16:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 19e2900bd399d1ba272afe8b5b50b1b29a948bbe ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 19e2900bd399d1ba272afe8b5b50b1b29a948bbe

Update notes on how to make a release


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Update pot files
@ 2018-01-13 15:45 sergiodj+buildbot
  2018-01-14  1:53 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-13 15:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3957a4963f38fb249eced6c880efacd22f10eb28 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 3957a4963f38fb249eced6c880efacd22f10eb28

Update pot files


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Bump version number to 2.30.51
@ 2018-01-13 14:31 sergiodj+buildbot
  2018-01-13 23:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-13 14:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 769c7ea507209948135facd04bf8defc3f21a8a4 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 769c7ea507209948135facd04bf8defc3f21a8a4

Bump version number to 2.30.51

bfd/
	* version.m4: Bump version to 2.30.51
	* configure: Regenerate.

binutils/
	* configure: Regenerate.

gas/
	* configure: Regenerate.

gprof/
	* configure: Regenerate.

ld/
	* configure: Regenerate.

opcodes/
	* configure: Regenerate.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add note about 2.30 branch creation to changelogs
@ 2018-01-13 13:46 sergiodj+buildbot
  2018-01-13 21:24 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-13 13:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT faf766e31794722b7e2c24e44e920d0476cede32 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: faf766e31794722b7e2c24e44e920d0476cede32

Add note about 2.30 branch creation to changelogs


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdb/testsuite: Don't attempt tests if they fail to compile
@ 2018-01-13  0:00 sergiodj+buildbot
  2018-01-13 18:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-13  0:00 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cbcdb1aaddb4dd1a388eadbea6b6ec342c7ab067 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: cbcdb1aaddb4dd1a388eadbea6b6ec342c7ab067

gdb/testsuite: Don't attempt tests if they fail to compile

In the gdb.base/whatis-ptype-typedefs.exp test, if the test program
fails to compile, don't run the tests.

gdb/testsuite/ChangeLog:

	* gdb.base/whatis-ptype-typedefs.exp: Don't run tests if we failed
	to prepare.
	(prepare): Return 0 on error, 1 on success.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Install and generate docs for gdb-add-index
@ 2018-01-12 23:43 sergiodj+buildbot
  2018-01-13 16:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-12 23:43 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ba643918cf869fa0d064d733f69b453b6fe642ea ***

Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: ba643918cf869fa0d064d733f69b453b6fe642ea

Install and generate docs for gdb-add-index

The "gdb-add-index" script has been resurrected on:

  commit caf26be91a584ef141ac5d3cb31007731af8b8e3
  Author: Samuel Bronson <naesten@gmail.com>
  Date:   Fri Nov 15 16:09:33 2013 -0500

      Resurrect gdb-add-index as a contrib script

However, for some reason (I couldn't find it in the archives), only
the script has been checked-in; the Makefile parts responsible for
installing it in the system were left out.  This commit fixes that, by
also resurrecting the Makefile and documentation bits.

This commit is part of our effort to upstream the local Fedora GDB
changes.  With this commit, we'll only carry a very small
Fedora-specific modification to the script.

gdb/ChangeLog:
2017-01-12  Tom Tromey  <tom@tromey.com>
	    Sergio Durigan Junior  <sergiodj@redhat.com>

	* Makefile.in (install-only): Install gdb-add-index.

gdb/doc/ChangeLog:
2017-01-12  Tom Tromey  <tom@tromey.com>
	    Sergio Durigan Junior  <sergiodj@redhat.com>

	* gdb.texinfo (Index Files): Mention gdb-add-index.
	(gdb-add-index man): New section.
	* Makefile.in (gdb-add-index.1): New rule to generate manpage
	from gdb.texinfo.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Use the correct value for the offset of 'kve_protection'.
@ 2018-01-12 22:32 sergiodj+buildbot
  2018-01-13 13:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-12 22:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 906b4aac4c1d3cdb2b1ea7105133cfbe25e04e14 ***

Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: 906b4aac4c1d3cdb2b1ea7105133cfbe25e04e14

Use the correct value for the offset of 'kve_protection'.

I had forgotten to convert the decimal output of 'ptype /o' to hex
(but still used a 0x prefix) for the KVE_PROTECTION constant defining
the offset of the 'kve_protection' field in the 'kinfo_vmentry'
structure.  This resulted in garbage permissions for entries in 'info
proc mappings' for FreeBSD core dumps.

gdb/ChangeLog:

	* fbsd-tdep.c (KVE_PROTECTION): Correct value.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix GDB hang with remote after error from resume
@ 2018-01-12 19:19 sergiodj+buildbot
  2018-01-13  3:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-12 19:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bdf2a94aa535016a1640d56e9b2b539c4376bf31 ***

Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: bdf2a94aa535016a1640d56e9b2b539c4376bf31

Fix GDB hang with remote after error from resume

Since this commit --

  Fix PR18360 - internal error when using "interrupt -a"
  (https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=c65d6b55)

-- the testsuite shows long delays on s390 with native-gdbserver when
executing certain tests, such as watchpoints.exp.  These hangs have been
discussed before in the context of buildbot problems, see here:

  https://sourceware.org/ml/gdb-patches/2017-12/msg00413.html

The problem can easily be triggered by stopping on a breakpoint, then
setting impossible watchpoints, and finally doing "continue".  Then, after
having set the step-over state (in keep_going_pass_signal in infrun.c),
GDB tries to insert breakpoints and watchpoints into the inferior.  This
fails, and the "continue" command is aborted.  But the step-over state is
not cleared in this case, which causes future step-over attempts to be
skipped since GDB thinks that "we already have an in-line step-over
operation ongoing" (see start_step_over in infrun.c).  Thus the next
"continue" just goes on to wait for events from the remote, which will
never occur.

The problem can also be reproduced on amd64 with native-gdbserver, using
the following change to watchpoints.exp:

 -- >8 --
 --- a/gdb/testsuite/gdb.base/watchpoints.exp
 +++ b/gdb/testsuite/gdb.base/watchpoints.exp
 @@ -61,2 +61,3 @@ with_test_prefix "before inferior start" {
      gdb_test "watch ival3" ".*" ""
 +    gdb_test "watch *(char \[256\] *) main"

 -- >8 --

To fix the hang, this patch clears the step-over info when
insert_breakpoints has failed.  Of course, with native-gdbserver the
watchpoints.exp test case still causes many FAILs on s390, because
gdbserver does not support watchpoints for that target.  This is a
separate issue.

gdb/ChangeLog:
2018-01-12  Andreas Arnez  <arnez@linux.vnet.ibm.com>

	* infrun.c (keep_going_pass_signal): Clear step-over info when
	insert_breakpoints fails.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix override of common symbols for a.out
@ 2018-01-12 11:55 sergiodj+buildbot
  2018-01-12 23:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-12 11:55 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a78eea1623aa6d05a395a73414bf01f6c8ae81c6 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: a78eea1623aa6d05a395a73414bf01f6c8ae81c6

Fix override of common symbols for a.out

The default should be bfd_link_common_skip_none, as in the original
patch at https://sourceware.org/ml/binutils/2002-07/msg00717.html

	* aoutx.h (aout_link_check_ar_symbols): Remove default and handle
	bfd_link_common_skip_none in switch.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] ld: Create a new LOAD segment for separate code segment
@ 2018-01-12  4:24 sergiodj+buildbot
  2018-01-12 12:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-12  4:24 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2888249fc9eb38b6d6e4bd969ce63c26e3753d5e ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 2888249fc9eb38b6d6e4bd969ce63c26e3753d5e

ld: Create a new LOAD segment for separate code segment

When generating separate code LOAD segment, create a new LOAD segment
if the previous section contains text and the current section doesn't
or vice versa:

Elf file type is DYN (Shared object file)
Entry point 0x200020
There are 7 program headers, starting at offset 52

Program Headers:
  Type           Offset   VirtAddr   PhysAddr   FileSiz MemSiz  Flg Align
  LOAD           0x000000 0x00000000 0x00000000 0x00200 0x00200 R   0x200000
  LOAD           0x200000 0x00200000 0x00200000 0x00036 0x00036 R E 0x200000
  LOAD           0x400000 0x00400000 0x00400000 0x00064 0x00064 R   0x200000
  LOAD           0x400f80 0x00600f80 0x00600f80 0x000a0 0x000a0 RW  0x200000
  DYNAMIC        0x400f80 0x00600f80 0x00600f80 0x00080 0x00080 RW  0x4
  GNU_STACK      0x000000 0x00000000 0x00000000 0x00000 0x00000 RW  0x10
  GNU_RELRO      0x400f80 0x00600f80 0x00600f80 0x00080 0x00080 R   0x1

 Section to Segment mapping:
  Segment Sections...
   00     .hash .gnu.hash .dynsym .dynstr .rela.plt
   01     .plt .text
   02     .rodata .eh_frame
   03     .dynamic .got.plt
   04     .dynamic
   05
   06     .dynamic

to prevent fetching or executing data in code pages as instructions.

Also don't put a writable section in a read-only segment if there is a
RELRO segment.

Since code segment is aligned and padded to the maximum page size on
disk, the minimum file size is bigger than the maximum page size which
is 2MB (0x200000):

-rwxr-xr-x 1 hjl hjl 4201932 Jan 10 10:41 libfoo.so

"-z max-page-size=0x1000" can be used to reduce the maximum page size to
4KB (0x1000):

-rwxr-xr-x 1 hjl hjl   15820 Jan 10 10:44 libfoo.so

	PR ld/22393
	* elf.c (_bfd_elf_map_sections_to_segments): When generating
	separate code and read-only data LOAD segments, create a new
	LOAD segment if the previous section contains text and the
	current section doesn't or vice versa.  Don't put a writable
	section in a read-only segment if there is a RELRO segment.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdb_compile_shlib: Only consider shlib= options when building executables
@ 2018-01-12  2:29 sergiodj+buildbot
  2018-01-12  7:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-12  2:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6181e9c2c5ba252ac016f51903dc35d7bfbbca71 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 6181e9c2c5ba252ac016f51903dc35d7bfbbca71

gdb_compile_shlib: Only consider shlib= options when building executables

Trying to use gdb_compile_shlib with the shlib= option to build a shared
library that depends on another shared library does not work as of
today.  See:

  https://sourceware.org/ml/gdb-patches/2017-10/msg00733.html

The problem is that building the lib is done in two steps, compilation
(.c -> .o) and linking (.o -> .so) and the shlib= options are passed to
both steps.  When compiling the object file (.o), it results in gcc
complaining:

  gcc: warning: .../solib-vanish-lib2.so: linker input file unused because linking not done

The first solution I came up with was to filter the options inside
gdb_compile_shlib to remove the shlib= options from the options we pass
when compiling the .o file.

I then thought it would be simpler to ignore the shlib= options in
gdb_compile when not building an executable (the executable category
includes the shared libraries).  For other compilation types (object
file, preprocess and generate assembly), it doesn't make sense to add
shared libraries to the source file list.

Regtested on the buildbot.

gdb/testsuite/ChangeLog:

	* lib/gdb.exp (gdb_compile): Ignore shlib= and shlib_load
	options when not creating an executable.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Ignore dynamic references on forced local symbols
@ 2018-01-11 23:57 sergiodj+buildbot
  2018-01-12  5:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-11 23:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d664fd41e15f058aab41b70c567ad09f2fab1115 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: d664fd41e15f058aab41b70c567ad09f2fab1115

Ignore dynamic references on forced local symbols

We should ignore dynamic references on forced local symbols during
garbage collection since they can never be referenced dynamically.

bfd/

	PR ld/22649
	* elflink.c (bfd_elf_gc_mark_dynamic_ref_symbol): Ignore dynamic
	references on forced local symbols.

ld/

	PR ld/22649
	* testsuite/ld-elf/pr22649-1.s: New file.
	* testsuite/ld-elf/pr22649-2a.s: Likewise.
	* testsuite/ld-elf/pr22649-2b.s: Likewise.
	* testsuite/ld-elf/pr22649.msg: Likewise.
	* testsuite/ld-elf/shared.exp: Run ld/22649 tests.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdb.base/breakpoint-in-ro-region.exp regression on sss targets (PR gdb/22583)
@ 2018-01-11 19:05 sergiodj+buildbot
  2018-01-12  0:15 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-11 19:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 71d378ae60a4f072ce392046878d471255f6c8a1 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 71d378ae60a4f072ce392046878d471255f6c8a1

gdb.base/breakpoint-in-ro-region.exp regression on sss targets (PR gdb/22583)

As Maciej reported at
<https://sourceware.org/ml/gdb-patches/2017-12/msg00212.html>, this
commit:

 commit d930703d68ae160ddfe8ebe5fdcf416fb6090e1e
 Date: Thu Nov 16 18:44:43 2017 +0000
 Subject: Don't ever Quit out of resume

caused regressions on software single-set targets, specifically:

 FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: single-step breakpoint is not left behind
 FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw on: single-step breakpoint is not left behind
 FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted on: auto-hw off: step in ro region (cannot insert hw break)
 FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted on: auto-hw off: single-step breakpoint is not left behind
 FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted on: auto-hw on: single-step breakpoint is not left behind

and indeed detailed logs indicate a breakpoint is left lingering, e.g.:

 (gdb) PASS: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: step in ro region (cannot insert sw break)
 maint info breakpoints 0
 Num     Type           Disp Enb Address    What
 0       sw single-step keep y   0x00400774 in main at [...]/gdb/testsuite/gdb.base/breakpoint-in-ro-region.c:24 inf 1 thread 1
	 stop only in thread 1
 (gdb) FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: single-step breakpoint is not left behind

vs:

 (gdb) PASS: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: step in ro region (cannot insert sw break)
 maint info breakpoints 0
 No breakpoint or watchpoint matching '0'.
 (gdb) PASS: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: single-step breakpoint is not left behind

as at commit d930703d68ae^.

Before commit d930703d68ae, we had a cleanup installed in 'resume'
that would delete single-step breakpoints on error:

  /* Resuming.  */

  /* Things to clean up if we QUIT out of resume ().  */
  static void
  resume_cleanups (void *ignore)
  {
    if (!ptid_equal (inferior_ptid, null_ptid))
     delete_single_step_breakpoints (inferior_thread ());

    normal_stop ();
  }

That whole function was removed by d930703d68ae mainly to eliminate
the normal_stop call:

~~~~
    Note that the exception called from within resume ends up calling
    normal_stop via resume_cleanups.  That's very borked though, because
    normal_stop is going to re-handle whatever was the last reported
    event, possibly even re-running a hook stop...
~~~~

But as the regression shows, removing resume_cleanups completely went
a bit too far, as the delete_single_step_breakpoints call is still
necessary.

So fix the regression by reinstating the
delete_single_step_breakpoints call on error.  However, since we're
trying to eliminate cleanups, restore it in a different form (using
TRY/CATCH).

Tested on x86-64 GNU/Linux both top of master and on top of a series
that implements software single-step on x86.

gdb/ChangeLog:
2018-01-11  Pedro Alves  <palves@redhat.com>

	PR gdb/22583
	* infrun.c (resume): Rename to ...
	(resume_1): ... this.
	(resume): Reimplement as wrapper around resume_1.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] ld: Keep PREINIT_ARRAY/INIT_ARRAY/FINI_ARRAY sections for -r --gc-sections
@ 2018-01-11 18:02 sergiodj+buildbot
  2018-01-11 22:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-11 18:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8b6f4cd34fdde524ea035c65f7d48aaa3fb449b5 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 8b6f4cd34fdde524ea035c65f7d48aaa3fb449b5

ld: Keep PREINIT_ARRAY/INIT_ARRAY/FINI_ARRAY sections for -r --gc-sections

We must keep all PREINIT_ARRAY, INIT_ARRAY as well as FINI_ARRAY sections
for ld -r --gc-sections.

bfd/

	PR ld/22677
	* elflink.c (bfd_elf_gc_sections): Keep all PREINIT_ARRAY,
	INIT_ARRAY as well as FINI_ARRAY sections for ld -r --gc-sections.

ld/

	PR ld/22677
	* scripttempl/elf.sc (PREINIT_ARRAY): New.
	Don't add .preinit_array for ld -r.
	* testsuite/ld-elf/pr22677.d: New file.
	* testsuite/ld-elf/pr22677.s: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove VL variants for 4FMAPS and 4VNNIW insns.
@ 2018-01-11  5:36 sergiodj+buildbot
  2018-01-11 15:58 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-11  5:36 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 888a89da7fa5d219695234c3a8dc7b8a57dfe8ee ***

Author: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
Branch: master
Commit: 888a89da7fa5d219695234c3a8dc7b8a57dfe8ee

Remove VL variants for 4FMAPS and 4VNNIW insns.

AVX512_4FMAPS and AVX512_4VNNIW insns are marked as having AVX512VL
variants.  That is wrong as SDM doesn't define such instructions. The
patch removes these VL variants.

gas/
	* testsuite/gas/i386/avx512_4fmaps-warn.l: Change xmm to zmm.
	* testsuite/gas/i386/avx512_4fmaps-warn.s: Likewise.
	* testsuite/gas/i386/avx512_4fmaps_vl-intel.d: Delete.
	* testsuite/gas/i386/avx512_4fmaps_vl-warn.l: Likewise.
	* testsuite/gas/i386/avx512_4fmaps_vl-warn.s: Likewise.
	* testsuite/gas/i386/avx512_4fmaps_vl.d: Likewise.
	* testsuite/gas/i386/avx512_4fmaps_vl.s: Likewise.
	* testsuite/gas/i386/avx512_4vnniw_vl-intel.d: Likewise.
	* testsuite/gas/i386/avx512_4vnniw_vl.d: Likewise.
	* testsuite/gas/i386/avx512_4vnniw_vl.s: Likewise.
	* testsuite/gas/i386/i386.exp: Delete _vl tests for 4fmaps an
	4vnniw tests.
	* testsuite/gas/i386/x86-64-avx512_4fmaps_vl-intel.d: Delete.
	* testsuite/gas/i386/x86-64-avx512_4fmaps_vl-warn.l: Likewise.
	* testsuite/gas/i386/x86-64-avx512_4fmaps_vl-warn.s: Likewise.
	* testsuite/gas/i386/x86-64-avx512_4fmaps_vl.d: Likewise.
	* testsuite/gas/i386/x86-64-avx512_4fmaps_vl.s: Likewise.
	* testsuite/gas/i386/x86-64-avx512_4vnniw_vl-intel.d: Likewise.
	* testsuite/gas/i386/x86-64-avx512_4vnniw_vl.d: Likewise.
	* testsuite/gas/i386/x86-64-avx512_4vnniw_vl.s: Likewise.

opcodes/
	* i386-opc.tbl: Remove VL variants for 4FMAPS and 4VNNIW
	insns.
	* i386-tbl.h: Regenerate.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] language_get_symbol_name_matcher -> get_symbol_name_matcher
@ 2018-01-11  1:53 sergiodj+buildbot
  2018-01-11  7:14 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-11  1:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 618daa933cdce21424d3759ea95a4e2f5c69a1c2 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 618daa933cdce21424d3759ea95a4e2f5c69a1c2

language_get_symbol_name_matcher -> get_symbol_name_matcher

Rename language_get_symbol_name_matcher -> get_symbol_name_matcher,
since the function is no longer a straight "language method".

gdb/ChangeLog:
2018-01-10  Pedro Alves  <palves@redhat.com>

	* language.h (language_get_symbol_name_matcher): Rename ...
	(get_symbol_name_matcher): ... this.
	* language.c (language_get_symbol_name_matcher): Ditto.
	* dictionary.c, linespec.c, minsyms.c, psymtab.c, symtab.c: All
	callers adjusted.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Ada: make verbatim matcher override other language matchers (PR gdb/22670)
@ 2018-01-11  1:05 sergiodj+buildbot
  2018-01-11  5:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-11  1:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c63d3e8d12f0b08cda95f89aa13274defed215f0 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: c63d3e8d12f0b08cda95f89aa13274defed215f0

Ada: make verbatim matcher override other language matchers (PR gdb/22670)

A previous patch fixed verbatim matching in the lookup at the minimal
symbol level, but we should also be finding that same symbol through
the partial/full symtab search.

For example, this is what happens if we use "print" instead of
"break":

    (gdb) p <MixedCaseFunc>
    $1 = {<text variable, no debug info>} 0x4024dc <MixedCaseFunc>

Before the C++ wildmatching series, GDB knows that MixedCaseFunc is a
function without parameters, and the expression above means calling
it.  If you try it before having started the inferior, you'd get the
following (expected) error:

    (gdb) print  <MixedCaseFunc>
    You can't do that without a process to debug.

The main idea behind making the name matcher be determined by the
symbol's language is so that C++ (etc.) wildmatching in linespecs
works even if the current language is not C++, as e.g., when you step
through C or assembly code.

Ada's verbatim matching syntax however ("<...>") isn't quite the same.
It is more a property of the current language than of a particular
symbol's language.  We want to support this syntax when debugging an
Ada program, but it's reason of existence is to find non-Ada symbols.
This suggests going back to enabling it depending on current language
instead of language of the symbol being matched.

I'm not entirely happy with the "current_language" reference (though I
think that it's harmless).  I think we could try storing the current
language in the lookup_name_info object, and then convert a bunch of
functions more to pass around lookup_name_info objects instead of
"const char *" names.  I.e., build the lookup_name_info higher up.
I'm not sure about that, I'll have to think more about it.  Maybe
something different will be better.  Meanwhile, this gets us going.

I've extended the testcase to also exercise a no-debug-info function,
for extra coverage of the minsyms-only paths.

gdb/ChangeLog:
2018-01-10  Pedro Alves  <palves@redhat.com>

	PR gdb/22670
	* dwarf2read.c
	(gdb_index_symbol_name_matcher::gdb_index_symbol_name_matcher):
	Adjust to use language_get_symbol_name_matcher instead of
	language_defn::la_get_symbol_name_matcher.
	* language.c (language_get_symbol_name_matcher): If in Ada mode
	and the lookup name is a verbatim match, return Ada's matcher.
	* language.h (language_get_symbol_name_matcher): Adjust comment.
	(ada_lookup_name_info::verbatim_p):: New method.

gdb/testsuite/ChangeLog:
2018-01-10  Pedro Alves  <palves@redhat.com>

	PR gdb/22670
	* gdb.ada/bp_c_mixed_case.exp: Add intro comment.  Test printing C
	functions too.  Test setting breakpoints and printing C functions
	with no debug info too.
	* gdb.ada/bp_c_mixed_case/qux.c: New file.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix gdb.ada/complete.exp's "complete break ada" test (PR gdb/22670)
@ 2018-01-11  0:21 sergiodj+buildbot
  2018-01-11  3:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-11  0:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d4c2a405cb7535d25b88e9b8dad0e557242950ca ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: d4c2a405cb7535d25b88e9b8dad0e557242950ca

Fix gdb.ada/complete.exp's "complete break ada" test (PR gdb/22670)

This patch fixes the regression covered by the test added by:

    commit 344420da6beac1e0b2f7964e7101f8dcdb509b0d
    Date: Thu Jan 4 03:30:37 2018 -0500
    Subject: Add "complete break ada" test to gdb.ada/complete.exp

The regression had been introduced by:

    commit b5ec771e60c1a0863e51eb491c85c674097e9e13
    Date:   Wed Nov 8 14:22:32 2017 +0000
    Subject: Introduce lookup_name_info and generalize Ada's FULL/WILD name matching

The gist of it is that linespec completion in Ada mode is generating
additional matches that should not appear in the match list
(internally generated symbols, or symbols that should be enclosed
between "<...>").  These extraneous entries have uppercase characters, such as:

    break ada__stringsS
    break ada__strings__R11s
    [etc]

These matches come from minimal symbols.  The problem is that Ada
minsyms end up with no language set (language_auto), and thus we end
up using the generic symbol name matcher for those instead of Ada's.
We already had a special case for in compare_symbol_name to handle
this, but it was limited to expressions, while the case at hand is
completing a linespec.  Fix this by applying the special case to
linespec completion as well.  I.e., remove the EXPRESSION check from
compare_symbol_name.  That alone turns out to not be sufficient still
-- GDB would still show a couple entries that shouldn't be there:

~~
    break ada__exceptions__exception_data__append_info_exception_name__2Xn
    break ada__exceptions__exception_data__exception_name_length__2Xn
~~

The reason is that these minimal symbols end up with their language
set to language_cplus / C++, because those encoded names manage to
demangle successfully as C++ symbols (using an old C++ mangling
scheme):

  $ echo ada__exceptions__exception_data__append_info_exception_name__2Xn | c++filt
  Xn::ada__exceptions__exception_data__append_info_exception_name(void)

It's unfortunate that Ada's encoding scheme doesn't start with some
unique prefix like "_Z" in the C++ Itanium ABI mangling scheme.  For
now, paper over that by treating C++ minsyms as Ada minsyms.

gdb/ChangeLog:
2018-01-10  Pedro Alves  <palves@redhat.com>

        PR gdb/22670
	* ada-lang.c (ada_collect_symbol_completion_matches): If the
	minsym's language is language_auto or language_cplus, pass down
	language_ada instead.
	* symtab.c (compare_symbol_name): Don't frob symbol language here.

gdb/testsuite/ChangeLog:
2018-01-10  Pedro Alves  <palves@redhat.com>

        PR gdb/22670
	* gdb.ada/complete.exp ("complete break ada"): Replace kfail with
	a fail.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix gdb.ada/bp_c_mixed_case.exp (PR gdb/22670)
@ 2018-01-10 23:32 sergiodj+buildbot
  2018-01-11  0:58 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-10 23:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8825213e97f0476068dc3b52b1b61df96b40708a ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 8825213e97f0476068dc3b52b1b61df96b40708a

Fix gdb.ada/bp_c_mixed_case.exp (PR gdb/22670)

The problem here is that we are using the user-provided lookup name
literally for name comparisons.  I.e., "<MixedCase>" with the "<>"s
included.

This commit fixes the minsym lookup case.  psymbol/symbol lookup will
be fixed in a follow up.

In the minsym case, we're using using the user-provided lookup name
literally for linkage name comparisons.  That obviously can't work
since the "<>" are not really part of the linkage name.

The original idea was that we'd use the symbol's language to select
the right symbol name matching algorithm, but that doesn't work for
Ada because it's not really possible to unambiguously tell from the
linkage name alone whether we're dealing with Ada symbols, so Ada
minsyms end up with no language set, or sometimes C++ set.

So fix this by treating Ada mode specially when determining the
linkage name to match against.

gdb/ChangeLog:
2018-01-10  Pedro Alves  <palves@redhat.com>

	PR gdb/22670
	* minsyms.c (linkage_name_str): New function.
	(iterate_over_minimal_symbols): Use it.

gdb/testsuite/ChangeLog:
2018-01-10  Pedro Alves  <palves@redhat.com>

	PR gdb/22670
	* gdb.ada/bp_c_mixed_case.exp: Remove setup_kfail calls.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: fix Disp8 handling for scalar AVX512_4FMAPS insns
@ 2018-01-10 14:58 sergiodj+buildbot
  2018-01-10 19:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-10 14:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cbda583ada32e16bf8b6c6aff730cc9eab63b364 ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: cbda583ada32e16bf8b6c6aff730cc9eab63b364

x86: fix Disp8 handling for scalar AVX512_4FMAPS insns

Just like their packed counterparts the memory operand is always 16
bytes wide, and the Disp8 scaling is the same for all of them. (As a
side note: I'm also surprised by there being AVX512VL variants of
these as well as the AVX512_4VNNIW ones - the SDM doesn't define any
such.)

Adjust the test cases also for the packed forms to actually live up to
their promise of testing correct Disp8 encoding.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: fix Disp8 handling for AVX512VL VPCMP*{B, W} variants
@ 2018-01-10 14:11 sergiodj+buildbot
  2018-01-10 16:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-10 14:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c9e9227878d172d93bcbef51dfc76d96f027751d ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: c9e9227878d172d93bcbef51dfc76d96f027751d

x86: fix Disp8 handling for AVX512VL VPCMP*{B,W} variants

In commit 2645e1d079 ("x86: add support for AVX-512 VPCMP*{B,W}
pseudo-ops") I screwed up the Disp8MemShift values of the AVX512VL
variants.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Support 'info proc' for native FreeBSD processes.
@ 2018-01-10  0:28 sergiodj+buildbot
  2018-01-10  7:56 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-10  0:28 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 92fce24de299a8b9a9a1c0c6b98e0e9c1656f99c ***

Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: 92fce24de299a8b9a9a1c0c6b98e0e9c1656f99c

Support 'info proc' for native FreeBSD processes.

- Command line arguments are fetched via the kern.proc.args.<pid>
  sysctl.
- The 'cwd' and 'exe' values are obtained from the per-process
  file descriptor table returned by kinfo_getfile() from libutil.
- 'mappings' is implemented by walking the array of VM map entries
  returned by kinfo_getvmmap() from libutil.
- 'status' output is generated by outputting fields from the structure
  returned by the kern.proc.pid.<pid> sysctl.
- 'stat' is aliased to 'status'.

gdb/ChangeLog:

	* configure.ac: Check for kinfo_getfile in libutil.
	* configure: Regenerate.
	* config.in: Regenerate.
	* fbsd-nat.c: Include "fbsd-tdep.h".
	(fbsd_fetch_cmdline): New.
	(fbsd_fetch_kinfo_proc): Move earlier and change to return a bool
	rather than calling error.
	(fbsd_info_proc): New.
	(fbsd_thread_name): Report error if fbsd_fetch_kinfo_proc fails.
	(fbsd_wait): Report warning if fbsd_fetch_kinfo_proc fails.
	(fbsd_nat_add_target): Set "to_info_proc" to "fbsd_info_proc".


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Support 'info proc' for FreeBSD process core dumps.
@ 2018-01-09 22:14 sergiodj+buildbot
  2018-01-09 23:54 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-09 22:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d2176225dc982c22640215a0e611e997e8eeb030 ***

Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: d2176225dc982c22640215a0e611e997e8eeb030

Support 'info proc' for FreeBSD process core dumps.

- Command line arguments are obtained from the pr_psargs[] array
  saved in the NT_PRPSINFO note.
- The 'cwd' and 'exe' values are obtained from the per-process file
  descriptor table stored in the NT_PROCSTAT_FILES core note.
- 'mappings' is implemented by walking the array of VM map entries
  stored in the NT_PROCSTAT_VMMAP core note.
- 'status' output is generated by outputting fields from
  the first structure stored in the NT_PROCSTAT_PROC core note.
- 'stat' is aliased to 'status'.

gdb/ChangeLog:

	* fbsd-tdep.c (KVE_STRUCTSIZE, KVE_START, KVE_END, KVE_OFFSET)
	(KVE_FLAGS, KVE_PROTECTION, KVE_PATH, KINFO_VME_PROT_READ)
	(KINFO_VME_PROT_WRITE, KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
	(KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
	(KINFO_VME_FLAG_SUPER, KINFO_VME_FLAG_GROWS_UP)
	(KINFO_VME_FLAG_GROWS_DOWN, KF_STRUCTSIZE, KF_TYPE, KF_FD)
	(KF_PATH, KINFO_FILE_TYPE_VNODE, KINFO_FILE_FD_TYPE_CWD)
	(KINFO_FILE_FD_TYPE_TEXT, SIG_WORDS, struct kinfo_proc_layout)
	(kinfo_proc_layout_32, kinfo_proc_layout_i386)
	(kinfo_proc_layout_64, fbsd_vm_map_entry_flags)
	(fbsd_core_info_proc_mappings, fbsd_core_vnode_path)
	(fbsd_core_fetch_timeval, fbsd_print_sigset)
	(fbsd_core_info_proc_status, fbsd_core_info_proc): New.
	(fbsd_init_abi):  Install gdbarch "core_info_proc" method.
	* fbsd-tdep.h (fbsd_vm_map_entry_flags): New.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [Arm] Add CSDB instruction
@ 2018-01-09 14:53 sergiodj+buildbot
  2018-01-09 18:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-09 14:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 91d8b670661883fc0472fd05cf0e54d0e357c187 ***

Author: James Greenhalgh <james.greenhalgh@arm.com>
Branch: master
Commit: 91d8b670661883fc0472fd05cf0e54d0e357c187

[Arm] Add CSDB instruction

CSDB is a new instruction which Arm has defined. As it shares the
encoding space with NOP instructions, it is available from Armv3 in
Arm mode, and Armv6T2 in Thumb mode.

OK? If so, please commit on my behalf as I don't have commit rights
over here.

Thanks, James

---
opcodes/

2018-01-09  James Greenhalgh  <james.greenhalgh@arm.com>

	* arm-dis.c (arm_opcodes): Add csdb.
	(thumb32_opcodes): Add csdb.

gas/

2018-01-09  James Greenhalgh  <james.greenhalgh@arm.com>

	* config/tc-arm.c (insns): Add csdb, enable for Armv3 and above
	in Arm execution state, and Armv6T2 and above in Thumb execution
	state.
	* testsuite/gas/arm/csdb.s: New.
	* testsuite/gas/arm/csdb.d: New.
	* testsuite/gas/arm/thumb2_it_bad.l: Add csdb.
	* testsuite/gas/arm/thumb2_it_bad.s: Add csdb.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix breakpoint add on inlined function using function name.
@ 2018-01-09 10:03 sergiodj+buildbot
  2018-01-09 14:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-09 10:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b1dc1806fad00fc5b2589164e964646c02a700fa ***

Author: Xavier Roirand <roirand@adacore.com>
Branch: master
Commit: b1dc1806fad00fc5b2589164e964646c02a700fa

Fix breakpoint add on inlined function using function name.

Using this Ada example:

  package B is
    procedure Read_Small with Inline_Always;
  end B;

  package body B is
    Total : Natural := 0;
    procedure Read_Small is
    begin
      Total := Total + 1;
    end Read_Small;
  end B;

and

  with B;

  procedure M is
  begin
    B.Read_Small;
  end M;

% gnatmake -g -O0 -m m.adb -cargs -gnatn
% gdb m

Inserting a breakpoint on Read_Small inlined function does not work:

(gdb) b read_small
Breakpoint 1 at 0x40250e: file b.adb, line 5.
(gdb) info b
Num     Type           Disp Enb Address            What
1       breakpoint     keep y   0x000000000040250e in b.doit at b.adb:5
(gdb)

In this exemple we should have two breakpoints set, one in package B and
the other one in the inlined instance inside procedure M), like below:

(gdb) b read_small
Breakpoint 1 at 0x40250e: b.adb:5. (2 locations)
(gdb) info b
Num     Type           Disp Enb Address            What
1       breakpoint     keep y   <MULTIPLE>
1.1                         y     0x000000000040250e in b.doit at b.adb:5
1.2                         y     0x0000000000402540 in m at b.adb:5
(gdb)

Looking at the DWARF info for inlined instance of Read_Small:

<1><1526>: Abbrev Number: 2 (DW_TAG_subprogram)
    <1527>   DW_AT_name        : ([...], offset: 0x1e82): b__read_small
    <152b>   DW_AT_decl_file   : 2
    <152c>   DW_AT_decl_line   : 3
    <152d>   DW_AT_inline      : 3      (declared as inline and inlined)
[...]
 <2><1547>: Abbrev Number: 4 (DW_TAG_inlined_subroutine)
    <1548>   DW_AT_abstract_origin: <0x1526>
    <154c>   DW_AT_low_pc      : 0x402552
    <1554>   DW_AT_high_pc     : 0x2b
    <155c>   DW_AT_call_file   : 1
    <155d>   DW_AT_call_line   : 5
 <2><155e>: Abbrev Number: 0

During the parsing of DWARF info in order to produce partial DIE linked
list, the DW_TAG_inlined_subroutine were skipped thus not present in the
final partial dies.
Taking DW_TAG_inlined_subroutine in account during the parsing process
fixes the problem.

gdb/ChangeLog:

        * dwarf2read.c (scan_partial_symbols, add_partial_symbol)
        (add_partial_subprogram, load_partial_dies): Add
        DW_TAG_inlined_subroutine handling.

gdb/testsuite/ChangeLog:

        * gdb.ada/bp_inlined_func: New testcase.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: Properly encode vmovd with 64-bit memeory
@ 2018-01-08 13:11 sergiodj+buildbot
  2018-01-08 21:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-08 13:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 704a705d7aaab8041df76e2981e2a1efc014aad0 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 704a705d7aaab8041df76e2981e2a1efc014aad0

x86: Properly encode vmovd with 64-bit memeory

For historical reason, we allow movd/vmovd with 64-bit register and
memeory operands.  But for vmovd, we failed to handle 64-bit memeory
operand.  This has been gone unnoticed since AT&T syntax always treats
memory operand as 32-bit memory.  This patch properly encodes vmovd
with 64-bit memeory operands.  It also removes AVX512 vmovd with 64-bit
operands since GCC has

    case TYPE_SSEMOV:
      switch (get_attr_mode (insn))
        {
        case MODE_DI:
          /* Handle broken assemblers that require movd instead of movq.  */
          if (!HAVE_AS_IX86_INTERUNIT_MOVQ
              && (GENERAL_REG_P (operands[0]) || GENERAL_REG_P (operands[1])))
            return "%vmovd\t{%1, %0|%0, %1}";
          return "%vmovq\t{%1, %0|%0, %1}";

and all AVX512 GNU assemblers set HAVE_AS_IX86_INTERUNIT_MOVQ, GCC won't
generate AVX512 vmovd with 64-bit operand.

gas/

	PR gas/22681
	* testsuite/gas/i386/i386.exp: Run x86-64-movd and
	x86-64-movd-intel.
	* testsuite/gas/i386/x86-64-movd-intel.d: New file.
	* testsuite/gas/i386/x86-64-movd.d: Likewise.
	* testsuite/gas/i386/x86-64-movd.s: Likewise.

opcodes/

	PR gas/22681
	* i386-opc.tbl: Properly encode vmovd with Qword memeory operand.
	Remove AVX512 vmovd with 64-bit operands.
	* i386-tbl.h: Regenerated.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix GDBserver build failure when $development is false
@ 2018-01-08 11:41 sergiodj+buildbot
  2018-01-08 15:56 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-08 11:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 605fd3c6590fbed834107a2e1d1df0ba58834576 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 605fd3c6590fbed834107a2e1d1df0ba58834576

Fix GDBserver build failure when $development is false

When we set bfd/development.sh:$development to false, GDBserver failed to
build,

selftest.o: In function `selftests::run_tests(char const*)':
binutils-gdb/gdb/gdbserver/../common/selftest.c:97:undefined reference to `selftests::reset()'
collect2: error: ld returned 1 exit status

selftest.o shouldn't be compiled and linked when $development is false.
With this patch, in release mode, GDBserver doesn't nothing with option
--selftest,

$ ./gdbserver --selftest=foo
Selftests are not available in a non-development build.
$ ./gdbserver --selftest
Selftests are not available in a non-development build.

gdb/gdbserver:

2018-01-08  Yao Qi  <yao.qi@linaro.org>
	    Simon Marchi  <simon.marchi@ericsson.com>

	* Makefile.in (OBS): Remove selftest.o.
	* configure.ac: Set srv_selftest_objs if $development is true.
	(GDBSERVER_DEPFILES): Append $srv_selftest_objs.
	* configure: Re-generated.
	* server.c (captured_main): Wrap variable selftest_filter with
	GDB_SELF_TEST.

gdb/testsuite:

2018-01-08  Simon Marchi  <simon.marchi@ericsson.com>

	* gdb.server/unittest.exp: Match the output in non-development
	mode.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix GDB build failure when $development is false
@ 2018-01-08 10:42 sergiodj+buildbot
  2018-01-08 14:05 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-08 10:42 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1e5ded6ce688ddee065fa852053dda07fcce959e ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 1e5ded6ce688ddee065fa852053dda07fcce959e

Fix GDB build failure when $development is false

We don't build GDB selftests bits when $development is false.  However, if
we turn bfd/development.sh:$development to false, common/selftest.c is
compiled which is not expected.  It causes the build failure,

selftest.o: In function `selftests::run_tests(char const*)':
binutils-gdb/gdb/common/selftest.c:97: undefined reference to `selftests::reset()'
collect2: error: ld returned 1 exit status

I fix this issue by putting selftest.o selftest-arch.o into CONFIG_OBS
only when $development is true.  After this is fixed, there are other
build failures in maint.c, this patch fixes them as well.

In the release mode, the output of these commands are:

(gdb) maintenance selftest
Selftests are not available in a non-development build.
(gdb) maintenance selftest foo
Selftests are not available in a non-development build.
(gdb) maintenance info selftests
Selftests are not available in a non-development build.

gdb:

2018-01-08  Yao Qi  <yao.qi@linaro.org>
	    Simon Marchi  <simon.marchi@ericsson.com>

	* Makefile.in (COMMON_SFILES): Remove selftest-arch.c and
	common/selftest.c.
	(COMMON_OBS): Remove selftest.o.
	* configure.ac: Append selftest-arch.c and common/selftest.c to
	CONFIG_SRCS.  Append selftest-arch.o and selftest.o to COMMON_OBS.
	* configure: Re-generated.
	* maint.c (maintenance_selftest): Wrap selftests::run_tests with
	GDB_SELF_TEST.
	(maintenance_info_selftests): Likewise.

gdb/testsuite:

2018-01-08  Simon Marchi  <simon.marchi@ericsson.com>

	* gdb.gdb/unittest.exp: Match output in non-development mode.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Relax expected output in gdb.ada/access_tagged_param.exp test
@ 2018-01-08 10:02 sergiodj+buildbot
  2018-01-08 12:14 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-08 10:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 30066b0b00a2c09baed08e49437c2ae3c44bc4e0 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 30066b0b00a2c09baed08e49437c2ae3c44bc4e0

Relax expected output in gdb.ada/access_tagged_param.exp test

One of the tests in gdb.ada/access_tagged_param.exp verifies
the value of the parameters being printed by GDB when stopping
at a breakpoint inside procedure Pck.Inspect.

In particular, one of these parameters is actually generated
internally by the compiler, and does only indirectly depend
on the user-level code. A recent change in AdaCore's compiler
caused the code expansion to change a little bit, and as a result,
the value of that parameter has changed from 2 to 3. This can be
evindenced by looking at the code post expansion, using the -gnatDG
command-line switch to generate the .dg files:

    $ gnatmake -g -gnatDG foo.adb
    $ vi foo.adb.dg

We can see that the call to pck.inspect used to be:

    pck__inspect (P8b, objL => 2);

With a recent version of GNAT Pro, it is now:

    pck__inspect (P9b, objL => 3);

This change causes a spurious FAIL when running this testcase.
The objL parameter being, at heart, a simple counter of the nesting
level, this commit relaxes the expected output to accept any single-
digit number. We could accept any decimal, but given the example
program, I dout that number will reach double-digit level. If it
does, we'll double-check that this is normal, and relax the expected
output further.

gdb/testsuite/ChangeLog:

        * gdb.ada/access_tagged_param.exp: Relax expected output
        for value of "ObjL" in "continue" to pck.inspect breakpoint
        test.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] (Ada) Fix print of array using non-contiguous enumeration indexes
@ 2018-01-08  5:16 sergiodj+buildbot
  2018-01-08  7:58 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-08  5:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 04bafb1ed002df1f25ca5a5773d87723a4baf46b ***

Author: Xavier Roirand <roirand@adacore.com>
Branch: master
Commit: 04bafb1ed002df1f25ca5a5773d87723a4baf46b

(Ada) Fix print of array using non-contiguous enumeration indexes

Consider the following code:

  type Index is (Index1, Index2);
  Size : constant Integer := 10;
  for Index use (Index1 => 1, Index2 => Size);
  type Array_Index_Enum is array (Index) of Integer;
  my_table : Array_Index_Enum :=(others => 42);

When compiling the code above with a compiler where the GNAT encodings
are turned off (which can be temporarily emulated by using the compiler
switch -fgnat-encodings=minimal), printing this table in gdb leads to:

  (gdb) p my_table
  $1 = (42, 42, 4203344, 10, -8320, 32767, 4203465, 0, 0, 0)

The displayed content is wrong since the handling part believes
that the length of the array is max index value (10) minus the
first index value (1) i+ 1 = 10 which is wrong since index are not
contiguous in this case.

The right behavior is to detect that the array is using enumeration
index hence parse the enumeration values in order to get the number
of indexes in this array (2 indexes here).

This patch fixes this issue and changes the output as follow:

  (gdb) p my_table
  $1 = (42, 42)

gdb/ChangeLog:

        * ada-valprint.c (val_print_packed_array_elements): Use
        proper number of elements when printing an array indexed
        by an enumeration type.

gdb/testsuite/ChangeLog (Joel Brobecker  <brobecker@adacore.com>):

        * gdb.ada/arr_enum_idx_w_gap.exp
        * gdb.ada/arr_enum_idx_w_gap/foo_q418_043.adb

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove dwarf2_per_objfile global
@ 2018-01-07 19:29 sergiodj+buildbot
  2018-01-08  4:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-07 19:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ed2dc618b3d2b0be01ffdf74c4c75504b707bcf1 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: ed2dc618b3d2b0be01ffdf74c4c75504b707bcf1

Remove dwarf2_per_objfile global

This patch removes the global variable dwarf2_per_objfile.  This global
variable is set at the various entry points of dwarf2read.c (using
dw2_setup), and is referred to throughout the file.  Instead of passing
data between functions in global variables like this one, it would be
better if the functions that depend on it either received it as argument
or got it from the existing arguments they receive.  For example, a
function receiving a reference to a dwarf2_per_cu_data can access it
from dwarf2_per_cu_data::dwarf2_per_objfile.

This patch has been tested on the buildbot.

gdb/ChangeLog:

	* dwarf2read.c (struct mapped_debug_names): Add constructor.
	<dwarf2_per_objfile>: New field.
	(dwarf2_per_objfile): Remove global.
	(get_dwarf2_per_objfile): New function.
	(set_dwarf2_per_objfile): New function.
	(dwarf2_build_psymtabs_hard): Change objfile parameter to
	dwarf2_per_objfile.
	(abbrev_table_read_table): Add dwarf2_per_objfile parameter.
	(read_abbrev_offset): Likewise.
	(read_indirect_string): Likewise.
	(read_indirect_line_string): Likewise.
	(read_indirect_string_at_offset): Likewise.
	(read_indirect_string_from_dwz): Likewise.
	(dwarf2_find_containing_comp_unit): Change objfile parameter to
	dwarf2_per_objfile.
	(age_cached_comp_units): Add dwarf2_per_objfile parameter.
	(create_all_comp_units): Change objfile parameter to
	dwarf2_per_objfile.
	(create_all_type_units): Likewise.
	(process_queue): Add dwarf2_per_objfile parameter.
	(read_and_check_comp_unit_head): Likewise.
	(lookup_dwo_unit_in_dwp): Likewise.
	(get_dwp_file): Likewise.
	(process_cu_includes): Likewise.
	(struct free_dwo_file_cleanup_data): New struct.
	(dwarf2_has_info): Use get_dwarf2_per_objfile and
	set_dwarf2_per_objfile.
	(dwarf2_get_dwz_file): Add dwarf2_per_objfile parameter.
	(dw2_do_instantiate_symtab): Get dwarf2_per_objfile from
	context, adjust calls.
	(dw2_instantiate_symtab): Likewise.
	(dw2_get_cutu): Add dwarf2_per_objfile parameter.
	(dw2_get_cu): Likewise.
	(create_cu_from_index_list): Change objfile parameter to
	dwarf2_per_objfile.
	(create_cus_from_index_list): Get dwarf2_per_objfile from
	context, adjust calls.
	(create_cus_from_index): Likewise.
	(create_signatured_type_table_from_index): Change objfile
	parameter to dwarf2_per_objfile.
	(create_signatured_type_table_from_debug_names): Change objfile
	parameter to dwarf2_per_objfile.
	(create_addrmap_from_index): Likewise.
	(create_addrmap_from_aranges): Likewise.
	(dwarf2_read_index): Use get_dwarf2_per_objfile, adjust calls.
	(dw2_setup): Remove.
	(dw2_get_file_names_reader): Get dwarf2_per_objfile from
	context.
	(dw2_find_last_source_symtab): Get dwarf2_per_objfile using
	get_dwarf2_per_objfile.
	(dw2_forget_cached_source_info): Likewise.
	(dw2_map_symtabs_matching_filename): Likewise.
	(struct dw2_symtab_iterator) <index>: Remove.
	<dwarf2_per_objfile>: New field.
	(dw2_symtab_iter_init): Replace index parameter with
	dwarf2_per_objfile.
	(dw2_symtab_iter_next): Use dwarf2_per_objfile from iter.
	(dw2_lookup_symbol): Use get_dwarf2_per_objfile and adjust.
	(dw2_print_stats): Likewise.
	(dw2_dump): Likewise.
	(dw2_expand_symtabs_for_function): Likewise.
	(dw2_expand_all_symtabs): Likewise.
	(dw2_expand_symtabs_with_fullname): Likewise.
	(dw2_expand_marked_cus): Replace index and objfile parameters
	with dwarf2_per_objfile.
	(dw_expand_symtabs_matching_file_matcher): Add
	dwarf2_per_objfile parameter and adjust calls.
	(dw2_expand_symtabs_matching): Use get_dwarf2_per_objfile and
	adjust calls.
	(dw2_find_pc_sect_compunit_symtab): Don't call dw2_setup.
	(dw2_map_symbol_filenames): Use get_dwarf2_per_objfile and
	adjust calls.
	(create_cus_from_debug_names_list): Replace objfile parameter
	with dwarf2_per_objfile and adjust calls.
	(create_cus_from_debug_names): Likewise.
	(dwarf2_read_debug_names): Likewise.
	(mapped_debug_names::namei_to_name): Adjust call.
	(dw2_debug_names_iterator::next): Likewise.
	(dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
	(dw2_debug_names_lookup_symbol): Use get_dwarf2_per_objfile.
	(dw2_debug_names_dump): Likewise.
	(dw2_debug_names_expand_symtabs_for_function): Likewise.
	(dw2_debug_names_expand_symtabs_matching): Likewise.
	(dwarf2_initialize_objfile): Likewise.
	(dwarf2_build_psymtabs): Likewise.
	(get_abbrev_section_for_cu): Get dwarf2_per_objfile from
	this_cu.
	(error_check_comp_unit_head): Add dwarf2_per_objfile parameter.
	(read_and_check_comp_unit_head): Likewise.
	(read_abbrev_offset): Likewise.
	(create_debug_type_hash_table): Likewise.
	(create_debug_types_hash_table): Likewise.
	(create_all_type_units): Replace objfile parameter with
	dwarf2_per_objfile.
	(add_type_unit): Add dwarf2_per_objfile parameter.
	(fill_in_sig_entry_from_dwo_entry): Replace objfile parameter
	with dwarf2_per_objfile.
	(lookup_dwo_signatured_type): Get dwarf2_per_objfile from cu.
	(lookup_dwp_signatured_type): Likewise.
	(lookup_signatured_type): Likewise.
	(read_cutu_die_from_dwo): Likewise.
	(init_tu_and_read_dwo_dies): Likewise.
	(init_cutu_and_read_dies): Likewise.
	(init_cutu_and_read_dies_no_follow): Likewise.
	(allocate_type_unit_groups_table): Add objfile parameter.
	(create_type_unit_group): Use dwarf2_per_objfile from cu.
	(get_type_unit_group): Likewise.
	(process_psymtab_comp_unit): Update call.
	(build_type_psymtabs_reader): Use dwarf2_per_objfile from cu.
	(build_type_psymtabs_1): Add dwarf2_per_objfile parameter.
	(print_tu_stats): Likewise.
	(build_type_psymtab_dependencies): Use dwarf2_per_objfile passed
	in void* parameter.
	(build_type_psymtabs): Change objfile parameter to
	dwarf2_per_objfile.
	(process_skeletonless_type_unit): Use dwarf2_per_objfile
	passed in void* parameter.
	(process_skeletonless_type_units): Change objfile parameter to
	dwarf2_per_objfile.
	(set_partial_user): Likewise.
	(dwarf2_build_psymtabs_hard): Likewise.
	(read_comp_units_from_section): Likewise.
	(create_all_comp_units): Likewise.
	(scan_partial_symbols): Update calls.
	(add_partial_symbol): Likewise.
	(dwarf2_read_symtab): Use get_dwarf2_per_objfile.
	(maybe_queue_comp_unit): Use dwarf2_read_symtab from cu.
	(process_queue): Add dwarf2_per_objfile parameter.
	(get_compunit_symtab): Use dwarf2_per_objfile from cu.
	(compute_compunit_symtab_includes): Likewise.
	(process_cu_includes): Add dwarf2_per_objfile parameter.
	(process_full_comp_unit): Use dwarf2_per_objfile from cu.
	(process_full_type_unit): Likewise.
	(process_imported_unit_die): Update call.
	(handle_DW_AT_stmt_list): Use dwarf2_per_objfile from cu.
	(read_file_scope): Likewise.
	(allocate_dwo_file_hash_table): Add objfile parameter.
	(lookup_dwo_file_slot): Add dwarf2_per_objfile parameter.
	(create_cus_hash_table): Likewise.
	(create_dwp_hash_table): Likewise.
	(create_dwo_unit_in_dwp_v1): Likewise.
	(create_dwp_v2_section): Likewise.
	(create_dwo_unit_in_dwp_v2): Likewise.
	(lookup_dwo_unit_in_dwp): Likewise.
	(try_open_dwop_file): Likewise.
	(open_dwo_file): Likewise. Use dwarf2_per_objfile from cu.
	(open_and_init_dwo_file): Use dwarf2_per_objfile from cu, update
	cleanup to include a reference to dwarf2_per_objfile.
	(open_dwp_file): Add dwarf2_per_objfile parameter.
	(open_and_init_dwp_file): Likewise.
	(get_dwp_file): Likewise.
	(lookup_dwo_cutu): Use dwarf2_per_objfile from cu.
	(queue_and_load_all_dwo_tus): Update call.
	(free_dwo_file_cleanup): Use dwarf2_per_objfile from cleanup
	data.
	(dwarf2_rnglists_process): Use dwarf2_per_objfile from cu.
	(dwarf2_ranges_process): Likewise.
	(dwarf2_get_pc_bounds): Likewise.
	(mark_common_block_symbol_computed): Likewise.
	(abbrev_table_read_table): Add dwarf2_per_objfile parameter.
	(dwarf2_read_abbrevs): Update call.
	(read_partial_die): Use dwarf2_per_objfile from cu.
	(find_partial_die): Likewise.
	(fixup_partial_die): Likewise.
	(read_attribute_value): Likewise.
	(read_indirect_string_at_offset_from): Add objfile parameter.
	(read_indirect_string_at_offset): Add dwarf2_per_objfile
	parameter.
	(read_indirect_string_from_dwz): Add objfile parameter.
	(read_indirect_string): Add objfile parameter.
	(read_addr_index_1): Add dwarf2_per_objfile parameter.
	(read_addr_index): Use dwarf2_per_objfile from cu.
	(dwarf2_read_addr_index): Use dwarf2_per_objfile from cu, don't
	call dw2_setup.
	(read_str_index): Use dwarf2_per_objfile from cu.
	(get_debug_line_section): Likewise.
	(read_formatted_entries): Add dwarf2_per_objfile parameter.
	(dwarf_decode_line_header): Use dwarf2_per_objfile from cu.
	(new_symbol_full): Use dwarf2_per_objfile from cu.
	(build_error_marker_type): Likewise.
	(lookup_die_type): Likewise.
	(determine_prefix): Likewise.
	(follow_die_offset): Likewise.
	(dwarf2_fetch_die_loc_sect_off): Use get_dwarf2_per_objfile.
	(dwarf2_fetch_constant_bytes): Don't call dw2_setup.
	(dwarf2_fetch_die_type_sect_off): Likewise.
	(dwarf2_get_die_type): Likewise.
	(follow_die_sig_1): Use dwarf2_per_objfile from cu.
	(get_signatured_type): Likewise.
	(get_DW_AT_signature_type): Likewise.
	(dwarf_decode_macro_bytes): Add dwarf2_per_objfile parameter.
	(dwarf_decode_macros): Use dwarf2_per_objfile from cu.
	(cu_debug_loc_section): Likewise.
	(fill_in_loclist_baton): Likewise.
	(dwarf2_symbol_mark_computed): Likewise.
	(dwarf2_find_containing_comp_unit): Change objfile parameter to
	dwarf2_per_objfile.
	(free_cached_comp_units): Use dwarf2_per_objfile passed in void*
	parameter.
	(age_cached_comp_units): Add dwarf2_per_objfile parameter.
	(free_one_cached_comp_unit): Use dwarf2_per_objfile from cu.
	(dwarf2_free_objfile): Use get_dwarf2_per_objfile.
	(set_die_type): Use dwarf2_free_objfile from cu.
	(get_die_type_at_offset): Likewise.
	(dwarf2_per_objfile_free): Don't assign global variable.
	(debug_names) <constructor>: Add dwarf2_per_objfile
	parameter, update m_debugstrlookup construction.
	(debug_names::debug_str_lookup): Add dwarf2_per_objfile
	parameter.
	<m_dwarf2_per_objfile>: New field.
	<lookup>: Use m_dwarf2_per_objfile.
	(check_dwarf64_offsets): Add dwarf2_per_objfile parameter.
	(psyms_seen_size): Likewise.
	(write_gdbindex): Replace objfile parameter with
	dwarf2_per_objfile.
	(write_debug_names): Likewise.
	(write_psymtabs_to_index): Likewise.
	(save_gdb_index_command): Use get_dwarf2_per_objfile, update
	calls.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Replace objfile field in dwarf2_cu and dwarf2_per_cu_data with dwarf2_per_objfile
@ 2018-01-07 18:45 sergiodj+buildbot
  2018-01-08  2:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-07 18:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e3b94546125849c6c513114cf20f78d2a7aa9db2 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: e3b94546125849c6c513114cf20f78d2a7aa9db2

Replace objfile field in dwarf2_cu and dwarf2_per_cu_data with dwarf2_per_objfile

The next patch aims to remove the dwarf2_per_objfile global.  In many
functions, we need to find a way to get a reference to the current
dwarf2_per_objfile through the objects passed in parameters.  Often, we have
access to a dwarf2_cu or a dwarf2_per_cu_data.  These objects have a reference
to the objfile, through which we can get the dwarf2_per_objfile:

  dwarf2_per_objfile = ((struct dwarf2_per_objfile *)
		        objfile_data (objfile, dwarf2_objfile_data_key));

However, this is a bit cumbersome to do all over the place.  It would be
more logical if the dwarf2_cu and dwarf2_per_cu_data had a reference to
their dwarf2_per_objfile, which would then have a reference to the
objfile.  It would be more in line with the object hierarchy, where
dwarf2_per_objfile owns the dwarf2_per_cu_data instances.  We could
even remove the reference dwarf2_cu has to dwarf2_per_objfile, since we
can access dwarf2_per_objfile through dwarf2_cu::per_cu.

In a graphical way, references would look like this after the current
patch:

  objfile <--- dwarf2_per_objfile <--- dwarf2_per_cu_data
                                    |      ^
				    |      |
                                    `- dwarf2_cu

This patch has been tested on the buildbot.

gdb/ChangeLog:

	* dwarf2read.c (struct dwarf2_cu) <objfile>: Remove.
	<dwarf2_per_objfile>: New field.
	(struct dwarf2_per_cu_data) <objfile>: Remove.
	<dwarf2_per_objfile>: New field.
	(create_cu_from_index_list): Assign dwarf2_per_objfile instead
	of objfile.
	(create_signatured_type_table_from_index): Likewise.
	(create_debug_type_hash_table): Likewise.
	(fill_in_sig_entry_from_dwo_entry): Likewise.
	(lookup_dwo_unit): Access objfile through dwarf2_per_objfile.
	(create_type_unit_group): Assign dwarf2_per_objfile instead of
	objfile.
	(create_partial_symtab): Access objfile through
	dwarf2_per_objfile.
	(process_psymtab_comp_unit_reader): Likewise.
	(read_comp_units_from_section): Likewise.
	(scan_partial_symbols): Likewise.
	(add_partial_symbol): Likewise.
	(add_partial_subprogram): Likewise.
	(peek_die_abbrev): Likewise.
	(fixup_go_packaging): Likewise.
	(process_full_comp_unit): Likewise.
	(process_full_type_unit): Likewise.
	(process_imported_unit_die): Likewise.
	(dwarf2_compute_name): Likewise.
	(dwarf2_physname): Likewise.
	(read_import_statement): Likewise.
	(create_cus_hash_table): Assign dwarf2_physname instead of
	objfile.
	(read_func_scope): Access objfile through dwarf2_per_objfile.
	(read_lexical_block_scope): Likewise.
	(read_call_site_scope): Likewise.
	(read_variable): Likewise.
	(dwarf2_rnglists_process): Likewise.
	(dwarf2_ranges_process): Likewise.
	(dwarf2_ranges_read): Likewise.
	(dwarf2_record_block_ranges): Likewise.
	(dwarf2_add_field): Likewise.
	(dwarf2_add_member_fn): Likewise.
	(read_structure_type): Likewise.
	(process_structure_scope): Likewise.
	(read_enumeration_type): Likewise.
	(read_array_type): Likewise.
	(read_common_block): Likewise.
	(read_namespace_type): Likewise.
	(read_namespace): Likewise.
	(read_module_type): Likewise.
	(read_tag_pointer_type): Likewise.
	(read_tag_ptr_to_member_type): Likewise.
	(read_tag_string_type): Likewise.
	(read_subroutine_type): Likewise.
	(read_typedef): Likewise.
	(read_base_type): Likewise.
	(attr_to_dynamic_prop): Likewise.
	(read_subrange_type): Likewise.
	(read_unspecified_type): Likewise.
	(load_partial_dies): Likewise.
	(read_partial_die): Likewise.
	(find_partial_die): Likewise.
	(guess_partial_die_structure_name): Likewise.
	(fixup_partial_die): Likewise.
	(read_attribute_value): Likewise.
	(read_addr_index_from_leb128): Likewise.
	(dwarf2_read_addr_index): Likewise.
	(dwarf2_string_attr): Likewise.
	(lnp_state_machine::check_line_address): Likewise.
	(dwarf_decode_lines_1): Likewise.
	(dwarf_decode_lines): Likewise.
	(dwarf2_start_symtab): Likewise.
	(var_decode_location): Likewise.
	(new_symbol_full): Likewise.
	(dwarf2_const_value_data): Likewise.
	(dwarf2_const_value_attr): Likewise.
	(dwarf2_const_value): Likewise.
	(die_type): Likewise.
	(die_containing_type): Likewise.
	(lookup_die_type): Likewise.
	(guess_full_die_structure_name): Likewise.
	(anonymous_struct_prefix): Likewise.
	(dwarf2_name): Likewise.
	(follow_die_ref_or_sig): Likewise.
	(follow_die_offset): Likewise.
	(follow_die_ref): Likewise.
	(dwarf2_fetch_die_loc_sect_off): Likewise.
	(dwarf2_fetch_constant_bytes): Likewise.
	(dwarf2_fetch_die_type_sect_off): Likewise.
	(dwarf2_get_die_type): Likewise.
	(follow_die_sig): Likewise.
	(decode_locdesc): Likewise.
	(dwarf2_per_cu_objfile): Likewise.
	(dwarf2_per_cu_text_offset): Likewise.
	(init_one_comp_unit): Assign dwarf2_per_objfile instead of
	objfile.
	(set_die_type): Access objfile through
	dwarf2_per_objfile.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make parse_debug_format_options return an std::string
@ 2018-01-07 18:03 sergiodj+buildbot
  2018-01-08  0:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-07 18:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2cc050302cd365fd28fac65d49b6c817eed74faf ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 2cc050302cd365fd28fac65d49b6c817eed74faf

Make parse_debug_format_options return an std::string

This avoid having to manually free the return value.

gdb/gdbserver/ChangeLog:

	* server.c (parse_debug_format_options): Return std::string.
	(handle_monitor_command, captured_main): Adjust.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Replace VEC(converted_character_d) with std::vector
@ 2018-01-07 17:08 sergiodj+buildbot
  2018-01-07 22:57 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-07 17:08 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b01ba14d4d5391e59fd0e1a3608fd47287edc008 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: b01ba14d4d5391e59fd0e1a3608fd47287edc008

Replace VEC(converted_character_d) with std::vector

This patch changes the usage of VEC(converted_character_d) to use an
std::vector instead.  This allows getting rid of a cleanup.

gdb/ChangeLog:

	* valprint.c (converted_character_d): Remove typedef.
	(DEF_VEC_O (converted_character_d)): Remove.
	(count_next_character): Use std::vector.
	(print_converted_chars_to_obstack): Likewise.
	(generic_printstr): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove xmethod_worker::clone
@ 2018-01-07 15:59 sergiodj+buildbot
  2018-01-07 18:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-07 15:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f979c73fd0be9a8a683f79af40c7b939c2a65d9f ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: f979c73fd0be9a8a683f79af40c7b939c2a65d9f

Remove xmethod_worker::clone

I think that the clone method of xmethod_worker can be removed.  It is
only used in find_overload_match, to clone an xmethod we want to
keep.  Instead, we can just std::move it out of the vector and into
value_from_xmethod.  value_from_xmethod creates a value that will own
the xmethod_worker from that point.  Other xmethod_workers left in the
vector will get destroyed when the vector gets destroyed, but the chosen
one will keep living inside the value struct.

gdb/ChangeLog:

	* extension.h (struct xmethod_worker) <clone>: Remove.
	* python/py-xmethods.c (struct python_xmethod_worker) <clone>:
	Remove.
	(python_xmethod_worker::clone): Remove.
	* valops.c (find_overload_match): Use std::move instead of
	clone.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] C++ify xmethod_worker, get rid of VEC(xmethod_worker_ptr)
@ 2018-01-07 14:48 sergiodj+buildbot
  2018-01-07 16:48 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-07 14:48 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ba18742c3a1b62ff218db99bee47bb932af6dab9 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: ba18742c3a1b62ff218db99bee47bb932af6dab9

C++ify xmethod_worker, get rid of VEC(xmethod_worker_ptr)

The initial goal of this patch was to remove the usage of
VEC(xmethod_worker_ptr) and corresponding cleanups.  I ended up having
to  C++ify the xmethod_worker code, to be able to have xmethod_workers
free their data in destructors, and therefore be able to use vectors of
xmethod_worker unique_ptr.

The operations in extension_language_ops that act on one instance of
xmethod_worker (get result type, get args type, invoke) are transformed
to methods of xmethod_worker.  xmethod_worker becomes an abstract base
class with virtual pure methods which python_xmethod_worker implements.
The only xmethod-related operation left in extension_language_ops is
get_matching_xmethod_workers, which returns a list of xmethod_workers.

The changes are relatively straightforward, but here are some notes on
things that may raise eyebrows:

  - I was not really comfortable with the value_of_xmethod function.  At
  first it looks like a simple getter, so I considered making it a
  method of xmethod_worker.  But actually it creates a value and
  transfers the ownership of the xmethod_worker to it.  It would be a
  bit weird and error-prone if calling a method on an object silently
  removed the ownership of the object from the caller.  To reflect the
  behavior more accurately, I renamed it to value_from_xmethod and made
  it accept an rvalue-reference (so the caller knows it gives away the
  ownership).  I noticed the backlink from xmethod_worker to its owning
  value was not used, so I removed it.

  - Some code, like get_matching_xmethod_workers, made each callee fill
  a new vector, which was then merged in the result vector.  I think
  it's safe if we always pass the same vector around, and each
  implementation just appends to it.

  - The clone operation does not seem particularly useful, it is removed
  in the following patch.

gdb/ChangeLog:

	* extension-priv.h (enum ext_lang_rc): Remove, move to extension.h.
	(struct extension_language_ops) <clone_xmethod_worker_data>: Remove.
	<free_xmethod_worker_data>: Remove.
	<get_matching_xmethod_workers>: Chance VEC to std::vector.
	<get_xmethod_arg_types>: Remove.
	<get_xmethod_result_type>: Remove.
	<invoke_xmethod>: Remove.
	* extension.c (new_xmethod_worker): Remove.
	(clone_xmethod_worker): Remove.
	(get_matching_xmethod_workers): Return void, pass std::vector by
	pointer.
	(get_xmethod_arg_types): Rename to...
	(xmethod_worker::get_arg_types): ... this, and adjust.
	(get_xmethod_result_type): Rename to...
	(xmethod_worker::get_result_type): ... this, and adjust.
	(invoke_xmethod): Remove.
	(free_xmethod_worker): Remove.
	(free_xmethod_worker_vec): Remove.
	* extension.h (enum ext_lang_rc): Move here from
	extension-priv.h.
	(struct xmethod_worker): Add constructor and destructor.
	<data>: Remove.
	<value>: Remove.
	<invoke, clone, do_get_result_type, do_get_arg_types>: New
	virtual pure methods.
	<get_arg_types, get_result_type>: New methods.
	(xmethod_worker_ptr): Remove typedef.
	(DEF_VEC_P (xmethod_worker_ptr)): Remove.
	(xmethod_worker_vec): Remove typedef.
	(xmethod_worker_up): New typedef.
	(invoke_xmethod): Remove.
	(clone_xmethod_worker): Remove.
	(free_xmethod_worker): Remove.
	(free_xmethod_worker_vec): Remove.
	(get_xmethod_arg_types): Remove.
	(get_xmethod_result_type): Remove.
	* valops.c (find_method_list): Use std::vector, don't use
	intermediate vector.
	(value_find_oload_method_list): Use std::vector.
	(find_overload_match): Use std::vector.
	(find_oload_champ): Use std::vector.
	* value.c (value_free): Use operator delete.
	(value_of_xmethod): Rename to...
	(value_from_xmethod): ... this.  Don't assign
	xmethod_worker::value, take rvalue-reference.
	(result_type_of_xmethod): Adjust.
	(call_xmethod): Adjust.
	* value.h: Include extension.h.
	(struct xmethod_worker): Don't forward-declare.
	(value_of_xmethod): Rename to...
	(value_from_xmethod): ... this, take rvalue-reference.
	* python/py-xmethods.c (struct gdbpy_worker_data): Rename to...
	(struct python_xmethod_worker): ... this, add constructor and
	destructor.
	<invoke, clone, do_get_arg_types, do_get_result_type>: Implement.
	(gdbpy_free_xmethod_worker_data): Rename to...
	(python_xmethod_worker::~python_xmethod_worker): ... this and
	adjust.
	(gdbpy_clone_xmethod_worker_data): Rename to...
	(python_xmethod_worker::clone): ... this and adjust.
	(gdbpy_get_matching_xmethod_workers): Use std::vector, don't use
	temporary vector.
	(gdbpy_get_xmethod_arg_types): Rename to...
	(python_xmethod_worker::do_get_arg_types): ... this and adjust.
	(gdbpy_get_xmethod_result_type): Rename to...
	(python_xmethod_worker::do_get_result_type): ... this and
	adjust.
	(gdbpy_invoke_xmethod): Rename to...
	(python_xmethod_worker::invoke): ... this and adjust.
	(new_python_xmethod_worker): Rename to...
	(python_xmethod_worker::python_xmethod_worker): ... this and
	adjust.
	* python/python-internal.h (gdbpy_clone_xmethod_worker_data):
	Remove.
	(gdbpy_free_xmethod_worker_data): Remove.
	(gdbpy_get_matching_xmethod_workers): Use std::vector.
	(gdbpy_get_xmethod_arg_types): Remove.
	(gdbpy_get_xmethod_result_type): Remove.
	(gdbpy_invoke_xmethod): Remove.
	* python/python.c (python_extension_ops): Remove obsolete
	callbacks.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] RISC-V: Print symbol address for jalr w/ zero offset.
@ 2018-01-06  2:13 sergiodj+buildbot
  2018-01-06  9:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-06  2:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 35eeb78fa9535df6a273c053d8f102e046261b89 ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 35eeb78fa9535df6a273c053d8f102e046261b89

RISC-V: Print symbol address for jalr w/ zero offset.

	ld/
	* testsuite/ld-riscv-elf/disas-jalr.d: New.
	* testsuite/ld-riscv-elf/disas-jalr.s: New.
	* testsuite/ld-riscv-elf/ld-riscv-elf.exp: Run new testcase.

	opcodes/
	* riscv-dis.c (print_insn_args) <'s'>: Call maybe_print_address for a
	jalr.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix gdb/spu-tdep.c build breakage
@ 2018-01-05 18:57 sergiodj+buildbot
  2018-01-06  2:24 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-05 18:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a655456c134e5e02bab33941e1c738ca33905d23 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: a655456c134e5e02bab33941e1c738ca33905d23

Fix gdb/spu-tdep.c build breakage

Commit de63c46b549d ("Fix regresssion(internal-error) printing
subprogram argument (PR gdb/22670)") missed updating spu-tdep.c for
the block_lookup_symbol interface change, resulting in:

  ../../binutils-gdb/gdb/spu-tdep.c: In function void spu_catch_start(objfile*):
  ../../binutils-gdb/gdb/spu-tdep.c:1969:59: error: cannot convert domain_enum_tag to symbol_name_match_type for argument 3 to symbol* block_lookup_symbol(const block*, const char*, symbol_name_match_type, domain_enum)
	 sym = block_lookup_symbol (block, "main", VAR_DOMAIN);
							     ^

gdb/ChangeLog:
2018-01-05  Pedro Alves  <palves@redhat.com>

	* spu-tdep.c (spu_catch_start): Pass
	symbol_name_match_type::SEARCH_NAME to block_lookup_symbol.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix gdb.ada/info_addr_mixed_case.exp (PR gdb/22670)
@ 2018-01-05 17:13 sergiodj+buildbot
  2018-01-05 23:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-05 17:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f98fc17b3ac4750842ec0fe28a18b51691ddfbda ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: f98fc17b3ac4750842ec0fe28a18b51691ddfbda

Fix gdb.ada/info_addr_mixed_case.exp (PR gdb/22670)

The comments about mixed case in the testcase are actually a red
herring.  The problem here is that we'd get to
ada_lookup_encoded_symbol with "my_table", which wraps the looked up
name in "<>"s to force a verbatim match, and that in turn disables
wild matching.

Fix this by swapping around the internals of ada_lookup_encoded_symbol
and ada_lookup_symbol, thus avoiding the encoding and
verbatim-wrapping in the ada_lookup_symbol case, the case that starts
with a user-provided lookup name.

Ada encoding is still done of course, in the ada_lookup_name_info
ctor.  This could be also seen as avoiding the double-encoding problem
in a different way.

gdb/ChangeLog:
2018-01-05  Pedro Alves  <palves@redhat.com>

	PR gdb/22670
	* ada-lang.c (ada_lookup_encoded_symbol): Reimplement in terms of
	ada_lookup_symbol.
	(ada_lookup_symbol): Reimplement in terms of
	ada_lookup_symbol_list, bits factored out from
	ada_lookup_encoded_symbol.

gdb/testsuite/ChangeLog:
2018-01-05  Pedro Alves  <palves@redhat.com>

	PR gdb/22670
	* gdb.ada/info_addr_mixed_case.exp: Remove kfail.  Extend test to
	exercise lower case too, and to exercise both full matching and
	wild matching.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] (Ada) problem printing renaming which references a subprogram parameter
@ 2018-01-05 13:34 sergiodj+buildbot
  2018-01-05 21:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-05 13:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 342f82403949c74517a6353baec73b94d18549ad ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 342f82403949c74517a6353baec73b94d18549ad

(Ada) problem printing renaming which references a subprogram parameter

Consider the following code, which creates a local variable B
which is a renaming whose expression references a subprogram
parameter:

   procedure Flip (Bits : in out Bits_Type; I : Natural) is
   begin
      declare
         B : Boolean renames Bits (I);
      begin
         B := not B; -- BREAK
      end;
   end Flip;

Trying to print the value of B when at the "BREAK" line currently
does not work:

    (gdb) p b
    Could not find i

What happens is the following: For the renaming, GNAT generates
a variable whose name is encoded as follow:

    b___XR_bits___XEXSi

GDB properly detects that variable, determines that, to compute
the variable's value, we start from the symbol "Bits", which
we then have to subscript (XS) using 'i' as the index. The error
occurs while trying to find 'i'.

This is because we forgot to pass the block in the call to
ada_lookup_encoded_symbol, which this patch fixes.

gdb/ChangeLog:

        * ada-exp.y (write_object_renaming): When subscripting an array
        using a symbol as the index, pass the block in call to
        ada_lookup_encoded_symbol when looking that symbol up.

gdb/testsuite/ChangeLog:

        * gdb.ada/rename_subscript_param: New testcase.

Tested on x86_64-linux.

Note: This requires the following GCC patch:

  | 2017-04-25  Pierre-Marie de Rodat  <derodat@adacore.com>
  |
  | * exp_dbug.adb: In Debug_Renaming_Declaration,
  | when dealing with indexed component, accept to produce a renaming
  | symbol when the index is an IN parameter or when it is a name
  | defined in an outer scope.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] (Ada) Fix Length attribute on array access
@ 2018-01-05 11:59 sergiodj+buildbot
  2018-01-05 18:18 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-05 11:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7150d33cda60fd543e9d9d68eb58d4e6155fb878 ***

Author: Jerome Guitton <guitton@adacore.com>
Branch: master
Commit: 7150d33cda60fd543e9d9d68eb58d4e6155fb878

(Ada) Fix Length attribute on array access

Consider the following variable "Indexed_By_Enum", declared as
an access to an array whose index type is an enumerated type
whose underlying values have "gaps":

   type Enum_With_Gaps is (LIT0, LIT1, LIT2, LIT3, LIT4);
   for Enum_With_Gaps use (LIT0 => 3,
                           LIT1 => 5,
                           LIT2 => 8,
                           LIT3 => 13,
                           LIT4 => 21);
   for Enum_With_Gaps'size use 16;

   type MyWord is range 0 .. 16#FFFF# ;
   for MyWord'Size use 16;

   type AR is array (Enum_With_Gaps range <>) of MyWord;
   type AR_Access is access AR;

   Indexed_By_Enum : AR_Access :=
     new AR'(LIT1 => 1,  LIT2 => 43, LIT3 => 42, LIT4 => 41);

Trying to print the length (number of elements) of this array using
the 'Length attribute does not work:

    (gdb) print indexed_by_enum'length
    'POS only defined on discrete types

The problem occurs while trying to get the array's index type.
It was using TYPE_INDEX_TYPE for that. It does not work for Ada arrays
in general; use ada_index_type instead.

gdb/ChangeLog:

	* ada-lang.c (ada_array_length): Use ada_index_type instead of
	TYPE_INDEX_TYPE.

gdb/testsuite/ChangeLog:

        * gdb.ada/arr_acc_idx_w_gap: New testcase.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] (Ada) Remove printing of array's first index when unneeded
@ 2018-01-05  7:31 sergiodj+buildbot
  2018-01-05 14:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-05  7:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e3861a03138e24e7f2f0e8c4982bdad2a6e1dbaf ***

Author: Xavier Roirand <roirand@adacore.com>
Branch: master
Commit: e3861a03138e24e7f2f0e8c4982bdad2a6e1dbaf

(Ada) Remove printing of array's first index when unneeded

Consider the following code:

  type Table is array (Character) of Natural;
  My_Table : Table := (others => 4874);

Printing this table in gdb leads to:

  (gdb) p my_table
  $1 = ('["00"]' => 4874 <repeats 256 times>)

In this case, the index of the first element in this array is also
the first element of the index type (character type). Similar to what
we do we enumeration types, we do not need to print the index of the
first element when printing the array.

This patch fixes this issue and changes the output as follow:

  (gdb) p my_table
  $1 = (4874 <repeats 256 times>)

gdb/ChangeLog:

        * ada-valprint.c (print_optional_low_bound): Handle
        character-indexed array printing like boolean-indexed array
        printing.

gdb/testuite/ChangeLog:

        * testsuite/gdb.ada/array_char_idx/pck.ads (Table): New type.
        (My_Table): New global variable.
        * testsuite/gdb.ada/array_char_idx.exp: Add test.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Bump version to 8.1.50.DATE-git.
@ 2018-01-05  5:59 sergiodj+buildbot
  2018-01-05 10:15 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-05  5:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 09aca9495c4794e586680f359e612ece173148ec ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 09aca9495c4794e586680f359e612ece173148ec

Bump version to 8.1.50.DATE-git.

Now that the GDB 8.1 branch has been created, we can
bump the version number.

gdb/ChangeLog:

	GDB 8.1 branch created (5219ac6237c272b938c28517bf371429260c71e7):
	* version.in: Bump version to 8.1.50.DATE-git.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] RISC-V: Add 2 missing privileged registers.
@ 2018-01-04 22:38 sergiodj+buildbot
  2018-01-05  0:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-04 22:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 645a2c5b46e18013ac9cb16b66ba7b6b97cd01c5 ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 645a2c5b46e18013ac9cb16b66ba7b6b97cd01c5

RISC-V: Add 2 missing privileged registers.

	gas/
	* testsuite/gas/riscv/priv-reg.s: Add missing stval and mtval.
	* testsuite/gas/riscv/priv-reg.d: Likewise.

	include/
	* opcode/riscv-opc.h (CSR_SBADADDR): Rename to CSR_STVAL.  Rename
	DECLARE_CSR entry.  Add alias to map sbadaddr to CSR_STVAL.
	(CSR_MBADADDR): Rename to CSR_MTVAL.  Rename DECLARE_CSR entry.
	Add alias to map mbadaddr to CSR_MTVAL.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdb.ada/maint_with_ada.exp: New testcase
@ 2018-01-04 11:13 sergiodj+buildbot
  2018-01-04 18:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-04 11:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7365ec2ff4a7028503f39655bd2628d54418106c ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 7365ec2ff4a7028503f39655bd2628d54418106c

gdb.ada/maint_with_ada.exp: New testcase

This commit adds a new testcase testing the "check-psymtabs" and
"check-symtabs" maintenance commands.

The "maintenance check-psymtabs" commands is currently known to
produce some errors. While the situation was admetedly made worse
by the following patch...

    commit b5ec771e60c1a0863e51eb491c85c674097e9e13
    Date:   Wed Nov 8 14:22:32 2017 +0000
    Subject: Introduce lookup_name_info and generalize Ada's FULL/WILD name matching

... hence the reference to PR gdb/22670, the command was already
spotting one inconsistency prior to it:

    (gdb) maintenance check-psymtabs
    Global symbol `interfaces__cS' only found in /[...]/b~var_arr_typedef.adb psymtab

For now, the "check-psymtab" test is KFAIL-ed.

gdb/testsuite/ChangeLog:

        PR gdb/22670
        * gdb.ada/maint_with_ada: New testcase.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add new gdb.ada/bp_c_mixed_case testcase for PR gdb/22670
@ 2018-01-04 10:28 sergiodj+buildbot
  2018-01-04 16:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-04 10:28 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 289483b6a06c7a24ee9ae9021d2728ca4700b7a6 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 289483b6a06c7a24ee9ae9021d2728ca4700b7a6

Add new gdb.ada/bp_c_mixed_case testcase for PR gdb/22670

This patch adds a new testcase to demonstrate a regression introduced by:

    commit b5ec771e60c1a0863e51eb491c85c674097e9e13
    Date:   Wed Nov 8 14:22:32 2017 +0000
    Subject: Introduce lookup_name_info and generalize Ada's FULL/WILD name matching

The purpose of the testcase is to verify that a user can insert
a breakpoint on a C function while debugging Ada, even if the name
of the function includes uppercase letters, requiring us to use
Ada's "<...>" notation to tell the GDB that the symbol name should
be looked up verbatim.

As of the commit above, GDB is no longer finding the function:

    (gdb) break <MixedCaseFunc>
    Function "<MixedCaseFunc>" not defined.
    Make breakpoint pending on future shared library load? (y or [n])

Before the patch, the breakpoint was inserted without problem.

gdb/testsuite/ChangeLog:

        PR gdb/22670
        * gdb.ada/bp_c_mixed_case: New testcase.

Tested on x86_64-linux; generates a KPASS before the regression
was introduced, and now generates a KFAIL.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Create pseudo sections for FreeBSD NT_PROCSTAT_(PROC|FILES|VMMAP) notes.
@ 2018-01-03 20:29 sergiodj+buildbot
  2018-01-03 21:53 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-03 20:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ddb2bbcf0624ef5f75c0a007c6b192c09b6fa70b ***

Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: ddb2bbcf0624ef5f75c0a007c6b192c09b6fa70b

Create pseudo sections for FreeBSD NT_PROCSTAT_(PROC|FILES|VMMAP) notes.

bfd/ChangeLog:

	* elf.c (elfcore_grok_freebsd_note): Handle
	NT_FREEBSD_PROCSTAT_PROC, NT_FREEBSD_PROCSTAT_FILES, and
	NT_FREEBSD_PROCSTAT_VMMAP.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Update year range in copyright notice of binutils files
@ 2018-01-03  7:50 sergiodj+buildbot
  2018-01-03  9:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-03  7:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 219d1afa89d0d53ca93a684cac341f16470f3ca0 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 219d1afa89d0d53ca93a684cac341f16470f3ca0

Update year range in copyright notice of binutils files


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Unbreak spurious fails in gdb.base/step-line.exp
@ 2018-01-03  4:17 sergiodj+buildbot
  2018-01-03  6:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-03  4:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bd570f80f6e47c93f4b1cc1e94688cdde33ca931 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: bd570f80f6e47c93f4b1cc1e94688cdde33ca931

Unbreak spurious fails in gdb.base/step-line.exp

My copyright year update in the copyright headers of the step-line
testcase caused it to start failing, due to shift in line numbers.

    FAIL: gdb.base/step-line.exp: continue to f1
    FAIL: gdb.base/step-line.exp: next to dummy 2
    FAIL: gdb.base/step-line.exp: next over dummy 2
    FAIL: gdb.base/step-line.exp: step into f2
    FAIL: gdb.base/step-line.exp: next over dummy 4
    FAIL: gdb.base/step-line.exp: next to dummy 5
    FAIL: gdb.base/step-line.exp: next to dummy 6
    FAIL: gdb.base/step-line.exp: next over dummy 6
    FAIL: gdb.base/step-line.exp: next to dummy 7
    FAIL: gdb.base/step-line.exp: next to dummy 8
    FAIL: gdb.base/step-line.exp: next over dummy 8
    FAIL: gdb.base/step-line.exp: next to dummy 9
    FAIL: gdb.base/step-line.exp: next to dummy 10
    FAIL: gdb.base/step-line.exp: next over dummy 10

This was caused by the copyright.py script after I changed it to
also update this testcase, which made the following transformation:

    -   Copyright (C) 2001-2017
    -   Free Software Foundation, Inc.
    +   Copyright (C) 2001-2018 Free Software Foundation, Inc.

We can easily unbreak the testcase without having to go back to
manual edits each year by adding an extra line in the header.

gdb/testsuite/ChangeLog:

	* gdb.base/step-line.c: Add extra empty line in copyright header.
        * gdb.base/step-line.inp: Likewise.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix compile time warning (in the ARM simulator) about a print statement with insufficient arguments.
@ 2018-01-02 17:37 sergiodj+buildbot
  2018-01-03  0:05 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-02 17:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 43724d16bebb38fe6794f6a3741352a7698038de ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 43724d16bebb38fe6794f6a3741352a7698038de

Fix compile time warning (in the ARM simulator) about a print statement with insufficient arguments.

	PR 22663
	* maverick.c (DSPCDP4): Add missing parameter to debug print
	statement.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [gdb/Ada] slices of arrays with dynamic strides
@ 2018-01-02  9:37 sergiodj+buildbot
  2018-01-02 20:03 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-02  9:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9fe561ab7fc5ee3a06061dae6909cd61b49435df ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 9fe561ab7fc5ee3a06061dae6909cd61b49435df

[gdb/Ada] slices of arrays with dynamic strides

    Consider the following Ada code:

       procedure Nested (L, U : Integer) is
          subtype Small_Type is Integer range L .. U;
          type Record_Type (I : Small_Type := L) is record
             S : String (1 .. I);
          end record;
          type Array_Type is array (Integer range <>) of Record_Type;

          A1 : Array_Type :=
            (1 => (I => 0, S => <>),
             2 => (I => 1, S => "A"),
             3 => (I => 2, S => "AB"));

          procedure Discard (R : Record_Type) is
          begin
             null;
          end Discard;

       begin
          Discard (A1 (1));  -- STOP
       end;

Trying to print a slice of that array currently yields:

    (gdb) p a1(1..3)
    $1 = ((i => 0, s => ""), (i => 0, s => ""), (i => 0, s => ""))

We expected instead:

    (gdb) p a1(1..3)
    $1 = ((i => 0, s => ""), (i => 1, s => "A"), (i => 2, s => "AB"))

This is because the functions we use in ada-lang.c to create the type
of the array slice (ada_value_slice and ada_value_slice_from_ptr) was
not taking into account the stride of the array. This patch fixes this.

gdb/ChangeLog:

        * ada-lang.c (ada_value_slice_from_ptr): Take array stride into
        account when creating the array type of the slice.
        (ada_value_slice): Likewise.

gdb/testsuite/ChangeLog:

        * gdb.ada/dyn_stride.exp: Add slice test.

Note that, with the current use of ada_value_slice, the enhancement
to handle dynamic array strides seems unnecessary, because I do not
see how an array with a dynamic stride can be referenced by either
by reference or pointer. Since references are coerced to array pointers,
in both cases, the slice is performed by ada_value_slice_from_ptr.
But ada_value_slice is enhanced nonetheless, in the spirit of making
the code more robust, in case we missed something, and also as similar
as possible with its from_ptr counterpart.

tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add support for dynamic DW_AT_byte_stride.
@ 2018-01-02  8:44 sergiodj+buildbot
  2018-01-02 17:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-02  8:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a405673cc5b56c260de4e1202cead709d1a4f24c ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: a405673cc5b56c260de4e1202cead709d1a4f24c

Add support for dynamic DW_AT_byte_stride.

This patch adds support for DW_AT_byte_stride, using Ada as one
example of where this would be useful. However, the implementation
is language-agnostic.

Consider the following Ada code:

   procedure Nested (L, U : Integer) is
      subtype Small_Type is Integer range L .. U;
      type Record_Type (I : Small_Type := L) is record
         S : String (1 .. I);
      end record;
      type Array_Type is array (Integer range <>) of Record_Type;

      A1 : Array_Type :=
        (1 => (I => 0, S => <>),
         2 => (I => 1, S => "A"),
         3 => (I => 2, S => "AB"));

      procedure Discard (R : Record_Type) is
      begin
         null;
      end Discard;

   begin
      Discard (A1 (1));  -- STOP
   end;

It defines an array A1 of Record_Type, which is a variant record
type whose maximum size actually depends on the value of the
parameters passed when calling Nested. As a result, the stride
of the array A1 cannot be known statically, which leads the compiler
to generate a dynamic DW_AT_byte_stride attribute for our type.
Here is what the debugging info looks like with GNAT:

        .uleb128 0x10   # (DIE (0x14e) DW_TAG_array_type)
        .long   .LASF17 # DW_AT_name: "foo__nested__T18b"
        .long   0x141   # DW_AT_byte_stride
        .long   0xdc    # DW_AT_type
        .uleb128 0x11   # (DIE (0x15f) DW_TAG_subrange_type)
        .long   0x166   # DW_AT_type
        .byte   0x3     # DW_AT_upper_bound
        .byte   0       # end of children of DIE 0x14e

There DW_AT_byte_stride is a reference to a local (internal)
variable:

        .uleb128 0x9    # (DIE (0x141) DW_TAG_variable)
        .long   .LASF6  # DW_AT_name: "foo__nested__T18b___PAD___XVZ"

This patch enhances GDB to handle this dynamic byte stride attribute
by first adding a new dynamic_prop_node_kind (DYN_PROP_BYTE_STRIDE)
to store the array dynamic stride info (when dynamic). It then enhances
the dynamic type resolver to handle this dynamic property.

Before applying this patch, trying to print the value of some of
A1's elements after having stopped at the "STOP" comment does not
work. For instance:

    (gdb) p a1(2)
    Cannot access memory at address 0x80000268dec0

With this patch applied, GDB now prints the value of all 3 elements
correctly:

    (gdb) print A1(1)
    $1 = (i => 0, s => "")
    (gdb) print A1(2)
    $2 = (i => 1, s => "A")
    (gdb) print A1(3)
    $3 = (i => 2, s => "AB")

gdb/ChangeLog:

        * gdbtypes.h (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_STRIDE>:
        New enum value.
        (create_array_type_with_stride): Add byte_stride_prop parameter.
        * gdbtypes.c (create_array_type_with_stride) <byte_stride_prop>:
        New parameter.  Update all callers in this file.
        (array_type_has_dynamic_stride): New function.
        (is_dynamic_type_internal, resolve_dynamic_array): Add handling
        of arrays with dynamic byte strides.
        * dwarf2read.c (read_array_type): Add support for dynamic
        DW_AT_byte_stride attributes.

gdb/testsuite/ChangeLog:

        * gdb.ada/dyn_stride: New testcase.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] treat Ada DW_TAG_unspecified_type DIEs as stub types
@ 2018-01-02  7:54 sergiodj+buildbot
  2018-01-02 15:29 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-02  7:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 74a2f8ffb83172de1af0da6751a65c08a722986f ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 74a2f8ffb83172de1af0da6751a65c08a722986f

treat Ada DW_TAG_unspecified_type DIEs as stub types

Consider the gdb.ada/taft_type.exp testcase, which exercises
the situation where a variable is defined using a type which
is a pointer to an incomplete type, with the actual type
definition being provided by another unit. Up to now, the
strategy used by GNAT when generating the DWARF debugging info
was to produce a incomplete DW_TAG_enumeration_type DIE with
a DW_AT_declaration flag attached to it:

        .uleb128 0x4    # (DIE (0x3e) DW_TAG_enumeration_type)
        .long   .LASF4  # DW_AT_name: "pck__empty"
                        # DW_AT_declaration

However, a more standard way for the compiler to describe
this kind of type is to use the DW_TAG_unspecified_type tag.
When the compiler is enhanced to do so, we'll need to treat
such types as stubs -- we only do so with types from Ada units,
however, as the meaning of this TAG is intentionally left
permissive and language-specific by the DWARF standard.

Without this patch, running the testcase above with an enhanced
compiler now yields:

    (gdb) print w.e.all
    Attempt to dereference a generic pointer.
    FAIL: gdb.ada/taft_type.exp: print w.e.all

gdb/ChangeLog:

	* dwarf2read.c (read_unspecified_type): Treat
        DW_TAG_enumeration_type DIEs from Ada units as stubs.

Tested on x86_64-linux, fixes the FAIL in gdb.ada/taft_type.exp above.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Update copyright year range in all GDB files
@ 2018-01-02  6:58 sergiodj+buildbot
  2018-01-02 13:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-02  6:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e2882c85786571175a0b0bfc3bcd2f14620b1ea3 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: e2882c85786571175a0b0bfc3bcd2f14620b1ea3

Update copyright year range in all GDB files

gdb/ChangeLog:

        Update copyright year range in all GDB files


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Update copyright year in version message of GDB, GDBserver and GDBreplay
@ 2018-01-02  4:44 sergiodj+buildbot
  2018-01-02  7:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-02  4:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 82e1e79a420734bcb1fa255a1e7b3250e6acee65 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 82e1e79a420734bcb1fa255a1e7b3250e6acee65

Update copyright year in version message of GDB, GDBserver and GDBreplay

gdb/ChangeLog:

	* top.c (print_gdb_version): Update Copyright year in version
	message.

gdb/gdbserver/ChangeLog:

	* gdbreplay.c (gdbreplay_version): Update copyright year in
	version message.
	* server.c (gdbserver_version): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Yearly rotation of the gdb/ChangeLog file
@ 2018-01-02  3:57 sergiodj+buildbot
  2018-01-02  5:29 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2018-01-02  3:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 053f54e57f64ca88596999f37bf3bd329b497d20 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 053f54e57f64ca88596999f37bf3bd329b497d20

Yearly rotation of the gdb/ChangeLog file

gdb/ChangeLog

        * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2017.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Avoid indexing std::vector past the end
@ 2017-12-31 11:04 sergiodj+buildbot
  2017-12-31 16:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-31 11:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 47fea877452b84b94ac6ffb26f194f12845526fa ***

Author: Ruslan Kabatsayev <b7.10110111@gmail.com>
Branch: master
Commit: 47fea877452b84b94ac6ffb26f194f12845526fa

Avoid indexing std::vector past the end

The code here wants to find address of an element, and often this
element is one past the end of std::vector. Dereferencing that element
leads to undefined behavior, so it's better to simply use pointer
arithmetic instead of taking address of invalid dereference.

gdb/ChangeLog:

	* psymtab.c (recursively_search_psymtabs): Use pointer arithmetic
	instead of dereferencing std::vector past the end.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Only ignore -Wenum-compare-switch if it exists
@ 2017-12-31  4:57 sergiodj+buildbot
  2017-12-31  6:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-31  4:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cfa27c399ec9236a100ef794505d35f60da41a6d ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: cfa27c399ec9236a100ef794505d35f60da41a6d

Only ignore -Wenum-compare-switch if it exists

My patch

  dwarf2read: Silence -Wenum-compare-switch warning
  132448f8359a268f34f074b0908b5255b568da06

made some parts of dwarf2read.c ignore warnings about switch using enums
of different kinds.  What I did not realize was that older Clang
versions (prior to 6) did not have that warning, and therefore give this
error:

/home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:24187:7: error: unknown warning group '-Wenum-compare-switch', ignored [-Werror,-Wunknown-pragmas]
      DIAGNOSTIC_IGNORE_SWITCH_DIFFERENT_ENUM_TYPES
      ^
/home/emaisin/src/binutils-gdb/gdb/common/diagnostics.h:42:3: note: expanded from macro 'DIAGNOSTIC_IGNORE_SWITCH_DIFFERENT_ENUM_TYPES'
  DIAGNOSTIC_IGNORE ("-Wenum-compare-switch")
  ^
/home/emaisin/src/binutils-gdb/gdb/common/diagnostics.h:27:3: note: expanded from macro 'DIAGNOSTIC_IGNORE'
  _Pragma (STRINGIFY (GCC diagnostic ignored option))
  ^
<scratch space>:10:25: note: expanded from here
 GCC diagnostic ignored "-Wenum-compare-switch"
                        ^

Clang has a way to test if it knows about a particular warning.  This
patch uses that feature to only define
DIAGNOSTIC_IGNORE_SWITCH_DIFFERENT_ENUM_TYPES to something if the
warning is recognized by the Clang version being used.  I tested
building dwarf2read.c with clang 4, 5, 6, as well as gcc.

gdb/ChangeLog:

	* common/diagnostics.h
	(DIAGNOSTIC_IGNORE_SWITCH_DIFFERENT_ENUM_TYPES): Only
	define if the compiler knows about -Wenum-compare-switch.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make mapped_debug_names and mapped_index final
@ 2017-12-30  7:02 sergiodj+buildbot
  2017-12-30  8:20 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-30  7:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fc898b42e355fef58e6a029799fdd71b9dda5dc6 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: fc898b42e355fef58e6a029799fdd71b9dda5dc6

Make mapped_debug_names and mapped_index final

When compiling with Clang 6, I see these warnings:

/home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:25421:5: error: destructor called on non-final 'mapped_index' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
    data->index_table->~mapped_index ();
    ^
In file included from /home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:31:
In file included from /home/emaisin/src/binutils-gdb/gdb/defs.h:28:
In file included from /home/emaisin/src/binutils-gdb/gdb/common/common-defs.h:92:
In file included from /home/emaisin/src/binutils-gdb/gdb/common/gdb_unique_ptr.h:23:
In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/memory:81:
/usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/unique_ptr.h:76:2: error: delete called on non-final 'mapped_debug_names' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
        delete __ptr;
        ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/unique_ptr.h:236:4: note: in instantiation of member function 'std::default_delete<mapped_debug_names>::operator()' requested here
          get_deleter()(__ptr);
          ^
/home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:2374:21: note: in instantiation of member function 'std::unique_ptr<mapped_debug_names, std::default_delete<mapped_debug_names> >::~unique_ptr' requested here
dwarf2_per_objfile::dwarf2_per_objfile (struct objfile *objfile_,
                    ^

This patch silences these warnings by making the classes final.

gdb/ChangeLog:

	* dwarf2read.c (struct mapped_debug_names): Make final.
	(struct mapped_index): Make final.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove unnecessary call to get_thread_db_info
@ 2017-12-30  3:17 sergiodj+buildbot
  2017-12-30  5:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-30  3:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 502a625ab01da27e851333b598c893d6f2c20bd0 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 502a625ab01da27e851333b598c893d6f2c20bd0

Remove unnecessary call to get_thread_db_info

In thread_db_detach, we call get_thread_db_info to first check if there
exists a thread_db_info entry for the pid to detach.  If there is, then
we call delete_thread_db_info.  It's unnecessary to call
get_thread_db_info in the first place, since delete_thread_db_info
handles the case where no thread_db_info entry exist for the given pid.

gdb/ChangeLog:

	* linux-thread-db.c (thread_db_detach): Remove call to
	delete_thread_db_info.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] RISC-V: Add missing privileged spec registers.
@ 2017-12-28 21:41 sergiodj+buildbot
  2017-12-28 23:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-28 21:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d9be0c189a9a9b77a6bf4501f8891544b8ce9593 ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: d9be0c189a9a9b77a6bf4501f8891544b8ce9593

RISC-V: Add missing privileged spec registers.

	gas/
	* testsuite/gas/riscv/priv-reg.d, testsuite/gas/riscv/priv-reg.s: New.

	include/
	* opcode/riscv-opc.h (DECLARE_CSR): Add missing privileged registers.
	Sort to match privileged spec documentation order.
	(DECLARE_CSR_ALIAS): Add ubadaddr, and comments.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p
@ 2017-12-27 17:51 sergiodj+buildbot
  2017-12-28  0:29 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-27 17:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cef0f8684e818f8b6c71c44dc9cc28a6d0ac3754 ***

Author: Stafford Horne <shorne@gmail.com>
Branch: master
Commit: cef0f8684e818f8b6c71c44dc9cc28a6d0ac3754

tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p

tdesc_register_in_reggroup_p in now able to handle arbitrary
groups. This is useful when groups are created while the
target descriptor file is received from the remote.

This can be the case of a soft core target processor where
registers/groups can change.

gdb/ChangeLog:

yyyy-mm-dd  Franck Jullien  <franck.jullien@gmail.com>
	    Stafford Horne  <shorne@gmail.com>

	* target-descriptions.c (tdesc_register_in_reggroup_p): Support
	arbitrary strings.
	(tdesc_use_registers): Add logic to register new reggroups.
	(tdesc_reg::group): Update comment to indicate we allow
	arbitrary strings.
	* NEWS (Changes since GDB 8.0): Announce that GDB supports
	arbitrary reggroups.

gdb/testsuite/ChangeLog:

yyyy-mm-dd  Stafford Horne  <shorne@gmail.com>

	* gdb.xml/extra-regs.xml: Add example foo reggroup.
	* gdb.xml/tdesc-regs.exp: Add test to check for foo reggroup.

gdb/doc/ChangeLog:

yyyy-mm-dd  Stafford Horne  <shorne@gmail.com>

	* gdb.texinfo (Target Description Format): Explain that arbitrary
	strings are now allowed for register groups.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] reggroups: Convert reggroups from post_init to pre_init
@ 2017-12-27 15:46 sergiodj+buildbot
  2017-12-27 19:29 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-27 15:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c1166ca9f3543b28e8b0057ecaf2cd3251cd51c5 ***

Author: Stafford Horne <shorne@gmail.com>
Branch: master
Commit: c1166ca9f3543b28e8b0057ecaf2cd3251cd51c5

reggroups: Convert reggroups from post_init to pre_init

Currently the reggroups gdbarch_data cannot be manipulated until after
the gdbarch is completely initialized.  This is usually done when the
object init depends on architecture specific fields.  In the case of
reggroups it only depends on the obstack being available.

Coverting this to pre_init allows using reggroups during gdbarch
initialization.  This is needed to allow registering arbitrary reggroups
during gdbarch initializations.

gdb/ChangeLog:

yyyy-mm-dd  Stafford Horne  <shorne@gmail.com>

	* reggroups.c (reggroups_init): Change to depend only on
	obstack rather than gdbarch.
	(reggroup_add): Remove logic for forcing premature init.
	(_initialize_reggroup): Set `reggroups_data` with
	gdbarch_data_register_pre_init() rather than
	gdbarch_data_register_post_init().


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] reggroups: Add test and docs for `info reg $reggroup` feature
@ 2017-12-27 15:03 sergiodj+buildbot
  2017-12-27 16:24 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-27 15:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b67d92b06e6155a392a0c2d413f87d050880dbf4 ***

Author: Stafford Horne <shorne@gmail.com>
Branch: master
Commit: b67d92b06e6155a392a0c2d413f87d050880dbf4

reggroups: Add test and docs for `info reg $reggroup` feature

Until now this feature has existed but was not documented.  Adding docs
and tests.

gdb/ChangeLog:

yyyy-mm-dd  Stafford Horne  <shorne@gmail.com>

	* infcmd.c (_initialize_infcmd): Add help for info reg $reggroup
	and info all-registers $reggroup feature.

gdb/doc/ChangeLog:

yyyy-mm-dd  Stafford Horne  <shorne@gmail.com>

	* gdb.texinfo (Registers): Document info reg $reggroup feature.

gdb/testsuite/ChangeLog:

yyyy-mm-dd  Stafford Horne  <shorne@gmail.com>

	* gdb.base/reggroups.c: New file.
	* gdb.base/reggroups.exp: New file.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add ATTRIBUTE_PRINTF to printf_field_type_assignment
@ 2017-12-23 21:51 sergiodj+buildbot
  2017-12-23 23:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-23 21:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6e8c24fe27098f407000812e61fa8210095a7970 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 6e8c24fe27098f407000812e61fa8210095a7970

Add ATTRIBUTE_PRINTF to printf_field_type_assignment

Get rid of:

/home/simark/src/binutils-gdb/gdb/target-descriptions.c:2026:25: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
    vprintf_unfiltered (fmt, args);

when building with clang.

gdb/ChangeLog:

	* target-descriptions.c (print_c_tdesc)
	<printf_field_type_assignment>: Add ATTRIBUTE_PRINTF.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Do not emit "field_type" var if not needed on "maint print c-tdesc"
@ 2017-12-21 23:57 sergiodj+buildbot
  2017-12-22  1:44 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-21 23:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a8d2e5856f87a658d69018fe1ccd56482eebdd59 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: a8d2e5856f87a658d69018fe1ccd56482eebdd59

Do not emit "field_type" var if not needed on "maint print c-tdesc"

While fiddling a bit with -Wunused-variable, Sergio noticed that "maint
print c-tdesc" was always generating code for the "tdesc_type
*field_type" variable, even when it wasn't used.  This is caught by GCC
when using -Wunused-variable, of course.

This patch changes the print_c_tdesc class to only output the field
declaration when we actually need it.

It shouldn't be necessary to do the same with the other variable
declarations (type_with_fields and element_type), because they are
always if they are declared.

The C files in features/ are regenerated, some declarations of
field_type are removed, as expected, while some others move to where
they are used for the first time.

gdb/ChangeLog:

	* target-descriptions.c (print_c_tdesc) <visit>: Don't output
	field_type declaration, use printf_field_type_assignment
	instead.
	<printf_field_type_assignment>: New method.
	* features/aarch64-core.c, features/aarch64-fpu.c
	features/arc-arcompact.c, features/arc-v2.c,
	features/arm/arm-with-iwmmxt.c, features/i386/32bit-core.c,
	features/i386/32bit-mpx.c, features/i386/32bit-sse.c,
	features/i386/64bit-avx512.c, features/i386/64bit-core.c,
	features/i386/64bit-mpx.c, features/i386/64bit-sse.c,
	features/i386/x32-core.c, features/or1k.c,
	features/rs6000/powerpc-7400.c,
	features/rs6000/powerpc-altivec32.c,
	features/rs6000/powerpc-altivec32l.c,
	features/rs6000/powerpc-altivec64.c,
	features/rs6000/powerpc-altivec64l.c,
	features/rs6000/powerpc-cell32l.c,
	features/rs6000/powerpc-cell64l.c,
	features/rs6000/powerpc-isa205-altivec32l.c,
	features/rs6000/powerpc-isa205-altivec64l.c,
	features/rs6000/powerpc-isa205-vsx32l.c,
	features/rs6000/powerpc-isa205-vsx64l.c,
	features/rs6000/powerpc-vsx32.c,
	features/rs6000/powerpc-vsx32l.c,
	features/rs6000/powerpc-vsx64.c,
	features/rs6000/powerpc-vsx64l.c, features/s390-gs-linux64.c,
	features/s390-tevx-linux64.c, features/s390-vx-linux64.c,
	features/s390x-gs-linux64.c, features/s390x-tevx-linux64.c,
	features/s390x-vx-linux64.c: Re-generate.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] RISC-V: Add compressed instruction hints, and a few misc cleanups.
@ 2017-12-20 21:59 sergiodj+buildbot
  2017-12-21  0:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-20 21:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 21a186f28061ea51e422ae47d062793ceac2180f ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 21a186f28061ea51e422ae47d062793ceac2180f

RISC-V: Add compressed instruction hints, and a few misc cleanups.

	gas/
	* config/tc-riscv.c (risc_ip) <o>: Add comment.
	* testsuite/gas/riscv/c-nonzero-imm.d,
	* testsuite/gas/riscv/c-nonzero-imm.l,
	* testsuite/gas/riscv/c-nonzero-imm.s,
	* testsuite/gas/riscv/c-nonzero-reg.d,
	* testsuite/gas/riscv/c-nonzero-reg.l,
	* testsuite/gas/riscv/c-nonzero-reg.s,
	* testsuite/gas/riscv/c-zero-imm-64.d,
	* testsuite/gas/riscv/c-zero-imm-64.s,
	* testsuite/gas/riscv/c-zero-imm.d, testsuite/gas/riscv/c-zero-imm.s,
	* testsuite/gas/riscv/c-zero-reg.d,
	* testsuite/gas/riscv/c-zero-reg.s: New.

	opcodes/
	* riscv-opc.c (match_c_add_with_hint, match_c_lui_with_hint): New.
	(riscv_opcodes) <li>: Delete "d,0" line.  Change Cj to Co.
	<andi, and, add, addiw, addw, c.addi>: Change Cj to Co.
	<add>: Add explanatory comment for 4-operand add instruction.
	<c.nop>: Add support for immediate operand.
	<c.mv, c.add>: Use match_c_add_with_hint instead of match_c_add.
	<c.lui>: Use match_c_lui_with_hint instead of match_c_lui.
	<c.li, c.slli>: Use match_opcode instead of match_rd_nonzero.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [Cell/B.E.] Fix regression due to gdbarch_significant_addr_bit
@ 2017-12-20 13:37 sergiodj+buildbot
  2017-12-20 16:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-20 13:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 396d3980f518cfc9a936e3fb8138b0492399525a ***

Author: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Branch: master
Commit: 396d3980f518cfc9a936e3fb8138b0492399525a

[Cell/B.E.] Fix regression due to gdbarch_significant_addr_bit

On Cell/B.E. multi-architecture debugging we use a "merged" address space
that encodes both the main PowerPC address space and the local store address
spaces of all active SPUs.  This will always occupy 64 bits.

However, gdbarch_addr_bit is set to 32 on SPU, and may be set to 32 as well
on PowerPC.  Since the new gdbarch_significant_addr_bit defaults to the
value of gdbarch_addr_bit, this means addresses may be improperly truncated.

Work around this problem by explicitly setting gdbarch_significant_addr_bit
to 64 both for the SPU target and also for PowerPC target that support
Cell/B.E. execution.

gdb/ChangeLog:
2017-12-20  Ulrich Weigand  <uweigand@de.ibm.com>

	* spu-tdep.c (spu_gdbarch_init): Set set_gdbarch_significant_addr_bit
	to 64 bits.
	(ppc_linux_init_abi): Likewise, if Cell/B.E. is supported.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR22626, invalid dynindx used for dynamic relocs against section syms
@ 2017-12-18 22:34 sergiodj+buildbot
  2017-12-18 23:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-18 22:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 63f452a8bfd9c89b56dcc087cea84151e7a9ec24 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 63f452a8bfd9c89b56dcc087cea84151e7a9ec24

PR22626, invalid dynindx used for dynamic relocs against section syms

_bfd_elf_link_renumber_dynsyms is called twice by the linker.  The
first call in bfd_elf_size_dynamic_sections is just to answer the
question as to whether there are there any dynamic symbols.  The
second call in bfd_elf_size_dynsym_hash_dynstr sets the st_shndx value
that dynamic symbols will have.  strip_excluded_output_sections is
called between these two calls.  So sections seen on the first
_bfd_elf_link_renumber_dynsyms pass might differ from those seen on
the second pass.  Unfortunately, that can result in a stripped
section's dynamic symbol being assigned a dynindx on the first pass
but not corrected to the final value (of zero, ie. not dynamic) on the
second pass.  PowerPC, x86, mips, and most other targets that emit
dynamic section symbols, just test that section symbol dynindx is
non-zero before using a given section symbol in dynamic relocations.

This patch prevents _bfd_elf_link_renumber_dynsyms from setting any
section symbol dynindx on the first pass.

	PR 22626
	* elflink.c (_bfd_elf_link_renumber_dynsyms): Don't set section
	dynindx when section_sym_count is NULL.
	(bfd_elf_size_dynamic_sections): Pass NULL section_sym_count to
	preliminary _bfd_elf_link_renumber_dynsyms call.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: fold certain AVX and AVX2 templates
@ 2017-12-18 11:26 sergiodj+buildbot
  2017-12-18 14:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-18 11:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 10c17abdd052c5f8f9c2bcdf8b01dffe5d06baf0 ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 10c17abdd052c5f8f9c2bcdf8b01dffe5d06baf0

x86: fold certain AVX and AVX2 templates

Just like for instructions in GPRs, there's no need to have separate
templates for otherwise identical insns acting on XMM or YMM registers
(or memory of the same size).


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: fold RegXMM/RegYMM/RegZMM into RegSIMD
@ 2017-12-18 10:42 sergiodj+buildbot
  2017-12-18 13:22 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-18 10:42 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1b54b8d7e4fc8055f9220a5287e8a94d8a65a88d ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 1b54b8d7e4fc8055f9220a5287e8a94d8a65a88d

x86: fold RegXMM/RegYMM/RegZMM into RegSIMD

... qualified by their respective sizes, allowing to drop FirstXmm0 at
the same time.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: drop FloatReg and FloatAcc
@ 2017-12-18  9:35 sergiodj+buildbot
  2017-12-18 12:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-18  9:35 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ca0d63fe0703ed36af1a7bda6097958805895b3a ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: ca0d63fe0703ed36af1a7bda6097958805895b3a

x86: drop FloatReg and FloatAcc

Express them as Reg|Tbyte and Acc|Tbyte respectively.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: replace Reg8, Reg16, Reg32, and Reg64
@ 2017-12-18  8:56 sergiodj+buildbot
  2017-12-18 10:50 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-18  8:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT dc821c5f9ae5208ad1ec438718f75e224f856deb ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: dc821c5f9ae5208ad1ec438718f75e224f856deb

x86: replace Reg8, Reg16, Reg32, and Reg64

Use a combination of a single new Reg bit and Byte, Word, Dword, or
Qword instead.

Besides shrinking the number of operand type bits this has the benefit
of making register handling more similar to accumulator handling (a
generic flag is being accompanied by a "size qualifier"). It requires,
however, to split a few insn templates, as it is no longer correct to
have combinations like Reg32|Reg64|Byte. This slight growth in size will
hopefully be outweighed by this change paving the road for folding a
presumably much larger number of templates later on.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] improved error message when getting an exception printing a variable
@ 2017-12-18  4:51 sergiodj+buildbot
  2017-12-18  8:33 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-18  4:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT eccab96d54a9455557d3c4d5bff431f6e526d0b7 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: eccab96d54a9455557d3c4d5bff431f6e526d0b7

improved error message when getting an exception printing a variable

Consider the following Ada code defining a global variable whose
type is an array of static bounds (1 .. 2), but where its elements
are a variant record whose size is not statically known:

    type Ints is array (Natural range <>) of Integer;
    type Bounded_Ints (Max_Size : Natural) is record
       Length : Natural := 0;
       Objs   : Ints (1 .. Max_Size);
    end record;

    type Ints_Doubled is array (1 .. 2) of Bounded_Ints (Idem (0));

    Global : Ints_Doubled;

When compiling this program at -O2 using a GCC-6.4-based compiler
on x86_64-linux, trying to print the value of that global variable
yields:

    (gdb) p global
    $1 =

Let's look at the debugging info, which starts with the global
variable itself...

        .uleb128 0x19   # (DIE (0x25e) DW_TAG_variable)
        .long   .LASF32 # DW_AT_name: "fd__global"
        .long   0x273   # DW_AT_type

... its type is a reference to a typedef ...

        .uleb128 0x14   # (DIE (0x273) DW_TAG_reference_type)
        .byte   0x8     # DW_AT_byte_size
        .long   0x202   # DW_AT_type
        [...]
        .uleb128 0x15   # (DIE (0x202) DW_TAG_typedef)
        .long   .LASF19 # DW_AT_name: "fd__ints_doubled"
        .long   0x20d   # DW_AT_type

... of an array (1..2) ...

        .uleb128 0x2    # (DIE (0x20d) DW_TAG_array_type)
        .long   .LASF19 # DW_AT_name: "fd__ints_doubled"
        .long   0x15b   # DW_AT_type
        .long   0x221   # DW_AT_sibling
        .uleb128 0x16   # (DIE (0x21a) DW_TAG_subrange_type)
        .long   0x40    # DW_AT_type
        .sleb128 2      # DW_AT_upper_bound
        .byte   0       # end of children of DIE 0x20d

... of a struct whose name is fd__Tints_doubledC:

        .uleb128 0x10   # (DIE (0x15b) DW_TAG_structure_type)
        .long   .LASF11 # DW_AT_name: "fd__Tints_doubledC"
        .long   0x1e4   # DW_AT_GNAT_descriptive_type
                        # DW_AT_artificial
        .long   0x1e4   # DW_AT_sibling
        .uleb128 0x7    # (DIE (0x16a) DW_TAG_member)
        .long   .LASF4  # DW_AT_name: "max_size"
        [snip]

The error occurs while Ada evaluator is trying to "fix"
the element type inside the array, so as to determine its actual
size. For that, it searches for a parallel "XVZ" variable,
which, when found, contains the object's actual size.

Unfortunately in our case, the variable exists but has been
optimized out, as seen by the presence of a variable DIE in
the debugging info, but with no address attribute:

        .uleb128 0x18   # (DIE (0x24e) DW_TAG_variable)
        .long   .LASF31 # DW_AT_name: "fd__Tints_doubledC___XVZ"
        .long   0x257   # DW_AT_type
                        # DW_AT_artificial

Discussing this with some members of AdaCore's compiler team,
it is expected that the optimizer can get rid of this variable,
and we don't want to pessimize the code just to improve debuggability,
since -O2 is about performance. So, the idea of this patch is
not to make it work, but provide a bit more information to help
users understand what kind of error is preventing GDB from being
able to print the variable's value.

The first hurdle we had to clear was the fact that ada_val_print
traps all exceptions (including QUIT ones!), and does so completly
silently. So, the fix was to add a trace of the exception being
generated. While doing so, we fix an old XXX/FIXME by only catching
errors, letting QUIT exceptions go through.

Once this is done, we now get an error message, which gives a first
clue as to what was happening:

    (gdb) p fd.global
    $1 = <error reading variable: value has been optimized out>

However, it would be more useful to know which value it was
that was optimized out. For that purpose, we enhanced
ada-lang.c::ada_to_fixed_type_1 so as to re-throw the error
with a message which indicates which variable we failed to read.

With those changes, the new output is now:

    (gdb) p fd.global
    $1 = <error reading variable: unable to read value of fd__Tints_doubledC___XVZ (value has been optimized out)>

gdb/ChangeLog:

        * ada-lang.c (ada_to_fixed_type_1): Rethrow errors with
        a more detailed exception message when getting an exception
        while trying to read the value of an XVZ variable.
        * ada-valprint.c (ada_val_print): Only catch RETURN_MASK_ERROR
        exceptions.  Print an error message when an exception is caught.

gdb/testsuite/ChangeLog:

        * gdb.dwarf2/ada-valprint-error.c: New file.
        * gdb.dwarf2/ada-valprint-error.exp: New file.

Tested on x86_64-linux


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] (Ada) crash assigning to record component which is an array
@ 2017-12-18  4:13 sergiodj+buildbot
  2017-12-18  6:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-18  4:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0e2da9f01334a01d1a6e224ecd592d6fbbb22515 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 0e2da9f01334a01d1a6e224ecd592d6fbbb22515

(Ada) crash assigning to record component which is an array

Consider the following code, which declares a variabled called "input"
of type "parameter", which is a record with one component called "u2",
where the type of that component is a simple 3-element array of
floating point values:

   type Float_Array_3 is array (1 .. 3) of Float;
   type parameters is record
      u2 : Float_Array_3;
   end record;
   input : parameters;

Trying to assign a value to input.u2 causes GDB to crash:

    (gdb) p input.u2 := (0.25,0.5,0.75)
    [1]    20228 segmentation fault (core dumped) [...]/gdb

The crash occurs because input.u2 is described in the debugging
info as a typedef of an array. Indeed, input's type is:

 <1><ae9>: Abbrev Number: 7 (DW_TAG_structure_type)
    <aea>   DW_AT_name        : (indirect string, offset: 0x1045): target_wrapper__parameters
    [...]
 <2><af5>: Abbrev Number: 8 (DW_TAG_member)
    <af6>   DW_AT_name        : u2
    [...]
    <afb>   DW_AT_type        : <0xaca>

and, looking at DIE 0xaca to get input.u2's type, we see:

 <1><aca>: Abbrev Number: 4 (DW_TAG_typedef)
    <acb>   DW_AT_name        : (indirect string, offset: 0x1060): target_wrapper__float_array_3
    [...]
    <ad1>   DW_AT_type        : <0xad5>

We can also confirm, following the DW_AT_type attribute (0xad5), that
it's a typedef of our array:

 <1><ad5>: Abbrev Number: 5 (DW_TAG_array_type)
    <ad6>   DW_AT_name        : (indirect string, offset: 0x1060): target_wrapper__float_array_3
    [...]

In fact, this scenario uncovered 2 areas where typedef handling
is missing, thus causing a crash. The first happens inside
assign_aggregate:

   if (ada_is_direct_array_type (lhs_type))
     {
       lhs = ada_coerce_to_simple_array (lhs);
       lhs_type = value_type (lhs);
       low_index = TYPE_ARRAY_LOWER_BOUND_VALUE (lhs_type);
       high_index = TYPE_ARRAY_UPPER_BOUND_VALUE (lhs_type);
     }

Here, lhs_type is a TYPE_CODE_TYPEDEF. ada_is_direct_array_type
knows how to handle it, but TYPE_ARRAY_LOWER_BOUND_VALUE assumes
that the given type is a TYPE_CODE_ARRAY. As such, it ends up
accessing some fields in lhs_type which it shouldn't, and kaboom.

We fixed this issue by making sure that the TYPE_CODE_TYPEDEF
layer gets stripped.

Once this is done, we hit a different kind of error, also leading to
a SEGV, this time in assign_component. The code looks like this:

  if (TYPE_CODE (value_type (lhs)) == TYPE_CODE_ARRAY)
    [...]
  else
    [...]

Because once again lhs is a TYPE_CODE_TYPEDEF, the check fail,
and we end up assuming that lhs is a struct, executing the "else"
block, which is:

  else
    {
      elt = ada_index_struct_field (index, lhs, 0, value_type (lhs));
      elt = ada_to_fixed_value (elt);
    }

Since lhs is not a struct, ada_index_struct_field returns NULL,
which ada_to_fixed_value does not handle well, hence another crash.

This patch fixes this other issue the same way, by stripping
TYPE_CODE_TYPEDEF layers.

gdb/ChangeLog:

        * ada-lang.c (assign_component): Strip any TYPE_CODE_TYPEDEF
        layer from lhs' type.
        (assign_aggregate): Likewise.

gdb/testsuite:

        * gdb.ada/assign_arr: New testcase.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Ada: fix bad handling in ada_convert_actual
@ 2017-12-18  3:22 sergiodj+buildbot
  2017-12-18  4:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-18  3:22 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cb923fcc23e07fe3dfb3837f47249aba79cdee6f ***

Author: Xavier Roirand <roirand@adacore.com>
Branch: master
Commit: cb923fcc23e07fe3dfb3837f47249aba79cdee6f

Ada: fix bad handling in ada_convert_actual

Using this small example:

procedure Foo is

   type Integer_Access is access all Integer;

   procedure P (A : Integer_Access) is
   begin
      null;
   end P;

begin
   P (null);
end Foo;

and doing this debug session:

(gdb) b p
Breakpoint 1 at 0x402d67: file foo.adb, line 7.
(gdb) print p(null)

Breakpoint 1, foo.p (a=0x641010) at foo.adb:10
...                  ^^^^^^^^^^

shows that something goes wrong between the initial null value and the
received parameter value in the 'f' function.
The value for the parameter 'a' we get is the address of the value we
would expect instead of the value itself. This can be checked by doing:

(gdb) p *a
$1 = 0

Before this fix, in ada_convert_value, this function was looking to the
actual value (the null value here) to determine if the formal (parameter
'a' in the procedure 'P' in this exemple) requires a pointer or not which
is a wrong assumption and leads to push the address of the value to the
inferior instead of the value itself.

This is fixed by this patch.

gdb/ChangeLog:

        * ada-lang.c (ada_convert_actual): Change the way actual value
        are passed to the inferior when the inferior expects a pointer type.

gdb/testsuite/ChangeLog:

        * gdb.ada/funcall_ptr: New testcase.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdb: Fix function parameter alignments in or1k-tdep.c.
@ 2017-12-16 23:29 sergiodj+buildbot
  2017-12-17  1:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-16 23:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 38af1824019684e819ffb880bdf7fb03a2c2000a ***

Author: Stafford Horne <shorne@gmail.com>
Branch: master
Commit: 38af1824019684e819ffb880bdf7fb03a2c2000a

gdb: Fix function parameter alignments in or1k-tdep.c.

As suggested by Joel Brobecker <brobecker@adacore.com> and as per fsf
coding standards.  Also fix a few more issues with directly printing
pointers.

gdb/ChangeLog:

	* gdb/or1k-tdep.c (show_or1k_debug): Fix function parameter alignment.
	(or1k_analyse_inst): Likewise.
	(or1k_single_step_through_delay): Likewise.
	(or1k_frame_cache): Fix parameter alignment and use paddress()
	instead of %x.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix ARI warning on gdb/typeprint.c:whatis_exp
@ 2017-12-16  3:54 sergiodj+buildbot
  2017-12-16  6:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-16  3:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 46afe196ec282505dcd2727725bfb5ef87ea4b21 ***

Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: 46afe196ec282505dcd2727725bfb5ef87ea4b21

Fix ARI warning on gdb/typeprint.c:whatis_exp

I forgot to indent the "if" clause properly and put the "&&" at the
beginning of the line, so ARI complained.  This commit fixed it.

gdb/ChangeLog:
2017-12-15  Sergio Durigan Junior  <sergiodj@redhat.com>

	* typeprint.c (whatis_exp): Fix ARI warning and reindent "if"
	condition.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Update documentation regarding the bfd returned by bfd_openr_next_archived_file
@ 2017-12-15 19:31 sergiodj+buildbot
  2017-12-15 21:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-15 19:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fc076a47fd716ca75447d432251abc67a19ef908 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: fc076a47fd716ca75447d432251abc67a19ef908

Update documentation regarding the bfd returned by bfd_openr_next_archived_file

	PR 22571
	* archive.c (bfd_openr_next_archived_file): Extend the
	documentation to note that it is necessary to call
	bfd_check_format on the rrturned bfd before using it.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix PR19061, gdb hangs/spins-on-cpu when debugging any program on Alpha
@ 2017-12-15 18:35 sergiodj+buildbot
  2017-12-15 19:46 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-15 18:35 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 68f81d60196eb201b209873cf53258f13b0046b9 ***

Author: Richard Henderson <rth@redhat.com>
Branch: master
Commit: 68f81d60196eb201b209873cf53258f13b0046b9

Fix PR19061, gdb hangs/spins-on-cpu when debugging any program on Alpha

This fixes PR19061, where gdb hangs/spins-on-cpu when debugging any
program on Alpha.

(This patch is Uros' forward port of the patch from comment #5
of the PR [1].)

Patch was tested on alphaev68-linux-gnu, also tested with gcc's
testsuite, where it fixed all hangs in guality.exp and
simulate-thread.exp testcases.

[1] https://sourceware.org/bugzilla/show_bug.cgi?id=19061#c5

gdb/ChangeLog:
2017-12-15  Richard Henderson  <rth@redhat.com>
	    Uros Bizjak  <ubizjak@gmail.com>

	PR gdb/19061
	* alpha-tdep.c (alpha_software_single_step): Call
	alpha_deal_with_atomic_sequence here.
	(set_gdbarch_software_single_step): Set to
	alpha_software_single_step.
	* nat/linux-ptrace.h [__alpha__]: Define GDB_ARCH_IS_TRAP_BRKPT
	and GDB_ARCH_IS_TRAP_HWBKPT.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Skip 'maintenance check xml-descriptions' if XML is disabled
@ 2017-12-15 11:47 sergiodj+buildbot
  2017-12-15 15:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-15 11:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1af17fd9cc3a453e55ce5b8f556c51859bf40363 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 1af17fd9cc3a453e55ce5b8f556c51859bf40363

Skip 'maintenance check xml-descriptions' if XML is disabled

I see the following test failure when gdb is configured without XML
support,

maintenance check xml-descriptions binutils-gdb/gdb/testsuite/../features
warning: Can not parse XML target description; XML support was disabled at compile time^M
Tested 29 XML files, 29 failed
(gdb) FAIL: gdb.gdb/unittest.exp: maintenance check xml-descriptions ${srcdir}/../features

gdb/testsuite:

2017-12-15  Yao Qi  <yao.qi@linaro.org>

	* gdb.gdb/unittest.exp: Skip 'maintenance check xml-descriptions'
	if XML is disabled.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Skip parse_memory_map_tests if XML is disabled
@ 2017-12-15 11:06 sergiodj+buildbot
  2017-12-15 12:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-15 11:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 97d4fac10fb9dac465d1d7e7a26c6b9cfb0b1326 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 97d4fac10fb9dac465d1d7e7a26c6b9cfb0b1326

Skip parse_memory_map_tests if XML is disabled

I find a fail in gdb unit test when gdb is configured without XML
support.

warning: Can not parse XML memory map; XML support was disabled at compile time^M
Self test failed: self-test failed at ../../binutils-gdb/gdb/unittests/memory-map-selftests.c:65
...
Ran 31 unit tests, 1 failed^M
(gdb) FAIL: gdb.gdb/unittest.exp: maintenance selftest

gdb:

2017-12-15  Yao Qi  <yao.qi@linaro.org>

	* unittests/memory-map-selftests.c: Wrap test with HAVE_LIBEXPAT.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix disassembly for PowerPC
@ 2017-12-15  9:44 sergiodj+buildbot
  2017-12-15 11:10 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-15  9:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fbc2255575afc0d332b28fd4991235e020cda667 ***

Author: Dimitar Dimitrov <dimitar@dinux.eu>
Branch: master
Commit: fbc2255575afc0d332b28fd4991235e020cda667

Fix disassembly for PowerPC

	* disassemble.c (disassemble_init_for_target): Don't put PRU
	between powerpc and rs6000 cases.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: drop stray CheckRegSize uses
@ 2017-12-15  8:34 sergiodj+buildbot
  2017-12-15  9:47 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-15  8:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 93b71a266695669cb9aa8ddf2717a1ccd53c925d ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 93b71a266695669cb9aa8ddf2717a1ccd53c925d

x86: drop stray CheckRegSize uses

They are relevant only when multiple operands permit registers:
operand_type_register_match() returns true if either operand is not a
register one. IOW

grep -i CheckRegSize i386-opc.tbl | grep -Ev "(Reg[8136]|Acc).*,.*(Reg|Acc)"

should produce no output.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] py-breakpoint: Don't use the 'p' PyArg_ParseTupleAndKeywords format specifier
@ 2017-12-14 21:04 sergiodj+buildbot
  2017-12-14 22:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-14 21:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8e557e52b3fd45a56fb42dbbaad3d6ece3694eb4 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 8e557e52b3fd45a56fb42dbbaad3d6ece3694eb4

py-breakpoint: Don't use the 'p' PyArg_ParseTupleAndKeywords format specifier

In Python 3, the 'p' format specifier can be passed to
PyArg_ParseTupleAndKeywords to test the argument for truth and convert
it to a boolean value (the p stands for predicate).  However, it is not
available in Python 2, causing this error:

  Traceback (most recent call last):
    File "test.py", line 1, in <module>
      b1 = gdb.Breakpoint("foo", qualified=False)
  TypeError: argument 10 (impossible<bad format char>)

This patch changes it to the 'O' specifier, which returns the Python
object passed in without transformation, and uses PyObject_IsTrue on it.
This is what is done for the other boolean parameters of this function
(internal and temporary).

This fixes the test gdb.python/py-breakpoint.exp for Python 2.

gdb/ChangeLog:

	* python/py-breakpoint.c (bppy_init): Use 'O' format specifier
	for "qualified" and use PyObject_IsTrue.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Update the address of the FSF in the copyright notice of files which were using the old address.
@ 2017-12-14 13:12 sergiodj+buildbot
  2017-12-14 14:15 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-14 13:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 863f7a5f4811c24d9a5863ffb541ff3da1511450 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 863f7a5f4811c24d9a5863ffb541ff3da1511450

Update the address of the FSF in the copyright notice of files which were using the old address.

top	* COPYING.LIBGLOSS: Update address of FSF in copyright notice.

bfd	* cpu-mt.c: Update address of FSF in copyright notice.
	* elf32-m32c.c: Likewise.
	* elf32-mt.c: Likewise.
	* elf32-rl78.c: Likewise.
	* elf32-rx.c: Likewise.
	* elf32-rx.h: Likewise.
	* elf32-spu.h: Likewise.
	* hosts/x86-64linux.h: Likewise.

etc	* add-log.el: Update address of FSF in copyright notice.

gas	* config/tc-m32c.c: Update address of FSF in copyright notice.
	* config/tc-m32c.h: Likewise.
	* config/tc-mt.c: Likewise.
	* config/tc-mt.h: Likewise.
	* config/tc-visium.c: Likewise.
	* config/tc-visium.h: Likewise.
	* testsuite/gas/rx/explode: Likewise.

ld	* testsuite/ld-mn10300/mn10300.exp: Update address of FSF in
	copyright notice.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Ada: unable to compare strings (Attempt to compare array with non-array)
@ 2017-12-14  5:57 sergiodj+buildbot
  2017-12-14  7:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-14  5:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 79e8fcaafa92e7b4a74e510c5487e87c60ff1945 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 79e8fcaafa92e7b4a74e510c5487e87c60ff1945

Ada: unable to compare strings (Attempt to compare array with non-array)

Consider the following Ada Code:

   type Str is new String (1 .. 4);
   My_str : Str := "ABCD";

This simply declares a 4-character string type. Trying to perform
equality tests using it currently yield an error:

    (gdb) p my_str = my_str
    Attempt to compare array with non-array
    (gdb) p my_str = "ABCD"
    Attempt to compare array with non-array

The error occurs because my_str is defined as an object whose
type is a typdef to a TYPE_CODE_ARRAY, which ada_value_equal
is not expecting at all (yet). This patch fixes this oversight.

gdb/ChangeLog:

        * ada-lang.c (ada_value_equal): Add handling of typedef types
        when comparing array objects.

gdb/testsuite/ChangeLog:

        * gdb.ada/str_binop_equal: New testcase.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] (Ada) Add support for task switching when debugging core files
@ 2017-12-14  4:30 sergiodj+buildbot
  2017-12-14  6:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-14  4:30 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e05fa6f9df82886043e1f1df30e0b9be3fee2d55 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: e05fa6f9df82886043e1f1df30e0b9be3fee2d55

(Ada) Add support for task switching when debugging core files

The reasons for not supporting task switching when debugging core files
appear to now mostly be OBE. In particular, on GNU/Linux, the thread
layer is now able to retrieve the same thread info as in the live
process. So, this patch is mostly about just removing the guard
that limited the use of task switching to live processes.

gdb/ChangeLog:

        * ada-tasks.c (read_atcb): Properly set task_info->ptid
        when !target_has_execution as well.
        (task_command): Remove error when !target_has_execution.

gdb/testsuite/ChangeLog:

        * gdb.ada/task_switch_in_core: New testcase.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add missing RISC-V fsrmi and fsflagsi instructions.
@ 2017-12-13 23:20 sergiodj+buildbot
  2017-12-14  3:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-13 23:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 25982ee0222196381863a17dc135fc1d2763b385 ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 25982ee0222196381863a17dc135fc1d2763b385

Add missing RISC-V fsrmi and fsflagsi instructions.

	PR 22599
	gas/
	* testsuite/gas/riscv/fsxxi.d, testsuite/gas/riscv/fsxxi.s: New.
	opcodes/
	* riscv-opc.c (riscv_opcodes) <fsrmi, fsflagsi>: New.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix regression: expression completer and scope operator (PR gdb/22584)
@ 2017-12-13 17:54 sergiodj+buildbot
  2017-12-13 22:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-13 17:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a22ecf70263eff75ca2c5878fe7e8d0311d6737f ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: a22ecf70263eff75ca2c5878fe7e8d0311d6737f

Fix regression: expression completer and scope operator (PR gdb/22584)

I noticed this regression in the expression completer:

 "(gdb) p std::[TAB]" => "(gdb) p std::std::"

obviously we should have not completed to "std::std::".

The problem is that in the earlier big completer rework, I missed
taking into account the fact that with expressions, the completion
word point is not always at the start of the symbol name (it is with
linespecs).

The fix is to run the common prefix / LCD string (what readline uses
to expand the input line) through make_completion_match_str too.

New testcase included, exercising both TAB completion and the complete
command.

gdb/ChangeLog:
2017-12-13  Pedro Alves  <palves@redhat.com>

	* completer.c (completion_tracker::maybe_add_completion): New
	'text' and 'word' parameters.  Use make_completion_match_str.
	(completion_tracker::add_completion): New 'text' and 'word'
	parameters.  Pass down.
	(completion_tracker::recompute_lowest_common_denominator): Change
	parameter type to gdb::unique_xmalloc_ptr rval ref.  Adjust.
	* completer.h (completion_tracker::add_completion): New 'text' and
	'word' parameters.
	(completion_tracker::recompute_lowest_common_denominator): Change
	parameter type to gdb::unique_xmalloc_ptr rval ref.
	(completion_tracker::recompute_lowest_common_denominator): Change
	parameter type to gdb::unique_xmalloc_ptr rval ref.
	* symtab.c (completion_list_add_name): Pass down 'text' and 'word'
	as well.

gdb/testsuite/ChangeLog:
2017-12-13  Pedro Alves  <palves@redhat.com>

	* gdb.cp/cpcompletion.exp: Load completion-support.exp.
	("expression with namespace"): New set of tests.
	* gdb.cp/pr9594.cc (Test_NS::foo, Test_NS::bar)
	(Nested::Test_NS::qux): New.
	* lib/completion-support.exp (test_gdb_complete_cmd_multiple): Add
	defaults to 'start_quote_char' and 'end_quote_char' parameters.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [BFD][AARCH64]Disallow R_AARCH64_ABS32(LP64) & R_AARCH64_ABS16 in const section of shared object.
@ 2017-12-13 16:11 sergiodj+buildbot
  2017-12-13 19:56 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-13 16:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 79e741920446582bd0e09f3e2b9f899c258efa56 ***

Author: Renlin Li <renlin.li@arm.com>
Branch: master
Commit: 79e741920446582bd0e09f3e2b9f899c258efa56

[BFD][AARCH64]Disallow R_AARCH64_ABS32(LP64) & R_AARCH64_ABS16 in const section of shared object.

R_AARCH64_ABS64, R_AARCH64_ABS32 and R_AARCH64_ABS16 are data relocations
supported in AArch64 elf ABI.

R_AARCH64_ABS64 under LP64 is allowed in shared object and a dynamic relocation entry
will be generated. This allows the dynamic linker to do further symbol resolution.
R_AARCH64_ABS32 likewise is allowed in shared object, however under ILP32 abi.

The original behavior for R_AARCH64_ABS32 under LP64 is that, it's allowed
in shared object and silently resolved at static linking time.
No dynamic relocation entry is generate for it.

R_AARCH64_ABS16 is allowed in shared object under both L64 and ILP32.
It's resolved at static linking time as well.

Under LP64, the address should be 64-bit. R_AARCH64_ABS32 relocation indicates
an address that is only sized 32 bits which is meaningless in LP64 shared object.
It's useful to error out.

I have checked glibc dynamic linker code, R_AARCH64_ABS16 is not supported at all. So
R_AARCH64_ABS16 should be reject in shared object completely.

In this patch, R_AARCH64_ABS32 is rejected under LP64 in constant section of shared object.
R_AARCH64_ABS16 is rejected in constant section of shared object in both ABI.

This will sometimes provide useful information for buggy code.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdb: Fix ARI warnings in or1k-tdep.c
@ 2017-12-13 15:34 sergiodj+buildbot
  2017-12-13 18:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-13 15:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9664701462aec634d304923df8dc9c52c5a92caf ***

Author: Stafford Horne <shorne@gmail.com>
Branch: master
Commit: 9664701462aec634d304923df8dc9c52c5a92caf

gdb: Fix ARI warnings in or1k-tdep.c

Fix a few issues not using the gettext _() wrapper and issues where
we are using %p directly instead of the dedicated host/target functions.

gdb/ChangeLog:

yyyy-mm-dd  Stafford Horne  <shorne@gmail.com>

	* or1k-tdep.c (or1k_analyse_inst): Use _() wrapper for message
	strings.
	(or1k_unwind_pc): Use paddress() instead of %p.
	(or1k_unwind_sp): Likewise.
	(or1k_frame_cache): Use host_address_to_string()/paddress()
	instead of %p and use _() wrapper for message strings.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix typo in gdb_ari.sh
@ 2017-12-13 14:53 sergiodj+buildbot
  2017-12-13 17:11 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-13 14:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3bbd9f1877bfc5f37ebff1fef2af9eb783f49ace ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 3bbd9f1877bfc5f37ebff1fef2af9eb783f49ace

Fix typo in gdb_ari.sh

gdb/ChangeLog:

	* contrib/ari/gdb_ari.sh: Fix typo in help.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] This patch enables disassembler_needs_relocs for PRU. It is needed to print correct symbols when disassembling arguments of "call" instructions with a relocation.
@ 2017-12-13 13:44 sergiodj+buildbot
  2017-12-13 15:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-13 13:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 024d185c10a48339ae06634d0738dd796a159cd8 ***

Author: Dimitar Dimitrov <dimitar@dinux.eu>
Branch: master
Commit: 024d185c10a48339ae06634d0738dd796a159cd8

This patch enables disassembler_needs_relocs for PRU. It is needed to print correct symbols when disassembling arguments of "call" instructions with a relocation.

opcodes	* disassemble.c: Enable disassembler_needs_relocs for PRU.

gas	* testsuite/gas/pru/extern.s: New test for print of U16_PMEMM
	relocation.
	* testsuite/gas/pru/extern.d: New test driver.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] S/390: Fix (some) PIE+undef weak failures
@ 2017-12-13 12:54 sergiodj+buildbot
  2017-12-13 13:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-13 12:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 10e7c0457cb7531f8b205e29e88b3e191cfa6037 ***

Author: Andreas Krebbel <krebbel@linux.vnet.ibm.com>
Branch: master
Commit: 10e7c0457cb7531f8b205e29e88b3e191cfa6037

S/390: Fix (some) PIE+undef weak failures

This fixes these failures on 64 bit which currently occur when running
the Binutils testsuite with a default PIE compiler.

< FAIL: Build rdynamic-1
< FAIL: Build dynamic-1
< FAIL: Build pr22269-1

bfd/ChangeLog:

2017-12-13  Andreas Krebbel  <krebbel@linux.vnet.ibm.com>

	* elf64-s390.c (elf_s390_adjust_dynamic_symbol): Use
	UNDEFWEAK_NO_DYNAMIC_RELOC.
	(allocate_dynrelocs): Likewise.
	(elf_s390_relocate_section): Check resolved_to_zero.
	(elf_s390_finish_dynamic_symbol): Don't generate runtime reloc if
	UNDEFWEAK_NO_DYNAMIC_RELOC.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] sim: or1k: add cgen generated files
@ 2017-12-12 20:43 sergiodj+buildbot
  2017-12-13  3:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-12 20:43 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6e51bfa75535439cc66039bcf4e8ebf16e8fe124 ***

Author: Stafford Horne <shorne@gmail.com>
Branch: master
Commit: 6e51bfa75535439cc66039bcf4e8ebf16e8fe124

sim: or1k: add cgen generated files

These are the simulator files generated by cgen.  These are split out
from the main sim patch to make the patch easier to review and smaller.

sim/ChangeLog:

2017-12-12  Stafford Horne  <shorne@gmail.com>
	    Peter Gavin  <pgavin@gmail.com>

	* or1k/arch.c: Generated.
	* or1k/arch.h: Generated.
	* or1k/cpu.c: Generated.
	* or1k/cpu.h: Generated.
	* or1k/cpuall.h: Generated.
	* or1k/decode.c: Generated.
	* or1k/decode.h: Generated.
	* or1k/model.c: Generated.
	* or1k/sem-switch.c: Generated.
	* or1k/sem.c: Generated.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] sim: cgen: add MUL2OFSI and MUL1OFSI functions (needed for OR1K l.mul[u])
@ 2017-12-12 19:10 sergiodj+buildbot
  2017-12-13  0:53 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-12 19:10 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 58884b0e451043ed2fb4d2fba18134f0fb451ce5 ***

Author: Peter Gavin <pgavin@gmail.com>
Branch: master
Commit: 58884b0e451043ed2fb4d2fba18134f0fb451ce5

sim: cgen: add MUL2OFSI and MUL1OFSI functions (needed for OR1K l.mul[u])

sim/common/ChangeLog:

2017-12-12  Peter Gavin  <pgavin@gmail.com>
	    Stafford Horne  <shorne@gmail.com>

	* cgen-ops.h (MUL2OFSI): New function, 2's complement overflow
	flag.
	(MUL1OFSI): New function, 1's complement overflow flag.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add gdb for or1k build
@ 2017-12-12 17:32 sergiodj+buildbot
  2017-12-12 21:30 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-12 17:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 638d913757609367eea219d00296a0a3d45010c2 ***

Author: Stafford Horne <shorne@gmail.com>
Branch: master
Commit: 638d913757609367eea219d00296a0a3d45010c2

Add gdb for or1k build

* ChangeLog:

2017-12-12  Stafford Horne  <shorne@gmail.com>

	* configure.ac: Remove logic adding gdb to noconfigsdirs for or1k.
	* configure: Regenerate.

Cc: gcc-patches@gcc.gnu.org


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdb: Add OpenRISC or1k and or1knd target support
@ 2017-12-12 15:17 sergiodj+buildbot
  2017-12-12 16:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-12 15:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a994fec4f8f7a886be61cfb3023c354cd2483b9d ***

Author: Franck Jullien <franck.jullien@gmail.com>
Branch: master
Commit: a994fec4f8f7a886be61cfb3023c354cd2483b9d

gdb: Add OpenRISC or1k and or1knd target support

This patch prepares the current GDB port of the OpenRISC processor from
https://github.com/openrisc/binutils-gdb for upstream merging.

Testing has been done with a cgen sim provided in a separate patch. This
has been tested with 2 toolchains. GCC [1] 5.4.0 from the OpenRISC
project with Newlib [2] and GCC 5.4.0 with Musl [3] 1.1.4.

It supports or1knd (no delay slot target).
The default target is or1k (with delay slot).

You can change the target arch with:

(gdb) set architecture or1knd
The target architecture is assumed to be or1knd

[1] https://github.com/openrisc/or1k-gcc
[2] https://github.com/openrisc/newlib
[3] https://github.com/openrisc/musl-cross

gdb/doc/ChangeLog:

2017-12-12  Stafford Horne  <shorne@gmail.com>
	    Stefan Wallentowitz  <stefan@wallentowitz.de>
	    Franck Jullien  <franck.jullien@gmail.com>
	    Jeremy Bennett  <jeremy.bennett@embecosm.com>

	* gdb.texinfo: Add OpenRISC documentation.

gdb/ChangeLog:

2017-12-12  Stafford Horne  <shorne@gmail.com>
	    Stefan Wallentowitz  <stefan@wallentowitz.de>
	    Stefan Kristiansson  <stefan.kristiansson@saunalahti.fi>
	    Franck Jullien  <franck.jullien@gmail.com>
	    Jeremy Bennett  <jeremy.bennett@embecosm.com>

	* configure.tgt: Add targets for or1k and or1knd.
	* or1k-tdep.c: New file.
	* or1k-tdep.h: New file.
	* features/Makefile: Add or1k.xml to build.
	* features/or1k.xml: New file.
	* features/or1k-core.xml: New file.
	* features/or1k.c: Generated.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR22576, ppc64_skip_trampoline_code uses wrong r2 for EXEC_REVERSE
@ 2017-12-12 13:33 sergiodj+buildbot
  2017-12-12 14:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-12 13:33 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT db9077b7275e86637218a7a7d165cb85a4de116f ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: db9077b7275e86637218a7a7d165cb85a4de116f

PR22576, ppc64_skip_trampoline_code uses wrong r2 for EXEC_REVERSE

The TOC pointer register, r2, on powerpc64 is generally not mentioned
in debug info.  It is saved and restored by call linkage code, and
set to the callee value either by call stub code (ELFv1) or in the
callee global entry point code (ELFv2).  A call stub uses the caller
TOC pointer to access the PLT.  So for gdb to read the correct PLT
entry in order to determine the destination of the trampoline, gdb
needs to know the caller r2.  When skipping over trampolines in the
normal forward direction, the caller r2 is simply the current value of
r2 (at the start of the trampoline).  However, when reversing over
trampolines the current value of r2 is that for the callee.  Using
that value results in wild reads of memory rather than the correct PLT
entry.

This patch corrects the value of r2 by using the value saved on the
stack for reverse execution.  Note that in reverse execution mode it
isn't really necessary for skip_trampoline_code to return the actual
destination, so we're doing a little more work than needed here.  Any
non-zero return value would do (and it would be nicer if the interface
was changed to return the start of the stub).

	PR tdep/22576
	* ppc64-tdep.c (ppc64_plt_entry_point): Rewrite to take TOC-relative
	PLT offset, and retrieve r2 from stack when executing in reverse.
	(ppc64_standard_linkage1_target): Drop pc param.  Calculate offset
	rather than PLT address.
	(ppc64_standard_linkage2_target): Likewise.
	(ppc64_standard_linkage3_target): Likewise.
	(ppc64_standard_linkage4_target): Likewise.
	(ppc64_skip_trampoline_code_1): Adjust to suit.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] remote: Return NULL extra_info/name if they are empty
@ 2017-12-12  2:28 sergiodj+buildbot
  2017-12-12  4:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-12  2:28 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a933405894161c8b15f675c48d077b7f7d6aabf2 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: a933405894161c8b15f675c48d077b7f7d6aabf2

remote: Return NULL extra_info/name if they are empty

Commit

  remote: C++ify thread_item and threads_listing_context
  21fe1c752e254167d953fa8c846280f63a3a5290

broke the test gdb.threads/names.exp.  The problem is that since we now
use an std::string to hold the extra_info, an empty string is returned
by target_extra_thread_info to print_thread_info_1 when the remote stub
didn't send any extra info, instead of NULL before.  Because of that,
print_thread_info_1 prints the extra info between parentheses, which
results in some spurious empty parentheses.

  Expected: * 1    Thread 22752.22752 "main" all_threads_ready () at ...
  Actual  : * 1    Thread 22752.22752 "main" () all_threads_ready () a ...

Since the bug was introduced by a behavior change in the remote target,
I chose to fix it on the remote target side by making it return NULL
when the extra string is empty.  This will avoid possibly changing the
behavior of the common code and affecting other targets.

The name field has the same problem.  If a remote stub returns no thread
names, remote_thread_name will return an empty string instead of NULL,
so print_thread_info_1 will show empty quotes ("") instead of nothing.

gdb/ChangeLog:

	PR gdb/22556
	* remote.c (remote_thread_name): Return NULL if name is empty.
	(remote_threads_extra_info): Return NULL if extra info is empty.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [Binutils][Objdump]Check symbol section information while search a mapping symbol backward.
@ 2017-12-11 16:19 sergiodj+buildbot
  2017-12-11 18:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-11 16:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4c5ae11b42433dbffc33fbde75c9e415594504d8 ***

Author: Renlin Li <renlin.li@arm.com>
Branch: master
Commit: 4c5ae11b42433dbffc33fbde75c9e415594504d8

[Binutils][Objdump]Check symbol section information while search a mapping symbol backward.

When checking mapping symbols backwardly, the section which defines the symbol
is not considerted. This patch fixes this by moving the section checking code
into get_sym_code_type () function which is shared by forward and backword
mapping symbol searching.

opcodes/

2017-12-11  Petr Pavlu  <petr.pavlu@arm.com>
	    Renlin Li  <renlin.li@arm.com>

	* aarch64-dis.c (print_insn_aarch64): Move symbol section check ...
	(get_sym_code_type): Here.

binutils/

2017-12-11  Renlin Li  <renlin.li@arm.com>

	* testsuite/binutils-all/aarch64/objdump.d: New.
	* testsuite/binutils-all/aarch64/objdump.s: New.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [MPFR] Fix regression on 32-bit host systems
@ 2017-12-11 14:55 sergiodj+buildbot
  2017-12-11 15:45 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-11 14:55 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f2f9e7ecc1f02bfe5da83c38cf356ea96d428c6d ***

Author: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Branch: master
Commit: f2f9e7ecc1f02bfe5da83c38cf356ea96d428c6d

[MPFR] Fix regression on 32-bit host systems

When converting parts of the mantissa to MPFR, we need to make sure to do
an *unsigned* conversion.  Since we convert at most 32 bits at a time,
stored in an unsigned long, this doesn't matter on systems where "long"
is larger than 32 bits.  But on systems where it is 32 bits, we can get
conversion errors.

gdb/ChangeLog
2017-12-11  Ulrich Weigand  <uweigand@de.ibm.com>

	* target-float.c (mpfr_float_ops::from_target): Use mpfr_set_ui
	instead of mpfr_set_si to convert mantissa bits.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Adapt gdb.ada/variant_record_packed_array.exp to accept reordered components
@ 2017-12-11  8:38 sergiodj+buildbot
  2017-12-11  9:38 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-11  8:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c5f9cfc894373abd00ee56c6723ee0ba95a84f95 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: c5f9cfc894373abd00ee56c6723ee0ba95a84f95

Adapt gdb.ada/variant_record_packed_array.exp to accept reordered components

Recent versions of GNAT are capable of reordering record components
to make their access for efficient. This patch adapts this test to
accept both cases (reordered or not).

gdb/testsuite/ChangeLog:

        * gdb.ada/variant_record_packed_array.exp: Adapt test to accept
        output with components being reordered.

Tested on x86_64-linux.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] (Ada) change tagged types base_address computation
@ 2017-12-11  7:04 sergiodj+buildbot
  2017-12-11  8:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-11  7:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 08f49010a10b1fc98f65aada96e788c87c56ad85 ***

Author: Xavier Roirand <roirand@adacore.com>
Branch: master
Commit: 08f49010a10b1fc98f65aada96e788c87c56ad85

(Ada) change tagged types base_address computation

There was a difference between C++ dispatch table and Ada's in the
way the Offset_To_Top field is used to determined the base address
of an object:

* in C++ it is a negative offset, so converting abstract interface to
deriving object requires adding this offset to this;

* in Ada, it was a positive offset, so the same conversion required
subtracting the offset value.

So in ada, the base address for a tagged type was computed using this formula:

base_address = value_address (obj) - offset_to_top;

The offset_to_top value was previously set to 0 or a positive value.
With recent version of AdaCore's GNAT compiler, the offset has been
changed to match C++, which means it's set to zero or a negative value

As a result, the new formula has to be:

base_address = value_address (obj) + offset_to_top;

Because we want to support old code compiled before GNAT compiler change
done in 19.0w (20171023-64) with this version and future versions of gdb,
then we change the sign of the offset_to_top if required. Required here
means if offset_to_top is positive since it indicates that the code has
been compiled with an old GNAT compiler.

This patch changes the formula as described above.

Also, one side-effect of offset_to_top now being negative is that
we now have to worry about the sign when we read its value from the
inferior. Up to now, we have been reading its value using the data
address builtin type. But since addresses are not always signed, we
now need to make sure we use the proper type (type Storage_Offset
from System.Storage_Elements). Ideally, we would be looking this type
up from the inferior, and then use that type. However, it is not
guaranteed that this type always be described in the debugging
information, so this patch just builds our own, adding it to Ada's
list of primitive types.

gdb/ChangeLog:

        * ada-lang.c (ada_tag_value_at_base_address): Change the way
        tagged type base address is computed.
        (enum ada_primitive_types) <ada_primitive_type_storage_offset>:
        New enumerate.
        (ada_language_arch_info): Set the ada_primitive_type_storage_offset
        element of lai->primitive_type_vector.

Tested on x86_64-linux. Fixes the following tests when using the newer
version of the compiler.

    gdb.ada/iwide.exp: print My_Drawable
    gdb.ada/iwide.exp: print d_access.all
    gdb.ada/iwide.exp: print dp_access.all
    gdb.ada/mi_interface.exp: create ggg1 varobj (unexpected output)
    gdb.ada/mi_interface.exp: list ggg1's children (unexpected output)
    gdb.mi/mi-var-rtti.exp: run to mi-var-rtti.cc:63 (set breakpoint) (unexpected output)
    gdb.mi/mi-var-rtti.exp: run to mi-var-rtti.cc:63 (set breakpoint)


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Typo fix
@ 2017-12-10 22:37 sergiodj+buildbot
  2017-12-10 23:33 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-10 22:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 57a2957f2ead9ec2464a1b6fbdb250e90d27afab ***

Author: Sangamesh Mallayya <sangamesh.swamy@in.ibm.com>
Branch: master
Commit: 57a2957f2ead9ec2464a1b6fbdb250e90d27afab

Typo fix

Entirely the fault of that Alan Modra bloke.

	* bfd.c (bfd_get_sign_extend_vma): Correct typo.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] dwarf2read.c: Rewrite/simplify mock_mapped_index
@ 2017-12-09  6:59 sergiodj+buildbot
  2017-12-09 16:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-09  6:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a3c5fafd2e0bc8c1ea98c579c0a044c5b324967b ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: a3c5fafd2e0bc8c1ea98c579c0a044c5b324967b

dwarf2read.c: Rewrite/simplify mock_mapped_index

Now that dw2_expand_symtabs_matching_symbol works with the abstract
mapped_index_base, we can make mock_mapped_index inherit
mapped_index_base too instead of having it pretend to be a real
.gdb_index table.

gdb/ChangeLog:
2017-12-08  Pedro Alves  <palves@redhat.com>

	* dwarf2read.c (mock_mapped_index): Reimplement as an extension of
	mapped_index_base.
	(check_match): Adjust to use mock_index directly.
	(check_find_bounds_finds)
	(test_mapped_index_find_name_component_bounds): Adjust to work
	with a mapped_index_base.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] dwarf2read.c:mapped_index, use gdb::array_view, simplify symbol table
@ 2017-12-09  5:22 sergiodj+buildbot
  2017-12-09 14:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-09  5:22 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f00a2de2a7556c59bce93f7ced44afa8e1bbf7c3 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: f00a2de2a7556c59bce93f7ced44afa8e1bbf7c3

dwarf2read.c:mapped_index, use gdb::array_view, simplify symbol table

This replaces a couple ptr+size pairs with gdb::array_view in the
.gdb_index code, and simplifies things by using an aggregate for the
type of the symbol table hash bucket instead of having to consider the
distinction between size of table vs number of slots and access name
vs vec by index.

gdb/ChangeLog:
2017-12-08  Pedro Alves  <palves@redhat.com>

	* dwarf2read.c (mapped_index::symbol_table_slot): New.
	(mapped_index::address_table): Now a gdb::array_view of const
	gdb_byte.
	(mapped_index::symbol_table): Now a gdb::array_view of
	symbol_table_slot.
	(mapped_index::address_table_size)
	(mapped_index::symbol_table_slots): Delete.
	(create_addrmap_from_index): Adjust.
	(find_slot_in_mapped_hash): Adjust.
	(read_index_from_section): Adjust.
	(dwarf2_read_index): Adjust.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] DWARF-5: .debug_names index consumer
@ 2017-12-09  4:00 sergiodj+buildbot
  2017-12-09 12:54 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-09  4:00 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 927aa2e778dce440f4de5de8fc37ead1683a804e ***

Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Branch: master
Commit: 927aa2e778dce440f4de5de8fc37ead1683a804e

DWARF-5: .debug_names index consumer

Some testcases needed to be updated as they were missing
.debug_aranges.  While that does not matter for no-index (as GDB
builds the mapping internally during dwarf2_build_psymtabs_hard) and
neither for .gdb_index (as GDB uses that internally built mapping
which it stores into .gdb_index) it does matter for .debug_names as
that simply assumes existing .debug_aranges from GCC.

gdb/ChangeLog:
2017-12-08  Jan Kratochvil  <jan.kratochvil@redhat.com>
	    Pedro Alves  <palves@redhat.com>

	* defs.h (elf_sym_fns_debug_names): New declaration.
	* dwarf2read.c: Include "hash_enum.h".
	(mapped_debug_names): New.
	(struct dwarf2_per_objfile): Add debug_names, debug_aranges and
	debug_names_table.
	(dwarf2_elf_names): Add ".debug_names" and ".debug_aranges".
	(struct dwz_file): Add debug_names.
	(dwarf2_per_objfile::locate_sections): Handle debug_names and
	debug_aranges.
	(locate_dwz_sections): Handle debug_names.
	(create_signatured_type_table_from_debug_names)
	(create_addrmap_from_aranges): New.
	(dwarf2_read_index): Update function comment.
	(dwarf5_augmentation): Moved up.
	(read_debug_names_from_section, create_cus_from_debug_names_list)
	(create_cus_from_debug_names, dwarf2_read_debug_names): New.
	(dwarf5_djb_hash): Moved up.
	(dw2_debug_names_iterator): New.
	(read_indirect_string_at_offset): New declaration.
	(mapped_debug_names::namei_to_name)
	(dw2_debug_names_iterator::find_vec_in_debug_names)
	(dw2_debug_names_iterator::next, dw2_debug_names_lookup_symbol)
	(dw2_debug_names_dump, dw2_debug_names_expand_symtabs_for_function)
	(dw2_debug_names_expand_symtabs_matching, dwarf2_debug_names_functions):
	New.
	(dwarf2_initialize_objfile): Return also elf_sym_fns_debug_names.
	(debug_names::djb_hash): Rename it to dwarf5_djb_hash.
	(debug_names::build): Update djb_hash caller.
	(write_debug_names): Move out and rename augmentation to
	dwarf5_augmentation.
	* elfread.c (elf_sym_fns_debug_names): New.
	* psymtab.h (dwarf2_debug_names_functions): New declaration.
	* symfile.h (struct dwarf2_debug_sections): Add debug_names and
	debug_aranges.
	* xcoffread.c (dwarf2_xcoff_names): Add debug_names and debug_aranges.

gdb/testsuite/ChangeLog:
2017-12-08  Jan Kratochvil  <jan.kratochvil@redhat.com>
	    Pedro Alves  <palves@redhat.com>

	* gdb.base/maint.exp (check for .gdb_index): Check also for
	.debug_names.
	* gdb.dlang/watch-loc.c (.debug_aranges): New.
	* gdb.dwarf2/dw2-case-insensitive-debug.S: Likewise.
	* gdb.dwarf2/gdb-index.exp (check if index present, .gdb_index used)
	(.gdb_index used after symbol reloading): Support also .debug_names.
	* gdb.mi/dw2-ref-missing-frame-func.c (.debug_aranges): New.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Refactor: Move some generic code out of .gdb_index code
@ 2017-12-09  2:18 sergiodj+buildbot
  2017-12-09  9:46 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-09  2:18 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4b514bc80885fa91e57b9d80f74ea267df343c46 ***

Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Branch: master
Commit: 4b514bc80885fa91e57b9d80f74ea267df343c46

Refactor: Move some generic code out of .gdb_index code

Preparation for the next patch.

gdb/ChangeLog
2017-12-08  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* dwarf2read.c (create_cu_from_index_list): New from ...
	(create_cus_from_index_list): ... this function, use it.
	(dw_expand_symtabs_matching_file_matcher)
	(dw2_expand_symtabs_matching_one): New from ...
	(dw2_expand_symtabs_matching): ... this function, use them.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] cc-with-tweaks.sh: Use gdb-add-index.sh
@ 2017-12-09  0:04 sergiodj+buildbot
  2017-12-09  5:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-09  0:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6432ec65a8822246db5bcede0c6bd3ed0e464a0b ***

Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Branch: master
Commit: 6432ec65a8822246db5bcede0c6bd3ed0e464a0b

cc-with-tweaks.sh: Use gdb-add-index.sh

With DWARF-5 .debug_names, the commands to add the index to the symbol
file are more complicated, as now also .debug_str needs to be
modified.

Currently, contrib/cc-with-tweaks.sh calls objcopy to handle the '-i'
option instead of using contrib/gdb-add-index.sh which basically does
the same.  To help with .debug_names, this commit makes
contrib/cc-with-tweaks.sh reuse contrib/gdb-add-index.sh instead.

A problem this ran into is whether contrib/cc-with-tweaks.sh should
fail or not when no index is produced.

Currently, contrib/cc-with-tweaks.sh is more quiet (=successful) than
contrib/gdb-add-index.sh and so with no further changes testsuite runs
with an index would "regress".  This commit tries to keep the behavior
unchanged.  Some cases still error with:
	Ada is not currently supported by the index
But some cases (such as some trivial gdb.dwarf2/ testcases with no DWARF data
to index) produce no index while the testcases still PASS now instead of:
	-PASS: gdb.arch/i386-bp_permanent.exp: stack pointer value matches
	+gdb compile failed, gdb-add-index.sh: No index was created for gdb/testsuite.unix.-m64/outputs/gdb.arch/i386-bp_permanent/i386-bp_permanent
	+gdb-add-index.sh: [Was there no debuginfo? Was there already an index?]
	+UNTESTED: gdb.arch/i386-bp_permanent.exp: failed to compile

gdb/ChangeLog
2017-12-08  Jan Kratochvil  <jan.kratochvil@redhat.com>
	    Pedro Alves  <palves@redhat.com>

	* contrib/cc-with-tweaks.sh: Change interpreter to bash, incl. initial
	comment.
	(GDB_ADD_INDEX): New variable.
	<$want_index>: Call $GDB_ADD_INDEX.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix thinko on dtrace-probe.c:dtrace_process_dof_probe
@ 2017-12-08 20:59 sergiodj+buildbot
  2017-12-09  1:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-08 20:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 92469284a650232768523564f2c715c4ebb57906 ***

Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: 92469284a650232768523564f2c715c4ebb57906

Fix thinko on dtrace-probe.c:dtrace_process_dof_probe

While investigating PR gdb/22557 ("Regression:
gdb.base/dtrace-probe.exp"), I noticed that the code is wrongly
declaring a new "expression_up" variable inside the TRY block in
"dtrace_process_dof_probe".  This causes the outter "expr" variable to
be empty, which may have an impact later when evaluating the
expression.

This commit fixes that.  Unfortunately the script used to test DTrace
probes (gdb/testsuite/lib/pdtrace.in) is not very reliable so I cannot
say whether this commit fixes the PR mentioned above.  Nonetheless,
it's an obvious fix and should go in.

gdb/ChangeLog:
2017-12-08  Sergio Durigan Junior  <sergiodj@redhat.com>

	* dtrace-probe.c (dtrace_process_dof_probe): Do not declare a new
	"expression_up" inside the TRY block.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Adjust breakpoint address by clearing non-significant bits
@ 2017-12-08 19:17 sergiodj+buildbot
  2017-12-08 22:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-08 19:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a0de8c21baf46c40ed8e62faef5f750b1e5453ea ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: a0de8c21baf46c40ed8e62faef5f750b1e5453ea

Adjust breakpoint address by clearing non-significant bits

Tag in tagged address on AArch64 is treated as a non-significant bits of
address, which can be got by gdbarch method significant_addr_bit, and gdb
can clear these bits.

With this patch, when user sets a breakpoint on tagged address on AArch64,
GDB will drop the top byte of address, and put breakpoint at the new place,
as shown below,

(gdb) hbreak *func_ptr
warning: Breakpoint address adjusted from 0xf000000000400690 to 0x00400690.
Hardware assisted breakpoint 2 at 0x400690

(gdb) break *func_ptr
warning: Breakpoint address adjusted from 0xf000000000400690 to 0x00400690.
Breakpoint 3 at 0x400690

When program hits a breakpoint, the stopped pc reported by Linux kernel is
the address *without* tag, so it is better the address recorded in
breakpoint location is the one without tag too, so we can still match
breakpoint location address and stopped pc reported by Linux kernel, by
simple compare.

gdb:

2017-12-08  Yao Qi  <yao.qi@linaro.org>

	* breakpoint.c (adjust_breakpoint_address): Call
	address_significant.

gdb/testsuite:

2017-12-08  Yao Qi  <yao.qi@linaro.org>

	* gdb.arch/aarch64-tagged-pointer.c (main): Update.
	* gdb.arch/aarch64-tagged-pointer.exp: Add test for breakpoint.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix PR 22567: set SAL .section in minsym_found
@ 2017-12-08 16:06 sergiodj+buildbot
  2017-12-08 17:03 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-08 16:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6b05c8bd437152d7a3ecfc19074ab243ee6c92f2 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 6b05c8bd437152d7a3ecfc19074ab243ee6c92f2

Fix PR 22567: set SAL .section in minsym_found

PR 22567 is that breakpoint location can't correct gdbarch from SAL,
because its fields .section and .symtab is NULL.  We use to have code
setting .section, but was removed by 4024cf2

-  if (msymbol_is_text (msymbol))
+  CORE_ADDR func_addr;
+  if (msymbol_is_function (objfile, msymbol, &func_addr))
     {
-      sal = find_pc_sect_line (MSYMBOL_VALUE_ADDRESS (objfile, msymbol),
-                              (struct obj_section *) 0, 0);
-      sal.section = MSYMBOL_OBJ_SECTION (objfile, msymbol);

this patch adds this back by moving it to the common place at the bottom
of the function.

gdb:

2017-12-08  Yao Qi  <yao.qi@linaro.org>

	PR breakpionts/22567
	* linespec.c (minsym_found): Set sal.section.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add aix 64-bit check to bfd_get_sign_extend_vma
@ 2017-12-08  6:55 sergiodj+buildbot
  2017-12-08  7:45 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-08  6:55 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c8bed57010e8789212a6841db4b397b175a00f9e ***

Author: Sangamesh Mallayya <sangamesh.swamy@in.ibm.com>
Branch: master
Commit: c8bed57010e8789212a6841db4b397b175a00f9e

Add aix 64-bit check to bfd_get_sign_extend_vma

	* bfd.c (bfd_get_sign_extend_vma): Handle aix5coff64-rs6000.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Validate explicit locations with early termination
@ 2017-12-08  0:32 sergiodj+buildbot
  2017-12-08  5:50 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-08  0:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fa6eb693cf43b427474b1d96ce093f6ea9e5da6a ***

Author: Keith Seitz <keiths@redhat.com>
Branch: master
Commit: fa6eb693cf43b427474b1d96ce093f6ea9e5da6a

Validate explicit locations with early termination

breakpoints/22569 involves an internal error generated by the rather
innocent looking command:

(gdb) break -source test.cpp main
.../linespec.c:3302: internal-error: void decode_line_full(...):
Assertion `result.size () == 1 || canonical->pre_expanded' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Quit this debugging session? (y or n)

The input string is tokenized into "-source", "test.cpp", and "main"
(input parsing breaks on whitespace). create_breakpoint is then called with
the explicit location (containing only the source file name) and "main" as
the extra_string argument.

No SaLs are created for this underspecified explicit location, and the
"result.size () == 1" evaluates false (as does the pre_expanded condition).
This triggers the assertion.

Normally string_to_explicit_location validates the input string.  However,
the presence of the string "main" causes the parser to exit early:

   802        else
   803          {
   804            /* End of the explicit location specification.
   805               Stop parsing and return whatever explicit location was
   806               parsed.  */
   807            *argp = start;
   808            return location;
   809          }

This bypasses the validation that is done a few lines down in this function
which would have emitted the expected error.  This patch fixes that.

Additionally, this patch also fixes an inconsistency with error reporting
in this use case:

(gdb) b -source foo
Source filename requires function, label, or line offset.
(gdb) b -source foo main
No source file named foo.

These two commands should have elicited the same error message.

gdb/ChangeLog:

	PR breakpoints/22569
	* location.c (string_to_explicit_location): When terminating
	parsing early, break out of enclosing loop instead of returning.

gdb/testsuite/ChangeLog:

	PR breakpoints/22569
	* gdb.linespec/ls-errs.exp: Change expected result of "break
	-source this file has spaces.c -line 3".
	Check that an explicit source file followed by whitespace is
	identified as an invalid explicit location.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Record nested types
@ 2017-12-07 23:49 sergiodj+buildbot
  2017-12-08  4:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-07 23:49 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 883fd55ab1049333364479a7f5b0c7e61a310bac ***

Author: Keith Seitz <keiths@redhat.com>
Branch: master
Commit: 883fd55ab1049333364479a7f5b0c7e61a310bac

Record nested types

GDB currently does not track types defined in classes.  Consider:

class A
{
  public:

  class B
  {
    public:
      class C { };
  };
};

(gdb) ptype A
type = class A {
   <no data fields>
}

This patch changes this behavior so that GDB records these nested types
and displays them to the user when he has set the (new) "print type"
option "nested-type-limit."

Example:

(gdb) set print type nested-type-limit 1
(gdb) ptype A
type = class A {
    <no data fields>
    class A::B {
        <no data fields>
    };
}
(gdb) set print type nested-type-limit 2
type = class A {
    <no data fields>
    class A::B {
        <no data fields>
        class A::B::C {
            <no data fields>
        };
    };
}

By default, the code maintains the status quo, that is, it will not print
any nested type definitions at all.

Testing is carried out via cp_ptype_class which required quite a bit of
modification to permit recursive calling (for the nested types).  This
was most easily facilitated by turning the ptype command output into a
queue.  Upshot: the test suite now has stack and queue data structures that
may be used by test writers.

gdb/ChangeLog

	* NEWS (New commands): Mention set/show print type nested-type-limit.
	* c-typeprint.c (c_type_print_base): Print out nested types.
	* dwarf2read.c (struct typedef_field_list): Rename to ...
	(struct decl_field_list): ... this.  Change all uses.
	(struct field_info) <nested_types_list, nested_types_list_count>:
	New fields.
	(add_partial_symbol): Look for nested type definitions in C++, too.
	(dwarf2_add_typedef): Rename to ...
	(dwarf2_add_type_defn): ... this.
	(type_can_define_types): New function.
	Update assertion to use type_can_define_types.
	Permit NULL for a field's name.
	(process_structure_scope): Handle child DIEs of types that can
	define types.
	Copy the list of nested types into the type struct.
	* gdbtypes.h (struct typedef_field): Rename to ...
	(struct decl_field): ... this.  Change all uses.
	[is_protected, is_private]: New fields.
	(struct cplus_struct_type) <nested_types, nested_types_count>: New
	fields.
	(TYPE_NESTED_TYPES_ARRAY, TYPE_NESTED_TYPES_FIELD)
	(TYPE_NESTED_TYPES_FIELD_NAME, TYPE_NESTED_TYPES_FIELD_TYPE)
	(TYPE_NESTED_TYPES_COUNT, TYPE_NESTED_TYPES_FIELD_PROTECTED)
	(TYPE_NESTED_TYPES_FIELD_PRIVATE): New macros.
	* typeprint.c (type_print_raw_options, default_ptype_flags): Add
	default value for print_nested_type_limit.
	(print_nested_type_limit): New static variable.
	(set_print_type_nested_types, show_print_type_nested_types): New
	functions.
	(_initialize_typeprint): Register new commands for set/show
	`print-nested-type-limit'.
	* typeprint.h (struct type_print_options) [print_nested_type_limit]:
	New field.

gdb/testsuite/ChangeLog

	* gdb.cp/nested-types.cc: New file.
	* gdb.cp/nested-types.exp: New file.
	* lib/cp-support.exp: Load data-structures.exp library.
	(debug_cp_test_ptype_class): New global.
	(cp_ptype_class_verbose, next_line): New procedures.
	(cp_test_ptype_class): Add and document new parameter `recursive_qid'.
	Add and document new return value.
	Switch the list of lines to a queue.
	Add support for new `type' key for nested type definitions.
	Add debugging/troubleshooting messages.
	* lib/data-structures.exp: New file.

gdb/doc/ChangeLog

	* gdb.texinfo (Symbols): Document "set print type nested-type-limit"
	and "show print type nested-type-limit".


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix wrong prefix in py-breakpoint.exp
@ 2017-12-07 22:54 sergiodj+buildbot
  2017-12-08  3:15 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-07 22:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ec72db3ef415ebdcedaf36a1d83bd6624ec063e0 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: ec72db3ef415ebdcedaf36a1d83bd6624ec063e0

Fix wrong prefix in py-breakpoint.exp

The prefix in test_bkpt_explicit_loc is wrong.  Instead of using
with_test_prefix directly, define test_bkpt_explicit_loc with
proc_with_prefix.

gdb/testsuite/ChangeLog:

	* gdb.python/py-breakpoint.exp (test_bkpt_explicit_loc): Define
	with proc_with_prefix, don't use with_test_prefix.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix regression in "commands"
@ 2017-12-07 22:13 sergiodj+buildbot
  2017-12-08  1:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-07 22:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 99598d713f45d1b26015ec3562d160dc2b3792e4 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 99598d713f45d1b26015ec3562d160dc2b3792e4

Fix regression in "commands"

Pedro pointed out a regression in "commands", where trying to clear a
breakpoint's command list would fail:

    (top-gdb) commands
    Type commands for breakpoint(s) 3, one per line.
    End with a line saying just "end".
    >end
    No breakpoints specified.
    (top-gdb)

I believe the bug was introduced by my patch that changes
counted_command_line to be a shared_ptr.  This causes the problem
because now the counted_command_line in commands_command_1 can be NULL,
whereas previously it never could be.

After some discussion, we agreed to simply remove the error case from
commands_command_1.

2017-12-07  Tom Tromey  <tom@tromey.com>

	PR breakpoints/22511:
	* breakpoint.c (commands_command_1): Don't throw an exception when
	no commands have been read.

2017-12-07  Tom Tromey  <tom@tromey.com>

	* gdb.base/break.exp: Add test for empty "commands".


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix build with g++ 6.3.1
@ 2017-12-07 19:41 sergiodj+buildbot
  2017-12-08  0:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-07 19:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 23a8d1862b7e5b95f0fe9d724c6be326e545e6d1 ***

Author: Adam Stylinski <adam.stylinski@etegent.com>
Branch: master
Commit: 23a8d1862b7e5b95f0fe9d724c6be326e545e6d1

Fix build with g++ 6.3.1

With g++ 6.3.1:

 target-descriptions.c: In member function virtual void
 print_c_tdesc::visit_pre(const target_desc*):
 target-descriptions.c:1836:16: error: types may not be defined in a
 for-range-declaration [-Werror]
      for (const struct bfd_arch_info *compatible : e->compatible)
		 ^~~~~~

I think at some point the forward declaration of this struct had been
removed and declared as a typedef.  This fixes that.

gdb/ChangeLog:
2017-12-07  Adam Stylinski  <adam.stylinski@etegent.com>

	PR c++/21222
	* target-descriptions.c (print_c_tdesc::visit_pre): Change type of
	range-for variable.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add virtual destructor to selftest
@ 2017-12-07 17:45 sergiodj+buildbot
  2017-12-07 21:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-07 17:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 30970df7d56bd65657c97296f31fe9862bf27e1d ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 30970df7d56bd65657c97296f31fe9862bf27e1d

Add virtual destructor to selftest

Clang 6 shows this warning

  In file included from /home/emaisin/src/binutils-gdb/gdb/common/selftest.c:19:
  In file included from /home/emaisin/src/binutils-gdb/gdb/common/common-defs.h:92:
  In file included from /home/emaisin/src/binutils-gdb/gdb/common/gdb_unique_ptr.h:23:
  In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/memory:81:
  /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/unique_ptr.h:76:2: error: delete called on 'selftests::selftest' that is abstract but has non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
          delete __ptr;
          ^
  /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/unique_ptr.h:236:4: note: in instantiation of member function 'std::default_delete<selftests::selftest>::operator()' requested here
            get_deleter()(__ptr);
            ^
  /home/emaisin/src/binutils-gdb/gdb/common/selftest.c:57:17: note: in instantiation of member function 'std::unique_ptr<selftests::selftest, std::default_delete<selftests::selftest> >::~unique_ptr' requested here
    tests[name] = std::unique_ptr<selftest> (test);
                  ^

The error is legitimate, we (the unique_ptr) are deleting selftest
objects through the base pointer, so technically the destructor should
be virtual, so that the destructor of the subclass is invoked.

gdb/ChangeLog:

	* common/selftest.h (struct selftest): Add virtual destructor.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] target_set_syscall_catchpoint, use gdb::array_view and bool
@ 2017-12-06 23:13 sergiodj+buildbot
  2017-12-07  2:05 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-06 23:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 649a140ccf129ff79ea55ac0cc23ebddec0f02ef ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 649a140ccf129ff79ea55ac0cc23ebddec0f02ef

target_set_syscall_catchpoint, use gdb::array_view and bool

I noticed that we're passing down a data/size pair to
target_ops::to_set_syscall_catchpoint.  This commit makes use of
gdb::array_view instead.  While at it, use bool where appropriate as
well.

gdb/ChangeLog:

	* break-catch-syscall.c (insert_catch_syscall)
	(remove_catch_syscall): Adjust to pass reference to
	inf_data->syscalls_counts directly via gdb::array_view.
	* fbsd-nat.c (fbsd_set_syscall_catchpoint): Adjust to use bool
	and gdb::array_view.
	* linux-nat.c (linux_child_set_syscall_catchpoint): Likewise.
	* remote.c (remote_set_syscall_catchpoint): Likewise.
	* target-debug.h (target_debug_print_bool): New.
	(define target_debug_print_gdb_array_view_const_int): New.
	* target-delegates.c: Regenerate.
	* target.h (target_ops) <to_set_syscall_catchpoint>: Use
	gdb::array_view and bool.
	(target_set_syscall_catchpoint): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] dyn_relocs tidy
@ 2017-12-06  8:12 sergiodj+buildbot
  2017-12-06 19:11 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-06  8:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3bf083ed23b1337341129b810ed5da29ba8207f9 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 3bf083ed23b1337341129b810ed5da29ba8207f9

dyn_relocs tidy

Many targets define their own dyn_relocs struct when they could use
struct elf_dyn_relocs.  This patch tidies that, and uses
readonly_dynrelocs in a few more places.

The SH adjust_dynamic_symbol had some really weird code dating back to
2002 that looked over dynamic relocations for any in SEC_HAS_CONTENTS
or SEC_READONLY sections, rather than just the usual SEC_READONLY
sections.  So basically any dynamic relocation.  What's more, the SH
relocate_section has no support for emitting dynamic relocations in
non-PIC.  In other words, SH has no support for avoiding copy relocs
in non-PIC.  I've made that more obvious by using "if (0 && ..)" in
asjust_dynamic_symbol.

Unfortunately, LM32, M32R, NDS32, and OR1K copied the bogus SH
adjust_dynamic_symbol code.  So none of those targets would have
avoided copy relocs.  LM32, M32R, NDS32 get the "if (0)" treatment
too.  (LM32 is even more broken in that non_got_ref is never set.)

OR1K relocate_section looks like it might support dynamic relocs in
non-PIC, so I've enabled the copy reloc avoidance code for that
target.

	* elf32-hppa.c (struct elf32_hppa_dyn_reloc_entry): Delete.  Use
	struct elf_dyn_relocs throughout file instead.
	(elf32_hppa_adjust_dynamic_symbol): Comment tidy.
	* elf32-lm32.c (struct elf_lm32_dyn_relocs): Delete.  Use
	struct elf_dyn_relocs throughout file instead.
	(lm32_elf_adjust_dynamic_symbol): Use readonly_dynrelocs, but disable.
	Disable -z no-copyreloc too.
	* elf32-m32r.c (struct elf_m32r_dyn_relocs): Delete.  Use
	struct elf_dyn_relocs throughout file instead.
	(m32r_elf_adjust_dynamic_symbol): Use readonly_dynrelocs, but disable.
	Disable -z no-copyreloc too.
	* elf32-metag.c (struct elf_metag_dyn_reloc_entry): Delete.  Use
	struct elf_dyn_relocs throughout file instead.
	(elf_metag_adjust_dynamic_symbol): Use readonly_dynrelocs.
	* elf32-microblaze.c (struct elf32_mb_dyn_relocs): Delete.  Use
	struct elf_dyn_relocs throughout file instead.
	(readonly_dynrelocs): New function.
	(microblaze_elf_adjust_dynamic_symbol): Use it.
	* elf32-nds32.c (struct elf_nds32_dyn_relocs): Delete.  Use
	struct elf_dyn_relocs throughout file instead.
	(nds32_elf_adjust_dynamic_symbol): Use readonly_dynrelocs, but disable.
	Disable -z no-copyreloc too.
	* elf32-nios2.c (struct elf32_nios2_dyn_relocs): Delete.  Use
	struct elf_dyn_relocs throughout file instead.
	* elf32-or1k.c (struct elf_or1k_dyn_relocs): Delete.  Use
	struct elf_dyn_relocs throughout file instead.
	(or1k_elf_adjust_dynamic_symbol): Use readonly_dynrelocs.
	* elf32-sh.c (struct elf_sh_dyn_relocs): Delete.  Use
	struct elf_dyn_relocs throughout file instead.
	(sh_elf_adjust_dynamic_symbol): Use readonly_dynrelocs, but disable.
	Disable -z no-copyreloc too.
	* elf32-tilepro.c (struct tilepro_elf_dyn_relocs): Delete.  Use
	struct elf_dyn_relocs throughout file instead.
	(tilepro_elf_adjust_dynamic_symbol): Use readonly_dynrelocs.
	* elfnn-riscv.c (struct riscv_elf_dyn_relocs): Delete.  Use
	struct elf_dyn_relocs throughout file instead.
	(riscv_elf_adjust_dynamic_symbol): Use readonly_dynrelocs.
	* elfxx-sparc.c (struct _bfd_sparc_elf_dyn_relocs): Delete.  Use
	struct elf_dyn_relocs throughout file instead.
	(_bfd_sparc_elf_adjust_dynamic_symbol): Use readonly_dynrelocs.
	* elfxx-tilegx.c (struct tilegx_elf_dyn_relocs): Delete.  Use
	struct elf_dyn_relocs throughout file instead.
	(tilegx_elf_adjust_dynamic_symbol): Use readonly_dynrelocs.
	* elf32-s390.c (elf_s390_adjust_dynamic_symbol): Use readonly_dynrelocs.
	* elf64-s390.c (elf_s390_adjust_dynamic_symbol): Use readonly_dynrelocs.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make tdesc_type::u::u::fields an std::vector
@ 2017-12-06  5:26 sergiodj+buildbot
  2017-12-06 12:48 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-06  5:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d05200d155f065b93e2dc353a7d33408c7574e9c ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: d05200d155f065b93e2dc353a7d33408c7574e9c

Make tdesc_type::u::u::fields an std::vector

This patch makes the tdesc_type::u::u::fields an std::vector of
tdesc_type_field.   The difficulty here is that the vector is part of a
union.  Because of this, I made fields a pointer to a vector, and
instantiate/destroy the vector if the type is one that uses this member
of the union

The field tdesc_type_field::name is changed to an std::string at the
same time.

gdb/ChangeLog:

	* target-descriptions.c (tdesc_type_field): Remove typedef.
	(DEF_VEC_O (tdesc_type_field)): Remove.
	(struct tdesc_type_field): Add constructor.
	<name>: Change type to std::string.
	(struct tdesc_type) <tdesc_type>: Instantiate vector if the type
	kind uses it.
	<~tdesc_type>: Destroy vector if the type kind uses it.
	<u::u::fields>: Change type to std::vector.
	(tdesc_gdb_type): Adjust.
	(tdesc_add_field): Adjust.
	(tdesc_add_typed_bitfield): Adjust.
	(tdesc_add_field): Adjust.
	(tdesc_add_enum_value): Adjust.
	(class print_c_tdesc) <visit>: Adjust.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Split tdesc_type into multiple classes
@ 2017-12-06  2:59 sergiodj+buildbot
  2017-12-06 15:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-06  2:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d4a0e8b57d6f85e4ee4a31e0e6929ff5b4fd9823 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: d4a0e8b57d6f85e4ee4a31e0e6929ff5b4fd9823

Split tdesc_type into multiple classes

This patch makes tdesc_type an abstract base class and creates three
subclasses:

- tdesc_type_builtin, for builtin types
- tdesc_type_vector, for vector types
- tdesc_type_with_fields, for struct, union, flag and enum types

This allows getting rid of the union in tdesc_type and to not allow the
std::vector separately.  I tried to go further and create separate
classes for struct, union, flag and enum, but it proved too difficult.
One problem is that from the point of the of the target description
code, the types tdesc_type_* are opaque (only forward-declared).
Therefore, it doesn't know about inheritance relationship between those
classes.  This makes it impossible to make functions that accept a
pointer to a base class and pass a pointer to a derived class, for
example.  I think this patch here is a good compromise, and if somebody
wants to improve things further, the door is open.

A make_gdb_type virtual pure method is added to tdesc_type, which
replaces the current tdesc_gdb_type function.  Calling this method on a
tdesc_type returns the corresponding built gdb type.

gdb/ChangeLog:

	* target-descriptions.c (struct tdesc_type): Use default
	destructor.
	<u>: Remove.
	<accept>: Remove.
	(struct tdesc_type_builtin): New.
	(struct tdesc_type_vector): New.
	(struct tdesc_type_with_fields): New.
	(tdesc_predefined_types): Change type to tdesc_type_builtin[].
	(tdesc_gdb_type): Remove.
	(tdesc_register_type): Adjust.
	(tdesc_create_vector): Create tdesc_type_vector.
	(tdesc_create_struct): Create tdesc_type_with_fields.
	(tdesc_set_struct_size): Change parameter type.
	(tdesc_create_union): Create tdesc_type_with_fields.
	(tdesc_create_flags): Likewise.
	(tdesc_create_enum): Likewise.
	(tdesc_add_field): Change parameter type.
	(tdesc_add_typed_bitfield): Likewise.
	(tdesc_add_bitfield): Likewise.
	(tdesc_add_flag): Likewise.
	(tdesc_add_enum_value): Likewise.
	(print_c_tdesc) <visit>: Remove overload with tdesc_type
	parameter, add overloads for tdesc_type_builtin,
	tdesc_type_with_fields and tdesc_type_vector.
	<m_printed_type>: Remove.
	<m_printed_element_type, m_printed_type_with_fields>: Add.
	* target-descriptions.h (tdesc_create_enum): Change return type.
	(tdesc_add_typed_bitfield): Change parameter type.
	(tdesc_add_enum_value): Change parameter type.
	* xml-tdesc.c (struct tdesc_parsing_data) <current_type>: Change
	type to tdesc_type_with_fields.
	(tdesc_start_struct): Adjust.
	(tdesc_start_flags): Adjust.
	(tdesc_start_enum): Adjust.
	(tdesc_start_field): Adjust.
	* arch/tdesc.h (struct tdesc_type_builtin): Forward-declare.
	(struct tdesc_type_vector): Forward-declare.
	(struct tdesc_type_with_fields): Forward-declare.
	(tdesc_create_struct): Change return type.
	(tdesc_create_union): Likewise.
	(tdesc_create_flags): Likewise.
	(tdesc_add_field): Change parameter type.
	(tdesc_set_struct_size): Likewise.
	(tdesc_add_bitfield): Likewise.
	(tdesc_add_flag): Likewise.
	* features: Re-generate C files.

gdb/gdbserver/ChangeLog:

	* tdesc.c (struct tdesc_type): Change return type.
	(tdesc_add_flag): Change parameter type.
	(tdesc_add_bitfield): Likewise.
	(tdesc_add_field): Likewise.
	(tdesc_set_struct_size): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make tdesc_type::name an std::string
@ 2017-12-06  1:26 sergiodj+buildbot
  2017-12-06 11:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-06  1:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 082b9140d953b9e6a78271384ec48ff5d0ba8fad ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 082b9140d953b9e6a78271384ec48ff5d0ba8fad

Make tdesc_type::name an std::string

This patch makes tdesc_type::name an std::string.  This way, we don't
need to free it manually in ~tdesc_type.  I think the comment on top of
name is not correct, the string is always malloc'ed.

gdb/ChangeLog:

	* target-descriptions.c (struct tdesc_type) <name>: Change type
	to std::string.
	<~tdesc_type>: Don't manually free name.
	<operator==>: Adjust.
	(tdesc_named_type): Adjust.
	(tdesc_find_type): Adjust.
	(tdesc_gdb_type): Adjust.
	(class print_c_tdesc) <visit>: Adjust.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make tdesc_feature::types an std::vector
@ 2017-12-06  1:05 sergiodj+buildbot
  2017-12-06 10:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-06  1:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 53c934e9fed9a35542661690e4e71febcbebb539 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 53c934e9fed9a35542661690e4e71febcbebb539

Make tdesc_feature::types an std::vector

This patch makes tdesc_feature::types an std::vector of unique_ptr of
tdesc_type.  This way, we don't need to manually free the objects and
the vector in ~tdesc_feature.

gdb/ChangeLog:

	* target-descriptions.c (tdesc_type_p): Remove typedef.
	(DEF_VEC_P (tdesc_type_p)): Remove.
	(struct tdesc_feature) <types>: Change type to std::vector.
	<~tdesc_feature>: Replace with default implementation.
	<accept>: Adjust.
	(tdesc_named_type): Adjust.
	(tdesc_create_vector): Adjust.
	(tdesc_create_struct): Adjust.
	(tdesc_create_union): Adjust.
	(tdesc_create_flags): Adjust.
	(tdesc_create_enum): Adjust.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make tdesc_reg string fields std::string
@ 2017-12-06  0:44 sergiodj+buildbot
  2017-12-06  8:22 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-06  0:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a8142ee195063e8c7202429e80ee58185c34b3fc ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: a8142ee195063e8c7202429e80ee58185c34b3fc

Make tdesc_reg string fields std::string

Make the name, group and type fields of tdesc_reg std::strings.  This
way, we don't have to manually free them in ~tdesc_reg.

Doing so results in a small change in the generated tdesc.  Instead of
passing an empty string for the group parameter of tdesc_create_reg, the
two modified tdesc now pass NULL.  The end result should be the same.

gdb/ChangeLog:

	* target-descriptions.c (struct tdesc_reg) <tdesc_reg>: Change
	type of name_ parameter, adjust to std::string change.
	<name, group, type>: Change type to std::string.
	<~tdesc_reg>: Replace with default implementation.
	<operator==>: Adjust.
	(tdesc_find_register_early): Adjust.
	(tdesc_register_name): Adjust.
	(tdesc_register_type): Adjust.
	(tdesc_register_in_reggroup_p): Adjust.
	(class print_c_tdesc) <visit>: Adjust.
	(class print_c_feature) <visit>: Adjust.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make target_desc::features an std::vector
@ 2017-12-06  0:22 sergiodj+buildbot
  2017-12-06  4:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-06  0:22 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3eea796c5daeb7b60531fc3d707470fa91a86e11 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 3eea796c5daeb7b60531fc3d707470fa91a86e11

Make target_desc::features an std::vector

This patch makes target_desc to be a vector of unique_ptr to
tdesc_feature objects.  This way, we don't have to manually free the
features and the vector in the target_desc destructor.

gdb/ChangeLog:

	* target-descriptions.c (tdesc_feature_p): Remove typedef.
	(DEF_VEC_P (tdesc_feature_p)): Remove.
	(struct target_desc) <features>: Change type to std::vector.
	<~target_desc>: Replace with default implementation.
	<accept>: Adjust.
	<operator==>: Adjust.
	(tdesc_has_registers): Adjust.
	(tdesc_find_feature): Adjust.
	(tdesc_use_registers): Adjust.
	(tdesc_create_feature): Adjust.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make target_desc::compatible an std::vector
@ 2017-12-05 23:22 sergiodj+buildbot
  2017-12-06  3:03 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-05 23:22 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 40e2a9835f6cf47b630babef3fd788e413ef2dc5 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 40e2a9835f6cf47b630babef3fd788e413ef2dc5

Make target_desc::compatible an std::vector

This patch changes target_desc::compatible to be a vector of
bfd_arch_info *.  This way, we don't need to manually free the vector in
the target_desc destructor.

gdb/ChangeLog:

	* target-descriptions.c (arch_p): Remove typedef.
	(DEF_VEC_P (arch_p)): Remove.
	(struct target_desc) <compatible>: Change type to std::vector.
	<~target_desc>: Don't manually free compatible.
	(tdesc_compatible_p): Adjust.
	(tdesc_add_compatible): Adjust.
	(class print_c_tdesc) <visit_pre>: Adjust.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make target_desc::properties an std::vector
@ 2017-12-05 22:53 sergiodj+buildbot
  2017-12-06  1:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-05 22:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 129c10bcb9b3bc2ed9682040aa9a0d144bb5e959 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 129c10bcb9b3bc2ed9682040aa9a0d144bb5e959

Make target_desc::properties an std::vector

This patch changes target_desc::properties to be a vector of property
objects.  This way, we don't need to manually free the property members
as well as the property objects themselves.

gdb/ChangeLog:

	* target-descriptions.c (property_s): Remove typedef.
	(DEF_VEC_O (property_s)): Remove.
	(struct target_desc) <properties>: Make an std::vector.
	<~target_desc>: Don't manually free properties.
	(tdesc_property): Adjust.
	(set_tdesc_property): Adjust.
	(class print_c_tdesc) <visit_pre>: Adjust.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Redefine gdb_static_assert as static_assert
@ 2017-12-05 22:06 sergiodj+buildbot
  2017-12-05 23:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-05 22:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ed9376bd95c52ba00aa37b224b4407030a00d184 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: ed9376bd95c52ba00aa37b224b4407030a00d184

Redefine gdb_static_assert as static_assert

Since we use C++11, we can use static_assert instead doing the trick
that makes a negative-sized array if the expression is false.
static_assert is built in the language and gives clearer error messages.

To avoid modifying the usages of gdb_static_assert, redefine
gdb_static_assert in terms of static_assert, passing an empty message.
If we want to add an assert with a message, it's always possible to use
static_assert directly.

gdb/ChangeLog:

	* common/gdb_assert.h (gdb_static_assert): Redefine using
	static_assert.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Implement "-a" command line option for gcore
@ 2017-12-04 18:58 sergiodj+buildbot
  2017-12-04 22:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-04 18:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cd93789b89f55355d3eeda6c31ed7bd0ed318acd ***

Author: Sergio Lopez <slp@redhat.com>
Branch: master
Commit: cd93789b89f55355d3eeda6c31ed7bd0ed318acd

Implement "-a" command line option for gcore

With the new "-a" command line option, the user may request gcore to
actually dump all present memory mappings. The actual effect of this
argument is OS dependent.

On GNU/Linux, it will disable use-coredump-filter and enable
dump-excluded-mappings.

gdb/ChangeLog:
2017-11-29  Sergio Lopez  <slp@redhat.com>

	* gcore.in: Add "-a" command line option for instructing gdb to
	dump all memory mappings (OS dependent).


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Document new {set, show} dump-excluded-mappings commands.
@ 2017-12-04 18:27 sergiodj+buildbot
  2017-12-04 21:22 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-04 18:27 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1e52e8495a074c9d1f7ef17f13b9060b76be6f41 ***

Author: Sergio Lopez <slp@redhat.com>
Branch: master
Commit: 1e52e8495a074c9d1f7ef17f13b9060b76be6f41

Document new {set,show} dump-excluded-mappings commands.

gdb/ChangeLog:
2017-11-29  Sergio Lopez  <slp@redhat.com>

	* NEWS (Changes since GDB 8.0): Announce {set,show}
	dump_excluded_mappings commands.

gdb/doc/ChangeLog:
2017-11-29  Sergio Lopez  <slp@redhat.com>

	* gdb.texinfo (gcore): Mention new {set,show}
	dump-excluded-mappings commands.
	(set dump-excluded-mappings): Document new command.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86 map file textrel
@ 2017-12-04 12:57 sergiodj+buildbot
  2017-12-04 15:33 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-04 12:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 826c3f1edc2f9da4594aed86b57a7b447a46016d ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 826c3f1edc2f9da4594aed86b57a7b447a46016d

x86 map file textrel

bfd/
	* elfxx-x86.c (readonly_dynrelocs): New function.
	(maybe_set_textrel): New function.  Always prints via minfo and
	correct "readonly" to "read-only" in warning message., replacing..
	(_bfd_x86_elf_readonly_dynrelocs): ..this.
	(_bfd_x86_elf_size_dynamic_sections): Correct "readonly" to
	"read-only" in warning message.  Formatting.
	(_bfd_x86_elf_adjust_dynamic_symbol): Use readonly_dynrelocs.
	* linker.c (bfd_link_hash_traverse): Comment typo fix.
ld/
	* testsuite/ld-i386/pr17935-1.d: Adjust expected error.
	* testsuite/ld-i386/pr17935-2.d: Likewise.
	* testsuite/ld-x86-64/pr17935-1.d: Likewise.
	* testsuite/ld-x86-64/pr17935-2.d: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove mem_region_vector typedef
@ 2017-12-03 18:49 sergiodj+buildbot
  2017-12-04 14:18 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-03 18:49 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1e97a22796cced8bba3359df46e8c2883653516f ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 1e97a22796cced8bba3359df46e8c2883653516f

Remove mem_region_vector typedef

Now that make-target-delegates understands namespaces and templates,
this typedef is no longer useful.

gdb/ChangeLog:

	* target.h (mem_region_vector): Remove.
	(struct target_ops) <to_memory_map>: Change return type to
	std::vector<mem_region>.
	* target-debug.h (target_debug_print_mem_region_vector): Rename
	to ...
	(target_debug_print_std_vector_mem_region): ... this.
	* target-delegates.c: Re-generate.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make make-target-delegates grok namespace scope op and template params
@ 2017-12-03 18:21 sergiodj+buildbot
  2017-12-04 12:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-03 18:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 10f64178412d9c6e4f2faade0da271ab8be273c9 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 10f64178412d9c6e4f2faade0da271ab8be273c9

Make make-target-delegates grok namespace scope op and template params

The next patch will want to use gdb::array_view<int> as parameter type
of a target_ops method.  However, that runs into a
make-target-delegates limitation: target_debug_foo calls in
target-delegates.c for parameters/return types with namespace scope
operators ("::") or template parameters, end up looking like:

 @@ -1313,9 +1313,7 @@ debug_set_syscall_catchpoint (struct target_ops *self, int arg1, int arg2, int a
    fputs_unfiltered (", ", gdb_stdlog);
    target_debug_print_int (arg3);
    fputs_unfiltered (", ", gdb_stdlog);
 -  target_debug_print_int (arg4);
 -  fputs_unfiltered (", ", gdb_stdlog);
 -  target_debug_print_int_p (arg5);
 +  target_debug_print_gdb::array_view<const_int> (arg4);

which obviously isn't something that compiles.  The problem is that
make-target-delegates wasn't ever taught that '::', '<', and '>' can
appear in parameter/return types.  You could work around it by hidding
the unsupported characters behind a typedef in the target method
declaration, or by using an explicit TARGET_DEBUG_PRINTER, but it's
better to just remove the limitation.

While at it, also fix an "abuse" of reserved identifiers.

gdb/ChangeLog:

	* make-target-delegates (munge_type): Also munge '<', '>', and
	':'.  Avoid double underscores in identifiers, and trailing
	underscores.
	* target-debug.h
	(target_debug_print_VEC_static_tracepoint_marker_p__p): Rename to
	...
	(target_debug_print_VEC_static_tracepoint_marker_p_p): ... this.
	* target-delegates.c: Regenerate.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix gdb.threads/process-dies-while-detaching.exp
@ 2017-12-03 16:34 sergiodj+buildbot
  2017-12-04 10:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-03 16:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f0fb2488c93c00fa1436a4813a375faa00a94de5 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: f0fb2488c93c00fa1436a4813a375faa00a94de5

Fix gdb.threads/process-dies-while-detaching.exp

I noticed [1] a test bug in gdb.threads/process-dies-while-detaching.exp.
Simplified, the test code in question looks somewhat like this:

~~~
  # Detach from a process, and ensure that it exits after detaching.
  # This relies on inferior I/O.

  proc detach_and_expect_exit {test} {

      gdb_test_multiple "detach" $test ....

      set saw_prompt 0
      set saw_inf_exit 0
      while { !$saw_prompt && !$saw_inf_exit } {
          gdb_test_multiple "" $test {
              -re "exited, status=0" {
                  set saw_inf_exit 1
              }
              -re "$gdb_prompt " {
                  set saw_prompt 1
              }
          }
      }

      pass $test
  }
~~~

The bug is in the while loop's condition.  We want to make sure we see
both the inferior output and the prompt, so the loop's test should be:

   -    while { !$saw_prompt && !$saw_inf_exit } {
   +    while { !$saw_prompt || !$saw_inf_exit } {

If we just fix that, the test starts failing though, because it
exposes a couple latent problems:

- When called from test_detach_killed_outside, the parent doesn't
  print "exited, status=0", because in that case the child dies with a
  signal, and so detach_and_expect_exit times out.

  Fix it by making the parent print "signaled, sig=9" in that case,
  and have the .exp expect it.

- When testing against --target_board=native-gdbserver, sometimes we'd
  get this:

    ERROR: Process no longer exists
    ERROR: : spawn id exp9 not open
	while executing
    "expect {
    -i exp8 -timeout 220
	    -i $server_spawn_id
	    eof {
		pass $test
		wait -i $server_spawn_id
		unset server_spawn_id
	    }
	    timeout {
	       ..."
	("uplevel" body line 1)
	invoked from within
    "uplevel $body" NONE : spawn id exp9 not open

  The problem is that:

   - inferior_spawn_id and server_spawn_id are the same when testing
     with gdbserver.
   - gdbserver exits after "detach", so we get an eof for
     $inferior_spawn_id in the loop in detach_and_expect_exit.
     That's the first "ERROR: Process no longer exists".
   - and then when we reach test_server_exit, server_spawn_id
     is already closed (because server_spawn_id==inferior_spawn_id).

  To handle this, make the loop in detach_and_expect_exit use an
  indirect spawn id list and remove $inferior_spawn_id from the list
  as soon as we got the inferior output we're expecting, so that the
  "eof" is left unprocessed until we reach test_server_exit.

[1] I changed GDB in a way that should have made the test fail, but it
    didn't.

gdb/testsuite/ChangeLog:
2017-12-03  Pedro Alves  <palves@redhat.com>

	* gdb.threads/process-dies-while-detaching.c: Include <errno.h>
	and <string.h>.
	(parent_function): Print distinct messages when waitpid fails, or
	the child exits with a signal, or the child exits for an unhandled
	reason.
	* gdb.threads/process-dies-while-detaching.exp
	(detach_and_expect_exit): New 'inf_output_re' parameter and use
	it.  Wait for both inferior output and GDB's prompt.  Use an
	indirect spawn id list.
	(do_detach): New parameter 'child_exit'.  Use it to compute
	expected inferior output.
	(test_detach, test_detach_watch, test_detach_killed_outside):
	Adjust to pass down the expected child exit kind.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove usage of find_inferior in linux_resume
@ 2017-12-03 13:24 sergiodj+buildbot
  2017-12-03 22:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-03 13:24 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c80825ff32ba805982ef5e66e4fa1a80e019d47d ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: c80825ff32ba805982ef5e66e4fa1a80e019d47d

Remove usage of find_inferior in linux_resume

Replace with for_each_thread.

gdb/gdbserver/ChangeLog:

	* linux-low.c (linux_resume_one_thread): Return void, take
	parameter directly.
	(linux_resume): Use for_each_thread.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove usage of find_inferior in linux_stabilize_threads
@ 2017-12-03 12:00 sergiodj+buildbot
  2017-12-03 19:48 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-03 12:00 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5a6b0a41dfc9b860f285ddb3a1e518299f614cd3 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 5a6b0a41dfc9b860f285ddb3a1e518299f614cd3

Remove usage of find_inferior in linux_stabilize_threads

Replace with find_thread.

gdb/gdbserver/ChangeLog:

	* linux-low.c (lwp_running): Return bool, remove unused
	argument.
	(linux_stabilize_threads): Use find_thread.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove usages of find_inferior calling not_stopped_callback
@ 2017-12-03 10:23 sergiodj+buildbot
  2017-12-03 17:08 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-03 10:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a1385b7b881d2b129f8c26fac8ad20bc406a1a6d ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: a1385b7b881d2b129f8c26fac8ad20bc406a1a6d

Remove usages of find_inferior calling not_stopped_callback

Replace with find_thread.  Writing a lambda inline in directly in the if
conditions would be a bit messy, so I chose to assign them to variables
instead.

gdb/gdbserver/ChangeLog:

	* linux-low.c (not_stopped_callback): Return bool, take filter
	argument directly.
	(linux_wait_for_event_filtered): Use find_thread.
	(linux_wait_1): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove for_each_inferior
@ 2017-12-03  9:36 sergiodj+buildbot
  2017-12-04  3:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-03  9:36 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f004534791145669d7765f8122e48f21e1deeb94 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: f004534791145669d7765f8122e48f21e1deeb94

Remove for_each_inferior

This patch removes for_each_inferior, replacing all its usages with
for_each_thread.

gdb/gdbserver/ChangeLog:

	* inferiors.c (for_each_inferior): Remove.
	(clear_inferiors): Use for_each_thread.
	* inferiors.h (for_each_inferior): Remove.
	* linux-low.c (linux_wait_for_event_filtered): Use
	for_each_thread.
	(linux_stabilize_threads): Likewise.
	* regcache.c (regcache_release): Likewise.
	* server.c (gdb_wants_all_threads_stopped): Likewise.
	(clear_pending_status_callback): Remove.
	(handle_status): Use for_each_thread.
	(captured_main): Likewise.
	* win32-low.c (child_init_thread_list): Likewise.
	(win32_clear_inferiors): Likewise.
	(fake_breakpoint_event): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Update comments
@ 2017-12-03  8:58 sergiodj+buildbot
  2017-12-04  0:49 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-03  8:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8f86d7aa8504e9a557e807a3e37718055befcd84 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 8f86d7aa8504e9a557e807a3e37718055befcd84

Update comments

These functions were modified in the previous patch series, but I forgot
to update some comments.

gdb/gdbserver/ChangeLog:

	* linux-low.c (resume_status_pending_p): Update comment.
	(need_step_over_p): Update comment.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove usages of find_inferior that call proceed_one_lwp
@ 2017-12-03  8:38 sergiodj+buildbot
  2017-12-03 23:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-03  8:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e2b4407579df508f85de961dd693c9028e79d823 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: e2b4407579df508f85de961dd693c9028e79d823

Remove usages of find_inferior that call proceed_one_lwp

Replace with for_each_thread.

gdb/gdbserver/ChangeLog:

	* linux-low.c (proceed_one_lwp): Return void, change parameter
	type.
	(unsuspend_and_proceed_one_lwp): Likewise.
	(proceed_all_lwps): Use for_each_thread.
	(unstop_all_lwps): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove usages of find_inferior in stop_all_lwps
@ 2017-12-03  7:50 sergiodj+buildbot
  2017-12-03 21:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-03  7:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT df3e4dbe661e522cc63d3dab15c3974713fba4dd ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: df3e4dbe661e522cc63d3dab15c3974713fba4dd

Remove usages of find_inferior in stop_all_lwps

Replace with for_each_thread.

gdb/gdbserver/ChangeLog:

	* linux-low.c (send_sigstop_callback): Return void, change
	parameter type.  Rename to...
	(send_sigstop): ... this.
	(suspend_and_send_sigstop_callback): Return void, change parameter
	type.  Rename to...
	(suspend_and_send_sigstop): ... this.
	(stop_all_lwps): Use for_each_thread.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove find_inferior_in_random
@ 2017-12-03  6:09 sergiodj+buildbot
  2017-12-03 10:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-03  6:09 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 83e1b6c13a285b4e1e852e1647667f09bb26892b ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 83e1b6c13a285b4e1e852e1647667f09bb26892b

Remove find_inferior_in_random

Replace with find_thread_in_random.

gdb/gdbserver/ChangeLog:

	* inferiors.c (find_inferior_in_random): Remove.
	* inferiors.h (find_inferior_in_random): Remove.
	* linux-low.c (status_pending_p_callback): Return bool, accept
	parameter ptid directly.
	(linux_wait_for_event_filtered): Use find_thread_in_random.
	(linux_wait_1): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove usage of find_inferior in last_thread_of_process_p
@ 2017-12-03  4:22 sergiodj+buildbot
  2017-12-03 12:00 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-03  4:22 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e4eb0dec0b9219a27ea6b9769f098fff34612779 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: e4eb0dec0b9219a27ea6b9769f098fff34612779

Remove usage of find_inferior in last_thread_of_process_p

Replace it with find_thread.  I also modified the code a bit to use a
lambda and a boolean.

gdb/gdbserver/ChangeLog:

	* linux-low.c (struct counter): Remove.
	(second_thread_of_pid_p): Remove.
	(last_thread_of_process_p): Use find_thread.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove find_inferior_id
@ 2017-12-03  3:14 sergiodj+buildbot
  2017-12-03  9:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-03  3:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8dc7b443a6295da4b3d7ba22f3a7695990bf4f39 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 8dc7b443a6295da4b3d7ba22f3a7695990bf4f39

Remove find_inferior_id

Remove find_inferior_id, replacing its usages with find_thread_ptid.
find_thread_ptid was implemented using find_inferior_id, so move the
implementation there instead.

gdb/gdbserver/ChangeLog:

	* inferiors.c (find_inferior_id): Remove.
	(find_thread_ptid): Move implemention from find_inferior_id to
	here.
	* inferiors.h (find_inferior_id): Remove.
	* server.c (handle_status): Use find_thread_ptid.
	(process_serial_event): Likewise.
	* thread-db.c (find_one_thread): Likewise.
	(thread_db_thread_handle): Likewise.
	* win32-low.c (thread_rec): Likewise.
	(child_delete_thread): Likewise.
	(win32_thread_alive): Likewise.
	(get_child_debug_event): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove usage of find_inferior in regcache_invalidate_pid
@ 2017-12-03  2:14 sergiodj+buildbot
  2017-12-03  4:14 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-03  2:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 634a3254c8fe1728c0202289afe594928094d860 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 634a3254c8fe1728c0202289afe594928094d860

Remove usage of find_inferior in regcache_invalidate_pid

Replace with for_each_thread with pid filtering.
regcache_invalidate_one is not longer needed, as it was only used to
filter the pid.  We can call regcache_invalidate_thread directly.

gdb/gdbserver/ChangeLog:

	* regcache.c (regcache_invalidate_one): Remove.
	(regcache_invalidate_pid): use for_each_thread.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix typo in poison.h
@ 2017-12-03  1:53 sergiodj+buildbot
  2017-12-03  2:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-03  1:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6d83e819df0c71868d04db46c60ff0ecf8cf1914 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 6d83e819df0c71868d04db46c60ff0ecf8cf1914

Fix typo in poison.h

gdb/ChangeLog:

	* common/poison.h (XDELETE): Fix typo.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add support for the readnever concept
@ 2017-12-02  2:52 sergiodj+buildbot
  2017-12-02  3:58 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-02  2:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 97cbe998d0dd5c13a0317fbb24d745da367d8caa ***

Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: 97cbe998d0dd5c13a0317fbb24d745da367d8caa

Add support for the readnever concept

The purpose of this concept is to turn the load of debugging
information off, either globally (via the '--readnever' option), or
objfile-specific.  The implementation proposed here is an extension of
the patch distributed with Fedora GDB; looking at the Fedora patch
itself and the history, one can see some reasons why it was never
resubmitted:

  - The patch appears to have been introduced as a workaround, at
    least initially;
  - The patch is far from perfect, as it simply shunts the load of
    DWARF debugging information, without really worrying about the
    other debug format.
  - Who really does non-symbolic debugging anyways?

One use of this feature is when a user simply wants to do the
following sequence: attach, dump core, detach.  Loading the debugging
information in this case is an unnecessary cause of delay.

This patch expands the version shipped with Fedora GDB in order to
make the feature available for all the debuginfo backends, not only
for DWARF.  It also implements a per-objfile flag which can be
activated by using the "-readnever" command when using the
'add-symbol-file' or 'symbol-file' commands.

It's also worth mentioning that this patch tests whether GDB correctly
fails to initialize if both '--readnow' and '--readnever' options are
passed.

Tested on the BuildBot.

gdb/ChangeLog:

2017-12-01  Andrew Cagney  <cagney@redhat.com>
	    Joel Brobecker  <brobecker@adacore.com>
	    Sergio Durigan Junior  <sergiodj@redhat.com>

	* NEWS (Changes since GDB 8.0: Mention new '--readnever'
	feature.
	* coffread.c (coff_symfile_read): Do not map over sections with
	'coff_locate_sections' if readnever is on.
	* dwarf2read.c (dwarf2_has_info): Return 0 if
	readnever is on.
	* elfread.c (elf_symfile_read): Do not map over sections with
	'elf_locate_sections' if readnever is on.
	* main.c (validate_readnow_readnever): New function.
	(captured_main_1): Add support for --readnever.
	(print_gdb_help): Document --readnever.
	* objfile-flags.h (enum objfile_flag) <OBJF_READNEVER>: New
	flag.
	* symfile.c (readnever_symbol_files): New global.
	(symbol_file_add_with_addrs): Set 'OBJF_READNEVER' when
	'READNEVER_SYMBOL_FILES' is set.
	(validate_readnow_readnever): New function.
	(symbol_file_command): Handle '-readnever' option.
	Call 'validate_readnow_readnever'.
	(add_symbol_file_command): Handle '-readnever' option.
	Call 'validate_readnow_readnever'.
	(_initialize_symfile): Document new '-readnever' option for
	both 'symbol-file' and 'add-symbol-file' commands.
	* top.h (readnever_symbol_files): New extern global.
	* xcoffread.c (xcoff_initial_scan): Do not read debug
	information if readnever is on.

gdb/doc/ChangeLog:

2017-12-01  Andrew Cagney  <cagney@redhat.com>
	    Joel Brobecker  <brobecker@adacore.com>
	    Sergio Durigan Junior  <sergiodj@redhat.com>

	* gdb.texinfo (File Options): Document --readnever.
	(Commands to Specify Files): Likewise, for 'symbol-file' and
	'add-symbol-file'.

gdb/testsuite/ChangeLog:

2017-12-01  Joel Brobecker  <brobecker@adacore.com>
	    Sergio Durigan Junior  <sergiodj@redhat.com>
	    Pedro Alves  <palves@redhat.com>

	* gdb.base/readnever.c, gdb.base/readnever.exp: New files.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Revert "Add support for the readnever concept"
@ 2017-12-01 22:25 sergiodj+buildbot
  2017-12-01 23:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-01 22:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7f0f8ac8b15f5f5327116614b4137e5dd533ada2 ***

Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: 7f0f8ac8b15f5f5327116614b4137e5dd533ada2

Revert "Add support for the readnever concept"

This reverts commit e2e321740ce2e36a97be2a410cd56eebaa2304aa.

It was mistakenly pushed.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Use consistent types for holding instructions, instruction masks, etc.
@ 2017-12-01 17:42 sergiodj+buildbot
  2017-12-01 18:59 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-01 17:42 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0f873fd58b51a2906f31bb445ab685da04a1be23 ***

Author: Peter Bergner <bergner@vnet.ibm.com>
Branch: master
Commit: 0f873fd58b51a2906f31bb445ab685da04a1be23

Use consistent types for holding instructions, instruction masks, etc.

include/
	* opcode/ppc.h (PPC_INT_FMT): Define.
	(struct powerpc_opcode) <opcode>: Update type.
	(struct powerpc_opcode) <mask>: Likewise.
	(struct powerpc_opcode) <bitm>: Likewise.
	(struct powerpc_opcode) <insert>: Likewise.
	(struct powerpc_opcode) <extract>: Likewise.
	(ppc_optional_operand_value): Likewise.

gas/
	* config/tc-ppc.c (last_insn): Update type.
	(insn_validate) <omask, mask>: Likewise.
	(ppc_setup_opcodes) <mask, right_bit>: Likewise.
	<PRINT_OPCODE_TABLE>: Update types and printf format specifiers.
	(ppc_insert_operand): Update return and argument types and remove
	unneeded type casts.
	<min, max, right, tmp>: Update type.
	(md_assemble): Remove unneeded type casts.
	<insn, val, tmp_insn>: Update type.

opcodes/
	* opcodes/ppc-dis.c (disassemble_init_powerpc): Fix white space.
	(operand_value_powerpc): Update return and argument type.
	<value, top>: Update type.
	(skip_optional_operands): Update argument type.
	(lookup_powerpc): Likewise.
	(lookup_vle): Likewise.
	<table_opcd, table_mask, insn2>: Update type.
	(lookup_spe2): Update argument type.
	<table_opcd, table_mask, insn2>: Update type.
	(print_insn_powerpc) <insn, value>: Update type.
	Use PPC_INT_FMT for printing instructions and operands.
	* opcodes/ppc-opc.c (insert_arx, extract_arx, insert_ary, extract_ary,
	insert_rx, extract_rx, insert_ry, extract_ry, insert_bat, extract_bat,
	insert_bba, extract_bba, insert_bdm, extract_bdm, insert_bdp,
	extract_bdp, valid_bo_pre_v2, valid_bo_post_v2, valid_bo, insert_bo,
	extract_bo, insert_boe, extract_boe, insert_dcmxs, extract_dcmxs,
	insert_dxd, extract_dxd, insert_dxdn, extract_dxdn, insert_fxm,
	extract_fxm, insert_li20, extract_li20, insert_ls, extract_ls,
	insert_esync, extract_esync, insert_mbe, extract_mbe, insert_mb6,
	extract_mb6, extract_nb, insert_nbi, insert_nsi, extract_nsi,
	insert_ral, extract_ral, insert_ram, extract_ram, insert_raq,
	extract_raq, insert_ras, extract_ras, insert_rbs, extract_rbs,
	insert_rbx, extract_rbx, insert_sci8, extract_sci8, insert_sci8n,
	extract_sci8n, insert_sd4h, extract_sd4h, insert_sd4w, extract_sd4w,
	insert_oimm, extract_oimm, insert_sh6, extract_sh6, insert_spr,
	extract_spr, insert_sprg, extract_sprg, insert_tbr, extract_tbr,
	insert_xt6, extract_xt6, insert_xtq6, extract_xtq6, insert_xa6,
	extract_xa6, insert_xb6, extract_xb6, insert_xb6s, extract_xb6s,
	insert_xc6, extract_xc6, insert_dm, extract_dm, insert_vlesi,
	extract_vlesi, insert_vlensi, extract_vlensi, insert_vleui,
	extract_vleui, insert_vleil, extract_vleil, insert_evuimm1_ex0,
	extract_evuimm1_ex0, insert_evuimm2_ex0, extract_evuimm2_ex0,
	insert_evuimm4_ex0, extract_evuimm4_ex0, insert_evuimm8_ex0,
	extract_evuimm8_ex0, insert_evuimm_lt8, extract_evuimm_lt8,
	insert_evuimm_lt16, extract_evuimm_lt16, insert_rD_rS_even,
	extract_rD_rS_even, insert_off_lsp, extract_off_lsp, insert_off_spe2,
	extract_off_spe2, insert_Ddd, extract_Ddd): Update types.
	(OP, OPTO, OPL, OPVUP, OPVUPRT, A, AFRALFRC_MASK, B, BD8, BD8IO, BD15,
	BD24, BBO, Y_MASK  , AT1_MASK, AT2_MASK, BBOCB, C_LK, C, CTX, UCTX,
	DX, EVSEL, IA16, I16A, I16L, IM7, LI20, MME, MD, MDS, SC, SC_MASK,
	SCI8, SCI8BF, SD4, SE_IM5, SE_R, SE_RR, VX, VX_LSP, VX_RA_CONST,
	VX_RB_CONST, VX_SPE_CRFD, VX_SPE2_CLR, VX_SPE2_SPLATB, VX_SPE2_OCTET,
	VX_SPE2_DDHH, VX_SPE2_HH, VX_SPE2_EVMAR, VX_SPE2_EVMAR_MASK, VXA,
	VXR, VXASH, X, EX, XX2, XX3, XX3RC, XX4, Z, XWRA_MASK, XLRT_MASK,
	XRLARB_MASK, XLRAND_MASK, XRTLRA_MASK, XRTLRARB_MASK, XRTARARB_MASK,
	XRTBFRARB_MASK, XOPL, XOPL2, XRCL, XRT, XRTRA, XCMP_MASK, XCMPL_MASK,
	XTO, XTLB, XSYNC, XEH_MASK, XDSS, XFL, XISEL, XL, XLO, XLYLK, XLOCB,
	XMBAR, XO, XOPS, XS, XFXM, XSPR, XUC, XW, APU): Update types in casts.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Update GDB's list of maintainers to reflect today's reality
@ 2017-12-01 13:57 sergiodj+buildbot
  2017-12-01 15:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-01 13:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2ee0c9b3eedca5d1071870334d2721be80a77ea1 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 2ee0c9b3eedca5d1071870334d2721be80a77ea1

Update GDB's list of maintainers to reflect today's reality

gdb/ChangeLog:

       * MAINTAINERS: Update list of maintainers, moving those who
       stepped down or became inactive to the "Past Maintainers"
       section.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: Print dynreloc in readonly section for map file output
@ 2017-12-01 12:37 sergiodj+buildbot
  2017-12-01 14:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-01 12:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 92f402a7e03f5d747bc9a09c8da2f61cc539ac33 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 92f402a7e03f5d747bc9a09c8da2f61cc539ac33

x86: Print dynreloc in readonly section for map file output

This fixed:

FAIL: DT_TEXTREL map file warning

on Linux/x86.

	* elfxx-x86.c (_bfd_x86_elf_readonly_dynrelocs): Print dynamic
	relocation in readonly section for map file output.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Replace mail address with the URL in copyright header
@ 2017-12-01 12:00 sergiodj+buildbot
  2017-12-01 13:05 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-01 12:00 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1cc75e929ff4e99b3bef4ca0e93250d5b1b126c9 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 1cc75e929ff4e99b3bef4ca0e93250d5b1b126c9

Replace mail address with the URL in copyright header

The copyright header in most of GDB files were changed from mail address
to the URL in the conversion to GPLv3 in Aug 2007.  However, some files
still use mail address instead of the URL.  This patch fixes them.

gdb/testsuite:

2017-12-01  Yao Qi  <yao.qi@linaro.org>

	* gdb.arch/aarch64-atomic-inst.exp: Replace mail address with
	the URL in copyright header.
	* gdb.arch/aarch64-fp.exp: Likewise.
	* gdb.arch/ppc64-atomic-inst.exp: Likewise.
	* gdb.arch/ppc64-isa207-atomic-inst.exp: Likewise.
	* gdb.base/expand-psymtabs.exp: Likewise.
	* gdb.cp/expand-psymtabs-cxx.exp: Likewise.
	* gdb.fortran/common-block.exp: Likewise.
	* gdb.fortran/common-block.f90: Likewise.
	* gdb.fortran/logical.exp: Likewise.
	* gdb.fortran/vla-datatypes.f90: Likewise.
	* gdb.fortran/vla-sub.f90: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] New gdb.ada/repeat_dyn testcase.
@ 2017-12-01  0:13 sergiodj+buildbot
  2017-12-01  9:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-12-01  0:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 875fb7a785e78fddef6da270636e8f4efbfd3e0d ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 875fb7a785e78fddef6da270636e8f4efbfd3e0d

New gdb.ada/repeat_dyn testcase.

This patch introduces a testcase that exercises a scenario
which used to trigger an internal-error, but no longer does:

Consider the following array:

   type Small is new Integer range Ident (1) .. Ident (10);
   type Table is array (1 .. 3) of Small;
   A1 : Table := (3, 5, 8);

The particularity of this array is that the type of each element
is a range type whose bounds are dynamic, since they depend on
the value returned by Ident (1) and Ident (10). Trying to apply
the repeat operator ('@') on one of its elements used to yield
an internal error:

    (gdb) p a1(1)@3
    $1 =
    /[...]/gdbtypes.c:4512: internal-error:
    copy_type: Assertion `TYPE_OBJFILE_OWNED (type)' failed.

Although the issue no longer appears, the testcase is still
interesting to have.

gdb/testsuite/ChangeLog:

        * gdb.ada/repeat_dyn: New testcase.

Tested on x86_64-linux with clean results.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Use boards/local-board.exp more
@ 2017-11-30 17:48 sergiodj+buildbot
  2017-12-01  5:29 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-30 17:48 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f1af7b94c16029f2c6da9eae4076f64cd9383687 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: f1af7b94c16029f2c6da9eae4076f64cd9383687

Use boards/local-board.exp more

local-board.exp was introduced recently, containing the code required to
force the gdbserver boards to be non-remote (from the DejaGNU point of
view).  Other board files use the same trick of forcing isremote to 0.
Instead of doing it by hand in each file, include local-board.exp.

gdb/testsuite/ChangeLog:

	* boards/cc-with-tweaks.exp: Include local-board.exp instead of
	setting isremote by hand.
	* boards/dwarf4-gdb-index.exp: Likewise.
	* boards/fission.exp: Likewise.
	* boards/stabs.exp: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix gdb.linespec/cpls-ops.exp on 32-bit
@ 2017-11-30 16:51 sergiodj+buildbot
  2017-12-01  4:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-30 16:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e3919f3e898aa5ab9a98dcaf9e242a9ebacc0757 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: e3919f3e898aa5ab9a98dcaf9e242a9ebacc0757

Fix gdb.linespec/cpls-ops.exp on 32-bit

gdb.linespec/cpls-ops.exp is currently failing on x86-64 -m32 and other
32-bit ports:

 b test_op_new::operator new(unsigned int) FAIL: gdb.linespec/cpls-ops.exp: operator-new: tab complete "b test_op_new::operator" (timeout)
 ^CQuit
 (gdb) complete b test_op_new::operator
 b test_op_new::operator new(unsigned int)
 (gdb) FAIL: gdb.linespec/cpls-ops.exp: operator-new: cmd complete "b test_op_new::operator"

The problem is simply that the testcase incorrectly assumes that
size_t is "unsigned long".

Fix this by extracting the right type with the "ptype" command.

gdb/testsuite/ChangeLog:
2017-11-30  Pedro Alves  <palves@redhat.com>

	* gdb.linespec/cpls-ops.exp
	(check_explicit_skips_function_argument): Extract the underlying
	type of size_t instead of hardcoding it.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix sol-thread.c compilation on Solaris
@ 2017-11-30 10:44 sergiodj+buildbot
  2017-11-30 19:56 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-30 10:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e8020e54f4b9ac05150c4b02fa81e228d6cf1f6a ***

Author: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Branch: master
Commit: e8020e54f4b9ac05150c4b02fa81e228d6cf1f6a

Fix sol-thread.c compilation on Solaris

Building current gdb mainline with gcc 7.1 on Solaris 11.4 fails:

/vol/src/gnu/gdb/gdb/dist/gdb/sol-thread.c: In function `void _initialize_sol_thread()':
/vol/src/gnu/gdb/gdb/dist/gdb/sol-thread.c:1229:66: error: invalid conversion from `void (*)(char*, int)' to `void (*)(const char*, int)' [-fpermissive]
     _("Show info on Solaris user threads."), &maintenanceinfolist);
                                                                  ^
In file included from /vol/src/gnu/gdb/gdb/dist/gdb/completer.h:21:0,
                 from /vol/src/gnu/gdb/gdb/dist/gdb/symtab.h:31,
                 from /vol/src/gnu/gdb/gdb/dist/gdb/language.h:26,
                 from /vol/src/gnu/gdb/gdb/dist/gdb/frame.h:72,
                 from /vol/src/gnu/gdb/gdb/dist/gdb/gdbarch.h:39,
                 from /vol/src/gnu/gdb/gdb/dist/gdb/defs.h:557,
                 from /vol/src/gnu/gdb/gdb/dist/gdb/sol-thread.c:51:
/vol/src/gnu/gdb/gdb/dist/gdb/command.h:140:33: note:   initializing argument 3 of `cmd_list_element* add_cmd(const char*, command_class, void (*)(const char*, int), const char*, cmd_list_element**)'
 extern struct cmd_list_element *add_cmd (const char *, enum command_class,
                                 ^~~~~~~

The following patch allows compilation to succeed on i386-pc-solaris2.11
and sparc-sun-solaris2.11.

	* sol-thread.c (info_solthreads): Constify args.
	Cast args to void *.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Define MPFR_USE_INTMAX_T so that mpfr.h assumes intmax_t is available.
@ 2017-11-30  1:14 sergiodj+buildbot
  2017-11-30 18:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-30  1:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7505954411a168f5c5b9adec23eac55b1532fbe6 ***

Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: 7505954411a168f5c5b9adec23eac55b1532fbe6

Define MPFR_USE_INTMAX_T so that mpfr.h assumes intmax_t is available.

mpfr.h uses a non-portable test to guess if intmax_t is available and
if API functions using intmax_t should be exposed.  Define
MPFR_USE_INTMAX_T to override the non-portable test and always expose
these functions.  This fixes the build on platforms where the test
guesses incorrectly.

gdb/ChangeLog:

	* target-float.c [HAVE_LIBMPFR]: Define MPFR_USE_INTMAX_T.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Breakpoints in symbols with ABI tags (PR c++/19436)
@ 2017-11-29 22:06 sergiodj+buildbot
  2017-11-30 14:03 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-29 22:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bd69330db86b2367aac8aac5915f1686451c9d5d ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: bd69330db86b2367aac8aac5915f1686451c9d5d

Breakpoints in symbols with ABI tags (PR c++/19436)

Trying to set a breakpoint in a function with an ABI tag does not work
currently.  E.g., debugging gdb itself, we see this with the
"string_printf" function:

 (top-gdb) b string_print                               [TAB]
 (top-gdb) b string_printf[abi:cxx11](char const*, ...) [RET]
 No source file named string_printf[abi.
 Make breakpoint pending on future shared library load? (y or [n])

Quoting doesn't help:
 (top-gdb) b 'string_printf[abi:cxx11]'(char const*, ...)
 malformed linespec error: unexpected string, "(char const*, ...)"
 (top-gdb) b 'string_printf[abi:cxx11](char const*, ...)'
 No source file named string_printf[abi.
 Make breakpoint pending on future shared library load? (y or [n]) n

This patch fixes this, and takes it a bit further.

The actual symbol name as demangled by libiberty's demangler is really

 string_printf[abi:cxx11](char const*, ...)

however, this patch makes it possible to set the breakpoint with

 string_printf(char const*, ...)

too.  I.e., ignoring the ABI tag.

And to match, it teaches the completer to complete the symbol name
without the ABI tag, i.e.,

  "string_pri<TAB>"  -> "string_printf(char const*, ...)"

If however, you really want to break on a symbol with the tag, then
you simply start writing the tag, and GDB will preserve it, like:

  "string_printf[a<TAB>"  -> "string_printf[abi:cxx11](char const*, ...)"

Grows the gdb.linespec/ tests like this:

  -# of expected passes           8977
  +# of expected passes           9176

gdb/ChangeLog:
2017-11-29  Pedro Alves  <palves@redhat.com>

	PR c++/19436
	* NEWS: Mention setting breakpoints on functions with C++ ABI
	tags.
	* completer.h (completion_match_for_lcd) <match,
	mark_ignored_range>: New methods.
	<finish>: Consider ignored ranges.
	<clear>: Clear ignored ranges.
	<m_ignored_ranges, m_finished_storage>: New fields.
	* cp-support.c (cp_search_name_hash): Ignore ABI tags.
	(cp_symbol_name_matches_1, cp_fq_symbol_name_matches): Pass the
	completion_match_for_lcd pointer to strncmp_iw_with_mode.
	(test_cp_symbol_name_cmp): Add [abi:...] tags unit tests.
	* language.c (default_symbol_name_matcher): Pass the
	completion_match_for_lcd pointer to strncmp_iw_with_mode.
	* linespec.c (linespec_lexer_lex_string): Don't tokenize ABI tags.
	* utils.c (skip_abi_tag): New function.
	(strncmp_iw_with_mode): Add completion_match_for_lcd parameter.
	Handle ABI tags.
	* utils.h (strncmp_iw_with_mode): Add completion_match_for_lcd
	parameter.

gdb/testsuite/ChangeLog:
2017-11-29  Pedro Alves  <palves@redhat.com>

	PR c++/19436
	* gdb.linespec/cpls-abi-tag.cc: New file.
	* gdb.linespec/cpls-abi-tag.exp: New file.

gdb/doc/ChangeLog:
2017-11-29  Pedro Alves  <palves@redhat.com>

	PR c++/19436
	* gdb.texinfo (Debugging C Plus Plus): Document setting
	breakpoints in functions with ABI tags.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make "break foo" find "A::foo", A::B::foo", etc. [C++ and wild matching]
@ 2017-11-29 21:46 sergiodj+buildbot
  2017-11-30 12:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-29 21:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a20714ff39f621961151d0c204e89062ab2107eb ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: a20714ff39f621961151d0c204e89062ab2107eb

Make "break foo" find "A::foo", A::B::foo", etc. [C++ and wild matching]

This patch teaches GDB about setting breakpoints in all scopes
(namespaces and classes) by default.

Here's a contrived example:

  (gdb) b func<tab>
  (anonymous namespace)::A::function()            Bn::(anonymous namespace)::B::function()        function(int, int)
  (anonymous namespace)::B::function()            Bn::(anonymous namespace)::function()           gdb::(anonymous namespace)::A::function()
  (anonymous namespace)::B::function() const      Bn::(anonymous namespace)::function(int, int)   gdb::(anonymous namespace)::function()
  (anonymous namespace)::function()               Bn::B::func()                                   gdb::(anonymous namespace)::function(int, int)
  (anonymous namespace)::function(int, int)       Bn::B::function()                               gdb::A::func()
  A::func()                                       Bn::func()                                      gdb::A::function()
  A::function()                                   Bn::function()                                  gdb::func()
  B::func()                                       Bn::function(int, int)                          gdb::function()
  B::function()                                   Bn::function(long)                              gdb::function(int, int)
  B::function() const                             func()                                          gdb::function(long)
  B::function_const() const                       function()
  (gdb) b function
  Breakpoint 1 at 0x4005ce: function. (26 locations)

  (gdb) b B::function<tab>
  (anonymous namespace)::B::function()        B::function() const                         Bn::B::function()
  (anonymous namespace)::B::function() const  B::function_const() const
  B::function()                               Bn::(anonymous namespace)::B::function()
  (gdb) b B::function
  Breakpoint 1 at 0x40072c: B::function. (6 locations)

To get back the original behavior of interpreting the function name as
a fully-qualified name, you can use the new "-qualified" (or "-q")
option/flag (added by this commit).  For example:

 (gdb) b B::function
 (anonymous namespace)::B::function()        B::function() const                         Bn::B::function()
 (anonymous namespace)::B::function() const  B::function_const() const
 B::function()                               Bn::(anonymous namespace)::B::function()

vs:

 (gdb) b -qualified B::function
 B::function()              B::function() const        B::function_const() const

I've chosen "-qualified" / "-q" because "-f" (for "full" or
"fully-qualified") is already taken for "-function".

Note: the "-qualified" option works with both linespecs and explicit
locations.  I.e., these are equivalent:

 (gdb) b -q func
 (gdb) b -q -f func

and so are these:

 (gdb) b -q filename.cc:func
 (gdb) b -q -s filename.cc -f func
 (gdb) b -s filename.cc -q -f func
 (gdb) b -s filename.cc -f func -q

To better understand why I consider wild matching the better default,
consider what happens when we get to the point when _all_ of GDB is
wrapped under "namespace gdb {}".  I have a patch series that does
that, and when I started debugging that GDB, I immediately became
frustrated.  You'd have to write "b gdb::internal_error", "b
gdb::foo", "b gdb::bar", etc. etc., which gets annoying pretty
quickly.  OTOH, consider how this makes it very easy to set
breakpoints in classes wrapped in anonymous namespaces.  You just
don't think of them, GDB finds the symbols for you automatically.

(At the Cauldron a couple months ago, several people told me that they
run into a similar issue when debugging other C++ projects.  One
example was when debugging LLVM, which puts all its code under the
"llvm" namespace.)

Implementation-wise, what the patch does is:

  - makes C++ symbol name hashing only consider the last component of
    a symbol name. (so that we can look up symbol names by
    last-component name only).

  - adds a C++ symbol name matcher for symbol_name_match_type::WILD,
    which ignores missing leading specifiers / components.

  - adjusts a few preexisting testsuite tests to use "-qualified" when
    they mean it.

  - adds new testsuite tests.

  - adds unit tests.

Grows the gdb.linespec/ tests like this:

  -# of expected passes           7823
  +# of expected passes           8977

gdb/ChangeLog:
2017-11-29  Pedro Alves  <palves@redhat.com>

	* NEWS: Mention that breakpoints on C++ functions are now set on
	on all namespaces/classes by default, and mention "break
	-qualified".
	* ax-gdb.c (agent_command_1): Adjust to pass a
	symbol_name_match_type to new_linespec_location.
	* breakpoint.c (parse_breakpoint_sals): Adjust to
	get_linespec_location's return type change.
	(strace_marker_create_sals_from_location): Adjust to pass a
	symbol_name_match_type to new_linespec_location.
	(strace_marker_decode_location): Adjust to get_linespec_location's
	return type change.
	(strace_command): Adjust to pass a symbol_name_match_type to
	new_linespec_location.
	(LOCATION_HELP_STRING): Add paragraph about wildmatching, and
	mention "-qualified".
	* c-lang.c (cplus_language_defn): Install cp_search_name_hash.
	* completer.c (explicit_location_match_type::MATCH_QUALIFIED): New
	enumerator.
	(complete_address_and_linespec_locations): New parameter
	'match_type'.  Pass it down.
	(explicit_options): Add "-qualified".
	(collect_explicit_location_matches): Pass the requested match type
	to the linespec completers.  Handle MATCH_QUALIFIED.
	(location_completer): Handle "-qualified" combined with linespecs.
	* cp-support.c (cp_search_name_hash): New.
	(cp_symbol_name_matches_1): Implement wild matching for C++.
	(cp_fq_symbol_name_matches): Reimplement.
	(cp_get_symbol_name_matcher): Return different matchers depending
	on the lookup name's match type.
	(selftests::test_cp_symbol_name_matches): Add wild matching tests.
	* cp-support.h (cp_search_name_hash): New declaration.
	* dwarf2read.c
	(selftests::dw2_expand_symtabs_matching::test_symbols): Add
	symbols.
	(test_dw2_expand_symtabs_matching_symbol): Add wild matching
	tests.
	* guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Adjust to
	pass a symbol_name_match_type to new_linespec_location.
	* linespec.c (linespec_parse_basic): Lookup function symbols using
	the parser's symbol name match type.
	(convert_explicit_location_to_linespec): New
	symbol_name_match_type parameter.  Pass it down to
	find_linespec_symbols.
	(convert_explicit_location_to_sals): Pass the location's name
	match type to convert_explicit_location_to_linespec.
	(parse_linespec): New match_type parameter.  Save it in the
	parser.
	(linespec_parser_new): Default to symbol_name_match_type::WILD.
	(linespec_complete_function): New symbol_name_match_type
	parameter.  Use it.
	(complete_linespec_component): Pass down the parser's recorded
	name match type.
	(linespec_complete_label): New symbol_name_match_type parameter.
	Use it.
	(linespec_complete): New symbol_name_match_type parameter.  Save
	it in the parser and pass it down.  Adjust to
	get_linespec_location's prototype change.
	(find_function_symbols, find_linespec_symbols): New
	symbol_name_match_type parameter.  Pass it down instead of
	assuming symbol_name_match_type::WILD.
	* linespec.h (linespec_complete, linespec_complete_function)
	(linespec_complete_label): New symbol_name_match_type parameter.
	* location.c (event_location::linespec_location): Now a struct
	linespec_location.
	(EL_LINESPEC): Adjust.
	(initialize_explicit_location): Default to
	symbol_name_match_type::WILD.
	(new_linespec_location): New symbol_name_match_type parameter.
	Record it in the location.
	(get_linespec_location): Now returns a struct linespec_location.
	(new_explicit_location): Also copy func_name_match_type.
	(explicit_to_string_internal)
	(string_to_explicit_location): Handle "-qualified".
	(copy_event_location): Adjust to LINESPEC_LOCATION type change.
	Copy symbol_name_match_type fields.
	(event_location_deleter::operator()): Adjust to LINESPEC_LOCATION
	type change.
	(event_location_to_string): Adjust to LINESPEC_LOCATION type
	change.  Handle "-qualfied".
	(string_to_explicit_location): Handle "-qualified".
	(string_to_event_location_basic): New symbol_name_match_type
	parameter.  Pass it down.
	(string_to_event_location): Handle "-qualified".
	* location.h (struct linespec_location): New.
	(explicit_location::func_name_match_type): New field.
	(new_linespec_location): Now returns a const linespec_location *.
	(string_to_event_location_basic): New symbol_name_match_type
	parameter.
	(explicit_completion_info::saw_explicit_location_option): New
	field.
	* mi/mi-cmd-break.c (mi_cmd_break_insert_1): Adjust to pass a
	symbol_name_match_type to new_linespec_location.
	* python/py-breakpoint.c (bppy_init): Likewise.
	* python/python.c (gdbpy_decode_line): Likewise.

gdb/testsuite/ChangeLog:
2017-11-29  Pedro Alves  <palves@redhat.com>

	* gdb.base/langs.exp: Use -qualified.
	* gdb.cp/meth-typedefs.exp: Use -qualified, and add tests without
	it.
	* gdb.cp/namespace.exp: Use -qualified.
	* gdb.linespec/cpcompletion.exp (overload-2, fqn, fqn-2)
	(overload-3, template-overload, template-ret-type, const-overload)
	(const-overload-quoted, anon-ns, ambiguous-prefix): New
	procedures.
	(test_driver): Call them.
	* gdb.cp/save-bp-qualified.cc: New.
	* gdb.cp/save-bp-qualified.exp: New.
	* gdb.linespec/explicit.exp: Test -qualified.
	* lib/completion-support.exp (completion::explicit_opts_list): Add
	"-qualified".
	* lib/gdb.exp (gdb_breakpoint): Handle "qualified".

gdb/doc/ChangeLog:
2017-11-29  Pedro Alves  <palves@redhat.com>

	* gdb.texinfo (Linespec Locations): Document how "function" is
	interpreted in C++ and Ada.  Document "-qualified".
	(Explicit Locations): Document how "-function" is interpreted in
	C++ and Ada.  Document "-qualified".


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [gdb/testsuite] Fix return type of psymtab-parameter
@ 2017-11-29 14:12 sergiodj+buildbot
  2017-11-29 20:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-29 14:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ed6c0bfb2643861636581ac8775144efa1728c7c ***

Author: Thomas Preud'homme <thomas.preudhomme@arm.com>
Branch: master
Commit: ed6c0bfb2643861636581ac8775144efa1728c7c

[gdb/testsuite] Fix return type of psymtab-parameter

As pointed out by Pedro Alves, psymtab-parameter testcase rely on the
return type being long. This patch revert the changes made in
f106e10e5e80265e1c43532bba4cb997a7dfa022 and change psymtab-parameter.cc
to return 0 long instead.

2017-11-29  Thomas Preud'homme  <thomas.preudhomme@arm.com>

gdb/testsuite/
	* gdb.cp/psymtab-parameter.cc (func): Change return type back to long.
	Return 0 as a long.
	* gdb.cp/psymtab-parameter.exp: Change func's return type back to long.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [gdb/testsuite] Fix wrong return type in tests
@ 2017-11-29 11:10 sergiodj+buildbot
  2017-11-29 18:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-29 11:10 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f106e10e5e80265e1c43532bba4cb997a7dfa022 ***

Author: Thomas Preud'homme <thomas.preudhomme@arm.com>
Branch: master
Commit: f106e10e5e80265e1c43532bba4cb997a7dfa022

[gdb/testsuite] Fix wrong return type in tests

The following tests are marked untested with latest GCC due to a warning
being emitted for a mismatch between their return type and what the lack
of return statement:

* gdb.cp/breakpoint.exp
* gdb.cp/psymtab-parameter.exp
* gdb.cp/shadow.exp

This patch fix the return type to match the function definitions.

2017-11-29  Thomas Preud'homme  <thomas.preudhomme@arm.com>

gdb/testsuite/
	* gdb.cp/breakpoint.cc (bar): Set return type to void.
	* gdb.cp/psymtab-parameter.cc (func): Likewise.
	* gdb.cp/psymtab-parameter.exp: Update comment regarding prototype of
	func ().
	* gdb.cp/shadow.cc (B.func): Return 0.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Copying symbol type in ld script assignments
@ 2017-11-28 12:59 sergiodj+buildbot
  2017-11-29  5:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-28 12:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cd5b2babea487b0a71a14b593af98330efd8d73e ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: cd5b2babea487b0a71a14b593af98330efd8d73e

Copying symbol type in ld script assignments

There is a call to update_definedness between code that evaluates an
assignment expression value and code that transfers symbol
attributes.  When script assignment expressions contain DEFINED, that
can mean the wrong symbol type is copied.  This patch tracks symbols
read during expression evaluation, rather than examining the
expression and re-evaluating conditionals.  Not only does this
simplify the code, it also means ld can now copy symbol types in more
complex expressions.

An unfortunate side effect of copying symbol type for more complex
expressions affects mmix, which uses
 PROVIDE (Main = DEFINED (Main) ? Main : (DEFINED (_start) ? _start : _start.));
in a default script.  So now _start or _start. symbol type may be
copied, losing the function type specially set up for Main.  This can
be avoided by making bfd_copy_link_hash_symbol_type do nothing for
mmix.

bfd/
	* elf64-mmix.c (bfd_elf64_bfd_copy_link_hash_symbol_type): Define.
ld/
	* ldexp.h (struct ldexp_control): Add "assign_src".
	* ldexp.c (fold_trinary): Save and restore assign_src around
	condition evaluation.
	(fold_name <NAME>): Set expld.assign_src.
	(try_copy_symbol_type): Delete.
	(exp_fold_tree_1): Set symbol type using expld.assign_src.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove REMOTE_OBS
@ 2017-11-28 11:31 sergiodj+buildbot
  2017-11-29  1:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-28 11:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 18ca73470a0d7eb96a807c97559cbb9fddb4b461 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 18ca73470a0d7eb96a807c97559cbb9fddb4b461

Remove REMOTE_OBS

This removes REMOTE_OBS from the Makefile.  It is no longer needed, as
remote support is always built into gdb.  The relevant sources are now
added to COMMON_SFILES, where they are treated like other ordinary
sources.

ChangeLog
2017-11-27  Tom Tromey  <tom@tromey.com>

	* Makefile.in (REMOTE_OBS): Remove.
	(SFILES): Remove remote sources.
	(COMMON_SFILES): Add remote sources.
	(ALLDEPFILES): Remove dcache.c.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Move target object files to target subdirectory
@ 2017-11-28  6:09 sergiodj+buildbot
  2017-11-28 23:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-28  6:09 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 66599a7dc0369583229c0c51e5e009cfa7cceb73 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 66599a7dc0369583229c0c51e5e009cfa7cceb73

Move target object files to target subdirectory

Move the object files corresponding to target/*.c to the target
subdirectory in the build tree.

ChangeLog
2017-11-27  Tom Tromey  <tom@tromey.com>

	* Makefile.in (SUBDIR_TARGET_SRCS, SUBDIR_TARGET_OBS): New
	variables.
	(SFILES): Use SUBDIR_TARGET_SRCS.
	(COMMON_OBS): Use SUBDIR_TARGET_OBS.  Remove waitstatus.o.
	(CONFIG_SRC_SUBDIR): Add target.
	(%.o): Remove target rule.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Move cli object files to cli subdirectory
@ 2017-11-28  1:23 sergiodj+buildbot
  2017-11-28  4:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-28  1:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f06afa533665d88c651617de528b9640eb4e8611 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: f06afa533665d88c651617de528b9640eb4e8611

Move cli object files to cli subdirectory

Following the "arch" move, this moves the object files corresponding
to the cli/*.c source files to the "cli" build directory.

ChangeLog
2017-11-27  Tom Tromey  <tom@tromey.com>

	* Makefile.in (SUBDIR_CLI_OBS): Redefine.
	(%.o): Remove cli rule.
	(CONFIG_SRC_SUBDIR): Add cli.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] A simpler way to make the "arch" build directory
@ 2017-11-28  0:24 sergiodj+buildbot
  2017-11-28  2:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-28  0:24 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b22c88c2ca013cc25d7a8fcbc748122bb1a349bb ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: b22c88c2ca013cc25d7a8fcbc748122bb1a349bb

A simpler way to make the "arch" build directory

This implements a simpler way to make the "arch" build directory --
namely, now it is done as an order-only dependency in the Makefile,
rather than being created when config.status is run.  This simpler
because it means that the build directories can be changed without
re-running autoconf.

ChangeLog
2017-11-27  Tom Tromey  <tom@tromey.com>

	* configure.ac (CONFIG_SRC_SUBDIR): Don't subst.
	* configure: Rebuild.
	* Makefile.in (CONFIG_SRC_SUBDIR): Redefine.
	(CONFIG_DEP_SUBDIR): New variable.
	(%.o): Add order-only dependency.
	($(CONFIG_DEP_SUBDIR)): New target.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] python: Fix memleak in do_start_initialization
@ 2017-11-27  1:09 sergiodj+buildbot
  2017-11-27  8:54 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-27  1:09 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e8e7d10c39955e7ff99ff42f6f16d6befe2fa12e ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: e8e7d10c39955e7ff99ff42f6f16d6befe2fa12e

python: Fix memleak in do_start_initialization

While playing with valgrind, I noticed that with Python 3, the progname
variable in do_start_initialization is not being freed (concat returns a
malloc'ed string).  This patch uses unique_xmalloc_ptr to manage it.
With Python 2, we pass progname it directly to Py_SetProgramName, so it
should not be freed.  We therefore release it before passing it.

gdb/ChangeLog:

	* python/python.c (do_start_initialization): Change progname
	type to gdb::unique_xmalloc_ptr.  Release the pointer when using
	Python 2.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [spu] Fix single-stepping regression
@ 2017-11-26 16:58 sergiodj+buildbot
  2017-11-26 18:20 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-26 16:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5ffd2cb722440053267d0db52df8bbd278fd6d91 ***

Author: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Branch: master
Commit: 5ffd2cb722440053267d0db52df8bbd278fd6d91

[spu] Fix single-stepping regression

Switching spu_software_single_step to use a regcache instead of a frame:
https://sourceware.org/ml/gdb-patches/2016-11/msg00355.html
cause a serious regression to SPU single-stepping.

There were two separate problems:
- SPU_LSLR_REGNUM is a pseudo register, so we must use the "cooked"
  regcache methods instead of the "raw" ones to access it.
- When accessing a branch target register, we must only use the first
  four bytes of the 16-byte vector register.  This was done automatically
  by the frame routines, but not by the regcache routines.

gdb/ChangeLog:
2017-11-26  Ulrich Weigand  <uweigand@de.ibm.com>

	* spu-tdep.c (spu_software_single_step): Access SPU_LSLR_REGNUM as
	"cooked" register.  Access only first four bytes of branch target
	registers.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix PR gdb/22491: Regression when setting SystemTap probe semaphores
@ 2017-11-25 14:48 sergiodj+buildbot
  2017-11-26  3:50 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-25 14:48 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 685de8c2990a04fba5e2954b7ff089a2c641071f ***

Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: 685de8c2990a04fba5e2954b7ff089a2c641071f

Fix PR gdb/22491: Regression when setting SystemTap probe semaphores

Pedro has kindly pointed out that
gdb.arch/amd64-stap-optional-prefix.exp was failing after my
C++-ification patches touching the probe interface.  The failure is
kind of cryptic:

 77 break -pstap bar
 78 Breakpoint 3 at 0x40048d
 79 (gdb) PASS: gdb.arch/amd64-stap-optional-prefix.exp: bar: break -pstap bar
 80 continue
 81 Continuing.
 82
 83 Program received signal SIGILL, Illegal instruction.
 84 main () at amd64-stap-optional-prefix.S:26
 85 26              STAP_PROBE1(probe, foo, (%rsp))

It took me a while to figure out where this SIGILL is coming from.
Initially I thought it was something related to writing registers to
the inferior when dealing with probe arguments, but I discarded this
since the arguments were not touching any registers.

In the end, this was a mistake that was introduced during the review
process of the patch.  When setting/clearing a SystemTap probe's
semaphore, the code was using 'm_address' (which refers the probe's
address) instead of 'm_sem_addr' (which refers to the semaphore's
address).  This caused GDB to write a bogus value in the wrong memory
position, which in turn caused the SIGILL.

I am pushing this patch to correct the mistake.

On a side note: I told Pedro that the BuildBot hadn't caught the
failure during my try build, and for a moment there was a suspicion
that the BuildBot might be at fault here.  However, I investigate this
and noticed that I only did one try build, with a patch that was
correctly using 'm_sem_addr' where applicable, and therefore no
failure should have happened indeed.  I probably should have requested
another try build after addressing the review's comments, but they
were mostly basic and I didn't think it was needed.  Oh, well.

2017-11-25  Sergio Durigan Junior  <sergiodj@redhat.com>

	PR gdb/22491
	* stap-probe.c (relocate_address): New function.
	(stap_probe::get_relocated_address): Use 'relocate_address'.
	(stap_probe::set_semaphore): Use 'relocate_address' and pass
	'm_sem_addr'.
	(stap_probe::clear_semaphore): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add comprehensive C++ operator linespec/location/completion tests
@ 2017-11-25  8:52 sergiodj+buildbot
  2017-11-25 21:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-25  8:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6a3c6ee41898743234d8fd9f9cab15f2ecdaba49 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 6a3c6ee41898743234d8fd9f9cab15f2ecdaba49

Add comprehensive C++ operator linespec/location/completion tests

This exercises the special handling C++ operators require in several
places in the linespec parser, both the linespec and explicit location
completers, symbol lookup, etc.  Particularly, makes sure all that
works without quoting.

Note that despite the apparent smallish size, this adds thousands of
tests to the testsuite, due to combination explosion (linespecs,
explicit locations, tab completion, complete command, completion at
different points in each function, etc.)

Grows the gdb.linespec/ tests like this:

 -# of expected passes           3464
 +# of expected passes           7823

gdb/testsuite/ChangeLog:
2017-11-25  Pedro Alves  <palves@redhat.com>

	* gdb.linespec/cpls-ops.cc: New file.
	* gdb.linespec/cpls-ops.exp: New file.
	* lib/completion-support.exp (test_complete_prefix_range_re): New,
	factored out from ...
	(test_complete_prefix_range): ... this.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix completing an empty string
@ 2017-11-25  4:19 sergiodj+buildbot
  2017-11-25 23:30 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-25  4:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a81aaca0578ee91ce1cee56c0a31e26c2a5ef581 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: a81aaca0578ee91ce1cee56c0a31e26c2a5ef581

Fix completing an empty string

Earlier while working on the big completer rework series, I managed to
break

 (gdb) [TAB]

locally, and make GDB crash, but only notice a few weeks down the
road, because we have no test for that...

I also noticed that:

 (gdb)     [TAB]

didn't work (didn't show all commands as matches), even though
entering a command with leading whitespace works:

 (gdb)     help

This commit fixes the latter and adds a testcase that covers both
issues.

The gdb.base/completion.exp change is necessary because the new test
has a file name that also starts with "gdb.base/complet", making that
particular test ambiguous.  Adding another letter disambiguates.

gdb/ChangeLog:
2017-11-25   Pedro Alves  <palves@redhat.com>

	* completer.c (complete_line_internal_1): Skip spaces until the
	start of the command.

gdb/testsuite/ChangeLog:
2017-11-25   Pedro Alves  <palves@redhat.com>

	* gdb.base/complete-empty.exp: New file.
	* gdb.base/completion.exp: Adjust.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Revert "elf: Properly compute offsets of note descriptor and next note"
@ 2017-11-25  3:37 sergiodj+buildbot
  2017-11-25 12:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-25  3:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4e25ac038efbe5293885cc75d8a3e08b23da7cc9 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 4e25ac038efbe5293885cc75d8a3e08b23da7cc9

Revert "elf: Properly compute offsets of note descriptor and next note"

This reverts commit 650444eb540f9fd85e821567a3f943b4bc41b8be.

With this patch, running the GDB test case gdb.base/auxv.exp is stuck in
an infinite loop, consuming memory to the point that it renders the
machine unusable. I am reverting it so we can take our time to
investigate while not killing all the developers' machines.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make strcmp_iw NOT ignore whitespace in the middle of tokens
@ 2017-11-25  2:17 sergiodj+buildbot
  2017-11-25 18:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-25  2:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0662b6a7c1b3b04a4ca31a09af703c91c7aa9646 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 0662b6a7c1b3b04a4ca31a09af703c91c7aa9646

Make strcmp_iw NOT ignore whitespace in the middle of tokens

currently "b func tion" manages to set a breakpoint at "function" !

All these years I had never noticed this, but now that the linespec
completer actually works, this easily happens by accident, with:

  "b func t<tab>"

expecting to get "thread", but getting instead:

  "b func tion"

...

Also, this:

  "b rettypefunc<int>"

manages to set a breakpoint on "rettype func<int>()".

These things happen due to strcmp_iw "magic".

Fix it by teaching strcmp_iw about when can it skip whitespace.  This
required handling user-defined operators, and scope operators,
complicating the code a bit, unfortunately.  I added unit tests for
all the corner cases I stumbled on, as I was developing this, and then
in the end wrote a testsuite testcase covering many of the same things
and more (to be added later).

gdb/ChangeLog:
2017-11-24  Pedro Alves  <palves@redhat.com>

	* cp-support.c (cp_symbol_name_matches_1): New, factored out from
	cp_fq_symbol_name_matches.  Pass language_cplus to
	strncmp_with_mode.
	(cp_fq_symbol_name_matches): Call cp_symbol_name_matches_1.
	(selftests::test_cp_symbol_name_cmp): New.
	(_initialize_cp_support): Register "cp_symbol_name_matches"
	selftests.
	* language.c (default_symbol_name_matcher): Pass language_minimal
	to strncmp_iw_with_mode.
	* utils.c: Include "cp-support.h" and <algorithm>.
	(valid_identifier_name_char, cp_skip_operator_token, skip_ws)
	(cp_is_operator): New functions.
	(strncmp_iw_with_mode): Use them.  Add language parameter.  Don't
	skip whitespace in the symbol name when the lookup name doesn't
	have spaces, and vice versa.
	(strncmp_iw, strcmp_iw): Pass language to strncmp_iw_with_mode.
	* utils.h (strncmp_iw_with_mode): Add language parameter.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Workaround build bug with GCC 6.2.1
@ 2017-11-24 23:37 sergiodj+buildbot
  2017-11-25 10:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-24 23:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 30649c145114fe3aac089bf06e9457238d46341b ***

Author: Philipp Rudo <prudo@linux.vnet.ibm.com>
Branch: master
Commit: 30649c145114fe3aac089bf06e9457238d46341b

Workaround build bug with GCC 6.2.1

Building GDB with GCC 6.2.1 gives multiple errors like

gdb/dtrace-probe.c: In member function void dtrace_probe::build_arg_exprs(gdbarch*):
gdb/dtrace-probe.c:627:8: error: types may not be defined in a for-range-declaration [-Werror]
    for (struct dtrace_probe_arg &arg : m_args

Fix it by removing the 'struct' keyword.

A similar Bug was already fixed for GCC 6.3.1
https://sourceware.org/ml/gdb-patches/2017-10/msg00442.html

gdb/ChangeLog:

	* dtrace-probe.c (dtrace_probe::build_arg_exprs)
	(dtrace_probe::is_enabled, dtrace_probe::enable)
	(dtrace_probe::disable): Remove keyword 'struct' at for-range
	variable
	* probe.c (gen_ui_out_table_header_info)
	(print_ui_out_not_applicables):  Remove keyword 'struct' at
	for-range variable


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix aarch64-none-elf build error
@ 2017-11-24 22:43 sergiodj+buildbot
  2017-11-25  8:46 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-24 22:43 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7696f5c95761be03db7ac62683aa027ecea30fa7 ***

Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: 7696f5c95761be03db7ac62683aa027ecea30fa7

Fix aarch64-none-elf build error

gdb/
	* configure.tgt: Add arch/aarch64.o


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Create private_thread_info hierarchy
@ 2017-11-24 20:32 sergiodj+buildbot
  2017-11-25  5:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-24 20:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7aabaf9d4ad52a1df1f551908fbd8cafc5e7597a ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 7aabaf9d4ad52a1df1f551908fbd8cafc5e7597a

Create private_thread_info hierarchy

There are multiple definitions of the private_thread_info structure
compiled in the same GDB build.  Because of the one definition rule, we
need to change this if we want to be able to make them non-POD (e.g. use
std::vector fields).  This patch creates a class hierarchy, with
private_thread_info being an abstract base class, and all the specific
implementations inheriting from it.

In order to poison XNEW/xfree for non-POD types, it is also needed to
get rid of the xfree in thread_info::~thread_info, which operates on an
opaque type.  This is replaced by thread_info::priv now being a
unique_ptr, which calls the destructor of the private_thread_info
subclass when the thread is being destroyed.

Including gdbthread.h from darwin-nat.h gave these errors:

/Users/simark/src/binutils-gdb/gdb/gdbthread.h:609:3: error: must use 'class' tag to refer to type 'thread_info' in this scope
  thread_info *m_thread;
  ^
  class
/usr/include/mach/thread_act.h:240:15: note: class 'thread_info' is hidden by a non-type declaration of 'thread_info' here
kern_return_t thread_info
              ^

It turns out that there is a thread_info function in the Darwin/XNU/mach API:

  http://web.mit.edu/darwin/src/modules/xnu/osfmk/man/thread_info.html

Therefore, I had to add the class keyword at a couple of places in gdbthread.h,
I don't really see a way around it.

gdb/ChangeLog:

	* gdbthread.h (private_thread_info): Define structure type, add
	virtual pure destructor.
	(thread_info) <priv>: Change type to unique_ptr.
	<private_dtor>: Remove.
	* thread.c (add_thread_with_info): Adjust to use of unique_ptr.
	(private_thread_info::~private_thread_info): Provide default
	implementation.
	(thread_info::~thread_info): Don't call private_dtor nor
	manually free priv.
	* aix-thread.c (private_thread_info): Rename to ...
	(aix_thread_info): ... this.
	(get_aix_thread_info): New.
	(sync_threadlists): Adjust.
	(iter_tid): Adjust.
	(aix_thread_resume): Adjust.
	(aix_thread_fetch_registers): Adjust.
	(aix_thread_store_registers): Adjust.
	(aix_thread_extra_thread_info): Adjust.
	* darwin-nat.h (private_thread_info): Rename to ...
	(darwin_thread_info): ... this.
	(get_darwin_thread_info): New.
	* darwin-nat.c (darwin_init_thread_list): Adjust.
	(darwin_check_new_threads): Adjust.
	(thread_info_from_private_thread_info): Adjust.
	* linux-thread-db.c (private_thread_info): Rename to ...
	(thread_db_thread_info): ... this, initialize fields.
	(get_thread_db_thread_info): New.
	<dying>: Change type to bool.
	(update_thread_state): Adjust to type rename.
	(record_thread): Adjust to type rename an use of unique_ptr.
	(thread_db_pid_to_str): Likewise.
	(thread_db_extra_thread_info): Likewise.
	(thread_db_thread_handle_to_thread_info): Likewise.
	(thread_db_get_thread_local_address): Likewise.
	* nto-tdep.h (private_thread_info): Rename to ...
	(nto_thread_info): ... this, initialize fields.
	(get_nto_thread_info): New.
	<name>: Change type to std::string.
	* nto-tdep.c (nto_extra_thread_info): Adjust to type rename and
	use of unique_ptr.
	* nto-procfs.c (update_thread_private_data_name): Adjust to
	std::string change, allocate nto_private_thread_info with new.
	(update_thread_private_data): Adjust to unique_ptr.
	* remote.c (private_thread_info): Rename to ...
	(remote_thread_info): ... this, initialize data members with
	default values.
	<extra, name>: Change type to std::string.
	<thread_handle>: Change type to non-pointer.
	(free_private_thread_info): Remove.
	(get_private_info_thread): Rename to...
	(get_remote_thread_info): ... this, change return type, adjust to
	use of unique_ptr, use remote_thread_info constructor.
	(remote_add_thread): Adjust.
	(get_private_info_ptid): Rename to...
	(get_remote_thread_info): ...this, change return type.
	(remote_thread_name): Use get_remote_thread_info, adjust to
	change to std::string.
	(struct thread_item) <~thread_item>: Remove.
	<thread_handle>: Make non pointer.
	(start_thread): Adjust to thread_item::thread_handle type
	change.
	(remote_update_thread_list): Adjust to type name change, move
	strings from temporary to long-lived object instead of
	duplicating.
	(remote_threads_extra_info): Use get_remote_thread_info.
	(process_initial_stop_replies): Likewise.
	(resume_clear_thread_private_info): Likewise.
	(remote_resume): Adjust to type name change.
	(remote_commit_resume): Use get_remote_thread_info.
	(process_stop_reply): Adjust to type name change.
	(remote_stopped_by_sw_breakpoint): Use get_remote_thread_info.
	(remote_stopped_by_hw_breakpoint): Likewise.
	(remote_stopped_by_watchpoint): Likewise.
	(remote_stopped_data_address): Likewise.
	(remote_core_of_thread): Likewise.
	(remote_thread_handle_to_thread_info): Use
	get_private_info_thread, adjust to thread_handle field type
	change.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] remote: C++ify thread_item and threads_listing_context
@ 2017-11-24 20:00 sergiodj+buildbot
  2017-11-25  4:20 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-24 20:00 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 21fe1c752e254167d953fa8c846280f63a3a5290 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 21fe1c752e254167d953fa8c846280f63a3a5290

remote: C++ify thread_item and threads_listing_context

This patch C++ifies the thread_item and threads_listing_context
structures in remote.c.  thread_item::{extra,name} are changed to
std::string.  As a result, there's a bit of awkwardness in
remote_update_thread_list, where we have to xstrdup those strings when
filling the private_thread_info structure.  This is removed in the
following patch, where private_thread_info is also C++ified and its
corresponding fields made std::string too.  The xstrdup then becomes an
std::move.

Other than that there's nothing really special, it's a usual day-to-day
VEC -> vector and char* -> std::string change.  It allows removing a
cleanup in remote_update_thread_list.

Note that an overload of hex2bin that returns a gdb::byte_vector is
added, with corresponding selftests.

gdb/ChangeLog:

	* remote.c (struct thread_item): Add constructor, disable copy
	construction and copy assignment, define default move
	construction and move assignment.
	<extra, name>: Change type to std::string.
	<core>: Initialize.
	<thread_handle>: Make non-pointer.
	(thread_item_t): Remove typedef.
	(DEF_VEC_O(thread_item_t)): Remove.
	(threads_listing_context) <contains_thread>: New method.
	<remove_thread>: New method.
	<items>: Change type to std::vector.
	(clear_threads_listing_context): Remove.
	(threads_listing_context_remove): Remove.
	(remote_newthread_step): Use thread_item constructor, adjust to
	change to std::vector.
	(start_thread): Use thread_item constructor, adjust to change to
	std::vector.
	(end_thread): Adjust to change to std::vector and std::string.
	(remote_get_threads_with_qthreadinfo): Use thread_item
	constructor, adjust to std::vector.
	(remote_update_thread_list): Adjust to change to std::vector and
	std::string, use threads_listing_context methods.
	(remove_child_of_pending_fork): Adjust.
	(remove_new_fork_children): Adjust.
	* Makefile.in (SUBDIR_UNITTESTS_SRCS): Add rsp-low-selftests.c.
	(SUBDIR_UNITTESTS_OBS): Add rsp-low-selftests.o.
	* unittests/rsp-low-selftests.c: New file.
	* common/rsp-low.h: Include common/byte-vector.h.
	(hex2bin): New overload.
	* common/rsp-low.c (hex2bin): New overload.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Create private_inferior class hierarchy
@ 2017-11-24 19:27 sergiodj+buildbot
  2017-11-25  2:59 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-24 19:27 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 089354bb0613ca1559813f0a79fbe73655113785 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 089354bb0613ca1559813f0a79fbe73655113785

Create private_inferior class hierarchy

There are currently multiple definitions of private_inferior, defined in
remote.c and darwin-nat.h.  The patch that poisons XNEW and friends for
non-POD types trips on that, because private_inferior is freed in
~inferior(), where it is an opaque type.  Since the compiler can't tell
whether the type is POD, it gives an error.  Also, we can't start using
C++ features in these structures (make them non-POD) as long as there
are multiple definitions with the same name.  For these reasons, this
patch makes a class hierarchy, with private_inferior being the abstract
base class, and darwin_inferior & remote_inferior inheriting from it.
Destruction is done through the virtual destructor.

I stumbled on some suspicious code in the darwin implementation though.
darwin_check_new_threads does an XCNEW(darwin_thread_t) when it finds a
new thread, allocating a new structure for it (darwin_thread_t is a
typedef for private_thread_info).  It then VEC_safe_pushes it in a
vector defined as DEF_VEC_O (a vector of objects).  This means that the
structure content gets copied in the vector.  The thread_info object is
created with the XCNEW'ed structure as the private thread info, while
the rest of the code works with the instance in the vector.  We have
therefore two distinct instances of darwin_thread_t/private_thread_info
for each thread.  This is not really a problem in practice, because
thread_info::priv is not used in the darwin code.  I still find it weird
and far from ideal, so I tried to fix it by changing the vector to be a
vector of pointers.  There should now be a single instance of the
structure for each thread.  The deallocation of the
darwin_thread_t/private_thread_info structure is done by the thread_info
destructor.

I am able to build on macOS, but not really test, since the port seems a
bit broken.  I am not able to debug reliably on the machine I have
access to, which runs macOS 10.12.6.

gdb/ChangeLog:

	* inferior.h (private_inferior): Define structure type, add
	virtual pure destructor.
	(inferior) <priv>: Change type to unique_ptr.
	* inferior.c (private_inferior::~private_inferior): Provide
	default implementation.
	(inferior::~inferior): Don't free priv field.
	(exit_inferior_1): Likewise.
	* darwin-nat.h (struct darwin_exception_info): Initialize fields.
	(darwin_exception_info): Remove typedef.
	(DEF_VEC_O (darwin_thread_t)); Remove.
	(private_inferior): Rename to ...
	(darwin_private_inferior): ... this, extend private_inferior.
	(get_darwin_inferior): New.
	<threads>: Change type to std::vector of darwin_thread_t pointers.
	* darwin-nat.c (darwin_check_new_threads): Adjust.
	(find_inferior_task_it): Adjust.
	(darwin_find_thread); Adjust.
	(darwin_suspend_inferior): Adjust.
	(darwin_resume_inferior): Adjust.
	(darwin_find_new_inferior): Adjust.
	(darwin_decode_notify_message): Adjust.
	(darwin_send_reply): Adjust.
	(darwin_resume_inferior_threads): Adjust.
	(darwin_suspend_inferior_threads): Adjust.
	(darwin_decode_message): Adjust.
	(darwin_wait): Adjust.
	(darwin_interrupt): Adjust.
	(darwin_deallocate_threads): Adjust.
	(darwin_mourn_inferior): Adjust, don't free private data.
	(darwin_reply_to_all_pending_messages): Adjust.
	(darwin_stop_inferior): Adjust.
	(darwin_setup_exceptions): Adjust.
	(darwin_kill_inferior): Adjust.
	(darwin_setup_request_notification): Adjust.
	(darwin_attach_pid): Adjust.
	(darwin_init_thread_list): Adjust.
	(darwin_setup_fake_stop_event): Adjust.
	(darwin_attach): Adjust.
	(darwin_detach): Adjust.
	(darwin_xfer_partial): Adjust.
	(set_enable_mach_exceptions): Adjust.
	(darwin_pid_to_exec_file): Adjust.
	(darwin_get_ada_task_ptid): Adjust.
	* darwin-nat-info.c (get_task_from_args): Adjust.
	(info_mach_ports_command): Adjust.
	(info_mach_region_command): Adjust.
	(info_mach_exceptions_command): Adjust.
	* remote.c (private_inferior): Rename to ...
	(remote_private_inferior): ... this, initialize fields.
	(get_remote_inferior); New.
	(remote_commit_resume): Use get_remote_inferior.
	(check_pending_event_prevents_wildcard_vcont_callback): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] elf: Properly compute offsets of note descriptor and next note
@ 2017-11-24 16:34 sergiodj+buildbot
  2017-11-24 22:08 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-24 16:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 650444eb540f9fd85e821567a3f943b4bc41b8be ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 650444eb540f9fd85e821567a3f943b4bc41b8be

elf: Properly compute offsets of note descriptor and next note

According to gABI, in a note entry, the note name field, not note name
size, is padded for the note descriptor.  And the note descriptor field,
not note descriptor size, is padded for the next note entry.  Also notes
are aligned to 4 bytes in 32-bit objects and 8 bytes in 64-bit objects.
Since on Linux, .note.ABI-tag and .note.gnu.build-id notes are always
aligned to 4 bytes, we need to use alignment of note section or note
segment, instead of assuming alignment based on ELF file class.

Tested on i686 and x86-64.

bfd/

	PR binutils/22444
	* elf.c (elf_read_notes): Add an argument for note aligment.
	(elf_parse_notes): Likewise.
	(_bfd_elf_make_section_from_shdr): Pass section aligment to
	elf_parse_notes.
	(bfd_section_from_phdr): Pass segment aligment to elf_read_notes.
	(elf_parse_notes): Add an argument for note aligment.  Use
	ELF_NOTE_DESC_OFFSET to get the offset of the note descriptor.
	Use ELF_NOTE_NEXT_OFFSET to get the offset of the next note
	entry.
	(elf_read_notes): Add an argument for note aligment and pass it
	to elf_parse_notes.

binutils/

	PR binutils/22444
	* readelf.c (process_notes_at): Use ELF_NOTE_DESC_OFFSET to get
	the offset of the note descriptor.  Use ELF_NOTE_NEXT_OFFSET to
	get the offset of the next note entry.

include/

	PR binutils/22444
	* elf/external.h (ELF_ALIGN_UP): New.
	(ELF_NOTE_DESC_OFFSET): Likewise.
	(ELF_NOTE_NEXT_OFFSET): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] regcache::cooked_read unit test
@ 2017-11-24 14:23 sergiodj+buildbot
  2017-11-24 19:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-24 14:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1b30aaa56607a563fa263b9d2ee9eba89d79c1b4 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 1b30aaa56607a563fa263b9d2ee9eba89d79c1b4

regcache::cooked_read unit test

This patch adds a unit test to regcache::cooked_read.  This unit test is a
little different from normal unit test, it is more about conformance test
or interaction test.  This test pass both raw register number and pseudo
register number to regcache::cooked_read, in order to inspect 1) return
value of cooked_read, 2) how are target_ops to_xfer_partial,
to_{fetch,store}_registers called (because regcache is updated by means of
these three target_ops methods).  With this test here, we have a clear
picture about how each port of GDB get cooked registers.

This patch also shares some code on mock target.

gdb:

2017-11-24  Yao Qi  <yao.qi@linaro.org>

	* gdbarch-selftests.c (test_target_has_registers): Move it to
	target.c.
	(test_target_has_stack): Likewise.
	(test_target_has_memory): Likewise.
	(test_target_prepare_to_store): Likewise.
	(test_target_store_registers): Likewise.
	(test_target_ops): Likewise.
	* regcache.c: Include selftest-arch.h and gdbthread.h.
	(target_ops_no_register): New class.
	(test_target_fetch_registers): New.
	(test_target_store_registers): New.
	(test_target_xfer_partial): New.
	(readwrite_regcache): New.
	(cooked_read_test): New.
	(_initialize_regcache): Register the test.
	* target.c: (test_target_has_registers): Moved from
	gdbarch-selftests.c.
	(test_target_has_stack): Likewise.
	(test_target_has_memory): Likewise.
	(test_target_prepare_to_store): Likewise.
	(test_target_store_registers): Likewise.
	* target.h (test_target_ops): New class.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdbserver: add aarch64_create_target_description
@ 2017-11-24 13:16 sergiodj+buildbot
  2017-11-24 15:46 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-24 13:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d6d7ce56231ca8c233e64b2ebcb910fe334d6ff8 ***

Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: d6d7ce56231ca8c233e64b2ebcb910fe334d6ff8

gdbserver: add aarch64_create_target_description

gdbserver/
	* configure.srv: Add new files.
	* linux-aarch64-ipa.c (get_ipa_tdesc): Call
	aarch64_linux_read_description.
	* linux-aarch64-low.c (aarch64_linux_read_description):
	Merge with aarch64_arch_setup.
	(aarch64_arch_setup): Call aarch64_linux_read_description.
	* linux-aarch64-tdesc.c: New file.
	* linux-aarch64-tdesc.h: New file.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Use flexible target descriptors for aarch64
@ 2017-11-24 13:09 sergiodj+buildbot
  2017-11-24 17:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-24 13:09 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 49bdb7ee48a10581e9f7254782f2eb953c4a164b ***

Author: Alan Hayward <alan.hayward@arm.com>
Branch: master
Commit: 49bdb7ee48a10581e9f7254782f2eb953c4a164b

Use flexible target descriptors for aarch64

gdb/
	* aarch64-tdep.c (_initialize_aarch64_tdep): Remove init.
	* arch/aarch64.c (aarch64_create_target_description): Create
	new target description.
	* features/Makefile: Add new files.
	* features/aarch64.c: Remove file.
	* features/aarch64-core.c: New autogenerated file.
	* features/aarch64-fpu.c: New autogenerated file.
	* target-descriptions.c (maint_print_c_tdesc_cmd): Check for aarch64.

gdbserver/
	* linux-aarch64-ipa.c (initialize_low_tracepoint): Remove init.
	* linux-aarch64-low.c (initialize_low_arch): Remove init.
	* linux-aarch64-tdesc.c (aarch64_linux_read_description): Add init.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Change value_contents_eq return bool
@ 2017-11-24 11:34 sergiodj+buildbot
  2017-11-24 13:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-24 11:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 98ead37e9735438986934f9f1f35f020a093fe07 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 98ead37e9735438986934f9f1f35f020a093fe07

Change value_contents_eq return bool

This patch changes value_contents_eq return type from int to bool.

gdb:

2017-11-24  Yao Qi  <yao.qi@linaro.org>

	* mi/mi-main.c (register_changed_p): Update.
	* value.c (value_contents_bits_eq): Change return type.
	(value_contents_eq): Likewise.
	* value.h: Update comments.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Change register_changed_p returns bool
@ 2017-11-24 11:08 sergiodj+buildbot
  2017-11-24 12:05 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-24 11:08 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 62ad7ce71b243df3e8d7d4f8b8560a7316233a9e ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 62ad7ce71b243df3e8d7d4f8b8560a7316233a9e

Change register_changed_p returns bool

register_changed_p actually returns bool, but return type is still int.
This patch changes the return type to bool.  The caller of
register_changed_p also checked whether the return value can be negative,
which is not needed now.  Such check was added in fb40c2090 in 2000,
at that moment, register_changed_p returns -1 when
read_relative_register_raw_bytes fails.  I can tell from its name that
it reads register contents, but we don't have this function called inside
register_changed_p, and the regcache is read-only.

gdb:

2017-11-24  Yao Qi  <yao.qi@linaro.org>

	* mi/mi-main.c (mi_cmd_data_list_changed_registers): Remove
	local 'changed'.  Remove error.
	(register_changed_p): Change return type to bool.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Change tic6x target descriptions
@ 2017-11-24  9:50 sergiodj+buildbot
  2017-11-24 10:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-24  9:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 506fe5f4996738f25b7c26f126a84b231429ba95 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 506fe5f4996738f25b7c26f126a84b231429ba95

Change tic6x target descriptions

This patch changes tic6x target descriptions to be more flexible.  Rebuild
tic6x-uclinux GDBserver with my x86 g++, and the unit test passes.

gdb:

2017-11-24  Yao Qi  <yao.qi@linaro.org>

	* arch/tic6x.c: New file.
	* arch/tic6x.h: New file.
	* features/Makefile (FEATURE_XMLFILES): Add tic6x-c6xp.xml,
	tic6x-core.xml and tic6x-gp.xml.
	* features/tic6x-c6xp.c: Generated.
	* features/tic6x-core.c: Generated.
	* features/tic6x-gp.c: Generated.
	* target-descriptions.c (maint_print_c_tdesc_cmd): Match
	"tic6x-".

gdb/gdbserver:

2017-11-24  Yao Qi  <yao.qi@linaro.org>

	* configure.srv: Set $srv_regobj for tic6x-linux.
	* linux-tic6x-low.c: Include "arch/tic6x.h" and "tdesc.h".
	(tic6x_read_description): Move some code to tic6x_arch_setup.
	(tic6x_tdesc_test): New function.
	(initialize_low_arch): Call selftests::register_test.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: don't omit disambiguating suffixes from "fi*"
@ 2017-11-24  8:04 sergiodj+buildbot
  2017-11-24  9:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-24  8:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ac465521a50102d589a6a05a1e722dfa349d3181 ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: ac465521a50102d589a6a05a1e722dfa349d3181

x86: don't omit disambiguating suffixes from "fi*"

"fi*" typically come in two (loads/stores: three) flavors, distinguished
by the suffix. Don't omit the 's' one when disassembling.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [testsuite] Pass -g3 to clang in gdb.base/macscp.exp
@ 2017-11-23 16:25 sergiodj+buildbot
  2017-11-23 23:15 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-23 16:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7c3c1aa885b720e25b25af6ac05f34f9ff0e3dfa ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 7c3c1aa885b720e25b25af6ac05f34f9ff0e3dfa

[testsuite] Pass -g3 to clang in gdb.base/macscp.exp

clang accepts option -g3 too.  I checked the manual of xlc and icc, looks
they don't accept -g3 option, so I don't pass -g3 for them.

gdb/testsuite:

2017-11-23  Yao Qi  <yao.qi@linaro.org>

	* gdb.base/macscp.exp: Append -g3 to additional_flags for clang.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Delete powerpc64 symbol weakref field
@ 2017-11-23 14:16 sergiodj+buildbot
  2017-11-23 18:49 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-23 14:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ab2477e15cbe067ff119f1bb5dea05de3cadbdd5 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: ab2477e15cbe067ff119f1bb5dea05de3cadbdd5

Delete powerpc64 symbol weakref field

Now that u.alias is circular, weakref just duplicates its function.
Also, function symbols shouldn't be on the alias list so there is no
need to use alias_readonly_dynrelocs with them.

	* elf64-ppc.c (struct ppc_link_hash_entry): Delete weakref field.
	(ppc64_elf_copy_indirect_symbol): Don't set weakref.
	(alias_readonly_dynrelocs): Use u.alias rather than weakref.
	(ppc64_elf_adjust_dynamic_symbol): Don't use
	alias_readonly_dynrelocs for function symbols.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Rename u.weakdef and make it a circular list
@ 2017-11-23 13:28 sergiodj+buildbot
  2017-11-23 17:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-23 13:28 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 60d67dc84bbc7d73672d297d714f8a4a0547618d ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 60d67dc84bbc7d73672d297d714f8a4a0547618d

Rename u.weakdef and make it a circular list

This makes the elf_link_hash_entry weakdef field, currently used to
point from a weak symbol to a strong alias, a circular list so that
all aliases can be found from any of them.  A new flag, is_weakalias,
distinguishes the weak symbol from a strong alias, and is used in all
places where we currently test u.weakdef != NULL.

With the original u.weakdef handling it was possible to have two or
more weak symbols pointing via u.weakdef to a strong definition.
Obviously that situation can't map to a circular list; One or more of
the weak symbols must point at another weak alias rather than the
strong definition.  To handle that, I've added an accessor function to
return the strong definition.

	* elf-bfd.h (struct elf_link_hash_entry): Add is_weakalias.
	Rename u.weakdef to u.alias and update comment.
	(weakdef): New static inline function.
	* elflink.c (bfd_elf_record_link_assignment) Test is_weakalias
	rather than u.weakdef != NULL, and use weakdef function.
	(_bfd_elf_adjust_dynamic_symbol): Likewise.
	(_bfd_elf_fix_symbol_flags): Likewise.  Clear is_weakalias on
	all aliases if def has been overridden in a regular object, not
	u.weakdef.
	(elf_link_add_object_symbols): Delete new_weakdef flag.  Test
	is_weakalias and use weakdef.  Set is_weakalias and circular
	u.alias.  Update comments.
	(_bfd_elf_gc_mark_rsec): Test is_weakalias rather than
	u.weakdef != NULL and use weakdef function.
	* elf-m10300.c (_bfd_mn10300_elf_adjust_dynamic_symbol): Test
	is_weakalias rather than u.weakdef != NULL and use weakdef
	function.  Assert that def is strong defined.
	* elf32-arc.c (elf_arc_adjust_dynamic_symbol): Likewise.
	* elf32-arm.c (elf32_arm_adjust_dynamic_symbol): Likewise.
	* elf32-bfin.c (elf32_bfinfdpic_adjust_dynamic_symbol): Likewise.
	(bfin_adjust_dynamic_symbol): Likewise.
	* elf32-cr16.c (_bfd_cr16_elf_adjust_dynamic_symbol): Likewise.
	* elf32-cris.c (elf_cris_adjust_dynamic_symbol): Likewise.
	* elf32-frv.c (elf32_frvfdpic_adjust_dynamic_symbol): Likewise.
	* elf32-hppa.c (elf32_hppa_adjust_dynamic_symbol): Likewise.
	* elf32-i370.c (i370_elf_adjust_dynamic_symbol): Likewise.
	* elf32-lm32.c (lm32_elf_adjust_dynamic_symbol): Likewise.
	* elf32-m32r.c (m32r_elf_adjust_dynamic_symbol): Likewise.
	* elf32-m68k.c (elf_m68k_adjust_dynamic_symbol): Likewise.
	* elf32-metag.c (elf_metag_adjust_dynamic_symbol): Likewise.
	* elf32-microblaze.c (microblaze_elf_adjust_dynamic_symbol): Likewise.
	* elf32-nds32.c (nds32_elf_adjust_dynamic_symbol): Likewise.
	* elf32-nios2.c (nios2_elf32_adjust_dynamic_symbol): Likewise.
	* elf32-or1k.c (or1k_elf_adjust_dynamic_symbol): Likewise.
	* elf32-ppc.c (ppc_elf_adjust_dynamic_symbol): Likewise.
	* elf32-s390.c (elf_s390_adjust_dynamic_symbol): Likewise.
	* elf32-score.c (s3_bfd_score_elf_adjust_dynamic_symbol): Likewise.
	* elf32-score7.c (s7_bfd_score_elf_adjust_dynamic_symbol): Likewise.
	* elf32-sh.c (sh_elf_adjust_dynamic_symbol): Likewise.
	* elf32-tic6x.c (elf32_tic6x_adjust_dynamic_symbol): Likewise.
	* elf32-tilepro.c (tilepro_elf_gc_mark_hook): Likewise.
	(tilepro_elf_adjust_dynamic_symbol): Likewise.
	* elf32-vax.c (elf_vax_adjust_dynamic_symbol): Likewise.
	* elf32-xtensa.c (elf_xtensa_adjust_dynamic_symbol): Likewise.
	* elf64-alpha.c (elf64_alpha_adjust_dynamic_symbol): Likewise.
	* elf64-hppa.c (elf64_hppa_adjust_dynamic_symbol): Likewise.
	* elf64-ia64-vms.c (elf64_ia64_adjust_dynamic_symbol): Likewise.
	* elf64-ppc.c (ppc64_elf_gc_mark_hook): Likewise.
	(ppc64_elf_adjust_dynamic_symbol): Likewise.
	* elf64-s390.c (elf_s390_adjust_dynamic_symbol): Likewise.
	* elf64-sh64.c (sh64_elf64_adjust_dynamic_symbol): Likewise.
	* elfnn-aarch64.c (elfNN_aarch64_adjust_dynamic_symbol): Likewise.
	* elfnn-ia64.c (elfNN_ia64_adjust_dynamic_symbol): Likewise.
	* elfnn-riscv.c (riscv_elf_adjust_dynamic_symbol): Likewise.
	* elfxx-mips.c (_bfd_mips_elf_adjust_dynamic_symbol): Likewise.
	* elfxx-sparc.c (_bfd_sparc_elf_gc_mark_hook): Likewise.
	(_bfd_sparc_elf_adjust_dynamic_symbol): Likewise.
	* elfxx-tilegx.c (tilegx_elf_gc_mark_hook): Likewise.
	(tilegx_elf_adjust_dynamic_symbol): Likewise.
	* elfxx-x86.c (_bfd_x86_elf_adjust_dynamic_symbol): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: correct UDn
@ 2017-11-23 10:23 sergiodj+buildbot
  2017-11-23 15:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-23 10:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 66f1eba0b7e83f293573ab42bbbe5d7d5c905d91 ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 66f1eba0b7e83f293573ab42bbbe5d7d5c905d91

x86: correct UDn

Make the assembler recognize UD0, supporting only the newer form
expecting a ModR/M byte.

Make assembler and disassembler properly emit / expect a ModR/M byte for
UD1.

For the testsuite, as arch-4 already tests all UDn, avoid producing a
huge delta for other tests using UD2B by making them use UD2 instead.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Convert DTrace probe interface to C++ (and perform some cleanups)
@ 2017-11-23  0:50 sergiodj+buildbot
  2017-11-23 13:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-23  0:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9c23b42ffa67b866cd7562c1d8caed70db5d6840 ***

Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: 9c23b42ffa67b866cd7562c1d8caed70db5d6840

Convert DTrace probe interface to C++ (and perform some cleanups)

This patch converts the DTrace probe
interface (gdb/dtrace-probe.[ch]) to C++, and also performs some
cleanups that were on my TODO list for a while.

The main changes were the conversion of 'struct dtrace_probe' to 'class
dtrace_probe', and a new 'class dtrace_static_probe_ops' to replace the
use of 'dtrace_probe_ops'.  Both classes implement the virtual methods
exported by their parents, 'class probe' and 'class static_probe_ops',
respectively.  I believe it's now a bit simpler to understand the
logic behind the dtrace-probe interface.

There are several helper functions used to parse parts of a dtrace
probe, and since they are generic and don't need to know about the
probe they're working on, I decided to leave them as simple static
functions (instead of e.g. converting them to class methods).

I've also converted a few uses of "VEC" to "std::vector", which makes
the code simpler and easier to maintain.  And, as usual, some cleanups
here and there.

Even though I'm sending a series of patches, they need to be tested
and committed as a single unit, because of inter-dependencies.  But it
should be easier to review in separate logical units.

I wasn't able to test these modifications because the current test
framework for DTrace probes is not working.  See
<https://sourceware.org/bugzilla/show_bug.cgi?id=22420>.

gdb/ChangeLog:
2017-11-22  Sergio Durigan Junior  <sergiodj@redhat.com>

	* dtrace-probe.c (struct probe_ops dtrace_probe_ops): Delete.
	(struct dtrace_probe_arg) <dtrace_probe_arg>: New constructor.
	<type_str>: Convert to 'std::string'.
	<expr>: Convert to 'expression_up'.
	(dtrace_probe_arg_s): Delete type and VEC.
	(dtrace_probe_enabler_s): Likewise.
	(struct dtrace_probe): Replace by...
	(class dtrace_static_probe_ops): ...this and...
	(class dtrace_probe): ...this.
	(dtrace_probe_is_linespec): Rename to...
	(dtrace_static_probe_ops::is_linespec): ...this.  Adjust code
	to reflect change.
	(dtrace_process_dof_probe): Use 'std::vector' instead of VEC.
	Adjust code.  Create new instance of 'dtrace_probe'.
	(dtrace_build_arg_exprs): Rename to...
	(dtrace_probe::build_arg_exprs): ...this.  Adjust code to
	reflect change.
	(dtrace_get_probes): Rename to...
	(dtrace_static_probe_ops::get_probes): ...this.  Adjust code
	to reflect change.
	(dtrace_get_arg): Rename to...
	(dtrace_probe::get_arg_by_number): ...this.  Adjust code to
	reflect change.
	(dtrace_probe_is_enabled): Rename to...
	(dtrace_probe::is_enabled): ...this.  Adjust code to reflect
	change.
	(dtrace_get_probe_address): Rename to...
	(dtrace_probe::get_relocated_address): ...this.  Adjust code
	to reflect change.
	(dtrace_get_probe_argument_count): Rename to...
	(dtrace_probe::get_argument_count): ...this.  Adjust code to
	reflect change.
	(dtrace_can_evaluate_probe_arguments): Rename to...
	(dtrace_probe::can_evaluate_arguments): ...this.  Adjust code
	to reflect change.
	(dtrace_evaluate_probe_argument): Rename to...
	(dtrace_probe::evaluate_argument): ...this.  Adjust code to
	reflect change.
	(dtrace_compile_to_ax): Rename to...
	(dtrace_probe::compile_to_ax): ...this.  Adjust code to
	reflect change.
	(dtrace_probe_destroy): Delete.
	(dtrace_type_name): Rename to...
	(dtrace_static_probe_ops::type_name): ...this.  Adjust code to
	reflect change.
	(dtrace_probe::get_static_ops): New method.
	(dtrace_gen_info_probes_table_header): Rename to...
	(dtrace_static_probe_ops::gen_info_probes_table_header):
	...this.  Adjust code to reflect change.
	(dtrace_gen_info_probes_table_values): Rename to...
	(dtrace_probe::gen_info_probes_table_values): ...this.  Adjust
	code to reflect change.
	(dtrace_enable_probe): Rename to...
	(dtrace_probe::enable_probe): ...this.  Adjust code to reflect
	change.
	(dtrace_disable_probe): Rename to...
	(dtrace_probe::disable_probe): ...this.  Adjust code to reflect
	change.
	(struct probe_ops dtrace_probe_ops): Delete.
	(info_probes_dtrace_command): Call 'info_probes_for_spops'
	instead of 'info_probes_for_ops'.
	(_initialize_dtrace_probe): Use 'all_static_probe_ops' instead
	of 'all_probe_ops'.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] (Ada) ravenscar-thread.c: remove unwanted trailing \n in call to warning
@ 2017-11-22 23:51 sergiodj+buildbot
  2017-11-23 12:05 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-22 23:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8f6cb6c33815f38b41e1e93e59f12869db07c070 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 8f6cb6c33815f38b41e1e93e59f12869db07c070

(Ada) ravenscar-thread.c: remove unwanted trailing \n in call to warning

A recent patch introduced a call to warning, and the string used
had a trailing newline, which is not correct; the nightly ARI run
caught it, so this patch removes it.

gdb/ChangeLog:

        * ravenscar-thread.c (ravenscar_inferior_created): Remove
        trailing newline at end of string in call to warning.

Tested on powerpc-eabispe, no regression.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] C++ify osdata
@ 2017-11-22 23:03 sergiodj+buildbot
  2017-11-23 10:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-22 23:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 479f8de1b3b7e69ca8d557bbe9d843c7d1bc89c5 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 479f8de1b3b7e69ca8d557bbe9d843c7d1bc89c5

C++ify osdata

This patch c++ifies the osdata structure: osdata_column, osdata_item and
osdata.  char* are replaced with std::string and VEC are replaced with
std::vector.  This allows to get rid of a great deal of cleanup and
free'ing code.

I replaced the splay tree in list_available_thread_groups with an
std::map.  Unless there's a good advantage to keep using a splay tree,
I think using the standard type should make things simpler to
understand.

gdb/ChangeLog:

	* osdata.h: Include vector isntead of vec.h.
	(osdata_column_s): Remove typedef.
	(struct osdata_column): Add constructor.
	<name, value>: Change type to std::string.
	(DEF_VEC_O (osdata_column_s)): Remove.
	(osdata_item_s): Remove typedef.
	(struct osdata_item) <columns>: Change type to std::vector.
	(DEF_VEC_O (osdata_item_s)): Remove.
	(struct osdata): Add constructor.
	<type>: Change type to std::string.
	<items>: Change type to std::vector.
	(osdata_p): Remove typedef.
	(DEF_VEC_P (osdata_p)): Remove.
	(osdata_parse): Return a unique_ptr.
	(osdata_free): Remove.
	(make_cleanup_osdata_free): Remove.
	(get_osdata): Return a unique_ptr.
	(get_osdata_column): Return pointer to std::string, take a
	reference to osdata_item as parameter.
	* osdata.c (struct osdata_parsing_data) <osdata>: Change type to
	unique_ptr.
	<property_name>: Change type to std::string.
	(osdata_start_osdata): Allocate osdata with new and adjust.
	(osdata_start_item): Adjust.
	(osdata_start_column): Adjust.
	(osdata_end_column): Adjust.
	(clear_parsing_data): Remove.
	(osdata_parse): Return a unique_ptr and adjust, remove cleanup.
	(osdata_item_clear): Remove.
	(get_osdata): return a unique_ptr and adjust.
	(get_osdata_column): Return a pointer to std::string and adjust.
	(info_osdata): Adjust.
	* mi/mi-main.c: Include <map>.
	(free_vector_of_osdata_items): Remove.
	(list_available_thread_groups): Adjust, use std::map instead of
	splay tree.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Show optimized out local variables in "info locals"
@ 2017-11-22 22:42 sergiodj+buildbot
  2017-11-23  8:33 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-22 22:42 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 41bd68f52c05f5654bed49f312f6562c8d048897 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 41bd68f52c05f5654bed49f312f6562c8d048897

Show optimized out local variables in "info locals"

Currently, optimized out variables are not shown when doing "info
locals".  Some users found that confusing, thinking GDB forgot to print
their variable.  This patch adds them to the "info locals" output.  I
added a test in gdb.dwarf2 to test for that behavior.  I think doing a
synthetic DWARF test is the easiest way to have an optimized out local
variable for sure.

However, this change reveals what I think is a bug in GDB, see:

http://lists.dwarfstd.org/pipermail/dwarf-discuss-dwarfstd.org/2017-September/004394.html

This patch marks the tests in inline-locals.exp that start failing as
KFAIL.  I'd like to tackle this bug eventually, but I don't have the
time right now.  I think it's still better to show an extra erroneous
entry than to not show the optimized out variables at all.  I haven't
created a bug in bugzilla yet, but if we agree it's indeed a bug,  I'll
create one and update the setup_kfail lines with the actual bug number
before pushing.

gdb/ChangeLog:

	* stack.c (iterate_over_block_locals): Add LOC_OPTIMIZED_OUT
	case in switch.

gdb/testsuite/ChangeLog:

	* gdb.opt/inline-locals.exp: Mark tests as KFAIL.
	* gdb.dwarf2/info-locals-optimized-out.exp: New file.
	* gdb.dwarf2/info-locals-optimized-out.c: New file.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove DEF_VEC_P (varobj_p)
@ 2017-11-22 22:06 sergiodj+buildbot
  2017-11-23  6:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-22 22:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7e2fd2f47b37185505f68e45c5cf016c7a16e1ce ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 7e2fd2f47b37185505f68e45c5cf016c7a16e1ce

Remove DEF_VEC_P (varobj_p)

The last patch removed the last usage of this type, so we can remove it.

gdb/ChangeLog:

	* varobj.h (DEF_VEC_P (varobj_p)): Remove.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Replace VEC (varobj_update_result) with std::vector
@ 2017-11-22 21:44 sergiodj+buildbot
  2017-11-23  5:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-22 21:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0604393c22f626f26b5a4a30e57da40404f5aa5e ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 0604393c22f626f26b5a4a30e57da40404f5aa5e

Replace VEC (varobj_update_result) with std::vector

This patch replaces makes varobj_update return an std::vector, and
updates the fallouts.

To make that easier, the varobj_update_result is c++ified a bit.  I
added a constructor and initialized its fields in-class.  The newobj
vector is also made an std::vector, so that it's automatically freed
when varobj_update_result is destroyed and handled correctly by the
default move constructor.  I disabled copy constructor and assignment
for that structure, because normally it never needs to be copied, only
moved.

As a result, the newobj parameter of update_dynamic_varobj_children must
be changed to an std::vector.  The patch converts the other vector
parameters of update_dynamic_varobj_children to std::vector.  It's not
strictly necessary to do it in the same patch, but I think it makes
sense to do it.

gdb/ChangeLog:

	* varobj.h (struct varobj_update_result): Add constructor, add
	move constructor, disable copy and assign, initialize fields.
	<newobj>: Change type to std::vector.
	(varobj_update): Return std::vector.
	* varobj.c (install_dynamic_child): Change VEC parameters to
	std::vector and adjust.
	(update_dynamic_varobj_children): Likewise.
	(varobj_update): Return std::vector and adjust.
	* mi/mi-cmd-var.c (varobj_update_one): Adjust to vector changes.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Basic c++ification of varobj
@ 2017-11-22 21:06 sergiodj+buildbot
  2017-11-23  2:10 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-22 21:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9e5b9d2b295d1771647a9e4bc942e398142ccf9b ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 9e5b9d2b295d1771647a9e4bc942e398142ccf9b

Basic c++ification of varobj

This patch does a basic c++ification or the varobj data structure.

  - varobj: add constructor and destructor, initialize fields
  - varobj_root: initialize fields
  - varobj_dynamic: initialize fields

This allows getting rid of new_variable, new_root_variable.
free_variable essentially becomes varobj's destructor.  This also allows
getting rid of a cleanup, make_cleanup_free_variable, which was only
used in varobj_create in case the varobj creation fails.  It is replaced
with a unique_ptr.

gdb/ChangeLog:

	* varobj.h (struct varobj): Add constructor and destructor,
	initialize fields.
	* varobj.c (struct varobj_root): Initialize fields.
	(struct varobj_dynamic): Initialize fields.
	(varobj_create): Use unique_ptr instead of cleanup.  Create
	varobj with new instead of new_root_variable.
	(delete_variable_1): Free variable with delete instead of
	free_variable.
	(create_child_with_value): Create variable with new instead of
	new_variable.
	(varobj::varobj): New.
	(varobj::~varobj): New (body mostly coming from free_variable).
	(new_variable): Remove.
	(free_variable): Remove.
	(do_free_variable_cleanup): Remove.
	(make_cleanup_free_variable): Remove.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make varobj::children an std::vector
@ 2017-11-22 20:57 sergiodj+buildbot
  2017-11-23  4:13 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-22 20:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ddf0ea085b626ddcbb14f88f495bcb677b7ab6e9 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: ddf0ea085b626ddcbb14f88f495bcb677b7ab6e9

Make varobj::children an std::vector

This patch makes the children field of varobj an std::vector, and
updates the fallout.

One note is that varobj::parent must be made non-const.  The reason is
that when a child deletes itself, it modifies its writes NULL to its
slot in its parent's children vector.  With the VEC, the const didn't
made the parent's children vector content const, only the pointer to it,
but with std::vector, even the content is.

gdb/ChangeLog:

	* varobj.h (struct varobj) <parent>: Remove const.
	<children>: Change type to std::vector.
	(varobj_list_children): Return std::vector const reference.
	(varobj_restrict_range): Change parameter type to std::vector
	const reference.
	* varobj.c (varobj_has_more): Adjust.
	(varobj_restrict_range): Change parameter type to std::vector
	const reference and adjust.
	(install_dynamic_child): Adjust.
	(update_dynamic_varobj_children): Adjust.
	(varobj_list_children): Return std::vector const reference and
	adjust.
	(varobj_add_child): Adjust.
	(update_type_if_necessary): Adjust.
	(varobj_update): Adjust.
	(delete_variable_1): Adjust.
	* ada-varobj.c (ada_value_has_mutated): Adjust.
	* mi/mi-cmd-var.c (mi_cmd_var_list_children): Adjust.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [testsuite] Pass pthreads in prepare_for_testing
@ 2017-11-22 17:26 sergiodj+buildbot
  2017-11-22 23:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-22 17:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1daad298d699383bb4f35aa919a1acfa0ab8e16c ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 1daad298d699383bb4f35aa919a1acfa0ab8e16c

[testsuite] Pass pthreads in prepare_for_testing

"pthreads" in the right flag to pass in prepare_for_testing to linker,
instead of additional_flags.  Without this patch, the test case can't be
complied by clang.

gdb compile failed, clang: warning: -lpthread: 'linker' input unused

gdb/testsuite:

2017-11-22  Yao Qi  <yao.qi@linaro.org>

	* gdb.base/info-os.exp: Pass pthreads.
	* gdb.multi/multi-attach.exp: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [testsuite] Don't skip gdb.dwarf2/pr10770.exp for non-gcc compiler
@ 2017-11-22 17:05 sergiodj+buildbot
  2017-11-22 22:29 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-22 17:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 88465e872cb6649c42863e5c47011bae9e17bbdb ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 88465e872cb6649c42863e5c47011bae9e17bbdb

[testsuite] Don't skip gdb.dwarf2/pr10770.exp for non-gcc compiler

gdb.dwarf2/pr10770.exp can be used for non-gcc compiler, at least clang.
This patch removes the restriction to only use gcc.  If other compilers,
like xlc or icc, can't compile the .c file, test result is not changed.

gdb/testsuite:

2017-11-22  Yao Qi  <yao.qi@linaro.org>

	* gdb.dwarf2/pr10770.exp: Remove code skipping non-gcc
	compiler.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove Vec_Disp8 field for vgf2p8mulb for AVX flavor.
@ 2017-11-22 16:44 sergiodj+buildbot
  2017-11-22 21:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-22 16:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 94b98370de3ee157e039f26865390b5994c47c3b ***

Author: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
Branch: master
Commit: 94b98370de3ee157e039f26865390b5994c47c3b

Remove Vec_Disp8 field for vgf2p8mulb for AVX flavor.

	* i386-opc.tbl: Remove Vec_Disp8 from vgf2p8mulb.
	* i386-tbl.h: Regenerate.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove Vec_Disp8 from vpcompressb and vpexpandb.
@ 2017-11-22 16:02 sergiodj+buildbot
  2017-11-22 18:49 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-22 16:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c7478d028e8829402b05478f571eb5e1916c63d3 ***

Author: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
Branch: master
Commit: c7478d028e8829402b05478f571eb5e1916c63d3

Remove Vec_Disp8 from vpcompressb and vpexpandb.

	* i386-opc.tbl: Remove Vec_Disp8 from vpcompressb and vpexpandb.
	* i386-tbl.h: Regenerate.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix build with GCC 8: strncpy ->strcpy
@ 2017-11-22 13:23 sergiodj+buildbot
  2017-11-22 15:03 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-22 13:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a9f26f609e3a1b6ae3aab300b55442e0a81e2bce ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: a9f26f609e3a1b6ae3aab300b55442e0a81e2bce

Fix build with GCC 8: strncpy ->strcpy

Recent gcc 8 trunk emits the warning below,

../../binutils-gdb/gdb/python/py-gdb-readline.c:79:15: error: char* strncpy(char*, const char*, size_t) output truncated before terminating nul copying as many bytes from a string as its length [-Werror=stringop-truncation]
       strncpy (q, p, n);
       ~~~~~~~~^~~~~~~~~
../../binutils-gdb/gdb/python/py-gdb-readline.c:73:14: note: length computed here
   n = strlen (p);
       ~~~~~~~^~~

gdb:

2017-11-22  Yao Qi  <yao.qi@linaro.org>

	* python/py-gdb-readline.c (gdbpy_readline_wrapper): Use strcpy.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] ravenscar: update inferior ptid with event ptid
@ 2017-11-22  2:56 sergiodj+buildbot
  2017-11-22  6:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-22  2:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3b1b69bffe522f22d269723856d2caa901041819 ***

Author: Jerome Guitton <guitton@adacore.com>
Branch: master
Commit: 3b1b69bffe522f22d269723856d2caa901041819

ravenscar: update inferior ptid with event ptid

When debugging a program using a ravenscar runtime, the thread
layer sometimes gets confused, and even missing some threads.
This was traced to an assumption that ravenscar_wait was making,
which is that calling the "to_wait" target_ops method would
set the inferior_ptid, so that we could then use that assumption
to update our thread_list and current ptid. However, this has not
been the case for quite a while now. This patch fixes the problem
by assigning inferior_ptid the ptid returned by "to_wait".

gdb/ChangeLog:

	* ravenscar-thread.c (ravenscar_wait): Update inferior ptid
	with event ptid from the lower layer before doing the
	ravenscar-specific update.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] (Ada) crash connecting to TSIM simulator
@ 2017-11-22  1:50 sergiodj+buildbot
  2017-11-22  5:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-22  1:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 54aa6c67f5a0d52dabd428cc40ce02781032acd3 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 54aa6c67f5a0d52dabd428cc40ce02781032acd3

(Ada) crash connecting to TSIM simulator

Connecting to a TSIM simulator over the remote protocol causes GDB
to crash with the following failed assertion:

    (gdb) tar remote :1234
    Remote debugging using :1234
    /[...]/gdb/ravenscar-thread.c:182: internal-error: ravenscar_update_inferior_ptid: Assertion `!is_ravenscar_task (inferior_ptid)' failed.
    A problem internal to GDB has been detected,
    further debugging may prove unreliable.
    Quit this debugging session? (y or n) y

What happens is the following. Upon connection to the target, GDB
sends a 'qfThreadInfo' query, which is the query asking the target
for the ID of the first thread, and TSIM replies 'm0':

    Sending packet: $qfThreadInfo#bb...Ack
    Packet received: m0

As a result of this, GDB takes the '0' as the TID, and because of it,
constructs a ptid whose value is {42000, 0, 0}. This trips our
!is_ravenscar_task check, because all it does to identify threads
corresponding to ravenscar tasks is that their lwp is null, because
that's how we construct their ptid.

But this is unfortunatly not sufficient when debugging with TSIM,
because the thread ID that TSIM returns causes the creation of
a ptid whose lwp is zero, which matches the current identification
scheme and yet is clearly not a ravenscar task.

The fix is to also make sure that the ptid's tid field is nonzero.

gdb/ChangeLog:

        * ravenscar-thread.c (is_ravenscar_task): Also verify that
        the ptid's TID is nonzero.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] problem debugging ravenscar programs if runtime is stripped
@ 2017-11-22  1:10 sergiodj+buildbot
  2017-11-22  4:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-22  1:10 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cf3fbed4a00e668ffcad1b878eccec87334fdcff ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: cf3fbed4a00e668ffcad1b878eccec87334fdcff

problem debugging ravenscar programs if runtime is stripped

Trying to debug a program using a stripped version of the ravenscar
runtime, we can get the following error:

    (gdb) cont
    Continuing.
    Cannot find Ada_Task_Control_Block type. Aborting

This is because the ravenscar-thread layer makes the assumption that
the runtime is built the way we expect it, meaning that the Ada tasking
units we rely on for Ada tasking debugging, are built with debugging
information, and that this debug information has not been stripped from
the runtime.

When this assumption is not true, resuming such a program can trigger
the error above, which then leads GDB a little confused. For instance,
we can see things like:

     (gdb) bt
     Target is executing.

This patch fixes the issue by disabling the ravenscar thread layer
if we detect that the runtime is missing some of the debugging info
we need in order to support Ada task debugging. This is the best
we can do, as the ravenscar-thread layer actually depends on the
ada-tasks layer to implement thread debugging.

gdb/ChangeLog:

        * ada-lang.h (ada_get_tcb_types_info): Add declaration.
        * ada-tasks.c (ada_get_tcb_types_info): Renames get_tcb_types_info.
        Make non-static.  Change return type to char *.  Adjust code
        accordingly.  Rewrite the function's documentation.
        (read_atcb): Adjust call to get_tcb_types_info accordingly.
        * ravenscar-thread.c (ravenscar_inferior_created): Check that
        we have enough debugging information in the runtime to support
        Ada task debugging before we enable the ravenscar-thread layer.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add multiple-CPU support in ravenscar-thread.c
@ 2017-11-22  0:26 sergiodj+buildbot
  2017-11-22  2:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-22  0:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9edcc12f9b714149f84bcf20dbdad91f030e62de ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 9edcc12f9b714149f84bcf20dbdad91f030e62de

Add multiple-CPU support in ravenscar-thread.c

This patch reworks the ravenscar-thread layer to remove the
assumption that the target only has 1 CPU. In particular,
when connected to a QEMU target over the remote protocol,
QEMU reports each CPU as one thread. This patch adapts
the ravenscar-thread layer to this, and adds a large comment
explaining the general design of this unit.

gdb/ChangeLog:

        * ada-lang.h (ada_get_task_info_from_ptid): Add declaration.
        * ada-tasks.c (ada_get_task_info_from_ptid): New function.
        * ravenscar-thread.c: Add into comment.
        (base_magic_null_ptid): Delete.
        (base_ptid): Change documentation.
        (ravenscar_active_task): Renames ravenscar_running_thread.
        All callers updated throughout.
        (is_ravenscar_task, ravenscar_get_thread_base_cpu): New function.
        (ravenscar_task_is_currently_active): Likewise.
        (get_base_thread_from_ravenscar_task): Ditto.
        (ravenscar_update_inferior_ptid): Adjust to handle multiple CPUs.
        (ravenscar_runtime_initialized): Likewise.
        (get_running_thread_id): Add new parameter "cpu".  Adjust
        implementation to handle this new parameter.
        (ravenscar_fetch_registers): Small adjustment to use
        is_ravenscar_task and ravenscar_task_is_currently_active in
        order to decide whether to use the target beneath or this
        module's arch_ops.
        (ravenscar_store_registers, ravenscar_prepare_to_store): Likewise.
        (ravenscar_stopped_by_sw_breakpoint): Use
        get_base_thread_from_ravenscar_task to get the underlying
        thread, rather than using base_ptid.
        (ravenscar_stopped_by_hw_breakpoint, ravenscar_stopped_by_watchpoint)
        (ravenscar_stopped_data_address, ravenscar_core_of_thread):
        Likewise.
        (ravenscar_inferior_created): Do not set base_magic_null_ptid.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] watchpoint regression debugging with remote protocol (bare metal)
@ 2017-11-21 23:01 sergiodj+buildbot
  2017-11-21 23:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-21 23:01 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e02544b292a3d537b43ae9cff890ea040b944d01 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: e02544b292a3d537b43ae9cff890ea040b944d01

watchpoint regression debugging with remote protocol (bare metal)

We have noticed a regression in our watchpoint support when debugging
through the remote protocol a program running on a bare metal platform,
when the program uses what we call the Ravenscar Runtime.

This runtime is a subset of the Ada runtime defined by the Ravenscar
Profile.  One of the nice things about this runtime is that it provides
tasking, which is equivalent to the concept of threads in C (it is
actually often mapped to threads, when available). For bare metal
targets, however, there is no OS, and therefore no thread layer.
What we did, then, was add a ravenscar-thread layer, which has insider
knowledge of the runtime to get the list of threads, but also all
necessary info to perform thread switching.

For the record, the commit which caused the regression is:

    commit 799a2abe613be0645b84f5aaa050f2f91e6ae3f7
    Date:   Mon Nov 30 16:05:16 2015 +0000
    Subject: remote: stop reason and watchpoint data address per thread

    Running local-watch-wrong-thread.exp with "maint set target-non-stop
    on" exposes that gdb/remote.c only records whether the target stopped
    for a breakpoint/watchpoint plus the watchpoint data address *for the
    last reported remote event*.  But in non-stop mode, we need to keep
    that info per-thread, as each thread can end up with its own
    last-status pending.

Our testcase is very simple. We have a package defining a global
variable named "Watch"...

    package Pck is
       Watch : Integer := 1974;
    end Pck;

... and a main subprogram which changes its value

    procedure Foo is
    begin
       Pck.Watch := Pck.Watch + 1;
    end Foo;

To reproduce, we built our program as usual, started it in QEMU,
and then connected GDB to QEMU...

    (gdb) target remote :4444
    (gdb) break _ada_foo
    (gdb) cont  <--- this is to make sure the program is started
                     and the variable we want to watch is initialized

... at which point we try to use a watchpoint on our global variable:

    (gdb) watch watch

... but, upon resuming the execution with a "cont", we expected to
get a watchpoint-hit notification, such as...

    (gdb) cont
    Hardware watchpoint 2: watch

    Old value = 1974
    New value = 1975
    0xfff00258 in foo () at /[...]/foo.adb:6
    6       end Foo;

... but unfortunately, we get a SIGTRAP instead:

    (gdb) cont
    Program received signal SIGTRAP, Trace/breakpoint trap.
    foo () at /[...]/foo.adb:6
        6   end Foo;

What happens is that, on the one hand, the change in remote.c
now stores the watchpoint-hit notification info in the thread
that received it; and on the other hand, we have a ravenscar-thread
layer which manages the thread list on top of the remote protocol
layer. The two of them get disconnected, and this eventually results
in GDB not realizing that we hit a watchpoint.  Below is how:

First, once connected and just before inserting our watchpoint,
we have the ravenscar-thread layer which built the list of threads
by extracting some info from inferior memory, giving us the following
two threads:

      (gdb) info threads
      Id   Target Id         Frame
      1    Thread 0 "0Q@" (Ravenscar task) foo () at /[...]/foo.adb:5
    * 2    Thread 0x24618 (Ravenscar task) foo () at /[...]/foo.adb:5

The first thread is the only thread QEMU told GDB about. The second
one is a thread that the ravenscar-thread added. QEMU has now way
to know about those threads, since they are really embedded inside
the program; that's why we have the ravenscar layer, which uses
inside-knowledge to extract the list of threads.

Next, we insert a watchpoint, which applies to all threads. No problem
so far.

Then, we continue; meaning that GDB sends a Z2 packet to QEMU to
get the watchpoint inserted, then a vCont to resume the program's
execution. The program hits the watchpoints, and thererfore QEMU
reports it back:

        Packet received: T05thread:01;watch:000022c4;

Since QEMU knows about one thread and one thread only, it stands
to reason that it would say that the event applies to thread:01,
which is our first thread in the "info threads" listing. That
thread has a ptid of {42000, lwp=1, tid=0}.

This is where Pedro's change kicks in: Seeing this event, and
having determined that the event was reported for thread 01,
and therefore ptid {42000, lwp=1, tid=0}, it saves the watchpoint-hit
event info in the private area of that thread/ptid. Once this is
done, remote.c's event-wait layer returns.

Enter the ravenscar-thread layer of the event-wait, which does
a little dance to delegate the wait to underlying layers with
ptids that those layers know about, and then when the target_beneath's
to_wait is done, tries to figure out which thread is now the active
thread. The code looks like this:

  1.    inferior_ptid = base_ptid;
  2.    beneath->to_wait (beneath, base_ptid, status, 0);
  3.    [...]
  4.        ravenscar_update_inferior_ptid ();
  5.
  6.    return inferior_ptid;

Line 1 is where we reset inferior_ptid to the ptid that
the target_beneath layer knows about, allowing us to then
call its to_wait implementation (line 2). And then, upon
return, we call ravenscar_update_inferior_ptid, which reads
inferior memory to determine which thread is actually active,
setting inferior_ptid accordingly. Then we return that
inferior_ptid (which, again, neither QEMU and therefore nor
the remote.c layer knows about).

Upon return, we eventually arrive to the part where we try
to handle the inferior event: we discover that we got a SIGTRAP
and, as part of its handling, we call watchpoints_triggered,
which calls target_stopped_by_watchpoint, which eventually
remote_stopped_by_watchpoint, where Pedro's change kicks in
again:

    struct thread_info *thread = inferior_thread ();
    return (thread->priv != NULL
            && thread->priv->stop_reason == TARGET_STOPPED_BY_WATCHPOINT);

Because the ravenscar-thread layer changed the inferior_ptid
to the ptid of the active thread, inferior_thread now returns
the private data of that thread. This is not the thread that
QEMU reported the watchpoint-hit on, and thus, the function
returns "no watchpoint hit, mister". Hence GDB not understanding
the SIGTRAP, thus reporting it verbatim.

The way we chose to fix the issue is by making sure that the
ravenscar-thread layer doesn't let the remote layer be called
with inferior_ptid being set to a thread that the remote layer
does not know about.

gdb/ChangeLog:

        * ravenscar-thread.c (ravenscar_stopped_by_sw_breakpoint)
        (ravenscar_stopped_by_hw_breakpoint, ravenscar_stopped_by_watchpoint)
        (ravenscar_stopped_data_address, ravenscar_core_of_thread):
        New functions.
        (init_ravenscar_thread_ops): Set the to_stopped_by_sw_breakpoint,
        to_stopped_by_hw_breakpoint, to_stopped_by_watchpoint,
        to_stopped_data_address and to_core_of_thread fields of
        ravenscar_ops.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [PowerPC] Detect different long double floating-point formats
@ 2017-11-21 18:08 sergiodj+buildbot
  2017-11-21 19:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-21 18:08 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ed0f427344d0befead629d9267aecd01bfb72721 ***

Author: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Branch: master
Commit: ed0f427344d0befead629d9267aecd01bfb72721

[PowerPC] Detect different long double floating-point formats

Current versions of GCC support switching the format used for "long double"
to either IBM double double or IEEE-128.  The resulting binary is marked
via different setting of the Tag_GNU_Power_ABI_FP GNU attribute.

This patch checks this attribute to detect the format of the default
"long double" type and sets GDB's notion of the format accordingly.

The patch also adds support for the "__ibm128" type, which always uses
IBM double double format independent of the format used for "long double".

A new test case verifies that all three types, "long double", "__float128",
and "__ibm128" are correctly detected in all three compiler settings,
the default setting, -mabi=ieeelongdouble, and -mabi=ibmlongdouble.

gdb/ChangeLog:
2017-11-21  Ulrich Weigand  <uweigand@de.ibm.com>

	* ppc-tdep.h (enum powerpc_long_double_abi): New data type.
	(struct gdbarch_tdep): New member long_double_abi.
	* rs6000-tdep.c (rs6000_gdbarch_init): Initialize long_double_abi
	member of tdep struct based on Tag_GNU_Power_ABI_FP attribute.
	* ppc-linux-tdep.c (ppc_linux_init_abi): Install long double data
	format depending on long_double_abi tdep member.
	(ppc_floatformat_for_type): Handle __ibm128 type.

gdb/testsuite/ChangeLog:
2017-11-21  Ulrich Weigand  <uweigand@de.ibm.com>

	* gdb.arch/ppc-longdouble.exp: New file.
	* gdb.arch/ppc-longdouble.c: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdb.ada/minsyms.exp: Don't hardcode the variable's address
@ 2017-11-21 17:30 sergiodj+buildbot
  2017-11-21 18:22 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-21 17:30 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a25d69c6dcbabf3f6629b847246ffb4ddbc29472 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: a25d69c6dcbabf3f6629b847246ffb4ddbc29472

gdb.ada/minsyms.exp: Don't hardcode the variable's address

This new testcase has a test that fails like this here:

  $1 = (<data variable, no debug info> *) 0x60208c <some_minsym>
  (gdb) FAIL: gdb.ada/minsyms.exp: print &some_minsym

The problem is that the testcase hardcodes an expected address for the
"some_minsym" variable, which obviously isn't stable.

Fix that by expecting $hex instead.

gdb/testsuite/ChangeLog:
2017-11-21  Pedro Alves  <palves@redhat.com>

	* gdb.ada/minsyms.exp: Accept any address for 'some_minsym'.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [ARC] Improve printing of pc-relative instructions.
@ 2017-11-21 14:17 sergiodj+buildbot
  2017-11-21 15:15 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-21 14:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 50d2740d562edc68b2fbcacc0585c3acfc2c302f ***

Author: claziss <claziss@synopsys.com>
Branch: master
Commit: 50d2740d562edc68b2fbcacc0585c3acfc2c302f

[ARC] Improve printing of pc-relative instructions.

opcodes/
2017-11-21  Claudiu Zissulescu <claziss@synopsys.com>

	* arc-dis.c (print_insn_arc): Pretty print pc-relative offsets.
	* arc-opc.c (SIMM21_A16_5): Make it pc-relative.

gas/
2017-11-21  Claudiu Zissulescu <claziss@synopsys.com>

	* testsuite/gas/arc/b.d : Update test.
	* testsuite/gas/arc/bl.d: Likewise.
	* testsuite/gas/arc/jli-1.d: Likewise.
	* testsuite/gas/arc/lp.d: Likewise.
	* testsuite/gas/arc/pcl-relocs.d: Likewise.
	* testsuite/gas/arc/pcrel-relocs.d: Likewise.
	* testsuite/gas/arc/pic-relocs.d: Likewise.
	* testsuite/gas/arc/plt-relocs.d: Likewise.
	* testsuite/gas/arc/pseudos.d: Likewise.
	* testsuite/gas/arc/relax-avoid2.d: Likewise.
	* testsuite/gas/arc/relax-avoid3.d: Likewise.
	* testsuite/gas/arc/relax-b.d: Likewise.
	* testsuite/gas/arc/tls-relocs.d: Likewise.
	* testsuite/gas/arc/relax-add01.d: Likewise.
	* testsuite/gas/arc/relax-add04.d: Likewise.
	* testsuite/gas/arc/relax-ld01.d: Likewise.
	* testsuite/gas/arc/relax-sub01.d: Likewise.
	* testsuite/gas/arc/relax-sub02.d: Likewise.
	* testsuite/gas/arc/relax-sub04.d: Likewise.
	* testsuite/gas/arc/pcl-print.s: New file.
	* testsuite/gas/arc/pcl-print.d: Likewise.
	* testsuite/gas/arc/nps400-12.d: Likewise.

ld/
2017-11-21  Claudiu Zissulescu <claziss@synopsys.com>

	* testsuite/ld-arc/jli-simple.d: Update test.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix build failure in darwin-nat.c
@ 2017-11-21  4:54 sergiodj+buildbot
  2017-11-21  7:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-21  4:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0fc7642151cc5e62f05ac8ea91fe4d5b44bee11a ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 0fc7642151cc5e62f05ac8ea91fe4d5b44bee11a

Fix build failure in darwin-nat.c

Fix:

/Users/simark/src/binutils-gdb/gdb/darwin-nat.c:2404:3: error: no matching function for call to 'add_setshow_boolean_cmd'
  add_setshow_boolean_cmd ("mach-exceptions", class_support,
  ^~~~~~~~~~~~~~~~~~~~~~~

gdb/ChangeLog:

	* darwin-nat.c (set_enable_mach_exceptions): Constify parameter.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix mapped_index::find_name_components_bounds upper bound computation
@ 2017-11-21  2:07 sergiodj+buildbot
  2017-11-21  5:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-21  2:07 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e6b2f5efa97c7f3de8a3947c6782c40ec6172686 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: e6b2f5efa97c7f3de8a3947c6782c40ec6172686

Fix mapped_index::find_name_components_bounds upper bound computation

Here we want to find where we'd insert "after", so we want
std::lower_bound, not std::upper_bound.

gdb/ChangeLog:
2017-11-21  Pedro Alves  <palves@redhat.com>

	* dwarf2read.c (mapped_index::find_name_components_bounds)
	<completion mode, upper bound>: Use std::lower_bound instead of
	std::upper_bound.
	(test_mapped_index_find_name_component_bounds): Remove incorrect
	"t1_fund" from expected symbols.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix gdb.base/whatis-ptype-typedefs.exp on 32-bit archs
@ 2017-11-20 23:31 sergiodj+buildbot
  2017-11-21  0:18 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-20 23:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 73fcf6418ddce47ead4ffde4fc9fea8e8bd1f4af ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 73fcf6418ddce47ead4ffde4fc9fea8e8bd1f4af

Fix gdb.base/whatis-ptype-typedefs.exp on 32-bit archs

The gdb.base/whatis-ptype-typedefs.exp testcase has several tests that
fail on 32-bit architectures.  E.g., on 'x86-64 -m32', I see:

 ...
 FAIL: gdb.base/whatis-ptype-typedefs.exp: lang=c: cast: whatis (float_typedef) v_uchar_array_t_struct_typedef (invalid)
 FAIL: gdb.base/whatis-ptype-typedefs.exp: lang=c: cast: ptype (float_typedef) v_uchar_array_t_struct_typedef (invalid)
 ...

gdb.log:

 (gdb) whatis (float_typedef) v_uchar_array_t_struct_typedef
 type = float_typedef
 (gdb) FAIL: gdb.base/whatis-ptype-typedefs.exp: lang=c: cast: whatis (float_typedef) v_uchar_array_t_struct_typedef (invalid)

As Simon explained [1], the issue boils down to the fact that on
64-bit, this is an invalid cast:

 (gdb) p (float_typedef) v_uchar_array_t_struct_typedef
 Invalid cast.

while on 32 bits it is valid:

 (gdb) p (float_typedef) v_uchar_array_t_struct_typedef
 $1 = 1.16251721e-41

The expression basically tries to cast an array (which decays to a
pointer) to a float.  The cast works on 32 bits because a float and a
pointer are of the same size, and value_cast works in that case:

~~~
   More general than a C cast: accepts any two types of the same length,
   and if ARG2 is an lvalue it can be cast into anything at all.  */
~~~

On 64 bits, they are not the same size, so it ends throwing the
"Invalid cast" error.

The testcase is expecting the invalid cast behavior, thus the FAILs.

A point of these tests was to cover as many code paths in value_cast
as possible, as a sort of documentation of the current behavior:

    # The main idea here is testing all the different paths in the
    # value casting code in GDB (value_cast), making sure typedefs are
    # preserved.
...
    # We try all combinations, even those that don't parse, or are
    # invalid, to catch the case of a regression making them
    # inadvertently valid.  For example, these convertions are
    # invalid:
...

In that spirit, this commit makes the testcase adjust itself depending
on size of floats and pointers, and also test floats of different
sizes.

Passes cleanly on x86-64 GNU/Linux both -m64/-m32.

[1] - https://sourceware.org/ml/gdb-patches/2017-11/msg00382.html

gdb/ChangeLog:
2017-11-20  Pedro Alves  <palves@redhat.com>

	* gdb.base/whatis-ptype-typedefs.c (double_typedef)
	(long_double_typedef): New typedefs.
	Use DEF on double and long double.
	* gdb.base/whatis-ptype-typedefs.exp: Add double and long double
	cases.
	(run_tests): New 'float_ptr_same_size', 'double_ptr_same_size',
	and 'long_double_ptr_same_size' locals.  Use them to decide
	whether cast from array/function to float is valid/invalid.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR22451, strip no longer works on older object files
@ 2017-11-20 14:38 sergiodj+buildbot
  2017-11-20 21:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-20 14:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 28e07a0510ca896311014cddf125aedfd7a8cd52 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 28e07a0510ca896311014cddf125aedfd7a8cd52

PR22451, strip no longer works on older object files

Setting SHF_GROUP unconditionally on rel/rela sections associated with
SHF_GROUP sections fails badly with objcopy/strip and ld -r if the
input file SHT_GROUP section didn't specify the rel/rela sections.
This patch rearranges where SHF_GROUP is set for rel/rela sections.

	PR 22451
	PR 22460
	* elf.c (_bfd_elf_init_reloc_shdr): Delete "sec_hdr" parameter
	and leave rel_hdr->sh_flags zero.  Update calls.
	(bfd_elf_set_group_contents): Check input rel/rela SHF_GROUP
	flag when !gas before adding rel/rela section to group.  Set
	output rel/rela SHF_GROUP flags.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove usage of find_inferior when calling kill_one_lwp_callback
@ 2017-11-20 10:03 sergiodj+buildbot
  2017-11-20 20:38 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-20 10:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 578290ecafb83e93f0ac695df586b65dac5e8c5d ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 578290ecafb83e93f0ac695df586b65dac5e8c5d

Remove usage of find_inferior when calling kill_one_lwp_callback

Replace with for_each_thread.

gdb/gdbserver/ChangeLog:

	* linux-low.c (kill_one_lwp_callback): Return void, take
	argument directly, don't filter on pid.
	(linux_kill): Use for_each_thread.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove usages of find_thread when calling need_step_over_p
@ 2017-11-20  9:29 sergiodj+buildbot
  2017-11-20 19:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-20  9:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT eca55aec1d919b69e0d61c91367f8b4d25bc7c43 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: eca55aec1d919b69e0d61c91367f8b4d25bc7c43

Remove usages of find_thread when calling need_step_over_p

Replace with find_thread.

gdb/gdbserver/ChangeLog:

	* linux-low.c (need_step_over_p): Return bool, remove dummy
	argument.
	(linux_resume, proceed_all_lwps): Use find_thread.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove usage of find_inferior in unsuspend_all_lwps
@ 2017-11-20  8:09 sergiodj+buildbot
  2017-11-20 13:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-20  8:09 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 139720c5b32963ce52c5f691e179920ff84a2237 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 139720c5b32963ce52c5f691e179920ff84a2237

Remove usage of find_inferior in unsuspend_all_lwps

Replace with for_each_thread.  I inlined unsuspend_one_lwp in
unsuspend_all_lwps, since it is very simple.

gdb/gdbserver/ChangeLog:

	* linux-low.c (unsuspend_one_lwp): Remove.
	(unsuspend_all_lwps): Use for_each_thread, inline code from
	unsuspend_one_lwp.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove usage of find_inferior in linux_stabilize_threads
@ 2017-11-20  7:13 sergiodj+buildbot
  2017-11-20 14:54 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-20  7:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fcb056a58dd38cfe7bcd34b7889138bf807c40b8 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: fcb056a58dd38cfe7bcd34b7889138bf807c40b8

Remove usage of find_inferior in linux_stabilize_threads

Simply replace with find_thread.

gdb/gdbserver/ChangeLog:

	* linux-low.c (stuck_in_jump_pad_callback): Change prototype,
	return bool, remove data argument.
	(linux_stabilize_threads): Use find_thread.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove usage of find_inferior in iterate_over_lwps
@ 2017-11-20  5:53 sergiodj+buildbot
  2017-11-20 12:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-20  5:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6d1e5673fec830f0f1c86632a5d9333e34582bb3 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 6d1e5673fec830f0f1c86632a5d9333e34582bb3

Remove usage of find_inferior in iterate_over_lwps

Replace find_inferior with find_thread.  Since it may be useful in the
future, I added another overload to find_thread which filters based on a
ptid (using ptid_t::matches), so now iterate_over_lwps doesn't have to
do the filtering itself.  iterate_over_lwps_filter is removed and
inlined into iterate_over_lwps.

gdb/gdbserver/ChangeLog:

	* gdbthread.h (find_thread): Add overload with ptid_t filter.
	* linux-low.c (struct iterate_over_lwps_args): Remove.
	(iterate_over_lwps_filter): Remove.
	(iterate_over_lwps): Use find_thread.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove usage of find_inferior in reset_lwp_ptrace_options_callback
@ 2017-11-20  5:03 sergiodj+buildbot
  2017-11-20 10:33 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-20  5:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bbf550d50e4c85666877456f014421089503e83b ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: bbf550d50e4c85666877456f014421089503e83b

Remove usage of find_inferior in reset_lwp_ptrace_options_callback

Replace with for_each_thread, and inline code from
reset_lwp_ptrace_options_callback.

gdb/gdbserver/ChangeLog:

	* linux-low.c (reset_lwp_ptrace_options_callback): Remove.
	(linux_handle_new_gdb_connection): Use for_each_thread, inline
	code from reset_lwp_ptrace_options_callback.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove usage of find_inferior in win32-low.c
@ 2017-11-20  4:18 sergiodj+buildbot
  2017-11-20  5:06 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-20  4:18 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2bee2b6ca4cb1a736f963a168dd2ded2831c540d ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 2bee2b6ca4cb1a736f963a168dd2ded2831c540d

Remove usage of find_inferior in win32-low.c

Replace with for_each_thread.

gdb/gdbserver/ChangeLog:

	* win32-low.c (continue_one_thread): Return void, take argument
	directly.
	(child_continue): Use for_each_thread.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix error message typo.
@ 2017-11-19  1:27 sergiodj+buildbot
  2017-11-19  1:30 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-19  1:27 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 671275c35e71d3bcdde173d8817e34e89b984241 ***

Author: Jim Wilson <jimw@sifive.com>
Branch: master
Commit: 671275c35e71d3bcdde173d8817e34e89b984241

Fix error message typo.

	bfd/
	* elfnn-riscv.c (_bfd_riscv_relax_align): Add space between alignment
	and to in error message.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make template_symbol derive from symbol
@ 2017-11-17 22:40 sergiodj+buildbot
  2017-11-18  4:48 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-17 22:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 68e745e38edebd2a12d60ef7b5774066db3f1c40 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 68e745e38edebd2a12d60ef7b5774066db3f1c40

Make template_symbol derive from symbol

This changes template_symbol to derive from symbol, which seems a bit
cleaner; and also more consistent with rust_vtable_symbol.

2017-11-17  Tom Tromey  <tom@tromey.com>

	* dwarf2read.c (read_func_scope): Update.
	* symtab.h (struct template_symbol): Derive from symbol.
	<base>: Remove.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make process_info::syscalls_to_catch an std::vector
@ 2017-11-17 20:02 sergiodj+buildbot
  2017-11-17 23:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-17 20:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f27866ba9c348a72a899f5a84dadf1f943c89720 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: f27866ba9c348a72a899f5a84dadf1f943c89720

Make process_info::syscalls_to_catch an std::vector

This patch makes the syscalls_to_catch field of process_info an
std::vector<int>.  The process_info structure must now be
newed/deleted.

In handle_extended_wait, the code that handles exec events destroys the
existing process_info and creates a new one.  It moves the content of
syscalls_to_catch from the old to the new vector.  I used std::move for
that (through an intermediary variable), which should have the same
behavior as the old code.

gdb/gdbserver/ChangeLog:

	* inferiors.h (struct process_info): Add constructor, initialize
	fields..
	<syscalls_to_catch>: Change type to std::vector<int>.
	* inferiors.c (add_process): Allocate process_info with new.
	(remove_process): Free process_info with delete.
	* linux-low.c (handle_extended_wait): Adjust.
	(gdb_catching_syscalls_p, gdb_catch_this_syscall_p): Adjust.
	* server.c (handle_general_set): Adjust.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make open_fds an std::vector
@ 2017-11-17 19:16 sergiodj+buildbot
  2017-11-17 22:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-17 19:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 37269bc92ca6a79f9e56fe83718f3c86a1db845d ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 37269bc92ca6a79f9e56fe83718f3c86a1db845d

Make open_fds an std::vector

Simple replacement of VEC with std::vector.

gdb/ChangeLog:

	* common/filestuff.c: Include <algorithm>.
	(open_fds): Change type to std::vector<int>.
	(do_mark_open_fd): Adjust.
	(unmark_fd_no_cloexec): Adjust.
	(do_close): Adjust.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] (Ada) fix handling of minimal symbols (UNOP_CAST and UNOP_ADDR)
@ 2017-11-17 18:07 sergiodj+buildbot
  2017-11-17 20:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-17 18:07 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ced9779b4c45b9bc9c16dd98fa30d7a620e93a55 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: ced9779b4c45b9bc9c16dd98fa30d7a620e93a55

(Ada) fix handling of minimal symbols (UNOP_CAST and UNOP_ADDR)

Consider a program which provides a symbol without debugging
information. For instance, compiling the following code without -g:

    Some_Minimal_Symbol : Integer := 1234;
    pragma Export (C, Some_Minimal_Symbol, "some_minsym");

Trying to print this variable with GDB now causes an error, which
is now expected:

    (gdb) p some_minsym
    'some_minsym' has unknown type; cast it to its declared type

However, trying to cast this symbol, or to take its address
does not work:

    (gdb) p integer(some_minsym)
    'some_minsym' has unknown type; cast it to its declared type
    (gdb) p &some_minsym
    'some_minsym' has unknown type; cast it to its declared type

Another manisfestation of this issue can be seen when trying to
insert an Ada exception catchpoint for a specific standard exception
(this only occurs if the Ada runtime is built without debugging
information, which is the default).  For instance:

    $ (gdb) catch exception constraint_error
    warning: failed to reevaluate internal exception condition for catchpoint 0: 'constraint_error' has unknown type; cast it to its declared type

This is because, internally, the cachtpoint uses a condition referencing
a minimal symbol, more precisely:

   long_integer (e) = long_integer (&constraint_error)

This patch fixes all issues listed above:

  1. resolve_subexp: Special-case the handling of OP_VAR_MSYM_VALUE
     expression elements, where there are no ambiguities to be resolved
     in that situation;

  2. ada_evaluate_subexp: Enhance the handling of the UNOP_CAST
     handling so as to process the case where the target of
     the cast is a minimal symbol (as well as a symbol with debugging
     information). This mimics what's done in C.

gdb/ChangeLog:

        * ada-lang.c (resolve_subexp): Add handling of OP_VAR_MSYM_VALUE.
        (ada_evaluate_subexp_for_cast): New function.
        (ada_evaluate_subexp) <UNOP_CAST>: Replace code by call to
        ada_evaluate_subexp_for_cast.
        (ada_evaluate_subexp) <nosideret>: Replace code by call to
        eval_skip_value.
        * eval.c (evaluate_var_value): Make non-static.
        (evaluate_var_msym_value, eval_skip_value): Likewise.
        * value.h (evaluate_var_value, evaluate_var_msym_value)
        (eval_skip_value): Declare.

gdb/testsuite/ChangeLog:

        * gdb.ada/minsyms: New testcase.

Tested on x86_64-linux. No regression. Fixes the following failures:

    catch_ex.exp: continuing to Program_Error exception
    catch_ex.exp: continuing to failed assertion
    catch_ex.exp: continuing to unhandled exception
    catch_ex.exp: continuing to program completion
    complete.exp: p <Exported_Capitalized>
    complete.exp: p Exported_Capitalized
    complete.exp: p exported_capitalized
    mi_catch_ex.exp: catch Program_Error (unexpected output)
    mi_catch_ex.exp: continue to exception catchpoint hit (unknown output after running)
    mi_catch_ex.exp: continue to assert failure catchpoint hit (unknown output after running)
    mi_catch_ex.exp: continue to unhandled exception catchpoint hit (unknown output after running)
    mi_ex_cond.exp: catch C_E if i = 2 (unexpected output)


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: Pass "%F%P:" to linker callback in case of error
@ 2017-11-17 12:33 sergiodj+buildbot
  2017-11-17 18:47 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-17 12:33 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2c244f9b0935e577d7c20bb5706e27438e48227f ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 2c244f9b0935e577d7c20bb5706e27438e48227f

x86: Pass "%F%P:" to linker callback in case of error

We should pass "%F%P:" to  linker callback in case of error.  Otherwise,
linker will report:

: failed to create GNU property section

	* elfxx-x86.c (_bfd_x86_elf_link_setup_gnu_properties): Pass
	"%F%P:", instead of "%F:", to linker callback in case of error.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] ada-lang.c::ada_value_cast: remove unused parameter noside
@ 2017-11-17  2:47 sergiodj+buildbot
  2017-11-17 17:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-17  2:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b7e228508255359e473611fdf7c067b0b79cadbe ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: b7e228508255359e473611fdf7c067b0b79cadbe

ada-lang.c::ada_value_cast: remove unused parameter noside

gdb/ChangeLog:

        * ada-lang.c (ada_value_cast): Remove parameter "noside".
        Update all callers.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Test breakpoint commands w/ "continue" + Ctrl-C
@ 2017-11-16 23:48 sergiodj+buildbot
  2017-11-17 16:08 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-16 23:48 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a0922d80dff15d4fbd5d469f56bcd1696846b90a ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: a0922d80dff15d4fbd5d469f56bcd1696846b90a

Test breakpoint commands w/ "continue" + Ctrl-C

This adds the testcase that exposed the multiple problems with Ctrl-C
handling fixed by the previous patches, when run against both native
and gdbserver GNU/Linux.

gdb/ChangeLog:
2017-11-16  Pedro Alves  <palves@redhat.com>

	* gdb.base/bp-cmds-continue-ctrl-c.c: New file.
	* gdb.base/bp-cmds-continue-ctrl-c.exp: New file.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Don't ever Quit out of resume
@ 2017-11-16 23:37 sergiodj+buildbot
  2017-11-17 13:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-16 23:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d930703d68ae160ddfe8ebe5fdcf416fb6090e1e ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: d930703d68ae160ddfe8ebe5fdcf416fb6090e1e

Don't ever Quit out of resume

If you have a breakpoint command that re-resumes the target, like:

  break foo
  commands
  > c
  > end

and then let the inferior run, hitting the breakpoint, and then press
Ctrl-C at just the right time, between GDB processing the stop at
"foo", and re-resuming the target, you'll hit the QUIT call in
infrun.c:resume.

With this hack, we can reproduce the bad case consistently:

  --- a/gdb/inf-loop.c
  +++ b/gdb/inf-loop.c
  @@ -31,6 +31,8 @@
   #include "top.h"
   #include "observer.h"

  +bool continue_hack;
  +
   /* General function to handle events in the inferior.  */

   void
  @@ -64,6 +66,8 @@ inferior_event_handler (enum inferior_event_type event_type,
	  {
	    check_frame_language_change ();

  +         continue_hack = true;
  +
	    /* Don't propagate breakpoint commands errors.  Either we're
	       stopping or some command resumes the inferior.  The user will
	       be informed.  */
  diff --git a/gdb/infrun.c b/gdb/infrun.c
  index d425664..c74b14c 100644
  --- a/gdb/infrun.c
  +++ b/gdb/infrun.c
  @@ -2403,6 +2403,10 @@ resume (enum gdb_signal sig)
     gdb_assert (!tp->stop_requested);
     gdb_assert (!thread_is_in_step_over_chain (tp));

  +  extern bool continue_hack;
  +
  +  if (continue_hack)
  +    set_quit_flag ();
     QUIT;

The GDB backtrace looks like this:

  (top-gdb) bt
  ...
  #3  0x0000000000612e8b in throw_quit(char const*, ...) (fmt=0xaf84a1 "Quit") at src/gdb/common/common-exceptions.c:408
  #4  0x00000000007fc104 in quit() () at src/gdb/utils.c:748
  #5  0x00000000006a79d2 in default_quit_handler() () at src/gdb/event-top.c:954
  #6  0x00000000007fc134 in maybe_quit() () at src/gdb/utils.c:762
  #7  0x00000000006f66a3 in resume(gdb_signal) (sig=GDB_SIGNAL_0) at src/gdb/infrun.c:2406
  #8  0x0000000000700c3d in keep_going_pass_signal(execution_control_state*) (ecs=0x7ffcf3744e60) at src/gdb/infrun.c:7793
  #9  0x00000000006f5fcd in start_step_over() () at src/gdb/infrun.c:2145
  #10 0x00000000006f7b1f in proceed(unsigned long, gdb_signal) (addr=18446744073709551615, siggnal=GDB_SIGNAL_DEFAULT)
      at src/gdb/infrun.c:3135
  #11 0x00000000006ebdd4 in continue_1(int) (all_threads=0) at src/gdb/infcmd.c:842
  #12 0x00000000006ec097 in continue_command(char*, int) (args=0x0, from_tty=0) at src/gdb/infcmd.c:938
  #13 0x00000000004b5140 in do_cfunc(cmd_list_element*, char*, int) (c=0x2d18570, args=0x0, from_tty=0)
      at src/gdb/cli/cli-decode.c:106
  #14 0x00000000004b8219 in cmd_func(cmd_list_element*, char*, int) (cmd=0x2d18570, args=0x0, from_tty=0)
      at src/gdb/cli/cli-decode.c:1952
  #15 0x00000000007f1532 in execute_command(char*, int) (p=0x7ffcf37452b1 "", from_tty=0) at src/gdb/top.c:608
  #16 0x00000000004bd127 in execute_control_command(command_line*) (cmd=0x3a88ef0) at src/gdb/cli/cli-script.c:485
  #17 0x00000000005cae0c in bpstat_do_actions_1(bpstat*) (bsp=0x37edcf0) at src/gdb/breakpoint.c:4513
  #18 0x00000000005caf67 in bpstat_do_actions() () at src/gdb/breakpoint.c:4563
  #19 0x00000000006e8798 in inferior_event_handler(inferior_event_type, void*) (event_type=INF_EXEC_COMPLETE, client_data=0x0)
      at src/gdb/inf-loop.c:72
  #20 0x00000000006f9447 in fetch_inferior_event(void*) (client_data=0x0) at src/gdb/infrun.c:3970
  #21 0x00000000006e870e in inferior_event_handler(inferior_event_type, void*) (event_type=INF_REG_EVENT, client_data=0x0)
      at src/gdb/inf-loop.c:43
  #22 0x0000000000494d58 in remote_async_serial_handler(serial*, void*) (scb=0x3585ca0, context=0x2cd1b80)
      at src/gdb/remote.c:13820
  #23 0x000000000044d682 in run_async_handler_and_reschedule(serial*) (scb=0x3585ca0) at src/gdb/ser-base.c:137
  #24 0x000000000044d767 in fd_event(int, void*) (error=0, context=0x3585ca0) at src/gdb/ser-base.c:188
  #25 0x00000000006a5686 in handle_file_event(file_handler*, int) (file_ptr=0x45997d0, ready_mask=1)
      at src/gdb/event-loop.c:733
  #26 0x00000000006a5c29 in gdb_wait_for_event(int) (block=1) at src/gdb/event-loop.c:859
  #27 0x00000000006a4aa6 in gdb_do_one_event() () at src/gdb/event-loop.c:347
  #28 0x00000000006a4ade in start_event_loop() () at src/gdb/event-loop.c:371

and when that happens, you end up with GDB's run control in quite a
messed up state.  Something like this:

  thread_function1 (arg=0x1) at threads.c:107
  107             usleep (SLEEP);  /* Loop increment.  */
  Quit
  (gdb) c
  Continuing.
  ** nothing happens, time passes..., press ctrl-c again **
  ^CQuit
  (gdb) info threads
    Id   Target Id         Frame
    1    Thread 1462.1462 "threads" (running)
  * 2    Thread 1462.1466 "threads" (running)
    3    Thread 1462.1465 "function0" (running)
  (gdb) c
  Cannot execute this command while the selected thread is running.
  (gdb)

The first "Quit" above is thrown from within "resume", and cancels run
control while GDB is in the middle of stepping over a breakpoint.
with step_over_info_valid_p() true.  The next "c" didn't actually
resume anything, because GDB throught that the step-over was still in
progress.  It wasn't, because the thread that was supposed to be
stepping over the breakpoint wasn't actually resumed.

So at this point, we press Ctrl-C again, and this time, the default
quit handler is called directly from the event loop
(event-top.c:default_quit_handler -> quit()), because gdb was left
owning the terminal (because the previous resume was cancelled before
we reach target_resume -> target_terminal::inferior()).

Note that the exception called from within resume ends up calling
normal_stop via resume_cleanups.  That's very borked though, because
normal_stop is going to re-handle whatever was the last reported
event, possibly even re-running a hook stop...  I think that the only
sane way to safely cancel the run control state machinery is to push
an event via handle_inferior_event like all other events.

The fix here does two things, and either alone would fix the problem
at hand:

#1 - passes the terminal to the inferior earlier, so that any QUIT
     call from the point we declare the target as running goes to the
     inferior directly, protecting run control from unsafe QUIT calls.

#2 - gets rid of this QUIT call in resume and of its related unsafe
     resume_cleanups.

Aboout #2, the comment describing resume says:

  /* Resume the inferior, but allow a QUIT.  This is useful if the user
     wants to interrupt some lengthy single-stepping operation
     (for child processes, the SIGINT goes to the inferior, and so
     we get a SIGINT random_signal, but for remote debugging and perhaps
     other targets, that's not true).

but that's a really old comment that predates a lot of fixes to Ctrl-C
handling throughout both GDB core and the remote target, that made
sure that a Ctrl-C isn't ever lost.  In any case, if some target
depended on this, a much better fix would be to make the target return
a SIGINT stop out of target_wait the next time that is called.

This was exposed by the new gdb.base/bp-cmds-continue-ctrl-c.exp
testcase added later in the series.

gdb/ChangeLog:
2017-11-16  Pedro Alves  <palves@redhat.com>

	* infrun.c (resume_cleanups): Delete.
	(resume): No longer install a resume_cleanups cleanup nor call
	QUIT.
	(proceed): Pass the terminal to the inferior.
	(keep_going_pass_signal): No longer install a resume_cleanups
	cleanup.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix testing gdb.rust/modules.exp against gdbserver
@ 2017-11-16 20:25 sergiodj+buildbot
  2017-11-17  8:11 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-16 20:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ea04e54ca8b935b01155c3d40381d879dd6ba683 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: ea04e54ca8b935b01155c3d40381d879dd6ba683

Fix testing gdb.rust/modules.exp against gdbserver

Currently several tests in gdb.rust/modules.exp fail with
 --target_board=native-gdbserver:

 Running src/gdb/testsuite/gdb.rust/modules.exp ...
 FAIL: gdb.rust/modules.exp: call f3()
 FAIL: gdb.rust/modules.exp: call self::f2()
 FAIL: gdb.rust/modules.exp: call self::super::f2()
 FAIL: gdb.rust/modules.exp: call super::f2()
 FAIL: gdb.rust/modules.exp: call self::super::super::f2()
 FAIL: gdb.rust/modules.exp: call super::super::f2()
 FAIL: gdb.rust/modules.exp: call ::f2()
 FAIL: gdb.rust/modules.exp: call extern modules::mod1::f2()

This is because these tests rely on matching inferior output.
However, when testing with gdbserver, inferior output goes to a
separate terminal instead of to gdb's terminal, and so gdb_test won't
cut it, as that is only reading from gdb's pty/gdb_spawn_id:

 (gdb) call f3()
 (gdb) FAIL: gdb.rust/modules.exp: call f3()
 call self::f2()
 (gdb) FAIL: gdb.rust/modules.exp: call self::f2()

Fix this by using gdb_test_stdio instead, which handles output coming
out of gdbserver's pty.

Also, skip the tests if the target/board doesn't support inferior I/O
at all.

gdb/ChangeLog:
2017-11-16  Pedro Alves  <palves@redhat.com>

	* gdb.rust/modules.exp: Skip tests that rely on inferior I/O if
	gdb,noinferiorio is set, and use gdb_test_stdio otherwise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Refactor endian handling in DFP routines
@ 2017-11-16 19:34 sergiodj+buildbot
  2017-11-17  5:22 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-16 19:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d723696126beb185dc1f8f3196be7cb29948148d ***

Author: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Branch: master
Commit: d723696126beb185dc1f8f3196be7cb29948148d

Refactor endian handling in DFP routines

This patch moves endian conversion into the decimal_from_number and
decimal_to_number routines, and removes it from all their callers,
making the code simpler overall.  No functional change.

gdb/ChangeLog:
2017-11-16  Ulrich Weigand  <uweigand@de.ibm.com>

	* target-float.c (decimal_from_number): Add byte_order argument and
	call match_endianness.  Error if unknown floating-point type.
	(decimal_to_number): Add byte_order argument and call match_endianness.
	(decimal_from_longest): Update call.  Do not call match_endianness.
	(decimal_from_ulongest): Likewise.
	(decimal_binop): Likewise.
	(decimal_is_zero): Likewise.
	(decimal_compare): Likewise.
	(decimal_convert): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Correct AArch64 crypto dependencies.
@ 2017-11-16 18:10 sergiodj+buildbot
  2017-11-17  0:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-16 18:10 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fadfa6b0020b934500356e7aea8934a4565657d3 ***

Author: Tamar Christina <tamar.christina@arm.com>
Branch: master
Commit: fadfa6b0020b934500356e7aea8934a4565657d3

Correct AArch64 crypto dependencies.

The crypto options depend on SIMD and FP, the documentation states so but the dependency is not there the code.

We have mostly gotten away with this due to the default flags
for the architectures (e.g. Armv8.2-a  implies +simd) but this
discrepancy needs to be addressed.

gas/

2017-11-16  Tamar Christina  <tamar.christina@arm.com>

	* opcodes/aarch64-tbl.h
	(aarch64_feature_crypto): Add ARCH64_FEATURE_SIMD and AARCH64_FEATURE_FP.
	(aarch64_feature_crypto_v8_2, aarch64_feature_sm4): Likewise.
	(aarch64_feature_sha3): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add assembler and disassembler support for the new Armv8.4-a instructions for AArch64.
@ 2017-11-16 17:52 sergiodj+buildbot
  2017-11-16 23:03 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-16 17:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e9dbdd80cb02ac66cf7d4cd1207ec11928db2c95 ***

Author: Tamar Christina <tamar.christina@arm.com>
Branch: master
Commit: e9dbdd80cb02ac66cf7d4cd1207ec11928db2c95

Add assembler and disassembler support for the new Armv8.4-a instructions for AArch64.

Some of these instructions have been back-ported as optional extensions to
Armv8.2-a and higher, but others are only available for Armv8.4-a.

opcodes/

	* aarch64-tbl.h (sha512h, sha512h2, sha512su0, sha512su1, eor3): New.
	(rax1, xar, bcax, sm3ss1, sm3tt1a, sm3tt1b, sm3tt2a, sm3tt2b): New.
	(sm3partw1, sm3partw2, sm4e, sm4ekey, fmlal, fmlsl): New.
	(fmlal2, fmlsl2, cfinv, rmif, setf8, setf16, stlurb): New.
	(ldapurb, ldapursb, stlurh, ldapurh, ldapursh, stlur): New.
	(ldapur, ldapursw, stlur): New.
	* aarch64-dis-2.c: Regenerate.

gas/

	* testsuite/gas/aarch64/armv8_4-a-illegal.d: New.
	* testsuite/gas/aarch64/armv8_4-a-illegal.l: New.
	* testsuite/gas/aarch64/armv8_4-a-illegal.s: New.
	* testsuite/gas/aarch64/armv8_4-a.d: New.
	* testsuite/gas/aarch64/armv8_4-a.s: New.
	* testsuite/gas/aarch64/armv8_2-a-crypto-fp16.s: New.
	* testsuite/gas/aarch64/armv8_2-a-crypto-fp16.d: New.
	* testsuite/gas/aarch64/armv8_3-a-crypto-fp16.d: New.
	* testsuite/gas/aarch64/armv8_4-a-crypto-fp16.d: New.
	* testsuite/gas/aarch64/armv8_2-a-crypto-fp16-illegal.s: New.
	* testsuite/gas/aarch64/armv8_2-a-crypto-fp16-illegal.l: New.
	* testsuite/gas/aarch64/armv8_2-a-crypto-fp16-illegal.d: New.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] GDBserver: Fix ignored Ctrl-C after reconnection
@ 2017-11-16 16:44 sergiodj+buildbot
  2017-11-16 21:38 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-16 16:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e849ea896bcdc3da8caff02eb6dc91dc85dd8a7e ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: e849ea896bcdc3da8caff02eb6dc91dc85dd8a7e

GDBserver: Fix ignored Ctrl-C after reconnection

This fixes the issue reported by Dmitry Antipov <dantipov@nvidia.com>
here:
  https://sourceware.org/ml/gdb/2017-10/msg00048.html

The problem is that GDBserver stops listening to Ctrl-C/interrupt
requests if you disconnect and reconnect back.

Dmitry wrote:

~~~
Currently gdbserver installs SIGIO handler just once, in
initialize_async_io() called from captured_main(), and this handler is
removed when remote_desc is closed in remote_close().  Next, when a
new instance of remote_desc is fetched from accept() and has '\003'
arrived, input_interrupt() is never called because it is not
registered as SIGIO handler.
~~~

The fix here is not remove the SIGIO handler in the first place, thus
going back to the original before-first-connection state.

(I haven't gone back to try it, but I think this was a regression
caused by commit 8b2073398477 ("[GDBserver] Block and unblock SIGIO"),
which was what made remote_close remove the signal handler.)

New test included.

gdb/gdbserver/ChangeLog:
2017-11-16  Pedro Alves  <palves@redhat.com>

	* remote-utils.c (remote_close): Block SIGIO signals instead of
	uninstalling the SIGIO handler.

gdb/testsuite/ChangeLog:
2017-11-16  Pedro Alves  <palves@redhat.com>

	* gdb.server/reconnect-ctrl-c.c: New file.
	* gdb.server/reconnect-ctrl-c.exp: New file.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Prevent illegal memory accesses when parsing incorrecctly formated core notes.
@ 2017-11-16 16:01 sergiodj+buildbot
  2017-11-16 20:20 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-16 16:01 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 80a0437873045cc08753fcac4af154e2931a99fd ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 80a0437873045cc08753fcac4af154e2931a99fd

Prevent illegal memory accesses when parsing incorrecctly formated core notes.

	PR 22421
	* elf.c (elfcore_grok_netbsd_procinfo): Check that the note is big enough.
	(elfcore_grok_openbsd_procinfo): Likewise.
	(elfcore_grok_nto_status): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add Python rbreak command.
@ 2017-11-16 15:04 sergiodj+buildbot
  2017-11-16 19:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-16 15:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d8ae99a7b08e29e31446aee1e47e59943d7d9926 ***

Author: Phil Muldoon <pmuldoon@redhat.com>
Branch: master
Commit: d8ae99a7b08e29e31446aee1e47e59943d7d9926

Add Python rbreak command.

gdb/Changelog

2017-11-16  Phil Muldoon  <pmuldoon@redhat.com>

	* python/python.c (gdbpy_rbreak): New function.
        * NEWS: Document Python rbreak feature.

testsuite/Changelog

2017-11-16  Phil Muldoon  <pmuldoon@redhat.com>

	* gdb.python/py-rbreak.exp: New file.
	* gdb.python/py-rbreak.c: New file.
	* gdb.python/py-rbreak-func2.c: New file.

doc/Changelog

2017-11-16  Phil Muldoon  <pmuldoon@redhat.com>

	* python.texi (Basic Python): Add rbreak documentation.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Prevent a possible seg-fault in the section merging code, by always creating a padding buffer.
@ 2017-11-16 15:02 sergiodj+buildbot
  2017-11-16 17:54 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-16 15:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 38b28f7088057d70497de7312cd983ec8e408a76 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 38b28f7088057d70497de7312cd983ec8e408a76

Prevent a possible seg-fault in the section merging code, by always creating a padding buffer.

	* merge.c (sec_merge_emit): Always create padding buffer.  Add
	asserts to make sure that the buffer is long enough.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix gdb.base/starti.exp racy test
@ 2017-11-16 13:23 sergiodj+buildbot
  2017-11-16 15:03 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-16 13:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 968a13f8362072b5f7eae8584d490b53d7f97ca5 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 968a13f8362072b5f7eae8584d490b53d7f97ca5

Fix gdb.base/starti.exp racy test

This commit fixes a couple problems with gdb.base/starti.exp, causing
spurious FAILs.

The first is a double-prompt problem:

~~~
 (gdb) PASS: gdb.base/starti.exp: hook-stop
 starti
 [....]
 gdb_expect_list pattern: /\$1 = 0/
 $1 = 0

 gdb_expect_list pattern: //
 0x00007ffff7ddcc80 in _start () from /lib64/ld-linux-x86-64.so.2

 (gdb)                                         # EXPECTED PROMPT
 (gdb) PASS: gdb.base/starti.exp: starti       # ANOTHER PROMPT!
 break main
~~~

This happens because the test uses gdb_test_sequence with no command,
like this:

 gdb_test_sequence "" "starti" {
     "Program stopped."
     "\\$1 = 0"
 }

but gdb_test_sequence doesn't have a check for empty command like
gdb_test_multiple does, and so sends "\n" to GDB:

 proc gdb_test_sequence { command test_name expected_output_list } {
     global gdb_prompt
     if { $test_name == "" } {
	 set test_name $command
     }
     lappend expected_output_list ""; # implicit ".*" before gdb prompt
     send_gdb "$command\n"
     return [gdb_expect_list $test_name "$gdb_prompt $" $expected_output_list]
 }

"starti" is a no-repeat command, so pressing <ret> just makes another
prompt appear, confusing the following gdb_test/gdb_test_multiple/etc.

Even with that fixed, the testcase is still racy though.

The second problem is that sometimes the "continue" test times out
here:

~~~
 continue
 Continuing.
 $2 = 1


 gdb_expect_list pattern: /.*Breakpoint .*main \(\) at .*starti.c.*/
 Breakpoint 1, main () at /home/pedro/src/gdb/testsuite/gdb.base/starti.c:29
 29	  return 0;
 (gdb) gdb_expect_list pattern: //
 * hung here *
~~~

The problem is that the too-greedy ".*" trailing match in
gdb_expect_list's pattern ends up consuming GDB's prompt too soon.
Fix that by removing the unnecessary trailing ".*".  While at it,
remove all ".*"s to be stricter.

Tested on x86_64 GNU/Linux.

gdb/testsuite/ChangeLog:
2017-11-16  Pedro Alves  <palves@redhat.com>

	* gdb.base/starti.exp ("continue" test): Remove ".*"s from
	pattern.
	* lib/gdb.exp (gdb_test_sequence): Don't send empty command to
	GDB.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove non-linux tic6x target descriptions
@ 2017-11-16 11:40 sergiodj+buildbot
  2017-11-16 13:50 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-16 11:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c632b6456b1f220475fbf61f19ada28230449ff6 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: c632b6456b1f220475fbf61f19ada28230449ff6

Remove non-linux tic6x target descriptions

They are not used by GDB nor by GDBserver.  This patch removes them.

gdb:

2017-11-16  Yao Qi  <yao.qi@linaro.org>

	* features/tic6x-c62x.xml: Remove.
	* features/tic6x-c64x.xml: Remove.
	* features/tic6x-c64xp.xml: Remove.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix tic6x-uclinux GDBserver build failure
@ 2017-11-16 10:28 sergiodj+buildbot
  2017-11-16 10:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-16 10:28 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3491a34c4f7de10dbd19c719052642d8471c45a6 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 3491a34c4f7de10dbd19c719052642d8471c45a6

Fix tic6x-uclinux GDBserver build failure

I can't find a c6x-uclinux c++ compiler, so I use my host g++ to build
tic6x-uclinux GDBserver, and find the following build failures.  They are
not target specific, so I believe they are real errors.  This patch fixes
them.

../binutils-gdb/gdb/gdbserver/linux-tic6x-low.c:313:34: error: invalid
conversion from 'void*' to 'tic6x_register*' [-fpermissive]
   union tic6x_register *regset = buf;
                                  ^
../binutils-gdb/gdb/gdbserver/linux-tic6x-low.c: In function 'void tic6x_store_gregset(regcache*, const void*)':
../binutils-gdb/gdb/gdbserver/linux-tic6x-low.c:324:40: error: invalid
conversion from 'const void*' to 'const tic6x_register*' [-fpermissive]
   const union tic6x_register *regset = buf;
                                        ^

../binutils-gdb/gdb/gdbserver/linux-tic6x-low.c: At global scope:
../binutils-gdb/gdb/gdbserver/linux-tic6x-low.c:359:28: error: redefinition of 'usrregs_info tic6x_usrregs_info'
 static struct usrregs_info tic6x_usrregs_info =
                            ^
../binutils-gdb/gdb/gdbserver/linux-tic6x-low.c:186:28: note: 'usrregs_info tic6x_usrregs_info' previously declared here
 static struct usrregs_info tic6x_usrregs_info;
                            ^

gdb/gdbserver:

2017-11-16  Yao Qi  <yao.qi@linaro.org>

	* linux-tic6x-low.c (tic6x_fill_gregset): Cast buf.
	(tic6x_store_gregset): Likewise.
	(tic6x_usrregs_info): Move it up.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Include <array> to declare std::array<>.
@ 2017-11-15 21:02 sergiodj+buildbot
  2017-11-16  2:08 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-15 21:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a014b87a9ac665d2b92cfc66384d1af3ddd345dd ***

Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: a014b87a9ac665d2b92cfc66384d1af3ddd345dd

Include <array> to declare std::array<>.

gdb/ChangeLog:

	* symtab.h: Include <array>.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Separate the new FP16 instructions backported from Armv8.4-a to Armv8.2-a into a new flag order to distinguish them from the rest of the already existing optional FP16 instructions in Armv8.2-a.
@ 2017-11-15 17:36 sergiodj+buildbot
  2017-11-15 21:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-15 17:36 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 01f48020363f1ca9b31df2ee0b2afedc38db1259 ***

Author: Tamar Christina <tamar.christina@arm.com>
Branch: master
Commit: 01f48020363f1ca9b31df2ee0b2afedc38db1259

Separate the new FP16 instructions backported from Armv8.4-a to Armv8.2-a into a new flag order to distinguish them from the rest of the already existing optional FP16 instructions in Armv8.2-a.

The new flag "+fp16fml" is available from Armv8.2-a and implies +fp16 and is mandatory
from Armv8.4-a.

gas/

	* config/tc-arm.c (arm_ext_fp16_fml, fp16fml): New.
	(do_neon_fmac_maybe_scalar_long): Use arm_ext_fp16_fml.
	* doc/c-arm.texi (fp16, fp16fml): New.
	* testsuite/gas/arm/armv8_2-a-fp16.d (fp16): Make fp16fml.
	* testsuite/gas/arm/armv8_3-a-fp16.d (fp16): Make fp16fml.
	* testsuite/gas/arm/armv8_2-a-fp16-illegal.d (fp16): Make fp16fml.
	* testsuite/gas/arm/armv8_2-a-fp16-thumb2.d (fp16): Make fp16fml.

include/

	* opcode/arm.h: (ARM_EXT2_FP16_FML): New.
	(ARM_AEXT2_V8_4A): Add ARM_EXT2_FP16_FML.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove no-longer applicable maintainer entries
@ 2017-11-15 16:19 sergiodj+buildbot
  2017-11-15 19:58 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-15 16:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c0c11fa91dbbf91b9c9d04384fe9f3ef5a6e7145 ***

Author: Andrew Cagney <cagney@gnu.org>
Branch: master
Commit: c0c11fa91dbbf91b9c9d04384fe9f3ef5a6e7145

Remove no-longer applicable maintainer entries

2017-11-15  Andrew Cagney  <cagney@gnu.org>

       * MAINTAINERS: Remove no-longer applicable entries.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Move self to Past Maintainers.
@ 2017-11-15 15:43 sergiodj+buildbot
  2017-11-15 18:45 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-15 15:43 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 34a7ebaff9e522913afba4e9cac9d8d5064e5480 ***

Author: Andrew Cagney <cagney@gnu.org>
Branch: master
Commit: 34a7ebaff9e522913afba4e9cac9d8d5064e5480

Move self to Past Maintainers.

2017-11-15  Andrew Cagney  <cagney@gnu.org>

      * MAINTAINERS: Move self to Past Maintainers.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Handle ' and I format flags
@ 2017-11-15 12:22 sergiodj+buildbot
  2017-11-15 15:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-15 12:22 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a5065160868895e91cac8515263d9783f8120818 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: a5065160868895e91cac8515263d9783f8120818

Handle ' and I format flags

Also a little tidying and error checking.

	* bfd.c (union _bfd_doprnt_args): Add "Bad".
	(_bfd_doprnt): Handle more flags.
	(_bfd_doprnt_scan): Likewise.  Tidy setting of args array.
	(error_handler_internal): Init args type to Bad.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix mem region parsing regression and add test
@ 2017-11-14 22:03 sergiodj+buildbot
  2017-11-14 22:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-14 22:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 074319087452e3a8b1a0e84279a82555dd798d69 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 074319087452e3a8b1a0e84279a82555dd798d69

Fix mem region parsing regression and add test

In my patch

  Get rid of VEC (mem_region)
  a664f67e50eff30198097d51cec0ec4690abb2a1

I introduced a regression, where the length of the memory region is
assigned to the "hi" field.  It should obviously be computed as "start +
length".  To my defense, no test had caught this :).  As a penance, I
wrote one.

gdb/ChangeLog:

	* Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
	memory-map-selftests.c.
	(SUBDIR_UNITTESTS_OBS): Add memory-map-selftests.o.
	* memory-map.c (memory_map_start_memory): Fix computation of hi
	address.
	* unittests/memory-map-selftests.c: New file.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR22431, powerpc64 ld segfault when .plt discarded
@ 2017-11-14 10:49 sergiodj+buildbot
  2017-11-14 12:30 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-14 10:49 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 06bcf5416feae129e239476ab1408e038bba171d ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 06bcf5416feae129e239476ab1408e038bba171d

PR22431, powerpc64 ld segfault when .plt discarded

The fix for the PR is to not use input_section->output_section->owner
to get to the output bfd, but use the output bfd directly since it is
available nowadays in struct bfd_link_info.

I thought it worth warning when non-empty dynamic sections are
discarded too, which meant a tweak to one of the ld tests to avoid the
warning.

bfd/
	PR 22431
	* elf64-ppc.c (ppc64_elf_size_dynamic_sections): Warn on discarding
	non-empty dynamic section.
	(ppc_build_one_stub): Take elf_gp from output bfd, not output
	section owner.
	(ppc_size_one_stub, ppc64_elf_next_toc_section): Likewise.
ld/
	* testsuite/ld-elf/note-3.t: Don't discard .got.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: add support for AVX-512 VPCMP*{B,W} pseudo-ops
@ 2017-11-14  9:06 sergiodj+buildbot
  2017-11-14  9:45 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-14  9:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2645e1d0798da9487def06d14bb744c33dba702d ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 2645e1d0798da9487def06d14bb744c33dba702d

x86: add support for AVX-512 VPCMP*{B,W} pseudo-ops

... matching up with VPCMP*{D,Q}.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Inconsistent .eh_frame_hdr on powerpc64
@ 2017-11-14  5:41 sergiodj+buildbot
  2017-11-14  5:45 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-14  5:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2d0d44d514d9a2e2b0f7ae8129d52b02160c9897 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 2d0d44d514d9a2e2b0f7ae8129d52b02160c9897

Inconsistent .eh_frame_hdr on powerpc64

There is code in bfd/elf-eh-frame.c and ld/emultempl/elf32.em that
checks for the presence of eh_frame info by testing for a section
named .eh_frame sized more than 8 bytes.   The size test is to exclude
a zero terminator.  A similar check in elf64-ppc.c wrongly just tested
for non-zero size before creating the linker generated .eh_frame
describing plt call and other linkage stubs.  The intention was to not
generate that info unless there was some user .eh_frame.  (No user
.eh_frame implies the user doesn't care about exception handling.)
Because the test in elf64-ppc.c was wrong, ld generated the stub
.eh_frame just on finding a zero .eh_frame terminator in crtend.o, but
didn't generate the corresponding .eh_frame_hdr.

	* elf64-ppc.c (ppc64_elf_size_stubs): Correct test for user
	.eh_frame info.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PE: don't corrupt section flags when linking from ELF objects
@ 2017-11-13 12:03 sergiodj+buildbot
  2017-11-13 13:11 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-13 12:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5be87c8fa74c9ae6684bea571b4157ad1966d008 ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 5be87c8fa74c9ae6684bea571b4157ad1966d008

PE: don't corrupt section flags when linking from ELF objects

Linking EFI executables from ELF object files can result in corrupted
COFF section flags if the section's alignment is too high. Issue a
diagnostic in that case, erroring out if this is not a final link, and
make sure only in-range values get written to the output image.

While doing this also make tic80 use the generic alignment macros
instead of custom #ifdef-ary.

No testsuite regressions for the range of COFF/PE targets that actually
cross-build in the first place on x86-64-linux.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: {f, }xsave64 / {f, }xrstor64 / xsaveopt64 should not allow q suffix
@ 2017-11-13 11:44 sergiodj+buildbot
  2017-11-13 11:57 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-13 11:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 897e603cb98c50968ea21d1b3baac5bc020ccc06 ***

Author: Jan Beulich <jbeulich@novell.com>
Branch: master
Commit: 897e603cb98c50968ea21d1b3baac5bc020ccc06

x86: {f,}xsave64 / {f,}xrstor64 / xsaveopt64 should not allow q suffix

Just like is the case for xsave{s,c}64 and xrstors64 already. I wonder
though why xsave{s,c} and xrstors don't allow for the q suffix, other
than the other insns without the "64" suffix do.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] weakdef list handling
@ 2017-11-12 10:49 sergiodj+buildbot
  2017-11-12 13:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-12 10:49 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e3e53eed9c2f1ab82ae4a7683f474b4f6eb162c7 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: e3e53eed9c2f1ab82ae4a7683f474b4f6eb162c7

weakdef list handling

The existing code allowed common and indirect symbols to pass an
assert, but then read root.u.def which is not valid for anything
besides defined and weakdef symbols.  The garbage root.u.def.section
pointer read can't possibly match pointers stored at the same location
for indirect and common symbols, so we would always have left
u.weakdef NULL.

	* elflink.c (elf_link_add_object_symbols): Ignore anything but
	defined and defweak symbols when setting up weakdefs.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] non_got_ref after adjust_dynamic_relocs
@ 2017-11-12 10:14 sergiodj+buildbot
  2017-11-12 11:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-12 10:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 529fe20eeb0030ea5d653d0ebec433f9e3145874 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 529fe20eeb0030ea5d653d0ebec433f9e3145874

non_got_ref after adjust_dynamic_relocs

This patch was aimed at a FIXME in elf32-hppa.c, the ludicrous and
confusing fact that non_got_ref after adjust_dynamic_relocs in that
backend means precisely the inverse of what it means before
adjust_dynamic_relocs.  Before, when non_got_ref is set it means there
are dynamic relocs, after, if non_got_ref is clear it means "keep
dynamic relocs" and later, "has dynamic relocs".  There is a reason
why it was done that way..  Some symbols that may have dynamic
relocations pre-allocated in check_relocs turn out to not be dynamic,
and then are not seen by the backend adjust_dynamic_symbols.  We want
those symbols to lose their dynamic relocs when non-pic, so it's handy
that non_got_ref means the opposite after adjust_dynamic_relocs.  But
it's really confusing.

Most other targets, like ppc32, don't always set non_got_ref on
non-GOT references that have dynamic relocations.  This is because the
primary purpose of non_got_ref before adjust_dynamic_relocs is to flag
symbols that might need to be copied to .dynbss, and there are
relocation types that may require dyn_relocs but clearly cannot have
symbols copied into .dynbss, for example, TLS relocations.

Why do we need a flag after adjust_dynamic_relocs to say "keep
dynamic relocations"?  Well, you can discard most unwanted dyn_relocs
in the backend adjust_dynamic_relocs, and for those symbols that
aren't seen by the backend adjust_dynamic_relocs, in
allocate_dynrelocs based on a flag set by adjust_dynamic relocs,
dynamic_adjusted.  That doesn't solve all our difficulties though.
relocate_section needs to know whether a symbol has dyn_relocs, and
many targets transfer dyn_relocs to a weakdef if the symbol has one.
The transfer means relocate_section can't test dyn_relocs itself and
the weakdef field has been overwritten by that time.  So non_got_ref
is used to flag "this symbol has dynamic relocations" for
relocate_section.

Confused still?  Well, let's hope the comments I've added help clarify
things..  The patch also fixes a case where we might wrongly emit
dynamic relocations in an executable for common and undefined symbols.

	* elf32-hppa.c (elf32_hppa_adjust_dynamic_symbol): Set non_got_ref
	to keep dyn_relocs, clear to discard.  Comment.
	(allocate_dynrelocs): Always clear non_got_ref when clearing
	dyn_relocs in non-pic case.  Invert non_got_ref test.  Also test
	dynamic_adjusted and ELF_COMMON_DEF_P.  Move code deleting
	dyn_relocs on undefined syms to handle for non-pic too.
	(elf32_hppa_relocate_section): Simplify test for non-pic dyn relocs.
	* elf32-ppc.c (ppc_elf_adjust_dynamic_symbol): Set non_got_ref
	to keep dyn_relocs, clear to discard.  Comment.
	(allocate_dynrelocs): Always clear non_got_ref when clearing
	dyn_relocs in non-pic case.  Invert non_got_ref test.  Also test
	dynamic_adjusted and ELF_COMMON_DEF_P.  Move code deleting
	dyn_relocs on undefined syms to handle for non-pic too.
	(ppc_elf_relocate_section): Simplify test for non-pic dyn relocs.
	* elf64-ppc.c (ppc64_elf_adjust_dynamic_symbol): Discard
	dyn_relocs here.  Don't bother setting non_got_ref.  Comment.
	(allocate_dynrelocs): Delete special handling of non-pic ELFv2
	ifuncs.  Move code deleting dyn_relocs on undefined symbols to
	handle for non-pic too.  Don't test non_got_ref.  Do test
	dynamic_adjusted and ELF_COMMON_DEF_P.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix racy output matching in gdb.tui/tui-completion.exp
@ 2017-11-10  1:39 sergiodj+buildbot
  2017-11-10  9:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-10  1:39 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 584a564f366de16d1cecd1910ab0be8ca6167415 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 584a564f366de16d1cecd1910ab0be8ca6167415

Fix racy output matching in gdb.tui/tui-completion.exp

'make check-read1 TESTS="gdb.tui/tui-completion.exp"' exposes this test race:

  (gdb) PASS: gdb.tui/completion.exp: set max-completions unlimited
  layout ^G
  asm    next   prev   regs   split  src
  (gdb) FAIL: gdb.tui/completion.exp: completion of layout names: tab completion
  Quit
  (gdb) PASS: gdb.tui/completion.exp: completion of layout names: quit command input
  focus ^G
  cmd   next  prev  src
  (gdb) FAIL: gdb.tui/completion.exp: completion of focus command: tab completion
  Quit

This is caused by expecting "$gdb_prompt layout $".
gdb_test_multiple's internal prompt regexp can match first if expect's
internal buffer is filled with partial output.  Fix that by splitting
the gdb_test_multiple in question in two.  Since the same problem/code
appears twice in the file, factor out a common procedure.

gdb/testsuite/ChangeLog:
2017-11-09  Pedro Alves  <palves@redhat.com>

	* gdb.tui/tui-completion.exp (test_tab_completion): New procedure,
	factored out from ...
	(top level): ... here, and adjusted to avoid expecting beyond the
	prompt in a single gdb_test_multiple.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix racy output matching in gdb.base/memattr.exp
@ 2017-11-10  0:28 sergiodj+buildbot
  2017-11-10  5:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-10  0:28 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2c88253fc469fbf40be7f0d1f7060b81055f2eb1 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 2c88253fc469fbf40be7f0d1f7060b81055f2eb1

Fix racy output matching in gdb.base/memattr.exp

Testing with:
 $ make check-read1 TESTS="gdb.base/memattr.exp"


Exposes a testcase bug that can result in racy fails:

  info mem
  Using user-defined memory regions.
  Num Enb Low Addr           High Addr          Attrs
  1   y   0x0000000000601060 0x0000000000601160 wo nocache
  2   y   0x0000000000601180 0x0000000000601280 ro nocache
  4   y   0x0000000000601280 0x0000000000601380 rw nocache
  3   y   0x0000000000601380 0x0000000000601480 rw nocache
  5   y   0x0000000000601480 0x0000000000601580 rw nocache
  (gdb) FAIL: gdb.base/memattr.exp: info mem (1)

The problem is that:

  "Attrs\[^\n\r]*.."

matches:

  "Attrs \r"

when the output buffer is filled with partial output like this:

  "info mem\r\nUsing user-defined memory regions.\r\nNum Enb Low Addr           High Addr          Attrs \r"

gdb/testsuite/ChangeLog:
2017-11-09  Pedro Alves  <palves@redhat.com>

	* gdb.base/memattr.exp: Tighten regexes to match the end line.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix racy output matching in gdb.base/completion.exp
@ 2017-11-09 23:46 sergiodj+buildbot
  2017-11-10  4:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-09 23:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c7a3851716f98540396b9e02be7d2fcd3bff2d29 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: c7a3851716f98540396b9e02be7d2fcd3bff2d29

Fix racy output matching in gdb.base/completion.exp

Testing with:
 $ make check-read1 TESTS="gdb.base/completion.exp"

Exposes a testcase bug that can result in racy fails:

  FAIL: gdb.base/completion.exp: command-name completion limiting using tab character
  ERROR: Undefined command "".
  FAIL: gdb.base/completion.exp: symbol-name completion limiting using tab character
  FAIL: gdb.base/completion.exp: symbol-name completion limiting using complete command

testsuite/gdb.log shows:

  (gdb) PASS: gdb.base/completion.exp: set max-completions 5
  p^G
  passcount     path          print         print-object  printf
  *** List may be truncated, max-completions reached. ***
  (gdb) FAIL: gdb.base/completion.exp: command-name completion limiting using tab character
  pcomplete p
  Undefined command: "pcomplete".  Try "help".
  (gdb) ERROR: Undefined command "".

The problem is that the expect buffer can get filled with partial
output that ends in the gdb prompt, and so the default FAIL inside
gdb_test_multiple matches.

Fix that by splitting the gdb_test_multiple in two stages.  Since that
is done in more than one place in the testcase, move the otherwise
duplicate code to helper procedures.

gdb/testsuite/ChangeLog:
2017-11-09  Pedro Alves  <palves@redhat.com>

	* gdb.base/completion.exp (ignore_and_resync, test_tab_complete):
	New procedures, factored out from ...
	(top level): ... here, and adjusted to avoid expecting beyond the
	prompt in one go.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] fix typos in ada-lang.c comment
@ 2017-11-09 20:24 sergiodj+buildbot
  2017-11-10  1:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-09 20:24 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 31432a672fd40058a714eb2791ea1c3168ccc4f1 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 31432a672fd40058a714eb2791ea1c3168ccc4f1

fix typos in ada-lang.c comment

gdb/ChangeLog:

        * ada-lang.c: Fix some typos in the general command documenting
        how Ada expressions are being evaluated and how their result
        is printed.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Enable the Dot Product extension by default for Armv8.4-a.
@ 2017-11-09 20:04 sergiodj+buildbot
  2017-11-10  0:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-09 20:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 981b557a488f7c3179dee1e34515ca9b10cf885c ***

Author: Tamar Christina <tamar.christina@arm.com>
Branch: master
Commit: 981b557a488f7c3179dee1e34515ca9b10cf885c

Enable the Dot Product extension by default for Armv8.4-a.

include/

	* opcode/aarch64.h (AARCH64_ARCH_V8_4): Enable DOTPROD.

gas/testsuite

	* gas/aarch64/dotproduct_armv8_4.s: New.
	* gas/aarch64/dotproduct_armv8_4.d: New.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add the operand encoding types for the new Armv8.2-a back-ported instructions. These are to be used later when the new instructions are added.
@ 2017-11-09 17:55 sergiodj+buildbot
  2017-11-09 21:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-09 17:55 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1a7ed57c840dcb0401f1a67c6763a89f7d2686d2 ***

Author: Tamar Christina <tamar.christina@arm.com>
Branch: master
Commit: 1a7ed57c840dcb0401f1a67c6763a89f7d2686d2

Add the operand encoding types for the new Armv8.2-a back-ported instructions. These are to be used later when the new instructions are added.

opcodes/
	* aarch64-tbl.h (QL_SHA512UPT, QL_V2SAME2D, QL_V3SAME2D): New.
	(QL_V4SAME16B, QL_V4SAME4S, QL_XAR, QL_SM3TT, QL_V3FML2S): New.
	(QL_V3FML4S, QL_V2FML2S, QL_V2FML4S, QL_RMIF, QL_SETF): New.
	(QL_STLW, QL_STLX): New.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Adds the new Fields and Operand types for the new instructions in Armv8.4-a.
@ 2017-11-09 17:04 sergiodj+buildbot
  2017-11-09 19:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-09 17:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f42f1a1d6ca0cc84e43d7f2b85044a2565ca00f2 ***

Author: Tamar Christina <tamar.christina@arm.com>
Branch: master
Commit: f42f1a1d6ca0cc84e43d7f2b85044a2565ca00f2

Adds the new Fields and Operand types for the new instructions in Armv8.4-a.

gas/
	* config/tc-aarch64.c (process_omitted_operand):
	Add AARCH64_OPND_Va, AARCH64_OPND_SM3_IMM2
	and AARCH64_OPND_IMM_2.
	(parse_operands): Add AARCH64_OPND_Va, AARCH64_OPND_SM3_IMM2,
	AARCH64_OPND_IMM_2, AARCH64_OPND_MASK
	and AARCH64_OPND_ADDR_OFFSET.

include/
	* opcode/aarch64.h:
	(aarch64_opnd): Add AARCH64_OPND_Va, AARCH64_OPND_MASK,
	AARCH64_OPND_IMM_2, AARCH64_OPND_ADDR_OFFSET
	and AARCH64_OPND_SM3_IMM2.
	(aarch64_insn_class): Add cryptosm3 and cryptosm4.
	(arch64_feature_set): Make uint64_t.

opcodes/
	* aarch64-asm.h (ins_addr_offset): New.
	* aarch64-asm.c (aarch64_ins_reglane): Add cryptosm3.
	(aarch64_ins_addr_offset): New.
	* aarch64-asm-2.c: Regenerate.
	* aarch64-dis.h (ext_addr_offset): New.
	* aarch64-dis.c (aarch64_ext_reglane): Add cryptosm3.
	(aarch64_ext_addr_offset): New.
	* aarch64-dis-2.c: Regenerate.
	* aarch64-opc.h (aarch64_field_kind): Add FLD_imm6_2,
	FLD_imm4_2 and FLD_SM3_imm2.
	* aarch64-opc.c (fields): Add FLD_imm6_2,
	FLD_imm4_2 and FLD_SM3_imm2.
	(operand_general_constraint_met_p): Add AARCH64_OPND_ADDR_OFFSET.
	(aarch64_print_operand): Add AARCH64_OPND_Va, AARCH64_OPND_SM3_IMM2,
	AARCH64_OPND_MASK, AARCH64_OPND_IMM_2 and AARCH64_OPND_ADDR_OFFSET.
	* aarch64-opc-2.c (Va, MASK, IMM_2, ADDR_OFFSET, SM3_IMM2): New.
	* aarch64-tbl.h
	(aarch64_opcode_table): Add Va, MASK, IMM_2, ADDR_OFFSET, SM3_IMM2.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Split the ARM Crypto ISA extensions for AES and SHA1+2 into their own options (+aes and +sha2). The reason for the split is because with the introduction of Armv8.4-a the implementation of AES has explicitly been made independent of the implementation of the other crypto extensions.
@ 2017-11-09 11:44 sergiodj+buildbot
  2017-11-09 12:22 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-09 11:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b6b9ca0c3ec9589d0dd40b2b86ba748a361b48eb ***

Author: Tamar Christina <tamar.christina@arm.com>
Branch: master
Commit: b6b9ca0c3ec9589d0dd40b2b86ba748a361b48eb

Split the ARM Crypto ISA extensions for AES and SHA1+2 into their own options (+aes and +sha2).  The reason for the split is because with the introduction of Armv8.4-a the implementation of AES has explicitly been made independent of the implementation of the other crypto extensions.

gas	* config/tc-aarch64.c (aarch64_arch_option_table): Add armv8.4-a.
	(aarch64_features):	Added SM4 and SHA3.

include	* opcode/aarch64.h:
	(AARCH64_FEATURE_V8_4, AARCH64_FEATURE_SM4): New.
	(AARCH64_ARCH_V8_4, AARCH64_FEATURE_SHA3): New.

opcodes	* aarch64-tbl.h
	(aarch64_feature_v8_4, aarch64_feature_crypto_v8_2): New.
	(aarch64_feature_sm4, aarch64_feature_sha3): New.
	(aarch64_feature_fp_16_v8_2): New.
	(ARMV8_4, SHA3, SM4, CRYPTO_V8_2, FP_F16_V8_2): New.
	(V8_4_INSN, CRYPTO_V8_2_INSN): New.
	(SHA3_INSN, SM4_INSN, FP16_V8_2_INSN): New.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Constify add_setshow_*
@ 2017-11-08  1:18 sergiodj+buildbot
  2017-11-08 15:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-08  1:18 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT eb4c3f4aaae2ee1b27c210e951260a7e699133b4 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: eb4c3f4aaae2ee1b27c210e951260a7e699133b4

Constify add_setshow_*

This constifies the add_setshow_* family of functions, and then fixes
up the fallout.  The bulk of this patch was written by script.

gdb/ChangeLog
2017-11-07  Tom Tromey  <tom@tromey.com>

	* ada-lang.c (catch_ada_exception_command): Constify.
	(catch_assert_command): Constify.
	* break-catch-throw.c (catch_catch_command, catch_throw_command)
	(catch_rethrow_command): Constify.
	(catch_exception_command_1): Constify.
	* breakpoint.h (add_catch_command): Constify.
	* break-catch-syscall.c (catch_syscall_command_1): Constify.
	(catch_syscall_split_args): Constify.
	* break-catch-sig.c (catch_signal_command): Constify.
	(catch_signal_split_args): Constify.
	* cli/cli-decode.h (struct cmd_list_element) <function>: Use
	cmd_const_sfunc_ftype.
	* cli/cli-decode.c (add_setshow_cmd_full): Constify.
	(add_setshow_enum_cmd, add_setshow_auto_boolean_cmd)
	(add_setshow_boolean_cmd, add_setshow_filename_cmd)
	(add_setshow_string_cmd, struct cmd_list_element)
	(add_setshow_optional_filename_cmd, add_setshow_integer_cmd)
	(add_setshow_uinteger_cmd, add_setshow_zinteger_cmd)
	(add_setshow_zuinteger_unlimited_cmd, add_setshow_zuinteger_cmd):
	Constify.
	(set_cmd_sfunc): Constify.
	(empty_sfunc): Constify.
	* command.h (add_setshow_enum_cmd, add_setshow_auto_boolean_cmd)
	(add_setshow_boolean_cmd, add_setshow_filename_cmd)
	(add_setshow_string_cmd, add_setshow_string_noescape_cmd)
	(add_setshow_optional_filename_cmd, add_setshow_integer_cmd)
	(add_setshow_uinteger_cmd, add_setshow_zinteger_cmd)
	(add_setshow_zuinteger_cmd, add_setshow_zuinteger_unlimited_cmd):
	Constify.
	(set_cmd_sfunc): Constify.
	(cmd_sfunc_ftype): Remove.
	* compile/compile.c (set_compile_args): Constify.
	* infrun.c (set_disable_randomization): Constify.
	* infcmd.c (set_args_command, set_cwd_command): Constify.
	* breakpoint.c (set_condition_evaluation_mode): Constify.
	(add_catch_command): Constify.
	(catch_fork_command_1, catch_exec_command_1)
	(catch_load_command_1, catch_unload_command_1): Constify.
	(catch_load_or_unload): Constify.
	* guile/scm-param.c (pascm_set_func): Constify.
	(add_setshow_generic): Constify.
	* python/py-param.c (get_set_value): Constify.
	* top.h (set_verbose): Constify.
	* tui/tui-win.c (tui_set_var_cmd): Constify.
	* mi/mi-main.c (set_mi_async_command): Constify.
	* cli/cli-logging.c (set_logging_overwrite)
	(set_logging_redirect): Constify.
	* value.c (set_max_value_size): Constify.
	* valprint.c (set_input_radix, set_output_radix): Constify.
	* utils.c (set_width_command, set_height_command): Constify.
	* typeprint.c (set_print_type_methods, set_print_type_typedefs): Constify.
	* tracepoint.c (set_disconnected_tracing)
	(set_circular_trace_buffer, set_trace_buffer_size)
	(set_trace_user, set_trace_notes, set_trace_stop_notes): Constify.
	* top.c (set_history_size_command, set_verbose, set_editing)
	(set_gdb_datadir, set_history_filename): Constify.
	* target.c (set_targetdebug, maint_set_target_async_command)
	(maint_set_target_non_stop_command, set_target_permissions)
	(set_write_memory_permission): Constify.
	(open_target): Constify.
	* target-descriptions.c (set_tdesc_filename_cmd): Constify.
	* target-dcache.c (set_stack_cache, set_code_cache): Constify.
	* symtab.c (set_symbol_cache_size_handler): Constify.
	* symfile.c (set_ext_lang_command): Constify.
	* symfile-debug.c (set_debug_symfile): Constify.
	* source.c (set_directories_command): Constify.
	* solib.c (reload_shared_libraries, gdb_sysroot_changed): Constify.
	* serial.c (set_parity): Constify.
	* rs6000-tdep.c (powerpc_set_soft_float, powerpc_set_vector_abi): Constify.
	* remote.c (set_remote_exec_file, set_remotebreak)
	(set_remote_protocol_Z_packet_cmd, set_range_stepping): Constify.
	* record.c (set_record_insn_history_size)
	(set_record_call_history_size): Constify.
	* record-full.c (set_record_full_insn_max_num): Constify.
	* proc-api.c (set_procfs_trace_cmd, set_procfs_file_cmd): Constify.
	* osabi.c (set_osabi): Constify.
	* mips-tdep.c (set_mips64_transfers_32bit_regs)
	(reinit_frame_cache_sfunc, mips_abi_update): Constify.
	* maint.c (maintenance_set_profile_cmd): Constify.
	* linux-thread-db.c (set_libthread_db_search_path): Constify.
	* language.c (set_language_command, set_range_command)
	(set_case_command): Constify.
	* infrun.c (set_non_stop, set_observer_mode)
	(set_stop_on_solib_events, set_schedlock_func)
	(set_exec_direction_func): Constify.
	* infcmd.c (set_inferior_tty_command): Constify.
	* disasm.c (set_disassembler_options_sfunc): Constify.
	* demangle.c (set_demangling_command): Constify.
	* dcache.c (set_dcache_size, set_dcache_line_size): Constify.
	* cris-tdep.c (set_cris_version, set_cris_mode)
	(set_cris_dwarf2_cfi): Constify.
	* corefile.c (set_gnutarget_command): Constify.
	* charset.c (set_host_charset_sfunc, set_target_charset_sfunc)
	(set_target_wide_charset_sfunc): Constify.
	* breakpoint.c (update_dprintf_commands): Constify.
	* auto-load.c (set_auto_load_dir, set_auto_load_safe_path): Constify.
	* arm-tdep.c (set_fp_model_sfunc, arm_set_abi)
	(set_disassembly_style_sfunc): Constify.
	* arch-utils.c (set_endian, set_architecture): Constify.
	* alpha-tdep.c (reinit_frame_cache_sfunc): Constify.
	* agent.c (set_can_use_agent): Constify.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove cmd_cfunc_ftype
@ 2017-11-08  0:57 sergiodj+buildbot
  2017-11-08 14:22 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-08  0:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5fed81ff351121887a93b5b57caebb86667cbbd2 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 5fed81ff351121887a93b5b57caebb86667cbbd2

Remove cmd_cfunc_ftype

This removes cmd_cfunc_ftype and the non-const overload of add_cmd;
then fixes up the fallout.

For the most part this patch is straightforward.  There are a few
files (go32-nat.c, windows-nat.c, and gnu-nat.c) that I could not
compile; so I made a best effort there.

gdb/ChangeLog
2017-11-07  Tom Tromey  <tom@tromey.com>

	* go32-nat.c (go32_sysinfo, go32_sldt, go32_sgdt, go32_sidt)
	(go32_pde, go32_pte, go32_pte_for_address): Constify.
	* gnu-nat.c (_parse_bool_arg, show_thread_default_pause_cmd)
	(set_thread_default_pause_cmd, set_thread_default_run_cmd)
	(show_thread_default_run_cmd, set_thread_default_detach_sc_cmd)
	(parse_int_arg, show_thread_default_detach_sc_cmd)
	(set_signals_cmd, show_signals_cmd, set_sig_thread_cmd)
	(show_sig_thread_cmd, set_stopped_cmd, show_stopped_cmd)
	(set_exceptions_cmd, show_exceptions_cmd, set_task_pause_cmd)
	(show_task_pause_cmd, set_task_detach_sc_cmd)
	(show_task_detach_sc_cmd, set_task_exc_port_cmd)
	(set_noninvasive_cmd, set_thread_pause_cmd)
	(show_thread_pause_cmd, set_thread_run_cmd, show_thread_run_cmd)
	(set_thread_detach_sc_cmd, show_thread_detach_sc_cmd)
	(set_thread_exc_port_cmd, thread_takeover_sc_cmd): Constify.
	* windows-nat.c (display_selectors): Constify.
	* cli/cli-decode.h (struct cmd_list_element) <function>: Remove
	non-const "cfunc".
	* cli/cli-decode.c (set_cmd_cfunc): Remove non-const overload.
	(cmd_cfunc_eq): Likewise.
	(struct cmd_list_element): Likewise.
	(do_cfunc): Remove.
	(cli_user_command_p): Update.
	* command.h (add_cmd): Remove non-const overload.
	(cmd_cfunc_ftype): Remove typedef.
	(cmd_cfunc_eq): Remove non-const overload.
	* value.c (show_values): Constify.
	* thread.c (thread_apply_all_command): Constify.
	* symfile.c (load_command): Constify.
	* source.c (directory_command): Constify.
	* maint.c (maintenance_internal_error)
	(maintenance_demangler_warning, maintenance_space_display)
	(maintenance_print_architecture, maintenance_translate_address)
	(maintenance_info_selftests, maintenance_internal_warning):
	Constify.
	* breakpoint.c (disable_trace_command, enable_trace_command):
	Constify.
	* auto-load.c (info_auto_load_local_gdbinit, add_auto_load_dir):
	Constify.
	(add_auto_load_safe_path): Constify.
	* guile/scm-auto-load.c (info_auto_load_guile_scripts): Constify.
	* top.h (show_commands): Constify.
	* linux-thread-db.c (info_auto_load_libthread_db): Constify.
	* sparc64-tdep.c (adi_examine_command): Constify.
	(adi_assign_command): Constify.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Constify add_path and friends
@ 2017-11-07 23:28 sergiodj+buildbot
  2017-11-08  8:58 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-07 23:28 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5614fb77203f5ea01edfb2d739e9d4f3d570dc09 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 5614fb77203f5ea01edfb2d739e9d4f3d570dc09

Constify add_path and friends

This constifies add_path, mod_path, and directory_switch.

gdb/ChangeLog
2017-11-07  Tom Tromey  <tom@tromey.com>

	* source.c (directory_switch, mod_path, add_path): Constify.
	* defs.h (add_path, mod_path, directory_switch): Constify.
	* mi/mi-cmd-env.c (env_mod_path): Constify.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make set_cmd_cfunc private
@ 2017-11-07 22:18 sergiodj+buildbot
  2017-11-08  6:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-07 22:18 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c2252c0dd8dcf3bb95598149aecd3158e89c31d7 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: c2252c0dd8dcf3bb95598149aecd3158e89c31d7

Make set_cmd_cfunc private

set_cmd_cfunc is only used in cli-decode.c, and I don't think there is
a good reason to expose it directly.  So, this patch makes it private.

gdb/ChangeLog
2017-11-07  Tom Tromey  <tom@tromey.com>

	* command.h (set_cmd_cfunc): Don't declare.
	* cli/cli-decode.c (set_cmd_cfunc): Now static.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Constify add_abbrev_prefix_cmd
@ 2017-11-07 21:27 sergiodj+buildbot
  2017-11-08  4:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-07 21:27 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ee7ddd713206fdf02512a9fb3fe928a210200c11 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: ee7ddd713206fdf02512a9fb3fe928a210200c11

Constify add_abbrev_prefix_cmd

This changes add_abbrev_prefix_cmd to take a const-taking callback
function and then fixes the one caller.

gdb/ChangeLog
2017-11-07  Tom Tromey  <tom@tromey.com>

	* breakpoint.c (stop_command): Constify.
	* cli/cli-decode.c (struct cmd_list_element): Constify.
	* command.h (add_abbrev_prefix_cmd): Constify.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] opcodes/arc: Fix incorrect insn_class for some nps insns
@ 2017-11-07 20:49 sergiodj+buildbot
  2017-11-08  2:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-07 20:49 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 52eab766df54915f8d3d71475235868285c4ca82 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 52eab766df54915f8d3d71475235868285c4ca82

opcodes/arc: Fix incorrect insn_class for some nps insns

A small number of NPS400 instruction incorrectly used NONE as an
insn_class_t, which would trigger a build warning.  Fixed by changing to
MISC.

opcodes/ChangeLog:

	* arc-nps400-tbl.h: Change incorrect use of NONE to MISC.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] RISC-V: Add satp as an alias for sptbr
@ 2017-11-07 17:23 sergiodj+buildbot
  2017-11-08  1:06 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-07 17:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1270b047fdc68d89f05668ed919d17f5fceeba2a ***

Author: Palmer Dabbelt <palmer@dabbelt.com>
Branch: master
Commit: 1270b047fdc68d89f05668ed919d17f5fceeba2a

RISC-V: Add satp as an alias for sptbr

The RISC-V privileged ISA changed the name of sptbr (Supervisor Page
Table Base Register) to satp (Supervisor Address Translation and
Protection) to reflect the fact it could be used for more than just
paging.  This patch adds an alias, as they're the same register.

include/ChangeLog

2017-11-06  Palmer Dabbelt  <palmer@dabbelt.com>

        * opcode/riscv-opc.h (sptbr): Rename to satp.
        (CSR_SPTBR): Rename to CSR_SATP.
        (sptbr): Alias to CSR_SATP.

gas/ChangeLog

2017-11-06  Palmer Dabbelt  <palmer@dabbelt.com>

        * testsuite/gas/riscv/satp.d: New test.
        testsuite/gas/riscv/satp.s: Likewise.
        testsuite/gas/riscv/riscv.exp: Likewise.
        config/tc-riscv.c (md_begin): Handle CSR aliases.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add some more breakpoint/location range tests
@ 2017-11-07 14:20 sergiodj+buildbot
  2017-11-07 23:54 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-07 14:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a02b41a7e604471e584dc2151fbd36714842710e ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: a02b41a7e604471e584dc2151fbd36714842710e

Add some more breakpoint/location range tests

Some extra thoroughness tests that I had over here.

gdb/testsuite/ChangeLog:
2017-11-07  Pedro Alves  <palves@redhat.com>

	* gdb.cp/ena-dis-br-range.exp: Add more tests.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make breakpoint/location number parsing error output consistent
@ 2017-11-07 13:35 sergiodj+buildbot
  2017-11-07 22:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-07 13:35 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 95e95a6de2e4a050870c49bf52fbac0239847b63 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 95e95a6de2e4a050870c49bf52fbac0239847b63

Make breakpoint/location number parsing error output consistent

... and also make GDB catch a few more cases of invalid input.

This fixes the inconsistency in GDB's output (e.g., "bad" vs "Bad")
exposed by the new tests added in the previous commit.

Also, makes the "0-0" and "inverted range" cases be loud errors.

Also makes GDB reject negative breakpoint number in ranges.  We
already rejected negative number literals, but you could still subvert
that via convenience variables, like:

  (gdb) set $bp -1
  (gdb) disable $bp.1-2

The change to get_number_trailer fixes a bug exposed by the new tests.
The function did not handle parsing "-$num".  [This wasn't visible in
the gdb.multi/tids.exp (which has similar tests) because the TID range
parsing is implemented differently.]

gdb/ChangeLog:
2017-11-07  Pedro Alves  <palves@redhat.com>

	* breakpoint.c (extract_bp_kind): New enum.
	(extract_bp_num, extract_bp_or_bp_range): New functions, partially
	factored out from ...
	(extract_bp_number_and_location): ... here.
	* cli/cli-utils.c (get_number_trailer): Handle '-$variable'.

gdb/testsuite/ChangeLog:
2017-11-07  Pedro Alves  <palves@redhat.com>

	* gdb.base/ena-dis-br.exp (test_ena_dis_br): Adjust test.
	* gdb.cp/ena-dis-br-range.exp: Adjust tests.
	(disable_invalid, disable_inverted, disable_negative): New
	procedures.
	("bad numbers"): New set of tests.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Breakpoint location parsing: always error instead of warning
@ 2017-11-07 12:09 sergiodj+buildbot
  2017-11-07 20:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-07 12:09 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cc638e867c240546b4dbc791761099d3ca5fe4a9 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: cc638e867c240546b4dbc791761099d3ca5fe4a9

Breakpoint location parsing: always error instead of warning

It's odd that when parsing a breakpoint or location number, we error out
in most cases, but warn in others.

  (gdb) disable 1-
  bad breakpoint number at or near: '1-'
  (gdb) disable -1
  bad breakpoint number at or near: '-1'
  (gdb) disable .foo
  bad breakpoint number at or near: '.foo'
  (gdb) disable foo.1
  Bad breakpoint number 'foo.1'
  (gdb) disable 1.foo
  warning: bad breakpoint number at or near '1.foo'

This changes GDB to always error out.  It required touching one testcase
that expected the warning.

gdb/ChangeLog:
2017-11-07  Pedro Alves  <palves@redhat.com>

	* breakpoint.c (extract_bp_number_and_location): Change return
	type to void.  Throw error instead of warning.
	(enable_disable_command): Adjust.

gdb/testsuite/ChangeLog:
2017-11-07  Pedro Alves  <palves@redhat.com>

	* gdb.base/ena-dis-br.exp: Don't expect "warning:".


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Allow enabling/disabling breakpoint location ranges
@ 2017-11-07 11:32 sergiodj+buildbot
  2017-11-07 18:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-07 11:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d0fe47010fc3289e081ba547a0bfcc6d07906cd2 ***

Author: Xavier Roirand <roirand@adacore.com>
Branch: master
Commit: d0fe47010fc3289e081ba547a0bfcc6d07906cd2

Allow enabling/disabling breakpoint location ranges

When a breakpoint has multiple locations, like e.g.:

 Num  Type       Disp Enb  Address    What
 1    breakpoint keep y    <MULTIPLE>
 1.1                  y    0x080486a2 in void foo<int>()...
 1.2                  y    0x080486ca in void foo<double>()...
 [....]
 1.5                  y    0x080487fa in void foo<long>()...

it's possible to enable/disable the individual locations using the
'<breakpoint_number>.<location_number>' syntax, like e.g.:

 (gdb) disable 1.2 1.3 1.4 1.5

That's inconvenient when you have a long list of locations to disable,
however.

This patch adds shorthand for the above, by making it possible to
specify a range of locations with the following syntax (similar to
thread id ranges):

 <breakpoint_number>.<first_location_number>-<last_location_number>

For example, the command above can now be simplified to:

 (gdb) disable 1.2-5

gdb/ChangeLog:
2017-11-07  Xavier Roirand  <roirand@adacore.com>
	    Pedro Alves  <palves@redhat.com>

	* breakpoint.c (map_breakpoint_number_range): New, factored out
	from ...
	(map_breakpoint_numbers): ... here.
	(find_location_by_number): Change parameters from string to
	breakpoint number and location.
	(extract_bp_number_and_location): New function.
	(enable_disable_bp_num_loc)
	(enable_disable_breakpoint_location_range)
	(enable_disable_command): New functions, factored out ...
	(enable_command, disable_command): ... these functions, and
	adjusted to support ranges.
	* NEWS: Document enable/disable breakpoint location range feature.

gdb/doc/ChangeLog:
2017-11-07  Xavier Roirand  <roirand@adacore.com>
	    Pedro Alves  <palves@redhat.com>

	* gdb.texinfo (Set Breaks): Document support for breakpoint
	location ranges in the enable/disable commands.

gdb/testsuite/ChangeLog:
2017-11-07  Xavier Roirand  <roirand@adacore.com>
	    Pedro Alves  <palves@redhat.com>

	* gdb.base/ena-dis-br.exp: Add reference to
	gdb.cp/ena-dis-br-range.exp.
	* gdb.cp/ena-dis-br-range.exp: New file.
	* gdb.cp/ena-dis-br-range.cc: New file.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] This patch similarly to the AArch64 one enables Dot Product support by default for the Cortex-A55 and Cortex-A75 which have hardware support for these instructions.
@ 2017-11-07 10:42 sergiodj+buildbot
  2017-11-07 17:03 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-07 10:42 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0198d5e6fc331d50dc19b7f250ac4bc510a8dbb5 ***

Author: Tamar Christina <tamar.christina@arm.com>
Branch: master
Commit: 0198d5e6fc331d50dc19b7f250ac4bc510a8dbb5

This patch similarly to the AArch64 one enables Dot Product support by default for the Cortex-A55 and Cortex-A75 which have hardware support for these instructions.

gas	* config/tc-arm.c (arm_cpus):
	Change FPU_ARCH_CRYPTO_NEON_VFP_ARMV8
	into FPU_ARCH_CRYPTO_NEON_VFP_ARMV8_DOTPROD.

include	* opcode/arm.h (FPU_ARCH_CRYPTO_NEON_VFP_ARMV8_DOTPROD):
	New macro.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] ngettext support
@ 2017-11-07  8:51 sergiodj+buildbot
  2017-11-07 13:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-07  8:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6003e27e764ff62c1269a3ac6b5806b3fa3a1740 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 6003e27e764ff62c1269a3ac6b5806b3fa3a1740

ngettext support

binutils has lacked proper pluralization of output messages for a long
time, for example, readelf will display information about a section
that "contains 1 entries" or "There are 1 section headers".  Fixing
this properly requires us to use ngettext, because other languages
have different rules to English.

This patch defines macros for ngettext and friends to handle builds
with --disable-nls, and tidies the existing nls support.  I've
redefined gettext rather than just defining "_" as dgettext in bfd and
opcodes in case someone wants to use gettext there (which might
conceivably happen with generated code).

bfd/
	* sysdep.h: Formatting, comment fixes.
	(gettext, ngettext): Redefine when ENABLE_NLS.
	(ngettext, dngettext, dcngettext): Define when !ENABLE_NLS.
	(_): Define using gettext.
	(textdomain, bindtextdomain): Use safer "do nothing".
	* hosts/alphavms.h (textdomain, bindtextdomain): Likewise.
	(ngettext, dngettext, dcngettext): Define when !ENABLE_NLS.
opcodes/
	* opintl.h: Formatting, comment fixes.
	(gettext, ngettext): Redefine when ENABLE_NLS.
	(ngettext, dngettext, dcngettext): Define when !ENABLE_NLS.
	(_): Define using gettext.
	(textdomain, bindtextdomain): Use safer "do nothing".
binutils/
	* sysdep.h (textdomain, bindtextdomain): Use safer "do nothing".
	(ngettext, dngettext, dcngettext): Define when !ENABLE_NLS.
gas/
	* asintl.h (textdomain, bindtextdomain): Use safer "do nothing".
	(ngettext, dngettext, dcngettext): Define when !ENABLE_NLS.
gold/
	* system.h (textdomain, bindtextdomain): Use safer "do nothing".
	(ngettext, dngettext, dcngettext): Define when !ENABLE_NLS.
ld/
	* ld.h (textdomain, bindtextdomain): Use safer "do nothing".
	(ngettext, dngettext, dcngettext): Define when !ENABLE_NLS.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Update my e-mail address.
@ 2017-11-07  2:03 sergiodj+buildbot
  2017-11-07 12:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-07  2:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 635dc5b2e5cda5b18d32c4b0f6c19cba3ef05c67 ***

Author: Luis Machado <luis.machado@linaro.org>
Branch: master
Commit: 635dc5b2e5cda5b18d32c4b0f6c19cba3ef05c67

Update my e-mail address.

gdb/ChangeLog:
2017-11-06  Luis Machado  <luis.machado@linaro.org>

	* MAINTAINERS (Write After Approval): Update my e-mail address.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Simplify child_terminal_inferior
@ 2017-11-07  1:31 sergiodj+buildbot
  2017-11-07 10:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-07  1:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 556e5da51349d00307bc05b7a6a813f71ac58664 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 556e5da51349d00307bc05b7a6a813f71ac58664

Simplify child_terminal_inferior

The comment about Lynx in child_terminal_init reads a bit odd, since
it's not exactly clear what "This" in "This is for Lynx" is referring
to.  Looking back in history makes it clearer.  When the comment was
originally added, in commit 91ecc8efa9b9, back in 1994, the code
looked like this:

~~~
#ifdef PROCESS_GROUP_TYPE
#ifdef PIDGET
      /* This is for Lynx, and should be cleaned up by having Lynx be
         a separate debugging target with a version of
         target_terminal_init_inferior which passes in the process
         group to a generic routine which does all the work (and the
         non-threaded child_terminal_init_inferior can just pass in
         inferior_pid to the same routine).  */
      inferior_process_group = PIDGET (inferior_pid);
#else
      inferior_process_group = inferior_pid;
#endif
#endif
~~~

So this looked like it was about when GDB was growing support for
multi-threading, and inferior_pid was still a single int for most
ports.

Eventually we got ptid_t, so the comment isn't really useful today.
Particularly more so since we no longer support Lynx as a GDB host.

The only caller left of child_terminal_init_with_pgrp is gnu-nat.c
(the Hurd), and that target uses fork-child, so when we reach
gnu_terminal_init after spawning a new child, the current inferior
must already have the PID set, and the child must be a process group
leader.

We can't add a 'getpgid(inf->pid) == inf->pid' assertion to
child_terminal_init though (like a previous version of this patch was
doing [1]), because child_terminal_init is also reached after
attaching to a process.  If we did, the new
gdb.base/attach-non-pgrp-leader.exp test would fail, with:

  (gdb) attach 12415
  Attaching to program: build/gdb/testsuite/outputs/gdb.base/attach-non-pgrp-leader/attach-non-pgrp-leader, process 12415
  src/gdb/inflow.c:180: internal-error: void child_terminal_init(target_ops*): Assertion `getpgid (inf->pid) == inf->pid' failed.
  A problem internal to GDB has been detected,
  further debugging may prove unreliable.
  Quit this debugging session? (y or n) FAIL: gdb.base/attach-non-pgrp-leader.exp: child: attach to child (GDB internal error)

I'm not making GDB save the pgid for attached processes with getpgid
for now, because the saved process group affects other things which
I'm leaving for following patches, like e.g., the "interrupt" command.

[1] - https://sourceware.org/ml/gdb-patches/2017-11/msg00039.html

gdb/ChangeLog:
2017-11-06  Pedro Alves  <palves@redhat.com>

	* gnu-nat.c (gnu_terminal_init): Delete.
	(gnu_target): Don't install gnu_terminal_init.
	* inflow.c (child_terminal_init_with_pgrp): Delete, merged with ...
	(child_terminal_init): ... this function.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Test attaching to a process that isn't a process group leader
@ 2017-11-07  1:06 sergiodj+buildbot
  2017-11-07  8:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-07  1:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 46f67f80ddfeea11d4a8134b347c74581faff8f6 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 46f67f80ddfeea11d4a8134b347c74581faff8f6

Test attaching to a process that isn't a process group leader

The patch at
<https://sourceware.org/ml/gdb-patches/2017-11/msg00039.html> was
proposing to add an assertion to child_terminal_init that turns out
would fail if you tried to attach to a process that isn't a process
group leader.

Since the testsuite failed to catch the problem, this commit adds a
new testcase that would catch it, like:

  (gdb) attach 12415
  Attaching to program: build/gdb/testsuite/outputs/gdb.base/attach-non-pgrp-leader/attach-non-pgrp-leader, process 12415
  src/gdb/inflow.c:180: internal-error: void child_terminal_init(target_ops*): Assertion `getpgid (inf->pid) == inf->pid' failed.
  A problem internal to GDB has been detected,
  further debugging may prove unreliable.
  Quit this debugging session? (y or n) FAIL: gdb.base/attach-non-pgrp-leader.exp: child: attach to child (GDB internal error)

gdb/testsuite/ChangeLog:
2017-11-06  Pedro Alves  <palves@redhat.com>

	* gdb.base/attach-non-pgrp-leader.c: New.
	* gdb.base/attach-non-pgrp-leader.exp: New.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Don't set terminal flags twice in a row
@ 2017-11-06 22:47 sergiodj+buildbot
  2017-11-07  5:13 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-06 22:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a94799ac1e430404fda5cbc181406cf5f3630108 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: a94799ac1e430404fda5cbc181406cf5f3630108

Don't set terminal flags twice in a row

I find this odd 'set flags twice' ancient code and comment annoyingly
distracting.  It may well be that the reason for the double-set was
simply a copy/paste mistake, and that we've been doing this for
decades [1] for no good reason.  Let's just get rid of it, and if we
find a real reason, add it back with a comment explaining why it's
necessary.

[1] This double-set was already in gdb 2.4 / 1988, the oldest release
we have sources for, and imported in git.  From 'git show 7b4ac7e1ed2c
inflow.c':

   +void
   +terminal_inferior ()
   +{
   +  if (terminal_is_ours)   /*  && inferior_thisrun_terminal == 0) */
   +    {
   +      fcntl (0, F_SETFL, tflags_inferior);
   +      fcntl (0, F_SETFL, tflags_inferior);

The "is there a reason" comment was added in 1993, by:

  commit a88797b5eadf31e21804bc820429028bf708fbcd
  Author:     Fred Fish <fnf@specifix.com>
  AuthorDate: Thu Aug 5 01:33:45 1993 +0000

gdb/ChangeLog:
2017-11-06  Pedro Alves  <palves@redhat.com>

	* inflow.c (child_terminal_inferior, child_terminal_ours_1): No
	longer set flags twice in row.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Target FP: Merge doublest.c and dfp.c into target-float.c
@ 2017-11-06 21:12 sergiodj+buildbot
  2017-11-07  1:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-06 21:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1cfb73dbb7503d1cfb088c14d1125a5030a1f386 ***

Author: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Branch: master
Commit: 1cfb73dbb7503d1cfb088c14d1125a5030a1f386

Target FP: Merge doublest.c and dfp.c into target-float.c

Now that all target FP operations are performed via target-float.c,
this file remains the sole caller of functions in doublest.c and dfp.c.
Therefore, this patch merges the latter files into the former and
makes all their function static there.

gdb/ChangeLog:
2017-11-06  Ulrich Weigand  <uweigand@de.ibm.com>

	* Makefile.in (SFILES): Remove doublest.c and dfp.c.
	(HFILES_NO_SRCDIR): Remove doublest.h and dfp.h.
	(COMMON_OBS): Remove doublest.o and dfp.o.
	Do not build target-float.c (instead of doublest.c)
	with -Wformat-nonliteral.

	* doublest.c: Remove file.
	* doublest.h: Remove file.
	* dfp.c: Remove file.
	* dfp.h: Remove file.

	* target-float.c: Do not include "doublest.h" and "dfp.h".
	(DOUBLEST): Move here from doublest.h.
	(enum float_kind): Likewise.
	(FLOATFORMAT_CHAR_BIT): Likewise.
	(FLOATFORMAT_LARGEST_BYTES): Likewise.
	(floatformat_totalsize_bytes): Move here from doublest.c.  Make static.
	(floatformat_precision): Likewise.
	(floatformat_normalize_byteorder, get_field, put_field): Likewise.
	(floatformat_is_negative, floatformat_classify, floatformat_mantissa):
	Likewise.
	(host_float_format, host_double_format, host_long_double_format):
	Likewise.
	(floatformat_to_string, floatformat_from_string): Likewise.
	(floatformat_to_doublest): Likewise.  Also, inline the original
	convert_floatformat_to_doublest.
	(floatformat_from_doublest): Likewise.  Also, inline the original
	convert_floatformat_from_doublest.

	Include "dpd/decimal128.h", "dpd/decimal64.h", and "dpd/decimal32.h".
	(MAX_DECIMAL_STRING): Move here from dfp.c.
	(match_endianness): Likewise.
	(set_decnumber_context, decimal_check_errors): Likewise.
	(decimal_from_number, decimal_to_number): Likewise.
	(decimal_to_string, decimal_from_string): Likewise.  Make static.
	(decimal_from_longest, decimal_from_ulongest): Likewise.
	(decimal_to_longest): Likewise.
	(decimal_binop, decimal_is_zero, decimal_compare): Likewise.
	(decimal_convert): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Target FP: Add binop and compare routines to target-float.{c, h}
@ 2017-11-06 17:27 sergiodj+buildbot
  2017-11-06 19:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-06 17:27 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 66c02b9ed1eabf1d7981c0c27ec9fd3c17fc5d35 ***

Author: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Branch: master
Commit: 66c02b9ed1eabf1d7981c0c27ec9fd3c17fc5d35

Target FP: Add binop and compare routines to target-float.{c,h}

This patch adds the following target floating-point routines:
 - target_float_binop
 - target_float_compare
which call the equivalent decimal_ routines to handle decimal FP,
and call helper routines that currently still go via DOUBLEST to
handle binary FP (derived from current valarith.c code).

These routines are used to handle both binary and decimal FP types
in scalar_binop, value_equal, and value_less, mostly following the
method currently used for decimal FP.  The existing value_args_as_decimal
helper is renamed to value_args_as_target_float and extended to handle
both binary and decimal types.

The unary operations value_pos and value_neg are also simplified,
the former by using a simple copy for all scalar types, the latter
by using value_binop (... BINOP_SUB) to implement negation as
subtraction from zero.

ChangeLog:
2017-11-06  Ulrich Weigand  <uweigand@de.ibm.com>

	* target-float.c: Include <math.h>.
	(floatformat_binop): New function.
	(floatformat_compare): Likewise.
	(target_float_binop): Likewise.
	(target_float_compare): Likewise.
	* target-float.h: Include "expression.h".
	(target_float_binop): Add prototype.
	(target_float_compare): Likewise.

	* valarith.c: Do not include "doublest.h" and "dfp.h".
	Include "common/byte-vector.h".
	(value_args_as_decimal): Remove, replace by ...
	(value_args_as_target_float): ... this function.  Handle both
	binary and decimal target floating-point formats.
	(scalar_binop): Handle both binary and decimal FP using
	value_args_as_target_float and target_float_binop.
	(value_equal): Handle both binary and decimal FP using
	value_args_as_target_float and target_float_compare.
	(value_less): Likewise.
	(value_pos): Handle all scalar types as simple copy.
	(value_neg): Handle all scalar types via BINOP_SUB from 0.
	* dfp.c (decimal_binop): Throw error instead of internal_error
	when called with an unsupported operation code.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Target FP: Add string routines to target-float.{c,h}
@ 2017-11-06 15:56 sergiodj+buildbot
  2017-11-06 16:47 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-06 15:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f69fdf9bca80ac703890a51e124e408cbccbb743 ***

Author: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Branch: master
Commit: f69fdf9bca80ac703890a51e124e408cbccbb743

Target FP: Add string routines to target-float.{c,h}

This adds target_float_to_string and target_float_from_string,
which dispatch to the corresponding floatformat_ or decimal_ routines.

Existing users of those routines are changed to use the new
target-float routines instead (most of those places already handle
both binary and decimal FP).

In addition, two other places are changes to use target_float_from_string:

- define_symbol in stabsread.c, when parsing a floating-point literal
  from stabs debug info

- gdbarch-selftest.c when initializing a target format values (to
  eliminate use of DOUBLEST there).

gdb/ChangeLog:
2017-11-06  Ulrich Weigand  <uweigand@de.ibm.com>

	* target-float.c (target_float_to_string): New function.
	(target_float_from_string): New function.
	* target-float.h (target_float_to_string): Add prototype.
	(target_float_from_string): Add prototype.

	* valprint.c: Include "target-float.h".  Do not include
	"doublest.h" and "dfp.h".
	(print_floating): Use target_float_to_string.
	* printcmd.c: Include "target-float.h".  Do not include "dfp.h".
	(printf_floating): Use target_float_to_string.
	* i387-tdep.c: Include "target-float.h".  Do not include "doublest.h".
	(print_i387_value): Use target_float_to_string.
	* mips-tdep.c: Include "target-float.h".
	(mips_print_fp_register): Use target_float_to_string.
	* sh64-tdep.c: Include "target-float.h".
	(sh64_do_fp_register): Use target_float_to_string.

	* parse.c: Include "target-float.h".  Do not include
	"doublest.h" and "dfp.h".
	(parse_float): Use target_float_from_string.
	* stabsread.c: Include "target-float.h".  Do not include "doublest.h".
	(define_symbol): Use target_float_from_string.
	* gdbarch-selftests.c: Include "target-float.h".
	(register_to_value_test): Use target_float_from_string.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Proper bound check in _bfd_doprnt_scan
@ 2017-11-05 12:25 sergiodj+buildbot
  2017-11-05 20:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-05 12:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 26a9301057457ae576b51b8127bb805b4e484a6b ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 26a9301057457ae576b51b8127bb805b4e484a6b

Proper bound check in _bfd_doprnt_scan

While an abort after storing out of bounds by one to an array in our
caller is probably OK in practice, it's better to check before storing.

	PR 22397
	* bfd.c (_bfd_doprnt_scan): Check args index before storing, not
	after.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR22397, BFD internal error when message locale isn't C
@ 2017-11-05 10:38 sergiodj+buildbot
  2017-11-05 19:14 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-05 10:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7167fe4c70ea74f1bb74a6130bb7e6bf5ca354ee ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 7167fe4c70ea74f1bb74a6130bb7e6bf5ca354ee

PR22397, BFD internal error when message locale isn't C

This adds positional parameter support to the bfd error handler,
something that was lost 2017-04-13 when _doprnt was added with commit
c08bb8dd.  The number of format args is now limited to 9, which is
sufficient for current _bfd_error_handler messages.  If someone
exceeds 9 args they get the joy of modifying this code to support more
args (shouldn't be too difficult).

	PR 22397
	* bfd.c (union _bfd_doprnt_args): New.
	(PRINT_TYPE): Add FIELD arg.  Take value from args.
	(_bfd_doprnt): Replace ap parameter with args.  Adjust all
	PRINT_TYPE invocations and reading of format args to suit.
	Move "%%" handling out of switch handling args.  Support
	positional parameters.
	(_bfd_doprnt_scan): New function.
	(error_handler_internal): Call _bfd_doprnt_scan and read args.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] powerpc TLS in PIEs
@ 2017-11-05  7:46 sergiodj+buildbot
  2017-11-05 15:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-05  7:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f15d0b545b9e9dada8d1398163693f67792e9e79 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: f15d0b545b9e9dada8d1398163693f67792e9e79

powerpc TLS in PIEs

This patch removes unnecessary GOT IE TLS relocations in PIEs.  Useful
with --no-tls-optimize, or with an enormous TLS segment.  With the
default --tls-optimize in effect IE code sequences will be edited to
LE under the same circumstances we can remove the GOT reloc.

	* elf32-ppc.c (got_entries_needed, got_relocs_needed): New functions.
	(allocate_dynrelocs, ppc_elf_size_dynamic_sections): Use them here.
	(ppc_elf_relocate_section): Don't output a dynamic relocation
	for IE GOT entries in an executable.
	* elf64-ppc.c (allocate_got): Trim unnecessary TPREL relocs.
	(ppc64_elf_size_dynamic_sections): Likewise.
	(ppc64_elf_relocate_section): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] hppa-linux TLS relocs
@ 2017-11-05  6:19 sergiodj+buildbot
  2017-11-05 12:38 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-05  6:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2e684e75ae3939f5f14fb89ca8a300b610d093dd ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 2e684e75ae3939f5f14fb89ca8a300b610d093dd

hppa-linux TLS relocs

This patch fixes various problems with TLS relocations.

1) Report an error if a symbol has both TLS and normal GOT entries.
2) The GOT entry size calculation was obscure and made use of the fact
   that a symbol shouldn't have both normal and TLS GOT entries.
3) The second word of a GD GOT entry sometimes omitted a dynamic
   reloc, which was fine except that doing so makes it impossible for
   ld.so to differentiate GD and LD entries.  Also, a NONE reloc was
   emitted.
4) Unnecessary relocs were emitted for GOT entries.
5) GOT relocs didn't take note of UNDEFWEAK_NO_DYNAMIC_RELOC.

	* elf32-hppa.c (enum _tls_type): Move.
	(struct elf32_hppa_link_hash_entry): Make tls_type a bitfield.
	(elf32_hppa_check_relocs): Set DF_STATIC_TLS only for shared libraries.
	Tidy tls_type handling.  Set symbol tls_type for GOT_TLS_LDM too.
	(got_entries_needed, got_relocs_needed): New functions.
	(allocate_dynrelocs): Use them.
	(elf32_hppa_size_dynamic_sections): Likewise.
	(elf32_hppa_relocate_section): Delete bogus FIXME.  Formatting.
	Correct code emitting relocs on GD/IE got entries.  Report an
	error when a symbol has both normal and TLS GOT relocs.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PowerPC readonly_dynrelocs
@ 2017-11-05  2:35 sergiodj+buildbot
  2017-11-05 13:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-05  2:35 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 98bbb1b86180324b278842d8d73c79cb5d76d349 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 98bbb1b86180324b278842d8d73c79cb5d76d349

PowerPC readonly_dynrelocs

PowerPC64 lacked the mapfile textrel warning on finding dynamic relocs
in read-only sections.  This patch adds it, and tidies the
readonly_dynrelocs interface.  PowerPC doesn't need a SEC_ALLOC test
because !SEC_ALLOC sections are excluded by check_relocs so will never
have dyn_relocs.

	* elf32-ppc.c (readonly_dynrelocs): Delete info param.  Update all
	callers.  Don't bother with SEC_ALLOC test.  Return section pointer.
	Move minfo call to..
	(maybe_set_textrel): ..here.
	* elf64-ppc.c (readonly_dynrelocs): Return section pointer.
	(maybe_set_textrel): Call minfo to print textrel warning to map file.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Use gdb::byte_vector in ppc-linux-tdep.c
@ 2017-11-05  1:19 sergiodj+buildbot
  2017-11-05  3:57 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-05  1:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 779bc38eca950c7f3b64173e99e25f0c0edfbe3b ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 779bc38eca950c7f3b64173e99e25f0c0edfbe3b

Use gdb::byte_vector in ppc-linux-tdep.c

This removes a cleanup from ppc-linux-tdep.c, replacing it with
gdb::byte_vector.

gdb/ChangeLog
2017-11-04  Tom Tromey  <tom@tromey.com>

	* ppc-linux-tdep.c (ppc_linux_get_syscall_number): Use
	gdb::byte_vector.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Use unique_xmalloc_ptr in c_type_print_base
@ 2017-11-04 23:46 sergiodj+buildbot
  2017-11-05  6:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-04 23:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 331b71e5ee226cb5455969899274f0e43e83aa1e ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 331b71e5ee226cb5455969899274f0e43e83aa1e

Use unique_xmalloc_ptr in c_type_print_base

This changes c_type_print_base to use unique_xmalloc_ptr, removing a
cleanup.

gdb/ChangeLog
2017-11-04  Tom Tromey  <tom@tromey.com>

	* c-typeprint.c (c_type_print_base): Use gdb::unique_xmalloc_ptr.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Replace start_rbreak_breakpoints and end_rbreak_breakpoints
@ 2017-11-04 20:14 sergiodj+buildbot
  2017-11-04 23:56 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-04 20:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c80049d3b615691dc902762d5d97551aa9664442 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: c80049d3b615691dc902762d5d97551aa9664442

Replace start_rbreak_breakpoints and end_rbreak_breakpoints

This replaces start_rbreak_breakpoints and end_rbreak_breakpoints with
a new scoped class.  This allows the removal of a cleanup.

This also fixes an earlier memory leak regression, by changing
"string" to be a std::string.

gdb/ChangeLog
2017-11-04  Tom Tromey  <tom@tromey.com>

	* breakpoint.c
	(scoped_rbreak_breakpoints::scoped_rbreak_breakpoints): Rename
	from start_rbreak_breakpoints.
	(scoped_rbreak_breakpoints): Rename from end_rbreak_breakpoints.
	* breakpoint.h (class scoped_rbreak_breakpoints): New.
	(start_rbreak_breakpoints, end_rbreak_breakpoints): Remove.
	* symtab.c (do_end_rbreak_breakpoints): Remove.
	(rbreak_command): Use scoped_rbreak_breakpoints, std::string.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove directive-searched cleanups
@ 2017-11-04 19:51 sergiodj+buildbot
  2017-11-04 22:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-04 19:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 167b0be1b5ef36a5605fcdfba0c84db2ed475e1e ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 167b0be1b5ef36a5605fcdfba0c84db2ed475e1e

Remove directive-searched cleanups

This removes a few cleanups related to the "searched" field in
struct using_direct, replacing these with scoped_restore.

gdb/ChangeLog
2017-11-04  Tom Tromey  <tom@tromey.com>

	* cp-namespace.c (reset_directive_searched): Remove.
	(cp_lookup_symbol_via_imports): Use scoped_restore.
	* cp-support.c (reset_directive_searched): Remove.
	(make_symbol_overload_list_using): Use scoped_restore.
	* d-namespace.c (d_lookup_symbol_imports): Use scoped_restore.
	(reset_directive_searched): Remove.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Use unique_xmalloc_ptr in find_separate_debug_file_by_debuglink
@ 2017-11-04 18:59 sergiodj+buildbot
  2017-11-04 21:11 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-04 18:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5eae7aeaf754549d3645a0c590c5ef9f0134a32d ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 5eae7aeaf754549d3645a0c590c5ef9f0134a32d

Use unique_xmalloc_ptr in find_separate_debug_file_by_debuglink

This changes find_separate_debug_file_by_debuglink to use
unique_xmalloc_ptr, removing some cleanups.

gdb/ChangeLog
2017-11-04  Tom Tromey  <tom@tromey.com>

	* symfile.c (find_separate_debug_file_by_debuglink): Use
	unique_xmalloc_ptr.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove cleanups from link_callbacks_einfo
@ 2017-11-04 17:45 sergiodj+buildbot
  2017-11-04 18:38 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-04 17:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 20dcd8cae7d87910f6c3936bad72e78b647a8de6 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 20dcd8cae7d87910f6c3936bad72e78b647a8de6

Remove cleanups from link_callbacks_einfo

This removes a cleanup from link_callbacks_einfo by using std::string.

gdb/ChangeLog
2017-11-04  Tom Tromey  <tom@tromey.com>

	* compile/compile-object-load.c (link_callbacks_einfo): Use
	std::string.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Replace really_free_pendings with a scoped_ class
@ 2017-11-04 17:00 sergiodj+buildbot
  2017-11-04 17:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-04 17:00 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 33c7c59df060e9952fc2f608c3a6ff0a23ecd40d ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 33c7c59df060e9952fc2f608c3a6ff0a23ecd40d

Replace really_free_pendings with a scoped_ class

This introduces scoped_free_pendings, and changes users of
really_free_pendings to use it instead, removing some clenaups.

I tried to examine the affected code to ensure there aren't dangling
cleanups in the vicinity.

gdb/ChangeLog
2017-11-04  Tom Tromey  <tom@tromey.com>

	* dwarf2read.c (process_full_comp_unit, process_full_type_unit):
	Use scoped_free_pendings.
	* dbxread.c (dbx_symfile_read, dbx_psymtab_to_symtab_1): Use
	scoped_free_pendings.
	* xcoffread.c (xcoff_psymtab_to_symtab_1): Use scoped_free_pendings.
	(xcoff_initial_scan): Likewise.
	* buildsym.c (reset_symtab_globals): Update comment.
	(scoped_free_pendings): Rename from really_free_pendings.
	(prepare_for_building): Update comment.
	(buildsym_init): Likewise.
	* buildsym.h (class scoped_free_pendings): New class.
	(really_free_pendings): Don't declare.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix regression on ARM after Target FP patches
@ 2017-11-03 15:41 sergiodj+buildbot
  2017-11-03 17:58 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-03 15:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 67fa57cfa536cefb5ae7cc4635db66d03fdbd8bb ***

Author: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Branch: master
Commit: 67fa57cfa536cefb5ae7cc4635db66d03fdbd8bb

Fix regression on ARM after Target FP patches

Commit edd079d9f6ca2f9ad21322b742269aec5de61190 exposed a pre-existing bug
in convert_doublest_to_floatformat.  In the specific case of converting
a zero value to a floatformat using a "special" byteorder (i.e. neither
floatformat_little nor floatformat_big), the output buffer was actually
left uninitialized.

gdb/ChangeLog:
2017-11-03  Ulrich Weigand  <uweigand@de.ibm.com>

	* doublest.c (convert_doublest_to_floatformat): Fix uninitialized
	output when converting a zero value to a special byteorder format.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [ARC] Force the disassam to use the hexadecimal number for printing
@ 2017-11-03 15:03 sergiodj+buildbot
  2017-11-03 16:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-03 15:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fdddd2900f39584e7d6cee27127593fba2cb0cf2 ***

Author: claziss <claziss@synopsys.com>
Branch: master
Commit: fdddd2900f39584e7d6cee27127593fba2cb0cf2

[ARC] Force the disassam to use the hexadecimal number for printing

Force printing of the short/signed values using hexadecimal
representation via disassembler option.

opcode/
2017-11-03  Claudiu Zissulescu  <claziss@synopsys.com>

        * arc-dis.c (print_hex): New variable.
        (parse_option): Check for hex option.
        (print_insn_arc): Use hexadecimal representation for short
        immediate values when requested.
        (print_arc_disassembler_options): Add hex option to the list.

binutils/
2017-11-03  Claudiu Zissulescu  <claziss@synopsys.com>

        * doc/binutils.texi (ARC): Update disassembler options.
        * testsuite/binutils-all/arc/hexprint.s: New file.
        * testsuite/binutils-all/arc/objdump.exp: Test hex printing feature.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [ARC] Sync opcode data base.
@ 2017-11-03 14:08 sergiodj+buildbot
  2017-11-03 14:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-03 14:08 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3334eba7f4aeaa06926d5f1fb51446c5cea43e42 ***

Author: claziss <claziss@synopsys.com>
Branch: master
Commit: 3334eba7f4aeaa06926d5f1fb51446c5cea43e42

[ARC] Sync opcode data base.

New EM and HS variants are developed, sync the data base to match them.

opcodes/
2017-11-03  Claudiu Zissulescu  <claziss@synopsys.com>

        * arc-tbl.h (abss, abssh, adc, adcs, adds, aslacc, asls, aslsacc)
        (asrs, asrsr, cbflyhf0r, cbflyhf1r, cmacchfr, cmacchnfr, cmachfr)
        (cmachnfr, cmpychfr, cmpychnfr, cmpyhfmr, cmpyhfr, cmpyhnfr, divf)
        (dmachbl, dmachbm, dmachf, dmachfr, dmacwhf, dmpyhbl, dmpyhbm)
        (dmpyhf, dmpyhfr, dmpyhwf, dmpywhf, dsync, flagacc, getacc, macdf)
        (macf, macfr, macwhfl, macwhflr, macwhfm, macwhfmr, macwhkl)
        (macwhkul, macwhl, macwhul, mpydf, mpyf, mpyfr, mpywhfl, mpywhflr)
        (mpywhfm, mpywhfmr, mpywhkl, mpywhkul, mpywhl, mpywhul, msubdf)
        (msubf, msubfr, msubwhfl, msubwhflr, msubwhfm, msubwhfmr, mul64)
        (negs, negsh, normacc, qmachf, qmpyh, qmpyhf, rndh, satf, sath)
        (sbcs, setacc, sflag, sqrt, sqrtf, subs, swi_s, vabs2h, vabss2h)
        (vadd4b, vadds2, vadds2h, vadds4h, vaddsubs, vaddsubs2h)
        (vaddsubs4h, valgn2h, vasl2h, vasls2h, vasr2h, vasrs2h, vasrsr2h)
        (vext2bhl, vext2bhlf, vext2bhm, vext2bhmf, vlsr2h, vmac2hf)
        (vmac2hfr, vmac2hnfr, vmax2h, vmin2h, vmpy2h, vmpy2hf, vmpy2hfr)
        (vmpy2hwf, vmsub2hf, vmsub2hfr, vmsub2hnfr, vneg2h, vnegs2h)
        (vnorm2h, vpack2hbl, vpack2hblf, vpack2hbm, vpack2hbmf, vpack2hl)
        (vpack2hm, vperm, vrep2hl, vrep2hm, vsext2bhl, vsext2bhm, vsub4b)
        (vsubadds, vsubadds2h, vsubadds4h, vsubs2, vsubs2h, vsubs4h):
        Changed opcodes.
        (prealloc, prefetch*): Place them before ld instruction.
        * arc-opc.c (skip_this_opcode): Add ARITH class.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix excessive memory allocation attempts and possible integer overfloaws when attempting to read a COFF binary with a corrupt symbol count.
@ 2017-11-03 12:17 sergiodj+buildbot
  2017-11-03 12:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-03 12:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6cee897971d4d7cd37d2a686bb6d2aa3e759c8ca ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 6cee897971d4d7cd37d2a686bb6d2aa3e759c8ca

Fix excessive memory allocation attempts and possible integer overfloaws when attempting to read a COFF binary with a corrupt symbol count.

	PR 22385
	* coffgen.c (_bfd_coff_get_external_symbols): Check for an
	overlarge raw syment count.
	(coff_get_normalized_symtab): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] aarch64: Remove AARCH64_FEATURE_F16 from AARCH64_ARCH_V8_2
@ 2017-11-02 20:52 sergiodj+buildbot
  2017-11-03  1:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-02 20:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c05e0c5af35ebbb1ca39bb1efffae2adecdfa253 ***

Author: Siddhesh Poyarekar <siddhesh@sourceware.org>
Branch: master
Commit: c05e0c5af35ebbb1ca39bb1efffae2adecdfa253

aarch64: Remove AARCH64_FEATURE_F16 from AARCH64_ARCH_V8_2

The FP16 feature is optional in ARMv8.2, so it is wrong to add it to
the default AARCH64_ARCH_V8_2 feature flags.  This patch makes the
behaviour consistent with that of gcc, which also does not assume FP16
for ARMv8.2.

include/

	* opcode/aarch64.h (AARCH64_ARCH_V8_2): Drop
	AARCH64_FEATURE_F16.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Construct readonly regcache without address space
@ 2017-11-02 19:53 sergiodj+buildbot
  2017-11-03  0:20 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-02 19:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f26ae15b471aaddee81d9d6c03af1cb0f2081735 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: f26ae15b471aaddee81d9d6c03af1cb0f2081735

Construct readonly regcache without address space

The address space is useless to readonly regcache, so this patch removes
the parameter to construct readonly regcache.

address_space was added in regcache by 6c95b8d, but for read-write
regcache.  regcache::aspace is used for various breakpoint/watchpoint
checking, and these regcache are not read-only regcache.

gdb:

2017-11-02  Yao Qi  <yao.qi@linaro.org>

	* frame.c (do_frame_register_read): Remove aspace.
	* jit.c (jit_frame_sniffer): Likwise.
	* ppc-linux-tdep.c (ppu2spu_sniffer): Likewise.
	* regcache.c (regcache::regcache): Pass nullptr.
	(regcache_print): Caller updated.
	* regcache.h (regcache::regcache): Remove one constructor
	parameter aspace.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] const-fy regcache::m_readonly_p
@ 2017-11-02 19:26 sergiodj+buildbot
  2017-11-02 23:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-02 19:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6c6e9412e930c96f48b8ee78a389437328f5283c ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 6c6e9412e930c96f48b8ee78a389437328f5283c

const-fy regcache::m_readonly_p

gdb:

2017-11-02  Yao Qi  <yao.qi@linaro.org>

	* regcache.h (regcache) <m_readonly_p>: Change it to const bool.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] s/get_regcache_aspace (regcache)/regcache->aspace ()/g
@ 2017-11-02 19:07 sergiodj+buildbot
  2017-11-02 20:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-02 19:07 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a01bda5221f75031ea2b6d05860e46c7b9b58b55 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: a01bda5221f75031ea2b6d05860e46c7b9b58b55

s/get_regcache_aspace (regcache)/regcache->aspace ()/g

and remove get_regcache_aspace.

gdb:

2017-11-02  Yao Qi  <yao.qi@linaro.org>

	* darwin-nat.c (cancel_breakpoint): Use regcache->aspace ().
	* frame.c (create_sentinel_frame): Likewise.
	* infrun.c (displaced_step_prepare_throw): Likewise.
	(resume): Likewise.
	(thread_still_needs_step_over_bp): Likewise.
	(proceed): Likewise.
	(do_target_wait): Likewise.
	(adjust_pc_after_break): Likewise.
	(handle_syscall_event): Likewise.
	(save_waitstatus): Likewise.
	(handle_inferior_event_1): Likewise.
	(handle_signal_stop): Likewise.
	(keep_going_pass_signal): Likewise.
	* linux-nat.c (status_callback): Likewise.
	(save_stop_reason): Likewise.
	(resume_stopped_resumed_lwps): Likewise.
	* record-full.c (record_full_exec_insn): Likewise.
	(record_full_wait_1): Likewise.
	* regcache.c (get_regcache_aspace): Remove.
	* regcache.h (get_regcache_aspace): Remove.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] const-fy regcache::m_aspace
@ 2017-11-02 18:14 sergiodj+buildbot
  2017-11-02 21:54 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-02 18:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8b86c9592117b3ba52921af11868dc0b81ce4858 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 8b86c9592117b3ba52921af11868dc0b81ce4858

const-fy regcache::m_aspace

regcache::m_aspace is a const, never changed during the lifetime of
regcache object.  The address_space object is a const object too.

gdb:

2017-11-02  Yao Qi  <yao.qi@linaro.org>

	* breakpoint.c (insert_single_step_breakpoints): Update.
	* frame.c (struct frame_info) <aspace>: Add const.
	(frame_save_as_regcache): Add const.
	(get_frame_address_space): Return const address_space *.
	* frame.h (get_frame_address_space): Update declaration.
	* infrun.c (struct step_over_info) <aspace>: Add const.
	(set_step_over_info): Make aspace const.
	(displaced_step_prepare_throw): Change variable const.
	(resume): Likewise.
	(proceed): Likewise.
	(adjust_pc_after_break): Likewise.
	(save_waitstatus): Likewise.
	(handle_signal_stop): Likewise.
	(keep_going_pass_signal): Likewise.
	* jit.c (jit_frame_sniffer): Add const.
	* mips-tdep.c (mips_single_step_through_delay): Likewise.
	* ppc-linux-tdep.c (ppu2spu_sniffer): Likewise.
	* record-full.c (record_full_wait_1): Likewise.
	* regcache.c (regcache::regcache): Change parameter to const.
	* regcache.h (regcache::regcache): Likewise.
	(regcache::aspace): Return const address_space *.
	(regcache) <m_aspace>: Add const.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove regcache_descr::nr_raw_registers
@ 2017-11-02 17:06 sergiodj+buildbot
  2017-11-02 19:24 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-02 17:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d999647bc427ce2e083c4449b683705449d0bb58 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: d999647bc427ce2e083c4449b683705449d0bb58

Remove regcache_descr::nr_raw_registers

struct regcache_descr has fields nr_raw_registers and gdbarch, and
nr_raw_registers can be got via gdbarch_num_regs (gdbarch), so it looks
nr_raw_registers is redundant.  This patch removes it and adds a protected
method num_raw_registers.

gdb:

2017-11-02  Yao Qi  <yao.qi@linaro.org>

	* regcache.c (struct regcache_descr) <nr_raw_registers>: Remove.
	(init_regcache_descr): Use gdbarch_num_regs.
	(regcache::regcache): Likewise.
	(regcache::get_register_status): Likewise.
	(regcache::assert_raw_regnum): Likewise.
	(regcache::cooked_read): Likewise.
	(regcache::cooked_read_value): Likewise.
	(regcache::cooked_write): Likewise.
	(regcache::dump): Likewise.
	(regcache::num_raw_registers): New method.
	* regcache.h (class regcache) <num_raw_registers>: New.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] New method regcache::assert_regnum
@ 2017-11-02 16:13 sergiodj+buildbot
  2017-11-02 18:10 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-02 16:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4e888c281cd19f019248bd165d7055af88641c80 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 4e888c281cd19f019248bd165d7055af88641c80

New method regcache::assert_regnum

class regcache has some methods checking the range of register number,
this patch is to move it in a new method assert_regnum.

gdb:

2017-11-02  Yao Qi  <yao.qi@linaro.org>

	* regcache.c (regcache::assert_regnum): New method.
	(regcache::invalidate): Call assert_regnum.
	(regcache::raw_update): Likewise.
	(regcache::raw_write): Likewise.
	(regcache::raw_read_part): Likewise.
	(regcache::raw_write_part): Likewise.
	(regcache::raw_supply): Likewise.
	(regcache::raw_supply_integer): Likewise.
	(regcache::raw_supply_zeroed): Likewise.
	(regcache::raw_collect): Likewise.
	(regcache::raw_collect_integer): Likewise.
	* regcache.h (regcache::assert_regnum): Declare.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove code wrapped by "#if 0"
@ 2017-11-02 15:52 sergiodj+buildbot
  2017-11-02 16:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-02 15:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2e1b49b32ab9aec1aca94f424cbe275e5f6f9ab4 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 2e1b49b32ab9aec1aca94f424cbe275e5f6f9ab4

Remove code wrapped by "#if 0"

These code wrapped by "#if 0" was added by af030b9a, which added the new
command to dump registers in 2002.  The email didn't mention this either
https://sourceware.org/ml/gdb-patches/2002-08/msg00227.html  It was there
for 15 years, and nobody needs it, so we can remove it.

gdb:

2017-11-02  Yao Qi  <yao.qi@linaro.org>

	* regcache.c (regcache::dump): Remove code.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove regcache_descr fields sizeof_raw_register_status and sizeof_cooked_register_status
@ 2017-11-02 15:27 sergiodj+buildbot
  2017-11-02 15:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-02 15:27 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6c5218dfdb7b38cc1617be7753cc1ec6d0612382 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 6c5218dfdb7b38cc1617be7753cc1ec6d0612382

Remove regcache_descr fields sizeof_raw_register_status and sizeof_cooked_register_status

struct regcache_descr has two fields sizeof_raw_register_status
and sizeof_cooked_register_status, but they equal to nr_cooked_registers
and nr_raw_registers respectively, so this patch removes them.

gdb:

2017-11-02  Yao Qi  <yao.qi@linaro.org>

	* regcache.c (struct regcache_descr) <sizeof_raw_register_status>:
	Remove.
	<sizeof_cooked_register_status>: Remove.
	(init_regcache_descr): Update.
	(regcache::regcache): Use nr_cooked_registers and nr_raw_registers.
	(regcache::save): Likewise.
	(regcache::dump): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Prevent illegal memory accesses when attempting to read excessively large COFF line number tables.
@ 2017-11-01 15:24 sergiodj+buildbot
  2017-11-01 15:48 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-01 15:24 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a67d66eb97e7613a38ffe6622d837303b3ecd31d ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: a67d66eb97e7613a38ffe6622d837303b3ecd31d

Prevent illegal memory accesses when attempting to read excessively large COFF line number tables.

	PR 22376
	* coffcode.h (coff_slurp_line_table): Check for an excessively
	large line number count.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix an invalid free called when attempting to link a COFF object against an ELF archive with --no-keep-memory enabled.
@ 2017-11-01 11:58 sergiodj+buildbot
  2017-11-01 12:03 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-11-01 11:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ee357486aa87b17782111295c5e7bd4ac9e6970f ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: ee357486aa87b17782111295c5e7bd4ac9e6970f

Fix an invalid free called when attempting to link a COFF object against an ELF archive with --no-keep-memory enabled.

	PR 22369
	* coffgen.c (_bfd_coff_free_symbols): Fail if called on a non-COFF
	file.
	* cofflink.c (coff_link_check_archive_element): Skip non-COFF
	members of an archive.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix illegal memory access triggered when parsing a PE binary with a corrupt data dictionary.
@ 2017-10-31 14:53 sergiodj+buildbot
  2017-10-31 14:57 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-31 14:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0bb6961f18b8e832d88b490d421ca56cea16c45b ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 0bb6961f18b8e832d88b490d421ca56cea16c45b

Fix illegal memory access triggered when parsing a PE binary with a corrupt data dictionary.

	PR 22373
	* peicode.h (pe_bfd_read_buildid): Check for invalid size and data
	offset values.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] frv-elf --gc-sections failures
@ 2017-10-30  2:25 sergiodj+buildbot
  2017-10-30  4:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-30  2:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7f9cb5d275e71a75e97230241ec7da6718a7a0f5 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 7f9cb5d275e71a75e97230241ec7da6718a7a0f5

frv-elf --gc-sections failures

git commit 81742b83e9 exposed an frv-elf bug, with the object id not
matching the hash table id.

	* elf32-frv.c (ELF_TARGET_ID): Don't define for generic
	elf target.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] relocs_compatible test for gc-sections
@ 2017-10-30  2:05 sergiodj+buildbot
  2017-10-30  2:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-30  2:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 81742b83e9f25895eaaf3a07ac1651a4e9a68251 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 81742b83e9f25895eaaf3a07ac1651a4e9a68251

relocs_compatible test for gc-sections

I noticed when looking at pr22300 that before calling check_relocs we
have an elf_object_id test (added for pr11933) as well as the
relocs_compatible test.  I believe backend gc_mark_hook and
gc_sweep_hook ought to be protected similarly from being confused by
unexpected relocations (for example, both elf64-ppc.c and elf32-ppc.c
use _bfd_elf_relocs_compatible, so I think it would be possible for
the ppc64 gc_mark_hook to be presented with a ppc32 relocatable
object).

	* elflink.c (elf_gc_sweep): Test elf_object_id in addition to
	relocs_compatible.
	(bfd_elf_gc_sections): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR22300, Abort in elf32_hppa_relocate_section building polyml
@ 2017-10-28 12:08 sergiodj+buildbot
  2017-10-28 22:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-28 12:08 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c0e331c794d6bd75d9be9bea6145513074c33f39 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: c0e331c794d6bd75d9be9bea6145513074c33f39

PR22300, Abort in elf32_hppa_relocate_section building polyml

polyml produces object files with the wrong OS/ABI for hppa-linux.
This, along with the fact that elf32-hppa.c is using the strictest
backend relocs_compatible, results in wrong merging of ELF symbols.

So, remove the relocs_compatible check in _bfd_elf_merge_symbol.
_bfd_elf_merge_symbol is only called nowadays from within blocks
protected by is_elf_hash_table, so "we are doing an ELF link" as the
removed comment says, is true.

Also relax relocs_compatible for hppa and powerpc.  relocs_compatible
is used for more than just merging symbols, as the name suggests.
This allows objects that are in fact reasonably compatible to be
linked.

	PR 22300
	* elflink.c (_bfd_elf_merge_symbol): Remove relocs_compatible check.
	* elf32-hppa.c (elf_backend_relocs_compatible): Define.
	* elf32-ppc.c (elf_backend_relocs_compatible): Define.
	* elf64-ppc.c (elf_backend_relocs_compatible): Define.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] C++ify xml-syscall.c
@ 2017-10-28  8:07 sergiodj+buildbot
  2017-10-28 14:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-28  8:07 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5a9dcda14c240eccee5c1de53cf4ae936230ed0c ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 5a9dcda14c240eccee5c1de53cf4ae936230ed0c

C++ify xml-syscall.c

This patch C++ifies the structures in xml-syscall.c, by using
std::vector instead of VEC, and std::string instead of char*.
Using a unique_ptr in syscall_parse_xml allows to remove a cleanup.

Something that seems strange with the existing code, if you look at
syscalls_info_free_syscalls_desc and
syscalls_info_free_syscall_group_desc, they free the structure elements
(the strings and vectors), but they don't free the syscall_desc and
syscall_group_desc structure themselves.  I don't see anything freeing
those currently.  Any idea why?  According to the comment above
syscalls_info_free_syscall_group_desc, it kinda looks like it's on
purpose.  With this patch, those structures are deleted when the vector
that contains them gets deleted.

The only time I'm aware a syscalls_info structure gets deleted is in the
case the data directory changes during runtime, in init_syscalls_info.
If tried that use case (including under valgrind):

 (gdb) catch syscall
 (gdb) set data-directory another-data-directory
 (gdb) catch syscall

I confirmed that the syscalls_info structure got deleted and recreated,
and everything seemed fine.

Regtested on the buildbot.

gdb/ChangeLog:

	* xml-syscall.c (struct syscall_desc): Add constructor.
	<name>: Change type to std::string.
	(syscall_desc_up): New typedef.
	(syscall_desc_p): Remove typeder.
	(DEF_VEC_P(syscall_desc_p)): Remove.
	(struct syscall_group_desc): Add constructor.
	<name>: Change type to std::string.
	<syscalls>: Change type to std::vector.
	(syscall_group_desc_up): New typedef.
	(syscall_group_desc_p): Remove typedef.
	(DEF_VEC_P(syscall_group_desc_p)): Remove.
	(struct syscalls_info) <syscalls>: Change type to std::vector of
	unique_ptr.
	<groups>: Likewise.
	<my_gdb_datadir>: Change type to std::string.
	(syscalls_info_up): New typedef.
	(allocate_syscalls_info): Remove.
	(syscalls_info_free_syscalls_desc): Remove.
	(syscalls_info_free_syscall_group_desc): Remove.
	(free_syscalls_info): Remove.
	(make_cleanup_free_syscalls_info): Remove.
	(syscall_group_create_syscall_group_desc): Adjust.
	(syscall_group_add_syscall): Adjust.
	(syscall_create_syscall_desc): Adjust.
	(syscall_parse_xml): Adjust, use unique_ptr instead of cleanup.
	(init_syscalls_info): Adjust.
	(syscall_group_get_group_by_name): Adjust.
	(xml_get_syscall_number): Adjust.
	(xml_get_syscall_name): Adjust.
	(xml_list_of_syscalls): Adjust.
	(xml_list_syscalls_by_group): Adjust.
	(xml_list_of_groups): Adjust.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove usages of find_inferior in handle_status
@ 2017-10-28  6:15 sergiodj+buildbot
  2017-10-28 18:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-28  6:15 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 99078d344db25efc376877e0e4c95157f0c36c60 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 99078d344db25efc376877e0e4c95157f0c36c60

Remove usages of find_inferior in handle_status

Replace one with find_thread, the other with for_each_thread.

gdb/gdbserver/ChangeLog:

	* server.c (queue_stop_reply_callback): Change prototype, return
	void.
	(find_status_pending_thread_callback): Remove.
	(handle_status): Replace find_inferior with find_thread and
	for_each_thread.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Get rid of VEC(probe_p)
@ 2017-10-28  5:13 sergiodj+buildbot
  2017-10-28 13:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-28  5:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 45461e0dcaf4193b5b4478031f515ffb7911ad85 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 45461e0dcaf4193b5b4478031f515ffb7911ad85

Get rid of VEC(probe_p)

Replace the remaining usages of VEC(probe_p) with std::vector.

Regtested on the buildbot.

gdb/ChangeLog:

	* probe.h: Don't include gdb_vecs.h.
	(DEF_VEC_P (probe_p)): Remove.
	(find_probes_in_objfile): Return an std::vector.
	* probe.c (find_probes_in_objfile): Likewise.
	* breakpoint.c (breakpoint_objfile_data)
	<longjmp_probes>: Change type to std::vector.
	<exception_probes>: Likewise.
	(free_breakpoint_probes): Don't manually free vectors.
	(create_longjmp_master_breakpoint): Adjust.
	(create_exception_master_breakpoint): Adjust.
	* solib-svr4.c (svr4_create_probe_breakpoints): Change
	parameter type, adjust.
	(svr4_create_solib_event_breakpoints): Adjust.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Get rid of VEC(filename_language)
@ 2017-10-28  3:31 sergiodj+buildbot
  2017-10-28  8:48 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-28  3:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 593e3209f3e4e525030bc8768850f3876fd0b850 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 593e3209f3e4e525030bc8768850f3876fd0b850

Get rid of VEC(filename_language)

This patch removes VEC(filename_language), replacing its usage with
std::vector.  filename_language::ext is changed to an std::string at the
same time.

Regtested on the buildbot.

gdb/ChangeLog:

	* symfile.c (filename_language): Make struct, not typedef.  Add
	constructor.
	<ext>: Change type to std::string.
	(DEF_VEC_O (filename_language)): Remove.
	(filename_language_table): Change type to std::vector.
	(add_filename_language): Adjust.
	(set_ext_lang_command): Adjust.
	(info_ext_lang_command): Adjust.
	(deduce_language_from_filename): Adjust.
	(class scoped_restore_filename_language_table): Remove.
	(test_filename_language): Use scoped_restore.
	(test_set_ext_lang_command): Use scoped_restore, adjust to
	std::vector change.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [AArch64] Mark LR clobbered by BL in inline asm
@ 2017-10-27 17:04 sergiodj+buildbot
  2017-10-28  4:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-27 17:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bb11dd58391459bd5ba54ec405adab663ac59e89 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: bb11dd58391459bd5ba54ec405adab663ac59e89

[AArch64] Mark LR clobbered by BL in inline asm

LR is a caller-save register, so, if inline asm does BL (which touches
LR), we should mark LR clobbered.

gdb/testsuite:

2017-10-27  Yao Qi  <yao.qi@linaro.org>

	* gdb.arch/insn-reloc.c (can_relocate_bl): Mark "x30" clobbered.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] RISC-V: Fix disassembly of c.addi4spn, c.addi16sp, c.lui when imm=0
@ 2017-10-27  3:57 sergiodj+buildbot
  2017-10-27 11:00 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-27  3:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 63a25ea0de6d2f6d45b26af8d9c808aa35962256 ***

Author: Andrew Waterman <andrew@sifive.com>
Branch: master
Commit: 63a25ea0de6d2f6d45b26af8d9c808aa35962256

RISC-V: Fix disassembly of c.addi4spn, c.addi16sp, c.lui when imm=0

These are all invalid instructions, so they should not disassemble.

opcodes/ChangeLog

2017-10-24  Andrew Waterman  <andrew@sifive.com>

        * riscv-opc.c (match_c_addi16sp) : New function.
        (match_c_addi4spn): New function.
        (match_c_lui): Don't allow 0-immediate encodings.
        (riscv_opcodes) <addi>: Use the above functions.
        <add>: Likewise.
        <c.addi4spn>: Likewise.
        <c.addi16sp>: Likewise.

gas/ChangeLog

2017-10-24  Andrew Waterman  <andrew@sifive.com>

        * testsuite/gas/riscv/c-addi16sp-fail.d: New test.
        testsuite/gas/riscv/c-addi16sp-fail.l: Likewise.
        testsuite/gas/riscv/c-addi16sp-fail.s: Likewise.
        testsuite/gas/riscv/c-addi4spn-fail.d: Likewise.
        testsuite/gas/riscv/c-addi4spn-fail.l: Likewise.
        testsuite/gas/riscv/c-addi4spn-fail.s: Likewise.
        testsuite/gas/riscv/riscv.exp: Add new tests.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Garbage collect remote.c:remote_async_terminal_ours_p
@ 2017-10-26 22:19 sergiodj+buildbot
  2017-10-28  0:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-26 22:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 23cc4e1b28d445e23827a09c454aa806f2b8c720 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 23cc4e1b28d445e23827a09c454aa806f2b8c720

Garbage collect remote.c:remote_async_terminal_ours_p

remote.c:remote_async_terminal_ours_p stopped being useful after
048094accce2 ("target remote: Don't rely on immediate_quit (introduce
quit handlers)") and commit 41fd2b0f5d95 ("Make input_fd be per UI"),
which turned remote's terminal_inferior/ours methods into nops.

gdb/ChangeLog:
2017-10-26  Pedro Alves  <palves@redhat.com>

	* remote.c (remote_async_terminal_ours_p): Delete.
	(remote_open_1, remote_terminal_inferior, remote_terminal_ours):
	Remove references to 'remote_async_terminal_ours_p'.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] const-fy breakpoint_ops->breakpoint_hit parameter aspace
@ 2017-10-26 21:14 sergiodj+buildbot
  2017-10-27 21:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-26 21:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bd5225139c83a80aad542e46efb66fabf51bff91 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: bd5225139c83a80aad542e46efb66fabf51bff91

const-fy breakpoint_ops->breakpoint_hit parameter aspace

gdb:

2017-10-26  Yao Qi  <yao.qi@linaro.org>

	* break-catch-sig.c (signal_catchpoint_breakpoint_hit): Make
	aspace const.
	* break-catch-syscall.c (breakpoint_hit_catch_syscall):
	Likewise.
	* breakpoint.c (bpstat_check_location): Remove cast.
	(breakpoint_hit_catch_fork): Make aspce const.
	(breakpoint_hit_catch_solib): Likewise.
	(breakpoint_hit_catch_exec): Likewise.
	(breakpoint_hit_ranged_breakpoint): Likewise.
	(breakpoint_hit_watchpoint): Likewise.
	(base_breakpoint_breakpoint_hit): Likewise.
	(bkpt_breakpoint_hit): Likewise.
	(dprintf_breakpoint_hit): Likewise.
	(tracepoint_breakpoint_hit): Likewise.
	* breakpoint.h (breakpoint_ops) <breakpoint_hit>: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] s/get_regcache_arch (regcache)/regcache->arch ()/g
@ 2017-10-26 20:23 sergiodj+buildbot
  2017-10-27 19:00 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-26 20:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ac7936dfd0c85e5de2dfec45ca0dbf72baeffa51 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: ac7936dfd0c85e5de2dfec45ca0dbf72baeffa51

s/get_regcache_arch (regcache)/regcache->arch ()/g

This patches removes get_regcache_arch, and use regache->arch () instead.
The motivation of this change is that I am going to move some basic stuff
into a base class of regcache.  I don't need to update "client" code
regcache->arch ().  On the other hand, this patch shortens the code a
little bit.

gdb:

2017-10-25  Yao Qi  <yao.qi@linaro.org>

	* aarch32-linux-nat.c (aarch32_gp_regcache_supply): Use
	regcache->arch () instead get_regcache_arch.
	* aarch64-fbsd-nat.c (aarch64_fbsd_fetch_inferior_registers):
	Likewise.
	(aarch64_fbsd_store_inferior_registers): Likewise.
	* aarch64-linux-nat.c (fetch_gregs_from_thread): Likewise.
	(store_gregs_to_thread): Likewise.
	(fetch_fpregs_from_thread): Likewise.
	(store_fpregs_to_thread): Likewise.
	* aarch64-tdep.c (aarch64_extract_return_value): Likewise.
	(aarch64_store_return_value): Likewise.
	(aarch64_software_single_step): Likewise.
	* aix-thread.c (aix_thread_wait): Likewise.
	(supply_reg32): Likewise.
	(supply_sprs64): Likewise.
	(supply_sprs32): Likewise.
	(fill_gprs64): Likewise.
	(fill_gprs32): Likewise.
	(fill_sprs64): Likewise.
	(fill_sprs32): Likewise.
	(store_regs_user_thread): Likewise.
	(store_regs_kernel_thread): Likewise.
	* alpha-bsd-nat.c (alphabsd_fetch_inferior_registers): Likewise.
	(alphabsd_store_inferior_registers): Likewise.
	* alpha-tdep.c (alpha_extract_return_value): Likewise.
	(alpha_store_return_value): Likewise.
	(alpha_deal_with_atomic_sequence): Likewise.
	(alpha_next_pc): Likewise.
	(alpha_software_single_step): Likewise.
	* amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Likewise.
	(amd64bsd_store_inferior_registers): Likewise.
	* amd64-linux-nat.c (amd64_linux_fetch_inferior_registers):
	Likewise.
	(amd64_linux_store_inferior_registers): Likewise.
	* amd64-nat.c (amd64_supply_native_gregset): Likewise.
	(amd64_collect_native_gregset): Likewise.
	* amd64-obsd-tdep.c (amd64obsd_supply_uthread): Likewise.
	(amd64obsd_collect_uthread): Likewise.
	* amd64-tdep.c (amd64_supply_fpregset): Likewise.
	(amd64_collect_fpregset): Likewise.
	(amd64_supply_fxsave): Likewise.
	(amd64_supply_xsave): Likewise.
	(amd64_collect_fxsave): Likewise.
	(amd64_collect_xsave): Likewise.
	* arc-tdep.c (arc_write_pc): Likewise.
	* arch-utils.c (default_skip_permanent_breakpoint): Likewise.
	* arm-fbsd-nat.c (arm_fbsd_fetch_inferior_registers): Likewise.
	(arm_fbsd_store_inferior_registers): Likewise.
	* arm-linux-nat.c (fetch_vfp_regs): Likewise.
	(store_vfp_regs): Likewise.
	(arm_linux_fetch_inferior_registers): Likewise.
	(arm_linux_store_inferior_registers): Likewise.
	* arm-linux-tdep.c (arm_linux_supply_gregset): Likewise.
	(arm_linux_sigreturn_next_pc): Likewise.
	(arm_linux_get_next_pcs_syscall_next_pc): Likewise.
	* arm-nbsd-nat.c (arm_supply_gregset): Likewise.
	(fetch_register): Likewise.
	(store_register): Likewise.
	* arm-tdep.c (arm_is_thumb): Likewise.
	(displaced_in_arm_mode): Likewise.
	(bx_write_pc): Likewise.
	(arm_get_next_pcs_addr_bits_remove): Likewise.
	(arm_software_single_step): Likewise.
	(arm_extract_return_value): Likewise.
	(arm_store_return_value): Likewise.
	(arm_write_pc): Likewise.
	* bfin-tdep.c (bfin_extract_return_value): Likewise.
	* bsd-uthread.c (bsd_uthread_fetch_registers): Likewise.
	(bsd_uthread_store_registers): Likewise.
	* core-regset.c (fetch_core_registers): Likewise.
	* corelow.c (get_core_registers): Likewise.
	* cris-tdep.c (cris_store_return_value): Likewise.
	(cris_extract_return_value): Likewise.
	(find_step_target): Likewise.
	(find_step_target): Likewise.
	(cris_software_single_step): Likewise.
	* ctf.c (ctf_fetch_registers): Likewise.
	* darwin-nat.c (cancel_breakpoint): Likewise.
	* fbsd-tdep.c (fbsd_collect_thread_registers): Likewise.
	* frv-tdep.c (frv_extract_return_value): Likewise.
	* ft32-tdep.c (ft32_store_return_value): Likewise.
	(ft32_extract_return_value): Likewise.
	* go32-nat.c (fetch_register): Likewise.
	(go32_fetch_registers): Likewise.
	(go32_store_registers): Likewise.
	(store_register): Likewise.
	* h8300-tdep.c (h8300_extract_return_value): Likewise.
	(h8300_store_return_value): Likewise.
	* hppa-linux-nat.c (fetch_register): Likewise.
	(store_register): Likewise.
	(hppa_linux_fetch_inferior_registers): Likewise.
	(hppa_linux_store_inferior_registers): Likewise.
	* i386-darwin-nat.c (i386_darwin_fetch_inferior_registers): Likewise.
	(i386_darwin_store_inferior_registers): Likewise.
	* i386-gnu-nat.c (gnu_fetch_registers): Likewise.
	(gnu_store_registers): Likewise.
	* i386-linux-nat.c (fetch_register): Likewise.
	(store_register): Likewise.
	(supply_gregset): Likewise.
	(fill_gregset): Likewise.
	(i386_linux_fetch_inferior_registers): Likewise.
	(i386_linux_store_inferior_registers): Likewise.
	(i386_linux_resume): Likewise.
	* i386-linux-tdep.c (i386_linux_get_syscall_number_from_regcache):
	Likewise.
	* i386-nto-tdep.c (i386nto_supply_gregset): Likewise.
	* i386-obsd-nat.c (i386obsd_supply_pcb): Likewise.
	* i386-obsd-tdep.c (i386obsd_supply_uthread): Likewise.
	(i386obsd_collect_uthread): Likewise.
	* i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
	(i386_supply_gregset): Likewise.
	(i386_collect_gregset): Likewise.
	(i386_supply_fpregset): Likewise.
	(i386_collect_fpregset): Likewise.
	(i386_mpx_bd_base): Likewise.
	* i386-v4-nat.c	(supply_fpregset): Likewise.
	(fill_fpregset): Likewise.
	* i387-tdep.c (i387_supply_fsave): Likewise.
	(i387_collect_fsave): Likewise.
	(i387_supply_fxsave): Likewise.
	(i387_collect_fxsave): Likewise.
	(i387_supply_xsave): Likewise.
	(i387_collect_xsave): Likewise.
	* ia64-linux-nat.c (ia64_linux_fetch_registers): Likewise.
	(ia64_linux_store_registers): Likewise.
	* ia64-tdep.c (ia64_access_rse_reg): Likewise.
	(ia64_extract_return_value): Likewise.
	(ia64_store_return_value): Likewise.
	(find_func_descr): Likewise.
	* inf-child.c (inf_child_fetch_inferior_registers): Likewise.
	* inf-ptrace.c (inf_ptrace_fetch_registers): Likewise.
	(inf_ptrace_store_registers): Likewise.
	* infrun.c (use_displaced_stepping): Likewise.
	(displaced_step_prepare_throw): Likewise.
	(resume): Likewise.
	(proceed): Likewise.
	(do_target_wait): Likewise.
	(adjust_pc_after_break): Likewise.
	(handle_inferior_event_1): Likewise.
	(handle_signal_stop): Likewise.
	(save_infcall_suspend_state): Likewise.
	(restore_infcall_suspend_state): Likewise.
	* iq2000-tdep.c (iq2000_extract_return_value): Likewise.
	* jit.c (jit_frame_prev_register): Likewise.
	* linux-nat.c (save_stop_reason): Likewise.
	(linux_nat_wait_1): Likewise.
	(resume_stopped_resumed_lwps): Likewise.
	* linux-record.c (record_linux_sockaddr): Likewise.
	(record_linux_msghdr): Likewise.
	(record_linux_system_call): Likewise.
	* linux-tdep.c (linux_collect_thread_registers): Likewise.
	* lm32-tdep.c (lm32_extract_return_value): Likewise.
	(lm32_store_return_value): Likewise.
	* m32c-tdep.c (m32c_read_flg): Likewise.
	(m32c_pseudo_register_read): Likewise.
	(m32c_pseudo_register_write): Likewise.
	* m32r-linux-tdep.c (m32r_linux_supply_gregset): Likewise.
	(m32r_linux_collect_gregset): Likewise.
	* m32r-tdep.c (m32r_store_return_value): Likewise.
	(m32r_extract_return_value): Likewise.
	* m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
	(m68kbsd_collect_fpregset): Likewise.
	* m68k-bsd-tdep.c (m68kbsd_supply_fpregset): Likewise.
	* m68k-linux-nat.c (fetch_register): Likewise.
	(old_fetch_inferior_registers): Likewise.
	(old_store_inferior_registers): Likewise.
	(store_regs): Likewise.
	* m68k-tdep.c (m68k_svr4_extract_return_value): Likewise.
	(m68k_svr4_store_return_value): Likewise.
	* m88k-tdep.c (m88k_store_arguments): Likewise.
	* mi/mi-main.c (mi_cmd_data_list_changed_registers): Likewise.
	(mi_cmd_data_write_register_values): Likewise.
	* mips-fbsd-nat.c (mips_fbsd_fetch_inferior_registers): Likewise.
	(mips_fbsd_store_inferior_registers): Likewise.
	* mips-fbsd-tdep.c (mips_fbsd_supply_fpregs): Likewise.
	(mips_fbsd_supply_gregs): Likewise.
	(mips_fbsd_collect_fpregs): Likewise.
	(mips_fbsd_collect_gregs): Likewise.
	(mips_fbsd_supply_fpregset): Likewise.
	(mips_fbsd_collect_fpregset): Likewise.
	(mips_fbsd_supply_gregset): Likewise.
	(mips_fbsd_collect_gregset): Likewise.
	* mips-linux-nat.c (supply_gregset): Likewise.
	(fill_gregset): Likewise.
	(supply_fpregset): Likewise.
	(fill_fpregset): Likewise.
	* mips-linux-tdep.c (mips_supply_gregset): Likewise.
	(mips_fill_gregset): Likewise.
	(mips_supply_fpregset): Likewise.
	(mips_fill_fpregset): Likewise.
	(mips64_supply_gregset): Likewise.
	(micromips_linux_sigframe_validate): Likewise.
	* mips-nbsd-nat.c (mipsnbsd_fetch_inferior_registers): Likewise.
	(mipsnbsd_fetch_inferior_registers): Likewise.
	(mipsnbsd_store_inferior_registers): Likewise.
	* mips-nbsd-tdep.c (mipsnbsd_supply_fpregset): Likewise.
	(mipsnbsd_supply_gregset): Likewise.
	(mipsnbsd_iterate_over_regset_sections): Likewise.
	(mipsnbsd_supply_reg): Likewise.
	(mipsnbsd_supply_fpreg): Likewise.
	* mips-tdep.c (mips_in_frame_stub): Likewise.
	(mips_dummy_id): Likewise.
	(is_octeon_bbit_op): Likewise.
	(micromips_bc1_pc): Likewise.
	(extended_mips16_next_pc): Likewise.
	(mips16_next_pc): Likewise.
	(deal_with_atomic_sequence): Likewise.
	* moxie-tdep.c (moxie_process_readu): Likewise.
	* nios2-tdep.c (nios2_get_next_pc): Likewise.
	* nto-procfs.c (procfs_store_registers): Likewise.
	* ppc-fbsd-nat.c (ppcfbsd_fetch_inferior_registers): Likewise.
	(ppcfbsd_store_inferior_registers): Likewise.
	* ppc-linux-nat.c (fetch_vsx_register): Likewise.
	(fetch_altivec_register): Likewise.
	(get_spe_registers): Likewise.
	(fetch_spe_register): Likewise.
	(fetch_altivec_registers): Likewise.
	(fetch_all_gp_regs): Likewise.
	(fetch_all_fp_regs): Likewise.
	(store_vsx_register): Likewise.
	(store_altivec_register): Likewise.
	(set_spe_registers): Likewise.
	(store_spe_register): Likewise.
	(store_altivec_registers): Likewise.
	(store_all_gp_regs): Likewise.
	(store_all_fp_regs): Likewise.
	* ppc-linux-tdep.c (ppc_linux_supply_gregset): Likewise.
	(ppc_linux_collect_gregset): Likewise.
	(ppc_canonicalize_syscall): Likewise.
	(ppc_linux_record_signal): Likewise.
	(ppu2spu_prev_register): Likewise.
	* ppc-nbsd-nat.c (ppcnbsd_supply_pcb): Likewise.
	* ppc-obsd-nat.c (ppcobsd_fetch_registers): Likewise.
	(ppcobsd_store_registers): Likewise.
	* ppc-ravenscar-thread.c (ppc_ravenscar_generic_fetch_registers):
	Likewise.
	(ppc_ravenscar_generic_store_registers): Likewise.
	* procfs.c (procfs_fetch_registers): Likewise.
	(procfs_store_registers): Likewise.
	* ravenscar-thread.c (ravenscar_fetch_registers): Likewise.
	(ravenscar_store_registers): Likewise.
	(ravenscar_prepare_to_store): Likewise.
	* record-btrace.c (record_btrace_fetch_registers): Likewise.
	* record-full.c (record_full_wait_1): Likewise.
	(record_full_registers_change): Likewise.
	(record_full_store_registers): Likewise.
	(record_full_core_fetch_registers): Likewise.
	(record_full_save): Likewise.
	(record_full_goto_insn): Likewise.
	* regcache.c (regcache_register_size): Likewise.
	(get_regcache_arch): Remove.
	(regcache_read_pc): Likewise.
	* regcache.h (get_regcache_arch): Remove.
	* remote-sim.c (gdbsim_fetch_register): Likewise.
	(gdbsim_store_register): Likewise.
	* remote.c (fetch_register_using_p): Likewise.
	(send_g_packet): Likewise.
	(remote_prepare_to_store): Likewise.
	(store_registers_using_G): Likewise.
	* reverse.c (save_bookmark_command): Likewise.
	(goto_bookmark_command): Likewise.
	* rs6000-aix-tdep.c (branch_dest): Likewise.
	* rs6000-nat.c (rs6000_ptrace64): Likewise.
	(fetch_register): Likewise.
	* rs6000-tdep.c (ppc_supply_reg): Likewise.
	(ppc_collect_reg): Likewise.
	(ppc_collect_gregset): Likewise.
	(ppc_collect_fpregset): Likewise.
	(ppc_collect_vsxregset): Likewise.
	(ppc_collect_vrregset): Likewise.
	(ppc_displaced_step_hw_singlestep): Likewise.
	(rs6000_pseudo_register_read): Likewise.
	(rs6000_pseudo_register_write): Likewise.
	* s390-linux-nat.c (supply_gregset): Likewise.
	(fill_gregset): Likewise.
	(s390_linux_fetch_inferior_registers): Likewise.
	* s390-linux-tdep.c (s390_write_pc): Likewise.
	(s390_software_single_step): Likewise.
	(s390_all_but_pc_registers_record): Likewise.
	(s390_linux_syscall_record): Likewise.
	* sentinel-frame.c (sentinel_frame_prev_arch): Likewise.
	* sh-nbsd-nat.c (shnbsd_fetch_inferior_registers): Likewise.
	(shnbsd_store_inferior_registers): Likewise.
	* sh-tdep.c (sh_extract_return_value_nofpu): Likewise.
	(sh_extract_return_value_fpu): Likewise.
	(sh_store_return_value_nofpu): Likewise.
	(sh_corefile_supply_regset): Likewise.
	(sh_corefile_collect_regset): Likewise.
	* sh64-tdep.c (sh64_extract_return_value): Likewise.
	(sh64_store_return_value): Likewise.
	* sparc-linux-tdep.c (sparc32_linux_collect_core_fpregset): Likewise.
	* sparc-nat.c (sparc_fetch_inferior_registers): Likewise.
	(sparc_store_inferior_registers): Likewise.
	* sparc-ravenscar-thread.c (register_in_thread_descriptor_p): Likewise.
	(sparc_ravenscar_prepare_to_store): Likewise.
	* sparc-tdep.c (sparc32_store_arguments): Likewise.
	(sparc_analyze_control_transfer): Likewise.
	(sparc_step_trap): Likewise.
	(sparc_software_single_step): Likewise.
	(sparc32_gdbarch_init): Likewise.
	(sparc_supply_rwindow): Likewise.
	(sparc_collect_rwindow): Likewise.
	* sparc64-linux-tdep.c (sparc64_linux_collect_core_fpregset): Likewise.
	* sparc64-nbsd-nat.c (sparc64nbsd_supply_gregset): Likewise.
	(sparc64nbsd_collect_gregset): Likewise.
	(sparc64nbsd_supply_fpregset): Likewise.
	(sparc64nbsd_collect_fpregset): Likewise.
	* sparc64-tdep.c (sparc64_store_arguments): Likewise.
	(sparc64_supply_gregset): Likewise.
	(sparc64_collect_gregset): Likewise.
	(sparc64_supply_fpregset): Likewise.
	(sparc64_collect_fpregset): Likewise.
	* spu-linux-nat.c (spu_fetch_inferior_registers): Likewise.
	* spu-tdep.c (spu_unwind_sp): Likewise.
	(spu2ppu_prev_register): Likewise.
	(spu_memory_remove_breakpoint): Likewise.
	* stack.c (return_command): Likewise.
	* tic6x-tdep.c (tic6x_extract_signed_field): Likewise.
	* tracefile-tfile.c (tfile_fetch_registers): Likewise.
	* tracefile.c (trace_save_ctf): Likewise.
	* windows-nat.c (do_windows_fetch_inferior_registers): Likewise.
	(do_windows_store_inferior_registers): Likewise.
	(windows_resume): Likewise.
	* xtensa-linux-nat.c (fill_gregset): Likewise.
	(supply_gregset_reg): Likewise.
	* xtensa-tdep.c (xtensa_register_write_masked): Likewise.
	(xtensa_register_read_masked): Likewise.
	(xtensa_supply_gregset): Likewise.
	(xtensa_extract_return_value): Likewise.
	(xtensa_store_return_value): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Target FP: Use target format throughout expression parsing
@ 2017-10-26 19:34 sergiodj+buildbot
  2017-10-27 17:45 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-26 19:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT edd079d9f6ca2f9ad21322b742269aec5de61190 ***

Author: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Branch: master
Commit: edd079d9f6ca2f9ad21322b742269aec5de61190

Target FP: Use target format throughout expression parsing

When parsing floating-point literals, the language parsers currently
use parse_float or some equivalent routine to parse the input string
into a DOUBLEST, which is then stored within a OP_DOUBLE expression
node.  When evaluating the expression, the OP_DOUBLE is finally
converted into a value in target format.

On the other hand, *decimal* floating-point literals are parsed
directly into target format and stored that way in a OP_DECFLOAT
expression node.  In order to eliminate the DOUBLEST, this patch
therefore unifies the handling of binary and decimal floating-
point literals and stores them both in target format within a
new OP_FLOAT expression node, replacing both OP_DOUBLE and
OP_DECFLOAT.

In order to store literals in target format, the parse_float
routine needs to know the type of the literal.  All parsers
therefore need to be changed to determine the appropriate type
(e.g. by detecting suffixes) *before* calling parse_float,
instead of after it as today.  However, this change is mostly
straightforward -- again, this is already done for decimal FP
today.

The core of the literal parsing is moved into a new routine
floatformat_from_string, mirroring floatformat_to_string.
The parse_float routine now calls either floatformat_from_string
or decimal_from_sting, allowing it to handle any type of FP
literal.

All language parsers need to be updated.  Some notes on
specific changes to the various languages:

- C: Decimal FP is now handled in parse_float, and no longer
  needs to be handled specially.

- D: Straightforward.

- Fortran: Still used a hard-coded "atof", also replaced by
  parse_float now.  Continues to always use builtin_real_s8
  as the type of literal, even though this is probably wrong.

- Go: This used to handle "f" and "l" suffixes, even though
  the Go language actually doesn't support those.  I kept this
  support for now -- maybe revisit later.  Note the the GDB
  test suite for some reason actually *verifies* that GDB supports
  those unsupported suffixes ...

- Pascal: Likewise -- this handles suffixes that are not
  supported in the language standard.

- Modula-2: Like Fortran, used to use "atof".

- Rust: Mostly straightforward, except for a unit-testing hitch.
  The code use to set a special "unit_testing" flag which would
  cause "rust_type" to always return NULL.  This makes it not
  possible to encode a literal into target format (which type?).
  The reason for this flag appears to have been that during
  unit testing, there is no "rust_parser" context set up, which
  means no "gdbarch" is available to use its types.  To fix this,
  I removed the unit_testing flag, and instead simply just set up
  a dummy rust_parser context during unit testing.

- Ada: This used to check sizeof (DOUBLEST) to determine which
  type to use for floating-point literal.  This seems questionable
  to begin with (since DOUBLEST is quite unrelated to target formats),
  and in any case we need to get rid of DOUBLEST.  I'm now simply
  always using the largest type (builtin_long_double).

gdb/ChangeLog:
2017-10-25  Ulrich Weigand  <uweigand@de.ibm.com>

	* doublest.c (floatformat_from_string): New function.
	* doublest.h (floatformat_from_string): Add prototype.

	* std-operator.def (OP_DOUBLE, OP_DECFLOAT): Remove, replace by ...
	(OP_FLOAT): ... this.
	* expression.h: Do not include "doublest.h".
	(union exp_element): Replace doubleconst and decfloatconst by
	new element floatconst.
	* ada-lang.c (resolve_subexp): Handle OP_FLOAT instead of OP_DOUBLE.
	(ada_evaluate_subexp): Likewise.
	* eval.c (evaluate_subexp_standard): Handle OP_FLOAT instead of
	OP_DOUBLE and OP_DECFLOAT.
	* expprint.c (print_subexp_standard): Likewise.
	(dump_subexp_body_standard): Likewise.
	* breakpoint.c (watchpoint_exp_is_const): Likewise.

	* parse.c: Include "dfp.h".
	(write_exp_elt_dblcst, write_exp_elt_decfloatcst): Remove.
	(write_exp_elt_floatcst): New function.
	(operator_length_standard): Handle OP_FLOAT instead of OP_DOUBLE
	and OP_DECFLOAT.
	(operator_check_standard): Likewise.
	(parse_float): Do not accept suffix.  Take type as input.  Return bool.
	Return target format buffer instead of host DOUBLEST.
	Use floatformat_from_string and decimal_from_string to parse
	either binary or decimal floating-point types.
	(parse_c_float): Remove.
	* parser-defs.h: Do not include "doublest.h".
	(write_exp_elt_dblcst, write_exp_elt_decfloatcst): Remove.
	(write_exp_elt_floatcst): Add prototype.
	(parse_float): Update prototype.
	(parse_c_float): Remove.

	* c-exp.y: Do not include "dfp.h".
	(typed_val_float): Use byte buffer instead of DOUBLEST.
	(typed_val_decfloat): Remove.
	(DECFLOAT): Remove.
	(FLOAT): Use OP_FLOAT and write_exp_elt_floatcst.
	(parse_number): Update to new parse_float interface.
	Parse suffixes and determine type before calling parse_float.
	Handle decimal and binary FP types the same way.

	* d-exp.y (typed_val_float): Use byte buffer instead of DOUBLEST.
	(FLOAT_LITERAL): Use OP_FLOAT and write_exp_elt_floatcst.
	(parse_number): Update to new parse_float interface.
	Parse suffixes and determine type before calling parse_float.

	* f-exp.y: Replace dval by typed_val_float.
	(FLOAT): Use OP_FLOAT and write_exp_elt_floatcst.
	(parse_number): Use parse_float instead of atof.

	* go-exp.y (typed_val_float): Use byte buffer instead of DOUBLEST.
	(parse_go_float): Remove.
	(FLOAT): Use OP_FLOAT and write_exp_elt_floatcst.
	(parse_number): Call parse_float instead of parse_go_float.
	Parse suffixes and determine type before calling parse_float.

	* p-exp.y (typed_val_float): Use byte buffer instead of DOUBLEST.
	(FLOAT): Use OP_FLOAT and write_exp_elt_floatcst.
	(parse_number): Update to new parse_float interface.
	Parse suffixes and determine type before calling parse_float.

	* m2-exp.y: Replace dval by byte buffer val.
	(FLOAT): Use OP_FLOAT and write_exp_elt_floatcst.
	(parse_number): Call parse_float instead of atof.

	* rust-exp.y (typed_val_float): Use byte buffer instead of DOUBLEST.
	(lex_number): Call parse_float instead of strtod.
	(ast_dliteral): Use OP_FLOAT instead of OP_DOUBLE.
	(convert_ast_to_expression): Handle OP_FLOAT instead of OP_DOUBLE.
	Use write_exp_elt_floatcst.
	(unit_testing): Remove static variable.
	(rust_type): Do not check unit_testing.
	(rust_lex_tests): Do not set uint_testing.  Set up dummy rust_parser.

	* ada-exp.y (type_float, type_double): Remove.
	(typed_val_float): Use byte buffer instead of DOUBLEST.
	(FLOAT): Use OP_FLOAT and write_exp_elt_floatcst.
	* ada-lex.l (processReal): Use parse_float instead of sscanf.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Use const reference for decimal_from_string argument
@ 2017-10-26 16:36 sergiodj+buildbot
  2017-10-27  9:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-26 16:36 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 09a7c6aa7a07f874f5357cde62b5753a10a5e107 ***

Author: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Branch: master
Commit: 09a7c6aa7a07f874f5357cde62b5753a10a5e107

Use const reference for decimal_from_string argument

No functional change.

gdb/ChangeLog:
2017-10-24  Ulrich Weigand  <uweigand@de.ibm.com>

	* dfp.h (decimal_from_string): Use const reference for argument.
	* dfp.c (decimal_from_string): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix unstable test names in gdb.python/py-objfile.exp
@ 2017-10-26 16:13 sergiodj+buildbot
  2017-10-26 20:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-26 16:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ad9b8f5d022f777f32cceab9856f47a5b6afcce1 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: ad9b8f5d022f777f32cceab9856f47a5b6afcce1

Fix unstable test names in gdb.python/py-objfile.exp

Currently, if you diff testsuite/gdb.sum of different builds you see
this spurious hunk:

  -PASS: gdb.python/py-objfile.exp: get python valueof "sep_objfile.build_id" (6a0bfcab663f9810ccff33c756afdebb940037d4)
  +PASS: gdb.python/py-objfile.exp: get python valueof "sep_objfile.build_id" (1f5531c657c57777b05fc95baa0025fd1d115c3b)

Fix this by syncing get_python_valueof with get_integer_valueof, which
stopped outputting the value in commit 2f20e312aad6
("get_integer_valueof: Don't output value in test name").

After this commit we'll show:

  PASS: gdb.python/py-objfile.exp: get python valueof "sep_objfile.build_id"

As the comment explicitly says get_python_valueof is modeled on
get_integer_valueof, I went ahead and also added the optional 'test'
parameter while at it.

gdb/testsuite/ChangeLog:
2017-10-24  Pedro Alves  <palves@redhat.com>

	* lib/gdb-python.exp (get_python_valueof): Add 'test' optional
	parameter and handle it.  Don't output read value in test name.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix unstable test names in gdb.gdb/unittest.exp
@ 2017-10-26 14:44 sergiodj+buildbot
  2017-10-26 19:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-26 14:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fee6da6e1d96796f8aa8308b3833a3e4cdb409ff ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: fee6da6e1d96796f8aa8308b3833a3e4cdb409ff

Fix unstable test names in gdb.gdb/unittest.exp

Currently, if you diff testsuite/gdb.sum of two builds built from different
source directories you see this spurious hunk:

  -PASS: gdb.gdb/unittest.exp: maintenance check xml-descriptions /home/pedro/gdb1/src/gdb/testsuite/../features
  +PASS: gdb.gdb/unittest.exp: maintenance check xml-descriptions /home/pedro/gdb2/src/gdb/testsuite/../features

After this commit we'll show instead:

  PASS: gdb.gdb/unittest.exp: maintenance check xml-descriptions ${srcdir}/../features

gdb/testsuite/ChangeLog:
2017-10-24  Pedro Alves  <palves@redhat.com>

	* gdb.gdb/unittest.exp ('maintenance check xml-descriptions'): Use
	custom test name.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] RISC-V: Only relax to C.LUI when imm != 0 and rd != 0/2
@ 2017-10-26 14:06 sergiodj+buildbot
  2017-10-27  4:00 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-26 14:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3342be5dabeeaf2218dfbf4d38f92214612436f4 ***

Author: Andrew Waterman <andrew@sifive.com>
Branch: master
Commit: 3342be5dabeeaf2218dfbf4d38f92214612436f4

RISC-V: Only relax to C.LUI when imm != 0 and rd != 0/2

This matches the ISA specification.  This also adds two tests: one to
make sure the assembler rejects invalid 'c.lui's, and one to make sure
we only relax valid 'c.lui's.

bfd/ChangeLog

2017-10-24  Andrew Waterman  <andrew@sifive.com>

        * elfnn-riscv.c (_bfd_riscv_relax_lui): Don't relax to c.lui
        when rd is x0.

include/ChangeLog

2017-10-24  Andrew Waterman  <andrew@sifive.com>

        * opcode/riscv.h (VALID_RVC_LUI_IMM): c.lui can't load the
        immediate 0.

gas/ChangeLog

2017-10-24  Andrew Waterman  <andrew@sifive.com>

        * testsuite/gas/riscv/c-lui-fail.d: New testcase.
        gas/testsuite/gas/riscv/c-lui-fail.l: Likewise.
        gas/testsuite/gas/riscv/c-lui-fail.s: Likewise.
        gas/testsuite/gas/riscv/riscv.exp: Likewise.

ld/ChangeLog

2017-10-24  Andrew Waterman  <andrew@sifive.com>

        * ld/testsuite/ld-riscv-elf/c-lui.d: New testcase.
        ld/testsuite/ld-riscv-elf/c-lui.s: Likewise.
        ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp: New test suite.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix gdb.opt/inline-cmds.exp regressions
@ 2017-10-26 13:38 sergiodj+buildbot
  2017-10-27  2:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-26 13:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5033013f17524964564dac5d422739ae5214729e ***

Author: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Branch: master
Commit: 5033013f17524964564dac5d422739ae5214729e

Fix gdb.opt/inline-cmds.exp regressions

When sorting pending blocks in end_symtab_get_static_block, blocks
with the same starting address must remain in the original order
to preserve inline function caller/callee relationships.

The original code seems to have implicitly relied on the fact that the
glibc qsort implemention actually (in the common case) provides a stable
sort, although this is not guaranteed by the standard.  But the GNU
libstdc++ std::sort implementation is *not* stable.

gdb/ChangeLog:
2017-10-24  Ulrich Weigand  <uweigand@de.ibm.com>

	* buildsym.c (end_symtab_get_static_block): Use std::stable_sort.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Reindent gdb.threads/attach-into-signal.exp
@ 2017-10-26 12:26 sergiodj+buildbot
  2017-10-27  0:10 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-26 12:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT eb2bfbadc159ff1463e58daf24c4ad5d1a23796d ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: eb2bfbadc159ff1463e58daf24c4ad5d1a23796d

Reindent gdb.threads/attach-into-signal.exp

A previous patch removed one nesting level.

gdb/testsuite/ChangeLog:
2017-10-24  Pedro Alves  <palves@redhat.com>

	* gdb.threads/attach-into-signal.exp (corefunc): Reindent.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Drop /proc/PID/status polling from gdb.threads/attach-into-signal.exp
@ 2017-10-26 11:38 sergiodj+buildbot
  2017-10-26 22:57 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-26 11:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1f75a6516a4b480b5521dfb4e1a0721887ab5cdc ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 1f75a6516a4b480b5521dfb4e1a0721887ab5cdc

Drop /proc/PID/status polling from gdb.threads/attach-into-signal.exp

I noticed that the 'with_test_prefix "stoppedtry $stoppedtry"' prefix
in this testcase is unnecessary, because inside that block there are
no pass/fail calls.  In fact the block includes a comment saying:

  # No PASS message as we may be looping in multiple
  # attempts.

but looking deeper at this I noticed a few odd things with this code
block:

1. This code is assuming that the second line in the /proc/PID/status
   files is the "State:" line, which may have been true when this was
   originally written, but is not true on my machine at least (Linux
   4.8.13).

     $ cat /proc/self/status
     Name:   cat
     Umask:  0002
     State:  R (running)

   So nowadays, that 'string match "*(stopped)*"' is running against
   the "Umask:" line and thus always returns false, meaning the loop
   always breaks on $stoppedtry == 0.

2. The loop seems to be waiting for the process to become "(stopped)",
   but if so then that 'if {![string match]}' check is reversed, it
   should be checking 'if {[string match]}' instead, because "string
   match" returns true if the string matches, not 0.

3. But if we fixed all that, we'd still run into the simple fact that
   nothing is actually stopping the test's inferior process before GDB
   attaches...  The top of the testcase says:

    # This test was created by modifying attach-stopped.exp.

   ... and attach-stopped.exp does have:

       # Stop the program
       remote_exec build "kill -s STOP ${testpid}"

   but then attach-stopped.exp doesn't have an equivalent
   /proc/PID/status poll loop...  (Maybe it could.)

So remove this whole loop as useless.

gdb/testsuite/ChangeLog:
2017-10-24  Pedro Alves  <palves@redhat.com>

	* gdb.threads/attach-into-signal.exp: Remove whole "stoppedtry"
	loop.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix unstable test names in gdb.base/startup-with-shell.exp
@ 2017-10-26  9:40 sergiodj+buildbot
  2017-10-26 18:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-26  9:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 10389c2c8b56b2519441e55bf16f77882fb897cb ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 10389c2c8b56b2519441e55bf16f77882fb897cb

Fix unstable test names in gdb.base/startup-with-shell.exp

Currently, if you diff testsuite/gdb.sum of two builds in different
directories you see these spurious hunks:

  -PASS: gdb.base/startup-with-shell.exp: touch /home/pedro/gdb1/build/gdb/testsuite/outputs/gdb.base/startup-with-shell/unique-file.unique-extension
  +PASS: gdb.base/startup-with-shell.exp: touch /home/pedro/gdb2/build/gdb/testsuite/outputs/gdb.base/startup-with-shell/unique-file.unique-extension

  -PASS: gdb.base/startup-with-shell.exp: startup_with_shell = on; run_args = *.unique-extension: set args /home/pedro/gdb1/build/gdb/testsuite/outputs/gdb.base/startup-with-shell/*.unique-extension
  +PASS: gdb.base/startup-with-shell.exp: startup_with_shell = on; run_args = *.unique-extension: set args /home/pedro/gdb2/build/gdb/testsuite/outputs/gdb.base/startup-with-shell/*.unique-extension

  -PASS: gdb.base/startup-with-shell.exp: startup_with_shell = off; run_args = *.unique-extension: set args /home/pedro/gdb1/build/gdb/testsuite/outputs/gdb.base/startup-with-shell/*.unique-extension
  +PASS: gdb.base/startup-with-shell.exp: startup_with_shell = off; run_args = *.unique-extension: set args /home/pedro/gdb2/build/gdb/testsuite/outputs/gdb.base/startup-with-shell/*.unique-extension

Since the run_args arguments are already shown in the test prefix, we
can change the "set args" test name to literally "set args $run_args".
I.e., after this commit we'll show:

  PASS: gdb.base/startup-with-shell.exp: startup_with_shell = on; run_args = *.unique-extension: set args $run_args
  PASS: gdb.base/startup-with-shell.exp: startup_with_shell = off; run_args = *.unique-extension: set args $run_args
  PASS: gdb.base/startup-with-shell.exp: startup_with_shell = on; run_args = $TEST: set args $run_args
  PASS: gdb.base/startup-with-shell.exp: startup_with_shell = off; run_args = $TEST: set args $run_args

gdb/testsuite/ChangeLog:
2017-10-24  Pedro Alves  <palves@redhat.com>

	* gdb.base/startup-with-shell.exp ('touch $unique_file'): Don't
	include the unstable output directory name in the test's name.
	(initial_setup_simple) <'set args'>: Use custom test name.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make sure that undefined symbols added to the linker command line via the -u option appear in the output executable, if they have not been resolved.
@ 2017-10-26  8:44 sergiodj+buildbot
  2017-10-26 14:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-26  8:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 66cae56016a12f7cbdc94be6f82c1cad1c59b521 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 66cae56016a12f7cbdc94be6f82c1cad1c59b521

Make sure that undefined symbols added to the linker command line via the -u option appear in the output executable, if they have not been resolved.

	PR 22319
bfd	* elflink.c (elf_link_output_extsym): Keep global undefined
	symbols if they have been marked as needed.

ld	* testsuite/ld-elf/pr22310.s: New test source file.
	* testsuite/ld-elf/pr22310.d: New test driver.
	* testsuite/ld-mmix/undef-3.d: Update expected output from readelf.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix the master due to bad regenerated files
@ 2017-10-26  7:51 sergiodj+buildbot
  2017-10-26 12:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-26  7:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fe4e2a3c9281851c9da99a6e36a2bc96e4279476 ***

Author: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
Branch: master
Commit: fe4e2a3c9281851c9da99a6e36a2bc96e4279476

Fix the master due to bad regenerated files

	* i386-init.h: Regenerate
	* i386-tbl.h: Likewise


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Enable Intel VAES instructions.
@ 2017-10-26  7:22 sergiodj+buildbot
  2017-10-26  9:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-26  7:22 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8dcf1fadf2b0763962639fc5dcedc1892e502265 ***

Author: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
Branch: master
Commit: 8dcf1fadf2b0763962639fc5dcedc1892e502265

Enable Intel VAES instructions.

Intel has disclosed a set of new instructions. The spec is
https://software.intel.com/sites/default/files/managed/c5/15/architecture-instruction-set-extensions-programming-reference.pdf

gas/

	* config/tc-i386.c (cpu_arch): Add VAES.
	* doc/c-i386.texi: Document VAES.
	* testsuite/gas/i386/i386.exp: Run VAES tests.
	* testsuite/gas/i386/avx512f_vaes-intel.d: New test.
	* testsuite/gas/i386/avx512f_vaes-wig.s: Ditto.
	* testsuite/gas/i386/avx512f_vaes-wig1-intel.d: Ditto.
	* testsuite/gas/i386/avx512f_vaes-wig1.d: Ditto.
	* testsuite/gas/i386/avx512f_vaes.d: Ditto.
	* testsuite/gas/i386/avx512f_vaes.s: Ditto.
	* testsuite/gas/i386/avx512vl_vaes-intel.d: Ditto.
	* testsuite/gas/i386/avx512vl_vaes-wig.s: Ditto.
	* testsuite/gas/i386/avx512vl_vaes-wig1-intel.d: Ditto.
	* testsuite/gas/i386/avx512vl_vaes-wig1.d: Ditto.
	* testsuite/gas/i386/avx512vl_vaes.d: Ditto.
	* testsuite/gas/i386/avx512vl_vaes.s: Ditto.
	* testsuite/gas/i386/vaes-intel.d: Ditto.
	* testsuite/gas/i386/vaes.d: Ditto.
	* testsuite/gas/i386/vaes.s: Ditto.
	* testsuite/gas/i386/x86-64-avx512f_vaes-intel.d: Ditto.
	* testsuite/gas/i386/x86-64-avx512f_vaes-wig.s: Ditto.
	* testsuite/gas/i386/x86-64-avx512f_vaes-wig1-intel.d: Ditto.
	* testsuite/gas/i386/x86-64-avx512f_vaes-wig1.d: Ditto.
	* testsuite/gas/i386/x86-64-avx512f_vaes.d: Ditto.
	* testsuite/gas/i386/x86-64-avx512f_vaes.s: Ditto.
	* testsuite/gas/i386/x86-64-avx512vl_vaes-intel.d: Ditto.
	* testsuite/gas/i386/x86-64-avx512vl_vaes-wig.s: Ditto.
	* testsuite/gas/i386/x86-64-avx512vl_vaes-wig1-intel.d: Ditto.
	* testsuite/gas/i386/x86-64-avx512vl_vaes-wig1.d: Ditto.
	* testsuite/gas/i386/x86-64-avx512vl_vaes.d: Ditto.
	* testsuite/gas/i386/x86-64-avx512vl_vaes.s: Ditto.
	* testsuite/gas/i386/x86-64-vaes-intel.d: Ditto.
	* testsuite/gas/i386/x86-64-vaes.d: Ditto.
	* testsuite/gas/i386/x86-64-vaes.s: Ditto.

opcodes/

	* i386-dis.c (enum): Add PREFIX_EVEX_0F38DC, PREFIX_EVEX_0F38DD,
	PREFIX_EVEX_0F38DE, PREFIX_EVEX_0F38DF.
	(enum): Remove VEX_LEN_0F38DC_P_2, VEX_LEN_0F38DD_P_2,
	VEX_LEN_0F38DE_P_2, VEX_LEN_0F38DF_P_2.
	(vex_len_table): Ditto.
	(enum): Remove VEX_W_0F38DC_P_2, VEX_W_0F38DD_P_2,
	VEX_W_0F38DE_P_2, VEX_W_0F38DF_P_2.
	(vew_w_table): Ditto.
	(prefix_table): Adjust instructions (see prefixes above).
	* i386-dis-evex.h (evex_table):
	Add new instructions (see prefixes above).
	* i386-gen.c (cpu_flag_init): Add VAES.
	(bitfield_cpu_flags): Ditto.
	* i386-opc.h (enum): Ditto.
	(i386_cpu_flags): Ditto.
	* i386-opc.tbl (vaes{enc,dec}{last,}): New instructions.
	* i386-init.h: Regenerate.
	* i386-tbl.h: Ditto.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add overloads of for_each_thread/find_thread that filter on pid
@ 2017-10-21 17:42 sergiodj+buildbot
  2017-10-21 20:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-21 17:42 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4d3bb80e5db40cd2308157db3c446f35ae97a915 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 4d3bb80e5db40cd2308157db3c446f35ae97a915

Add overloads of for_each_thread/find_thread that filter on pid

It happens often that we want to iterate or find threads restricted to a
given pid.  I think it's worth having an overload to help with this.
Right now there is a single user of each of the find_thread and
for_each_thread overload, but as we replace the usages of find_inferior
with for_each_thread/find_thread, more usages will pop up.

gdb/gdbserver/ChangeLog:

	* gdbthread.h (find_thread, for_each_thread): New functions.
	* inferiors.c (thread_of_pid): Remove.
	(find_any_thread_of_pid): Use find_thread.
	* linux-low.c (num_lwps): Use for_each_thread.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Create a displaced_step_closure class hierarchy
@ 2017-10-21 15:59 sergiodj+buildbot
  2017-10-21 16:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-21 15:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cfba98720f62473abc54457a376a3b7aa7ab1e40 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: cfba98720f62473abc54457a376a3b7aa7ab1e40

Create a displaced_step_closure class hierarchy

displaced_step_closure is a type defined in multiple -tdep.c files.
Trying to xfree it from the common code (infrun.c) is a problem when we
try to poison xfree for non-POD types.  Because there can be multiple of
these types in the same build, this patch makes a hierarchy of classes
with a virtual destructor.  When the common code deletes the object
through a displaced_step_closure pointer, it will invoke the right
destructor.

The amd64 used a last-member array with a variable size.  That doesn't
work with new, so I changed it for an std::vector.  Other architectures
which used a simple byte buffer as a closure now use a shared
buf_displaced_step_closure, a closure type that only contains a
gdb::byte_vector.

Reg-tested on the buildbot.

gdb/ChangeLog:

	* infrun.h: Include common/byte-vector.h.
	(struct displaced_step_closure): New struct.
	(struct buf_displaced_step_closure): New struct.
	* infrun.c (displaced_step_closure::~displaced_step_closure):
	Provide default implementation.
	(displaced_step_clear): Deallocate step closure with delete.
	* aarch64-tdep.c (displaced_step_closure): Rename to ...
	(aarch64_displaced_step_closure): ... this, extend
	displaced_step_closure.
	(aarch64_displaced_step_data) <dsc>: Change type to
	aarch64_displaced_step_closure.
	(aarch64_displaced_step_copy_insn): Adjust to type change, use
	unique_ptr.
	(aarch64_displaced_step_fixup): Add cast for displaced step
	closure.
	* amd64-tdep.c (displaced_step_closure): Rename to ...
	(amd64_displaced_step_closure): ... this, extend
	displaced_step_closure.
	<insn_buf>: Change type to std::vector<gdb_byte>.
	<max_len>: Remove.
	(fixup_riprel): Change type of DSC parameter, adjust to type
	change of insn_buf.
	(fixup_displaced_copy): Change type of DSC parameter.
	(amd64_displaced_step_copy_insn): Instantiate
	amd64_displaced_step_closure.
	(amd64_displaced_step_fixup): Add cast for closure type, adjust
	to type change of insn_buf.
	* arm-linux-tdep.c (arm_linux_cleanup_svc): Change type of
	parameter DSC.
	(arm_linux_copy_svc): Likewise.
	(cleanup_kernel_helper_return): Likewise.
	(arm_catch_kernel_helper_return): Likewise.
	(arm_linux_displaced_step_copy_insn): Instantiate
	arm_displaced_step_closure.
	* arm-tdep.c (arm_pc_is_thumb): Add cast for closure.
	(displaced_read_reg): Change type of parameter DSC.
	(branch_write_pc): Likewise.
	(load_write_pc): Likewise.
	(alu_write_pc): Likewise.
	(displaced_write_reg): Likewise.
	(arm_copy_unmodified): Likewise.
	(thumb_copy_unmodified_32bit): Likewise.
	(thumb_copy_unmodified_16bit): Likewise.
	(cleanup_preload): Likewise.
	(install_preload): Likewise.
	(arm_copy_preload): Likewise.
	(thumb2_copy_preload): Likewise.
	(install_preload_reg): Likewise.
	(arm_copy_preload_reg): Likewise.
	(cleanup_copro_load_store): Likewise.
	(install_copro_load_store): Likewise.
	(arm_copy_copro_load_store) Likewise.
	(thumb2_copy_copro_load_store): Likewise.
	(cleanup_branch): Likewise.
	(install_b_bl_blx): Likewise.
	(arm_copy_b_bl_blx): Likewise.
	(thumb2_copy_b_bl_blx): Likewise.
	(thumb_copy_b): Likewise.
	(install_bx_blx_reg): Likewise.
	(arm_copy_bx_blx_reg): Likewise.
	(thumb_copy_bx_blx_reg): Likewise.
	(cleanup_alu_imm): Likewise.
	(arm_copy_alu_imm): Likewise.
	(thumb2_copy_alu_imm): Likewise.
	(cleanup_alu_reg): Likewise.
	(install_alu_reg): Likewise.
	(arm_copy_alu_reg): Likewise.
	(thumb_copy_alu_reg): Likewise.
	(cleanup_alu_shifted_reg): Likewise.
	(install_alu_shifted_reg): Likewise.
	(arm_copy_alu_shifted_reg): Likewise.
	(cleanup_load): Likewise.
	(cleanup_store): Likewise.
	(arm_copy_extra_ld_st): Likewise.
	(install_load_store): Likewise.
	(thumb2_copy_load_literal): Likewise.
	(thumb2_copy_load_reg_imm): Likewise.
	(arm_copy_ldr_str_ldrb_strb): Likewise.
	(cleanup_block_load_all): Likewise.
	(cleanup_block_store_pc): Likewise.
	(cleanup_block_load_pc): Likewise.
	(arm_copy_block_xfer): Likewise.
	(thumb2_copy_block_xfer): Likewise.
	(cleanup_svc): Likewise.
	(install_svc): Likewise.
	(arm_copy_svc): Likewise.
	(thumb_copy_svc): Likewise.
	(arm_copy_undef): Likewise.
	(thumb_32bit_copy_undef): Likewise.
	(arm_copy_unpred): Likewise.
	(arm_decode_misc_memhint_neon): Likewise.
	(arm_decode_unconditional): Likewise.
	(arm_decode_miscellaneous): Likewise.
	(arm_decode_dp_misc): Likewise.
	(arm_decode_ld_st_word_ubyte): Likewise.
	(arm_decode_media): Likewise.
	(arm_decode_b_bl_ldmstm): Likewise.
	(arm_decode_ext_reg_ld_st): Likewise.
	(thumb2_decode_dp_shift_reg): Likewise.
	(thumb2_decode_ext_reg_ld_st): Likewise.
	(arm_decode_svc_copro): Likewise.
	(thumb2_decode_svc_copro): Likewise.
	(install_pc_relative): Likewise.
	(thumb_copy_pc_relative_16bit): Likewise.
	(thumb_decode_pc_relative_16bit): Likewise.
	(thumb_copy_pc_relative_32bit): Likewise.
	(thumb_copy_16bit_ldr_literal): Likewise.
	(thumb_copy_cbnz_cbz): Likewise.
	(thumb2_copy_table_branch): Likewise.
	(cleanup_pop_pc_16bit_all): Likewise.
	(thumb_copy_pop_pc_16bit): Likewise.
	(thumb_process_displaced_16bit_insn): Likewise.
	(decode_thumb_32bit_ld_mem_hints): Likewise.
	(thumb_process_displaced_32bit_insn): Likewise.
	(thumb_process_displaced_insn): Likewise.
	(arm_process_displaced_insn): Likewise.
	(arm_displaced_init_closure): Likewise.
	(arm_displaced_step_fixup): Add cast for closure.
	* arm-tdep.h: Include infrun.h.
	(displaced_step_closure): Rename to ...
	(arm_displaced_step_closure): ... this, extend
	displaced_step_closure.
	<u::svc::copy_svc_os>: Change type of parameter DSC.
	<cleanup>: Likewise.
	(arm_process_displaced_insn): Likewise.
	(arm_displaced_init_closure): Likewise.
	(displaced_read_reg): Likewise.
	(displaced_write_reg): Likewise.
	* i386-linux-tdep.c (i386_linux_displaced_step_copy_insn):
	Adjust.
	* i386-tdep.h: Include infrun.h.
	(i386_displaced_step_closure): New typedef.
	* i386-tdep.c (i386_displaced_step_copy_insn): Use
	i386_displaced_step_closure.
	(i386_displaced_step_fixup): Adjust.
	* rs6000-tdep.c (ppc_displaced_step_closure): New typedef.
	(ppc_displaced_step_copy_insn): Use ppc_displaced_step_closure
	and unique_ptr.
	(ppc_displaced_step_fixup): Adjust.
	* s390-linux-tdep.c (s390_displaced_step_closure): New typedef.
	(s390_displaced_step_copy_insn): Use s390_displaced_step_closure
	and unique_ptr.
	(s390_displaced_step_fixup): Adjust.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Use std::vector in gdb_bfd_data
@ 2017-10-20 19:05 sergiodj+buildbot
  2017-10-20 20:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-20 19:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d5833c62d93e8176b70e8509ab36cc38801c3ebd ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: d5833c62d93e8176b70e8509ab36cc38801c3ebd

Use std::vector in gdb_bfd_data

This changes gdb_bfd_data to use std::vector rather than VEC.

ChangeLog
2017-10-20  Tom Tromey  <tom@tromey.com>

	* gdb_bfd.c (struct gdb_bfd_data) <included_bfds>: Now a
	std::vector.
	(gdb_bfd_record_inclusion): Update.
	(bfdp): Remove typedef.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Introduce new_bfd_ref
@ 2017-10-20 16:28 sergiodj+buildbot
  2017-10-20 18:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-20 16:28 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2712ce2e659f82168154d4533f53d2963ae82571 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 2712ce2e659f82168154d4533f53d2963ae82571

Introduce new_bfd_ref

This introduces a helper function, new_bfd_ref, that calls gdb_bfd_ref
and returns a gdb_bfd_ref_ptr.  Then it updates several places to use
this.

ChangeLog
2017-10-20  Tom Tromey  <tom@tromey.com>

	* exec.c (exec_file_attach): Use new_bfd_ref.
	* symfile-mem.c (symbol_file_add_from_memory): Use new_bfd_ref.
	* gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
	(gdb_bfd_openw, gdb_bfd_openr_iovec, gdb_bfd_fdopenr): Use
	new_bfd_ref.
	* gdb_bfd.h (new_bfd_ref): New function.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix 'gdb.base/quit.exp hangs forever' if the test fails
@ 2017-10-20 15:58 sergiodj+buildbot
  2017-10-20 16:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-20 15:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 15763a09d4aea85fc3153d6746c040dd48565637 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 15763a09d4aea85fc3153d6746c040dd48565637

Fix 'gdb.base/quit.exp hangs forever' if the test fails

The [wait -i $gdb_spawn_id] in the test is dangerous in the sense that
it won't be subject to timeout logic.  So if GDB fails quiting, this
testcase hangs forever, hanging the test run with it.  See:
  https://sourceware.org/ml/gdb-patches/2016-10/msg00728.html

Instead of 'wait'ing directly, use gdb_test_multiple and expect 'eof'.

Tested that the testcase no longer hangs by hacking the test to send
"info threads" instead of "quit".

Tested with
  --target_board={unix, native-gdbserver,native-extended-gdbserver}
and tested with
  --host_board=local-remote-host
as well.

gdb/testsuite/ChangeLog:
2017-10-20  Pedro Alves  <palves@redhat.com>

	* gdb.base/quit.exp: Use gdb_test_multiple and expect 'eof' before
	'wait -i'.  Use gdb_assert and remote_close.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix gdb.gdb/ selftest tests when testing optimized GDB builds
@ 2017-10-20 14:57 sergiodj+buildbot
  2017-10-20 14:57 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-20 14:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fcc8fb2f3de370f2def30bb18c98243ed4f3fb8c ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: fcc8fb2f3de370f2def30bb18c98243ed4f3fb8c

Fix gdb.gdb/ selftest tests when testing optimized GDB builds

After commit bf4692711232 ("Eliminate catch_errors"), GCC started
inlining captured_command_loop in captured_main.  And setting a
breakpoint on captured_command_loop makes the inferior GDB stop in
captured_main, _after_ captured_command_loop's call to
interp_pre_command_loop, which prints the inferior GDB's prompt, has
already executed, confusing the gdb.gdb/ selftest tests:

  (gdb) FAIL: gdb.gdb/complaints.exp: run until breakpoint at captured_command_loop
  WARNING: Couldn't test self

Debugging GDB with GDB manually, we see:

  (top-gdb) b captured_command_loop
  Breakpoint 1 at 0x71ee60: file src/gdb/main.c, line 324.
  (top-gdb) r
  [....]
  (gdb)                  <<<<<< PROMPT HERE
  Thread 1 "gdb" hit Breakpoint 1, captured_main (data=<optimized out>) at src/gdb/main.c:1147
  1147              captured_command_loop ();
  (top-gdb)

Note the stop at 'captured_main', and the "PROMPT HERE" line.  That
prompt does not show up when debugging a non-optimized build of GDB.

Fix this by preventing inlining of captured_command_loop.

Ref: https://sourceware.org/ml/gdb-patches/2017-10/msg00522.html

gdb/ChangeLog:
2017-10-20  Pedro Alves  <palves@redhat.com>

	* main.c (captured_command_loop): Add attribute noinline.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Get rid of VEC(interp_factory_p)
@ 2017-10-20  2:37 sergiodj+buildbot
  2017-10-20  2:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-20  2:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4c2287b0bdfbed95d37d09222fc253f4c5086ada ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 4c2287b0bdfbed95d37d09222fc253f4c5086ada

Get rid of VEC(interp_factory_p)

Replace it with an std::vector.

gdb/ChangeLog:

	* interps.c (struct interp_factory): Add constructor.
	(interp_factory_p): Remove typedef.
	(DEF_VEC_P(interp_factory_p)): Remove.
	(interpreter_factories): Change type to std::vector.
	(interp_factory_register): Adjust.
	(interp_lookup): Adjust.
	(interpreter_completer): Adjust.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove cleanups from break-catch-syscall.c
@ 2017-10-20  0:58 sergiodj+buildbot
  2017-10-20  0:58 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-20  0:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3d415c26bad3a15eed00d2ddf85c4268df77a4cc ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 3d415c26bad3a15eed00d2ddf85c4268df77a4cc

Remove cleanups from break-catch-syscall.c

This removes the remaining cleanups from break-catch-syscall.c by
storing temporary strings in a vector.

ChangeLog
2017-10-19  Tom Tromey  <tom@tromey.com>

	* break-catch-syscall.c (catch_syscall_completer): Use
	std::string, gdb::unique_xmalloc_ptr.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdb: Remove hard-coded line number from test
@ 2017-10-19 20:39 sergiodj+buildbot
  2017-10-19 20:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-19 20:39 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 49a4ce2eae231ae627ab9a312256c6e402b5a27e ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 49a4ce2eae231ae627ab9a312256c6e402b5a27e

gdb: Remove hard-coded line number from test

Removes the use of a hard-coded line number from a test.

gdb/testsuite/ChangeLog:

	* gdb.linespec/ls-errs.exp (do_test): Update comment, use line
	number from variable rather than hard-coded.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix build breakage in gdb/xml-support.c
@ 2017-10-19 18:15 sergiodj+buildbot
  2017-10-19 19:18 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-19 18:15 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 63929e843d54d327676bed4d86dad280f4675547 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 63929e843d54d327676bed4d86dad280f4675547

Fix build breakage in gdb/xml-support.c

The buildbots are showing that the previous change to
xml_fetch_content_from_file causes __wur warnings/errors:

  ../../binutils-gdb/gdb/xml-support.c: In function gdb::unique_xmalloc_ptr<char> xml_fetch_content_from_file(const char*, void*):
  ../../binutils-gdb/gdb/xml-support.c:1028:43: error: ignoring return value of size_t fread(void*, size_t, size_t, FILE*), declared with attribute warn_unused_result [-Werror=unused-result]
     fread (text.get (), 1, len, file.get ());
					     ^

This commit fixes it.

gdb/ChangeLog:
2017-10-19  Pedro Alves  <palves@redhat.com>

	* xml-support.c (xml_fetch_content_from_file): Check fread's
	return.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] tilegx: Check bfd_link_executable for TLS check
@ 2017-10-19 13:54 sergiodj+buildbot
  2017-10-19 15:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-19 13:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 280958942b74f3164708700f195188c4d3446f58 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 280958942b74f3164708700f195188c4d3446f58

tilegx: Check bfd_link_executable for TLS check

Copied from x86, check bfd_link_executable, instead of bfd_link_pic,
for TLS transition check.  Not sure if it works correctly.  All usages
of bfd_link_pic should be audited.

	PR ld/22263
	* elfxx-tilegx.c (tilegx_elf_tls_transition): Replace
	bfd_link_pic with !bfd_link_executable, !bfd_link_pic with
	bfd_link_executable for TLS check.
	(tilegx_elf_check_relocs): Likewise.
	(allocate_dynrelocs): Likewise.
	(tilegx_elf_relocate_section): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] sparc: Check bfd_link_executable for TLS check
@ 2017-10-19 12:45 sergiodj+buildbot
  2017-10-19 12:45 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-19 12:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0fb7012e88683b8bd67a4fb8f782359fa0e11724 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 0fb7012e88683b8bd67a4fb8f782359fa0e11724

sparc: Check bfd_link_executable for TLS check

Copied from x86, check bfd_link_executable, instead of bfd_link_pic,
for TLS transition check.  Not sure if it works correctly.  All usages
of bfd_link_pic should be audited.

	PR ld/22263
	* elfxx-sparc.c (sparc_elf_tls_transition): Replace
	bfd_link_pic with !bfd_link_executable, !bfd_link_pic with
	bfd_link_executable for TLS check.
	(_bfd_sparc_elf_check_relocs): Likewise.
	(allocate_dynrelocs): Likewise.
	(_bfd_sparc_elf_relocate_section): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [Visium] Disassemble the operands of the stop instruction.
@ 2017-10-18 14:57 sergiodj+buildbot
  2017-10-18 14:57 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-18 14:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2a6969e1738859ea8c12837fb0cba3845bc87ceb ***

Author: Eric Botcazou <ebotcazou@gcc.gnu.org>
Branch: master
Commit: 2a6969e1738859ea8c12837fb0cba3845bc87ceb

[Visium] Disassemble the operands of the stop instruction.

binutils/
        * MAINTAINERS: Add myself as Visium maintainer.
opcodes/
        * visium-dis.c (disassem_class1) <case 0>: Print the operands.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove features/tic6x-c62x-linux.c
@ 2017-10-18 12:24 sergiodj+buildbot
  2017-10-18 12:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-18 12:24 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 28c7c158766513a1c6f599c08f85851fcab855e6 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 28c7c158766513a1c6f599c08f85851fcab855e6

Remove features/tic6x-c62x-linux.c

c40c7bf (Remove features/tic6x-*.c files) doesn't remove
features/tic6x-c62x-linux.c.  This patch removes it.

gdb:

2017-10-18  Yao Qi  <yao.qi@linaro.org>

	* features/tic6x-c62x-linux.c: Remove.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Really make the native-stdio-gdbserver board non-remote
@ 2017-10-17 20:14 sergiodj+buildbot
  2017-10-18  0:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-17 20:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b27de576d41eed16936cf639857df4e1e27a8e9e ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: b27de576d41eed16936cf639857df4e1e27a8e9e

Really make the native-stdio-gdbserver board non-remote

I've noticed now that due to a last-minute change, commit 739b3f1d8ff7
("Make native gdbserver boards no longer be "remote" (in DejaGnu
terms)") managed to miss loading "local-board" in the
native-stdio-gdbserver board...

gdb/testsuite/ChangeLog:
2017-10-17  Pedro Alves  <palves@redhat.com>

	* boards/native-stdio-gdbserver.exp: Load "local-board".


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add several "quit with live inferior" tests
@ 2017-10-17 17:30 sergiodj+buildbot
  2017-10-17 23:14 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-17 17:30 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8484c9554519c25c73a349d0581cc269f102c5d2 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 8484c9554519c25c73a349d0581cc269f102c5d2

Add several "quit with live inferior" tests

In my multi-target branch, I had managed to break GDB exiting
successfuly in response to "quit" or SIGHUP/SIGTERM when:

 - you're debugging with "target extended-remote",
 - have more than one inferior loaded in gdb, some running, and at
   least one not running, and,
 - quit gdb with the inferior that is not running yet selected.

The testsuite still passed cleanly anyway.  I only noticed because I
was left with a bunch of core dumps in the gdb/testsuite/ directory --
the testsuite infrastructure closes GDB's pty after running each
testcase, which results in GDB getting a SIGHUP and should make GDB
exit gracefully.  If GDB crashes at that point though, there's no
indication about it in gdb.sum/gdb.log.

This commit adds a multitude of tests exercising quitting GDB with
live inferiors, some of which would have caught the problem.

gdb/testsuite/ChangeLog:
2017-10-17  Pedro Alves  <palves@redhat.com>

	* gdb.base/quit-live.c: New file.
	* gdb.base/quit-live.exp: New file.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove cleanups from disasm.c
@ 2017-10-17 16:58 sergiodj+buildbot
  2017-10-17 22:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-17 16:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 30f0b1015897466fb88ed26c56a0b4f42808edbc ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 30f0b1015897466fb88ed26c56a0b4f42808edbc

Remove cleanups from disasm.c

This changes the remaining spots in disasm.c to use the RAII ui-out
emitters, removing a few cleanups.  This also fixes a regression that
Simon pointed out.

2017-10-17  Tom Tromey  <tom@tromey.com>

	* disasm.c (do_mixed_source_and_assembly_deprecated): Use
	gdb::optional, ui_out_emit_list, ui_out_emit_tuple.
	(do_mixed_source_and_assembly): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix double-free corruption
@ 2017-10-17 14:44 sergiodj+buildbot
  2017-10-17 18:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-17 14:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7b7009999ab8daac9db776c850b7df6e1f586334 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 7b7009999ab8daac9db776c850b7df6e1f586334

Fix double-free corruption

Fixes a double-free regression introduced by commit b7b030adc405
("Return unique_xmalloc_ptr from target_read_stralloc"):

gdb.sum:
  Running src/gdb/testsuite/gdb.base/catch-syscall.exp ...
  ERROR: Process no longer exists

Valgrind shows:

  (gdb) catch syscall
  ==3687== Thread 1:
  ==3687== Invalid free() / delete / delete[] / realloc()
  ==3687==    at 0x4C29CF0: free (vg_replace_malloc.c:530)
  ==3687==    by 0x610862: xfree(void*) (common-utils.c:101)
  ==3687==    by 0x440D5D: gdb::xfree_deleter<char>::operator()(char*) const (gdb_unique_ptr.h:34)
  ==3687==    by 0x446CC6: std::unique_ptr<char, gdb::xfree_deleter<char> >::reset(char*) (unique_ptr.h:344)
  ==3687==    by 0x81BE50: xml_fetch_content_from_file(char const*, void*) (xml-support.c:1042)
  ==3687==    by 0x81DA86: xml_init_syscalls_info(char const*) (xml-syscall.c:366)
  ==3687==    by 0x81DBDD: init_syscalls_info(gdbarch*) (xml-syscall.c:398)
  ==3687==    by 0x81E131: get_syscall_by_number(gdbarch*, int, syscall*) (xml-syscall.c:599)
  ==3687==    by 0x5BE86F: catch_syscall_command_1(char*, int, cmd_list_element*) (break-catch-syscall.c:481)
  ==3687==    by 0x4B46B1: do_sfunc(cmd_list_element*, char*, int) (cli-decode.c:138)
  ==3687==    by 0x4B76B8: cmd_func(cmd_list_element*, char*, int) (cli-decode.c:1952)
  ==3687==    by 0x7E91C7: execute_command(char*, int) (top.c:615)
  ==3687==  Address 0x14332ae0 is 0 bytes inside a block of size 4,096 free'd
  ==3687==    at 0x4C2AB8B: realloc (vg_replace_malloc.c:785)
  ==3687==    by 0x610792: xrealloc (common-utils.c:62)
  ==3687==    by 0x81BE3E: xml_fetch_content_from_file(char const*, void*) (xml-support.c:1042)
  ==3687==    by 0x81DA86: xml_init_syscalls_info(char const*) (xml-syscall.c:366)
  ==3687==    by 0x81DBDD: init_syscalls_info(gdbarch*) (xml-syscall.c:398)
  ==3687==    by 0x81E131: get_syscall_by_number(gdbarch*, int, syscall*) (xml-syscall.c:599)
  ==3687==    by 0x5BE86F: catch_syscall_command_1(char*, int, cmd_list_element*) (break-catch-syscall.c:481)
  ==3687==    by 0x4B46B1: do_sfunc(cmd_list_element*, char*, int) (cli-decode.c:138)
  ==3687==    by 0x4B76B8: cmd_func(cmd_list_element*, char*, int) (cli-decode.c:1952)
  ==3687==    by 0x7E91C7: execute_command(char*, int) (top.c:615)
  ==3687==    by 0x6A422D: command_handler(char*) (event-top.c:583)
  ==3687==    by 0x6A45F2: command_line_handler(char*) (event-top.c:773)
  [...]

The problem is that if xrealloc decides it needs a new memory block,
it frees the previous block/pointer, and then text.reset() frees it
again.

gdb/ChangeLog:
2017-10-17  Pedro Alves  <palves@redhat.com>

	* xml-support.c (xml_fetch_content_from_file): Call
	unique_ptr::release() instead unique_ptr::get() when passing
	through xrealloc.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [GDBserver] Move arm-linux.o and arm-get-next-pcs.o to arch/
@ 2017-10-17 13:53 sergiodj+buildbot
  2017-10-17 14:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-17 13:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e675d1703fbdec643ec42aa67b9720cb199f4375 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: e675d1703fbdec643ec42aa67b9720cb199f4375

[GDBserver] Move arm-linux.o and arm-get-next-pcs.o to arch/

gdb/gdbserver:

2017-10-17  Yao Qi  <yao.qi@linaro.org>

	* configure.srv: Rename arm-linux.o with arch/arm-linux.o.
	Rename arm-get-next-pcs.o with arch/arm-get-next-pcs.o.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [GDBserver] Move arm.o to arch/arm.o
@ 2017-10-17 12:52 sergiodj+buildbot
  2017-10-17 12:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-17 12:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7eb4e0f95641edebbc28a710f28111f0ecb9f0d1 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 7eb4e0f95641edebbc28a710f28111f0ecb9f0d1

[GDBserver] Move arm.o to arch/arm.o

gdb/gdbserver:

2017-10-17  Yao Qi  <yao.qi@linaro.org>

	* configure.srv: Rename arm.o with arch/arm.o.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [GDBserver] Replicate src dir in build dir
@ 2017-10-17 11:42 sergiodj+buildbot
  2017-10-17 11:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-17 11:42 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 60d6cfc99e67c3f94e31e26112873719b12b738f ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 60d6cfc99e67c3f94e31e26112873719b12b738f

[GDBserver] Replicate src dir in build dir

Similar to f38307f5 (Replicate src dir in build dir), this patch change
configure and Makefile to generate object files in arch/ directory.

gdb/gdbserver:

2017-10-17  Yao Qi  <yao.qi@linaro.org>

	* Makefile.in (CONFIG_SRC_SUBDIR): New variable.
	(clean): Remove .o files in CONFIG_SRC_SUBDIR.
	(distclean): Remove DEPDIR in CONFIG_SRC_SUBDIR.
	(arch-i386.o, arch-amd64.o): Remove rules.
	(arch/%.o): New rule.
	Update POSTCOMPILE and COMPILE.pre.
	* configure.ac: Invoke AC_CONFIG_COMMANDS.
	* configure: Re-generated.
	* configure.srv: Replace arch-i386.o with arch/i386.o.
	Replace arch-amd64.o with arch/amd64.o.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Record and output access specifiers for nested typedefs
@ 2017-10-17  2:05 sergiodj+buildbot
  2017-10-17  6:44 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-17  2:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c191a6875b118fce30e7dc4d9e4bd20eff850270 ***

Author: Keith Seitz <keiths@redhat.com>
Branch: master
Commit: c191a6875b118fce30e7dc4d9e4bd20eff850270

Record and output access specifiers for nested typedefs

We currently do not record access information for typedefs defined inside
classes.  Consider:

struct foo
{
   typedef int PUBLIC;
 private:
   typedef int PRIVATE;
   PRIVATE b;
};

(gdb) ptype foo
type = struct foo {
  private:
    PRIVATE b;

    typedef int PRIVATE;
    typedef int PUBLIC;
}

This patch fixes this:

(gdb) ptype foo
type = struct foo {
  private:
    PRIVATE b;

    typedef int PRIVATE;
  public:
    typedef int PUBLIC;
}

gdb/ChangeLog:

	* c-typeprint.c (enum access_specifier): Moved here from
	c_type_print_base.
	(output_access_specifier): New function.
	(c_type_print_base): Consider typedefs when assessing
	whether access labels are needed.
	Use output_access_specifier as needed.
	Output access specifier for typedefs, if needed.
	* dwarf2read.c (dwarf2_add_typedef): Record DW_AT_accessibility.
	* gdbtypes.h (struct typedef_field) <is_protected, is_private>: New
	fields.
	(TYPE_TYPEDEF_FIELD_PROTECTED, TYPE_TYPEDEF_FIELD_PRIVATE): New
	accessor macros.

gdb/testsuite/ChangeLog:

	* gdb.cp/classes.cc (class_with_typedefs, class_with_public_typedef)
	(class_with_protected_typedef, class_with_private_typedef)
	(struct_with_public_typedef, struct_with_protected_typedef)
	(struct_with_private_typedef): New classes/structs.
	* gdb.cp/classes.exp (test_ptype_class_objects): Add tests for
	typedefs and access specifiers.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Return unique_xmalloc_ptr from target_fileio_read_stralloc
@ 2017-10-17  1:45 sergiodj+buildbot
  2017-10-17  5:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-17  1:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 87028b873938aa3cc756c99e33a328640dbc30bc ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 87028b873938aa3cc756c99e33a328640dbc30bc

Return unique_xmalloc_ptr from target_fileio_read_stralloc

Change target_fileio_read_stralloc to return unique_xmalloc_ptr and
fix up the callers.  This removes a number of cleanups.

ChangeLog
2017-10-16  Tom Tromey  <tom@tromey.com>

	* linux-tdep.c (linux_info_proc, linux_find_memory_regions_full)
	(linux_fill_prpsinfo, linux_vsyscall_range_raw): Update.
	* target.c (target_fileio_read_stralloc): Update.
	* sparc64-tdep.c (adi_is_addr_mapped): Update.
	* target.h (target_fileio_read_stralloc): Return
	unique_xmalloc_ptr.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Return unique_xmalloc_ptr from target_read_stralloc
@ 2017-10-17  1:24 sergiodj+buildbot
  2017-10-17  4:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-17  1:24 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b7b030adc405017f01e996a90f85e40730ef8397 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: b7b030adc405017f01e996a90f85e40730ef8397

Return unique_xmalloc_ptr from target_read_stralloc

This changes target_read_stralloc to return a unique_xmalloc_ptr, and
then fixes all the callers.  unique_xmalloc_ptr is used, rather than
std::string, because target_read_stralloc gives a special meaning to a
NULL return.

ChangeLog
2017-10-16  Tom Tromey  <tom@tromey.com>

	* xml-syscall.c (xml_init_syscalls_info): Update.
	* xml-support.c (xinclude_start_include): Update.
	(xml_fetch_content_from_file): Return unique_xmalloc_ptr.
	* xml-support.h (xml_fetch_another): Return unique_xmalloc_ptr.
	(xml_fetch_content_from_file): Likewise.
	* osdata.c (get_osdata): Update.
	* target.h (target_read_stralloc, target_get_osdata): Return
	unique_xmalloc_ptr.
	* solib-aix.c (solib_aix_get_library_list): Update.
	* solib-target.c (solib_target_current_sos): Update.
	* solib-svr4.c (svr4_current_sos_via_xfer_libraries): Update.
	* xml-tdesc.c (fetch_available_features_from_target): Update.
	(target_fetch_description_xml): Update.
	(file_read_description_xml): Update.
	* remote.c (remote_get_threads_with_qxfer, remote_memory_map)
	(remote_traceframe_info, btrace_read_config, remote_read_btrace)
	(remote_pid_to_exec_file): Update.
	* target.c (target_read_stralloc): Return unique_xmalloc_ptr.
	(target_get_osdata): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Use std::vector in end_symtab_get_static_block
@ 2017-10-16 22:35 sergiodj+buildbot
  2017-10-16 22:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-16 22:35 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b05628f0a878cdd64492bbc49d60003d699763ad ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: b05628f0a878cdd64492bbc49d60003d699763ad

Use std::vector in end_symtab_get_static_block

Change end_symtab_get_static_block to use std::vector.  This removes a
cleanup.

ChangeLog
2017-10-16  Tom Tromey  <tom@tromey.com>

	* buildsym.c (block_compar): Remove.
	(end_symtab_get_static_block): Use std::vector.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Use proc_with_prefix in py-breakpoint.exp
@ 2017-10-16 19:33 sergiodj+buildbot
  2017-10-16 19:33 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-16 19:33 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fe68b9530f6ec45d57838b96dbe11723b90467f4 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: fe68b9530f6ec45d57838b96dbe11723b90467f4

Use proc_with_prefix in py-breakpoint.exp

Use proc_with_prefix to avoid having to call with_test_prefix with a
duplicate of the proc name.  The diff is mostly lines being re-indented.

gdb/testsuite/ChangeLog:

	* gdb.python/py-breakpoint.exp (test_bkpt_basic,
	test_bkpt_deletion, test_bkpt_cond_and_cmds,
	test_bkpt_invisible, test_watchpoints, test_bkpt_internal,
	test_bkpt_eval_funcs, test_bkpt_temporary, test_bkpt_address,
	test_bkpt_pending, test_bkpt_events): Use proc_with_prefix,
	remove with_test_prefix.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Get rid of VEC(mem_range_s)
@ 2017-10-16 15:34 sergiodj+buildbot
  2017-10-16 17:53 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-16 15:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a79b1bc6f690f3d146a3caddabd9f13a886c856a ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: a79b1bc6f690f3d146a3caddabd9f13a886c856a

Get rid of VEC(mem_range_s)

This patch replaces the last usages of VEC(mem_range_s) with
std::vector<mem_range>.  This allows getting rid of a few cleanups and
of the DEF_VEC_O(mem_range_s).

I added a test for normalize_mem_ranges to make sure I didn't break
anything there.

Regtested on the buildbot.

gdb/ChangeLog:

	* memrange.h (struct mem_range): Define operator< and operator==.
	(mem_range_s): Remove.
	(DEF_VEC_O (mem_range_s)): Remove.
	(normalize_mem_ranges): Change parameter type to std::vector.
	* memrange.c (compare_mem_ranges): Remove.
	(normalize_mem_ranges): Change parameter type to std::vector,
	adjust to vector change.
	* exec.c (section_table_available_memory): Return vector, remove
	parameter.
	(section_table_read_available_memory): Adjust to std::vector
	change.
	* remote.c (remote_read_bytes): Adjust to std::vector
	change.
	* tracepoint.h (traceframe_available_memory): Change parameter
	type to std::vector.
	* tracepoint.c (traceframe_available_memory): Change parameter
	type to std::vector, adjust.
	* gdb/mi/mi-main.c (mi_cmd_trace_frame_collected): Adjust to
	std::vector change.
	* gdb/Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
	unittests/memrange-selftests.c.
	(SUBDIR_UNITTESTS_OBS): Add memrange-selftests.o.
	* gdb/unittests/memrange-selftests.c: New file.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] ELF: Call check_relocs after opening all inputs
@ 2017-10-16 11:51 sergiodj+buildbot
  2017-10-16 15:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-16 11:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5c3261b0e834647cf9eb555320e20871b7854f98 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 5c3261b0e834647cf9eb555320e20871b7854f98

ELF: Call check_relocs after opening all inputs

For all ELF targers, call check_relocs after opening all inputs and
garbage collection.  Since the symbol resolution is known, check_relocs
can be simplified.  Also garbage collection doesn't need to undo what
check_relocs has done for symbols which have been garbage collected.
Since ELF targets never see the removed sections, gc_sweep_hook can be
removed from elf_backend_data and we can avoid GOT/PLT with garbage
collection now.

Set link_info.check_relocs_after_open_input to TRUE for all linker
targets which use ELF linker and update garbage collection tests to
remove unused GOT section.

ldemul_after_check_relocs is added for powerpc to support --secure-plt,
--bss-plt and --sdata-got.

Tested natively without regressions on i686, x86-64 and x32.  Tested
cross binutils on x86-64 without regressions for aarch64-linux,
alpha-linux, arm-linux, bfin-elf, cr16-elf, cris-elf, crx-elf, frv-linux,
hppa64-linux, hppa-linux, ia64-linux, lm32-elf, m32r-elf, m68k-linux,
mcore-elf, metag-elf, microblaze-linux, mips-linux, mmix, mn10300-elf,
nds32le-linux, nios2-linux, or1k-elf, powerpc64-linux, powerpc-linux,
riscv32-linux, riscv64-linux, s390-linux, s390x-linux, score-elf,
sh3-linux, sparc64-linux, sparc-linux, tic6x-elf, tilegx-linux,
tilepro-linux, vax-linux, x86_64-mingw32 and xtensa-linux.

bfd/

	* elf-bfd.h (elf_backend_data): Remove gc_sweep_hook.
	* elf32-arm.c (elf32_arm_gc_sweep_hook): Removed.
	(elf_backend_gc_sweep_hook): Likewise.
	* elf32-bfin.c (bfin_gc_sweep_hook): Likewise.
	(bfinfdpic_gc_sweep_hook): Likewise.
	(elf_backend_gc_sweep_hook): Likewise.
	* elf32-cr16.c (elf32_cr16_gc_sweep_hook): Likewise.
	(elf_backend_gc_sweep_hook): Likewise.
	* elf32-cris.c (cris_elf_gc_sweep_hook): Likewise.
	(elf_backend_gc_sweep_hook): Likewise.
	* elf32-hppa.c (elf32_hppa_gc_sweep_hook): Likewise.
	(elf_backend_gc_sweep_hook): Likewise.
	* elf32-lm32.c (lm32_elf_gc_sweep_hook): Likewise.
	(elf_backend_gc_sweep_hook): Likewise.
	* elf32-m32r.c (m32r_elf_gc_sweep_hook): Likewise.
	(elf_backend_gc_sweep_hook): Likewise.
	* elf32-m68k.c (elf_m68k_got_entry): Remove elf_m68k_gc_sweep_hook
	from comments.
	(elf_m68k_remove_got_entry_type): Removed.
	(elf_m68k_find_got_entry_ptr): Likewise.
	(elf_m68k_remove_got_entry): Likewise.
	(elf_m68k_gc_sweep_hook): Likewise.
	(elf_backend_gc_sweep_hook): Likewise.
	* elf32-mcore.c (mcore_elf_gc_sweep_hook): Likewise.
	(elf_backend_gc_sweep_hook): Likewise.
	* elf32-metag.c (elf_metag_gc_sweep_hook): Likewise.
	(elf_backend_gc_sweep_hook): Likewise.
	* elf32-microblaze.c (elf_backend_gc_sweep_hook): Likewise.
	(elf_backend_gc_sweep_hook): Likewise.
	* elf32-mips.c (elf_backend_gc_sweep_hook): Likewise.
	(elf_backend_gc_sweep_hook): Likewise.
	* elf32-nds32.c (nds32_elf_gc_sweep_hook): Likewise.
	(elf_backend_gc_sweep_hook): Likewise.
	* elf32-nios2.c (nios2_elf32_gc_sweep_hook): Likewise.
	(elf_backend_gc_sweep_hook): Likewise.
	* elf32-or1k.c (or1k_elf_gc_sweep_hook): Likewise.
	(elf_backend_gc_sweep_hook): Likewise.
	* elf32-ppc.c (ppc_elf_gc_sweep_hook): Likewise.
	(elf_backend_gc_sweep_hook): Likewise.
	* elf32-s390.c (elf_s390_gc_sweep_hook): Likewise.
	(elf_backend_gc_sweep_hook): Likewise.
	* elf32-sparc.c (elf_backend_gc_sweep_hook): Likewise.
	* elf32-tic6x.c (elf32_tic6x_gc_sweep_hook): Likewise.
	(elf_backend_gc_sweep_hook): Likewise.
	* elf32-tilegx.c (elf_backend_gc_sweep_hook): Likewise.
	* elf32-tilepro.c (tilepro_elf_gc_sweep_hook): Likewise.
	(elf_backend_gc_sweep_hook): Likewise.
	* elf32-vax.c (elf_vax_gc_sweep_hook): Likewise.
	(elf_backend_gc_sweep_hook): Likewise.
	* elf32-xtensa.c (elf_xtensa_gc_sweep_hook): Likewise.
	(elf_backend_gc_sweep_hook): Likewise.
	* elf64-alpha.c (elf64_alpha_gc_sweep_hook): Likewise.
	(elf_backend_gc_sweep_hook): Likewise.
	* elf64-mips.c (elf_backend_gc_sweep_hook): Likewise.
	* elf64-mmix.c (mmix_elf_gc_sweep_hook): Likewise.
	(elf_backend_gc_sweep_hook): Likewise.
	* elf64-ppc.c (elf_backend_gc_sweep_hook): Likewise.
	(ppc64_elf_gc_sweep_hook): Likewise.
	* elf64-s390.c (elf_s390_gc_sweep_hook): Likewise.
	(elf_backend_gc_sweep_hook): Likewise.
	* elf64-sparc.c (elf_backend_gc_sweep_hook): Likewise.
	* elf64-tilegx.c (elf_backend_gc_sweep_hook): Likewise.
	* elflink.c (elf_link_add_object_symbols): Don't call
	_bfd_elf_link_check_relocs here.
	(gc_sweep_hook_fn): Removed.
	(elf_gc_sweep): Remove gc_sweep_hook.
	* elfnn-aarch64.c (elfNN_aarch64_gc_sweep_hook): Removed.
	(elf_backend_gc_sweep_hook): Likewise.
	* elfnn-riscv.c (riscv_elf_gc_sweep_hook): Likewise.
	(elf_backend_gc_sweep_hook): Likewise.
	* elfxx-mips.c (_bfd_mips_elf_gc_sweep_hook): Likewise.
	* elfxx-mips.h (_bfd_mips_elf_gc_sweep_hook): Likewise.
	(elf_backend_gc_sweep_hook): Likewise.
	* elfxx-sparc.c (_bfd_sparc_elf_gc_sweep_hook): Likewise.
	* elfxx-sparc.h (_bfd_sparc_elf_gc_sweep_hook): Likewise.
	* elfxx-target.h (elf_backend_gc_sweep_hook): Likewise.
	(elfNN_bed): Remove elf_backend_gc_sweep_hook.
	* elfxx-tilegx.c (tilegx_elf_gc_sweep_hook): Removed.
	* elfxx-tilegx.h (tilegx_elf_gc_sweep_hook): Likewise.

ld/

	* emulparams/elf32_x86_64.sh (CHECK_RELOCS_AFTER_OPEN_INPUT):
	Removed.
	* emulparams/elf_i386_be.sh (CHECK_RELOCS_AFTER_OPEN_INPUT):
	Likewise.
	* emulparams/elf_i386_chaos.sh (CHECK_RELOCS_AFTER_OPEN_INPUT):
	Likewise.
	* emulparams/elf_i386_ldso.sh (CHECK_RELOCS_AFTER_OPEN_INPUT):
	Likewise.
	* emulparams/elf_i386_vxworks.sh (CHECK_RELOCS_AFTER_OPEN_INPUT):
	Likewise.
	* emulparams/elf_iamcu.sh (CHECK_RELOCS_AFTER_OPEN_INPUT):
	Likewise.
	* emulparams/elf_k1om.sh (CHECK_RELOCS_AFTER_OPEN_INPUT):
	Likewise.
	* emulparams/elf_l1om.sh (CHECK_RELOCS_AFTER_OPEN_INPUT):
	Likewise.
	* emulparams/elf_x86_64.sh (CHECK_RELOCS_AFTER_OPEN_INPUT):
	Likewise.
	* emulparams/i386lynx.sh (CHECK_RELOCS_AFTER_OPEN_INPUT):
	Likewise.
	* emulparams/i386moss.sh (CHECK_RELOCS_AFTER_OPEN_INPUT):
	Likewise.
	* emulparams/i386nto.sh (CHECK_RELOCS_AFTER_OPEN_INPUT):
	Likewise.
	* emulparams/i386nw.sh (CHECK_RELOCS_AFTER_OPEN_INPUT):
	Likewise.
	* emulparams/shelf.sh (CHECK_RELOCS_AFTER_OPEN_INPUT):
	Likewise.
	* emulparams/shelf32.sh (CHECK_RELOCS_AFTER_OPEN_INPUT):
	Likewise.
	* emulparams/shelf_nto.sh (CHECK_RELOCS_AFTER_OPEN_INPUT):
	Likewise.
	* emulparams/shelf_vxworks.sh (CHECK_RELOCS_AFTER_OPEN_INPUT):
	Likewise.
	* emulparams/shlelf32_linux.sh (CHECK_RELOCS_AFTER_OPEN_INPUT):
	Likewise.
	* emulparams/shlelf_linux.sh (CHECK_RELOCS_AFTER_OPEN_INPUT):
	Likewise.
	* emulparams/shlelf_nto.sh (CHECK_RELOCS_AFTER_OPEN_INPUT):
	Likewise.
	* emultempl/aarch64elf.em (gld${EMULATION_NAME}_before_parse):
	Set link_info.check_relocs_after_open_input to TRUE.
	* emultempl/armelf.em (gld${EMULATION_NAME}_before_parse):
	Likewise.
	* emultempl/scoreelf.em (gld${EMULATION_NAME}_before_parse):
	Likewise.
	* emultempl/aix.em (ld_${EMULATION_NAME}_emulation): Add
	after_parse_default.
	* emultempl/armcoff.em (ld_${EMULATION_NAME}_emulation): Likewise.
	* emultempl/beos.em (ld_${EMULATION_NAME}_emulation): Likewise.
	* emultempl/generic.em (ld_${EMULATION_NAME}_emulation): Likewise.
	* emultempl/gld960.em (ld_${EMULATION_NAME}_emulation): Likewise.
	* emultempl/gld960c.em (ld_${EMULATION_NAME}_emulation): Likewise.
	* emultempl/lnk960.em (ld_${EMULATION_NAME}_emulation): Likewise.
	* emultempl/m68kcoff.em (ld_${EMULATION_NAME}_emulation): Likewise.
	* emultempl/msp430.em (ld_${EMULATION_NAME}_emulation): Likewise.
	* emultempl/pe.em (ld_${EMULATION_NAME}_emulation): Likewise.
	* emultempl/pep.em (ld_${EMULATION_NAME}_emulation): Likewise.
	* emultempl/sunos.em (ld_${EMULATION_NAME}_emulation): Likewise.
	* emultempl/ticoff.em (ld_${EMULATION_NAME}_emulation): Likewise.
	* emultempl/vanilla.em (ld_${EMULATION_NAME}_emulation): Likewise.
	* emultempl/elf32.em (gld${EMULATION_NAME}_before_parse): Always
	set link_info.check_relocs_after_open_input to TRUE.
	(ld_${EMULATION_NAME}_emulation): Add $LDEMUL_AFTER_CHECK_RELOCS.
	* emultempl/linux.em (gld${EMULATION_NAME}_before_parse):
	Set link_info.check_relocs_after_open_input to TRUE.
	(ld_${EMULATION_NAME}_emulation): Add after_check_relocs_default.
	* emultempl/mmix-elfnmmo.em (mmix_before_parse): New function.
	(LDEMUL_BEFORE_PARSE): New.
	* emultempl/mmixelf.em (elfmmix_before_parse): Replace
	gld${EMULATION_NAME}_before_parse with mmix_before_parse.
	* emultempl/ppc32elf.em (ppc_after_open): Renamed to ...
	(ppc_after_check_relocs): This.  Call after_check_relocs_default
	instead of gld${EMULATION_NAME}_after_open.
	(LDEMUL_AFTER_OPEN): Removed.
	(LDEMUL_AFTER_CHECK_RELOCS): New.
	* ldemul.c (ldemul_after_check_relocs): New.
	(after_check_relocs_default): Likewise.
	* ldemul.h (ldemul_after_check_relocs): Likewise.
	(after_check_relocs_default): Likewise.
	(ld_emulation_xfer_struct): Add after_check_relocs.
	* ldlang.c (lang_process): Call ldemul_after_check_relocs after
	lang_check_relocs.
	* testsuite/ld-aarch64/gc-got-relocs.d: Don't expect GOT section.
	* testsuite/ld-aarch64/gc-tls-relocs.d: Likewise.
	* testsuite/ld-cris/tls-gc-68.d: Likewise.
	* testsuite/ld-cris/tls-gc-69.d: Likewise.
	* testsuite/ld-cris/tls-gc-70.d: Likewise.
	* testsuite/ld-cris/tls-gc-75.d: Likewise.
	* testsuite/ld-cris/tls-gc-79.d: Likewise.
	* testsuite/ld-mmix/bpo-10.d: Don't expect .MMIX.reg_contents
	section.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Regenerate gdbserver/configure
@ 2017-10-16 10:50 sergiodj+buildbot
  2017-10-16 14:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-16 10:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5bfda25568c34410129c91042cdfdf10c143edac ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 5bfda25568c34410129c91042cdfdf10c143edac

Regenerate gdbserver/configure

4fa7574 (Fix gdb 8.1 Solaris compilation) changes warning.m4 and updates
configure, but gdbserver/configure is not updated.

gdb/gdbserver:

2017-10-16  Yao Qi  <yao.qi@linaro.org>

	* configure: Regenerated.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix GDB build without expat
@ 2017-10-16  2:42 sergiodj+buildbot
  2017-10-16  2:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-16  2:42 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8676616596351876612aa84be798537625348086 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 8676616596351876612aa84be798537625348086

Fix GDB build without expat

An earlier patch of mine changed parse_traceframe_info to make it return
a unique_ptr.  I forgot to update the version of the function used in an
expat-less build, this patch fixes it.

gdb/ChangeLog:

	* tracepoint.c (parse_traceframe_info): Return a unique_ptr
	(the !HAVE_LIBEXPAT version).


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Replace psymbol_allocation_list with std::vector
@ 2017-10-14 12:31 sergiodj+buildbot
  2017-10-14 17:10 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-14 12:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT af5bf4ada48ff65b6658be1fab8f9c8f8ab5f319 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: af5bf4ada48ff65b6658be1fab8f9c8f8ab5f319

Replace psymbol_allocation_list with std::vector

psymbol_allocation_list is basically a vector implementation.  We can
replace it with an std::vector, now that objfile has been C++-ified.

I sent this to the buildbot, there are a few suspicious failures, but
I don't think they are related to this patch.  For example on powerpc:

new FAIL: gdb.base/catch-syscall.exp: execve: syscall execve has returned
new FAIL: gdb.base/catch-syscall.exp: execve: continue to main
new FAIL: gdb.base/catch-syscall.exp: execve: continue until exit

I get the same failures when testing manually on gcc112, without this
patch.

gdb/ChangeLog:

	* objfiles.h: Don't include symfile.h.
	(struct partial_symbol): Remove forward-declaration.
	(struct objfile) <global_psymbols, static_psymbols>: Change type
	to std::vector<partial_symbol *>.
	* objfiles.c (objfile::objfile): Don't memset those fields.
	(objfile::~objfile): Don't free those fields.
	* psympriv.h (struct psymbol_allocation_list): Remove
	forward-declaration.
	(add_psymbol_to_list): Change psymbol_allocation_list parameter
	to std::vector.
	(start_psymtab_common): Change parameters to std::vector.
	* psymtab.c: Include algorithm.
	(require_partial_symbols): Call shrink_to_fit.
	(find_pc_sect_psymbol): Adjust to vector change.
	(match_partial_symbol): Likewise.
	(lookup_partial_symbol): Likewise.
	(psym_relocate): Likewise.
	(dump_psymtab): Likewise.
	(recursively_search_psymtabs): Likewise.
	(compare_psymbols): Remove.
	(sort_pst_symbols): Adjust to vector change.
	(start_psymtab_common): Likewise.
	(end_psymtab_common): Likewise.
	(psymbol_bcache_full): De-constify return value.
	(add_psymbol_to_bcache): Likewise.
	(extend_psymbol_list): Remove.
	(append_psymbol_to_list): Adjust to vector change.
	(add_psymbol_to_list): Likewise.
	(init_psymbol_list): Likewise.
	(maintenance_info_psymtabs): Likewise.
	(maintenance_check_psymtabs): Likewise.
	* symfile.h (struct psymbol_allocation_list): Remove.
	* symfile.c (reread_symbols): Adjust to vector change.
	* dbxread.c (start_psymtab): Change type of parameters.
	(dbx_symfile_read): Adjust to vector change.
	(read_dbx_symtab): Likewise.
	(start_psymtab): Change type of parameters.
	* dwarf2read.c (dwarf2_build_psymtabs): Adjust to vector change.
	(create_partial_symtab): Likewise.
	(add_partial_symbol): Likewise.
	(write_one_signatured_type): Likewise.
	(recursively_write_psymbols): Likewise.
	* mdebugread.c (parse_partial_symbols): Likewise.
	* xcoffread.c (xcoff_start_psymtab): Change type of parameters.
	(scan_xcoff_symtab): Adjust to vector change.
	(xcoff_initial_scan): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Don't run gdb.gdb/ selftests if use_gdb_stub is true
@ 2017-10-14  5:29 sergiodj+buildbot
  2017-10-14 11:38 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-14  5:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT dad0c6d2f7410d3b451800f856f3c6818303c316 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: dad0c6d2f7410d3b451800f856f3c6818303c316

Don't run gdb.gdb/ selftests if use_gdb_stub is true

If we make the native-gdbserver board be !is_remote, then the few
tests that use the selftest-support.exp routines to debug gdb itself
start running, and fail, with something like:

  Running ..../src/gdb/testsuite/gdb.gdb/selftest.exp ...
  ERROR: tcl error sourcing ..../src/gdb/testsuite/gdb.gdb/selftest.exp.
  ERROR: gdbserver does not support run [....] without extended-remote
      while executing
  "error "gdbserver does not support $command without extended-remote""
      (procedure "gdb_test_multiple" line 25)
      invoked from within
  "gdb_test_multiple "run $INTERNAL_GDBFLAGS" "$description" {
	  -re "Starting program.*Breakpoint \[0-9\]+,.*$function \\(\\).* at .*main.c:.*$gdb..."
      (procedure "selftest_setup" line 45)

This commit makes sure those tests continue to be skipped.

gdb/testsuite/ChangeLog:
2017-10-13  Pedro Alves  <palves@redhat.com>

	* lib/selftest-support.exp (selftest_setup): Extend comments, and
	also skip on stub-like targets.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] ada: Use std::string in print_dynamic_range_bound
@ 2017-10-14  3:35 sergiodj+buildbot
  2017-10-14 15:14 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-14  3:35 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3ec5942fbf8501db10784b0dff7d24222a113728 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 3ec5942fbf8501db10784b0dff7d24222a113728

ada: Use std::string in print_dynamic_range_bound

Replace this usage of GROW_VECT with an std::string.  I don't think
there's a reason for this variable to be static, other than it was
cumbersome to manage its lifetime (i.e. use a cleanup) before.

Tested by comparing the gdb.ada/*.exp test results before and after the
patch.

gdb/ChangeLog:

	* ada-typeprint.c (print_dynamic_range_bound): Use std::string.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Simplify tic6x and s390x expedite registers
@ 2017-10-14  2:59 sergiodj+buildbot
  2017-10-14  8:38 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-14  2:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2399fe6ab0b6ee64c569992e4bc3bbae3b5b2193 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 2399fe6ab0b6ee64c569992e4bc3bbae3b5b2193

Simplify tic6x and s390x expedite registers

Nowadays, we have six tic6x expedite registers, which are duplicated.

tic6x-c64xp-expedite = A15,PC
tic6x-c64x-expedite = A15,PC
tic6x-c62x-expedite = A15,PC
tic6x-c64xp-linux-expedite = A15,PC
tic6x-c64x-linux-expedite = A15,PC
tic6x-c62x-linux-expedite = A15,PC

in features/Makefile, we have

   echo "expedite:$(if $($*-expedite),$($*-expedite),$($(firstword $(subst -, ,$(notdir $*)))-expedite))" \
        >> $(outdir)/$*.tmp

which means for a given bar/foo-baz.xml, we'll look for either
bar/foo-baz-expedite or foo-expedite.  We can define only one generic
expedite register for all different ti6cx and s390x target descriptions.
Actually, we've done that for x86 target descriptions.

Re-run 'make GDB=/path/build/gdb all' to regenerate regformats/*.dat files,
and they are not changed.

gdb:

2017-10-13  Yao Qi  <yao.qi@linaro.org>

	* features/Makefile: Remove tic6x-*-expedite, add tic6x-expedite.
	Remove s390x-*-expedite, add s390x-expedite.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make gdb.base/find-unmapped.exp pass on remote targets
@ 2017-10-13 16:57 sergiodj+buildbot
  2017-10-14  9:58 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-13 16:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8b0553c18f0dc63ab0ae930f2e8eed2bce4cd32c ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 8b0553c18f0dc63ab0ae930f2e8eed2bce4cd32c

Make gdb.base/find-unmapped.exp pass on remote targets

Currently, with --target_board=native-extended-gdbserver, we get:

  Running .../src/gdb/testsuite/gdb.base/find-unmapped.exp ...
  FAIL: gdb.base/find-unmapped.exp: find global_var_0, global_var_2, 0xff
  FAIL: gdb.base/find-unmapped.exp: find global_var_1, global_var_2, 0xff
  FAIL: gdb.base/find-unmapped.exp: find global_var_2, (global_var_2 + 16), 0xff

This commit makes the test pass there, and also enables in on
--target_board=native-gdbserver, and other remote targets.

I've filed PR gdb/22293 to track the missing-warning problem.

gdb/testsuite/ChangeLog:
2017-10-13  Pedro Alves  <palves@redhat.com>

	PR gdb/22293
	* gdb.base/find-unmapped.exp: Don't skip if is_remote target.
	(top level): Move some tests to ...
	(test_not_found): ... this new procedure.
	(top level): Call it.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make gdb.base/solib-nodir.exp work with --target_board=native-extended-gdbserver
@ 2017-10-13 16:26 sergiodj+buildbot
  2017-10-13 18:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-13 16:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 27c9e813f93974c2d1e237f3c4f25029627bcb58 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 27c9e813f93974c2d1e237f3c4f25029627bcb58

Make gdb.base/solib-nodir.exp work with --target_board=native-extended-gdbserver

Fixes:
 Running .../src/gdb/testsuite/gdb.base/solib-nodir.exp ...
 FAIL: gdb.base/solib-nodir.exp: library loaded

... by using the new "set cwd" command.

gdb/testsuite/ChangeLog:
2017-10-13  Pedro Alves  <palves@redhat.com>
	    Simon Marchi <simon.marchi@polymtl.ca>

	* gdb.base/solib-nodir.exp: Split is_remote and skip_shlib_tests
	calls and add comments.  Skip test if use_gdb_stub is set.
	(top level): Use "set cwd" command instead of "cd" command.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix gdb.base/term.exp on non-"target native" boards
@ 2017-10-13 14:55 sergiodj+buildbot
  2017-10-14  4:44 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-13 14:55 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7594f6236073fcc8696c43e1f5267e61f7d5c226 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 7594f6236073fcc8696c43e1f5267e61f7d5c226

Fix gdb.base/term.exp on non-"target native" boards

With --target_board=native-extended-gdbserver, we get:

  Running .../src/gdb/testsuite/gdb.base/term.exp ...
  FAIL: gdb.base/term.exp: info terminal at breakpoint

  (gdb) info terminal
  No saved terminal information.

Fix it by running the test everywhere, and expecting different output
on non-native targets.

gdb/testsuite/ChangeLog:
2017-10-13  Pedro Alves  <palves@redhat.com>

	* gdb.base/term.exp: Don't skip if is_remote target.  Instead,
	expect different "info terminal" output if testing with a
	non-native target.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove is_remote kfail from gdb.python/py-evthreads.exp
@ 2017-10-13 14:31 sergiodj+buildbot
  2017-10-14  3:29 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-13 14:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ebe3b40202042fc644df5ea3bd111425ba1aeeee ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: ebe3b40202042fc644df5ea3bd111425ba1aeeee

Remove is_remote kfail from gdb.python/py-evthreads.exp

This testcase works fine with gdbserver nowadays.  So remove the
kfail.

gdb/testsuite/ChangeLog:
2017-10-13  Pedro Alves  <palves@redhat.com>
	    Simon Marchi  <simon.marchi@polymtl.ca>

	PR python/12966
	* gdb.python/py-evthreads.exp: Remove is_remote target kfail.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] kfail gdb.python/py-evsignal.exp on RSP targets properly
@ 2017-10-13 12:51 sergiodj+buildbot
  2017-10-14  0:46 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-13 12:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8d6ef72b0470dfb1133525c8c4556d3578744ac4 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 8d6ef72b0470dfb1133525c8c4556d3578744ac4

kfail gdb.python/py-evsignal.exp on RSP targets properly

Fixes, with --target_board=native-extended-gdbserver:

   Running ..../src/gdb/testsuite/gdb.python/py-evsignal.exp ...
   FAIL: gdb.python/py-evsignal.exp: signal Thread 3

gdb/testsuite/ChangeLog:
2017-10-13  Pedro Alves  <palves@redhat.com>

	* gdb.python/py-evsignal.exp: Check gdb_protocol instead of
	is_remote.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix is_remote check in gdb.base/remote.exp
@ 2017-10-13 11:37 sergiodj+buildbot
  2017-10-13 21:03 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-13 11:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 23fb630af09f2601e7cb75233837399d67cfd017 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 23fb630af09f2601e7cb75233837399d67cfd017

Fix is_remote check in gdb.base/remote.exp

1. Otherwise, when the native-gdbserver board stops setting is_remote,
   this test would stop running there.

2. Makes the test run with --target_board=native-extended-gdbserver
   too.

gdb/testsuite/ChangeLog:
2017-10-13  Pedro Alves  <palves@redhat.com>

	* gdb.base/remote.exp: Check gdb_protocol instead of is_remote.
	(top level): Add comment.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdb.base/remote.exp: Fix typo and add missing return
@ 2017-10-13 10:49 sergiodj+buildbot
  2017-10-13 19:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-13 10:49 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cc77b1dc33790bcb852c8c72e2efebaa3b505b01 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: cc77b1dc33790bcb852c8c72e2efebaa3b505b01

gdb.base/remote.exp: Fix typo and add missing return

(Dropped 'u' while at it because we're supposed to prefer American
English spelling...)

gdb/testsuite/ChangeLog:
2017-10-13  Pedro Alves  <palves@redhat.com>

	* gdb.base/remote.exp (top level): Fix comment typo and add
	missing return.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Eliminate is_remote check in gdb.base/shlib-call.exp
@ 2017-10-13  9:47 sergiodj+buildbot
  2017-10-13 16:49 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-13  9:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5e830d9807b91f806524ff822d953443c8fb3d2f ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 5e830d9807b91f806524ff822d953443c8fb3d2f

Eliminate is_remote check in gdb.base/shlib-call.exp

gdb/testsuite/ChangeLog:
2017-10-13  Pedro Alves  <palves@redhat.com>

	* gdb.base/shlib-call.exp (top level): Use gdb_run_cmd and remove
	is_remote target check.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove simple_displaced_step_copy_insn
@ 2017-10-13  5:12 sergiodj+buildbot
  2017-10-13 15:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-13  5:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c2508e905f956c5a5e0d2a7fff58b4c746180237 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: c2508e905f956c5a5e0d2a7fff58b4c746180237

Remove simple_displaced_step_copy_insn

Nothing uses this function.  Remove it, and adjust comments referring to
it.

gdb/ChangeLog:

	* arch-utils.h (simple_displaced_step_copy_insn): Remove.
	* arch-utils.c (simple_displaced_step_copy_insn): Remove.
	* gdbarch.sh (displaced_step_copy_insn): Adjust comment.
	* gdbarch.h: Regenerate.
	* i386-linux-tdep.c (i386_linux_displaced_step_copy_insn):
	Adjust comment.
	* i386-tdep.c (i386_displaced_step_copy_insn): Adjust comment.
	(i386_displaced_step_fixup): Adjust comment.
	* rs6000-tdep.c (ppc_displaced_step_copy_insn): Adjust comment.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] FT32: support for FT32B processor - part 1
@ 2017-10-13  4:53 sergiodj+buildbot
  2017-10-13 14:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-13  4:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3b4b0a629a972bf80fc0ac6202f89681fab1df37 ***

Author: James Bowman <jamesb@excamera.com>
Branch: master
Commit: 3b4b0a629a972bf80fc0ac6202f89681fab1df37

FT32: support for FT32B processor - part 1

FT32B is a new FT32 family member. It has a code
compression scheme, which requires the use of linker
relaxations. The change is quite large, so submission
is in several parts.

Part 1 adds a 15-bit instruction field, and CPU-specific functions for
the code compression that are used in binutils and GDB.

bfd/ChangeLog:

2017-10-12  James Bowman  <james.bowman@ftdichip.com>

	* bfd-in2.h: Regenerate.
	* libbfd.h: Regenerate.
	* elf32-ft32.c: Add HOWTO R_FT32_15.
	* reloc.c: Add BFD_RELOC_FT32_15.

gas/ChangeLog:

2017-10-12  James Bowman  <james.bowman@ftdichip.com>

	* config/tc-ft32.c (md_assemble): Replace FT32_FLD_K8 with
	K15.
	(md_apply_fix, tc_gen_reloc): Add BFD_RELOC_FT32_15.

include/ChangeLog:

2017-10-12  James Bowman  <james.bowman@ftdichip.com>

	* elf/ft32.h: Add R_FT32_15.
	* opcode/ft32.h: Replace FT32_FLD_K8 with K15.
	(ft32_shortcode, sc_compar, ft32_split_shortcode,
	ft32_merge_shortcode, ft32_merge_shortcode): New functions.

opcodes/ChangeLog:

2017-10-12  James Bowman  <james.bowman@ftdichip.com>

	* opcodes/ft32-dis.c (print_insn_ft32): Replace FT32_FLD_K8 with K15.
	* opcodes/ft32-opc.c (ft32_opc_info): Replace FT32_FLD_K8 with
	K15. Add jmpix pattern.

sim/ChangeLog:

2017-10-12  James Bowman  <james.bowman@ftdichip.com>

	* sim/ft32/interp.c (step_once): Replace FT32_FLD_K8 with K15.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add myself as ft32 maintainer for sim.
@ 2017-10-13  4:31 sergiodj+buildbot
  2017-10-13 12:46 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-13  4:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d268bbaff7da90caf5fbc94456ae58315ffa1802 ***

Author: James Bowman <jamesb@excamera.com>
Branch: master
Commit: d268bbaff7da90caf5fbc94456ae58315ffa1802

Add myself as ft32 maintainer for sim.

sim/ChangeLog:
2017-10-12  James Bowman  <james.bowman@ftdichip.com>

	* MAINTAINERS (ft32): Add myself.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove references to gdb64 in the testsuite
@ 2017-10-13  3:20 sergiodj+buildbot
  2017-10-13  9:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-13  3:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8aed1c0d04e6d0eb7d0790c4691665cffef573b7 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 8aed1c0d04e6d0eb7d0790c4691665cffef573b7

Remove references to gdb64 in the testsuite

I'm not sure whether this gdb64 was ever a thing in the upstream repo,
but it certainly doesn't exist nowadays.

AFAICT, this came in with the original big merge with the HP tree:
https://sourceware.org/ml/gdb-patches/1999-q2/msg00149.html

gdb/testsuite/ChangeLog:
2017-10-12  Pedro Alves  <palves@redhat.com>

	* gdb.base/attach.exp: Remove references to gdb64.
	* gdb.base/dbx.exp: Remove references to gdb64.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove is_remote check in labels.exp
@ 2017-10-13  3:01 sergiodj+buildbot
  2017-10-13  7:53 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-13  3:01 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cfa34c871c6644bd7b132b5ca7f2217880f5fa9b ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: cfa34c871c6644bd7b132b5ca7f2217880f5fa9b

Remove is_remote check in labels.exp

This works fine with remote target boards.

gdb/testsuite/ChangeLog:
2017-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
	    Pedro Alves  <palves@redhat.com>

	* gdb.base/label.exp: Remove is_remote target check.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make gdb.base/auvx.exp work with --target_board=native-extended-gdbserver
@ 2017-10-13  2:40 sergiodj+buildbot
  2017-10-13  6:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-13  2:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9192b7decc7256a41502bf68df36f429cceffc89 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 9192b7decc7256a41502bf68df36f429cceffc89

Make gdb.base/auvx.exp work with --target_board=native-extended-gdbserver

Currently we get:
 Running .../src/gdb/testsuite/gdb.base/auxv.exp ...
 WARNING: can't generate a core file - core tests suppressed - check ulimit -c

After this commit we get all the same PASSes as when native testing.

The problem is that the testcase wants to create a core dump in a
temporary directory and it is using the "cd" command to start the
inferior with that directory as current directory, but that command
only affects the inferior's cwd when native debugging.  Fix it by
using using the new "set cwd" command instead, which works with
gdbserver as well.

This still won't work with stub-like targets, because with those when
we connect the inferior is already running.  It'd be possible to make
it work by making the inferior itself change dirs, but we'll need to
make the native-gdbserver board no longer set is_remote first.

gdb/testsuite/ChangeLog:
2017-10-12  Pedro Alves  <palves@redhat.com>

	* gdb.base/auvx.exp (coredir): Update comment.
	(top level) <core_works>: Use "set cwd" command instead of "cd"
	command.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Use bool in pv_area
@ 2017-10-13  1:49 sergiodj+buildbot
  2017-10-13  5:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-13  1:49 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a900ff724a725ea951ba8b17232577e1a4b4866e ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: a900ff724a725ea951ba8b17232577e1a4b4866e

Use bool in pv_area

This updates a couple of member functions in pv_area to return bool.

gdb/ChangeLog
2017-10-12  Tom Tromey  <tom@tromey.com>

	* prologue-value.h (pv_area::store_would_trash): Return bool.
	(pv_area::find_reg): Likewise.
	* prologue-value.c (pv_area::store_would_trash): Return bool.
	(pv_area::find_reg): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] C++-ify prologue-value's pv_area
@ 2017-10-13  0:40 sergiodj+buildbot
  2017-10-13  4:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-13  0:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f7b7ed97a23e2bf4a2ec27bef0fe0af55a080a94 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: f7b7ed97a23e2bf4a2ec27bef0fe0af55a080a94

C++-ify prologue-value's pv_area

This patch is an initial C++-ification of pv_area, from
prologue-value.  It turns pv_area into a class with a constructor and
destructor; renames the data members; and changes various functions to
be member functions.  This allows the removal of
make_cleanup_free_pv_area.

gdb/ChangeLog
2017-10-12  Tom Tromey  <tom@tromey.com>

	* s390-linux-tdep.c (s390_store, s390_load)
	(s390_check_for_saved, s390_analyze_prologue): Update.
	* rx-tdep.c (check_for_saved, rx_analyze_prologue): Update.
	* rl78-tdep.c (rl78_analyze_prologue, check_for_saved): Update.
	* prologue-value.h (class pv_area): Move from prologue-value.c.
	Change names of members.  Add constructor, destructor, member
	functions.
	(make_pv_area, free_pv_area, make_cleanup_free_pv_area)
	(pv_area_store, pv_area_fetch, pv_area_store_would_trash)
	(pv_area_fetch, pv_area_scan): Don't declare.
	* prologue-value.c (struct pv_area::area_entry): Now member of
	pv_area.
	(struct pv_area): Move to prologue-value.h.
	(pv_area::pv_area): Rename from make_pv_area.
	(pv_area::~pv_area): Rename from free_pv_area.
	(do_free_pv_area_cleanup, make_cleanup_free_pv_area): Remove.
	(clear_entries, find_entry, overlaps, store_would_trash, store)
	(fetch, find_reg, scan): Now member of pv_area.
	Remove "area" argument.  Update.
	* msp430-tdep.c (check_for_saved, msp430_analyze_prologue):
	Update.
	* mn10300-tdep.c (push_reg, check_for_saved)
	(mn10300_analyze_prologue): Update.
	* mep-tdep.c (is_arg_spill, check_for_saved)
	(mep_analyze_prologue): Update.
	* m32c-tdep.c (m32c_pv_push, m32c_srcdest_fetch)
	(m32c_srcdest_store, m32c_pv_enter, m32c_is_arg_spill)
	(m32c_is_struct_return, m32c_analyze_prologue): Update.
	* arm-tdep.c (thumb_analyze_prologue, arm_analyze_prologue):
	Update.
	* arc-tdep.c (arc_is_in_prologue, arc_analyze_prologue): Update.
	* aarch64-tdep.c (aarch64_analyze_prologue): Update.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Run gdb.base/catch-fork-static.exp on remote target boards
@ 2017-10-13  0:06 sergiodj+buildbot
  2017-10-13  0:06 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-13  0:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6bf0052db8bbeed41e512d1d3ce14ba2a446723d ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 6bf0052db8bbeed41e512d1d3ce14ba2a446723d

Run gdb.base/catch-fork-static.exp on remote target boards

Another case of a stale check.  We support following forks in the
remote protocol nowadays.

gdb/testsuite/ChangeLog:
2017-10-12  Pedro Alves  <palves@redhat.com>
	    Simon Marchi  <simon.marchi@polymtl.ca>

	* gdb.base/catch-fork-static.exp: No longer skip on is_remote
	target boards.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] linux low: Make the arch code free arch_process_info
@ 2017-10-12 23:51 sergiodj+buildbot
  2017-10-13  2:58 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-12 23:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 04ec7890fccfa5ddd9cc92961a4df58957ca181b ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 04ec7890fccfa5ddd9cc92961a4df58957ca181b

linux low: Make the arch code free arch_process_info

For the same reason as the previous patch, we need to make the
arch-specific code free the arch_process_info structure it allocates.

gdb/gdbserver/ChangeLog:

	* linux-low.h (struct linux_target_ops) <delete_process>: New
	field.
	* linux-low.c (linux_mourn): Call the_low_target.delete_process.
	* linux-aarch64-low.c (aarch64_linux_delete_process): New.
	(struct linux_target_ops): Add delete_process callback.
	* linux-arm-low.c (arm_delete_process): New.
	(struct linux_target_ops): Add delete_process callback.
	* linux-bfin-low.c (struct linux_target_ops): Likewise.
	* linux-crisv32-low.c (struct linux_target_ops): Likewise.
	* linux-m32r-low.c (struct linux_target_ops): Likewise.
	* linux-mips-low.c (mips_linux_delete_process): New.
	(struct linux_target_ops): Add delete_process callback.
	* linux-ppc-low.c (struct linux_target_ops): Likewise.
	* linux-s390-low.c (struct linux_target_ops): Likewise.
	* linux-sh-low.c (struct linux_target_ops): Likewise.
	* linux-tic6x-low.c (struct linux_target_ops): Likewise.
	* linux-tile-low.c (struct linux_target_ops): Likewise.
	* linux-x86-low.c (x86_linux_delete_process): New.
	(struct linux_target_ops): Add delete_process callback.
	* linux-xtensa-low.c (struct linux_target_ops): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] lwp_info: Make the arch code free arch_lwp_info
@ 2017-10-12 21:52 sergiodj+buildbot
  2017-10-13  1:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-12 21:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 466eeceef409597388dd2b4e8b907cf080bedcf1 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 466eeceef409597388dd2b4e8b907cf080bedcf1

lwp_info: Make the arch code free arch_lwp_info

I have the goal of "poisoning" the XNEW/xfree-family of functions, so
that we catch their usages with non-POD types.  A few things need to be
fixed in the mean time, this is one.

The common lwp code in linux-nat.c and gdbserver/linux-low.c xfrees the
private lwp data of type arch_lwp_info.  However, that type is opaque
from its point of view, as its defined differently in each arch-specific
implementation.  This trips on the std::is_pod<T> check, since the
compiler can't tell whether the type is POD or not if it doesn't know
about it.

My initial patch [1] made a class hierarchy with a virtual destructor.
However, as Pedro pointed out, we only have one native architecture at
the time built in gdb and gdbserver, so that's overkill.  Instead, we
can move the responsibility of free'ing arch_lwp_info to the arch code
(which is also the one that allocated it in the first place).  This is
what this patch does.

Also, I had the concern that if we wanted to use C++ features in these
structures, we would have a problem with the one-definition rule.
However, since a build will only have one version of arch_lwp_info,
that's not a problem.

There are changes in arch-specific files, I was only able to built-test
this patch with the following cross-compilers:

  aarch64-linux-gnu
  alpha-linux-gnu
  arm-linux-gnueabihf
  hppa-linux-gnu
  m68k-linux-gnu
  mips64el-linux-gnuabi64
  powerpc64-linux-gnu
  s390x-linux-gnu
  sh4-linux-gnu
  sparc64-linux-gnu
  x86_64-linux-gnu
  x86_64-w64-mingw32

A buildbot run didn't find any regression.

[1] https://sourceware.org/ml/gdb-patches/2017-08/msg00255.html

gdb/ChangeLog:

	* linux-nat.h (linux_nat_set_delete_thread): New declaration.
	* linux-nat.c (linux_nat_delete_thread): New variable.
	(lwp_free): Invoke linux_nat_delete_thread if set.
	(linux_nat_set_delete_thread): New function.
	* aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Assign
	thread delete callback.
	* arm-linux-nat.c (arm_linux_delete_thread): New function.
	(_initialize_arm_linux_nat): Assign thread delete callback.
	* s390-linux-nat.c (s390_delete_thread): New function.
	(_initialize_s390_nat): Assign thread delete callback.
	* x86-linux-nat.c (x86_linux_add_target): Likewise.
	* nat/aarch64-linux.c (aarch64_linux_delete_thread): New
	function.
	* nat/aarch64-linux.h (aarch64_linux_delete_thread): New
	declaration.
	* nat/x86-linux.c (x86_linux_delete_thread): New function.
	* nat/x86-linux.h (x86_linux_delete_thread): New declaration.

gdb/gdbserver/ChangeLog:

	* linux-aarch64-low.c (the_low_target): Add thread delete
	callback.
	* linux-arm-low.c (arm_delete_thread): New function.
	(the_low_target): Add thread delete callback.
	* linux-bfin-low.c (the_low_target): Likewise.
	* linux-crisv32-low.c (the_low_target): Likewise.
	* linux-low.c (delete_lwp): Invoke delete_thread callback if
	set.
	* linux-low.h (struct linux_target_ops) <delete_thread>: New
	field.
	* linux-m32r-low.c (the_low_target): Add thread delete callback.
	* linux-mips-low.c (mips_linux_delete_thread): New function.
	(the_low_target): Add thread delete callback.
	* linux-ppc-low.c (the_low_target): Likewise.
	* linux-s390-low.c (the_low_target): Likewise.
	* linux-sh-low.c (the_low_target): Likewise.
	* linux-tic6x-low.c (the_low_target): Likewise.
	* linux-tile-low.c (the_low_target): Likewise.
	* linux-x86-low.c (the_low_target): Likewise.
	* linux-xtensa-low.c (the_low_target): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] checkpoint.exp: Check for non-"target native" instead of isnative/is_remote
@ 2017-10-12 19:33 sergiodj+buildbot
  2017-10-12 22:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-12 19:33 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e48ef82dd2fc85560d14a45a632c82eaaadca7ce ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: e48ef82dd2fc85560d14a45a632c82eaaadca7ce

checkpoint.exp: Check for non-"target native" instead of isnative/is_remote

This gets rid of a number of FAILs with
--target_board=native-extended-gdbserver.

The fact that checkpointing does not work has nothing to do with
dejagnu's native and remote concepts.  It only works with native Linux
targets because the implementation is currently baked with
linux-nat.c.

gdb/testsuite/ChangeLog:
2017-10-12  Pedro Alves  <palves@redhat.com>
	    Simon Marchi  <simon.marchi@polymtl.ca>

	* gdb.base/checkpoint.exp: Don't check is_remote or isnative.
	Instead skip if there's any gdb_protocol set.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove is_remote target check from gdb.base/dprintf-non-stop.exp
@ 2017-10-12 19:12 sergiodj+buildbot
  2017-10-12 21:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-12 19:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8d7aea574a8ab3a235088866860df75b542ae4a3 ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 8d7aea574a8ab3a235088866860df75b542ae4a3

Remove is_remote target check from gdb.base/dprintf-non-stop.exp

1. is_remote is not the right check.

2. Both Simon & Pedro ran it continuously for some time against
   native-gdbserver and didn't see a failure.

3. The test has been running against native-extended-gdbserver anyway.

gdb/testsuite/ChangeLog:
2017-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
	    Pedro Alves  <palves@redhat.com>

	* gdb.base/dprintf-non-stop.exp: Remove is_remote target check.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Tighten remote check in gdb.base/argv0-symlink.exp
@ 2017-10-12 18:52 sergiodj+buildbot
  2017-10-12 20:13 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-12 18:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 30440677f3d0cdd2085bea40496774ffa24f6bb1 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 30440677f3d0cdd2085bea40496774ffa24f6bb1

Tighten remote check in gdb.base/argv0-symlink.exp

Check for gdbserver instead of dejagnu remote.  Unlike what the
comment says, the test actually fails with target remote + gdbserver
(it does pass with extended-remote).  The result is:

 FAIL -> KFAIL with --target_board=native-gdbserver
 KPASS -> PASS with --target_board=native-extended-gdbserver

gdb/testsuite/ChangeLog:
2017-10-12  Pedro Alves  <palves@redhat.com>
	    Simon Marchi  <simon.marchi@polymtl.ca>

	* gdb.base/argv0-symlink.exp: kfail on remote gdbserver,
	instead of on dejagnu remote boards.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Enable gdb.base/inferior-died.exp on is_remote target boards
@ 2017-10-12 18:10 sergiodj+buildbot
  2017-10-12 18:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-12 18:10 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4e04f0450f83d8d0ad08579b5e6c8b4e8a8e693f ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 4e04f0450f83d8d0ad08579b5e6c8b4e8a8e693f

Enable gdb.base/inferior-died.exp on is_remote target boards

We support follow-fork in the remote protocol nowadays.

Also, the right way to enable non-stop mode is to do it before
connecting, and for use_gdb_stub boards, that means we have to do it
at gdb_load time.  The "modern" pattern for that is to pass non-stop
in GDBFLAGS.

This makes the test pass with --target_board=native-gdbserver.

gdb/testsuite/ChangeLog:
2017-10-12  Pedro Alves  <palves@redhat.com>
	    Simon Marchi <simon.marchi@polymtl.ca>

	* gdb.base/inferior-died.exp: Remove is_remote and isnative
	checks.  Use build_executable + clean_restart instead of
	prepare_for_testing.  Pass "set non-stop on" via GDBFLAGS instead
	of enabling non-stop after starting gdb.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Force the AArch64 linker backend to refuse to link when it encounters unresoleable relocations.
@ 2017-10-12 13:05 sergiodj+buildbot
  2017-10-12 13:05 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-12 13:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1d75a8e26e6def4f492c84a5f678e41ddebda799 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 1d75a8e26e6def4f492c84a5f678e41ddebda799

Force the AArch64 linker backend to refuse to link when it encounters unresoleable relocations.

	* reloc.c (enum bfd_reloc_status): Start values at 2.
	* bfd-in2.h: Regenerate.
	* elfnn-aarch64.c (aarch64_relocate): Invert sense of function, so
	that a TRUE return indicates success.  Compare the result of
	calling _bfd_aarch64_elf_put_addend against bfd_reloc_ok.
	(build_one_stub): Change sense of tests against aarch64_relocate
	return value.
	(elfNN_aarch64_tls_relax): Return bfd_reloc_notsupported, rather
	than FALSE, when an error is detected.
	(elfNN_aarch64_final_link_relocate): Likewise.

	* testsuite/ld-aarch64/pcrel_pic_defined.d: Expect errors not
	warnings.  Expect errors about unsupported relocations.
	* testsuite/ld-aarch64/pcrel_pic_undefined.d: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: Add _bfd_x86_elf_hide_symbol
@ 2017-10-12  9:37 sergiodj+buildbot
  2017-10-12  9:54 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-12  9:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9f8575350f980aa6da8c488c6aa30862620eaa1f ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 9f8575350f980aa6da8c488c6aa30862620eaa1f

x86: Add _bfd_x86_elf_hide_symbol

When there is no dynamic interpreter in PIE, make the undefined weak
symbol dynamic so that PC relative branch to the undefined weak symbol
will land to address 0.

	* elf32-i386.c (elf_backend_hide_symbol): New.
	* elf64-x86-64.c (elf_backend_hide_symbol): Likewise.
	* elfxx-x86.c (_bfd_x86_elf_hide_symbol): Likewise.
	* elfxx-x86.h (_bfd_x86_elf_hide_symbol): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] _bfd_elf_link_hash_hide_symbol calls in generic ELF code
@ 2017-10-12  3:43 sergiodj+buildbot
  2017-10-12  7:29 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-12  3:43 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 559192d89d743834951fc386530c6bc7f89b358d ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 559192d89d743834951fc386530c6bc7f89b358d

_bfd_elf_link_hash_hide_symbol calls in generic ELF code

This function shouldn't be called directly, except from backend code.

bfd/
	* elflink.c (_bfd_elf_adjust_dynamic_symbol): Call
	elf_backend_hide_symbol, not _bfd_elf_link_hash_hide_symbol.
	(bfd_elf_define_start_stop): Likewise.
ld/
	* emultempl/elf32.em (before_allocation): Call
	elf_backend_hide_symbol, not _bfd_elf_link_hash_hide_symbol.
	Formatting.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Constify add_prefix_cmd
@ 2017-10-11 23:12 sergiodj+buildbot
  2017-10-12  3:13 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-11 23:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 981a3fb3594dddae266b7a5014c3001727200d7b ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 981a3fb3594dddae266b7a5014c3001727200d7b

Constify add_prefix_cmd

This changes add_prefix_cmd to accept a const-taking function as an
argument; then fixes up all the callers.

In a couple of spots I had to add a non-const overload of a function,
because the function is passed to two different command-adding
"constructors".  These overloads are temporary; once constification is
complete they can be removed.

This patch also fixes a typo I happened to notice while constifying.

Note that this touches a couple of files (gnu-nat.c and go32-nat.c)
that I can't build.  So, while I made a best-effort there, I am not
certain they will still compile.

Tested by rebuilding.

gdb/ChangeLog
2017-10-11  Tom Tromey  <tom@tromey.com>

	* gdbthread.h (thread_command): Constify.
	* inferior.h (detach_command): Constify.
	* top.h (set_history, show_history): Constify.
	* arm-tdep.c (set_arm_command, show_arm_command): Constify.
	* serial.c (serial_set_cmd, serial_show_cmd): Constify.
	* bsd-kvm.c (bsd_kvm_cmd): Constify.
	* printcmd.c (set_command): Constify.
	(non_const_set_command): New function.
	* dcache.c (set_dcache_command, show_dcache_command): Constify.
	* breakpoint.c (enable_command, disable_command, delete_command)
	(catch_command, tcatch_command, set_breakpoint_cmd)
	(show_breakpoint_cmd): Constify.
	* macrocmd.c (macro_command): Constify.
	* infcmd.c (unset_command, kill_command, detach_command)
	(info_proc_cmd): Constify.
	* i386-tdep.c (set_mpx_cmd, show_mpx_cmd): Constify.
	* auto-load.c (show_auto_load_cmd, set_auto_load_cmd)
	(info_auto_load_cmd): Constify.
	* target-descriptions.c (set_tdesc_cmd, show_tdesc_cmd)
	(unset_tdesc_cmd): Constify.
	* ada-lang.c (set_ada_command, show_ada_command)
	(maint_set_ada_cmd, maint_show_ada_cmd): Constify.
	* guile/guile.c (set_guile_command, show_guile_command)
	(info_guile_command): Constify.
	* tui/tui-win.c (tui_command, set_tui_cmd, show_tui_cmd):
	Constify.
	* skip.c (skip_command): Constify.
	* compile/compile.c (_initialize_compile): Constify.
	* dwarf2read.c (set_dwarf_cmd, show_dwarf_cmd): Constify.
	* btrace.c (maint_btrace_cmd, maint_btrace_set_cmd)
	(maint_btrace_show_cmd, maint_btrace_pt_set_cmd)
	(maint_btrace_pt_show_cmd): Constify.
	* remote.c (set_remote_cmd, show_remote_cmd, remote_command):
	Constify.
	* python/python.c (user_show_python, user_set_python): Constify.
	* mips-tdep.c (set_mips_command, show_mips_command)
	(set_mipsfpu_command): Constify.
	* record-btrace.c (cmd_record_btrace_start)
	(cmd_set_record_btrace, cmd_show_record_btrace)
	(cmd_set_record_btrace_bts, cmd_show_record_btrace_bts)
	(cmd_set_record_btrace_pt, cmd_show_record_btrace_pt): Constify.
	* rs6000-tdep.c (set_powerpc_command, show_powerpc_command):
	Constify.
	* symfile.c (overlay_command): Constify.
	* spu-tdep.c (set_spu_command, show_spu_command): Constify.
	* cli/cli-logging.c (set_logging_command, show_logging_command):
	Constify.
	* cli/cli-dump.c (dump_command, append_command)
	(srec_dump_command, ihex_dump_command, verilog_dump_command)
	(tekhex_dump_command, binary_dump_command)
	(binary_append_command): Constify.
	* cli/cli-decode.c (struct cmd_list_element): Change type of
	"fun".
	* cli/cli-cmds.c (info_command, show_command, set_debug)
	(show_debug): Constify.
	(show_command): Add non-const overload.
	* top.c (set_history, show_history): Constify.
	* sh-tdep.c (set_sh_command, show_sh_command): Constify.
	* command.h (add_prefix_cmd): Accept a cmd_const_cfunc_ftype.
	* target.c (target_command): Constify.
	* sparc64-tdep.c (info_adi_command): Constify.
	* record-full.c (cmd_record_full_start): Constify.
	(set_record_full_command): Constify.  Fix typo.
	(show_record_full_command): Constify.
	* thread.c (thread_command, thread_apply_command): Constify.
	* memattr.c (dummy_cmd): Constify.
	* value.c (function_command): Constify.
	* frame.c (set_backtrace_cmd, show_backtrace_cmd): Constify.
	* probe.c (info_probes_command): Constify.
	* ser-tcp.c (set_tcp_cmd, show_tcp_cmd): Constify.
	* gnu-nat.c (set_task_cmd, show_task_cmd, set_thread_cmd)
	(show_thread_cmd, set_thread_default_cmd)
	(show_thread_default_cmd): Constify.
	(check_empty): Constify.
	* tracepoint.c (tfind_command): Constify.
	* cp-support.c (maint_cplus_command): Constify.
	* windows-tdep.c (info_w32_command): Constify.
	* record.c (cmd_record_start, set_record_command)
	(show_record_command, info_record_command, cmd_record_goto):
	Constify.
	* ravenscar-thread.c (set_ravenscar_command)
	(show_ravenscar_command): Constify.
	* utils.c (set_internal_problem_cmd, show_internal_problem_cmd):
	Constify.
	(add_internal_problem_command): Remove casts.
	* arc-tdep.c (maintenance_print_arc_command): Constify.
	* valprint.c (set_print, show_print, set_print_raw)
	(show_print_raw): Constify.
	* maint.c (maintenance_command, maintenance_info_command)
	(maintenance_print_command, maintenance_set_cmd)
	(maintenance_show_cmd, set_per_command_cmd)
	(show_per_command_cmd, maintenance_check_command): Constify.
	* language.c (set_check, show_check): Constify.
	* typeprint.c (show_print_type, set_print_type): Constify.
	* go32-nat.c (go32_info_dos_command): Constify.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove prepare_re_set_context
@ 2017-10-11 22:52 sergiodj+buildbot
  2017-10-12  1:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-11 22:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fdf44873ec6e37417bf8c8ce33bb9b1a6b4ddcef ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: fdf44873ec6e37417bf8c8ce33bb9b1a6b4ddcef

Remove prepare_re_set_context

prepare_re_set_context returns a null cleanup and doesn't seem
generally useful.  This patch removes it plus a few more cleanups; and
changes breakpoint_re_set to use scoped_restore rather than its own
manual mechanism.

2017-10-11  Tom Tromey  <tom@tromey.com>

	* breakpoint.c (prepare_re_set_context): Remove.
	(breakpoint_re_set_one): Update.  Don't use cleanups.
	(breakpoint_re_set): Use scoped_restore, std::string, and
	scoped_restore_current_language.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add FreeBSD/arm architecture.
@ 2017-10-11 20:03 sergiodj+buildbot
  2017-10-11 22:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-11 20:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7176dfd28d1a2a74e6d8dd698aeb857eb6edfb98 ***

Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: 7176dfd28d1a2a74e6d8dd698aeb857eb6edfb98

Add FreeBSD/arm architecture.

Support for collecting and supplying general purpose and floating
point registers is provided along with signal frame unwinding.  While
FreeBSD/arm kernels do populate NT_FPREGSET notes, they are always
zero-filled, so this implementation ignores them.  Recent FreeBSD/arm
kernels generate NT_ARM_VFP notes which are used to supply
floating-point registers.  As with Linux, the AT_HWCAP feature flags
are used to determine the correct target description.

gdb/ChangeLog:

	* Makefile.in (ALL_TARGET_OBS): Add arm-fbsd-tdep.o.
	(ALLDEPFILES): Add arm-fbsd-tdep.c.
	* NEWS: Mention new FreeBSD/arm target.
	* configure.tgt: Add arm*-*-freebsd*.
	* arm-fbsd-tdep.c: New file.
	* arm-fbsd-tdep.h: New file.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] GDB: Remove Linux core PRPSINFO note writer override
@ 2017-10-11 16:50 sergiodj+buildbot
  2017-10-11 20:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-11 16:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT fe22022617a7122491aa83c893a10a8d861cde73 ***

Author: Maciej W. Rozycki <macro@imgtec.com>
Branch: master
Commit: fe22022617a7122491aa83c893a10a8d861cde73

GDB: Remove Linux core PRPSINFO note writer override

Revert parts of commit b3ac9c77560a ("Put more info in NT_PRPSINFO Linux
notes"), <https://sourceware.org/ml/binutils/2013-02/msg00024.html>, and
remove support for a Linux core PRPSINFO note writer override, now that
all variants are handled automatically within BFD itself.

	gdb/
	* linux-tdep.c (linux_make_corefile_notes): Remove call to
	`gdbarch_elfcore_write_linux_prpsinfo'.
	* gdbarch.sh (elfcore_write_linux_prpsinfo): Remove architecture
	method.
	(elf_internal_linux_prpsinfo): Remove declaration.
	* gdbarch.h: Regenerate.
	* gdbarch.c: Regenerate.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] ELF/BFD: Handle both variants of the 64-bit Linux core PRPSINFO note
@ 2017-10-11 16:30 sergiodj+buildbot
  2017-10-11 19:38 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-11 16:30 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3c9a7b0d6d84425ea24d222a1a31e206e587374f ***

Author: Maciej W. Rozycki <macro@imgtec.com>
Branch: master
Commit: 3c9a7b0d6d84425ea24d222a1a31e206e587374f

ELF/BFD: Handle both variants of the 64-bit Linux core PRPSINFO note

Fix commit 70a38d42c5b3 ("New entry points for writing Linux NT_PRPSINFO
notes."), <https://sourceware.org/ml/binutils/2013-02/msg00023.html>,
and handle both variants of the 64-bit Linux core PRPSINFO note across
all targets.

The 64-bit Linux core PRPSINFO note matches the 64-bit kernel structure,
defined as follows:

(gdb) ptype struct elf_prpsinfo
type = struct elf_prpsinfo {
    char pr_state;
    char pr_sname;
    char pr_zomb;
    char pr_nice;
    unsigned long pr_flag;
    __kernel_uid_t pr_uid;
    __kernel_gid_t pr_gid;
    pid_t pr_pid;
    pid_t pr_ppid;
    pid_t pr_pgrp;
    pid_t pr_sid;
    char pr_fname[16];
    char pr_psargs[80];
}
(gdb)

where the individual data types of most members are the same across all
64-bit Linux ports, with the exception of `__kernel_uid_t' and
`__kernel_gid_t'.  These are defined in <asm-generic/posix_types.h> as
32-bit `unsigned int' by default, however overridden as 16-bit `unsigned
short' in port-specific <asm/posix_types.h> for the SuperH target.

The default is already handled, as from the commit referred.  Add the
other variant then and provide a backend flag to switch between the two
cases possible, with the 32-bit one being the default and the 16-bit one
explicitly selected.  Set the flag in the SuperH target backend.  This
arrangement is analogous to how the 32-bit Linux core PRPSINFO note is
handled.

	bfd/
	* elf-bfd.h (elf_backend_data): Add `linux_prpsinfo64_ugid16'
	member.
	* elf-linux-core.h (elf_external_linux_prpsinfo64): Rename to...
	(elf_external_linux_prpsinfo64_ugid32): ... this.
	(swap_linux_prpsinfo32_out): Rename to...
	(swap_linux_prpsinfo32_ugid32_out): ... this.
	(elf_external_linux_prpsinfo64_ugid16): New structure.
	(swap_linux_prpsinfo64_ugid16_out): New function.
	* elfxx-target.h [!elf_backend_linux_prpsinfo64_ugid16]
	(elf_backend_linux_prpsinfo64_ugid16): Define.
	(elfNN_bed): Initialize `linux_prpsinfo64_ugid16' member.
	* elf.c (elfcore_write_linux_prpsinfo64): Handle both variants
	of the 64-bit Linux core PRPSINFO note.
	* elf64-sh64.c (elf_backend_linux_prpsinfo64_ugid16): Define.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] ELF/BFD, GDB: Handle both variants of the 32-bit Linux core PRPSINFO note
@ 2017-10-11 16:09 sergiodj+buildbot
  2017-10-11 18:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-11 16:09 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a2f63b2e7a5da01ff828b45c7e0e57265ee24131 ***

Author: Maciej W. Rozycki <macro@imgtec.com>
Branch: master
Commit: a2f63b2e7a5da01ff828b45c7e0e57265ee24131

ELF/BFD,GDB: Handle both variants of the 32-bit Linux core PRPSINFO note

Fix commit 70a38d42c5b3 ("New entry points for writing Linux NT_PRPSINFO
notes."), <https://sourceware.org/ml/binutils/2013-02/msg00023.html>,
and commit b3ac9c77560a ("Put more info in NT_PRPSINFO Linux notes"),
<https://sourceware.org/ml/binutils/2013-02/msg00024.html>, and handle
both variants of the 32-bit Linux core PRPSINFO note across all targets.

The 32-bit Linux core PRPSINFO note matches the 32-bit kernel structure,
defined as follows:

(gdb) ptype struct elf_prpsinfo
type = struct elf_prpsinfo {
    char pr_state;
    char pr_sname;
    char pr_zomb;
    char pr_nice;
    unsigned long pr_flag;
    __kernel_uid_t pr_uid;
    __kernel_gid_t pr_gid;
    pid_t pr_pid;
    pid_t pr_ppid;
    pid_t pr_pgrp;
    pid_t pr_sid;
    char pr_fname[16];
    char pr_psargs[80];
}
(gdb)

where the individual data types of most members are the same across all
32-bit Linux ports, with the exception of `__kernel_uid_t' and
`__kernel_gid_t'.  These are defined in <asm-generic/posix_types.h> as
32-bit `unsigned int' by default, however overridden as 16-bit `unsigned
short' in port-specific <asm/posix_types.h> for a few targets, mostly
earlier ports of Linux, specifically: ARM, CRIS, FR-V, M32R, m68k,
MN10300/AM33, s390, SuperH, SPARC and i386.

The default is the same as the PowerPC variant already handled, as from
the commits referred.  Make the special PowerPC case generic then,
removing the GDB part, and provide a backend flag to switch between the
two cases possible, with the 32-bit one being the default and the 16-bit
one explicitly selected.  Set the flag in the target backends affected.

	bfd/
	* elf-bfd.h (elf_backend_data): Add `linux_prpsinfo32_ugid16'
	member.
	(elfcore_write_ppc_linux_prpsinfo32): Remove prototype.
	* elf32-ppc.c (elfcore_write_ppc_linux_prpsinfo32): Remove.
	(elf_external_ppc_linux_prpsinfo32)
	(swap_ppc_linux_prpsinfo32_out): Move to...
	* elf-linux-core.h (elf_external_linux_prpsinfo32_ugid32)
	(swap_linux_prpsinfo32_ugid32_out): ... these.
	(elf_external_linux_prpsinfo32): Rename to...
	(elf_external_linux_prpsinfo32_ugid16): ... this.
	(swap_linux_prpsinfo32_out): Rename to...
	(swap_linux_prpsinfo32_ugid16_out): ... this.
	* elfxx-target.h [!elf_backend_linux_prpsinfo32_ugid16]
	(elf_backend_linux_prpsinfo32_ugid16): Define.
	(elfNN_bed): Initialize `linux_prpsinfo32_ugid16' member.
	* elf.c (elfcore_write_linux_prpsinfo32): Handle both variants
	of the 32-bit Linux core PRPSINFO note.
	* elf32-am33lin.c (elf_backend_linux_prpsinfo32_ugid16): Define.
	* elf32-arm.c (elf_backend_linux_prpsinfo32_ugid16): Define.
	* elf32-cris.c (elf_backend_linux_prpsinfo32_ugid16): Define.
	* elf32-frv.c (elf_backend_linux_prpsinfo32_ugid16): Define.
	* elf32-i386.c (elf_backend_linux_prpsinfo32_ugid16): Define.
	* elf32-m32r.c (elf_backend_linux_prpsinfo32_ugid16): Define.
	* elf32-m68k.c (elf_backend_linux_prpsinfo32_ugid16): Define.
	* elf32-s390.c (elf_backend_linux_prpsinfo32_ugid16): Define.
	* elf32-sh.c (elf_backend_linux_prpsinfo32_ugid16): Define.
	* elf32-sparc.c (elf_backend_linux_prpsinfo32_ugid16): Define.

	gdb/
	* ppc-linux-tdep.c (ppc_linux_init_abi): Remove call to
	`set_gdbarch_elfcore_write_linux_prpsinfo'.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] arc: Pass proper CPU value to the disassembler
@ 2017-10-11 13:11 sergiodj+buildbot
  2017-10-11 13:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-11 13:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 56d704daee44b036d1eff86123de6dec0c55f61b ***

Author: Anton Kolesov <Anton.Kolesov@synopsys.com>
Branch: master
Commit: 56d704daee44b036d1eff86123de6dec0c55f61b

arc: Pass proper CPU value to the disassembler

There was a problem with generation of the disassembler options for ARC in GDB,
because a BFD architecture name was used as a CPU name, but they have different
meaning even if some architectures have same name as respective CPUs.  Target
description specifies a BFD architecture, which is different from ARC CPU, as
accepted by the disassembler (and most other ARC tools), because CPU values are
much more fine grained - there can be multiple CPU values per single BFD
architecture.  As a result this code should translate architecture to some CPU
value.  Since there is no info on exact CPU configuration, it is best to use
the most feature-rich CPU, so that the disassembler will recognize all
instructions available to the specified architecture.

gdb/ChangeLog
yyyy-mm-dd  Anton Kolesov  <Anton.Kolesov@synopsys.com>

	* arc-tdep.c (arc_gdbarch_init): Pass proper cpu value to disassembler.
	* arc-tdep.h (arc_arch_is_em): New function.
	(arc_arch_is_hs): Likewise.

gdb/testsuite/ChangeLog
yyyy-mm-dd  Anton Kolesov  <Anton.Kolesov@synopsys.com>

	* gdb.arch/arc-tdesc-cpu.exp: New file.
	* gdb.arch/arc-tdesc-cpu.xml: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Rename _doprnt -> _bfd_doprnt to fix DJGPP bfd build (and likely others)
@ 2017-10-11 12:08 sergiodj+buildbot
  2017-10-11 12:13 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-11 12:08 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8f314ad58ec824ce6c8467af29f11583f79a80ea ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 8f314ad58ec824ce6c8467af29f11583f79a80ea

Rename _doprnt -> _bfd_doprnt to fix DJGPP bfd build (and likely others)

Building bfd/ for DJGPP, I see:

 ../../src/bfd/bfd.c:642:1: error: conflicting types for '_doprnt'
  _doprnt (FILE *stream, const char *format, va_list ap)
  ^~~~~~~
 In file included from ../../src/bfd/sysdep.h:37:0,
		  from ../../src/bfd/bfd.c:367:
 /usr/lib64/gcc/i586-pc-msdosdjgpp/6.1.0/include-fixed/stdio.h:171:5: note: previous declaration of '_doprnt' was here
  int _doprnt(const char *_fmt, va_list _args, FILE *_f);
      ^~~~~~~

Possible fixes the build on other systems too -- _doprnt was/is an
exported symbol on old Unix/BSD systems too.

bfd/ChangeLog:
2017-10-11  Pedro Alves  <palves@redhat.com>

	* bfd.c (_doprnt): Rename to ...
	(_bfd_doprnt): ... this.
	(error_handler_internal): Adjust.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove unnecessary parentheses in declarations
@ 2017-10-11 10:21 sergiodj+buildbot
  2017-10-11 10:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-11 10:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7fa29be949a96f68ee65dcdb4f56f132609170db ***

Author: Egeyar Bagcioglu <egeyar.bagcioglu@oracle.com>
Branch: master
Commit: 7fa29be949a96f68ee65dcdb4f56f132609170db

Remove unnecessary parentheses in declarations

GCC commit a94975e57 ("C++ warning on vexing parse") introduces new
warnings "unnecessary parentheses in the declaration of ...".  These
cause the build of binutils and gdb to fail.  This patch removes those
parentheses for a successful build.

gdb/ChangeLog:
2017-10-11  Egeyar Bagcioglu  <egeyar.bagcioglu@oracle.com>

	* macrotab.h (macro_lookup_inclusion): Remove unnecessary
	parentheses in the declaration.
	(macro_lookup_inclusion): Likewise.
	(macro_lookup_definition): Likewise.
	* p-lang.h (pascal_builtin_types): Likewise.
	* tui/tui-data.c (tui_win_list): Likewise.
	* tui/tui-data.h (tui_win_list): Likewise.
	* utils.h (make_cleanup_free_section_addr_info): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: Set GOT refcount to 1
@ 2017-10-10 23:19 sergiodj+buildbot
  2017-10-11  0:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-10 23:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0f09b4d8d8f7c5d249c8375c5c42d4eba3bdc858 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 0f09b4d8d8f7c5d249c8375c5c42d4eba3bdc858

x86: Set GOT refcount to 1

Since x86 check_relocs is called after opening all inputs and garbage
collection, they never see the removed sections.  There is no need
for incrementing GOT refcount.  But since PLT refcount is also used in

  /* Don't create the PLT entry if there are only function pointer
     relocations which can be resolved at run-time.  */
  else if (htab->elf.dynamic_sections_created
           && (h->plt.refcount > eh->func_pointer_refcount
               || eh->plt_got.refcount > 0))
    {

we must increment it.

	* elf32-i386.c (elf_i386_check_relocs): Set GOT refcount to 1
	instead of incrementing it.
	* elf64-x86-64.c (elf_x86_64_check_relocs): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Eliminate catch_errors
@ 2017-10-10 16:39 sergiodj+buildbot
  2017-10-10 17:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-10 16:39 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bf4692711232eb96cd840f96d88897a2746d8190 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: bf4692711232eb96cd840f96d88897a2746d8190

Eliminate catch_errors

If you want to use catch_errors with a function with parameters, then
currently you have to manually write a "capture" struct wrapping the
arguments and marshall/unmarshall that.

https://sourceware.org/ml/gdb-patches/2017-09/msg00834.html proposed
adjusting catch_errors to use gdb::function_view, which would allow
passing lambdas with automatic captures.  However, it seems like using
TRY/CATCH directly instead ends up producing clearer and easier to
debug code.  This is what this commit does.

Note that removing catch_errors exposes further cleanup opportunities
around no longer having to follow catch_errors callback type, and also
removes a few cleanups.

I didn't do anything to save/restore current_uiout because I think
that should be the responsibility of the code that changes
current_uiout in the first place.

(Another approach could be to make catch_errors a variadic template
like:

  template<typename Function, typename... Args>
  int catch_errors (const char *errstring, return_mask mask,
		    Function &&func, Args... args);

and then with:

  extern void function_with_args (int, int);
  extern void function_with_no_args ();

calls to the above functions would be wrapped like this:

  catch_errors ("some error happened", RETURN_MASK_ERROR,
                function_with_args, arg1, arg2);

  catch_errors ("some error happened", RETURN_MASK_ERROR,
                function_with_no_args);

but I'm thinking that that doesn't improve much if at all either.)

gdb/ChangeLog
2017-10-10  Pedro Alves  <palves@redhat.com>
	    Tom Tromey  <tom@tromey.com>

	* breakpoint.c (breakpoint_cond_eval): Change return type to bool
	and reverse logic.
	(WP_DELETED, WP_VALUE_CHANGED, WP_VALUE_NOT_CHANGED, WP_IGNORE):
	No longer macros.  Instead ...
	(enum wp_check_result): They're now values of this new
	enumeration.
	(watchpoint_check): Change return type to wp_check_result and
	parameter type to bpstat.
	(bpstat_check_watchpoint): Use TRY/CATCH instead of catch_errors.
	(bpstat_check_breakpoint_conditions): Use TRY/CATCH instead of
	catch_errors.  Reverse logic of watchpoint_check call.
	(breakpoint_re_set_one): Now returns void and takes a breakpoint
	pointer as parameter.
	(breakpoint_re_set): Use TRY/CATCH instead of catch_errors.
	* common/common-exceptions.c (throw_exception_sjlj): Update
	comments to avoid mentioning catch_errors.
	* exceptions.c (catch_errors): Delete.
	* exceptions.h: Update comments to avoid mentioning catch_errors.
	(catch_errors_ftype, catch_errors): Delete.
	* infrun.c (normal_stop): Use TRY/CATCH instead of catch_errors.
	(hook_stop_stub): Delete.
	(restore_selected_frame): Change return type to void, and
	parameter type to const frame_id &.
	(restore_infcall_control_state): Use TRY/CATCH instead of
	catch_errors.
	* main.c (captured_command_loop): Return void and remove
	parameter.  Remove references to catch_errors.
	(captured_main): Use TRY/CATCH instead of catch_errors.
	* objc-lang.c (objc_submethod_helper_data)
	(find_objc_msgcall_submethod_helper): Delete.
	(find_objc_msgcall_submethod): Use TRY/CATCH instead of
	catch_errors.
	* record-full.c (record_full_message): Return void.
	(record_full_message_args, record_full_message_wrapper): Delete.
	(record_full_message_wrapper_safe): Return bool and use TRY/CATCH
	instead of catch_errors.
	* solib-aix.c (solib_aix_open_symbol_file_object): Change
	parameter type to int.
	* solib-darwin.c (open_symbol_file_object): Ditto.
	* solib-dsbt.c (open_symbol_file_object): Ditto.
	* solib-frv.c (open_symbol_file_object): Ditto.
	* solib-svr4.c (open_symbol_file_object): Ditto.
	* solib-target.c (solib_target_open_symbol_file_object): Ditto.
	* solib.c (update_solib_list): Use TRY/CATCH instead of
	catch_errors.
	* solist.h (struct target_so_ops) <open_symbol_file_object>:
	Change type.
	* symmisc.c (struct print_symbol_args): Remove.
	(dump_symtab_1): Use TRY/CATCH instead of catch_errors.
	(print_symbol): Change type.
	* windows-nat.c (handle_load_dll, handle_unload_dll): Return void
	and remove parameters.
	(catch_errors): New.
	(get_windows_debug_event): Adjust.

gdb/testsuite/ChangeLog:
2017-10-10  Pedro Alves  <palves@redhat.com>

	* lib/selftest-support.exp (selftest_setup): Update for
	captured_command_loop's prototype change.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [ARM] PR ld/21402, only override the symbol dynamic decision on undefined weak symbol.
@ 2017-10-10 16:08 sergiodj+buildbot
  2017-10-10 16:08 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-10 16:08 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6c699715f68be7d8c468e965fbefce997f7ed937 ***

Author: Renlin Li <renlin.li@arm.com>
Branch: master
Commit: 6c699715f68be7d8c468e965fbefce997f7ed937

[ARM] PR ld/21402, only override the symbol dynamic decision on undefined weak symbol.

Similar as aarch64 backend, arm backend only overrides the decision on undefined
weak symbols. arm backend part already emits necessary relative relocation for
this case.

bfd/

	PR ld/21402
	* elf32-arm.c (allocate_dynrelocs_for_symbol): Only make undefined weak
	symbols into dynamic.

ld/

	PR ld/21402
	* testsuite/ld-arm/tls-app.d: Update address.
	* testsuite/ld-arm/tls-app.r: Remove relocations.
	* testsuite/ld-arm/unresolved-1-dyn.d: Update.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove free_splay_tree cleanup
@ 2017-10-10  0:23 sergiodj+buildbot
  2017-10-10  8:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-10  0:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1a56bfa56ed967c5f6ed98f75834408417a062ff ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 1a56bfa56ed967c5f6ed98f75834408417a062ff

Remove free_splay_tree cleanup

One spot in gdb uses a cleanup to free a splay tree.  This patch
introduces a unique_ptr specialization for this case.

ChangeLog
2017-10-09  Tom Tromey  <tom@tromey.com>

	* mi/mi-main.c (free_splay_tree): Remove.
	(list_available_thread_groups): Use splay_tree_up.
	* common/gdb_splay_tree.h: New file.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] bfin: Don't create .interp section for info->nointerp
@ 2017-10-10  0:15 sergiodj+buildbot
  2017-10-10  4:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-10  0:15 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9d45a7de8b80336b9965ee99353c34be85b1b98f ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 9d45a7de8b80336b9965ee99353c34be85b1b98f

bfin: Don't create .interp section for info->nointerp

Don't create the .interp section with "ld --no-dynamic-linker".  This
fixed:

FAIL: PR ld/20828 forcibly exported symbol version without section GC
FAIL: PR ld/20828 forcibly exported symbol version with section GC
FAIL: readelf version information

	* elf32-bfin.c (bfin_size_dynamic_sections): Don't create the
	.interp section with "ld --no-dynamic-linker".


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] mn10300: Don't free cached internal symbol table
@ 2017-10-09 22:40 sergiodj+buildbot
  2017-10-10  5:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-09 22:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 478c006f9b4a64d59c31aed081c14c1d7dd4ba68 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 478c006f9b4a64d59c31aed081c14c1d7dd4ba68

mn10300: Don't free cached internal symbol table

Since ELF linker may cache internal symbol table in init_reloc_cookie,
we should check if it is cached, before free it.

	* elf-m10300.c (mn10300_elf_check_relocs): Don't free cached
	isymbuf.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Multi-arch exec, more register reading avoidance
@ 2017-10-09 21:45 sergiodj+buildbot
  2017-10-10  1:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-09 21:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cbd2b4e316370ab740433b06ed65786831232c8f ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: cbd2b4e316370ab740433b06ed65786831232c8f

Multi-arch exec, more register reading avoidance

As mentioned in commit bf93d7ba9931 ("Add thread after updating
gdbarch when exec'ing"), we should avoid doing register reads after a
process does an exec and before we've updated that inferior's gdbarch.
Otherwise, we may interpret the registers using the wrong
architecture.

There's still (at least) one case where we still read registers
post-exec with the pre-exec architecture.  That's when infrun decides
it needs to switch context to the exec'ing thread.  I.e., if the exec
event is processed at a time when the current thread is not already
the exec'ing thread, then we get (with the test added by this commit):

  continue
  Continuing.
  Truncated register 50 in remote 'g' packet
  Truncated register 50 in remote 'g' packet
  (gdb) FAIL: gdb.multi/multi-arch-exec.exp: selected_thread=2: follow_exec_mode=same: continue across exec that changes architecture

The fix is to avoid reading registers when switching context in this
case.

(I'd be nice to get rid of the constant stop_pc reading when switching
threads, but that'd be a deeper change.)

gdb/ChangeLog:
2017-10-09  Pedro Alves  <palves@redhat.com>

	* infrun.c (handle_inferior_event_1) <TARGET_WAITKIND_EXECD>: Skip
	reading registers when switching context.

gdb/testsuite/ChangeLog:
2017-10-09  Pedro Alves  <palves@redhat.com>

	* gdb.multi/multi-arch-exec.c: Include <pthread.h> and <assert.h>.
	(barrier): New.
	(thread_start, all_started): New functions.
	(main): Spawn new thread and wait until it is scheduled.
	* gdb.multi/multi-arch-exec.exp: Build $srcfile1 with the pthreads
	option.
	(do_test): Add 'selected_thread' parameter.  Run to all_started
	instead of main.  Explicitly set the breakpoint at main.  Switch
	to the SELECTED_THREAD thread.
	(top level): Test handling the exec event with either the main
	thread or the second thread selected.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdb.multi/multi-arch-exec.exp: Also test -m32 => -m64
@ 2017-10-09 19:41 sergiodj+buildbot
  2017-10-10  2:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-09 19:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 777a42f1f86b60d11cfe0e5964036823e6920f79 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 777a42f1f86b60d11cfe0e5964036823e6920f79

gdb.multi/multi-arch-exec.exp: Also test -m32 => -m64

The gdb.multi/multi-arch-exec.exp testcase currently tests execing
from -m64 to -m32, but does not test the other direction.  For
thoroughness, this commit fixes that.  Without the fix in the previous
commit for example ("Multi-arch exec, more register reading
avoidance"), on x86_64 we would get different symptoms depending on
"execing direction".  Vis:

  Continuing.
  Truncated register 50 in remote 'g' packet
  Truncated register 50 in remote 'g' packet
  (gdb) FAIL: gdb.multi/multi-arch-exec.exp: first_arch=1: selected_thread=2: follow_exec_mode=same: continue across exec that changes architecture

Vs:

  Continuing.
  Remote 'g' packet reply is too long (expected 440 bytes, got 816 bytes): daffffffffffffff0000[snip]
  Remote 'g' packet reply is too long (expected 440 bytes, got 816 bytes): daffffffffffffff0000[snip]
  (gdb) FAIL: gdb.multi/multi-arch-exec.exp: first_arch=2: selected_thread=2: follow_exec_mode=same: continue across exec that changes architecture

gdb/testsuite/ChangeLog:
2017-10-09  Pedro Alves  <palves@redhat.com>

	Test both arch1=>arch2 and arch2=>arch1.

	* gdb.multi/multi-arch-exec.exp (exec1, srcfile1, binfile1, exec2)
	(srcfile2, binfile2, march1, march2): Remove globals.  Largely
	factored out to...
	(append_arch1_options, append_arch2_options, append_arch_options)
	(build_executables): New procedures.
	(do_test): New 'first_arch' parameter.  Use it to define 'from_exec'
	local.
	(top level): Add new 'first_arch' testing axis.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Don't try building gdb against guile-2.2
@ 2017-10-09 18:14 sergiodj+buildbot
  2017-10-09 22:53 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-09 18:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6e66f7538112d2f5fb1af17dbde33ba37a7171be ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: master
Commit: 6e66f7538112d2f5fb1af17dbde33ba37a7171be

Don't try building gdb against guile-2.2

GDB currently doesn't build with Guile 2.2 (see PR 21104).  If one has
both Guile 2.2 and 2.0 installed, GDB will pick up Guile 2.2 first and
fail building.  Until somebody does the work of adapting the GDB code to
Guile 2.2, we should not try using it.  This patch therefore removes it
from configure.

gdb/ChangeLog:

	* configure.ac (try_guile_versions): Remove guile-2.2.
	* configure: Regenerate.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] S/390: Sync with latest POP - 3 new instructions
@ 2017-10-09 17:56 sergiodj+buildbot
  2017-10-09 21:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-09 17:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8e464506d2131fc931c4f81a22cc7125b7adf434 ***

Author: Andreas Krebbel <krebbel@linux.vnet.ibm.com>
Branch: master
Commit: 8e464506d2131fc931c4f81a22cc7125b7adf434

S/390: Sync with latest POP - 3 new instructions

prno, tpei, and irbm are missing in the optable.

gas/ChangeLog:

2017-10-09  Andreas Krebbel  <krebbel@linux.vnet.ibm.com>

	* testsuite/gas/s390/zarch-arch12.d (prno, tpei, irbm): New
	instructions added.
	* testsuite/gas/s390/zarch-arch12.s: Likewise.
	* testsuite/gas/s390/zarch-z13.d: Rename ppno to prno.

opcodes/ChangeLog:

2017-10-09  Andreas Krebbel  <krebbel@linux.vnet.ibm.com>

	* s390-opc.txt (prno, tpei, irbm): New instructions added.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix automatic dependency tracking
@ 2017-10-09 16:13 sergiodj+buildbot
  2017-10-09 18:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-09 16:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 890e97902a21a3b88f9b6028852736b813303029 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 890e97902a21a3b88f9b6028852736b813303029

Fix automatic dependency tracking

Commit f38307f5 changed COMPILE.post and POSTCOMPILE to remove
$(basename) from the dependency file name computation.  However, it
did not update the `-include' at the end of the Makefile.in; this in
effect disabled automatic dependency tracking.

This patch restores the $(basename) wrapper so that the dependency
files are named "file.Po" rather than "file.o.Po".

I also tested the non-gcc3 dependency mode, which pointed out that
this case hadn't been working since the switch to C++.  This is also
fixed in this patch.

Tested by rebuilding.

ChangeLog
2017-10-09  Tom Tromey  <tom@tromey.com>

	* Makefile.in (COMPILE.post, POSTCOMPILE): Restore $(basename).
	(COMPILE.pre): Use $(CXX).


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make cp_remove_params return a gdb::unique_xmalloc_ptr
@ 2017-10-09 15:34 sergiodj+buildbot
  2017-10-09 17:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-09 15:34 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 109483d9eec3f0d0c3eaafd5d829435059167c52 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 109483d9eec3f0d0c3eaafd5d829435059167c52

Make cp_remove_params return a gdb::unique_xmalloc_ptr

Use the type system instead of callers needing to know how the
returned string's memory is supposed to be managed.

gdb/ChangeLog:
2017-10-09  Pedro Alves  <palves@redhat.com>

	* cp-support.c (cp_remove_params): Return a gdb::unique_xmalloc_ptr.
	Use bool.
	(overload_list_add_symbol): Adjust to use gdb::unique_xmalloc_ptr.
	* cp-support.h (cp_remove_params): Now returns a
	gdb::unique_xmalloc_ptr.
	* dwarf2read.c (find_slot_in_mapped_hash): Now returns bool.
	Adjust to cp_remove_params returning a gdb::unique_xmalloc_ptr.
	* psymtab.c (psymtab_search_name): Adjust to cp_remove_params
	returning a gdb::unique_xmalloc_ptr.
	(lookup_partial_symbol): Adjust to use gdb::unique_xmalloc_ptr.
	* stack.c (find_frame_funname): Adjust to cp_remove_params
	returning a gdb::unique_xmalloc_ptr.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove some cleanups from dwarf2read.c
@ 2017-10-09  7:27 sergiodj+buildbot
  2017-10-09 12:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-09  7:27 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 791afaa233ca9f4baa59aa16062296a00aa2c4da ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 791afaa233ca9f4baa59aa16062296a00aa2c4da

Remove some cleanups from dwarf2read.c

This removes a number of cleanups from dwarf2read.c in a
straightforward way.

Note that some places in dwarf2read create dangling cleanups.  I don't
believe any of the changes in this patch interact with those spots.

Regression tested by the buildbot.

gdb/ChangeLog
2017-10-08  Tom Tromey  <tom@tromey.com>

	* dwarf2read.c (dwarf2_get_dwz_file): Use
	gdb::unique_xmalloc_ptr.
	(find_slot_in_mapped_hash): Likewise.
	(dwarf2_physname): Likewise.
	(create_dwo_unit_in_dwp_v1): Use std::string.
	(create_dwo_unit_in_dwp_v2): Likewise.
	(lookup_dwo_cutu): Likewise.
	(inherit_abstract_dies): Use std::vector.
	(read_array_type): Likewise.
	(dwarf_decode_macros): Remove unused declaration.
	(unsigned_int_compar): Remove.
	(dwarf2_build_psymtabs_hard): Use scoped_restore.
	(psymtabs_addrmap_cleanup): Remove.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove make_cleanup_value_free
@ 2017-10-09  5:51 sergiodj+buildbot
  2017-10-09  9:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-09  5:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 757325a3f24e01bf8e7b7214f33c546bc52d1d12 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 757325a3f24e01bf8e7b7214f33c546bc52d1d12

Remove make_cleanup_value_free

This removes make_cleanup_value_free, in favor of a unique_ptr
specialization.

Regression tested by the buildbot.

gdb/ChangeLog
2017-10-08  Tom Tromey  <tom@tromey.com>

	* utils.h (make_cleanup_value_free): Remove.
	* utils.c (do_value_free, struct cleanup): Remove.
	* dwarf2loc.c (dwarf2_evaluate_loc_desc_full) <DWARF_VALUE_STACK>:
	Use gdb_value_up.
	* value.h (struct value_deleter): New.
	(gdb_value_up): New typedef.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Change search_symbols to return std::vector
@ 2017-10-09  5:31 sergiodj+buildbot
  2017-10-09  7:15 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-09  5:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b9c04fb2681dd5706d2cafa5dcc6bdcd99016cf4 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: b9c04fb2681dd5706d2cafa5dcc6bdcd99016cf4

Change search_symbols to return std::vector

This changes search_symbols to return a std::vector, replacing the
previous linked list approach.  This allows the removal of some
cleanups, as well as the use of std::sort and std::unique, saving some
code and extra allocations in sort_search_symbols_remove_dups.

Regression tested by the buildbot.

gdb/ChangeLog
2017-10-08  Tom Tromey  <tom@tromey.com>

	* symtab.c (free_search_symbols, do_free_search_symbols_cleanup)
	(make_cleanup_free_search_symbols): Remove.
	(search_symbols): Return std::vector.
	(symbol_search::compare_search_syms): Now member of
	symbol_search.  Change arguments.
	(sort_search_symbols_remove_dups): Change arguments.  Rewrite.
	(symtab_symbol_info, rbreak_command): Update.
	* symtab.h (struct symbol_search) <next>: Remove.
	Add constructors.
	(symbol_search::operator<): New function.
	(symbol_search::operator==): New function.
	(search_symbols): Remove std::vector.
	(free_search_symbols, make_cleanup_free_search_symbols): Remove.
	(symbol_search::compare_search_syms): Declare.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR22212, memory leak in nm
@ 2017-10-09  5:11 sergiodj+buildbot
  2017-10-09  6:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-09  5:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b55ec8b676ed05d93ee49d6c79ae0403616c4fb0 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: b55ec8b676ed05d93ee49d6c79ae0403616c4fb0

PR22212, memory leak in nm

	PR 22212
	* dwarf2.c (_bfd_dwarf2_cleanup_debug_info): Free
	funcinfo_hash_table and varinfo_hash_table.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] sh: Dump dynamic relocation info to the map file
@ 2017-10-09  1:20 sergiodj+buildbot
  2017-10-09  3:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-09  1:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a72f95f7760bf85693af393c5e01dd3aedbe5bde ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: a72f95f7760bf85693af393c5e01dd3aedbe5bde

sh: Dump dynamic relocation info to the map file

Dump dynamic relocation info to the map file when generating dynamic
relocation in read-only section relocations if -Map is used.

	* elf32-sh.c (readonly_dynrelocs): Dump dynamic relocation
	in read-only section with minfo.
	(sh_elf_size_dynamic_sections): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] sparc: Remove a strayed comment
@ 2017-10-09  0:35 sergiodj+buildbot
  2017-10-09  1:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-09  0:35 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f9799aae8e51948c1d87fbe7249b3d76dcb4585d ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: f9799aae8e51948c1d87fbe7249b3d76dcb4585d

sparc: Remove a strayed comment

	* elfxx-sparc.c (_bfd_sparc_elf_size_dynamic_sections): Remove
	a strayed comment.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Reformat elf_x86_allocate_dynrelocs
@ 2017-10-08 20:47 sergiodj+buildbot
  2017-10-08 21:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-08 20:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 70090aa5f629dcbdfa88b20c29951fa8f50f0545 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 70090aa5f629dcbdfa88b20c29951fa8f50f0545

Reformat elf_x86_allocate_dynrelocs

	* elfxx-x86.c (elf_x86_allocate_dynrelocs): Reformat.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] sparc: Dump dynamic relocation info to the map file
@ 2017-10-08  0:51 sergiodj+buildbot
  2017-10-08  2:22 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-08  0:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f0f07ad1825e9b7f539e410562993b25f76e5627 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: f0f07ad1825e9b7f539e410562993b25f76e5627

sparc: Dump dynamic relocation info to the map file

Dump dynamic relocation info to the map file when generating dynamic
relocation in read-only section relocations if -Map is used.

	* elfxx-sparc.c (readonly_dynrelocs): Dump dynamic relocation
	in read-only section with minfo.
	(_bfd_sparc_elf_size_dynamic_sections): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Skip gdb.mi/mi-threads-interrupt.exp if nointerrupts.
@ 2017-10-06 22:49 sergiodj+buildbot
  2017-10-07 12:15 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-06 22:49 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b3b7c423883ad8d8b81f166ad2d2d4b637086bc0 ***

Author: Sandra Loosemore <sandra@codesourcery.com>
Branch: master
Commit: b3b7c423883ad8d8b81f166ad2d2d4b637086bc0

Skip gdb.mi/mi-threads-interrupt.exp if nointerrupts.

2017-10-06  Sandra Loosemore  <sandra@codesourcery.com>

	gdb/testsuite/
	* gdb.mi/mi-threads-interrupt.exp: Skip test if nointerrupts.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Move arm.o arm-get-next-pcs.o arm-linux.o to arch/
@ 2017-10-06 13:38 sergiodj+buildbot
  2017-10-07  7:49 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-06 13:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 71917808c3490b4d4df9c6e848e3c5d75f5278d2 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 71917808c3490b4d4df9c6e848e3c5d75f5278d2

Move arm.o arm-get-next-pcs.o arm-linux.o to arch/

It is tested by building GDB for some targets, arm-elf, arm-netbsd,
arm-linux, and aarch64-linux.

gdb:

2017-10-06  Yao Qi  <yao.qi@linaro.org>

	* Makefile.in (ALL_TARGET_OBS): Replace arm.o, arm-get-next-pcs.o,
	and arm-linux.o with arch/arm.o, arch/arm-get-next-pcs.o and
	arch/arm-linux.o respectively.
	* configure.tgt: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix more GDB build breakage on mingw32
@ 2017-10-06 11:06 sergiodj+buildbot
  2017-10-07  4:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-06 11:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a1b85d282f408dfd18a27539874846197f7e4044 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: a1b85d282f408dfd18a27539874846197f7e4044

Fix more GDB build breakage on mingw32

With F23's mingw gcc 5.3.0, I'm seeing:

 i686-w64-mingw32-g++ -x c++ -std=gnu++11 -g3 -O0   -I. -I../../src/gdb -I../../src/gdb/common -I../../src/gdb/config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode -I../../src/gdb/../opcodes/.. -I../../src/gdb/../readline/.. -I../../src/gdb/../zlib -I../bfd -I../../src/gdb/../bfd -I../../src/gdb/../include -I../libdecnumber -I../../src/gdb/../libdecnumber  -I../../src/gdb/gnulib/import -Ibuild-gnulib/import   -I/home/pedro/src/expat/install-win32//include   -Wall -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable -Wno-sign-compare -Wno-narrowing -Wno-error=maybe-uninitialized -Wno-format -Werror -c -o windows-nat.o -MT windows-nat.o -MMD -MP -MF ./.deps/windows-nat.o.Tpo ../../src/gdb/windows-nat.c
 ../../src/gdb/windows-nat.c: In function 'void windows_create_inferior(target_ops*, const char*, const string&, char**, int)':
 ../../src/gdb/windows-nat.c:2476:7: error: 'replace' is not a member of 'std'
	std::replace (expanded_infcwd.begin (), expanded_infcwd.end (),
	^

gdb/Changelog:
2017-10-06  Pedro Alves  <palves@redhat.com>

	* windows-nat.c: Include <algorithm>.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix GDB build under msys+mingw gcc 32bit
@ 2017-10-06 10:53 sergiodj+buildbot
  2017-10-07  2:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-06 10:53 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b79f7801a2c555ee4ff4bc3050141e83158f66d4 ***

Author: Yuanhui Zhang <asmwarrior@gmail.com>
Branch: master
Commit: b79f7801a2c555ee4ff4bc3050141e83158f66d4

Fix GDB build under msys+mingw gcc 32bit

I see a build error when building GDB under msys+mingw gcc 32bit:

 g++ -x c++ -std=gnu++11 -g -O2    -I. -I../../../binutils-gdb/gdb/gdbserver -I../../../binutils-gdb/gdb/gdbserver/../common -I../../../binutils-gdb/gdb/gdbserver/../regformats -I../../../binutils-gdb/gdb/gdbserver/.. -I../../../binutils-gdb/gdb/gdbserver/../../include -I../../../binutils-gdb/gdb/gdbserver/../gnulib/import -Ibuild-gnulib-gdbserver/import  -Wall -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable -Wno-sign-compare -Wno-narrowing -Wno-error=maybe-uninitialized -Wno-format -Werror -DGDBSERVER -c -o win32-low.o -MT win32-low.o -MMD -MP -MF .deps/win32-low.Tpo ../../../binutils-gdb/gdb/gdbserver/win32-low.c
 ../../../binutils-gdb/gdb/gdbserver/win32-low.c: In function 'BOOL create_process(const char*, char*, DWORD, PROCESS_INFORMATION*)':
 ../../../binutils-gdb/gdb/gdbserver/win32-low.c:566:48: error: 'get_inferior_cwd' was not declared in this scope
    const char *inferior_cwd = get_inferior_cwd ();
						 ^
 make[4]: *** [win32-low.o] Error 1

It can be fixed by simply including the right header file.

gdb/gdbserver/ChangeLog:
2017-10-06  Yuanhui Zhang  <asmwarrior@gmail.com>

	* win32-low.c: Include "common-inferior.h".


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Share code updating gdb_target_obs
@ 2017-10-06 10:23 sergiodj+buildbot
  2017-10-07  0:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-06 10:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d97987e219b80c670e37eb0e25e31b36fa295509 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: d97987e219b80c670e37eb0e25e31b36fa295509

Share code updating gdb_target_obs

Nowadays, there are much duplications in configure.tgt to update
gdb_target_obs, some cpu specific object files are added to gdb_target_obs
to some different target triplets of the same cpu.  The same problem
exists for os specific object files too.  It is fragile to update them,
and build with all targets enabled doesn't find the problem.

This patch splits the gdb_target_obs update to three steps, cpu steps, os
steps, and the rest.

I tested this patch by build gdb for each different target triplets
respectively,

aarch64-elf aarch64-rtems aarch64-freebsd aarch64-linux alpha-elf
alpha-linux alpha-netbsd alpha-openbsd arm-elf arm-wince-pe arm-linux
arm-netbsd arm-symbianelf avr cris-elf frv-elf h8300-elf i386-elf
i386-darwin i386-dicos i386-freebsd i386-netbsdelf i386-openbsd
i386-nto i386-solaris i386-linux i386-gnu i386-cygwin i386-mingw32
i386-go32 ia64-linux-gnu ia64-vms lm32-elf m32c-elf m32r-elf m32r-linux
m68hc11-elf m68k-elf m68k-linux m68k-netbsd m68k-openbsd m88k-openbsd
mep-elf microblaze-xilinx-elf microblaze-linux-gnu mips-elf moxie-elf
ms1-elf nios2-elf nios2-linux-gnu hppa-elf hppa-linux hppa-netbsd
hppa-openbsd powerpc-eabi powerpc-freebsd powerpc-netbsd powerpc-openbsd
powerpc-linux powerpc-lynx178 rl78-elf rx-elf s390-linux-gnu score-elf
sh-elf sh-linux sh-openbsd sh64-elf sh64-linux sh64-openbsd sparc64-linux
sparc-linux sparc-freebsd sparc64-freebsd sparc-netbsd sparc64-netbsd
sparc-openbsd sparc64-openbsd spu-elf tic6x-elf tic6x-uclinux v850-elf
vax-netbsd vax-openbsd x86_64-linux-gnu x86_64-darwin x86_64-dicos
x86_64-elf x86_64-freebsd x86_64-mingw32 x86_64-netbsd x86_64-openbsd
x86_64-rtems xstormy16-elf xtensa-elf xtensa-linux

gdb:

2017-10-06  Yao Qi  <yao.qi@linaro.org>

	* configure.tgt (i386_tobjs): New variable.
	(amd64_tobjs): New variable.
	Set $cpu_obs and $os_obs.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: Add VERIFY_COPY_RELOC
@ 2017-10-06  7:54 sergiodj+buildbot
  2017-10-06 20:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-06  7:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ff38b4cc55dade4c9970cac2149a946d5dc0adc7 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: ff38b4cc55dade4c9970cac2149a946d5dc0adc7

x86: Add VERIFY_COPY_RELOC

Add VERIFY_COPY_RELOC to verify that symbol supports copy relocation.

	* elfxx-x86.h (VERIFY_COPY_RELOC): New.
	* elf32-i386.c (elf_i386_finish_dynamic_symbol): Use it.
	* elf64-x86-64.c (elf_x86_64_finish_dynamic_symbol): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: Add GENERATE_DYNAMIC_RELOCATION_P
@ 2017-10-06  7:44 sergiodj+buildbot
  2017-10-06 16:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-06  7:44 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT aebcc8ffd201adbee973b414818b01876dabe1a0 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: aebcc8ffd201adbee973b414818b01876dabe1a0

x86: Add GENERATE_DYNAMIC_RELOCATION_P

Add GENERATE_DYNAMIC_RELOCATION_P which returns TRUE if dynamic
relocation should be generated.

	* elf32-i386.c (X86_SIZE_TYPE_P): New.
	(elf_i386_relocate_section): Use GENERATE_DYNAMIC_RELOCATION_P.
	* elf64-x86-64.c (X86_SIZE_TYPE_P): New.
	(elf_x86_64_relocate_section): Use GENERATE_DYNAMIC_RELOCATION_P.
	* elfxx-x86.h (GENERATE_DYNAMIC_RELOCATION_P): New.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: Add POINTER_LOCAL_IFUNC_P/PLT_LOCAL_IFUNC_P
@ 2017-10-06  7:42 sergiodj+buildbot
  2017-10-06 15:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-06  7:42 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cf1070f1a1ca1f8be1cd88aa6ece55a25e6a887b ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: cf1070f1a1ca1f8be1cd88aa6ece55a25e6a887b

x86: Add POINTER_LOCAL_IFUNC_P/PLT_LOCAL_IFUNC_P

Add POINTER_LOCAL_IFUNC_P which returns TRUE for pointer reference to
local IFUNC symbol.  Add PLT_LOCAL_IFUNC_P which returns TRUE for PLT
reference to local IFUNC symbol.

	* elfxx-x86.h (POINTER_LOCAL_IFUNC_P): New.
	(PLT_LOCAL_IFUNC_P): Likewise.
	* elf32-i386.c (elf_i386_relocate_section): Use them.
	* elf64-x86-64.c (elf_x86_64_relocate_section): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add RESOLVED_LOCALLY_P
@ 2017-10-06  7:30 sergiodj+buildbot
  2017-10-06 12:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-06  7:30 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2eba97c207399d8b541092a7b0a4428dc02f5cf1 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 2eba97c207399d8b541092a7b0a4428dc02f5cf1

Add RESOLVED_LOCALLY_P


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: Add NEED_DYNAMIC_RELOCATION_P
@ 2017-10-06  7:26 sergiodj+buildbot
  2017-10-06 10:50 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-06  7:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT daf1c414a48baf090f005ce4b319b6881d5d6872 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: daf1c414a48baf090f005ce4b319b6881d5d6872

x86: Add NEED_DYNAMIC_RELOCATION_P

Add NEED_DYNAMIC_RELOCATION_P which returns TRUE if dynamic relocation
is needed.

	* elf32-i386.c (X86_PCREL_TYPE_P): New.
	(elf_i386_check_relocs): Use NEED_DYNAMIC_RELOCATION_P.
	* elf64-x86-64.c (IS_X86_64_PCREL_TYPE): Renamed to ...
	(X86_PCREL_TYPE_P): This.
	(elf_x86_64_check_relocs): Use NEED_DYNAMIC_RELOCATION_P.
	Replace IS_X86_64_PCREL_TYPE with X86_PCREL_TYPE_P.
	(elf_x86_64_relocate_section): Replace IS_X86_64_PCREL_TYPE with
	X86_PCREL_TYPE_P.
	* elfxx-x86.h (NEED_DYNAMIC_RELOCATION_P): New.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] powerpc: Dump dynamic relocation info to the map file
@ 2017-10-06  1:11 sergiodj+buildbot
  2017-10-06  4:08 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-06  1:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0caf6c82ab23ece570d14499ed02653968cd8abd ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 0caf6c82ab23ece570d14499ed02653968cd8abd

powerpc: Dump dynamic relocation info to the map file

Dump dynamic relocation info to the map file when generating dynamic
relocation in read-only section relocations if -Map is used.

	* elf32-ppc.c (readonly_dynrelocs): Add a link_info argument.
	Dump dynamic relocation in read-only section with minfo if
	needed.
	(ppc_elf_adjust_dynamic_symbol): Pass NULL to readonly_dynrelocs.
	(maybe_set_textrel): Likewise.
	(ppc_elf_size_dynamic_sections): Dump dynamic relocation in
	read-only section with minfo.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Clean up includes of doublest.h and floatformat.h
@ 2017-10-05 17:18 sergiodj+buildbot
  2017-10-05 22:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-05 17:18 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1841ee5d0300cf00022c8aadfe16725c5e86fe1d ***

Author: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Branch: master
Commit: 1841ee5d0300cf00022c8aadfe16725c5e86fe1d

Clean up includes of doublest.h and floatformat.h

As a first small step to getting rid of doublest.h, this patch removes the
include of "floatformat.h" in "doublest.h".  This is actually not needed
for the file itself.  A few source files now need to include "floatformat.h"
directly, since they got it indirectly via "doublest.h" and still need it.

In reviewing which files need it, I found a number of files that include
"floatformat.h" directly without actually needing it at all.  Similarly,
a number of files include "doublest.h" without needing it.  I've also
removed those unnecessary include statements.

gdb/ChangeLog:
2017-10-05  Ulrich Weigand  <uweigand@de.ibm.com>

	* doublest.h: Do not include "floatformat.h".  Remove stale comments.
	* gdbtypes.c: Include "floatformat.h".
	* value.c: Likewise.
	* m68k-tdep.c: Likewise.

	* findvar.c: Do not include "floatformat.h".
	* amd64-darwin-tdep.c: Likewise.
	* arm-linux-tdep.c: Likewise.
	* i386-darwin-tdep.c: Likewise.
	* i387-tdep.c: Likewise.
	* m68k-linux-tdep.c: Likewise.
	* mep-tdep.c: Likewise.
	* mips-tdep.c: Likewise.
	* nios2-tdep.c: Likewise.
	* s390-linux-tdep.c: Likewise.
	* sparc-obsd-tdep.c: Likewise.
	* sparc-tdep.c: Likewise.
	* sparc64-tdep.c: Likewise.
	* spu-tdep.c: Likewise.
	* tic6x-tdep.c: Likewise.
	* tilegx-tdep.c: Likewise.
	* vax-tdep.c: Likewise.
	* xstormy16-tdep.c: Likewise.
	* xtensa-tdep.c: Likewise.

	* top.c: Do not include "doublest.h".
	* aarch64-tdep.c: Likewise.
	* alpha-tdep.c: Likewise.
	* arm-linux-tdep.c: Likewise.
	* m68k-linux-tdep.c: Likewise.
	* tilegx-tdep.c: Likewise.
	* xstormy16-tdep.c: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Clean up some DFP interfaces
@ 2017-10-05 17:18 sergiodj+buildbot
  2017-10-05 23:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-05 17:18 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3b4b2f160d288b85a1379d24fd0f4de19062f3fd ***

Author: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Branch: master
Commit: 3b4b2f160d288b85a1379d24fd0f4de19062f3fd

Clean up some DFP interfaces

This cleans up a number of interfaces in dfp.c / dfp.h.  Specifically:

- The decimal_from_string / decimal_to_string routines are C++-ified
  to operate on std::string instead of character buffers.  In the
  decimal_from_string, the boolean return value now actually is bool
  instead of an int.

- The decimal_from_integral and decimal_from_doublest routines take
  an struct value as input.  This is not really appropriate at the low
  level the DFP routines sit, so this replaced them with new routines
  decimal_from_longest / decimal_from_ulongest / decimal_from_doublest
  that operate on contents instead.

- To mirror the decimal_from_[u]longest, a new decimal_to_longest
  routine is added as well, which can be used in unpack_long to
  avoid an unnecessary conversion via DOUBLEST.

Note that the decimal_from_longest / decimal_from_ulongest routines
are actually more powerful than decimal_from_integral: the old routine
would only accept integer *types* of at most four bytes size, while
the new routines accept all integer *values* that fit in an [u]int32_t,
no matter which type they came from.  The DFP tests are updated to
allow for this larger range of integers that can be converted.

gdb/ChangeLog:
2017-10-05  Ulrich Weigand  <uweigand@de.ibm.com>

	* dfp.h (MAX_DECIMAL_STRING): Move to dfp.c.
	(decimal_to_string): Return std::string object.
	(decimal_from_string): Accept std::string object.  Return bool.
	(decimal_from_integral, decimal_from_doublest): Remove.
	(decimal_from_longest): Add prototype.
	(decimal_from_ulongest): Likewise.
	(decimal_to_longest): Likewise.
	(decimal_from_doublest): Likewise.
	* dfp.c: Do not include "gdbtypes.h" or "value.h".
	(MAX_DECIMAL_STRING): Move here.
	(decimal_to_string): Return std::string object.
	(decimal_from_string): Accept std::string object.  Return bool.
	(decimal_from_integral): Remove, replace by ...
	(decimal_from_longest, decimal_from_ulongest): ... these new functions.
	(decimal_to_longest): New function.
	(decimal_from_floating): Remove, replace by ...
	(decimal_from_doublest): ... this new function.
	(decimal_to_doublest): Update to new decimal_to_string interface.

	* value.c (unpack_long): Use decimal_to_longest.
	* valops.c (value_cast): Use decimal_from_doublest instead of
	decimal_from_floating.  Use decimal_from_[u]longest isntead of
	decimal_from_integral.
	* valarith.c (value_args_as_decimal): Likewise.
	* valprint.c (print_decimal_floating): Update to new
	decimal_to_string interface.
	* printcmd.c (printf_decfloat): Likewise.
	* c-exp.y (parse_number): Update to new decimal_from_string interface.

gdb/testsuite/ChangeLog:
2017-10-05  Ulrich Weigand  <uweigand@de.ibm.com>

	* gdb.base/dfp-exprs.exp: Update tests to larger range of supported
	integer-to-dfp conversion.
	* gdb.base/dfp-test.exp: Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove unused "union agent_val" from ax.h
@ 2017-10-05 17:18 sergiodj+buildbot
  2017-10-06  1:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-05 17:18 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d13b8493cbd2891b5886e6176d468eb63c73606a ***

Author: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Branch: master
Commit: d13b8493cbd2891b5886e6176d468eb63c73606a

Remove unused "union agent_val" from ax.h

The ax.h header file contains a use of DOUBLEST in the type "union agent_val".

However, that type is never used anywhere, so it can be simply removed.

gdb/ChangeLog:
2017-10-05  Ulrich Weigand  <uweigand@de.ibm.com>

	* ax.h: Do not include "doublest.h".
	(union agent_val): Remove.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Handle FreeBSD-specific AT_EHDRFLAGS and AT_HWCAP auxiliary vector types.
@ 2017-10-05 17:00 sergiodj+buildbot
  2017-10-05 18:11 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-05 17:00 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 12c4bd7f53e9cefcf7c3a7f8cbf9e552526cb963 ***

Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: 12c4bd7f53e9cefcf7c3a7f8cbf9e552526cb963

Handle FreeBSD-specific AT_EHDRFLAGS and AT_HWCAP auxiliary vector types.

FreeBSD recently added two additional ELF auxiliary vectors.  FreeBSD's
AT_HWCAP uses a different number compared to AT_HWCAP on Linux as the
numerical value was already in use for a different vector on FreeBSD.

include/ChangeLog:

	* elf/common.h (AT_FREEBSD_EHDRFLAGS, AT_FREEBSD_HWCAP): Define.

gdb/ChangeLog:

	* fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_EHDRFLAGS and
	AT_HWCAP.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Handle the NT_ARM_VFP core dump note on FreeBSD.
@ 2017-10-05 17:00 sergiodj+buildbot
  2017-10-05 20:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-05 17:00 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6d5be5d6b8b4412e65bc037472aa2e727c25ccf5 ***

Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: 6d5be5d6b8b4412e65bc037472aa2e727c25ccf5

Handle the NT_ARM_VFP core dump note on FreeBSD.

bfd/ChangeLog:

	* elf.c (elfcore_grok_freebsd_note): Handle NT_ARM_VFP.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] tile: Dump dynamic relocation info to the map file
@ 2017-10-05 13:02 sergiodj+buildbot
  2017-10-05 14:14 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-05 13:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 007873f54e41eaef2f7a89b8adbb63a563d98b65 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 007873f54e41eaef2f7a89b8adbb63a563d98b65

tile: Dump dynamic relocation info to the map file

Dump dynamic relocation info to the map file when generating dynamic
relocation in read-only section relocations if -Map is used.

	* elf32-tilepro.c (readonly_dynrelocs): Dump dynamic relocation
	in read-only section with minfo.
	(tilepro_elf_size_dynamic_sections): Likewise.
	* elfxx-tilegx.c (readonly_dynrelocs): Likewise.
	(tilegx_elf_size_dynamic_sections): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Update my email address.
@ 2017-10-05  4:45 sergiodj+buildbot
  2017-10-05  5:56 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-05  4:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c91933e9e33654c7b8973cb449b93f5152afcbcb ***

Author: Tristan Gingold <tgingold@free.fr>
Branch: master
Commit: c91933e9e33654c7b8973cb449b93f5152afcbcb

Update my email address.

Also refer to global maintainers for branch release approval.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] bfd_set_input_error
@ 2017-10-05  1:42 sergiodj+buildbot
  2017-10-05  3:46 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-05  1:42 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2ca7de3746be7484aa5affceafa1ad2e1d789381 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 2ca7de3746be7484aa5affceafa1ad2e1d789381

bfd_set_input_error

A downside to the 2017-10-04 PR22245 fix is that bfd_set_error can now
silently accept invalid errors if/when someone passes the a value of
the wrong enumeration type, which previously would be caught by the
-Wenum-conversion warning.

	PR 22245
	* bfd.c (bfd_set_error): Revert 2017-10-04 change.  Remove
	ellipsis parameter.  Split out bfd_error_on_input code to..
	(bfd_set_input_error): .. New function.
	* archive.c (_bfd_write_archive_contents): Use bfd_set_input_error.
	* vms-lib.c (_bfd_vms_lib_write_archive_contents): Likewise.
	* bfd-in2.h: Regenerate.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] bfd_error_on_input is for archives
@ 2017-10-05  1:09 sergiodj+buildbot
  2017-10-05  2:24 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-05  1:09 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8c6716e57eb991ba6ceb07011045d626652aaf01 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 8c6716e57eb991ba6ceb07011045d626652aaf01

bfd_error_on_input is for archives

	* elflink.c (elf_link_input_bfd): Correct ctor/dtor in init_array/
	fini_array error value.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR21167, relocation sections not included in groups
@ 2017-10-04 23:08 sergiodj+buildbot
  2017-10-05  0:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-04 23:08 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT db4677b8bd90b49f826807352c6c3c7eb0d57814 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: db4677b8bd90b49f826807352c6c3c7eb0d57814

PR21167, relocation sections not included in groups

This fixes a wart I've known about for years, but haven't done
anything about because BFD treats relocation sections as an adjunct to
the section they relocate.  SHF_GROUP on the section thus implicitly
applies to its relocation section(s), but it is an error that the
reloc sections aren't part of the group.

Like many patches to gas, this wasn't as straightforward as it could
be due to a number of backends, i386, cr16 and others, removing relocs
in tc_get_reloc rather than marking them as "done" earlier in
md_apply_reloc.  So it isn't possible for the group support to
reliably detect the presence of relocs by looking at fixups earlier
than write_relocs.  However the group support needs to create
signature symbols, and that must be done before the symbol table is
frozen, before write_relocs.  So split off the group sizing from
elf_adjust_symtab and put it in elf_frob_file_after_relocs.

bfd/
	PR 21167
	* elf.c (_bfd_elf_setup_sections): Don't trim reloc sections from
	groups.
	(_bfd_elf_init_reloc_shdr): Pass sec_hdr, use it to copy SHF_GROUP
	flag from section.
	(elf_fake_sections): Adjust calls.  Exit immediately on failure.
	(bfd_elf_set_group_contents): Add associated reloc section indices
	to group contents
gas/
	PR 21167
	* config/obj-elf.c (struct group_list): Delete elt_count.
	(groups): New static.
	(build_group_lists): Don't count elements.
	(elf_adjust_symtab): Use groups rather than auto list.  Set up
	pointer from group member to SHT_GROUP section.  Don't size
	SHT_GROUP section or clean up here..
	(elf_frob_file_after_relocs): ..do so here instead.
	* testsuite/gas/arc/jli-1.d,
	* testsuite/gas/elf/groupautob.d,
	* testsuite/gas/mips/compact-eh-eb-2.d,
	* testsuite/gas/mips/compact-eh-eb-5.d,
	* testsuite/gas/mips/compact-eh-el-2.d,
	* testsuite/gas/mips/compact-eh-el-5.d: Adjust.
ld/
	PR 21167
	* testsuite/ld-elf/group9b.d: Adjust for relocs included in group.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Redesign mock environment for gdbarch selftests
@ 2017-10-04 17:39 sergiodj+buildbot
  2017-10-04 19:11 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-04 17:39 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 55b11ddf16b97b9c50ed480bc9da8b3e1c6c4198 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 55b11ddf16b97b9c50ed480bc9da8b3e1c6c4198

Redesign mock environment for gdbarch selftests

A following patch will remove this hack from within regcache's
implementation:

  struct regcache *
  get_thread_arch_regcache (ptid_t ptid, struct gdbarch *gdbarch)
  {
    struct address_space *aspace;

    /* For the benefit of "maint print registers" & co when debugging an
       executable, allow dumping the regcache even when there is no
       thread selected (target_thread_address_space internal-errors if
       no address space is found).  Note that normal user commands will
       fail higher up on the call stack due to no
       target_has_registers.  */
    aspace = (ptid_equal (null_ptid, ptid)
	      ? NULL
	      : target_thread_address_space (ptid));

i.e., it'll no longer be possible to try to build a regcache for
null_ptid.  That change alone would regress the gdbarch self tests
though, causing this:

  (gdb) maintenance selftest
  [...]
  Running selftest register_to_value.
  src/gdb/inferior.c:309: internal-error: inferior* find_inferior_pid(int): Assertion `pid != 0' failed.
  A problem internal to GDB has been detected,
  further debugging may prove unreliable.
  Quit this debugging session? (y or n) FAIL: gdb.gdb/unittest.exp: maintenance selftest (GDB internal error)

The problem is that the way the mocking environment for those unit
tests is written is a bit fragile: it creates a special purpose
regcache (and sentinel's frame), using whatever is the current
inferior_ptid (usually null_ptid), and assumes get_current_regcache
will find that in the regcache::current_regcache list.

This commit changes the way the mock environment is created.  It
eliminates the special regcache and frame and instead creates a fuller
mock environment, with a custom mock target_ops, and then a mock
inferior and thread "running" on that target.

If there's already a running target when you type "maint selftest",
then we error out, instead of pushing a new target on top of the
existing one (and thus killing the debug session).  This results in:

  (gdb) maint selftest
  (...)
  Self test failed: arch i386: target already pushed
  Self test failed: arch i386:x86-64: target already pushed
  Self test failed: arch i386:x64-32: target already pushed
  Self test failed: arch i8086: target already pushed
  Self test failed: arch i386:intel: target already pushed
  Self test failed: arch i386:x86-64:intel: target already pushed
  Self test failed: arch i386:x64-32:intel: target already pushed
  Self test failed: arch i386:nacl: target already pushed
  Self test failed: arch i386:x86-64:nacl: target already pushed
  Self test failed: arch i386:x64-32:nacl: target already pushed
  Self test failed: self-test failed at /home/pedro/gdb/mygit/src/gdb/selftest-arch.c:86
  (...)
  Ran 19 unit tests, 1 failed

I think that's OK, because self tests are really meant to be run from
a clean state right after GDB is started.  I'm adding that erroring
out just as safe measure just in case someone types "maint selftest"
on the command line while already debugging something (as I've done
it).

(In my multi-target branch, where this patch originated from, we don't
actually need to error out, because there each inferior has its own
target stack).

Also, note that the current code was doing:

 current_inferior()->gdbarch = gdbarch;

without taking care to restore the previous gdbarch.  This means that
GDB's state was being left inconsistent after running the self tests,
further supporting the point that there's probably not much
expectation that mixing "maint selftests" and regular debugging in the
same GDB invocation really works.  This patch fixes that, regardless.

gdb/ChangeLog:
2017-10-04  Pedro Alves  <palves@redhat.com>

	* frame.c (create_test_frame): Delete.
	* frame.h (create_test_frame): Delete.
	* gdbarch-selftests.c: Include gdbthread.h and target.h.
	(class regcache_test): Delete.
	(test_target_has_registers, test_target_has_stack)
	(test_target_has_memory, test_target_prepare_to_store)
	(test_target_store_registers): New functions.
	(test_target_ops): New class.
	(register_to_value_test): Error out if there's already a
	process_stratum (or higher) target pushed.  Create a fuller mock
	environment, with mock target_ops, inferior, address space, thread
	and inferior_ptid.
	* progspace.c (struct address_space): Move to ...
	* progspace.h (struct address_space): ... here.
	* regcache.h (regcache::~regcache, regcache::raw_write)
	[GDB_SELF_TEST]: No longer virtual.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix "Remote 'g' packet reply is too long" problems with multiple inferiors
@ 2017-10-04 17:39 sergiodj+buildbot
  2017-10-04 21:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-04 17:39 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5cd63fda035d4ba949e6478406162c4673b3c9ef ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 5cd63fda035d4ba949e6478406162c4673b3c9ef

Fix "Remote 'g' packet reply is too long" problems with multiple inferiors

When debugging two inferiors (or more) against gdbserver, and the
inferiors have different architectures, such as e.g., on x86_64
GNU/Linux and one inferior is 64-bit while the other is 32-bit, then
GDB can get confused with the different architectures in a couple
spots.

In both cases I ran into, GDB incorrectly ended up using the
architecture of whatever happens to be the selected inferior instead
of the architecture of some other given inferior:

#1 - When parsing the expedited registers in stop replies.

#2 - In the default implementation of the target_thread_architecture
     target method.

These resulted in instances of the infamous "Remote 'g' packet reply
is too long" error.  For example, with the test added in this commit,
we get:

~~~
  Continuing.
  Remote 'g' packet reply is too long (expected 440 bytes, got 816 bytes): ad064000000000000[snip]
  (gdb) FAIL: gdb.multi/multi-arch.exp: inf1 event with inf2 selected: continue to hello_loop

  c
  Continuing.
  Truncated register 50 in remote 'g' packet
  (gdb) PASS: gdb.multi/multi-arch.exp: inf2 event with inf1 selected: c
~~~

This commit fixes that.

gdb/ChangeLog:
2017-10-04  Pedro Alves  <palves@redhat.com>

	* remote.c (get_remote_arch_state): New 'gdbarch' parameter.  Use
	it instead of target_gdbarch.
	(get_remote_state, get_remote_packet_size): Adjust
	get_remote_arch_state calls, passing down target_gdbarch
	explicitly.
	(packet_reg_from_regnum, packet_reg_from_pnum): New parameter
	'gdbarch' and use it instead of target_gdbarch.
	(get_memory_packet_size): Adjust get_remote_arch_state calls,
	passing down target_gdbarch explicitly.
	(struct stop_reply) <arch>: New field.
	(remote_parse_stop_reply): Use the stopped thread's architecture,
	not the current inferior's.  Save the architecture in the
	stop_reply.
	(process_stop_reply): Use the stop reply's architecture.
	(process_g_packet, remote_fetch_registers)
	(remote_prepare_to_store, store_registers_using_G)
	(remote_store_registers): Adjust get_remote_arch_state calls,
	using the regcache's architecture.
	(remote_get_trace_status): Adjust get_remote_arch_state calls,
	passing down target_gdbarch explicitly.
	* spu-multiarch.c (spu_thread_architecture): Defer to the target
	beneath instead of calling target_gdbarch.
	* target.c (default_thread_architecture): Use the specified
	inferior's architecture, instead of the current inferior's
	architecture (via target_gdbarch).

gdb/testsuite/ChangeLog:
2017-10-04  Pedro Alves  <palves@redhat.com>

	* gdb.multi/hangout.c: Include <unistd.h>.
	(hangout_loop): New function.
	(main): Call alarm.  Call hangout_loop in a loop.
	* gdb.multi/hello.c: Include <unistd.h>.
	(hello_loop): New function.
	(main): Call alarm.  Call hangout_loop in a loop.
	* gdb.multi/multi-arch.exp: Test running to a breakpoint one
	inferior with the other selected.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix -list-thread-groups --available logic and add test
@ 2017-10-04 16:48 sergiodj+buildbot
  2017-10-04 17:59 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-04 16:48 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4c71c1059f876fcca9809f7b6372b721ddb83635 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 4c71c1059f876fcca9809f7b6372b721ddb83635

Fix -list-thread-groups --available logic and add test

New in v3:

- Replace use_gdb_stub with can_spawn_for_attach.
- Call kill_wait_spawned_process on spawn_ids.

Commit

  Use std::set in mi-main.c
  52f9abe4c739f42cc5f80b2629276493ac6306f9

changed the logic of the "-list-thread-groups --available" by mistake
when a pid is passed.  It prints all the processes except the one
specified by the given pid.  The correct behavior is to only print the
process corresponding to that pid.  this patch fixes that and adds a test.

gdb/ChangeLog:

	* mi/mi-main.c (list_available_thread_groups): Reverse filter logic.

gdb/testsuite/ChangeLog:

	* gdb.mi/list-thread-groups-available.exp: New file.
	* gdb.mi/list-thread-groups-available.c: New file.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Move code out of 'between TRY and CATCH'
@ 2017-10-04 12:21 sergiodj+buildbot
  2017-10-04 13:24 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-04 12:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 73dcd72d4eeec176f769660ddcdefd1f25d0a2ec ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 73dcd72d4eeec176f769660ddcdefd1f25d0a2ec

Move code out of 'between TRY and CATCH'

I tried building GDB with TRY/CATCH mapped to raw C++ try/catch (by
defining GDB_XCPT to GDB_XCPT_RAW_TRY in
gdb/common/common-exceptions.h), and that caught a case of code
written between try and catch.  This commit fixes it.

gdb/ChangeLog:
2017-10-04  Pedro Alves  <palves@redhat.com>

	* guile/scm-breakpoint.c (gdbscm_breakpoint_commands): Move code
	out of 'between TRY and CATCH'.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add missing-END_CATCH detection/protection (to gdb's TRY/CATCH/END_CATCH)
@ 2017-10-04 10:25 sergiodj+buildbot
  2017-10-04 12:13 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-04 10:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a87c142792e4dcbec2bb3825e71f3ace044c2096 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: a87c142792e4dcbec2bb3825e71f3ace044c2096

Add missing-END_CATCH detection/protection (to gdb's TRY/CATCH/END_CATCH)

While we still have cleanups (i.e., make_cleanup & co), we must be
sure to add END_CATCH at the end of a TRY/CATCH/END_CATCH construct.
However, it's currently too easy to miss adding the END_CATCH, because
the code compiles anyway without it.  I realized this when I noticed
that another patch I was working on missed several adding END_CATCH in
several new TRY/CATCH uses.

This commit fixes that by making TRY open a new scope that is only
closed by END_CATCH.  This way, if you forget to add the END_CATCH,
then compilation fails due to the unbalanced curly braces.

This caught a couple places where we were missing END_CATCH in current
master, also fixed by the patch.

gdb/ChangeLog:
2017-10-04  Pedro Alves  <palves@redhat.com>

	* cli/cli-cmds.c (complete_command): Add missing END_CATCH.
	* common/common-exceptions.h (TRY): Open an outermost scope.
	Expand intro comment.
	(CATCH): Reindent.
	(END_CATCH): Close the outermost scope.
	* completer.c (complete_line_internal): Add missing END_CATCH.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Extend "set cwd" to work on gdbserver
@ 2017-10-04  7:08 sergiodj+buildbot
  2017-10-04 10:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-04  7:08 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bc3b087de2401c65c02730d346e8bea4dc0504ae ***

Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: bc3b087de2401c65c02730d346e8bea4dc0504ae

Extend "set cwd" to work on gdbserver

This is the "natural" extension necessary for the "set cwd" command
(and the whole "set the inferior's cwd" logic) to work on gdbserver.

The idea here is to have a new remote packet, QSetWorkingDir (name
adopted from LLDB's extension to the RSP, as can be seen at
<https://raw.githubusercontent.com/llvm-mirror/lldb/master/docs/lldb-gdb-remote.txt>),
which sends an hex-encoded string representing the working directory
that the remote inferior will use.  There is a slight difference from
the packet proposed by LLDB: GDB's version will accept empty
arguments, meaning that the user wants to clear the previously set
working directory for the inferior (i.e., "set cwd" without arguments
on GDB).

For UNIX-like targets this feature is already implemented on
nat/fork-inferior.c, and all gdbserver has to do is to basically
implement "set_inferior_cwd" and call it whenever such packet arrives.
For other targets, like Windows, it is possible to use the existing
"get_inferior_cwd" function and do the necessary steps to make sure
that the inferior will use the specified working directory.

Aside from that, the patch consists basically of updates to the
testcase (making it available on remote targets) and the
documentation.

No regressions found.

gdb/ChangeLog:
2017-10-04  Sergio Durigan Junior  <sergiodj@redhat.com>

	* NEWS (Changes since GDB 8.0): Add entry about new
	'set-cwd-on-gdbserver' feature.
	(New remote packets): Add entry for QSetWorkingDir.
	* common/common-inferior.h (set_inferior_cwd): New prototype.
	* infcmd.c (set_inferior_cwd): Remove "static".
	(show_cwd_command): Expand text to include remote debugging.
	* remote.c: Add PACKET_QSetWorkingDir.
	(remote_protocol_features) <QSetWorkingDir>: New entry for
	PACKET_QSetWorkingDir.
	(extended_remote_set_inferior_cwd): New function.
	(extended_remote_create_inferior): Call
	"extended_remote_set_inferior_cwd".
	(_initialize_remote): Call "add_packet_config_cmd" for
	QSetWorkingDir.

gdb/gdbserver/ChangeLog:
2017-10-04  Sergio Durigan Junior  <sergiodj@redhat.com>

	* inferiors.c (set_inferior_cwd): New function.
	* server.c (handle_general_set): Handle QSetWorkingDir packet.
	(handle_query): Inform that QSetWorkingDir is supported.
	* win32-low.c (create_process): Pass the inferior's cwd to
	CreateProcess.

gdb/testsuite/ChangeLog:
2017-10-04  Sergio Durigan Junior  <sergiodj@redhat.com>

	* gdb.base/set-cwd.exp: Make it available on
	native-extended-gdbserver.

gdb/doc/ChangeLog:
2017-10-04  Sergio Durigan Junior  <sergiodj@redhat.com>

	* gdb.texinfo (Starting your Program) <The working directory.>:
	Mention remote debugging.
	(Working Directory) <Your Program's Working Directory>:
	Likewise.
	(Connecting) <Remote Packet>: Add "set-working-dir"
	and "QSetWorkingDir" to the table.
	(Remote Protocol) <QSetWorkingDir>: New item, explaining the
	packet.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR22245, Fix potential UB in bfd_set_error
@ 2017-10-04  4:18 sergiodj+buildbot
  2017-10-04  5:11 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-04  4:18 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9ba5f27cdd15d22d6c5739ff5d2b1c81d796e114 ***

Author: Pavel I. Kryukov <kryukov@frtk.ru>
Branch: master
Commit: 9ba5f27cdd15d22d6c5739ff5d2b1c81d796e114

PR22245, Fix potential UB in bfd_set_error

Passing enum as a first argument to variadic argument function
may lead to undefined behavior. The explanation on CERT site:
https://www.securecoding.cert.org/confluence/display/cplusplus/
EXP58-CPP.+Pass+an+object+of+the+correct+type+to+va_start

The bug was found by Kirill Nedostoev (nedostoev.ka@phystech.edu)
when he tried to build GNU binutils with Clang 7.

	PR 22245
	* bfd.c (bfd_set_error): Avoid UB on passing arg to va_start that
	undergoes default promotion.
	* bfd-in2.h: Regenerate.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdbarch: Remove duplicate `struct objfile' declaration
@ 2017-10-03 23:08 sergiodj+buildbot
  2017-10-04  0:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-03 23:08 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT db8dd1601ee4d0629957bcc8b4156d65f42a218d ***

Author: Maciej W. Rozycki <macro@imgtec.com>
Branch: master
Commit: db8dd1601ee4d0629957bcc8b4156d65f42a218d

gdbarch: Remove duplicate `struct objfile' declaration

Remove a duplicate `struct objfile' declaration mistakenly added with
commit 3e29f34a4eef ("MIPS: Keep the ISA bit in compressed code
addresses").

	gdb/
	* gdbarch.sh (objfile): Remove duplicate declaration.
	* gdbarch.h: Regenerate.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Update my email address.
@ 2017-10-03 21:48 sergiodj+buildbot
  2017-10-03 22:54 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-03 21:48 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c0107b0f57bc958b640dabafd4c6c618ea023397 ***

Author: Jim Wilson <jim.wilson@linaro.org>
Branch: master
Commit: c0107b0f57bc958b640dabafd4c6c618ea023397

Update my email address.

	sim/
	* MAINTAINERS (aarch64): Update my email address.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix &str printing in Rust
@ 2017-10-02 21:46 sergiodj+buildbot
  2017-10-03 14:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-02 21:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 45320ffa0450b27e232d933d2a1c6a09d94ac18b ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 45320ffa0450b27e232d933d2a1c6a09d94ac18b

Fix &str printing in Rust

Printing a string slice ("&str") in Rust would print until the
terminating \0; but that is incorrect because a slice has a length.
This fixes &str printing, and arranges to preserve the type name when
slicing a slice, so that printing a slice of an "&str" works as well.

This is PR rust/22236.

2017-10-02  Tom Tromey  <tom@tromey.com>

	PR rust/22236:
	* rust-lang.c (rust_val_print_str): New function.
	(val_print_struct): Call it.
	(rust_subscript): Preserve name of slice type.

2017-10-02  Tom Tromey  <tom@tromey.com>

	PR rust/22236:
	* gdb.rust/simple.rs (main): New variable "fslice".
	* gdb.rust/simple.exp: Add slice tests.  Update string tests.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix ptype of Rust slices
@ 2017-10-02 21:04 sergiodj+buildbot
  2017-10-03 13:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-02 21:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b3e3859bc577db5b79bb3d39048fd46c0a0420ef ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: b3e3859bc577db5b79bb3d39048fd46c0a0420ef

Fix ptype of Rust slices

Something like "ptype &x[..]" (where "x" was a slice) would crash gdb.
rust_subscript wasn't handling slicing in the EVAL_AVOID_SIDE_EFFECTS
case.

2017-10-02  Tom Tromey  <tom@tromey.com>

	* rust-lang.c (rust_subscript): Handle slices in
	EVAL_AVOID_SIDE_EFFECTS case.

2017-10-02  Tom Tromey  <tom@tromey.com>

	* gdb.rust/simple.exp: Test ptype of a slice.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Allow indexing of &str in Rust
@ 2017-10-02 20:33 sergiodj+buildbot
  2017-10-03 12:29 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-02 20:33 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 01af5e0d09ac9c621e7b280f44a2c7ef55784493 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 01af5e0d09ac9c621e7b280f44a2c7ef55784493

Allow indexing of &str in Rust

rust_slice_type_p was not recognizing &str as a slice type, so indexing
into (or making a slice of) a slice was not working.

2017-10-02  Tom Tromey  <tom@tromey.com>

	* rust-lang.c (rust_slice_type_p): Recognize &str as a slice type.

2017-10-02  Tom Tromey  <tom@tromey.com>

	* gdb.rust/simple.exp: Test index of slice.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
[parent not found: <9754d8c4c48209eaefb044d03dc25f14dca8a263@gdb-build>]
* [binutils-gdb] Fix GDB build with G++ 4.8
@ 2017-10-02  9:57 sergiodj+buildbot
  2017-10-03  9:29 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-02  9:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cc536b21677586455973f81ee05257ada8efdcb8 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: cc536b21677586455973f81ee05257ada8efdcb8

Fix GDB build with G++ 4.8

G++ 4.8 trips on:

  In file included from /opt/gcc-4.8/include/c++/4.8.5/algorithm:62:0,
		   from ../../src/gdb/ada-lang.c:65:
  /opt/gcc-4.8/include/c++/4.8.5/bits/stl_algo.h: In instantiation of _RandomAccessIterator std::__unguarded_partition(_RandomAccessIterator, _RandomAccessIterator, const _Tp&) [with _RandomAccessIterator = __gnu_cxx::__normal_iterator<ada_exc_info*, std::vector<ada_exc_info> >; _Tp = ada_exc_info]:
  /opt/gcc-4.8/include/c++/4.8.5/bits/stl_algo.h:2283:70:   required from _RandomAccessIterator std::__unguarded_partition_pivot(_RandomAccessIterator, _RandomAccessIterator) [with _RandomAccessIterator = __gnu_cxx::__normal_iterator<ada_exc_info*, std::vector<ada_exc_info> >]
  /opt/gcc-4.8/include/c++/4.8.5/bits/stl_algo.h:2315:54:   required from void std::__introsort_loop(_RandomAccessIterator, _RandomAccessIterator, _Size) [with _RandomAccessIterator = __gnu_cxx::__normal_iterator<ada_exc_info*, std::vector<ada_exc_info> >; _Size = long int]
  /opt/gcc-4.8/include/c++/4.8.5/bits/stl_algo.h:5461:36:   required from void std::sort(_RAIter, _RAIter) [with _RAIter = __gnu_cxx::__normal_iterator<ada_exc_info*, std::vector<ada_exc_info> >]
  ../../src/gdb/ada-lang.c:13153:61:   required from here
  /opt/gcc-4.8/include/c++/4.8.5/bits/stl_algo.h:2245:19: error: passing const ada_exc_info as this argument of bool ada_exc_info::operator<(const ada_exc_info&) discards qualifiers [-fpermissive]
      while (__pivot < *__last)
		     ^

Seems to be a libstdc++ bug meanwhile fixed by:
  https://gcc.gnu.org/ml/libstdc++/2012-04/msg00074.

In any case, there's no reason these methods can't be const.

gdb/ChangeLog:
2017-10-02  Tom Tromey  <tom@tromey.com>
	    Pedro Alves  <palves@redhat.com>

	* ada-lang.h (ada_exc_info::operator<): Make const.
	(ada_exc_info::operator==): Make const.
	* ada-lang.c (ada_exc_info::operator<, ada_exc_info::operator==):
	Make const.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
[parent not found: <8abcee91738bf0be98e949049c559839ef811ae4@gdb-build>]
* [binutils-gdb] Use std::set in mi-main.c
@ 2017-10-01  2:06 sergiodj+buildbot
  2017-10-03  0:06 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-10-01  2:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 52f9abe4c739f42cc5f80b2629276493ac6306f9 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 52f9abe4c739f42cc5f80b2629276493ac6306f9

Use std::set in mi-main.c

Change a couple of spots in mi-main.c to use std::set.  This
simplifies the code and removes some cleanups.

gdb/ChangeLog
2017-09-29  Tom Tromey  <tom@tromey.com>

	* mi/mi-main.c (struct print_one_inferior_data) <inferiors>: Now a
	'std::set *'.
	(print_one_inferior): Update.
	(free_vector_of_ints): Remove.
	(list_available_thread_groups): Change "ids" to std::set.
	(mi_cmd_list_thread_groups): Update.
	(struct collect_cores_data) <core>: Now a std::set.
	(collect_cores): Update.
	(unique): Remove.
	(print_one_inferior): Update.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Don't copy a string in mi_cmd_disassemble
@ 2017-09-30 14:16 sergiodj+buildbot
  2017-10-02 18:03 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-30 14:16 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9813429a729dbcd761dfbb02d2d7a3449af0881d ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 9813429a729dbcd761dfbb02d2d7a3449af0881d

Don't copy a string in mi_cmd_disassemble

This string copy in mi_cmd_disassemble seems not to be needed, so
don't do it.

gdb/ChangeLog
2017-09-29  Tom Tromey  <tom@tromey.com>

	* mi/mi-cmd-disas.c (mi_cmd_disassemble): Don't copy "oarg".


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove cleanups from mi_cmd_break_insert_1
@ 2017-09-30 11:26 sergiodj+buildbot
  2017-10-02 15:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-30 11:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 784c453a4f1aeee237203dd6257a6ed24bee28c3 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 784c453a4f1aeee237203dd6257a6ed24bee28c3

Remove cleanups from mi_cmd_break_insert_1

This changes mi_argv_to_format to return a string, allowing the
removal of some cleanups.

gdb/ChangeLog
2017-09-29  Tom Tromey  <tom@tromey.com>

	* mi/mi-cmd-break.c (mi_argv_to_format): Return std::string.
	(mi_cmd_break_insert_1): Update.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove make_cleanup_defer_target_commit_resume
@ 2017-09-30 10:20 sergiodj+buildbot
  2017-10-02 13:15 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-30 10:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a9bc57b97840a874ad2802e29a44fbf557668808 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: a9bc57b97840a874ad2802e29a44fbf557668808

Remove make_cleanup_defer_target_commit_resume

This removes make_cleanup_defer_target_commit_resume in favor of using
scoped_restore.

gdb/ChangeLog
2017-09-29  Tom Tromey  <tom@tromey.com>

	* target.h (make_scoped_defer_target_commit_resume): Update.
	* target.c (make_scoped_defer_target_commit_resume): Rename from
	make_cleanup_defer_target_commit_resume.  Return a
	scoped_restore.
	* infrun.c (proceed): Use make_scoped_defer_target_commit_resume.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove cleanup from mt-tdep.c
@ 2017-09-30  8:37 sergiodj+buildbot
  2017-10-02  8:56 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-30  8:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 42518ba746b5b6cb7c169a55430e73551be345f5 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 42518ba746b5b6cb7c169a55430e73551be345f5

Remove cleanup from mt-tdep.c

Remove a cleanup from mt-tdep.c, using gdb::byte_vector.

gdb/ChangeLog
2017-09-29  Tom Tromey  <tom@tromey.com>

	* mt-tdep.c (mt_push_dummy_call): Use gdb::byte_vector.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove some cleanups from stack.c
@ 2017-09-30  7:10 sergiodj+buildbot
  2017-10-02  2:56 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-30  7:10 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2003f3d839fa887811ff65380191e0beaeff719e ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 2003f3d839fa887811ff65380191e0beaeff719e

Remove some cleanups from stack.c

This removes some cleanups from stack.c by using std::string or
gdb::unique_xmalloc_ptr.  One cleanup remains in this file; I did not
remove it here because it is handled in another patch series that has
yet to be resolved.

gdb/ChangeLog
2017-09-29  Tom Tromey  <tom@tromey.com>

	* stack.c (parse_frame_specification): Use std::string
	(info_frame_command): Use gdb::unique_xmalloc_ptr.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove cleanup from tilegx-tdep.c
@ 2017-09-30  6:22 sergiodj+buildbot
  2017-10-02  1:45 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-30  6:22 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8f8accb58078b1f249dc6865b8784a0a8e8881dd ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 8f8accb58078b1f249dc6865b8784a0a8e8881dd

Remove cleanup from tilegx-tdep.c

This removes a cleanup from tilegx-tdep.c, by using gdb::byte_vector.

gdb/ChangeLog
2017-09-29  Tom Tromey  <tom@tromey.com>

	* tilegx-tdep.c (tilegx_push_dummy_call): Use gdb::byte_vector.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Constify core_file_command
@ 2017-09-28  2:14 sergiodj+buildbot
  2017-09-28  9:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-28  2:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d64097b17c88ae18781ecce59d1b265b41e9551a ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: d64097b17c88ae18781ecce59d1b265b41e9551a

Constify core_file_command

gdb/ChangeLog
2017-09-27  Tom Tromey  <tom@tromey.com>

	* gdbcore.h (core_file_command): Update.
	* corefile.c (core_file_command): Constify.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Constify commands in cli-dump.c
@ 2017-09-28  1:36 sergiodj+buildbot
  2017-09-28 18:46 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-28  1:36 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2d0ac1068babfe8800607b17ddb2f31189bdb334 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 2d0ac1068babfe8800607b17ddb2f31189bdb334

Constify commands in cli-dump.c

gdb/ChangeLog
2017-09-27  Tom Tromey  <tom@tromey.com>

	* cli/cli-dump.c (dump_memory_command, dump_value_command)
	(dump_srec_memory, dump_srec_value, dump_ihex_memory)
	(dump_ihex_value, dump_verilog_memory, dump_verilog_value)
	(dump_tekhex_memory, dump_tekhex_value, dump_binary_memory)
	(dump_binary_value, append_binary_memory, append_binary_value):
	Constify.
	(struct dump_context) <func>: Constify.
	(add_dump_command): Update.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Constify some commands in  cli-cmds.c
@ 2017-09-28  1:33 sergiodj+buildbot
  2017-09-28 17:10 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-28  1:33 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT dede02ce4d2267d044db41a0896af4d670647a04 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: dede02ce4d2267d044db41a0896af4d670647a04

Constify some commands in  cli-cmds.c

gdb/ChangeLog
2017-09-27  Tom Tromey  <tom@tromey.com>

	* cli/cli-cmds.c (show_version, show_configuration)
	(source_command, show_user): Constify.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Constify cmd_record_full_restore
@ 2017-09-28  0:29 sergiodj+buildbot
  2017-09-28 13:00 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-28  0:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 41243651350688a9a0f3a3542871d37e7f3c5f20 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 41243651350688a9a0f3a3542871d37e7f3c5f20

Constify cmd_record_full_restore

gdb/ChangeLog
2017-09-27  Tom Tromey  <tom@tromey.com>

	* record-full.c (cmd_record_full_restore): Constify.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Constify show_convenience
@ 2017-09-27 23:15 sergiodj+buildbot
  2017-09-28 10:38 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-27 23:15 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ad25e4234a3f370a693b9c392c5b54216aab4592 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: ad25e4234a3f370a693b9c392c5b54216aab4592

Constify show_convenience

gdb/ChangeLog
2017-09-27  Tom Tromey  <tom@tromey.com>

	* value.c (show_convenience): Constify.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Constify display_tib
@ 2017-09-27 22:06 sergiodj+buildbot
  2017-09-28  3:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-27 22:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c281872eec33c92db0565afdbfdee91558e5d8e0 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: c281872eec33c92db0565afdbfdee91558e5d8e0

Constify display_tib

gdb/ChangeLog
2017-09-27  Tom Tromey  <tom@tromey.com>

	* windows-tdep.c (display_tib): Constify.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Constify maintenance_print_user_registers
@ 2017-09-27 21:51 sergiodj+buildbot
  2017-09-28  8:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-27 21:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4d4589ef76b975eead8da6bfa65db4a9dc85089a ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 4d4589ef76b975eead8da6bfa65db4a9dc85089a

Constify maintenance_print_user_registers

gdb/ChangeLog
2017-09-27  Tom Tromey  <tom@tromey.com>

	* user-regs.c (maintenance_print_user_registers): Constify.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Constify maintenance_cplus_namespace
@ 2017-09-27 20:54 sergiodj+buildbot
  2017-09-28  6:58 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-27 20:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 32a7bf17c94a81c08535ea045f43fe8c8271d3fd ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 32a7bf17c94a81c08535ea045f43fe8c8271d3fd

Constify maintenance_cplus_namespace

gdb/ChangeLog
2017-09-27  Tom Tromey  <tom@tromey.com>

	* cp-namespace.c (maintenance_cplus_namespace): Constify.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Constify two functions in valprint.c
@ 2017-09-27 19:37 sergiodj+buildbot
  2017-09-27 21:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-27 19:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b0a8e6c4431a2e762dac88f3d73efca4bc47c90a ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: b0a8e6c4431a2e762dac88f3d73efca4bc47c90a

Constify two functions in valprint.c

gdb/ChangeLog
2017-09-27  Tom Tromey  <tom@tromey.com>

	* valprint.c (set_radix, show_radix): Constify.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Constify dump_arc_instruction_command
@ 2017-09-27 18:28 sergiodj+buildbot
  2017-09-27 23:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-27 18:28 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 57f5a81bd240459edbdac1628800291e7535ed02 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 57f5a81bd240459edbdac1628800291e7535ed02

Constify dump_arc_instruction_command

gdb/ChangeLog
2017-09-27  Tom Tromey  <tom@tromey.com>

	* arc-tdep.c (dump_arc_instruction_command): Constify.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Constify add_cmd gdb_bfd.c
@ 2017-09-27 16:46 sergiodj+buildbot
  2017-09-27 17:22 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-27 16:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e4e3333549c96d2915bb888b7b347566c938e75a ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: e4e3333549c96d2915bb888b7b347566c938e75a

Constify add_cmd gdb_bfd.c

This constifies a command function in gdb_bfd.c.

gdb/ChangeLog
2017-09-27  Tom Tromey  <tom@tromey.com>

	* gdb_bfd.c (maintenance_info_bfds): Constify.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add add_cmd function overloads
@ 2017-09-27 15:48 sergiodj+buildbot
  2017-09-27 16:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-27 15:48 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0450cc4ce8b4775c47e9aaa1c5a34e181b10ae98 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 0450cc4ce8b4775c47e9aaa1c5a34e181b10ae98

Add add_cmd function overloads

This adds two add_cmd overloads: one whose callback takes a const char *,
and one that doesn't accept a function at all.  The no-function overload
was introduced to avoid ambiguity when NULL was passed as the function.

Long term the goal is for all commands to take const arguments, and
for the non-const variants to be removed entirely.

gdb/ChangeLog
2017-09-27  Tom Tromey  <tom@tromey.com>

	* cli/cli-decode.c (add_cmd, set_cmd_cfunc): New function
	overloads.
	(do_add_cmd): Rename from add_cmd.  Don't call set_cmd_cfunc.
	(do_const_cfunc): New function.
	(cmd_cfunc_eq): New overload.
	(cli_user_command_p): Check do_const_cfunc.
	* cli/cli-decode.h (struct cmd_list_element) <function>: New field
	const_cfunc.
	* command.h (add_cmd): Add const overload and no-function
	overload.
	(set_cmd_cfunc): Add const overload.
	(cmd_const_cfunc_ftype): Declare.
	(cmd_cfunc_eq): Add const overload.
	* breakpoint.c, cli-cmds.c, cli-dump.c, guile/scm-cmd.c,
	python/py-cmd.c, target.c, tracepoint.c: Use no-function add_cmd
	overload.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86-64: Don't pass output_bfd to info->callbacks->minfo
@ 2017-09-26 22:02 sergiodj+buildbot
  2017-09-27  6:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-26 22:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ac69a0d75bf472a140e5405c8a90420d5f63a998 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: ac69a0d75bf472a140e5405c8a90420d5f63a998

x86-64: Don't pass output_bfd to info->callbacks->minfo

Don't pass output_bfd to info->callbacks->minfo when dumping local IFUNC
functions in the map file.

	PR ld/22199
	* elf64-x86-64.c (elf_x86_64_finish_dynamic_symbol): Don't pass
	output_bfd to info->callbacks->minfo.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] dwarf2read: Restrict ICC workaround to ICC<14
@ 2017-09-26 18:56 sergiodj+buildbot
  2017-09-27  4:15 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-26 18:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5230b05a94b964da335a0758686b92a8efcc823d ***

Author: Walfred Tedeschi <walfred.tedeschi@intel.com>
Branch: master
Commit: 5230b05a94b964da335a0758686b92a8efcc823d

dwarf2read: Restrict ICC workaround to ICC<14

GDB has a workaround for DWARF output by ICC, related to missing
DW_AT_declaration on incomplete types.  The bug was fixed in ICC 14,
so this commit adjusts GDB accordingly.

For the version check, this adds a new parser function for the ICC
producer string.  While at it, it also adds unit tests for the
producer parsing covering the new function and preexisting parsers.

gdb/ChangeLog:
2017-09-26  Walfred Tedeschi  <walfred.tedeschi@intel.com>
	    Pedro Alves <palves@redhat.com>

	* dwarf2read.c (dwarf2_cu): Remove field producer_is_icc and add
	producer_is_icc_lt_14.
	(producer_is_icc_lt_14): New function.
	(check_producer): Add code for checking version of ICC.
	(producer_is_icc): Move to producer.c.
	(read_structure_type): Restrict ICC workaround to ICC<14.
	* producer.c: Include selftest.h.
	(producer_is_icc, producer_parsing_tests, _initialize_producer):
	New functions.
	* producer.h (producer_is_icc): New declaration.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Use "switch_to_thread" more thoroughly on gdbserver
@ 2017-09-26 17:59 sergiodj+buildbot
  2017-09-26 23:44 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-26 17:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 75352e283fb2b265d14c750859156943f6eb2693 ***

Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: 75352e283fb2b265d14c750859156943f6eb2693

Use "switch_to_thread" more thoroughly on gdbserver

This is a technical debt that I left when I ported "switch_to_thread"
to gdbserver.  It's a simple patch that converts occurences of:

  current_thread = find_thread_ptid (ptid);

to:

  switch_to_thread (ptid);

This patch also converts a simple "if" to a "gdb_assert" on
gdbserver's version of "switch_to_thread":

  gdb_assert (ptid != minus_one_ptid);

This change makes the code more similar to what GDB already does.

Regtested on BuildBot.

gdb/gdbserver/ChangeLog:
2017-09-26  Sergio Durigan Junior  <sergiodj@redhat.com>

	* gdbthread.h: Include "common-gdbthread.h".
	* inferiors.c (switch_to_thread): Use "gdb_assert" instead of
	"if" when validating the ptid.
	* remote-utils.c: Include "gdbthread.h".
	(prepare_resume_reply): Use "switch_to_thread".
	* target.c (done_accessing_memory): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Allow linking GDB with ncursesw
@ 2017-09-26 17:12 sergiodj+buildbot
  2017-09-26 22:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-26 17:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5007d765ae09c10c7f3b18bb16841b9d2d59e181 ***

Author: Matthias Klose <doko@ubuntu.com>
Branch: master
Commit: 5007d765ae09c10c7f3b18bb16841b9d2d59e181

Allow linking GDB with ncursesw

Triggered by https://launchpad.net/bugs/1275210, to be able to cope
with UTF-8 characters in gdbtui.

Reference:
  https://sourceware.org/ml/gdb-patches/2017-09/msg00356.html

gdb/ChangeLog:
2017-09-26  Matthias Klose  <doko@ubuntu.com>

	* configure.ac: Search ncursesw before ncurses.
	Check ncursesw/ncurses.h before ncurses/ncurses.h.
	* gdb_curses.h: Include <ncursesw/ncurses.h>
	* config.in, configure: Regenerate.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix an assertion failure when parsing a fuzzed x86_64 ELF binary.
@ 2017-09-26 16:23 sergiodj+buildbot
  2017-09-26 22:00 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-26 16:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 262c0a877f91b9102fd42523598b46ea79a8970e ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 262c0a877f91b9102fd42523598b46ea79a8970e

Fix an assertion failure when parsing a fuzzed x86_64 ELF binary.

	PR 22172
	* elf64-x86-64.c (elf_x86_64_info_to_howto): Do not trigger an
	assertion failure if elf_x86_64_rtype_to_howto has already issued
	an error message.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Tidy reading data in read_formatted_entries
@ 2017-09-26 16:00 sergiodj+buildbot
  2017-09-26 19:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-26 16:00 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 33e0a9a056bd23e923b929a4f2ab049ade0b1c32 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 33e0a9a056bd23e923b929a4f2ab049ade0b1c32

Tidy reading data in read_formatted_entries

Using read_attribute_value accomplishes two things: It checks for
unexpected formats, and ensures the buffer pointer always increments.

	PR 22210
	* dwarf2.c (read_formatted_entries): Use read_attribute_value to
	read data.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Avoid needless resource usage when processing a corrupt DWARF directory or file name table.
@ 2017-09-26 15:21 sergiodj+buildbot
  2017-09-26 18:24 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-26 15:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 30d0157a2ad64e64e5ff9fcc0dbe78a3e682f573 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 30d0157a2ad64e64e5ff9fcc0dbe78a3e682f573

Avoid needless resource usage when processing a corrupt DWARF directory or file name table.

	PR 22210
	* dwarf2.c (read_formatted_entries): Fail early if we know that
	the loop parsing data entries will overflow the end of the
	section.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove support for Solaris < 10 (PR gdb/22185)
@ 2017-09-26 14:35 sergiodj+buildbot
  2017-09-26 16:20 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-26 14:35 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 281c4447738409888d9659924937da182a65b4e1 ***

Author: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Branch: master
Commit: 281c4447738409888d9659924937da182a65b4e1

Remove support for Solaris < 10 (PR gdb/22185)

Given that GCC has obsoleted/removed support for Solaris 9 in GCC 4.9/5 in 2013:

    https://gcc.gnu.org/gcc-4.9/changes.html
    https://gcc.gnu.org/ml/gcc-patches/2013-05/msg00728.html

and the last gdb version that can be compiled with gcc 4.9 is 7.12.1 only when
configured with --disable-build-with-cxx, it's time to obsolete/remove support
for Solaris < 10.

This patch does this, simplifying configure.nat along the way (only a single
sol2 configuration with variants for i386 and sparc).

Some configure checks for older Solaris versions can go, too, and the check
for libthread_db.so.1 removed:

* Since Solaris 10, dlopen has moved to libc and libdl.so is just a
  filter on ld.so.1, so no need to check.

* $RDYNAMIC is already handled above (and is a no-op with Solaris ld
  anyway).

Both proc-service.c and sol-thread.c lose support for (Solaris-only)
PROC_SERVICE_IS_OLD.

The attached revised patch has been tested on sparcv9-sun-solaris2.10,
sparcv9-sun-solaris2.11.4, amd64-pc-solaris2.10, amd64-pc-solaris2.11.4,
and x86_64-pc-linux-gnu.

I've also started an i386-pc-solaris2.9 build to check that it really
stops as expected.

	PR gdb/22185
	* configure.host <*-*-solaris2.[01], *-*-solaris2.[2-9]*>: Mark as
	obsolete.
	Use gdb_host sol2 for i[34567]86-*-solaris2*, x86_64-*-solaris2*.
	Remove i386sol2 support.
	* configure.nat <i386sol2>: Remove.
	<sol2-64>: Fold into ...
	<sol2>: ... this.
	Move common settings to default section.
	Add sol-thread.o.
	* configure.tgt <i[34567]86-*-solaris2.1[0-9]*,
	x86_64-*-solaris2.1[0-9]*>: Rename to ...
	<i[34567]86-*-solaris2*, x86_64-*-solaris2*>: ... this.
	<i[34567]86-*-solaris*>: Remove.
	<sparc-*-solaris2.[0-6], sparc-*-solaris2.[0-6].*>: Remove.

	* configure.ac: Remove wctype in libw check.
	(_MSE_INT_H): Don't define on Solaris 7-9.
	<solaris*>: Remove libthread_db.so.1 check.
	* configure: Regenerate.
	* config.in: Regenerate.

	* proc-service.c: Remove PROC_SERVICE_IS_OLD handling.
	(gdb_ps_prochandle_t, gdb_ps_read_buf_t, gdb_ps_write_buf_t)
	(gdb_ps_size_t): Remove.
	Use base types in users.
	* sol-thread.c: Likewise, also for gdb_ps_addr_t.

	* NEWS (Changes since GDB 8.0): Document Solaris 2.0-9 removal.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR22209, invalid memory read in find_abstract_instance_name
@ 2017-09-26 13:13 sergiodj+buildbot
  2017-09-26 13:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-26 13:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1b86808a86077722ee4f42ff97f836b12420bb2a ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 1b86808a86077722ee4f42ff97f836b12420bb2a

PR22209, invalid memory read in find_abstract_instance_name

This patch adds bounds checking for DW_FORM_ref_addr die refs, and
calculates them relative to the first .debug_info section.  See the
big comment for why calculating relative to the current .debug_info
section was wrong for relocatable object files.

	PR 22209
	* dwarf2.c (struct comp_unit): Delete sec_info_ptr field.
	(find_abstract_instance_name): Calculate DW_FORM_ref_addr relative
	to stash->info_ptr_memory, and check die_ref is within that memory.
	Set info_ptr_end correctly when another CU is refd.  Check die_ref
	for DW_FORM_ref4 etc. is within CU.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Remove make_cleanup_regcache_xfree
@ 2017-09-26  2:45 sergiodj+buildbot
  2017-09-26  4:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-26  2:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9ac86b52da268147b2565e4920357432bb7a34c3 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 9ac86b52da268147b2565e4920357432bb7a34c3

Remove make_cleanup_regcache_xfree

This removes make_cleanup_regcache_xfree in favor of using
std::unique_ptr as the return type of frame_save_as_regcache.

gdb/ChangeLog
2017-09-25  Tom Tromey  <tom@tromey.com>

	* spu-tdep.c (spu2ppu_sniffer): Update.
	* regcache.h (make_cleanup_regcache_xfree): Don't declare.
	* regcache.c (do_regcache_xfree, make_cleanup_regcache_xfree):
	Remove.
	* ppc-linux-tdep.c (ppu2spu_sniffer): Update.
	* mi/mi-main.c (mi_cmd_data_list_changed_registers): Update.
	* frame.h (frame_save_as_regcache): Return std::unique_ptr.
	* frame.c (frame_save_as_regcache): Return std::unique_ptr.
	(frame_pop): Update.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR22204, Lack of DW_LNE_end_sequence causes "infinite" loop
@ 2017-09-26  0:40 sergiodj+buildbot
  2017-09-26  0:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-26  0:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e338894dc2e603683bed2172e8e9f25b29051005 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: e338894dc2e603683bed2172e8e9f25b29051005

PR22204, Lack of DW_LNE_end_sequence causes "infinite" loop

	PR 22204
	* dwarf2.c (decode_line_info): Ensure line_ptr stays within
	bounds in inner loop.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] S390: Document guarded-storage register support
@ 2017-09-25 17:51 sergiodj+buildbot
  2017-09-26  0:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-25 17:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 289e23aa03084b22c73ebdcf18371f1e6666ead0 ***

Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: 289e23aa03084b22c73ebdcf18371f1e6666ead0

S390: Document guarded-storage register support

This documents the newly added support for guarded-storage registers on
IBM z.

gdb/ChangeLog:

	* NEWS: Advertise support for guarded-storage registers on IBM z.

gdb/doc/ChangeLog:

	* gdb.texinfo (S/390 and System z Features): Document the new
	features org.gnu.gdb.s390.gs and org.gnu.gdb.s390.gsbc.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] S390: Add guarded-storage register support to gdbserver
@ 2017-09-25 17:02 sergiodj+buildbot
  2017-09-25 22:48 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-25 17:02 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ad3396348e0ebb61fdf71cff307bac08175ed366 ***

Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: ad3396348e0ebb61fdf71cff307bac08175ed366

S390: Add guarded-storage register support to gdbserver

Enable gdbserver to deal with the new guarded-storage register sets.

gdb/gdbserver/ChangeLog:

	* configure.srv (s390*-*-linux*): Add s390-gs-linux64.o and
	s390x-gs-linux64.o to srv_regobj.  Add s390-gs-linux64.xml,
	s390x-gs-linux64.xml, s390-gs.xml, and s390-gsbc.xml to
	srv_xmlfiles.  Add s390-gs-linux64-ipa.o and
	s390x-gs-linux64-ipa.o to ipa_obj.
	* linux-s390-low.c (HWCAP_S390_GS): New define.
	(s390_fill_gs, s390_store_gs, s390_fill_gsbc, s390_store_gsbc):
	New functions.
	(s390_regsets): Add regsets for NT_S390_GS_CB and NT_S390_GS_BC.
	(s390_arch_setup): Check for guarded-storage support and choose
	appropriate tdesc.
	(initialize_low_arch): Invoke init_registers_s390_gs_linux64 and
	init_registers_s390x_gs_linux64.
	* linux-s390-tdesc.h (enum s390_linux_tdesc) <S390_TDESC_GS>: New
	enum value.
	(init_registers_s390x_gs_linux64, tdesc_s390x_gs_linux64)
	(init_registers_s390_gs_linux64, tdesc_s390_gs_linux64): Declare.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] S390: Add guarded-storage register support to GDB
@ 2017-09-25 16:24 sergiodj+buildbot
  2017-09-25 21:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-25 16:24 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1b63490c9173f8c9770b7885def720516aa9b9f8 ***

Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: 1b63490c9173f8c9770b7885def720516aa9b9f8

S390: Add guarded-storage register support to GDB

Recognize targets with the new guarded-storage feature and then present
the guarded-storage registers and the Linux-specific guarded-storage
broadcast control block appropriately.

gdb/ChangeLog:

	* s390-linux-nat.c (have_regset_gs): New static variable.
	(s390_linux_fetch_inferior_registers): Handle guarded-storage
	control block and guarded-storage broadcast control regsets.
	(s390_read_description): Detect whether the target has
	guarded-storage support, return appropriate tdesc.
	* s390-linux-tdep.c (features/s390-gs-linux64.c): New include.
	(features/s390x-gs-linux64.c): Likewise.
	(struct gdbarch_tdep) <have_gs>: New field.
	(s390_regmap_gs, s390_regmap_gsbc, s390_gs_regset)
	(s390_gsbc_regset): New variables.
	(s390_iterate_over_regset_sections): Iterate over s390_gs_regset
	and s390_gsbc_regset, if applicable.
	(s390_core_read_description): Check whether core file was from a
	target with guarded-storage support; include appropriate regsets.
	(s390_gdbarch_init): Add registers for guarded-storage support.
	(_initialize_s390_tdep): Initialize new target descriptions that
	include registers for guarded-storage support.
	* s390-linux-tdep.h (HWCAP_S390_GS, S390_GSD_REGNUM)
	(S390_GSSM_REGNUM, S390_GSEPLA_REGNUM)
	(S390_BC_GSD_REGNUM, S390_BC_GSSM_REGNUM): New defines.
	(S390_NUM_REGS): Adjust macro definition.
	(s390_gs_regset, s390_gsbc_regset, tdesc_s390_gs_linux64)
	(tdesc_s390x_gs_linux64): New declarations.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR22202, buffer overflow in parse_die
@ 2017-09-25 15:04 sergiodj+buildbot
  2017-09-25 16:59 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-25 15:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1da5c9a485f3dcac4c45e96ef4b7dae5948314b5 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 1da5c9a485f3dcac4c45e96ef4b7dae5948314b5

PR22202, buffer overflow in parse_die

There was a complete lack of sanity checking in dwarf1.c

	PR 22202
	* dwarf1.c (parse_die): Sanity check pointer against section limit
	before dereferencing.
	(parse_line_table): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR22201, DW_AT_name with out of bounds reference
@ 2017-09-25 14:14 sergiodj+buildbot
  2017-09-25 15:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-25 14:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 11855d8a1f11b102a702ab76e95b22082cccf2f8 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 11855d8a1f11b102a702ab76e95b22082cccf2f8

PR22201, DW_AT_name with out of bounds reference

DW_AT_name ought to always have a string value.

	PR 22201
	* dwarf2.c (scan_unit_for_symbols): Ignore DW_AT_name unless it
	has string form.
	(parse_comp_unit): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR22200, DWARF5 .debug_line sanity check
@ 2017-09-25 13:52 sergiodj+buildbot
  2017-09-25 14:08 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-25 13:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c361faae8d964db951b7100cada4dcdc983df1bf ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: c361faae8d964db951b7100cada4dcdc983df1bf

PR22200, DWARF5 .debug_line sanity check

The format_count entry can't be zero unless the count is also zero.

	PR 22200
	* dwarf2.c (read_formatted_entries): Error on format_count zero.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Initialize 'imm' on opcodes/aarch64-opc.c:expand_fp_imm (and fix breakage on mingw)
@ 2017-09-25  6:17 sergiodj+buildbot
  2017-09-25  6:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-25  6:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 57a024f4650d7562e963efb6b00c4a4cd74185c4 ***

Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: 57a024f4650d7562e963efb6b00c4a4cd74185c4

Initialize 'imm' on opcodes/aarch64-opc.c:expand_fp_imm (and fix breakage on mingw)

Hi,

While compiling GDB using a mingw compiler from Fedora 26:

  ../gdb/configure --host=x86_64-w64-mingw32 --target=x86_64-w64-mingw32 \
    --disable-binutils --disable-ld --disable-gold --disable-gas --disable-sim \
    --disable-gprof  --enable-targets=all

I stumbled upon a simple occurrence of -Werror=maybe-uninitialized:

  ../../gdb/opcodes/aarch64-opc.c: In function 'expand_fp_imm':
  ../../gdb/opcodes/aarch64-opc.c:2880:10: error: 'imm' may be used uninitialized in this function [-Werror=maybe-uninitialized]
     return imm;
	    ^~~

It is the compiler's fault, because this function always assigns to
'imm' if the necessary conditions are met, and it calls "assert (0)"
otherwise, but I thought it'd be clearer to have 'imm' explicitly set
to zero anyway.

opcodes/ChangeLog:
2017-09-21  Sergio Durigan Junior  <sergiodj@redhat.com>

	* aarch64-opc.c (expand_fp_imm): Initialize 'imm'.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR22197, buffer overflow in bfd_get_debug_link_info_1
@ 2017-09-24 12:59 sergiodj+buildbot
  2017-09-24 19:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-24 12:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 52b36c51e5bf6d7600fdc6ba115b170b0e78e31d ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 52b36c51e5bf6d7600fdc6ba115b170b0e78e31d

PR22197, buffer overflow in bfd_get_debug_link_info_1

	PR 22197
	* opncls.c (bfd_get_debug_link_info_1): Properly check that crc is
	within section bounds.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR22191, memory leak in dwarf2.c
@ 2017-09-24 12:42 sergiodj+buildbot
  2017-09-24 17:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-24 12:42 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT a26a013f22a19e2c16729e64f40ef8a7dfcc086e ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: a26a013f22a19e2c16729e64f40ef8a7dfcc086e

PR22191, memory leak in dwarf2.c

table->sequences is a linked list before it is replaced by a bfd_alloc
array in sort_line_sequences.

	PR 22191
	* dwarf2.c (decode_line_info): Properly free line sequences on error.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR22186, divide-by-zero in decode_line_info
@ 2017-09-24  8:28 sergiodj+buildbot
  2017-09-24 11:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-24  8:28 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d8010d3e75ec7194a4703774090b27486b742d48 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: d8010d3e75ec7194a4703774090b27486b742d48

PR22186, divide-by-zero in decode_line_info

	PR 22186
	* dwarf2.c (decode_line_info): Fail on lh.line_range of zero
	rather than dividing by zero.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR22169, heap-based buffer overflow in read_1_byte
@ 2017-09-24  8:08 sergiodj+buildbot
  2017-09-24 10:00 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-24  8:08 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 515f23e63c0074ab531bc954f84ca40c6281a724 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 515f23e63c0074ab531bc954f84ca40c6281a724

PR22169, heap-based buffer overflow in read_1_byte

The .debug_line header length field doesn't include the length field
itself, ie. it's the size of the rest of .debug_line.

	PR 22169
	* dwarf2.c (decode_line_info): Correct .debug_line unit_length check.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR22166, SHT_GNU_verneed memory allocation
@ 2017-09-24  7:15 sergiodj+buildbot
  2017-09-24  7:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-24  7:15 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bd61e135492ecf624880e6b78e5fcde3c9716df6 ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: bd61e135492ecf624880e6b78e5fcde3c9716df6

PR22166, SHT_GNU_verneed memory allocation

The sanity check covers the previous minimim size, plus that the size
is at least enough for sh_info verneed entries.

Also, since we write all verneed fields or exit with an error, there
isn't any need to zero the memory allocated for verneed entries.

	PR 22166
	* elf.c (_bfd_elf_slurp_version_tables): Test sh_info on
	SHT_GNU_verneed section for sanity.  Don't zalloc memory for
	verref.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Removed unused declaration
@ 2017-09-23 21:05 sergiodj+buildbot
  2017-09-23 21:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-23 21:05 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b4a7c699688bd88313893cbb59ee0df5b8cd009b ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: b4a7c699688bd88313893cbb59ee0df5b8cd009b

Removed unused declaration

An earlier patch of mine removed make_cleanup_override_quit_handler,
but neglected to remove the declaration.  This patch removes it.
Tested by rebuilding.  I'm committing this as obvious.

ChangeLog
2017-09-23  Tom Tromey  <tom@tromey.com>

	* defs.h (make_cleanup_override_quit_handler): Don't declare.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Change type of scoped_input_handler::m_quit_handler
@ 2017-09-22 22:17 sergiodj+buildbot
  2017-09-23  2:06 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-22 22:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c2f97536b77f9d9531a1a2c37008b454eb67a82e ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: c2f97536b77f9d9531a1a2c37008b454eb67a82e

Change type of scoped_input_handler::m_quit_handler

Simon pointed out that scoped_input_handler::m_quit_handler must have
the correct scoped_restore_tmpl type, to avoid binding to a temporary.
This patch fixes the problem.

gdb/ChangeLog
2017-09-22  Tom Tromey  <tom@tromey.com>

	* utils.c (class scoped_input_handler) <m_quit_handler>: Change
	type to scoped_restore_tmpl.
	<scoped_input_handler>: Initialize m_quit_handler directly.

Reviewed-By: Pedro Alves <palves@redhat.com>


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: Guard against corrupted PLT
@ 2017-09-22 21:41 sergiodj+buildbot
  2017-09-22 23:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-22 21:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 61e3bf5f83f7e505b6bc51ef65426e5b31e6e360 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: 61e3bf5f83f7e505b6bc51ef65426e5b31e6e360

x86: Guard against corrupted PLT

There should be only one entry in PLT for a given symbol.  Set howto to
NULL after processing a PLT entry to guard against corrupted PLT so that
the duplicated PLT entries are skipped.

	PR binutils/22170
	* elfxx-x86.c (_bfd_x86_elf_get_synthetic_symtab): Guard against
	corrupted PLT.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Get rid of "gdb_dirbuf" and use "getcwd (NULL, 0)"
@ 2017-09-22 18:25 sergiodj+buildbot
  2017-09-22 20:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-22 18:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 43573013c9836f2b91b74b9b29dac35fdb41e06b ***

Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: 43573013c9836f2b91b74b9b29dac35fdb41e06b

Get rid of "gdb_dirbuf" and use "getcwd (NULL, 0)"

Currently we have "current_directory" and "gdb_dirbuf" globals, which
means that we basically have two possible places to consult when we
want to know GDB's current working directory.

This is not ideal and can lead to confusion.  Moreover, the way we're
using "gdb_difbuf" along with "getcwd" is problematic because we
declare the buffer with "1024" elements hardcoded, which does not take
into account longer pathnames that are possible in many filesystems.
Using "PATH_MAX" would also not be a solution because of portability
problems.  Therefore, the best solution is to rely on the fact that
"getcwd (NULL, 0)" will "do the right thing" and return a
heap-allocated string containing the full path.  With the new "getcwd"
module from gnulib, it is now possible to do that without worrying
about breaking some host.

With this patch "current_directory" is now the only place to check for
GDB's cwd.

Reviewed-by: Pedro Alves <palves@redhat.com>

gdb/ChangeLog:
2017-09-22  Sergio Durigan Junior  <sergiodj@redhat.com>

	* cli/cli-cmds.c (pwd_command): Use "getcwd (NULL, 0)".
	(cd_command): Likewise.  Free "current_directory" before
	assigning to it.
	* main.c (captured_main_1): Use "getcwd (NULL, 0)".
	* mi/mi-cmd-env.c (mi_cmd_env_pwd): Likewise.
	* top.c (gdb_dirbuf): Remove global declaration.
	* top.h (gdb_dirbuf): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdbserver x86 on win32: call init_target_desc
@ 2017-09-22 15:58 sergiodj+buildbot
  2017-09-22 18:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-22 15:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cc4d742f4ce05bf933397a513b953c0feeae0663 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: cc4d742f4ce05bf933397a513b953c0feeae0663

gdbserver x86 on win32: call init_target_desc

When trying to run gdbserver compiled for x86 win32 under wine, I get:

  $ wine ./gdbserver/gdbserver.exe --once :1234 ./test
  /home/emaisin/src/binutils-gdb/gdb/gdbserver/regcache.c:177: A problem internal to GDBserver has been detected.
  regcache* new_register_cache(const target_desc*): Assertion `tdesc->registers_size != 0' failed.

It seems like on that platform, init_target_desc is never called, so
registers_size is never computed.

My first thought was to call init_target_desc somewhere in win32-low.c,
but it turns out that when using win32 on arm, the target description is
already initialized by the generated code.  My second thought was to
call it in {i386,amd64}_create_target_description, but those functions
are shared with GDB, and init_target_desc is gdbserver-specific.  So I
ended up with the simplest fix, calling it in i386_arch_setup.

Now I hit some other problem:

  $ wine ./gdbserver/gdbserver.exe --once :1234 ./test
  Killing process(es): 39
  No program to debug
  Exiting

but still, I think fixing the tdesc issue this is a step forward.

gdb/gdbserver/ChangeLog:

	* win32-i386-low.c (i386_arch_setup): Call init_target_desc.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] x86: Return -1 if bfd_canonicalize_dynamic_reloc returns 0
@ 2017-09-22 15:29 sergiodj+buildbot
  2017-09-22 17:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-22 15:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b69e9267d15a09ce3f3d4599eae2952dfc6df502 ***

Author: H.J. Lu <hjl.tools@gmail.com>
Branch: master
Commit: b69e9267d15a09ce3f3d4599eae2952dfc6df502

x86: Return -1 if bfd_canonicalize_dynamic_reloc returns 0

Stop if bfd_canonicalize_dynamic_reloc returns 0.

	PR ld/22163
	* elfxx-x86.c (_bfd_x86_elf_get_synthetic_symtab): Also return
	-1 if bfd_canonicalize_dynamic_reloc returns 0.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Fix sometimes-uninitialized warning in gdbscm_value_address
@ 2017-09-22 14:18 sergiodj+buildbot
  2017-09-22 14:38 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-22 14:18 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 432ae719d35c81324e01ae6bd9970cc43e69fa5e ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 432ae719d35c81324e01ae6bd9970cc43e69fa5e

Fix sometimes-uninitialized warning in gdbscm_value_address

I am getting this warning with clang:

/home/emaisin/src/binutils-gdb/gdb/guile/scm-value.c:439:11: error: variable 'address' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
      if (res_val != NULL)
          ^~~~~~~~~~~~~~~
/home/emaisin/src/binutils-gdb/gdb/guile/scm-value.c:444:32: note: uninitialized use occurs here
      if (gdbscm_is_exception (address))
                               ^~~~~~~
/home/emaisin/src/binutils-gdb/gdb/guile/scm-value.c:439:7: note: remove the 'if' if its condition is always true
      if (res_val != NULL)
      ^~~~~~~~~~~~~~~~~~~~
/home/emaisin/src/binutils-gdb/gdb/guile/scm-value.c:427:18: note: initialize the variable 'address' to silence this warning
      SCM address;
                 ^
                  = nullptr

We can get rid of it with a small refactoring.  I think it's a bit
cleaner/safer to initialize address with a pessimistic value and assign
it on success.  Then there's no chance of using it uninitialized.  If I
understand correctly, the NULL check on res_val was to check whether
value_addr threw, and that if value_addr returns without throwing, the
result will never be NULL.  If that's true, we can skip the res_val
variable.

Tested by running gdb.guile/*.exp locally.

gdb/ChangeLog:

	* guile/scm-value.c (gdbscm_value_address): Initialize address,
	get rid of res_val.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Test case for Inferior.thread_from_thread_handle
@ 2017-09-21 20:48 sergiodj+buildbot
  2017-09-22  4:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-21 20:48 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 757bf54bb48a8417154cfdd7128c1775d43478d8 ***

Author: Kevin Buettner <kevinb@redhat.com>
Branch: master
Commit: 757bf54bb48a8417154cfdd7128c1775d43478d8

Test case for Inferior.thread_from_thread_handle

As the title says, this is a test case for
Inferior.thread_from_thread_handle, a python method which will,
given a thread library dependent thread handle, find the GDB thread
which corresponds to that thread handle (in the inferior under
consideration).

The C file for this test case causes the thread handles for the
main thread and two child threads to be placed into an array.  The
test case runs to one of the functions (do_something()) at which point,
it retrieves the thread handles from the array and attempts to find the
corresponding thread in GDB's internal thread list.

I use barriers to make sure that both threads have actually started;
execution will stop when one of the threads breaks at do_something.

Thanks to Simon Marchi for suggestions for forcing the thread
numbering to be stable.

gdb/testsuite/ChangeLog:

	* gdb.python/py-thrhandle.c, gdb.python/py-thrhandle.exp: New
	files.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add thread_handle_to_thread_info support for remote targets
@ 2017-09-21 20:24 sergiodj+buildbot
  2017-09-22  0:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-21 20:24 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f6327dcbf0bc91bb9d99e12232d2b1a2f959fce6 ***

Author: Kevin Buettner <kevinb@redhat.com>
Branch: master
Commit: f6327dcbf0bc91bb9d99e12232d2b1a2f959fce6

Add thread_handle_to_thread_info support for remote targets

This patch adds support to remote targets for converting a thread
handle to a thread_info struct pointer.

A thread handle is fetched via a "handle" attribute which has been
added to the qXfer:threads:read query packet.  An implementation is
provided in gdbserver for targets using the Linux kernel.

gdb/gdbserver/ChangeLog:

	* linux-low.h (struct lwp_info): Add new field, thread_handle.
	(thread_db_thread_handle): Declare.
	* linux-low.c (linux_target_ops): Initialize thread_handle.
	* server.c (handle_qxfer_threads_worker): Add support for
	"handle" attribute.
	* target.h (struct target_ops): Add new function pointer,
	thread_handle.
	(target_thread_handle): Define.
	* thread-db.c (find_one_thread, attach_thread): Set thread_handle
	field in lwp.
	(thread_db_thread_handle): New function.

gdb/ChangeLog:

	* remote.c (vector): Include.
	(struct private_thread_info): Add field, thread_handle.
	(free_private_thread_info): Deallocate storage associated with
	thread handle.
	(get_private_info_thread): Initialize `thread_handle' field.
	(struct thread_item): Add field, thread_handle.
	(clear_threads_listing_context): Deallocate storage associated
	with thread handle.
	(start_thread): Add support for "handle" attribute.
	(thread_attributes): Add "handle".
	(remote_get_threads_with_qthreadinfo): Initialize thread_handle
	field.
	(remote_update_thread_list): Update thread_handle.
	(remote_thread_handle_to_thread_info): New function.
	(init_remote_ops): Initialize to_thread_handle_to_thread_info.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add thread_db_notice_clone to gdbserver
@ 2017-09-21 20:08 sergiodj+buildbot
  2017-09-21 22:06 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-21 20:08 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8629910955a751a93f2f12389ff1f497556cc260 ***

Author: Kevin Buettner <kevinb@redhat.com>
Branch: master
Commit: 8629910955a751a93f2f12389ff1f497556cc260

Add thread_db_notice_clone to gdbserver

While working on a patch for fetching a thread handle in gdbserver, I
ran into a circumstance in which tests in gdb.mi/mi-nsmoribund.exp
would occasionally fail.  Over a large enough number of runs, it would
fail roughly 2% of the time.

That thread handle patch caused find_one_thread() to be called on
every stop.  find_one_thread() calls td_ta_map_lwp2thr() which, in
turn, can cause ps_get_thread_area() to be called.
ps_get_thread_area() makes a call to ptrace() for getting the thread
area address.  If this should happen when the thread is not stopped,
the call to ptrace will return error which in turn propogates back to
find_one_thread().  find_one_thread() calls error() in this instance
which causes the program to die.

This patch causes find_one_thread() to be called upon reciept of a
clone event.  Since the clone is stopped, the circumstances described
above cannot occur.

gdb/gdbserver/ChangeLog:

	* linux-low.c (handle_extended_wait): Call thread_db_notice_clone().
	* linux-low.h (thread_db_notice_clone): Declare.
	* thread-db.c (thread_db_notice_clone): New function.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add target method for converting thread handle to thread_info struct pointer
@ 2017-09-21 19:14 sergiodj+buildbot
  2017-09-21 19:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-21 19:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e04ee09e24563f013c35cdebd7e9de3092b99b83 ***

Author: Kevin Buettner <kevinb@redhat.com>
Branch: master
Commit: e04ee09e24563f013c35cdebd7e9de3092b99b83

Add target method for converting thread handle to thread_info struct pointer

This patch adds a target method named `to_thread_handle_to_thread_info'.
It is intended to map a thread library specific thread handle (such as
pthread_t for the pthread library) to the corresponding GDB internal
thread_info struct (pointer).

An implementation is provided for Linux pthreads; see linux-thread-db.c.

gdb/ChangeLog:

	* target.h (struct target_ops): Add to_thread_handle_to_thread_info.
	(target_thread_handle_to_thread_info): Declare.
	* target.c (target_thread_handle_to_thread_info): New function.
	* target-delegates.c: Regenerate.
	* gdbthread.h (find_thread_by_handle): Declare.
	* thread.c (find_thread_by_handle): New function.
	* linux-thread-db.c (thread_db_thread_handle_to_thread_info): New
	function.
	(init_thread_db_ops): Register thread_db_thread_handle_to_thread_info.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] S/390: Fix Elf note swap s390_gs_bc vs. s390_gs_cb
@ 2017-09-21 16:21 sergiodj+buildbot
  2017-09-21 16:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-21 16:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8fe09d7421db51bc13c9228547d63e6315bd6bd0 ***

Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: 8fe09d7421db51bc13c9228547d63e6315bd6bd0

S/390: Fix Elf note swap s390_gs_bc vs. s390_gs_cb

Fix two typos that resulted in swapping the BFD names for the core note
register sections NT_S390_GS_CB and NT_S390_GS_BC.

bfd/ChangeLog:

	* elf.c (elfcore_grok_note): For the cases NT_S390_GS_CB and
	NT_S390_GS_BC, correct the previously swapped invocations of
	elfcore_grok_s390_gs_bc and elfcore_grok_s390_gs_cb.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] linux-waitpid: Get rid of format string warning
@ 2017-09-21 13:51 sergiodj+buildbot
  2017-09-21 16:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-21 13:51 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1e5b66ed4285ecf063e7801a46178ebb0ce5be41 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 1e5b66ed4285ecf063e7801a46178ebb0ce5be41

linux-waitpid: Get rid of format string warning

Clang gives this warning:

/home/emaisin/src/binutils-gdb/gdb/gdbserver/../nat/linux-waitpid.c:45:25: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
      vfprintf (stderr, format, args);
                        ^~~~~~

Get rid of it by adding ATTRIBUTE_PRINTF.

gdb/ChangeLog:

	* nat/linux-waitpid.c (linux_debug): Add ATTRIBUTE_PRINTF.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] microblaze-tdep: Add ATTRIBUTE_PRINTF to microblaze_debug
@ 2017-09-21 12:52 sergiodj+buildbot
  2017-09-21 13:11 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-21 12:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ebe48ba0856dcccaa7a60d873c61e6f1f96f5887 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: ebe48ba0856dcccaa7a60d873c61e6f1f96f5887

microblaze-tdep: Add ATTRIBUTE_PRINTF to microblaze_debug

I am getting this warning with clang:

/home/emaisin/src/binutils-gdb/gdb/microblaze-tdep.c:94:28: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
       vprintf_unfiltered (fmt, args);
                           ^~~

Adding ATTRIBUTE_PRINTF to microblaze_debug gets rid of it.  Strangely,
gcc doesn't warn about non-literal format strings when calling vprintf
(or a vprintf-style function, like vprintf_unfiltered).  I filed this
gcc bug:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82206

gdb/ChangeLog:

	* microblaze-tdep.c (microblaze_debug): Add ATTRIBUTE_PRINTF.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] [SIM, ARM] Fix build failure
@ 2017-09-21  8:31 sergiodj+buildbot
  2017-09-21  9:10 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-21  8:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 88240b186d224d634633d9996832f1235364b6d4 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 88240b186d224d634633d9996832f1235364b6d4

[SIM, ARM] Fix build failure

This patch fixes the build failure by using disassembler to get
disassemble function pointer, and do the disassembly, because
print_insn_little_arm is no longer visible outside opcodes/

binutils-gdb/sim/arm/wrapper.c:98:10: error: implicit declaration of function 'print_insn_little_arm' [-Werror=implicit-function-declaration]
   size = print_insn_little_arm (0, & info);
          ^

sim/arm:

2017-09-21  Yao Qi  <yao.qi@linaro.org>

	* wrapper.c (print_insn): Use disassembler instead of
	print_insn_little_arm.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Allocate bpstats with new
@ 2017-09-21  5:09 sergiodj+buildbot
  2017-09-21  5:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-21  5:09 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 04afa70c8e1c931dd44db76eb9f0ddd4949ed00c ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 04afa70c8e1c931dd44db76eb9f0ddd4949ed00c

Allocate bpstats with new

This changes struct bpstats to be allocated with new and freed with
delete, adding constructors and a destructor in the process.  This
allows the removal of one cleanup and clears the way for more to
follow.

gdb/ChangeLog
2017-09-20  Tom Tromey  <tom@tromey.com>

	* breakpoint.c (~bpstats): Rename from bpstat_free.  Update.
	(bpstat_clear): Use delete.
	(bpstats): New constructors.
	(bpstat_copy, bpstat_stop_status): Use new.
	(dprintf_after_condition_true): Update.
	* breakpoint.h (bpstats::bpstats): Add constructors.
	(bpstats::~bpstats): Add destructor.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] eval.c:evaluate_subexp_standard: Use RAII to avoid leaks
@ 2017-09-21  0:06 sergiodj+buildbot
  2017-09-21  4:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-21  0:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c83833f49353e1fe7fa727291210be751161ade1 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: c83833f49353e1fe7fa727291210be751161ade1

eval.c:evaluate_subexp_standard: Use RAII to avoid leaks

While working on the no-debug-info debugging improvements series, I
noticed these bare xfree calls, which lead to leaks if
evaluate_subexp_standard throws.

Fix that by reworking make_params as a RAII class.  Ends up
eliminating a couple heap allocations too.

gdb/ChangeLog:
2017-09-20  Pedro Alves  <palves@redhat.com>

	* eval.c (make_params): Delete, refactored as ...
	(class fake_method): ... this new type's ctor.
	(fake_method::~fake_method): New.
	(evaluate_subexp_standard): Use 'fake_method'.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Overload catch_command_errors
@ 2017-09-20 22:31 sergiodj+buildbot
  2017-09-20 22:56 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-20 22:31 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 013af3fc8eba48d081f0e83303cd800097e5b7a8 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 013af3fc8eba48d081f0e83303cd800097e5b7a8

Overload catch_command_errors

This changes catch_command_errors_const to be an overload of
catch_command_errors, which may mildly help future constification
efforts.

Tested by rebuilding.

gdb/ChangeLog
2017-09-20  Tom Tromey  <tom@tromey.com>

	* main.c (catch_command_errors): Rename from
	catch_command_errors_const.
	(captured_main_1): Update.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdb - avx512: tests were failing due to missing memory aligment.
@ 2017-09-20 14:10 sergiodj+buildbot
  2017-09-20 14:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-20 14:10 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6470a84860b11ba6e7258604ae78f047a1af2f5d ***

Author: Walfred Tedeschi <walfred.tedeschi@intel.com>
Branch: master
Commit: 6470a84860b11ba6e7258604ae78f047a1af2f5d

gdb - avx512: tests were failing due to missing memory aligment.

Test was running on a fault during code execution.  Analysis have shown
that the wrong instruction had been used.  An instruction that takes
not alligned memory is more appropriated for the task.

ChangeLog:

2017-09-20  Walfred Tedeschi  <walfred.tedeschi@intel.com>

gdb/testesuite/ChangeLog:
	* gdb.arch/i386-avx512.c (move_zmm_data_to_reg): Use
	vmovups instead vmovaps.
	(move_zmm_data_to_memory): Use vmovups instead vmovaps.

Change-Id: I4a95560861ef1792ed6ce86578fdd726162863f1


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add a 'starti' command.
@ 2017-09-19 19:46 sergiodj+buildbot
  2017-09-19 20:18 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-19 19:46 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4e5a4f5850487740eb7549f1d0b8625ce577faab ***

Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: 4e5a4f5850487740eb7549f1d0b8625ce577faab

Add a 'starti' command.

This works like 'start' but it stops at the first instruction rather
than the first line in main().  This is useful if one wants to single
step through runtime linker startup.

While here, introduce a RUN_ARGS_HELP macro for shared help text
between run, start, and starti.  This includes expanding the help for
start and starti to include details from run's help text.

gdb/ChangeLog:

	* NEWS (Changes since GDB 8.0): Add starti.
	* infcmd.c (enum run_break): New.
	(run_command_1): Queue pending event for RUN_STOP_AT_FIRST_INSN
	case.
	(run_command): Use enum run_how.
	(start_command): Likewise.
	(starti_command): New function.
	(RUN_ARGS_HELP): New macro.
	(_initialize_infcmd): Use RUN_ARGS_HELP for run and start
	commands.  Add starti command.

gdb/doc/ChangeLog:

	* gdb.texinfo (Starting your Program): Add description of
	starti command.  Mention starti command as an alternative for
	debugging the elaboration phase.

gdb/testsuite/ChangeLog:

	* gdb.base/starti.c: New file.
	* gdb.base/starti.exp: New file.
	* lib/gdb.exp (gdb_starti_cmd): New procedure.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] PR22150, ld keeps a version reference for gc'd symbols
@ 2017-09-19  5:56 sergiodj+buildbot
  2017-09-19  6:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-19  5:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3d13f3e9bda5aada68915f5d958f731ae79ed41d ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 3d13f3e9bda5aada68915f5d958f731ae79ed41d

PR22150, ld keeps a version reference for gc'd symbols

elf_gc_sweep_symbol should run after verdefs are calculated, since
the verdef code creates symbols for the versions.  However,
elf_gc_sweep_symbol needs to run before verrefs so as to not emit
useless verrefs for symbols that are gc'd.

I've also removed a _bfd_elf_link_renumber_dynsyms calls added by
Maciej after I fussed about it when reviewing.  On further examination
the call appears to be unnecessary.  Looking at renumber_dynsyms also
made me realize that the test to exclude .gnu.version has been wrong
since 2016-04-26 (git commit d5486c4372), so fix that too.

	PR 22150
	* elflink.c (bfd_elf_size_dynamic_sections): Garbage collect
	symbols before calculating verrefs.  Don't renumber dynsyms
	after gc.  Exclude .gnu.version when zero or one dynsym.
	Localize some vars and reindent.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Make xml_escape_text return an std::string
@ 2017-09-16 14:50 sergiodj+buildbot
  2017-09-16 17:49 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-16 14:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5e1875543df7413d3cbc3831390445e347064b75 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 5e1875543df7413d3cbc3831390445e347064b75

Make xml_escape_text return an std::string

This is a simple replacement, it allows removing some manual free'ing in
the callers.

gdb/ChangeLog:

	* common/buffer.c (buffer_xml_printf): Adjust.
	* common/xml-utils.c (xml_escape_text): Change return type to
	std::string, update code accordingly.
	* common/xml-utils.h (xml_escape_text): Change return type to
	std::string.
	* rs6000-aix-tdep.c (rs6000_aix_shared_library_to_xml): Adjust.
	* windows-tdep.c (windows_xfer_shared_library): Adjust.
	* unittests/xml-utils-selftests.c (test_xml_escape_text):
	Adjust.

gdb/gdbserver/ChangeLog:

	* linux-low.c (linux_qxfer_libraries_svr4): Adjust to change of
	return type of xml_escape_text.
	* server.c (emit_dll_description): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Refactor handle_qxfer_libraries and friends to use std::string
@ 2017-09-16 14:26 sergiodj+buildbot
  2017-09-17  4:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-16 14:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 04fd3ba9b63936653fff2b1657b3824c94a8efd6 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 04fd3ba9b63936653fff2b1657b3824c94a8efd6

Refactor handle_qxfer_libraries and friends to use std::string

Using std::string in handle_qxfer_libraries and friends allow to
simplify the code.  We don't have to manually free the buffer, and we
don't have to pre-compute the required space.

gdb/gdbserver/ChangeLog:

	* server.c (accumulate_file_name_length): Remove.
	(emit_dll_description): Adjust to std::string change.
	(handle_qxfer_libraries): Use std::string to hold document.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add unit test for xml_escape_text
@ 2017-09-16 13:24 sergiodj+buildbot
  2017-09-16 16:14 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-16 13:24 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c3d7b541fa920e6ecb0f06ffe1e0e3f070fa295d ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: c3d7b541fa920e6ecb0f06ffe1e0e3f070fa295d

Add unit test for xml_escape_text

The following patch modifies xml_escape_text, so I took the opportunity
to write a unit test for it.

gdb/ChangeLog:

	* Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new source file.
	(SUBDIR_UNITTESTS_OBS): Add new object file.
	* unittests/xml-utils-selftests.c: New file.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add selftests run filtering
@ 2017-09-16 13:01 sergiodj+buildbot
  2017-09-16 14:50 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-16 13:01 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1526853e34c063bef25bd7d0eb15c1449c28e999 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 1526853e34c063bef25bd7d0eb15c1449c28e999

Add selftests run filtering

With the growing number of selftests, I think it would be useful to be
able to run only a subset of the tests.  This patch associates a name to
each registered selftest.  It then allows doing something like:

  (gdb) maintenance selftest aarch64
  Running self-tests.
  Running selftest aarch64-analyze-prologue.
  Running selftest aarch64-process-record.
  Ran 2 unit tests, 0 failed

or with gdbserver:

  ./gdbserver --selftest=aarch64

In both cases, only the tests that contain "aarch64" in their name are
ran.  To help validate that the tests you want to run were actually ran,
it also prints a message with the test name before running each test.

Right now, all the arch-dependent tests are registered as a single test
of the selftests.  To be able to filter those too, I made them
"first-class citizen" selftests.  The selftest type is an interface,
with different implementations for "simple selftests" and "arch
selftests".  The run_tests function simply iterates on that an invokes
operator() on each test.

I changed the tests data structure from a vector to a map, because

  - it allows iterating in a stable (alphabetical) order
  - it allows to easily verify if a test with a given name has been
    registered, to avoid duplicates

There's also a new command "maintenance info selftests" that lists the
registered selftests.

gdb/ChangeLog:

	* common/selftest.h (selftest): New struct/interface.
	(register_test): Add name parameter, add new overload.
	(run_tests): Add filter parameter.
	(for_each_selftest_ftype): New typedef.
	(for_each_selftest): New declaration.
	* common/selftest.c (tests): Change type to
	map<string, unique_ptr<selftest>>.
	(simple_selftest): New struct.
	(register_test): New function.
	(register_test): Add name parameter and use it.
	(run_tests): Add filter parameter and use it.  Add prints.
	Adjust to vector -> map change.
	* aarch64-tdep.c (_initialize_aarch64_tdep): Add names when
	registering selftests.
	* arm-tdep.c (_initialize_arm_tdep): Likewise.
	* disasm-selftests.c (_initialize_disasm_selftests): Likewise.
	* dwarf2-frame.c (_initialize_dwarf2_frame): Likewise.
	* dwarf2loc.c (_initialize_dwarf2loc): Likewise.
	* findvar.c (_initialize_findvar): Likewise.
	* gdbarch-selftests.c (_initialize_gdbarch_selftests): Likewise.
	* maint.c (maintenance_selftest): Update call to run_tests.
	(maintenance_info_selftests): New function.
	(_initialize_maint_cmds): Register "maintenance info selftests"
	command.  Update "maintenance selftest" doc.
	* regcache.c (_initialize_regcache): Add names when registering
	selftests.
	* rust-exp.y (_initialize_rust_exp): Likewise.
	* selftest-arch.c (gdbarch_selftest): New struct.
	(gdbarch_tests): Remove.
	(register_test_foreach_arch): Add name parameter.  Call
	register_test.
	(tests_with_arch): Remove, move most content to
	gdbarch_selftest::operator().
	(_initialize_selftests_foreach_arch): Remove.
	* selftest-arch.h (register_test_foreach_arch): Add name
	parameter.
	(run_tests_with_arch): New declaration.
	* utils-selftests.c (_initialize_utils_selftests): Add names
	when registering selftests.
	* utils.c (_initialize_utils): Likewise.
	* unittests/array-view-selftests.c
	(_initialize_array_view_selftests): Likewise.
	* unittests/environ-selftests.c (_initialize_environ_selftests):
	Likewise.
	* unittests/function-view-selftests.c
	(_initialize_function_view_selftests): Likewise.
	* unittests/offset-type-selftests.c
	(_initialize_offset_type_selftests): Likewise.
	* unittests/optional-selftests.c
	(_initialize_optional_selftests): Likewise.
	* unittests/scoped_restore-selftests.c
	(_initialize_scoped_restore_selftests): Likewise.
	* NEWS: Document "maintenance selftest" and "maint info
	selftests".

gdb/gdbserver/ChangeLog:

	* server.c (captured_main): Accept argument for --selftest.
	Update run_tests call.
	* linux-x86-tdesc-selftest.c (initialize_low_tdesc): Add names
	when registering selftests.

gdb/doc/ChangeLog:

	* gdb.texinfo (Maintenance Commands): Document filter parameter
	of "maint selftest".  Document "maint info selftests" command.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] mi_load_progress: Use unique_ptr to manage ui_out lifetime
@ 2017-09-16 12:13 sergiodj+buildbot
  2017-09-16 12:29 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-16 12:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bd77e8ff276864d6622f2433b8a499bf4332fa65 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: bd77e8ff276864d6622f2433b8a499bf4332fa65

mi_load_progress: Use unique_ptr to manage ui_out lifetime

In mi_load_progress, we xfree a ui_out object.  Because ui_out is not
trivially destructible, it should be freed with delete.  This patch
makes use of a unique_ptr to do it.

gdb/ChangeLog:

	* mi/mi-main.c (mi_load_progress): Make uiout variable
	a unique_ptr.

diff --git a/gdb/mi/mi-main.c b/gdb/mi/mi-main.c index 0ee2605..0359dc1
100644 --- a/gdb/mi/mi-main.c +++ b/gdb/mi/mi-main.c @@ -2325,7 +2325,6
@@ mi_load_progress (const char *section_name, static char
*previous_sect_name = NULL; int new_section; struct ui_out *saved_uiout;
-  struct ui_out *uiout; struct mi_interp *mi = (struct mi_interp *)
   current_interpreter ();

   /* This function is called through deprecated_show_load_progress
@@ -2333,17 +2332,19 @@ mi_load_progress (const char *section_name,
      of this function.  */
   saved_uiout = current_uiout;

+  std::unique_ptr<ui_out> uiout;
+
   if (current_interp_named_p (INTERP_MI)
       || current_interp_named_p (INTERP_MI2))
-    current_uiout = mi_out_new (2);
+    uiout.reset (mi_out_new (2));
   else if (current_interp_named_p (INTERP_MI1))
-    current_uiout = mi_out_new (1);
+    uiout.reset (mi_out_new (1));
   else if (current_interp_named_p (INTERP_MI3))
-    current_uiout = mi_out_new (3);
+    uiout.reset (mi_out_new (3));
   else
     return;

-  uiout = current_uiout;
+  current_uiout = uiout.get ();

   new_section = (previous_sect_name ?
 		 strcmp (previous_sect_name, section_name) : 1);
@@ -2356,12 +2357,12 @@ mi_load_progress (const char *section_name,
 	fputs_unfiltered (current_token, mi->raw_stdout);
       fputs_unfiltered ("+download", mi->raw_stdout);
       {
-	ui_out_emit_tuple tuple_emitter (uiout, NULL);
+	ui_out_emit_tuple tuple_emitter (uiout.get (), NULL);
 	uiout->field_string ("section", section_name);
 	uiout->field_int ("section-size", total_section);
 	uiout->field_int ("total-size", grand_total);
       }
-      mi_out_put (uiout, mi->raw_stdout);
+      mi_out_put (uiout.get (), mi->raw_stdout);
       fputs_unfiltered ("\n", mi->raw_stdout);
       gdb_flush (mi->raw_stdout);
     }
@@ -2374,19 +2375,18 @@ mi_load_progress (const char *section_name,
 	fputs_unfiltered (current_token, mi->raw_stdout);
       fputs_unfiltered ("+download", mi->raw_stdout);
       {
-	ui_out_emit_tuple tuple_emitter (uiout, NULL);
+	ui_out_emit_tuple tuple_emitter (uiout.get (), NULL);
 	uiout->field_string ("section", section_name);
 	uiout->field_int ("section-sent", sent_so_far);
 	uiout->field_int ("section-size", total_section);
 	uiout->field_int ("total-sent", total_sent);
 	uiout->field_int ("total-size", grand_total);
       }
-      mi_out_put (uiout, mi->raw_stdout);
+      mi_out_put (uiout.get (), mi->raw_stdout);
       fputs_unfiltered ("\n", mi->raw_stdout);
       gdb_flush (mi->raw_stdout);
     }

-  xfree (uiout);
   current_uiout = saved_uiout;
 }


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Sync libiberty/ & include/ with GCC
@ 2017-09-15 19:36 sergiodj+buildbot
  2017-09-16  2:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-15 19:36 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 26a67918a501370a8fe62db18a74761a0073016f ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 26a67918a501370a8fe62db18a74761a0073016f

Sync libiberty/ & include/ with GCC

Note this brings in the interface files for libcc1/G++ as well, which
we will be needing in GDB soon anyway.  That commit renamed a method
in the C interface and that required a small update to GDB's compile/
code, which I've included that in this patch to keep the tree
building.

include/ChangeLog:
2017-09-15  Pedro Alves  <palves@redhat.com>

	* ansidecl.h (DISABLE_COPY_AND_ASSIGN): New macro.

	2017-09-12  Jiong Wang  <jiong.wang@arm.com>

	* dwarf2.def (DW_CFA_AARCH64_negate_ra_state): New DW_CFA_DUP.
	* dwarf2.h (DW_CFA_DUP): New define.

	2017-08-21  Richard Biener  <rguenther@suse.de>

	* simple-object.h (simple_object_copy_lto_debug_sections): New
	function.

	2017-05-18  Martin Liska  <mliska@suse.cz>

	* ansidecl.h: Define CONSTEXPR macro.

	2017-05-24  Nathan Sidwell  <nathan@acm.org>

	* libiberty.h (ASTRDUP): Adjust cast to avoid warning.

	2017-01-30  Alexandre Oliva <aoliva@redhat.com>

	Introduce C++ support in libcc1.
	* gcc-c-fe.def (int_type_v0): Rename from...
	(int_type): ... this.  Introduce new version.
	(float_type_v0): Rename from...
	(float_type): ... this.  Introduce new version.
	(char_type): New.
	* gcc-c-interface.h (gcc_c_api_version): Add GCC_C_FE_VERSION_1.
	(gcc_type_array): Move...
	* gcc-interface.h: ... here.
	* gcc-cp-fe.def: New.
	* gcc-cp-interface.h: New.

	2016-04-29  Oleg Endo  <olegendo@gcc.gnu.org>

	* longlong.h (umul_ppmm): Remove SHMEDIA checks.
	(__umulsidi3, count_leading_zeros): Remove SHMEDIA implementations.

	2017-09-15  Yao Qi  <yao.qi@linaro.org>
	    Pedro Alves  <palves@redhat.com>

	* ansidecl.h (DISABLE_COPY_AND_ASSIGN): New macro.

	2017-09-12  Jiong Wang  <jiong.wang@arm.com>

	* dwarf2.def (DW_CFA_AARCH64_negate_ra_state): New DW_CFA_DUP.
	* dwarf2.h (DW_CFA_DUP): New define.

	2017-08-21  Richard Biener  <rguenther@suse.de>

	* simple-object.h (simple_object_copy_lto_debug_sections): New
	function.

	2017-05-18  Martin Liska  <mliska@suse.cz>

	* ansidecl.h: Define CONSTEXPR macro.

	2017-05-24  Nathan Sidwell  <nathan@acm.org>

	* libiberty.h (ASTRDUP): Adjust cast to avoid warning.

	2017-01-30  Alexandre Oliva <aoliva@redhat.com>

	Introduce C++ support in libcc1.
	* gcc-c-fe.def (int_type_v0): Rename from...
	(int_type): ... this.  Introduce new version.
	(float_type_v0): Rename from...
	(float_type): ... this.  Introduce new version.
	(char_type): New.
	* gcc-c-interface.h (gcc_c_api_version): Add GCC_C_FE_VERSION_1.
	(gcc_type_array): Move...
	* gcc-interface.h: ... here.
	* gcc-cp-fe.def: New.
	* gcc-cp-interface.h: New.

	2016-04-29  Oleg Endo  <olegendo@gcc.gnu.org>

	* longlong.h (umul_ppmm): Remove SHMEDIA checks.
	(__umulsidi3, count_leading_zeros): Remove SHMEDIA implementations.

libiberty/ChangeLog:
2017-09-15  Nathan Sidwell  <nathan@acm.org>

	PR demangler/82195
	* cp-demangle.c (d_name): Add 'toplevel' parm.  Pass to	...
	(d_local_name): ... here.  Parse trailing function args on nested
	local_name.
	(d_encoding, d_special_name, d_class_enum_type): Adjust d_name calls.
	* testsuite/demangle-expected: Add tests.

2017-09-15  Richard Biener  <rguenther@suse.de>

	PR lto/81968
	* simple-object-elf.c (simple_object_elf_copy_lto_debug_sections):
	Iterate marking dependent sections necessary.

2017-09-15  Nathan Sidwell  <nathan@acm.org>

	* cp-demangle.c (is_fnqual_component_type): Reimplement using
	FNQUAL_COMPONENT_CASE.
	(d_encoding): Hold bare_function_type in local var.
	(d_local_name): Build name in both cases and build result once.
	Collapse switch-if to single conditional.
	(d_local_name):

	* testsuite/demangle-expected: Realign blank lines with tests.

2017-09-12  Jiong Wang  <jiong.wang@arm.com>

	* dwarfnames.c (DW_CFA_DUP): New define.

gdb/ChangeLog:
2017-09-15  Pedro Alves  <palves@redhat.com>

	* compile/compile-c-types.c (convert_enum, convert_int)
	(convert_float): Adjust to refer to int_type_v0 and float_type_v0.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdbserver: Remove thread_to_gdb_id
@ 2017-09-15 18:45 sergiodj+buildbot
  2017-09-15 23:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-15 18:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 124aceb46dfd1f836f35d6075ead4e00e705f6f3 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 124aceb46dfd1f836f35d6075ead4e00e705f6f3

gdbserver: Remove thread_to_gdb_id

As explained in the previous patch, the gdb_id concept is no longer
relevant.  The function thread_to_gdb_id is trivial, it returns the
thread's ptid.  Remove it and replace its usage with ptid_of.

The changes in nto-low.c and lynx-low.c are fairly straightforward, but
I was not able to build test them.

gdb/gdbserver/ChangeLog:

	* inferiors.h (thread_to_gdb_id): Remove.
	* inferiors.c (thread_to_gdb_id): Remove.
	* server.c (handle_qxfer_threads_worker, handle_query): Adjust.
	* lynx-low.c (lynx_resume, lynx_wait_1, lynx_fetch_registers,
	lynx_store_registers, lynx_read_memory, lynx_write_memory):
	Likewise.
	* nto-low.c (nto_fetch_registers, nto_store_registers,
	nto_stopped_by_watchpoint, nto_stopped_data_address): Likewise.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdbserver: Remove gdb_id_to_thread_id
@ 2017-09-15 17:56 sergiodj+buildbot
  2017-09-15 21:30 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-15 17:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 96cde54f0adf2315404f3eba35dc3dfbc57f98c8 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 96cde54f0adf2315404f3eba35dc3dfbc57f98c8

gdbserver: Remove gdb_id_to_thread_id

>From what I understand, this function is not doing anything useful as of
today.

Here's the result of my archeological research:

- The field thread_info::gdb_id was added in

  a06660f7  Use LWP IDs for thread IDs in gdbserver

  There was problem when using a 32-bits gdb with a 64-bits gdbserver.
  For some reason that I don't fully understand, the thread ids
  exchanged between gdb and gdbserver could overflow a 32 bits data
  type.  My guess is that they were the thread address (e.g. the
  0x7ffff7f20b40 in "Thread 0x7ffff7f20b40 (LWP 1058)" today).  This
  patch changed that so gdb/gdbserver would talk in terms of the OS
  assigned numerical id (as shown in ps).  It therefore added a way to
  convert between this gdb_id (the numerical id) and the thread id (the
  address).

- 95954743cb  Implement the multiprocess extensions, and add linux
              multiprocess supportNon-stop mode support.

  This patch made gdbserver deal with threads using their numerical ids
  and not the address-like id.  Starting from there, the gdb_id <->
  thread id conversion was not needed anymore, since the remote protocol
  and gdbserver were using the same kind of ids again.  The gdb_id field
  in the thread_info structure was also unused starting there.

- d50171e4  Teach linux gdbserver to step-over-breakpoints.

  This patch moved the thread_info structure around, and got rid of the
  gdb_id field (which was unused).

Looking at the implementation of gdb_id_to_thread_id, it is not doing
anything useful.  It is looking up a thread by ptid using
find_thread_ptid, which basically loops over all threads looking at
their entry.id field.  If a thread with that ptid is found, it returns
its entry.id field.  So it will always return the same thing as it input
(with the exception of if no thread exist with that ptid, then it will
return null_ptid).

gdb/gdbserver/ChangeLog:

	* inferiors.h (gdb_id_to_thread_id): Remove.
	* inferiors.c (gdb_id_to_thread_id): Remove.
	* server.c (process_serial_event): Adjust to gdb_id_to_thread_id
	removal.  Move pid declaration closer to where it's used.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Deduplicate require_running macros and move them up
@ 2017-09-15 17:29 sergiodj+buildbot
  2017-09-15 19:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-15 17:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT f8a4e1192032044cdae544848865636f6e07a925 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: f8a4e1192032044cdae544848865636f6e07a925

Deduplicate require_running macros and move them up

I find it very confusing to define the require_running in the middle of
the file, and re-define it to something else later in the middle of the
same file.  I think it would be better if those macros had different
names so that we know exactly what they do.

gdb/gdbserver/ChangeLog:

	* server.c (require_running): Rename to ...
	(require_running_or_return): ... this ...
	(require_running_or_break): ... and this.
	(handle_query, process_serial_event): Adjust.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] gdbserver: Move detach code to its own function
@ 2017-09-15 16:54 sergiodj+buildbot
  2017-09-15 20:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-15 16:54 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e8ca139ed036e6da8adf42fc6fbd93973b724d3c ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: e8ca139ed036e6da8adf42fc6fbd93973b724d3c

gdbserver: Move detach code to its own function

The code required to handle the 'D' packet is non trivial, so move it
out to its own function.

The moved out code is identical, except for the call to strtol and some
breaks that became returns.

Tested manually, and by running gdb.base/*detach*.exp with
native-gdbserver and native-extended-gdbserver.

gdb/gdbserver/ChangeLog:

	* server.c (handle_detach): New function.
	(process_serial_event): Move code out, call handle_detach.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
* [binutils-gdb] Add -l option to src-release script.
@ 2017-09-15 16:41 sergiodj+buildbot
  2017-09-15 18:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
  0 siblings, 1 reply; 2091+ messages in thread
From: sergiodj+buildbot @ 2017-09-15 16:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ef87240fd95c5f29a697eccf20b2f1f6dc3593a6 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: ef87240fd95c5f29a697eccf20b2f1f6dc3593a6

Add -l option to src-release script.

Since we are updating src-release.sh I thought I would check in this
small patch.  It adds the option to create lzip compressed tarballs
via the -l command line option.

	* src-release.sh (LZIPPROG): New define.  Provides the name of the
	lzip program.
	(do_lz): New function.  Compresses a tarball using the lzip
	program.
	(do_compress): Add support for lzip compression.
	(usage): Mention -l option.
	(build_release): Support -l option to invoke lzip compression.


^ permalink raw reply	[flat|nested] 2091+ messages in thread
end of thread, other threads:[~2018-09-20  6:42 UTC | newest]

Thread overview: 2091+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-07 15:27 [binutils-gdb] Fix decoding of ARM VFP instructions sergiodj+buildbot
2018-05-07 15:32 ` Failures on Fedora-s390x-m64, branch master sergiodj+buildbot
2018-05-07 15:52 ` *** COMPILATION FAILED *** Failures on Fedora-i686, branch master *** BREAKAGE *** sergiodj+buildbot
2018-05-07 15:54 ` Failures on Fedora-x86_64-native-gdbserver-m32, branch master sergiodj+buildbot
2018-05-07 15:55 ` Failures on RHEL-s390x-m64, " sergiodj+buildbot
2018-05-07 16:04 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " sergiodj+buildbot
2018-05-07 16:07 ` Failures on Fedora-x86_64-cc-with-index, " sergiodj+buildbot
2018-05-07 16:17 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " sergiodj+buildbot
2018-05-07 16:17 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-w64-mingw32, branch master *** BREAKAGE *** sergiodj+buildbot
2018-05-07 16:45 ` Failures on Debian-s390x-m64, branch master sergiodj+buildbot
2018-05-07 17:04 ` Failures on Debian-s390x-native-extended-gdbserver-m64, " sergiodj+buildbot
2018-05-07 17:05 ` Failures on Fedora-x86_64-m32, " sergiodj+buildbot
2018-05-18 13:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, " sergiodj+buildbot
2018-05-21 16:04 ` Failures on Ubuntu-AArch32-m32, " sergiodj+buildbot
  -- strict thread matches above, loose matches on Subject: below --
2018-05-30 20:37 [binutils-gdb] Remove regcache_register_status sergiodj+buildbot
2018-09-23 15:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-30 16:17 [binutils-gdb] 2018-05-30 Amaan Cheval <amaan.cheval@gmail.com> sergiodj+buildbot
2018-09-19 22:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-30  8:52 [binutils-gdb] Add znver2 support sergiodj+buildbot
2018-09-18 23:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-26 17:55 [binutils-gdb] Remove interp_ui_out sergiodj+buildbot
2018-09-13 12:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-25 17:20 [binutils-gdb] Remove cleanups from coff-pe-read.c sergiodj+buildbot
2018-09-10 23:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-25 12:40 [binutils-gdb] MIPS/Linux: Correct o32 core file FGR interpretation sergiodj+buildbot
2018-09-09 21:57 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-25 12:19 [binutils-gdb] Fix help and documentation for inferior commands sergiodj+buildbot
2018-09-02 20:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-25  0:21 [binutils-gdb] Update help text in record.c sergiodj+buildbot
2018-09-08  0:38 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-24 21:10 [binutils-gdb] Update help strings in TUI sergiodj+buildbot
2018-09-04 17:20 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-24 20:12 [binutils-gdb] Update core-related help strings sergiodj+buildbot
2018-09-04 11:08 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-23 19:22 [binutils-gdb] Remove file and line from struct complain sergiodj+buildbot
2018-08-24  3:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-23  3:06 [binutils-gdb] Fix gdb.base/remote.exp with native-extended-gdbserver board sergiodj+buildbot
2018-08-18  2:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-23  2:22 [binutils-gdb] remote: Make vcont_builder a class sergiodj+buildbot
2018-08-16  8:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-23  2:03 [binutils-gdb] gdb/x86: Fix `-Wstrict-overflow' build error in `i387_collect_xsave' sergiodj+buildbot
2018-08-17 15:45 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-22 17:34 [binutils-gdb] [PowerPC] Fix access to VSCR in linux targets sergiodj+buildbot
2018-08-08  8:54 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-22 15:57 [binutils-gdb] [PowerPC] Consolidate linux target description selection sergiodj+buildbot
2018-08-06  5:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-22  6:36 [binutils-gdb] PR23207, hppa ld SIGSEGVs on invalid object files sergiodj+buildbot
2018-08-04 13:15 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-21 20:19 [binutils-gdb] Change ada_catchpoint::excep_string to be a std::string sergiodj+buildbot
2018-07-30 13:22 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-21 17:46 [binutils-gdb] Use std::string in reread_symbols sergiodj+buildbot
2018-07-28 20:00 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-21  3:57 [binutils-gdb] Fix copy-pasto, allocate objfile_per_bfd_storage with obstack_new sergiodj+buildbot
2018-07-27 22:14 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-21  1:51 [binutils-gdb] Introduce obstack_new, poison other "typed" obstack functions sergiodj+buildbot
2018-07-27  1:33 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-19  7:33 [binutils-gdb] Fix reference in comment: SRC_AND_LOC instead of LOC_AND_SRC sergiodj+buildbot
2018-07-26  4:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-18 20:15 [binutils-gdb] Show padding in ptype/o output sergiodj+buildbot
2018-07-15  6:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-18 15:27 [binutils-gdb] Add support for the Freescale s12z processor sergiodj+buildbot
2018-07-14 19:58 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-17 15:55 [binutils-gdb] Updated simplified Chinese translation for the opcodes directory sergiodj+buildbot
2018-07-07  9:46 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-17 15:50 [binutils-gdb] value.c: Remove unused variables sergiodj+buildbot
2018-07-06 23:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-16 13:10 [binutils-gdb] PR22458, failure to choose a matching ELF target sergiodj+buildbot
2018-07-01 21:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-15 17:55 [binutils-gdb] MIPS: Make `mask_address_var' static sergiodj+buildbot
2018-06-29 11:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-15 15:48 [binutils-gdb] testsuite: Fix a `server_pid' access crash in gdb.server/server-kill.exp sergiodj+buildbot
2018-06-29  7:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-11 21:20 [binutils-gdb] Eliminate the 'the_core_target' global sergiodj+buildbot
2018-06-22  9:47 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-11 17:54 [binutils-gdb] Remove cleanups from mdebugread.c sergiodj+buildbot
2018-06-21  8:59 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-10 20:54 [binutils-gdb] Fix the clang build sergiodj+buildbot
2018-06-19 21:15 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-10 17:18 [binutils-gdb] gdbserver/Windows: Fix "no program to debug" error sergiodj+buildbot
2018-06-18 14:18 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-10 17:03 [binutils-gdb] [gdbserver/win32] fatal "glob could not process pattern '(null)'" error sergiodj+buildbot
2018-06-18  7:18 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-10 12:28 [binutils-gdb] Add support for detecting Freescale S12Z binaries in readelf sergiodj+buildbot
2018-06-16 22:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-10 10:11 [binutils-gdb] Fix tagged pointer support sergiodj+buildbot
2018-06-16 21:50 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-08 23:14 [binutils-gdb] RISC-V: Add missing hint instructions from RV128I sergiodj+buildbot
2018-06-11 20:54 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-08 17:40 [binutils-gdb] gdb/x86: Handle kernels using compact xsave format sergiodj+buildbot
2018-06-10  2:18 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-08 13:27 [binutils-gdb] watchpoint-unaligned.exp: Use skip_hw_watchpoint_tests sergiodj+buildbot
2018-06-07  9:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-08 12:20 [binutils-gdb] Prevent a memory exhaustion failure when running objdump on a fuzzed input file with corrupt string and attribute sections sergiodj+buildbot
2018-06-03 22:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-08  2:10 [binutils-gdb] Simplify VLE handling in print_insn_powerpc() sergiodj+buildbot
2018-06-03 12:46 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-05  7:03 [binutils-gdb] Add fall-through comment to i386-tdep.c sergiodj+buildbot
2018-05-11 22:22 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-05  4:33 [binutils-gdb] Fix "fall through" comments sergiodj+buildbot
2018-05-10  7:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-05  1:14 [binutils-gdb] Use function_view in cli-script.c sergiodj+buildbot
2018-05-08 21:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-04 22:30 [binutils-gdb] aarch64: PR 19806: watchpoints: false negatives + PR 20207 contiguous ones sergiodj+buildbot
2018-05-06 21:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-04 21:12 [binutils-gdb] (SPARC/LEON) fix incorrect array return value printed by "finish" sergiodj+buildbot
2018-05-05 19:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-04 20:13 [binutils-gdb] Remove do_closedir_cleanup sergiodj+buildbot
2018-05-05 12:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-04 14:14 [binutils-gdb] configure uses incorrect link order when testing libpython sergiodj+buildbot
2018-05-04 18:20 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-03 21:34 [binutils-gdb] gdb/testsuite: Filter out some registers for riscv sergiodj+buildbot
2018-05-04  5:08 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-03  2:54 [binutils-gdb] Eliminate target_ops::to_xclose sergiodj+buildbot
2018-05-03 11:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-03  2:12 [binutils-gdb] Make inf_ptrace_trad Linux-only, move to separate file sergiodj+buildbot
2018-05-03  9:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-03  0:37 [binutils-gdb] More procfs.c simplification sergiodj+buildbot
2018-05-03  6:56 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-05-01  1:23 [binutils-gdb] Remove a use of is_mi_like_p from darwin-nat-info.c sergiodj+buildbot
2018-05-02 12:15 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-30 23:58 [binutils-gdb] Remove some uses of is_mi_like_p from spu-tdep.c sergiodj+buildbot
2018-05-02  5:38 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-30 23:38 [binutils-gdb] Remove some uses of is_mi_like_p from py-framefilter.c sergiodj+buildbot
2018-05-02  3:29 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-30 22:16 [binutils-gdb] Change Python code to use new_reference sergiodj+buildbot
2018-05-01 22:33 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-30 21:46 [binutils-gdb] Introduce ref_ptr::new_reference sergiodj+buildbot
2018-05-01 14:54 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-30 21:37 [binutils-gdb] Remove new_bfd_ref sergiodj+buildbot
2018-05-01 17:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-30 19:20 [binutils-gdb] Expose type alignment on gdb.Type sergiodj+buildbot
2018-05-01  4:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-30 18:19 [binutils-gdb] Handle alignof and _Alignof sergiodj+buildbot
2018-05-01  1:33 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-30 17:32 [binutils-gdb] Add initial type alignment support sergiodj+buildbot
2018-04-30 23:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-30 15:27 [binutils-gdb] Use bool in read_index_from_section sergiodj+buildbot
2018-04-30 18:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-29 16:52 [binutils-gdb] proc-events.c: fix compilation on Solaris sergiodj+buildbot
2018-04-30 12:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-29 16:18 [binutils-gdb] Fix race when building ada-lex.c sergiodj+buildbot
2018-04-30  6:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-27 20:09 [binutils-gdb] Add inclusive range support for Rust sergiodj+buildbot
2018-04-29 20:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-27 19:21 [binutils-gdb] Enable -Wsuggest-override sergiodj+buildbot
2018-04-29 16:18 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-27 13:09 [binutils-gdb] Revert "Enable Intel MOVDIRI, MOVDIR64B instructions." sergiodj+buildbot
2018-04-29 14:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-27 11:12 [binutils-gdb] Regenerate some files for recent ARM patches sergiodj+buildbot
2018-04-29 11:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-26 23:25 [binutils-gdb] Fix remote 'g' command error handling (PR remote/9665) sergiodj+buildbot
2018-04-29  5:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-26 22:02 [binutils-gdb] Enable Intel MOVDIRI, MOVDIR64B instructions sergiodj+buildbot
2018-04-29  2:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-26 19:45 [binutils-gdb] Fix resolving GNU ifunc bp locations when inferior runs resolver sergiodj+buildbot
2018-04-29  0:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-26 18:42 [binutils-gdb] Extend GNU ifunc testcases sergiodj+buildbot
2018-04-28 22:06 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-26 18:05 [binutils-gdb] PPC64: always make synthetic .text symbols for GNU ifunc symbols sergiodj+buildbot
2018-04-28 19:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-26 16:34 [binutils-gdb] For PPC64: elf_gnu_ifunc_record_cache: handle plt symbols in .text section sergiodj+buildbot
2018-04-28 10:49 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-26 15:43 [binutils-gdb] Eliminate find_pc_partial_function_gnu_ifunc sergiodj+buildbot
2018-04-28  4:57 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-26 15:18 [binutils-gdb] Breakpoints, don't skip prologue of ifunc resolvers with debug info sergiodj+buildbot
2018-04-28  2:15 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-26 14:53 [binutils-gdb] Fix setting breakpoints on ifunc functions after they're already resolved sergiodj+buildbot
2018-04-28  0:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-26 14:33 [binutils-gdb] Calling ifunc functions when resolver has debug info, user symbol same name sergiodj+buildbot
2018-04-27 19:20 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-26 14:27 [binutils-gdb] Fix calling ifunc functions when resolver has debug info and different name sergiodj+buildbot
2018-04-27 14:50 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-26 13:28 [binutils-gdb] Calling ifunc functions when target has no debug info but resolver has sergiodj+buildbot
2018-04-27 17:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-26 12:47 [binutils-gdb] Fix breakpoints in ifunc after inferior resolved it (@got.plt symbol creation) sergiodj+buildbot
2018-04-27 12:15 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-26 10:29 [binutils-gdb] x86: x87-related adjustments sergiodj+buildbot
2018-04-27  1:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-26  9:03 [binutils-gdb] x86: fold various non-memory operand AVX512VL templates sergiodj+buildbot
2018-04-27  9:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-26  8:36 [binutils-gdb] x86: CpuXSAVE is a prereq for various other features sergiodj+buildbot
2018-04-27  7:11 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-26  8:13 [binutils-gdb] x86: drop CpuRegMMX, CpuReg[XYZ]MM, and CpuRegMask sergiodj+buildbot
2018-04-27  4:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-26  7:04 [binutils-gdb] x86: drop VexImmExt sergiodj+buildbot
2018-04-26 23:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-26  2:23 [binutils-gdb] [ARM] FDPIC: Make _GLOBAL_OFFSET_TABLE_ a relative symbol sergiodj+buildbot
2018-04-26 19:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-26  1:48 [binutils-gdb] [ARM] FDPIC: Translate R_ARM_TARGET2 relocation into R_ARM_GOT32 relocation for FDPIC platform sergiodj+buildbot
2018-04-26 16:59 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-26  1:29 [binutils-gdb] [ARM] FDPIC: Add stack segment sergiodj+buildbot
2018-04-26 14:33 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-26  0:55 [binutils-gdb] [ARM] Add TLS relocations for FDPIC sergiodj+buildbot
2018-04-26 12:20 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-26  0:03 [binutils-gdb] [ARM] Implement PLT for FDPIC sergiodj+buildbot
2018-04-26  9:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-25 23:02 [binutils-gdb] [ARM] Add FDPIC relocations definitions sergiodj+buildbot
2018-04-26  4:33 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-25 22:20 [binutils-gdb] [ARM] Add FDPIC OSABI flag support sergiodj+buildbot
2018-04-26  2:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-25 21:40 [binutils-gdb] [ARM] Add armelf_linux_fdpiceabi and armelfb_linux_fdpiceabi BFD backends sergiodj+buildbot
2018-04-25 23:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-25 18:28 [binutils-gdb] Fix new inferior events output sergiodj+buildbot
2018-04-25 20:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-25 14:49 [binutils-gdb] x86: drop redundant AVX512VL shift templates sergiodj+buildbot
2018-04-25 18:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-25  0:47 [binutils-gdb] Remove arm-aout and arm-coff support sergiodj+buildbot
2018-04-25  8:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-24 16:07 [binutils-gdb] Fix an illegal memory access when copying a PE format file with corrupt debug information sergiodj+buildbot
2018-04-24 23:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-23 12:15 [binutils-gdb] Prevent an illegal memory access in gprof by ensuring that string tables for aout format files are always zero-terminated sergiodj+buildbot
2018-04-23 14:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-23  9:10 [binutils-gdb] Silence gcc-8 warnings sergiodj+buildbot
2018-04-23 12:14 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-20 21:47 [binutils-gdb] Improve on-line help for thread_apply_command and thread_apply_all_command sergiodj+buildbot
2018-04-21  9:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-20 14:09 [binutils-gdb] PR22978, TLS local-dynamic incorrectly linked on hppa-linux sergiodj+buildbot
2018-04-20 21:47 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-19 17:40 [binutils-gdb] Fix dependency tracking in gdbserver subdirectories sergiodj+buildbot
2018-04-19 22:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-18 21:02 [binutils-gdb] Remove xml file references from target descriptions sergiodj+buildbot
2018-04-19 12:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-18 20:22 [binutils-gdb] Add feature reference in .dat files sergiodj+buildbot
2018-04-19  6:46 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-18 14:07 [binutils-gdb] Commonise tdesc_feature and makes use of it in gdbserver tdesc sergiodj+buildbot
2018-04-18 20:00 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-18  8:44 [binutils-gdb] Remove mips aout, coff, and pe support sergiodj+buildbot
2018-04-18 15:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-18  2:13 [binutils-gdb] elf32_bed/elf64_bed sergiodj+buildbot
2018-04-18 13:33 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-18  1:33 [binutils-gdb] x86: Use a normal input file with compatible relocation sergiodj+buildbot
2018-04-18 11:24 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-18  0:23 [binutils-gdb] various i386-aout and i386-coff target removal sergiodj+buildbot
2018-04-18  8:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-17 20:26 [binutils-gdb] Conditionally drop the discriminant field in quirk_rust_enum sergiodj+buildbot
2018-04-18  4:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-17 17:52 [binutils-gdb] Don't print symbol declaration's line number in rbreak output sergiodj+buildbot
2018-04-17 23:57 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-17 13:19 [binutils-gdb] Resync libiberty sources with master version in GCC repository sergiodj+buildbot
2018-04-17 17:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-17  3:38 [binutils-gdb] Reinstate readelf decoding of i860, i960 and i370 relocs sergiodj+buildbot
2018-04-17 13:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-16 21:12 [binutils-gdb] linux_spu_make_corefile_notes: return note_data instead of nullptr sergiodj+buildbot
2018-04-17 11:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-16 19:20 [binutils-gdb] Adjust more test cases to changed output of info var/func/type sergiodj+buildbot
2018-04-17  8:05 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-16  9:50 [binutils-gdb] Remove h8300-coff support sergiodj+buildbot
2018-04-16 20:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-16  9:17 [binutils-gdb] Remove IEEE 695 object support sergiodj+buildbot
2018-04-16 18:22 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-16  8:43 [binutils-gdb] Remove tandem support sergiodj+buildbot
2018-04-16 16:00 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-14  9:25 [binutils-gdb] powerpc common-page-size sergiodj+buildbot
2018-04-14 16:29 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-14  9:08 [binutils-gdb] powerpc max-page-size vs __QNXTARGET__ sergiodj+buildbot
2018-04-14 14:20 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-14  8:58 [binutils-gdb] powerpc-lynxos and powerpc-windiss fixes sergiodj+buildbot
2018-04-14 11:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-13 17:44 [binutils-gdb] Show line numbers in output for "info var/func/type" sergiodj+buildbot
2018-04-13 21:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-13 10:21 [binutils-gdb] btrace: set/show record btrace cpu sergiodj+buildbot
2018-04-13 19:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-13  9:59 [binutils-gdb] btrace: fix output of "set record btrace" sergiodj+buildbot
2018-04-13 14:13 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-12 20:34 [binutils-gdb] Fix -D_GLIBCXX_DEBUG gdb-add-index regression sergiodj+buildbot
2018-04-13  3:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-12 19:33 [binutils-gdb] Remove old univariant code from rust-lang.c sergiodj+buildbot
2018-04-13  1:33 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-12 17:40 [binutils-gdb] Fix Solaris build sergiodj+buildbot
2018-04-12 23:24 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-11 11:23 [binutils-gdb] File I/O file handles after target closes sergiodj+buildbot
2018-04-11 15:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-10 21:11 [binutils-gdb] Iterate by index in auto_load_safe_path_vec_update sergiodj+buildbot
2018-04-10 23:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-09 20:19 [binutils-gdb] Adapt and integrate string_view tests sergiodj+buildbot
2018-04-10  8:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-09 20:08 [binutils-gdb] Use an std::vector for inline_states sergiodj+buildbot
2018-04-10 12:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-09 19:54 [binutils-gdb] Remove VEC(tsv_s), use std::vector instead sergiodj+buildbot
2018-04-10  9:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-09 19:11 [binutils-gdb] Add gdb::string_view sergiodj+buildbot
2018-04-10  5:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-09 18:41 [binutils-gdb] Update ax_cv_cxx_compile_cxx.m4 sergiodj+buildbot
2018-04-10  2:45 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-09 15:13 [binutils-gdb] Apply "Convert observers to C++" edit to gdbarch.sh sergiodj+buildbot
2018-04-10  1:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-09 13:12 [binutils-gdb] MIPS64/BFD: Fix a crash with STN_UNDEF in relocation sergiodj+buildbot
2018-04-09 23:54 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-09 11:16 [binutils-gdb] PowerPC inline PLT call support sergiodj+buildbot
2018-04-09 19:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-09  9:17 [binutils-gdb] Support PLT16 relocs against local symbols sergiodj+buildbot
2018-04-09 17:03 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-09  9:03 [binutils-gdb] Rearrange PLT reloc output on powerpc sergiodj+buildbot
2018-04-09 14:29 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-07 20:50 [binutils-gdb] Replace dw2_get_cu/dw2_get_cutu with methods of dwarf2_per_objfile sergiodj+buildbot
2018-04-08  3:59 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-07 20:40 [binutils-gdb] Fix gdb.mi/mi-stack.exp when gcc generates a stack protector sergiodj+buildbot
2018-04-08 13:45 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-07 20:17 [binutils-gdb] Remove stale file i386-avx.dat sergiodj+buildbot
2018-04-07 22:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-07 20:11 [binutils-gdb] Replace make_cleanup_restore_current_traceframe with RAII class sergiodj+buildbot
2018-04-08 10:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-07 19:29 [binutils-gdb] Remove some usages of get_dwarf2_per_objfile sergiodj+buildbot
2018-04-08  5:18 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-07 19:01 [binutils-gdb] Remove some unused variables in dwarf2read.c sergiodj+buildbot
2018-04-08  2:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-07 18:47 [binutils-gdb] Defer breakpoint reset when cloning progspace for fork child sergiodj+buildbot
2018-04-08  1:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-07 18:34 [binutils-gdb] Implement write_async_safe for mi_console_file (PR 22299) sergiodj+buildbot
2018-04-08  0:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-07 18:05 [binutils-gdb] Fix generation of x86-64 gdbarch with osabi none (PR 22979) sergiodj+buildbot
2018-04-07 21:22 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-07 17:38 [binutils-gdb] Make target_read_alloc & al return vectors sergiodj+buildbot
2018-04-07 18:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-07  4:04 [binutils-gdb] Remove value::next and value::released sergiodj+buildbot
2018-04-07  8:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-07  2:23 [binutils-gdb] Remove free_all_values sergiodj+buildbot
2018-04-07  5:50 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-07  0:41 [binutils-gdb] Change varobj to use value_ref_ptr sergiodj+buildbot
2018-04-07  3:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-07  0:26 [binutils-gdb] Remove range_s VEC sergiodj+buildbot
2018-04-07 13:44 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-06 23:57 [binutils-gdb] Use new and delete for values sergiodj+buildbot
2018-04-07 11:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-06 23:29 [binutils-gdb] Remove free_value_chain sergiodj+buildbot
2018-04-07  7:10 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-06 23:00 [binutils-gdb] Change value history to use value_ref_ptr sergiodj+buildbot
2018-04-07  4:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-06 22:31 [binutils-gdb] Change last_examine_value to value_ref_ptr sergiodj+buildbot
2018-04-07  1:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-06 20:32 [binutils-gdb] Add -Wno-error=deprecated-register to gdb build flags sergiodj+buildbot
2018-04-06 21:53 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-05 22:53 [binutils-gdb] Use dlsym to check if libdl is needed for plugin sergiodj+buildbot
2018-04-06 11:24 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-05 22:49 [binutils-gdb] config: Sync with GCC sergiodj+buildbot
2018-04-06  9:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-05 18:17 [binutils-gdb] Change streq to return bool sergiodj+buildbot
2018-04-06  3:13 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-05 15:05 [binutils-gdb] Remove a string copy from event_location_to_sals sergiodj+buildbot
2018-04-06  1:54 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-05 14:52 [binutils-gdb] Have filter_results take a std::vector sergiodj+buildbot
2018-04-05 22:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-05 14:37 [binutils-gdb] Return std::string from canonical_to_fullform sergiodj+buildbot
2018-04-05 19:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-05 14:24 [binutils-gdb] Make copy_token_string return unique_xmalloc_ptr sergiodj+buildbot
2018-04-05 18:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-05 13:56 [binutils-gdb] Remove some cleanups from search_minsyms_for_name sergiodj+buildbot
2018-04-05 15:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-04 11:58 [binutils-gdb] i386: Clear vex instead of vex.evex sergiodj+buildbot
2018-04-04 14:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-04  8:16 [binutils-gdb] Update Spanish translations for ld/ opcodes/ and gold/ sub-directories sergiodj+buildbot
2018-04-04 12:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-04  2:44 [binutils-gdb] PR binutils/22875: HPPA/ELF: Also fail with relocation placeholders sergiodj+buildbot
2018-04-04 10:45 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-04  2:30 [binutils-gdb] PR binutils/22875: i860/ELF: Report unsupported relocation types sergiodj+buildbot
2018-04-04  8:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-04  2:16 [binutils-gdb] PR binutils/22875: Visium/ELF: Prevent an out-of-bounds howto table access sergiodj+buildbot
2018-04-04  6:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-04  2:02 [binutils-gdb] PR binutils/22875: FRV/ELF: Prevent an out-of-bounds howto table access sergiodj+buildbot
2018-04-04  3:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-04  1:44 [binutils-gdb] PR binutils/22875: IQ2000/ELF: Prevent an out-of-bounds howto table access sergiodj+buildbot
2018-04-04  5:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-04  1:17 [binutils-gdb] PR binutils/22875: MIPS/ELF: Also fail with relocation placeholders sergiodj+buildbot
2018-04-04  2:22 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-03 18:20 [binutils-gdb] Change read_alphacoff_dynamic_symtab to use gdb::byte_vector sergiodj+buildbot
2018-04-03 19:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-04-02  2:44 [binutils-gdb] Change rs6000_ptrace_ldinfo to return a byte_vector sergiodj+buildbot
2018-04-02  3:49 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-31  1:27 [binutils-gdb] Use std::vector and std::string instead of VEC(char_ptr) in gdbserver tdesc sergiodj+buildbot
2018-03-31  7:10 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-30 22:45 [binutils-gdb] Use std::vector in uploaded_tp sergiodj+buildbot
2018-03-31  5:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-30 22:03 [binutils-gdb] Remove usage of VEC(char_ptr) in gdbscm_parse_function_args sergiodj+buildbot
2018-03-31  9:24 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-30 20:35 [binutils-gdb] Remove some cleanups from solib-svr4.c sergiodj+buildbot
2018-03-31  4:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-30 20:03 [binutils-gdb] Remove free_cached_comp_units cleanups sergiodj+buildbot
2018-03-30 22:33 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-30 19:55 [binutils-gdb] Remove parameter from free_dwo_file sergiodj+buildbot
2018-03-31  0:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-29 13:26 [binutils-gdb] PR binutils/22875: MIPS: Remove duplicate unsupported relocation processing sergiodj+buildbot
2018-03-29 14:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-28 20:56 [binutils-gdb] MIPS/BFD: Call `mips_elf32_rtype_to_howto' directly with o32 sergiodj+buildbot
2018-03-29  0:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-28 17:35 [binutils-gdb] [1/2][GAS][AARCH64]Add BFD_RELOC_AARCH64_TLSLE_LDST8/16/32/64_TPREL_LO12 support in GAS sergiodj+buildbot
2018-03-28 21:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-28 13:10 [binutils-gdb] x86: convert broadcast insn attribute to boolean sergiodj+buildbot
2018-03-28 18:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-28 12:42 [binutils-gdb] x86: don't show suffixes for to-scalar-int conversion insns sergiodj+buildbot
2018-03-28 14:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-28 10:35 [binutils-gdb] PR ld/22972 on SPARC sergiodj+buildbot
2018-03-28 13:06 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-28  9:04 [binutils-gdb] Enhance the AARCH64 assembler to support LDFF1xx instructions which use REG+REG addressing with an assumed offset register sergiodj+buildbot
2018-03-28 11:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-27 17:14 [binutils-gdb] Remove cleanups from gdb_readline_wrapper sergiodj+buildbot
2018-03-28  7:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-27 15:13 [binutils-gdb] Include <cmath> in dwarf-index-write.c sergiodj+buildbot
2018-03-28  4:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-27 14:24 [binutils-gdb] Move DWARF index-related things to a separate file sergiodj+buildbot
2018-03-28  2:14 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-27 14:13 [binutils-gdb] problem looking up some symbols when they have a linkage name sergiodj+buildbot
2018-03-28  0:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-27  7:12 [binutils-gdb] Simplify exception handling in py-framefilter.c sergiodj+buildbot
2018-03-27 22:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-27  6:58 [binutils-gdb] Improve "backtrace" help text sergiodj+buildbot
2018-03-27 20:57 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-27  6:44 [binutils-gdb] Call wrap_hint in one more spot in py-framefilter.c sergiodj+buildbot
2018-03-27 19:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-27  6:17 [binutils-gdb] Move some code later in backtrace_command_1 sergiodj+buildbot
2018-03-27 16:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-27  5:17 [binutils-gdb] Avoid manual resource management in py-framefilter.c sergiodj+buildbot
2018-03-27 11:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-27  4:49 [binutils-gdb] Allow hiding of some filtered frames sergiodj+buildbot
2018-03-27  8:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-27  4:34 [binutils-gdb] Change backtrace_command_1 calling to use flags sergiodj+buildbot
2018-03-27  6:46 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-27  4:21 [binutils-gdb] Rationalize "backtrace" command line parsing sergiodj+buildbot
2018-03-27  5:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-26 11:05 [binutils-gdb] Make gdbserver reg_defs a vector of objects sergiodj+buildbot
2018-03-26 12:13 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-24  3:23 [binutils-gdb] aarch64: Make "info address" resolve TLS variables sergiodj+buildbot
2018-03-24  4:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-23 13:00 [binutils-gdb] gdb: Fix testsuite issue in gdb.arch/amd64-disp-step-avx.exp sergiodj+buildbot
2018-03-23 15:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-23 12:14 [binutils-gdb] gdb: Minor cleanup in some gdb.arch/* tests sergiodj+buildbot
2018-03-23 14:05 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-23  9:56 [binutils-gdb] Testsuite: fully migrate to use_gdb_stub convenience func sergiodj+buildbot
2018-03-23 11:05 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-23  3:37 [binutils-gdb] Remove some cleanups from record-full.c sergiodj+buildbot
2018-03-23  4:46 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-22 13:54 [binutils-gdb] ppc: Fix stwux and stdux masks in skip_prologue sergiodj+buildbot
2018-03-22 20:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-22 13:41 [binutils-gdb] ppc: Detect when LR is saved through frame pointer sergiodj+buildbot
2018-03-22 19:20 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-22  9:20 [binutils-gdb] S390: Correct brace style in s390_get_wordsize sergiodj+buildbot
2018-03-22 16:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-22  8:31 [binutils-gdb] x86: drop remaining redundant DispN sergiodj+buildbot
2018-03-22 13:47 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-22  8:17 [binutils-gdb] x86: fix swapped operand handling for BNDMOV sergiodj+buildbot
2018-03-22 12:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-22  8:02 [binutils-gdb] x86/Intel: fix fallout from earlier template folding sergiodj+buildbot
2018-03-22 11:05 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-22  4:50 [binutils-gdb] Make parse_static_tracepoint_marker_definition work with multiple static tracepoint definitions sergiodj+buildbot
2018-03-22  5:54 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-21 20:49 [binutils-gdb] Add myself as a write-after-approval GDB maintainer sergiodj+buildbot
2018-03-22  0:56 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-21 20:10 [binutils-gdb] DT_FLAGS_1: Add Solaris bits sergiodj+buildbot
2018-03-21 23:38 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-21 12:27 [binutils-gdb] PowerPC64 synthetic symbols sergiodj+buildbot
2018-03-21 18:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-21 11:59 [binutils-gdb] Make tls_mask unsigned in elf32-ppc.c sergiodj+buildbot
2018-03-21 15:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-21 11:32 [binutils-gdb] Don't exceed reloc array bounds sergiodj+buildbot
2018-03-21 12:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-20 14:14 [binutils-gdb] Replace the linear search in find_pc_sect_line with a binary search sergiodj+buildbot
2018-03-20 15:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-19 17:31 [binutils-gdb] Support bare-identifier field initializers in Rust sergiodj+buildbot
2018-03-19 18:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-19 11:10 [binutils-gdb] Updated Spanish translation for the bfd/ sub-directory, and updated Ukranian translation for the gas/ sub-directory sergiodj+buildbot
2018-03-19 12:11 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-19  4:11 [binutils-gdb] Remove some cleanups from solib.c sergiodj+buildbot
2018-03-19  5:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-16 21:30 [binutils-gdb] Add silent Makefile rules sergiodj+buildbot
2018-03-16 23:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-16  2:19 [binutils-gdb] Add selftest for substitute_path_component sergiodj+buildbot
2018-03-16  3:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-15  8:04 [binutils-gdb] nds32: Remove the unsupported target feature sergiodj+buildbot
2018-03-15  9:11 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-14 17:26 [binutils-gdb] Allow - in %p for printf sergiodj+buildbot
2018-03-14 18:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-14 16:46 [binutils-gdb] Special case NULL when using printf's %s format sergiodj+buildbot
2018-03-14 19:57 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-14 16:04 [binutils-gdb] Add usage to printf command sergiodj+buildbot
2018-03-14 17:18 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-14 13:59 [binutils-gdb] Update my email address sergiodj+buildbot
2018-03-14 15:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-14 12:19 [binutils-gdb] PowerPC64 debian bug 886264, out-of-line save/restore functions sergiodj+buildbot
2018-03-14 14:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-13 23:55 [binutils-gdb] Remove two cleanups using std::string sergiodj+buildbot
2018-03-14  0:59 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-13 14:19 [binutils-gdb] Prevent memory access violations when attempting to parse an x86_64 PE binary containing corrupt unwind information sergiodj+buildbot
2018-03-13 16:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-12 22:14 [binutils-gdb] gdb/riscv: Fix some ARI issues sergiodj+buildbot
2018-03-12 23:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-12 14:44 [binutils-gdb] Use gdb::byte_vector when reading section data sergiodj+buildbot
2018-03-12 15:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-12  3:22 [binutils-gdb] Remove cleanup from build_type_psymtabs_1 sergiodj+buildbot
2018-03-12  4:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-09  5:23 [binutils-gdb] Use scoped_fd in more places sergiodj+buildbot
2018-03-09 23:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-09  0:12 [binutils-gdb] Make find_separate_debug_file* return std::string sergiodj+buildbot
2018-03-09 18:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-08 20:05 [binutils-gdb] x86-64: Also optimize "clr reg64" sergiodj+buildbot
2018-03-09 12:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-08 13:06 [binutils-gdb] x86: fold LWP templates sergiodj+buildbot
2018-03-08 21:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-08  9:44 [binutils-gdb] x86: fold VEX-encoded GFNI templates sergiodj+buildbot
2018-03-09  2:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-08  9:07 [binutils-gdb] x86: fold FMA and FMA4 templates sergiodj+buildbot
2018-03-08 19:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-08  8:43 [binutils-gdb] x86: drop bogus NoAVX sergiodj+buildbot
2018-03-08 15:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-08  8:27 [binutils-gdb] x86: bogus VMOVD with 64-bit operands should only allow for registers sergiodj+buildbot
2018-03-08 10:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-08  8:19 [binutils-gdb] x86: drop FloatD sergiodj+buildbot
2018-03-08 12:50 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-07 23:02 [binutils-gdb] Return gdb::optional<std::string> from target_fileio_readlink sergiodj+buildbot
2018-03-08  0:05 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-07 17:55 [binutils-gdb] gdb: Add riscv to list of architectures with a save_reggroup sergiodj+buildbot
2018-03-07 19:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-07 17:03 [binutils-gdb] [PR20402][LD][AARCH64]Don't emit RELATIVE relocation for absolute symbols which are resolved at static linking time sergiodj+buildbot
2018-03-07 18:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-07  7:12 [binutils-gdb] XCOFF disassembler sergiodj+buildbot
2018-03-07  9:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-07  7:01 [binutils-gdb] mips64 rtype_to_howto error status sergiodj+buildbot
2018-03-07  8:05 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-06 21:53 [binutils-gdb] Formatting fixes in rust-exp.y sergiodj+buildbot
2018-03-07  3:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-06 19:45 [binutils-gdb] gdb/riscv: Remove use of pseudo registers sergiodj+buildbot
2018-03-06 22:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-06 15:28 [binutils-gdb] gdb/riscv: Fix type when reading register from regcache sergiodj+buildbot
2018-03-06 17:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-06 10:29 [binutils-gdb] gdb/amd64: Ignore zero sized fields when calling functions sergiodj+buildbot
2018-03-06 11:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-05  1:19 [binutils-gdb] Propagate gdb_disassembly_flags to btrace_print_lines sergiodj+buildbot
2018-03-05  2:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-04  6:38 [binutils-gdb] Use signal information to determine SIGTRAP type for FreeBSD sergiodj+buildbot
2018-03-04 10:11 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-04  5:54 [binutils-gdb] Implement "to_stopped_by_hw_breakpoint" for x86 debug registers sergiodj+buildbot
2018-03-04  6:56 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-03  8:16 [binutils-gdb] Remove free_char_ptr_vec sergiodj+buildbot
2018-03-03 11:44 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-03  5:54 [binutils-gdb] handle_general_set: Remove useless xstrdup sergiodj+buildbot
2018-03-03 13:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-03  5:05 [binutils-gdb] Make program_space::deleted_solibs a vector of std::string sergiodj+buildbot
2018-03-03  8:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-03  1:20 [binutils-gdb] opcodes error messages sergiodj+buildbot
2018-03-03  2:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-02 12:07 [binutils-gdb] [GDB/testsuite] Use %progbits in watch-loc.c sergiodj+buildbot
2018-03-02 13:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-02 11:03 [binutils-gdb] Ensure 8-byte alignment for AArch64 stubs sergiodj+buildbot
2018-03-02 12:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-01 22:37 [binutils-gdb] RISC-V: Fix symbol size bug when relaxation deletes bytes sergiodj+buildbot
2018-03-02  0:18 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-01 16:51 [binutils-gdb] Fix Rust enum test failures sergiodj+buildbot
2018-03-01 18:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-03-01 14:29 [binutils-gdb] x86: Encode AVX256/AVX512 vpsub[bwdq] with VEX128/EVEX128 sergiodj+buildbot
2018-03-01 15:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-28 23:16 [binutils-gdb] correct ft32 reloc range test sergiodj+buildbot
2018-03-01  7:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-28 17:06 [binutils-gdb] Make gdbserver work with filename-only binaries sergiodj+buildbot
2018-03-01  4:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-28 17:02 [binutils-gdb] Create new common/pathstuff.[ch] sergiodj+buildbot
2018-03-01  3:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-28 12:18 [binutils-gdb] Catch integer overflows/underflows when parsing corrupt DWARF FORM blocks sergiodj+buildbot
2018-03-01  0:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-28 12:05 [binutils-gdb] PR22887, null pointer dereference in aout_32_swap_std_reloc_out sergiodj+buildbot
2018-02-28 23:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-28  7:57 [binutils-gdb] Nonsense error messages on invalid aout string offset sergiodj+buildbot
2018-02-28 21:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-27 19:20 [binutils-gdb] Change target_write_memory_blocks to use std::vector sergiodj+buildbot
2018-02-28 15:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-27 16:46 [binutils-gdb] Explicitly specify common tdesc.h for use with aarch64.h sergiodj+buildbot
2018-02-28 13:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-27 12:32 [binutils-gdb] Use standardized error message for unrecognized relocs sergiodj+buildbot
2018-02-28  9:53 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-27 10:41 [binutils-gdb] Have info_to_howto functions return a success/fail status. Check this result. Stop strip from completeing if one of these functions fails sergiodj+buildbot
2018-02-28  8:14 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-27  0:14 [binutils-gdb] Handle DW_TAG_variant_part and DW_TAG_variant sergiodj+buildbot
2018-02-27 19:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-26 21:31 [binutils-gdb] Convert Rust to use discriminated unions sergiodj+buildbot
2018-02-27 17:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-26 20:30 [binutils-gdb] MIPS: Don't use a 32-bit BFD architecture with a 64-bit ABI sergiodj+buildbot
2018-02-28  3:03 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-26 18:41 [binutils-gdb] Move read_partial_die to partial_die_info::read sergiodj+buildbot
2018-02-27 11:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-26 18:06 [binutils-gdb] Change frame_filter_flags to use DEF_ENUM_FLAGS_TYPE sergiodj+buildbot
2018-02-28  0:29 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-26 17:54 [binutils-gdb] Make "bt N" print correct number of frames when using a frame filter sergiodj+buildbot
2018-02-27 21:45 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-26 17:16 [binutils-gdb] Initial support for variant parts sergiodj+buildbot
2018-02-27 15:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-26 12:02 [binutils-gdb] Move arch/tdesc.h to common/tdesc.h sergiodj+buildbot
2018-02-26 23:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-26  1:53 [binutils-gdb] Segfault on phdrs allocated but not created sergiodj+buildbot
2018-02-26 21:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-26  1:40 [binutils-gdb] crx string overflow warning sergiodj+buildbot
2018-02-26 19:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-26  1:28 [binutils-gdb] assorted target messages sergiodj+buildbot
2018-02-26 16:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-26  1:16 [binutils-gdb] BFD messages sergiodj+buildbot
2018-02-26 14:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-26  1:03 [binutils-gdb] AOUT/COFF/PE messages sergiodj+buildbot
2018-02-26 12:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-26  0:38 [binutils-gdb] MIPS messages sergiodj+buildbot
2018-02-26  7:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-26  0:14 [binutils-gdb] ELF linker messages sergiodj+buildbot
2018-02-26  5:49 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-26  0:13 [binutils-gdb] unrecognized/unsupported reloc message sergiodj+buildbot
2018-02-26  3:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-25 20:37 [binutils-gdb] Fix double space expected in cp_test_ptype_class sergiodj+buildbot
2018-02-25 22:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-24 17:31 [binutils-gdb] Remove most cleanups from linux-thread-db.c sergiodj+buildbot
2018-02-24 21:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-24 17:19 [binutils-gdb] Remove cleanups from check_fast_tracepoint_sals sergiodj+buildbot
2018-02-24 18:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-23 20:31 [binutils-gdb] GDB/testsuite: Fix a typo in $actual_line sergiodj+buildbot
2018-02-23 23:10 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-23 11:31 [binutils-gdb] PR22881, null pointer dereference in assign_file_positions_for_non_load_sections sergiodj+buildbot
2018-02-23 13:47 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-23  7:38 [binutils-gdb] nds32: Support target directive .ict_model sergiodj+buildbot
2018-02-23  9:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-22 22:16 [binutils-gdb] New plugin interface to get list of symbols wrapped with --wrap option sergiodj+buildbot
2018-02-23  2:50 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-22 14:40 [binutils-gdb] x86: Add {rex} pseudo prefix sergiodj+buildbot
2018-02-22 23:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-21 19:23 [binutils-gdb] Add "common-defs.h" include to files in arch/ subdir not yet including it sergiodj+buildbot
2018-02-22 18:20 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-21 17:11 [binutils-gdb] Remove a cleanup from call_function_by_hand_dummy sergiodj+buildbot
2018-02-22 13:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-21 16:31 [binutils-gdb] Remove a cleanup from parse_expression_for_completion sergiodj+buildbot
2018-02-22 16:00 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-21 15:39 [binutils-gdb] Move register_dump to regcache-dump.c sergiodj+buildbot
2018-02-22  8:18 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-21 13:27 [binutils-gdb] Pass readable_regcache to gdbarch method read_pc sergiodj+buildbot
2018-02-22 10:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-21 12:50 [binutils-gdb] No longer create readonly regcache sergiodj+buildbot
2018-02-22  4:57 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-21 12:25 [binutils-gdb] Class detached_regcache sergiodj+buildbot
2018-02-22  0:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-21 12:12 [binutils-gdb] Class readonly_detached_regcache sergiodj+buildbot
2018-02-21 21:45 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-21 12:00 [binutils-gdb] Remove regcache_save and regcache_cpy sergiodj+buildbot
2018-02-21 19:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-21 11:47 [binutils-gdb] class readable_regcache and pass readable_regcache to gdbarch pseudo_register_read and pseudo_register_read_value sergiodj+buildbot
2018-02-21 16:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-21 11:39 [binutils-gdb] Class reg_buffer sergiodj+buildbot
2018-02-21 13:53 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-20 21:11 [binutils-gdb] MIPS16/opcodes: Free up `M' operand code sergiodj+buildbot
2018-02-20 23:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-20 16:58 [binutils-gdb] remote-sim: Add missing ATTRIBUTE_PRINTF sergiodj+buildbot
2018-02-20 20:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-20 14:56 [binutils-gdb] Enable link time garbage collection support for the IA64 target sergiodj+buildbot
2018-02-20 19:00 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-20 11:13 [binutils-gdb] Fix make 3.81 build errors sergiodj+buildbot
2018-02-20 13:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-19  3:38 [binutils-gdb] PT_LOAD and PT_GNU_RELRO segment overlap sergiodj+buildbot
2018-02-19  5:03 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-16 16:34 [binutils-gdb] New class allocate_on_obstack sergiodj+buildbot
2018-02-16 18:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-15 22:04 [binutils-gdb] RISC-V: Fix relocation failure with zero address sections sergiodj+buildbot
2018-02-16  0:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-15 19:14 [binutils-gdb] RISC-V: Give error for ignored pcrel_lo addend sergiodj+buildbot
2018-02-15 21:59 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-15 15:29 [binutils-gdb] PR ld/22832 on SPARC sergiodj+buildbot
2018-02-15 20:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-15  4:34 [binutils-gdb] delete ada-lang.c::ada_to_fixed_value_create advance declaration sergiodj+buildbot
2018-02-15  5:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-14 19:26 [binutils-gdb] Fix GDB crash after Quit thrown from unwinder sniffer sergiodj+buildbot
2018-02-15  4:00 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-14 16:14 [binutils-gdb] Constify target_so_ops::bfd_open sergiodj+buildbot
2018-02-15  2:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-14 15:50 [binutils-gdb] Move some declarations to source.h sergiodj+buildbot
2018-02-14 22:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-14 15:37 [binutils-gdb] Return unique_xmalloc_ptr from some solib.c functions sergiodj+buildbot
2018-02-14 19:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-14 15:16 [binutils-gdb] Fix compilation of the BFD sub-directory with a gcc v8 compiler by adding extra casts sergiodj+buildbot
2018-02-14 17:45 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-13 22:52 [binutils-gdb] x86: Properly check building shared library sergiodj+buildbot
2018-02-14  3:48 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-13 17:36 [binutils-gdb] Use enum flags for flags passed to openp sergiodj+buildbot
2018-02-14  2:10 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-13 15:51 [binutils-gdb] x86-64: Generate branch with PLT32 relocation sergiodj+buildbot
2018-02-14  0:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-13 13:43 [binutils-gdb] Fix compile time warning messages from gcc version 8 about cast between incompatible function types sergiodj+buildbot
2018-02-13 20:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-13 13:31 [binutils-gdb] WebAssembly: Disable subdirectory configuration for unsupported LD sergiodj+buildbot
2018-02-13 19:13 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-13 13:28 [binutils-gdb] WebAssembly: Correct an `index' global shadowing error for pre-4.8 GCC sergiodj+buildbot
2018-02-13 16:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-13  6:47 [binutils-gdb] Fix prefix of maint set/show per-command sergiodj+buildbot
2018-02-13  7:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-13  0:11 [binutils-gdb] gdb: Remove cleanup from dw2_do_instantiate_symtab sergiodj+buildbot
2018-02-13  2:18 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-12 15:14 [binutils-gdb] MIPS: Fix encoding for MIPSr6 sigrie instruction sergiodj+buildbot
2018-02-12 22:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-12 13:36 [binutils-gdb] Add support for reading msdos MZ executables sergiodj+buildbot
2018-02-12 19:59 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-12 12:16 [binutils-gdb] oops - actually remove the assignment this time: bfd/elf32-nds32.c:9693]: (warning) Redundant assignment of 'irel->r_addend' to itself sergiodj+buildbot
2018-02-12 15:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-09 19:26 [binutils-gdb] Don't reference past the end of the vector sergiodj+buildbot
2018-02-11  2:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-09 17:02 [binutils-gdb] x86: Add is_solaris to elf_x86_target_os sergiodj+buildbot
2018-02-11  4:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-09 15:25 [binutils-gdb] btrace: reword error messages sergiodj+buildbot
2018-02-10 23:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-09 15:12 [binutils-gdb] btrace: check perf_event_paranoid sergiodj+buildbot
2018-02-10 21:49 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-09 15:00 [binutils-gdb] btrace: improve enable error messages sergiodj+buildbot
2018-02-10 19:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-09 14:22 [binutils-gdb] btrace: prepare for throwing exceptions when enabling btrace sergiodj+buildbot
2018-02-10 11:59 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-09 12:24 [binutils-gdb] gdb/NEWS: Clarify the news entry for "rbreak" in GDB 8.1 sergiodj+buildbot
2018-02-09 20:49 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-08 23:17 [binutils-gdb] Remove cleanups from solib.c sergiodj+buildbot
2018-02-09 12:58 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-08 22:04 [binutils-gdb] Use std::string in maybe_expand sergiodj+buildbot
2018-02-09  5:14 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-08 20:47 [binutils-gdb] Class-ify macro_buffer sergiodj+buildbot
2018-02-09  3:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-08 20:13 [binutils-gdb] Remove cleanups from macro_define_command sergiodj+buildbot
2018-02-09  6:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-08 19:32 [binutils-gdb] Return unique_xmalloc_ptr from macro scope functions sergiodj+buildbot
2018-02-09  1:24 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-08 19:05 [binutils-gdb] Remove a cleanup from gdbserver sergiodj+buildbot
2018-02-08 20:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-07 14:04 [binutils-gdb] Fix type of values representing optimized out static members sergiodj+buildbot
2018-02-07 15:30 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-07  4:11 [binutils-gdb] Revert "PowerPC PLT speculative execution barriers" sergiodj+buildbot
2018-02-07 12:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-07  1:08 [binutils-gdb] RISC-V: Eliminate spurious error w/ reloc truncated message sergiodj+buildbot
2018-02-07  9:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-06 20:29 [binutils-gdb] Remove some $ARCH_read_pc and $ARCH_write_pc sergiodj+buildbot
2018-02-07  7:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-06 17:43 [binutils-gdb] Fix PR ld/22263 on SPARC sergiodj+buildbot
2018-02-07  5:06 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-06 17:17 [binutils-gdb] Improve the find_nearest_line function for the MIPS target so that it tries harder to find a function name sergiodj+buildbot
2018-02-07  0:59 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-06 16:48 [binutils-gdb] Prevent attempts to call strncpy with a zero-length field by chacking the size of debuglink sections sergiodj+buildbot
2018-02-06 21:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-06 16:04 [binutils-gdb] Allow the find_abstract_instance_name() function in the BFD library to also return file and line number information sergiodj+buildbot
2018-02-06 18:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-05 19:45 [binutils-gdb] ppc64: Fix stwux encoding sergiodj+buildbot
2018-02-06  8:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-05 18:56 [binutils-gdb] [PR22764][LD][AARCH64]Allow R_AARCH64_ABS16 and R_AARCH64_ABS32 against absolution symbol or undefine symbol in shared object sergiodj+buildbot
2018-02-06  7:08 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-05 18:11 [binutils-gdb] Remove myself as a write-after-approval GDB maintainer sergiodj+buildbot
2018-02-06  5:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-05 17:05 [binutils-gdb] x86: Remove the unused _GLOBAL_OFFSET_TABLE_ sergiodj+buildbot
2018-02-06  3:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-05 14:42 [binutils-gdb] RISC-V/BFD: Correct a missing initializer error with pre-4.7 GCC sergiodj+buildbot
2018-02-05 23:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-05 14:29 [binutils-gdb] MIPS/BFD: Correctly report unsupported `.reginfo' section size sergiodj+buildbot
2018-02-05 21:57 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-05  8:46 [binutils-gdb] Align natural-format register values to the same column sergiodj+buildbot
2018-02-05 11:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-05  5:03 [binutils-gdb] Move comment in gdb/dwarf2read.c::dwarf2_physname sergiodj+buildbot
2018-02-05  6:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-03 17:11 [binutils-gdb] gdb/testsuite: Remove use of dejagnu cleanup proc sergiodj+buildbot
2018-02-03 19:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-02 20:58 [binutils-gdb] RISC-V: Fix --wrap and relaxation conflict sergiodj+buildbot
2018-02-02 22:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-02 19:21 [binutils-gdb] MI: Allow non-raw varobj evaluation sergiodj+buildbot
2018-02-02 20:50 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-02  3:50 [binutils-gdb] Do not classify C struct members as a filename sergiodj+buildbot
2018-02-02  5:13 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-01 16:11 [binutils-gdb] Rewrite arm_record_coproc_data_proc and arm_record_data_proc_misc_ld_str sergiodj+buildbot
2018-02-01 21:08 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-01 15:47 [binutils-gdb] set ret signed in arm_record_extension_space sergiodj+buildbot
2018-02-01 19:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-02-01 15:05 [binutils-gdb] Fix gdb.base/attach.exp fails when gdb is configured --with-sysroot=/ sergiodj+buildbot
2018-02-01 17:18 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-31 15:21 [binutils-gdb] gdb: Fix remote-sim/MinGW/Darwin builds sergiodj+buildbot
2018-02-01  4:15 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-31 13:56 [binutils-gdb] (Ada) C++fy conditional string when catching exception sergiodj+buildbot
2018-01-31 19:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-31 13:56 [binutils-gdb] Check if __start/__stop symbols are referenced by shared objects sergiodj+buildbot
2018-01-31 23:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-31 13:41 [binutils-gdb] (Ada) Add gdb-mi support for stopping at start of exception handler sergiodj+buildbot
2018-01-31 21:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-31 13:03 [binutils-gdb] (Ada) Add testcase for catch assert with condition sergiodj+buildbot
2018-01-31 14:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-31  7:35 [binutils-gdb] internal-error using '@' (repeat) operator on array of dynamic objects sergiodj+buildbot
2018-01-31  9:59 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-30 18:05 [binutils-gdb] Improve junk file removal in source tarball creation script sergiodj+buildbot
2018-01-30 23:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-30 16:06 [binutils-gdb] Per-inferior target_terminal state, fix PR gdb/13211, more sergiodj+buildbot
2018-01-30 19:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-30 15:53 [binutils-gdb] linux-nat: Eliminate custom target_terminal_{inferior, ours}, stop using set_sigint_trap sergiodj+buildbot
2018-01-30 17:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-30  8:44 [binutils-gdb] PR22758, FAIL: Run pr22393-2 sergiodj+buildbot
2018-01-30 11:29 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-29 18:21 [binutils-gdb] Don't call "detach_inferior" on "remote_follow_fork" sergiodj+buildbot
2018-01-29 20:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-29 13:45 [binutils-gdb] Prevent patch remnants from being included in release tarballs sergiodj+buildbot
2018-01-29 15:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-28 17:24 [binutils-gdb] Remove dwarf2_per_objfile_free and use after free of dwarf2_per_objfile sergiodj+buildbot
2018-01-28 18:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-27 17:07 [binutils-gdb] Avoid compilation errors in MinGW native builds of GDB sergiodj+buildbot
2018-01-27 21:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-26 15:05 [binutils-gdb] Add myself as a write-after-approval GDB maintainer sergiodj+buildbot
2018-01-26 16:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-26  6:02 [binutils-gdb] Define __start/__stop symbols when there is only a dynamic def sergiodj+buildbot
2018-01-26  9:03 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-26  5:34 [binutils-gdb] PowerPC64 .branch_lt size change leads to "stubs don't match calculated size" sergiodj+buildbot
2018-01-26  6:58 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-25 11:50 [binutils-gdb] PR22746, crash when running 32-bit objdump on corrupted file sergiodj+buildbot
2018-01-25 15:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-25 11:35 [binutils-gdb] Fix PR ld/22727 (TLS breakage in PIC/PIE mode on SPARC) sergiodj+buildbot
2018-01-25 13:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-24 18:49 [binutils-gdb] Fix GCC PR83906 - [8 Regression] Random FAIL: libstdc++-prettyprinters/80276.cc whatis p4 sergiodj+buildbot
2018-01-25  1:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-24 16:51 [binutils-gdb] [LD][AARCH64]Add group relocations to create PC-relative offset sergiodj+buildbot
2018-01-24 23:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-24 16:36 [binutils-gdb] [GAS][AARCH64]Add group relocations to create PC-relative offset sergiodj+buildbot
2018-01-24 20:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-23 19:18 [binutils-gdb] MIPS/BFD: Update a stale `mips_elf32_section_processing' reference sergiodj+buildbot
2018-01-24 17:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-23 17:39 [binutils-gdb] Enable Intel PCONFIG instruction sergiodj+buildbot
2018-01-24 14:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-23 17:26 [binutils-gdb] Enable Intel WBNOINVD instruction sergiodj+buildbot
2018-01-24 12:11 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-23 17:23 [binutils-gdb] s390: if -> gdb_assert for tdesc_has_registers check sergiodj+buildbot
2018-01-23 23:59 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-23 16:25 [binutils-gdb] s390: Move tdesc validation to separate function sergiodj+buildbot
2018-01-23 22:11 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-23 15:13 [binutils-gdb] s390: Move record-replay to s390-tdep.c sergiodj+buildbot
2018-01-24  7:13 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-23 14:44 [binutils-gdb] s390: gdbarch_tdep add hook for syscall record sergiodj+buildbot
2018-01-24  3:48 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-23 14:44 [binutils-gdb] s390: gdbarch_tdep.have_* int -> bool sergiodj+buildbot
2018-01-23 18:57 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-23 14:30 [binutils-gdb] s390: Hook s390 into OSABI mechanism sergiodj+buildbot
2018-01-24  1:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-23 13:15 [binutils-gdb] s390: Allocate gdbarch & tdep at start of gdbarch_init sergiodj+buildbot
2018-01-23 16:22 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-22 15:56 [binutils-gdb] MAINTAINERS: Update my company e-mail address sergiodj+buildbot
2018-01-23  2:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-22 13:34 [binutils-gdb] regcache_cooked_read -> regcache->cooked_read sergiodj+buildbot
2018-01-22 22:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-22 12:07 [binutils-gdb] Remove mt port sergiodj+buildbot
2018-01-22 16:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-22 11:47 [binutils-gdb] Replace regcache_raw_read with regcache->raw_read sergiodj+buildbot
2018-01-22 18:58 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-22  5:10 [binutils-gdb] Ada/DWARF: Assume the Ada compiler produces descriptive type attributes sergiodj+buildbot
2018-01-22  8:20 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-22  4:32 [binutils-gdb] wrong line number in breakpoint location sergiodj+buildbot
2018-01-22  6:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-21 19:13 [binutils-gdb] gdb: Don't store a thread-id for floating varobj sergiodj+buildbot
2018-01-22  3:30 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-21 17:01 [binutils-gdb] gdb: PR mi/20395: Fix -var-update for registers in frames 1 and up sergiodj+buildbot
2018-01-21 22:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-21 16:50 [binutils-gdb] gdb: New API for tracking innermost block sergiodj+buildbot
2018-01-21 20:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-21 16:42 [binutils-gdb] gdb: Remove out of date comment sergiodj+buildbot
2018-01-22  0:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-21 16:05 [binutils-gdb] gdb: Remove duplicate declaration of global innermost_block sergiodj+buildbot
2018-01-21 18:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-20 22:46 [binutils-gdb] x86: Check the versioned __tls_get_addr symbol sergiodj+buildbot
2018-01-21  1:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-19 22:47 [binutils-gdb] Fix qualified name lookup for Rust sergiodj+buildbot
2018-01-20 22:46 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-19 19:19 [binutils-gdb] S390: Fix infcalls in s390-vregs test case sergiodj+buildbot
2018-01-20 20:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-19 19:04 [binutils-gdb] gdb: Fix ia64 defining TRAP_HWBKPT before including gdb_wait.h sergiodj+buildbot
2018-01-20 15:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-19 17:48 [binutils-gdb] Make linux_nat_detach/thread_db_detach use the inferior parameter sergiodj+buildbot
2018-01-20 13:18 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-19 17:34 [binutils-gdb] Pass inferior down to target_detach and to_detach sergiodj+buildbot
2018-01-20 11:03 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-19 13:35 [binutils-gdb] S390: Improve comments for s390-tdbregs test case sergiodj+buildbot
2018-01-20  6:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-19 11:05 [binutils-gdb] Update French translation in bfd sub-directory sergiodj+buildbot
2018-01-20  4:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-19 10:00 [binutils-gdb] Don't pass -m32 to libcc1 on arm-linux sergiodj+buildbot
2018-01-20  0:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-19  9:33 [binutils-gdb] Find arm-linux-gnueabi(hf)?-gcc in compile sergiodj+buildbot
2018-01-19 23:00 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-18 19:09 [binutils-gdb] GDB testsuite: Re-enable -fdiagnostics-color=never sergiodj+buildbot
2018-01-19 19:44 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-18 15:43 [binutils-gdb] Make abbrev_table::abbrevs private sergiodj+buildbot
2018-01-19 15:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-18 12:35 [binutils-gdb] Call cooked_read in ppu2spu_prev_register sergiodj+buildbot
2018-01-19 12:49 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-18 12:14 [binutils-gdb] PowerPC PLT stub alignment fixes sergiodj+buildbot
2018-01-19 10:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-17 23:20 [binutils-gdb] Fix warning on gdb/compile/compile.c (C++-ify "triplet_rx") sergiodj+buildbot
2018-01-19  4:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-17 22:21 [binutils-gdb] RISC-V: Fix bug in prior addi/c.nop patch sergiodj+buildbot
2018-01-19  2:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-17 20:21 [binutils-gdb] Remove symbolp typedef sergiodj+buildbot
2018-01-18 23:54 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-17 20:16 [binutils-gdb] Allocate abbrev_table with new sergiodj+buildbot
2018-01-18 15:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-17 19:57 [binutils-gdb] Change dwarf2_cu::method_info to be a std::vector sergiodj+buildbot
2018-01-18 19:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-17 19:45 [binutils-gdb] Allocate dwarf2_cu with new sergiodj+buildbot
2018-01-18 17:11 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-17 19:20 [binutils-gdb] Unify new_symbol and new_symbol_full sergiodj+buildbot
2018-01-18 13:50 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-17 18:49 [binutils-gdb] Fix gdb segv when objfile can't be opened sergiodj+buildbot
2018-01-18 11:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-17 17:59 [binutils-gdb] Make linux_ptrace_attach_fail_reason return an std::string sergiodj+buildbot
2018-01-18  9:05 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-17 17:04 [binutils-gdb] Replace CET bit with IBT and SHSTK bits sergiodj+buildbot
2018-01-18  5:20 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-17 13:48 [binutils-gdb] configure: Fix test for fs_base/gs_base in <sys/user.h> sergiodj+buildbot
2018-01-17 23:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-17 11:56 [binutils-gdb] Relax gdb.compile/compile.exp to match the address printed for frame sergiodj+buildbot
2018-01-17 15:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-17 11:10 [binutils-gdb] Warning fix sergiodj+buildbot
2018-01-17 12:56 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-16 13:03 [binutils-gdb] Update translations for various binutils components sergiodj+buildbot
2018-01-16 14:45 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-16  9:25 [binutils-gdb] Mark register unavailable when PTRACE_PEEKUSER fails sergiodj+buildbot
2018-01-16 11:44 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-15 23:14 [binutils-gdb] gdb/common/signals-state-save-restore.c: Fix typos sergiodj+buildbot
2018-01-16  2:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-15 12:32 [binutils-gdb] Update Ukranian translations for bfd, binutils, gas, gold, ld and opcodes sergiodj+buildbot
2018-01-15 13:53 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-13 16:17 [binutils-gdb] Update notes on how to make a release sergiodj+buildbot
2018-01-14  4:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-13 15:45 [binutils-gdb] Update pot files sergiodj+buildbot
2018-01-14  1:53 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-13 14:31 [binutils-gdb] Bump version number to 2.30.51 sergiodj+buildbot
2018-01-13 23:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-13 13:46 [binutils-gdb] Add note about 2.30 branch creation to changelogs sergiodj+buildbot
2018-01-13 21:24 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-13  0:00 [binutils-gdb] gdb/testsuite: Don't attempt tests if they fail to compile sergiodj+buildbot
2018-01-13 18:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-12 23:43 [binutils-gdb] Install and generate docs for gdb-add-index sergiodj+buildbot
2018-01-13 16:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-12 22:32 [binutils-gdb] Use the correct value for the offset of 'kve_protection' sergiodj+buildbot
2018-01-13 13:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-12 19:19 [binutils-gdb] Fix GDB hang with remote after error from resume sergiodj+buildbot
2018-01-13  3:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-12 11:55 [binutils-gdb] Fix override of common symbols for a.out sergiodj+buildbot
2018-01-12 23:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-12  4:24 [binutils-gdb] ld: Create a new LOAD segment for separate code segment sergiodj+buildbot
2018-01-12 12:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-12  2:29 [binutils-gdb] gdb_compile_shlib: Only consider shlib= options when building executables sergiodj+buildbot
2018-01-12  7:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-11 23:57 [binutils-gdb] Ignore dynamic references on forced local symbols sergiodj+buildbot
2018-01-12  5:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-11 19:05 [binutils-gdb] gdb.base/breakpoint-in-ro-region.exp regression on sss targets (PR gdb/22583) sergiodj+buildbot
2018-01-12  0:15 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-11 18:02 [binutils-gdb] ld: Keep PREINIT_ARRAY/INIT_ARRAY/FINI_ARRAY sections for -r --gc-sections sergiodj+buildbot
2018-01-11 22:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-11  5:36 [binutils-gdb] Remove VL variants for 4FMAPS and 4VNNIW insns sergiodj+buildbot
2018-01-11 15:58 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-11  1:53 [binutils-gdb] language_get_symbol_name_matcher -> get_symbol_name_matcher sergiodj+buildbot
2018-01-11  7:14 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-11  1:05 [binutils-gdb] Ada: make verbatim matcher override other language matchers (PR gdb/22670) sergiodj+buildbot
2018-01-11  5:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-11  0:21 [binutils-gdb] Fix gdb.ada/complete.exp's "complete break ada" test (PR gdb/22670) sergiodj+buildbot
2018-01-11  3:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-10 23:32 [binutils-gdb] Fix gdb.ada/bp_c_mixed_case.exp (PR gdb/22670) sergiodj+buildbot
2018-01-11  0:58 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-10 14:58 [binutils-gdb] x86: fix Disp8 handling for scalar AVX512_4FMAPS insns sergiodj+buildbot
2018-01-10 19:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-10 14:11 [binutils-gdb] x86: fix Disp8 handling for AVX512VL VPCMP*{B, W} variants sergiodj+buildbot
2018-01-10 16:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-10  0:28 [binutils-gdb] Support 'info proc' for native FreeBSD processes sergiodj+buildbot
2018-01-10  7:56 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-09 22:14 [binutils-gdb] Support 'info proc' for FreeBSD process core dumps sergiodj+buildbot
2018-01-09 23:54 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-09 14:53 [binutils-gdb] [Arm] Add CSDB instruction sergiodj+buildbot
2018-01-09 18:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-09 10:03 [binutils-gdb] Fix breakpoint add on inlined function using function name sergiodj+buildbot
2018-01-09 14:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-08 13:11 [binutils-gdb] x86: Properly encode vmovd with 64-bit memeory sergiodj+buildbot
2018-01-08 21:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-08 11:41 [binutils-gdb] Fix GDBserver build failure when $development is false sergiodj+buildbot
2018-01-08 15:56 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-08 10:42 [binutils-gdb] Fix GDB build failure when $development is false sergiodj+buildbot
2018-01-08 14:05 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-08 10:02 [binutils-gdb] Relax expected output in gdb.ada/access_tagged_param.exp test sergiodj+buildbot
2018-01-08 12:14 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-08  5:16 [binutils-gdb] (Ada) Fix print of array using non-contiguous enumeration indexes sergiodj+buildbot
2018-01-08  7:58 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-07 19:29 [binutils-gdb] Remove dwarf2_per_objfile global sergiodj+buildbot
2018-01-08  4:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-07 18:45 [binutils-gdb] Replace objfile field in dwarf2_cu and dwarf2_per_cu_data with dwarf2_per_objfile sergiodj+buildbot
2018-01-08  2:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-07 18:03 [binutils-gdb] Make parse_debug_format_options return an std::string sergiodj+buildbot
2018-01-08  0:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-07 17:08 [binutils-gdb] Replace VEC(converted_character_d) with std::vector sergiodj+buildbot
2018-01-07 22:57 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-07 15:59 [binutils-gdb] Remove xmethod_worker::clone sergiodj+buildbot
2018-01-07 18:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-07 14:48 [binutils-gdb] C++ify xmethod_worker, get rid of VEC(xmethod_worker_ptr) sergiodj+buildbot
2018-01-07 16:48 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-06  2:13 [binutils-gdb] RISC-V: Print symbol address for jalr w/ zero offset sergiodj+buildbot
2018-01-06  9:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-05 18:57 [binutils-gdb] Fix gdb/spu-tdep.c build breakage sergiodj+buildbot
2018-01-06  2:24 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-05 17:13 [binutils-gdb] Fix gdb.ada/info_addr_mixed_case.exp (PR gdb/22670) sergiodj+buildbot
2018-01-05 23:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-05 13:34 [binutils-gdb] (Ada) problem printing renaming which references a subprogram parameter sergiodj+buildbot
2018-01-05 21:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-05 11:59 [binutils-gdb] (Ada) Fix Length attribute on array access sergiodj+buildbot
2018-01-05 18:18 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-05  7:31 [binutils-gdb] (Ada) Remove printing of array's first index when unneeded sergiodj+buildbot
2018-01-05 14:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-05  5:59 [binutils-gdb] Bump version to 8.1.50.DATE-git sergiodj+buildbot
2018-01-05 10:15 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-04 22:38 [binutils-gdb] RISC-V: Add 2 missing privileged registers sergiodj+buildbot
2018-01-05  0:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-04 11:13 [binutils-gdb] gdb.ada/maint_with_ada.exp: New testcase sergiodj+buildbot
2018-01-04 18:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-04 10:28 [binutils-gdb] Add new gdb.ada/bp_c_mixed_case testcase for PR gdb/22670 sergiodj+buildbot
2018-01-04 16:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-03 20:29 [binutils-gdb] Create pseudo sections for FreeBSD NT_PROCSTAT_(PROC|FILES|VMMAP) notes sergiodj+buildbot
2018-01-03 21:53 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-03  7:50 [binutils-gdb] Update year range in copyright notice of binutils files sergiodj+buildbot
2018-01-03  9:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-03  4:17 [binutils-gdb] Unbreak spurious fails in gdb.base/step-line.exp sergiodj+buildbot
2018-01-03  6:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-02 17:37 [binutils-gdb] Fix compile time warning (in the ARM simulator) about a print statement with insufficient arguments sergiodj+buildbot
2018-01-03  0:05 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-02  9:37 [binutils-gdb] [gdb/Ada] slices of arrays with dynamic strides sergiodj+buildbot
2018-01-02 20:03 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-02  8:44 [binutils-gdb] Add support for dynamic DW_AT_byte_stride sergiodj+buildbot
2018-01-02 17:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-02  7:54 [binutils-gdb] treat Ada DW_TAG_unspecified_type DIEs as stub types sergiodj+buildbot
2018-01-02 15:29 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-02  6:58 [binutils-gdb] Update copyright year range in all GDB files sergiodj+buildbot
2018-01-02 13:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-02  4:44 [binutils-gdb] Update copyright year in version message of GDB, GDBserver and GDBreplay sergiodj+buildbot
2018-01-02  7:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2018-01-02  3:57 [binutils-gdb] Yearly rotation of the gdb/ChangeLog file sergiodj+buildbot
2018-01-02  5:29 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-31 11:04 [binutils-gdb] Avoid indexing std::vector past the end sergiodj+buildbot
2017-12-31 16:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-31  4:57 [binutils-gdb] Only ignore -Wenum-compare-switch if it exists sergiodj+buildbot
2017-12-31  6:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-30  7:02 [binutils-gdb] Make mapped_debug_names and mapped_index final sergiodj+buildbot
2017-12-30  8:20 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-30  3:17 [binutils-gdb] Remove unnecessary call to get_thread_db_info sergiodj+buildbot
2017-12-30  5:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-28 21:41 [binutils-gdb] RISC-V: Add missing privileged spec registers sergiodj+buildbot
2017-12-28 23:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-27 17:51 [binutils-gdb] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p sergiodj+buildbot
2017-12-28  0:29 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-27 15:46 [binutils-gdb] reggroups: Convert reggroups from post_init to pre_init sergiodj+buildbot
2017-12-27 19:29 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-27 15:03 [binutils-gdb] reggroups: Add test and docs for `info reg $reggroup` feature sergiodj+buildbot
2017-12-27 16:24 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-23 21:51 [binutils-gdb] Add ATTRIBUTE_PRINTF to printf_field_type_assignment sergiodj+buildbot
2017-12-23 23:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-21 23:57 [binutils-gdb] Do not emit "field_type" var if not needed on "maint print c-tdesc" sergiodj+buildbot
2017-12-22  1:44 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-20 21:59 [binutils-gdb] RISC-V: Add compressed instruction hints, and a few misc cleanups sergiodj+buildbot
2017-12-21  0:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-20 13:37 [binutils-gdb] [Cell/B.E.] Fix regression due to gdbarch_significant_addr_bit sergiodj+buildbot
2017-12-20 16:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-18 22:34 [binutils-gdb] PR22626, invalid dynindx used for dynamic relocs against section syms sergiodj+buildbot
2017-12-18 23:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-18 11:26 [binutils-gdb] x86: fold certain AVX and AVX2 templates sergiodj+buildbot
2017-12-18 14:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-18 10:42 [binutils-gdb] x86: fold RegXMM/RegYMM/RegZMM into RegSIMD sergiodj+buildbot
2017-12-18 13:22 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-18  9:35 [binutils-gdb] x86: drop FloatReg and FloatAcc sergiodj+buildbot
2017-12-18 12:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-18  8:56 [binutils-gdb] x86: replace Reg8, Reg16, Reg32, and Reg64 sergiodj+buildbot
2017-12-18 10:50 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-18  4:51 [binutils-gdb] improved error message when getting an exception printing a variable sergiodj+buildbot
2017-12-18  8:33 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-18  4:13 [binutils-gdb] (Ada) crash assigning to record component which is an array sergiodj+buildbot
2017-12-18  6:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-18  3:22 [binutils-gdb] Ada: fix bad handling in ada_convert_actual sergiodj+buildbot
2017-12-18  4:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-16 23:29 [binutils-gdb] gdb: Fix function parameter alignments in or1k-tdep.c sergiodj+buildbot
2017-12-17  1:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-16  3:54 [binutils-gdb] Fix ARI warning on gdb/typeprint.c:whatis_exp sergiodj+buildbot
2017-12-16  6:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-15 19:31 [binutils-gdb] Update documentation regarding the bfd returned by bfd_openr_next_archived_file sergiodj+buildbot
2017-12-15 21:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-15 18:35 [binutils-gdb] Fix PR19061, gdb hangs/spins-on-cpu when debugging any program on Alpha sergiodj+buildbot
2017-12-15 19:46 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-15 11:47 [binutils-gdb] Skip 'maintenance check xml-descriptions' if XML is disabled sergiodj+buildbot
2017-12-15 15:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-15 11:06 [binutils-gdb] Skip parse_memory_map_tests if XML is disabled sergiodj+buildbot
2017-12-15 12:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-15  9:44 [binutils-gdb] Fix disassembly for PowerPC sergiodj+buildbot
2017-12-15 11:10 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-15  8:34 [binutils-gdb] x86: drop stray CheckRegSize uses sergiodj+buildbot
2017-12-15  9:47 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-14 21:04 [binutils-gdb] py-breakpoint: Don't use the 'p' PyArg_ParseTupleAndKeywords format specifier sergiodj+buildbot
2017-12-14 22:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-14 13:12 [binutils-gdb] Update the address of the FSF in the copyright notice of files which were using the old address sergiodj+buildbot
2017-12-14 14:15 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-14  5:57 [binutils-gdb] Ada: unable to compare strings (Attempt to compare array with non-array) sergiodj+buildbot
2017-12-14  7:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-14  4:30 [binutils-gdb] (Ada) Add support for task switching when debugging core files sergiodj+buildbot
2017-12-14  6:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-13 23:20 [binutils-gdb] Add missing RISC-V fsrmi and fsflagsi instructions sergiodj+buildbot
2017-12-14  3:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-13 17:54 [binutils-gdb] Fix regression: expression completer and scope operator (PR gdb/22584) sergiodj+buildbot
2017-12-13 22:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-13 16:11 [binutils-gdb] [BFD][AARCH64]Disallow R_AARCH64_ABS32(LP64) & R_AARCH64_ABS16 in const section of shared object sergiodj+buildbot
2017-12-13 19:56 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-13 15:34 [binutils-gdb] gdb: Fix ARI warnings in or1k-tdep.c sergiodj+buildbot
2017-12-13 18:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-13 14:53 [binutils-gdb] Fix typo in gdb_ari.sh sergiodj+buildbot
2017-12-13 17:11 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-13 13:44 [binutils-gdb] This patch enables disassembler_needs_relocs for PRU. It is needed to print correct symbols when disassembling arguments of "call" instructions with a relocation sergiodj+buildbot
2017-12-13 15:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-13 12:54 [binutils-gdb] S/390: Fix (some) PIE+undef weak failures sergiodj+buildbot
2017-12-13 13:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-12 20:43 [binutils-gdb] sim: or1k: add cgen generated files sergiodj+buildbot
2017-12-13  3:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-12 19:10 [binutils-gdb] sim: cgen: add MUL2OFSI and MUL1OFSI functions (needed for OR1K l.mul[u]) sergiodj+buildbot
2017-12-13  0:53 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-12 17:32 [binutils-gdb] Add gdb for or1k build sergiodj+buildbot
2017-12-12 21:30 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-12 15:17 [binutils-gdb] gdb: Add OpenRISC or1k and or1knd target support sergiodj+buildbot
2017-12-12 16:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-12 13:33 [binutils-gdb] PR22576, ppc64_skip_trampoline_code uses wrong r2 for EXEC_REVERSE sergiodj+buildbot
2017-12-12 14:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-12  2:28 [binutils-gdb] remote: Return NULL extra_info/name if they are empty sergiodj+buildbot
2017-12-12  4:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-11 16:19 [binutils-gdb] [Binutils][Objdump]Check symbol section information while search a mapping symbol backward sergiodj+buildbot
2017-12-11 18:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-11 14:55 [binutils-gdb] [MPFR] Fix regression on 32-bit host systems sergiodj+buildbot
2017-12-11 15:45 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-11  8:38 [binutils-gdb] Adapt gdb.ada/variant_record_packed_array.exp to accept reordered components sergiodj+buildbot
2017-12-11  9:38 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-11  7:04 [binutils-gdb] (Ada) change tagged types base_address computation sergiodj+buildbot
2017-12-11  8:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-10 22:37 [binutils-gdb] Typo fix sergiodj+buildbot
2017-12-10 23:33 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-09  6:59 [binutils-gdb] dwarf2read.c: Rewrite/simplify mock_mapped_index sergiodj+buildbot
2017-12-09 16:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-09  5:22 [binutils-gdb] dwarf2read.c:mapped_index, use gdb::array_view, simplify symbol table sergiodj+buildbot
2017-12-09 14:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-09  4:00 [binutils-gdb] DWARF-5: .debug_names index consumer sergiodj+buildbot
2017-12-09 12:54 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-09  2:18 [binutils-gdb] Refactor: Move some generic code out of .gdb_index code sergiodj+buildbot
2017-12-09  9:46 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-09  0:04 [binutils-gdb] cc-with-tweaks.sh: Use gdb-add-index.sh sergiodj+buildbot
2017-12-09  5:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-08 20:59 [binutils-gdb] Fix thinko on dtrace-probe.c:dtrace_process_dof_probe sergiodj+buildbot
2017-12-09  1:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-08 19:17 [binutils-gdb] Adjust breakpoint address by clearing non-significant bits sergiodj+buildbot
2017-12-08 22:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-08 16:06 [binutils-gdb] Fix PR 22567: set SAL .section in minsym_found sergiodj+buildbot
2017-12-08 17:03 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-08  6:55 [binutils-gdb] Add aix 64-bit check to bfd_get_sign_extend_vma sergiodj+buildbot
2017-12-08  7:45 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-08  0:32 [binutils-gdb] Validate explicit locations with early termination sergiodj+buildbot
2017-12-08  5:50 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-07 23:49 [binutils-gdb] Record nested types sergiodj+buildbot
2017-12-08  4:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-07 22:54 [binutils-gdb] Fix wrong prefix in py-breakpoint.exp sergiodj+buildbot
2017-12-08  3:15 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-07 22:13 [binutils-gdb] Fix regression in "commands" sergiodj+buildbot
2017-12-08  1:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-07 19:41 [binutils-gdb] Fix build with g++ 6.3.1 sergiodj+buildbot
2017-12-08  0:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-07 17:45 [binutils-gdb] Add virtual destructor to selftest sergiodj+buildbot
2017-12-07 21:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-06 23:13 [binutils-gdb] target_set_syscall_catchpoint, use gdb::array_view and bool sergiodj+buildbot
2017-12-07  2:05 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-06  8:12 [binutils-gdb] dyn_relocs tidy sergiodj+buildbot
2017-12-06 19:11 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-06  5:26 [binutils-gdb] Make tdesc_type::u::u::fields an std::vector sergiodj+buildbot
2017-12-06 12:48 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-06  2:59 [binutils-gdb] Split tdesc_type into multiple classes sergiodj+buildbot
2017-12-06 15:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-06  1:26 [binutils-gdb] Make tdesc_type::name an std::string sergiodj+buildbot
2017-12-06 11:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-06  1:05 [binutils-gdb] Make tdesc_feature::types an std::vector sergiodj+buildbot
2017-12-06 10:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-06  0:44 [binutils-gdb] Make tdesc_reg string fields std::string sergiodj+buildbot
2017-12-06  8:22 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-06  0:22 [binutils-gdb] Make target_desc::features an std::vector sergiodj+buildbot
2017-12-06  4:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-05 23:22 [binutils-gdb] Make target_desc::compatible an std::vector sergiodj+buildbot
2017-12-06  3:03 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-05 22:53 [binutils-gdb] Make target_desc::properties an std::vector sergiodj+buildbot
2017-12-06  1:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-05 22:06 [binutils-gdb] Redefine gdb_static_assert as static_assert sergiodj+buildbot
2017-12-05 23:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-04 18:58 [binutils-gdb] Implement "-a" command line option for gcore sergiodj+buildbot
2017-12-04 22:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-04 18:27 [binutils-gdb] Document new {set, show} dump-excluded-mappings commands sergiodj+buildbot
2017-12-04 21:22 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-04 12:57 [binutils-gdb] x86 map file textrel sergiodj+buildbot
2017-12-04 15:33 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-03 18:49 [binutils-gdb] Remove mem_region_vector typedef sergiodj+buildbot
2017-12-04 14:18 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-03 18:21 [binutils-gdb] Make make-target-delegates grok namespace scope op and template params sergiodj+buildbot
2017-12-04 12:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-03 16:34 [binutils-gdb] Fix gdb.threads/process-dies-while-detaching.exp sergiodj+buildbot
2017-12-04 10:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-03 13:24 [binutils-gdb] Remove usage of find_inferior in linux_resume sergiodj+buildbot
2017-12-03 22:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-03 12:00 [binutils-gdb] Remove usage of find_inferior in linux_stabilize_threads sergiodj+buildbot
2017-12-03 19:48 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-03 10:23 [binutils-gdb] Remove usages of find_inferior calling not_stopped_callback sergiodj+buildbot
2017-12-03 17:08 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-03  9:36 [binutils-gdb] Remove for_each_inferior sergiodj+buildbot
2017-12-04  3:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-03  8:58 [binutils-gdb] Update comments sergiodj+buildbot
2017-12-04  0:49 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-03  8:38 [binutils-gdb] Remove usages of find_inferior that call proceed_one_lwp sergiodj+buildbot
2017-12-03 23:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-03  7:50 [binutils-gdb] Remove usages of find_inferior in stop_all_lwps sergiodj+buildbot
2017-12-03 21:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-03  6:09 [binutils-gdb] Remove find_inferior_in_random sergiodj+buildbot
2017-12-03 10:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-03  4:22 [binutils-gdb] Remove usage of find_inferior in last_thread_of_process_p sergiodj+buildbot
2017-12-03 12:00 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-03  3:14 [binutils-gdb] Remove find_inferior_id sergiodj+buildbot
2017-12-03  9:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-03  2:14 [binutils-gdb] Remove usage of find_inferior in regcache_invalidate_pid sergiodj+buildbot
2017-12-03  4:14 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-03  1:53 [binutils-gdb] Fix typo in poison.h sergiodj+buildbot
2017-12-03  2:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-02  2:52 [binutils-gdb] Add support for the readnever concept sergiodj+buildbot
2017-12-02  3:58 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-01 22:25 [binutils-gdb] Revert "Add support for the readnever concept" sergiodj+buildbot
2017-12-01 23:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-01 17:42 [binutils-gdb] Use consistent types for holding instructions, instruction masks, etc sergiodj+buildbot
2017-12-01 18:59 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-01 13:57 [binutils-gdb] Update GDB's list of maintainers to reflect today's reality sergiodj+buildbot
2017-12-01 15:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-01 12:37 [binutils-gdb] x86: Print dynreloc in readonly section for map file output sergiodj+buildbot
2017-12-01 14:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-01 12:00 [binutils-gdb] Replace mail address with the URL in copyright header sergiodj+buildbot
2017-12-01 13:05 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-12-01  0:13 [binutils-gdb] New gdb.ada/repeat_dyn testcase sergiodj+buildbot
2017-12-01  9:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-30 17:48 [binutils-gdb] Use boards/local-board.exp more sergiodj+buildbot
2017-12-01  5:29 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-30 16:51 [binutils-gdb] Fix gdb.linespec/cpls-ops.exp on 32-bit sergiodj+buildbot
2017-12-01  4:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-30 10:44 [binutils-gdb] Fix sol-thread.c compilation on Solaris sergiodj+buildbot
2017-11-30 19:56 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-30  1:14 [binutils-gdb] Define MPFR_USE_INTMAX_T so that mpfr.h assumes intmax_t is available sergiodj+buildbot
2017-11-30 18:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-29 22:06 [binutils-gdb] Breakpoints in symbols with ABI tags (PR c++/19436) sergiodj+buildbot
2017-11-30 14:03 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-29 21:46 [binutils-gdb] Make "break foo" find "A::foo", A::B::foo", etc. [C++ and wild matching] sergiodj+buildbot
2017-11-30 12:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-29 14:12 [binutils-gdb] [gdb/testsuite] Fix return type of psymtab-parameter sergiodj+buildbot
2017-11-29 20:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-29 11:10 [binutils-gdb] [gdb/testsuite] Fix wrong return type in tests sergiodj+buildbot
2017-11-29 18:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-28 12:59 [binutils-gdb] Copying symbol type in ld script assignments sergiodj+buildbot
2017-11-29  5:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-28 11:31 [binutils-gdb] Remove REMOTE_OBS sergiodj+buildbot
2017-11-29  1:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-28  6:09 [binutils-gdb] Move target object files to target subdirectory sergiodj+buildbot
2017-11-28 23:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-28  1:23 [binutils-gdb] Move cli object files to cli subdirectory sergiodj+buildbot
2017-11-28  4:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-28  0:24 [binutils-gdb] A simpler way to make the "arch" build directory sergiodj+buildbot
2017-11-28  2:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-27  1:09 [binutils-gdb] python: Fix memleak in do_start_initialization sergiodj+buildbot
2017-11-27  8:54 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-26 16:58 [binutils-gdb] [spu] Fix single-stepping regression sergiodj+buildbot
2017-11-26 18:20 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-25 14:48 [binutils-gdb] Fix PR gdb/22491: Regression when setting SystemTap probe semaphores sergiodj+buildbot
2017-11-26  3:50 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-25  8:52 [binutils-gdb] Add comprehensive C++ operator linespec/location/completion tests sergiodj+buildbot
2017-11-25 21:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-25  4:19 [binutils-gdb] Fix completing an empty string sergiodj+buildbot
2017-11-25 23:30 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-25  3:37 [binutils-gdb] Revert "elf: Properly compute offsets of note descriptor and next note" sergiodj+buildbot
2017-11-25 12:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-25  2:17 [binutils-gdb] Make strcmp_iw NOT ignore whitespace in the middle of tokens sergiodj+buildbot
2017-11-25 18:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-24 23:37 [binutils-gdb] Workaround build bug with GCC 6.2.1 sergiodj+buildbot
2017-11-25 10:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-24 22:43 [binutils-gdb] Fix aarch64-none-elf build error sergiodj+buildbot
2017-11-25  8:46 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-24 20:32 [binutils-gdb] Create private_thread_info hierarchy sergiodj+buildbot
2017-11-25  5:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-24 20:00 [binutils-gdb] remote: C++ify thread_item and threads_listing_context sergiodj+buildbot
2017-11-25  4:20 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-24 19:27 [binutils-gdb] Create private_inferior class hierarchy sergiodj+buildbot
2017-11-25  2:59 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-24 16:34 [binutils-gdb] elf: Properly compute offsets of note descriptor and next note sergiodj+buildbot
2017-11-24 22:08 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-24 14:23 [binutils-gdb] regcache::cooked_read unit test sergiodj+buildbot
2017-11-24 19:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-24 13:16 [binutils-gdb] gdbserver: add aarch64_create_target_description sergiodj+buildbot
2017-11-24 15:46 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-24 13:09 [binutils-gdb] Use flexible target descriptors for aarch64 sergiodj+buildbot
2017-11-24 17:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-24 11:34 [binutils-gdb] Change value_contents_eq return bool sergiodj+buildbot
2017-11-24 13:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-24 11:08 [binutils-gdb] Change register_changed_p returns bool sergiodj+buildbot
2017-11-24 12:05 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-24  9:50 [binutils-gdb] Change tic6x target descriptions sergiodj+buildbot
2017-11-24 10:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-24  8:04 [binutils-gdb] x86: don't omit disambiguating suffixes from "fi*" sergiodj+buildbot
2017-11-24  9:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-23 16:25 [binutils-gdb] [testsuite] Pass -g3 to clang in gdb.base/macscp.exp sergiodj+buildbot
2017-11-23 23:15 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-23 14:16 [binutils-gdb] Delete powerpc64 symbol weakref field sergiodj+buildbot
2017-11-23 18:49 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-23 13:28 [binutils-gdb] Rename u.weakdef and make it a circular list sergiodj+buildbot
2017-11-23 17:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-23 10:23 [binutils-gdb] x86: correct UDn sergiodj+buildbot
2017-11-23 15:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-23  0:50 [binutils-gdb] Convert DTrace probe interface to C++ (and perform some cleanups) sergiodj+buildbot
2017-11-23 13:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-22 23:51 [binutils-gdb] (Ada) ravenscar-thread.c: remove unwanted trailing \n in call to warning sergiodj+buildbot
2017-11-23 12:05 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-22 23:03 [binutils-gdb] C++ify osdata sergiodj+buildbot
2017-11-23 10:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-22 22:42 [binutils-gdb] Show optimized out local variables in "info locals" sergiodj+buildbot
2017-11-23  8:33 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-22 22:06 [binutils-gdb] Remove DEF_VEC_P (varobj_p) sergiodj+buildbot
2017-11-23  6:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-22 21:44 [binutils-gdb] Replace VEC (varobj_update_result) with std::vector sergiodj+buildbot
2017-11-23  5:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-22 21:06 [binutils-gdb] Basic c++ification of varobj sergiodj+buildbot
2017-11-23  2:10 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-22 20:57 [binutils-gdb] Make varobj::children an std::vector sergiodj+buildbot
2017-11-23  4:13 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-22 17:26 [binutils-gdb] [testsuite] Pass pthreads in prepare_for_testing sergiodj+buildbot
2017-11-22 23:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-22 17:05 [binutils-gdb] [testsuite] Don't skip gdb.dwarf2/pr10770.exp for non-gcc compiler sergiodj+buildbot
2017-11-22 22:29 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-22 16:44 [binutils-gdb] Remove Vec_Disp8 field for vgf2p8mulb for AVX flavor sergiodj+buildbot
2017-11-22 21:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-22 16:02 [binutils-gdb] Remove Vec_Disp8 from vpcompressb and vpexpandb sergiodj+buildbot
2017-11-22 18:49 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-22 13:23 [binutils-gdb] Fix build with GCC 8: strncpy ->strcpy sergiodj+buildbot
2017-11-22 15:03 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-22  2:56 [binutils-gdb] ravenscar: update inferior ptid with event ptid sergiodj+buildbot
2017-11-22  6:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-22  1:50 [binutils-gdb] (Ada) crash connecting to TSIM simulator sergiodj+buildbot
2017-11-22  5:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-22  1:10 [binutils-gdb] problem debugging ravenscar programs if runtime is stripped sergiodj+buildbot
2017-11-22  4:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-22  0:26 [binutils-gdb] Add multiple-CPU support in ravenscar-thread.c sergiodj+buildbot
2017-11-22  2:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-21 23:01 [binutils-gdb] watchpoint regression debugging with remote protocol (bare metal) sergiodj+buildbot
2017-11-21 23:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-21 18:08 [binutils-gdb] [PowerPC] Detect different long double floating-point formats sergiodj+buildbot
2017-11-21 19:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-21 17:30 [binutils-gdb] gdb.ada/minsyms.exp: Don't hardcode the variable's address sergiodj+buildbot
2017-11-21 18:22 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-21 14:17 [binutils-gdb] [ARC] Improve printing of pc-relative instructions sergiodj+buildbot
2017-11-21 15:15 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-21  4:54 [binutils-gdb] Fix build failure in darwin-nat.c sergiodj+buildbot
2017-11-21  7:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-21  2:07 [binutils-gdb] Fix mapped_index::find_name_components_bounds upper bound computation sergiodj+buildbot
2017-11-21  5:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-20 23:31 [binutils-gdb] Fix gdb.base/whatis-ptype-typedefs.exp on 32-bit archs sergiodj+buildbot
2017-11-21  0:18 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-20 14:38 [binutils-gdb] PR22451, strip no longer works on older object files sergiodj+buildbot
2017-11-20 21:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-20 10:03 [binutils-gdb] Remove usage of find_inferior when calling kill_one_lwp_callback sergiodj+buildbot
2017-11-20 20:38 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-20  9:29 [binutils-gdb] Remove usages of find_thread when calling need_step_over_p sergiodj+buildbot
2017-11-20 19:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-20  8:09 [binutils-gdb] Remove usage of find_inferior in unsuspend_all_lwps sergiodj+buildbot
2017-11-20 13:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-20  7:13 [binutils-gdb] Remove usage of find_inferior in linux_stabilize_threads sergiodj+buildbot
2017-11-20 14:54 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-20  5:53 [binutils-gdb] Remove usage of find_inferior in iterate_over_lwps sergiodj+buildbot
2017-11-20 12:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-20  5:03 [binutils-gdb] Remove usage of find_inferior in reset_lwp_ptrace_options_callback sergiodj+buildbot
2017-11-20 10:33 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-20  4:18 [binutils-gdb] Remove usage of find_inferior in win32-low.c sergiodj+buildbot
2017-11-20  5:06 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-19  1:27 [binutils-gdb] Fix error message typo sergiodj+buildbot
2017-11-19  1:30 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-17 22:40 [binutils-gdb] Make template_symbol derive from symbol sergiodj+buildbot
2017-11-18  4:48 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-17 20:02 [binutils-gdb] Make process_info::syscalls_to_catch an std::vector sergiodj+buildbot
2017-11-17 23:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-17 19:16 [binutils-gdb] Make open_fds an std::vector sergiodj+buildbot
2017-11-17 22:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-17 18:07 [binutils-gdb] (Ada) fix handling of minimal symbols (UNOP_CAST and UNOP_ADDR) sergiodj+buildbot
2017-11-17 20:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-17 12:33 [binutils-gdb] x86: Pass "%F%P:" to linker callback in case of error sergiodj+buildbot
2017-11-17 18:47 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-17  2:47 [binutils-gdb] ada-lang.c::ada_value_cast: remove unused parameter noside sergiodj+buildbot
2017-11-17 17:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-16 23:48 [binutils-gdb] Test breakpoint commands w/ "continue" + Ctrl-C sergiodj+buildbot
2017-11-17 16:08 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-16 23:37 [binutils-gdb] Don't ever Quit out of resume sergiodj+buildbot
2017-11-17 13:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-16 20:25 [binutils-gdb] Fix testing gdb.rust/modules.exp against gdbserver sergiodj+buildbot
2017-11-17  8:11 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-16 19:34 [binutils-gdb] Refactor endian handling in DFP routines sergiodj+buildbot
2017-11-17  5:22 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-16 18:10 [binutils-gdb] Correct AArch64 crypto dependencies sergiodj+buildbot
2017-11-17  0:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-16 17:52 [binutils-gdb] Add assembler and disassembler support for the new Armv8.4-a instructions for AArch64 sergiodj+buildbot
2017-11-16 23:03 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-16 16:44 [binutils-gdb] GDBserver: Fix ignored Ctrl-C after reconnection sergiodj+buildbot
2017-11-16 21:38 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-16 16:01 [binutils-gdb] Prevent illegal memory accesses when parsing incorrecctly formated core notes sergiodj+buildbot
2017-11-16 20:20 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-16 15:04 [binutils-gdb] Add Python rbreak command sergiodj+buildbot
2017-11-16 19:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-16 15:02 [binutils-gdb] Prevent a possible seg-fault in the section merging code, by always creating a padding buffer sergiodj+buildbot
2017-11-16 17:54 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-16 13:23 [binutils-gdb] Fix gdb.base/starti.exp racy test sergiodj+buildbot
2017-11-16 15:03 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-16 11:40 [binutils-gdb] Remove non-linux tic6x target descriptions sergiodj+buildbot
2017-11-16 13:50 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-16 10:28 [binutils-gdb] Fix tic6x-uclinux GDBserver build failure sergiodj+buildbot
2017-11-16 10:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-15 21:02 [binutils-gdb] Include <array> to declare std::array<> sergiodj+buildbot
2017-11-16  2:08 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-15 17:36 [binutils-gdb] Separate the new FP16 instructions backported from Armv8.4-a to Armv8.2-a into a new flag order to distinguish them from the rest of the already existing optional FP16 instructions in Armv8.2-a sergiodj+buildbot
2017-11-15 21:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-15 16:19 [binutils-gdb] Remove no-longer applicable maintainer entries sergiodj+buildbot
2017-11-15 19:58 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-15 15:43 [binutils-gdb] Move self to Past Maintainers sergiodj+buildbot
2017-11-15 18:45 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-15 12:22 [binutils-gdb] Handle ' and I format flags sergiodj+buildbot
2017-11-15 15:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-14 22:03 [binutils-gdb] Fix mem region parsing regression and add test sergiodj+buildbot
2017-11-14 22:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-14 10:49 [binutils-gdb] PR22431, powerpc64 ld segfault when .plt discarded sergiodj+buildbot
2017-11-14 12:30 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-14  9:06 [binutils-gdb] x86: add support for AVX-512 VPCMP*{B,W} pseudo-ops sergiodj+buildbot
2017-11-14  9:45 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-14  5:41 [binutils-gdb] Inconsistent .eh_frame_hdr on powerpc64 sergiodj+buildbot
2017-11-14  5:45 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-13 12:03 [binutils-gdb] PE: don't corrupt section flags when linking from ELF objects sergiodj+buildbot
2017-11-13 13:11 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-13 11:44 [binutils-gdb] x86: {f, }xsave64 / {f, }xrstor64 / xsaveopt64 should not allow q suffix sergiodj+buildbot
2017-11-13 11:57 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-12 10:49 [binutils-gdb] weakdef list handling sergiodj+buildbot
2017-11-12 13:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-12 10:14 [binutils-gdb] non_got_ref after adjust_dynamic_relocs sergiodj+buildbot
2017-11-12 11:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-10  1:39 [binutils-gdb] Fix racy output matching in gdb.tui/tui-completion.exp sergiodj+buildbot
2017-11-10  9:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-10  0:28 [binutils-gdb] Fix racy output matching in gdb.base/memattr.exp sergiodj+buildbot
2017-11-10  5:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-09 23:46 [binutils-gdb] Fix racy output matching in gdb.base/completion.exp sergiodj+buildbot
2017-11-10  4:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-09 20:24 [binutils-gdb] fix typos in ada-lang.c comment sergiodj+buildbot
2017-11-10  1:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-09 20:04 [binutils-gdb] Enable the Dot Product extension by default for Armv8.4-a sergiodj+buildbot
2017-11-10  0:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-09 17:55 [binutils-gdb] Add the operand encoding types for the new Armv8.2-a back-ported instructions. These are to be used later when the new instructions are added sergiodj+buildbot
2017-11-09 21:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-09 17:04 [binutils-gdb] Adds the new Fields and Operand types for the new instructions in Armv8.4-a sergiodj+buildbot
2017-11-09 19:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-09 11:44 [binutils-gdb] Split the ARM Crypto ISA extensions for AES and SHA1+2 into their own options (+aes and +sha2). The reason for the split is because with the introduction of Armv8.4-a the implementation of AES has explicitly been made independent of the implementation of the other crypto extensions sergiodj+buildbot
2017-11-09 12:22 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-08  1:18 [binutils-gdb] Constify add_setshow_* sergiodj+buildbot
2017-11-08 15:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-08  0:57 [binutils-gdb] Remove cmd_cfunc_ftype sergiodj+buildbot
2017-11-08 14:22 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-07 23:28 [binutils-gdb] Constify add_path and friends sergiodj+buildbot
2017-11-08  8:58 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-07 22:18 [binutils-gdb] Make set_cmd_cfunc private sergiodj+buildbot
2017-11-08  6:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-07 21:27 [binutils-gdb] Constify add_abbrev_prefix_cmd sergiodj+buildbot
2017-11-08  4:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-07 20:49 [binutils-gdb] opcodes/arc: Fix incorrect insn_class for some nps insns sergiodj+buildbot
2017-11-08  2:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-07 17:23 [binutils-gdb] RISC-V: Add satp as an alias for sptbr sergiodj+buildbot
2017-11-08  1:06 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-07 14:20 [binutils-gdb] Add some more breakpoint/location range tests sergiodj+buildbot
2017-11-07 23:54 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-07 13:35 [binutils-gdb] Make breakpoint/location number parsing error output consistent sergiodj+buildbot
2017-11-07 22:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-07 12:09 [binutils-gdb] Breakpoint location parsing: always error instead of warning sergiodj+buildbot
2017-11-07 20:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-07 11:32 [binutils-gdb] Allow enabling/disabling breakpoint location ranges sergiodj+buildbot
2017-11-07 18:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-07 10:42 [binutils-gdb] This patch similarly to the AArch64 one enables Dot Product support by default for the Cortex-A55 and Cortex-A75 which have hardware support for these instructions sergiodj+buildbot
2017-11-07 17:03 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-07  8:51 [binutils-gdb] ngettext support sergiodj+buildbot
2017-11-07 13:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-07  2:03 [binutils-gdb] Update my e-mail address sergiodj+buildbot
2017-11-07 12:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-07  1:31 [binutils-gdb] Simplify child_terminal_inferior sergiodj+buildbot
2017-11-07 10:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-07  1:06 [binutils-gdb] Test attaching to a process that isn't a process group leader sergiodj+buildbot
2017-11-07  8:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-06 22:47 [binutils-gdb] Don't set terminal flags twice in a row sergiodj+buildbot
2017-11-07  5:13 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-06 21:12 [binutils-gdb] Target FP: Merge doublest.c and dfp.c into target-float.c sergiodj+buildbot
2017-11-07  1:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-06 17:27 [binutils-gdb] Target FP: Add binop and compare routines to target-float.{c, h} sergiodj+buildbot
2017-11-06 19:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-06 15:56 [binutils-gdb] Target FP: Add string routines to target-float.{c,h} sergiodj+buildbot
2017-11-06 16:47 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-05 12:25 [binutils-gdb] Proper bound check in _bfd_doprnt_scan sergiodj+buildbot
2017-11-05 20:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-05 10:38 [binutils-gdb] PR22397, BFD internal error when message locale isn't C sergiodj+buildbot
2017-11-05 19:14 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-05  7:46 [binutils-gdb] powerpc TLS in PIEs sergiodj+buildbot
2017-11-05 15:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-05  6:19 [binutils-gdb] hppa-linux TLS relocs sergiodj+buildbot
2017-11-05 12:38 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-05  2:35 [binutils-gdb] PowerPC readonly_dynrelocs sergiodj+buildbot
2017-11-05 13:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-05  1:19 [binutils-gdb] Use gdb::byte_vector in ppc-linux-tdep.c sergiodj+buildbot
2017-11-05  3:57 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-04 23:46 [binutils-gdb] Use unique_xmalloc_ptr in c_type_print_base sergiodj+buildbot
2017-11-05  6:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-04 20:14 [binutils-gdb] Replace start_rbreak_breakpoints and end_rbreak_breakpoints sergiodj+buildbot
2017-11-04 23:56 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-04 19:51 [binutils-gdb] Remove directive-searched cleanups sergiodj+buildbot
2017-11-04 22:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-04 18:59 [binutils-gdb] Use unique_xmalloc_ptr in find_separate_debug_file_by_debuglink sergiodj+buildbot
2017-11-04 21:11 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-04 17:45 [binutils-gdb] Remove cleanups from link_callbacks_einfo sergiodj+buildbot
2017-11-04 18:38 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-04 17:00 [binutils-gdb] Replace really_free_pendings with a scoped_ class sergiodj+buildbot
2017-11-04 17:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-03 15:41 [binutils-gdb] Fix regression on ARM after Target FP patches sergiodj+buildbot
2017-11-03 17:58 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-03 15:03 [binutils-gdb] [ARC] Force the disassam to use the hexadecimal number for printing sergiodj+buildbot
2017-11-03 16:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-03 14:08 [binutils-gdb] [ARC] Sync opcode data base sergiodj+buildbot
2017-11-03 14:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-03 12:17 [binutils-gdb] Fix excessive memory allocation attempts and possible integer overfloaws when attempting to read a COFF binary with a corrupt symbol count sergiodj+buildbot
2017-11-03 12:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-02 20:52 [binutils-gdb] aarch64: Remove AARCH64_FEATURE_F16 from AARCH64_ARCH_V8_2 sergiodj+buildbot
2017-11-03  1:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-02 19:53 [binutils-gdb] Construct readonly regcache without address space sergiodj+buildbot
2017-11-03  0:20 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-02 19:26 [binutils-gdb] const-fy regcache::m_readonly_p sergiodj+buildbot
2017-11-02 23:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-02 19:07 [binutils-gdb] s/get_regcache_aspace (regcache)/regcache->aspace ()/g sergiodj+buildbot
2017-11-02 20:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-02 18:14 [binutils-gdb] const-fy regcache::m_aspace sergiodj+buildbot
2017-11-02 21:54 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-02 17:06 [binutils-gdb] Remove regcache_descr::nr_raw_registers sergiodj+buildbot
2017-11-02 19:24 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-02 16:13 [binutils-gdb] New method regcache::assert_regnum sergiodj+buildbot
2017-11-02 18:10 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-02 15:52 [binutils-gdb] Remove code wrapped by "#if 0" sergiodj+buildbot
2017-11-02 16:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-02 15:27 [binutils-gdb] Remove regcache_descr fields sizeof_raw_register_status and sizeof_cooked_register_status sergiodj+buildbot
2017-11-02 15:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-01 15:24 [binutils-gdb] Prevent illegal memory accesses when attempting to read excessively large COFF line number tables sergiodj+buildbot
2017-11-01 15:48 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-11-01 11:58 [binutils-gdb] Fix an invalid free called when attempting to link a COFF object against an ELF archive with --no-keep-memory enabled sergiodj+buildbot
2017-11-01 12:03 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-31 14:53 [binutils-gdb] Fix illegal memory access triggered when parsing a PE binary with a corrupt data dictionary sergiodj+buildbot
2017-10-31 14:57 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-30  2:25 [binutils-gdb] frv-elf --gc-sections failures sergiodj+buildbot
2017-10-30  4:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-30  2:05 [binutils-gdb] relocs_compatible test for gc-sections sergiodj+buildbot
2017-10-30  2:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-28 12:08 [binutils-gdb] PR22300, Abort in elf32_hppa_relocate_section building polyml sergiodj+buildbot
2017-10-28 22:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-28  8:07 [binutils-gdb] C++ify xml-syscall.c sergiodj+buildbot
2017-10-28 14:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-28  6:15 [binutils-gdb] Remove usages of find_inferior in handle_status sergiodj+buildbot
2017-10-28 18:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-28  5:13 [binutils-gdb] Get rid of VEC(probe_p) sergiodj+buildbot
2017-10-28 13:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-28  3:31 [binutils-gdb] Get rid of VEC(filename_language) sergiodj+buildbot
2017-10-28  8:48 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-27 17:04 [binutils-gdb] [AArch64] Mark LR clobbered by BL in inline asm sergiodj+buildbot
2017-10-28  4:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-27  3:57 [binutils-gdb] RISC-V: Fix disassembly of c.addi4spn, c.addi16sp, c.lui when imm=0 sergiodj+buildbot
2017-10-27 11:00 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-26 22:19 [binutils-gdb] Garbage collect remote.c:remote_async_terminal_ours_p sergiodj+buildbot
2017-10-28  0:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-26 21:14 [binutils-gdb] const-fy breakpoint_ops->breakpoint_hit parameter aspace sergiodj+buildbot
2017-10-27 21:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-26 20:23 [binutils-gdb] s/get_regcache_arch (regcache)/regcache->arch ()/g sergiodj+buildbot
2017-10-27 19:00 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-26 19:34 [binutils-gdb] Target FP: Use target format throughout expression parsing sergiodj+buildbot
2017-10-27 17:45 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-26 16:36 [binutils-gdb] Use const reference for decimal_from_string argument sergiodj+buildbot
2017-10-27  9:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-26 16:13 [binutils-gdb] Fix unstable test names in gdb.python/py-objfile.exp sergiodj+buildbot
2017-10-26 20:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-26 14:44 [binutils-gdb] Fix unstable test names in gdb.gdb/unittest.exp sergiodj+buildbot
2017-10-26 19:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-26 14:06 [binutils-gdb] RISC-V: Only relax to C.LUI when imm != 0 and rd != 0/2 sergiodj+buildbot
2017-10-27  4:00 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-26 13:38 [binutils-gdb] Fix gdb.opt/inline-cmds.exp regressions sergiodj+buildbot
2017-10-27  2:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-26 12:26 [binutils-gdb] Reindent gdb.threads/attach-into-signal.exp sergiodj+buildbot
2017-10-27  0:10 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-26 11:38 [binutils-gdb] Drop /proc/PID/status polling from gdb.threads/attach-into-signal.exp sergiodj+buildbot
2017-10-26 22:57 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-26  9:40 [binutils-gdb] Fix unstable test names in gdb.base/startup-with-shell.exp sergiodj+buildbot
2017-10-26 18:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-26  8:44 [binutils-gdb] Make sure that undefined symbols added to the linker command line via the -u option appear in the output executable, if they have not been resolved sergiodj+buildbot
2017-10-26 14:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-26  7:51 [binutils-gdb] Fix the master due to bad regenerated files sergiodj+buildbot
2017-10-26 12:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-26  7:22 [binutils-gdb] Enable Intel VAES instructions sergiodj+buildbot
2017-10-26  9:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-21 17:42 [binutils-gdb] Add overloads of for_each_thread/find_thread that filter on pid sergiodj+buildbot
2017-10-21 20:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-21 15:59 [binutils-gdb] Create a displaced_step_closure class hierarchy sergiodj+buildbot
2017-10-21 16:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-20 19:05 [binutils-gdb] Use std::vector in gdb_bfd_data sergiodj+buildbot
2017-10-20 20:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-20 16:28 [binutils-gdb] Introduce new_bfd_ref sergiodj+buildbot
2017-10-20 18:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-20 15:58 [binutils-gdb] Fix 'gdb.base/quit.exp hangs forever' if the test fails sergiodj+buildbot
2017-10-20 16:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-20 14:57 [binutils-gdb] Fix gdb.gdb/ selftest tests when testing optimized GDB builds sergiodj+buildbot
2017-10-20 14:57 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-20  2:37 [binutils-gdb] Get rid of VEC(interp_factory_p) sergiodj+buildbot
2017-10-20  2:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-20  0:58 [binutils-gdb] Remove cleanups from break-catch-syscall.c sergiodj+buildbot
2017-10-20  0:58 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-19 20:39 [binutils-gdb] gdb: Remove hard-coded line number from test sergiodj+buildbot
2017-10-19 20:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-19 18:15 [binutils-gdb] Fix build breakage in gdb/xml-support.c sergiodj+buildbot
2017-10-19 19:18 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-19 13:54 [binutils-gdb] tilegx: Check bfd_link_executable for TLS check sergiodj+buildbot
2017-10-19 15:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-19 12:45 [binutils-gdb] sparc: Check bfd_link_executable for TLS check sergiodj+buildbot
2017-10-19 12:45 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-18 14:57 [binutils-gdb] [Visium] Disassemble the operands of the stop instruction sergiodj+buildbot
2017-10-18 14:57 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-18 12:24 [binutils-gdb] Remove features/tic6x-c62x-linux.c sergiodj+buildbot
2017-10-18 12:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-17 20:14 [binutils-gdb] Really make the native-stdio-gdbserver board non-remote sergiodj+buildbot
2017-10-18  0:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-17 17:30 [binutils-gdb] Add several "quit with live inferior" tests sergiodj+buildbot
2017-10-17 23:14 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-17 16:58 [binutils-gdb] Remove cleanups from disasm.c sergiodj+buildbot
2017-10-17 22:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-17 14:44 [binutils-gdb] Fix double-free corruption sergiodj+buildbot
2017-10-17 18:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-17 13:53 [binutils-gdb] [GDBserver] Move arm-linux.o and arm-get-next-pcs.o to arch/ sergiodj+buildbot
2017-10-17 14:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-17 12:52 [binutils-gdb] [GDBserver] Move arm.o to arch/arm.o sergiodj+buildbot
2017-10-17 12:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-17 11:42 [binutils-gdb] [GDBserver] Replicate src dir in build dir sergiodj+buildbot
2017-10-17 11:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-17  2:05 [binutils-gdb] Record and output access specifiers for nested typedefs sergiodj+buildbot
2017-10-17  6:44 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-17  1:45 [binutils-gdb] Return unique_xmalloc_ptr from target_fileio_read_stralloc sergiodj+buildbot
2017-10-17  5:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-17  1:24 [binutils-gdb] Return unique_xmalloc_ptr from target_read_stralloc sergiodj+buildbot
2017-10-17  4:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-16 22:35 [binutils-gdb] Use std::vector in end_symtab_get_static_block sergiodj+buildbot
2017-10-16 22:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-16 19:33 [binutils-gdb] Use proc_with_prefix in py-breakpoint.exp sergiodj+buildbot
2017-10-16 19:33 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-16 15:34 [binutils-gdb] Get rid of VEC(mem_range_s) sergiodj+buildbot
2017-10-16 17:53 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-16 11:51 [binutils-gdb] ELF: Call check_relocs after opening all inputs sergiodj+buildbot
2017-10-16 15:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-16 10:50 [binutils-gdb] Regenerate gdbserver/configure sergiodj+buildbot
2017-10-16 14:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-16  2:42 [binutils-gdb] Fix GDB build without expat sergiodj+buildbot
2017-10-16  2:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-14 12:31 [binutils-gdb] Replace psymbol_allocation_list with std::vector sergiodj+buildbot
2017-10-14 17:10 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-14  5:29 [binutils-gdb] Don't run gdb.gdb/ selftests if use_gdb_stub is true sergiodj+buildbot
2017-10-14 11:38 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-14  3:35 [binutils-gdb] ada: Use std::string in print_dynamic_range_bound sergiodj+buildbot
2017-10-14 15:14 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-14  2:59 [binutils-gdb] Simplify tic6x and s390x expedite registers sergiodj+buildbot
2017-10-14  8:38 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-13 16:57 [binutils-gdb] Make gdb.base/find-unmapped.exp pass on remote targets sergiodj+buildbot
2017-10-14  9:58 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-13 16:26 [binutils-gdb] Make gdb.base/solib-nodir.exp work with --target_board=native-extended-gdbserver sergiodj+buildbot
2017-10-13 18:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-13 14:55 [binutils-gdb] Fix gdb.base/term.exp on non-"target native" boards sergiodj+buildbot
2017-10-14  4:44 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-13 14:31 [binutils-gdb] Remove is_remote kfail from gdb.python/py-evthreads.exp sergiodj+buildbot
2017-10-14  3:29 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-13 12:51 [binutils-gdb] kfail gdb.python/py-evsignal.exp on RSP targets properly sergiodj+buildbot
2017-10-14  0:46 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-13 11:37 [binutils-gdb] Fix is_remote check in gdb.base/remote.exp sergiodj+buildbot
2017-10-13 21:03 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-13 10:49 [binutils-gdb] gdb.base/remote.exp: Fix typo and add missing return sergiodj+buildbot
2017-10-13 19:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-13  9:47 [binutils-gdb] Eliminate is_remote check in gdb.base/shlib-call.exp sergiodj+buildbot
2017-10-13 16:49 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-13  5:12 [binutils-gdb] Remove simple_displaced_step_copy_insn sergiodj+buildbot
2017-10-13 15:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-13  4:53 [binutils-gdb] FT32: support for FT32B processor - part 1 sergiodj+buildbot
2017-10-13 14:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-13  4:31 [binutils-gdb] Add myself as ft32 maintainer for sim sergiodj+buildbot
2017-10-13 12:46 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-13  3:20 [binutils-gdb] Remove references to gdb64 in the testsuite sergiodj+buildbot
2017-10-13  9:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-13  3:01 [binutils-gdb] Remove is_remote check in labels.exp sergiodj+buildbot
2017-10-13  7:53 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-13  2:40 [binutils-gdb] Make gdb.base/auvx.exp work with --target_board=native-extended-gdbserver sergiodj+buildbot
2017-10-13  6:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-13  1:49 [binutils-gdb] Use bool in pv_area sergiodj+buildbot
2017-10-13  5:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-13  0:40 [binutils-gdb] C++-ify prologue-value's pv_area sergiodj+buildbot
2017-10-13  4:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-13  0:06 [binutils-gdb] Run gdb.base/catch-fork-static.exp on remote target boards sergiodj+buildbot
2017-10-13  0:06 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-12 23:51 [binutils-gdb] linux low: Make the arch code free arch_process_info sergiodj+buildbot
2017-10-13  2:58 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-12 21:52 [binutils-gdb] lwp_info: Make the arch code free arch_lwp_info sergiodj+buildbot
2017-10-13  1:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-12 19:33 [binutils-gdb] checkpoint.exp: Check for non-"target native" instead of isnative/is_remote sergiodj+buildbot
2017-10-12 22:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-12 19:12 [binutils-gdb] Remove is_remote target check from gdb.base/dprintf-non-stop.exp sergiodj+buildbot
2017-10-12 21:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-12 18:52 [binutils-gdb] Tighten remote check in gdb.base/argv0-symlink.exp sergiodj+buildbot
2017-10-12 20:13 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-12 18:10 [binutils-gdb] Enable gdb.base/inferior-died.exp on is_remote target boards sergiodj+buildbot
2017-10-12 18:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-12 13:05 [binutils-gdb] Force the AArch64 linker backend to refuse to link when it encounters unresoleable relocations sergiodj+buildbot
2017-10-12 13:05 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-12  9:37 [binutils-gdb] x86: Add _bfd_x86_elf_hide_symbol sergiodj+buildbot
2017-10-12  9:54 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-12  3:43 [binutils-gdb] _bfd_elf_link_hash_hide_symbol calls in generic ELF code sergiodj+buildbot
2017-10-12  7:29 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-11 23:12 [binutils-gdb] Constify add_prefix_cmd sergiodj+buildbot
2017-10-12  3:13 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-11 22:52 [binutils-gdb] Remove prepare_re_set_context sergiodj+buildbot
2017-10-12  1:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-11 20:03 [binutils-gdb] Add FreeBSD/arm architecture sergiodj+buildbot
2017-10-11 22:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-11 16:50 [binutils-gdb] GDB: Remove Linux core PRPSINFO note writer override sergiodj+buildbot
2017-10-11 20:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-11 16:30 [binutils-gdb] ELF/BFD: Handle both variants of the 64-bit Linux core PRPSINFO note sergiodj+buildbot
2017-10-11 19:38 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-11 16:09 [binutils-gdb] ELF/BFD, GDB: Handle both variants of the 32-bit Linux core PRPSINFO note sergiodj+buildbot
2017-10-11 18:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-11 13:11 [binutils-gdb] arc: Pass proper CPU value to the disassembler sergiodj+buildbot
2017-10-11 13:25 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-11 12:08 [binutils-gdb] Rename _doprnt -> _bfd_doprnt to fix DJGPP bfd build (and likely others) sergiodj+buildbot
2017-10-11 12:13 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-11 10:21 [binutils-gdb] Remove unnecessary parentheses in declarations sergiodj+buildbot
2017-10-11 10:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-10 23:19 [binutils-gdb] x86: Set GOT refcount to 1 sergiodj+buildbot
2017-10-11  0:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-10 16:39 [binutils-gdb] Eliminate catch_errors sergiodj+buildbot
2017-10-10 17:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-10 16:08 [binutils-gdb] [ARM] PR ld/21402, only override the symbol dynamic decision on undefined weak symbol sergiodj+buildbot
2017-10-10 16:08 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-10  0:23 [binutils-gdb] Remove free_splay_tree cleanup sergiodj+buildbot
2017-10-10  8:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-10  0:15 [binutils-gdb] bfin: Don't create .interp section for info->nointerp sergiodj+buildbot
2017-10-10  4:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-09 22:40 [binutils-gdb] mn10300: Don't free cached internal symbol table sergiodj+buildbot
2017-10-10  5:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-09 21:45 [binutils-gdb] Multi-arch exec, more register reading avoidance sergiodj+buildbot
2017-10-10  1:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-09 19:41 [binutils-gdb] gdb.multi/multi-arch-exec.exp: Also test -m32 => -m64 sergiodj+buildbot
2017-10-10  2:43 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-09 18:14 [binutils-gdb] Don't try building gdb against guile-2.2 sergiodj+buildbot
2017-10-09 22:53 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-09 17:56 [binutils-gdb] S/390: Sync with latest POP - 3 new instructions sergiodj+buildbot
2017-10-09 21:41 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-09 16:13 [binutils-gdb] Fix automatic dependency tracking sergiodj+buildbot
2017-10-09 18:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-09 15:34 [binutils-gdb] Make cp_remove_params return a gdb::unique_xmalloc_ptr sergiodj+buildbot
2017-10-09 17:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-09  7:27 [binutils-gdb] Remove some cleanups from dwarf2read.c sergiodj+buildbot
2017-10-09 12:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-09  5:51 [binutils-gdb] Remove make_cleanup_value_free sergiodj+buildbot
2017-10-09  9:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-09  5:31 [binutils-gdb] Change search_symbols to return std::vector sergiodj+buildbot
2017-10-09  7:15 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-09  5:11 [binutils-gdb] PR22212, memory leak in nm sergiodj+buildbot
2017-10-09  6:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-09  1:20 [binutils-gdb] sh: Dump dynamic relocation info to the map file sergiodj+buildbot
2017-10-09  3:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-09  0:35 [binutils-gdb] sparc: Remove a strayed comment sergiodj+buildbot
2017-10-09  1:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-08 20:47 [binutils-gdb] Reformat elf_x86_allocate_dynrelocs sergiodj+buildbot
2017-10-08 21:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-08  0:51 [binutils-gdb] sparc: Dump dynamic relocation info to the map file sergiodj+buildbot
2017-10-08  2:22 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-06 22:49 [binutils-gdb] Skip gdb.mi/mi-threads-interrupt.exp if nointerrupts sergiodj+buildbot
2017-10-07 12:15 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-06 13:38 [binutils-gdb] Move arm.o arm-get-next-pcs.o arm-linux.o to arch/ sergiodj+buildbot
2017-10-07  7:49 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-06 11:06 [binutils-gdb] Fix more GDB build breakage on mingw32 sergiodj+buildbot
2017-10-07  4:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-06 10:53 [binutils-gdb] Fix GDB build under msys+mingw gcc 32bit sergiodj+buildbot
2017-10-07  2:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-06 10:23 [binutils-gdb] Share code updating gdb_target_obs sergiodj+buildbot
2017-10-07  0:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-06  7:54 [binutils-gdb] x86: Add VERIFY_COPY_RELOC sergiodj+buildbot
2017-10-06 20:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-06  7:44 [binutils-gdb] x86: Add GENERATE_DYNAMIC_RELOCATION_P sergiodj+buildbot
2017-10-06 16:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-06  7:42 [binutils-gdb] x86: Add POINTER_LOCAL_IFUNC_P/PLT_LOCAL_IFUNC_P sergiodj+buildbot
2017-10-06 15:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-06  7:30 [binutils-gdb] Add RESOLVED_LOCALLY_P sergiodj+buildbot
2017-10-06 12:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-06  7:26 [binutils-gdb] x86: Add NEED_DYNAMIC_RELOCATION_P sergiodj+buildbot
2017-10-06 10:50 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-06  1:11 [binutils-gdb] powerpc: Dump dynamic relocation info to the map file sergiodj+buildbot
2017-10-06  4:08 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-05 17:18 [binutils-gdb] Clean up includes of doublest.h and floatformat.h sergiodj+buildbot
2017-10-05 22:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-05 17:18 [binutils-gdb] Clean up some DFP interfaces sergiodj+buildbot
2017-10-05 23:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-05 17:18 [binutils-gdb] Remove unused "union agent_val" from ax.h sergiodj+buildbot
2017-10-06  1:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-05 17:00 [binutils-gdb] Handle FreeBSD-specific AT_EHDRFLAGS and AT_HWCAP auxiliary vector types sergiodj+buildbot
2017-10-05 18:11 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-05 17:00 [binutils-gdb] Handle the NT_ARM_VFP core dump note on FreeBSD sergiodj+buildbot
2017-10-05 20:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-05 13:02 [binutils-gdb] tile: Dump dynamic relocation info to the map file sergiodj+buildbot
2017-10-05 14:14 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-05  4:45 [binutils-gdb] Update my email address sergiodj+buildbot
2017-10-05  5:56 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-05  1:42 [binutils-gdb] bfd_set_input_error sergiodj+buildbot
2017-10-05  3:46 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-05  1:09 [binutils-gdb] bfd_error_on_input is for archives sergiodj+buildbot
2017-10-05  2:24 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-04 23:08 [binutils-gdb] PR21167, relocation sections not included in groups sergiodj+buildbot
2017-10-05  0:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-04 17:39 [binutils-gdb] Redesign mock environment for gdbarch selftests sergiodj+buildbot
2017-10-04 19:11 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-04 17:39 [binutils-gdb] Fix "Remote 'g' packet reply is too long" problems with multiple inferiors sergiodj+buildbot
2017-10-04 21:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-04 16:48 [binutils-gdb] Fix -list-thread-groups --available logic and add test sergiodj+buildbot
2017-10-04 17:59 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-04 12:21 [binutils-gdb] Move code out of 'between TRY and CATCH' sergiodj+buildbot
2017-10-04 13:24 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-04 10:25 [binutils-gdb] Add missing-END_CATCH detection/protection (to gdb's TRY/CATCH/END_CATCH) sergiodj+buildbot
2017-10-04 12:13 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-04  7:08 [binutils-gdb] Extend "set cwd" to work on gdbserver sergiodj+buildbot
2017-10-04 10:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-04  4:18 [binutils-gdb] PR22245, Fix potential UB in bfd_set_error sergiodj+buildbot
2017-10-04  5:11 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-03 23:08 [binutils-gdb] gdbarch: Remove duplicate `struct objfile' declaration sergiodj+buildbot
2017-10-04  0:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-03 21:48 [binutils-gdb] Update my email address sergiodj+buildbot
2017-10-03 22:54 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-02 21:46 [binutils-gdb] Fix &str printing in Rust sergiodj+buildbot
2017-10-03 14:52 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-02 21:04 [binutils-gdb] Fix ptype of Rust slices sergiodj+buildbot
2017-10-03 13:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-10-02 20:33 [binutils-gdb] Allow indexing of &str in Rust sergiodj+buildbot
2017-10-03 12:29 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
     [not found] <9754d8c4c48209eaefb044d03dc25f14dca8a263@gdb-build>
2017-10-02 12:04 ` sergiodj+buildbot
2017-10-02  9:57 [binutils-gdb] Fix GDB build with G++ 4.8 sergiodj+buildbot
2017-10-03  9:29 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
     [not found] <8abcee91738bf0be98e949049c559839ef811ae4@gdb-build>
2017-10-02  5:21 ` sergiodj+buildbot
2017-10-01  2:06 [binutils-gdb] Use std::set in mi-main.c sergiodj+buildbot
2017-10-03  0:06 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-30 14:16 [binutils-gdb] Don't copy a string in mi_cmd_disassemble sergiodj+buildbot
2017-10-02 18:03 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-30 11:26 [binutils-gdb] Remove cleanups from mi_cmd_break_insert_1 sergiodj+buildbot
2017-10-02 15:26 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-30 10:20 [binutils-gdb] Remove make_cleanup_defer_target_commit_resume sergiodj+buildbot
2017-10-02 13:15 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-30  8:37 [binutils-gdb] Remove cleanup from mt-tdep.c sergiodj+buildbot
2017-10-02  8:56 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-30  7:10 [binutils-gdb] Remove some cleanups from stack.c sergiodj+buildbot
2017-10-02  2:56 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-30  6:22 [binutils-gdb] Remove cleanup from tilegx-tdep.c sergiodj+buildbot
2017-10-02  1:45 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-28  2:14 [binutils-gdb] Constify core_file_command sergiodj+buildbot
2017-09-28  9:27 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-28  1:36 [binutils-gdb] Constify commands in cli-dump.c sergiodj+buildbot
2017-09-28 18:46 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-28  1:33 [binutils-gdb] Constify some commands in cli-cmds.c sergiodj+buildbot
2017-09-28 17:10 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-28  0:29 [binutils-gdb] Constify cmd_record_full_restore sergiodj+buildbot
2017-09-28 13:00 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-27 23:15 [binutils-gdb] Constify show_convenience sergiodj+buildbot
2017-09-28 10:38 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-27 22:06 [binutils-gdb] Constify display_tib sergiodj+buildbot
2017-09-28  3:01 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-27 21:51 [binutils-gdb] Constify maintenance_print_user_registers sergiodj+buildbot
2017-09-28  8:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-27 20:54 [binutils-gdb] Constify maintenance_cplus_namespace sergiodj+buildbot
2017-09-28  6:58 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-27 19:37 [binutils-gdb] Constify two functions in valprint.c sergiodj+buildbot
2017-09-27 21:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-27 18:28 [binutils-gdb] Constify dump_arc_instruction_command sergiodj+buildbot
2017-09-27 23:09 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-27 16:46 [binutils-gdb] Constify add_cmd gdb_bfd.c sergiodj+buildbot
2017-09-27 17:22 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-27 15:48 [binutils-gdb] Add add_cmd function overloads sergiodj+buildbot
2017-09-27 16:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-26 22:02 [binutils-gdb] x86-64: Don't pass output_bfd to info->callbacks->minfo sergiodj+buildbot
2017-09-27  6:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-26 18:56 [binutils-gdb] dwarf2read: Restrict ICC workaround to ICC<14 sergiodj+buildbot
2017-09-27  4:15 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-26 17:59 [binutils-gdb] Use "switch_to_thread" more thoroughly on gdbserver sergiodj+buildbot
2017-09-26 23:44 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-26 17:12 [binutils-gdb] Allow linking GDB with ncursesw sergiodj+buildbot
2017-09-26 22:02 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-26 16:23 [binutils-gdb] Fix an assertion failure when parsing a fuzzed x86_64 ELF binary sergiodj+buildbot
2017-09-26 22:00 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-26 16:00 [binutils-gdb] Tidy reading data in read_formatted_entries sergiodj+buildbot
2017-09-26 19:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-26 15:21 [binutils-gdb] Avoid needless resource usage when processing a corrupt DWARF directory or file name table sergiodj+buildbot
2017-09-26 18:24 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-26 14:35 [binutils-gdb] Remove support for Solaris < 10 (PR gdb/22185) sergiodj+buildbot
2017-09-26 16:20 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-26 13:13 [binutils-gdb] PR22209, invalid memory read in find_abstract_instance_name sergiodj+buildbot
2017-09-26 13:36 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-26  2:45 [binutils-gdb] Remove make_cleanup_regcache_xfree sergiodj+buildbot
2017-09-26  4:32 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-26  0:40 [binutils-gdb] PR22204, Lack of DW_LNE_end_sequence causes "infinite" loop sergiodj+buildbot
2017-09-26  0:55 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-25 17:51 [binutils-gdb] S390: Document guarded-storage register support sergiodj+buildbot
2017-09-26  0:37 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-25 17:02 [binutils-gdb] S390: Add guarded-storage register support to gdbserver sergiodj+buildbot
2017-09-25 22:48 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-25 16:24 [binutils-gdb] S390: Add guarded-storage register support to GDB sergiodj+buildbot
2017-09-25 21:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-25 15:04 [binutils-gdb] PR22202, buffer overflow in parse_die sergiodj+buildbot
2017-09-25 16:59 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-25 14:14 [binutils-gdb] PR22201, DW_AT_name with out of bounds reference sergiodj+buildbot
2017-09-25 15:19 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-25 13:52 [binutils-gdb] PR22200, DWARF5 .debug_line sanity check sergiodj+buildbot
2017-09-25 14:08 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-25  6:17 [binutils-gdb] Initialize 'imm' on opcodes/aarch64-opc.c:expand_fp_imm (and fix breakage on mingw) sergiodj+buildbot
2017-09-25  6:34 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-24 12:59 [binutils-gdb] PR22197, buffer overflow in bfd_get_debug_link_info_1 sergiodj+buildbot
2017-09-24 19:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-24 12:42 [binutils-gdb] PR22191, memory leak in dwarf2.c sergiodj+buildbot
2017-09-24 17:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-24  8:28 [binutils-gdb] PR22186, divide-by-zero in decode_line_info sergiodj+buildbot
2017-09-24 11:39 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-24  8:08 [binutils-gdb] PR22169, heap-based buffer overflow in read_1_byte sergiodj+buildbot
2017-09-24 10:00 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-24  7:15 [binutils-gdb] PR22166, SHT_GNU_verneed memory allocation sergiodj+buildbot
2017-09-24  7:31 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-23 21:05 [binutils-gdb] Removed unused declaration sergiodj+buildbot
2017-09-23 21:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-22 22:17 [binutils-gdb] Change type of scoped_input_handler::m_quit_handler sergiodj+buildbot
2017-09-23  2:06 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-22 21:41 [binutils-gdb] x86: Guard against corrupted PLT sergiodj+buildbot
2017-09-22 23:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-22 18:25 [binutils-gdb] Get rid of "gdb_dirbuf" and use "getcwd (NULL, 0)" sergiodj+buildbot
2017-09-22 20:51 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-22 15:58 [binutils-gdb] gdbserver x86 on win32: call init_target_desc sergiodj+buildbot
2017-09-22 18:12 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-22 15:29 [binutils-gdb] x86: Return -1 if bfd_canonicalize_dynamic_reloc returns 0 sergiodj+buildbot
2017-09-22 17:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-22 14:18 [binutils-gdb] Fix sometimes-uninitialized warning in gdbscm_value_address sergiodj+buildbot
2017-09-22 14:38 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-21 20:48 [binutils-gdb] Test case for Inferior.thread_from_thread_handle sergiodj+buildbot
2017-09-22  4:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-21 20:24 [binutils-gdb] Add thread_handle_to_thread_info support for remote targets sergiodj+buildbot
2017-09-22  0:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-21 20:08 [binutils-gdb] Add thread_db_notice_clone to gdbserver sergiodj+buildbot
2017-09-21 22:06 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-21 19:14 [binutils-gdb] Add target method for converting thread handle to thread_info struct pointer sergiodj+buildbot
2017-09-21 19:35 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-21 16:21 [binutils-gdb] S/390: Fix Elf note swap s390_gs_bc vs. s390_gs_cb sergiodj+buildbot
2017-09-21 16:40 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-21 13:51 [binutils-gdb] linux-waitpid: Get rid of format string warning sergiodj+buildbot
2017-09-21 16:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-21 12:52 [binutils-gdb] microblaze-tdep: Add ATTRIBUTE_PRINTF to microblaze_debug sergiodj+buildbot
2017-09-21 13:11 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-21  8:31 [binutils-gdb] [SIM, ARM] Fix build failure sergiodj+buildbot
2017-09-21  9:10 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-21  5:09 [binutils-gdb] Allocate bpstats with new sergiodj+buildbot
2017-09-21  5:17 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-21  0:06 [binutils-gdb] eval.c:evaluate_subexp_standard: Use RAII to avoid leaks sergiodj+buildbot
2017-09-21  4:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-20 22:31 [binutils-gdb] Overload catch_command_errors sergiodj+buildbot
2017-09-20 22:56 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-20 14:10 [binutils-gdb] gdb - avx512: tests were failing due to missing memory aligment sergiodj+buildbot
2017-09-20 14:21 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-19 19:46 [binutils-gdb] Add a 'starti' command sergiodj+buildbot
2017-09-19 20:18 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-19  5:56 [binutils-gdb] PR22150, ld keeps a version reference for gc'd symbols sergiodj+buildbot
2017-09-19  6:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-16 14:50 [binutils-gdb] Make xml_escape_text return an std::string sergiodj+buildbot
2017-09-16 17:49 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-16 14:26 [binutils-gdb] Refactor handle_qxfer_libraries and friends to use std::string sergiodj+buildbot
2017-09-17  4:23 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-16 13:24 [binutils-gdb] Add unit test for xml_escape_text sergiodj+buildbot
2017-09-16 16:14 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-16 13:01 [binutils-gdb] Add selftests run filtering sergiodj+buildbot
2017-09-16 14:50 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-16 12:13 [binutils-gdb] mi_load_progress: Use unique_ptr to manage ui_out lifetime sergiodj+buildbot
2017-09-16 12:29 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-15 19:36 [binutils-gdb] Sync libiberty/ & include/ with GCC sergiodj+buildbot
2017-09-16  2:42 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-15 18:45 [binutils-gdb] gdbserver: Remove thread_to_gdb_id sergiodj+buildbot
2017-09-15 23:28 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-15 17:56 [binutils-gdb] gdbserver: Remove gdb_id_to_thread_id sergiodj+buildbot
2017-09-15 21:30 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-15 17:29 [binutils-gdb] Deduplicate require_running macros and move them up sergiodj+buildbot
2017-09-15 19:07 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-15 16:54 [binutils-gdb] gdbserver: Move detach code to its own function sergiodj+buildbot
2017-09-15 20:16 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot
2017-09-15 16:41 [binutils-gdb] Add -l option to src-release script sergiodj+buildbot
2017-09-15 18:04 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).