public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb/gdb-8.3-branch] Fix vertical scrolling of TUI source window
@ 2019-03-16 18:28 sergiodj+buildbot
  2019-03-16 18:28 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
                   ` (10 more replies)
  0 siblings, 11 replies; 55+ messages in thread
From: sergiodj+buildbot @ 2019-03-16 18:28 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ed4c1406c8d0e7dfad6eb0c7ef1c01999f590e2a ***

Author: Eli Zaretskii <eliz@gnu.org>
Branch: gdb-8.3-branch
Commit: ed4c1406c8d0e7dfad6eb0c7ef1c01999f590e2a

Fix vertical scrolling of TUI source window

gdb/ChangeLog:
2019-03-16  Eli Zaretskii  <eliz@gnu.org>

	* source-cache.c (source_cache::get_source_lines): Call
	find_source_lines to initialize s->nlines.  This fixes vertical
	scrolling of TUI source window when the DOWN arrow is pressed.

(cherry picked from commit ab42892fb7d265e72a85e918d4f5c6dfeee3fcd8)


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Bump GDB version number to 8.3.0.DATE-git.
@ 2019-05-11 18:58 sergiodj+buildbot
  2019-05-11 19:14 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-05-11 18:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9c5d0147d8cc011808fc5e165d528a0baad7e6c4 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: gdb-8.3-branch
Commit: 9c5d0147d8cc011808fc5e165d528a0baad7e6c4

Bump GDB version number to 8.3.0.DATE-git.

gdb/ChangeLog:

	* version.in: Set GDB version number to 8.3.0.DATE-git.


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Set GDB version number to 8.3.
@ 2019-05-11 18:40 sergiodj+buildbot
  2019-05-11 18:54 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-05-11 18:40 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9b407598397ef8429cbf866a02745768082e49a6 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: gdb-8.3-branch
Commit: 9b407598397ef8429cbf866a02745768082e49a6

Set GDB version number to 8.3.

gdb/ChangeLog:

	* version.in: Set GDB version number to 8.3.


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Fix style bug when paging
@ 2019-05-08 17:50 sergiodj+buildbot
  2019-05-08 17:54 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-05-08 17:50 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d0e1efa6ae35091a76023bc4e32b6b1e745fa393 ***

Author: Tom Tromey <tromey@adacore.com>
Branch: gdb-8.3-branch
Commit: d0e1efa6ae35091a76023bc4e32b6b1e745fa393

Fix style bug when paging

Philippe pointed out a styling bug that would occur in some conditions
when paging:

    https://sourceware.org/ml/gdb-patches/2019-04/msg00101.html

I was finally able to reproduce this, and this patch fixes the bug.

The problem occurred when text overflowed the line, causing a
pagination prompt, but when no wrap column had been set.  In this
case, the current style was reset to show the prompt, but then not
reset back to the previously applied style before emitting the rest of
the line.

The fix is to record the applied style in this case, and re-apply it
afterward -- but only if the pager prompt was emitted, something that
the existing style.exp pointed out on the first, more naive, version
of the patch.

Tested on x86-64 Fedora 29.

gdb/ChangeLog
2019-05-08  Tom Tromey  <tromey@adacore.com>

	* utils.c (fputs_maybe_filtered): Reset style after paging, even
	when no wrap column is set.


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Don't derive partial_symbol from general_symbol_info
@ 2019-05-04 20:48 sergiodj+buildbot
  2019-05-04 21:04 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-05-04 20:48 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 20555e9e40f8e5ae041ca593d72c7148d94b6565 ***

Author: Tom Tromey <tom@tromey.com>
Branch: gdb-8.3-branch
Commit: 20555e9e40f8e5ae041ca593d72c7148d94b6565

Don't derive partial_symbol from general_symbol_info

This patch partly reverts commit 8a6d42345 ("Change representation of
psymbol to flush out accessors"); specifically, it changes
partial_symbol to no longer derive from general_symbol_info.

The basic problem here is that the bcache compares objects bitwise,
and this change made it less likely that the relevant fields in the
psymbol would be fully initialized.  This could be seen by running a
test under valgrind on the Fedora-i686 buildbot.

I considered a simpler patch, namely just zeroing the psymbol's
"value" field in add_psymbol_to_bcache.  However, it wasn't clear to
me that this memset could not then be optimized away by the compiler.

Regression tested by the buildbot.  I think this should go in 8.3 as
well.

2019-05-04  Tom Tromey  <tom@tromey.com>

	* psymtab.c (psymbol_name_matches, match_partial_symbol)
	(lookup_partial_symbol, print_partial_symbols)
	(recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
	(psymbol_compare): Update.
	(add_psymbol_to_bcache): Clear the entire psymbol.
	(maintenance_check_psymtabs): Update.
	* psympriv.h (struct partial_symbol): Don't derive from
	general_symbol_info.
	<obj_section, unrelocated_address, address,
	set_unrelocated_address>: Update.
	<ginfo>: New member.
	* dwarf-index-write.c (write_psymbols, debug_names::insert)
	(debug_names::write_psymbols): Update.


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Fix compilation with mingw.org's MinGW.
@ 2019-05-03  8:22 sergiodj+buildbot
  2019-05-03  8:32 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-05-03  8:22 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bc694fdc3ccfb7bac93b5480dff908076c7d7893 ***

Author: Eli Zaretskii <eliz@gnu.org>
Branch: gdb-8.3-branch
Commit: bc694fdc3ccfb7bac93b5480dff908076c7d7893

Fix compilation with mingw.org's MinGW.

That flavor of MinGW assumes Windows 9X as the default target,
which doesn't expose CONSOLE_FONT_INFO stuff in Windows header
files.  Since we no longer support running on Windows older
than XP anyway, requiring it at build time makes sense.

gdb/ChangeLog
2019-05-03  Eli Zaretskii  <eliz@gnu.org>

	* windows-nat.c [_WIN32_WINNT]: Define _WIN32_WINNT to Windows XP
	level, so that various Windows header files expose the necessary
	declarations and definitions.


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Fix lookup of separate debug file on MS-Windows.
@ 2019-05-03  8:07 sergiodj+buildbot
  2019-05-03  8:22 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-05-03  8:07 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 661f388860346b3747b3b76479f2a784f3b8e9da ***

Author: Eli Zaretskii <eliz@gnu.org>
Branch: gdb-8.3-branch
Commit: 661f388860346b3747b3b76479f2a784f3b8e9da

Fix lookup of separate debug file on MS-Windows.

If you put the separate debug file in a global debug directory, GDB on
MS-Windows would fail to find it.  This happens because we obtain the
directory to look up the debug file by concatenating the debug
directory name with the leading directories of the executable, and the
latter includes the drive letter on MS-Windows.  So we get an invalid
file name like

   d:/usr/lib/debug/d:/usr/bin/foo.debug

This commit fixes that by removing the colon of the drive letter,
thus producing

   d:/usr/lib/debug/d/usr/bin/foo.debug

gdb/ChangeLog:
2019-05-03  Eli Zaretskii  <eliz@gnu.org>

	* symfile.c (find_separate_debug_file): Remove colon from the
	drive spec of DOS/Windows file names of the target, so that the
	file name produced from DEBUGDIR and the target's directory will
	be valid on DOS/Windows systems.

gdb/doc/ChangeLog:
2019-05-03  Eli Zaretskii  <eliz@gnu.org>

	* gdb.texinfo (Separate Debug Files): Document how the
	subdirectory of the global debug directory is computed on
	MS-Windows/MS-DOS.

(cherry picked from commit 5f2459c233faebe8f882e556b2f4a86594a51292)


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Treat the .gnu.debuglink and .gnu.debugaltlink sections as debug sections when reading them in from COFF/PE format files.
@ 2019-05-03  7:23 sergiodj+buildbot
  2019-05-03  7:38 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-05-03  7:23 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 35f7673945a9c30fca33d981afdcd42f6fd73a6b ***

Author: Nick Clifton <nickc@redhat.com>
Branch: gdb-8.3-branch
Commit: 35f7673945a9c30fca33d981afdcd42f6fd73a6b

Treat the .gnu.debuglink and .gnu.debugaltlink sections as debug sections when reading them in from COFF/PE format files.

	PR 24493
	* coffcode.h (styp_to_sec_flags): Treat .gnu.debuglink and
	.gnu.debugaltlink sections as debugging sections.

(cherry picked from commit 2cdc1a970d3249888524d251abfb87a9bdc77434)


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] (Windows) fix thr != nullptr assert failure in delete_thread_1
@ 2019-04-30 21:20 sergiodj+buildbot
  2019-04-30 21:32 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-04-30 21:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 002aae07299a446d7ef100410bc603c05d91d152 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: gdb-8.3-branch
Commit: 002aae07299a446d7ef100410bc603c05d91d152

(Windows) fix thr != nullptr assert failure in delete_thread_1

We have observed that GDB would randomly trip the following
assertion failure when debugging on Windows. When allowing
the program to run until the inferior exits, we occasionally see:

     (gdb) cont
     Continuing.
     [Thread 48192.0xd100 exited with code 1]
     [Thread 48192.0x10ad8 exited with code 1]
     [Thread 48192.0x36e28 exited with code 0]
     [Thread 48192.0x52be4 exited with code 0]
     [Thread 48192.0x5aa40 exited with code 0]
     ../../src/gdb/thread.c:453: internal-error: void delete_thread_1(thread_inf
o*, bool): Assertion `thr != nullptr' failed.

Running the same scenario with some additional traces enabled...

    (gdb) set verbose
    (gdb) set debugevents

... allows us to understand what the issue is. To understand, we need
to first look at the events received when starting the program, and
in particular which threads got created how. First, we get a
CREATE_PROCESS_DEBUG_EVENT for tid=0x442a8:

    gdb: kernel event for pid=317536 tid=0x442a8 code=CREATE_PROCESS_DEBUG_EVENT)

Shortly after, we get some CREATE_THREAD_DEBUG_EVENT events,
one of them being for tid=0x4010c:

    gdb: kernel event for pid=317536 tid=0x4010c code=CREATE_THREAD_DEBUG_EVENT)
Fast forward a bit of debugging, and we do a "cont" as above,
at which point the programs reaches the end, and the system reports
"exit" events. The first interesting one is the following:

    gdb: kernel event for pid=317536 tid=0x442a8 code=EXIT_THREAD_DEBUG_EVENT)

This is reporting a thread-exit event for a thread whose tid
is the TID of what we call the "main thread". That's the thread
that was created when we received the CREATE_PROCESS_DEBUG_EVENT
notification, and whose TID is actually stored in a global variable
named main_thread_id. This is not something we expected, as
the assumption we made was that the main thread would exit last,
and we would be notified of it via an EXIT_PROCESS_DEBUG_EVENT.
But apparently, this is not always true, at least on Windows Server
2012 and 2016 where this issue has been observed happening randomly.

The consequence of the above notification is that we call
windows_delete_thread for that thread, which removes it from
our list of known threads.

And a little bit later, then we then get the EXIT_PROCESS_DEBUG_EVENT,
and we can see that the associated tid is not the main_thread_id,
but rather the tid of one of the threads that was created during
the lifetime of the program, in this case tid=0x4010c:

    gdb: kernel event for pid=317536 tid=0x4010c code=EXIT_PROCESS_DEBUG_EVENT)

And the debug trace printed right after shows why we're crashing:

    [Deleting Thread 317536.0x442a8]

We are trying to delete the thread whose tid=0x442a8, which is
the main_thread_id! As we have already deleted that thread before,
the search for it returns a nullptr, which then trips the assertion
check in delete_thread_1.

This commit fixes this issue. It ignores the open question of
what to do with the main_thread_id global, particularly after
that thread has been removed from our list of threads. This will
be dealt with as a separate patch, to allow cherry-picking
this patch into a release branch.

For now, we fix the code so as to avoid this crash.

gdb/ChangeLog:

	* windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
	Use current_event.dwThreadId instead of main_thread_id.


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Fix crash in dwarf2read.c with template parameters
@ 2019-04-30 14:56 sergiodj+buildbot
  2019-04-30 15:12 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-04-30 14:56 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 578f1223be227123fc2301ca11f7dcfa01bb2a9d ***

Author: Tom Tromey <tromey@adacore.com>
Branch: gdb-8.3-branch
Commit: 578f1223be227123fc2301ca11f7dcfa01bb2a9d

Fix crash in dwarf2read.c with template parameters

PR c++/24470 concerns a crash in dwarf2read.c that occurs with a
particular test case.

The issue turns out to be that process_structure_scope will pass NULL
to symbol_symtab.  This happens because new_symbol decided not to
create a symbol for the particular DIE.

This patch fixes the problem by finding another reasonably-appropriate
symtab to use instead; issuing a complaint if one cannot be found for
some reason.

As mentioned in the bug, I think there are other bugs here.  For
example, when using "ptype" on the "l" object in the test case, I
think I would expect to see the template parameter.  I didn't research
this too closely, since it seemed more important to fix the crash.

Tested on x86-64 Fedora 29.

I'd like to check this in to the 8.3 branch as well.

gdb/ChangeLog
2019-04-30  Tom Tromey  <tromey@adacore.com>

	PR c++/24470:
	* dwarf2read.c (process_structure_scope): Handle case where type
	has template parameters but no symbol was created.

gdb/testsuite/ChangeLog
2019-04-30  Tom Tromey  <tromey@adacore.com>

	PR c++/24470:
	* gdb.cp/temargs.cc: Add test code from PR.


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] gdb/configure.ac: add --enable-source-highlight
@ 2019-04-20 16:55 sergiodj+buildbot
  2019-04-20 17:10 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-04-20 16:55 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4ae3a64b95432b580f98d457a2346003877f48d1 ***

Author: Sergei Trofimovich <siarheit@google.com>
Branch: gdb-8.3-branch
Commit: 4ae3a64b95432b580f98d457a2346003877f48d1

gdb/configure.ac: add --enable-source-highlight

Allow disabling source-highlight dependency autodetection even
it exists in the system. More details on problem of automatic
dependencies:
https://wiki.gentoo.org/wiki/Project:Quality_Assurance/Automagic_dependencies

Noticed by Jeroen Roovers in https://bugs.gentoo.org/680238

	* configure.ac: add --enable-source-highlight switch.
	* configure: Regenerate.
	* top.c (print_gdb_version): plumb --enable-source-highlight
	status to "show configuration".

gdb/ChangeLog
2019-04-19  Sergei Trofimovich <siarheit@google.com>

	* configure.ac: add --enable-source-highlight switch.
	* configure: Regenerate.
	* top.c (print_gdb_version): plumb --enable-source-highlight
	status to "show configuration".


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Fix "list" when control characters are seen
@ 2019-04-20 16:08 sergiodj+buildbot
  2019-04-20 16:34 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-04-20 16:08 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 014bc49bfcf15d53c65d956ed337ab3217431483 ***

Author: Tom Tromey <tromey@adacore.com>
Branch: gdb-8.3-branch
Commit: 014bc49bfcf15d53c65d956ed337ab3217431483

Fix "list" when control characters are seen

PR symtab/24423 points out that control characters in a source file
cause a hang in the "list" command, a regression introduced by the
styling changes.

This patch, from the PR, fixes the bug.  I've included a minimal
change to the "list" test that exercises this code.

I recall that this bug was discussed on gdb-patches, and I thought
there was a patch there as well, but I was unable to find it.

2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>

	PR symtab/24423:
	* source.c (print_source_lines_base): Advance "iter" when a
	control character is seen.

gdb/testsuite/ChangeLog
2019-04-19  Tom Tromey  <tromey@adacore.com>

	PR symtab/24423:
	* gdb.base/list0.h (foo): Add a control-l character.


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Fix GDB 8.3 regression crash when registers cannot be modified.
@ 2019-04-20 15:20 sergiodj+buildbot
  2019-04-20 15:36 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-04-20 15:20 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT bf9a7cea9c88de232f07151614562f81b52630a0 ***

Author: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Branch: gdb-8.3-branch
Commit: bf9a7cea9c88de232f07151614562f81b52630a0

Fix GDB 8.3 regression crash when registers cannot be modified.

This crash was detected when using GDB with the valgrind gdbserver.
To reproduce:

valgrind sleep 10000

In another window:
gdb
target remote | vgdb
p printf("make sleep print something\n")
=>
terminate called after throwing an instance of 'gdb_exception_RETURN_MASK_ERROR'
Aborted

The problem is that the valgrind gdbserver does not allow to change
registers when the inferior is blocked in a system call.
GDB then raises an exception.  The exception causes the destructor
of
 typedef std::unique_ptr<infcall_suspend_state, infcall_suspend_state_deleter>
    infcall_suspend_state_up;
to be called.  This destructor itself tries to restore the value of
the registers, and fails similarly.  We must catch the exception in
the destructor to avoid crashing GDB.
If the destructor encounters a problem, no warning is produced if
there is an uncaught exception, as in this case, the user will already
be informed of a problem via this exception.

With this change, no crash anymore, and all the valgrind 3.15 tests
pass succesfully.

Note: when this patch is approved, I will push an equivalent patch
on master, but with TRY/CATCH/e.message () replaced by
try/catch/e.what ().

gdb/ChangeLog
2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

	* inferior.h (struct infcall_suspend_state_deleter):
	Catch exception in destructor to avoid crash.


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Another fix for GDB styling
@ 2019-04-12 13:08 sergiodj+buildbot
  2019-04-12 13:39 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-04-12 13:08 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cd3c4bccf4684fd30d125ecd27146c79e5087b02 ***

Author: Eli Zaretskii <eliz@gnu.org>
Branch: gdb-8.3-branch
Commit: cd3c4bccf4684fd30d125ecd27146c79e5087b02

Another fix for GDB styling

gdb/ChangeLog:
2019-04-12  Eli Zaretskii  <eliz@gnu.org>

	* utils.c (prompt_for_continue): Don't restore the styling at the
	end, as applied_style has the wrong value.  This fixes styling in
	long lists of file names that are interrupted by the "Continue?"
	prompt.

(cherry picked from commit 51196bbc5618a3741bd7bbed01ac76b25a2e6f9c)


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Fix testsuite hangs when gdb_test_multiple body errors out
@ 2019-03-28 18:47 sergiodj+buildbot
  2019-03-28 20:39 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-03-28 18:47 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7f45a45af30f6988472ea8f954f94713c45ad478 ***

Author: Pedro Alves <palves@redhat.com>
Branch: gdb-8.3-branch
Commit: 7f45a45af30f6988472ea8f954f94713c45ad478

Fix testsuite hangs when gdb_test_multiple body errors out

This commit fixes a regression in the testsuite itself, triggered by
errors being raised from within gdb_test_multiple, originally reported
by Pedro Franco de Carvalho's at
<https://sourceware.org/ml/gdb-patches/2019-03/msg00160.html>.  Parts
of the commit message are based on his report.

This started happening due to a commit that was introduced recently,
and it can cause the testsuite to hang.

The commit that triggers this is:

 fe1a5cad302b5535030cdf62895e79512713d738
 [gdb/testsuite] Log wait status on process no longer exists error

That commit introduces a new "eof" block in gdb_test_multiple.  That
is not incorrect itself, but dejagnu's remote_expect is picking that
block as the "default" action when an error is raised from within the
commands inside a call to gdb_test_multiple:

  # remote_expect works basically the same as standard expect, but it
  # also takes care of getting the file descriptor from the specified
  # host and also calling the timeout/eof/default section if there is an
  # error on the expect call.
  #
  proc remote_expect { board timeout args } {

I find that "feature" surprising, and I don't really know why it
exists, but this means that the eof section that remote_expect picks
as the error block can be executed even when there was no actual eof
and the GDB process is still running, so the wait introduced in the
commit that tries to get the exit status of GDB hangs forever, while
GDB itself waits for input.

This only happens when there are internal testsuite errors (not
testcase failures).  This can be reproduced easily with a testcase
such as:

  gdb_start
  gdb_test_multiple "show version" "show version" {
    -re ".*" {
       error "forced error"
    }
  }

I think that working around this in GDB is useful so that the
testsuite doesn't hang in these cases.

Adding an empty "default" block at the end of the expect body in
gdb_test_multiple doesn't work, because dejagnu gives preference to
"eof" blocks:

	    if { $x eq "eof" } {
		set save_next 1
	    } elseif { $x eq "default" || $x eq "timeout" } {
		if { $error_sect eq "" } {
		    set save_next 1
		}
	    }

And we do have "eof" blocks.  So we need to make sure that the last
"eof" block is safe to use as the default error block.  It's also
pedantically incorrect to print

 "ERROR: Process no longer exists"

which is what we'd get if the last eof block we have was selected
(more below on this).

So this commit solves this by appending an "eof" with an empty
spawn_id list, so that it won't ever match.

Now, why is the first "eof" block selected today as the error block,
instead of the last one?

The reason is that remote_expect, while parsing the body to select the
default block to execute after an error, is affected by the comments
in the body (since they are also parsed).

If this comment in gdb_test_multiple

 # patterns below apply to any spawn id specified.

is changed to

 # The patterns below apply to any spawn id specified.

then the second eof block is selected and there is no hang.

Any comment at that same place with an even number of tokens also
works.

This is IMO a coincidence caused by how comments work in TCL.
Comments should only appear in places where a command can appear.  And
here, remote_expect is parsing a list of options, not commands, so
it's not unreasonable to not parse comments, similarly to how this:

  set a_list {
     an_element
     # another_element
  }

results in a list with three elements, not one element.

The fact that comments with an even number of tokens work is just a
coincidence of how remote_expect's little state machine is
implemented.

I thought we could solve this by stripping out comment lines in
gdb_expect, but I didn't find an easy way to do that.  Particularly, a
couple naive approaches I tried run into complications.  For example,
we have gdb_test calls with regular expressions that include sequences
like "\r\n#", and by the time we get to gdb_expect, the \r\n have
already been expanded to a real newline, so just splitting the whole
body at newline boundaries, looking for lines that start with #
results in incorrectly stripping out half of the gdb_text regexp.  I
think it's better (at least in this commit), to move the comments out
of the list, because it's much simpler and risk free.

gdb/testsuite/ChangeLog:
2019-03-25  Pedro Alves  <palves@redhat.com>

	* lib/gdb.exp (gdb_test_multiple): Split appends to $code and
	move comments outside list.  Append '-i "" eof' section.

(cherry picked from commit 9a93502fa81734d39f213ccb33b497bc40e1423d)


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Bump GDB version number to 8.2.91.DATE-git.
@ 2019-03-27  1:03 sergiodj+buildbot
  2019-03-27  1:31 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-03-27  1:03 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d18988f72bffbd08e345dc18c3dd2317157cab1a ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: gdb-8.3-branch
Commit: d18988f72bffbd08e345dc18c3dd2317157cab1a

Bump GDB version number to 8.2.91.DATE-git.

gdb/ChangeLog:

	* version.in: Set GDB version number to 8.2.91.DATE-git.


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Set GDB version number to 8.2.91.
@ 2019-03-27  0:32 sergiodj+buildbot
  2019-03-27  0:32 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-03-27  0:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d49ac41ec62576de1a3d2038fe99375c120ef5ef ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: gdb-8.3-branch
Commit: d49ac41ec62576de1a3d2038fe99375c120ef5ef

Set GDB version number to 8.2.91.

gdb/ChangeLog:

	* version.in: Set GDB version number to 8.2.91.


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] gdb/testsuite: Prepare for DejaGnu 1.6.2
@ 2019-03-26 23:59 sergiodj+buildbot
  2019-03-27  0:14 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-03-26 23:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 8a9d17eafbc2b2db8b3dc3ba5ead06237176eb87 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: gdb-8.3-branch
Commit: 8a9d17eafbc2b2db8b3dc3ba5ead06237176eb87

gdb/testsuite: Prepare for DejaGnu 1.6.2

Changes in DejaGnu 1.6.2 mean that our testsuite will no longer run.
This is because of some confusion over how the gdb.exp file is
handled.

The gdb.exp file is really the tool init file, which is loaded from
within the DejaGnu core, and it should not be loaded directly from any
other file in the testsuite.

DejaGnu tries to prevent the same library being loaded twice by
remembering the names of library files as they are loaded.  Until
recently loading the tool init file in DejaGnu was very similar to
loading a library file, as a result, loading the gdb.exp tool init
file simply recorded 'gdb.exp' as having been loaded, future attempts
to load 'gdb.exp' as a library would then be ignored (as the file was
marked as already loaded).

DejaGnu has now changed so that it supports having both a tool init
file and a library with the same name, something that was not possible
before.  What this means however is that when the core loads the
'gdb.exp' tool init file it no longer marks the library 'gdb.exp' as
having been loaded.  When we then execute 'load_lib gdb.exp' we then
try to reload the 'gdb.exp' file.

Unfortunately our gdb.exp file can only be loaded once.  It use of
'rename cd builtin_cd' means that a second attempt to load this file
will fail.

This was discussed on the DejaGnu list here:
   http://lists.gnu.org/archive/html/dejagnu/2019-03/msg00000.html

and the suggested advice is that, unless we have some real requirement
to load the tool init file twice, we should remove calls to 'load_lib
gdb.exp' and rely on DejaGnu to load the file for us, which is what
this patch does.

I've tested with native X86-64/GNU Linux and see no regressions.

gdb/testsuite/ChangeLog:

	* config/default.exp: Remove 'load_lib gdb.exp'.
	* config/monitor.exp: Likewise.
	* config/sid.exp: Likewise.
	* config/sim.exp: Likewise.
	* config/slite.exp: Likewise.
	* config/unix.exp: Likewise.
	* gdb.base/default.exp: Remove unhelpful comment.


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Merge handle_inferior_event and handle_inferior_event_1
@ 2019-03-26 22:00 sergiodj+buildbot
  2019-03-26 21:52 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-03-26 22:00 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e8ad6586f1568233cbd48d041656d0774ffdc0fb ***

Author: Tom Tromey <tromey@adacore.com>
Branch: gdb-8.3-branch
Commit: e8ad6586f1568233cbd48d041656d0774ffdc0fb

Merge handle_inferior_event and handle_inferior_event_1

I noticed that handle_inferior_event is just a small wrapper that
frees the value chain.  This patch replaces it with a
scoped_value_mark, reducing the number of lines of code here.

Regression tested on x86-64 Fedora 29.

gdb/ChangeLog
2019-03-20  Tom Tromey  <tromey@adacore.com>

	PR gdb/24391
	* infrun.c (handle_inferior_event): Rename from
	handle_inferior_event_1.  Create a scoped_value_mark.
	(handle_inferior_event): Remove.


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Fix use-after-free in source_cache::get_source_lines
@ 2019-03-26  1:15 sergiodj+buildbot
  2019-03-26  1:06 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-03-26  1:15 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 154eab6dec772e705b4eefe34ebfefec8808c2cf ***

Author: Simon Marchi <simon.marchi@polymtl.ca>
Branch: gdb-8.3-branch
Commit: 154eab6dec772e705b4eefe34ebfefec8808c2cf

Fix use-after-free in source_cache::get_source_lines

Commit ab42892fb7d2 ("Fix vertical scrolling of TUI source window")
introduced a use-after-free in source_cache::get_source_lines.

At the beginning of the method, we get the fullname of the symtab:

    const char *fullname = symtab_to_fullname (s);

fullname points to the string owned by the symtab (s.fullname).  When we
later do

    scoped_fd desc = open_source_file (s);

s.fullname gets reallocated (even though the string contents may not
change).  The fullname local variable now points to freed memory.

To avoid it, refresh the value of fullname after calling
open_source_file.

Here is the ASan report:

$ ./gdb -nx --data-directory=data-directory ./a.out
(gdb) start
Temporary breakpoint 1 at 0x1130: file test.cpp, line 12.
Starting program: /home/simark/build/binutils-gdb/gdb/a.out

Temporary breakpoint 1, main () at test.cpp:12
=================================================================
==26068==ERROR: AddressSanitizer: heap-use-after-free on address 0x6210003d4100 at pc 0x7fed89a34681 bp 0x7ffd8d185d80 sp 0x7ffd8d185528
READ of size 2 at 0x6210003d4100 thread T0
    #0 0x7fed89a34680 in __interceptor_strlen /build/gcc/src/gcc/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:301
    #1 0x55b6edf6c2f7 in std::char_traits<char>::length(char const*) /usr/include/c++/8.2.1/bits/char_traits.h:320
    #2 0x55b6edf6c9b2 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(char const*, std::allocator<char> const&) /usr/include/c++/8.2.1/bits/basic_string.h:516
    #3 0x55b6ef09121b in source_cache::get_source_lines(symtab*, int, int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >*) /home/simark/src/binutils-gdb/gdb/source-cache.c:214
    #4 0x55b6ef0a15cb in print_source_lines_base /home/simark/src/binutils-gdb/gdb/source.c:1340
    #5 0x55b6ef0a2045 in print_source_lines(symtab*, int, int, enum_flags<print_source_lines_flag>) /home/simark/src/binutils-gdb/gdb/source.c:1415
    #6 0x55b6ef112c87 in print_frame_info(frame_info*, int, print_what, int, int) /home/simark/src/binutils-gdb/gdb/stack.c:914
    #7 0x55b6ef10e90d in print_stack_frame(frame_info*, int, print_what, int) /home/simark/src/binutils-gdb/gdb/stack.c:180
    #8 0x55b6ee9592f8 in print_stop_location /home/simark/src/binutils-gdb/gdb/infrun.c:7853
    #9 0x55b6ee95948f in print_stop_event(ui_out*) /home/simark/src/binutils-gdb/gdb/infrun.c:7870
    #10 0x55b6ef34b962 in tui_on_normal_stop /home/simark/src/binutils-gdb/gdb/tui/tui-interp.c:98
    #11 0x55b6ee01a14d in std::_Function_handler<void (bpstats*, int), void (*)(bpstats*, int)>::_M_invoke(std::_Any_data const&, bpstats*&&, int&&) /usr/include/c++/8.2.1/bits/std_function.h:297
    #12 0x55b6ee965415 in std::function<void (bpstats*, int)>::operator()(bpstats*, int) const /usr/include/c++/8.2.1/bits/std_function.h:687
    #13 0x55b6ee962f1b in gdb::observers::observable<bpstats*, int>::notify(bpstats*, int) const /home/simark/src/binutils-gdb/gdb/common/observable.h:106
    #14 0x55b6ee95a6e7 in normal_stop() /home/simark/src/binutils-gdb/gdb/infrun.c:8142
    #15 0x55b6ee93f236 in fetch_inferior_event(void*) /home/simark/src/binutils-gdb/gdb/infrun.c:3782
    #16 0x55b6ee8f2641 in inferior_event_handler(inferior_event_type, void*) /home/simark/src/binutils-gdb/gdb/inf-loop.c:43
    #17 0x55b6eea2a1f0 in handle_target_event /home/simark/src/binutils-gdb/gdb/linux-nat.c:4358
    #18 0x55b6ee7045f1 in handle_file_event /home/simark/src/binutils-gdb/gdb/event-loop.c:733
    #19 0x55b6ee704e89 in gdb_wait_for_event /home/simark/src/binutils-gdb/gdb/event-loop.c:859
    #20 0x55b6ee7027b5 in gdb_do_one_event() /home/simark/src/binutils-gdb/gdb/event-loop.c:322
    #21 0x55b6ee702907 in start_event_loop() /home/simark/src/binutils-gdb/gdb/event-loop.c:371
    #22 0x55b6eeadfc16 in captured_command_loop /home/simark/src/binutils-gdb/gdb/main.c:331
    #23 0x55b6eeae2ef9 in captured_main /home/simark/src/binutils-gdb/gdb/main.c:1174
    #24 0x55b6eeae30c2 in gdb_main(captured_main_args*) /home/simark/src/binutils-gdb/gdb/main.c:1190
    #25 0x55b6edf4fa89 in main /home/simark/src/binutils-gdb/gdb/gdb.c:32
    #26 0x7fed88ad8222 in __libc_start_main (/usr/lib/libc.so.6+0x24222)
    #27 0x55b6edf4f86d in _start (/home/simark/build/binutils-gdb/gdb/gdb+0x197186d)

0x6210003d4100 is located 0 bytes inside of 4096-byte region [0x6210003d4100,0x6210003d5100)
freed by thread T0 here:
    #0 0x7fed89a8ac19 in __interceptor_free /build/gcc/src/gcc/libsanitizer/asan/asan_malloc_linux.cc:66
    #1 0x55b6edfe12df in xfree<char> /home/simark/src/binutils-gdb/gdb/common/common-utils.h:60
    #2 0x55b6edfea675 in gdb::xfree_deleter<char>::operator()(char*) const /home/simark/src/binutils-gdb/gdb/common/gdb_unique_ptr.h:34
    #3 0x55b6edfe532c in std::unique_ptr<char, gdb::xfree_deleter<char> >::reset(char*) /usr/include/c++/8.2.1/bits/unique_ptr.h:382
    #4 0x55b6edfe7329 in std::unique_ptr<char, gdb::xfree_deleter<char> >::operator=(std::unique_ptr<char, gdb::xfree_deleter<char> >&&) /usr/include/c++/8.2.1/bits/unique_ptr.h:289
    #5 0x55b6ef09ec2b in find_and_open_source(char const*, char const*, std::unique_ptr<char, gdb::xfree_deleter<char> >*) /home/simark/src/binutils-gdb/gdb/source.c:990
    #6 0x55b6ef09f56a in open_source_file(symtab*) /home/simark/src/binutils-gdb/gdb/source.c:1069
    #7 0x55b6ef090f78 in source_cache::get_source_lines(symtab*, int, int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >*) /home/simark/src/binutils-gdb/gdb/source-cache.c:205
    #8 0x55b6ef0a15cb in print_source_lines_base /home/simark/src/binutils-gdb/gdb/source.c:1340
    #9 0x55b6ef0a2045 in print_source_lines(symtab*, int, int, enum_flags<print_source_lines_flag>) /home/simark/src/binutils-gdb/gdb/source.c:1415
    #10 0x55b6ef112c87 in print_frame_info(frame_info*, int, print_what, int, int) /home/simark/src/binutils-gdb/gdb/stack.c:914
    #11 0x55b6ef10e90d in print_stack_frame(frame_info*, int, print_what, int) /home/simark/src/binutils-gdb/gdb/stack.c:180
    #12 0x55b6ee9592f8 in print_stop_location /home/simark/src/binutils-gdb/gdb/infrun.c:7853
    #13 0x55b6ee95948f in print_stop_event(ui_out*) /home/simark/src/binutils-gdb/gdb/infrun.c:7870
    #14 0x55b6ef34b962 in tui_on_normal_stop /home/simark/src/binutils-gdb/gdb/tui/tui-interp.c:98
    #15 0x55b6ee01a14d in std::_Function_handler<void (bpstats*, int), void (*)(bpstats*, int)>::_M_invoke(std::_Any_data const&, bpstats*&&, int&&) /usr/include/c++/8.2.1/bits/std_function.h:297
    #16 0x55b6ee965415 in std::function<void (bpstats*, int)>::operator()(bpstats*, int) const /usr/include/c++/8.2.1/bits/std_function.h:687
    #17 0x55b6ee962f1b in gdb::observers::observable<bpstats*, int>::notify(bpstats*, int) const /home/simark/src/binutils-gdb/gdb/common/observable.h:106
    #18 0x55b6ee95a6e7 in normal_stop() /home/simark/src/binutils-gdb/gdb/infrun.c:8142
    #19 0x55b6ee93f236 in fetch_inferior_event(void*) /home/simark/src/binutils-gdb/gdb/infrun.c:3782
    #20 0x55b6ee8f2641 in inferior_event_handler(inferior_event_type, void*) /home/simark/src/binutils-gdb/gdb/inf-loop.c:43
    #21 0x55b6eea2a1f0 in handle_target_event /home/simark/src/binutils-gdb/gdb/linux-nat.c:4358
    #22 0x55b6ee7045f1 in handle_file_event /home/simark/src/binutils-gdb/gdb/event-loop.c:733
    #23 0x55b6ee704e89 in gdb_wait_for_event /home/simark/src/binutils-gdb/gdb/event-loop.c:859
    #24 0x55b6ee7027b5 in gdb_do_one_event() /home/simark/src/binutils-gdb/gdb/event-loop.c:322
    #25 0x55b6ee702907 in start_event_loop() /home/simark/src/binutils-gdb/gdb/event-loop.c:371
    #26 0x55b6eeadfc16 in captured_command_loop /home/simark/src/binutils-gdb/gdb/main.c:331
    #27 0x55b6eeae2ef9 in captured_main /home/simark/src/binutils-gdb/gdb/main.c:1174
    #28 0x55b6eeae30c2 in gdb_main(captured_main_args*) /home/simark/src/binutils-gdb/gdb/main.c:1190
    #29 0x55b6edf4fa89 in main /home/simark/src/binutils-gdb/gdb/gdb.c:32

previously allocated by thread T0 here:
    #0 0x7fed89a8b019 in __interceptor_malloc /build/gcc/src/gcc/libsanitizer/asan/asan_malloc_linux.cc:86
    #1 0x7fed88af983f in realpath@@GLIBC_2.3 (/usr/lib/libc.so.6+0x4583f)
    #2 0x7fed899dbbbc in __interceptor_canonicalize_file_name /build/gcc/src/gcc/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:3297
    #3 0x55b6ee376a03 in gdb_realpath(char const*) /home/simark/src/binutils-gdb/gdb/common/pathstuff.c:72
    #4 0x55b6ef09ec12 in find_and_open_source(char const*, char const*, std::unique_ptr<char, gdb::xfree_deleter<char> >*) /home/simark/src/binutils-gdb/gdb/source.c:990
    #5 0x55b6ef09f56a in open_source_file(symtab*) /home/simark/src/binutils-gdb/gdb/source.c:1069
    #6 0x55b6ef0a0f12 in print_source_lines_base /home/simark/src/binutils-gdb/gdb/source.c:1270
    #7 0x55b6ef0a2045 in print_source_lines(symtab*, int, int, enum_flags<print_source_lines_flag>) /home/simark/src/binutils-gdb/gdb/source.c:1415
    #8 0x55b6ef112c87 in print_frame_info(frame_info*, int, print_what, int, int) /home/simark/src/binutils-gdb/gdb/stack.c:914
    #9 0x55b6ef10e90d in print_stack_frame(frame_info*, int, print_what, int) /home/simark/src/binutils-gdb/gdb/stack.c:180
    #10 0x55b6ee9592f8 in print_stop_location /home/simark/src/binutils-gdb/gdb/infrun.c:7853
    #11 0x55b6ee95948f in print_stop_event(ui_out*) /home/simark/src/binutils-gdb/gdb/infrun.c:7870
    #12 0x55b6ef34b962 in tui_on_normal_stop /home/simark/src/binutils-gdb/gdb/tui/tui-interp.c:98
    #13 0x55b6ee01a14d in std::_Function_handler<void (bpstats*, int), void (*)(bpstats*, int)>::_M_invoke(std::_Any_data const&, bpstats*&&, int&&) /usr/include/c++/8.2.1/bits/std_function.h:297
    #14 0x55b6ee965415 in std::function<void (bpstats*, int)>::operator()(bpstats*, int) const /usr/include/c++/8.2.1/bits/std_function.h:687
    #15 0x55b6ee962f1b in gdb::observers::observable<bpstats*, int>::notify(bpstats*, int) const /home/simark/src/binutils-gdb/gdb/common/observable.h:106
    #16 0x55b6ee95a6e7 in normal_stop() /home/simark/src/binutils-gdb/gdb/infrun.c:8142
    #17 0x55b6ee93f236 in fetch_inferior_event(void*) /home/simark/src/binutils-gdb/gdb/infrun.c:3782
    #18 0x55b6ee8f2641 in inferior_event_handler(inferior_event_type, void*) /home/simark/src/binutils-gdb/gdb/inf-loop.c:43
    #19 0x55b6eea2a1f0 in handle_target_event /home/simark/src/binutils-gdb/gdb/linux-nat.c:4358
    #20 0x55b6ee7045f1 in handle_file_event /home/simark/src/binutils-gdb/gdb/event-loop.c:733
    #21 0x55b6ee704e89 in gdb_wait_for_event /home/simark/src/binutils-gdb/gdb/event-loop.c:859
    #22 0x55b6ee7027b5 in gdb_do_one_event() /home/simark/src/binutils-gdb/gdb/event-loop.c:322
    #23 0x55b6ee702907 in start_event_loop() /home/simark/src/binutils-gdb/gdb/event-loop.c:371
    #24 0x55b6eeadfc16 in captured_command_loop /home/simark/src/binutils-gdb/gdb/main.c:331
    #25 0x55b6eeae2ef9 in captured_main /home/simark/src/binutils-gdb/gdb/main.c:1174
    #26 0x55b6eeae30c2 in gdb_main(captured_main_args*) /home/simark/src/binutils-gdb/gdb/main.c:1190
    #27 0x55b6edf4fa89 in main /home/simark/src/binutils-gdb/gdb/gdb.c:32
    #28 0x7fed88ad8222 in __libc_start_main (/usr/lib/libc.so.6+0x24222)

gdb/ChangeLog:

	* source-cache.c (source_cache::get_source_lines): Re-read
	fullname after calling open_source_file.


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Fix first time you type UP or DOWN in TUI's command window
@ 2019-03-18 19:27 sergiodj+buildbot
  2019-03-18 19:27 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-03-18 19:27 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7fa34358ef888d242c3441b2a2342297b17775e3 ***

Author: Pedro Alves <palves@redhat.com>
Branch: gdb-8.3-branch
Commit: 7fa34358ef888d242c3441b2a2342297b17775e3

Fix first time you type UP or DOWN in TUI's command window

The first time you type UP or DOWN arrow in the command window, GDB
should scroll the source window, but instead it displays the line
number and the file name in the command window(?).

What happens there is that the first time we call
tui_ui_out::do_field_int, it doesn't initialize m_line, because
m_start_of_line is -1, as set by the constructor; and then the
following call to tui_ui_out::do_field_string falls back to
cli_ui_out::do_field_string because m_line is zero.

The problem is caused by a typo in the C++ification of tui_ui_out,
commit 112e8700a6f, where m_line and m_start_of_line's initial values
were swapped from what they used to be:

 -struct ui_out *
 -tui_out_new (struct ui_file *stream)
 +tui_ui_out::tui_ui_out (ui_file *stream)
 +: cli_ui_out (stream, 0),
 +  m_line (0),
 +  m_start_of_line (-1)
  {
 -
 -  /* Initialize our fields.  */
 -  data->line = -1;
 -  data->start_of_line = 0;

This commit fixes it.

gdb/ChangeLog:
2019-03-18  Pedro Alves  <palves@redhat.com>
	    Eli Zaretskii <eliz@gnu.org>

	* tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
	m_line and m_start_of_line.


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Fix gdb/TUI behavior in response to [Enter] keypress
@ 2019-03-18 18:37 sergiodj+buildbot
  2019-03-18 18:37 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-03-18 18:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 2e73c81b875328f60d22d74ddb8dbe77757d9737 ***

Author: Eli Zaretskii <eliz@gnu.org>
Branch: gdb-8.3-branch
Commit: 2e73c81b875328f60d22d74ddb8dbe77757d9737

Fix gdb/TUI behavior in response to [Enter] keypress

gdb/ChangeLog:
2019-03-18  Eli Zaretskii  <eliz@gnu.org>

	* tui/tui-io.c (gdb_wgetch): Don't echo CR.
	(tui_getc): When gdb_wgetch returns a CR, behave the same as when
	it returns a newline.  This fixes a regression in TUI mode, whereby
	the next line is output on the same screen line as the user input.

(cherry picked from commit b17c4cd078e2d1d8951951016815e474fb133780)


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Improve/fix the TUI's current source line highlight
@ 2019-03-18 15:25 sergiodj+buildbot
  2019-03-18 15:25 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-03-18 15:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 77b66be9699f4800e169acb5cba6c96bd9cb327b ***

Author: Pedro Alves <palves@redhat.com>
Branch: gdb-8.3-branch
Commit: 77b66be9699f4800e169acb5cba6c96bd9cb327b

Improve/fix the TUI's current source line highlight

With styling enabled, I think the way we display the TUI's
highlighted/current line is very ugly and distracting.  The problem in
my view is that we reverse foreground/background in colored text as
well, leading to rainbow of background colors.

This patch changes that to something that I find much more sensible --
only reverse the default foreground/background colors, leave styled
text colors alone.  If the foreground color is not the default
(because the text was styled), leave the foreground color as is.  If
e.g., the terminal is fg=BLACK, and bg=WHITE, and the style wants to
print text in RED, reverse the background color (print in BLACK), but
still print the text in RED.

Note: The new ui_file_style::set_fg method isn't called set_foreground
instead, because set_foreground is a macro in /usr/lib/term.h (ncurses).

gdb/ChangeLog:
2019-03-18  Pedro Alves  <palves@redhat.com>

	* tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
	New globals.
	(apply_style): New, factored out from ...
	(apply_ansi_escape): ... this.  Handle reverse video mode.
	(tui_set_reverse_mode): New function.
	* tui/tui-io.h (tui_set_reverse_mode): New declaration.
	* tui/tui-winsource.c (tui_show_source_line): Use
	tui_set_reverse_mode instead of setting A_STANDOUT.
	* ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
	New setter methods.


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Fix scrolling right in the TUI
@ 2019-03-18 15:12 sergiodj+buildbot
  2019-03-18 15:12 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-03-18 15:12 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6885905d1da17780b3f00f90e9b56340a7f239e8 ***

Author: Hannes Domani <ssbssa@yahoo.de>
Branch: gdb-8.3-branch
Commit: 6885905d1da17780b3f00f90e9b56340a7f239e8

Fix scrolling right in the TUI

This commit fixes two issues in scrolling right in the TUI:

#1 - Scrolling right with the arrow keys, the first keypress doesn't
do anything.  The problem is that copy_source_line() checks if
(column < first_col), and because of the ++column directly before, it
basically starts with 1 instead of 0.

#2 - Scrolling right handles TABS and escaped characters as single
characters, which just looks weird.  The problem is that there's a
spot that misses handling TABS.

gdb/ChangeLog:
2019-03-18  Hannes Domani  <ssbssa@yahoo.de>

	* tui/tui-source.c (copy_source_line): Fix handling of 'column'.
	Handle tabs.


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Fix redisplay of the current line in GDB TUI mode
@ 2019-03-17 16:32 sergiodj+buildbot
  2019-03-17 16:32 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-03-17 16:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 89ab4b06975ffc59c8a70d0cee7608ed26c836ab ***

Author: Eli Zaretskii <eliz@gnu.org>
Branch: gdb-8.3-branch
Commit: 89ab4b06975ffc59c8a70d0cee7608ed26c836ab

Fix redisplay of the current line in GDB TUI mode

Without this change, when the current line is longer than the source
window width, redisplaying that line overwrites the window frame and
also portions of the next line.

gdb/ChangeLog:
2019-03-17  Eli Zaretskii  <eliz@gnu.org>

	* tui/tui-winsource.c (tui_set_is_exec_point_at): Call
	tui_refill_source_window instead of tui_refresh_win, to update the
	current execution line.  This fixes redisplay of the current line
	when stepping through very long lines with "next" or "step".

(cherry picked from commit f7f0a12390fc514a5b7b38d1b23397d87532ce05)


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Revert "Use wclrtoeol in tui_show_source_line"
@ 2019-03-16 12:45 sergiodj+buildbot
  2019-03-16 12:45 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-03-16 12:45 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7b9d48cade45dc370b129f7279c87556af442d68 ***

Author: Eli Zaretskii <eliz@gnu.org>
Branch: gdb-8.3-branch
Commit: 7b9d48cade45dc370b129f7279c87556af442d68

Revert "Use wclrtoeol in tui_show_source_line"

gdb/ChangeLog:
2019-03-16  Eli Zaretskii  <eliz@gnu.org>

	* tui/tui-winsource.c (tui_show_source_line): Revert "Use
	wclrtoeol in tui_show_source_line".  This reverts changes made in
	commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.

(cherry picked from commit 798e1c302af509c31839c5c3b50c058b61206ee7)


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] The NEWS file had two "New targets" sections for 8.3.
@ 2019-03-14 16:38 sergiodj+buildbot
  2019-03-14 16:38 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-03-14 16:38 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT aaa9eae67da575bbb29aa76a13929666aa241da1 ***

Author: John Baldwin <jhb@FreeBSD.org>
Branch: gdb-8.3-branch
Commit: aaa9eae67da575bbb29aa76a13929666aa241da1

The NEWS file had two "New targets" sections for 8.3.

gdb/ChangeLog:

	* NEWS: Combine separate "New targets" sections for 8.3.


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Fix colors in TUI mode in MS-Windows build with ncurses
@ 2019-03-14 15:49 sergiodj+buildbot
  2019-03-14 15:49 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-03-14 15:49 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7cf3f4acfddebe44f80b71dcdf1041d870c6d100 ***

Author: Eli Zaretskii <eliz@gnu.org>
Branch: gdb-8.3-branch
Commit: 7cf3f4acfddebe44f80b71dcdf1041d870c6d100

Fix colors in TUI mode in MS-Windows build with ncurses

The MS-Windows port of ncurses fails to switch to a color pair if
one or both of the colors are the implicit default colors.  This
change records the default colors when TUI is initialized, and
then specifies them explicitly when a color pair uses the default
colors.  This allows color styling in TUI mode on MS-Windows.

gdb/ChangeLog:
2019-03-14  Eli Zaretskii  <eliz@gnu.org>

	* tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
	ncurses_norm_attr.
	(tui_initialize_io) [__MINGW32__]: Record the default terminal
	colors in ncurses_norm_attr.
	(apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
	"none", replace it with the default color recorded in
	ncurses_norm_attr.

(cherry picked from commit 3fff2c370cd658877be8107bfe9dde8dd0470b46)


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Avoid a crash in source_cache::extract_lines
@ 2019-03-14 13:08 sergiodj+buildbot
  2019-03-14 13:08 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-03-14 13:08 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 655aeea04784cdc3e4dfbc0801e7be56f9a1ec11 ***

Author: Tom Tromey <tromey@adacore.com>
Branch: gdb-8.3-branch
Commit: 655aeea04784cdc3e4dfbc0801e7be56f9a1ec11

Avoid a crash in source_cache::extract_lines

If the first requested line is larger than the number of lines in the
source buffer, source_cache::extract_lines could crash, because it
would try to pass string::npos" to string::substr.

This patch avoids the crash by checking for this case.

This version of the patch changes get_source_lines to return
std::string.

2019-03-14  Tom Tromey  <tromey@adacore.com>

	* source-cache.h (class source_cache) <get_source_lines>: Return
	std::string.
	* source-cache.c (source_cache::extract_lines): Handle case where
	first_pos==npos.  Return std::string.
	(source_cache::get_source_lines): Update.


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Add the "set style source" command
@ 2019-03-14 12:55 sergiodj+buildbot
  2019-03-14 12:55 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-03-14 12:55 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT cf2a5276288ce16242a35594db9f61fa9e8f5120 ***

Author: Tom Tromey <tromey@adacore.com>
Branch: gdb-8.3-branch
Commit: cf2a5276288ce16242a35594db9f61fa9e8f5120

Add the "set style source" command

This adds "set style source" (and "show style source") commands.  This
gives the user control over whether source code is highlighted.

2019-03-14  Tom Tromey  <tromey@adacore.com>

	* NEWS: Add item for "style sources" commands.
	* source-cache.c (source_cache::get_source_lines): Check
	source_styling.
	* cli/cli-style.c (source_styling): New global.
	(_initialize_cli_style): Add "style sources" commands.
	(show_style_sources): New function.
	* cli/cli-style.h (source_styling): Declare.

gdb/doc/ChangeLog
2019-03-14  Tom Tromey  <tromey@adacore.com>

	* gdb.texinfo (Output Styling): Document "set style source" and
	"show style source".

gdb/testsuite/ChangeLog
2019-03-14  Tom Tromey  <tromey@adacore.com>

	* gdb.base/style.exp: Add "set style sources" test.


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Make TUI react to "set style enabled"
@ 2019-03-14 12:41 sergiodj+buildbot
  2019-03-14 12:41 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-03-14 12:41 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3768f5bdec2ed46e7c3c07c863cebd99a5efe645 ***

Author: Tom Tromey <tromey@adacore.com>
Branch: gdb-8.3-branch
Commit: 3768f5bdec2ed46e7c3c07c863cebd99a5efe645

Make TUI react to "set style enabled"

When the user toggles "set style enabled", the TUI should react by
redrawing the source window, if necessary.  This patch implements this
behavior.

No test because the TUI is generally not tested.

This version of the patch incorporates Pedro's patch to provide a
clean way to force the TUI to update the source window's contents.

2019-03-14  Pedro Alves  <palves@redhat.com>
	    Tom Tromey  <tromey@adacore.com>

	* tui/tui-winsource.h (tui_refill_source_window): Declare.
	* tui/tui-winsource.c (tui_refill_source_window): New function,
	from...
	(tui_horizontal_source_scroll): ... here.  Move some logic.
	* cli/cli-style.c (set_style_enabled): Notify new observable.
	* tui/tui-hooks.c (tui_redisplay_source): New function.
	(tui_attach_detach_observers): Attach or detach
	tui_redisplay_source.
	* observable.h (source_styling_changed): New observable.
	* observable.c: Define source_styling_changed observable.


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Fix MinGW build with source-highlight
@ 2019-03-12 18:13 sergiodj+buildbot
  2019-03-12 18:13 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-03-12 18:13 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4a9e44628b32c26e91aa480ae93db4432ed8d957 ***

Author: Eli Zaretskii <eliz@gnu.org>
Branch: gdb-8.3-branch
Commit: 4a9e44628b32c26e91aa480ae93db4432ed8d957

Fix MinGW build with source-highlight

gdb/ChangeLog
2019-03-12  Eli Zaretskii  <eliz@gnu.org>

	PR/24325
	* source-cache.c: #undef open and close, to avoid unresolved
	externals during linking.

(cherry picked from commit 3a3508220eecf27e1952a73cd3ea6d6314ce8e1d)


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Support styling on native MS-Windows console
@ 2019-03-09  7:14 sergiodj+buildbot
  2019-03-09  7:14 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-03-09  7:14 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1778a983e2f31181644b7574b8d062e4be22e813 ***

Author: Eli Zaretskii <eliz@gnu.org>
Branch: gdb-8.3-branch
Commit: 1778a983e2f31181644b7574b8d062e4be22e813

Support styling on native MS-Windows console

gdb/ChangeLog:
2019-03-08  Eli Zaretskii  <eliz@gnu.org>

	PR/24315
	* utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
	on MS-Windows if $TERM is not defined.

	* cli/cli-style.c: Set cli_styling to 1 in the MinGW build.

	* posix-hdep.c (gdb_console_fputs):
	* mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
	functions.
	* ui-file.h (gdb_console_fputs): Add prototype.

	* ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
	back to fputs only if the former returns zero.

(cherry picked from commit e4adb93903d4ae0b7ab2b5004364e50627df95f7)


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Can't interrupt process without controlling terminal on Solaris (PR gdb/8527)
@ 2019-03-07 21:15 sergiodj+buildbot
  2019-03-07 21:16 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-03-07 21:15 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 6028d151fc820579da1292c4cc393a4bcd3da8f8 ***

Author: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Branch: gdb-8.3-branch
Commit: 6028d151fc820579da1292c4cc393a4bcd3da8f8

Can't interrupt process without controlling terminal on Solaris (PR gdb/8527)

If gdb attaches to a process that either has no controlling terminal,
or the controlling terminal differs from the one gdb is running under,
break/^C doesn't interrupt the debugged process on Solaris.

Fixed as follows, analogous to what all all other targets do.  Patch from
the PR, recently re-submitted by Brian Vandenberg.

Tested on amd64-pc-solaris2.11, sparcv9-sun-solaris2.11, and
x86_64-pc-linux-gnu.

2019-03-07  Brian Vandenberg  <phantall@gmail.com>
	    Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	gdb:
	PR gdb/8527
	* procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
	set_sigint_trap, clear_sigint_trap.

	gdb/testsuite:
	PR gdb/8527
	* gdb.base/interrupt-daemon-attach.c,
	gdb.base/interrupt-daemon-attach.exp: New test.


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Testsuite: Ensure changing directory does not break the log file
@ 2019-03-06 10:29 sergiodj+buildbot
  2019-03-06 10:29 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-03-06 10:29 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 9b068afad22bfa9386b21762c91eaddd8ef691b4 ***

Author: Alan Hayward <alan.hayward@arm.com>
Branch: gdb-8.3-branch
Commit: 9b068afad22bfa9386b21762c91eaddd8ef691b4

Testsuite: Ensure changing directory does not break the log file

get_compiler_info switches to a new log file before checking the compiler
to ensure the checks are not logged. Afterwards it restores back to using
the original log file. However, the logfile uses a relative path name -
if the current test has changed the current directory then all further
output for the test will be lost.  This can confuse the code that collates
the main gdb.log file at the end of a FORCE_PARALLEL run.

fullpath-expand.exp calls gdb_compile after changing the current directory.

The "Ensure stack protection is off for GCC" patch added a call to
get_compiler_info from inside of gdb_compile, causing log file collection
to break for FORCE_PARALLEL runs.

The ideal solution would be to ensure the log file is always created using
an absolute path name. However, this is set at multiple points in
Makefile.in and in some instances just relies on dejagnu common code to set
the log file directory to "."

The simpler and safer solution is to override the builtin cd function. The
new function checks the current log file and if the path is relative, then
it resets the logging using an absolute path. Finally it calls the builtin
cd.  This ensures get_compiler_info (and any other code) can correctly
backup and restore the current log file.

gdb/testsuite/ChangeLog:

	* lib/gdb.exp (builtin_cd): rename of cd.
	(cd): Override builtin.


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Use '$enable_unittest' instead of '$development' on gdbserver/configure.srv (for 'aarch64*-*-linux*' case)
@ 2019-03-05 17:52 sergiodj+buildbot
  2019-03-05 17:52 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-03-05 17:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 24329b66c90f1f51c96e718fe6533af3a3b4aa47 ***

Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: gdb-8.3-branch
Commit: 24329b66c90f1f51c96e718fe6533af3a3b4aa47

Use '$enable_unittest' instead of '$development' on gdbserver/configure.srv (for 'aarch64*-*-linux*' case)

On commit 8ecfd7bd4acd69213c06fac6de9af38299123547 ("Add parameter to
allow enabling/disabling selftests via configure") it seems that I
forgot to use the proper '$enable_unittest' variable when checking to
see whether to add selftest-related objects to 'srv_regobj'.  This
causes a build failure on Aarch64 when 'development=false' (which is
the case for the 8.3 branch) and 'enable_unittest=true'.

This patch fixes the problem by using '$enable_unittest' instead of
'$development' when performing the check.  As a reminder, it's
important to notice that '$enable_unittest's default value (i.e., when
the option '--enable-unit-tests' is not passed to configure) is the
same as '$development', so this patch doesn't affect the current
build.

I'd like to install this patch both on master and on the 8.3 branch.

OK?

gdb/gdbserver/ChangeLog:
2019-03-04  Sergio Durigan Junior  <sergiodj@redhat.com>

	* configure.srv: Use '$enable_unittest' instead of '$development'
	when checking whether to fill 'srv_regobj' on 'aarch64*-*-linux*'
	case.


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Avoid compilation warnings on MinGW.
@ 2019-03-02 14:32 sergiodj+buildbot
  2019-03-02 14:32 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-03-02 14:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 4344b2225c8d4878a27401b94ec6315c728f46bf ***

Author: Eli Zaretskii <eliz@gnu.org>
Branch: gdb-8.3-branch
Commit: 4344b2225c8d4878a27401b94ec6315c728f46bf

Avoid compilation warnings on MinGW.

gdb/ChangeLog:
2019-03-02  Eli Zaretskii  <eliz@gnu.org>

	* xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
	for-loop range, to avoid compiler warnings.

	* tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
	avoid compiler warnings about unused variables.

(cherry picked from commit a6a4b2c636b29de09dea890b448f99804ef7bc18)


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] GDB no longer supports Windows before XP.
@ 2019-03-02 14:21 sergiodj+buildbot
  2019-03-02 14:21 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-03-02 14:21 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0db97a309b840fa59b0348049082b850702639e2 ***

Author: Eli Zaretskii <eliz@gnu.org>
Branch: gdb-8.3-branch
Commit: 0db97a309b840fa59b0348049082b850702639e2

GDB no longer supports Windows before XP.

gdb/ChangeLog:
2019-03-02  Eli Zaretskii  <eliz@gnu.org>

	* NEWS: Mention end of support for native debugging on MS-Windows
	before XP.

(cherry picked from commit 742a7df5f4a149f0818aaccfc432c4c0c9a6e26d)


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Fix GDB compilation on MinGW (PR gdb/24292)
@ 2019-03-02 14:11 sergiodj+buildbot
  2019-03-02 14:11 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-03-02 14:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 654c8256bb9e083b3dcdd6205d6ecbc6beddb00e ***

Author: Eli Zaretskii <eliz@gnu.org>
Branch: gdb-8.3-branch
Commit: 654c8256bb9e083b3dcdd6205d6ecbc6beddb00e

Fix GDB compilation on MinGW (PR gdb/24292)

gdb/ChangeLog:
2019-03-02  Eli Zaretskii  <eliz@gnu.org>

	PR gdb/24292
	* common/netstuff.c:
	* gdbserver/gdbreplay.c
	* gdbserver/remote-utils.c:
	* ser-tcp.c:
	* unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
	Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
	_WIN32_WINNT to 0x0501 if defined to a smaller value, as
	'getaddrinfo' and 'freeaddrinfo' were not available before
	Windows XP, and mingw.org's MinGW headers by default define
	_WIN32_WINNT to 0x500.

(cherry picked from commit 41fa577fbc326402be49b3f03bc828e52dba8b88)


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Document fact that mininum Python version is now 2.6
@ 2019-02-27 19:49 sergiodj+buildbot
  2019-02-27 19:49 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-02-27 19:49 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7008bd663c7b314d9177044bb70fd39d4103e2c4 ***

Author: Kevin Buettner <kevinb@redhat.com>
Branch: gdb-8.3-branch
Commit: 7008bd663c7b314d9177044bb70fd39d4103e2c4

Document fact that mininum Python version is now 2.6

gdb/ChangeLog:

	* NEWS: Note minimum Python version.

gdb/doc/ChangeLog:

	* gdb.texinfo (Configure Options): Document minimum python
	version.


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Bump GDB version number to 8.2.90.DATE-git.
@ 2019-02-27  6:22 sergiodj+buildbot
  2019-02-27  6:22 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-02-27  6:22 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e94d66159e5a0d7e574466343b14ee3da7814da1 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: gdb-8.3-branch
Commit: e94d66159e5a0d7e574466343b14ee3da7814da1

Bump GDB version number to 8.2.90.DATE-git.

gdb/ChangeLog:

	* version.in: Set GDB version number to 8.2.90.DATE-git.


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Set GDB version number to 8.2.90.
@ 2019-02-27  6:11 sergiodj+buildbot
  2019-02-27  6:11 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-02-27  6:11 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c77cdfe6472414713071709731fe3b7041f8608e ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: gdb-8.3-branch
Commit: c77cdfe6472414713071709731fe3b7041f8608e

Set GDB version number to 8.2.90.

gdb/ChangeLog:

	* version.in: Set GDB version number to 8.2.90.


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] change section name in gdb/NEWS for changes in GDB 8.3
@ 2019-02-27  5:59 sergiodj+buildbot
  2019-02-27  5:59 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-02-27  5:59 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d05bcc0f7696eb2e33779f13701c4af10eed0e89 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: gdb-8.3-branch
Commit: d05bcc0f7696eb2e33779f13701c4af10eed0e89

change section name in gdb/NEWS for changes in GDB 8.3

gdb/ChangeLog:

        * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [binutils-gdb/gdb-8.3-branch] Set development mode to "off" by default.
@ 2019-02-27  5:26 sergiodj+buildbot
  2019-02-27  5:26 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
  0 siblings, 1 reply; 55+ messages in thread
From: sergiodj+buildbot @ 2019-02-27  5:26 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c96a77fd206679a62db8912f0219d69b31ea3fe6 ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: gdb-8.3-branch
Commit: c96a77fd206679a62db8912f0219d69b31ea3fe6

Set development mode to "off" by default.

bfd/ChangeLog:

	* development.sh (development): Set to false.


^ permalink raw reply	[flat|nested] 55+ messages in thread
end of thread, other threads:[~2019-05-11 18:58 UTC | newest]

Thread overview: 55+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-16 18:28 [binutils-gdb/gdb-8.3-branch] Fix vertical scrolling of TUI source window sergiodj+buildbot
2019-03-16 18:28 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-03-17  2:55 ` Failures on Debian-s390x-native-extended-gdbserver-m64, " sergiodj+buildbot
2019-03-17  3:31 ` Failures on Debian-s390x-native-gdbserver-m64, " sergiodj+buildbot
2019-03-17  3:52 ` Failures on Debian-s390x-m64, " sergiodj+buildbot
2019-03-21 19:11 ` Failures on Fedora-i686, " sergiodj+buildbot
2019-03-21 19:25 ` Failures on Fedora-x86_64-cc-with-index, " sergiodj+buildbot
2019-03-21 20:01 ` Failures on Fedora-x86_64-native-gdbserver-m64, " sergiodj+buildbot
2019-03-21 20:50 ` Failures on Fedora-x86_64-m32, " sergiodj+buildbot
2019-03-21 21:12 ` Failures on Fedora-x86_64-native-gdbserver-m32, " sergiodj+buildbot
2019-03-21 21:35 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " sergiodj+buildbot
2019-03-22  0:59 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " sergiodj+buildbot
  -- strict thread matches above, loose matches on Subject: below --
2019-05-11 18:58 [binutils-gdb/gdb-8.3-branch] Bump GDB version number to 8.3.0.DATE-git sergiodj+buildbot
2019-05-11 19:14 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-05-11 18:40 [binutils-gdb/gdb-8.3-branch] Set GDB version number to 8.3 sergiodj+buildbot
2019-05-11 18:54 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-05-08 17:50 [binutils-gdb/gdb-8.3-branch] Fix style bug when paging sergiodj+buildbot
2019-05-08 17:54 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-05-04 20:48 [binutils-gdb/gdb-8.3-branch] Don't derive partial_symbol from general_symbol_info sergiodj+buildbot
2019-05-04 21:04 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-05-03  8:22 [binutils-gdb/gdb-8.3-branch] Fix compilation with mingw.org's MinGW sergiodj+buildbot
2019-05-03  8:32 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-05-03  8:07 [binutils-gdb/gdb-8.3-branch] Fix lookup of separate debug file on MS-Windows sergiodj+buildbot
2019-05-03  8:22 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-05-03  7:23 [binutils-gdb/gdb-8.3-branch] Treat the .gnu.debuglink and .gnu.debugaltlink sections as debug sections when reading them in from COFF/PE format files sergiodj+buildbot
2019-05-03  7:38 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-04-30 21:20 [binutils-gdb/gdb-8.3-branch] (Windows) fix thr != nullptr assert failure in delete_thread_1 sergiodj+buildbot
2019-04-30 21:32 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-04-30 14:56 [binutils-gdb/gdb-8.3-branch] Fix crash in dwarf2read.c with template parameters sergiodj+buildbot
2019-04-30 15:12 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-04-20 16:55 [binutils-gdb/gdb-8.3-branch] gdb/configure.ac: add --enable-source-highlight sergiodj+buildbot
2019-04-20 17:10 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-04-20 16:08 [binutils-gdb/gdb-8.3-branch] Fix "list" when control characters are seen sergiodj+buildbot
2019-04-20 16:34 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-04-20 15:20 [binutils-gdb/gdb-8.3-branch] Fix GDB 8.3 regression crash when registers cannot be modified sergiodj+buildbot
2019-04-20 15:36 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-04-12 13:08 [binutils-gdb/gdb-8.3-branch] Another fix for GDB styling sergiodj+buildbot
2019-04-12 13:39 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-03-28 18:47 [binutils-gdb/gdb-8.3-branch] Fix testsuite hangs when gdb_test_multiple body errors out sergiodj+buildbot
2019-03-28 20:39 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-03-27  1:03 [binutils-gdb/gdb-8.3-branch] Bump GDB version number to 8.2.91.DATE-git sergiodj+buildbot
2019-03-27  1:31 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-03-27  0:32 [binutils-gdb/gdb-8.3-branch] Set GDB version number to 8.2.91 sergiodj+buildbot
2019-03-27  0:32 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-03-26 23:59 [binutils-gdb/gdb-8.3-branch] gdb/testsuite: Prepare for DejaGnu 1.6.2 sergiodj+buildbot
2019-03-27  0:14 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-03-26 22:00 [binutils-gdb/gdb-8.3-branch] Merge handle_inferior_event and handle_inferior_event_1 sergiodj+buildbot
2019-03-26 21:52 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-03-26  1:15 [binutils-gdb/gdb-8.3-branch] Fix use-after-free in source_cache::get_source_lines sergiodj+buildbot
2019-03-26  1:06 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-03-18 19:27 [binutils-gdb/gdb-8.3-branch] Fix first time you type UP or DOWN in TUI's command window sergiodj+buildbot
2019-03-18 19:27 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-03-18 18:37 [binutils-gdb/gdb-8.3-branch] Fix gdb/TUI behavior in response to [Enter] keypress sergiodj+buildbot
2019-03-18 18:37 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-03-18 15:25 [binutils-gdb/gdb-8.3-branch] Improve/fix the TUI's current source line highlight sergiodj+buildbot
2019-03-18 15:25 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-03-18 15:12 [binutils-gdb/gdb-8.3-branch] Fix scrolling right in the TUI sergiodj+buildbot
2019-03-18 15:12 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-03-17 16:32 [binutils-gdb/gdb-8.3-branch] Fix redisplay of the current line in GDB TUI mode sergiodj+buildbot
2019-03-17 16:32 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-03-16 12:45 [binutils-gdb/gdb-8.3-branch] Revert "Use wclrtoeol in tui_show_source_line" sergiodj+buildbot
2019-03-16 12:45 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-03-14 16:38 [binutils-gdb/gdb-8.3-branch] The NEWS file had two "New targets" sections for 8.3 sergiodj+buildbot
2019-03-14 16:38 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-03-14 15:49 [binutils-gdb/gdb-8.3-branch] Fix colors in TUI mode in MS-Windows build with ncurses sergiodj+buildbot
2019-03-14 15:49 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-03-14 13:08 [binutils-gdb/gdb-8.3-branch] Avoid a crash in source_cache::extract_lines sergiodj+buildbot
2019-03-14 13:08 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-03-14 12:55 [binutils-gdb/gdb-8.3-branch] Add the "set style source" command sergiodj+buildbot
2019-03-14 12:55 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-03-14 12:41 [binutils-gdb/gdb-8.3-branch] Make TUI react to "set style enabled" sergiodj+buildbot
2019-03-14 12:41 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-03-12 18:13 [binutils-gdb/gdb-8.3-branch] Fix MinGW build with source-highlight sergiodj+buildbot
2019-03-12 18:13 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-03-09  7:14 [binutils-gdb/gdb-8.3-branch] Support styling on native MS-Windows console sergiodj+buildbot
2019-03-09  7:14 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-03-07 21:15 [binutils-gdb/gdb-8.3-branch] Can't interrupt process without controlling terminal on Solaris (PR gdb/8527) sergiodj+buildbot
2019-03-07 21:16 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-03-06 10:29 [binutils-gdb/gdb-8.3-branch] Testsuite: Ensure changing directory does not break the log file sergiodj+buildbot
2019-03-06 10:29 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-03-05 17:52 [binutils-gdb/gdb-8.3-branch] Use '$enable_unittest' instead of '$development' on gdbserver/configure.srv (for 'aarch64*-*-linux*' case) sergiodj+buildbot
2019-03-05 17:52 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-03-02 14:32 [binutils-gdb/gdb-8.3-branch] Avoid compilation warnings on MinGW sergiodj+buildbot
2019-03-02 14:32 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-03-02 14:21 [binutils-gdb/gdb-8.3-branch] GDB no longer supports Windows before XP sergiodj+buildbot
2019-03-02 14:21 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-03-02 14:11 [binutils-gdb/gdb-8.3-branch] Fix GDB compilation on MinGW (PR gdb/24292) sergiodj+buildbot
2019-03-02 14:11 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-02-27 19:49 [binutils-gdb/gdb-8.3-branch] Document fact that mininum Python version is now 2.6 sergiodj+buildbot
2019-02-27 19:49 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-02-27  6:22 [binutils-gdb/gdb-8.3-branch] Bump GDB version number to 8.2.90.DATE-git sergiodj+buildbot
2019-02-27  6:22 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-02-27  6:11 [binutils-gdb/gdb-8.3-branch] Set GDB version number to 8.2.90 sergiodj+buildbot
2019-02-27  6:11 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-02-27  5:59 [binutils-gdb/gdb-8.3-branch] change section name in gdb/NEWS for changes in GDB 8.3 sergiodj+buildbot
2019-02-27  5:59 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot
2019-02-27  5:26 [binutils-gdb/gdb-8.3-branch] Set development mode to "off" by default sergiodj+buildbot
2019-02-27  5:26 ` Failures on RHEL-s390x-m64, branch gdb-8.3-branch sergiodj+buildbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).