*** COMPILATION FAILED *** Failures on Solaris11-amd64-m64, branch master *** BREAKAGE ***

[gdb-buildbot@sergiodj.net]

Buildername:
        Solaris11-amd64-m64

Worker:
        solaris11-amd64

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/14/builds/2149

Author:
        Tom Tromey <tom@tromey.com>

Commit tested:
        0240c8f11b06a33a043bacbe2b9e723ae6ad573c

Subject of commit:
        Change how TUI windows are instantiated

*** FAILED to build GDB -- compile gdb ***
==============================================

+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.

  CXX    solib.o
  CXX    source-cache.o
  CXX    source.o
  CXX    stabsread.o
  CXX    stack.o
  CXX    stap-probe.o
  CXX    std-regs.o
  CXX    symfile-debug.o
  CXX    symfile.o
  CXX    symmisc.o
  CXX    symtab.o
  CXX    target-connection.o
  CXX    target-dcache.o
  CXX    target-descriptions.o
  CXX    target-float.o
  CXX    target-memory.o
  CXX    target.o
  CXX    target/waitstatus.o
  CXX    test-target.o
  CXX    thread-iter.o
  CXX    thread.o
  CXX    tid-parse.o
  CXX    top.o
  CXX    tracectf.o
  CXX    tracefile-tfile.o
  CXX    tracefile.o
  CXX    tracepoint.o
  CXX    trad-frame.o
  CXX    tramp-frame.o
  CXX    tui/tui-command.o
  CXX    tui/tui-data.o
  CXX    tui/tui-disasm.o
  CXX    tui/tui-file.o
  CXX    tui/tui-hooks.o
  CXX    tui/tui-interp.o
  CXX    tui/tui-io.o
  CXX    tui/tui-layout.o
  CXX    tui/tui-out.o
  CXX    tui/tui-regs.o
  CXX    tui/tui-source.o
../../binutils-gdb/gdb/tui/tui-layout.c:354:40: error: window_factory was not declared in this scope
 static std::unordered_map<std::string, window_factory> *known_window_types;
                                        ^~~~~~~~~~~~~~
../../binutils-gdb/gdb/tui/tui-layout.c:354:54: error: template argument 2 is invalid
 static std::unordered_map<std::string, window_factory> *known_window_types;
                                                      ^
../../binutils-gdb/gdb/tui/tui-layout.c:354:54: error: template argument 5 is invalid
../../binutils-gdb/gdb/tui/tui-layout.c: In function tui_gen_win_info* tui_get_window_by_name(const string&):
../../binutils-gdb/gdb/tui/tui-layout.c:361:31: error: saved_tui_windows was not declared in this scope
   for (tui_win_info *window : saved_tui_windows)
                               ^~~~~~~~~~~~~~~~~
../../binutils-gdb/gdb/tui/tui-layout.c:361:31: note: suggested alternative: all_tui_windows
   for (tui_win_info *window : saved_tui_windows)
                               ^~~~~~~~~~~~~~~~~
                               all_tui_windows
../../binutils-gdb/gdb/tui/tui-layout.c:365:35: error: request for member find in * known_window_types, which is of non-class type int
   auto iter = known_window_types->find (name);
                                   ^~~~
../../binutils-gdb/gdb/tui/tui-layout.c:366:35: error: request for member end in * known_window_types, which is of non-class type int
   if (iter == known_window_types->end ())
                                   ^~~
../../binutils-gdb/gdb/tui/tui-layout.c: In function void initialize_known_windows():
../../binutils-gdb/gdb/tui/tui-layout.c:380:60: error: window_factory was not declared in this scope
   known_window_types = new std::unordered_map<std::string, window_factory>;
                                                            ^~~~~~~~~~~~~~
../../binutils-gdb/gdb/tui/tui-layout.c:380:74: error: template argument 2 is invalid
   known_window_types = new std::unordered_map<std::string, window_factory>;
                                                                          ^
../../binutils-gdb/gdb/tui/tui-layout.c:380:74: error: template argument 5 is invalid
../../binutils-gdb/gdb/tui/tui-layout.c:382:23: error: request for member emplace in * known_window_types, which is of non-class type int
   known_window_types->emplace ("src",
                       ^~~~~~~
../../binutils-gdb/gdb/tui/tui-layout.c:385:23: error: request for member emplace in * known_window_types, which is of non-class type int
   known_window_types->emplace ("cmd",
                       ^~~~~~~
../../binutils-gdb/gdb/tui/tui-layout.c:387:23: error: request for member emplace in * known_window_types, which is of non-class type int
   known_window_types->emplace ("regs",
                       ^~~~~~~
../../binutils-gdb/gdb/tui/tui-layout.c:390:23: error: request for member emplace in * known_window_types, which is of non-class type int
   known_window_types->emplace ("asm",
                       ^~~~~~~
../../binutils-gdb/gdb/tui/tui-layout.c:393:23: error: request for member emplace in * known_window_types, which is of non-class type int
   known_window_types->emplace ("status", get_locator_window);
                       ^~~~~~~
../../binutils-gdb/gdb/tui/tui-layout.c: In function bool validate_window_name(const string&):
../../binutils-gdb/gdb/tui/tui-layout.c:924:35: error: request for member find in * known_window_types, which is of non-class type int
   auto iter = known_window_types->find (name);
                                   ^~~~
../../binutils-gdb/gdb/tui/tui-layout.c:925:38: error: request for member end in * known_window_types, which is of non-class type int
   return iter != known_window_types->end ();
                                      ^~~
gmake[2]: *** [Makefile:1597: tui/tui-layout.o] Error 1
gmake[2]: *** Waiting for unfinished jobs....
gmake[2]: Leaving directory '/opt/gdb-buildbot/home/solaris11-amd64/solaris11-amd64-m64/build/gdb'
gmake[1]: *** [Makefile:9731: all-gdb] Error 2
gmake[1]: Leaving directory '/opt/gdb-buildbot/home/solaris11-amd64/solaris11-amd64-m64/build'
gmake: *** [Makefile:853: all] Error 2
program finished with exit code 2
elapsedTime=397.087514
==============================================