From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by sourceware.org (Postfix) with ESMTPS id 637153858C42; Mon, 8 Jan 2024 23:28:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 637153858C42 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 637153858C42 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::52b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704756510; cv=none; b=bC2UzjBxQWhA4+0dR47ThdwVA5TUIebi3Md4mHOaOTUG+R3TXeekL2tDoT2l3qUlF9ZLVQvJRAo5d3Ztn+Xnm44Qbv9h+HQ5kxdMs70iTfum8lJ1L+mPdKbvWlHHpA+rnFOfbYdYZ0u13xm7k3MXgMDriPpSbq/GLpNaIvPE4o8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704756510; c=relaxed/simple; bh=LmaKLNEm6LmJN7le9s75yrRW3AXzpuSg1phFU2cyf1w=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=ed/FCuO56Yknpz07eo5oL8kMCzp8FAOnOzXuemQuOVlN/O42ExKioHIVPy2O1H1EimzgR2hIWnTu8RDgmCWDjEick95IMQnbefKYU49CDyDbeZU9W0lragKwytzaj5L3/SFDfg951MrqZuwiN7owNt9i1g9a1coTFMe39beZ0qw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-5ce07cf1e5dso881741a12.2; Mon, 08 Jan 2024 15:28:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704756508; x=1705361308; darn=sourceware.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=eFYcaQSXoMPyYHWB/awLFDVO3+R8hkhIXcxCOx/4Wpo=; b=ADrSMYXKN7Zv+eTw5q8+YS6VBt5DoiwC1mlrnI1pFgkxs/jD/FnFytW9QmkYyCzKUv px1XF85uCk9PoQGvKepeyHiDFq4RqaMOFf3LhxtaD1FX4VjtnNXW8tDXOF6aGnehjv4Q xUo3QknwEt2ZEQ5HXY7JveYS87S1gUEOdahlJYoFwc3RaZPwY5mudTjQQF5cG4c8P4j/ LSdsft1L0OZevUDIUJDm6f/+SbfcjFTtFDzL+q8UTWbrUUi8EA8ooCdi/4eYE+Qkz9vK 6bqQGdHNvJIJru0+AbPS6WgJO+iD7zyLnZd9CwHfCxRPkKb+LE5JojmWHHknRPJyhgjs b2MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704756508; x=1705361308; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eFYcaQSXoMPyYHWB/awLFDVO3+R8hkhIXcxCOx/4Wpo=; b=wRRRlOOynB7pe0coxM/YIFO+9FhX7BJ+4x10JVIITkccN2VPoGXVgVDCptlHBDUTv/ oM/uoPQ3+QkFf/ZrWvEH3gsV2nanrbJ7rLVp9s4UeHDOZdfK36BJQD93I7mR13Gz/LcN g2yD1Oj6Tr5qiT9rDhf2ihMuQelhGMJvZ9wDR7n32VOJQO/tVUlbqTwVsBxajtJwaacT pnWjhLyppdrfB/tqLK+ckoPbPQVCOTxD1HUjS9oJKpYvXHDCMuIfqiF+dfxiTJSO3oRh QiXQizDN249OEOdJtdQfWuw7zX8P0wQlyTvyd9imvRFw7euZ8fHBss0Kg3OLaqUdCKMB ZWZQ== X-Gm-Message-State: AOJu0Yx4d1t80WAghcfHKQq2pX/fsCtMUAh2UDfaTLSSuupo8jgZFQQz i+R0/yuJDX6RQ04kmERmbQ80rrTzatmr/w== X-Google-Smtp-Source: AGHT+IFjg26G09ocSLOgauDVC6j4RWQ2aFiJ75wC64fDQUORG4USC6JkTB/NpuBuWdlpfsc/R5uRVw== X-Received: by 2002:a05:6a20:c614:b0:199:88fa:adbe with SMTP id gp20-20020a056a20c61400b0019988faadbemr1348444pzb.35.1704756508325; Mon, 08 Jan 2024 15:28:28 -0800 (PST) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:63d5:18ac:9575:191a]) by smtp.gmail.com with ESMTPSA id ju21-20020a170903429500b001d1d1ef8be5sm427079plb.173.2024.01.08.15.28.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 15:28:27 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 44E5B11404FE; Tue, 9 Jan 2024 09:58:25 +1030 (ACDT) Date: Tue, 9 Jan 2024 09:58:25 +1030 From: Alan Modra To: Mark Wielaard Cc: "H.J. Lu" , Indu Bhagat , Jan Beulich , Jin Ma , Mike Frysinger , Tamar Christina , Tejas Joshi , Tom de Vries , binutils@sourceware.org, gdb-testers@sourceware.org, Arsen =?utf-8?Q?Arsenovi=C4=87?= , Sam James Subject: Re: =?utf-8?B?4pigIEJ1aWxkYm90IChTb3VyY2V3?= =?utf-8?Q?are=29=3A_binutils-gdb-autorege?= =?utf-8?Q?n?= - failed 'git diff ...' (failure) (master) Message-ID: References: <20240107052456.A09763858D35@sourceware.org> <20240107172936.GX26453@gnu.wildebeest.org> <20240108215146.GB26453@gnu.wildebeest.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240108215146.GB26453@gnu.wildebeest.org> X-Spam-Status: No, score=-3026.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Jan 08, 2024 at 10:51:46PM +0100, Mark Wielaard wrote: > Hi Alan, > > On Mon, Jan 08, 2024 at 10:54:09AM +1030, Alan Modra wrote: > > On Sun, Jan 07, 2024 at 06:29:36PM +0100, Mark Wielaard wrote: > > > So the autogen tester would like to move these entries back to where > > > they were before. > > > > So why are the aclocal.m4 dependencies being sorted differently? It > > seems to me that what is currently in libcollector/aclocal.m4: > > > > m4_include([../../config/depstand.m4]) > > m4_include([../../config/lead-dot.m4]) > > m4_include([../../config/override.m4]) > > m4_include([../../config/warnings.m4]) > > m4_include([../../libtool.m4]) > > m4_include([../../ltoptions.m4]) > > m4_include([../../ltsugar.m4]) > > m4_include([../../ltversion.m4]) > > m4_include([../../lt~obsolete.m4]) > > > > is sorted correctly. This is the result I get by configuring with > > --enable-maintainer-mode, and until I see others getting a different > > result with --enable-maintainer-mode and the "correct" versions of > > auto tools, I'm going to say the tester is doing something wrong. > > You are right. There is a difference between what > --enable-maintainer-mode does and what autoregen.py does. > autoregen.py doesn't fully handle the (order of directories) of > AC_CONFIG_MACRO_DIRS in gprofng/libcollector/configure.ac. Yes, I squinted at that one a little after I posted my previous email, and found that swapping the order of AC_CONFIG_MACRO_DIRS args didn't help.. > We can make this the same by using the following hack in autoregen.py Thanks for fixing this. -- Alan Modra Australia Development Lab, IBM