public inbox for gdb-testers@sourceware.org help / color / mirror / Atom feed
From: sergiodj+buildbot@redhat.com To: gdb-testers@sourceware.org Subject: [binutils-gdb/gdb-7.10-branch] gdbserver: move_out_of_jump_pad_callback misses switching current thread Date: Thu, 06 Aug 2015 16:01:00 -0000 [thread overview] Message-ID: <a01c46276aa3a16c2ac1dae249df14e39d1c281f@gdb-build> (raw) *** TEST RESULTS FOR COMMIT a01c46276aa3a16c2ac1dae249df14e39d1c281f *** Author: Pedro Alves <palves@redhat.com> Branch: gdb-7.10-branch Commit: a01c46276aa3a16c2ac1dae249df14e39d1c281f gdbserver: move_out_of_jump_pad_callback misses switching current thread While hacking on the fix for PR threads/18600 (Threads left stopped after fork+thread spawn), I once saw its test (fork-plus-threads.exp) FAIL against gdbserver because move_out_of_jump_pad_callback has a gdb_breakpoint_here call, and the caller isn't making sure the current thread points to the right thread. In the case I saw, the current thread pointed to the wrong process, so gdb_breakpoint_here returned the wrong answer. Unfortunately I didn't save logs. Still, seems obvious enough and it should fix a potential occasional racy FAIL. Tested on x86_64 Fedora 20. gdb/gdbserver/ChangeLog: 2015-08-06 Pedro Alves <palves@redhat.com> * linux-low.c (move_out_of_jump_pad_callback): Temporarily switch the current thread.
next reply other threads:[~2015-08-06 16:01 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-08-06 16:01 sergiodj+buildbot [this message] 2015-08-06 16:01 ` Failures on AIX-POWER7-plain, branch gdb-7.10-branch sergiodj+buildbot 2015-08-06 16:40 ` Failures on Fedora-x86_64-m32, " sergiodj+buildbot 2015-08-06 16:41 ` Failures on Fedora-i686, " sergiodj+buildbot 2015-08-06 16:51 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " sergiodj+buildbot 2015-08-06 16:54 ` Failures on Fedora-x86_64-native-gdbserver-m64, " sergiodj+buildbot 2015-08-06 17:04 ` Failures on Debian-s390x-native-gdbserver-m64, " sergiodj+buildbot 2015-08-06 17:06 ` Failures on Fedora-x86_64-m64, " sergiodj+buildbot 2015-08-06 17:07 ` Failures on Fedora-x86_64-native-gdbserver-m32, " sergiodj+buildbot 2015-08-06 17:27 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " sergiodj+buildbot 2015-08-06 17:29 ` Failures on Debian-s390x-native-extended-gdbserver-m64, " sergiodj+buildbot 2015-08-07 4:28 ` Failures on Fedora-ppc64be-cc-with-index, " sergiodj+buildbot 2015-08-07 4:48 ` Failures on Fedora-ppc64be-m64, " sergiodj+buildbot 2015-08-07 5:04 ` Failures on Fedora-ppc64be-native-gdbserver-m64, " sergiodj+buildbot 2015-08-07 5:25 ` Failures on Fedora-ppc64be-native-extended-gdbserver-m64, " sergiodj+buildbot 2015-08-07 9:13 ` Failures on Fedora-ppc64le-native-extended-gdbserver-m64, " sergiodj+buildbot 2015-08-07 10:55 ` Failures on Debian-x86_64-m64, " sergiodj+buildbot 2015-08-07 14:57 ` Failures on Debian-i686, " sergiodj+buildbot 2015-08-07 15:23 ` Failures on Debian-i686-native-gdbserver, " sergiodj+buildbot 2015-08-07 15:58 ` Failures on Debian-i686-native-extended-gdbserver, " sergiodj+buildbot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a01c46276aa3a16c2ac1dae249df14e39d1c281f@gdb-build \ --to=sergiodj+buildbot@redhat.com \ --cc=gdb-testers@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).