public inbox for gdb-testers@sourceware.org help / color / mirror / Atom feed
From: gdb-buildbot@sergiodj.net To: gdb-testers@sourceware.org Subject: [binutils-gdb] Propagate endianity to subrange types Date: Wed, 04 Dec 2019 20:05:00 -0000 [thread overview] Message-ID: <a05cf17ab92357449ed62fa0d1bac7389ee2de09@gdb-build> (raw) *** TEST RESULTS FOR COMMIT a05cf17ab92357449ed62fa0d1bac7389ee2de09 *** commit a05cf17ab92357449ed62fa0d1bac7389ee2de09 Author: Tom Tromey <tromey@adacore.com> AuthorDate: Mon Nov 25 13:04:52 2019 -0700 Commit: Tom Tromey <tromey@adacore.com> CommitDate: Wed Dec 4 09:31:18 2019 -0700 Propagate endianity to subrange types A subrange type should inherit its endianity from its base type. gdb/ChangeLog 2019-12-04 Tom Tromey <tromey@adacore.com> * gdbtypes.c (create_range_type): Inherit endianity from base type. gdb/testsuite/ChangeLog 2019-12-04 Tom Tromey <tromey@adacore.com> * gdb.ada/scalar_storage/storage.adb: New file. * gdb.ada/scalar_storage/pck.adb: New file. * gdb.ada/scalar_storage/pck.ads: New file. * gdb.ada/scalar_storage.exp: New file. Change-Id: I2998ab919dc28aeff097763c4242f9bfb90823a3 diff --git a/gdb/ChangeLog b/gdb/ChangeLog index e09a5887d1..f06f73903a 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2019-12-04 Tom Tromey <tromey@adacore.com> + + * gdbtypes.c (create_range_type): Inherit endianity + from base type. + 2019-12-04 Tom Tromey <tromey@adacore.com> * ada-lang.c (decode_constrained_packed_array) diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c index 737ebfecc5..775e8c18f9 100644 --- a/gdb/gdbtypes.c +++ b/gdb/gdbtypes.c @@ -949,6 +949,9 @@ create_range_type (struct type *result_type, struct type *index_type, if (high_bound->kind == PROP_CONST && high_bound->data.const_val < 0) TYPE_UNSIGNED (result_type) = 0; + TYPE_ENDIANITY_NOT_DEFAULT (result_type) + = TYPE_ENDIANITY_NOT_DEFAULT (index_type); + return result_type; } diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 1c8aa8633e..3ba369245c 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,10 @@ +2019-12-04 Tom Tromey <tromey@adacore.com> + + * gdb.ada/scalar_storage/storage.adb: New file. + * gdb.ada/scalar_storage/pck.adb: New file. + * gdb.ada/scalar_storage/pck.ads: New file. + * gdb.ada/scalar_storage.exp: New file. + 2019-12-04 Tom Tromey <tromey@adacore.com> * gdb.base/endianity.c (struct otherendian) <f>: New field. diff --git a/gdb/testsuite/gdb.ada/scalar_storage.exp b/gdb/testsuite/gdb.ada/scalar_storage.exp new file mode 100644 index 0000000000..92ad4edf99 --- /dev/null +++ b/gdb/testsuite/gdb.ada/scalar_storage.exp @@ -0,0 +1,36 @@ +# Copyright 2019 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +# Test that range types with scalar storage order are handled +# properly. + +load_lib "ada.exp" + +standard_ada_testfile storage + +if {[gdb_compile_ada "${srcfile}" "${binfile}" executable [list debug ]] != "" } { + return -1 +} + +clean_restart ${testfile} + +set bp_location [gdb_get_line_number "START" ${testdir}/storage.adb] +if ![runto "storage.adb:$bp_location" ] then { + perror "Couldn't run ${testfile}" + return +} + +gdb_test "print V_LE" "= \\(value => 126\\)" +gdb_test "print V_BE" "= \\(value => 126\\)" diff --git a/gdb/testsuite/gdb.ada/scalar_storage/pck.adb b/gdb/testsuite/gdb.ada/scalar_storage/pck.adb new file mode 100644 index 0000000000..6535991a19 --- /dev/null +++ b/gdb/testsuite/gdb.ada/scalar_storage/pck.adb @@ -0,0 +1,21 @@ +-- Copyright 2019 Free Software Foundation, Inc. +-- +-- This program is free software; you can redistribute it and/or modify +-- it under the terms of the GNU General Public License as published by +-- the Free Software Foundation; either version 3 of the License, or +-- (at your option) any later version. +-- +-- This program is distributed in the hope that it will be useful, +-- but WITHOUT ANY WARRANTY; without even the implied warranty of +-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +-- GNU General Public License for more details. +-- +-- You should have received a copy of the GNU General Public License +-- along with this program. If not, see <http://www.gnu.org/licenses/>. + +package body Pck is + procedure Do_Nothing (A : System.Address) is + begin + null; + end Do_Nothing; +end Pck; diff --git a/gdb/testsuite/gdb.ada/scalar_storage/pck.ads b/gdb/testsuite/gdb.ada/scalar_storage/pck.ads new file mode 100644 index 0000000000..b8d0010175 --- /dev/null +++ b/gdb/testsuite/gdb.ada/scalar_storage/pck.ads @@ -0,0 +1,19 @@ +-- Copyright 2019 Free Software Foundation, Inc. +-- +-- This program is free software; you can redistribute it and/or modify +-- it under the terms of the GNU General Public License as published by +-- the Free Software Foundation; either version 3 of the License, or +-- (at your option) any later version. +-- +-- This program is distributed in the hope that it will be useful, +-- but WITHOUT ANY WARRANTY; without even the implied warranty of +-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +-- GNU General Public License for more details. +-- +-- You should have received a copy of the GNU General Public License +-- along with this program. If not, see <http://www.gnu.org/licenses/>. + +with System; +package Pck is + procedure Do_Nothing (A : System.Address); +end Pck; diff --git a/gdb/testsuite/gdb.ada/scalar_storage/storage.adb b/gdb/testsuite/gdb.ada/scalar_storage/storage.adb new file mode 100644 index 0000000000..abc1a83860 --- /dev/null +++ b/gdb/testsuite/gdb.ada/scalar_storage/storage.adb @@ -0,0 +1,47 @@ +-- Copyright 2019 Free Software Foundation, Inc. +-- +-- This program is free software; you can redistribute it and/or modify +-- it under the terms of the GNU General Public License as published by +-- the Free Software Foundation; either version 3 of the License, or +-- (at your option) any later version. +-- +-- This program is distributed in the hope that it will be useful, +-- but WITHOUT ANY WARRANTY; without even the implied warranty of +-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +-- GNU General Public License for more details. +-- +-- You should have received a copy of the GNU General Public License +-- along with this program. If not, see <http://www.gnu.org/licenses/>. + +with Pck; use Pck; +with System.Storage_Elements; use System.Storage_Elements; + +procedure Storage is + subtype Some_Range is Natural range 0..127; + + type Rec is record + Value : Some_Range; + end record; + + for Rec use record + Value at 0 range 0..127; + end record; + + type Rec_LE is new Rec; + for Rec_LE'Bit_Order use System.Low_Order_First; + for Rec_LE'Scalar_Storage_Order use System.Low_Order_First; + + type Rec_BE is new Rec; + for Rec_BE'Bit_Order use System.High_Order_First; + for Rec_BE'Scalar_Storage_Order use System.High_Order_First; + + V_LE : Rec_LE; + V_BE : Rec_BE; + +begin + V_LE.Value := 126; + V_BE.Value := 126; + + Do_Nothing (V_LE'Address); -- START + Do_Nothing (V_BE'Address); +end Storage;
next reply other threads:[~2019-12-04 19:53 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-04 20:05 gdb-buildbot [this message] 2019-12-04 19:53 ` Failures on Ubuntu-Aarch64-native-gdbserver-m64, branch master gdb-buildbot 2019-12-04 23:47 ` Failures on Fedora-i686, " gdb-buildbot 2019-12-04 23:51 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot 2019-12-04 23:55 ` Failures on Fedora-x86_64-m32, " gdb-buildbot 2019-12-05 0:02 ` Failures on Fedora-x86_64-m64, " gdb-buildbot 2019-12-05 0:38 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a05cf17ab92357449ed62fa0d1bac7389ee2de09@gdb-build \ --to=gdb-buildbot@sergiodj.net \ --cc=gdb-testers@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).