public inbox for gdb-testers@sourceware.org help / color / mirror / Atom feed
From: gdb-buildbot@sergiodj.net To: gdb-testers@sourceware.org Subject: [binutils-gdb] Don't call erase_data_content from tui_data_window::show_registers Date: Wed, 16 Oct 2019 17:19:00 -0000 [thread overview] Message-ID: <a31bff9d2d78d0d45e3e75dd2513ccbf480a7bc4@gdb-build> (raw) *** TEST RESULTS FOR COMMIT a31bff9d2d78d0d45e3e75dd2513ccbf480a7bc4 *** commit a31bff9d2d78d0d45e3e75dd2513ccbf480a7bc4 Author: Tom Tromey <tom@tromey.com> AuthorDate: Tue Oct 1 17:42:17 2019 -0600 Commit: Tom Tromey <tom@tromey.com> CommitDate: Wed Oct 9 16:50:36 2019 -0600 Don't call erase_data_content from tui_data_window::show_registers tui_data_window::show_registers currently calls erase_data_content. However, I think it's better to have fewer calls to this (ideally just one would suffice). This refactors that function to remove this call. gdb/ChangeLog 2019-10-09 Tom Tromey <tom@tromey.com> * tui/tui-regs.c (tui_data_window::show_registers): Don't call erase_data_content. diff --git a/gdb/ChangeLog b/gdb/ChangeLog index bca7b7b4ff..a5504a9c00 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2019-10-09 Tom Tromey <tom@tromey.com> + + * tui/tui-regs.c (tui_data_window::show_registers): Don't call + erase_data_content. + 2019-10-09 Tom Tromey <tom@tromey.com> * tui/tui-wingeneral.h (tui_delete_win): Don't declare. diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c index 474b62e204..1d936f712b 100644 --- a/gdb/tui/tui-regs.c +++ b/gdb/tui/tui-regs.c @@ -154,13 +154,14 @@ tui_data_window::show_registers (struct reggroup *group) for (auto &&data_item_win : m_regs_content) data_item_win.highlight = false; m_current_group = group; - rerender (); } else { m_current_group = 0; - erase_data_content (_("[ Register Values Unavailable ]")); + m_regs_content.clear (); } + + rerender (); }
next reply other threads:[~2019-10-16 17:19 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-16 17:19 gdb-buildbot [this message] 2019-10-16 17:19 ` Failures on Ubuntu-Aarch64-m64, branch master gdb-buildbot 2019-10-16 18:50 ` Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, " gdb-buildbot 2019-10-16 19:39 ` Failures on Ubuntu-Aarch64-native-gdbserver-m64, " gdb-buildbot 2019-10-23 4:29 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a31bff9d2d78d0d45e3e75dd2513ccbf480a7bc4@gdb-build \ --to=gdb-buildbot@sergiodj.net \ --cc=gdb-testers@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).