[binutils-gdb] Consolidate x86 debug register code for BSD native targets.

[binutils-gdb] Consolidate x86 debug register code for BSD native targets.

[sergiodj+buildbot]

*** TEST RESULTS FOR COMMIT a3405d124e1388b613a35af49f19f0cc1b8d959d ***

Author: John Baldwin <jhb@FreeBSD.org>
Branch: master
Commit: a3405d124e1388b613a35af49f19f0cc1b8d959d

Consolidate x86 debug register code for BSD native targets.

Move the debug register support code from amd64bsd-nat.c and
i386bsd-nat.c into a shared x86bsd-nat.c.

Instead of setting up x86_dr_low in amd64fbsd-nat.c and
i386fbsd-nat.c, add a x86bsd_target function that creates a new target
that inherits from inf_ptrace and sets up x86 debug registers if
supported.  In addition to initializing x86_dr_low, the x86bsd target
installs a custom mourn_inferior target operation to clean up the
x86 debug register state.  Previously this was only done on amd64.
Now it will be done for both i386 and amd64.  The i386bsd_target and
amd64bsd_target functions create targets that inherit from x86bsd
rather than inf_ptrace.

gdb/ChangeLog:

	* Makefile.in [HFILES_NO_SRCDIR]: Replace 'amd64bsd-nat.h' with
	'x86bsd-nat.h'.
	* amd64bsd-nat.c: Include 'x86bsd-nat.h' instead of
	'amd64bsd-nat.h'.
	(amd64bsd_xsave_len): Rename and move to x86bsd-nat.c.
	(amd64bsd_fetch_inferior_registers): Replace 'amd64bsd_xsave_len'
	with 'x86bsd_xsave_len'.
	(amd64bsd_store_inferior_registers): Likewise.
	(amd64bsd_target): Inherit from x86bsd_target.
	(amd64bsd_dr_get): Rename and move to x86bsd-nat.c.
	(amd64bsd_dr_set): Likewise.
	(amd64bsd_dr_set_control): Likewise.
	(amd64bsd_dr_set_addr): Likewise.
	(amd64bsd_dr_get_addr): Likewise.
	(amd64bsd_dr_get_status): Likewise.
	(amd64bsd_dr_get_control): Likewise.
	* amd64fbsd-nat.c: Include 'x86bsd-nat.h' instead of
	'amd64bsd-nat.h'.
	(super_mourn_inferior): Move to x86bsd-nat.c.
	(amd64fbsd_mourn_inferior): Rename and move to x86bsd-nat.c.
	(amd64fbsd_read_description): Replace 'amd64bsd_xsave_len' with
	'x86bsd_xsave_len'.
	(_initialize_amd64fbsd_nat): Remove x86 watchpoint setup and
	mourn_inferior' target op.
	* config/i386/fbsd.mh (NATDEPFILES): Add x86bsd-nat.o.
	* config/i386/fbsd64.mh: Likewise.
	* config/i386/nbsd64.mh: Likewise.
	* config/i386/nbsdelf.mh: Likewise.
	* config/i386/obsd.mh: Likewise.
	* config/i386/obsd64.mh: Likewise.
	* i386bsd-nat.c: Include 'x86bsd-nat.h'.
	(i386bsd_xsave_len): Rename and move to x86bsd-nat.c.
	(i386bsd_fetch_inferior_registers): Replace 'i386bsd_xsave_len'
	with 'x86bsd_xsave_len'.
	(i386bsd_store_inferior_registers): Likewise.
	(i386bsd_target): Inherit from x86bsd_target.
	(i386bsd_dr_get): Rename and move to x86bsd-nat.c.
	(i386bsd_dr_set): Likewise.
	(i386bsd_dr_set_control): Likewise.
	(i386bsd_dr_set_addr): Likewise.
	(i386bsd_dr_get_addr): Likewise.
	(i386bsd_dr_get_status): Likewise.
	(i386bsd_dr_get_control): Likewise.
	* i386bsd-nat.h (i386bsd_xsave_len): Remove.
	(i386bsd_dr_set_control): Remove.
	(i386bsd_dr_set_addr): Remove.
	(i386bsd_dr_get_addr): Remove.
	(i386bsd_dr_get_status): Remove.
	(i386bsd_dr_get_control): Remove.
	* i386fbsd-nat.c: Include 'x86bsd-nat.h'.
	(i386fbsd_read_description): Replace 'i386bsd_xsave_len' with
	'x86bsd_xsave_len'.
	(_initialize_i386fbsd_nat): Remove x86 watchpoint setup and
	mourn_inferior' target op.
	* x86bsd-nat.c: New file.
	* x86bsd-nat.h: New file.

Failures on Fedora-ppc64be-cc-with-index, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-ppc64be-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-ppc64be-cc-with-index/builds/3822>

Commit(s) tested:
	a3405d124e1388b613a35af49f19f0cc1b8d959d

Author(s) (in the same order as the commits):
	John Baldwin <jhb@FreeBSD.org>

Subject:
	Consolidate x86 debug register code for BSD native targets.

Testsuite log (gdb.sum and gdb.log) URL(s):
	<Error fetching commit ID for a3405d124e1388b613a35af49f19f0cc1b8d959d>

Failures on Fedora-ppc64be-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-ppc64be-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-ppc64be-m64/builds/3825>

Commit(s) tested:
	a3405d124e1388b613a35af49f19f0cc1b8d959d

Author(s) (in the same order as the commits):
	John Baldwin <jhb@FreeBSD.org>

Subject:
	Consolidate x86 debug register code for BSD native targets.

Testsuite log (gdb.sum and gdb.log) URL(s):
	<Error fetching commit ID for a3405d124e1388b613a35af49f19f0cc1b8d959d>

Failures on Debian-i686, branch master

[sergiodj+buildbot]

Buildslave:
	wildebeest-debian-wheezy-i686

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Debian-i686/builds/3782>

Commit(s) tested:
	a3405d124e1388b613a35af49f19f0cc1b8d959d

Author(s) (in the same order as the commits):
	John Baldwin <jhb@FreeBSD.org>

Subject:
	Consolidate x86 debug register code for BSD native targets.

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/cgit/Debian-i686/.git/tree/?h=master&id=27c666e456e897c1ed64cc4a36772c84f7e3779e>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: signal thr1: setup: continue to breakpoint: run to breakpoint in thread 2
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: signal thr1: setup: unbreak loop in thread 2
PASS -> FAIL: gdb.threads/signal-while-stepping-over-bp-other-thread.exp: step
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Debian-i686/xfails/master/xfail;hb=b49a91b>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Debian-i686/xfails/master/xfail.table;hb=b49a91b>

Failures on Fedora-ppc64be-native-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-ppc64be-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-ppc64be-native-gdbserver-m64/builds/3819>

Commit(s) tested:
	a3405d124e1388b613a35af49f19f0cc1b8d959d

Author(s) (in the same order as the commits):
	John Baldwin <jhb@FreeBSD.org>

Subject:
	Consolidate x86 debug register code for BSD native targets.

Testsuite log (gdb.sum and gdb.log) URL(s):
	<Error fetching commit ID for a3405d124e1388b613a35af49f19f0cc1b8d959d>

Failures on Fedora-x86_64-native-gdbserver-m32, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-3

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-gdbserver-m32/builds/3891>

Commit(s) tested:
	a3405d124e1388b613a35af49f19f0cc1b8d959d

Author(s) (in the same order as the commits):
	John Baldwin <jhb@FreeBSD.org>

Subject:
	Consolidate x86 debug register code for BSD native targets.

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/cgit/Fedora-x86_64-native-gdbserver-m32/.git/tree/?h=master&id=180f37c47b3aace3721cfdd4c191a3983055f375>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.ada/array_ptr_renaming.exp: print nt
PASS -> FAIL: gdb.ada/array_ptr_renaming.exp: print ntp
PASS -> FAIL: gdb.ada/array_ptr_renaming.exp: print ntp.all
new FAIL: gdb.ada/mi_catch_ex.exp: Cannot run to main, testcase aborted
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-gdbserver-m32/xfails/master/xfail;hb=afde56f>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-gdbserver-m32/xfails/master/xfail.table;hb=afde56f>

Failures on Fedora-ppc64be-native-extended-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-ppc64be-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-ppc64be-native-extended-gdbserver-m64/builds/3827>

Commit(s) tested:
	a3405d124e1388b613a35af49f19f0cc1b8d959d

Author(s) (in the same order as the commits):
	John Baldwin <jhb@FreeBSD.org>

Subject:
	Consolidate x86 debug register code for BSD native targets.

Testsuite log (gdb.sum and gdb.log) URL(s):
	<Error fetching commit ID for a3405d124e1388b613a35af49f19f0cc1b8d959d>

Failures on Debian-i686-native-extended-gdbserver, branch master

[sergiodj+buildbot]

Buildslave:
	wildebeest-debian-wheezy-i686

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Debian-i686-native-extended-gdbserver/builds/3764>

Commit(s) tested:
	a3405d124e1388b613a35af49f19f0cc1b8d959d

Author(s) (in the same order as the commits):
	John Baldwin <jhb@FreeBSD.org>

Subject:
	Consolidate x86 debug register code for BSD native targets.

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/cgit/Debian-i686-native-extended-gdbserver/.git/tree/?h=master&id=36a1b25ff567d5ad5e34a5d847799eee2663abfc>

*** Diff to previous build ***
============================
new FAIL: gdb.threads/attach-into-signal.exp: threaded: process is still running on the attempt # 1 of 100
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Debian-i686-native-extended-gdbserver/xfails/master/xfail;hb=b49a91b>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Debian-i686-native-extended-gdbserver/xfails/master/xfail.table;hb=b49a91b>

Failures on Fedora-ppc64le-native-extended-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-ppc64le-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-ppc64le-native-extended-gdbserver-m64/builds/3760>

Commit(s) tested:
	a3405d124e1388b613a35af49f19f0cc1b8d959d

Author(s) (in the same order as the commits):
	John Baldwin <jhb@FreeBSD.org>

Subject:
	Consolidate x86 debug register code for BSD native targets.

Testsuite log (gdb.sum and gdb.log) URL(s):
	<Error fetching commit ID for a3405d124e1388b613a35af49f19f0cc1b8d959d>

Failures on Fedora-ppc64le-cc-with-index, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-ppc64le-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-ppc64le-cc-with-index/builds/3738>

Commit(s) tested:
	a3405d124e1388b613a35af49f19f0cc1b8d959d

Author(s) (in the same order as the commits):
	John Baldwin <jhb@FreeBSD.org>

Subject:
	Consolidate x86 debug register code for BSD native targets.

Testsuite log (gdb.sum and gdb.log) URL(s):
	<Error fetching commit ID for a3405d124e1388b613a35af49f19f0cc1b8d959d>

Failures on Fedora-ppc64le-native-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-ppc64le-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-ppc64le-native-gdbserver-m64/builds/3748>

Commit(s) tested:
	a3405d124e1388b613a35af49f19f0cc1b8d959d

Author(s) (in the same order as the commits):
	John Baldwin <jhb@FreeBSD.org>

Subject:
	Consolidate x86 debug register code for BSD native targets.

Testsuite log (gdb.sum and gdb.log) URL(s):
	<Error fetching commit ID for a3405d124e1388b613a35af49f19f0cc1b8d959d>

Failures on Fedora-ppc64le-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-ppc64le-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-ppc64le-m64/builds/3739>

Commit(s) tested:
	a3405d124e1388b613a35af49f19f0cc1b8d959d

Author(s) (in the same order as the commits):
	John Baldwin <jhb@FreeBSD.org>

Subject:
	Consolidate x86 debug register code for BSD native targets.

Testsuite log (gdb.sum and gdb.log) URL(s):
	<Error fetching commit ID for a3405d124e1388b613a35af49f19f0cc1b8d959d>

Failures on Ubuntu-AArch64-native-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	ubuntu-aarch64-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch64-native-gdbserver-m64/builds/131>

Commit(s) tested:
	a3405d124e1388b613a35af49f19f0cc1b8d959d

Author(s) (in the same order as the commits):
	John Baldwin <jhb@FreeBSD.org>

Subject:
	Consolidate x86 debug register code for BSD native targets.

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/cgit/Ubuntu-AArch64-native-gdbserver-m64/.git/tree/?h=master&id=cf55d39deae0e542ec652cc6a47e4255df826486>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.base/info-os.exp: get process list
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch64-native-gdbserver-m64/xfails/master/xfail;hb=>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch64-native-gdbserver-m64/xfails/master/xfail.table;hb=>