[binutils-gdb] gdb: Move defs.h before any system header in debuginfod-support.c

[binutils-gdb] gdb: Move defs.h before any system header in debuginfod-support.c

[gdb-buildbot]

*** TEST RESULTS FOR COMMIT a84bb2a0790125f5fb5df65b7873fb6076164527 ***

commit a84bb2a0790125f5fb5df65b7873fb6076164527
Author:     Jon Turney <jon.turney@dronecode.org.uk>
AuthorDate: Sat Feb 29 13:33:35 2020 +0000
Commit:     Jon Turney <jon.turney@dronecode.org.uk>
CommitDate: Mon Mar 2 12:59:44 2020 +0000

    gdb: Move defs.h before any system header in debuginfod-support.c
    
    * defs.h includes config.h
    * config.h may define _GNU_SOURCE
    * if _GNU_SOURCE is defined, that must be before including any system
    header (see feature_test_macro(7))
    
    This is necessary to ensure that a prototype for mkostemp() is brought
    into scope by <stdlib.h> when compiling filestuff.h, on platforms where
    _GNU_SOURCE isn't unconditionally defined for C++.
    
    In file included from ../../gdb/../gdbsupport/scoped_fd.h:24,
                     from ../../gdb/debuginfod-support.c:22:
    ../../gdb/../gdbsupport/filestuff.h: In function int gdb_mkostemp_cloexec(char*, int):
    ../../gdb/../gdbsupport/filestuff.h:59:10: error: mkostemp was not declared in this scope; did you mean mkstemp?
    
    gdb/ChangeLog:
    
    2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
    
            * debuginfod-support.c: Include defs.h first.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 5f49542fb8..591ef40286 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
+
+	* debuginfod-support.c: Include defs.h first.
+
 2020-02-28  Tom de Vries  <tdevries@suse.de>
 
 	* symfile.c (set_initial_language): Use default language for lookup.
diff --git a/gdb/debuginfod-support.c b/gdb/debuginfod-support.c
index e0f0fac076..f4a227b040 100644
--- a/gdb/debuginfod-support.c
+++ b/gdb/debuginfod-support.c
@@ -16,8 +16,8 @@
    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
-#include <errno.h>
 #include "defs.h"
+#include <errno.h>
 #include "cli/cli-style.h"
 #include "gdbsupport/scoped_fd.h"
 #include "debuginfod-support.h"

Failures on Fedora-i686, branch master

[gdb-buildbot]

Buildername:
        Fedora-i686

Worker:
        fedora-x86-64-4

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/18/builds/2355

Author:
        Jon Turney <jon.turney@dronecode.org.uk>

Commit tested:
        a84bb2a0790125f5fb5df65b7873fb6076164527

Subject of commit:
        gdb: Move defs.h before any system header in debuginfod-support.c

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-i686/a8/a84bb2a0790125f5fb5df65b7873fb6076164527/

*** Diff to previous build ***
==============================================
new FAIL: gdb.base/catch-syscall.exp: multiple targets: insert catch syscall on syscall 1 -- write on i386:x86-64
new FAIL: gdb.server/server-kill-python.exp: ensure inferior is running
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
new KFAIL: gdb.xml/tdesc-arch.exp: crlf: set tdesc filename tdesc-arch.xml
new KFAIL: gdb.xml/tdesc-arch.exp: set tdesc filename tdesc-arch.xml
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/a8/a84bb2a0790125f5fb5df65b7873fb6076164527//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/a8/a84bb2a0790125f5fb5df65b7873fb6076164527//xfail.table.gz>

Failures on Fedora-x86_64-cc-with-index, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-cc-with-index

Worker:
        fedora-x86-64-1

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/20/builds/2302

Author:
        Jon Turney <jon.turney@dronecode.org.uk>

Commit tested:
        a84bb2a0790125f5fb5df65b7873fb6076164527

Subject of commit:
        gdb: Move defs.h before any system header in debuginfod-support.c

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/a8/a84bb2a0790125f5fb5df65b7873fb6076164527/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.base/gdb-caching-proc.exp: gdb_target_symbol_prefix consistency
PASS -> FAIL: gdb.base/gdb-caching-proc.exp: support_nested_function_tests consistency
PASS -> UNRESOLVED: gdb.base/reread.exp: opts= "" "" : second pass: breakpoint foo in first file
PASS -> UNRESOLVED: gdb.base/reread.exp: opts= "-fPIE" "ldflags=-pie" : second pass: breakpoint foo in first file
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 1st thread: print k
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 1st thread: print r
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 1st thread: print z
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 1st thread: print k
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 1st thread: print r
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 1st thread: print z
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/a8/a84bb2a0790125f5fb5df65b7873fb6076164527//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/a8/a84bb2a0790125f5fb5df65b7873fb6076164527//xfail.table.gz>

Failures on Fedora-x86_64-m32, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-m32

Worker:
        fedora-x86-64-4

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/17/builds/2351

Author:
        Jon Turney <jon.turney@dronecode.org.uk>

Commit tested:
        a84bb2a0790125f5fb5df65b7873fb6076164527

Subject of commit:
        gdb: Move defs.h before any system header in debuginfod-support.c

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/a8/a84bb2a0790125f5fb5df65b7873fb6076164527/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/a8/a84bb2a0790125f5fb5df65b7873fb6076164527//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/a8/a84bb2a0790125f5fb5df65b7873fb6076164527//xfail.table.gz>

Failures on Fedora-x86_64-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-m64

Worker:
        fedora-x86-64-1

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/3/builds/2412

Author:
        Jon Turney <jon.turney@dronecode.org.uk>

Commit tested:
        a84bb2a0790125f5fb5df65b7873fb6076164527

Subject of commit:
        gdb: Move defs.h before any system header in debuginfod-support.c

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/a8/a84bb2a0790125f5fb5df65b7873fb6076164527/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.base/branch-to-self.exp: break-cond: side=host: continue to breakpoint: continue to break
PASS -> FAIL: gdb.base/branch-to-self.exp: break-cond: side=host: p counter
PASS -> UNRESOLVED: gdb.base/reread.exp: opts= "" "" : second pass: breakpoint foo in first file
PASS -> UNRESOLVED: gdb.base/reread.exp: opts= "-fPIE" "ldflags=-pie" : second pass: breakpoint foo in first file
PASS -> FAIL: gdb.base/reread.exp: opts= "-fPIE" "ldflags=-pie" : second pass: run to foo
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: first thread: print i02
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: first thread: print i12
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: first thread: print i22
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 1st thread: print k
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 1st thread: print r
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 1st thread: print z
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 4th stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 4th stop: print j
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: single_scope: second thread: print i3
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/a8/a84bb2a0790125f5fb5df65b7873fb6076164527//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/a8/a84bb2a0790125f5fb5df65b7873fb6076164527//xfail.table.gz>

Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-extended-gdbserver-m32

Worker:
        fedora-x86-64-4

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/4/builds/2248

Author:
        Jon Turney <jon.turney@dronecode.org.uk>

Commit tested:
        a84bb2a0790125f5fb5df65b7873fb6076164527

Subject of commit:
        gdb: Move defs.h before any system header in debuginfod-support.c

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/a8/a84bb2a0790125f5fb5df65b7873fb6076164527/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/a8/a84bb2a0790125f5fb5df65b7873fb6076164527//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/a8/a84bb2a0790125f5fb5df65b7873fb6076164527//xfail.table.gz>

Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-extended-gdbserver-m64

Worker:
        fedora-x86-64-1

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/2/builds/2248

Author:
        Jon Turney <jon.turney@dronecode.org.uk>

Commit tested:
        a84bb2a0790125f5fb5df65b7873fb6076164527

Subject of commit:
        gdb: Move defs.h before any system header in debuginfod-support.c

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/a8/a84bb2a0790125f5fb5df65b7873fb6076164527/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=2: continue until exit
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=2: print re_run_var_2
UNRESOLVED -> FAIL: gdb.threads/fork-plus-threads.exp: detach-on-fork=off: inferior 1 exited
new FAIL: gdb.threads/fork-plus-threads.exp: detach-on-fork=off: only inferior 1 left
PASS -> FAIL: gdb.threads/interrupted-hand-call.exp: continue until exit
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: single_scope: first thread: print i3
new KFAIL: gdb.threads/watchthreads2.exp: gdb can drop watchpoints in multithreaded app
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/a8/a84bb2a0790125f5fb5df65b7873fb6076164527//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/a8/a84bb2a0790125f5fb5df65b7873fb6076164527//xfail.table.gz>

Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Ubuntu-Aarch64-native-extended-gdbserver-m64

Worker:
        ubuntu-aarch64

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/5/builds/2132

Author:
        Jon Turney <jon.turney@dronecode.org.uk>

Commit tested:
        a84bb2a0790125f5fb5df65b7873fb6076164527

Subject of commit:
        gdb: Move defs.h before any system header in debuginfod-support.c

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/a8/a84bb2a0790125f5fb5df65b7873fb6076164527/

*** Diff to previous build ***
==============================================
PASS -> UNRESOLVED: gdb.threads/attach-into-signal.exp: threaded: attach
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/a8/a84bb2a0790125f5fb5df65b7873fb6076164527//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/a8/a84bb2a0790125f5fb5df65b7873fb6076164527//xfail.table.gz>

Failures on Ubuntu-Aarch64-native-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Ubuntu-Aarch64-native-gdbserver-m64

Worker:
        ubuntu-aarch64

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/19/builds/2164

Author:
        Jon Turney <jon.turney@dronecode.org.uk>

Commit tested:
        a84bb2a0790125f5fb5df65b7873fb6076164527

Subject of commit:
        gdb: Move defs.h before any system header in debuginfod-support.c

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-gdbserver-m64/a8/a84bb2a0790125f5fb5df65b7873fb6076164527/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.base/step-over-syscall.exp: detach-on-fork=off: follow-fork=parent: break cond on target : fork: pc after stepi matches insn addr after syscall
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-gdbserver-m64/a8/a84bb2a0790125f5fb5df65b7873fb6076164527//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-gdbserver-m64/a8/a84bb2a0790125f5fb5df65b7873fb6076164527//xfail.table.gz>

Failures on Fedora-x86_64-native-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-gdbserver-m64

Worker:
        fedora-x86-64-2

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/22/builds/2248

Author:
        Jon Turney <jon.turney@dronecode.org.uk>

Commit tested:
        a84bb2a0790125f5fb5df65b7873fb6076164527

Subject of commit:
        gdb: Move defs.h before any system header in debuginfod-support.c

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/a8/a84bb2a0790125f5fb5df65b7873fb6076164527/

*** Diff to previous build ***
==============================================
new FAIL: gdb.base/gdb-caching-proc.exp: set print elements unlimited
new FAIL: gdb.base/gdb-caching-proc.exp: show print elements
new FAIL: gdb.base/gdb-caching-proc.exp: show print repeats
PASS -> FAIL: gdb.threads/interrupted-hand-call.exp: continue until exit
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 1st stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 1st stop: print j
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: outer_threads: outer stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: outer_threads: outer stop: print j
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: single_scope: first thread: print i3
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
new KFAIL: gdb.threads/watchthreads2.exp: gdb can drop watchpoints in multithreaded app
PASS -> FAIL: gdb.trace/mi-tsv-changed.exp: create delete modify: tvariable $tvar3 modified
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/a8/a84bb2a0790125f5fb5df65b7873fb6076164527//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/a8/a84bb2a0790125f5fb5df65b7873fb6076164527//xfail.table.gz>

Failures on Fedora-x86_64-native-gdbserver-m32, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-gdbserver-m32

Worker:
        fedora-x86-64-3

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/24/builds/2249

Author:
        Jon Turney <jon.turney@dronecode.org.uk>

Commit tested:
        a84bb2a0790125f5fb5df65b7873fb6076164527

Subject of commit:
        gdb: Move defs.h before any system header in debuginfod-support.c

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/a8/a84bb2a0790125f5fb5df65b7873fb6076164527/

*** Diff to previous build ***
==============================================
new FAIL: gdb.base/gdb-caching-proc.exp: show print elements
PASS -> FAIL: gdb.threads/interrupted-hand-call.exp: continue until exit
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/a8/a84bb2a0790125f5fb5df65b7873fb6076164527//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/a8/a84bb2a0790125f5fb5df65b7873fb6076164527//xfail.table.gz>