public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] bfd/elf-properties: avoid shadowing a C library symbol
@ 2019-06-25 15:25 gdb-buildbot
  2019-06-25 15:08 ` Failures on Fedora-i686, branch master gdb-buildbot
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: gdb-buildbot @ 2019-06-25 15:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT ab9f654ca3f1222f63533aabfffc223ae1fc69dc ***

commit ab9f654ca3f1222f63533aabfffc223ae1fc69dc
Author:     Jan Beulich <jbeulich@novell.com>
AuthorDate: Tue Jun 25 12:01:50 2019 +0200
Commit:     Jan Beulich <jbeulich@suse.com>
CommitDate: Tue Jun 25 12:01:50 2019 +0200

    bfd/elf-properties: avoid shadowing a C library symbol
    
    With my (oldish) gcc/glibc combination I'm seeing
    
    .../bfd/elf-properties.c: In function elf_find_and_remove_property:
    .../bfd/elf-properties.c:244: error: declaration of remove shadows a global declaration
    /usr/include/stdio.h:157: error: shadowed declaration is here

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index d8cbef1bd1..0783242758 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2019-06-25  Jan Beulich  <jbeulich@suse.com>
+
+	* elf-properties.c (elf_find_and_remove_property): Rename last
+	parameter. Mention it in comment.
+
 2019-06-24  Ilia Diachkov  <ilia.diachkov@optimitech.com>
 
 	* elfnn-riscv.c (_bfd_riscv_relax_lui): Delete early exit when
diff --git a/bfd/elf-properties.c b/bfd/elf-properties.c
index a297c9c5c2..198eece084 100644
--- a/bfd/elf-properties.c
+++ b/bfd/elf-properties.c
@@ -236,12 +236,12 @@ elf_merge_gnu_properties (struct bfd_link_info *info, bfd *abfd, bfd *bbfd,
   return FALSE;
 }
 
-/* Return the property of TYPE on *LISTP and remove it from *LISTP.
-   Return NULL if not found.  */
+/* Return the property of TYPE on *LISTP and remove it from *LISTP if RM is
+   true.  Return NULL if not found.  */
 
 static elf_property *
 elf_find_and_remove_property (elf_property_list **listp,
-			      unsigned int type, bfd_boolean remove)
+			      unsigned int type, bfd_boolean rm)
 {
   elf_property_list *list;
 
@@ -250,7 +250,7 @@ elf_find_and_remove_property (elf_property_list **listp,
       if (type == list->property.pr_type)
 	{
 	  /* Remove this property.  */
-	  if (remove)
+	  if (rm)
 	    *listp = list->next;
 	  return &list->property;
 	}


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2019-07-09 17:08 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-25 15:25 [binutils-gdb] bfd/elf-properties: avoid shadowing a C library symbol gdb-buildbot
2019-06-25 15:08 ` Failures on Fedora-i686, branch master gdb-buildbot
2019-06-25 15:36 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot
2019-06-25 15:36 ` Failures on Fedora-x86_64-m32, " gdb-buildbot
2019-06-25 15:47 ` Failures on Fedora-x86_64-m64, " gdb-buildbot
2019-06-25 15:54 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
2019-06-25 15:55 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot
2019-06-25 16:00 ` Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot
2019-07-09 17:09 ` *** COMPILATION FAILED *** Failures on NetBSD-x86_64-m64, branch master *** BREAKAGE *** gdb-buildbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).