public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: sergiodj+buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] Fix unstable test names in gdb.python/py-objfile.exp
Date: Thu, 26 Oct 2017 16:13:00 -0000	[thread overview]
Message-ID: <ad9b8f5d022f777f32cceab9856f47a5b6afcce1@gdb-build> (raw)

*** TEST RESULTS FOR COMMIT ad9b8f5d022f777f32cceab9856f47a5b6afcce1 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: ad9b8f5d022f777f32cceab9856f47a5b6afcce1

Fix unstable test names in gdb.python/py-objfile.exp

Currently, if you diff testsuite/gdb.sum of different builds you see
this spurious hunk:

  -PASS: gdb.python/py-objfile.exp: get python valueof "sep_objfile.build_id" (6a0bfcab663f9810ccff33c756afdebb940037d4)
  +PASS: gdb.python/py-objfile.exp: get python valueof "sep_objfile.build_id" (1f5531c657c57777b05fc95baa0025fd1d115c3b)

Fix this by syncing get_python_valueof with get_integer_valueof, which
stopped outputting the value in commit 2f20e312aad6
("get_integer_valueof: Don't output value in test name").

After this commit we'll show:

  PASS: gdb.python/py-objfile.exp: get python valueof "sep_objfile.build_id"

As the comment explicitly says get_python_valueof is modeled on
get_integer_valueof, I went ahead and also added the optional 'test'
parameter while at it.

gdb/testsuite/ChangeLog:
2017-10-24  Pedro Alves  <palves@redhat.com>

	* lib/gdb-python.exp (get_python_valueof): Add 'test' optional
	parameter and handle it.  Don't output read value in test name.


             reply	other threads:[~2017-10-26 16:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-26 16:13 sergiodj+buildbot [this message]
2017-10-26 16:13 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, branch master sergiodj+buildbot
2017-10-26 20:32 ` Failures on Ubuntu-AArch32-m32, " sergiodj+buildbot
2017-10-26 20:42 ` Failures on Fedora-x86_64-native-gdbserver-m32, " sergiodj+buildbot
2017-10-26 20:56 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, " sergiodj+buildbot
2017-10-26 21:01 ` Failures on Fedora-x86_64-native-gdbserver-m64, " sergiodj+buildbot
2017-10-26 21:20 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, " sergiodj+buildbot
2017-10-26 21:41 ` Failures on Fedora-x86_64-m32, " sergiodj+buildbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad9b8f5d022f777f32cceab9856f47a5b6afcce1@gdb-build \
    --to=sergiodj+buildbot@sergiodj.net \
    --cc=gdb-testers@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).