From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-testers-return-93233-listarch-gdb-testers=sources.redhat.com@sourceware.org>
Received: (qmail 36010 invoked by alias); 26 Oct 2017 16:13:41 -0000
Mailing-List: contact gdb-testers-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-testers.sourceware.org>
List-Subscribe: <mailto:gdb-testers-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-testers/>
List-Post: <mailto:gdb-testers@sourceware.org>
List-Help: <mailto:gdb-testers-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-testers-owner@sourceware.org
Received: (qmail 35999 invoked by uid 89); 26 Oct 2017 16:13:40 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: kwanyin.sergiodj.net
Received: from kwanyin.sergiodj.net (HELO kwanyin.sergiodj.net) (158.69.185.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Oct 2017 16:13:39 +0000
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [binutils-gdb] Fix unstable test names in gdb.python/py-objfile.exp
From: sergiodj+buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Message-Id: <ad9b8f5d022f777f32cceab9856f47a5b6afcce1@gdb-build>
Date: Thu, 26 Oct 2017 16:13:00 -0000
X-SW-Source: 2017-q4/txt/msg02843.txt.bz2

*** TEST RESULTS FOR COMMIT ad9b8f5d022f777f32cceab9856f47a5b6afcce1 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: ad9b8f5d022f777f32cceab9856f47a5b6afcce1

Fix unstable test names in gdb.python/py-objfile.exp

Currently, if you diff testsuite/gdb.sum of different builds you see
this spurious hunk:

  -PASS: gdb.python/py-objfile.exp: get python valueof "sep_objfile.build_id" (6a0bfcab663f9810ccff33c756afdebb940037d4)
  +PASS: gdb.python/py-objfile.exp: get python valueof "sep_objfile.build_id" (1f5531c657c57777b05fc95baa0025fd1d115c3b)

Fix this by syncing get_python_valueof with get_integer_valueof, which
stopped outputting the value in commit 2f20e312aad6
("get_integer_valueof: Don't output value in test name").

After this commit we'll show:

  PASS: gdb.python/py-objfile.exp: get python valueof "sep_objfile.build_id"

As the comment explicitly says get_python_valueof is modeled on
get_integer_valueof, I went ahead and also added the optional 'test'
parameter while at it.

gdb/testsuite/ChangeLog:
2017-10-24  Pedro Alves  <palves@redhat.com>

	* lib/gdb-python.exp (get_python_valueof): Add 'test' optional
	parameter and handle it.  Don't output read value in test name.