[binutils-gdb] Replace psymbol_allocation_list with std::vector

[binutils-gdb] Replace psymbol_allocation_list with std::vector

[sergiodj+buildbot]

*** TEST RESULTS FOR COMMIT af5bf4ada48ff65b6658be1fab8f9c8f8ab5f319 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: af5bf4ada48ff65b6658be1fab8f9c8f8ab5f319

Replace psymbol_allocation_list with std::vector

psymbol_allocation_list is basically a vector implementation.  We can
replace it with an std::vector, now that objfile has been C++-ified.

I sent this to the buildbot, there are a few suspicious failures, but
I don't think they are related to this patch.  For example on powerpc:

new FAIL: gdb.base/catch-syscall.exp: execve: syscall execve has returned
new FAIL: gdb.base/catch-syscall.exp: execve: continue to main
new FAIL: gdb.base/catch-syscall.exp: execve: continue until exit

I get the same failures when testing manually on gcc112, without this
patch.

gdb/ChangeLog:

	* objfiles.h: Don't include symfile.h.
	(struct partial_symbol): Remove forward-declaration.
	(struct objfile) <global_psymbols, static_psymbols>: Change type
	to std::vector<partial_symbol *>.
	* objfiles.c (objfile::objfile): Don't memset those fields.
	(objfile::~objfile): Don't free those fields.
	* psympriv.h (struct psymbol_allocation_list): Remove
	forward-declaration.
	(add_psymbol_to_list): Change psymbol_allocation_list parameter
	to std::vector.
	(start_psymtab_common): Change parameters to std::vector.
	* psymtab.c: Include algorithm.
	(require_partial_symbols): Call shrink_to_fit.
	(find_pc_sect_psymbol): Adjust to vector change.
	(match_partial_symbol): Likewise.
	(lookup_partial_symbol): Likewise.
	(psym_relocate): Likewise.
	(dump_psymtab): Likewise.
	(recursively_search_psymtabs): Likewise.
	(compare_psymbols): Remove.
	(sort_pst_symbols): Adjust to vector change.
	(start_psymtab_common): Likewise.
	(end_psymtab_common): Likewise.
	(psymbol_bcache_full): De-constify return value.
	(add_psymbol_to_bcache): Likewise.
	(extend_psymbol_list): Remove.
	(append_psymbol_to_list): Adjust to vector change.
	(add_psymbol_to_list): Likewise.
	(init_psymbol_list): Likewise.
	(maintenance_info_psymtabs): Likewise.
	(maintenance_check_psymtabs): Likewise.
	* symfile.h (struct psymbol_allocation_list): Remove.
	* symfile.c (reread_symbols): Adjust to vector change.
	* dbxread.c (start_psymtab): Change type of parameters.
	(dbx_symfile_read): Adjust to vector change.
	(read_dbx_symtab): Likewise.
	(start_psymtab): Change type of parameters.
	* dwarf2read.c (dwarf2_build_psymtabs): Adjust to vector change.
	(create_partial_symtab): Likewise.
	(add_partial_symbol): Likewise.
	(write_one_signatured_type): Likewise.
	(recursively_write_psymbols): Likewise.
	* mdebugread.c (parse_partial_symbols): Likewise.
	* xcoffread.c (xcoff_start_psymtab): Change type of parameters.
	(scan_xcoff_symtab): Adjust to vector change.
	(xcoff_initial_scan): Likewise.

Failures on Fedora-s390x-m64, branch master

[sergiodj+buildbot]

Buildslave:
	marist-fedora-s390x

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-s390x-m64/builds/6655>

Commit(s) tested:
	af5bf4ada48ff65b6658be1fab8f9c8f8ab5f319

Author(s) (in the same order as the commits):
	Simon Marchi <simon.marchi@ericsson.com>

Subject:
	Replace psymbol_allocation_list with std::vector

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-s390x-m64/af/af5bf4ada48ff65b6658be1fab8f9c8f8ab5f319/>

*** Diff to previous build ***
============================
XFAIL -> FAIL: gdb.gdb/python-interrupts.exp: run until breakpoint at captured_command_loop
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-s390x-m64/xfails/master/xfail;hb=f504840>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-s390x-m64/xfails/master/xfail.table;hb=f504840>

Failures on Ubuntu-AArch64-native-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	ubuntu-aarch64-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch64-native-gdbserver-m64/builds/3178>

Commit(s) tested:
	af5bf4ada48ff65b6658be1fab8f9c8f8ab5f319

Author(s) (in the same order as the commits):
	Simon Marchi <simon.marchi@ericsson.com>

Subject:
	Replace psymbol_allocation_list with std::vector

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Ubuntu-AArch64-native-gdbserver-m64/af/af5bf4ada48ff65b6658be1fab8f9c8f8ab5f319/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch64-native-gdbserver-m64/xfails/master/xfail;hb=754eb9f>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch64-native-gdbserver-m64/xfails/master/xfail.table;hb=754eb9f>

Failures on Ubuntu-AArch32-m32, branch master

[sergiodj+buildbot]

Buildslave:
	ubuntu-trusty-aarch32-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-m32/builds/1792>

Commit(s) tested:
	af5bf4ada48ff65b6658be1fab8f9c8f8ab5f319

Author(s) (in the same order as the commits):
	Simon Marchi <simon.marchi@ericsson.com>

Subject:
	Replace psymbol_allocation_list with std::vector

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-m32/af/af5bf4ada48ff65b6658be1fab8f9c8f8ab5f319/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch32-m32/xfails/master/xfail;hb=>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch32-m32/xfails/master/xfail.table;hb=>

Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master

[sergiodj+buildbot]

Buildslave:
	ubuntu-trusty-aarch32-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-native-extended-gdbserver-m32/builds/1792>

Commit(s) tested:
	af5bf4ada48ff65b6658be1fab8f9c8f8ab5f319

Author(s) (in the same order as the commits):
	Simon Marchi <simon.marchi@ericsson.com>

Subject:
	Replace psymbol_allocation_list with std::vector

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-native-extended-gdbserver-m32/af/af5bf4ada48ff65b6658be1fab8f9c8f8ab5f319/>

*** Diff to previous build ***
============================
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=9: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=16: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=19: wait for stops
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=step: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=step: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=step: step to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=step: step does not change thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=step: current thread advanced - unlocked
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=0: continue to breakpoint: return to loop
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=0: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=0: print call_function = 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=0: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=0: next to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=0: other threads ran - unlocked
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: continue to breakpoint: return to loop
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: print call_function = 1
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: next to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: other threads ran - unlocked
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: continue to breakpoint: return to loop
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: print call_function = 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: step to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: continue to breakpoint: return to loop
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: print call_function = 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: next to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: continue to breakpoint: return to loop
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: print call_function = 1
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: next to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: continue to breakpoint: return to loop
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: print call_function = 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: step to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: continue to breakpoint: return to loop
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: print call_function = 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: listed args
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: next to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: continue to breakpoint: return to loop
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: set scheduler-locking on
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: print call_function = 1
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: next to increment
============================


*** Complete list of XFAILs for this builder ***

FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST.  PLEASE CONTACT THE BUILDBOT ADMIN.

Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master

[sergiodj+buildbot]

Buildslave:
	ubuntu-trusty-aarch32-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-native-gdbserver-m32/builds/1780>

Commit(s) tested:
	af5bf4ada48ff65b6658be1fab8f9c8f8ab5f319

Author(s) (in the same order as the commits):
	Simon Marchi <simon.marchi@ericsson.com>

Subject:
	Replace psymbol_allocation_list with std::vector

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-native-gdbserver-m32/af/af5bf4ada48ff65b6658be1fab8f9c8f8ab5f319/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch32-native-gdbserver-m32/xfails/master/xfail;hb=>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch32-native-gdbserver-m32/xfails/master/xfail.table;hb=>

Failures on Fedora-x86_64-cc-with-index, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-3

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-cc-with-index/builds/7573>

Commit(s) tested:
	af5bf4ada48ff65b6658be1fab8f9c8f8ab5f319

Author(s) (in the same order as the commits):
	Simon Marchi <simon.marchi@ericsson.com>

Subject:
	Replace psymbol_allocation_list with std::vector

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-cc-with-index/af/af5bf4ada48ff65b6658be1fab8f9c8f8ab5f319/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-cc-with-index/xfails/master/xfail;hb=71a02a0>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-cc-with-index/xfails/master/xfail.table;hb=71a02a0>

Failures on Fedora-x86_64-m32, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-3

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m32/builds/7617>

Commit(s) tested:
	af5bf4ada48ff65b6658be1fab8f9c8f8ab5f319

Author(s) (in the same order as the commits):
	Simon Marchi <simon.marchi@ericsson.com>

Subject:
	Replace psymbol_allocation_list with std::vector

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-m32/af/af5bf4ada48ff65b6658be1fab8f9c8f8ab5f319/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-m32/xfails/master/xfail;hb=0517b09>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-m32/xfails/master/xfail.table;hb=0517b09>

Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-3

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-extended-gdbserver-m32/builds/7606>

Commit(s) tested:
	af5bf4ada48ff65b6658be1fab8f9c8f8ab5f319

Author(s) (in the same order as the commits):
	Simon Marchi <simon.marchi@ericsson.com>

Subject:
	Replace psymbol_allocation_list with std::vector

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-extended-gdbserver-m32/af/af5bf4ada48ff65b6658be1fab8f9c8f8ab5f319/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-extended-gdbserver-m32/xfails/master/xfail;hb=e8fe831>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-extended-gdbserver-m32/xfails/master/xfail.table;hb=e8fe831>