[binutils-gdb] Plug source_command leak

[binutils-gdb] Plug source_command leak

[sergiodj+buildbot]

*** TEST RESULTS FOR COMMIT b0cba12e07cc17683b13c6275f58a6a829f96d06 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: b0cba12e07cc17683b13c6275f58a6a829f96d06

Plug source_command leak

The heap-allocated 'old_source_verbose' local was accidentally left
behind by commit 2ec845e75876 ("More uses of scoped_restore").

Valgrind caught it, like:

 ==20123== 8 bytes in 1 blocks are definitely lost in loss record 4,609 of 13,785
 ==20123==    at 0x4C2A988: calloc (vg_replace_malloc.c:711)
 ==20123==    by 0x60A2F8: xcalloc (common-utils.c:84)
 ==20123==    by 0x4CDBE5: build_command_line(command_control_type, char const*) (cli-script.c:159)
 ==20123==    by 0x4CDC32: get_command_line(command_control_type, char const*) (cli-script.c:172)
 ==20123==    by 0x5230F1: python_command(char*, int) (python.c:421)
 ==20123==    by 0x4C61AD: do_cfunc(cmd_list_element*, char*, int) (cli-decode.c:106)
 ==20123==    by 0x4C911F: cmd_func(cmd_list_element*, char*, int) (cli-decode.c:1902)
 ==20123==    by 0x7CA79E: execute_command(char*, int) (top.c:650)
 ==20123==    by 0x695A0C: command_handler(char*) (event-top.c:590)
 ==20123==    by 0x7CA33F: read_command_file(_IO_FILE*) (top.c:461)
 ==20123==    by 0x4D0C3A: script_from_file(_IO_FILE*, char const*) (cli-script.c:1584)
 ==20123==    by 0x4C2727: source_script_from_stream(_IO_FILE*, char const*, char const*) (cli-cmds.c:589)

gdb/ChangeLog:
2017-08-17  Pedro Alves  <palves@redhat.com>

	* cli/cli-cmds.c (source_command): Delete 'old_source_verbose'
	local.

Failures on Fedora-s390x-m64, branch master

[sergiodj+buildbot]

Buildslave:
	marist-fedora-s390x

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-s390x-m64/builds/5932>

Commit(s) tested:
	b0cba12e07cc17683b13c6275f58a6a829f96d06

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Plug source_command leak

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-s390x-m64/b0/b0cba12e07cc17683b13c6275f58a6a829f96d06/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.gdb/python-interrupts.exp: call catch_command_errors
PASS -> FAIL: gdb.gdb/python-interrupts.exp: signal SIGINT
PASS -> FAIL: gdb.gdb/selftest.exp: xgdb is at prompt
PASS -> FAIL: gdb.gdb/selftest.exp: Set xgdb_prompt
PASS -> FAIL: gdb.gdb/selftest.exp: backtrace through signal handler
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=6: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=7: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=14: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=16: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=17: wait for stops
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-s390x-m64/xfails/master/xfail;hb=474b075>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-s390x-m64/xfails/master/xfail.table;hb=474b075>

Failures on Fedora-x86_64-m32, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-3

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m32/builds/6835>

Commit(s) tested:
	b0cba12e07cc17683b13c6275f58a6a829f96d06

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Plug source_command leak

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-m32/b0/b0cba12e07cc17683b13c6275f58a6a829f96d06/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.ada/win_fu_syms.exp: compilation foo.adb
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-m32/xfails/master/xfail;hb=76a0059>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-m32/xfails/master/xfail.table;hb=76a0059>

Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master

[sergiodj+buildbot]

Buildslave:
	ubuntu-trusty-aarch32-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-native-gdbserver-m32/builds/1156>

Commit(s) tested:
	b0cba12e07cc17683b13c6275f58a6a829f96d06

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Plug source_command leak

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-native-gdbserver-m32/b0/b0cba12e07cc17683b13c6275f58a6a829f96d06/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.base/step-over-syscall.exp: clone: displaced=off: single step over clone
============================


*** Complete list of XFAILs for this builder ***

FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST.  PLEASE CONTACT THE BUILDBOT ADMIN.

Failures on Ubuntu-AArch64-native-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	ubuntu-aarch64-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch64-native-gdbserver-m64/builds/2533>

Commit(s) tested:
	b0cba12e07cc17683b13c6275f58a6a829f96d06

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Plug source_command leak

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Ubuntu-AArch64-native-gdbserver-m64/b0/b0cba12e07cc17683b13c6275f58a6a829f96d06/>

*** Diff to previous build ***
============================
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=1: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=14: wait for stops
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch64-native-gdbserver-m64/xfails/master/xfail;hb=84d1683>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch64-native-gdbserver-m64/xfails/master/xfail.table;hb=84d1683>

Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master

[sergiodj+buildbot]

Buildslave:
	ubuntu-trusty-aarch32-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-native-extended-gdbserver-m32/builds/1166>

Commit(s) tested:
	b0cba12e07cc17683b13c6275f58a6a829f96d06

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Plug source_command leak

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-native-extended-gdbserver-m32/b0/b0cba12e07cc17683b13c6275f58a6a829f96d06/>

*** Diff to previous build ***
============================
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=7: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=13: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=14: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=19: wait for stops
============================


*** Complete list of XFAILs for this builder ***

FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST.  PLEASE CONTACT THE BUILDBOT ADMIN.

Failures on Ubuntu-AArch32-m32, branch master

[sergiodj+buildbot]

Buildslave:
	ubuntu-trusty-aarch32-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-m32/builds/1166>

Commit(s) tested:
	b0cba12e07cc17683b13c6275f58a6a829f96d06

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Plug source_command leak

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-m32/b0/b0cba12e07cc17683b13c6275f58a6a829f96d06/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.mi/mi-var-rtti.exp: run to mi-var-rtti.cc:93
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=11: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=12: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=15: wait for stops
============================


*** Complete list of XFAILs for this builder ***

FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST.  PLEASE CONTACT THE BUILDBOT ADMIN.