[binutils-gdb] Revert "2020-04-29 Sterling Augustine <saugustine@google.com>"

[binutils-gdb] Revert "2020-04-29 Sterling Augustine <saugustine@google.com>"

[gdb-buildbot]

*** TEST RESULTS FOR COMMIT b2a0dd767a59a4b1e343c178177dcaee55e540f1 ***

commit b2a0dd767a59a4b1e343c178177dcaee55e540f1
Author:     Tom de Vries <tdevries@suse.de>
AuthorDate: Thu Apr 30 18:51:49 2020 +0200
Commit:     Tom de Vries <tdevries@suse.de>
CommitDate: Thu Apr 30 18:51:49 2020 +0200

    Revert "2020-04-29  Sterling Augustine <saugustine@google.com>"
    
    This reverts commit 84ed7a472551bce1ac58e0eced619433fabc956c.
    
    The problem that the commit attempts to address has already been fixed in
    commit 770479f223e "gdb: Fix toplevel types with -fdebug-types-section".
    
    The commit itself is superfluous because it sets list_in_scope at a point that
    it's already set (by start_symtab).

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index f78d829248..ede911f7ac 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -50,10 +50,6 @@
 	* gdbarch.sh: Use %s with printf, instead of variables in the
 	format string.
 
-2020-04-29  Sterling Augustine <saugustine@google.com>
-
-       * dwarf2/read.c (setup_type_unit_groups): Set list_in_scope.
-
 2020-04-29  Tom Tromey  <tromey@adacore.com>
 
 	PR ada/25875:
diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index 91a6803bf3..1813085d0d 100644
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -10942,7 +10942,6 @@ dwarf2_cu::setup_type_unit_groups (struct die_info *die)
 	= XOBNEWVEC (&COMPUNIT_OBJFILE (cust)->objfile_obstack,
 		     struct symtab *, line_header->file_names_size ());
 
-      list_in_scope = get_builder ()->get_file_symbols ();
       auto &file_names = line_header->file_names ();
       for (i = 0; i < file_names.size (); ++i)
 	{

Failures on Fedora-i686, branch master

[gdb-buildbot]

Buildername:
        Fedora-i686

Worker:
        fedora-x86-64-4

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/18/builds/3031

Author:
        Tom de Vries <tdevries@suse.de>

Commit tested:
        b2a0dd767a59a4b1e343c178177dcaee55e540f1

Subject of commit:
        Revert "2020-04-29  Sterling Augustine <saugustine@google.com>"

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-i686/b2/b2a0dd767a59a4b1e343c178177dcaee55e540f1/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/b2/b2a0dd767a59a4b1e343c178177dcaee55e540f1//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/b2/b2a0dd767a59a4b1e343c178177dcaee55e540f1//xfail.table.gz>

Failures on Fedora-x86_64-cc-with-index, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-cc-with-index

Worker:
        fedora-x86-64-3

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/20/builds/2980

Author:
        Tom de Vries <tdevries@suse.de>

Commit tested:
        b2a0dd767a59a4b1e343c178177dcaee55e540f1

Subject of commit:
        Revert "2020-04-29  Sterling Augustine <saugustine@google.com>"

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/b2/b2a0dd767a59a4b1e343c178177dcaee55e540f1/

*** Diff to previous build ***
==============================================
new KFAIL: gdb.base/step-over-syscall.exp: clone: displaced=on: single step over clone
PASS -> FAIL: gdb.cp/cpcompletion.exp: expression with namespace: cmd complete "p Test_NS:"
PASS -> FAIL: gdb.cp/cpcompletion.exp: expression with namespace: tab complete "p Test_NS::"
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 1st stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 1st stop: print j
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: single_scope: first thread: print i3
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/b2/b2a0dd767a59a4b1e343c178177dcaee55e540f1//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/b2/b2a0dd767a59a4b1e343c178177dcaee55e540f1//xfail.table.gz>

Failures on Fedora-x86_64-m32, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-m32

Worker:
        fedora-x86-64-4

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/17/builds/3026

Author:
        Tom de Vries <tdevries@suse.de>

Commit tested:
        b2a0dd767a59a4b1e343c178177dcaee55e540f1

Subject of commit:
        Revert "2020-04-29  Sterling Augustine <saugustine@google.com>"

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/b2/b2a0dd767a59a4b1e343c178177dcaee55e540f1/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.base/reread.exp: opts= "-fPIE" "ldflags=-pie" : second pass: run to foo
PASS -> FAIL: gdb.threads/fork-plus-threads.exp: detach-on-fork=off: only inferior 1 left
PASS -> FAIL: gdb.threads/gcore-stale-thread.exp: save a corefile
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/b2/b2a0dd767a59a4b1e343c178177dcaee55e540f1//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/b2/b2a0dd767a59a4b1e343c178177dcaee55e540f1//xfail.table.gz>

Failures on Fedora-x86_64-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-m64

Worker:
        fedora-x86-64-3

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/3/builds/3085

Author:
        Tom de Vries <tdevries@suse.de>

Commit tested:
        b2a0dd767a59a4b1e343c178177dcaee55e540f1

Subject of commit:
        Revert "2020-04-29  Sterling Augustine <saugustine@google.com>"

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/b2/b2a0dd767a59a4b1e343c178177dcaee55e540f1/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.multi/multi-arch-exec.exp: first_arch=1: selected_thread=1: follow_exec_mode=new: continue across exec that changes architecture
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: second thread: print i02
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: second thread: print i12
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: second thread: print i22
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 2nd thread: print k
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 2nd thread: print r
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 2nd thread: print z
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 2nd thread: print k
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 2nd thread: print r
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 2nd thread: print z
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/b2/b2a0dd767a59a4b1e343c178177dcaee55e540f1//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/b2/b2a0dd767a59a4b1e343c178177dcaee55e540f1//xfail.table.gz>

Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-extended-gdbserver-m32

Worker:
        fedora-x86-64-4

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/4/builds/2921

Author:
        Tom de Vries <tdevries@suse.de>

Commit tested:
        b2a0dd767a59a4b1e343c178177dcaee55e540f1

Subject of commit:
        Revert "2020-04-29  Sterling Augustine <saugustine@google.com>"

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/b2/b2a0dd767a59a4b1e343c178177dcaee55e540f1/

*** Diff to previous build ***
==============================================
PASS -> UNRESOLVED: gdb.threads/attach-into-signal.exp: threaded: attach
new FAIL: gdb.threads/attach-into-signal.exp: threaded: thread apply 2 print $_siginfo.si_signo
PASS -> FAIL: gdb.threads/interrupted-hand-call.exp: continue until exit
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/b2/b2a0dd767a59a4b1e343c178177dcaee55e540f1//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/b2/b2a0dd767a59a4b1e343c178177dcaee55e540f1//xfail.table.gz>

Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-extended-gdbserver-m64

Worker:
        fedora-x86-64-3

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/2/builds/2923

Author:
        Tom de Vries <tdevries@suse.de>

Commit tested:
        b2a0dd767a59a4b1e343c178177dcaee55e540f1

Subject of commit:
        Revert "2020-04-29  Sterling Augustine <saugustine@google.com>"

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/b2/b2a0dd767a59a4b1e343c178177dcaee55e540f1/

*** Diff to previous build ***
==============================================
FAIL -> UNRESOLVED: gdb.threads/fork-plus-threads.exp: detach-on-fork=off: inferior 1 exited
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 4th stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 4th stop: print j
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/b2/b2a0dd767a59a4b1e343c178177dcaee55e540f1//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/b2/b2a0dd767a59a4b1e343c178177dcaee55e540f1//xfail.table.gz>

Failures on Fedora-x86_64-native-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-gdbserver-m64

Worker:
        fedora-x86-64-3

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/22/builds/2933

Author:
        Tom de Vries <tdevries@suse.de>

Commit tested:
        b2a0dd767a59a4b1e343c178177dcaee55e540f1

Subject of commit:
        Revert "2020-04-29  Sterling Augustine <saugustine@google.com>"

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/b2/b2a0dd767a59a4b1e343c178177dcaee55e540f1/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.threads/interrupted-hand-call.exp: continue until exit
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/b2/b2a0dd767a59a4b1e343c178177dcaee55e540f1//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/b2/b2a0dd767a59a4b1e343c178177dcaee55e540f1//xfail.table.gz>