[binutils-gdb] Fix test_gdb_complete_tab_multiple race

[binutils-gdb] Fix test_gdb_complete_tab_multiple race

[gdb-buildbot]

*** TEST RESULTS FOR COMMIT b2b2a2159876fa8db57ce017b949cafc6f1a32df ***

commit b2b2a2159876fa8db57ce017b949cafc6f1a32df
Author:     Pedro Alves <palves@redhat.com>
AuthorDate: Wed Jul 3 16:57:48 2019 +0100
Commit:     Pedro Alves <palves@redhat.com>
CommitDate: Wed Jul 3 16:57:48 2019 +0100

    Fix test_gdb_complete_tab_multiple race
    
    Running 'make check-read1 TESTS="gdb.base/options.exp"' revealed a
    race in test_gdb_complete_tab_multiple.  There's a gdb_test_multiple
    call that expects a prompt in the middle of the regexp.  That's racy
    because gdb_test_multiple includes a built-in FAIL pattern for the
    prompt, which may match if gdb is slow enough to produce the rest of
    the output after the prompt.
    
    Fix this in the usual way of splitting the matching in two.
    
    gdb/testsuite/ChangeLog:
    2019-07-03  Pedro Alves  <palves@redhat.com>
    
            * lib/completion-support.exp (test_gdb_complete_tab_multiple):
            Split one gdb_test_multiple call in two to avoid a race.

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 9b988dcfcc..6e2234984d 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,5 +1,10 @@
 2019-07-03  Pedro Alves  <palves@redhat.com>
 
+	* lib/completion-support.exp (test_gdb_complete_tab_multiple):
+	Split one gdb_test_multiple call in two to avoid a race.
+
+2019-07-03  Pedro Alves  <palves@redhat.com>
+
 	* gdb.base/with.c: New file.
 	* gdb.base/with.exp: New file.
 
diff --git a/gdb/testsuite/lib/completion-support.exp b/gdb/testsuite/lib/completion-support.exp
index 97fed18b05..3199e85fd4 100644
--- a/gdb/testsuite/lib/completion-support.exp
+++ b/gdb/testsuite/lib/completion-support.exp
@@ -151,8 +151,12 @@ proc test_gdb_complete_tab_multiple { input_line add_completed_line \
 		set maybe_bell ""
 	    }
 	    gdb_test_multiple "" "$test (second tab)" {
-		-re "^${maybe_bell}\r\n$expected_re\r\n$gdb_prompt $input_line_re$add_completed_line_re$" {
-		    pass "$test"
+		-re "^${maybe_bell}\r\n$expected_re\r\n$gdb_prompt " {
+		    gdb_test_multiple "" "$test (second tab)" {
+			-re "^$input_line_re$add_completed_line_re$" {
+			    pass "$test"
+			}
+		    }
 		}
 	    }
 	}

Failures on Fedora-i686, branch master

[gdb-buildbot]

Buildername:
        Fedora-i686

Worker:
        fedora-x86-64-3

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/18/builds/154

Author:
        Pedro Alves <palves@redhat.com>

Commit tested:
        b2b2a2159876fa8db57ce017b949cafc6f1a32df

Subject of commit:
        Fix test_gdb_complete_tab_multiple race

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-i686/b2/b2b2a2159876fa8db57ce017b949cafc6f1a32df/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/b2/b2b2a2159876fa8db57ce017b949cafc6f1a32df//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/b2/b2b2a2159876fa8db57ce017b949cafc6f1a32df//xfail.table.gz>

Failures on Fedora-x86_64-cc-with-index, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-cc-with-index

Worker:
        fedora-x86-64-2

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/20/builds/153

Author:
        Pedro Alves <palves@redhat.com>

Commit tested:
        b2b2a2159876fa8db57ce017b949cafc6f1a32df

Subject of commit:
        Fix test_gdb_complete_tab_multiple race

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/b2/b2b2a2159876fa8db57ce017b949cafc6f1a32df/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/b2/b2b2a2159876fa8db57ce017b949cafc6f1a32df//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/b2/b2b2a2159876fa8db57ce017b949cafc6f1a32df//xfail.table.gz>

Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-extended-gdbserver-m32

Worker:
        fedora-x86-64-3

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/4/builds/152

Author:
        Pedro Alves <palves@redhat.com>

Commit tested:
        b2b2a2159876fa8db57ce017b949cafc6f1a32df

Subject of commit:
        Fix test_gdb_complete_tab_multiple race

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/b2/b2b2a2159876fa8db57ce017b949cafc6f1a32df/

*** Diff to previous build ***
==============================================
UNRESOLVED -> FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=main: force-fail=1: run failure detected
UNRESOLVED -> FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=separate: force-fail=1: run failure detected
UNRESOLVED -> FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=main: force-fail=1: run failure detected
UNRESOLVED -> FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=separate: force-fail=1: run failure detected
PASS -> UNRESOLVED: gdb.threads/attach-into-signal.exp: threaded: attach
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/b2/b2b2a2159876fa8db57ce017b949cafc6f1a32df//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/b2/b2b2a2159876fa8db57ce017b949cafc6f1a32df//xfail.table.gz>

Failures on Fedora-x86_64-native-gdbserver-m32, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-gdbserver-m32

Worker:
        fedora-x86-64-1

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/24/builds/152

Author:
        Pedro Alves <palves@redhat.com>

Commit tested:
        b2b2a2159876fa8db57ce017b949cafc6f1a32df

Subject of commit:
        Fix test_gdb_complete_tab_multiple race

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/b2/b2b2a2159876fa8db57ce017b949cafc6f1a32df/

*** Diff to previous build ***
==============================================
new FAIL: gdb.base/corefile.exp: core-file warning-free
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/b2/b2b2a2159876fa8db57ce017b949cafc6f1a32df//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/b2/b2b2a2159876fa8db57ce017b949cafc6f1a32df//xfail.table.gz>

Failures on Fedora-x86_64-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-m64

Worker:
        fedora-x86-64-2

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/3/builds/170

Author:
        Pedro Alves <palves@redhat.com>

Commit tested:
        b2b2a2159876fa8db57ce017b949cafc6f1a32df

Subject of commit:
        Fix test_gdb_complete_tab_multiple race

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/b2/b2b2a2159876fa8db57ce017b949cafc6f1a32df/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/b2/b2b2a2159876fa8db57ce017b949cafc6f1a32df//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/b2/b2b2a2159876fa8db57ce017b949cafc6f1a32df//xfail.table.gz>