public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: gdb-buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] ubsan: alpha-vma: timeout
Date: Mon, 13 Jan 2020 06:19:00 -0000	[thread overview]
Message-ID: <b50ef514ff0c8d5506227c412c508f9f538bcf5a@gdb-build> (raw)

*** TEST RESULTS FOR COMMIT b50ef514ff0c8d5506227c412c508f9f538bcf5a ***

commit b50ef514ff0c8d5506227c412c508f9f538bcf5a
Author:     Alan Modra <amodra@gmail.com>
AuthorDate: Mon Jan 13 10:10:41 2020 +1030
Commit:     Alan Modra <amodra@gmail.com>
CommitDate: Mon Jan 13 12:12:05 2020 +1030

    ubsan: alpha-vma: timeout
    
            * vms-alpha.c (_bfd_vms_slurp_egsd): Ensure minimum size even
            for "ignored" records.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 70944d3c80..84caf0b04a 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2020-01-13  Alan Modra  <amodra@gmail.com>
+
+	* vms-alpha.c (_bfd_vms_slurp_egsd): Ensure minimum size even
+	for "ignored" records.
+
 2020-01-13  Alan Modra  <amodra@gmail.com>
 
 	* wasm-module.c (wasm_scan_name_function_section): Formatting.
diff --git a/bfd/vms-alpha.c b/bfd/vms-alpha.c
index 73e7285384..32f4e68bbb 100644
--- a/bfd/vms-alpha.c
+++ b/bfd/vms-alpha.c
@@ -1217,6 +1217,16 @@ _bfd_vms_slurp_egsd (bfd *abfd)
 	  return FALSE;
 	}
 
+      if (gsd_size < 4)
+	{
+	too_small:
+	  _bfd_error_handler (_("corrupt EGSD record type %d: size (%#x) "
+				"is too small"),
+			      gsd_type, gsd_size);
+	  bfd_set_error (bfd_error_bad_value);
+	  return FALSE;
+	}
+
       switch (gsd_type)
 	{
 	case EGSD__C_PSC:
@@ -1227,14 +1237,7 @@ _bfd_vms_slurp_egsd (bfd *abfd)
 	    asection *section;
 
 	    if (offsetof (struct vms_egps, flags) + 2 > gsd_size)
-	      {
-	      too_small:
-		_bfd_error_handler (_("corrupt EGSD record type %d: size (%#x) "
-				      "is too small"),
-				    gsd_type, gsd_size);
-		bfd_set_error (bfd_error_bad_value);
-		return FALSE;
-	      }
+	      goto too_small;
 	    vms_flags = bfd_getl16 (egps->flags);
 
 	    if ((vms_flags & EGPS__V_REL) == 0)


             reply	other threads:[~2020-01-13  5:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-13  6:19 gdb-buildbot [this message]
2020-01-13  6:38 ` Failures on Ubuntu-Aarch64-native-gdbserver-m64, branch master gdb-buildbot
2020-01-14 23:06 ` Failures on Fedora-i686, " gdb-buildbot
2020-01-14 23:52 ` Failures on Fedora-x86_64-m32, " gdb-buildbot
2020-01-14 23:52 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot
2020-01-14 23:52 ` Failures on Fedora-x86_64-m64, " gdb-buildbot
2020-01-15  0:16 ` Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot
2020-01-15  0:38 ` Failures on Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot
2020-01-15  0:38 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b50ef514ff0c8d5506227c412c508f9f538bcf5a@gdb-build \
    --to=gdb-buildbot@sergiodj.net \
    --cc=gdb-testers@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).