public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Remove dict_empty/mdict_empty
@ 2019-11-27  0:04 gdb-buildbot
  2019-11-27  0:04 ` Failures on Ubuntu-Aarch64-native-gdbserver-m64, branch master gdb-buildbot
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: gdb-buildbot @ 2019-11-27  0:04 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT b62f6f5435efa0bedf5a363ee09552285b1f1372 ***

commit b62f6f5435efa0bedf5a363ee09552285b1f1372
Author:     Simon Marchi <simon.marchi@efficios.com>
AuthorDate: Tue Nov 26 12:12:01 2019 -0500
Commit:     Simon Marchi <simon.marchi@efficios.com>
CommitDate: Tue Nov 26 14:29:20 2019 -0500

    Remove dict_empty/mdict_empty
    
    These functions are not used in the code base, remove them.
    
    gdb/ChangeLog:
    
            * dictionary.c (dict_empty, mdict_empty): Remove.
            * dictionary.c (mdict_empty): Remove.
    
    Change-Id: I4c1b08c730f6790b2f3d28b680607618e3c08e48

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 7288efa37c..b2068a91c7 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
+
+	* dictionary.c (dict_empty, mdict_empty): Remove.
+	* dictionary.c (mdict_empty): Remove.
+
 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 
 	 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
diff --git a/gdb/dictionary.c b/gdb/dictionary.c
index 939f32b59a..0d13370b72 100644
--- a/gdb/dictionary.c
+++ b/gdb/dictionary.c
@@ -508,16 +508,6 @@ dict_size (const struct dictionary *dict)
    implemented generically by means of the vtable.  Typically, they're
    rarely used.  */
 
-/* Test to see if DICT is empty.  */
-
-static int
-dict_empty (struct dictionary *dict)
-{
-  struct dict_iterator iter;
-
-  return (dict_iterator_first (dict, &iter) == NULL);
-}
-
 
 /* The functions implementing the dictionary interface.  */
 
@@ -1283,17 +1273,3 @@ mdict_size (const struct multidictionary *mdict)
 
   return size;
 }
-
-/* See dictionary.h.  */
-
-bool
-mdict_empty (const struct multidictionary *mdict)
-{
-  for (unsigned short idx = 0; idx < mdict->n_allocated_dictionaries; ++idx)
-    {
-      if (!dict_empty (mdict->dictionaries[idx]))
-	return false;
-    }
-
-  return true;
-}
diff --git a/gdb/dictionary.h b/gdb/dictionary.h
index e6481cd38c..9a7739b7c1 100644
--- a/gdb/dictionary.h
+++ b/gdb/dictionary.h
@@ -93,10 +93,6 @@ extern void mdict_add_symbol (struct multidictionary *mdict,
 extern void mdict_add_pending (struct multidictionary *mdict,
 			       const struct pending *symbol_list);
 
-/* Is the multidictionary empty?  */
-
-extern int mdict_empty (struct multidictionary *mdict);
-
 /* A type containing data that is used when iterating over all symbols
    in a dictionary.  Don't ever look at its innards; this type would
    be opaque if we didn't need to be able to allocate it on the


^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-11-29  9:17 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-27  0:04 [binutils-gdb] Remove dict_empty/mdict_empty gdb-buildbot
2019-11-27  0:04 ` Failures on Ubuntu-Aarch64-native-gdbserver-m64, branch master gdb-buildbot
2019-11-29  8:37 ` Failures on Fedora-x86_64-m32, " gdb-buildbot
2019-11-29  8:38 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot
2019-11-29  9:13 ` Failures on Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot
2019-11-29  9:17 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).