From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31961 invoked by alias); 12 Jan 2020 17:12:47 -0000 Mailing-List: contact gdb-testers-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-testers-owner@sourceware.org Received: (qmail 31951 invoked by uid 89); 12 Jan 2020 17:12:46 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-15.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: kwanyin.sergiodj.net Received: from kwanyin.sergiodj.net (HELO kwanyin.sergiodj.net) (158.69.185.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 12 Jan 2020 17:12:45 +0000 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [binutils-gdb] gdbserver: make aarch64_write_goto_address static From: gdb-buildbot@sergiodj.net To: gdb-testers@sourceware.org Message-Id: Date: Sun, 12 Jan 2020 17:27:00 -0000 X-SW-Source: 2020-q1/txt/msg01091.txt *** TEST RESULTS FOR COMMIT bb1183e25ae74ba21500fb4e39bc1ca9822e3086 *** commit bb1183e25ae74ba21500fb4e39bc1ca9822e3086 Author: Simon Marchi AuthorDate: Sun Jan 12 11:06:23 2020 -0500 Commit: Simon Marchi CommitDate: Sun Jan 12 11:06:44 2020 -0500 gdbserver: make aarch64_write_goto_address static This function is only used in this file, so make it static. It fixes this error, when building with -Wmissing-declarations: CXX linux-aarch64-low.o /home/simark/src/binutils-gdb/gdb/gdbserver/linux-aarch64-low.c:2642:1: error: no previous declaration for 'void aarch64_write_goto_address(CORE_ADDR, CORE_ADDR, int)' [-Werror=missing-declarations] aarch64_write_goto_address (CORE_ADDR from, CORE_ADDR to, int size) ^~~~~~~~~~~~~~~~~~~~~~~~~~ gdb/gdbserver/ChangeLog: * linux-aarch64-low.c (aarch64_write_goto_address): Make static. diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index 40a765a3ed..83be63c393 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,3 +1,7 @@ +2020-01-12 Simon Marchi + + * linux-aarch64-low.c (aarch64_write_goto_address): Make static. + 2020-01-12 Simon Marchi * linux-aarch32-tdesc.c: Include linux-aarch32-tdesc.h. diff --git a/gdb/gdbserver/linux-aarch64-low.c b/gdb/gdbserver/linux-aarch64-low.c index c58347d80c..961fd5b3cc 100644 --- a/gdb/gdbserver/linux-aarch64-low.c +++ b/gdb/gdbserver/linux-aarch64-low.c @@ -2638,7 +2638,7 @@ aarch64_emit_goto (int *offset_p, int *size_p) /* Implementation of emit_ops method "write_goto_address". */ -void +static void aarch64_write_goto_address (CORE_ADDR from, CORE_ADDR to, int size) { uint32_t insn;