public inbox for gdb-testers@sourceware.org help / color / mirror / Atom feed
From: gdb-buildbot@sergiodj.net To: gdb-testers@sourceware.org Subject: [binutils-gdb] ARC: Use of uninitialised value Date: Mon, 06 Apr 2020 09:12:50 -0400 [thread overview] Message-ID: <beea5cc1bc2249389dc77ea0c86ab82dafd05bb5@gdb-build> (raw) *** TEST RESULTS FOR COMMIT beea5cc1bc2249389dc77ea0c86ab82dafd05bb5 *** commit beea5cc1bc2249389dc77ea0c86ab82dafd05bb5 Author: Alan Modra <amodra@gmail.com> AuthorDate: Sun Mar 22 20:02:55 2020 +1030 Commit: Alan Modra <amodra@gmail.com> CommitDate: Sun Mar 22 23:22:13 2020 +1030 ARC: Use of uninitialised value * arc-dis.c (find_format): Use ISO C string concatenation rather than line continuation within a string. Don't access needs_limm before testing opcode != NULL. diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog index 06b81d7b54..eb3e4c32f2 100644 --- a/opcodes/ChangeLog +++ b/opcodes/ChangeLog @@ -1,3 +1,9 @@ +2020-03-22 Alan Modra <amodra@gmail.com> + + * arc-dis.c (find_format): Use ISO C string concatenation rather + than line continuation within a string. Don't access needs_limm + before testing opcode != NULL. + 2020-03-22 Alan Modra <amodra@gmail.com> * ns32k-dis.c (print_insn_arg): Update comment. diff --git a/opcodes/arc-dis.c b/opcodes/arc-dis.c index 9662c2fc53..131aee6b34 100644 --- a/opcodes/arc-dis.c +++ b/opcodes/arc-dis.c @@ -436,8 +436,9 @@ find_format (bfd_vma memaddr, opcode = arcExtMap_genOpcode (i, isa_mask, &errmsg); if (opcode == NULL) { - (*info->fprintf_func) (info->stream, "\ -An error occured while generating the extension instruction operations"); + (*info->fprintf_func) (info->stream, + _("An error occured while generating the " + "extension instruction operations")); *opcode_result = NULL; return FALSE; } @@ -452,7 +453,7 @@ An error occured while generating the extension instruction operations"); opcode = find_format_from_table (info, arc_opcodes, insn, *insn_len, isa_mask, &needs_limm, TRUE); - if (needs_limm && opcode != NULL) + if (opcode != NULL && needs_limm) { bfd_byte buffer[4]; int status;
next reply other threads:[~2020-04-06 13:12 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-06 13:12 gdb-buildbot [this message] 2020-04-06 13:12 ` Failures on Fedora-i686, branch master gdb-buildbot 2020-04-06 13:47 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot 2020-04-06 14:04 ` Failures on Fedora-x86_64-m32, " gdb-buildbot 2020-04-06 14:18 ` Failures on Fedora-x86_64-m64, " gdb-buildbot 2020-04-06 14:59 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot 2020-04-06 14:59 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot 2020-04-10 4:27 ` Failures on Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot 2020-04-10 22:47 ` Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot 2020-04-11 21:49 ` Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, " gdb-buildbot 2020-04-11 23:38 ` Failures on Ubuntu-Aarch64-native-gdbserver-m64, " gdb-buildbot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=beea5cc1bc2249389dc77ea0c86ab82dafd05bb5@gdb-build \ --to=gdb-buildbot@sergiodj.net \ --cc=gdb-testers@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).