public inbox for gdb-testers@sourceware.org help / color / mirror / Atom feed
From: gdb-buildbot@sergiodj.net To: gdb-testers@sourceware.org Subject: [binutils-gdb] gdbserver: turn target op 'supports_agent' into a method Date: Tue, 03 Mar 2020 03:18:00 -0000 [thread overview] Message-ID: <c0245cb999ec9692db1947240e865988a0c19c82@gdb-build> (raw) *** TEST RESULTS FOR COMMIT c0245cb999ec9692db1947240e865988a0c19c82 *** commit c0245cb999ec9692db1947240e865988a0c19c82 Author: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com> AuthorDate: Mon Feb 17 16:12:01 2020 +0100 Commit: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com> CommitDate: Thu Feb 20 17:35:16 2020 +0100 gdbserver: turn target op 'supports_agent' into a method gdbserver/ChangeLog: 2020-02-20 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com> Turn process_stratum_target's supports_agent op into a method of process_target. * target.h (struct process_stratum_target): Remove the target op. (class process_target): Add the target op. (target_supports_agent): Update the macro. * target.cc (process_target::supports_agent): Define. Update the derived classes and callers below. * linux-low.cc (linux_target_ops): Update. (linux_supports_agent): Turn into ... (linux_process_target::supports_agent): ... this. * linux-low.h (class linux_process_target): Update. * lynx-low.cc (lynx_target_ops): Update. * nto-low.cc (nto_target_ops): Update. * win32-low.cc (win32_target_ops): Update. diff --git a/gdbserver/ChangeLog b/gdbserver/ChangeLog index 3ee9556d88..4b91c893fb 100644 --- a/gdbserver/ChangeLog +++ b/gdbserver/ChangeLog @@ -1,3 +1,23 @@ +2020-02-20 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com> + + Turn process_stratum_target's supports_agent op into a method of + process_target. + + * target.h (struct process_stratum_target): Remove the target op. + (class process_target): Add the target op. + (target_supports_agent): Update the macro. + * target.cc (process_target::supports_agent): Define. + + Update the derived classes and callers below. + + * linux-low.cc (linux_target_ops): Update. + (linux_supports_agent): Turn into ... + (linux_process_target::supports_agent): ... this. + * linux-low.h (class linux_process_target): Update. + * lynx-low.cc (lynx_target_ops): Update. + * nto-low.cc (nto_target_ops): Update. + * win32-low.cc (win32_target_ops): Update. + 2020-02-20 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com> Turn process_stratum_target's qxfer_libraries_svr4 op into a diff --git a/gdbserver/linux-low.cc b/gdbserver/linux-low.cc index 4e5e8aea14..df4c98d257 100644 --- a/gdbserver/linux-low.cc +++ b/gdbserver/linux-low.cc @@ -6424,10 +6424,10 @@ linux_process_target::supports_disable_randomization () #endif } -static int -linux_supports_agent (void) +bool +linux_process_target::supports_agent () { - return 1; + return true; } static int @@ -7463,7 +7463,6 @@ linux_get_hwcap2 (int wordsize) static linux_process_target the_linux_target; static process_stratum_target linux_target_ops = { - linux_supports_agent, #ifdef HAVE_LINUX_BTRACE linux_enable_btrace, linux_low_disable_btrace, diff --git a/gdbserver/linux-low.h b/gdbserver/linux-low.h index 463e4e9b70..0f0f3e0b86 100644 --- a/gdbserver/linux-low.h +++ b/gdbserver/linux-low.h @@ -431,6 +431,8 @@ public: unsigned char *readbuf, unsigned const char *writebuf, CORE_ADDR offset, int len) override; + + bool supports_agent () override; }; #define get_thread_lwp(thr) ((struct lwp_info *) (thread_target_data (thr))) diff --git a/gdbserver/lynx-low.cc b/gdbserver/lynx-low.cc index 74e7de526f..031166ed12 100644 --- a/gdbserver/lynx-low.cc +++ b/gdbserver/lynx-low.cc @@ -735,7 +735,6 @@ static lynx_process_target the_lynx_target; /* The LynxOS target_ops vector. */ static process_stratum_target lynx_target_ops = { - NULL, /* support_agent */ NULL, /* enable_btrace */ NULL, /* disable_btrace */ NULL, /* read_btrace */ diff --git a/gdbserver/nto-low.cc b/gdbserver/nto-low.cc index 037a053183..27fe3ca413 100644 --- a/gdbserver/nto-low.cc +++ b/gdbserver/nto-low.cc @@ -947,7 +947,6 @@ nto_sw_breakpoint_from_kind (int kind, int *size) static nto_process_target the_nto_target; static process_stratum_target nto_target_ops = { - NULL, /* support_agent */ NULL, /* enable_btrace */ NULL, /* disable_btrace */ NULL, /* read_btrace */ diff --git a/gdbserver/target.cc b/gdbserver/target.cc index fa04bd011b..2bbd8b4d7a 100644 --- a/gdbserver/target.cc +++ b/gdbserver/target.cc @@ -720,3 +720,9 @@ process_target::qxfer_libraries_svr4 (const char *annex, { gdb_assert_not_reached ("target op qxfer_libraries_svr4 not supported"); } + +bool +process_target::supports_agent () +{ + return false; +} diff --git a/gdbserver/target.h b/gdbserver/target.h index fe0a7df579..8a1c12260f 100644 --- a/gdbserver/target.h +++ b/gdbserver/target.h @@ -70,9 +70,6 @@ class process_target; shared code. */ struct process_stratum_target { - /* Return true if target supports debugging agent. */ - int (*supports_agent) (void); - /* Enable branch tracing for PTID based on CONF and allocate a branch trace target information struct for reading and for disabling branch trace. */ struct btrace_target_info *(*enable_btrace) @@ -497,6 +494,9 @@ public: unsigned char *readbuf, unsigned const char *writebuf, CORE_ADDR offset, int len); + + /* Return true if target supports debugging agent. */ + virtual bool supports_agent (); }; extern process_stratum_target *the_target; @@ -607,8 +607,7 @@ int kill_inferior (process_info *proc); the_target->pt->supports_disable_randomization () #define target_supports_agent() \ - (the_target->supports_agent ? \ - (*the_target->supports_agent) () : 0) + the_target->pt->supports_agent () static inline struct btrace_target_info * target_enable_btrace (ptid_t ptid, const struct btrace_config *conf) diff --git a/gdbserver/win32-low.cc b/gdbserver/win32-low.cc index 54d7fde89b..84b6ea3e28 100644 --- a/gdbserver/win32-low.cc +++ b/gdbserver/win32-low.cc @@ -1858,7 +1858,6 @@ win32_sw_breakpoint_from_kind (int kind, int *size) static win32_process_target the_win32_target; static process_stratum_target win32_target_ops = { - NULL, /* support_agent */ NULL, /* enable_btrace */ NULL, /* disable_btrace */ NULL, /* read_btrace */
next reply other threads:[~2020-03-03 2:44 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-03 3:18 gdb-buildbot [this message] 2020-03-03 3:10 ` Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, branch master gdb-buildbot 2020-03-03 13:18 ` Failures on Fedora-i686, " gdb-buildbot 2020-03-03 13:59 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot 2020-03-03 14:01 ` Failures on Fedora-x86_64-m64, " gdb-buildbot 2020-03-03 14:27 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot 2020-03-03 14:57 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot 2020-03-04 6:41 ` Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot 2020-03-05 18:05 ` Failures on Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c0245cb999ec9692db1947240e865988a0c19c82@gdb-build \ --to=gdb-buildbot@sergiodj.net \ --cc=gdb-testers@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).